GNU bug report logs - #79778
[PATCH] 31.0.50; dolist test coverage should be improved

Previous Next

To reply to this bug, email your comments to 79778 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Neal Sidhwaney <nealsid <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] 31.0.50; dolist test coverage should be improved
Date: Thu, 6 Nov 2025 14:35:32 -0500

[Message part 1 (text/plain, inline)]

The dolist macro test coverage (in test/lisp/subr-tests.el) is low and
should be improved.  Attached is a patch which adds a few test cases.

[Message part 2 (text/html, inline)]

[0001-Add-test-cases-for-dolist.patch (application/octet-stream, attachment)]

Message #8 received at 79778 <at> debbugs.gnu.org (full text, mbox):

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: Neal Sidhwaney <nealsid <at> gmail.com>
Cc: 79778 <at> debbugs.gnu.org
Subject: Re: bug#79778: [PATCH] 31.0.50; dolist test coverage should be
 improved
Date: Fri, 07 Nov 2025 15:08:40 +0000

Hello,

On Thu 06 Nov 2025 at 02:35pm -05, Neal Sidhwaney wrote:

> The dolist macro test coverage (in test/lisp/subr-tests.el) is low and should be
> improved.  Attached is a patch which adds a few test cases.

Thanks.  More test coverage is always appreciated.

For a contribution of this size however we will need you to do the
copyright paperwork.  Is that something you are willing to do?

-- 
Sean Whitton

Message #11 received at 79778 <at> debbugs.gnu.org (full text, mbox):

From: Neal Sidhwaney <nealsid <at> gmail.com>
To: Sean Whitton <spwhitton <at> spwhitton.name>
Cc: 79778 <at> debbugs.gnu.org
Subject: Re: bug#79778: [PATCH] 31.0.50;
 dolist test coverage should be improved
Date: Fri, 7 Nov 2025 10:20:06 -0500

[Message part 1 (text/plain, inline)]

Hi Sean,

I'd be happy to assign copyright to the FSF.  In fact, I've already sent
the form in, but it was just yesterday that I did that, so I'd imagine it
might take a little longer to complete the process.

Thanks,

Neal


On Fri, Nov 7, 2025 at 10:08 AM Sean Whitton <spwhitton <at> spwhitton.name>
wrote:

> Hello,
>
> On Thu 06 Nov 2025 at 02:35pm -05, Neal Sidhwaney wrote:
>
> > The dolist macro test coverage (in test/lisp/subr-tests.el) is low and
> should be
> > improved.  Attached is a patch which adds a few test cases.
>
> Thanks.  More test coverage is always appreciated.
>
> For a contribution of this size however we will need you to do the
> copyright paperwork.  Is that something you are willing to do?
>
> --
> Sean Whitton
>

[Message part 2 (text/html, inline)]

Message #14 received at 79778 <at> debbugs.gnu.org (full text, mbox):

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: Neal Sidhwaney <nealsid <at> gmail.com>
Cc: 79778 <at> debbugs.gnu.org
Subject: Re: bug#79778: [PATCH] 31.0.50; dolist test coverage should be
 improved
Date: Fri, 07 Nov 2025 15:34:32 +0000

Hello,

On Fri 07 Nov 2025 at 10:20am -05, Neal Sidhwaney wrote:

> Hi Sean,
>
> I'd be happy to assign copyright to the FSF.  In fact, I've already sent the form in,
> but it was just yesterday that I did that, so I'd imagine it might take a little longer
> to complete the process.

Cool -- please ping this bug when it's done so we can look into
installing the patch.  Thanks again.

-- 
Sean Whitton

Message #17 received at 79778 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Neal Sidhwaney <nealsid <at> gmail.com>
Cc: 79778 <at> debbugs.gnu.org
Subject: Re: bug#79778: [PATCH] 31.0.50;
 dolist test coverage should be improved
Date: Sat, 08 Nov 2025 12:19:39 +0200

> From: Neal Sidhwaney <nealsid <at> gmail.com>
> Date: Thu, 6 Nov 2025 14:35:32 -0500
> 
> The dolist macro test coverage (in test/lisp/subr-tests.el) is low and should be improved.  Attached is a patch
> which adds a few test cases.

Thanks.  Additions to the test suite are always welcome, but we cannot
accept such a large contribution without your assigning the copyright
to the FSF.  If you agree, I will send you the form to fill and the
instructions to go with it.

Message #20 received at 79778 <at> debbugs.gnu.org (full text, mbox):

From: Neal Sidhwaney <nealsid <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 79778 <at> debbugs.gnu.org
Subject: Re: bug#79778: [PATCH] 31.0.50;
 dolist test coverage should be improved
Date: Sat, 8 Nov 2025 10:07:35 -0500

[Message part 1 (text/plain, inline)]

On Sat, Nov 8, 2025 at 5:19 AM Eli Zaretskii <eliz <at> gnu.org> wrote:

>
> Thanks.  Additions to the test suite are always welcome, but we cannot
> accept such a large contribution without your assigning the copyright
> to the FSF.  If you agree, I will send you the form to fill and the
> instructions to go with it.
>

Absolutely! I've actually already sent the form in, and am waiting to hear
back.  Thanks.

Neal

[Message part 2 (text/html, inline)]

Message #23 received at 79778 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Neal Sidhwaney <nealsid <at> gmail.com>
Cc: 79778 <at> debbugs.gnu.org
Subject: Re: bug#79778: [PATCH] 31.0.50;
 dolist test coverage should be improved
Date: Sat, 08 Nov 2025 17:59:24 +0200

> From: Neal Sidhwaney <nealsid <at> gmail.com>
> Date: Sat, 8 Nov 2025 10:07:35 -0500
> Cc: 79778 <at> debbugs.gnu.org
> 
> On Sat, Nov 8, 2025 at 5:19 AM Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>  Thanks.  Additions to the test suite are always welcome, but we cannot
>  accept such a large contribution without your assigning the copyright
>  to the FSF.  If you agree, I will send you the form to fill and the
>  instructions to go with it.
> 
> Absolutely! I've actually already sent the form in, and am waiting to hear back.  Thanks.

Great, thanks.  So we are basically waiting for the legal paperwork to
run to completion, and will install the additions when that happens.

Message #28 received at 79778-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: nealsid <at> gmail.com
Cc: 79778-done <at> debbugs.gnu.org
Subject: Re: bug#79778: [PATCH] 31.0.50;
 dolist test coverage should be improved
Date: Thu, 27 Nov 2025 11:05:00 +0200

> Cc: 79778 <at> debbugs.gnu.org
> Date: Sat, 08 Nov 2025 17:59:24 +0200
> From: Eli Zaretskii <eliz <at> gnu.org>
> 
> > From: Neal Sidhwaney <nealsid <at> gmail.com>
> > Date: Sat, 8 Nov 2025 10:07:35 -0500
> > Cc: 79778 <at> debbugs.gnu.org
> > 
> > On Sat, Nov 8, 2025 at 5:19 AM Eli Zaretskii <eliz <at> gnu.org> wrote:
> > 
> >  Thanks.  Additions to the test suite are always welcome, but we cannot
> >  accept such a large contribution without your assigning the copyright
> >  to the FSF.  If you agree, I will send you the form to fill and the
> >  instructions to go with it.
> > 
> > Absolutely! I've actually already sent the form in, and am waiting to hear back.  Thanks.
> 
> Great, thanks.  So we are basically waiting for the legal paperwork to
> run to completion, and will install the additions when that happens.

With the copyright-assignment paperwork completed, I've now installed
your changes on the master branch, and I'm therefore closing this bug.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.