GNU bug report logs - #79785
31.0.50; [PATCH] Make Flymake fringe indicators use dedicated faces

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: Protesilaos Stavrou <prot@HIDDEN>; Keywords: patch; Done: Eli Zaretskii <eliz@HIDDEN>; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 79785-done <at> debbugs.gnu.org:

Received: (at 79785-done) by debbugs.gnu.org; 25 Nov 2025 20:31:40 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 25 15:31:39 2025
Received: from localhost ([127.0.0.1]:42299 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1vNzhI-0004eI-8Y
	for submit <at> debbugs.gnu.org; Tue, 25 Nov 2025 15:31:39 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:54510)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1vMlOA-00085Y-BM
 for 79785-done <at> debbugs.gnu.org; Sat, 22 Nov 2025 06:02:47 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1vMlNs-0006Km-Ai; Sat, 22 Nov 2025 06:02:28 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=3UlIj/C7wCwBbGHz2b9hcTe3pt8zqwTed+Iyq9D+Lr0=; b=X6rueD7mmTKw
 LB2DivG2cc40DAUowvT1Tb4a6AdXjWXymMJZMqcsktItXVH5lY1bxnhH2GaCiUZzzJn3d7h1qoX38
 DoYfFoYcbZ+C4Epnj1CV9KZXwlADq+zDUDUSrGM5iGBj4jWiiFR8lz30KV6Jlw3ZijyuMmkJDAc2V
 7VYGfqsgW8PpB+iLBGPzOWpLq058dvNzs01MX/Gwc8chcB4x1L7Ua4Utxp/VHimuwYBl3GdPvF6jd
 WoR8I1IljsqjH2sDzrVPMQehQxcC60ZO1OstsYAzfy9bx8nEp3ytRFUND3BnbsdQqoLUizPC8eEFl
 mTHjANiNTCfAURkCl0MuHA==;
Date: Sat, 22 Nov 2025 13:02:18 +0200
Message-Id: <86fra6fhz9.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Protesilaos Stavrou <prot@HIDDEN>
In-Reply-To: <5e62c9900c115b2176941c324ba843e6@HIDDEN> (message from
 Protesilaos Stavrou on Mon, 17 Nov 2025 10:20:17 +0200)
Subject: Re: bug#79785: 31.0.50; [PATCH] Make Flymake fringe indicators use
 dedicated faces
References: <2fddca172e3698f386da40804bdc466e@HIDDEN>
 <86ikfk9b4j.fsf@HIDDEN> <ierh5uwmeaa.fsf@HIDDEN>
 <86ms4npwmn.fsf@HIDDEN> <8986f038e8b41954428c05b839bfc61f@HIDDEN>
 <CAO=BR8MG6SBxE=P4tpZHucK3gwPHarbuda2vjt3qRbAq8BZhmA@HIDDEN>
 <5e62c9900c115b2176941c324ba843e6@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 79785-done
Cc: sbaugh@HIDDEN, 79785-done <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Mon, 17 Nov 2025 10:20:17 +0200
> From: Protesilaos Stavrou <prot@HIDDEN>
> Cc: Eli Zaretskii <eliz@HIDDEN>, 79785 <at> debbugs.gnu.org
> 
> > From: Spencer Baugh <sbaugh@HIDDEN>
> > Date: Sat, 15 Nov 2025 11:48:51 -0500
> 
> > [... 23 lines elided]
> 
> >> >> After those two changes, this patch seems good to me.
> >> >>
> >> >> >> +(defface flymake-error-fringe '((t :inherit compilation-error))
> >> >> >> +  "Face used by default in the `flymake-error-bitmap'."
> >> >> >> +  :version "31.1"
> >> >> >> +  :package-version '(Flymake . "1.5.0"))
> >> >> >
> >> >> > This and other similar :package-version values in the new faces need
> >> >> > the value of Flymake versions added to
> >> >> > customize-package-emacs-version-alist to be expanded to include
> >> >> > version 1.5.0 of Flymake.
> >> >>
> >> >> That's unrelated to this patch and should be done separately, right?
> >> >
> >> > Up to you.  From my POV, it is related to this change because (AFAIU)
> >> > it is the first one that requires a newer version of Flymake to have
> >> > these faces available.
> >> 
> >> @Spencer If you want to do it as part of the patch, then I leave
> >> everything to you. No problem!
> >> 
> > 
> > No, I don't want to do it as part of this patch.
> 
> Very well! I did not touch that. I updated the patch to refer to package
> version 1.4.4. Nothing more. See attached.

Thanks, now installed on the master branch, and closing the bug.

Notification sent to Protesilaos Stavrou <prot@HIDDEN>:
bug acknowledged by developer. Full text available.

Reply sent to Eli Zaretskii <eliz@HIDDEN>:
You have taken responsibility. Full text available.