Received: (at 79799-done) by debbugs.gnu.org; 25 Nov 2025 20:31:26 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 25 15:31:25 2025
Received: from localhost ([127.0.0.1]:42291 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1vNzh2-0004WK-Ia
for submit <at> debbugs.gnu.org; Tue, 25 Nov 2025 15:31:25 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:35672)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1vMkjV-00048b-Ji
for 79799-done <at> debbugs.gnu.org; Sat, 22 Nov 2025 05:20:46 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1vMkjC-0004aH-Fd; Sat, 22 Nov 2025 05:20:26 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
Date; bh=4Fje7nhIdJAeqR5PDauEdW4J9PvniCjbiq1q6IbhW34=; b=YZnciMrGRgOdfKqs7f81
wa2MZd/XzBVgiqTGKw/z5Fa9q1Zcr9dAhGDzAt6EalNK11Zo/FWdf5w4i6t58KZqWZo7Zpx9qYF1c
Ihb8g1eCfrIyc20rtSU4AitqrEAor+q1zZsOvYnpAXpe97GhZyw4fsO6yAdBk2hm1WtJXy4YaLpLr
3YKafLDT8mxoc0IqF356PaJQe2GfTCKJ0aVx/itbD/T858UHosMfWS7eNLLnceT0csRkoAitRcZPR
WqjOFccJZDShim26apw+uTSRAEzYtu3SWa4MadducLAeNnZLLFJvh31jpFq6tuvLrKedjNH/YlF0q
KfQsKkmgP/efDg==;
Date: Sat, 22 Nov 2025 12:20:09 +0200
Message-Id: <86ldjyfjxi.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Jostein =?utf-8?Q?Kj=C3=B8nigsen?= <jostein@HIDDEN>
In-Reply-To: <B2BF3C3D-AC33-4D84-9CBC-11D3A9728AFA@HIDDEN>
(message from Jostein =?utf-8?Q?Kj=C3=B8nigsen?= on Sat, 15 Nov 2025
11:18:21 +0100)
Subject: Re: bug#79799: [PATCH] csharp-mode : Remove duplicated declarations
and fix a typo in a function's name.
References: <8wTEbc4VY_FldUKO2MY2Z9hIAe5OBkQpw9_AH-H-AB3PQILfojLuv4zIWXdkEKa8xXQohxoQIAfNbiioOpQuETdqcYuD5ImEhMKQXncuX8k=@kigoth.pink>
<86v7jbocpj.fsf@HIDDEN>
<B2BF3C3D-AC33-4D84-9CBC-11D3A9728AFA@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 79799-done
Cc: ana@HIDDEN, theo@HIDDEN, 79799-done <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: Jostein Kjønigsen <jostein@HIDDEN>
> Date: Sat, 15 Nov 2025 11:18:21 +0100
> Cc: ana@HIDDEN,
> Theodor Thornhill <theo@HIDDEN>,
> Jostein Kjønigsen <jostein@HIDDEN>,
> 79799 <at> debbugs.gnu.org
>
>
> > On 15 Nov 2025, at 10:40, Eli Zaretskii <eliz@HIDDEN> wrote:
> >
> >> Date: Sun, 09 Nov 2025 14:22:48 +0000
> >> From: ana--- via "Bug reports for GNU Emacs,
> >> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
> >
> > Theo and Jostein, any comments about the patch?
>
> Hei Eli. Thanks for bringing it to my attention.
>
> >
> >> From ff5cd9e6f2582b91b44f582f4a0d4b1bc4b6c6da Mon Sep 17 00:00:00 2001
> >> From: Ana <ana@HIDDEN>
> >> Date: Sun, 9 Nov 2025 14:59:01 +0100
> >> Subject: [PATCH] csharp-mode : Remove duplicated declarations and fix a typo in a function's name.
> >>
> >> * lisp/progmodes/csharp-mode.el (csharp-vsemi-unknown): rename to 'csharp-vsemi-unknown-p'. The code was calling a function that does not exist due to this typo.
> >> (c-class-decl-kwds): remove duplicated declaration for csharp.
> >> (csharp-ts-mode--font-lock-settings): remove duplicated declaration of 'escape-sequence'.
> >> ---
> >> lisp/progmodes/csharp-mode.el | 12 +-----------
> >> 1 file changed, 1 insertion(+), 11 deletions(-)
> >>
> >> diff --git a/lisp/progmodes/csharp-mode.el b/lisp/progmodes/csharp-mode.el
> >> index 86b925afa7d..741d00ced1d 100644
> >> --- a/lisp/progmodes/csharp-mode.el
> >> +++ b/lisp/progmodes/csharp-mode.el
> >> @@ -197,12 +197,11 @@
> >> (c-lang-defconst c-at-vsemi-p-fn
> >> csharp 'csharp-at-vsemi-p)
> >>
> >> -(defun csharp-vsemi-status-unknown () t)
> >> +(defun csharp-vsemi-status-unknown-p () t)
> >>
> >> (c-lang-defconst c-vsemi-status-unknown-p-fn
> >> csharp 'csharp-vsemi-status-unknown-p)
>
> On the surface this looks like a good change. Whatever is there is obviously wrong, but I'll be honest and admit I don't know what would be a good way to test or verify this change.
>
> >>
> >> -
> >> (c-lang-defconst c-modifier-kwds
> >> csharp '("abstract" "default" "final" "native" "private" "protected"
> >> "public" "partial" "internal" "readonly" "static" "event" "transient"
> >> @@ -240,9 +239,6 @@
> >> (c-lang-defconst c-inexpr-class-kwds
> >> csharp nil)
> >>
> >> -(c-lang-defconst c-class-decl-kwds
> >> - csharp '("class" "struct" "interface"))
> >> -
>
> Another duplicate. Oh my. Thanks for cleaning it up!
>
> >> (c-lang-defconst c-std-abbrev-keywords
> >> csharp (append (c-lang-const c-std-abbrev-keywords) '("catch" "finally")))
> >>
> >> @@ -594,7 +590,6 @@ compilation and evaluation time conflicts."
> >> "[[:blank:]]+Stack Trace:\n"
> >> "[[:blank:]]+at [^\n]+ in \\([^\n]+\\):line \\([0-9]+\\)"))
> >>
> >> -
> >> (eval-after-load 'compile
> >> (lambda ()
> >> (dolist
> >> @@ -1080,11 +1075,6 @@ function is called. Subsequent calls return the first evaluated value."
> >> name: (identifier) @font-lock-function-name-face
> >> (lambda_expression)))
> >>
> >> - :language 'c-sharp
> >> - :feature 'escape-sequence
> >> - :override t
> >> - '((escape_sequence) @font-lock-escape-face)
> >> -
>
> This part looks good. We're clearly defining this feature twice. Good catch!
>
> >> :language 'c-sharp
> >> :feature 'directives
> >> :override t
> >> --
> >> 2.43.0
> >>
>
>
> I can 100% vouch for 2 out of these 3 changes. The third looks like good too, but I can't certify it..
Thanks, I've installed the patch, and I'm closing this bug.
ana@HIDDEN:Eli Zaretskii <eliz@HIDDEN>:
Received: (at 79799) by debbugs.gnu.org; 15 Nov 2025 10:18:44 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 15 05:18:44 2025
Received: from localhost ([127.0.0.1]:33888 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1vKDMh-0007eH-KY
for submit <at> debbugs.gnu.org; Sat, 15 Nov 2025 05:18:44 -0500
Received: from fhigh-b3-smtp.messagingengine.com ([202.12.124.154]:39577)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <jostein@HIDDEN>)
id 1vKDMe-0007e8-K9
for 79799 <at> debbugs.gnu.org; Sat, 15 Nov 2025 05:18:41 -0500
Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42])
by mailfhigh.stl.internal (Postfix) with ESMTP id 9EA017A0182;
Sat, 15 Nov 2025 05:18:34 -0500 (EST)
Received: from phl-mailfrontend-01 ([10.202.2.162])
by phl-compute-02.internal (MEProxy); Sat, 15 Nov 2025 05:18:34 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
secure.kjonigsen.net; h=cc:cc:content-transfer-encoding
:content-type:content-type:date:date:from:from:in-reply-to
:in-reply-to:message-id:mime-version:references:reply-to:subject
:subject:to:to; s=fm2; t=1763201914; x=1763288314; bh=yw9tHB9By9
mzoxXACl0boVJqT+IuhXWHPV6LfKzSq2o=; b=c2q81/+OjbR2o1oIbSjnZqqYub
Do3SeHnZtkg6CuiCtOKeaSTFnrRSFksnveA8kUaWqSHAsUZoK2FpUJEH1O/8LJLk
f6tf7CcUYV9K9M7pyAknR2B/Z5pc0abt77qjynWWy2V/gWShuGiay9anJcxH5ZCR
R8btlOq7bMhJmGlFgGSipZlz4lfwKt0roKtjBybfkKnGvDPgjQTYVokl88qV+Agt
6cMVBELsJ9RHAmNVS11DxxQbeiwulS4wTHDN0iX4YMvUi0NWCMgDg1biNUqdYRhl
QVKJ361cOmB2hFDImdSgGQew4GS+PfBxq8bqOu6HLFYNPwe6uhNnxzWzLu8g==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-transfer-encoding
:content-type:content-type:date:date:feedback-id:feedback-id
:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:subject:subject:to:to:x-me-proxy
:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1763201914; x=
1763288314; bh=yw9tHB9By9mzoxXACl0boVJqT+IuhXWHPV6LfKzSq2o=; b=g
284RRD70B02hPwYn6bqwN4an7vuNZaJ3DdXSpJgGW/aCUcMcwmXbqSOHMg2UsQpO
jDQ/fLX0KbTt6trOGL1TDD7qtvhI8+Kng+baJgFxTpwGIALJfJ2y6LgD8mSAuAyr
SgNRCoaPIZq5pPN9YZMSXjZ0t7DNy0+iZTqise00W9fI9d6U3bdRl8O40erw/+dY
iTNr0h+wG8OzJy2KeVQ90lObY8jD/IcTj3MKFF0bVQAEA0LO9mZ8DMLIcLxreIBV
JXVJ5tVmlKUqELwex3iaBKnNHhsg0dT+QEQ5G2zIsssCDsrT14zHv5XHDXzB4cQk
BgiVhj9K4J2BTKk1O/xjg==
X-ME-Sender: <xms:elMYaVTT_gCwIDHDx8Ra9AA8G_EP35VhlbmwCttp2CqdonHWfafMVw>
<xme:elMYaVpZ-iKjFTCCl27ZZ7YUYzxu2fdkhmjRKEqdEA5IqxTjH67ZM8GoNNRPlqkYx
0G95XwktQCjXT8usq8948Vr4xzX4QBl_TOp1ehTG-fvaG6lnNE>
X-ME-Received: <xmr:elMYaTJ66d6Nrz89S803dGPCPwQmuyYHFr-_zPanAhJ616uu_28DsQJnCh6-KWiEW6qQKbWm33-JeMwIMU1vOzs4L3sU0sgq>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvuddvgeegucetufdoteggodetrf
dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu
rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf
gurheptggguffhjgffvefgkfhfvffosehtqhhmtdhhtddvnecuhfhrohhmpeflohhsthgv
ihhnucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhigh
hsvghnrdhnvghtqeenucggtffrrghtthgvrhhnpeefvdeludelveeuueevgfetueehveef
geekheeiffefleekudevgeetkeefveehieenucevlhhushhtvghrufhiiigvpedtnecurf
grrhgrmhepmhgrihhlfhhrohhmpehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnihhg
shgvnhdrnhgvthdpnhgspghrtghpthhtohephedpmhhouggvpehsmhhtphhouhhtpdhrtg
hpthhtohepvghlihiisehgnhhurdhorhhgpdhrtghpthhtoheprghnrgeskhhighhothhh
rdhpihhnkhdprhgtphhtthhopehthhgvohesthhhohhrnhhhihhllhdrnhhopdhrtghpth
htohepjhhoshhtvghinheskhhjohhnihhgshgvnhdrnhgvthdprhgtphhtthhopeejleej
leelseguvggssghughhsrdhgnhhurdhorhhg
X-ME-Proxy: <xmx:elMYaYod6zSn5-0P38HjGUJd8goUNBCa8_IfFp23ZrVcEHuPsUmM0Q>
<xmx:elMYabxM8-AFQfpYCCaYfEQo3QZQGR8juMlkvfRklk9Szss7fFTbGw>
<xmx:elMYacPt1CfhZvDObPHDsisykBNtUKFJpykgfWqQB25ihlupkkBPUg>
<xmx:elMYaQ62Q-PzRDZbinb0B6DkmAoVCA5jYPlSVgVwNHpdIwAvqI-zIA>
<xmx:elMYaeF_geeniPYTrfB5WN2O2UqhACMDSjEskn_NIn5Moq2WzCrLRA0_>
Feedback-ID: ib2f84088:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat,
15 Nov 2025 05:18:33 -0500 (EST)
Content-Type: text/plain;
charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81.1.3\))
Subject: Re: bug#79799: [PATCH] csharp-mode : Remove duplicated declarations
and fix a typo in a function's name.
From: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= <jostein@HIDDEN>
In-Reply-To: <86v7jbocpj.fsf@HIDDEN>
Date: Sat, 15 Nov 2025 11:18:21 +0100
Content-Transfer-Encoding: quoted-printable
Message-Id: <B2BF3C3D-AC33-4D84-9CBC-11D3A9728AFA@HIDDEN>
References: <8wTEbc4VY_FldUKO2MY2Z9hIAe5OBkQpw9_AH-H-AB3PQILfojLuv4zIWXdkEKa8xXQohxoQIAfNbiioOpQuETdqcYuD5ImEhMKQXncuX8k=@kigoth.pink>
<86v7jbocpj.fsf@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
X-Mailer: Apple Mail (2.3826.700.81.1.3)
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 79799
Cc: ana@HIDDEN, Theodor Thornhill <theo@HIDDEN>,
=?utf-8?Q?Jostein_Kj=C3=B8nigsen?= <jostein@HIDDEN>,
79799 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
> On 15 Nov 2025, at 10:40, Eli Zaretskii <eliz@HIDDEN> wrote:
>=20
>> Date: Sun, 09 Nov 2025 14:22:48 +0000
>> From: ana--- via "Bug reports for GNU Emacs,
>> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
>=20
> Theo and Jostein, any comments about the patch?
Hei Eli. Thanks for bringing it to my attention.
>=20
>> =46rom ff5cd9e6f2582b91b44f582f4a0d4b1bc4b6c6da Mon Sep 17 00:00:00 =
2001
>> From: Ana <ana@HIDDEN>
>> Date: Sun, 9 Nov 2025 14:59:01 +0100
>> Subject: [PATCH] csharp-mode : Remove duplicated declarations and fix =
a typo in a function's name.
>>=20
>> * lisp/progmodes/csharp-mode.el (csharp-vsemi-unknown): rename to =
'csharp-vsemi-unknown-p'. The code was calling a function that does not =
exist due to this typo.
>> (c-class-decl-kwds): remove duplicated declaration for csharp.
>> (csharp-ts-mode--font-lock-settings): remove duplicated declaration =
of 'escape-sequence'.
>> ---
>> lisp/progmodes/csharp-mode.el | 12 +-----------
>> 1 file changed, 1 insertion(+), 11 deletions(-)
>>=20
>> diff --git a/lisp/progmodes/csharp-mode.el =
b/lisp/progmodes/csharp-mode.el
>> index 86b925afa7d..741d00ced1d 100644
>> --- a/lisp/progmodes/csharp-mode.el
>> +++ b/lisp/progmodes/csharp-mode.el
>> @@ -197,12 +197,11 @@
>> (c-lang-defconst c-at-vsemi-p-fn
>> csharp 'csharp-at-vsemi-p)
>>=20
>> -(defun csharp-vsemi-status-unknown () t)
>> +(defun csharp-vsemi-status-unknown-p () t)
>>=20
>> (c-lang-defconst c-vsemi-status-unknown-p-fn
>> csharp 'csharp-vsemi-status-unknown-p)
On the surface this looks like a good change. Whatever is there is =
obviously wrong, but I'll be honest and admit I don't know what would be =
a good way to test or verify this change.
>>=20
>> -
>> (c-lang-defconst c-modifier-kwds
>> csharp '("abstract" "default" "final" "native" "private" =
"protected"
>> "public" "partial" "internal" "readonly" "static" "event" =
"transient"
>> @@ -240,9 +239,6 @@
>> (c-lang-defconst c-inexpr-class-kwds
>> csharp nil)
>>=20
>> -(c-lang-defconst c-class-decl-kwds
>> - csharp '("class" "struct" "interface"))
>> -
Another duplicate. Oh my. Thanks for cleaning it up!
>> (c-lang-defconst c-std-abbrev-keywords
>> csharp (append (c-lang-const c-std-abbrev-keywords) '("catch" =
"finally")))
>>=20
>> @@ -594,7 +590,6 @@ compilation and evaluation time conflicts."
>> "[[:blank:]]+Stack Trace:\n"
>> "[[:blank:]]+at [^\n]+ in \\([^\n]+\\):line \\([0-9]+\\)"))
>>=20
>> -
>> (eval-after-load 'compile
>> (lambda ()
>> (dolist
>> @@ -1080,11 +1075,6 @@ function is called. Subsequent calls return =
the first evaluated value."
>> name: (identifier) @font-lock-function-name-face
>> (lambda_expression)))
>>=20
>> - :language 'c-sharp
>> - :feature 'escape-sequence
>> - :override t
>> - '((escape_sequence) @font-lock-escape-face)
>> -
This part looks good. We're clearly defining this feature twice. Good =
catch!
>> :language 'c-sharp
>> :feature 'directives
>> :override t
>> --=20
>> 2.43.0
>>=20
I can 100% vouch for 2 out of these 3 changes. The third looks like good =
too, but I can't certify it..
--
Cheers
Jostein
bug-gnu-emacs@HIDDEN:bug#79799; Package emacs.
Full text available.
Received: (at 79799) by debbugs.gnu.org; 15 Nov 2025 09:41:08 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 15 04:41:08 2025
Received: from localhost ([127.0.0.1]:33756 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1vKCmJ-0006ES-Rl
for submit <at> debbugs.gnu.org; Sat, 15 Nov 2025 04:41:08 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:54170)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1vKCmH-0006Dw-Dn
for 79799 <at> debbugs.gnu.org; Sat, 15 Nov 2025 04:41:06 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1vKCmA-0003ub-Vn; Sat, 15 Nov 2025 04:40:59 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
Date; bh=COGElY2xD5zOWGx2SeQwGdEM5/hBl0tjrhCzyazf9aM=; b=jTuU4T0+7Q5Myz6L9QPv
TM08o7baKzMuxy+ufa5iN3thwHcO96wlFYIYP5P0COc4bKVsHA6u1/z+LF49XZeehaWwOxl+n86OL
46JDqizV2kSKhTlKxdELA5t4PAfp2uX0eF95NH0vTvx6+ZZ7xpQbYR6T5PGKIrVugS60Q+7cqh7jt
jqzIbzMJzKoRgc6ptzH3ddWlle2ur/sJtl6mrPqd9SnbS2Ue16dSiPEc1xo5Qgs8KaHyR3V9NlyH+
WyA1HUfjPUNcrgv6PvqAnvxTF5WViT79jOzrw1Ggji1eUeMhIlJOeIoORIdG9XgHwGwvDZ9M1bkNr
PF2aMoV8biTHBQ==;
Date: Sat, 15 Nov 2025 11:40:56 +0200
Message-Id: <86v7jbocpj.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: ana@HIDDEN, Theodor Thornhill <theo@HIDDEN>,
Jostein =?utf-8?Q?Kj=C3=B8nigsen?= <jostein@HIDDEN>
In-Reply-To: <8wTEbc4VY_FldUKO2MY2Z9hIAe5OBkQpw9_AH-H-AB3PQILfojLuv4zIWXdkEKa8xXQohxoQIAfNbiioOpQuETdqcYuD5ImEhMKQXncuX8k=@kigoth.pink>
(bug-gnu-emacs@HIDDEN)
Subject: Re: bug#79799: [PATCH] csharp-mode : Remove duplicated declarations
and fix a typo in a function's name.
References: <8wTEbc4VY_FldUKO2MY2Z9hIAe5OBkQpw9_AH-H-AB3PQILfojLuv4zIWXdkEKa8xXQohxoQIAfNbiioOpQuETdqcYuD5ImEhMKQXncuX8k=@kigoth.pink>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 79799
Cc: 79799 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> Date: Sun, 09 Nov 2025 14:22:48 +0000
> From: ana--- via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
Theo and Jostein, any comments about the patch?
> From ff5cd9e6f2582b91b44f582f4a0d4b1bc4b6c6da Mon Sep 17 00:00:00 2001
> From: Ana <ana@HIDDEN>
> Date: Sun, 9 Nov 2025 14:59:01 +0100
> Subject: [PATCH] csharp-mode : Remove duplicated declarations and fix a typo in a function's name.
>
> * lisp/progmodes/csharp-mode.el (csharp-vsemi-unknown): rename to 'csharp-vsemi-unknown-p'. The code was calling a function that does not exist due to this typo.
> (c-class-decl-kwds): remove duplicated declaration for csharp.
> (csharp-ts-mode--font-lock-settings): remove duplicated declaration of 'escape-sequence'.
> ---
> lisp/progmodes/csharp-mode.el | 12 +-----------
> 1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/lisp/progmodes/csharp-mode.el b/lisp/progmodes/csharp-mode.el
> index 86b925afa7d..741d00ced1d 100644
> --- a/lisp/progmodes/csharp-mode.el
> +++ b/lisp/progmodes/csharp-mode.el
> @@ -197,12 +197,11 @@
> (c-lang-defconst c-at-vsemi-p-fn
> csharp 'csharp-at-vsemi-p)
>
> -(defun csharp-vsemi-status-unknown () t)
> +(defun csharp-vsemi-status-unknown-p () t)
>
> (c-lang-defconst c-vsemi-status-unknown-p-fn
> csharp 'csharp-vsemi-status-unknown-p)
>
> -
> (c-lang-defconst c-modifier-kwds
> csharp '("abstract" "default" "final" "native" "private" "protected"
> "public" "partial" "internal" "readonly" "static" "event" "transient"
> @@ -240,9 +239,6 @@
> (c-lang-defconst c-inexpr-class-kwds
> csharp nil)
>
> -(c-lang-defconst c-class-decl-kwds
> - csharp '("class" "struct" "interface"))
> -
> (c-lang-defconst c-std-abbrev-keywords
> csharp (append (c-lang-const c-std-abbrev-keywords) '("catch" "finally")))
>
> @@ -594,7 +590,6 @@ compilation and evaluation time conflicts."
> "[[:blank:]]+Stack Trace:\n"
> "[[:blank:]]+at [^\n]+ in \\([^\n]+\\):line \\([0-9]+\\)"))
>
> -
> (eval-after-load 'compile
> (lambda ()
> (dolist
> @@ -1080,11 +1075,6 @@ function is called. Subsequent calls return the first evaluated value."
> name: (identifier) @font-lock-function-name-face
> (lambda_expression)))
>
> - :language 'c-sharp
> - :feature 'escape-sequence
> - :override t
> - '((escape_sequence) @font-lock-escape-face)
> -
> :language 'c-sharp
> :feature 'directives
> :override t
> --
> 2.43.0
>
bug-gnu-emacs@HIDDEN:bug#79799; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 9 Nov 2025 14:23:14 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 09 09:23:14 2025 Received: from localhost ([127.0.0.1]:58966 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1vI6K1-0001sp-Mp for submit <at> debbugs.gnu.org; Sun, 09 Nov 2025 09:23:14 -0500 Received: from lists.gnu.org ([2001:470:142::17]:41080) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <ana@HIDDEN>) id 1vI6Jy-0001se-43 for submit <at> debbugs.gnu.org; Sun, 09 Nov 2025 09:23:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ana@HIDDEN>) id 1vI6Jr-0004nI-Ns for bug-gnu-emacs@HIDDEN; Sun, 09 Nov 2025 09:23:03 -0500 Received: from mail-08.mail-europe.com ([57.129.93.249]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ana@HIDDEN>) id 1vI6Jp-00084z-Km for bug-gnu-emacs@HIDDEN; Sun, 09 Nov 2025 09:23:03 -0500 Date: Sun, 09 Nov 2025 14:22:48 +0000 To: "bug-gnu-emacs@HIDDEN" <bug-gnu-emacs@HIDDEN> From: ana@HIDDEN Subject: [PATCH] csharp-mode : Remove duplicated declarations and fix a typo in a function's name. Message-ID: <8wTEbc4VY_FldUKO2MY2Z9hIAe5OBkQpw9_AH-H-AB3PQILfojLuv4zIWXdkEKa8xXQohxoQIAfNbiioOpQuETdqcYuD5ImEhMKQXncuX8k=@kigoth.pink> Feedback-ID: 96884362:user:proton X-Pm-Message-ID: c80278454b93cc6844bc318b8683a07b3b6c7927 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1=_gD02pyJXA6XKZOcMGuAuy08fLwhY0Lzi62Y10GpR0" Received-SPF: pass client-ip=57.129.93.249; envelope-from=ana@HIDDEN; helo=mail-08.mail-europe.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) --b1=_gD02pyJXA6XKZOcMGuAuy08fLwhY0Lzi62Y10GpR0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Empty Message --b1=_gD02pyJXA6XKZOcMGuAuy08fLwhY0Lzi62Y10GpR0 Content-Type: text/x-patch; name=0001-csharp-mode-Remove-duplicated-declarations-and-fix-a.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-csharp-mode-Remove-duplicated-declarations-and-fix-a.patch RnJvbSBmZjVjZDllNmYyNTgyYjkxYjQ0ZjU4MmY0YTBkNGIxYmM0YjZjNmRhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbmEgPGFuYUBraWdvdGgucGluaz4KRGF0ZTogU3VuLCA5IE5v diAyMDI1IDE0OjU5OjAxICswMTAwClN1YmplY3Q6IFtQQVRDSF0gY3NoYXJwLW1vZGUgOiBSZW1v dmUgZHVwbGljYXRlZCBkZWNsYXJhdGlvbnMgYW5kIGZpeCBhIHR5cG8gaW4gYSBmdW5jdGlvbidz IG5hbWUuCgoqIGxpc3AvcHJvZ21vZGVzL2NzaGFycC1tb2RlLmVsIChjc2hhcnAtdnNlbWktdW5r bm93bik6IHJlbmFtZSB0byAnY3NoYXJwLXZzZW1pLXVua25vd24tcCcuIFRoZSBjb2RlIHdhcyBj YWxsaW5nIGEgZnVuY3Rpb24gdGhhdCBkb2VzIG5vdCBleGlzdCBkdWUgdG8gdGhpcyB0eXBvLgoo Yy1jbGFzcy1kZWNsLWt3ZHMpOiByZW1vdmUgZHVwbGljYXRlZCBkZWNsYXJhdGlvbiBmb3IgY3No YXJwLgooY3NoYXJwLXRzLW1vZGUtLWZvbnQtbG9jay1zZXR0aW5ncyk6IHJlbW92ZSBkdXBsaWNh dGVkIGRlY2xhcmF0aW9uIG9mICdlc2NhcGUtc2VxdWVuY2UnLgotLS0KIGxpc3AvcHJvZ21vZGVz L2NzaGFycC1tb2RlLmVsIHwgMTIgKy0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNl cnRpb24oKyksIDExIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL2Nz aGFycC1tb2RlLmVsIGIvbGlzcC9wcm9nbW9kZXMvY3NoYXJwLW1vZGUuZWwKaW5kZXggODZiOTI1 YWZhN2QuLjc0MWQwMGNlZDFkIDEwMDY0NAotLS0gYS9saXNwL3Byb2dtb2Rlcy9jc2hhcnAtbW9k ZS5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9jc2hhcnAtbW9kZS5lbApAQCAtMTk3LDEyICsxOTcs MTEgQEAKIChjLWxhbmctZGVmY29uc3QgYy1hdC12c2VtaS1wLWZuCiAgIGNzaGFycCAnY3NoYXJw LWF0LXZzZW1pLXApCiAKLShkZWZ1biBjc2hhcnAtdnNlbWktc3RhdHVzLXVua25vd24gKCkgdCkK KyhkZWZ1biBjc2hhcnAtdnNlbWktc3RhdHVzLXVua25vd24tcCAoKSB0KQogCiAoYy1sYW5nLWRl ZmNvbnN0IGMtdnNlbWktc3RhdHVzLXVua25vd24tcC1mbgogICBjc2hhcnAgJ2NzaGFycC12c2Vt aS1zdGF0dXMtdW5rbm93bi1wKQogCi0KIChjLWxhbmctZGVmY29uc3QgYy1tb2RpZmllci1rd2Rz CiAgIGNzaGFycCAnKCJhYnN0cmFjdCIgImRlZmF1bHQiICJmaW5hbCIgIm5hdGl2ZSIgInByaXZh dGUiICJwcm90ZWN0ZWQiCiAgICAgICAgICAgICJwdWJsaWMiICJwYXJ0aWFsIiAiaW50ZXJuYWwi ICJyZWFkb25seSIgInN0YXRpYyIgImV2ZW50IiAidHJhbnNpZW50IgpAQCAtMjQwLDkgKzIzOSw2 IEBACiAoYy1sYW5nLWRlZmNvbnN0IGMtaW5leHByLWNsYXNzLWt3ZHMKICAgY3NoYXJwIG5pbCkK IAotKGMtbGFuZy1kZWZjb25zdCBjLWNsYXNzLWRlY2wta3dkcwotICBjc2hhcnAgJygiY2xhc3Mi ICJzdHJ1Y3QiICJpbnRlcmZhY2UiKSkKLQogKGMtbGFuZy1kZWZjb25zdCBjLXN0ZC1hYmJyZXYt a2V5d29yZHMKICAgY3NoYXJwIChhcHBlbmQgKGMtbGFuZy1jb25zdCBjLXN0ZC1hYmJyZXYta2V5 d29yZHMpICcoImNhdGNoIiAiZmluYWxseSIpKSkKIApAQCAtNTk0LDcgKzU5MCw2IEBAIGNvbXBp bGF0aW9uIGFuZCBldmFsdWF0aW9uIHRpbWUgY29uZmxpY3RzLiIKICAgICJbWzpibGFuazpdXStT dGFjayBUcmFjZTpcbiIKICAgICJbWzpibGFuazpdXSthdCBbXlxuXSsgaW4gXFwoW15cbl0rXFwp OmxpbmUgXFwoWzAtOV0rXFwpIikpCiAKLQogKGV2YWwtYWZ0ZXItbG9hZCAnY29tcGlsZQogICAo bGFtYmRhICgpCiAgICAgKGRvbGlzdApAQCAtMTA4MCwxMSArMTA3NSw2IEBAIGZ1bmN0aW9uIGlz IGNhbGxlZC4gIFN1YnNlcXVlbnQgY2FsbHMgcmV0dXJuIHRoZSBmaXJzdCBldmFsdWF0ZWQgdmFs dWUuIgogICAgICAgICAgICAgICAgIG5hbWU6IChpZGVudGlmaWVyKSBAZm9udC1sb2NrLWZ1bmN0 aW9uLW5hbWUtZmFjZQogICAgICAgICAgICAgICAgIChsYW1iZGFfZXhwcmVzc2lvbikpKQogCi0g ICAgICAgICAgICAgOmxhbmd1YWdlICdjLXNoYXJwCi0gICAgICAgICAgICAgOmZlYXR1cmUgJ2Vz Y2FwZS1zZXF1ZW5jZQotICAgICAgICAgICAgIDpvdmVycmlkZSB0Ci0gICAgICAgICAgICAgJygo ZXNjYXBlX3NlcXVlbmNlKSBAZm9udC1sb2NrLWVzY2FwZS1mYWNlKQotCiAgICAgICAgICAgICAg Omxhbmd1YWdlICdjLXNoYXJwCiAgICAgICAgICAgICAgOmZlYXR1cmUgJ2RpcmVjdGl2ZXMKICAg ICAgICAgICAgICA6b3ZlcnJpZGUgdAotLSAKMi40My4wCgo= --b1=_gD02pyJXA6XKZOcMGuAuy08fLwhY0Lzi62Y10GpR0--
ana@HIDDEN:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#79799; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.