GNU logs - #79810, boring messages

Message sent to eg642616@HIDDEN, bug-gnu-emacs@HIDDEN:

Subject: bug#79810: hideshow: Indicators missing for same-line multi-blocks
Resent-From: Juri Linkov <juri@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: eg642616@HIDDEN, bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 10 Nov 2025 18:43:02 +0000
Resent-Message-ID: <handler.79810.B.17628001536091 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 79810 <at> debbugs.gnu.org
Cc: Elijah Gabe =?UTF-8?Q?P=C3=A9rez?= <eg642616@HIDDEN>
From: Juri Linkov <juri@HIDDEN>
Organization: LINKOV.NET
Date: Mon, 10 Nov 2025 20:39:56 +0200
Message-ID: <87tsz1k9z7.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=80.241.56.171; envelope-from=juri@HIDDEN;
 helo=mout-p-201.mailbox.org
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,
 RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

We have a problem in hideshow when a line contains more than 1 block.

For example in c-ts-mode:

#include <stdio.h>
int main(int argc, char* argv[]) {
  for (int i = 0; i < argc; i++) {
    printf("%s\n", argv[i]);
  }
  return 0;
}

There is no hideshow indicator for the second line
because the argument list is not hideable, so the 
the opening bracket for the function body is ignored
on the same line.

When the curly bracket on the next line,
then the indicator is shown:

int main(int argc, char* argv[])
{
  for (int i = 0; i < argc; i++) {

The same problem exists for go-ts-mode
and other modes with similar syntax.

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Juri Linkov <juri@HIDDEN>
Subject: bug#79810: Acknowledgement (hideshow: Indicators missing for
 same-line multi-blocks)
Message-ID: <handler.79810.B.17628001536091.ack <at> debbugs.gnu.org>
References: <87tsz1k9z7.fsf@HIDDEN>
X-Gnu-PR-Message: ack 79810
X-Gnu-PR-Package: emacs
Reply-To: 79810 <at> debbugs.gnu.org
Date: Mon, 10 Nov 2025 18:43:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

As you requested using X-Debbugs-CC, your message was also forwarded to
  Elijah Gabe P=C3=A9rez <eg642616@HIDDEN>
(after having been given a bug report number, if it did not have one).

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 79810 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
79810: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D79810
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#79810: hideshow: Indicators missing for same-line multi-blocks
Resent-From: Elijah Gabe =?UTF-8?Q?P=C3=A9rez?= <eg642616@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 10 Nov 2025 22:07:01 +0000
Resent-Message-ID: <handler.79810.B79810.17628123755042 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Juri Linkov <juri@HIDDEN>
Cc: 79810 <at> debbugs.gnu.org
From: Elijah Gabe =?UTF-8?Q?P=C3=A9rez?= <eg642616@HIDDEN>
In-Reply-To: <87tsz1k9z7.fsf@HIDDEN>
References: <87tsz1k9z7.fsf@HIDDEN>
Date: Mon, 10 Nov 2025 16:06:01 -0600
Message-ID: <871pm5wnjq.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--=-=-=
Content-Type: text/plain

Juri Linkov <juri@HIDDEN> writes:

> We have a problem in hideshow when a line contains more than 1 block.
>
> For example in c-ts-mode:
>
> #include <stdio.h>
> int main(int argc, char* argv[]) {
>   for (int i = 0; i < argc; i++) {
>     printf("%s\n", argv[i]);
>   }
>   return 0;
> }
>
> There is no hideshow indicator for the second line
> because the argument list is not hideable, so the 
> the opening bracket for the function body is ignored
> on the same line.
>
> When the curly bracket on the next line,
> then the indicator is shown:
>
> int main(int argc, char* argv[])
> {
>   for (int i = 0; i < argc; i++) {
>
> The same problem exists for go-ts-mode
> and other modes with similar syntax.

I found the bug, this patch should fix it:


--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
 filename=0001-hideshow-Fix-indicators-for-multiple-block-in-the-sa.patch

From e1874d86783f5a15b19a525c61aaa0f6f1740ed4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?El=C3=ADas=20Gabriel=20P=C3=A9rez?= <eg642616@HIDDEN>
Date: Mon, 10 Nov 2025 15:46:19 -0600
Subject: [PATCH] hideshow: Fix indicators for multiple block in the same line

bug#79810

* lisp/progmodes/hideshow.el (hs-hideable-region-p): Simplify.
(hs-block-positions): Change return value.
(hs--add-indicators): Go to the next line only if we have
successfully created the overlays.
(hs-hide-block-at-point, hs-hide-block): Update code.
---
 lisp/progmodes/hideshow.el | 58 ++++++++++++++++++++++----------------
 1 file changed, 34 insertions(+), 24 deletions(-)

diff --git a/lisp/progmodes/hideshow.el b/lisp/progmodes/hideshow.el
index af5d7a5b19e..06bc0c6e36d 100644
--- a/lisp/progmodes/hideshow.el
+++ b/lisp/progmodes/hideshow.el
@@ -678,11 +678,16 @@ hs-discard-overlays
         (delete-overlay ov))))
   (hs--refresh-indicators from to))
 
-(defun hs-hideable-region-p (beg end)
-  "Return t if region in BEG and END can be hidden."
+(defun hs-hideable-region-p (&optional beg end)
+  "Return t if region in BEG and END can be hidden.
+If BEG and END are not specified, it will try to check at the current
+block at point."
   ;; Check if BEG and END are not in the same line number,
   ;; since using `count-lines' is slow.
-  (< beg (save-excursion (goto-char end) (line-beginning-position))))
+  (if (and beg end)
+      (< beg (save-excursion (goto-char end) (line-beginning-position)))
+    (when-let* ((block (hs-block-positions)))
+      (apply #'hs-hideable-region-p block))))
 
 (defun hs-make-overlay (b e kind &optional b-offset e-offset)
   "Return a new overlay in region defined by B and E with type KIND.
@@ -724,7 +729,7 @@ hs-make-overlay
 
 (defun hs-block-positions ()
   "Return the current code block positions.
-This returns a cons-cell with the current code block beginning and end
+This returns a list with the current code block beginning and end
 positions.  This does nothing if there is not a code block at current
 point."
   (save-match-data
@@ -754,7 +759,7 @@ hs-block-positions
             (setq block-end
                   (or (funcall hs-adjust-block-end-function block-beg)
                       block-end)))
-          (cons block-beg block-end))))))
+          (list block-beg block-end))))))
 
 (defun hs--make-indicators-overlays (beg)
   "Helper function to make the indicators overlays."
@@ -824,9 +829,9 @@ hs--add-indicators
                            (point))))
                 ;; Check if block is longer than 1 line.
                 (_ (hs-hideable-region-p b-beg b-end)))
-      (hs--make-indicators-overlays b-beg))
-    ;; Only 1 indicator per line
-    (forward-line 1))
+      ;; Only 1 indicator per line
+      (when (hs--make-indicators-overlays b-beg)
+        (forward-line))))
   `(jit-lock-bounds ,beg . ,end))
 
 (defun hs--refresh-indicators (from to)
@@ -947,8 +952,8 @@ hs-hide-block-at-point
   (if comment-reg
       (hs-hide-comment-region (car comment-reg) (cadr comment-reg) end)
     (when-let* ((block (hs-block-positions)))
-      (let ((p (car-safe block))
-            (q (cdr-safe block))
+      (let ((p (car block))
+            (q (cadr block))
             ov)
         (if (hs-hideable-region-p p q)
             (progn
@@ -1229,7 +1234,8 @@ hs-hide-block
 `hs-hide-hook' is run.  See documentation for `run-hooks'."
   (interactive "P")
   (hs-life-goes-on
-   (let ((c-reg (funcall hs-inside-comment-predicate)))
+   (let ((c-reg (funcall hs-inside-comment-predicate))
+         (pos (point)))
      (cond
       ((and c-reg (or (null (nth 0 c-reg))
                       (not (hs-hideable-region-p (car c-reg) (nth 1 c-reg)))))
@@ -1238,20 +1244,24 @@ hs-hide-block
       (c-reg (hs-hide-block-at-point end c-reg))
 
       ((or (and (eq hs-hide-block-behavior 'after-bol)
-                (save-excursion
-                  (goto-char (line-beginning-position))
-                  (funcall hs-find-next-block-function hs-block-start-regexp
-                           (line-end-position) nil))
+                (setq pos (point))
+                (goto-char (line-beginning-position))
+                (catch 'hs--exit-hide
+                  (while (and (funcall hs-find-next-block-function
+                                       hs-block-start-regexp
+                                       (line-end-position) nil)
+                              (save-excursion
+                                (goto-char (match-beginning 0))
+                                (if (hs-hideable-region-p)
+                                    (throw 'hs--exit-hide t)
+                                  t)))))
                 (goto-char (match-beginning 0)))
-           (funcall hs-looking-at-block-start-predicate))
-       ;; If hiding the block fails (due the block is not hideable)
-       ;; then just hide the parent block (if possible)
-       (unless (save-excursion (hs-hide-block-at-point end))
-         (goto-char (1- (point)))
-         (funcall hs-find-block-beginning-function)
-         (hs-hide-block-at-point end)))
-
-      ((funcall hs-find-block-beginning-function)
+           (and (goto-char pos)
+                (funcall hs-looking-at-block-start-predicate)))
+       (hs-hide-block-at-point end))
+
+      ((and (goto-char (line-beginning-position))
+            (funcall hs-find-block-beginning-function))
        (hs-hide-block-at-point end)))
 
      (run-hooks 'hs-hide-hook))))
-- 
2.51.1


--=-=-=
Content-Type: text/plain



-- 
- E.G via Gnus and Org.

--=-=-=--

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#79810: hideshow: Indicators missing for same-line multi-blocks
Resent-From: Juri Linkov <juri@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 11 Nov 2025 07:42:02 +0000
Resent-Message-ID: <handler.79810.B79810.176284689027039 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Elijah Gabe =?UTF-8?Q?P=C3=A9rez?= <eg642616@HIDDEN>
Cc: 79810 <at> debbugs.gnu.org
From: Juri Linkov <juri@HIDDEN>
In-Reply-To: <871pm5wnjq.fsf@HIDDEN>
Organization: LINKOV.NET
References: <87tsz1k9z7.fsf@HIDDEN> <871pm5wnjq.fsf@HIDDEN>
Date: Tue, 11 Nov 2025 09:39:20 +0200
Message-ID: <871pm5hvbr.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

close 79810 31.0.50
thanks

> I found the bug, this patch should fix it:

Thanks for fixing this bug.  Now the patch is pushed.

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 11 Nov 2025 07:41:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 11 02:41:30 2025
Received: from localhost ([127.0.0.1]:42995 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1vIj0M-000724-4G
	for submit <at> debbugs.gnu.org; Tue, 11 Nov 2025 02:41:30 -0500
Received: from mout-p-101.mailbox.org ([80.241.56.151]:49922)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <juri@HIDDEN>)
 id 1vIj0E-00071U-8Q; Tue, 11 Nov 2025 02:41:22 -0500
Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4d5JPM6k6Sz9t74;
 Tue, 11 Nov 2025 08:41:11 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linkov.net; s=MBO0001; 
 t=1762846871;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=2gzwYBlHSPnwY6Rs/0+n3ubF912/axf4RUOgUNYxgAg=;
 b=sQjDIx4fvj/tDap6ZfoRV3ybCSFISIzWGbbLpg7wQ27hMG5hMswzjSDH2rcoOHVFcnvNaL
 ClhiXC8DF/FmyNQMvyO/txKNKH7oAhjwiW1VTEgijXir79h1lhfFLmVgMzbOWw72QSsCs0
 +KRJb788E7/ehxPwnahcTf5wkk4hpkYeAoCKO+5S1e3A9j8DjZ8yopqdEz/3t9FxNrjXCd
 jXAw3UDdUBCZNVrdbjJgvwvMqQX/ET92Z8WEM7mEoV23YrgA+vS2/UCOh7yXLT71MjcCQU
 6W471BYJEalncJyeGAwIAnnwYnhe3D+0s1JLV9ni2a00hbniOiu2tyqY1bqmDg==
From: Juri Linkov <juri@HIDDEN>
To: Elijah Gabe =?iso-8859-1?Q?P=E9rez?= <eg642616@HIDDEN>
Subject: Re: bug#79810: hideshow: Indicators missing for same-line multi-blocks
In-Reply-To: <871pm5wnjq.fsf@HIDDEN>
Organization: LINKOV.NET
References: <87tsz1k9z7.fsf@HIDDEN> <871pm5wnjq.fsf@HIDDEN>
Date: Tue, 11 Nov 2025 09:39:20 +0200
Message-ID: <871pm5hvbr.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: control
Cc: 79810 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

close 79810 31.0.50
thanks

> I found the bug, this patch should fix it:

Thanks for fixing this bug.  Now the patch is pushed.

Last modified: Tue, 11 Nov 2025 07:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.