GNU logs - #79815, boring messages

Message sent to larsi@HIDDEN, bug-gnu-emacs@HIDDEN:

Subject: bug#79815: [PATCH] Add current subject to future history in `message-change-subject'
Resent-From: Rudolf =?UTF-8?Q?Adamkovi=C4=8D?= <rudolf@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: larsi@HIDDEN, bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 11 Nov 2025 12:23:02 +0000
Resent-Message-ID: <handler.79815.B.176286373915298 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 79815 <at> debbugs.gnu.org
Cc: Lars Magne Ingebrigtsen <larsi@HIDDEN>
Feedback-ID: i88214938:Fastmail
From: Rudolf =?UTF-8?Q?Adamkovi=C4=8D?= <rudolf@HIDDEN>
Date: Tue, 11 Nov 2025 13:21:57 +0100
Message-ID: <m28qgcrc7u.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=202.12.124.144; envelope-from=rudolf@HIDDEN;
 helo=fout-b1-smtp.messagingengine.com
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,
 RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

--=-=-=
Content-Type: text/plain

Tags: patch

Fellow Emacs hackers,

When amending the subject header with `message-change-subject', the
current value of the header is not available in the "future history",
which is impractical if all one needs is to fix a word, or add a missing
prefix or suffix.  The attached patch improves the situation by putting
the current subject into the future history.

Rudy


--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
 filename=0001-Add-current-subject-to-future-history-in-message-cha.patch

From 2ce917c57eec7453b52be540f0c847ff2922af96 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rudolf=20Adamkovi=C4=8D?= <rudolf@HIDDEN>
Date: Tue, 11 Nov 2025 13:07:18 +0100
Subject: [PATCH] Add current subject to future history in
 `message-change-subject'

* etc/NEWS (minutes): Announce the feature.
* lisp/gnus/message.el (message-change-subject): Read the new subject
with the old subject in the "future history".
---
 etc/NEWS             |  3 ++
 lisp/gnus/message.el | 67 ++++++++++++++++++++++++--------------------
 2 files changed, 40 insertions(+), 30 deletions(-)

diff --git a/etc/NEWS b/etc/NEWS
index 7168cc5bb92..c773f3a6d01 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -1740,6 +1740,9 @@ honored if it was already set.
 +++
 *** 'message-strip-subject-re' now matches case-insensitively.
 
+---
+*** 'message-change-subject' inserts current subject to "future history".
+
 ** Sendmail
 
 ---
diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el
index 18a3e0a9fde..0f90a098a3f 100644
--- a/lisp/gnus/message.el
+++ b/lisp/gnus/message.el
@@ -2400,36 +2400,43 @@ message-strip-subject-trailing-was
 
 ;;; Suggested by Jonas Steverud  @  www.dtek.chalmers.se/~d4jonas/
 
-(defun message-change-subject (new-subject)
-  "Ask for NEW-SUBJECT header, append (was: <Old Subject>)."
-  (interactive
-   (list
-    (read-from-minibuffer "New subject: "))
-   message-mode)
-  (cond ((and (not (or (null new-subject) ; new subject not empty
-		       (zerop (string-width new-subject))
-		       (string-match "^[ \t]*$" new-subject))))
-	 (save-excursion
-	   (let ((old-subject
-		  (save-restriction
-		    (message-narrow-to-headers)
-		    (message-fetch-field "Subject"))))
-	     (cond ((not old-subject)
-		    (error "No current subject"))
-		   ((not (string-match
-			  (concat "^[ \t]*"
-				  (regexp-quote new-subject)
-				  "[ \t]*$")
-			  old-subject))  ; yes, it really is a new subject
-		    ;; delete eventual Re: prefix
-		    (setq old-subject
-			  (message-strip-subject-re old-subject))
-		    (message-goto-subject)
-		    (delete-line)
-		    (insert (concat "Subject: "
-				    new-subject
-				    " (was: "
-				    old-subject ")\n")))))))))
+(defun message-change-subject (&optional new-subject)
+  "Change subject to NEW-SUBJECT with \"(was: <Old Subject>)\" suffix.
+If NEW-SUBJECT is nil, the user is prompted for the new subject, with
+the old subject in \"future history\"."
+  (interactive nil message-mode)
+  (let ((old-subject (save-restriction
+		       (message-narrow-to-headers)
+		       (message-fetch-field "Subject"))))
+    (if (not old-subject)
+	(error "No current subject")
+      (let ((new-subject (or new-subject
+                             (read-from-minibuffer "New subject: "
+                                                   nil nil nil nil
+                                                   old-subject))))
+        (cond
+         ;; Abort on empty subject.
+         ((or (null new-subject)
+	      (zerop (string-width new-subject))
+	      (string-match "^[ \t]*$" new-subject))
+          (message "Subject empty"))
+         ;; Abort on unchanged subject.
+         ((string-match
+	   (concat "^[ \t]*"
+		   (regexp-quote new-subject)
+		   "[ \t]*$")
+	   old-subject)
+          (message "Subject unchanged"))
+         ;; Otherwise, proceed.
+         (t
+	  (save-excursion
+            (message-goto-subject)
+	    (delete-line)
+	    (insert (concat "Subject: "
+			    new-subject
+			    " (was: "
+                            (message-strip-subject-re old-subject)
+                            ")\n")))))))))
 
 (defun message-mark-inserted-region (beg end &optional verbatim)
   "Mark some region in the current article with enclosing tags.
-- 
2.39.5 (Apple Git-154)


--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


--=20
"It is better to have 100 functions operate on one data structure than
10 functions on 10 data structures."

--- Alan Perlis

Rudolf Adamkovi=C4=8D <rudolf@HIDDEN> [he/him]
http://adamkovic.org

--=-=-=--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Rudolf =?UTF-8?Q?Adamkovi=C4=8D?= <rudolf@HIDDEN>
Subject: bug#79815: Acknowledgement ([PATCH] Add current subject to future
 history in `message-change-subject')
Message-ID: <handler.79815.B.176286373915298.ack <at> debbugs.gnu.org>
References: <m28qgcrc7u.fsf@HIDDEN>
X-Gnu-PR-Message: ack 79815
X-Gnu-PR-Package: emacs
X-Gnu-PR-Keywords: patch
Reply-To: 79815 <at> debbugs.gnu.org
Date: Tue, 11 Nov 2025 12:23:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

As you requested using X-Debbugs-CC, your message was also forwarded to
  Lars Magne Ingebrigtsen <larsi@HIDDEN>
(after having been given a bug report number, if it did not have one).

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 79815 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
79815: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D79815
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Last modified: Tue, 11 Nov 2025 12:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.