GNU bug report logs - #79856
[PATCH] font-lock-doc-markup-face for 'tag_name' node in document blocks.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: Vincenzo Pupillo <v.pupillo@HIDDEN>; Keywords: patch; Done: Juri Linkov <juri@HIDDEN>; Maintainer for emacs is bug-gnu-emacs@HIDDEN.
bug marked as fixed in version 31.0.50, send any further explanations to 79856 <at> debbugs.gnu.org and Vincenzo Pupillo <v.pupillo@HIDDEN> Request was from Juri Linkov <juri@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 79856 <at> debbugs.gnu.org:


Received: (at 79856) by debbugs.gnu.org; 20 Nov 2025 17:50:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 20 12:50:15 2025
Received: from localhost ([127.0.0.1]:49603 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1vM8nP-0000zJ-0G
	for submit <at> debbugs.gnu.org; Thu, 20 Nov 2025 12:50:15 -0500
Received: from mout-p-201.mailbox.org ([2001:67c:2050:0:465::201]:42820)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <juri@HIDDEN>)
 id 1vM8nM-0000yr-Sq; Thu, 20 Nov 2025 12:50:13 -0500
Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4dC5Tm3bv6z9sqW;
 Thu, 20 Nov 2025 18:50:04 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linkov.net; s=MBO0001; 
 t=1763661004;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 content-transfer-encoding:content-transfer-encoding:
 in-reply-to:in-reply-to:references:references;
 bh=+ldQ/Ad1CbcZvHHKgI1JXnZrDj5SdOjVj6Gqcx2POwY=;
 b=YgpaQJUq8qK5zhItIncHADVGLJ6NmSF3p+EW3ZSvdUYeyPS4j3HpMg3yGW2L25YUhnNxCt
 toxJUOEyAlwdiobcF5XthUkYGFfIiQRZJhlnLlQYQ1uUbc45Z8ASZOd1Hv3J8VpzF2/o5q
 prKjfxCZsNLlMuIrkoIjIUYA++1vqdfCItIw3mYwKKwnSpGgT3mzpWnKDuuNsIiDXWzrX+
 /GYWUe9jKRN5yMAwNX2vSVoYE/WOiyejjiGFGAEGTOOgkuyBkovzIgQ7RSBeFdM9cs/Vqb
 o7sr5+NfYz9j6LLzE/QoqHnz74gB8Jv6I/DxiL+oO4atY+PuD7E0OQ2jeXwSTw==
From: Juri Linkov <juri@HIDDEN>
To: Vincenzo Pupillo <v.pupillo@HIDDEN>
Subject: Re: bug#79856: [PATCH] font-lock-doc-markup-face for 'tag_name'
 node in document blocks.
In-Reply-To: <27248630.1r3eYUQgxm@HIDDEN>
Organization: LINKOV.NET
References: <27248630.1r3eYUQgxm@HIDDEN>
Date: Thu, 20 Nov 2025 19:49:25 +0200
Message-ID: <87tsyoh9wa.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 79856
Cc: 79856 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

close 79856 31.0.50
thanks

> following an email exchange with Protesilaos, he pointed out that for 
> 'tag_name' in doxygen, jsdoc, and phpdoc document blocks, it would be more 
> appropriate to use ‘font-lock-doc-markup-face’ instead of 'font-lock-constant-
> face'. Here is the patch.

Thanks, pushed.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#79856; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 18 Nov 2025 15:26:32 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 18 10:26:32 2025
Received: from localhost ([127.0.0.1]:58456 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1vLNbE-0005lv-8B
	for submit <at> debbugs.gnu.org; Tue, 18 Nov 2025 10:26:32 -0500
Received: from lists.gnu.org ([2001:470:142::17]:57626)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <v.pupillo@HIDDEN>)
 id 1vLNbC-0005lB-8Z
 for submit <at> debbugs.gnu.org; Tue, 18 Nov 2025 10:26:30 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <v.pupillo@HIDDEN>)
 id 1vLNav-0002y1-3O
 for bug-gnu-emacs@HIDDEN; Tue, 18 Nov 2025 10:26:13 -0500
Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <v.pupillo@HIDDEN>)
 id 1vLNar-0007TN-4S
 for bug-gnu-emacs@HIDDEN; Tue, 18 Nov 2025 10:26:12 -0500
Received: by mail-wm1-x333.google.com with SMTP id
 5b1f17b1804b1-4777771ed1aso39362415e9.2
 for <bug-gnu-emacs@HIDDEN>; Tue, 18 Nov 2025 07:26:06 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1763479565; x=1764084365; darn=gnu.org;
 h=content-transfer-encoding:mime-version:message-id:date:subject:to
 :from:from:to:cc:subject:date:message-id:reply-to;
 bh=s5dgjURW2Eg3LmUDL10vxYsKml2sRKShOcbBmUBH+W0=;
 b=ZcOaeEnoOm6b6XJBBgmxJtanikHacgqaiW7j6qidK1IYtHpEDuZs7i4Xpzizz2XZeP
 KduUr8NTSFdTYu/2AVRdMSwE4NQ9G4RZmfvavVAStLsPQsIS/GKTHtmu7S2qQuBPQp1u
 eHiPOVBVXhjBuLBUFQDkdDm94avgGXSTa38jy7FVBqrOzSEvihw5w4XQHqJaOXUqakQ/
 aeSHxY9H2Sl9fYSaS49EqoW3hhHBggNXvVau6kEhcvMSoJqiNLzpPp1OOBugTUtPu4Tw
 mxs4yuGNWqmnTAs2pjlWnsuLELC8W+qKzSf1VmSebvEJ/nHi1XIwDmeRr4upV4j1ATsz
 Swnw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1763479565; x=1764084365;
 h=content-transfer-encoding:mime-version:message-id:date:subject:to
 :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=s5dgjURW2Eg3LmUDL10vxYsKml2sRKShOcbBmUBH+W0=;
 b=Tu1HPCmqmNvRDT04H+HK1hz59xhqWajy0gqPZY4ZcAz+tl4oMmicD/JapOAjZYlQj7
 NzgM4xg3jyu3jGqmGsnpDNUsDn9LBh6CmmNXQXJ1UxO62agtSD2jf5wQSYGn8CWTzqgR
 VFA81QWwwsJgZpM9qx+m0gw9QH2qoTah/RH1/rODgnKKIuM+/tBSKWIDgz0wXzyFrcLp
 3jn4/UG5GFXSmGkgOGF6e7fciRYq+MNjoVZgjRL88y8chSAnvxhIm3mwEjT5DKEjk7ls
 0QjoDxZVDChHLL9QkAWHj5TTH/6mukiTPRp0YYhYzTlgCZXv+JVIukJGiZhIlB/Gh8Jf
 LmLw==
X-Gm-Message-State: AOJu0YwOLDu6fRuLopqacrYejUh8MhP0t/uS+SlRfTyoKvRfC7umx+ZG
 GUeDC4Qy5bA8oDaoA1kqme+FghXmzMqtxFCu+w1ZyyyvBziQFHtHrQxmRgoYsQ==
X-Gm-Gg: ASbGnctm+2OifWqJqDYs/hfBDxhUZom50Cx3skq/jmrbdbOl/jnhvSDBq+Px4e7QbOx
 bg6m340pRd/kpei4yeNLj5um6NbARRq08lcxOkG+6xOWDXT6sdpMI4igtAJ03Se43FDXzS0BJXs
 RsR+0z0vTORoQIaqKLvAkrYixWanjxUtN5b6HPjoEKk+BwPe93wBAdM6Ai8hGDH1/yoDk+lRHGS
 tZL+iJA7gRiQ6JDcQFLX2xelBEtMWlmrJqoioIaiY4+wVVEj80nHYukOWbqbVEMXYcLVVywczTT
 zqy82WZ36CaNdvcZp2/f5/7IuX2BkUOkKPVmxbSe3/LQuebePeb9U18pzQWwAh7IVq8xZDrnonZ
 viSYFId9ls6agfUJv8ry/LnokJwD8kGMTl9L0toqzbXJhBPIVxoEIGE9P0wXV5+sLXvwvzncQOH
 uFkx78Ux8rszDRevVUSWoP8VT+v77RYPcqKMVkB/LUqGhQzy7twCNpQUV0csHaBA==
X-Google-Smtp-Source: AGHT+IEf7a2AMJYoJox0Qk+Tap1QzPLZLnOSK+8ZOlnG9ga/rHt69MgZXZNWoVWLzoGCfWw3jdhc0Q==
X-Received: by 2002:a05:6000:310b:b0:42b:43cc:9827 with SMTP id
 ffacd0b85a97d-42b5936c667mr14572799f8f.38.1763479565380; 
 Tue, 18 Nov 2025 07:26:05 -0800 (PST)
Received: from 3-191.divsi.unimi.it (3-191.divsi.unimi.it. [159.149.3.191])
 by smtp.gmail.com with ESMTPSA id
 ffacd0b85a97d-42b53e845bdsm31508554f8f.12.2025.11.18.07.26.04
 for <bug-gnu-emacs@HIDDEN>
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 18 Nov 2025 07:26:04 -0800 (PST)
From: Vincenzo Pupillo <v.pupillo@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: [PATCH] font-lock-doc-markup-face for 'tag_name' node in document
 blocks.
Date: Tue, 18 Nov 2025 16:26:03 +0100
Message-ID: <27248630.1r3eYUQgxm@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="nextPart2435494.vFx2qVVIhK"
Content-Transfer-Encoding: 7Bit
Received-SPF: pass client-ip=2a00:1450:4864:20::333;
 envelope-from=v.pupillo@HIDDEN; helo=mail-wm1-x333.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

This is a multi-part message in MIME format.

--nextPart2435494.vFx2qVVIhK
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"

Ciao,
following an email exchange with Protesilaos, he pointed out that for=20
'tag_name' in doxygen, jsdoc, and phpdoc document blocks, it would be more=
=20
appropriate to use =E2=80=98font-lock-doc-markup-face=E2=80=99 instead of '=
font-lock-constant-
face'. Here is the patch.

Thanks.

Vincenzo
--nextPart2435494.vFx2qVVIhK
Content-Disposition: attachment;
 filename="0001-Use-documentation-mark-up-face-for-tag_name-node-in-.patch"
Content-Transfer-Encoding: 7Bit
Content-Type: text/x-patch; charset="UTF-8";
 name="0001-Use-documentation-mark-up-face-for-tag_name-node-in-.patch"

From 69e6fe72e68b9e4388682e35f6e7b35bcb61aaf2 Mon Sep 17 00:00:00 2001
From: Vincenzo Pupillo <v.pupillo@HIDDEN>
Date: Mon, 17 Nov 2025 23:01:03 +0100
Subject: [PATCH] Use documentation mark-up face for 'tag_name' node in
 document block.

Embedded documentation mark-up should be used for 'tag_name' in
documentation blocks (thanks to Protesilaos Stavrou).

* lisp/progmodes/c-ts-common.el
(c-ts-mode-doxygen-comment-font-lock-settings): Replaced
'font-lock-constant-face' with 'font-lock-doc-markup-face'.
* lisp/progmodes/js.el (js--treesit-font-lock-settings): Replaced
'font-lock-constant-face' with 'font-lock-doc-markup-face'.
* lisp/progmodes/php-ts-mode.el
(php-ts-mode--phpdoc-font-lock-settings): Replaced
'font-lock-constant-face' with 'font-lock-doc-markup-face'.
---
 lisp/progmodes/c-ts-common.el | 2 +-
 lisp/progmodes/js.el          | 2 +-
 lisp/progmodes/php-ts-mode.el | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/lisp/progmodes/c-ts-common.el b/lisp/progmodes/c-ts-common.el
index 5f9d485538a..08857f9ab20 100644
--- a/lisp/progmodes/c-ts-common.el
+++ b/lisp/progmodes/c-ts-common.el
@@ -407,7 +407,7 @@ c-ts-mode-doxygen-comment-font-lock-settings
    :language 'doxygen
    :override t
    :feature 'keyword
-   '((tag_name) @font-lock-constant-face
+   '((tag_name) @font-lock-doc-markup-face
      (type) @font-lock-type-face
      (emphasis) @bold
      ((tag_name) @bold (:match ".note" @bold))
diff --git a/lisp/progmodes/js.el b/lisp/progmodes/js.el
index 71951002ca8..15304486a5b 100644
--- a/lisp/progmodes/js.el
+++ b/lisp/progmodes/js.el
@@ -3735,7 +3735,7 @@ js--treesit-font-lock-settings
              :language 'jsdoc
              :override t
              :feature 'keyword
-             '((tag_name) @font-lock-constant-face)
+             '((tag_name) @font-lock-doc-markup-face)
 
              :language 'jsdoc
              :override t
diff --git a/lisp/progmodes/php-ts-mode.el b/lisp/progmodes/php-ts-mode.el
index 2c04c8cdeea..ea06c3f9dc9 100644
--- a/lisp/progmodes/php-ts-mode.el
+++ b/lisp/progmodes/php-ts-mode.el
@@ -1213,7 +1213,7 @@ php-ts-mode--phpdoc-font-lock-settings
    :language 'phpdoc
    :feature 'attribute
    :override t
-   `((tag_name) @font-lock-constant-face
+   `((tag_name) @font-lock-doc-markup-face
      (uri) @font-lock-doc-markup-face
      (tag
       [(version) (email_address)] @font-lock-doc-markup-face)
-- 
2.51.1


--nextPart2435494.vFx2qVVIhK--







Acknowledgement sent to Vincenzo Pupillo <v.pupillo@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#79856; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Thu, 20 Nov 2025 18:00:03 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.