GNU logs - #79883, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#79883: Allow locally overriding how a form is indented
Resent-From: Jonas Bernoulli <jonas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 25 Nov 2025 20:23:01 +0000
Resent-Message-ID: <handler.79883.B.17641021784734 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 79883 <at> debbugs.gnu.org
From: Jonas Bernoulli <jonas@HIDDEN>
Date: Sun, 23 Nov 2025 19:59:16 +0100
Message-ID: <87h5ukini3.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=212.243.197.30; envelope-from=jonas@HIDDEN;
 helo=mail.hostpark.net
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
 RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)

Hello,

The following patch makes it possible to change how certain forms
are indented in a file, using a buffer-local variable, like so:

;; Local Variables:
;; lisp-indent-local-overrides: ((interactive . 0) (cond . 0))
;; End:

IMO that's how these two forms should be indented, but it's unlikely
everyone would agree.  Even if everyone agreed, changing this globally
would have the drawback that a lot of existing code would suddenly be
indented wrongly.  Letting maintainers change the indentation for these
and/or other forms in individual files would not have the same issue.

diff --git a/lisp/emacs-lisp/lisp-mode.el b/lisp/emacs-lisp/lisp-mode.el
--- a/lisp/emacs-lisp/lisp-mode.el
+++ b/lisp/emacs-lisp/lisp-mode.el
@@ -1203,6 +1203,17 @@ lisp--local-defform-body-p
                          t)
                    (= local-definitions-starting-point (point))))))))))
 
+(defvar-local lisp-indent-local-overrides nil)
+
+(put 'lisp-indent-local-overrides 'safe-local-variable
+     (lambda (value)
+       (and (listp value)
+            (all (lambda (elt)
+                   (and (symbolp (car elt))
+                        (or (eq (cdr elt) 'defun)
+                            (integerp (cdr elt)))))
+                 value))))
+
 (defun lisp-indent-function (indent-point state)
   "This function is the normal value of the variable `lisp-indent-function'.
 The function `calculate-lisp-indent' calls this to determine
@@ -1252,12 +1263,12 @@ lisp-indent-function
           ;; inside the innermost containing sexp.
           (backward-prefix-chars)
           (current-column))
-      (let ((function (buffer-substring (point)
-                                       (progn (forward-sexp 1) (point))))
-           method)
-       (setq method (or (function-get (intern-soft function)
-                                       'lisp-indent-function 'macro)
-                        (get (intern-soft function) 'lisp-indent-hook)))
+      (let* ((function (intern-soft
+                        (buffer-substring (point)
+                                          (progn (forward-sexp 1) (point)))))
+             (method (or (alist-get function lisp-indent-local-overrides)
+                         (function-get function 'lisp-indent-function 'macro)
+                         (get function 'lisp-indent-hook))))
        (cond ((or (eq method 'defun)
                    ;; Check whether we are in flet-like form.
                    (lisp--local-defform-body-p state))

     Cheers,
     Jonas

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Jonas Bernoulli <jonas@HIDDEN>
Subject: bug#79883: Acknowledgement (Allow locally overriding how a form
 is indented)
Message-ID: <handler.79883.B.17641021784734.ack <at> debbugs.gnu.org>
References: <87h5ukini3.fsf@HIDDEN>
X-Gnu-PR-Message: ack 79883
X-Gnu-PR-Package: emacs
Reply-To: 79883 <at> debbugs.gnu.org
Date: Tue, 25 Nov 2025 20:23:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 79883 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
79883: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D79883
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#79883: Allow locally overriding how a form is indented
Resent-From: Sean Whitton <spwhitton@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 26 Nov 2025 10:49:02 +0000
Resent-Message-ID: <handler.79883.B79883.176415412329296 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 79883 <at> debbugs.gnu.org
Cc: Jonas Bernoulli <jonas@HIDDEN>
Feedback-ID: 20115:3760:null:purelymail
From: Sean Whitton <spwhitton@HIDDEN>
In-Reply-To: <87h5ukini3.fsf@HIDDEN>
References: <87h5ukini3.fsf@HIDDEN>
Date: Wed, 26 Nov 2025 10:48:27 +0000
Message-ID: <87bjkpdq84.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hello,

On Sun 23 Nov 2025 at 07:59pm +01, Jonas Bernoulli wrote:

> Hello,
>
> The following patch makes it possible to change how certain forms
> are indented in a file, using a buffer-local variable, like so:
>
> ;; Local Variables:
> ;; lisp-indent-local-overrides: ((interactive . 0) (cond . 0))
> ;; End:
>
> IMO that's how these two forms should be indented, but it's unlikely
> everyone would agree.  Even if everyone agreed, changing this globally
> would have the drawback that a lot of existing code would suddenly be
> indented wrongly.  Letting maintainers change the indentation for these
> and/or other forms in individual files would not have the same issue.

A feature like this makes sense to me.  Can you write up the docs?

Thanks.

-- 
Sean Whitton

Last modified: Wed, 26 Nov 2025 11:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.