X-Loop: help-debbugs@HIDDEN
Subject: bug#79900: [PATCH] NS: Fix toolbar style and position
Resent-From: Rudolf =?UTF-8?Q?Adamkovi=C4=8D?= <rudolf@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 26 Nov 2025 08:52:01 +0000
Resent-Message-ID: <handler.79900.B.1764147110602 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: report 79900
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: 79900 <at> debbugs.gnu.org
X-Debbugs-Original-To: bug-gnu-emacs@HIDDEN
Received: via spool by submit <at> debbugs.gnu.org id=B.1764147110602
(code B ref -1); Wed, 26 Nov 2025 08:52:01 +0000
Received: (at submit) by debbugs.gnu.org; 26 Nov 2025 08:51:50 +0000
Received: from localhost ([127.0.0.1]:50459 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1vOBFe-00009c-2D
for submit <at> debbugs.gnu.org; Wed, 26 Nov 2025 03:51:50 -0500
Received: from lists.gnu.org ([2001:470:142::17]:52002)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <rudolf@HIDDEN>)
id 1vOBFZ-000095-Qs
for submit <at> debbugs.gnu.org; Wed, 26 Nov 2025 03:51:47 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <rudolf@HIDDEN>)
id 1vOBEs-0007zu-9Z
for bug-gnu-emacs@HIDDEN; Wed, 26 Nov 2025 03:51:11 -0500
Received: from fhigh-a7-smtp.messagingengine.com ([103.168.172.158])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <rudolf@HIDDEN>)
id 1vOBEp-0004SC-VR
for bug-gnu-emacs@HIDDEN; Wed, 26 Nov 2025 03:51:01 -0500
Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42])
by mailfhigh.phl.internal (Postfix) with ESMTP id 1A64E1400275
for <bug-gnu-emacs@HIDDEN>; Wed, 26 Nov 2025 03:50:57 -0500 (EST)
Received: from phl-mailfrontend-01 ([10.202.2.162])
by phl-compute-02.internal (MEProxy); Wed, 26 Nov 2025 03:50:57 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamkovic.org;
h=cc:content-type:content-type:date:date:from:from:in-reply-to
:message-id:mime-version:reply-to:subject:subject:to:to; s=fm2;
t=1764147057; x=1764233457; bh=t54ZAXV1KyFp8GgtaqFomQM6Tp71tLwZ
WpKP+EsngPo=; b=NpNEx2hudsMz1epb5U3PVuIXBZSoPiQT6Cf4duiAil8hmGff
AunC/tg8RAXmi2ikB6yErjkx0gP5KpRqvjlHQzggSOJkqzszZ1mzu7+wqIRzvRy3
d+bBIfurihvhPatlibbXymb/SETb7atdJyNkza0VaqdJJNKndkdCCtzkaex4Nbe8
+gC9onh2s7zlE8tYNGkd+9QTNrsjWYl/24aZv0QBTzljUG60Bi9oSisam3VMPC6P
30JFeqvetmzT/7Qs2ypGlVw1KQGpEeTya9tKAjFyUu4iNf3FHTyYEPbauILRQBbJ
vrZ6PI0yDY+tkFXibS6fQOqmoHTtirrHPi83dg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-type:content-type:date:date
:feedback-id:feedback-id:from:from:in-reply-to:message-id
:mime-version:reply-to:subject:subject:to:to:x-me-proxy
:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1764147057; x=
1764233457; bh=t54ZAXV1KyFp8GgtaqFomQM6Tp71tLwZWpKP+EsngPo=; b=K
rPyadtG32OI5QXmOuYWmDCoHFzHDe8nZAqxbmk2I5Igd/ewc7KfqYwiU8dAmuC4c
igynh5vLbg7/um9vcUxt6WnMvww9KcUKR+sjhO3kPJkPYf6DKFz15BLydJMr9Dl8
SGQLkYBXIU7DAFPx7ztZZovZ9PinyJGLWDO4+iQxm9xaph2j3XGSG8egciaJw5g1
ZN2KAGTTU/f/2HNkkhThAbOnCfn1pkHql3uyHbzRWnxsSG5J6Vpyr9qsOjYFjEes
TsD9QOZQrivRWXU/EggdnMBf6qIfnM1K3F6hTD1IlBh7PWLSn//5X190U57l/xOJ
TCi9JErLKJ6M4MKxhcfSA==
X-ME-Sender: <xms:cL8maTetkK3SkUQBGobprGPZGbY4A218YeWsvuWRJpu4iKVwnKe3gg>
<xme:cL8mafG7irW0MhjAeZiaQvabIsuu0prVQLj2EejBdv3dPCRWS3ZS17ocAmtNNmsmv
zdS0dh3FSf9QEHznbVCk6JyWQv9ycQ9Guc9T5YAgqrPbwyv9F4isA>
X-ME-Received: <xmr:cL8maXlYyTkPgsvdIgiN26pijuuwGUVFmz_YTMGqAxfNOEccgkJzRJH4JlFYckIOeuaQzW8nPM6hW-u3MUW-EFyQPxv2eS8>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvgeefledvucetufdoteggodetrf
dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu
rghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkgggtsehmtderredttdejne
cuhfhrohhmpeftuhguohhlfhcutegurghmkhhovhhitgcuoehruhguohhlfhesrggurghm
khhovhhitgdrohhrgheqnecuggftrfgrthhtvghrnhepueethfekleetfffggeeikeeftd
dtiefhleehleelvedugfefvdefffetgefhfeelnecuffhomhgrihhnpehgnhhurdhorhhg
necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprhhuug
holhhfsegruggrmhhkohhvihgtrdhorhhgpdhnsggprhgtphhtthhopedupdhmohguvgep
shhmthhpohhuthdprhgtphhtthhopegsuhhgqdhgnhhuqdgvmhgrtghssehgnhhurdhorh
hg
X-ME-Proxy: <xmx:cL8maRx2Y6R2bDQCGDlxsB1336-itgyl0kX_ljPk3NRxIx7KxCsYww>
<xmx:cL8maTTdaABMXWvp9mKyaZR32FEpyLNAfBp91wvdEaK0XMsS6k6gpA>
<xmx:cL8maUtoyM--NYNweCtva4qovuUt076vsWcGmJlFw3NSNWro5IXP3w>
<xmx:cL8maVu_UFY3v-s0JLPY8u720vi9KRnEONSgxAPHzKOXuIng_WX0yg>
<xmx:cb8maY-akV2JI7BvW6c3zAgzg52rUkKMFwdQ4WiKsVRhNXWgAb6WVPIA>
Feedback-ID: i88214938:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA for
<bug-gnu-emacs@HIDDEN>; Wed, 26 Nov 2025 03:50:56 -0500 (EST)
From: Rudolf =?UTF-8?Q?Adamkovi=C4=8D?= <rudolf@HIDDEN>
Date: Wed, 26 Nov 2025 09:50:53 +0100
Message-ID: <m2zf89ch3m.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=103.168.172.158;
envelope-from=rudolf@HIDDEN; helo=fhigh-a7-smtp.messagingengine.com
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,
RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)
--=-=-=
Content-Type: text/plain
Tags: patch
Mac OS 11 introduced compact toolbar styles and automatic styling of
toolbars. As a result, the position and size of Emacs toolbars is now
determined at runtime by Apple. No documentation exists as to how the
toolbar style is determined. This patch fixes the toolbar style.
Motivation:
https://lists.gnu.org/archive/html/help-gnu-emacs/2025-11/msg00132.html
https://lists.gnu.org/archive/html/help-gnu-emacs/2025-11/msg00147.html
Rudy
In GNU Emacs 31.0.50 (build 8, aarch64-apple-darwin24.5.0, NS
appkit-2575.60 Version 15.5 (Build 24F74)) of 2025-11-26 built on
skynet.local
Repository revision: ead2fa8655003e40d2a9aa128c1b0477ff0a2970
Repository branch: master
Windowing system distributor 'Apple', version 10.3.2575
System Description: macOS 15.5
Configured using:
'configure --with-json --with-tree-sitter --with-sqlite3
--with-native-compilation=aot'
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=0001-NS-Fix-toolbar-style-and-position.patch
From 290676267ac3a43fa50b58a25918e20548eb87c8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rudolf=20Adamkovi=C4=8D?= <rudolf@HIDDEN>
Date: Wed, 26 Nov 2025 09:24:19 +0100
Subject: [PATCH] NS: Fix toolbar style and position
* src/nsterm.m ([EmacsWindow initWithEmacsFrame:fullscreen:screen:]):
Always show the toolbar below the window title. This is needed on Mac
OS 11+ where the toolbar style is decided by the system (which is
unpredictable) and the newfangled "compact" toolbar may be chosen (which
is undesirable).
---
src/nsterm.m | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/src/nsterm.m b/src/nsterm.m
index 74ee1219bbc..200b006d6fa 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -9562,6 +9562,13 @@ - (instancetype) initWithEmacsFrame: (struct frame *) f
#ifdef NS_IMPL_COCOA
if ([self respondsToSelector:@selector(setTabbingMode:)])
[self setTabbingMode:NSWindowTabbingModeDisallowed];
+#endif
+ /* Always show the toolbar below the window title. This is needed
+ on Mac OS 11+ where the toolbar style is decided by the system
+ (which is unpredictable) and the newfangled "compact" toolbar
+ may be chosen (which is undesirable). */
+#ifdef NS_IMPL_COCOA
+ [self setToolbarStyle: NSWindowToolbarStyleExpanded];
#endif
}
--
2.39.5 (Apple Git-154)
--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
--=20
"Genius is 1% inspiration and 99% perspiration."
--- Thomas Alva Edison, 1932
Rudolf Adamkovi=C4=8D <rudolf@HIDDEN> [he/him]
http://adamkovic.org
--=-=-=--
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Rudolf =?UTF-8?Q?Adamkovi=C4=8D?= <rudolf@HIDDEN> Subject: bug#79900: Acknowledgement ([PATCH] NS: Fix toolbar style and position) Message-ID: <handler.79900.B.1764147110602.ack <at> debbugs.gnu.org> References: <m2zf89ch3m.fsf@HIDDEN> X-Gnu-PR-Message: ack 79900 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 79900 <at> debbugs.gnu.org Date: Wed, 26 Nov 2025 08:52:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): bug-gnu-emacs@HIDDEN If you wish to submit further information on this problem, please send it to 79900 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 79900: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D79900 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN
Subject: bug#79900: [PATCH] NS: Fix toolbar style and position
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 29 Nov 2025 11:40:02 +0000
Resent-Message-ID: <handler.79900.B79900.176441634415824 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 79900
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Rudolf =?UTF-8?Q?Adamkovi=C4=8D?= <rudolf@HIDDEN>, alan@HIDDEN
Cc: 79900 <at> debbugs.gnu.org
Received: via spool by 79900-submit <at> debbugs.gnu.org id=B79900.176441634415824
(code B ref 79900); Sat, 29 Nov 2025 11:40:02 +0000
Received: (at 79900) by debbugs.gnu.org; 29 Nov 2025 11:39:04 +0000
Received: from localhost ([127.0.0.1]:55440 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1vPJI7-000477-Ig
for submit <at> debbugs.gnu.org; Sat, 29 Nov 2025 06:39:04 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:53196)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1vPJI5-00046K-Ku
for 79900 <at> debbugs.gnu.org; Sat, 29 Nov 2025 06:39:02 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1vPJHz-0000zI-Nz; Sat, 29 Nov 2025 06:38:55 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
Date; bh=KESwRjIFpKuCXTZpPxZmwLw9+R0lhxa4Xl87NGmwr8s=; b=Ngec/qzNP5YSEbj1MiHA
1fvWAPlP2MJ2xVtL8LvFABZPnkTxgMbPHJGJSmCufSpu880hnn3mROpkq1Juj2PB07l+2ZEDREHl0
PYhMNvM2xhSP1A9WUrAK8Bg4hcd/jqFV99/cbNfI4WMa4JVG5Emfnc5z9HdP3+wHmS2AdNoFXmW8Q
v4qNFRe/kQU3Yu7nRdp+qZGbEVLkx/2N2gZTu+ygra5qWkRvfPpp6zxKuGpFooqpY0ZvO2aN6kUyc
noVSGEtrfPxgJMgQpEhLa+DuIPIvA2HeWCp8DesbbVdUkWFO1AQ6FIiZqjd9LcWbjMJrTyvlGD3OS
igghLqwHHtXcsA==;
Date: Sat, 29 Nov 2025 13:38:53 +0200
Message-Id: <86h5ud6pbm.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <m2zf89ch3m.fsf@HIDDEN> (message from Rudolf
=?UTF-8?Q?Adamkovi=C4=8D?= on Wed, 26 Nov 2025 09:50:53 +0100)
References: <m2zf89ch3m.fsf@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: Rudolf Adamkovič <rudolf@HIDDEN>
> Date: Wed, 26 Nov 2025 09:50:53 +0100
>
> Mac OS 11 introduced compact toolbar styles and automatic styling of
> toolbars. As a result, the position and size of Emacs toolbars is now
> determined at runtime by Apple. No documentation exists as to how the
> toolbar style is determined. This patch fixes the toolbar style.
>
> Motivation:
>
> https://lists.gnu.org/archive/html/help-gnu-emacs/2025-11/msg00132.html
> https://lists.gnu.org/archive/html/help-gnu-emacs/2025-11/msg00147.html
Thanks.
Would users of Emacs on macOS please try this and provide feedback?
X-Loop: help-debbugs@HIDDEN
Subject: bug#79900: [PATCH] NS: Fix toolbar style and position
In-Reply-To: <m2zf89ch3m.fsf@HIDDEN>
Resent-From: Rudolf Schlatte <rudi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 03 Dec 2025 08:35:02 +0000
Resent-Message-ID: <handler.79900.B.176475088413228 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 79900
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: 79900 <at> debbugs.gnu.org
X-Debbugs-Original-To: bug-gnu-emacs@HIDDEN
Received: via spool by submit <at> debbugs.gnu.org id=B.176475088413228
(code B ref -1); Wed, 03 Dec 2025 08:35:02 +0000
Received: (at submit) by debbugs.gnu.org; 3 Dec 2025 08:34:44 +0000
Received: from localhost ([127.0.0.1]:38810 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1vQiJv-0003RH-Ub
for submit <at> debbugs.gnu.org; Wed, 03 Dec 2025 03:34:44 -0500
Received: from lists.gnu.org ([2001:470:142::17]:59612)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
id 1vQiJt-0003Qx-Qh
for submit <at> debbugs.gnu.org; Wed, 03 Dec 2025 03:34:42 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
id 1vQiJo-000072-GL
for bug-gnu-emacs@HIDDEN; Wed, 03 Dec 2025 03:34:36 -0500
Received: from ciao.gmane.io ([116.202.254.214])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
id 1vQiJm-0004aG-HA
for bug-gnu-emacs@HIDDEN; Wed, 03 Dec 2025 03:34:36 -0500
Received: from list by ciao.gmane.io with local (Exim 4.92)
(envelope-from <geb-bug-gnu-emacs@HIDDEN>)
id 1vQiJj-0003hR-JX
for bug-gnu-emacs@HIDDEN; Wed, 03 Dec 2025 09:34:31 +0100
X-Injected-Via-Gmane: http://gmane.org/
From: Rudolf Schlatte <rudi@HIDDEN>
Date: Wed, 03 Dec 2025 09:34:26 +0100
Message-ID: <m1a500ge0d.fsf@HIDDEN>
References: <m2zf89ch3m.fsf@HIDDEN> <86h5ud6pbm.fsf@HIDDEN>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
User-Agent: Gnus/5.13 (Gnus v5.13)
Cancel-Lock: sha1:8wjdFjztUvlHINX1zzVsjfQUD9Q=
Received-SPF: pass client-ip=116.202.254.214;
envelope-from=geb-bug-gnu-emacs@HIDDEN; helo=ciao.gmane.io
X-Spam_score_int: -16
X-Spam_score: -1.7
X-Spam_bar: -
X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9,
HEADER_FROM_DIFFERENT_DOMAINS=0.244, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,
RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.3 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)
Eli Zaretskii <eliz@HIDDEN> writes:
>> From: Rudolf Adamkovič <rudolf@HIDDEN>
>> Date: Wed, 26 Nov 2025 09:50:53 +0100
>>
>> Mac OS 11 introduced compact toolbar styles and automatic styling of
>> toolbars. As a result, the position and size of Emacs toolbars is now
>> determined at runtime by Apple. No documentation exists as to how the
>> toolbar style is determined. This patch fixes the toolbar style.
>>
>> Motivation:
>>
>> https://lists.gnu.org/archive/html/help-gnu-emacs/2025-11/msg00132.html
>> https://lists.gnu.org/archive/html/help-gnu-emacs/2025-11/msg00147.html
>
> Thanks.
>
> Would users of Emacs on macOS please try this and provide feedback?
The patch applies cleanly to master and does what it says, i.e., the
toolbar icons show up in a separate area below the title bar instead of
inside the title bar. Can't say that I like it, since it makes Emacs
look outdated on current OS versions and takes away some vertical space.
Maybe this can be made a user option?
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Eli Zaretskii <eliz@HIDDEN>
Subject: bug#79900: closed ([PATCH] NS: Fix toolbar style and position)
CC: tracker <at> debbugs.gnu.org
Message-ID: <handler.79900.D79900.176485072819168.ackdone <at> debbugs.gnu.org>
References: <868qfi1lut.fsf@HIDDEN> <m2zf89ch3m.fsf@HIDDEN>
X-Gnu-PR-Message: closed 79900
X-Gnu-PR-Package: emacs
X-Gnu-PR-Keywords: patch
Date: Thu, 04 Dec 2025 12:19:02 +0000
Content-Type: multipart/mixed; boundary="----------=_1764850742-19198-0"
This is a multi-part message in MIME format...
------------=_1764850742-19198-0
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=utf-8
Your message dated Thu, 04 Dec 2025 14:18:34 +0200
with message-id <868qfi1lut.fsf@HIDDEN>
and subject line Re: bug#79900: [PATCH] NS: Fix toolbar style and position
has caused the debbugs.gnu.org bug report #79900,
regarding [PATCH] NS: Fix toolbar style and position
to be marked as done.
(If you believe you have received this mail in error, please contact
help-debbugs@HIDDEN)
--=20
79900: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D79900
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems
------------=_1764850742-19198-0
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
Received: (at submit) by debbugs.gnu.org; 26 Nov 2025 08:51:50 +0000
Received: from localhost ([127.0.0.1]:50459 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1vOBFe-00009c-2D
for submit <at> debbugs.gnu.org; Wed, 26 Nov 2025 03:51:50 -0500
Received: from lists.gnu.org ([2001:470:142::17]:52002)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <rudolf@HIDDEN>)
id 1vOBFZ-000095-Qs
for submit <at> debbugs.gnu.org; Wed, 26 Nov 2025 03:51:47 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <rudolf@HIDDEN>)
id 1vOBEs-0007zu-9Z
for bug-gnu-emacs@HIDDEN; Wed, 26 Nov 2025 03:51:11 -0500
Received: from fhigh-a7-smtp.messagingengine.com ([103.168.172.158])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <rudolf@HIDDEN>)
id 1vOBEp-0004SC-VR
for bug-gnu-emacs@HIDDEN; Wed, 26 Nov 2025 03:51:01 -0500
Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42])
by mailfhigh.phl.internal (Postfix) with ESMTP id 1A64E1400275
for <bug-gnu-emacs@HIDDEN>; Wed, 26 Nov 2025 03:50:57 -0500 (EST)
Received: from phl-mailfrontend-01 ([10.202.2.162])
by phl-compute-02.internal (MEProxy); Wed, 26 Nov 2025 03:50:57 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamkovic.org;
h=cc:content-type:content-type:date:date:from:from:in-reply-to
:message-id:mime-version:reply-to:subject:subject:to:to; s=fm2;
t=1764147057; x=1764233457; bh=t54ZAXV1KyFp8GgtaqFomQM6Tp71tLwZ
WpKP+EsngPo=; b=NpNEx2hudsMz1epb5U3PVuIXBZSoPiQT6Cf4duiAil8hmGff
AunC/tg8RAXmi2ikB6yErjkx0gP5KpRqvjlHQzggSOJkqzszZ1mzu7+wqIRzvRy3
d+bBIfurihvhPatlibbXymb/SETb7atdJyNkza0VaqdJJNKndkdCCtzkaex4Nbe8
+gC9onh2s7zlE8tYNGkd+9QTNrsjWYl/24aZv0QBTzljUG60Bi9oSisam3VMPC6P
30JFeqvetmzT/7Qs2ypGlVw1KQGpEeTya9tKAjFyUu4iNf3FHTyYEPbauILRQBbJ
vrZ6PI0yDY+tkFXibS6fQOqmoHTtirrHPi83dg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-type:content-type:date:date
:feedback-id:feedback-id:from:from:in-reply-to:message-id
:mime-version:reply-to:subject:subject:to:to:x-me-proxy
:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1764147057; x=
1764233457; bh=t54ZAXV1KyFp8GgtaqFomQM6Tp71tLwZWpKP+EsngPo=; b=K
rPyadtG32OI5QXmOuYWmDCoHFzHDe8nZAqxbmk2I5Igd/ewc7KfqYwiU8dAmuC4c
igynh5vLbg7/um9vcUxt6WnMvww9KcUKR+sjhO3kPJkPYf6DKFz15BLydJMr9Dl8
SGQLkYBXIU7DAFPx7ztZZovZ9PinyJGLWDO4+iQxm9xaph2j3XGSG8egciaJw5g1
ZN2KAGTTU/f/2HNkkhThAbOnCfn1pkHql3uyHbzRWnxsSG5J6Vpyr9qsOjYFjEes
TsD9QOZQrivRWXU/EggdnMBf6qIfnM1K3F6hTD1IlBh7PWLSn//5X190U57l/xOJ
TCi9JErLKJ6M4MKxhcfSA==
X-ME-Sender: <xms:cL8maTetkK3SkUQBGobprGPZGbY4A218YeWsvuWRJpu4iKVwnKe3gg>
<xme:cL8mafG7irW0MhjAeZiaQvabIsuu0prVQLj2EejBdv3dPCRWS3ZS17ocAmtNNmsmv
zdS0dh3FSf9QEHznbVCk6JyWQv9ycQ9Guc9T5YAgqrPbwyv9F4isA>
X-ME-Received: <xmr:cL8maXlYyTkPgsvdIgiN26pijuuwGUVFmz_YTMGqAxfNOEccgkJzRJH4JlFYckIOeuaQzW8nPM6hW-u3MUW-EFyQPxv2eS8>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvgeefledvucetufdoteggodetrf
dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu
rghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkgggtsehmtderredttdejne
cuhfhrohhmpeftuhguohhlfhcutegurghmkhhovhhitgcuoehruhguohhlfhesrggurghm
khhovhhitgdrohhrgheqnecuggftrfgrthhtvghrnhepueethfekleetfffggeeikeeftd
dtiefhleehleelvedugfefvdefffetgefhfeelnecuffhomhgrihhnpehgnhhurdhorhhg
necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprhhuug
holhhfsegruggrmhhkohhvihgtrdhorhhgpdhnsggprhgtphhtthhopedupdhmohguvgep
shhmthhpohhuthdprhgtphhtthhopegsuhhgqdhgnhhuqdgvmhgrtghssehgnhhurdhorh
hg
X-ME-Proxy: <xmx:cL8maRx2Y6R2bDQCGDlxsB1336-itgyl0kX_ljPk3NRxIx7KxCsYww>
<xmx:cL8maTTdaABMXWvp9mKyaZR32FEpyLNAfBp91wvdEaK0XMsS6k6gpA>
<xmx:cL8maUtoyM--NYNweCtva4qovuUt076vsWcGmJlFw3NSNWro5IXP3w>
<xmx:cL8maVu_UFY3v-s0JLPY8u720vi9KRnEONSgxAPHzKOXuIng_WX0yg>
<xmx:cb8maY-akV2JI7BvW6c3zAgzg52rUkKMFwdQ4WiKsVRhNXWgAb6WVPIA>
Feedback-ID: i88214938:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA for
<bug-gnu-emacs@HIDDEN>; Wed, 26 Nov 2025 03:50:56 -0500 (EST)
From: =?utf-8?Q?Rudolf_Adamkovi=C4=8D?= <rudolf@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: [PATCH] NS: Fix toolbar style and position
X-Debbugs-Cc:
Date: Wed, 26 Nov 2025 09:50:53 +0100
Message-ID: <m2zf89ch3m.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=103.168.172.158;
envelope-from=rudolf@HIDDEN; helo=fhigh-a7-smtp.messagingengine.com
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,
RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)
--=-=-=
Content-Type: text/plain
Tags: patch
Mac OS 11 introduced compact toolbar styles and automatic styling of
toolbars. As a result, the position and size of Emacs toolbars is now
determined at runtime by Apple. No documentation exists as to how the
toolbar style is determined. This patch fixes the toolbar style.
Motivation:
https://lists.gnu.org/archive/html/help-gnu-emacs/2025-11/msg00132.html
https://lists.gnu.org/archive/html/help-gnu-emacs/2025-11/msg00147.html
Rudy
In GNU Emacs 31.0.50 (build 8, aarch64-apple-darwin24.5.0, NS
appkit-2575.60 Version 15.5 (Build 24F74)) of 2025-11-26 built on
skynet.local
Repository revision: ead2fa8655003e40d2a9aa128c1b0477ff0a2970
Repository branch: master
Windowing system distributor 'Apple', version 10.3.2575
System Description: macOS 15.5
Configured using:
'configure --with-json --with-tree-sitter --with-sqlite3
--with-native-compilation=aot'
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=0001-NS-Fix-toolbar-style-and-position.patch
From 290676267ac3a43fa50b58a25918e20548eb87c8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rudolf=20Adamkovi=C4=8D?= <rudolf@HIDDEN>
Date: Wed, 26 Nov 2025 09:24:19 +0100
Subject: [PATCH] NS: Fix toolbar style and position
* src/nsterm.m ([EmacsWindow initWithEmacsFrame:fullscreen:screen:]):
Always show the toolbar below the window title. This is needed on Mac
OS 11+ where the toolbar style is decided by the system (which is
unpredictable) and the newfangled "compact" toolbar may be chosen (which
is undesirable).
---
src/nsterm.m | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/src/nsterm.m b/src/nsterm.m
index 74ee1219bbc..200b006d6fa 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -9562,6 +9562,13 @@ - (instancetype) initWithEmacsFrame: (struct frame *) f
#ifdef NS_IMPL_COCOA
if ([self respondsToSelector:@selector(setTabbingMode:)])
[self setTabbingMode:NSWindowTabbingModeDisallowed];
+#endif
+ /* Always show the toolbar below the window title. This is needed
+ on Mac OS 11+ where the toolbar style is decided by the system
+ (which is unpredictable) and the newfangled "compact" toolbar
+ may be chosen (which is undesirable). */
+#ifdef NS_IMPL_COCOA
+ [self setToolbarStyle: NSWindowToolbarStyleExpanded];
#endif
}
--
2.39.5 (Apple Git-154)
--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
--=20
"Genius is 1% inspiration and 99% perspiration."
--- Thomas Alva Edison, 1932
Rudolf Adamkovi=C4=8D <rudolf@HIDDEN> [he/him]
http://adamkovic.org
--=-=-=--
------------=_1764850742-19198-0
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
Received: (at 79900-done) by debbugs.gnu.org; 4 Dec 2025 12:18:48 +0000
Received: from localhost ([127.0.0.1]:48135 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1vR8IK-0004z6-FE
for submit <at> debbugs.gnu.org; Thu, 04 Dec 2025 07:18:48 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:47670)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1vR8IH-0004yp-4n
for 79900-done <at> debbugs.gnu.org; Thu, 04 Dec 2025 07:18:46 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1vR8IB-00070D-1f; Thu, 04 Dec 2025 07:18:39 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
Date; bh=E8GWGjfM3T8n85CbDsI4ajdms8OSFCb0V2xL9OBY1ko=; b=JobsQDKhuNACfXijnrdG
QV0XT++3CurMxa8ehIaWkXg1b7C3gcrf+QRr1yW666PGsNYwg8/qD7MuxMfrKylmNHfO018LzRlO/
bDA5pm/3+eRfUO2jDHsdCPTKhEXrKmqWlYZNmlFa/VeRibJeMHpYTYvxtBvf9bfH7qErHD56SwoeY
hLZn6FXJU1WcEkWl5yqFjlweIS9/UoRlbqc/tA6Clr19jpOFdUVWefsnAuuQf7u8Iudyh4kn+xuhf
I/GC2JdkxNbNSOuhQKU2WwnHWIhp3R/KNZdcKHph2Te7UcVJ14oUBk5FJz+e1JFfvtFPx/LedYNrR
lctGVC6lJakS4Q==;
Date: Thu, 04 Dec 2025 14:18:34 +0200
Message-Id: <868qfi1lut.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Rudolf Schlatte <rudi@HIDDEN>
In-Reply-To: <m1a500ge0d.fsf@HIDDEN> (message from
Rudolf Schlatte on Wed, 03 Dec 2025 09:34:26 +0100)
Subject: Re: bug#79900: [PATCH] NS: Fix toolbar style and position
References: <m2zf89ch3m.fsf@HIDDEN> <86h5ud6pbm.fsf@HIDDEN>
<m1a500ge0d.fsf@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 79900-done
Cc: 79900-done <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: Rudolf Schlatte <rudi@HIDDEN>
> Date: Wed, 03 Dec 2025 09:34:26 +0100
>
> Eli Zaretskii <eliz@HIDDEN> writes:
>
> >> From: Rudolf Adamkovič <rudolf@HIDDEN>
> >> Date: Wed, 26 Nov 2025 09:50:53 +0100
> >>
> >> Mac OS 11 introduced compact toolbar styles and automatic styling of
> >> toolbars. As a result, the position and size of Emacs toolbars is now
> >> determined at runtime by Apple. No documentation exists as to how the
> >> toolbar style is determined. This patch fixes the toolbar style.
> >>
> >> Motivation:
> >>
> >> https://lists.gnu.org/archive/html/help-gnu-emacs/2025-11/msg00132.html
> >> https://lists.gnu.org/archive/html/help-gnu-emacs/2025-11/msg00147.html
> >
> > Thanks.
> >
> > Would users of Emacs on macOS please try this and provide feedback?
>
> The patch applies cleanly to master and does what it says, i.e., the
> toolbar icons show up in a separate area below the title bar instead of
> inside the title bar.
Thanks, now installed on the master branch, and closing the bug.
> Can't say that I like it, since it makes Emacs look outdated on
> current OS versions and takes away some vertical space. Maybe this
> can be made a user option?
I have no opinion about this, but patches are welcome, as always.
------------=_1764850742-19198-0--
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Rudolf =?UTF-8?Q?Adamkovi=C4=8D?= <rudolf@HIDDEN>
Subject: bug#79900: closed (Re: bug#79900: [PATCH] NS: Fix toolbar style
and position)
Message-ID: <handler.79900.D79900.176485072819168.notifdone <at> debbugs.gnu.org>
References: <868qfi1lut.fsf@HIDDEN> <m2zf89ch3m.fsf@HIDDEN>
X-Gnu-PR-Message: they-closed 79900
X-Gnu-PR-Package: emacs
X-Gnu-PR-Keywords: patch
Reply-To: 79900 <at> debbugs.gnu.org
Date: Thu, 04 Dec 2025 12:19:02 +0000
Content-Type: multipart/mixed; boundary="----------=_1764850742-19198-1"
This is a multi-part message in MIME format...
------------=_1764850742-19198-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
Your bug report
#79900: [PATCH] NS: Fix toolbar style and position
which was filed against the emacs package, has been closed.
The explanation is attached below, along with your original report.
If you require more details, please reply to 79900 <at> debbugs.gnu.org.
--=20
79900: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D79900
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems
------------=_1764850742-19198-1
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
Received: (at 79900-done) by debbugs.gnu.org; 4 Dec 2025 12:18:48 +0000
Received: from localhost ([127.0.0.1]:48135 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1vR8IK-0004z6-FE
for submit <at> debbugs.gnu.org; Thu, 04 Dec 2025 07:18:48 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:47670)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1vR8IH-0004yp-4n
for 79900-done <at> debbugs.gnu.org; Thu, 04 Dec 2025 07:18:46 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1vR8IB-00070D-1f; Thu, 04 Dec 2025 07:18:39 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
Date; bh=E8GWGjfM3T8n85CbDsI4ajdms8OSFCb0V2xL9OBY1ko=; b=JobsQDKhuNACfXijnrdG
QV0XT++3CurMxa8ehIaWkXg1b7C3gcrf+QRr1yW666PGsNYwg8/qD7MuxMfrKylmNHfO018LzRlO/
bDA5pm/3+eRfUO2jDHsdCPTKhEXrKmqWlYZNmlFa/VeRibJeMHpYTYvxtBvf9bfH7qErHD56SwoeY
hLZn6FXJU1WcEkWl5yqFjlweIS9/UoRlbqc/tA6Clr19jpOFdUVWefsnAuuQf7u8Iudyh4kn+xuhf
I/GC2JdkxNbNSOuhQKU2WwnHWIhp3R/KNZdcKHph2Te7UcVJ14oUBk5FJz+e1JFfvtFPx/LedYNrR
lctGVC6lJakS4Q==;
Date: Thu, 04 Dec 2025 14:18:34 +0200
Message-Id: <868qfi1lut.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Rudolf Schlatte <rudi@HIDDEN>
In-Reply-To: <m1a500ge0d.fsf@HIDDEN> (message from
Rudolf Schlatte on Wed, 03 Dec 2025 09:34:26 +0100)
Subject: Re: bug#79900: [PATCH] NS: Fix toolbar style and position
References: <m2zf89ch3m.fsf@HIDDEN> <86h5ud6pbm.fsf@HIDDEN>
<m1a500ge0d.fsf@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 79900-done
Cc: 79900-done <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: Rudolf Schlatte <rudi@HIDDEN>
> Date: Wed, 03 Dec 2025 09:34:26 +0100
>
> Eli Zaretskii <eliz@HIDDEN> writes:
>
> >> From: Rudolf Adamkovič <rudolf@HIDDEN>
> >> Date: Wed, 26 Nov 2025 09:50:53 +0100
> >>
> >> Mac OS 11 introduced compact toolbar styles and automatic styling of
> >> toolbars. As a result, the position and size of Emacs toolbars is now
> >> determined at runtime by Apple. No documentation exists as to how the
> >> toolbar style is determined. This patch fixes the toolbar style.
> >>
> >> Motivation:
> >>
> >> https://lists.gnu.org/archive/html/help-gnu-emacs/2025-11/msg00132.html
> >> https://lists.gnu.org/archive/html/help-gnu-emacs/2025-11/msg00147.html
> >
> > Thanks.
> >
> > Would users of Emacs on macOS please try this and provide feedback?
>
> The patch applies cleanly to master and does what it says, i.e., the
> toolbar icons show up in a separate area below the title bar instead of
> inside the title bar.
Thanks, now installed on the master branch, and closing the bug.
> Can't say that I like it, since it makes Emacs look outdated on
> current OS versions and takes away some vertical space. Maybe this
> can be made a user option?
I have no opinion about this, but patches are welcome, as always.
------------=_1764850742-19198-1
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
Received: (at submit) by debbugs.gnu.org; 26 Nov 2025 08:51:50 +0000
Received: from localhost ([127.0.0.1]:50459 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1vOBFe-00009c-2D
for submit <at> debbugs.gnu.org; Wed, 26 Nov 2025 03:51:50 -0500
Received: from lists.gnu.org ([2001:470:142::17]:52002)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <rudolf@HIDDEN>)
id 1vOBFZ-000095-Qs
for submit <at> debbugs.gnu.org; Wed, 26 Nov 2025 03:51:47 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <rudolf@HIDDEN>)
id 1vOBEs-0007zu-9Z
for bug-gnu-emacs@HIDDEN; Wed, 26 Nov 2025 03:51:11 -0500
Received: from fhigh-a7-smtp.messagingengine.com ([103.168.172.158])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <rudolf@HIDDEN>)
id 1vOBEp-0004SC-VR
for bug-gnu-emacs@HIDDEN; Wed, 26 Nov 2025 03:51:01 -0500
Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42])
by mailfhigh.phl.internal (Postfix) with ESMTP id 1A64E1400275
for <bug-gnu-emacs@HIDDEN>; Wed, 26 Nov 2025 03:50:57 -0500 (EST)
Received: from phl-mailfrontend-01 ([10.202.2.162])
by phl-compute-02.internal (MEProxy); Wed, 26 Nov 2025 03:50:57 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamkovic.org;
h=cc:content-type:content-type:date:date:from:from:in-reply-to
:message-id:mime-version:reply-to:subject:subject:to:to; s=fm2;
t=1764147057; x=1764233457; bh=t54ZAXV1KyFp8GgtaqFomQM6Tp71tLwZ
WpKP+EsngPo=; b=NpNEx2hudsMz1epb5U3PVuIXBZSoPiQT6Cf4duiAil8hmGff
AunC/tg8RAXmi2ikB6yErjkx0gP5KpRqvjlHQzggSOJkqzszZ1mzu7+wqIRzvRy3
d+bBIfurihvhPatlibbXymb/SETb7atdJyNkza0VaqdJJNKndkdCCtzkaex4Nbe8
+gC9onh2s7zlE8tYNGkd+9QTNrsjWYl/24aZv0QBTzljUG60Bi9oSisam3VMPC6P
30JFeqvetmzT/7Qs2ypGlVw1KQGpEeTya9tKAjFyUu4iNf3FHTyYEPbauILRQBbJ
vrZ6PI0yDY+tkFXibS6fQOqmoHTtirrHPi83dg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-type:content-type:date:date
:feedback-id:feedback-id:from:from:in-reply-to:message-id
:mime-version:reply-to:subject:subject:to:to:x-me-proxy
:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1764147057; x=
1764233457; bh=t54ZAXV1KyFp8GgtaqFomQM6Tp71tLwZWpKP+EsngPo=; b=K
rPyadtG32OI5QXmOuYWmDCoHFzHDe8nZAqxbmk2I5Igd/ewc7KfqYwiU8dAmuC4c
igynh5vLbg7/um9vcUxt6WnMvww9KcUKR+sjhO3kPJkPYf6DKFz15BLydJMr9Dl8
SGQLkYBXIU7DAFPx7ztZZovZ9PinyJGLWDO4+iQxm9xaph2j3XGSG8egciaJw5g1
ZN2KAGTTU/f/2HNkkhThAbOnCfn1pkHql3uyHbzRWnxsSG5J6Vpyr9qsOjYFjEes
TsD9QOZQrivRWXU/EggdnMBf6qIfnM1K3F6hTD1IlBh7PWLSn//5X190U57l/xOJ
TCi9JErLKJ6M4MKxhcfSA==
X-ME-Sender: <xms:cL8maTetkK3SkUQBGobprGPZGbY4A218YeWsvuWRJpu4iKVwnKe3gg>
<xme:cL8mafG7irW0MhjAeZiaQvabIsuu0prVQLj2EejBdv3dPCRWS3ZS17ocAmtNNmsmv
zdS0dh3FSf9QEHznbVCk6JyWQv9ycQ9Guc9T5YAgqrPbwyv9F4isA>
X-ME-Received: <xmr:cL8maXlYyTkPgsvdIgiN26pijuuwGUVFmz_YTMGqAxfNOEccgkJzRJH4JlFYckIOeuaQzW8nPM6hW-u3MUW-EFyQPxv2eS8>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvgeefledvucetufdoteggodetrf
dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu
rghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkgggtsehmtderredttdejne
cuhfhrohhmpeftuhguohhlfhcutegurghmkhhovhhitgcuoehruhguohhlfhesrggurghm
khhovhhitgdrohhrgheqnecuggftrfgrthhtvghrnhepueethfekleetfffggeeikeeftd
dtiefhleehleelvedugfefvdefffetgefhfeelnecuffhomhgrihhnpehgnhhurdhorhhg
necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprhhuug
holhhfsegruggrmhhkohhvihgtrdhorhhgpdhnsggprhgtphhtthhopedupdhmohguvgep
shhmthhpohhuthdprhgtphhtthhopegsuhhgqdhgnhhuqdgvmhgrtghssehgnhhurdhorh
hg
X-ME-Proxy: <xmx:cL8maRx2Y6R2bDQCGDlxsB1336-itgyl0kX_ljPk3NRxIx7KxCsYww>
<xmx:cL8maTTdaABMXWvp9mKyaZR32FEpyLNAfBp91wvdEaK0XMsS6k6gpA>
<xmx:cL8maUtoyM--NYNweCtva4qovuUt076vsWcGmJlFw3NSNWro5IXP3w>
<xmx:cL8maVu_UFY3v-s0JLPY8u720vi9KRnEONSgxAPHzKOXuIng_WX0yg>
<xmx:cb8maY-akV2JI7BvW6c3zAgzg52rUkKMFwdQ4WiKsVRhNXWgAb6WVPIA>
Feedback-ID: i88214938:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA for
<bug-gnu-emacs@HIDDEN>; Wed, 26 Nov 2025 03:50:56 -0500 (EST)
From: =?utf-8?Q?Rudolf_Adamkovi=C4=8D?= <rudolf@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: [PATCH] NS: Fix toolbar style and position
X-Debbugs-Cc:
Date: Wed, 26 Nov 2025 09:50:53 +0100
Message-ID: <m2zf89ch3m.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=103.168.172.158;
envelope-from=rudolf@HIDDEN; helo=fhigh-a7-smtp.messagingengine.com
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,
RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)
--=-=-=
Content-Type: text/plain
Tags: patch
Mac OS 11 introduced compact toolbar styles and automatic styling of
toolbars. As a result, the position and size of Emacs toolbars is now
determined at runtime by Apple. No documentation exists as to how the
toolbar style is determined. This patch fixes the toolbar style.
Motivation:
https://lists.gnu.org/archive/html/help-gnu-emacs/2025-11/msg00132.html
https://lists.gnu.org/archive/html/help-gnu-emacs/2025-11/msg00147.html
Rudy
In GNU Emacs 31.0.50 (build 8, aarch64-apple-darwin24.5.0, NS
appkit-2575.60 Version 15.5 (Build 24F74)) of 2025-11-26 built on
skynet.local
Repository revision: ead2fa8655003e40d2a9aa128c1b0477ff0a2970
Repository branch: master
Windowing system distributor 'Apple', version 10.3.2575
System Description: macOS 15.5
Configured using:
'configure --with-json --with-tree-sitter --with-sqlite3
--with-native-compilation=aot'
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=0001-NS-Fix-toolbar-style-and-position.patch
From 290676267ac3a43fa50b58a25918e20548eb87c8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rudolf=20Adamkovi=C4=8D?= <rudolf@HIDDEN>
Date: Wed, 26 Nov 2025 09:24:19 +0100
Subject: [PATCH] NS: Fix toolbar style and position
* src/nsterm.m ([EmacsWindow initWithEmacsFrame:fullscreen:screen:]):
Always show the toolbar below the window title. This is needed on Mac
OS 11+ where the toolbar style is decided by the system (which is
unpredictable) and the newfangled "compact" toolbar may be chosen (which
is undesirable).
---
src/nsterm.m | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/src/nsterm.m b/src/nsterm.m
index 74ee1219bbc..200b006d6fa 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -9562,6 +9562,13 @@ - (instancetype) initWithEmacsFrame: (struct frame *) f
#ifdef NS_IMPL_COCOA
if ([self respondsToSelector:@selector(setTabbingMode:)])
[self setTabbingMode:NSWindowTabbingModeDisallowed];
+#endif
+ /* Always show the toolbar below the window title. This is needed
+ on Mac OS 11+ where the toolbar style is decided by the system
+ (which is unpredictable) and the newfangled "compact" toolbar
+ may be chosen (which is undesirable). */
+#ifdef NS_IMPL_COCOA
+ [self setToolbarStyle: NSWindowToolbarStyleExpanded];
#endif
}
--
2.39.5 (Apple Git-154)
--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
--=20
"Genius is 1% inspiration and 99% perspiration."
--- Thomas Alva Edison, 1932
Rudolf Adamkovi=C4=8D <rudolf@HIDDEN> [he/him]
http://adamkovic.org
--=-=-=--
------------=_1764850742-19198-1--
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.