GNU bug report logs - #79914
[PATCH] (vc-dir-clean-files) Improve clarity of docstring and error

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Package: emacs; Reported by: Kristoffer Balintona <krisbalintona@HIDDEN>; Keywords: patch; Done: Sean Whitton <spwhitton@HIDDEN>; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 79914-done <at> debbugs.gnu.org:


Received: (at 79914-done) by debbugs.gnu.org; 30 Nov 2025 20:59:57 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 30 15:59:57 2025
Received: from localhost ([127.0.0.1]:42601 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1vPoWS-0002bR-Qp
	for submit <at> debbugs.gnu.org; Sun, 30 Nov 2025 15:59:57 -0500
Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]:54453)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <krisbalintona@HIDDEN>)
 id 1vPoWQ-0002b9-J2
 for 79914-done <at> debbugs.gnu.org; Sun, 30 Nov 2025 15:59:55 -0500
Received: by mail-lf1-x129.google.com with SMTP id
 2adb3069b0e04-596a055b1b8so3883871e87.0
 for <79914-done <at> debbugs.gnu.org>; Sun, 30 Nov 2025 12:59:54 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1764536388; x=1765141188; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:from:to:cc:subject:date:message-id:reply-to;
 bh=f91hG109mRd6ih4vS8XQhw7Mgt+zBzVh1gRseQNN3bg=;
 b=ROLifZiYYoLg1YVCOFUP+u1U+6jleodTMic30qE/e4w/ituPDWp+erZdSCIrcRzhV5
 diLUcxHTFa+myYAhUomccB8kSBTnBAeE7wRc16B8ZQNsjVr2IO7bQrvrzK7YApb0P25r
 f9BNKbJKPq1DStpuqyf2IzD8xUY24GelxNHpid2cx0G50PLakJt7XLGooc+fojIJMaOF
 BD8gEdqxrOkkYC9Sh2+E1Dt1JKzQozv2lIES15T76Pr5Q08MYjCmaA9L0lZokt9eQ1Sl
 MsSA8MyKUoY+EyXKHNMyPelGSjsqCaUNVBjA4y9c2YqyJxjmm0TKz3U7FuruYV4hT2Cd
 Tu6g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1764536388; x=1765141188;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=f91hG109mRd6ih4vS8XQhw7Mgt+zBzVh1gRseQNN3bg=;
 b=W+kGqjQMg7F00FLlsXFAXc0eF84Hc24PlDeDY0hrf41ULJ6sFlzH3lm52nrjEjIcac
 MryuuYLbUURhTxvYrMM+V/cLHgFOF2D1GUQMOY+a8uaI2NrVuz0qtxieb3KHYSDSBwVD
 kQn4WU6fSj+nqRZPC7lmDd4gGT/op0DgTsOobC2cjMSxdb7ukPPdiybQiC8un1b/WrYP
 FOCmQiFiTYEoeBRlLxMvKgMq7sfwlk+qaDYU4w9VaNxCERa6KceAdT+fUcSour8+Ks87
 Bw9g8ewFtgta14qvO3Z3f0D+qU1ixnGoivmmvmIc4mFUeS/sFoPSVMiQrLTEhHsAS0lb
 4TSQ==
X-Gm-Message-State: AOJu0YyPK3a+E7Y0aCwCKiyFdX05VWQgMvJiPva0oU3boB3aGPXLqIHE
 6x/uXU7pXSvzfSRoOGo82nX0nlkB6fncdr9LEm/RDxwvkdWNv3jzVP9fB3+39mnxNrxnU0oK8sp
 69Dx+eBRXQRKXeLG2EUTY6VbOinEyyHfkVQ==
X-Gm-Gg: ASbGncvi6wVW4V4IsgKBT3lX5fyVwEA/M52eNBZt5YLxTmXMy/mA0BeQJ6z+4HLlcbe
 Xa94VbklAVzA2SUQpkm5hYG13TwzJJFlhxy+X8GzXP2PumbZIK+5zk2xWDPJ1ZXIsR8HV4xSeLE
 Rm68Rch2VaYGjoS/kZ/jKhDEj73CUJz+wNliqfLgZxS3DdKcqCNU7HMeOZ2039mF0GNANyv1rSB
 FBFFlSeScc+QpEJmX8uOkim8uAAONFyyJAhT5ZGzIZyw+0Rvl5IlRwu14WGYF5H9pnEprU=
X-Google-Smtp-Source: AGHT+IH7lkV8nX1Z4xiN5vSyGCozdsMfSXM2jjtkk1LYq7YQUlCnV6mfzlFIxSL0HuFW0SB8NYC0ay8VKNpOnhfN7gs=
X-Received: by 2002:a05:6512:3b27:b0:592:f13e:c7d7 with SMTP id
 2adb3069b0e04-596a3ecf613mr11995670e87.20.1764536387854; Sun, 30 Nov 2025
 12:59:47 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Sun, 30 Nov 2025 15:59:47 -0500
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Sun, 30 Nov 2025 15:59:47 -0500
From: Kristoffer Balintona <krisbalintona@HIDDEN>
In-Reply-To: <87jyz71m4a.fsf@HIDDEN>
References: <CANVbq5=7ofV09cnsX__vPN+Li2DQG6tn4UBYDd66qknmmksisg@HIDDEN>
 <86jyz854ln.fsf@HIDDEN>
 <CANVbq5n-5E1y4Fo6XMPCbF0dPeLMnvW2reB4nOofEBf9c27L1g@HIDDEN>
 <87o6oj3dqf.fsf@HIDDEN> <86345v6440.fsf@HIDDEN>
 <87jyz71m4a.fsf@HIDDEN>
MIME-Version: 1.0
Date: Sun, 30 Nov 2025 15:59:47 -0500
X-Gm-Features: AWmQ_bnQX8SH7jPRHeQDFPZG0WkIPbdhRfJazRiu_JyV3srbIkgZEUD-aZ9bBVM
Message-ID: <CANVbq5m5s2HUEhT2mVkTi3ZGrHGeUfc5gCW38WogJe1q-Tdu4w@HIDDEN>
Subject: Re: bug#79914: [PATCH] (vc-dir-clean-files) Improve clarity of
 docstring and error
To: Sean Whitton <spwhitton@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 79914-done
Cc: 79914-done <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On Sun, Nov 30 2025, Sean Whitton wrote:

> Hello,
>
> On Sun 30 Nov 2025 at 03:29pm +02, Eli Zaretskii wrote:
>
>>> From: Sean Whitton <spwhitton@HIDDEN>
>>> Cc: Eli Zaretskii <eliz@HIDDEN>,  79914 <at> debbugs.gnu.org
>>> Date: Sun, 30 Nov 2025 12:29:44 +0000
>>>
>>> - first line of commit message should start with ';' for this kind of
>>>   change
>>>
>>> - I think "delete" is better than "clean" as the first word
>>>
>>> - The second and third sentences should be the other way around.  It's
>>>   better to finish describing the current command before referring to
>>>   another one, in general.
>>
>> Here's what I propose instead:
>>
>>    Delete from the repository the marked files, or the current file if no marks.
>>
>>  This command cleans unregistered files from the repository.  (To
>>  delete files that are registered, use `vc-dir-delete-file' instead.)
>>  It is therefore an error to use this command to delete files that are
>>  tracked by a VCS.
>
> Thanks, installed (Co-authored-by: Kristoffer) and closing the bug.

Thanks for both of your feedback.

-- 
Kind regards,
Kristoffer
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#79914; Package emacs. Full text available.

Message received at 79914-done <at> debbugs.gnu.org:


Received: (at 79914-done) by debbugs.gnu.org; 30 Nov 2025 17:11:46 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 30 12:11:45 2025
Received: from localhost ([127.0.0.1]:41156 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1vPkxd-00013D-FU
	for submit <at> debbugs.gnu.org; Sun, 30 Nov 2025 12:11:45 -0500
Received: from sendmail.purelymail.com ([34.202.193.197]:58456)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <spwhitton@HIDDEN>)
 id 1vPkxZ-00012t-5U
 for 79914-done <at> debbugs.gnu.org; Sun, 30 Nov 2025 12:11:43 -0500
DKIM-Signature: a=rsa-sha256;
 b=OiszbggsS2Rt8Rc0VpSkBlN/ayPEv2OWkGT+zrNh3T0dHb5e8ILUVECDoeZ7PnT0pm04GnCSBQtOyqEzTiEZVonEKj9PyqK3MeMiPKoSnX9LeXCMVOJxmjTlDoif3nsAa0X0TEB9+e+mJvtQfZydJfTAGXF/lr3VTYMbumvnai2G5tJRw2TN4dnZN3wJS6HosfyDxbgGtwwudoJkP/9HBNJc9zTa8KCN6dke3qyafa7979g9MbbIIobImNJn4+Dzoe0zlfH0eYS1LFvKpu3VMiTopGUZIU5sHJadk8dITp/JQVUjPMmvQZMKkALOKhUk1aad7ULV7XWhRrMJ87XQGQ==;
 s=purelymail2; d=spwhitton.name; v=1;
 bh=H2nYYH3juG1Lc7CKjy5wa9ksqMqu9hQYt8xHgC+AEMU=;
 h=Received:Received:From:To:Subject:Date; 
DKIM-Signature: a=rsa-sha256;
 b=NXafU6B08ZIxr1tS3CqMqQYkL14RGzIAwOuR95I0ezSvnGDzHarMGeHbGalfFY2v0e0RqIzKkm7ItwViHkBFHA+xfAyU06aqW1lxqeqegDTZsSeEmOYCTpw+Bih/DeUrFiIepns7ovjqDUwF2OXBR/U7yqRE3Lo9wWIQrTl+q+iBmMn4IvDqXIX5YXueWc4MumF8ryy7O5CVGMBQSCuiM0tZ3F6C2ui5JB4Y0g92oITm7rIOSfjrEhLdYK7eYfT/YDCx8UEJSSwGy//R06pIgrzRzNsUfuPASHK37ktJrcbMkT0jhyDEZiJ7rSQWPdb5xNTUR21D8Evi1F2Cfl7gKw==;
 s=purelymail2; d=purelymail.com; v=1;
 bh=H2nYYH3juG1Lc7CKjy5wa9ksqMqu9hQYt8xHgC+AEMU=;
 h=Feedback-ID:Received:Received:From:To:Subject:Date; 
Feedback-ID: 20115:3760:null:purelymail
X-Pm-Original-To: 79914-done <at> debbugs.gnu.org
Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -1740685167; 
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384);
 Sun, 30 Nov 2025 17:11:34 +0000 (UTC)
Received: by zephyr.silentflame.com (Postfix, from userid 1000)
 id 076639401A1; Sun, 30 Nov 2025 17:11:33 +0000 (GMT)
From: Sean Whitton <spwhitton@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#79914: [PATCH] (vc-dir-clean-files) Improve clarity of
 docstring and error
In-Reply-To: <86345v6440.fsf@HIDDEN>
References: <CANVbq5=7ofV09cnsX__vPN+Li2DQG6tn4UBYDd66qknmmksisg@HIDDEN>
 <86jyz854ln.fsf@HIDDEN>
 <CANVbq5n-5E1y4Fo6XMPCbF0dPeLMnvW2reB4nOofEBf9c27L1g@HIDDEN>
 <87o6oj3dqf.fsf@HIDDEN> <86345v6440.fsf@HIDDEN>
Date: Sun, 30 Nov 2025 17:11:33 +0000
Message-ID: <87jyz71m4a.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -1.0 (-)
X-Debbugs-Envelope-To: 79914-done
Cc: 79914-done <at> debbugs.gnu.org, krisbalintona@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.0 (--)

Hello,

On Sun 30 Nov 2025 at 03:29pm +02, Eli Zaretskii wrote:

>> From: Sean Whitton <spwhitton@HIDDEN>
>> Cc: Eli Zaretskii <eliz@HIDDEN>,  79914 <at> debbugs.gnu.org
>> Date: Sun, 30 Nov 2025 12:29:44 +0000
>>
>> - first line of commit message should start with ';' for this kind of
>>   change
>>
>> - I think "delete" is better than "clean" as the first word
>>
>> - The second and third sentences should be the other way around.  It's
>>   better to finish describing the current command before referring to
>>   another one, in general.
>
> Here's what I propose instead:
>
>    Delete from the repository the marked files, or the current file if no marks.
>
>  This command cleans unregistered files from the repository.  (To
>  delete files that are registered, use `vc-dir-delete-file' instead.)
>  It is therefore an error to use this command to delete files that are
>  tracked by a VCS.

Thanks, installed (Co-authored-by: Kristoffer) and closing the bug.

-- 
Sean Whitton
Notification sent to Kristoffer Balintona <krisbalintona@HIDDEN>:
bug acknowledged by developer. Full text available.
Reply sent to Sean Whitton <spwhitton@HIDDEN>:
You have taken responsibility. Full text available.

Message received at 79914 <at> debbugs.gnu.org:


Received: (at 79914) by debbugs.gnu.org; 30 Nov 2025 13:29:33 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 30 08:29:33 2025
Received: from localhost ([127.0.0.1]:38623 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1vPhUa-0004No-Kn
	for submit <at> debbugs.gnu.org; Sun, 30 Nov 2025 08:29:33 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:41588)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1vPhUY-0004ND-4X
 for 79914 <at> debbugs.gnu.org; Sun, 30 Nov 2025 08:29:30 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1vPhUS-0006B5-7e; Sun, 30 Nov 2025 08:29:24 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=0BxHTwksX7F0Eh+dVG44bdRQE5kCpvwZwRT6s+zaRUc=; b=Ez79PY1CtelK
 dVDOgLbN0fhzzY8ethf8gRRcuHqJEPmT/R9q+5fmm1dM14FASAYZmbgKqaaUXtd29yevsGk/TSJwK
 SJplObQRwmNc/Td23hoddga2rTFuIS6VMSRTbq/BkmAcA1lBcKh0AIVn+ay0Cg/t5YGUAazahor89
 1Lv9IzK0d4b5fmAK7n6aqV8voUWF6fEUszKyG9y+fuTrCwvIsjDasBGcI6ue2wV2z5NGdttqhJ3a6
 S8xAChAeR3yry/fl/XS7QUfpiYH4X11e9IP2+4G2V7F1mmQWyNN4bcYJrPRBzxDsRDDawJFS6ijhB
 w24Td1OqmuQoG211rF/wEw==;
Date: Sun, 30 Nov 2025 15:29:19 +0200
Message-Id: <86345v6440.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Sean Whitton <spwhitton@HIDDEN>
In-Reply-To: <87o6oj3dqf.fsf@HIDDEN> (message from Sean
 Whitton on Sun, 30 Nov 2025 12:29:44 +0000)
Subject: Re: bug#79914: [PATCH] (vc-dir-clean-files) Improve clarity of
 docstring and error
References: <CANVbq5=7ofV09cnsX__vPN+Li2DQG6tn4UBYDd66qknmmksisg@HIDDEN>
 <86jyz854ln.fsf@HIDDEN>
 <CANVbq5n-5E1y4Fo6XMPCbF0dPeLMnvW2reB4nOofEBf9c27L1g@HIDDEN>
 <87o6oj3dqf.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 79914
Cc: 79914 <at> debbugs.gnu.org, krisbalintona@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Sean Whitton <spwhitton@HIDDEN>
> Cc: Eli Zaretskii <eliz@HIDDEN>,  79914 <at> debbugs.gnu.org
> Date: Sun, 30 Nov 2025 12:29:44 +0000
> 
> - first line of commit message should start with ';' for this kind of
>   change
> 
> - I think "delete" is better than "clean" as the first word
> 
> - The second and third sentences should be the other way around.  It's
>   better to finish describing the current command before referring to
>   another one, in general.

Here's what I propose instead:

   Delete from the repository the marked files, or the current file if no marks.

 This command cleans unregistered files from the repository.  (To
 delete files that are registered, use `vc-dir-delete-file' instead.)
 It is therefore an error to use this command to delete files that are
 tracked by a VCS.
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#79914; Package emacs. Full text available.

Message received at 79914 <at> debbugs.gnu.org:


Received: (at 79914) by debbugs.gnu.org; 30 Nov 2025 12:29:54 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 30 07:29:54 2025
Received: from localhost ([127.0.0.1]:38262 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1vPgYs-0006OG-9I
	for submit <at> debbugs.gnu.org; Sun, 30 Nov 2025 07:29:54 -0500
Received: from sendmail.purelymail.com ([34.202.193.197]:49200)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <spwhitton@HIDDEN>)
 id 1vPgYp-0006Nx-L7
 for 79914 <at> debbugs.gnu.org; Sun, 30 Nov 2025 07:29:52 -0500
DKIM-Signature: a=rsa-sha256;
 b=gwMoKjo9xS8/7Dc+8t1MZ//pkzWkC9vvrYNkhObJ7JK2kbgV9mp8iiOzAG9yD1Plpgtr+xoGwzoA3C30Hl3MshJjRgm6h6z36EUj78mziNXSaXzteS4drKcCYE3JxSvKg0wUNyxar4mCa+dXz0h4mZQjGJIZ121O32kVeCtQNITSj6rH0vHPBC4R1hrqj0E7SEaQLnwszxfON0XiIiZN3pBN0WT9wP/+f5GWrJvuu8pY/LdoUyjx28qHQISm0aVcPbQWXtWuxGnKbbSJRNHNL2twjYkx/JBpQoFVKH5hAaF2XzP1BECFwt77YFj4OTS3IP36DKtdy5vra9i/BfF2iw==;
 s=purelymail2; d=spwhitton.name; v=1;
 bh=AkJVGqAxI/sdykO3ncNTt2oZPMxsPV7XOw465zi+/hs=;
 h=Received:Received:From:To:Subject:Date; 
DKIM-Signature: a=rsa-sha256;
 b=NtNcyR5AEV2dbqCAecQ9Uq06knBLS6xVdrYnVdq6A2RwXxy8sN2t49siZ5yMyFNoOw1BtKiG/gSiDnMrZGPZ64sMt438x5l7mld4dLQal2/o9FqILPdkC3swJAjPHaCNXEztjjfpIErW7FxuDcguw23erGwOIKE2BQKSBzKP+RXSf2aMB5c/SX8U62nLIGdEFWCLfJZ46IgQMae2uFJcg34rd7MF9imSRpF6/S5K+AFL9AUbhbTJqxNkKO3XUiEDbhnm2a1pALgl2VtneWOE40c2RPiAlsUPTqOKDY0PVwJoZqJ2BpghmxFC5UxCmBBmwjfrb/a7N507HcmiH+FrFA==;
 s=purelymail2; d=purelymail.com; v=1;
 bh=AkJVGqAxI/sdykO3ncNTt2oZPMxsPV7XOw465zi+/hs=;
 h=Feedback-ID:Received:Received:From:To:Subject:Date; 
Feedback-ID: 20115:3760:null:purelymail
X-Pm-Original-To: 79914 <at> debbugs.gnu.org
Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 384080962; 
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384);
 Sun, 30 Nov 2025 12:29:45 +0000 (UTC)
Received: by zephyr.silentflame.com (Postfix, from userid 1000)
 id BF38994082F; Sun, 30 Nov 2025 12:29:44 +0000 (GMT)
From: Sean Whitton <spwhitton@HIDDEN>
To: Kristoffer Balintona <krisbalintona@HIDDEN>
Subject: Re: bug#79914: [PATCH] (vc-dir-clean-files) Improve clarity of
 docstring and error
In-Reply-To: <CANVbq5n-5E1y4Fo6XMPCbF0dPeLMnvW2reB4nOofEBf9c27L1g@HIDDEN>
References: <CANVbq5=7ofV09cnsX__vPN+Li2DQG6tn4UBYDd66qknmmksisg@HIDDEN>
 <86jyz854ln.fsf@HIDDEN>
 <CANVbq5n-5E1y4Fo6XMPCbF0dPeLMnvW2reB4nOofEBf9c27L1g@HIDDEN>
Date: Sun, 30 Nov 2025 12:29:44 +0000
Message-ID: <87o6oj3dqf.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 79914
Cc: 79914 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hello,

On Sun 30 Nov 2025 at 02:44am -06, Kristoffer Balintona wrote:

> diff --git a/lisp/vc/vc-dir.el b/lisp/vc/vc-dir.el
> index ef5aa5dbda2..5dbe57c59f9 100644
> --- a/lisp/vc/vc-dir.el
> +++ b/lisp/vc/vc-dir.el
> @@ -999,9 +999,12 @@ that share the same state."
>    (vc-dir-at-event e (vc-dir-mark-unmark 'vc-dir-toggle-mark-file)))
>
>  (defun vc-dir-clean-files ()
> -  "Delete the marked files, or the current file if no marks.
> -The files will not be marked as deleted in the version control
> -system; see `vc-dir-delete-file'."
> +  "Clean marked unregistered files, or file at point if none are marked.
> +To delete files that are registered under the version control system,
> +use `vc-dir-delete-file' instead.
> +
> +If any of the selected files are tracked by the version control system,
> +signal an error and do not delete anything."
>    (interactive)
>    (let* ((files (or (vc-dir-marked-files)
>                      (list (vc-dir-current-file))))
> @@ -1011,8 +1014,8 @@ system; see `vc-dir-delete-file'."
>                                   'unregistered)))
>                        files)))
>      (when tracked
> -      (user-error (ngettext "Trying to clean tracked file: %s"
> -                            "Trying to clean tracked files: %s"
> +      (user-error (ngettext "Cannot clean tracked file: %s"
> +                            "Cannot clean tracked files: %s"
>                              (length tracked))
>                    (mapconcat #'file-name-nondirectory tracked ", ")))
>      (map-y-or-n-p "Delete %s? " #'delete-file files)

Thanks, these improvements are welcome.

Three comments from me:

- first line of commit message should start with ';' for this kind of
  change

- I think "delete" is better than "clean" as the first word

- The second and third sentences should be the other way around.  It's
  better to finish describing the current command before referring to
  another one, in general.

-- 
Sean Whitton
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#79914; Package emacs. Full text available.

Message received at 79914 <at> debbugs.gnu.org:


Received: (at 79914) by debbugs.gnu.org; 30 Nov 2025 09:53:39 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 30 04:53:39 2025
Received: from localhost ([127.0.0.1]:37115 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1vPe7e-0002Jd-Dv
	for submit <at> debbugs.gnu.org; Sun, 30 Nov 2025 04:53:38 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:54378)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1vPe7b-0002JI-BK
 for 79914 <at> debbugs.gnu.org; Sun, 30 Nov 2025 04:53:36 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1vPe7W-0002d7-2F; Sun, 30 Nov 2025 04:53:30 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=D4/bjRE3MoZh147W027Wi1lgM3gv/m/1gTdnlb2BLxU=; b=Ik2aB1cfc7f5
 QPohOwP2ra7GYYZL/lXHnWJpt1a6ElJguyWNTGDZWVdKS1VtuSlswr/XbwrjEAbnXdq6Ix44x1pk0
 kd1a7ZV4YaKKKl5V3jwbzPd/e3hAFKZVnQsQWdgqXu1KSiedMVkG7HEmO/wgIqrsNErSWTV3owcqD
 NyTyQROgBAb7Nxv6tZUjtkSr+J1+Ycq7Zzoya11fyR2SGQE4i0ynGvFNZ7teBxoQ37NiC25jQjgzn
 DuGEP0nvfv6PINFPd+GJTfwnRRIu2WCFv+o2hgSpvGOrC08Z4O0vGhlbl6tZTWSlGDPZJ/7KucCvK
 +feSh6IN5d/rgLyixLVJXQ==;
Date: Sun, 30 Nov 2025 11:53:26 +0200
Message-Id: <86fr9v6e3t.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Kristoffer Balintona <krisbalintona@HIDDEN>
In-Reply-To: <CANVbq5n-5E1y4Fo6XMPCbF0dPeLMnvW2reB4nOofEBf9c27L1g@HIDDEN>
 (message from Kristoffer Balintona on Sun, 30 Nov 2025 02:44:53 -0600)
Subject: Re: bug#79914: [PATCH] (vc-dir-clean-files) Improve clarity of
 docstring and error
References: <CANVbq5=7ofV09cnsX__vPN+Li2DQG6tn4UBYDd66qknmmksisg@HIDDEN>
 <86jyz854ln.fsf@HIDDEN>
 <CANVbq5n-5E1y4Fo6XMPCbF0dPeLMnvW2reB4nOofEBf9c27L1g@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 79914
Cc: 79914 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Kristoffer Balintona <krisbalintona@HIDDEN>
> Date: Sun, 30 Nov 2025 02:44:53 -0600
> Cc: 79914 <at> debbugs.gnu.org
> 
> On Sun, Nov 30 2025, Eli Zaretskii wrote:
> 
> >> From: Kristoffer Balintona <krisbalintona@HIDDEN>
> >> Date: Sun, 30 Nov 2025 01:12:59 -0600
> >>
> >> The docstring of `vc-dir-clean-files' has always confused me. I had to
> >> look at its function definition to understand it.
> >>
> >> The attached patch attempts to improve the clarity of its docstring and
> >> error message (when trying to delete registered files). Let me know if
> >> I've gotten the VCS terminology wrong.
> >>
> >>  (defun vc-dir-clean-files ()
> >> -  "Delete the marked files, or the current file if no marks.
> >> -The files will not be marked as deleted in the version control
> >> -system; see `vc-dir-delete-file'."
> >> +  "Delete unregistered files from disk.
> >
> > This first line of the doc string could tell more: it says nothing
> > about marked files, and doesn't mention the current file.  Please try
> > to improve this sentence; there's quite a lot free screen space to do
> > that.
> >
> > Also, how about using "clean" in the first sentence?  This would
> > probably make the command easier to remember.
> 
> Sure. Updated patch attached.
> 
> >> +Attempt to delete the marked files, or the file at point if none are
> >> +marked.  If any selected file is tracked by the version control system,
> >> +abort with an error.
> >
> > Why "attempt" if you already say that the files must be unregistered?
> 
> Fixed.
> 
> >> +To delete files registered under version control, use
> >> +`vc-dir-delete-file' instead."
> >
> > This should probably be the very second sentence of the doc string.
> 
> Okay. See updated patch.
> 
> In general, should remarks regarding failures/errors go at the end of
> docstrings?
> 
> >> @@ -1011,8 +1015,8 @@ system; see `vc-dir-delete-file'."
> >>                                   'unregistered)))
> >>                        files)))
> >>      (when tracked
> >> -      (user-error (ngettext "Trying to clean tracked file: %s"
> >> -                            "Trying to clean tracked files: %s"
> >> +      (user-error (ngettext "Trying to clean tracked file: %s.  Aborting"
> >> +                            "Trying to clean tracked files: %s.  Aborting"
> >>                              (length tracked))
> >>                    (mapconcat #'file-name-nondirectory tracked ", ")))
> >
> > I think the "Aborting" part is unnecessary, since the user-error we
> > signal already conveys that.  We don't say "aborting" in our error
> > messages, and for a good reason: that's redundant, given what Emacs
> > does when it signals an error.
> 
> I inserted that addition because for the first few times I called this
> command, I thought that error as a "progress" message: that the command
> had started doing its work (not that there was an error and it had
> stopped). At least for me, I think it was the phrasing of "Trying..."
> that gave me the impression that the command hadn't stopped.
> 
> What do you think about an error message like this instead:
>     "Cannot clean tracked files: FILES"
> To me, this firmly indicates that something has gone wrong and the
> command is not in-progress.

Yes, this message text is much better.

The patch now LGTM, but let's wait for Sean to chime in, in case he
has comments or suggestions.

Thanks.
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#79914; Package emacs. Full text available.

Message received at 79914 <at> debbugs.gnu.org:


Received: (at 79914) by debbugs.gnu.org; 30 Nov 2025 08:45:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 30 03:45:05 2025
Received: from localhost ([127.0.0.1]:36764 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1vPd3I-0006fr-EC
	for submit <at> debbugs.gnu.org; Sun, 30 Nov 2025 03:45:05 -0500
Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]:47168)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <krisbalintona@HIDDEN>)
 id 1vPd3F-0006eU-E1
 for 79914 <at> debbugs.gnu.org; Sun, 30 Nov 2025 03:45:02 -0500
Received: by mail-lf1-x130.google.com with SMTP id
 2adb3069b0e04-5942a631c2dso4803956e87.2
 for <79914 <at> debbugs.gnu.org>; Sun, 30 Nov 2025 00:45:01 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1764492294; x=1765097094; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:from:to:cc:subject:date:message-id:reply-to;
 bh=yJuzOcDqf58yciHpj4tUgZ56nE7Zz3F8eA4lWSbNq8Y=;
 b=Y6VFlbiNizWJt1P67Ts8HBBnbudtS1uJj/zFoCNslByjM/aykDgphHjxdvrrXwGElL
 R8lL/x5RF2frv7mqIF/ZTxCKz/yd5oGzEAnAbThxhrT9q0f/F0rc+cIqyq2AqRr1Vg7o
 rjxK9xu8YOWTptMIUuSo96D77RRn9+tMzkorG5vDPo95oCJT/SYS3T+HOSI+c1CZmAQF
 zTleMYr+JYfbuIaWW8QF7gI9bqlETIVgbHrU4HXrPsB7qRFfBtU4Z4AxdFmf3ISkOGGq
 33I1OG31n6LNyYHpWZ01wivkHgj4143ysvTtG4OQSEo6cdLaky0j9SLwXiPjRSXcJo7K
 5yzg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1764492294; x=1765097094;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=yJuzOcDqf58yciHpj4tUgZ56nE7Zz3F8eA4lWSbNq8Y=;
 b=TfcKQW9x5zL1W7slhJ3e89YhEvLjazIi9BDsY+T3V23rJWMYCFD0WL04meKJyndpSh
 58lizk4SoZAZpuBOrG5ulDcWTFPFjpiMfsNlzir23qKrN9rdxICa+Yx+CvLfxsP2kmbY
 9EpQxNnyVShHnG3Y0HkoTiElCEnjSZQFJUn/6dInLflX3bR2DhEvW2CFBpxcFF/tJj3b
 V1cfaUwfuOTNul+RizPwv+cTSHgMGKpRxsNLC2L+gjTxURVJdw80K9msdSdlYBrhUuls
 WOUGBLU5zG1X/zd6qXkOuYsQNUMjLj1oV4Pia++PDF4GkG9Nk3GX0+lK5o/SYBeRyMn5
 O/dw==
X-Gm-Message-State: AOJu0Yy3HIMMT1O0wDuVIujtSKUkmoErcFhiAfxwEukuHlKjl7x0sp5h
 12cRLqvaTr7/zmWgQ57zIHqxdEPNaGjGxlMwPSnWmvXG0jo2SzqkueLg8d7gZeeZ5n5HCVQ0k3T
 9rIPVwyfO8IVDWIGITEdrKr9KKsClqN0=
X-Gm-Gg: ASbGncsp5GK/jFr6dySc4+DWKBX2HK9plwRXVj+dUERkSeibU5HdqMQcgceHZY7xAE4
 qgvAdsRFbpLUKbPgI60hHXdKqa6Bc4a79l91HAiPM5y/DDPRBx/0+xH0GwjC54JK0NRjRf8VemL
 Co1CKzhrmMeiwTWtsWwGtG4grrH6swtLioMaI66ZVUfLruj+56eWN0OtV4Gyr8bxFq0Bl/pRWIV
 /MFMQqj2faBEWus8mYlqhS4ziORAX/vb0q3WDg+7VDnDxpVq2N8kl/rAWEbhMukYxD/RSM=
X-Google-Smtp-Source: AGHT+IGBLuT8zbUYhDOcYw84f1VCjvbUJct2Hnx1gH/bPhWSFFlDHnQ32i5DAqkZDEzZ3uDLTX64zqaXfPns/PqDcUo=
X-Received: by 2002:a05:6512:3d8b:b0:595:7f1c:29bb with SMTP id
 2adb3069b0e04-596a3eb3f5emr11010330e87.22.1764492294030; Sun, 30 Nov 2025
 00:44:54 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Sun, 30 Nov 2025 02:44:53 -0600
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Sun, 30 Nov 2025 02:44:53 -0600
From: Kristoffer Balintona <krisbalintona@HIDDEN>
In-Reply-To: <86jyz854ln.fsf@HIDDEN>
References: <CANVbq5=7ofV09cnsX__vPN+Li2DQG6tn4UBYDd66qknmmksisg@HIDDEN>
 <86jyz854ln.fsf@HIDDEN>
MIME-Version: 1.0
Date: Sun, 30 Nov 2025 02:44:53 -0600
X-Gm-Features: AWmQ_bmBwZ3kwTjy_QJCQldN-05ZkC22_EBcr6m2Ouu6l1Ywgui9wxMNnZfIcFE
Message-ID: <CANVbq5n-5E1y4Fo6XMPCbF0dPeLMnvW2reB4nOofEBf9c27L1g@HIDDEN>
Subject: Re: bug#79914: [PATCH] (vc-dir-clean-files) Improve clarity of
 docstring and error
To: Eli Zaretskii <eliz@HIDDEN>
Content-Type: multipart/mixed; boundary="000000000000651b0c0644cbe037"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 79914
Cc: 79914 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--000000000000651b0c0644cbe037
Content-Type: text/plain; charset="UTF-8"

On Sun, Nov 30 2025, Eli Zaretskii wrote:

>> From: Kristoffer Balintona <krisbalintona@HIDDEN>
>> Date: Sun, 30 Nov 2025 01:12:59 -0600
>>
>> The docstring of `vc-dir-clean-files' has always confused me. I had to
>> look at its function definition to understand it.
>>
>> The attached patch attempts to improve the clarity of its docstring and
>> error message (when trying to delete registered files). Let me know if
>> I've gotten the VCS terminology wrong.
>>
>>  (defun vc-dir-clean-files ()
>> -  "Delete the marked files, or the current file if no marks.
>> -The files will not be marked as deleted in the version control
>> -system; see `vc-dir-delete-file'."
>> +  "Delete unregistered files from disk.
>
> This first line of the doc string could tell more: it says nothing
> about marked files, and doesn't mention the current file.  Please try
> to improve this sentence; there's quite a lot free screen space to do
> that.
>
> Also, how about using "clean" in the first sentence?  This would
> probably make the command easier to remember.

Sure. Updated patch attached.

>> +Attempt to delete the marked files, or the file at point if none are
>> +marked.  If any selected file is tracked by the version control system,
>> +abort with an error.
>
> Why "attempt" if you already say that the files must be unregistered?

Fixed.

>> +To delete files registered under version control, use
>> +`vc-dir-delete-file' instead."
>
> This should probably be the very second sentence of the doc string.

Okay. See updated patch.

In general, should remarks regarding failures/errors go at the end of
docstrings?

>> @@ -1011,8 +1015,8 @@ system; see `vc-dir-delete-file'."
>>                                   'unregistered)))
>>                        files)))
>>      (when tracked
>> -      (user-error (ngettext "Trying to clean tracked file: %s"
>> -                            "Trying to clean tracked files: %s"
>> +      (user-error (ngettext "Trying to clean tracked file: %s.  Aborting"
>> +                            "Trying to clean tracked files: %s.  Aborting"
>>                              (length tracked))
>>                    (mapconcat #'file-name-nondirectory tracked ", ")))
>
> I think the "Aborting" part is unnecessary, since the user-error we
> signal already conveys that.  We don't say "aborting" in our error
> messages, and for a good reason: that's redundant, given what Emacs
> does when it signals an error.

I inserted that addition because for the first few times I called this
command, I thought that error as a "progress" message: that the command
had started doing its work (not that there was an error and it had
stopped). At least for me, I think it was the phrasing of "Trying..."
that gave me the impression that the command hadn't stopped.

What do you think about an error message like this instead:
    "Cannot clean tracked files: FILES"
To me, this firmly indicates that something has gone wrong and the
command is not in-progress.

> Thanks.

Thank you for your comments.

--000000000000651b0c0644cbe037
Content-Type: text/plain; charset="US-ASCII"
Content-Disposition: attachment
Content-Transfer-Encoding: base64
X-Attachment-Id: a0eb54b6ffe63820_0.2

Ci0tIApLaW5kIHJlZ2FyZHMsCktyaXN0b2ZmZXIK
--000000000000651b0c0644cbe037
Content-Type: text/x-patch; charset="US-ASCII"; 
	name="0001-vc-dir-clean-files-Improve-clarity-of-docstring-and-.patch"
Content-Disposition: attachment; 
	filename="0001-vc-dir-clean-files-Improve-clarity-of-docstring-and-.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: a0eb54b6ffe63820_0.1

RnJvbSA1NDE2OTVmNjU1NjY4MDE1YTc2ODNjYWI4MGI0NTVlMDVkNjAxNDEyIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBLcmlzdG9mZmVyIEJhbGludG9uYSA8a3Jpc2JhbGludG9uYUBn
bWFpbC5jb20+CkRhdGU6IFN1biwgMzAgTm92IDIwMjUgMDA6NDc6MDMgLTA2MDAKU3ViamVjdDog
W1BBVENIIDEvMV0gKHZjLWRpci1jbGVhbi1maWxlcykgSW1wcm92ZSBjbGFyaXR5IG9mIGRvY3N0
cmluZyBhbmQKIGVycm9yCgoqIGxpc3AvdmMvdmMtZGlyLmVsICh2Yy1kaXItY2xlYW4tZmlsZXMp
OiBNYWtlIGNsZWFyIGluCmRvY3N0cmluZyBhbmQgZXJyb3IgbWVzc2FnZSB0aGF0IHRoaXMgY29t
bWFuZCBpcyBvbmx5IGZvcgp1bnJlZ2lzdGVyZWQgZmlsZXMuCi0tLQogbGlzcC92Yy92Yy1kaXIu
ZWwgfCAxMyArKysrKysrKy0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspLCA1
IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvdmMvdmMtZGlyLmVsIGIvbGlzcC92Yy92
Yy1kaXIuZWwKaW5kZXggZWY1YWE1ZGJkYTIuLjVkYmU1N2M1OWY5IDEwMDY0NAotLS0gYS9saXNw
L3ZjL3ZjLWRpci5lbAorKysgYi9saXNwL3ZjL3ZjLWRpci5lbApAQCAtOTk5LDkgKzk5OSwxMiBA
QCB0aGF0IHNoYXJlIHRoZSBzYW1lIHN0YXRlLiIKICAgKHZjLWRpci1hdC1ldmVudCBlICh2Yy1k
aXItbWFyay11bm1hcmsgJ3ZjLWRpci10b2dnbGUtbWFyay1maWxlKSkpCiAKIChkZWZ1biB2Yy1k
aXItY2xlYW4tZmlsZXMgKCkKLSAgIkRlbGV0ZSB0aGUgbWFya2VkIGZpbGVzLCBvciB0aGUgY3Vy
cmVudCBmaWxlIGlmIG5vIG1hcmtzLgotVGhlIGZpbGVzIHdpbGwgbm90IGJlIG1hcmtlZCBhcyBk
ZWxldGVkIGluIHRoZSB2ZXJzaW9uIGNvbnRyb2wKLXN5c3RlbTsgc2VlIGB2Yy1kaXItZGVsZXRl
LWZpbGUnLiIKKyAgIkNsZWFuIG1hcmtlZCB1bnJlZ2lzdGVyZWQgZmlsZXMsIG9yIGZpbGUgYXQg
cG9pbnQgaWYgbm9uZSBhcmUgbWFya2VkLgorVG8gZGVsZXRlIGZpbGVzIHRoYXQgYXJlIHJlZ2lz
dGVyZWQgdW5kZXIgdGhlIHZlcnNpb24gY29udHJvbCBzeXN0ZW0sCit1c2UgYHZjLWRpci1kZWxl
dGUtZmlsZScgaW5zdGVhZC4KKworSWYgYW55IG9mIHRoZSBzZWxlY3RlZCBmaWxlcyBhcmUgdHJh
Y2tlZCBieSB0aGUgdmVyc2lvbiBjb250cm9sIHN5c3RlbSwKK3NpZ25hbCBhbiBlcnJvciBhbmQg
ZG8gbm90IGRlbGV0ZSBhbnl0aGluZy4iCiAgIChpbnRlcmFjdGl2ZSkKICAgKGxldCogKChmaWxl
cyAob3IgKHZjLWRpci1tYXJrZWQtZmlsZXMpCiAgICAgICAgICAgICAgICAgICAgIChsaXN0ICh2
Yy1kaXItY3VycmVudC1maWxlKSkpKQpAQCAtMTAxMSw4ICsxMDE0LDggQEAgc3lzdGVtOyBzZWUg
YHZjLWRpci1kZWxldGUtZmlsZScuIgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
J3VucmVnaXN0ZXJlZCkpKQogICAgICAgICAgICAgICAgICAgICAgIGZpbGVzKSkpCiAgICAgKHdo
ZW4gdHJhY2tlZAotICAgICAgKHVzZXItZXJyb3IgKG5nZXR0ZXh0ICJUcnlpbmcgdG8gY2xlYW4g
dHJhY2tlZCBmaWxlOiAlcyIKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAiVHJ5aW5nIHRv
IGNsZWFuIHRyYWNrZWQgZmlsZXM6ICVzIgorICAgICAgKHVzZXItZXJyb3IgKG5nZXR0ZXh0ICJD
YW5ub3QgY2xlYW4gdHJhY2tlZCBmaWxlOiAlcyIKKyAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAiQ2Fubm90IGNsZWFuIHRyYWNrZWQgZmlsZXM6ICVzIgogICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIChsZW5ndGggdHJhY2tlZCkpCiAgICAgICAgICAgICAgICAgICAobWFwY29uY2F0ICMn
ZmlsZS1uYW1lLW5vbmRpcmVjdG9yeSB0cmFja2VkICIsICIpKSkKICAgICAobWFwLXktb3Itbi1w
ICJEZWxldGUgJXM/ICIgIydkZWxldGUtZmlsZSBmaWxlcykKLS0gCjIuNTIuMAoK
--000000000000651b0c0644cbe037--
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#79914; Package emacs. Full text available.

Message received at 79914 <at> debbugs.gnu.org:


Received: (at 79914) by debbugs.gnu.org; 30 Nov 2025 08:04:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 30 03:04:15 2025
Received: from localhost ([127.0.0.1]:36446 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1vPcPm-00046o-RN
	for submit <at> debbugs.gnu.org; Sun, 30 Nov 2025 03:04:15 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:38946)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1vPcPk-00046U-QJ
 for 79914 <at> debbugs.gnu.org; Sun, 30 Nov 2025 03:04:13 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1vPcPf-0003Dq-FB; Sun, 30 Nov 2025 03:04:07 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=y8drO6NrNdkds5uhciO/YXe3pe0Tp7LaoTZyL89Hhac=; b=Hzp2aL2+S8JH
 gtBrlMe+Si3qRKsbgqADFbx+1KxZBd0WoNr8OkjrRKJ+w9MVtvHmXh5R0DUPrX2n1UDzpv7vMOf7S
 XA55DFJ4NILBXcoojzBAROzU63yJmUa0nTxcsIntXw22Nn2yaUMvWvxbwPxaghx/nEM7XXmxna9Ul
 ROC3q3f0dFZFaEma0xYjg078vR8PxILr+8MdY5MYug0yKpSu4gt+PojR1XJ+63+VVV4AYJUahmWq/
 2EsI59dZ1CGfDSx5GD0E3nSBHpcyB869W2YBcGXuH88lQLj4u/z9cmTohd1wyX1jlu9K7Q3/ZZEXd
 7xY+lYrmv4Qvu5oeHfjCqA==;
Date: Sun, 30 Nov 2025 10:04:04 +0200
Message-Id: <86jyz854ln.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Kristoffer Balintona <krisbalintona@HIDDEN>
In-Reply-To: <CANVbq5=7ofV09cnsX__vPN+Li2DQG6tn4UBYDd66qknmmksisg@HIDDEN>
 (message from Kristoffer Balintona on Sun, 30 Nov 2025 01:12:59 -0600)
Subject: Re: bug#79914: [PATCH] (vc-dir-clean-files) Improve clarity of
 docstring and error
References: <CANVbq5=7ofV09cnsX__vPN+Li2DQG6tn4UBYDd66qknmmksisg@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 79914
Cc: 79914 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Kristoffer Balintona <krisbalintona@HIDDEN>
> Date: Sun, 30 Nov 2025 01:12:59 -0600
> 
> The docstring of `vc-dir-clean-files' has always confused me. I had to
> look at its function definition to understand it.
> 
> The attached patch attempts to improve the clarity of its docstring and
> error message (when trying to delete registered files). Let me know if
> I've gotten the VCS terminology wrong.
> 
>  (defun vc-dir-clean-files ()
> -  "Delete the marked files, or the current file if no marks.
> -The files will not be marked as deleted in the version control
> -system; see `vc-dir-delete-file'."
> +  "Delete unregistered files from disk.

This first line of the doc string could tell more: it says nothing
about marked files, and doesn't mention the current file.  Please try
to improve this sentence; there's quite a lot free screen space to do
that.

Also, how about using "clean" in the first sentence?  This would
probably make the command easier to remember.

> +Attempt to delete the marked files, or the file at point if none are
> +marked.  If any selected file is tracked by the version control system,
> +abort with an error.

Why "attempt" if you already say that the files must be unregistered?

> +To delete files registered under version control, use
> +`vc-dir-delete-file' instead."

This should probably be the very second sentence of the doc string.

> @@ -1011,8 +1015,8 @@ system; see `vc-dir-delete-file'."
>                                   'unregistered)))
>                        files)))
>      (when tracked
> -      (user-error (ngettext "Trying to clean tracked file: %s"
> -                            "Trying to clean tracked files: %s"
> +      (user-error (ngettext "Trying to clean tracked file: %s.  Aborting"
> +                            "Trying to clean tracked files: %s.  Aborting"
>                              (length tracked))
>                    (mapconcat #'file-name-nondirectory tracked ", ")))

I think the "Aborting" part is unnecessary, since the user-error we
signal already conveys that.  We don't say "aborting" in our error
messages, and for a good reason: that's redundant, given what Emacs
does when it signals an error.

Thanks.
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#79914; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 30 Nov 2025 07:13:12 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 30 02:13:12 2025
Received: from localhost ([127.0.0.1]:36063 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1vPbcN-0006SH-Tm
	for submit <at> debbugs.gnu.org; Sun, 30 Nov 2025 02:13:12 -0500
Received: from lists.gnu.org ([2001:470:142::17]:45748)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <krisbalintona@HIDDEN>)
 id 1vPbcM-0006Rw-20
 for submit <at> debbugs.gnu.org; Sun, 30 Nov 2025 02:13:11 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <krisbalintona@HIDDEN>)
 id 1vPbcG-0001Aj-A7
 for bug-gnu-emacs@HIDDEN; Sun, 30 Nov 2025 02:13:04 -0500
Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <krisbalintona@HIDDEN>)
 id 1vPbcE-0003pO-G5
 for bug-gnu-emacs@HIDDEN; Sun, 30 Nov 2025 02:13:04 -0500
Received: by mail-lf1-x129.google.com with SMTP id
 2adb3069b0e04-5957753e0efso3505734e87.1
 for <bug-gnu-emacs@HIDDEN>; Sat, 29 Nov 2025 23:13:02 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1764486780; x=1765091580; darn=gnu.org;
 h=to:subject:message-id:date:mime-version:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=gt2ZC9Nlz97stZyBj0HQJURC8d5AOJ8ZkElMjsSy5ZM=;
 b=SBShXlTuOvT1fDhErc1qy1LQb+viPcC6ccyQcmU9cMYpBp6BxTLFd085HydKA4qK5H
 V9bvmDjkCmFZxFZPDiCRFOPZ7rtPeo5GsvLmj3zBoQt/3LRkk0+4Cy9Z282KixWWpRsE
 TTK+Lpa7jF4wY5EbzKNTubC03vflZ93fF9sG/T8eNHCHjooUkSwlF6CHJTa3eISGDsoH
 Nx7jzO4YYHEmj+W6TNJhrPXvQqF3c/U9UavkbP56XlTutJF5hCPPFuTaalCK87SsB+yr
 7dryObuoDvPLY4H1tjXckaLiygAITGho24y3accS3cRPtz6u31q5EwO7Utewh08pwbqs
 +AiA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1764486780; x=1765091580;
 h=to:subject:message-id:date:mime-version:from:x-gm-gg
 :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=gt2ZC9Nlz97stZyBj0HQJURC8d5AOJ8ZkElMjsSy5ZM=;
 b=m8wuNTBcut6t3ITapEDK0bk+xrsurTVbQKopAHPH9dXag/yY9/8+YBcbXzReHu0p4I
 9VKXkBlAEQlyQPibdhXeRTyKvvetxXWU1dDFTUThnTYFZmkR8guTBK/RqvWo/dHRNuuP
 m0k6HgykSOXI98/tdaJo17wl/R7V3tJwgP8QdF+gQNHKrf47919Th4YLTMruq+xChGFJ
 opRyJuHuaWkN6PSyHhUO+8GkKFLORGvWSyj/VdCXnajMKPDhLQdvEiuNHdWzk39Iem5Z
 GSeBd+5p/VtQPRZ4f+G89EeZ+J44HGLtCMN4wmFPv0AhGAhuLzsCivovCV9P8cu8Vnfo
 GagA==
X-Gm-Message-State: AOJu0YzwRnYqUGUlbaI4FCpszOYFKEWm14S+kHhHPBAlqGMJ/ECwemO+
 eWHzSWNXaBYHhedvxLNwXFsjqRKseRbOzmKMQd3CoRU0xewoC03Dcu/U6CKkTVXl2URxYGKu16y
 6hMRFpkev3CsUiSYoM29RAe0J+ny9RGOI7A==
X-Gm-Gg: ASbGncs+S9xlLUB11WutW/iLSqFn7Ay2Vha+SqhXwKpDoUmvUvv9HLey33lmgZfrCus
 ivsyknXODwORcVylxbgujbERRrWMzfPABZn+V+9dbMCOZanjman1+ocXEkfmc2O5HT/BpLEU5GH
 xulqhpd1bO00spyWKUikDK9dr++TU2gX/WRk0ROq5XT2xRmpnCjRzsvc7GLhm3j0wOF2X8NnVxP
 rN1xEQveiomnq++048GQW0t3gRHhhQ5SpoWKlg+BNvUcMGfKezUG8rnIwRS4DIw12cU9SQ=
X-Google-Smtp-Source: AGHT+IESl4ZeI0M3Sk1yiZTPWkdzk3dRnvYjJd3WmAP+BH30e5hbMnjcB0gpC9zjE2mXpgJDjfwsnkWfKnzgmVXNcOY=
X-Received: by 2002:a05:6512:110a:b0:595:7df4:6930 with SMTP id
 2adb3069b0e04-596a3ea666fmr11095670e87.8.1764486780152; Sat, 29 Nov 2025
 23:13:00 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Sun, 30 Nov 2025 01:12:59 -0600
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Sun, 30 Nov 2025 01:12:59 -0600
From: Kristoffer Balintona <krisbalintona@HIDDEN>
MIME-Version: 1.0
Date: Sun, 30 Nov 2025 01:12:59 -0600
X-Gm-Features: AWmQ_bnfJU89BtbCorsBXOoJJJqiOpUeH9ewGwlaclWjd0gny3iaN_Bh7GxX3Fw
Message-ID: <CANVbq5=7ofV09cnsX__vPN+Li2DQG6tn4UBYDd66qknmmksisg@HIDDEN>
Subject: [PATCH] (vc-dir-clean-files) Improve clarity of docstring and error
To: bug-gnu-emacs@HIDDEN
Content-Type: multipart/mixed; boundary="000000000000be08460644ca97f6"
Received-SPF: pass client-ip=2a00:1450:4864:20::129;
 envelope-from=krisbalintona@HIDDEN; helo=mail-lf1-x129.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

--000000000000be08460644ca97f6
Content-Type: text/plain; charset="UTF-8"

Tags: patch

Tags: patch

Hello,

The docstring of `vc-dir-clean-files' has always confused me. I had to
look at its function definition to understand it.

The attached patch attempts to improve the clarity of its docstring and
error message (when trying to delete registered files). Let me know if
I've gotten the VCS terminology wrong.


In GNU Emacs 31.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.49, cairo version 1.18.4)
Windowing system distributor 'Microsoft Corporation', version 11.0.12010000
System Description: Arch Linux

Configured using:
 'configure
 CONFIG_SHELL=/gnu/store/9pi8kah55s964qfik4cqysjdq74ll4sv-bash-minimal-5.2.37/bin/bash
 SHELL=/gnu/store/9pi8kah55s964qfik4cqysjdq74ll4sv-bash-minimal-5.2.37/bin/bash
 --prefix=/gnu/store/6w3c8fi1yvjahq0biv8bxjf0kgjzaici-emacs-master-31.0.50-1.11b68c6
 --enable-fast-install
 --docdir=/gnu/store/qk5y2mpib8qykghqff30lndjn6v5vvng-emacs-master-31.0.50-1.11b68c6-doc/share/doc/emacs-master-31.0.50
 --with-cairo --with-modules --with-native-compilation=aot 'CFLAGS=-g
 -O2 -Wno-error=incompatible-pointer-types' --disable-build-details'

--000000000000be08460644ca97f6
Content-Type: text/plain; charset="US-ASCII"
Content-Disposition: attachment
Content-Transfer-Encoding: base64
X-Attachment-Id: 8635ddc7892ea771_0.2

Ci0tIApLaW5kIHJlZ2FyZHMsCktyaXN0b2ZmZXIK
--000000000000be08460644ca97f6
Content-Type: text/x-patch; charset="US-ASCII"; 
	name="0001-vc-dir-clean-files-Improve-clarity-of-docstring-and-.patch"
Content-Disposition: attachment; 
	filename="0001-vc-dir-clean-files-Improve-clarity-of-docstring-and-.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: 8635ddc7892ea771_0.1

RnJvbSA0ZGFhZTIyMzhkM2VhNzkwMGVjOGI0YzRjY2UzZDc4YmY5N2E3NGVjIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBLcmlzdG9mZmVyIEJhbGludG9uYSA8a3Jpc2JhbGludG9uYUBn
bWFpbC5jb20+CkRhdGU6IFN1biwgMzAgTm92IDIwMjUgMDA6NDc6MDMgLTA2MDAKU3ViamVjdDog
W1BBVENIIDEvMV0gKHZjLWRpci1jbGVhbi1maWxlcykgSW1wcm92ZSBjbGFyaXR5IG9mIGRvY3N0
cmluZyBhbmQKIGVycm9yCgoqIGxpc3AvdmMvdmMtZGlyLmVsICh2Yy1kaXItY2xlYW4tZmlsZXMp
OiBNYWtlIGNsZWFyIGluCmRvY3N0cmluZyBhbmQgZXJyb3IgbWVzc2FnZSB0aGF0IHRoaXMgY29t
bWFuZCBpcyBvbmx5IGZvcgp1bnJlZ2lzdGVyZWQgZmlsZXMuCi0tLQogbGlzcC92Yy92Yy1kaXIu
ZWwgfCAxNCArKysrKysrKystLS0tLQogMSBmaWxlIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwg
NSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL3ZjL3ZjLWRpci5lbCBiL2xpc3AvdmMv
dmMtZGlyLmVsCmluZGV4IGVmNWFhNWRiZGEyLi41MmY5ZjUyMDhkZSAxMDA2NDQKLS0tIGEvbGlz
cC92Yy92Yy1kaXIuZWwKKysrIGIvbGlzcC92Yy92Yy1kaXIuZWwKQEAgLTk5OSw5ICs5OTksMTMg
QEAgdGhhdCBzaGFyZSB0aGUgc2FtZSBzdGF0ZS4iCiAgICh2Yy1kaXItYXQtZXZlbnQgZSAodmMt
ZGlyLW1hcmstdW5tYXJrICd2Yy1kaXItdG9nZ2xlLW1hcmstZmlsZSkpKQogCiAoZGVmdW4gdmMt
ZGlyLWNsZWFuLWZpbGVzICgpCi0gICJEZWxldGUgdGhlIG1hcmtlZCBmaWxlcywgb3IgdGhlIGN1
cnJlbnQgZmlsZSBpZiBubyBtYXJrcy4KLVRoZSBmaWxlcyB3aWxsIG5vdCBiZSBtYXJrZWQgYXMg
ZGVsZXRlZCBpbiB0aGUgdmVyc2lvbiBjb250cm9sCi1zeXN0ZW07IHNlZSBgdmMtZGlyLWRlbGV0
ZS1maWxlJy4iCisgICJEZWxldGUgdW5yZWdpc3RlcmVkIGZpbGVzIGZyb20gZGlzay4KK0F0dGVt
cHQgdG8gZGVsZXRlIHRoZSBtYXJrZWQgZmlsZXMsIG9yIHRoZSBmaWxlIGF0IHBvaW50IGlmIG5v
bmUgYXJlCittYXJrZWQuICBJZiBhbnkgc2VsZWN0ZWQgZmlsZSBpcyB0cmFja2VkIGJ5IHRoZSB2
ZXJzaW9uIGNvbnRyb2wgc3lzdGVtLAorYWJvcnQgd2l0aCBhbiBlcnJvci4KKworVG8gZGVsZXRl
IGZpbGVzIHJlZ2lzdGVyZWQgdW5kZXIgdmVyc2lvbiBjb250cm9sLCB1c2UKK2B2Yy1kaXItZGVs
ZXRlLWZpbGUnIGluc3RlYWQuIgogICAoaW50ZXJhY3RpdmUpCiAgIChsZXQqICgoZmlsZXMgKG9y
ICh2Yy1kaXItbWFya2VkLWZpbGVzKQogICAgICAgICAgICAgICAgICAgICAobGlzdCAodmMtZGly
LWN1cnJlbnQtZmlsZSkpKSkKQEAgLTEwMTEsOCArMTAxNSw4IEBAIHN5c3RlbTsgc2VlIGB2Yy1k
aXItZGVsZXRlLWZpbGUnLiIKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICd1bnJl
Z2lzdGVyZWQpKSkKICAgICAgICAgICAgICAgICAgICAgICBmaWxlcykpKQogICAgICh3aGVuIHRy
YWNrZWQKLSAgICAgICh1c2VyLWVycm9yIChuZ2V0dGV4dCAiVHJ5aW5nIHRvIGNsZWFuIHRyYWNr
ZWQgZmlsZTogJXMiCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgIlRyeWluZyB0byBjbGVh
biB0cmFja2VkIGZpbGVzOiAlcyIKKyAgICAgICh1c2VyLWVycm9yIChuZ2V0dGV4dCAiVHJ5aW5n
IHRvIGNsZWFuIHRyYWNrZWQgZmlsZTogJXMuICBBYm9ydGluZyIKKyAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAiVHJ5aW5nIHRvIGNsZWFuIHRyYWNrZWQgZmlsZXM6ICVzLiAgQWJvcnRpbmci
CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGxlbmd0aCB0cmFja2VkKSkKICAgICAgICAg
ICAgICAgICAgIChtYXBjb25jYXQgIydmaWxlLW5hbWUtbm9uZGlyZWN0b3J5IHRyYWNrZWQgIiwg
IikpKQogICAgIChtYXAteS1vci1uLXAgIkRlbGV0ZSAlcz8gIiAjJ2RlbGV0ZS1maWxlIGZpbGVz
KQotLSAKMi41Mi4wCgo=
--000000000000be08460644ca97f6--
Acknowledgement sent to Kristoffer Balintona <krisbalintona@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#79914; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sun, 30 Nov 2025 21:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.