GNU bug report logs - #79958
[PATCH] Eglot: more fine-grained customization of faces

Previous Next

To reply to this bug, email your comments to 79958 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lua Viana Reis <me <at> lua.blog.br>
To: bug-gnu-emacs <at> gnu.org, João Távora
 <joaotavora <at> gmail.com>
Subject: [PATCH] Eglot: more fine-grained customization of faces
Date: Sun,  7 Dec 2025 00:21:22 +0000 (UTC)

[Message part 1 (text/plain, inline)]

So far, this has more or less been requested three times:

https://github.com/lua-vr/eglot-semtok/issues/2
https://github.com/joaotavora/eglot/discussions/1557
https://github.com/joaotavora/eglot/issues/615#issuecomment-3612710124

This patch removes the eglot-semantic-token-{types,modifiers} in favor 
of a new variable eglot-semantic-token-faces. It is an alist with each 
element is of the form (FACE . NAMES). Eglot will apply all the FACEs 
whose list of NAMES are contained in the token's, in the order they 
appear in this list.

This allows:
- customizing priority of faces (just reorder the list)
- selecting specific combinations (say, add an element of the form 
`(highlight "variable" "definition")` to highlight tokens that are 
variable and definitions)
- removing faces (remove them from the list)

Other than allowing more customization, there is no change in the faces 
compared to before.


Lua

[0001-add-semantic-tokens-support-for-eglot.patch (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lua Viana Reis <me <at> lua.blog.br>
To: bug-gnu-emacs <at> gnu.org, João Távora
 <joaotavora <at> gmail.com>
Subject: Re: [PATCH] Eglot: more fine-grained customization of faces
Date: Sun,  7 Dec 2025 00:27:12 +0000 (UTC)

[Message part 1 (text/plain, inline)]

Sorry, I keep getting bitten by e-mail. I sent the wrong patch before.

Em 06/12/2025 21:21, Lua Viana Reis escreveu:
> So far, this has more or less been requested three times:
>
> https://github.com/lua-vr/eglot-semtok/issues/2
> https://github.com/joaotavora/eglot/discussions/1557
> https://github.com/joaotavora/eglot/issues/615#issuecomment-3612710124
>
> This patch removes the eglot-semantic-token-{types,modifiers} in favor 
> of a new variable eglot-semantic-token-faces. It is an alist with each 
> element is of the form (FACE . NAMES). Eglot will apply all the FACEs 
> whose list of NAMES are contained in the token's, in the order they 
> appear in this list.
>
> This allows:
> - customizing priority of faces (just reorder the list)
> - selecting specific combinations (say, add an element of the form 
> `(highlight "variable" "definition")` to highlight tokens that are 
> variable and definitions)
> - removing faces (remove them from the list)
>
> Other than allowing more customization, there is no change in the 
> faces compared to before.
>
>
> Lua

[0001-eglot-fine-grained-customization-of-semtok-faces.patch (text/x-patch, attachment)]

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lua Viana Reis <me <at> lua.blog.br>
To: bug-gnu-emacs <at> gnu.org, João Távora
 <joaotavora <at> gmail.com>
Subject: Re: [PATCH] Eglot: more fine-grained customization of faces
Date: Sun,  7 Dec 2025 01:41:55 +0000 (UTC)

[Message part 1 (text/plain, inline)]

As it turns out, eglot-semantic-token-{types,modifiers} should not be 
removed. I fixed the patch so they are kept.


Lua

[0001-eglot-fine-grained-customization-of-semtok-faces.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.