GNU bug report logs - #79970
[PATCH] hideshow: Rename 'hs-cycle-filter' to 'hs-TAB-toggling'.

Previous Next

To reply to this bug, email your comments to 79970 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] hideshow: Rename 'hs-cycle-filter' to 'hs-TAB-toggling'.
Date: Mon, 08 Dec 2025 17:44:56 -0600

[Message part 1 (text/plain, inline)]

Tags: patch

Since there is now a `hs-cycle` command, I think that `hs-cycle-filter`
has a name that could be misinterpreted as something related to
`hs-cycle`.  I propose changing the name to something like
`hs-TAB-toggling`.

[0001-hideshow-Rename-hs-cycle-filter-to-hs-TAB-toggling-..patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
- E.G via Gnus and Org.

Message #8 received at 79970 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Elijah Gabe Pérez <eg642616 <at> gmail.com>
Cc: 79970 <at> debbugs.gnu.org
Subject: Re: bug#79970: [PATCH] hideshow: Rename 'hs-cycle-filter' to
 'hs-TAB-toggling'.
Date: Tue, 09 Dec 2025 09:30:20 +0200

> Since there is now a `hs-cycle` command, I think that `hs-cycle-filter`
> has a name that could be misinterpreted as something related to
> `hs-cycle`.  I propose changing the name to something like
> `hs-TAB-toggling`.

This doesn't look like a good name with upper-case letters.

`hs-cycle-filter` was intended as a counterpart of
`outline-minor-mode-cycle-filter` that is used for
`outline-cycle` and `outline-cycle-buffer`.

And for hideshow `hs-cycle-filter` could be used for
`hs-cycle` as well.  The only advantage for TAB to be on
`hs-toggle-hiding` is because for the whole cycle
`hs-cycle` requires typing TAB three times whereas
`hs-toggle-hiding` only two.  So `hs-cycle` is required
for special cases.

Or maybe this should be customable?

Message #11 received at 79970 <at> debbugs.gnu.org (full text, mbox):

From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
To: Juri Linkov <juri <at> linkov.net>
Cc: 79970 <at> debbugs.gnu.org
Subject: Re: bug#79970: [PATCH] hideshow: Rename 'hs-cycle-filter' to
 'hs-TAB-toggling'.
Date: Wed, 10 Dec 2025 16:56:58 -0600

Juri Linkov <juri <at> linkov.net> writes:

>> Since there is now a `hs-cycle` command, I think that `hs-cycle-filter`
>> has a name that could be misinterpreted as something related to
>> `hs-cycle`.  I propose changing the name to something like
>> `hs-TAB-toggling`.
>
> This doesn't look like a good name with upper-case letters.
>
> `hs-cycle-filter` was intended as a counterpart of
> `outline-minor-mode-cycle-filter` that is used for
> `outline-cycle` and `outline-cycle-buffer`.

Oh, I didn't know that.  I don't use outline-minor-mode often, so I
wasn't aware of that.

> And for hideshow `hs-cycle-filter` could be used for
> `hs-cycle` as well.  The only advantage for TAB to be on
> `hs-toggle-hiding` is because for the whole cycle
> `hs-cycle` requires typing TAB three times whereas
> `hs-toggle-hiding` only two.  So `hs-cycle` is required
> for special cases.
>
> Or maybe this should be customable?

No, I think it's fine as it is.

So I think this bug can be closed.

-- 
- E.G via Gnus and Org.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.