GNU bug report logs - #79970
[PATCH] hideshow: Rename 'hs-cycle-filter' to 'hs-TAB-toggling'.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: Elijah Gabe Pérez <eg642616@HIDDEN>; Keywords: patch; Done: Juri Linkov <juri@HIDDEN>; Maintainer for emacs is bug-gnu-emacs@HIDDEN.
bug marked as fixed in version 31.0.50, send any further explanations to 79970 <at> debbugs.gnu.org and Elijah Gabe Pérez <eg642616@HIDDEN> Request was from Juri Linkov <juri@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 79970 <at> debbugs.gnu.org:


Received: (at 79970) by debbugs.gnu.org; 12 Dec 2025 07:32:36 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Dec 12 02:32:36 2025
Received: from localhost ([127.0.0.1]:53430 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1vTxdj-0003zy-M0
	for submit <at> debbugs.gnu.org; Fri, 12 Dec 2025 02:32:35 -0500
Received: from mout-p-202.mailbox.org ([80.241.56.172]:53370)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <juri@HIDDEN>)
 id 1vTxdg-0003zT-G5; Fri, 12 Dec 2025 02:32:34 -0500
Received: from smtp102.mailbox.org (smtp102.mailbox.org
 [IPv6:2001:67c:2050:b231:465::102])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4dSLkw4Pf7z9tfv;
 Fri, 12 Dec 2025 08:32:24 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linkov.net; s=MBO0001; 
 t=1765524744;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=BwFTo+paP50XGy5j/O6FD05H3Bo77JGqSMoJOfIbCaI=;
 b=RmiEzdUlSVnDWXVAoZFi4oaqIG1yTjtcqsed0KieVwkdBw81Utjere0nbQChwg/e+yPF/M
 myQHh/qM/UkCY+C6lFE3/wjxEd79q7/h+tQGGaei/6PQ9QDLXjKQYArLssCJfNqG5CfkTW
 1GMnteQLlu5gOxvrOSPYfmQqyjelImjky9vsV0Zku3dq5gRSokS94gU8xNZzhO/aVdu4th
 hsgN+Pj6b0rTPf0m51HeIwJ68Pi7lG2Ls7vpgMtqcZVzUu1ZMyt9OEpkJ8AMZcIywNg7RA
 z0Dv4JL4h21/2wPF475tNO7qUHCCVaHKnbcdSOYtuej8prlRmsWPheaII4nV9g==
Authentication-Results: outgoing_mbo_mout; dkim=none;
 spf=pass (outgoing_mbo_mout: domain of juri@HIDDEN designates
 2001:67c:2050:b231:465::102 as permitted sender)
 smtp.mailfrom=juri@HIDDEN
From: Juri Linkov <juri@HIDDEN>
To: Elijah Gabe =?iso-8859-1?Q?P=E9rez?= <eg642616@HIDDEN>
Subject: Re: bug#79970: [PATCH] hideshow: Rename 'hs-cycle-filter' to
 'hs-TAB-toggling'.
In-Reply-To: <877buu3pz9.fsf@HIDDEN>
Organization: LINKOV.NET
References: <87tsy0lerr.fsf@HIDDEN> <87a4zsunah.fsf@HIDDEN>
 <877buu3pz9.fsf@HIDDEN>
Date: Fri, 12 Dec 2025 09:31:31 +0200
Message-ID: <87fr9gcg18.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Rspamd-Queue-Id: 4dSLkw4Pf7z9tfv
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 79970
Cc: 79970 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

close 79970 31.0.50
thanks

>> Or maybe this should be customable?
>
> No, I think it's fine as it is.
>
> So I think this bug can be closed.

Ok, closed.  I added this to the docstring:

  Currently it affects only the command `hs-toggle-hiding' by default,
  but it can be easily replaced with the command `hs-cycle'.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#79970; Package emacs. Full text available.

Message received at 79970 <at> debbugs.gnu.org:


Received: (at 79970) by debbugs.gnu.org; 10 Dec 2025 22:57:20 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 10 17:57:20 2025
Received: from localhost ([127.0.0.1]:37719 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1vTT7X-0000Ef-SP
	for submit <at> debbugs.gnu.org; Wed, 10 Dec 2025 17:57:20 -0500
Received: from mail-oo1-xc43.google.com ([2607:f8b0:4864:20::c43]:44122)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <eg642616@HIDDEN>)
 id 1vTT7S-0000EH-T6
 for 79970 <at> debbugs.gnu.org; Wed, 10 Dec 2025 17:57:17 -0500
Received: by mail-oo1-xc43.google.com with SMTP id
 006d021491bc7-6574d7e451dso225726eaf.0
 for <79970 <at> debbugs.gnu.org>; Wed, 10 Dec 2025 14:57:14 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1765407429; x=1766012229; darn=debbugs.gnu.org;
 h=mime-version:message-id:date:references:in-reply-to:subject:cc:to
 :from:from:to:cc:subject:date:message-id:reply-to;
 bh=JelxgNvjzzWwfYDFtu0wnQixf1Ao6cRhWUxsjPQ8xlk=;
 b=ABgN1XlG/7e3WZ5QBYRAenwAamhcUIa2CrUAjD8/GcoJnPMJ+1toIQ7/hnfg1WlmWV
 q7pOC+vT+A23Yc6C/kf125WlJxU/TaAyRLvIBvvBZ1+80ygYw9LOSe5qUlTsiyUldKnI
 wwGXdzCX/zoBoxuTuZqmT0tqvuy4yTNW8tZSLM28DeGiJq75Wa5u9KdA0KK+e/fg/lbg
 rhLA3ji7NXcIXolAQ6jUKvclxP3RM+giFih8ESv1mCD6EAMe776eNZYfn/P2YaadpnOZ
 yX6TiTt/0e/alSYeQIs/fKekGiTKDSHQ6MCs20iBndV2VcmnLDcDG1XCahmfMhcuTKbP
 Nf9g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1765407429; x=1766012229;
 h=mime-version:message-id:date:references:in-reply-to:subject:cc:to
 :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=JelxgNvjzzWwfYDFtu0wnQixf1Ao6cRhWUxsjPQ8xlk=;
 b=W/Iq7kgBsc50EhvESFxZmq/BsGNiJ8iblcS5uJr8AWz2LYE0rUmhSZ6oyCJNWRHK+/
 XlQMbjFD5fOLC1BBzyRXwqwLLHwIq+OwSttaZAMl0SDkC4i/+3N6hVg5m4cWGymINHoQ
 pea5PEzZ5EsRU7btFUy/RmJJqGq6z9oVT9jIjQeQq1ZyAqbVYa2iLvTZLR5Qws2oZf8A
 OtofsA0WIo2j48n4hkRsRAxyam4tibaoQZeHKx7X0I//QSCp4hUP4EdbD1KkmAAXdlsU
 zZmbdgCikiOcwIwT1cXp6C9J6DIFOcG0mDpZpKbtqwb6L3CmeIcBXsFAKYWg/4ME0lGM
 cu7w==
X-Gm-Message-State: AOJu0Yzgp2cJF58KToEf0UnSNIIhMG3kX6gVRjaPD4XTH+XFy1hO12GE
 gLZRX2aqnLeVDlESXDfkKMDlgqn6TiDWiffNcYv9okhW+76uTVQq8wB0+7fZvGZq
X-Gm-Gg: ASbGncusqjpupseFXt2MP2f5fP9UyjRe9gLITMyuYVugt6o+8t5sZeZqVLSo7HSm2wC
 GafJdpkEfuVZjSyI5vYal1PXHItYB9TDc2gdp28rqUc5FqomahiNZQsi3y1WElfgOI43QHx6kBh
 KxaZN5USa1zGjPcG+fmk/JxDed1QJCNzvtZi48bun4h0g9bamdPJBgcp0x3/eVzEHHHclx+ErzI
 vj7b+d/BQMLjC0JMlPAtXU9jKhIcOswZeBjm57af5IuDCPbiNVKVuxwpY2J9+xADGARuAgpMQdq
 aoFSrGAAi7WR6rBciKVWBT42cNOyy0R2GgYb++xEuRZ7J2g5Dtu52WditlM74AiLz5tDU/5S89N
 KD8i8UT+2pvJwGj6Z+ofzTPaATAsq55QQJ10sQmVZpFy4E7KwOaDqSVYUHI3thcFCcm/0TARUUf
 Lu/mA2
X-Google-Smtp-Source: AGHT+IFCIoEPMuYhoxXTXtDoiioNwj2Yc87HZypvi5gSzdSR13ygdHcWNongueqn1hNjVaG4iOvpmg==
X-Received: by 2002:a05:6820:180e:b0:659:9a49:8f59 with SMTP id
 006d021491bc7-65b2abeca99mr2363403eaf.30.1765407428963; 
 Wed, 10 Dec 2025 14:57:08 -0800 (PST)
Received: from fedora ([189.215.164.221]) by smtp.gmail.com with ESMTPSA id
 006d021491bc7-65b35f4f923sm228769eaf.7.2025.12.10.14.57.08
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 10 Dec 2025 14:57:08 -0800 (PST)
From: =?utf-8?Q?Elijah_Gabe_P=C3=A9rez?= <eg642616@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
Subject: Re: bug#79970: [PATCH] hideshow: Rename 'hs-cycle-filter' to
 'hs-TAB-toggling'.
In-Reply-To: <87a4zsunah.fsf@HIDDEN>
References: <87tsy0lerr.fsf@HIDDEN> <87a4zsunah.fsf@HIDDEN>
Date: Wed, 10 Dec 2025 16:56:58 -0600
Message-ID: <877buu3pz9.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.3 (/)
X-Debbugs-Envelope-To: 79970
Cc: 79970 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)

Juri Linkov <juri@HIDDEN> writes:

>> Since there is now a `hs-cycle` command, I think that `hs-cycle-filter`
>> has a name that could be misinterpreted as something related to
>> `hs-cycle`.  I propose changing the name to something like
>> `hs-TAB-toggling`.
>
> This doesn't look like a good name with upper-case letters.
>
> `hs-cycle-filter` was intended as a counterpart of
> `outline-minor-mode-cycle-filter` that is used for
> `outline-cycle` and `outline-cycle-buffer`.

Oh, I didn't know that.  I don't use outline-minor-mode often, so I
wasn't aware of that.

> And for hideshow `hs-cycle-filter` could be used for
> `hs-cycle` as well.  The only advantage for TAB to be on
> `hs-toggle-hiding` is because for the whole cycle
> `hs-cycle` requires typing TAB three times whereas
> `hs-toggle-hiding` only two.  So `hs-cycle` is required
> for special cases.
>
> Or maybe this should be customable?

No, I think it's fine as it is.

So I think this bug can be closed.

-- 
- E.G via Gnus and Org.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#79970; Package emacs. Full text available.

Message received at 79970 <at> debbugs.gnu.org:


Received: (at 79970) by debbugs.gnu.org; 9 Dec 2025 07:39:08 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Dec 09 02:39:08 2025
Received: from localhost ([127.0.0.1]:51551 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1vSsJQ-0005gQ-5r
	for submit <at> debbugs.gnu.org; Tue, 09 Dec 2025 02:39:08 -0500
Received: from mout-p-103.mailbox.org ([2001:67c:2050:0:465::103]:58818)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1vSsJM-0005fV-Gd
 for 79970 <at> debbugs.gnu.org; Tue, 09 Dec 2025 02:39:05 -0500
Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4dQW1q51X3z9tNb;
 Tue,  9 Dec 2025 08:38:55 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linkov.net; s=MBO0001; 
 t=1765265935;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=RnJSOTUuzGvTC6aYCABVN2OT4pA4PbNq3ulfrbyN/Qo=;
 b=z0BLxImA32susuzq+CxpSdoIvVek3V2mejgQmimozr2Ij03emHKLZ3TT2o8r0yAsqxwm6K
 bEYPh9YVgTiSAohI4r1+VZmgYzhEr+zuO93NQL0eqIW24Rpe4qH0oteZ8ZiBnAFA0OiKJz
 P3G7N4ZM5cJER71oRBvkJrOlzp0uZH5eFegnCykN6HLc7nSJnGGBJ11Rm8N06IFO5b8mkG
 lEvYyDAumtGWbPEfQ4Sd9XQxoXLERSbmWUTQx+JUfsGIpdFwUiSn234WZw325Jaw1lh9/H
 bQwlOZIZ4fJOEouqSlMHSK+lei/jaYuLP7kDbwHYcUVi53CwAWjTWr+Fxp4rLQ==
From: Juri Linkov <juri@HIDDEN>
To: Elijah Gabe =?iso-8859-1?Q?P=E9rez?= <eg642616@HIDDEN>
Subject: Re: bug#79970: [PATCH] hideshow: Rename 'hs-cycle-filter' to
 'hs-TAB-toggling'.
In-Reply-To: <87tsy0lerr.fsf@HIDDEN>
Organization: LINKOV.NET
References: <87tsy0lerr.fsf@HIDDEN>
Date: Tue, 09 Dec 2025 09:30:20 +0200
Message-ID: <87a4zsunah.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 79970
Cc: 79970 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

> Since there is now a `hs-cycle` command, I think that `hs-cycle-filter`
> has a name that could be misinterpreted as something related to
> `hs-cycle`.  I propose changing the name to something like
> `hs-TAB-toggling`.

This doesn't look like a good name with upper-case letters.

`hs-cycle-filter` was intended as a counterpart of
`outline-minor-mode-cycle-filter` that is used for
`outline-cycle` and `outline-cycle-buffer`.

And for hideshow `hs-cycle-filter` could be used for
`hs-cycle` as well.  The only advantage for TAB to be on
`hs-toggle-hiding` is because for the whole cycle
`hs-cycle` requires typing TAB three times whereas
`hs-toggle-hiding` only two.  So `hs-cycle` is required
for special cases.

Or maybe this should be customable?




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#79970; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 8 Dec 2025 23:45:12 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Dec 08 18:45:12 2025
Received: from localhost ([127.0.0.1]:49365 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1vSkul-0003R2-M4
	for submit <at> debbugs.gnu.org; Mon, 08 Dec 2025 18:45:12 -0500
Received: from lists.gnu.org ([2001:470:142::17]:53864)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <eg642616@HIDDEN>)
 id 1vSkui-0003QB-Gv
 for submit <at> debbugs.gnu.org; Mon, 08 Dec 2025 18:45:09 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eg642616@HIDDEN>)
 id 1vSkuc-0003TG-GF
 for bug-gnu-emacs@HIDDEN; Mon, 08 Dec 2025 18:45:02 -0500
Received: from mail-oa1-x42.google.com ([2001:4860:4864:20::42])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <eg642616@HIDDEN>)
 id 1vSkua-00057W-Ma
 for bug-gnu-emacs@HIDDEN; Mon, 08 Dec 2025 18:45:02 -0500
Received: by mail-oa1-x42.google.com with SMTP id
 586e51a60fabf-3ec46e3c65bso4417589fac.0
 for <bug-gnu-emacs@HIDDEN>; Mon, 08 Dec 2025 15:45:00 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1765237499; x=1765842299; darn=gnu.org;
 h=mime-version:message-id:date:subject:to:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=9DYEzcPBV0ZfKEkPRoV5wGWu79YSjWfyZnKq7s1MXRA=;
 b=FCS2iEivUghelC7abdzooYhibHSKKJI+fISHGNfoAgkVjwn5KYqR8UhV4mE7j47vru
 6RUZt/+0Oytes3UFjDNFi45rvdbFtX+/J2metNyasnfKOQYo0q1XDDlEo2xdcHnk1V+f
 MQMPw24625VGClJJIFhJtV9MBBUmTYm2HwKQVEW2WT3ZS8Mn2eSH4e3IL/dhk8bNB5nG
 VsJOOm6m+mhrkYpZY8OYaPbkmue4+jyBVGQkb/16ENGlvE0T0cbfg0Pmy9YX9AoktDIJ
 pTJASzofQxi/kB60PfDkpS7AfdNbZjkgb4rzeFIixtqkzbaqYTlxNRV42fpDIrQKr7E+
 da8w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1765237499; x=1765842299;
 h=mime-version:message-id:date:subject:to:from:x-gm-gg
 :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=9DYEzcPBV0ZfKEkPRoV5wGWu79YSjWfyZnKq7s1MXRA=;
 b=o1C4RnjQzPLki1twcbx0ELPYv0f8RCFfhybScfJ2uLAHIV0KDnCphVAAAAyKR3KX7n
 Q2f9xDzJYRztNtz3GIv7TIHRMQFwMRZHpF94AUTfkF1wxN2MSkiVJDVY2rMtn09XL9Dd
 VUBvlxICRLuM+euNEZUZZrygSKMYFGttg0mZzmiOjST0YBFROKC2PgS/WuiRQA780Eol
 xEYQguCox8K1XFvr4shqAdP2JTWy6El4kTr1N7xFLUNgOJqBBFkOXN39I8CYLrzlnwX3
 HRxtTQTRkY5PUu4JzqbqdgvbxfVeP5V1ZI/M+ry0S3aXDYD4fuA9qT500Izj285+E1PX
 qusA==
X-Gm-Message-State: AOJu0YzufCLUqD39txzJU+5ET3KYzH4QqHIMX5ommlqCdhOwo7PjeEXN
 4pqAg+ce71U9h6BbCms86R9VJ052CUoQpnlSXJI4hKBg5zG2rqLBn8TSlRpekDJp
X-Gm-Gg: ASbGncsKmDhA7uO5E+c7XyhgBuUQlAX54pPP5R/n8bLcwF3fT1GWHaZJOvlQ+2Grrx4
 2F8oFGXkvHE28WNRxDwLiNfIhyMXq2yKQjWbkQnKC+hu1wgc3BeUgNLU+7TeBSdVsZrMyUMRDWg
 RsJCI5lEikysmDKsYW2tNDDHvvHV83SxgKYXLPOMxDATNvXvvfovt0Mx5SQsJgnx2zEiyF+w6nL
 Gk8wlMekj6JDryYBTzrcouz18OS3JD1o0R9wOlaCQIB11yisO4q+wlLL/8GNmgY6Ebgy9vwJ2hx
 ONCpFRiSwbVyVcJdmhJAUFqHdwRFRz2qwHhAMmm1BG53Bg/tz+PBMwwWjTa4B4Mz/irHeWt/ZUg
 ZAfcjRmQh+3BPVShYLpijqensmCKC3/XNdyMXCy/9mp48G39WgifU3qYSg4+iClSMU08uTvjYB0
 JYEZpx
X-Google-Smtp-Source: AGHT+IGdk7lLii70c/jq2LY7NSOx7B0tPIEsHMMRK9lFhki0nBeonKFntcH8QYk3eMUPuo5UllxK2A==
X-Received: by 2002:a05:6870:a50c:b0:3f5:4172:12a with SMTP id
 586e51a60fabf-3f544084737mr4186193fac.59.1765237498718; 
 Mon, 08 Dec 2025 15:44:58 -0800 (PST)
Received: from fedora ([189.215.160.233]) by smtp.gmail.com with ESMTPSA id
 586e51a60fabf-3f50aa30042sm10048039fac.4.2025.12.08.15.44.57
 for <bug-gnu-emacs@HIDDEN>
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 08 Dec 2025 15:44:58 -0800 (PST)
From: =?utf-8?Q?Elijah_Gabe_P=C3=A9rez?= <eg642616@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: [PATCH] hideshow: Rename 'hs-cycle-filter' to 'hs-TAB-toggling'.
Date: Mon, 08 Dec 2025 17:44:56 -0600
Message-ID: <87tsy0lerr.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=2001:4860:4864:20::42;
 envelope-from=eg642616@HIDDEN; helo=mail-oa1-x42.google.com
X-Spam_score_int: -17
X-Spam_score: -1.8
X-Spam_bar: -
X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  Tags: patch Since there is now a `hs-cycle` command, I think
 that `hs-cycle-filter` has a name that could be misinterpreted as something
 related to `hs-cycle`. I propose changing the name to something like `hs-TA
 [...] Content analysis details:   (1.2 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at https://www.dnswl.org/,
 no trust [2001:470:142:0:0:0:0:17 listed in] [list.dnswl.org]
 1.0 SPF_SOFTFAIL           SPF: sender does not match SPF record (softfail)
 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends
 in digit (eg642616[at]gmail.com)
 0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
 provider (eg642616[at]gmail.com)
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.2 (/)

--=-=-=
Content-Type: text/plain

Tags: patch

Since there is now a `hs-cycle` command, I think that `hs-cycle-filter`
has a name that could be misinterpreted as something related to
`hs-cycle`.  I propose changing the name to something like
`hs-TAB-toggling`.


--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
 filename=0001-hideshow-Rename-hs-cycle-filter-to-hs-TAB-toggling-..patch

From d0e9b4214a42ac37779dac81f413fcd4210d213e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?El=C3=ADas=20Gabriel=20P=C3=A9rez?= <eg642616@HIDDEN>
Date: Mon, 8 Dec 2025 16:12:06 -0600
Subject: [PATCH] hideshow: Rename 'hs-cycle-filter' to 'hs-TAB-toggling'. 
 (Bug#)

* doc/emacs/programs.texi (Hideshow):
* etc/NEWS:
* lisp/progmodes/hideshow.el (hs-cycle-filter):
(hs-minor-mode-map): Rename 'hs-cycle-filter'.
---
 doc/emacs/programs.texi    |  4 ++--
 etc/NEWS                   |  2 +-
 lisp/progmodes/hideshow.el | 10 +++++-----
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/doc/emacs/programs.texi b/doc/emacs/programs.texi
index 6acd04d0bae..a5d428392db 100644
--- a/doc/emacs/programs.texi
+++ b/doc/emacs/programs.texi
@@ -1742,7 +1742,7 @@ Hideshow
 @vindex hs-indicator-maximum-buffer-size
 @vindex hs-isearch-open
 @vindex hs-hide-block-behavior
-@vindex hs-cycle-filter
+@vindex hs-TAB-toggling
   These variables can be used to customize Hideshow mode:
 
 @table @code
@@ -1780,7 +1780,7 @@ Hideshow
 disabled; the value of @code{nil} will activate the indicators
 regardless of the buffer size.
 
-@item hs-cycle-filter
+@item hs-TAB-toggling
 This variable controls where on the line with hideable blocks typing the
 @kbd{@key{TAB}} key will cycle the visibility of the blocks.  Depending
 on its non-@code{nil} value, @key{TAB} can be active on different parts
diff --git a/etc/NEWS b/etc/NEWS
index 45c1d2865f1..f7d26ed550a 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -1157,7 +1157,7 @@ which the current line belongs.  If set to 'after-cursor', hide the block
 after cursor position.  By default this is set to 'after-bol'.
 
 +++
-*** New user option 'hs-cycle-filter' for visibility-cycling with 'TAB'.
+*** New user option 'hs-TAB-toggling' for visibility-cycling with 'TAB'.
 This user option controls the positions on the headline of hideable blocks
 where the 'TAB' key cycles the blocks' visibility.
 
diff --git a/lisp/progmodes/hideshow.el b/lisp/progmodes/hideshow.el
index 886bd7505aa..f510241a804 100644
--- a/lisp/progmodes/hideshow.el
+++ b/lisp/progmodes/hideshow.el
@@ -106,7 +106,7 @@
 ;;   Max buffer size in bytes where the indicators should be enabled.
 ;; - `hs-allow-nesting'
 ;;   If non-nil, hiding remembers internal blocks.
-;; - `hs-cycle-filter'
+;; - `hs-TAB-toggling'
 ;;   Control where typing a `TAB' cycles the visibility.
 ;;
 ;; The variable `hs-hide-all-non-comment-function' may be useful if you
@@ -430,7 +430,7 @@ hs-set-up-overlay
   :type 'function
   :version "28.1")
 
-(defcustom hs-cycle-filter nil
+(defcustom hs-TAB-toggling nil
   "Control where typing a \\`TAB' cycles the visibility.
 This option determines on which parts of a line where a block
 begins \\`TAB' will be bound to visibility-cycling commands such
@@ -527,13 +527,13 @@ hs-minor-mode-map
           "" hs-toggle-hiding
           :filter
           ,(lambda (cmd)
-             (when (and hs-cycle-filter
+             (when (and hs-TAB-toggling
                         ;; On the headline with hideable blocks
                         (save-excursion
                           (forward-line 0)
                           (hs-get-first-block-on-line))
-                        (or (not (functionp hs-cycle-filter))
-                            (funcall hs-cycle-filter)))
+                        (or (not (functionp hs-TAB-toggling))
+                            (funcall hs-TAB-toggling)))
                cmd)))
   "<left-fringe> <mouse-1>" #'hs-indicator-mouse-toggle-hiding)
 
-- 
2.52.0


--=-=-=
Content-Type: text/plain


-- 
- E.G via Gnus and Org.

--=-=-=--




Acknowledgement sent to Elijah Gabe Pérez <eg642616@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#79970; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Fri, 12 Dec 2025 07:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.