GNU bug report logs - #79977
[PATCH] ; etc/NEWS: Fix unbalanced parentheses

Previous Next

To reply to this bug, email your comments to 79977 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Rudolf Adamkovič <rudolf <at> adamkovic.org>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] ; etc/NEWS: Fix unbalanced parentheses
Date: Tue, 09 Dec 2025 15:17:39 +0100

[Message part 1 (text/plain, inline)]

Tags: patch

Howdy, hackers!

Today, I decided to investigate why `submit-emacs-patch' is messed up in
my Emacs, and what I found is interesting.  The TL;DR is that Paredit is
the culprit, but it seems that `submit-emacs-patch' is at fault.

Here is what happens:
  
  1. `submit-emacs-patch' calls `lm-maintainers' on `etc/NEWS'
  2. `lm-maintainers' calls `lm-with-file'
  3. `lm-with-file' activates `emacs-lisp-mode'
  4. `emacs-lisp-mode' activates `paredit-mode'
  5. `paredit-mode' calls `check-parens'
  6. `check-parens' errors out and leaves cursor on the error
  7. back in `submit-emacs-patch', the mail is messed up

I am attaching a patch that fixes unbalanced parentheses in `etc/NEWS'.

P.S. While my patch makes it possible for Paredit users to use
`submit-emacs-patch', it would be nice if `submit-emacs-patch' called
`lm-maintainers' only on files that contain valid Emacs Lisp code.

Rudy

In GNU Emacs 31.0.50 (build 1, aarch64-apple-darwin24.5.0, NS
 appkit-2575.60 Version 15.5 (Build 24F74)) of 2025-12-03 built on
 skynet.local
Repository revision: 669f0f4ff1970cb685ba0a3121110047cf9e44a3
Repository branch: master
Windowing system distributor 'Apple', version 10.3.2575
System Description:  macOS 15.5

Configured using:
 'configure --with-json --with-tree-sitter --with-sqlite3
 --with-native-compilation=aot'

[0001-etc-NEWS-Fix-unbalanced-parentheses.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
"Be especially critical of any statement following the word
'obviously.'"

--- Anna Pell Wheeler, 1883-1966

Rudolf Adamkovič <rudolf <at> adamkovic.org> [he/him]
http://adamkovic.org

Message #8 received at 79977 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Rudolf Adamkovič <rudolf <at> adamkovic.org>
Cc: 79977 <at> debbugs.gnu.org
Subject: Re: bug#79977: [PATCH] ; etc/NEWS: Fix unbalanced parentheses
Date: Tue, 09 Dec 2025 16:35:22 +0100

Rudolf Adamkovič <rudolf <at> adamkovic.org> writes:

> Howdy, hackers!

Hi Rudy,

> I am attaching a patch that fixes unbalanced parentheses in `etc/NEWS'.

Thanks, I've pushed your patch to master.

> P.S. While my patch makes it possible for Paredit users to use
> `submit-emacs-patch', it would be nice if `submit-emacs-patch' called
> `lm-maintainers' only on files that contain valid Emacs Lisp code.

I keep the bug open for this problem.

> Rudy

Best regards, Michael.

Message #11 received at 79977 <at> debbugs.gnu.org (full text, mbox):

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: Rudolf Adamkovič <rudolf <at> adamkovic.org>
Cc: 79977 <at> debbugs.gnu.org, Michael Albinus <michael.albinus <at> gmx.de>
Subject: Re: bug#79977: [PATCH] ; etc/NEWS: Fix unbalanced parentheses
Date: Tue, 09 Dec 2025 19:18:16 +0000

Hello,

Thanks both for fixing my typo, here.

-- 
Sean Whitton

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.