GNU bug report logs - #79983
[PATCH] ; * lisp/progmodes/hideshow.el (hs-cycle): Fix regression.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 79983 in the body.
You can then email your comments to 79983 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] ; * lisp/progmodes/hideshow.el (hs-cycle): Fix regression.
Date: Wed, 10 Dec 2025 10:14:07 -0600

[Message part 1 (text/plain, inline)]

Tags: patch

This fixes a bug in `hs-cycle` that caused cycling to not work in some
cases.

[0001-lisp-progmodes-hideshow.el-hs-cycle-Fix-regression.-.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
- E.G via Gnus and Org.

Message #8 received at 79983 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Elijah Gabe Pérez <eg642616 <at> gmail.com>
Cc: 79983 <at> debbugs.gnu.org
Subject: Re: bug#79983: [PATCH] ;
 * lisp/progmodes/hideshow.el (hs-cycle): Fix regression.
Date: Wed, 10 Dec 2025 18:33:13 +0200

> From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
> Date: Wed, 10 Dec 2025 10:14:07 -0600
> 
> This fixes a bug in `hs-cycle` that caused cycling to not work in some
> cases.

Thanks, but please always try to add tests for the bugs you fix, so
that there's no danger of reintroducing these bugs in the future.

Message #11 received at 79983 <at> debbugs.gnu.org (full text, mbox):

From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 79983 <at> debbugs.gnu.org
Subject: Re: bug#79983: [PATCH] ; * lisp/progmodes/hideshow.el (hs-cycle):
 Fix regression.
Date: Wed, 10 Dec 2025 13:58:29 -0600

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
>> Date: Wed, 10 Dec 2025 10:14:07 -0600
>> 
>> This fixes a bug in `hs-cycle` that caused cycling to not work in some
>> cases.
>
> Thanks, but please always try to add tests for the bugs you fix, so
> that there's no danger of reintroducing these bugs in the future.

Thank you, I've added a few.

[0001-lisp-progmodes-hideshow.el-hs-cycle-Fix-regression.-.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
- E.G via Gnus and Org.

Message #14 received at 79983 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Elijah Gabe Pérez <eg642616 <at> gmail.com>
Cc: 79983 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#79983: [PATCH] ; * lisp/progmodes/hideshow.el (hs-cycle):
 Fix regression.
Date: Fri, 12 Dec 2025 09:24:10 +0200

close 79983 31.0.50
thanks

> Subject: [PATCH] ; * lisp/progmodes/hideshow.el (hs-cycle): Fix regression. 
>  (Bug#79983)
>
> * test/lisp/progmodes/hideshow-tests.el
> (hideshow-cycle-with-delimiters)
> (hideshow-cycle-without-delimiters)
> (hideshow-check-unbalanced-parens): Add new tests.

Thanks, pushed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.