Juri Linkov <juri@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 79983) by debbugs.gnu.org; 12 Dec 2025 07:25:10 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Dec 12 02:25:10 2025 Received: from localhost ([127.0.0.1]:53314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1vTxWY-0000bt-5e for submit <at> debbugs.gnu.org; Fri, 12 Dec 2025 02:25:10 -0500 Received: from mout-p-103.mailbox.org ([80.241.56.161]:48694) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1vTxWV-0000av-3r; Fri, 12 Dec 2025 02:25:07 -0500 Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:b231:465::202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4dSLZM3pGBz9sdR; Fri, 12 Dec 2025 08:24:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linkov.net; s=MBO0001; t=1765524299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dRgwB5WxYuMXmngfiXn5QcEgGhlVFhFn+psXGtNc5nY=; b=z9W/An9XARK+pPXEHm49NQpXVnFhbpZWI8kSR4NZ4WIoNER2hrukKcEXhBfxV1SomBo48e M42mowy6pmdFaRky/lJ8Qu4dzMOcWNg2h7Jh+LardTQ16MlzFx9Uh/sxOWkSSazwnmd/R+ BRG5UYRZ6DvrFqtBYvcd7xJcsAKSLuozv+yxcm9t1X60egALRYElBDEfGe4xKIiKzvryZg b1KxthbdP9yGm8rpc4LeKyUCuxHS0vjsdI5BrfX1yLxqAj0lCFaXiKbBB/TiKk0kt/Uxvb wuqlA9iULopXqHVEKyZNHJHpkrPfHN3DjRrppUzRFQRBARj+dHoC9r1IsdiEDg== Authentication-Results: outgoing_mbo_mout; dkim=none; spf=pass (outgoing_mbo_mout: domain of juri@HIDDEN designates 2001:67c:2050:b231:465::202 as permitted sender) smtp.mailfrom=juri@HIDDEN From: Juri Linkov <juri@HIDDEN> To: Elijah Gabe =?iso-8859-1?Q?P=E9rez?= <eg642616@HIDDEN> Subject: Re: bug#79983: [PATCH] ; * lisp/progmodes/hideshow.el (hs-cycle): Fix regression. In-Reply-To: <871pl2xg62.fsf@HIDDEN> Organization: LINKOV.NET References: <87bjk6xqk0.fsf@HIDDEN> <864ipycn5i.fsf@HIDDEN> <871pl2xg62.fsf@HIDDEN> Date: Fri, 12 Dec 2025 09:24:10 +0200 Message-ID: <87pl8kcgdh.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 4dSLZM3pGBz9sdR X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 79983 Cc: 79983 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) close 79983 31.0.50 thanks > Subject: [PATCH] ; * lisp/progmodes/hideshow.el (hs-cycle): Fix regression. > (Bug#79983) > > * test/lisp/progmodes/hideshow-tests.el > (hideshow-cycle-with-delimiters) > (hideshow-cycle-without-delimiters) > (hideshow-check-unbalanced-parens): Add new tests. Thanks, pushed.
bug-gnu-emacs@HIDDEN:bug#79983; Package emacs.
Full text available.
Received: (at 79983) by debbugs.gnu.org; 10 Dec 2025 19:58:40 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 10 14:58:40 2025
Received: from localhost ([127.0.0.1]:36477 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1vTQKd-0004L6-EU
for submit <at> debbugs.gnu.org; Wed, 10 Dec 2025 14:58:40 -0500
Received: from mail-ot1-x343.google.com ([2607:f8b0:4864:20::343]:47436)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <eg642616@HIDDEN>)
id 1vTQKb-0004Kr-Ha
for 79983 <at> debbugs.gnu.org; Wed, 10 Dec 2025 14:58:38 -0500
Received: by mail-ot1-x343.google.com with SMTP id
46e09a7af769-7c765f41346so175279a34.3
for <79983 <at> debbugs.gnu.org>; Wed, 10 Dec 2025 11:58:37 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1765396711; x=1766001511; darn=debbugs.gnu.org;
h=mime-version:user-agent:message-id:date:references:in-reply-to
:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=K1X4uzjdrLSZBfyOEZyPvq9drqY1vJPuzSi1OrHAIIY=;
b=k1Wxeqgdr0PvI1SxxIT6DPlm/V0jcXidf8axPjTOtL/Jbp7QJSDA7N82WHtYgQV6si
SXUZhL9bW1J6tyHaWosGhMLRJI5B3b0QGjT25QvX0/CgVEZrW+ZGpXtF8qq7CW9M6+bE
4Yonh8+GsVoMmBRy13XIB8dsPT4KzYCSzDqAHNagusUaR9W72HDflD57mQeUmUjImhR7
XfVP6O28pxwGGRo0c+7xWvljU8KWR9wjLY3eHEn1RI4QETtrZYNxq7gU/TboI9Mhb1j6
TkcX0fhuwQGN7MTEB2EOwIqjoYhz98/4Uj8eHzGYQkMjUPUybmZv1+IeiW+SGZjRq5GQ
aS5A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1765396711; x=1766001511;
h=mime-version:user-agent:message-id:date:references:in-reply-to
:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject
:date:message-id:reply-to;
bh=K1X4uzjdrLSZBfyOEZyPvq9drqY1vJPuzSi1OrHAIIY=;
b=gYrSDJmYx3x8qtnibioB3NYp+p+mmwGwS/Bc0XTIHo3z3f9B/EXraGflRg9Uz96BSN
pWjPboF1/lpeqkCGy8hQEaO2wMCkJrSZL8Ct01zeNK3oxLBNvgngwgoxP8NsHnoeftxv
ZgSjeFp3jpAnNLqxRb+m4QXa6UdSveaqsgIkh6gI+qgujek0MbaTh2D6I+cHwwcXj01r
AM2ax9CSsAjYMj4qbc8ekKS/4Xi4544IyyM+40/WtxfVYBE7eLYVe+49mGqn+AnXttSE
rIZgCvupJsLzx1ptR/BvnUeIn7woiXepIdV90BSZkH4NYmK3nnznp34H8A8cGSdGXGTW
8Psg==
X-Gm-Message-State: AOJu0Yy3s4Id37fpJ8OQB/wuAQT67xoBzmZH0imkX5TXs7qcS1Sl9+C/
hQQMRerJn3aTyzfcq5gQBsnKzzY2mMxRZUJRWiRB6GLsTVTkCL0mGqA9aQNiMfBh
X-Gm-Gg: ASbGnctg6Nt2QuYwRMi9egmE80P3hPs54WetIfsn5Np2nvz0s41wnMjkSBzOLJSlUI1
kjSV4/WNiSbbqJw0HbhetKdQ+JQUl0OPTTkVokwGFd+FtuxiBRZno1D91D5zctgDjWphkqBaTia
5f2gDC1nnDHMgGfUPFsi52GyxXccylfeAu4TpH2bQK5B4CGW2J+GCvK/7Yz4W852e+RNo8p2pQp
ccOxfDZubXlmYt2ekxjAMpqllJheiFFswpSge0R8YcTVe1CLzEbvqixKxUjAv9tBAGCVCqcfoac
UpSEHhUUqo5A15+WIuvmxgfz8w0S88lM3jMRkdfNbqI3ynYqi6XxYkCVYH4I9QVpWIUSqFLHJIF
eNphF7WUwIRpK6bIbZzTkCUh7o8zCtS5R9gTlMka8CyGZzMAzDiGImdULBN5J2RH+du466cJT6O
dv93Pa
X-Google-Smtp-Source: AGHT+IF49LrU8iO3v8x8NVbCgaSTi5Bt/VCbJt4PPEyDmxhzGjILMSVnR45eCsHasjG4oh4a3/xQbw==
X-Received: by 2002:a05:6820:2187:b0:659:9a49:9094 with SMTP id
006d021491bc7-65b2ac28735mr1955194eaf.19.1765396711519;
Wed, 10 Dec 2025 11:58:31 -0800 (PST)
Received: from fedora ([189.215.164.221]) by smtp.gmail.com with ESMTPSA id
586e51a60fabf-3f5d5149058sm387442fac.18.2025.12.10.11.58.30
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 10 Dec 2025 11:58:31 -0800 (PST)
From: =?utf-8?Q?Elijah_Gabe_P=C3=A9rez?= <eg642616@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#79983: [PATCH] ; * lisp/progmodes/hideshow.el (hs-cycle):
Fix regression.
In-Reply-To: <864ipycn5i.fsf@HIDDEN>
References: <87bjk6xqk0.fsf@HIDDEN> <864ipycn5i.fsf@HIDDEN>
Date: Wed, 10 Dec 2025 13:58:29 -0600
Message-ID: <871pl2xg62.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: 0.3 (/)
X-Debbugs-Envelope-To: 79983
Cc: 79983 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)
--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Eli Zaretskii <eliz@HIDDEN> writes:
>> From: Elijah Gabe P=C3=A9rez <eg642616@HIDDEN>
>> Date: Wed, 10 Dec 2025 10:14:07 -0600
>>=20
>> This fixes a bug in `hs-cycle` that caused cycling to not work in some
>> cases.
>
> Thanks, but please always try to add tests for the bugs you fix, so
> that there's no danger of reintroducing these bugs in the future.
Thank you, I've added a few.
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=0001-lisp-progmodes-hideshow.el-hs-cycle-Fix-regression.-.patch
From d2306067e630efc6aee2283452bbb2846ed71dfd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?El=C3=ADas=20Gabriel=20P=C3=A9rez?= <eg642616@HIDDEN>
Date: Wed, 10 Dec 2025 10:05:44 -0600
Subject: [PATCH] ; * lisp/progmodes/hideshow.el (hs-cycle): Fix regression.
(Bug#79983)
* test/lisp/progmodes/hideshow-tests.el
(hideshow-cycle-with-delimiters)
(hideshow-cycle-without-delimiters)
(hideshow-check-unbalanced-parens): Add new tests.
---
lisp/progmodes/hideshow.el | 5 +-
test/lisp/progmodes/hideshow-tests.el | 84 +++++++++++++++++++++++++++
2 files changed, 87 insertions(+), 2 deletions(-)
diff --git a/lisp/progmodes/hideshow.el b/lisp/progmodes/hideshow.el
index f0bea28ceac..7f47f7588ff 100644
--- a/lisp/progmodes/hideshow.el
+++ b/lisp/progmodes/hideshow.el
@@ -1425,7 +1425,7 @@ hs-cycle
(message "Hide %d level" level))
(t
(let* (hs-allow-nesting
- (block (hs-block-positions nil :ad-end))
+ (block (hs-block-positions :ad-beg :ad-end))
(ov (seq-find
(lambda (o)
(and (eq (overlay-get o 'invisible) 'hs)))
@@ -1436,7 +1436,8 @@ hs-cycle
(hs-hide-block)
(message "Hide block and nested blocks"))
;; Hide the children blocks if the parent block is hidden
- ((= (overlay-end ov) (cadr block))
+ ((and (= (overlay-start ov) (car block))
+ (= (overlay-end ov) (cadr block)))
(apply #'hs-hide-level-recursive 1 block)
(message "Hide first nested blocks"))
;; Otherwise show all in the parent block, we cannot use
diff --git a/test/lisp/progmodes/hideshow-tests.el b/test/lisp/progmodes/hideshow-tests.el
index 39161f2455c..49f661a2390 100644
--- a/test/lisp/progmodes/hideshow-tests.el
+++ b/test/lisp/progmodes/hideshow-tests.el
@@ -342,6 +342,90 @@ hideshow-mouse-toggle-hiding-1
(funcall call-at "}")
(should (string= (hideshow-tests-visible-string) contents)))))
+(ert-deftest hideshow-cycle-with-delimiters ()
+ "Should cycle the visibility of a block with delimiters."
+ (let ((contents "
+int
+main ()
+{
+ {
+ {
+ }
+ }
+}
+"))
+ (hideshow-tests-with-temp-buffer
+ c-mode
+ contents
+ (hideshow-tests-look-at "{")
+ (hs-cycle 1)
+ (should (string=
+ (hideshow-tests-visible-string)
+ "
+int
+main ()
+{}
+"))
+ (hs-cycle 1)
+ (should (string=
+ (hideshow-tests-visible-string)
+ "
+int
+main ()
+{
+ {}
+}
+"))
+ (hs-cycle 1)
+ (should (string=
+ (hideshow-tests-visible-string)
+ contents)))))
+
+(ert-deftest hideshow-cycle-without-delimiters ()
+ "Should cycle the visibility of a block without delimiters."
+ (let ((contents "
+def test1 ():
+ def test2 ():
+ def test3():
+"))
+ (hideshow-tests-with-temp-buffer
+ python-mode
+ contents
+ (hideshow-tests-look-at "test1")
+ (hs-cycle 1)
+ (should (string=
+ (hideshow-tests-visible-string)
+ "
+def test1 ():
+"))
+ (hs-cycle 1)
+ (should (string=
+ (hideshow-tests-visible-string)
+ "
+def test1 ():
+ def test2 ():
+"))
+ (hs-cycle 1)
+ (should (string=
+ (hideshow-tests-visible-string)
+ contents)))))
+
+(ert-deftest hideshow-check-unbalanced-parens ()
+ (let ((contents "
+(defun test1 ())
+
+(defun test2
+"))
+ (hideshow-tests-with-temp-buffer
+ c-mode
+ contents
+ (hideshow-tests-look-at "test1")
+ (beginning-of-line)
+ (should (hs-block-positions))
+ (hideshow-tests-look-at "test2")
+ (beginning-of-line)
+ (should-not (hs-block-positions)))))
+
(provide 'hideshow-tests)
;;; hideshow-tests.el ends here
--
2.52.0
--=-=-=
Content-Type: text/plain
--
- E.G via Gnus and Org.
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#79983; Package emacs.
Full text available.Received: (at 79983) by debbugs.gnu.org; 10 Dec 2025 16:33:39 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 10 11:33:39 2025 Received: from localhost ([127.0.0.1]:35303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1vTN8C-0004ZY-SE for submit <at> debbugs.gnu.org; Wed, 10 Dec 2025 11:33:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38768) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1vTN87-0004Xs-SK for 79983 <at> debbugs.gnu.org; Wed, 10 Dec 2025 11:33:33 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1vTN82-0003wA-2J; Wed, 10 Dec 2025 11:33:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=bYtczqxxi3K6Z6ja/Cr+CBHcioeVc/iKw4Yu99Of74U=; b=F9GYJX5HKD5U1E/ejM1u Mk+CwD1RCA4Wgzw19PE4FOPwiT1wAgEyXMy7mAvmWZvttmZ/mqxIRJ1pb1WY5RINiX+nqdtBXmoqL p28wC3Lbf99FGvWwNLYOuN+923UG38/jy906ud4OQZBU1gU/vRvyCe+bcKW2//ywyPNeR4gvEOd/P wjqqVCMCFqX3RS/MrR6yh3Kapgd2lXvA8HjOjvMJZhMe0myNnRyqQ4iEXe0+eRQdjKZgrW/YmG77k jBESRzc/lVjSHCAS7SzNtI1JKWAHRab7L4Mda8hZTZq+2TEtLMQJfrzhsAnqU6VBbivcyhc9TXJa2 x+FsCc/stonLZQ==; Date: Wed, 10 Dec 2025 18:33:13 +0200 Message-Id: <864ipycn5i.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Elijah Gabe =?iso-8859-1?Q?P=E9rez?= <eg642616@HIDDEN> In-Reply-To: <87bjk6xqk0.fsf@HIDDEN> (message from Elijah Gabe =?iso-8859-1?Q?P=E9rez?= on Wed, 10 Dec 2025 10:14:07 -0600) Subject: Re: bug#79983: [PATCH] ; * lisp/progmodes/hideshow.el (hs-cycle): Fix regression. References: <87bjk6xqk0.fsf@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 79983 Cc: 79983 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Elijah Gabe Pérez <eg642616@HIDDEN> > Date: Wed, 10 Dec 2025 10:14:07 -0600 > > This fixes a bug in `hs-cycle` that caused cycling to not work in some > cases. Thanks, but please always try to add tests for the bugs you fix, so that there's no danger of reintroducing these bugs in the future.
bug-gnu-emacs@HIDDEN:bug#79983; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 10 Dec 2025 16:15:07 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 10 11:15:07 2025
Received: from localhost ([127.0.0.1]:35181 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1vTMqI-0003FT-Ru
for submit <at> debbugs.gnu.org; Wed, 10 Dec 2025 11:15:07 -0500
Received: from lists.gnu.org ([2001:470:142::17]:36570)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <eg642616@HIDDEN>)
id 1vTMqG-0003By-MP
for submit <at> debbugs.gnu.org; Wed, 10 Dec 2025 11:15:05 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eg642616@HIDDEN>)
id 1vTMq7-00062k-FG
for bug-gnu-emacs@HIDDEN; Wed, 10 Dec 2025 11:14:55 -0500
Received: from mail-oa1-x42.google.com ([2001:4860:4864:20::42])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <eg642616@HIDDEN>)
id 1vTMq5-0005zh-MM
for bug-gnu-emacs@HIDDEN; Wed, 10 Dec 2025 11:14:55 -0500
Received: by mail-oa1-x42.google.com with SMTP id
586e51a60fabf-3e8819eda8bso2287636fac.3
for <bug-gnu-emacs@HIDDEN>; Wed, 10 Dec 2025 08:14:53 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1765383292; x=1765988092; darn=gnu.org;
h=mime-version:message-id:date:subject:to:from:from:to:cc:subject
:date:message-id:reply-to;
bh=Q1q80FVRa0NE0bApzGlOPLB1ktpB1H9xgbSU9yJEZEs=;
b=SQNc2TAnOki7jmp4yHOpnxe8E8CZ1IWWbhVOCpPr+Xt1kdcN6Md7N53FO6Fv2GtIhv
CmUdmGzL5Od68/7CHd17kmSjYyZu4GFF4u+Bre3NlRSs2RaQJVRkqAg1I0fVV8YlS9EY
johRw1SlyNQVcPFZ0ics3GZ9Kje720O9iZmVsdiP0Q3SHxSBgH7rYGF3Yi+XSu6OZDGY
iP7qukE7jffYTz5SyqItMN8nq7RnMzD9gk6d4sZTEkS1mxHijdlTJl4BzJLlPzfC4W74
ua3b469EmEmcyqj7wh8e24CZWE2kRTHi0nzmsS+hRCSOtUiC+I156ptYGvVLOTeXHy0X
cgxw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1765383292; x=1765988092;
h=mime-version:message-id:date:subject:to:from:x-gm-gg
:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=Q1q80FVRa0NE0bApzGlOPLB1ktpB1H9xgbSU9yJEZEs=;
b=cTaxaOiDXdJzNvJaCmwktV/CL9YH7dxu4dGD72iuh8n1xt2RwIN7VQUwM4GOQM8LP2
4KkvtAHfskAk2qosU73XLtJVo6a0oimk52xCE2/0fUOIj3vaL2RryyO0Zj82k3U5zDRT
y+RpemWPid4vfiDeh8XnQrKblmPDRcTbzJ2G8+u8dpyS7g1FuelRAM6M4cwm+elxrmdg
+MIz5YRcN/1uImpDZB/52+3hF6U5VMutQ2hmiht7OhIgFcccQQn1pb6cyWYjI/wlGu2W
n32yUqKgVOAxLVLx8/dboZLQ+ODypnURwXcC3mXQoS8KQ4I4H77znT1TKYQnYdT4Cixe
5Q3Q==
X-Gm-Message-State: AOJu0YyCG/4syPI8ZrnrRq4mam3wrdCFTZZONpBb5JnmQJHqebBIGcFq
O6AhZ7g6mVQcKIVygR7cmjKTieYZvQkEDs5sxEs5G6lzn5+dnb4zj3As43P4ZSrE
X-Gm-Gg: ASbGnctoMkrL/MwPL2Hqx7aAon+AiILMrSbVxVtjyeuoofpUKfCwF2AsGhfpaIRmciK
Y+jN7wz3kGquld6oAhj38h5daZaoNkApcozS2IkXm6at1dSQh6fWJLqDPG/AFcrwDXmP0LiprWF
vEcGDT5O9LKvJlA6hpE3X2GndnAW/3gj0DYmUHQAehForqRKlMgv9PV7CPz/1Z9Vn6LoWBzeFbg
QhVfVFBTnaSWJ/34pfsqr3yo0uG6UngzpLkhAFDwQ7Wwuyq/kb3rYsC9Oe7tqvUmgiThsGKl8qw
bue/LQIdt1pPAPd2IMxXKssL5euRTVeRdbs2PK1MLqkhC4/BixfRfjzxcAuiowTiEWNul7WayHL
Yh6fVAFqewuX30AxZfocRRFXp2P75ZER2EWFBfImbmLgzHQMiJa1cdofkr1hX0fx3GF1jO7O8xE
p92yY3LBMuDbOpcjg=
X-Google-Smtp-Source: AGHT+IEnys+T960JCTa3J5Ev/QM9NKEwVL3K6Tv/x306+pzvcGnpWTdL+WxQA3ictiU5rJ6nIsZHQQ==
X-Received: by 2002:a05:6820:2d02:b0:659:9a49:8e5a with SMTP id
006d021491bc7-65b2acbf52cmr1764550eaf.42.1765383291758;
Wed, 10 Dec 2025 08:14:51 -0800 (PST)
Received: from fedora ([189.215.160.233]) by smtp.gmail.com with ESMTPSA id
006d021491bc7-6597ef41302sm9179730eaf.15.2025.12.10.08.14.11
for <bug-gnu-emacs@HIDDEN>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 10 Dec 2025 08:14:51 -0800 (PST)
From: =?utf-8?Q?Elijah_Gabe_P=C3=A9rez?= <eg642616@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: [PATCH] ; * lisp/progmodes/hideshow.el (hs-cycle): Fix regression.
Date: Wed, 10 Dec 2025 10:14:07 -0600
Message-ID: <87bjk6xqk0.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=2001:4860:4864:20::42;
envelope-from=eg642616@HIDDEN; helo=mail-oa1-x42.google.com
X-Spam_score_int: -17
X-Spam_score: -1.8
X-Spam_bar: -
X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,
RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Tags: patch This fixes a bug in `hs-cycle` that caused
cycling
to not work in some cases. From 7f38c11992810d123e6658c7ded94d6da74b3469
Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?El=C3=ADas=20Gabriel=20P=C3=A9rez?=
Date: Wed, 10 Dec 2025 10:05:44 -0600 Subject: [PATCH] ; * lisp/progmodes/h
[...] Content analysis details: (1.2 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail)
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends
in digit (eg642616[at]gmail.com)
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (eg642616[at]gmail.com)
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust [2001:470:142:0:0:0:0:17 listed in] [list.dnswl.org]
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.2 (/)
--=-=-=
Content-Type: text/plain
Tags: patch
This fixes a bug in `hs-cycle` that caused cycling to not work in some
cases.
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=0001-lisp-progmodes-hideshow.el-hs-cycle-Fix-regression.-.patch
From 7f38c11992810d123e6658c7ded94d6da74b3469 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?El=C3=ADas=20Gabriel=20P=C3=A9rez?= <eg642616@HIDDEN>
Date: Wed, 10 Dec 2025 10:05:44 -0600
Subject: [PATCH] ; * lisp/progmodes/hideshow.el (hs-cycle): Fix regression.
(Bug#)
---
lisp/progmodes/hideshow.el | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lisp/progmodes/hideshow.el b/lisp/progmodes/hideshow.el
index 123eb1bd6c6..66403fe87bb 100644
--- a/lisp/progmodes/hideshow.el
+++ b/lisp/progmodes/hideshow.el
@@ -1428,7 +1428,7 @@ hs-cycle
(message "Hide %d level" level))
(t
(let* (hs-allow-nesting
- (block (hs-block-positions nil :ad-end))
+ (block (hs-block-positions :ad-beg :ad-end))
(ov (seq-find
(lambda (o)
(and (eq (overlay-get o 'invisible) 'hs)))
@@ -1439,7 +1439,8 @@ hs-cycle
(hs-hide-block)
(message "Hide block and nested blocks"))
;; Hide the children blocks if the parent block is hidden
- ((= (overlay-end ov) (cadr block))
+ ((and (= (overlay-start ov) (car block))
+ (= (overlay-end ov) (cadr block)))
(apply #'hs-hide-level-recursive 1 block)
(message "Hide first nested blocks"))
;; Otherwise show all in the parent block, we cannot use
--
2.52.0
--=-=-=
Content-Type: text/plain
--
- E.G via Gnus and Org.
--=-=-=--
Elijah Gabe Pérez <eg642616@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#79983; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.