GNU bug report logs - #80117
31.0.50; [PATCH] Avoid byte-compiled code in `ibuffer-maybe-show-predicates' user option

Previous Next

To reply to this bug, email your comments to 80117 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Phil Sainty <psainty <at> orcon.net.nz>
To: bug-gnu-emacs <at> gnu.org
Subject: 31.0.50; [PATCH] Avoid byte-compiled code in
 `ibuffer-maybe-show-predicates' user option
Date: Sat, 03 Jan 2026 15:49:52 +1300

[Message part 1 (text/plain, inline)]

* lisp/ibuffer.el (ibuffer-hidden-buffer-p): New function.
(ibuffer-maybe-show-predicates): Use it.

This prevents byte-compiled code appearing in the *Help* buffer:

 ibuffer-maybe-show-predicates is a variable defined in ‘ibuffer.el’.
 Its value is
 (#f(compiled-function (buf) #<bytecode -0xf88f2e6c202aaf3>))

And also in the customize UI:

 Hide Ibuffer Maybe Show Predicates:
 Repeat:
 INS DEL Choice: Value Menu Function:
 #[257 "\301\302\303^C!\"\205^K^@^H?\207"
       [buffer-file-name string-match "^ " buffer-name] 5
       
("/home/phil/emacs/trunk/usr/local/share/emacs/31.0.50/lisp/ibuffer.elc"
        . 7690)]



In GNU Emacs 31.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.16.0, Xaw scroll bars) of 2025-12-31 built on phil-lp
Repository revision: f2104942018c6a8631515ce07ad452e8adfe3684
Repository branch: tab-bar-documentation
Windowing system distributor 'The X.Org Foundation', version 
11.0.12101004
System Description: Ubuntu 22.04.5 LTS

Configured using:
 'configure --prefix=/home/phil/emacs/trunk/usr/local
 --without-native-compilation --with-x-toolkit=lucid --without-sound
 '--program-transform-name=s/^ctags$/ctags_emacs/''

Configured features:
CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
LCMS2 LIBSELINUX LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP
SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM
XINERAMA XPM XRANDR LUCID ZLIB

Important settings:
  value of $LC_MONETARY: en_NZ.UTF-8
  value of $LC_NUMERIC: en_NZ.UTF-8
  value of $LC_TIME: en_NZ.UTF-8
  value of $LANG: en_GB.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  minibuffer-nonselected-mode: t
  minibuffer-regexp-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug lisp-mnt message mailcap yank-media puny
dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg
rfc6068 epg-config gnus-util text-property-search time-date subr-x
mm-decode mm-bodies mm-encode mailabbrev gmm-utils mailheader sendmail
mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mm-util mail-prsvr
mail-utils tabify cl-macs ibuffer ibuffer-loaddefs thingatpt help-fns
byte-opt gv bytecomp byte-compile radix-tree help-mode cus-edit pp
cus-start cus-load icons wid-edit cl-loaddefs cl-lib rmc iso-transl
tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks
lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd
touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list
replace newcomment text-mode lisp-mode prog-mode register page tab-bar
menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse
jit-lock font-lock syntax font-core term/tty-colors frame minibuffer
nadvice seq simple cl-generic indonesian philippine cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop
case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure
cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp
files window text-properties overlay sha1 md5 base64 format env
code-pages mule custom widget keymap hashtable-print-readable backquote
threads dbusbind inotify lcms2 dynamic-setting system-font-setting
font-render-setting cairo x-toolkit x multi-tty move-toolbar
make-network-process tty-child-frames emacs)

Memory information:
((conses 16 77179 18766) (symbols 48 8709 0) (strings 32 22236 1913)
 (string-bytes 1 560663) (vectors 16 13875)
 (vector-slots 8 151953 9106) (floats 8 30 3) (intervals 56 491 0)
 (buffers 1064 14))

[0001-Avoid-byte-compiled-code-in-ibuffer-maybe-show-predi.patch (text/x-diff, attachment)]

Message #8 received at 80117 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Phil Sainty <psainty <at> orcon.net.nz>
Cc: 80117 <at> debbugs.gnu.org
Subject: Re: bug#80117: 31.0.50;
 [PATCH] Avoid byte-compiled code in `ibuffer-maybe-show-predicates'
 user option
Date: Sat, 03 Jan 2026 10:45:44 +0200

> Date: Sat, 03 Jan 2026 15:49:52 +1300
> From: Phil Sainty <psainty <at> orcon.net.nz>
> 
> * lisp/ibuffer.el (ibuffer-hidden-buffer-p): New function.
> (ibuffer-maybe-show-predicates): Use it.

Should this new function be an internal one, perhaps, and its name
therefore be ibuffer--hidden-buffer-p instead?  After all, until now
it was not important to call it at all, right?

Or do you envision other uses for this function?

Thanks.

Message #11 received at 80117 <at> debbugs.gnu.org (full text, mbox):

From: Phil Sainty <psainty <at> orcon.net.nz>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 80117 <at> debbugs.gnu.org
Subject: Re: bug#80117: 31.0.50; [PATCH] Avoid byte-compiled code in
 `ibuffer-maybe-show-predicates' user option
Date: Sat, 03 Jan 2026 23:39:36 +1300

On 2026-01-03 21:45, Eli Zaretskii wrote:
>> Date: Sat, 03 Jan 2026 15:49:52 +1300
>> From: Phil Sainty <psainty <at> orcon.net.nz>
>> 
>> * lisp/ibuffer.el (ibuffer-hidden-buffer-p): New function.
>> (ibuffer-maybe-show-predicates): Use it.
> 
> Should this new function be an internal one, perhaps, and its name
> therefore be ibuffer--hidden-buffer-p instead?

Perhaps.

Any default value of a user option seems to me like a public-
facing value rather than an internal one, so I think that's
my only argument for maybe keeping the name as-is (but maybe
I have the wrong interpretation).


> After all, until now it was not important to call it at all, right?
> Or do you envision other uses for this function?

I didn't have any other particular uses in mind.  I see now
that `ibuffer-fontification-alist' includes almost the same
form, so it could be tweaked to account for both cases.


-Phil

Message #14 received at 80117 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Phil Sainty <psainty <at> orcon.net.nz>
Cc: 80117 <at> debbugs.gnu.org
Subject: Re: bug#80117: 31.0.50; [PATCH] Avoid byte-compiled code in
 `ibuffer-maybe-show-predicates' user option
Date: Sat, 10 Jan 2026 14:42:36 +0200

> Date: Sat, 03 Jan 2026 23:39:36 +1300
> From: Phil Sainty <psainty <at> orcon.net.nz>
> Cc: 80117 <at> debbugs.gnu.org
> 
> On 2026-01-03 21:45, Eli Zaretskii wrote:
> >> Date: Sat, 03 Jan 2026 15:49:52 +1300
> >> From: Phil Sainty <psainty <at> orcon.net.nz>
> >> 
> >> * lisp/ibuffer.el (ibuffer-hidden-buffer-p): New function.
> >> (ibuffer-maybe-show-predicates): Use it.
> > 
> > Should this new function be an internal one, perhaps, and its name
> > therefore be ibuffer--hidden-buffer-p instead?
> 
> Perhaps.
> 
> Any default value of a user option seems to me like a public-
> facing value rather than an internal one, so I think that's
> my only argument for maybe keeping the name as-is (but maybe
> I have the wrong interpretation).
> 
> 
> > After all, until now it was not important to call it at all, right?
> > Or do you envision other uses for this function?
> 
> I didn't have any other particular uses in mind.  I see now
> that `ibuffer-fontification-alist' includes almost the same
> form, so it could be tweaked to account for both cases.

OK, then please feel free to install your changes on the master
branch.

Message #17 received at 80117 <at> debbugs.gnu.org (full text, mbox):

From: Phil Sainty <psainty <at> orcon.net.nz>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 80117 <at> debbugs.gnu.org
Subject: Re: bug#80117: 31.0.50; [PATCH] Avoid byte-compiled code in
 `ibuffer-maybe-show-predicates' user option
Date: Sun, 11 Jan 2026 20:29:47 +1300

[Message part 1 (text/plain, inline)]

Hi Eli,

On 2026-01-11 01:42, Eli Zaretskii wrote:
> OK, then please feel free to install your changes on the master
> branch.

Thanks.  I did some more testing (which resulted in bug#80180),
and then decided to follow up this comment as well:

>> I see now that `ibuffer-fontification-alist' includes almost
>> the same form, so it could be tweaked to account for both cases.

I'm attaching a new patch which does that as well.

Both changes test well for me, but along the way I realised
that the original code I was copying *looked* buggy:

 (lambda (buf)
   (and (string-match "^ " (buffer-name buf))
   (null buffer-file-name)))

That (null buffer-file-name) seems like it should actually be
(null (buffer-file-name buf))

I added (message "%s" (buffer-name)) to the function to see what
was happening, and it appears that BUF is in fact the current
buffer when the function is called, so it seems that the code
was working correctly as-is, but also quite unclear as written.

I couldn't easily see why BUF should always be current, so
I've gone with this in the new patch, for best clarity:

-       (null buffer-file-name)))
+       (null (buffer-file-name buf))))

Let me know if this all still looks good to you, and I'll
install the new patch.


-Phil

[0001-Avoid-byte-compiled-code-in-ibuffer-maybe-show-predi.patch (text/x-diff, attachment)]

Message #20 received at 80117 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Phil Sainty <psainty <at> orcon.net.nz>
Cc: 80117 <at> debbugs.gnu.org
Subject: Re: bug#80117: 31.0.50; [PATCH] Avoid byte-compiled code in
 `ibuffer-maybe-show-predicates' user option
Date: Sun, 11 Jan 2026 10:20:47 +0200

> Date: Sun, 11 Jan 2026 20:29:47 +1300
> From: Phil Sainty <psainty <at> orcon.net.nz>
> Cc: 80117 <at> debbugs.gnu.org
> 
> Let me know if this all still looks good to you, and I'll
> install the new patch.

Still looks good, thanks.

Message #25 received at 80117-done <at> debbugs.gnu.org (full text, mbox):

From: Phil Sainty <psainty <at> orcon.net.nz>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 80117-done <at> debbugs.gnu.org
Subject: Re: bug#80117: 31.0.50; [PATCH] Avoid byte-compiled code in
 `ibuffer-maybe-show-predicates' user option
Date: Sun, 11 Jan 2026 22:33:56 +1300

Now pushed to the master branch.  Closing this bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.