Received: (at 80505) by debbugs.gnu.org; 28 Feb 2026 16:11:14 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 28 11:11:14 2026 Received: from localhost ([127.0.0.1]:38053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1vwMuP-0001hU-M9 for submit <at> debbugs.gnu.org; Sat, 28 Feb 2026 11:11:14 -0500 Received: from mta-14-3.privateemail.com ([198.54.127.110]:47679) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <basil@HIDDEN>) id 1vwMuN-0001h6-By for 80505 <at> debbugs.gnu.org; Sat, 28 Feb 2026 11:11:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=contovou.net; s=default; t=1772295065; bh=2HKcsNnW0q54n7CXHuS1qjfP98seLjdjdYbpotru3/o=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=WZkOfZSmxG/vVq/JzSQfQKOo/IJHNKACa3oV1DbRpkjDxLsizU+GgR+tbXh9jQQsl VoAY0uYQ+F+1Wc65nFKq3VADyRskTf56qPCJO1lEkwRSfMSl5rBIock/8kg6gPfcgd g2FyU4yowO8n2baAyx3WiBfeES4yyM1Hy13ivd0ZyrKxPXnKgGtOfbZLO7kCrMg+wD 65DiYxsNMXvSKx/hoQPXKJ2Ve8ulN30gpH7cn3Ww6Sv7F8HwE1STuuRpz0023hJfmO dHt33ZhryaKQkj+T1BD/aBhha1fJ0UCrWeOuVToc96pylHlMquQ91RW4srSwOesvGf 8mgW//K7DCmDA== Received: from mta-14.privateemail.com (localhost [127.0.0.1]) by mta-14.privateemail.com (Postfix) with ESMTP id 4fNVYP2kMhz3hhV6; Sat, 28 Feb 2026 11:11:05 -0500 (EST) Received: from localhost (1F2EF519.nat.pool.telekom.hu [31.46.245.25]) by mta-14.privateemail.com (Postfix) with ESMTPA; Sat, 28 Feb 2026 11:11:02 -0500 (EST) From: "Basil L. Contovounesios" <basil@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#80505: 29.4; help-window-old-frame is no longer set In-Reply-To: <86fr6l3ztu.fsf@HIDDEN> References: <87o6l9sx3p.fsf@HIDDEN> <2f1ae165-c728-4767-a802-bed765317204@HIDDEN> <86fr6l3ztu.fsf@HIDDEN> Date: Sat, 28 Feb 2026 17:10:59 +0100 Message-ID: <87zf4sj1bg.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Virus-Scanned: ClamAV using ClamSMTP X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Eli Zaretskii [2026-02-28 12:52 +0200] wrote: >> > The following change for bug#25979 in Emacs 29: >> > >> > Don't clear out local variables in `with-help-window' >> > cd87a5c7a18 2022-05-13 17:14:36 [...] Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [198.54.127.110 listed in list.dnswl.org] 0.4 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [198.54.127.110 listed in sa-accredit.habeas.com] 1.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [198.54.127.110 listed in bl.score.senderscore.com] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [198.54.127.110 listed in wl.mailspike.net] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Debbugs-Envelope-To: 80505 Cc: martin rudalics <rudalics@HIDDEN>, 80505 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.4 (/) Eli Zaretskii [2026-02-28 12:52 +0200] wrote: >> > The following change for bug#25979 in Emacs 29: >> > >> > Don't clear out local variables in `with-help-window' >> > cd87a5c7a18 2022-05-13 17:14:36 +0200 >> > https://git.sv.gnu.org/cgit/emacs.git/commit/?id=cd87a5c7a18 >> > >> > removed the part of with-help-window that sets help-window-old-frame. >> > This was the only place where help-window-old-frame is ever set, so the >> > remaining code which checks its value now always gets the same result. >> > The omission looks accidental to me, so I suggest reintroducing >> > help-window-old-frame to what is now help--window-setup: > If we are going to revert that change, please make sure the bug it > fixed is not re-introduced. The bug has already been reintroduced by bug#73637#44; it is not affected by help-window-old-frame. That's mainly why I think the variable's fate was accidental. -- Basil
bug-gnu-emacs@HIDDEN:bug#80505; Package emacs.
Full text available.Received: (at 80505) by debbugs.gnu.org; 28 Feb 2026 10:52:26 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 28 05:52:26 2026 Received: from localhost ([127.0.0.1]:34520 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1vwHvt-0008Jm-VP for submit <at> debbugs.gnu.org; Sat, 28 Feb 2026 05:52:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33696) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1vwHvr-0008JE-5D for 80505 <at> debbugs.gnu.org; Sat, 28 Feb 2026 05:52:23 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1vwHvl-0005Sl-Fa; Sat, 28 Feb 2026 05:52:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jQKpmpA0ALflkgtg38wPgipLUTlpKxAiM1ff3n+Y8Cc=; b=VRwpf5Q869o+ r5zg35pd0qwUYWyM7EAdq/X/5x35lVINyHBp9J+Cg63ae7xL/D8TXBc51YA0LJdX26PafbwKye4ZE 6/jJ7v8W7E1eD2WxP+GPPA6jaw3WvzSDW9mnE+gML+UFyM8kpLQ2+7DZ85rdxO/lTFSHhImz8y3Cb byKccKtJAbbLWansR8Uh18L2e93eOC2bfG8qOspMJQi7aqMcr4+w/YvJth0+Hv3BSqxAoPHZL6t/L P8ZGQgSuLT+tbRoUmz1Gpay9qRYfeNbQmGua6BdmAv4UaJgDOVIxLx8TzqUcftBw0O0noZi9utFoR lceZ+LquZ4xtpvJDzBjVNw==; Date: Sat, 28 Feb 2026 12:52:13 +0200 Message-Id: <86fr6l3ztu.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: martin rudalics <rudalics@HIDDEN> In-Reply-To: <2f1ae165-c728-4767-a802-bed765317204@HIDDEN> (bug-gnu-emacs@HIDDEN) Subject: Re: bug#80505: 29.4; help-window-old-frame is no longer set References: <87o6l9sx3p.fsf@HIDDEN> <2f1ae165-c728-4767-a802-bed765317204@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 80505 Cc: basil@HIDDEN, 80505 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Sat, 28 Feb 2026 09:25:42 +0100 > From: martin rudalics via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> > > > The following change for bug#25979 in Emacs 29: > > > > Don't clear out local variables in `with-help-window' > > cd87a5c7a18 2022-05-13 17:14:36 +0200 > > https://git.sv.gnu.org/cgit/emacs.git/commit/?id=cd87a5c7a18 > > > > removed the part of with-help-window that sets help-window-old-frame. > > This was the only place where help-window-old-frame is ever set, so the > > remaining code which checks its value now always gets the same result. > > I never tried to understand that patch so I cannot seriously comment on > it. > > > The omission looks accidental to me, so I suggest reintroducing > > help-window-old-frame to what is now help--window-setup: > > > > > > > > Otherwise, the variable should probably be declared obsolete, and its > > redundant remnants removed. > > > > WDYT? > > I completely trust you to DTRT here. If we are going to revert that change, please make sure the bug it fixed is not re-introduced.
bug-gnu-emacs@HIDDEN:bug#80505; Package emacs.
Full text available.Received: (at 80505) by debbugs.gnu.org; 28 Feb 2026 08:25:55 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 28 03:25:55 2026 Received: from localhost ([127.0.0.1]:33914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1vwFe7-00036d-4l for submit <at> debbugs.gnu.org; Sat, 28 Feb 2026 03:25:55 -0500 Received: from mout.gmx.net ([212.227.15.15]:36741) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <rudalics@HIDDEN>) id 1vwFe4-00036A-Jc for 80505 <at> debbugs.gnu.org; Sat, 28 Feb 2026 03:25:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.at; s=s31663417; t=1772267144; x=1772871944; i=rudalics@HIDDEN; bh=3XOlmNqIeqrGeURxXf64fxF5uMzZ8FhKteRgDlojg7Q=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=i5ccZXls+UYjnQevLofBzRfxb9fJvQKIve6//EBIG7WGnFfFgW4f3WgAkf6Pp5cI T0//Ix7/ItqIcTf5AqioFBePa4g1nAEsQobL23OVR1Oi6n/GWi11lQvWTa2AcrMOc 44BPoNH2lkFyRlpdU2L2dX5MN1BnNj4QO8xP3ZEwba+UvUjswy6HCOqzPPMOC+4LD NR1MXN4GlxEyJq1Clao0wzdW2z44RSSa1VJWX/v0WBzk5V4aLhkbVz/18+lzXqHmR C2MpGvVU/utXUD029UCThhyZZgOJOz06jVx0EKZqC1JnnYculkPRpW4P7kY6rfgT0 /n+GAnbI9EgtkNgfhA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from client.hidden.invalid by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MKsjH-1wHV1O44cf-00RKXb; Sat, 28 Feb 2026 09:25:44 +0100 Message-ID: <2f1ae165-c728-4767-a802-bed765317204@HIDDEN> Date: Sat, 28 Feb 2026 09:25:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#80505: 29.4; help-window-old-frame is no longer set To: "Basil L. Contovounesios" <basil@HIDDEN>, 80505 <at> debbugs.gnu.org References: <87o6l9sx3p.fsf@HIDDEN> Content-Language: en-US From: martin rudalics <rudalics@HIDDEN> In-Reply-To: <87o6l9sx3p.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:aEblQNNcsrk2pNCBRmlnE8swtnUK05iwvFsWv+tH/5piwgBv6OR oZYtzreQrvAeZ9fvEcRQuA+YC0a55moFkt4VOqhCNc77BsWmCH5h2Im+nmuPOThcRZ2E9aG JCItWLwvOV7CSryPBGb2U5P5NK32Hj1OEkbSEf6d2Xl1bJxD1q33caLwjy/hBLkQ10hOfn8 Q79mjjQLuJOlj5zsc9/RA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:amihx6fWTb8=;51Ck11xA4nQjN+tYeQaHvKVc/r7 X9Qx0fqiTH35mXwusgau4lDFEYKhBLPDsiWVnk9jmG3DDfA49sDbP4QfkofQuEfM6BiyuUNRD m9x13u8QVrIruspnOP5F49u8LMI3BX9MyPHhwWp0T7kAvMHrKnfjda2l9ozKWfiP46WlSsHJZ zR5+GsjINXDUdTwUR1Y7eoRrdLktQucmVqu1g1/im3M1KiMCJEd9j1AR4J6/aKJJmjasOUJJh 7Na4cRFUz3IwrtCLRw5Zt4SGUvsLzPXF7UdhdHM8lFs6HGQaW+u0jSRRNuhyuSNpFfltKA2B6 qEU0ICPYVmOA+AOTVkBWrlbwlSRF2++NUOU0pQ3NuEa3+cGxzumgf/rMj/PXLUi8vNFVMfPiM qMsytYzW1wlPU4IWscYBc9QB7ORc0WKQ0y7w/957SWTL2xgQSqZkw+DcWF1geuRtvt7LVmLPB naL/zlRYnmuPFKQ27JqLTjg7t3rPHkcva7AbDWrCau3zKYvMn9MNlwZP2iq5y4vjQpncqSFCW vfjovLZnHwSGyxWh9wQtm+INGEjPpMHM0G834ttyOPgdTP4rnUIqymx+bjtJtOIovU9UGU4sO M16jyUoxGdpma58fkEyPWt8OL+448jviLANiRMAE21JIB+TeBTCXI5qvB0W95UiBS3/bc9sAE aLAM9lhfQ2H45eeOKCDBwiyODSo9/YOLY9ri/qp+db8fnstHrvbdWlfOKmcgzppfgtsAZfz38 7OtfPwKXM979BEUcumLH81tMNBWGgCdgR1QM75q0BP4s3XBM/2KjulkMme2KMZeQbtLIdiZtk XSCwjGNOW0va1D0mgwhfBXK08fIYX4Kyn3ICvKYJ5AZoOnRIesfbNIGex+BFCpYVm8b6PJsJk TAE/zhU0S+hdgHnxTqyTiIH4jAej6ne/8CYa6NI9cImk0R2eBi3GdHAiATHcQ4XPq5/Myd5un W+kiS4ITvAsX+ksoRR/cau0pC8Xdk5jSdqIgv4k4HnVhe1DObDRzZuMrLll1HGbOVPIfEFHKl fU2j+3zp20vTatrrT5EIxPWlI9KlQ8MMMvCg5m1WPKFwfVKa94H3jOzZjlAEZzauZCNMtsTZK GR1FqxnuzpipsFbmvSdTf3rc5KLD0Q4LB043HayyUP3lk211+E98qPH1UO4V2WtGUDUQOkXh8 YqhXaSd8eOsMC2MDBXgWmIMM+DRwZsTelmBBoVHosy8FifSWtusxzJju2uZDCwv65Hvi59aOz pXxNwBhQ01CNOLyXpDCAFRVPeP8Uv8exVQjdffVZAjGm+0tD1xVDA3bGdUw4/NZyypINeRkAX VymlWOIZMpfAgr2xTS75rZn3IZxPL37XwonYxB+HfgSjfVpc3SBYdsC6RxW86OB0xRtenZdET d2HwVG98mItdDkXUxL39tymXiqYVRuUYqx8ij746C+xDucjUXZAxhZ6onXGS/7sGBvmgXHXQv ZPPLrI/AS9eg+Q+hzOxyUrd1GP2SmN61n40fXlqBjR+t/I9dnvwjHav3/2EuQjn1Keq52Vcbr lIKYPxrulakdVLTHou6b93fHkwnCTVowRQqr7wVirP/a47SLQeQnEEMI0frfb29judPhD/ML4 Xnz5n6mJ/P5s+DHK7lhj7zZagqSxdlYLyaJMiYCQBaIfMSrNMQ7JP/LJ2OClQadaHdYQTQD3l Ny9MY8KcXf4LR64wSmfkJZNdUqRltn8BTEHEEIkWIveuzQJnTdirSD1x0V6XqxZA1FDKE8SUT 0cRheqt+fPstqItMFwXhz6htJh02GYAYJPFNVmmRZYxQ4N/bFCbVK+t2OW9LF2bcXJQHzhuPA 6AJ5t0DT38KUumwLJAaVG/jJ9adPz9O5sHdYKC3g4Y01RITRDc4zZlhpPeNgeB9359D8YNERG 6NLrOrTrHJfaBPHjZuJXaTzJ7WX2cBcItXnTOvVWMiHBEqUat/w+IoRmdrJZjG3QCsr9aUg+j qQH+MgLE0mEq74lPVs1/RMqYvKKK/5zUx+6I8pJ/yKP+hZ8Q3RtLK0d3Pe6HtllfE4dFsKKV9 lFpKbMdiPzFNNpwzirC1qIZVIuf6ck9NvQVwGFANrBVR+pRu/d6AcuR9aR9kfeJR6lY9YsfeT By4UoqsB0QoWW591M0V4HLJVeA7yK5x8q7uKKIClWsGxVd1kim0fFeNAAydcBXmbIRssL81+S ZU8pUL7cj0Z0kFC5AudP4AB5pPbj42iDKvPjZv0G4Q8cIR96JbAoOF6NwSWeDDatz/1anJqiE UA5NFMnN0AQwAfO++DuhT7F7RjkHHdcKRStJl2qU2rxGn8mVEWS41f627a/gjeSIHzeWhFCvg Zt+IMTZ302+qBDZ6eQniltSmppBNnXHQArSKWYEAlTgeB/ixNjunxt+Em6Uzqafs+w30TPcc3 YnRR4cqX0M09A0VDNZnwCSrwO8YzBQCF9aPOS2xoT/WzH/L++AmbIiZTroNcU3OVmuAUFFxsZ aPXe/3gJ81QrOcNjfud/JFcMSqANFlvHX/3koKZeIelQn1fT5rgxLV7U95Gusq33Wo8HCuPmc 8y6KxHcnIBtWCu/U+3TBCCpMrUvss6TAZBKwPQUmE6CMpQFOGnUZUqrA8/AqCq0iS2oNY7raI 771+SceC433Pc5rFe1C3Gd+1HEuUVCFbHbKbFMrWavuTn1ZKr2a0SWOgcqVslpK9qQmuwYTNI Ceo27ZgJOjEZSpIwOAmTd8VYRmA2GM5Pzl6yWdmJTFVJZVOb0/3loL+aXCffLMK4/hyN1di8V JiDc8TE8C7OmKmOFDV5wOn5KTs87JyUwdoSMCwPg5jXs+mUX9Yeb8sRdvU8qbuf2sSJ1oUrUF aayD0d8/EQVtukqEET4U6idxfbQP1fNx/6LAE+R9k3KI6dCkO4frb0fecuCklYvG5G6pJJVAE hsa0kOH+XiMKjKA0Qv/hMMEX+S/o19RnBOcM1f3iiMBzTDpkLkNPwzSIbtmk9BJPOwcbofyhh 5T3kTvb7khO+p9rboD3PsiJnUIU/yN49r6m9Ulz6hmQKRvvavQ0TbenwIfXsw5BbHWOiY/mco oCKTBf+dv5oqcTekfygZkGa3u4HaG6E+UWPLxiDKiX4bp+ckBY8QxEvjTwNPyARrgRelC5Gat 7KnrirFz1RZKo6HAFMW2svyTG4o/T7RG6vbB8JyKgUiZsjGROozjxX6DtzQdpEHX67+bBDqzD 4bc1Sy+HlyB+jvzXK7lWTFY6T5x7Fuj4V7t7J4c4mFdRziMS45pwZPRSCqd62NMkAcykIBpoY DMiaEuwoE+muCaB33fTfu/8HYtXGX87GlUxZVhhdESITavuFw27WUam2lUo6mY7t1qUh7Moc4 ttr0c+JCgRp/rUVAnNLXcn+P3UQ/BBcOxDOq15IYFmkxMAwLWNcgxJ0bKv9eAIGqyYuF1+3PB wBgQKL1GDvR4XtvRrXopvR9pKtRZbPYPugqDZIQDojGinIS6/wY2pb5vlggpioIcZUaLbZnQh J4QRqwA9PcM4epS7crlxrPJGl/X0zCmZZdNRweTJu3FYymUEGxeUuQATthoHUilZx2BAIQshf HC5HXeW8kXZgmny2b3QZFCoGx0Ih/NPjvIshAx5xFsxDvsLmPfPZKlYzwtNI36l4lhnrlKi8E 7xpdrTzEnV7c1ux7OytVaaV1xAaBe7v5/x9S2f6zCW683THybtZt2isUTPsHB2AC0qFn7SuhQ yrSPkrMVABy06BmNepBLMRU8568kCUTaVzDFr3JlSzB23gRjeNTumAwr72fw0Trbt1D10V9aq oq56SNYFuKmxd6HLWEZth02B9tLulRODrYXyQrHKTydmIyPBaeFBUOgJE7f2DQHQ0rOZN1k2P 4UjtqtpKAha81BJe57OdhrvjtHhf8USYMvZ2CTtj1EH0uNLdBfxAyIMxmiqqLVdOJ+RnNIcib SkIerBLRRlZEOIbjNnww3c64rzvl0wqWE3DxbAU95f1whMyDRhE2cJpZxPZBJC6G0cpdlOILC sPbLZCqA55ja9IUxhohn8W7eFSS4AMoKXQ1ZjOtnBC5tQTc+wr9/12A4nlt/8gDXldn/fTp1Z U9yOl8leJq7dXcxuORF3/e3T3kPM/BQdlMC2UeNkDIbzIDhkMJDfaOwLI1a+c8ROaeFBL/55x Vs4YckxPq/etu70Uck8KXXECZbmt8OQjp0duqnuUmU9RGCrkTzaPt+HAQL4Sz8w80oAbf5+RD S9JcCBXUz7pzrodrfRcOF+wc20MppK1UO0oDkXA33kGadIKTgpb5oD7Rk8OJE6LNwn4AfILWp jlx20YP+6z2Y2/ljUOzfJBibABo/LhlpYdHZBTjkOV8z3zR3LBmb6k8QaPQMw6Plj7XhU1xJF gdwqbG2YE20HlMXLGzU0Ab3P0fK27eGU/zyxWHZJ22y4WOM70ykxITC+DU9wkt9mlTVYXOdyA dmnPjrVYWEJkwGElHV1yvu9OqqX+LnlAY3s8t9MVyCM7j2QxKhADT8Di7P0t9TiaVwtwib82x hh6gLv64ctXl/rWYJ5NX59GZk6bKfit5uYn3mPbwkUb12eu5xnctCqdqYiUxgYxFQ9gdMqOE5 X8prPdA6M4tgMDOGUfwmpOVaolkUFclxZVKT4i5ffN4ZPo2eZEobSiph6T+wk3MlQhsr4E7d0 8P+ZnHPMAVQADjuV/74x+PPYh3jsQPXiBmPDM7Q4UP5Sw3hwBiKRseb8iB0j/664sukakiqJE 8cDJJdNwSsgJ2WBP6FaUjrZGvyuwVuFyM6/2P26okpGl6d//gatk8CZIjU1qTl6QReVnhA1Z0 E9mmj7rv8JSmk5MszsQ5nj3W1T9xWj5/7vuOC1A4RSXij6osM6Rn8NeygAckQqxR+ANlix9b4 gzWUqtg5tp6J1ytAL0txxDfI2ntQNl2An6Jj2jZTI820Iv7rgS/BkZBG2Il2JoFDMyiLO83U+ qvzNeLW5Y89XQBeorCpxVs14dmUAkJIDAy8q5DnHs4GG8XD/DIJQmBQXcEM0bOA9K0EdGDEOA IbXAJPPCcqHRShvPjxpc6MD+bDLBkW9G0rtcLtGcys4cHnTt3OfmmeDVKkTOTcE4TYD6mMIBN g/OYu1oQMt/7mmj1hQz5mzvq4zkBonXaMtPK9p1b69RleG7IceRhgm2KqlU4ceZGV7guugane IMKfBE7JbKnzYsR8CzmxFN3Umzkwe1GmcnyCmZVeuqHxyBefkBSyDwOrARQvS5MCdOWU/h1OI Lcrnfrxw= X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 80505 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.3 (/) > The following change for bug#25979 in Emacs 29: > > Don't clear out local variables in `with-help-window' > cd87a5c7a18 2022-05-13 17:14:36 +0200 > https://git.sv.gnu.org/cgit/emacs.git/commit/?id=cd87a5c7a18 > > removed the part of with-help-window that sets help-window-old-frame. > This was the only place where help-window-old-frame is ever set, so the > remaining code which checks its value now always gets the same result. I never tried to understand that patch so I cannot seriously comment on it. > The omission looks accidental to me, so I suggest reintroducing > help-window-old-frame to what is now help--window-setup: > > > > Otherwise, the variable should probably be declared obsolete, and its > redundant remnants removed. > > WDYT? I completely trust you to DTRT here. martin
bug-gnu-emacs@HIDDEN:bug#80505; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 27 Feb 2026 21:20:03 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Feb 27 16:20:03 2026 Received: from localhost ([127.0.0.1]:54249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1vw5Fh-0004x8-I1 for submit <at> debbugs.gnu.org; Fri, 27 Feb 2026 16:20:02 -0500 Received: from lists.gnu.org ([2001:470:142::17]:48832) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <basil@HIDDEN>) id 1vw5Fe-0004vi-BE for submit <at> debbugs.gnu.org; Fri, 27 Feb 2026 16:19:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <basil@HIDDEN>) id 1vw5FY-0002aW-Ax for bug-gnu-emacs@HIDDEN; Fri, 27 Feb 2026 16:19:52 -0500 Received: from mta-14-3.privateemail.com ([198.54.127.110]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <basil@HIDDEN>) id 1vw5FV-0006Ah-Jn for bug-gnu-emacs@HIDDEN; Fri, 27 Feb 2026 16:19:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=contovou.net; s=default; t=1772227182; bh=Fmqxg6deC29031rc874A8i/gAOjvYBiBsBEr2rspxAk=; h=From:To:Subject:Date:From; b=GnI+0x4CsD3KOpayb6nZIP/vGSfrLehB8T4wPx5x/VOyWtWgQWo4Tiv2aufU8HfcH KoTbP5i9Oq2cSEr924xqSMbffPEn+F4lJm3cRghN0otRKo2j1NTv9hHVTsqT27Kyix F2YFNx0XCX+oi8eb5269/9a561pJ0nkXY/hHtIc5JS3DIJ4QXhlHXNt+y8zrPqlVa2 KaXRibpx6sPqI0/8/HECiAMiIG+igddQZxtf+S37B4WG7c6zdfgdH7z+jMu5ofqZ9O zGjSVKDlSCe9wEyAbW0ep8c0hzQxFjPYk7xyt2LWIiCCd/8a+PMJw0Ym1mfxmYVx94 VCikTNFfnEv2A== Received: from mta-14.privateemail.com (localhost [127.0.0.1]) by mta-14.privateemail.com (Postfix) with ESMTP id 4fN1Ry2CSGz3hhV6 for <bug-gnu-emacs@HIDDEN>; Fri, 27 Feb 2026 16:19:42 -0500 (EST) Received: from localhost (1F2EF519.nat.pool.telekom.hu [31.46.245.25]) by mta-14.privateemail.com (Postfix) with ESMTPA for <bug-gnu-emacs@HIDDEN>; Fri, 27 Feb 2026 16:19:41 -0500 (EST) From: "Basil L. Contovounesios" <basil@HIDDEN> To: bug-gnu-emacs@HIDDEN Subject: 29.4; help-window-old-frame is no longer set X-Debbugs-Cc: martin rudalics <rudalics@HIDDEN> Date: Fri, 27 Feb 2026 22:19:38 +0100 Message-ID: <87o6l9sx3p.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Virus-Scanned: ClamAV using ClamSMTP Received-SPF: pass client-ip=198.54.127.110; envelope-from=basil@HIDDEN; helo=MTA-14-3.privateemail.com X-Spam_score_int: -9 X-Spam_score: -1.0 X-Spam_bar: - X-Spam_report: (-1.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.706, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.401, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain The following change for bug#25979 in Emacs 29: Don't clear out local variables in `with-help-window' cd87a5c7a18 2022-05-13 17:14:36 +0200 https://git.sv.gnu.org/cgit/emacs.git/commit/?id=cd87a5c7a18 removed the part of with-help-window that sets help-window-old-frame. This was the only place where help-window-old-frame is ever set, so the remaining code which checks its value now always gets the same result. The omission looks accidental to me, so I suggest reintroducing help-window-old-frame to what is now help--window-setup: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=setq.diff diff --git a/lisp/help.el b/lisp/help.el index 76c3770fbba..49d4659ab02 100644 --- a/lisp/help.el +++ b/lisp/help.el @@ -2231,6 +2231,7 @@ with-help-window `(help--window-setup ,buffer-or-name (lambda () ,@body))) (defun help--window-setup (buffer callback) + (setq help-window-old-frame (selected-frame)) ;; Make `help-window-point-marker' point nowhere. The only place ;; where this should be set to a buffer position is within BODY. (set-marker help-window-point-marker nil) --=-=-= Content-Type: text/plain Otherwise, the variable should probably be declared obsolete, and its redundant remnants removed. WDYT? Thanks, -- Basil In GNU Emacs 29.4 (build 2, x86_64-pc-linux-gnu, X toolkit, cairo version 1.18.2, Xaw3d scroll bars) of 2024-11-29 built on tais Windowing system distributor 'The X.Org Foundation', version 11.0.12101021 System Description: Debian GNU/Linux forky/sid Configured using: 'configure --prefix=/home/blc/.local --program-suffix=-29.4-lucid --with-native-compilation --with-file-notification --with-x-toolkit=lucid --with-x' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XAW3D XDBE XIM XINPUT2 XPM LUCID ZLIB Important settings: value of $LANG: en_IE.UTF-8 locale-coding-system: utf-8-unix Major mode: ELisp/l Minor modes in effect: bug-reference-prog-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils misearch multi-isearch bug-reference byte-opt thingatpt cl-loaddefs comp comp-cstr warnings icons subr-x rx cl-seq cl-macs gv cl-extra help-mode bytecomp byte-compile cl-lib find-func mule-util info rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo x-toolkit xinput2 x multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 82479 9948) (symbols 48 7725 0) (strings 32 23292 3089) (string-bytes 1 718020) (vectors 16 17081) (vector-slots 8 327810 12294) (floats 8 31 44) (intervals 56 722 31) (buffers 984 14)) --=-=-=--
"Basil L. Contovounesios" <basil@HIDDEN>:rudalics@HIDDEN, bug-gnu-emacs@HIDDEN.
Full text available.rudalics@HIDDEN, bug-gnu-emacs@HIDDEN:bug#80505; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.