Received: (at 80908) by debbugs.gnu.org; 2 May 2026 11:22:07 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat May 02 07:22:06 2026 Received: from localhost ([127.0.0.1]:44594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1wJ8Q9-0008Ns-Ux for submit <at> debbugs.gnu.org; Sat, 02 May 2026 07:22:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47606) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1wJ8Q7-0008Me-LQ for 80908 <at> debbugs.gnu.org; Sat, 02 May 2026 07:22:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1wJ8Q2-0000qH-4n; Sat, 02 May 2026 07:21:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Bsy+/cXWqQwRDpWXaLn51cAuUPbHb8Gwb+2wWJWvKEA=; b=N62ovHCgiCeO AYtE+7U6XQ3qAnrkRb2pEkqtgjUjMqzb7NXGuiKesRLf6uooW/roY4Z46kTNQgNcr3lZ7gbr3OwDN x3sWHoTEodPYxIbNYsDs4mET9HG3j5+Ak3gevI2Qp28e+Fz0tkj6JOgN/yqpAYSOsZE4ieu/vpt+/ Uk+dyUDyVZ2yyQRJ4VbFBVzB+8HrMI+qPlAktfpqcxc4Q0sGTXZz7xef9ARXjNNGZmbkCTaehpkO0 0GIGhz3PX/ZFbh6sd/V9dUDvChwMB8WNSZLgqS0Jl4fej1rik5Aj7Okjr9K8Z3VzMdozmExM4zjc/ vy3KxKEvHagIuWpYkNExRA==; Date: Sat, 02 May 2026 14:21:40 +0300 Message-Id: <86v7d683az.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Chris Roberts <frayedultrasonicaligator@HIDDEN> In-Reply-To: <20260501152708.1ed78879@cdr> (message from Chris Roberts on Fri, 1 May 2026 15:27:08 +0200) Subject: Re: bug#80908: [PATCH] Minor improvements for the built-in sqlite integration References: <20260426160550.08582df8@cdr> <86eck07k0p.fsf@HIDDEN> <20260430185214.397affb1@cdr> <86a4uj3cmy.fsf@HIDDEN> <20260501152708.1ed78879@cdr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 80908 Cc: 80908 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Fri, 1 May 2026 15:27:08 +0200 > From: Chris Roberts <frayedultrasonicaligator@HIDDEN> > Cc: 80908 <at> debbugs.gnu.org > > > Please uses should/should-not/should-error at least once in each test. > > These are the predicates tested by the test suite and considered to be > > the pass criteria for the tests. > > Sure, that makes sense; I sent a corrected patch. I decided to check if > the return value of the two `sqlite-close' calls is `eq' because I > believe the return value should be the same whether `sqlite-close' was > a no-op or actually closed the db, for consistency. Thanks, now installed.
bug-gnu-emacs@HIDDEN:bug#80908; Package emacs.
Full text available.
Received: (at 80908) by debbugs.gnu.org; 1 May 2026 13:27:17 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 01 09:27:17 2026
Received: from localhost ([127.0.0.1]:34692 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1wIntk-0007qM-0m
for submit <at> debbugs.gnu.org; Fri, 01 May 2026 09:27:17 -0400
Received: from layka.disroot.org ([178.21.23.139]:37186)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <frayedultrasonicaligator@HIDDEN>)
id 1wIntg-0007pY-Ek
for 80908 <at> debbugs.gnu.org; Fri, 01 May 2026 09:27:13 -0400
Received: from mail01.disroot.lan (localhost [127.0.0.1])
by disroot.org (Postfix) with ESMTP id 51D4E2672E;
Fri, 1 May 2026 15:27:10 +0200 (CEST)
X-Virus-Scanned: SPAM Filter at disroot.org
Received: from layka.disroot.org ([127.0.0.1])
by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP
id Mhm86QH9LP0q; Fri, 1 May 2026 15:27:09 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail;
t=1777642029; bh=zxqUhEMK/37c+6MfDsNw+UwAAqOWzOQE9L8ejXCwZ6A=;
h=Date:From:To:Cc:Subject:In-Reply-To:References;
b=MX2ra3cUT6jXq1H0K3A2mJvNwhfQfw058SqKnNg2cBPYpMV501Yr350NR2fJ7KmI3
2qCgylEMKCANkkolvn/ThTEs+pfaCMAFmW8ovPLRDHuNKZ0APg2Qpa7LVoyZp4Gh/k
CrJYRy3LawnDl2dZEbYapKn8QaEdPHF00QwwyvF2I6+rmfqN3Ud9d/RR0kmLdbnzYx
JimUJbfsZ7FnbN8IF6pigPvNuMxXf7TBCBgPaWxL79dyVBQl47e9nYLeSUQkB0I53z
AIPhli1dcOYa8PgpGAbV+FceLbf22Y1vWGd4y9kxyZen1yLZ8uPOBAE5GlGJ7BwZ4v
v8B9Op7x+LV7Q==
Date: Fri, 1 May 2026 15:27:08 +0200
From: Chris Roberts <frayedultrasonicaligator@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#80908: [PATCH] Minor improvements for the built-in sqlite
integration
Message-ID: <20260501152708.1ed78879@cdr>
In-Reply-To: <86a4uj3cmy.fsf@HIDDEN>
References: <20260426160550.08582df8@cdr> <86eck07k0p.fsf@HIDDEN>
<20260430185214.397affb1@cdr> <86a4uj3cmy.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="MP_/xVYOmP5WfjZ_VgiuNUTsEZV"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 80908
Cc: 80908 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--MP_/xVYOmP5WfjZ_VgiuNUTsEZV
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
> On Fri, 01 May 2026 08:46:45 +0300
> Eli Zaretskii wrote:
>
> You can keep posting patches in parallel with the assignment process.
> We can accept a few more small changes from you, and will tel you when
> there's a need to wait.
Okay.
> Please uses should/should-not/should-error at least once in each test.
> These are the predicates tested by the test suite and considered to be
> the pass criteria for the tests.
Sure, that makes sense; I sent a corrected patch. I decided to check if
the return value of the two `sqlite-close' calls is `eq' because I
believe the return value should be the same whether `sqlite-close' was
a no-op or actually closed the db, for consistency.
--MP_/xVYOmP5WfjZ_VgiuNUTsEZV
Content-Type: text/x-patch
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename=0001-Add-a-test-for-sqlite-close.patch
From 2b697b0cf82b3597ed9ab93afbce94f9794a714f Mon Sep 17 00:00:00 2001
From: Chris Roberts <git@HIDDEN>
Date: Fri, 1 May 2026 15:23:27 +0200
Subject: [PATCH] ; Add a test for sqlite-close
* test/src/sqlite-tests.el (sqlite-closed-db): Add test.
---
test/src/sqlite-tests.el | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/test/src/sqlite-tests.el b/test/src/sqlite-tests.el
index a9fab7da681..bcd80124dfd 100644
--- a/test/src/sqlite-tests.el
+++ b/test/src/sqlite-tests.el
@@ -185,6 +185,14 @@ sqlite-close-dbs
(sqlite-close db)
(should-error (sqlite-select db "select * from test6"))))
+(ert-deftest sqlite-closed-db ()
+ "Verify that `sqlite-close' on a closed database is a no-op."
+ (skip-unless (sqlite-available-p))
+ (let (db)
+ (setq db (sqlite-open))
+ (should (eq (sqlite-close db)
+ (sqlite-close db)))))
+
(ert-deftest sqlite-load-extension ()
(skip-unless (sqlite-available-p))
(skip-unless (fboundp 'sqlite-load-extension))
--
2.34.1
--MP_/xVYOmP5WfjZ_VgiuNUTsEZV--
bug-gnu-emacs@HIDDEN:bug#80908; Package emacs.
Full text available.Received: (at 80908) by debbugs.gnu.org; 1 May 2026 05:47:02 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 01 01:47:02 2026 Received: from localhost ([127.0.0.1]:33335 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1wIgiL-0002y8-Gu for submit <at> debbugs.gnu.org; Fri, 01 May 2026 01:47:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37352) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1wIgiI-0002xM-Tx for 80908 <at> debbugs.gnu.org; Fri, 01 May 2026 01:46:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1wIgiC-00040G-RK; Fri, 01 May 2026 01:46:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/Od8uDxVtxpwMI5Kq50iJFZbym5dYNsy5On0wBK+o9Q=; b=GAKt5xddZBVs tXe08EZzdNtHhQSdratCPESdlx+rwyWlXw2nMfCN8iV8GyTCYwPaugFL0mYFpXYjVBCOUoIjMMkv6 XkHgU7wXmCbIF+mnuIABK2nToj7/0nPypzDLMBxpzN60jreOLp8gs3YbZYDGv3lzKI9eWurYNPEFv RyWHegI65+wrmajD8jiwkJ/0V2OKix9OrvnvPEqB/TCyCv/hKJOpKHkllUJPWODErBBJqUSoTxxLG 4sZqhoulIcSNr71Gc/SZ6XsxdiE7XrcyDA33Og3GZmqK8NzckimPoyqx1EaOyTlGtloMrFDb5F0aS VcYyqpx4qx6DetrEfPvssw==; Date: Fri, 01 May 2026 08:46:45 +0300 Message-Id: <86a4uj3cmy.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Chris Roberts <frayedultrasonicaligator@HIDDEN> In-Reply-To: <20260430185214.397affb1@cdr> (message from Chris Roberts on Thu, 30 Apr 2026 18:52:14 +0200) Subject: Re: bug#80908: [PATCH] Minor improvements for the built-in sqlite integration References: <20260426160550.08582df8@cdr> <86eck07k0p.fsf@HIDDEN> <20260430185214.397affb1@cdr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 80908 Cc: 80908 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Thu, 30 Apr 2026 18:52:14 +0200 > From: Chris Roberts <frayedultrasonicaligator@HIDDEN> > Cc: 80908 <at> debbugs.gnu.org > > Thank you. I was not aware of the tests; I have added one in the > attached patch. Thanks. > Since this brings me to around 15 lines of contributed code, should I > hold off on sending more patches until I have the copyright assignment > sorted out? You can keep posting patches in parallel with the assignment process. We can accept a few more small changes from you, and will tel you when there's a need to wait. > +(ert-deftest sqlite-closed-db () > + "Verify that `sqlite-close' on a closed database is a no-op." > + (skip-unless (sqlite-available-p)) > + (let (db) > + (setq db (sqlite-open)) > + (sqlite-close db) > + (sqlite-close db))) Please uses should/should-not/should-error at least once in each test. These are the predicates tested by the test suite and considered to be the pass criteria for the tests.
bug-gnu-emacs@HIDDEN:bug#80908; Package emacs.
Full text available.
Received: (at 80908) by debbugs.gnu.org; 30 Apr 2026 16:52:26 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 30 12:52:25 2026
Received: from localhost ([127.0.0.1]:56500 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1wIUch-0002Yc-DP
for submit <at> debbugs.gnu.org; Thu, 30 Apr 2026 12:52:25 -0400
Received: from layka.disroot.org ([178.21.23.139]:46098)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <frayedultrasonicaligator@HIDDEN>)
id 1wIUcc-0002XJ-7U
for 80908 <at> debbugs.gnu.org; Thu, 30 Apr 2026 12:52:21 -0400
Received: from mail01.disroot.lan (localhost [127.0.0.1])
by disroot.org (Postfix) with ESMTP id 5B89227186;
Thu, 30 Apr 2026 18:52:16 +0200 (CEST)
X-Virus-Scanned: SPAM Filter at disroot.org
Received: from layka.disroot.org ([127.0.0.1])
by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP
id rr5ssQhm_mNj; Thu, 30 Apr 2026 18:52:15 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail;
t=1777567935; bh=s34+6epiV0+PjnMkSzeaYPri8elupY9WfuARVYDHNqs=;
h=Date:From:To:Cc:Subject:In-Reply-To:References;
b=FnoHFi1xEHugWq9cCTbvvslaMYlCnJQVM1RIV3I/zU9OJJ6UjGMysjkOtt0ZbtD6P
KPSuX70gP/7NCWxGX83U9bj16keKQBcayeBPsUqKPdraU5poF8QA3tGKUZsPYcAd9+
QOLzyBFMCutSC/lMvY6vRfttJQUXDTNgoheCUxoJ5zctEUTvo9X6t+vnxk1vkK9VdP
yJnrIrpevMPbAprrVn+WmwdNazqjaC5W/gdqLfclkDlC1EDq9bq7oYTqSXHL11blTh
BI1FzDxepe99ADg6f2xveWwHoWINQjaKjaxCzhY/A3lkJX/rkVU3zepoivT7rn6n7c
K2C0MJPgtd4DA==
Date: Thu, 30 Apr 2026 18:52:14 +0200
From: Chris Roberts <frayedultrasonicaligator@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#80908: [PATCH] Minor improvements for the built-in sqlite
integration
Message-ID: <20260430185214.397affb1@cdr>
In-Reply-To: <86eck07k0p.fsf@HIDDEN>
References: <20260426160550.08582df8@cdr>
<86eck07k0p.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="MP_/PE=v7rqUeIp0fmjxf6x_hIz"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 80908
Cc: 80908 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--MP_/PE=v7rqUeIp0fmjxf6x_hIz
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
> On Mon, 27 Apr 2026 13:52:22 +0300
> Eli Zaretskii wrote:
>
> Thanks, I installed it.
>
> A couple of minor comments for the future:
>
> . Our convention is to leave 2 spaces between sentences, and also 2
> spaces between the end of a C comment and the closing "*/".
> . Changes which are visible to users and not bugfixes should be
> called out in NEWS
> . We usually like to add tests for new features, so bonus points for
> adding a test for this behavior to test/src/sqlite-tests.el
>
> (I fixed the first two of the above for you this time.)
Thank you. I was not aware of the tests; I have added one in the
attached patch.
Since this brings me to around 15 lines of contributed code, should I
hold off on sending more patches until I have the copyright assignment
sorted out?
--MP_/PE=v7rqUeIp0fmjxf6x_hIz
Content-Type: text/x-patch
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename=0001-Add-a-test-for-sqlite-close.patch
From 67eae03548ba0f6651220d3f92827014c24ee0ba Mon Sep 17 00:00:00 2001
From: Chris Roberts <git@HIDDEN>
Date: Thu, 30 Apr 2026 18:49:38 +0200
Subject: [PATCH] ; Add a test for sqlite-close
* test/src/sqlite-tests.el (sqlite-closed-db): Add test.
---
test/src/sqlite-tests.el | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/test/src/sqlite-tests.el b/test/src/sqlite-tests.el
index a9fab7da681..9d42bd56964 100644
--- a/test/src/sqlite-tests.el
+++ b/test/src/sqlite-tests.el
@@ -185,6 +185,14 @@ sqlite-close-dbs
(sqlite-close db)
(should-error (sqlite-select db "select * from test6"))))
+(ert-deftest sqlite-closed-db ()
+ "Verify that `sqlite-close' on a closed database is a no-op."
+ (skip-unless (sqlite-available-p))
+ (let (db)
+ (setq db (sqlite-open))
+ (sqlite-close db)
+ (sqlite-close db)))
+
(ert-deftest sqlite-load-extension ()
(skip-unless (sqlite-available-p))
(skip-unless (fboundp 'sqlite-load-extension))
--
2.34.1
--MP_/PE=v7rqUeIp0fmjxf6x_hIz--
bug-gnu-emacs@HIDDEN:bug#80908; Package emacs.
Full text available.
Received: (at 80908) by debbugs.gnu.org; 27 Apr 2026 10:52:51 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 27 06:52:51 2026
Received: from localhost ([127.0.0.1]:39669 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1wHJa7-0003fo-7m
for submit <at> debbugs.gnu.org; Mon, 27 Apr 2026 06:52:51 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:50688)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1wHJa5-0003fK-BY
for 80908 <at> debbugs.gnu.org; Mon, 27 Apr 2026 06:52:50 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1wHJZz-0004tg-Jn; Mon, 27 Apr 2026 06:52:43 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=u3wQfn2gv8zLUpy5ELrZAEW/CLVhdUSCyddn8YESIn8=; b=UcQ7xidmje+6
4nOGpS5M6n1krkx3odxiJNY+aWAgRfT+HVnsSOeeYJQHyimmagojMm1aGLEOdtzvHWlLI134ZuCoT
+x/xpVw/mTdhq56buFoAWWC0pdWdL8zg+v9Bntg+C/IRBOJu5+n4yatxE4VkYgba5wWS5JjFh8Pfz
BONZgYR3DHUC1fGUz6NjrhbnsHiA+qMCc1aFfKYDAJ0E6qmeC/nKz6ivoBJ83y6/Iu91KOLeqDRJD
OiqMIw/zRrwXBXc4Iq+CxIDqTSEeVX5nxIFSVHZ4+xHJRWLGmgv6qEXfOLAnengwvCp9JZAJ9SOWk
Rj9R8qLsjuh2O8I4rQqjqA==;
Date: Mon, 27 Apr 2026 13:52:22 +0300
Message-Id: <86eck07k0p.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Chris Roberts <frayedultrasonicaligator@HIDDEN>
In-Reply-To: <20260426160550.08582df8@cdr> (bug-gnu-emacs@HIDDEN)
Subject: Re: bug#80908: [PATCH] Minor improvements for the built-in sqlite
integration
References: <20260426160550.08582df8@cdr>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 80908
Cc: 80908 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> Date: Sun, 26 Apr 2026 16:05:50 +0200
> From: Chris Roberts via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
>
> Last month I suggested three minor improvements to sqlite.c on
> emacs-devel, in a thread titled "Improvement suggestions for the
> built-in sqlite integration". They were as follows:
>
> Suggestion 1: a function to check if the connection is open/closed
> Suggestion 2: sqlite-close on a closed connection should be a noop
> Suggestion 3: expose the database name to the user
>
> You can see said thread for the rationale behind these suggestions.
>
> I am attaching here a patch to implement Suggestion 2, and hopefully
> will be able to follow up with 1 and 3 as well. I tried to follow the
> guidelines to the best of my ability, but please let me know if I
> missed anything, or if something should be corrected.
Thanks, I installed it.
A couple of minor comments for the future:
. Our convention is to leave 2 spaces between sentences, and also 2
spaces between the end of a C comment and the closing "*/".
. Changes which are visible to users and not bugfixes should be
called out in NEWS
. We usually like to add tests for new features, so bonus points for
adding a test for this behavior to test/src/sqlite-tests.el
(I fixed the first two of the above for you this time.)
> P.S. The email address listed in the patch is an alias that forwards
> all email to the address I'm sending this message from. If this is a
> problem, feel free to replace said alias with the direct address.
I don't think the email is important to us.
bug-gnu-emacs@HIDDEN:bug#80908; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 26 Apr 2026 15:29:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Apr 26 11:29:18 2026
Received: from localhost ([127.0.0.1]:56516 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1wH1Q5-0005id-3n
for submit <at> debbugs.gnu.org; Sun, 26 Apr 2026 11:29:18 -0400
Received: from lists1p.gnu.org ([2001:470:142::17]:42856)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <frayedultrasonicaligator@HIDDEN>)
id 1wH07r-0007Xg-54
for submit <at> debbugs.gnu.org; Sun, 26 Apr 2026 10:06:24 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <frayedultrasonicaligator@HIDDEN>)
id 1wH07U-0005wy-Lb
for bug-gnu-emacs@HIDDEN; Sun, 26 Apr 2026 10:06:03 -0400
Received: from layka.disroot.org ([178.21.23.139])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <frayedultrasonicaligator@HIDDEN>)
id 1wH07Q-0007D0-Vw
for bug-gnu-emacs@HIDDEN; Sun, 26 Apr 2026 10:05:59 -0400
Received: from mail01.disroot.lan (localhost [127.0.0.1])
by disroot.org (Postfix) with ESMTP id A8305271C3
for <bug-gnu-emacs@HIDDEN>; Sun, 26 Apr 2026 16:05:51 +0200 (CEST)
X-Virus-Scanned: SPAM Filter at disroot.org
Received: from layka.disroot.org ([127.0.0.1])
by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP
id 8-z3xO9vuzKD for <bug-gnu-emacs@HIDDEN>;
Sun, 26 Apr 2026 16:05:51 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail;
t=1777212351; bh=vAWVtQfdRwsg8EHhgn5lAiBDg/84aOIcWO9lozCbnvA=;
h=Date:From:To:Subject;
b=HJlJaQftrQhznlSqrmO+oNCXfiyPwISIyegToErEfRqDszCb15+TBtOELFB1juVcc
cGRMhry7fnOaI+5nnzx9JCRiyoy2gxEbwKUlDK3/A1+OrucHfnKK4mzc7WbMXu8g7x
gIi0f/1ef2/D6skVOTaPX3O4EwcpWpMCo3oI7foEVsXMRYDGasav3XmyXAzI1ShgMz
RXZgwlj7nGOcnhp8Jts8cM+S2zti/0Rdbu4CK5Uqh70a9o2O5Dy0Zbx7WEdq5SUqrx
SzAhJ3LIfQebERD46M+TlUl0S0OmAP8ihC61vvuSBUw945GQPS5R0o14daFll138I1
DnE/lwsnBwlUg==
Date: Sun, 26 Apr 2026 16:05:50 +0200
From: Chris Roberts <frayedultrasonicaligator@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: [PATCH] Minor improvements for the built-in sqlite integration
Message-ID: <20260426160550.08582df8@cdr>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="MP_/LFD2Zo4KlrEpI/+8vJ7MKeO"
Received-SPF: pass client-ip=178.21.23.139;
envelope-from=frayedultrasonicaligator@HIDDEN; helo=layka.disroot.org
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Sun, 26 Apr 2026 11:29:15 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)
--MP_/LFD2Zo4KlrEpI/+8vJ7MKeO
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Hello,
Last month I suggested three minor improvements to sqlite.c on
emacs-devel, in a thread titled "Improvement suggestions for the
built-in sqlite integration". They were as follows:
Suggestion 1: a function to check if the connection is open/closed
Suggestion 2: sqlite-close on a closed connection should be a noop
Suggestion 3: expose the database name to the user
You can see said thread for the rationale behind these suggestions.
I am attaching here a patch to implement Suggestion 2, and hopefully
will be able to follow up with 1 and 3 as well. I tried to follow the
guidelines to the best of my ability, but please let me know if I
missed anything, or if something should be corrected.
P.S. The email address listed in the patch is an alias that forwards
all email to the address I'm sending this message from. If this is a
problem, feel free to replace said alias with the direct address.
-- Chris Roberts
--MP_/LFD2Zo4KlrEpI/+8vJ7MKeO
Content-Type: text/x-patch
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename=0001-sqlite-close-no-op-for-already-closed-connections.patch
From 2fa4dccd83068e7182653b1ca033ef48e870bac2 Mon Sep 17 00:00:00 2001
From: Chris Roberts <git@HIDDEN>
Date: Sun, 26 Apr 2026 15:28:29 +0200
Subject: [PATCH] sqlite-close: no-op for already closed connections
This behavior is more expected than throwing an error,
as passing NULL (closed db connection) to sqlite3_close
is a "harmless no-op" according to the documentation.
* src/sqlite.c (sqlite-close): Ignore already closed connections.
---
src/sqlite.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/src/sqlite.c b/src/sqlite.c
index 244bb7bb027..97399339817 100644
--- a/src/sqlite.c
+++ b/src/sqlite.c
@@ -330,6 +330,11 @@ DEFUN ("sqlite-close", Fsqlite_close, Ssqlite_close, 1, 1, 0,
doc: /* Close the sqlite database DB. */)
(Lisp_Object db)
{
+ /* Do nothing when the connection is already closed.
+ This aligns with the behavior of sqlite3_close. */
+ if (SQLITE (db) && !XSQLITE (db)->db)
+ return Qt;
+
check_sqlite (db, false);
sqlite3_close (XSQLITE (db)->db);
XSQLITE (db)->db = NULL;
--
2.34.1
--MP_/LFD2Zo4KlrEpI/+8vJ7MKeO--
Chris Roberts <frayedultrasonicaligator@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#80908; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.