Received: (at 80988) by debbugs.gnu.org; 4 Jun 2026 14:58:27 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jun 04 10:58:26 2026 Received: from localhost ([127.0.0.1]:36093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1wV9Wc-0005kl-Jk for submit <at> debbugs.gnu.org; Thu, 04 Jun 2026 10:58:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55840) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1wV9Wa-0005kN-3X for 80988 <at> debbugs.gnu.org; Thu, 04 Jun 2026 10:58:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1wV9WT-0004lo-4l; Thu, 04 Jun 2026 10:58:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=P2j8g6XG8IEXj1lh28XjiqIf1DLoSer+H3BBULPi5YM=; b=JPMBflYQjsFrY6oaDLQB lbYJgHaBftA9rWiITETvFnU3rCm/wxuq4jO3Mat52/zmEYHSHge6PuDEYgsqRm7teHf47iMgjpaa7 /P7MNTgxgSmaaM91UTkymbLqv/lMO6OWfDsOGqq7ZJcY5VRwGcBBJRgapfctjkUw4kZMIQg8hGqMB 0Z3vdRyfv6vosLyQwqdL9N9KYU864qLka4i4zQ784xJFWxWB8tbkS35sqaDefVTrkRKClL5hq7nLX 4OdqLZ08R+nWnwk5wKACb6Dsk8fzjsXBWMeL/vbUr4KmjieV3f+g19+fMCFCF/VNpGXE5sV0Q8Zkq UoCZaRh6VsmzKQ==; Date: Thu, 04 Jun 2026 17:58:13 +0300 Message-Id: <86se72s67u.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Stefan Monnier <monnier@HIDDEN> In-Reply-To: <jwvwlwexti5.fsf-monnier+emacs@HIDDEN> (bug-gnu-emacs@HIDDEN) Subject: Re: bug#80988: 31.0.50; Progress report (commit f5f2306fc1d) References: <875x4yl7fm.fsf@HIDDEN> <CAN+1Hbrs_rFU35hBUaKa-AA7eaYZOmnPBMaw-Di5hDrCsd9uOA@HIDDEN> <878q9rquo1.fsf@HIDDEN> <CAN+1HbpJP7aWDioF1GSBHh0Bem8Od1_Ea_qJqoyx0+ptNaDaJg@HIDDEN> <CAN+1Hbq00c0WZnYuf_hatUweO3-0tGMJge1BQDpzmaQANbF3LA@HIDDEN> <jwvbje2f5m3.fsf-monnier+emacs@HIDDEN> <CAN+1HboAqmXqWbXNq=BQUjpQGRh==xzZF356C44DSdtbGLU35g@HIDDEN> <jwvh5nsioyh.fsf-monnier+emacs@HIDDEN> <CAN+1Hbp5i=33WotqfnXwKZUKAZ9apVqVuoNZW5WkjLJU0P7XPw@HIDDEN> <jwvbje0im50.fsf-monnier+emacs@HIDDEN> <CAN+1HbpMd-VFozDHjUCf07RKje-4jQL74BZ9MUNBYOYgHKE-Vw@HIDDEN> <jwvse7ba9yt.fsf-monnier+emacs@HIDDEN> <CAN+1Hbofbr=U2Ns3vCyPAoSHmc5mrEVpDgv=RAex9PDNS=qRRA@HIDDEN> <jwvpl2e0wz1.fsf-monnier+emacs@HIDDEN> <CAN+1Hboawe3PtgdozkWw4iVnK+LGARYqKeh3=a3L8qQKGEXZsg@HIDDEN> <jwvwlwexti5.fsf-monnier+emacs@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 80988 Cc: arstoffel@HIDDEN, azeng@HIDDEN, 80988 <at> debbugs.gnu.org, shipmints@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Cc: Augusto Stoffel <arstoffel@HIDDEN>, Aaron Zeng <azeng@HIDDEN>, > Stéphane Marks <shipmints@HIDDEN> > Date: Thu, 04 Jun 2026 10:38:18 -0400 > From: Stefan Monnier via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> > > Eli? Sean? Philip? Any objection to pushing this to `emacs-31`? > I think it's an important fix to the new > `progress-reporter-update-functions` API. No objections from me.
bug-gnu-emacs@HIDDEN:bug#80988; Package emacs.
Full text available.
Received: (at 80988) by debbugs.gnu.org; 4 Jun 2026 14:38:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jun 04 10:38:30 2026
Received: from localhost ([127.0.0.1]:35836 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1wV9DK-0004FH-6L
for submit <at> debbugs.gnu.org; Thu, 04 Jun 2026 10:38:30 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:48949)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <monnier@HIDDEN>)
id 1wV9DH-0004F3-5c
for 80988 <at> debbugs.gnu.org; Thu, 04 Jun 2026 10:38:28 -0400
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 235C310016C;
Thu, 04 Jun 2026 10:38:21 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1780583899;
bh=hK1POoGY0bG3/pU8YRLAc+mQsNYx9dQrCq6jaTQEP0s=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=gcAcDVy58qhP5nqGiQLJY0xXMAiS5JreaXLfoJev86xk8zYJMdxs5wF1uh1PDzz0b
BbkQJbMuARSA5QuRwl3hhb9ifL6xcJRgJrtICqdbW3+LzCNs0th3rBeZynb/tPrG9i
Ag2BuIVSZlke/zbmpH0YNjmApjM0OJSIZe3gPrm+si+kzg8i/txJm81jqXkUDDWi4q
WT03HA64OMJhSl3Pp5EnBOk4qq30AVTzwGN2MjOPLlNlQrczHvGpwnQqll14euooN0
pJzwLpNqgjYQpv5XzXQ4+E0Y7vxFyn4hJ67GdMcOA22X5T+nVtyT5JDvTHsTpdActR
L8FsKsUCH9Kfw==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id DBA311000F0;
Thu, 04 Jun 2026 10:38:19 -0400 (EDT)
Received: from pastel (unknown [104.247.237.64])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A9240120709;
Thu, 4 Jun 2026 10:38:19 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: 80988 <at> debbugs.gnu.org
Subject: Re: bug#80988: 31.0.50; Progress report (commit f5f2306fc1d)
In-Reply-To: <CAN+1Hboawe3PtgdozkWw4iVnK+LGARYqKeh3=a3L8qQKGEXZsg@HIDDEN>
Message-ID: <jwvwlwexti5.fsf-monnier+emacs@HIDDEN>
References: <875x4yl7fm.fsf@HIDDEN>
<CAN+1Hbrs_rFU35hBUaKa-AA7eaYZOmnPBMaw-Di5hDrCsd9uOA@HIDDEN>
<878q9rquo1.fsf@HIDDEN>
<CAN+1HbpJP7aWDioF1GSBHh0Bem8Od1_Ea_qJqoyx0+ptNaDaJg@HIDDEN>
<CAN+1Hbq00c0WZnYuf_hatUweO3-0tGMJge1BQDpzmaQANbF3LA@HIDDEN>
<jwvbje2f5m3.fsf-monnier+emacs@HIDDEN>
<CAN+1HboAqmXqWbXNq=BQUjpQGRh==xzZF356C44DSdtbGLU35g@HIDDEN>
<jwvh5nsioyh.fsf-monnier+emacs@HIDDEN>
<CAN+1Hbp5i=33WotqfnXwKZUKAZ9apVqVuoNZW5WkjLJU0P7XPw@HIDDEN>
<jwvbje0im50.fsf-monnier+emacs@HIDDEN>
<CAN+1HbpMd-VFozDHjUCf07RKje-4jQL74BZ9MUNBYOYgHKE-Vw@HIDDEN>
<jwvse7ba9yt.fsf-monnier+emacs@HIDDEN>
<CAN+1Hbofbr=U2Ns3vCyPAoSHmc5mrEVpDgv=RAex9PDNS=qRRA@HIDDEN>
<jwvpl2e0wz1.fsf-monnier+emacs@HIDDEN>
<CAN+1Hboawe3PtgdozkWw4iVnK+LGARYqKeh3=a3L8qQKGEXZsg@HIDDEN>
Date: Thu, 04 Jun 2026 10:38:18 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL 0.073 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 80988
Cc: Augusto Stoffel <arstoffel@HIDDEN>, Aaron Zeng <azeng@HIDDEN>,
=?windows-1252?Q?St=E9phane?= Marks <shipmints@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Eli? Sean? Philip? Any objection to pushing this to `emacs-31`?
I think it's an important fix to the new
`progress-reporter-update-functions` API.
=3D=3D=3D Stefan
> Agreed. Revised attached.
>
> -St=E9phane
> From 94a75a37e1a8d49589f54252f571e696dc4c8745 Mon Sep 17 00:00:00 2001
> From: =3D?UTF-8?q?St=3DC3=3DA9phane=3D20Marks?=3D <shipmints@HIDDEN>
> Date: Wed, 27 May 2026 16:05:23 -0400
> Subject: [PATCH] Improve progress-reporter state to remove hard coded len=
gth
> (bug#80988)
>
> Remove hard-coded state range, now a monotonically increasing
> integer.
>
> * lisp/subr.el (progress-reporter-update-functions): Update
> docstring.
> (progress-reporter-echo-area): Use
> 'progress-reporter--pulse-characters' length.
> (progress-reporter-do-update): Increase 'state' by 1 each pass.
> *
> lisp/system-taskbar.el (system-taskbar--progress-reporter-update):
> Make steps independent of 'progress-reporter-echo-area' steps.
> ---
> lisp/subr.el | 12 ++++++------
> lisp/system-taskbar.el | 4 +++-
> 2 files changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/lisp/subr.el b/lisp/subr.el
> index d97598ab61f..16234d313a7 100644
> --- a/lisp/subr.el
> +++ b/lisp/subr.el
> @@ -7114,8 +7114,7 @@ progress-reporter-update-functions
> STATE can be one of:
> - A float representing the percentage complete in the range 0.0-1.0
> for a numeric reporter.
> -- An integer representing the index which cycles through the range 0-3
> -for a pulsing reporter.
> +- A monotonically increasing integer for a pulsing reporter.
> - The symbol `done' to indicate that the progress reporter is complete.")
>=20=20
> (defsubst progress-reporter-update (reporter &optional value suffix)
> @@ -7130,7 +7129,7 @@ progress-reporter-update
> Optional argument SUFFIX is a string to be displayed after REPORTER's
> main message and progress text. If REPORTER is a non-numerical
> reporter, then VALUE should be nil, or a string to use instead of
> -SUFFIX. SUFFIX is considered obsolete and may be removed in the future.
> +SUFFIX.
>=20=20
> See `progress-reporter-update-functions' for the list of functions
> called on each update.
> @@ -7241,8 +7240,9 @@ progress-reporter-echo-area
> (message "%s" text)))
> ((pred integerp)
> (let ((message-log-max nil)
> - (pulse-char (aref progress-reporter--pulse-characters
> - state)))
> + (pulse-char
> + (aref progress-reporter--pulse-characters
> + (mod state (length progress-reporter--pulse-charac=
ters)))))
> (message "%s %s" text pulse-char)))
> ('done
> (message "%sdone" text))))))
> @@ -7294,7 +7294,7 @@ progress-reporter-do-update
> (if suffix
> (aset parameters 6 suffix)
> (setq suffix (or (aref parameters 6) "")))
> - (let ((index (mod (1+ (car reporter)) 4)))
> + (let ((index (1+ (car reporter))))
> (setcar reporter index)
> (run-hook-with-args 'progress-reporter-update-functions
> reporter
> diff --git a/lisp/system-taskbar.el b/lisp/system-taskbar.el
> index cc41183fb32..973b426e026 100644
> --- a/lisp/system-taskbar.el
> +++ b/lisp/system-taskbar.el
> @@ -282,7 +282,9 @@ system-taskbar--progress-reporter-update
> ((pred floatp)
> (system-taskbar--progress state))
> ((pred integerp)
> - (system-taskbar--progress (/ (1+ state) 4.0)))
> + ;; This won't show 0.0 to indicate work in process until done.
> + (system-taskbar--progress
> + (/ (1+ (mod state 5)) 5.0)))
> ('done
> (system-taskbar--progress nil)))))
bug-gnu-emacs@HIDDEN:bug#80988; Package emacs.
Full text available.
Received: (at 80988) by debbugs.gnu.org; 3 Jun 2026 15:38:04 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jun 03 11:38:03 2026
Received: from localhost ([127.0.0.1]:43107 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1wUnfM-0007BZ-CP
for submit <at> debbugs.gnu.org; Wed, 03 Jun 2026 11:38:03 -0400
Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]:50386)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <arstoffel@HIDDEN>)
id 1wUnfH-0007Ar-1B
for 80988 <at> debbugs.gnu.org; Wed, 03 Jun 2026 11:37:57 -0400
Received: by mail-wm1-x32d.google.com with SMTP id
5b1f17b1804b1-490b09e4cccso18956865e9.0
for <80988 <at> debbugs.gnu.org>; Wed, 03 Jun 2026 08:37:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20251104; t=1780501073; x=1781105873; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:message-id:date:references
:in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id
:reply-to; bh=+Esj/n5SllJkWs4Qz2OuffTsKTlLuHz2dkCWeDNeFOw=;
b=m2VPANqmKevqGd1/oTagnMvkGbcl1AgO+dXxCm78AKrPfsaytFKR7/XSESxZj+Iciv
ocBlDLCUOtZfGebYndT4W7v5MnDNQgxJ9hzpu7NpLyo0aHHD0D4g9P/L80c/nNH9+/QX
uCY5uQ9YzyulTZ73hobxpKxn29YSLPuJKsLfZjLpQHvovrTxyOL9itdU56S774EnrYUf
VC9IgjPYFckafFwV11VIvH8QxdOFGCH4L5T+D/ydlH2x3hGJIcnRyYi6xis6NuHtkHmi
U0hl1lqiMDK+/5Z2G4OMfzRFEKXQO1WZao7U40E4IDG6F1PWsNvWSlntFVNr2t2AvboJ
i45Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20251104; t=1780501073; x=1781105873;
h=content-transfer-encoding:mime-version:message-id:date:references
:in-reply-to:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to
:cc:subject:date:message-id:reply-to;
bh=+Esj/n5SllJkWs4Qz2OuffTsKTlLuHz2dkCWeDNeFOw=;
b=WYi8VRgRoOUBwHAazNcVI7kswTGb3JegbLtzKPJFp5eHhyNcLPNx0OcMAeuBgLAwZq
USJFc7DE0sm52l/GR3BQSDMkoJr7ckOco7rMae+yU6y8VAZx4vUPsxRf0xiRLEA+Z8bF
IFUVqTyupfMEuz73tIIhWdEqonKq6ht8/PpKxJRc34eg/Na6ad+6A4m0xsp60oTGGVr1
ibTQw4u5C3QPaykqnOLSR/LdFIFH1DY7rZQV3Yz0qyAfPJEhdP0yQqB/3ADebXCigRaA
dBDF2FCG5TP2PXGW5tvRJOCjG1bMXlZYRv3rIPeYJAoEYbvjiWOo8Jw8qeG33B4721xv
ES+Q==
X-Forwarded-Encrypted: i=1;
AFNElJ/2qDcpcT4ForFiOgNXA8gE+4vmehGI74AvVkUD9VYJtgtY+D544klUIM5BuJ3IjeLvlx2xdw==@debbugs.gnu.org
X-Gm-Message-State: AOJu0YzOpzkGyr5dIrB42w9Vl4vDnVnz+7URfiEC8ps+0VLP+AKvU7jt
zoeWmn1FVSiUPX45h8opk5mbyRzDFwCO6KZtf3wyU7sGTEyo9QxpQsjU
X-Gm-Gg: Acq92OEOTnh6ZOpfxQ4ZiDtMhEOlUKN+gu5sI/6YcSd8CIvUaqPtI3K8syxz/r6q/g5
9/i/NFT+I8Z2bD8AhxsgmY2D19hYD2xjCsLNDy+HMj7XBz16w5P17uPFAS45/FR03qwzhzc/Wxk
B/G/3O47gQwCK9CEft+W9rxuibxnlX0ECqTI+pWdHz7gTppz0BzRk6GYcsNCtH+/Gg0KG7JIs1o
YosJeC+W+kAQOjshCs30+SKe6C8ML+BC4HyjbIlktn0rFCa2RuGHB9ZAuC+x6FyFzD9G8+oFWhQ
jXOY72lvKGmtLt44bvHvh69WPNJX0/wKebxU2PZSKAXgUVIsQcQiawRGfIdMuvgK6JJ7nECG42V
F/S3PBIrX/g2qvS1/lDHUM12Bro9EEea9DS4nbd6IXPDHqZn43ckR5l1Xr4OO2lFsW40NKThSs5
mxnCkXC197WUF1RqQGaitj4XHzOKGMIejE
X-Received: by 2002:a05:600c:5394:b0:490:b0e0:3de2 with SMTP id
5b1f17b1804b1-490b60f9e98mr68995425e9.33.1780501073440;
Wed, 03 Jun 2026 08:37:53 -0700 (PDT)
Received: from ars3 ([94.134.79.83]) by smtp.gmail.com with ESMTPSA id
5b1f17b1804b1-490bc3e59f5sm151605e9.14.2026.06.03.08.37.52
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 03 Jun 2026 08:37:52 -0700 (PDT)
From: Augusto Stoffel <arstoffel@HIDDEN>
To: =?utf-8?Q?St=C3=A9phane?= Marks <shipmints@HIDDEN>
Subject: Re: bug#80988: 31.0.50; Progress report (commit f5f2306fc1d)
In-Reply-To: <CAN+1Hboawe3PtgdozkWw4iVnK+LGARYqKeh3=a3L8qQKGEXZsg@HIDDEN>
References: <875x4yl7fm.fsf@HIDDEN>
<CAN+1Hbrs_rFU35hBUaKa-AA7eaYZOmnPBMaw-Di5hDrCsd9uOA@HIDDEN>
<878q9rquo1.fsf@HIDDEN>
<CAN+1HbpJP7aWDioF1GSBHh0Bem8Od1_Ea_qJqoyx0+ptNaDaJg@HIDDEN>
<CAN+1Hbq00c0WZnYuf_hatUweO3-0tGMJge1BQDpzmaQANbF3LA@HIDDEN>
<jwvbje2f5m3.fsf-monnier+emacs@HIDDEN>
<CAN+1HboAqmXqWbXNq=BQUjpQGRh==xzZF356C44DSdtbGLU35g@HIDDEN>
<jwvh5nsioyh.fsf-monnier+emacs@HIDDEN>
<CAN+1Hbp5i=33WotqfnXwKZUKAZ9apVqVuoNZW5WkjLJU0P7XPw@HIDDEN>
<jwvbje0im50.fsf-monnier+emacs@HIDDEN>
<CAN+1HbpMd-VFozDHjUCf07RKje-4jQL74BZ9MUNBYOYgHKE-Vw@HIDDEN>
<jwvse7ba9yt.fsf-monnier+emacs@HIDDEN>
<CAN+1Hbofbr=U2Ns3vCyPAoSHmc5mrEVpDgv=RAex9PDNS=qRRA@HIDDEN>
<jwvpl2e0wz1.fsf-monnier+emacs@HIDDEN>
<CAN+1Hboawe3PtgdozkWw4iVnK+LGARYqKeh3=a3L8qQKGEXZsg@HIDDEN>
Date: Wed, 03 Jun 2026 17:37:52 +0200
Message-ID: <87jysf8wj3.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: 80988
Cc: Stefan Monnier <monnier@HIDDEN>, 80988 <at> debbugs.gnu.org,
Aaron Zeng <azeng@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.0 (/)
This looks reasonable to me, I hope it can make it into Emacs 31.
On Tue, 2 Jun 2026, St=C3=A9phane Marks wrote:
> On Fri, May 29, 2026 at 4:48=E2=80=AFPM Stefan Monnier <monnier@HIDDEN=
real.ca> wrote:
>
> > Done. See attached patch. I also took the liberty of restoring SUFFI=
X at
> > the same time since that was undone in the originating sibling patch.
>
> Let's keep the suffix part for bug#81134.
>
> > @@ -7114,8 +7114,7 @@ progress-reporter-update-functions
> > STATE can be one of:
> > - A float representing the percentage complete in the range 0.0-1.0
> > for a numeric reporter.
> > -- An integer representing the index which cycles through the range 0-3
> > -for a pulsing reporter.
> > +- A monotonically increasing integer for a pulsing reporter.
> > - The symbol `done' to indicate that the progress reporter is complet=
e.")
> >=20=20
> > (defsubst progress-reporter-update (reporter &optional value suffix)
>
> LGTM.
>
> > ((pred integerp)
> > (let ((message-log-max nil)
> > - (pulse-char (aref progress-reporter--pulse-characters
> > - state)))
> > - (message "%s %s" text pulse-char)))
> > + (pulse-char
> > + (aref progress-reporter--pulse-characters
> > + (mod state (length progress-reporter--pulse-cha=
racters)))))
> > + (message "%s %s%s" text pulse-char suffix)))
> > ('done
> > (message "%sdone" text))))))
> >=20=20
> > @@ -7294,7 +7297,7 @@ progress-reporter-do-update
> > (if suffix
> > (aset parameters 6 suffix)
> > (setq suffix (or (aref parameters 6) "")))
> > - (let ((index (mod (1+ (car reporter)) 4)))
> > + (let ((index (1+ (car reporter))))
> > (setcar reporter index)
> > (run-hook-with-args 'progress-reporter-update-functions
> > reporter
> > diff --git a/lisp/system-taskbar.el b/lisp/system-taskbar.el
> > index cc41183fb32..973b426e026 100644
> > --- a/lisp/system-taskbar.el
> > +++ b/lisp/system-taskbar.el
> > @@ -282,7 +282,9 @@ system-taskbar--progress-reporter-update
> > ((pred floatp)
> > (system-taskbar--progress state))
> > ((pred integerp)
> > - (system-taskbar--progress (/ (1+ state) 4.0)))
> > + ;; This won't show 0.0 to indicate work in process until done.
> > + (system-taskbar--progress
> > + (/ (1+ (mod state 5)) 5.0)))
> > ('done
> > (system-taskbar--progress nil)))))
>
> Agreed. Revised attached.
>
> -St=C3=A9phane
>
> [4. text/x-patch; 0001-Improve-progress-reporter-state-to-remove-hard-cod=
ed.patch]...
bug-gnu-emacs@HIDDEN:bug#80988; Package emacs.
Full text available.
Received: (at 80988) by debbugs.gnu.org; 2 Jun 2026 16:35:43 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 02 12:35:43 2026
Received: from localhost ([127.0.0.1]:58685 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1wUS5e-0004nV-GD
for submit <at> debbugs.gnu.org; Tue, 02 Jun 2026 12:35:43 -0400
Received: from mail-ua1-x92c.google.com ([2607:f8b0:4864:20::92c]:60854)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <shipmints@HIDDEN>)
id 1wUS5b-0004n1-SB
for 80988 <at> debbugs.gnu.org; Tue, 02 Jun 2026 12:35:41 -0400
Received: by mail-ua1-x92c.google.com with SMTP id
a1e0cc1a2514c-96392241154so3969788241.1
for <80988 <at> debbugs.gnu.org>; Tue, 02 Jun 2026 09:35:39 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1780418139; cv=none;
d=google.com; s=arc-20240605;
b=cRV6iSB4t3jQFgdku0MktNByI8IsCcKwyaDq3OahK25QkZDy9PAMwrgtpMmQ9bbx+C
tJZIvLFs8sfkPq873YOg1XK/yRh8/jQOU3IITxYym2EvL+KYA9r7yDCY7gKccu+X8h21
YzndAOGLqvYj2JHEHsGdHT0cZ7iIx0NiGZssAIKnzi0S4kLyYwmQjKOCPHdcqDOnwceo
n0lHAoIK8ovRGHSF1G+zehiZVWD8sTcIXGYBatpaUjWCVbfGNlANQoj4rW3OcrfxfzcL
FCjS/Gs1gKE6WDFXIjXlo7p8HSspmFMcHgZilVSZ7pVWw5CWqAn/DWXe6PS3MtXY5N2h
hq9A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20240605;
h=cc:to:subject:message-id:date:from:in-reply-to:references
:mime-version:dkim-signature;
bh=pU93ekTkjIt0fBwDNPR6I4OTdj0aD13GKkRXStYOCDQ=;
fh=yLRp/NXWfQrxtsbggg5HJ2SEaiAnFjssfyib8MTgVE0=;
b=RCqCxDC5XLAA7D20tJUokkLK4ayQgnS1uErXytR3+tvQacrO6enlzedwdz4og9QRrR
jnPRkUwS3Otnpg+8K4gPxuJpm1KeZIYkR2R5zFpLBPsE1d4ow6VkOduWOo3MSM2OtEnF
9E+Zy/pjG8Wp1TSVoqT2v/osJVFHPJzDIQvZi+0lv9K7Xo2n8RoxxQyMs19Qw/jIm7/3
DRMdJcUkMFkskxA3Jmkpo4NO80DCjWwlSee9ynoRjBB+jZiE+M7DI6dnJiBsJSfGLWIq
1BbCnu2zbxqYM559JNqhDlAxDaz3oR5pC/Cm3fAUbg4TB9/ZB9CFDpyDQ79yhc0xsthi
eCPQ==; darn=debbugs.gnu.org
ARC-Authentication-Results: i=1; mx.google.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20251104; t=1780418139; x=1781022939; darn=debbugs.gnu.org;
h=cc:to:subject:message-id:date:from:in-reply-to:references
:mime-version:from:to:cc:subject:date:message-id:reply-to;
bh=pU93ekTkjIt0fBwDNPR6I4OTdj0aD13GKkRXStYOCDQ=;
b=crTxw/TBRQKIpWnl098gOSZ2nZnWcWtxEpwSbzlvmp11JSPQOmnQsKvtw9rORQVxQH
RFA9cpX5UDYzKYZBPXc5Qevt4pcdTfcmUXAJn76vx0SZBUonGHBFky0JgKsuQaukafoD
vTBYJ0YwhBIAbzSmZT73edjfB+jCIZZp773fN+xIXis27VKqdDgqbLpXXNq6XGQRWEtH
lyofsaec9AeXrF3bMXkvcYIjdJgHjzptrQdIb4vwH+Y+EyuK9BYR2mre6DJiOO9xlJeA
5AeQcKM+3giV37viQ9qfFjczjE94lAqDon96uNv1kLbpzWCTHNLbuU9TAiFxsSlhyD/D
jHkA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20251104; t=1780418139; x=1781022939;
h=cc:to:subject:message-id:date:from:in-reply-to:references
:mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date
:message-id:reply-to;
bh=pU93ekTkjIt0fBwDNPR6I4OTdj0aD13GKkRXStYOCDQ=;
b=bTUV1aNyGsrYZekk+i5pFxe+hPLZZm3QRaidbh1BIanuqApG4NsqyME3YRbFC0d5Ey
42V3PERpkitLv6AgOrfVgtEIrBiUs484aAC5+wRCbnQccW2R2EGNFbZaC8bL6AaxmBZK
cDdlJy4yBmS4pq9ATk65tmjmtYeUSD78YLi2ADwywZEnhMTogeCmOk6WhwfiCv2jconw
z9f5JL+ulHz+GONXfXZJ4xRIL8I9moIhIXXuWaeLOhDekj7xpSK5oXBEXEttg/ofbzo1
iHq5Jy/6O5TGFrupG4mWE+8hMjISDVifa7n5rCBbL2SGOXyJPVuvv9By54cNG/uomf9D
vbBg==
X-Forwarded-Encrypted: i=1;
AFNElJ9Nu082gWM7jlsmVgpDcdie2LztCre9HAKwCC0QxXv3IeXzG6NCH+4y8JhEn8bQtIpbiOI2bA==@debbugs.gnu.org
X-Gm-Message-State: AOJu0Yy/iuMy4EFj1s/oNQG7IJJzoK8eGrNrLNy23MLSiyHaJxJqvyD5
0h4augQvBT9Q1KWvjiRjl1ilYHvwpGOL0YD2uEVjubnWE8vGgJA2nDtPXAKlHV2tWYUKAaecBw/
9FfYuEcPuVZPhyO7ZdnBN21tsZsPt1ps=
X-Gm-Gg: Acq92OEEMmBCYMd7T1b+jAB7vu7d0HYquBtp5QJ2zQ43HXUo3gTG/DcVuQHoFotKJU/
j/H7SJ55PN4PS6VCvL+XRBiPPL3vfVSygna74M9MAulUQldGUag4CnSAU0PMi2ptoBcqDfkoxw4
+ERjC/QT4BXbkkBngvgDky2S7f9IttYY37OydKC7LUxo5X0++ukGirNUHrZrVj2guSeptHsoK8W
vcreo8eQnICIXiX5llef3D8ZLcAS70Hgv6udp5wXSj4O+9zPAIUERG+BDoGyO3tHxCDoscdhGjb
HMhubVryDz4OTZNX/EBkqdjL+4TUUnB98fNL/TfkoBFw50G5jHo45jKRX4rtir6mwg4+TWkKfA6
o4H/YhkLcF1kFM33wrREhfS1dJbcF17HHzSXoba8R5uU9D8tXSFVRLYQ2wA==
X-Received: by 2002:a05:6102:290a:b0:6cc:16d2:3101 with SMTP id
ada2fe7eead31-6ea30284761mr675011137.28.1780418138938; Tue, 02 Jun 2026
09:35:38 -0700 (PDT)
MIME-Version: 1.0
References: <875x4yl7fm.fsf@HIDDEN>
<CAN+1Hbrs_rFU35hBUaKa-AA7eaYZOmnPBMaw-Di5hDrCsd9uOA@HIDDEN>
<878q9rquo1.fsf@HIDDEN>
<CAN+1HbpJP7aWDioF1GSBHh0Bem8Od1_Ea_qJqoyx0+ptNaDaJg@HIDDEN>
<CAN+1Hbq00c0WZnYuf_hatUweO3-0tGMJge1BQDpzmaQANbF3LA@HIDDEN>
<jwvbje2f5m3.fsf-monnier+emacs@HIDDEN>
<CAN+1HboAqmXqWbXNq=BQUjpQGRh==xzZF356C44DSdtbGLU35g@HIDDEN>
<jwvh5nsioyh.fsf-monnier+emacs@HIDDEN>
<CAN+1Hbp5i=33WotqfnXwKZUKAZ9apVqVuoNZW5WkjLJU0P7XPw@HIDDEN>
<jwvbje0im50.fsf-monnier+emacs@HIDDEN>
<CAN+1HbpMd-VFozDHjUCf07RKje-4jQL74BZ9MUNBYOYgHKE-Vw@HIDDEN>
<jwvse7ba9yt.fsf-monnier+emacs@HIDDEN>
<CAN+1Hbofbr=U2Ns3vCyPAoSHmc5mrEVpDgv=RAex9PDNS=qRRA@HIDDEN>
<jwvpl2e0wz1.fsf-monnier+emacs@HIDDEN>
In-Reply-To: <jwvpl2e0wz1.fsf-monnier+emacs@HIDDEN>
From: =?UTF-8?Q?St=C3=A9phane_Marks?= <shipmints@HIDDEN>
Date: Tue, 2 Jun 2026 12:35:27 -0400
X-Gm-Features: AVHnY4La066l1STRGSHciMR_MUZXUDuXzL2a13AdY2gBEfyQZuj1riszSF_POOc
Message-ID: <CAN+1Hboawe3PtgdozkWw4iVnK+LGARYqKeh3=a3L8qQKGEXZsg@HIDDEN>
Subject: Re: bug#80988: 31.0.50; Progress report (commit f5f2306fc1d)
To: Stefan Monnier <monnier@HIDDEN>
Content-Type: multipart/mixed; boundary="000000000000b94adc065347e69d"
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: 80988
Cc: Augusto Stoffel <arstoffel@HIDDEN>, Aaron Zeng <azeng@HIDDEN>,
80988 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.0 (/)
--000000000000b94adc065347e69d
Content-Type: multipart/alternative; boundary="000000000000b94adc065347e69b"
--000000000000b94adc065347e69b
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
On Fri, May 29, 2026 at 4:48=E2=80=AFPM Stefan Monnier <monnier@HIDDEN=
al.ca>
wrote:
> > Done. See attached patch. I also took the liberty of restoring SUFFIX
> at
> > the same time since that was undone in the originating sibling patch.
>
> Let's keep the suffix part for bug#81134.
>
> > @@ -7114,8 +7114,7 @@ progress-reporter-update-functions
> > STATE can be one of:
> > - A float representing the percentage complete in the range 0.0-1.0
> > for a numeric reporter.
> > -- An integer representing the index which cycles through the range 0-3
> > -for a pulsing reporter.
> > +- A monotonically increasing integer for a pulsing reporter.
> > - The symbol `done' to indicate that the progress reporter is
> complete.")
> >
> > (defsubst progress-reporter-update (reporter &optional value suffix)
>
> LGTM.
>
> > ((pred integerp)
> > (let ((message-log-max nil)
> > - (pulse-char (aref progress-reporter--pulse-characters
> > - state)))
> > - (message "%s %s" text pulse-char)))
> > + (pulse-char
> > + (aref progress-reporter--pulse-characters
> > + (mod state (length
> progress-reporter--pulse-characters)))))
> > + (message "%s %s%s" text pulse-char suffix)))
> > ('done
> > (message "%sdone" text))))))
> >
> > @@ -7294,7 +7297,7 @@ progress-reporter-do-update
> > (if suffix
> > (aset parameters 6 suffix)
> > (setq suffix (or (aref parameters 6) "")))
> > - (let ((index (mod (1+ (car reporter)) 4)))
> > + (let ((index (1+ (car reporter))))
> > (setcar reporter index)
> > (run-hook-with-args 'progress-reporter-update-functions
> > reporter
> > diff --git a/lisp/system-taskbar.el b/lisp/system-taskbar.el
> > index cc41183fb32..973b426e026 100644
> > --- a/lisp/system-taskbar.el
> > +++ b/lisp/system-taskbar.el
> > @@ -282,7 +282,9 @@ system-taskbar--progress-reporter-update
> > ((pred floatp)
> > (system-taskbar--progress state))
> > ((pred integerp)
> > - (system-taskbar--progress (/ (1+ state) 4.0)))
> > + ;; This won't show 0.0 to indicate work in process until done.
> > + (system-taskbar--progress
> > + (/ (1+ (mod state 5)) 5.0)))
> > ('done
> > (system-taskbar--progress nil)))))
>
Agreed. Revised attached.
-St=C3=A9phane
--000000000000b94adc065347e69b
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon=
t-family:monospace"><span style=3D"font-family:Arial,Helvetica,sans-serif">=
On Fri, May 29, 2026 at 4:48=E2=80=AFPM Stefan Monnier <<a href=3D"mailt=
o:monnier@HIDDEN">monnier@HIDDEN</a>> wrote:</span><=
/div></div><div class=3D"gmail_quote gmail_quote_container"><blockquote cla=
ss=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid =
rgb(204,204,204);padding-left:1ex">> Done.=C2=A0 See attached patch.=C2=
=A0 I also took the liberty of restoring SUFFIX at<br>
> the same time since that was undone in the originating sibling patch.<=
br>
<br>
Let's keep the suffix part for bug#81134.<br>
<br>
> @@ -7114,8 +7114,7 @@ progress-reporter-update-functions<br>
>=C2=A0 STATE can be one of:<br>
>=C2=A0 - A float representing the percentage complete in the range 0.0-=
1.0<br>
>=C2=A0 for a numeric reporter.<br>
> -- An integer representing the index which cycles through the range 0-=
3<br>
> -for a pulsing reporter.<br>
> +- A monotonically increasing integer for a pulsing reporter.<br>
>=C2=A0 - The symbol `done' to indicate that the progress reporter i=
s complete.")<br>
>=C2=A0 <br>
>=C2=A0 (defsubst progress-reporter-update (reporter &optional value=
suffix)<br>
<br>
LGTM.<br>
<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ((pred integerp)<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(let ((message-log-max nil)<br=
>
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(pulse-char (a=
ref progress-reporter--pulse-characters<br>
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0state)))<br>
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(message "%s %s" t=
ext pulse-char)))<br>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(pulse-char<br=
>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (aref progres=
s-reporter--pulse-characters<br>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
=C2=A0 (mod state (length progress-reporter--pulse-characters)))))<br>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(message "%s %s%s"=
text pulse-char suffix)))<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ('done<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(message "%sdone" te=
xt))))))<br>
>=C2=A0 <br>
> @@ -7294,7 +7297,7 @@ progress-reporter-do-update<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(if suffix<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(aset par=
ameters 6 suffix)<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(setq suffix (or=
(aref parameters 6) "")))<br>
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(let ((index (mod (1+ (car r=
eporter)) 4)))<br>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(let ((index (1+ (car report=
er))))<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (setcar reporter index)<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(run-hook-with-a=
rgs 'progress-reporter-update-functions<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0reporter<br>
> diff --git a/lisp/system-taskbar.el b/lisp/system-taskbar.el<br>
> index cc41183fb32..973b426e026 100644<br>
> --- a/lisp/system-taskbar.el<br>
> +++ b/lisp/system-taskbar.el<br>
> @@ -282,7 +282,9 @@ system-taskbar--progress-reporter-update<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 ((pred floatp)<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(system-taskbar--progress state))<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 ((pred integerp)<br>
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0(system-taskbar--progress (/ (1+ state) 4.=
0)))<br>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0;; This won't show 0.0 to indicate wor=
k in process until done.<br>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0(system-taskbar--progress<br>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 (/ (1+ (mod state 5)) 5.0)))<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 ('done<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(system-taskbar--progress nil)))))<br=
></blockquote><div><br></div><div class=3D"gmail_default" style=3D"font-fam=
ily:monospace">Agreed.=C2=A0 Revised attached.</div><div class=3D"gmail_def=
ault" style=3D"font-family:monospace"><br></div><div class=3D"gmail_default=
" style=3D"font-family:monospace">-St=C3=A9phane</div></div></div>
--000000000000b94adc065347e69b--
--000000000000b94adc065347e69d
Content-Type: application/octet-stream;
name="0001-Improve-progress-reporter-state-to-remove-hard-coded.patch"
Content-Disposition: attachment;
filename="0001-Improve-progress-reporter-state-to-remove-hard-coded.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mpwuz8j30>
X-Attachment-Id: f_mpwuz8j30
RnJvbSA5NGE3NWEzN2UxYThkNDk1ODlmNTQyNTJmNTcxZTY5NmRjNGM4NzQ1IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/U3Q9QzM9QTlwaGFuZT0yME1hcmtzPz0gPHNo
aXBtaW50c0BnbWFpbC5jb20+CkRhdGU6IFdlZCwgMjcgTWF5IDIwMjYgMTY6MDU6MjMgLTA0MDAK
U3ViamVjdDogW1BBVENIXSBJbXByb3ZlIHByb2dyZXNzLXJlcG9ydGVyIHN0YXRlIHRvIHJlbW92
ZSBoYXJkIGNvZGVkIGxlbmd0aAogKGJ1ZyM4MDk4OCkKClJlbW92ZSBoYXJkLWNvZGVkIHN0YXRl
IHJhbmdlLCBub3cgYSBtb25vdG9uaWNhbGx5IGluY3JlYXNpbmcKaW50ZWdlci4KCiogbGlzcC9z
dWJyLmVsIChwcm9ncmVzcy1yZXBvcnRlci11cGRhdGUtZnVuY3Rpb25zKTogVXBkYXRlCmRvY3N0
cmluZy4KKHByb2dyZXNzLXJlcG9ydGVyLWVjaG8tYXJlYSk6IFVzZQoncHJvZ3Jlc3MtcmVwb3J0
ZXItLXB1bHNlLWNoYXJhY3RlcnMnIGxlbmd0aC4KKHByb2dyZXNzLXJlcG9ydGVyLWRvLXVwZGF0
ZSk6IEluY3JlYXNlICdzdGF0ZScgYnkgMSBlYWNoIHBhc3MuCioKbGlzcC9zeXN0ZW0tdGFza2Jh
ci5lbCAoc3lzdGVtLXRhc2tiYXItLXByb2dyZXNzLXJlcG9ydGVyLXVwZGF0ZSk6Ck1ha2Ugc3Rl
cHMgaW5kZXBlbmRlbnQgb2YgJ3Byb2dyZXNzLXJlcG9ydGVyLWVjaG8tYXJlYScgc3RlcHMuCi0t
LQogbGlzcC9zdWJyLmVsICAgICAgICAgICB8IDEyICsrKysrKy0tLS0tLQogbGlzcC9zeXN0ZW0t
dGFza2Jhci5lbCB8ICA0ICsrKy0KIDIgZmlsZXMgY2hhbmdlZCwgOSBpbnNlcnRpb25zKCspLCA3
IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3Avc3Vici5lbCBiL2xpc3Avc3Vici5lbApp
bmRleCBkOTc1OThhYjYxZi4uMTYyMzRkMzEzYTcgMTAwNjQ0Ci0tLSBhL2xpc3Avc3Vici5lbAor
KysgYi9saXNwL3N1YnIuZWwKQEAgLTcxMTQsOCArNzExNCw3IEBAIHByb2dyZXNzLXJlcG9ydGVy
LXVwZGF0ZS1mdW5jdGlvbnMKIFNUQVRFIGNhbiBiZSBvbmUgb2Y6CiAtIEEgZmxvYXQgcmVwcmVz
ZW50aW5nIHRoZSBwZXJjZW50YWdlIGNvbXBsZXRlIGluIHRoZSByYW5nZSAwLjAtMS4wCiBmb3Ig
YSBudW1lcmljIHJlcG9ydGVyLgotLSBBbiBpbnRlZ2VyIHJlcHJlc2VudGluZyB0aGUgaW5kZXgg
d2hpY2ggY3ljbGVzIHRocm91Z2ggdGhlIHJhbmdlIDAtMwotZm9yIGEgcHVsc2luZyByZXBvcnRl
ci4KKy0gQSBtb25vdG9uaWNhbGx5IGluY3JlYXNpbmcgaW50ZWdlciBmb3IgYSBwdWxzaW5nIHJl
cG9ydGVyLgogLSBUaGUgc3ltYm9sIGBkb25lJyB0byBpbmRpY2F0ZSB0aGF0IHRoZSBwcm9ncmVz
cyByZXBvcnRlciBpcyBjb21wbGV0ZS4iKQogCiAoZGVmc3Vic3QgcHJvZ3Jlc3MtcmVwb3J0ZXIt
dXBkYXRlIChyZXBvcnRlciAmb3B0aW9uYWwgdmFsdWUgc3VmZml4KQpAQCAtNzEzMCw3ICs3MTI5
LDcgQEAgcHJvZ3Jlc3MtcmVwb3J0ZXItdXBkYXRlCiBPcHRpb25hbCBhcmd1bWVudCBTVUZGSVgg
aXMgYSBzdHJpbmcgdG8gYmUgZGlzcGxheWVkIGFmdGVyIFJFUE9SVEVSJ3MKIG1haW4gbWVzc2Fn
ZSBhbmQgcHJvZ3Jlc3MgdGV4dC4gIElmIFJFUE9SVEVSIGlzIGEgbm9uLW51bWVyaWNhbAogcmVw
b3J0ZXIsIHRoZW4gVkFMVUUgc2hvdWxkIGJlIG5pbCwgb3IgYSBzdHJpbmcgdG8gdXNlIGluc3Rl
YWQgb2YKLVNVRkZJWC4gIFNVRkZJWCBpcyBjb25zaWRlcmVkIG9ic29sZXRlIGFuZCBtYXkgYmUg
cmVtb3ZlZCBpbiB0aGUgZnV0dXJlLgorU1VGRklYLgogCiBTZWUgYHByb2dyZXNzLXJlcG9ydGVy
LXVwZGF0ZS1mdW5jdGlvbnMnIGZvciB0aGUgbGlzdCBvZiBmdW5jdGlvbnMKIGNhbGxlZCBvbiBl
YWNoIHVwZGF0ZS4KQEAgLTcyNDEsOCArNzI0MCw5IEBAIHByb2dyZXNzLXJlcG9ydGVyLWVjaG8t
YXJlYQogICAgICAgICAgICAobWVzc2FnZSAiJXMiIHRleHQpKSkKICAgICAgICAgKChwcmVkIGlu
dGVnZXJwKQogICAgICAgICAgKGxldCAoKG1lc3NhZ2UtbG9nLW1heCBuaWwpCi0gICAgICAgICAg
ICAgICAocHVsc2UtY2hhciAoYXJlZiBwcm9ncmVzcy1yZXBvcnRlci0tcHVsc2UtY2hhcmFjdGVy
cwotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RhdGUpKSkKKyAgICAgICAgICAg
ICAgIChwdWxzZS1jaGFyCisgICAgICAgICAgICAgICAgKGFyZWYgcHJvZ3Jlc3MtcmVwb3J0ZXIt
LXB1bHNlLWNoYXJhY3RlcnMKKyAgICAgICAgICAgICAgICAgICAgICAobW9kIHN0YXRlIChsZW5n
dGggcHJvZ3Jlc3MtcmVwb3J0ZXItLXB1bHNlLWNoYXJhY3RlcnMpKSkpKQogICAgICAgICAgICAo
bWVzc2FnZSAiJXMgJXMiIHRleHQgcHVsc2UtY2hhcikpKQogICAgICAgICAoJ2RvbmUKICAgICAg
ICAgIChtZXNzYWdlICIlc2RvbmUiIHRleHQpKSkpKSkKQEAgLTcyOTQsNyArNzI5NCw3IEBAIHBy
b2dyZXNzLXJlcG9ydGVyLWRvLXVwZGF0ZQogICAgICAgICAgICAoaWYgc3VmZml4CiAgICAgICAg
ICAgICAgICAoYXNldCBwYXJhbWV0ZXJzIDYgc3VmZml4KQogICAgICAgICAgICAgIChzZXRxIHN1
ZmZpeCAob3IgKGFyZWYgcGFyYW1ldGVycyA2KSAiIikpKQotICAgICAgICAgICAobGV0ICgoaW5k
ZXggKG1vZCAoMSsgKGNhciByZXBvcnRlcikpIDQpKSkKKyAgICAgICAgICAgKGxldCAoKGluZGV4
ICgxKyAoY2FyIHJlcG9ydGVyKSkpKQogCSAgICAgKHNldGNhciByZXBvcnRlciBpbmRleCkKICAg
ICAgICAgICAgICAocnVuLWhvb2std2l0aC1hcmdzICdwcm9ncmVzcy1yZXBvcnRlci11cGRhdGUt
ZnVuY3Rpb25zCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZXBvcnRlcgpkaWZm
IC0tZ2l0IGEvbGlzcC9zeXN0ZW0tdGFza2Jhci5lbCBiL2xpc3Avc3lzdGVtLXRhc2tiYXIuZWwK
aW5kZXggY2M0MTE4M2ZiMzIuLjk3M2I0MjZlMDI2IDEwMDY0NAotLS0gYS9saXNwL3N5c3RlbS10
YXNrYmFyLmVsCisrKyBiL2xpc3Avc3lzdGVtLXRhc2tiYXIuZWwKQEAgLTI4Miw3ICsyODIsOSBA
QCBzeXN0ZW0tdGFza2Jhci0tcHJvZ3Jlc3MtcmVwb3J0ZXItdXBkYXRlCiAgICAgICAoKHByZWQg
ZmxvYXRwKQogICAgICAgIChzeXN0ZW0tdGFza2Jhci0tcHJvZ3Jlc3Mgc3RhdGUpKQogICAgICAg
KChwcmVkIGludGVnZXJwKQotICAgICAgIChzeXN0ZW0tdGFza2Jhci0tcHJvZ3Jlc3MgKC8gKDEr
IHN0YXRlKSA0LjApKSkKKyAgICAgICA7OyBUaGlzIHdvbid0IHNob3cgMC4wIHRvIGluZGljYXRl
IHdvcmsgaW4gcHJvY2VzcyB1bnRpbCBkb25lLgorICAgICAgIChzeXN0ZW0tdGFza2Jhci0tcHJv
Z3Jlc3MKKyAgICAgICAgKC8gKDErIChtb2Qgc3RhdGUgNSkpIDUuMCkpKQogICAgICAgKCdkb25l
CiAgICAgICAgKHN5c3RlbS10YXNrYmFyLS1wcm9ncmVzcyBuaWwpKSkpKQogCi0tIAoyLjU0LjAK
Cg==
--000000000000b94adc065347e69d--
bug-gnu-emacs@HIDDEN:bug#80988; Package emacs.
Full text available.
Received: (at 80988) by debbugs.gnu.org; 29 May 2026 20:48:53 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 29 16:48:53 2026
Received: from localhost ([127.0.0.1]:59711 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1wT48S-0002E2-PR
for submit <at> debbugs.gnu.org; Fri, 29 May 2026 16:48:53 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:13368)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <monnier@HIDDEN>)
id 1wT48R-0002Db-21
for 80988 <at> debbugs.gnu.org; Fri, 29 May 2026 16:48:51 -0400
Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 0E6B4820E8;
Fri, 29 May 2026 16:48:45 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1780087724;
bh=fH56ktBek20jJcgMn6T7zvWRc8yEMToicq1Gq0Qs1uw=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=g1UB+AnVBAtLQaJ77Cw8nFNrSiG3fKjRJ1kdPsw3R25dRC47LWScUzXoGAiqhmGzs
V02N5Hzb8jVBVzLFKBZ/A8Ur45aG3/zkq/o7yehaMskI2u1rrc21NshXCMAx1T8J04
qVS0IGQKY9SGw3oaklWdsvkrS7kt07GkBABAX3CZ24pqAbacPpOLHWBoDwX2lhsJrs
h4oK9m51vOlx4uOTpg66WbeV4QvdPtcU90Gu2KupPXLp+oNar29mjAJ6P6JbT/+kIg
cGRq0avW+Ki18O/UdfY1kmmjOP8XCVD9D25g1jprT73hQrtp3hNoj3KJFVc7DIXRFk
Gaq4rueaOt48Q==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 2F55F8168A;
Fri, 29 May 2026 16:48:44 -0400 (EDT)
Received: from alfajor (unknown [192.197.121.29])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1B4751203B5;
Fri, 29 May 2026 16:48:44 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: =?windows-1252?Q?St=E9phane?= Marks <shipmints@HIDDEN>
Subject: Re: bug#80988: 31.0.50; Progress report (commit f5f2306fc1d)
In-Reply-To: <CAN+1Hbofbr=U2Ns3vCyPAoSHmc5mrEVpDgv=RAex9PDNS=qRRA@HIDDEN>
Message-ID: <jwvpl2e0wz1.fsf-monnier+emacs@HIDDEN>
References: <875x4yl7fm.fsf@HIDDEN>
<CAN+1Hbrs_rFU35hBUaKa-AA7eaYZOmnPBMaw-Di5hDrCsd9uOA@HIDDEN>
<878q9rquo1.fsf@HIDDEN>
<CAN+1HbpJP7aWDioF1GSBHh0Bem8Od1_Ea_qJqoyx0+ptNaDaJg@HIDDEN>
<CAN+1Hbq00c0WZnYuf_hatUweO3-0tGMJge1BQDpzmaQANbF3LA@HIDDEN>
<jwvbje2f5m3.fsf-monnier+emacs@HIDDEN>
<CAN+1HboAqmXqWbXNq=BQUjpQGRh==xzZF356C44DSdtbGLU35g@HIDDEN>
<jwvh5nsioyh.fsf-monnier+emacs@HIDDEN>
<CAN+1Hbp5i=33WotqfnXwKZUKAZ9apVqVuoNZW5WkjLJU0P7XPw@HIDDEN>
<jwvbje0im50.fsf-monnier+emacs@HIDDEN>
<CAN+1HbpMd-VFozDHjUCf07RKje-4jQL74BZ9MUNBYOYgHKE-Vw@HIDDEN>
<jwvse7ba9yt.fsf-monnier+emacs@HIDDEN>
<CAN+1Hbofbr=U2Ns3vCyPAoSHmc5mrEVpDgv=RAex9PDNS=qRRA@HIDDEN>
Date: Fri, 29 May 2026 16:48:43 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 80988
Cc: Augusto Stoffel <arstoffel@HIDDEN>, Aaron Zeng <azeng@HIDDEN>,
80988 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> Done. See attached patch. I also took the liberty of restoring SUFFIX at
> the same time since that was undone in the originating sibling patch.
Let's keep the suffix part for bug#81134.
> @@ -7114,8 +7114,7 @@ progress-reporter-update-functions
> STATE can be one of:
> - A float representing the percentage complete in the range 0.0-1.0
> for a numeric reporter.
> -- An integer representing the index which cycles through the range 0-3
> -for a pulsing reporter.
> +- A monotonically increasing integer for a pulsing reporter.
> - The symbol `done' to indicate that the progress reporter is complete.")
>
> (defsubst progress-reporter-update (reporter &optional value suffix)
LGTM.
> ((pred integerp)
> (let ((message-log-max nil)
> - (pulse-char (aref progress-reporter--pulse-characters
> - state)))
> - (message "%s %s" text pulse-char)))
> + (pulse-char
> + (aref progress-reporter--pulse-characters
> + (mod state (length progress-reporter--pulse-characters)))))
> + (message "%s %s%s" text pulse-char suffix)))
> ('done
> (message "%sdone" text))))))
>
> @@ -7294,7 +7297,7 @@ progress-reporter-do-update
> (if suffix
> (aset parameters 6 suffix)
> (setq suffix (or (aref parameters 6) "")))
> - (let ((index (mod (1+ (car reporter)) 4)))
> + (let ((index (1+ (car reporter))))
> (setcar reporter index)
> (run-hook-with-args 'progress-reporter-update-functions
> reporter
> diff --git a/lisp/system-taskbar.el b/lisp/system-taskbar.el
> index cc41183fb32..973b426e026 100644
> --- a/lisp/system-taskbar.el
> +++ b/lisp/system-taskbar.el
> @@ -282,7 +282,9 @@ system-taskbar--progress-reporter-update
> ((pred floatp)
> (system-taskbar--progress state))
> ((pred integerp)
> - (system-taskbar--progress (/ (1+ state) 4.0)))
> + ;; This won't show 0.0 to indicate work in process until done.
> + (system-taskbar--progress
> + (/ (1+ (mod state 5)) 5.0)))
> ('done
> (system-taskbar--progress nil)))))
LGTM, thanks.
=== Stefan
bug-gnu-emacs@HIDDEN:bug#80988; Package emacs.
Full text available.Received: (at 80988) by debbugs.gnu.org; 29 May 2026 14:51:58 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 29 10:51:58 2026 Received: from localhost ([127.0.0.1]:56255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1wSyZ4-0007nd-3e for submit <at> debbugs.gnu.org; Fri, 29 May 2026 10:51:58 -0400 Received: from mail-vs1-xe2b.google.com ([2607:f8b0:4864:20::e2b]:46494) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <shipmints@HIDDEN>) id 1wSyZ1-0007nT-Hq for 80988 <at> debbugs.gnu.org; Fri, 29 May 2026 10:51:56 -0400 Received: by mail-vs1-xe2b.google.com with SMTP id ada2fe7eead31-6c25b040555so393382137.1 for <80988 <at> debbugs.gnu.org>; Fri, 29 May 2026 07:51:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1780066314; cv=none; d=google.com; s=arc-20240605; b=JHh9IZLduPFD3jNwLP6rhzxtXKomOISTOsSs028mnudAsFYa+zyMspoKcOPV4Gr4qp +95RICu/j7RBBPsiRvLX7/RtdL1620w7F5hlrz1AFbkhGZepC3nQpKVgrNlueSRWeyXw 5oJUVCIzd4VOd37udLdwD2SbNTahcV53S071HyH6n8VyEwCPHsCgrnuyEzYeIUGw9117 NoNZvZmEXiEwrddn8MEy8JaFTJys5PXYeg4zWUjhCOG2qpe64FHfVZyXtez5vVDnIDUl evlQB++am9uEikblleCGnxPX/UMDfGmevuGf8BogJ3LFsLe1u56YaFQiixN8bM8SUDRs PuOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=c90ms49fRcVtI+pdW33G6sQb7mb5oWdCD3JAUgvdAqQ=; fh=XVNdI2LOLQv4MLMhXHNjDGyIhXAZ3QaDmdca/QrgsZ8=; b=O49/kPJ6GqpuEQEKBmDDgdMHc37G5PV9FAuBCYDC5i/I3lm4nnxSLvwRWGyBIVi63w loEA+hDhkm3QP4NMpBes1+TbS3S21orn+kGfM+JhaM61uSHDYWj6440XSl+kFxJ2rssV /c+sq8OiAbdOhYF7uvVVDU8WmBFPqx+dtSdE5CmYEdwkSVO2hBX+bJ0dUelTcmWf1aPf ScvX3O95iJoEl96qMBzQ0Crn0rKPA1kzvddMECeH3P1gQggmPUYDbRwgVmqJUnVqdFUL DQf5GohgZt0NGRRzBD2KGikLHUmkK2hRWSH5X+VRHQ4XOFUGCIer82Qsk87TKtTDuiqO en8Q==; darn=debbugs.gnu.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780066314; x=1780671114; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=c90ms49fRcVtI+pdW33G6sQb7mb5oWdCD3JAUgvdAqQ=; b=JdjAthoBneVx6IHuKRZCSTuJQgyueJVmSk0SRoV7hkQCp1+I1eBXhgSyU/OkXvQa/4 87klzNJnOio1Qzi2gk0lBZwuGe5AoyUgIAzKK8swgZHnbTtNRpGIPb6T88Ix9Cf0DnZj EQr/4M45VTrO6Pr3xY1Ke/bsOgIckEXHWfr3SynKQYrb2y89GMxQKIvRRpG577PuVHMx dJscWMiHGzDKlEcwBejKI8/Q/NqXB/Z6mIqBQc3MaVYYCQnyztc42ruqcYa/A+6g3R6h AxpGz6qWiPKoThhZlMr9xi/ZslR49cxug/FquqkcwHBgbZQzFmGDy49bfvBp8grQ9nKn ITNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780066314; x=1780671114; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=c90ms49fRcVtI+pdW33G6sQb7mb5oWdCD3JAUgvdAqQ=; b=XTU3S5MhEobMV6qTpMguIc1tXBXwsto0g8IZc53sI50eCnElQHUmWHqwrp0SzK1iVO EEhLocP6j6gjAZzfb1/hRptoxGzounGWdobuEEPctnLhQgc7vK5GOzW28XnZQX30nlYG QJRGgGKBgAOz4BlzS9ZWepWlA3U7/yaqj0yU9PYa9S8KqzAFZA56wPmdQbf2RTvAXm7z q6AGo/9DHjEtEsu/Bq6hB04i5ujnoN1sQ34mr6fP6SZlRSoyMzbFrNixfdMfMh2KDgLD 2vPfDMiXxQhs+n1WF77o52oEYnwvAbpIYWB+FQx27UeyMjjUf5afeFozDpvXZHKxlpJk AVgg== X-Forwarded-Encrypted: i=1; AFNElJ8hFh47bhZhI3n9cil243a/XvBYcCIvDCv25r6EF8nQ9T+aBGXgNjyH8YIouUfyDlfauV7B7Q==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzsdDF+EU4q6hiOPLZc+/SjMmXBSg7lWBYagC40ifAGviIcr+dE X2uw0q9eWuuVBAELSL/7sKg+IrpH/1u372ewOBJyhMFtUYEiTsdlW0sv4T8hZhiCMP2phV0oiOR fPwHN1xf0TAII/bwk1AUUnto6DnUE8IE= X-Gm-Gg: Acq92OEB/zLZKz+AvhKZk6kMa/3JeUOWr+hUPQXPadb/SaROqRV94ApsLfJU1IM+1n/ CnPeP0elKs3ZKfbHyFilNaEg5Filae4pLHrN4U9W1HrIzFxQ1e0sJ6SsJj8uRQG+LB8hWrkOyXJ c3GLvDTTdD8mYKsX84JR4fHnIFs7k28q76kDWoxY0qsSBxH6vXlSFqPWuaLgXbpXN9mBcl1Grt8 1OZ74Ej58kOAKACep+XXXmmS44bClH8spSIzDvVPTdDJgMX7mjGdRrkO/qC3dpuylE0gXz3690o +FO5dBxrTCJ7rU1BxOJ8RfUQfy0I+1PrAhkM72JMJ1+IbqcBfDBmonU7xB3qPKgKJP9/rj/rDlf 5UJNlRGWL7sOVJv4vyZWCuTurKWD2r4USdHxHgIfV6YhuZPQOpx1yRv/9dI4= X-Received: by 2002:a05:6102:5983:b0:604:f029:224c with SMTP id ada2fe7eead31-6bf2daaadf4mr1457619137.8.1780066314578; Fri, 29 May 2026 07:51:54 -0700 (PDT) MIME-Version: 1.0 References: <875x4yl7fm.fsf@HIDDEN> <CAN+1Hbrs_rFU35hBUaKa-AA7eaYZOmnPBMaw-Di5hDrCsd9uOA@HIDDEN> <878q9rquo1.fsf@HIDDEN> <CAN+1HbpJP7aWDioF1GSBHh0Bem8Od1_Ea_qJqoyx0+ptNaDaJg@HIDDEN> <CAN+1Hbq00c0WZnYuf_hatUweO3-0tGMJge1BQDpzmaQANbF3LA@HIDDEN> <jwvbje2f5m3.fsf-monnier+emacs@HIDDEN> <CAN+1HboAqmXqWbXNq=BQUjpQGRh==xzZF356C44DSdtbGLU35g@HIDDEN> <jwvh5nsioyh.fsf-monnier+emacs@HIDDEN> <CAN+1Hbp5i=33WotqfnXwKZUKAZ9apVqVuoNZW5WkjLJU0P7XPw@HIDDEN> <jwvbje0im50.fsf-monnier+emacs@HIDDEN> <CAN+1HbpMd-VFozDHjUCf07RKje-4jQL74BZ9MUNBYOYgHKE-Vw@HIDDEN> <jwvse7ba9yt.fsf-monnier+emacs@HIDDEN> In-Reply-To: <jwvse7ba9yt.fsf-monnier+emacs@HIDDEN> From: =?UTF-8?Q?St=C3=A9phane_Marks?= <shipmints@HIDDEN> Date: Fri, 29 May 2026 10:51:41 -0400 X-Gm-Features: AVHnY4IhlHL01xlfoJrE0LC7yEGY6grY6cImjTqfA3tKdBEIsmBNmHEPcDzzuE4 Message-ID: <CAN+1Hbofbr=U2Ns3vCyPAoSHmc5mrEVpDgv=RAex9PDNS=qRRA@HIDDEN> Subject: Re: bug#80988: 31.0.50; Progress report (commit f5f2306fc1d) To: Stefan Monnier <monnier@HIDDEN> Content-Type: multipart/mixed; boundary="0000000000005bd0840652f5fc4d" X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 80988 Cc: Augusto Stoffel <arstoffel@HIDDEN>, Aaron Zeng <azeng@HIDDEN>, 80988 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.0 (/) --0000000000005bd0840652f5fc4d Content-Type: multipart/alternative; boundary="0000000000005bd0830652f5fc4b" --0000000000005bd0830652f5fc4b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, May 28, 2026 at 10:27=E2=80=AFAM Stefan Monnier <monnier@HIDDEN= eal.ca> wrote: > > So we're no longer going to cycle like the docstring suggests > > > > - An integer representing the index which cycles through the range 0-= 3 > > for a pulsing reporter. > > > > and switch to a monotonic counter? > > Exactly. If STATE cycles via `mod N`, then the backends can use cycles > only of length N or a divisor of N. What's the benefit? > + Aaron Done. See attached patch. I also took the liberty of restoring SUFFIX at the same time since that was undone in the originating sibling patch. --0000000000005bd0830652f5fc4b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon= t-family:monospace"><span style=3D"font-family:Arial,Helvetica,sans-serif">= On Thu, May 28, 2026 at 10:27=E2=80=AFAM Stefan Monnier <<a href=3D"mail= to:monnier@HIDDEN">monnier@HIDDEN</a>> wrote:</span>= </div></div><div class=3D"gmail_quote gmail_quote_container"><blockquote cl= ass=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid= rgb(204,204,204);padding-left:1ex">> So we're no longer going to cy= cle like the docstring suggests<br> ><br> >=C2=A0 =C2=A0- An integer representing the index which cycles through t= he range 0-3<br> >=C2=A0 =C2=A0for a pulsing reporter.<br> ><br> > and switch to a monotonic counter?<br> <br> Exactly.=C2=A0 If STATE cycles via `mod N`, then the backends can use cycle= s<br> only of length N or a divisor of N.=C2=A0 What's the benefit?<br></bloc= kquote><div><br></div><div><div class=3D"gmail_default" style=3D"font-famil= y:monospace">+ Aaron</div><br></div><div class=3D"gmail_default" style=3D"f= ont-family:monospace">Done.=C2=A0 See attached patch.=C2=A0 I also took the= liberty of restoring SUFFIX at the same time since that was undone in the = originating sibling patch.</div></div></div> --0000000000005bd0830652f5fc4b-- --0000000000005bd0840652f5fc4d Content-Type: application/octet-stream; name="0001-Improve-progress-reporter-state-restore-suffix-bug-8.patch" Content-Disposition: attachment; filename="0001-Improve-progress-reporter-state-restore-suffix-bug-8.patch" Content-Transfer-Encoding: base64 Content-ID: <f_mpr1ihfg0> X-Attachment-Id: f_mpr1ihfg0 RnJvbSAxNDEyNzk3M2YyODIxZDNjNzBjODYyZTQxMGY2YjBkY2U0MzViYWNhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/U3Q9QzM9QTlwaGFuZT0yME1hcmtzPz0gPHNo aXBtaW50c0BnbWFpbC5jb20+CkRhdGU6IFdlZCwgMjcgTWF5IDIwMjYgMTY6MDU6MjMgLTA0MDAK U3ViamVjdDogW1BBVENIXSBJbXByb3ZlIHByb2dyZXNzLXJlcG9ydGVyIHN0YXRlLCByZXN0b3Jl IHN1ZmZpeCAoYnVnIzgwOTg4CiBidWcjODExMzQpCgotIFJlbW92ZSBoYXJkLWNvZGVkIHN0YXRl IHJhbmdlLCBub3cgYSBtb25vdG9uaWNhbGx5IGluY3JlYXNpbmcKaW50ZWdlci4KCi0gUmVzdG9y ZSBkZXByZWNhdGVkIFNVRkZJWCBhcyB0aGlzIGlzIGJlaW5nIHVzZWQgb3V0c2lkZSBvZiBjb3Jl LgoKKiBsaXNwL3N1YnIuZWwgKHByb2dyZXNzLXJlcG9ydGVyLXVwZGF0ZS1mdW5jdGlvbnMpOiBV cGRhdGUKZG9jc3RyaW5nLgoocHJvZ3Jlc3MtcmVwb3J0ZXItZWNoby1hcmVhKTogVXNlCidwcm9n cmVzcy1yZXBvcnRlci0tcHVsc2UtY2hhcmFjdGVycycgbGVuZ3RoLiAgUHJpbnQgU1VGRklYLgoo cHJvZ3Jlc3MtcmVwb3J0ZXItZG8tdXBkYXRlKTogSW5jcmVhc2UgJ3N0YXRlJyBieSAxIGVhY2gg cGFzcy4KKgpsaXNwL3N5c3RlbS10YXNrYmFyLmVsIChzeXN0ZW0tdGFza2Jhci0tcHJvZ3Jlc3Mt cmVwb3J0ZXItdXBkYXRlKToKTWFrZSBzdGVwcyBpbmRlcGVuZGVudCBvZiAncHJvZ3Jlc3MtcmVw b3J0ZXItZWNoby1hcmVhJyBzdGVwcy4KLS0tCiBsaXNwL3N1YnIuZWwgICAgICAgICAgIHwgMjMg KysrKysrKysrKysrKy0tLS0tLS0tLS0KIGxpc3Avc3lzdGVtLXRhc2tiYXIuZWwgfCAgNCArKyst CiAyIGZpbGVzIGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQoKZGlm ZiAtLWdpdCBhL2xpc3Avc3Vici5lbCBiL2xpc3Avc3Vici5lbAppbmRleCBkOTc1OThhYjYxZi4u YTIyNDcwNmFhOWQgMTAwNjQ0Ci0tLSBhL2xpc3Avc3Vici5lbAorKysgYi9saXNwL3N1YnIuZWwK QEAgLTcxMTQsOCArNzExNCw3IEBAIHByb2dyZXNzLXJlcG9ydGVyLXVwZGF0ZS1mdW5jdGlvbnMK IFNUQVRFIGNhbiBiZSBvbmUgb2Y6CiAtIEEgZmxvYXQgcmVwcmVzZW50aW5nIHRoZSBwZXJjZW50 YWdlIGNvbXBsZXRlIGluIHRoZSByYW5nZSAwLjAtMS4wCiBmb3IgYSBudW1lcmljIHJlcG9ydGVy LgotLSBBbiBpbnRlZ2VyIHJlcHJlc2VudGluZyB0aGUgaW5kZXggd2hpY2ggY3ljbGVzIHRocm91 Z2ggdGhlIHJhbmdlIDAtMwotZm9yIGEgcHVsc2luZyByZXBvcnRlci4KKy0gQSBtb25vdG9uaWNh bGx5IGluY3JlYXNpbmcgaW50ZWdlciBmb3IgYSBwdWxzaW5nIHJlcG9ydGVyLgogLSBUaGUgc3lt Ym9sIGBkb25lJyB0byBpbmRpY2F0ZSB0aGF0IHRoZSBwcm9ncmVzcyByZXBvcnRlciBpcyBjb21w bGV0ZS4iKQogCiAoZGVmc3Vic3QgcHJvZ3Jlc3MtcmVwb3J0ZXItdXBkYXRlIChyZXBvcnRlciAm b3B0aW9uYWwgdmFsdWUgc3VmZml4KQpAQCAtNzEzMCw3ICs3MTI5LDcgQEAgcHJvZ3Jlc3MtcmVw b3J0ZXItdXBkYXRlCiBPcHRpb25hbCBhcmd1bWVudCBTVUZGSVggaXMgYSBzdHJpbmcgdG8gYmUg ZGlzcGxheWVkIGFmdGVyIFJFUE9SVEVSJ3MKIG1haW4gbWVzc2FnZSBhbmQgcHJvZ3Jlc3MgdGV4 dC4gIElmIFJFUE9SVEVSIGlzIGEgbm9uLW51bWVyaWNhbAogcmVwb3J0ZXIsIHRoZW4gVkFMVUUg c2hvdWxkIGJlIG5pbCwgb3IgYSBzdHJpbmcgdG8gdXNlIGluc3RlYWQgb2YKLVNVRkZJWC4gIFNV RkZJWCBpcyBjb25zaWRlcmVkIG9ic29sZXRlIGFuZCBtYXkgYmUgcmVtb3ZlZCBpbiB0aGUgZnV0 dXJlLgorU1VGRklYLgogCiBTZWUgYHByb2dyZXNzLXJlcG9ydGVyLXVwZGF0ZS1mdW5jdGlvbnMn IGZvciB0aGUgbGlzdCBvZiBmdW5jdGlvbnMKIGNhbGxlZCBvbiBlYWNoIHVwZGF0ZS4KQEAgLTcy MzAsMjAgKzcyMjksMjQgQEAgcHJvZ3Jlc3MtcmVwb3J0ZXItZWNoby1hcmVhCiAKIERvIG5vdCBl bWl0IGEgbWVzc2FnZSBpZiB0aGUgcmVwb3J0ZXIgY29udGV4dCBpcyBgYXN5bmMnIGFuZCB0aGUg ZWNobwogYXJlYSBpcyBidXN5IHdpdGggc29tZXRoaW5nIGVsc2UuIgotICAobGV0ICgodGV4dCAo cHJvZ3Jlc3MtcmVwb3J0ZXItdGV4dCByZXBvcnRlcikpKQorICAobGV0ICgodGV4dCAocHJvZ3Jl c3MtcmVwb3J0ZXItdGV4dCByZXBvcnRlcikpCisgICAgICAgIChzdWZmaXggKGlmLWxldCogKChz dWZmaXggKGFyZWYgKGNkciByZXBvcnRlcikgNikpKQorICAgICAgICAgICAgICAgICAgICAoY29u Y2F0ICIgIiBzdWZmaXgpCisgICAgICAgICAgICAgICAgICAiIikpKQogICAgICh1bmxlc3MgKGFu ZCAoZXEgKHByb2dyZXNzLXJlcG9ydGVyLWNvbnRleHQgcmVwb3J0ZXIpICdhc3luYykKICAgICAg ICAgICAgICAgICAgKGN1cnJlbnQtbWVzc2FnZSkKICAgICAgICAgICAgICAgICAgKG5vdCAoc3Ry aW5nLXByZWZpeC1wIHRleHQgKGN1cnJlbnQtbWVzc2FnZSkpKSkKICAgICAgIChwY2FzZSBzdGF0 ZQogICAgICAgICAoKHByZWQgZmxvYXRwKQogICAgICAgICAgKGlmIChwbHVzcCBzdGF0ZSkKLSAg ICAgICAgICAgICAobWVzc2FnZSAiJXMlZCUlIiB0ZXh0ICgqIHN0YXRlIDEwMC4wKSkKLSAgICAg ICAgICAgKG1lc3NhZ2UgIiVzIiB0ZXh0KSkpCisgICAgICAgICAgICAgKG1lc3NhZ2UgIiVzJWQl JSVzIiB0ZXh0ICgqIHN0YXRlIDEwMC4wKSBzdWZmaXgpCisgICAgICAgICAgIChtZXNzYWdlICIl cyVzIiB0ZXh0IHN1ZmZpeCkpKQogICAgICAgICAoKHByZWQgaW50ZWdlcnApCiAgICAgICAgICAo bGV0ICgobWVzc2FnZS1sb2ctbWF4IG5pbCkKLSAgICAgICAgICAgICAgIChwdWxzZS1jaGFyIChh cmVmIHByb2dyZXNzLXJlcG9ydGVyLS1wdWxzZS1jaGFyYWN0ZXJzCi0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBzdGF0ZSkpKQotICAgICAgICAgICAobWVzc2FnZSAiJXMgJXMiIHRl eHQgcHVsc2UtY2hhcikpKQorICAgICAgICAgICAgICAgKHB1bHNlLWNoYXIKKyAgICAgICAgICAg ICAgICAoYXJlZiBwcm9ncmVzcy1yZXBvcnRlci0tcHVsc2UtY2hhcmFjdGVycworICAgICAgICAg ICAgICAgICAgICAgIChtb2Qgc3RhdGUgKGxlbmd0aCBwcm9ncmVzcy1yZXBvcnRlci0tcHVsc2Ut Y2hhcmFjdGVycykpKSkpCisgICAgICAgICAgIChtZXNzYWdlICIlcyAlcyVzIiB0ZXh0IHB1bHNl LWNoYXIgc3VmZml4KSkpCiAgICAgICAgICgnZG9uZQogICAgICAgICAgKG1lc3NhZ2UgIiVzZG9u ZSIgdGV4dCkpKSkpKQogCkBAIC03Mjk0LDcgKzcyOTcsNyBAQCBwcm9ncmVzcy1yZXBvcnRlci1k by11cGRhdGUKICAgICAgICAgICAgKGlmIHN1ZmZpeAogICAgICAgICAgICAgICAgKGFzZXQgcGFy YW1ldGVycyA2IHN1ZmZpeCkKICAgICAgICAgICAgICAoc2V0cSBzdWZmaXggKG9yIChhcmVmIHBh cmFtZXRlcnMgNikgIiIpKSkKLSAgICAgICAgICAgKGxldCAoKGluZGV4IChtb2QgKDErIChjYXIg cmVwb3J0ZXIpKSA0KSkpCisgICAgICAgICAgIChsZXQgKChpbmRleCAoMSsgKGNhciByZXBvcnRl cikpKSkKIAkgICAgIChzZXRjYXIgcmVwb3J0ZXIgaW5kZXgpCiAgICAgICAgICAgICAgKHJ1bi1o b29rLXdpdGgtYXJncyAncHJvZ3Jlc3MtcmVwb3J0ZXItdXBkYXRlLWZ1bmN0aW9ucwogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVwb3J0ZXIKZGlmZiAtLWdpdCBhL2xpc3Avc3lz dGVtLXRhc2tiYXIuZWwgYi9saXNwL3N5c3RlbS10YXNrYmFyLmVsCmluZGV4IGNjNDExODNmYjMy Li45NzNiNDI2ZTAyNiAxMDA2NDQKLS0tIGEvbGlzcC9zeXN0ZW0tdGFza2Jhci5lbAorKysgYi9s aXNwL3N5c3RlbS10YXNrYmFyLmVsCkBAIC0yODIsNyArMjgyLDkgQEAgc3lzdGVtLXRhc2tiYXIt LXByb2dyZXNzLXJlcG9ydGVyLXVwZGF0ZQogICAgICAgKChwcmVkIGZsb2F0cCkKICAgICAgICAo c3lzdGVtLXRhc2tiYXItLXByb2dyZXNzIHN0YXRlKSkKICAgICAgICgocHJlZCBpbnRlZ2VycCkK LSAgICAgICAoc3lzdGVtLXRhc2tiYXItLXByb2dyZXNzICgvICgxKyBzdGF0ZSkgNC4wKSkpCisg ICAgICAgOzsgVGhpcyB3b24ndCBzaG93IDAuMCB0byBpbmRpY2F0ZSB3b3JrIGluIHByb2Nlc3Mg dW50aWwgZG9uZS4KKyAgICAgICAoc3lzdGVtLXRhc2tiYXItLXByb2dyZXNzCisgICAgICAgICgv ICgxKyAobW9kIHN0YXRlIDUpKSA1LjApKSkKICAgICAgICgnZG9uZQogICAgICAgIChzeXN0ZW0t dGFza2Jhci0tcHJvZ3Jlc3MgbmlsKSkpKSkKIAotLSAKMi41NC4wCgo= --0000000000005bd0840652f5fc4d--
bug-gnu-emacs@HIDDEN:bug#80988; Package emacs.
Full text available.Received: (at 80988) by debbugs.gnu.org; 28 May 2026 14:27:20 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 28 10:27:20 2026 Received: from localhost ([127.0.0.1]:36562 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1wSbhf-00078m-Su for submit <at> debbugs.gnu.org; Thu, 28 May 2026 10:27:20 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:39989) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <monnier@HIDDEN>) id 1wSbhd-00078T-Co for 80988 <at> debbugs.gnu.org; Thu, 28 May 2026 10:27:18 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 10168827B8; Thu, 28 May 2026 10:27:12 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1779978430; bh=lIO20Dtzw2rJycPENm8EBrS0lGKCDSuwVRlwok+aLyw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=L4xnCmBWl8SPaKDoDaXrbLzGyyPlrDimMDxo0fDSWPOuKitn1LSw0T1Yuv8donzSB FmqpgSmVm/WhA3IoQLBd+FtuioAUYuYqdusPbOHFYaQLQzNJQBiJJUw1rssZQNZfTp Spi+oltL/WYvxM1dzo1W1Et8bDhCvbnI2cvrXM1Tx6g4bsSX0DPv7uedR3/NQSjGEX YL3ROatHD++dJ+2td6W4m177lftqki/d7siuYydQzSrRDAbfEkUvhUsKwtN7g+O2MF ATeS74NrWg/7bG4t+RQumG4uo9bB16/WS9tpdN+PCC6Zhs/jymQ+UHfCn0rdT9LfXn tN7obrwh8NR2Q== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 7595E819F4; Thu, 28 May 2026 10:27:10 -0400 (EDT) Received: from pastel (104-195-197-162.cpe.teksavvy.com [104.195.197.162]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4C911120193; Thu, 28 May 2026 10:27:10 -0400 (EDT) From: Stefan Monnier <monnier@HIDDEN> To: =?windows-1252?Q?St=E9phane?= Marks <shipmints@HIDDEN> Subject: Re: bug#80988: 31.0.50; Progress report (commit f5f2306fc1d) In-Reply-To: <CAN+1HbpMd-VFozDHjUCf07RKje-4jQL74BZ9MUNBYOYgHKE-Vw@HIDDEN> Message-ID: <jwvse7ba9yt.fsf-monnier+emacs@HIDDEN> References: <875x4yl7fm.fsf@HIDDEN> <CAN+1Hbrs_rFU35hBUaKa-AA7eaYZOmnPBMaw-Di5hDrCsd9uOA@HIDDEN> <878q9rquo1.fsf@HIDDEN> <CAN+1HbpJP7aWDioF1GSBHh0Bem8Od1_Ea_qJqoyx0+ptNaDaJg@HIDDEN> <CAN+1Hbq00c0WZnYuf_hatUweO3-0tGMJge1BQDpzmaQANbF3LA@HIDDEN> <jwvbje2f5m3.fsf-monnier+emacs@HIDDEN> <CAN+1HboAqmXqWbXNq=BQUjpQGRh==xzZF356C44DSdtbGLU35g@HIDDEN> <jwvh5nsioyh.fsf-monnier+emacs@HIDDEN> <CAN+1Hbp5i=33WotqfnXwKZUKAZ9apVqVuoNZW5WkjLJU0P7XPw@HIDDEN> <jwvbje0im50.fsf-monnier+emacs@HIDDEN> <CAN+1HbpMd-VFozDHjUCf07RKje-4jQL74BZ9MUNBYOYgHKE-Vw@HIDDEN> Date: Thu, 28 May 2026 10:27:09 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.097 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 80988 Cc: Augusto Stoffel <arstoffel@HIDDEN>, 80988 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > So we're no longer going to cycle like the docstring suggests > > - An integer representing the index which cycles through the range 0-3 > for a pulsing reporter. > > and switch to a monotonic counter? Exactly. If STATE cycles via `mod N`, then the backends can use cycles only of length N or a divisor of N. What's the benefit? === Stefan
bug-gnu-emacs@HIDDEN:bug#80988; Package emacs.
Full text available.
Received: (at 80988) by debbugs.gnu.org; 27 May 2026 21:28:08 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 27 17:28:08 2026
Received: from localhost ([127.0.0.1]:50733 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1wSLnM-0004Pq-B7
for submit <at> debbugs.gnu.org; Wed, 27 May 2026 17:28:08 -0400
Received: from mail-vk1-xa31.google.com ([2607:f8b0:4864:20::a31]:47498)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <shipmints@HIDDEN>)
id 1wSLnK-0004Pf-5i
for 80988 <at> debbugs.gnu.org; Wed, 27 May 2026 17:28:07 -0400
Received: by mail-vk1-xa31.google.com with SMTP id
71dfb90a1353d-57512b86273so8820518e0c.3
for <80988 <at> debbugs.gnu.org>; Wed, 27 May 2026 14:28:06 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1779917285; cv=none;
d=google.com; s=arc-20240605;
b=QR85GisZaLIbfcdDGxZEll+Asciyv5FhJmirP3atgwKr/0mAvmmdZj1yDq70PisN0c
gC4yBDESJYgxFJ/GDzXiOZcCkkbzvucCzYVr2cJftKB4Rhdi1tyyF7XQjocW0BN0ha13
cuVOYmTefvUxvT+PurKnz6C2Z4RjeOLWgIESFGlU+N45OAcLG4rSsS7avTrRfuRIkhn1
CkangalUyV34GaNq6ZCSWRxJTeiKHd6dnv850PSplAoC63SNvBMnp+YP9EBP+7Cwgj0z
dWPLk5m2ZRf5pCz2nxXpsx+I0rCWHk5FJOZNXyAd7mRHUxrDkLLgy7noyt3TGzCsYNOh
0EtA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20240605;
h=cc:to:subject:message-id:date:from:in-reply-to:references
:mime-version:dkim-signature;
bh=s0n4gp69pYJ1n0f0UdjCPkJ9TTXNbBolcwV2+CR9q/0=;
fh=AsDdQXxvI7RRVp2LipQZ/JQYkRvvpKQ+aXQhz3mY3JI=;
b=XkdXHQ+XHW34jPzYXmuMwDHzbHdMuPfsY9yatBRO/G3qqdLXoDuznjlXq4LWwKcDV6
RKyYaceo9S+1fUQ8zzjAfNniqJe6NcfBkOX2Q0rZZX6+Ein2Es6mkYBEhI5mqDq3HUAa
qQfwNVIhy7EUXwCF6EdLNjBJPeHeKRrHPEXAZNRnCiAVEZOuESEUwHREFlDbNmEXs46g
UksFEsINbFrjLqlMRZIW15cf/R8xm5nZQdsxTUTcUz5LQfu4YkeOlAP4dmg2klILmFch
S4FT3/J4dGIx169+MRpqpRu/3khjmEXRtO4VUT01eT/tk73oS2KKSSYtGdiC+49HLYgB
V8qg==; darn=debbugs.gnu.org
ARC-Authentication-Results: i=1; mx.google.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20251104; t=1779917285; x=1780522085; darn=debbugs.gnu.org;
h=cc:to:subject:message-id:date:from:in-reply-to:references
:mime-version:from:to:cc:subject:date:message-id:reply-to;
bh=s0n4gp69pYJ1n0f0UdjCPkJ9TTXNbBolcwV2+CR9q/0=;
b=slOyVqQ/7zHBjP1oxhchAOWlvOSiiCCmWoQz1s1NljNmdB87bJB+J2rIUQaha+I5lD
Wd0pcW06OWL4NiglU4HeZhAX2dNxqBsnSJved5jd0XvMUQQrq1smbKbve/TwpYWw8rF7
GtXFUCsTP4e4sqA2nKtar2QTjwnGGz3oT3NqdP+aXez+lP2FdiWAIPuF02clY/d37qNc
cRXxEeHwBtpTmPoIU2FGybH1YCdcqyPgoJqfJeWBX+1zmiwBTOjvnFo3g4g1ogb465eI
eTz9jL/qvb5+gXhueSUSQVbWQ1GkChgpDTrej4EYTycqPZ1Jos9sgGefEQhlnP2XTVws
ayMw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20251104; t=1779917285; x=1780522085;
h=cc:to:subject:message-id:date:from:in-reply-to:references
:mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date
:message-id:reply-to;
bh=s0n4gp69pYJ1n0f0UdjCPkJ9TTXNbBolcwV2+CR9q/0=;
b=kQwgfupY2RksHMxhiFbjTkQpGKA9W7H8jyG8aCUy2po8Z5qhE5w56O+JrcYSVRhgpz
kXjgCbP1zdijMT/xCZr38SGl8bsZNmneTks+nI85V77T0SwTJrBfV96R/31To9qOI4K0
X74qloevqSb6syNiGuVSmvoB3ApuUU3IxIOtJ4Q/rVL/LE87trxZah3PkTJcKRq6lvkK
1WfFgfW2AjhXSU8Ss1HgDgBboPJG19WoTftmIjdNMWsZ91riyRK2K+u0qHuAh+HWcyRa
yhFBxPNLIIBf9L6nF1d7KpcrQnG1l7lQ2Pe/hg9YPqzllz05mcN/kgSnZ9HCsJqcU290
6a9g==
X-Forwarded-Encrypted: i=1;
AFNElJ87uMyDCgvKZDciI4ayeKN/B1499MVBaqpmdlKfaPMTx7EAyVmk3PT3HJmHvKK9vF4UpV8mLQ==@debbugs.gnu.org
X-Gm-Message-State: AOJu0Yy5ybVgr0nOteDpBjjBgOps55Zbd2M0FZWQIVL5PR7GfApTij8L
CfHXVuZ8xapJPgJDWKwyr7VhqVt7LQzLRJsG4rGCMTXipiuZhdXuHD1jitP3B5P7IMRECpuyUCN
/h67YrKGrXnx893cQHz25SfN5au5fWa0=
X-Gm-Gg: Acq92OGkglUnXpGGWwiivbkW+tJrLuBBZvfWlkFWxqg8V30AIIhosk3I6T4dkBRuTfQ
Bz3dszlIdkJF0X9T+/BX/eDpRIwCKhvuFQ6Y82zLNA9z0qo7VmSl+qUF8BoaHlaM01IpTp59+Kd
4BTfQOLFwfUsj55MIIF69cH9c9xPJg86fSLD1yM975g/OKSAcQwFU0/M3FD313SXqR1xep3Vwbi
5YmC4Ob7cSXWGmXGDosIuIKKagkWiywPMaP8szRqPKXctxYadWA7Jh4G4gksGSjxOLVwI7RzWzK
dJTcX0cY5DyHHLRAtm41YNbIHzCNN1ZPg5cQTkakXeGefTPmZ5JAQy0eISKor0rr81b1S8SmPm+
Rm07HNkyBhG0kJQNa7FHCrIc95jdsC9YSs1aZCFZfbe6ut+flTyZBYhSBHXg=
X-Received: by 2002:a05:6122:4b14:b0:575:3b1b:ef01 with SMTP id
71dfb90a1353d-58662aba6edmr14103874e0c.9.1779917285119; Wed, 27 May 2026
14:28:05 -0700 (PDT)
MIME-Version: 1.0
References: <875x4yl7fm.fsf@HIDDEN>
<CAN+1Hbrs_rFU35hBUaKa-AA7eaYZOmnPBMaw-Di5hDrCsd9uOA@HIDDEN>
<878q9rquo1.fsf@HIDDEN>
<CAN+1HbpJP7aWDioF1GSBHh0Bem8Od1_Ea_qJqoyx0+ptNaDaJg@HIDDEN>
<CAN+1Hbq00c0WZnYuf_hatUweO3-0tGMJge1BQDpzmaQANbF3LA@HIDDEN>
<jwvbje2f5m3.fsf-monnier+emacs@HIDDEN>
<CAN+1HboAqmXqWbXNq=BQUjpQGRh==xzZF356C44DSdtbGLU35g@HIDDEN>
<jwvh5nsioyh.fsf-monnier+emacs@HIDDEN>
<CAN+1Hbp5i=33WotqfnXwKZUKAZ9apVqVuoNZW5WkjLJU0P7XPw@HIDDEN>
<jwvbje0im50.fsf-monnier+emacs@HIDDEN>
In-Reply-To: <jwvbje0im50.fsf-monnier+emacs@HIDDEN>
From: =?UTF-8?Q?St=C3=A9phane_Marks?= <shipmints@HIDDEN>
Date: Wed, 27 May 2026 17:27:52 -0400
X-Gm-Features: AVHnY4JeDTtWp3d_Ly6Yl1Cga5iXpU3aVnSmadeWGKxvTfQkdM-ZDGGp944PC4o
Message-ID: <CAN+1HbpMd-VFozDHjUCf07RKje-4jQL74BZ9MUNBYOYgHKE-Vw@HIDDEN>
Subject: Re: bug#80988: 31.0.50; Progress report (commit f5f2306fc1d)
To: Stefan Monnier <monnier@HIDDEN>
Content-Type: multipart/alternative; boundary="000000000000825f720652d349ec"
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: 80988
Cc: Augusto Stoffel <arstoffel@HIDDEN>, 80988 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.0 (/)
--000000000000825f720652d349ec
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
On Wed, May 27, 2026 at 5:24=E2=80=AFPM Stefan Monnier <monnier@HIDDEN=
al.ca>
wrote:
> >> > diff --git a/lisp/system-taskbar.el b/lisp/system-taskbar.el
> >> > index cc41183fb32..973b426e026 100644
> >> > --- a/lisp/system-taskbar.el
> >> > +++ b/lisp/system-taskbar.el
> >> > @@ -282,7 +282,9 @@ system-taskbar--progress-reporter-update
> >> > ((pred floatp)
> >> > (system-taskbar--progress state))
> >> > ((pred integerp)
> >> > - (system-taskbar--progress (/ (1+ state) 4.0)))
> >> > + ;; This won't show 0.0 to indicate work in process until don=
e.
> >> > + (system-taskbar--progress
> >> > + (/ (1+ (mod state 5)) 5.0)))
> >> > ('done
> >> > (system-taskbar--progress nil)))))
> >>
> >> AFAICT, `state` here will cycle between 0, 1, 2, 3, 0, 1, ... so the
> >> `mod 5` won't do anything. And I think we should fix this by not doin=
g
> >> the `mod` in `progress-reporter-do-update`.
> > That's only true if the pulse characters are never replaced with a stri=
ng
> > longer or shorter than 4. I replace mine.
>
> IIUC your comment is referring to my statement that "`state` here will
> cycle between 0, 1, 2, 3, 0, 1, ..." and indeed it depends on the
> pulse-characters variable, but my point is just that `state` should
> simply be an integer that grows by one at each step (and never wrap
> around), so we can use different `mod` in different backends.
>
So we're no longer going to cycle like the docstring suggests
- An integer representing the index which cycles through the range 0-3
for a pulsing reporter.
and switch to a monotonic counter?
--000000000000825f720652d349ec
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon=
t-family:monospace"><span style=3D"font-family:Arial,Helvetica,sans-serif">=
On Wed, May 27, 2026 at 5:24=E2=80=AFPM Stefan Monnier <<a href=3D"mailt=
o:monnier@HIDDEN">monnier@HIDDEN</a>> wrote:</span><=
/div></div><div class=3D"gmail_quote gmail_quote_container"><blockquote cla=
ss=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid =
rgb(204,204,204);padding-left:1ex">>> > diff --git a/lisp/system-t=
askbar.el b/lisp/system-taskbar.el<br>
>> > index cc41183fb32..973b426e026 100644<br>
>> > --- a/lisp/system-taskbar.el<br>
>> > +++ b/lisp/system-taskbar.el<br>
>> > @@ -282,7 +282,9 @@ system-taskbar--progress-reporter-update<=
br>
>> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 ((pred floatp)<br>
>> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(system-taskbar--progress st=
ate))<br>
>> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 ((pred integerp)<br>
>> > -=C2=A0 =C2=A0 =C2=A0 =C2=A0(system-taskbar--progress (/ (1+ =
state) 4.0)))<br>
>> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0;; This won't show 0.0 to ind=
icate work in process until done.<br>
>> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0(system-taskbar--progress<br>
>> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 (/ (1+ (mod state 5)) 5.0)))<br>
>> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 ('done<br>
>> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(system-taskbar--progress ni=
l)))))<br>
>><br>
>> AFAICT, `state` here will cycle between 0, 1, 2, 3, 0, 1, ... so t=
he<br>
>> `mod 5` won't do anything.=C2=A0 And I think we should fix thi=
s by not doing<br>
>> the `mod` in `progress-reporter-do-update`.<br>
> That's only true if the pulse characters are never replaced with a=
string<br>
> longer or shorter than 4.=C2=A0 I replace mine.<br>
<br>
IIUC your comment is referring to my statement that "`state` here will=
<br>
cycle between 0, 1, 2, 3, 0, 1, ..." and indeed it depends on the<br>
pulse-characters variable, but my point is just that `state` should<br>
simply be an integer that grows by one at each step (and never wrap<br>
around), so we can use different `mod` in different backends.<br></blockquo=
te><div><br></div><div class=3D"gmail_default" style=3D"font-family:monospa=
ce">So we're no longer going to cycle like the docstring suggests</div>=
<div class=3D"gmail_default" style=3D"font-family:monospace"><br></div><div=
class=3D"gmail_default" style=3D"font-family:monospace">=C2=A0 - An intege=
r representing the index which cycles through the range 0-3<br>=C2=A0 for a=
pulsing reporter.<br></div><div class=3D"gmail_default" style=3D"font-fami=
ly:monospace"><br></div><div class=3D"gmail_default" style=3D"font-family:m=
onospace">and switch to a monotonic counter?</div></div></div>
--000000000000825f720652d349ec--
bug-gnu-emacs@HIDDEN:bug#80988; Package emacs.
Full text available.
Received: (at 80988) by debbugs.gnu.org; 27 May 2026 21:24:40 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 27 17:24:40 2026
Received: from localhost ([127.0.0.1]:50681 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1wSLk0-00046S-GE
for submit <at> debbugs.gnu.org; Wed, 27 May 2026 17:24:40 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:40277)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <monnier@HIDDEN>)
id 1wSLjy-000468-H9
for 80988 <at> debbugs.gnu.org; Wed, 27 May 2026 17:24:39 -0400
Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 605F682141;
Wed, 27 May 2026 17:24:32 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1779917071;
bh=pMH+jW+NZ6OeUeqBmj9yfd6qTaqx5/mNpX3IeIXvgFo=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=aqpemnwLKOtAkL50jmhrVcEkorOAg3HVYbBjLoHBAL0wx/UpBMYYV56hX46VqUFhF
wpiEIhADhAB//7DqXlVoYPcWra03S1jNDDlQMNFrK8SFWdLgIN/q/5pqQnJrICg8BT
xEK/7uvScEgAy+WKPxJ0la2/BG/weofOeX9H48DRyJJxBV5hcmUFwyVpF40ZZXOc8Y
XNXTaOGCWCYgTLF7GKQrZVkOiTGf4kaC1LPZsE4C6b1BsGSxkD7cgQf+izAuRiQs9R
8IO9gSnekiinugLqXsbqw+eBC3oW/SzE2A1PhGjn9/WY4ACCGoNoWYK9pevjoQl6+R
qEvKqXWSG9ZOA==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 0FBFE816A5;
Wed, 27 May 2026 17:24:31 -0400 (EDT)
Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E7F8F12044C;
Wed, 27 May 2026 17:24:30 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: =?windows-1252?Q?St=E9phane?= Marks <shipmints@HIDDEN>
Subject: Re: bug#80988: 31.0.50; Progress report (commit f5f2306fc1d)
In-Reply-To: <CAN+1Hbp5i=33WotqfnXwKZUKAZ9apVqVuoNZW5WkjLJU0P7XPw@HIDDEN>
Message-ID: <jwvbje0im50.fsf-monnier+emacs@HIDDEN>
References: <875x4yl7fm.fsf@HIDDEN>
<CAN+1Hbrs_rFU35hBUaKa-AA7eaYZOmnPBMaw-Di5hDrCsd9uOA@HIDDEN>
<878q9rquo1.fsf@HIDDEN>
<CAN+1HbpJP7aWDioF1GSBHh0Bem8Od1_Ea_qJqoyx0+ptNaDaJg@HIDDEN>
<CAN+1Hbq00c0WZnYuf_hatUweO3-0tGMJge1BQDpzmaQANbF3LA@HIDDEN>
<jwvbje2f5m3.fsf-monnier+emacs@HIDDEN>
<CAN+1HboAqmXqWbXNq=BQUjpQGRh==xzZF356C44DSdtbGLU35g@HIDDEN>
<jwvh5nsioyh.fsf-monnier+emacs@HIDDEN>
<CAN+1Hbp5i=33WotqfnXwKZUKAZ9apVqVuoNZW5WkjLJU0P7XPw@HIDDEN>
Date: Wed, 27 May 2026 17:24:30 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL 0.190 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 80988
Cc: Augusto Stoffel <arstoffel@HIDDEN>, 80988 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
>> > diff --git a/lisp/system-taskbar.el b/lisp/system-taskbar.el
>> > index cc41183fb32..973b426e026 100644
>> > --- a/lisp/system-taskbar.el
>> > +++ b/lisp/system-taskbar.el
>> > @@ -282,7 +282,9 @@ system-taskbar--progress-reporter-update
>> > ((pred floatp)
>> > (system-taskbar--progress state))
>> > ((pred integerp)
>> > - (system-taskbar--progress (/ (1+ state) 4.0)))
>> > + ;; This won't show 0.0 to indicate work in process until done.
>> > + (system-taskbar--progress
>> > + (/ (1+ (mod state 5)) 5.0)))
>> > ('done
>> > (system-taskbar--progress nil)))))
>>
>> AFAICT, `state` here will cycle between 0, 1, 2, 3, 0, 1, ... so the
>> `mod 5` won't do anything. And I think we should fix this by not doing
>> the `mod` in `progress-reporter-do-update`.
> That's only true if the pulse characters are never replaced with a string
> longer or shorter than 4. I replace mine.
IIUC your comment is referring to my statement that "`state` here will
cycle between 0, 1, 2, 3, 0, 1, ..." and indeed it depends on the
pulse-characters variable, but my point is just that `state` should
simply be an integer that grows by one at each step (and never wrap
around), so we can use different `mod` in different backends.
=== Stefan
bug-gnu-emacs@HIDDEN:bug#80988; Package emacs.
Full text available.
Received: (at 80988) by debbugs.gnu.org; 27 May 2026 20:30:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 27 16:30:27 2026
Received: from localhost ([127.0.0.1]:50202 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1wSKtW-00086n-2y
for submit <at> debbugs.gnu.org; Wed, 27 May 2026 16:30:26 -0400
Received: from mail-vs1-xe2a.google.com ([2607:f8b0:4864:20::e2a]:51464)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <shipmints@HIDDEN>)
id 1wSKtT-00086c-Tn
for 80988 <at> debbugs.gnu.org; Wed, 27 May 2026 16:30:24 -0400
Received: by mail-vs1-xe2a.google.com with SMTP id
ada2fe7eead31-6314287380bso8889562137.3
for <80988 <at> debbugs.gnu.org>; Wed, 27 May 2026 13:30:23 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1779913823; cv=none;
d=google.com; s=arc-20240605;
b=F36jzGO884PNAZWkKzRaKrqd1I9/fTvxEsmOf0+vbSrqgd5kF8mICt7DlhBMm3NWhT
tE65Br/zTw+0ASbb2B4ryiRpjy5uDtTeHtS5r8nh7s3Z/aL7tBJgBDJtaQhR+4P+iToD
q1WFDWGZNlJ3ARDy00ObBE/6x3boTOwJ1r91em3ENbqElRMg8foHS33iUJ+vjReUeHcz
1nTR71K12KDidVgHRQXNZj6F82nSyiWvtlRoYwgHJulNF1qDPs7vks1mRTnM255jzZOF
Aoh6HH5Dx7+0fbSiGJy1i7NR5DEKuzkksSYMXzn7lvyqF2Q5kXZj67WhBwdPJndP3WT+
3N2w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20240605;
h=cc:to:subject:message-id:date:from:in-reply-to:references
:mime-version:dkim-signature;
bh=9FcT/5wL+tMyp37+ewRdz4soSaC9FHogAFtl6rOD5vc=;
fh=JRGSNfv8Ym534gzjh3CzC5sx05DPgXj/R9IK34R8b0s=;
b=Bm3kVIbefzgL4kQeyATB0z7AxQNsBf4V8fEz6nOWNmV0s93u6xxzWbd9eLM0yr5oei
ZGoHvXgzStKf53rirMYBXYCbn5a1USZt00+BX+rKywAm4tKYEgNrP/+aPnR4Biid6sBF
SKiwa66S/W28HUPUJHq1ckBnEJu3S/tR9hjIBqRFIGs9j3jeTItvmbZESeTGLK0R5jW/
NOubbos3WAwC2NTPWtpa84DIg1JPybjz1n4jguPTZ8HZLeC+AqLMjSXZHRgPTl1CqioL
Mmp38Qi+CTin+nzznF0mJ+DY7zSMsoB3hjfHIR6lwwZSVSz0+SBpCIdj7i0Vx1hAowpi
5TBQ==; darn=debbugs.gnu.org
ARC-Authentication-Results: i=1; mx.google.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20251104; t=1779913823; x=1780518623; darn=debbugs.gnu.org;
h=cc:to:subject:message-id:date:from:in-reply-to:references
:mime-version:from:to:cc:subject:date:message-id:reply-to;
bh=9FcT/5wL+tMyp37+ewRdz4soSaC9FHogAFtl6rOD5vc=;
b=Y8rwmvQTyOtmSeiRp2/YL3ATDeCYcKwIgqnvrn4vWrt/gDL4745jMKMNB5ELDsFRkT
sFXaKmLrVjBOx8JhwsYEdOxfTBdD7TNMZs75Z39kAXFIPztIIjqV0kasle2q+MXeVafY
2utfSiUDjC3rGltF/7nGxi1sV/r8F+iJDwvecHynmEApA+KVeQLaXp4J3m+r+gwrCTqZ
UrqqYwuBcNTPJ8LSNFjxB3AdPzEd2OxFyZY2keMT2kOQ9XzW2qBUx/OKFy7+2TcwpCRr
YoddW3Y5Qytzvr2mYpd1GABsNVA6T2HMlkBsfYsxqvqAHGLZhYUJmAY0pPZTlhPp8JlD
Xw5w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20251104; t=1779913823; x=1780518623;
h=cc:to:subject:message-id:date:from:in-reply-to:references
:mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date
:message-id:reply-to;
bh=9FcT/5wL+tMyp37+ewRdz4soSaC9FHogAFtl6rOD5vc=;
b=QegjhozrhCVEgBZE3O11XK/xP8ro5k4B9LcJhRoezFPSU/c5ImDh/QERvY+3Ft+hCC
ge5Lr69Mwfz+RE5IGPrvPkvt9NFo0Gg9nF2XcaL5MhgKTKF2rJKtrONxH3iCve1cXr8C
cZfeDY1JooYC7MjBb8MusCaSt1MuxUsKNb7Nqk4jJoWPSAtWtpiMJat0YLiwAUR8yTqu
NWWBEYNGdx4s/e94qE2tq6jCWA19fpyEMp5ftipNAcq75E7EQh3la33XLWlAJxQ7zVOE
Y/G5jwx3jed7nLIxbtfaR57xp8Qq4KiH/gjjUjPxZJsCCU699G9cuD/+U9yozhONi+s3
LDCQ==
X-Forwarded-Encrypted: i=1;
AFNElJ8wy1AJRO0u8XHDlg6lFBqN+a+i7zFLdHxaympFEQWm7ePsitqyJMyE13U479kgHR0bze+3lg==@debbugs.gnu.org
X-Gm-Message-State: AOJu0Yw3VpzFZ8JwI5d6MUKEPyhjfirZrlwdoCV40j7W3Wt9aNUt0FOl
KB45tmMaQDCrHxZyT3HWBMoXNHkOBykN+nit3GVHpuYuEz8ZECggFdR+G7B8IYTOnfyObnoAv/x
sL4qf13YnaCbr99SN2UkQI6Zf2NIvLsI=
X-Gm-Gg: Acq92OE0j120DtAgI3sD7g+pQnu5LWETiRhxQ4yBWggfvmqaCa3tkXehkPo+mkeKFuz
gGZssunsSHMXCB2eaSLdgI722bi5mFRIJBKBlx/2oelckyP8dxS3D0Ojk7Ou6KDVC48uLuqyct8
7EA5w6QFChFrGePNLHQoHD4aMnETFq2f4nUgpPsomNP5zO2wvqwIZtUbV2c1ooPo2kIuq8D3OAM
nlejQr/kG2eoWyD6+pS5KR4ULr9Ihws3CJW4Qa15XEe1owjpqIBHmPA9Ctbgt2jYYfotXXpjqml
ov9VWI4Kl7BBhVixgFm23Rgrv9NxmEKFq0MLt+8wBkfuOsgtR6CE0qCz39nJRywWwJHkzTs/Slh
iskxVURLJCfzFBjRTk3qrXVZb1KThg8ZAkKyFh97qi2uSaX4tPcRP+kb4c0g=
X-Received: by 2002:a05:6102:5ccb:b0:632:73ad:6c8 with SMTP id
ada2fe7eead31-67c7f273532mr14542506137.7.1779913822996; Wed, 27 May 2026
13:30:22 -0700 (PDT)
MIME-Version: 1.0
References: <875x4yl7fm.fsf@HIDDEN>
<CAN+1Hbrs_rFU35hBUaKa-AA7eaYZOmnPBMaw-Di5hDrCsd9uOA@HIDDEN>
<878q9rquo1.fsf@HIDDEN>
<CAN+1HbpJP7aWDioF1GSBHh0Bem8Od1_Ea_qJqoyx0+ptNaDaJg@HIDDEN>
<CAN+1Hbq00c0WZnYuf_hatUweO3-0tGMJge1BQDpzmaQANbF3LA@HIDDEN>
<jwvbje2f5m3.fsf-monnier+emacs@HIDDEN>
<CAN+1HboAqmXqWbXNq=BQUjpQGRh==xzZF356C44DSdtbGLU35g@HIDDEN>
<jwvh5nsioyh.fsf-monnier+emacs@HIDDEN>
In-Reply-To: <jwvh5nsioyh.fsf-monnier+emacs@HIDDEN>
From: =?UTF-8?Q?St=C3=A9phane_Marks?= <shipmints@HIDDEN>
Date: Wed, 27 May 2026 16:30:11 -0400
X-Gm-Features: AVHnY4KoqSjJ1Om2OseVROV6lLH83cgsp_MwAwcUsKJ-SXlL819vq2xWc0IMUsM
Message-ID: <CAN+1Hbp5i=33WotqfnXwKZUKAZ9apVqVuoNZW5WkjLJU0P7XPw@HIDDEN>
Subject: Re: bug#80988: 31.0.50; Progress report (commit f5f2306fc1d)
To: Stefan Monnier <monnier@HIDDEN>
Content-Type: multipart/alternative; boundary="000000000000268ca20652d27b7c"
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: 80988
Cc: Augusto Stoffel <arstoffel@HIDDEN>, 80988 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.0 (/)
--000000000000268ca20652d27b7c
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
On Wed, May 27, 2026 at 4:23=E2=80=AFPM Stefan Monnier <monnier@HIDDEN=
al.ca>
wrote:
> >> > @@ -7294,7 +7300,8 @@ progress-reporter-do-update
> >> > (if suffix
> >> > (aset parameters 6 suffix)
> >> > (setq suffix (or (aref parameters 6) "")))
> >> > - (let ((index (mod (1+ (car reporter)) 4)))
> >> > + (let ((index (mod (1+ (car reporter))
> >> > + (length
> progress-reporter-pulse-characters))))
> >> > (setcar reporter index)
> >> > (run-hook-with-args 'progress-reporter-update-function=
s
> >> > reporter
> >>
> >> Why do any `mod` operation here at all?
>
> This question remains.
>
> > @@ -7114,8 +7114,9 @@ progress-reporter-update-functions
> > STATE can be one of:
> > - A float representing the percentage complete in the range 0.0-1.0
> > for a numeric reporter.
> > -- An integer representing the index which cycles through the range 0-3
> > -for a pulsing reporter.
> > +- An integer which for a pulsing reporter cycles through the character=
s
> > +in the vector `progress-reporter--pulse-characters'; i.e., the integer
> > +modulo the length of the vector.
> > - The symbol `done' to indicate that the progress reporter is
> complete.")
> >
> > (defsubst progress-reporter-update (reporter &optional value suffix)
>
> I think after we answer the above question, this text may need some tweak=
.
>
> > @@ -7241,8 +7242,9 @@ progress-reporter-echo-area
> > (message "%s" text)))
> > ((pred integerp)
> > (let ((message-log-max nil)
> > - (pulse-char (aref progress-reporter--pulse-characters
> > - state)))
> > + (pulse-char
> > + (aref progress-reporter--pulse-characters
> > + (mod state (length
> progress-reporter--pulse-characters)))))
> > (message "%s %s" text pulse-char)))
> > ('done
> > (message "%sdone" text))))))
> > @@ -7294,7 +7296,8 @@ progress-reporter-do-update
> > (if suffix
> > (aset parameters 6 suffix)
> > (setq suffix (or (aref parameters 6) "")))
> > - (let ((index (mod (1+ (car reporter)) 4)))
> > + (let ((index (mod (1+ (car reporter))
> > + (length
> progress-reporter--pulse-characters))))
> > (setcar reporter index)
> > (run-hook-with-args 'progress-reporter-update-functions
> > reporter
> > diff --git a/lisp/system-taskbar.el b/lisp/system-taskbar.el
> > index cc41183fb32..973b426e026 100644
> > --- a/lisp/system-taskbar.el
> > +++ b/lisp/system-taskbar.el
> > @@ -282,7 +282,9 @@ system-taskbar--progress-reporter-update
> > ((pred floatp)
> > (system-taskbar--progress state))
> > ((pred integerp)
> > - (system-taskbar--progress (/ (1+ state) 4.0)))
> > + ;; This won't show 0.0 to indicate work in process until done.
> > + (system-taskbar--progress
> > + (/ (1+ (mod state 5)) 5.0)))
> > ('done
> > (system-taskbar--progress nil)))))
>
> AFAICT, `state` here will cycle between 0, 1, 2, 3, 0, 1, ... so the
> `mod 5` won't do anything. And I think we should fix this by not doing
> the `mod` in `progress-reporter-do-update`.
>
That's only true if the pulse characters are never replaced with a string
longer or shorter than 4. I replace mine.
--000000000000268ca20652d27b7c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon=
t-family:monospace"><span style=3D"font-family:Arial,Helvetica,sans-serif">=
On Wed, May 27, 2026 at 4:23=E2=80=AFPM Stefan Monnier <<a href=3D"mailt=
o:monnier@HIDDEN">monnier@HIDDEN</a>> wrote:</span><=
/div></div><div class=3D"gmail_quote gmail_quote_container"><blockquote cla=
ss=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid =
rgb(204,204,204);padding-left:1ex">>> > @@ -7294,7 +7300,8 @@ prog=
ress-reporter-do-update<br>
>> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(if suffix<br>
>> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
(aset parameters 6 suffix)<br>
>> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(setq s=
uffix (or (aref parameters 6) "")))<br>
>> > -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(let ((index (mod (=
1+ (car reporter)) 4)))<br>
>> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(let ((index (mod (=
1+ (car reporter))<br>
>> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(length progress-reporter-puls=
e-characters))))<br>
>> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (setcar reporter ind=
ex)<br>
>> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(run-ho=
ok-with-args 'progress-reporter-update-functions<br>
>> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0reporter<br>
>><br>
>> Why do any `mod` operation here at all?<br>
<br>
This question remains.<br>
<br>
> @@ -7114,8 +7114,9 @@ progress-reporter-update-functions<br>
>=C2=A0 STATE can be one of:<br>
>=C2=A0 - A float representing the percentage complete in the range 0.0-=
1.0<br>
>=C2=A0 for a numeric reporter.<br>
> -- An integer representing the index which cycles through the range 0-=
3<br>
> -for a pulsing reporter.<br>
> +- An integer which for a pulsing reporter cycles through the characte=
rs<br>
> +in the vector `progress-reporter--pulse-characters'; i.e., the in=
teger<br>
> +modulo the length of the vector.<br>
>=C2=A0 - The symbol `done' to indicate that the progress reporter i=
s complete.")<br>
>=C2=A0 <br>
>=C2=A0 (defsubst progress-reporter-update (reporter &optional value=
suffix)<br>
<br>
I think after we answer the above question, this text may need some tweak.<=
br>
<br>
> @@ -7241,8 +7242,9 @@ progress-reporter-echo-area<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(message "%s"=
text)))<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ((pred integerp)<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(let ((message-log-max nil)<br=
>
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(pulse-char (a=
ref progress-reporter--pulse-characters<br>
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0state)))<br>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(pulse-char<br=
>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (aref progres=
s-reporter--pulse-characters<br>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
=C2=A0 (mod state (length progress-reporter--pulse-characters)))))<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(message "%s %s&qu=
ot; text pulse-char)))<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ('done<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(message "%sdone" te=
xt))))))<br>
> @@ -7294,7 +7296,8 @@ progress-reporter-do-update<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(if suffix<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(aset par=
ameters 6 suffix)<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(setq suffix (or=
(aref parameters 6) "")))<br>
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(let ((index (mod (1+ (car r=
eporter)) 4)))<br>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(let ((index (mod (1+ (car r=
eporter))<br>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(length progress-reporter--pulse-charact=
ers))))<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (setcar reporter index)<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(run-hook-with-a=
rgs 'progress-reporter-update-functions<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0reporter<br>
> diff --git a/lisp/system-taskbar.el b/lisp/system-taskbar.el<br>
> index cc41183fb32..973b426e026 100644<br>
> --- a/lisp/system-taskbar.el<br>
> +++ b/lisp/system-taskbar.el<br>
> @@ -282,7 +282,9 @@ system-taskbar--progress-reporter-update<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 ((pred floatp)<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(system-taskbar--progress state))<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 ((pred integerp)<br>
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0(system-taskbar--progress (/ (1+ state) 4.=
0)))<br>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0;; This won't show 0.0 to indicate wor=
k in process until done.<br>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0(system-taskbar--progress<br>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 (/ (1+ (mod state 5)) 5.0)))<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 ('done<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(system-taskbar--progress nil)))))<br=
>
<br>
AFAICT, `state` here will cycle between 0, 1, 2, 3, 0, 1, ... so the<br>
`mod 5` won't do anything.=C2=A0 And I think we should fix this by not =
doing<br>
the `mod` in `progress-reporter-do-update`.<br></blockquote><div><br></div>=
<div><span style=3D"font-family:monospace">That's only true if the puls=
e characters are never replaced with a string longer or shorter than 4.<spa=
n class=3D"gmail_default" style=3D"font-family:monospace">=C2=A0 I replace =
mine.</span></span></div></div></div>
--000000000000268ca20652d27b7c--
bug-gnu-emacs@HIDDEN:bug#80988; Package emacs.
Full text available.
Received: (at 80988) by debbugs.gnu.org; 27 May 2026 20:23:21 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 27 16:23:20 2026
Received: from localhost ([127.0.0.1]:50124 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1wSKmc-0007Tv-3E
for submit <at> debbugs.gnu.org; Wed, 27 May 2026 16:23:20 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:48061)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <monnier@HIDDEN>)
id 1wSKmX-0007T7-36
for 80988 <at> debbugs.gnu.org; Wed, 27 May 2026 16:23:15 -0400
Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 6D3BA44358B;
Wed, 27 May 2026 16:23:05 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1779913384;
bh=0s5jmEbbk6B9aO+XDVt7aV03xcxvHO8PRGYBUjU50us=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=gnbWXcVIbOI0mTEp34KzoIHuTAuRzZ/GStl9/mnl0kpa6pH1yJvmvPmk3iaWKr1Yc
WieSkzg+id5Fn2Zn/UUv3cRKwpR3KoBP2pSDT9hMIMFHonUDYOVaotUEbL8eNsQGSx
XzYgem1/Ade5RsefxZv6RtjKp7crljuvM45S2dsN1T6C3uprG7845Q0lLraGD2BY46
4bOh+MVbIHhI19RneYf+rGms5QBhLmHTQLT7BKA+BOra8WfRMEonO4zpWljQdT3Van
Si1gOMK4ej1cBlRsahc8GHS3SbNInG1WJCNOmnrwknv7me+ylsh/QtjzRQGEhFOqzV
IKLaM+Q08EyHw==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 174D944357F;
Wed, 27 May 2026 16:23:04 -0400 (EDT)
Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 0663D1201F6;
Wed, 27 May 2026 16:23:04 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: =?windows-1252?Q?St=E9phane?= Marks <shipmints@HIDDEN>
Subject: Re: bug#80988: 31.0.50; Progress report (commit f5f2306fc1d)
In-Reply-To: <CAN+1HboAqmXqWbXNq=BQUjpQGRh==xzZF356C44DSdtbGLU35g@HIDDEN>
Message-ID: <jwvh5nsioyh.fsf-monnier+emacs@HIDDEN>
References: <875x4yl7fm.fsf@HIDDEN>
<CAN+1Hbrs_rFU35hBUaKa-AA7eaYZOmnPBMaw-Di5hDrCsd9uOA@HIDDEN>
<878q9rquo1.fsf@HIDDEN>
<CAN+1HbpJP7aWDioF1GSBHh0Bem8Od1_Ea_qJqoyx0+ptNaDaJg@HIDDEN>
<CAN+1Hbq00c0WZnYuf_hatUweO3-0tGMJge1BQDpzmaQANbF3LA@HIDDEN>
<jwvbje2f5m3.fsf-monnier+emacs@HIDDEN>
<CAN+1HboAqmXqWbXNq=BQUjpQGRh==xzZF356C44DSdtbGLU35g@HIDDEN>
Date: Wed, 27 May 2026 16:23:03 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL 0.189 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 80988
Cc: Augusto Stoffel <arstoffel@HIDDEN>, 80988 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
>> > @@ -7294,7 +7300,8 @@ progress-reporter-do-update
>> > (if suffix
>> > (aset parameters 6 suffix)
>> > (setq suffix (or (aref parameters 6) "")))
>> > - (let ((index (mod (1+ (car reporter)) 4)))
>> > + (let ((index (mod (1+ (car reporter))
>> > + (length progress-reporter-pulse-characters))))
>> > (setcar reporter index)
>> > (run-hook-with-args 'progress-reporter-update-functions
>> > reporter
>>
>> Why do any `mod` operation here at all?
This question remains.
> @@ -7114,8 +7114,9 @@ progress-reporter-update-functions
> STATE can be one of:
> - A float representing the percentage complete in the range 0.0-1.0
> for a numeric reporter.
> -- An integer representing the index which cycles through the range 0-3
> -for a pulsing reporter.
> +- An integer which for a pulsing reporter cycles through the characters
> +in the vector `progress-reporter--pulse-characters'; i.e., the integer
> +modulo the length of the vector.
> - The symbol `done' to indicate that the progress reporter is complete.")
>
> (defsubst progress-reporter-update (reporter &optional value suffix)
I think after we answer the above question, this text may need some tweak.
> @@ -7241,8 +7242,9 @@ progress-reporter-echo-area
> (message "%s" text)))
> ((pred integerp)
> (let ((message-log-max nil)
> - (pulse-char (aref progress-reporter--pulse-characters
> - state)))
> + (pulse-char
> + (aref progress-reporter--pulse-characters
> + (mod state (length progress-reporter--pulse-characters)))))
> (message "%s %s" text pulse-char)))
> ('done
> (message "%sdone" text))))))
> @@ -7294,7 +7296,8 @@ progress-reporter-do-update
> (if suffix
> (aset parameters 6 suffix)
> (setq suffix (or (aref parameters 6) "")))
> - (let ((index (mod (1+ (car reporter)) 4)))
> + (let ((index (mod (1+ (car reporter))
> + (length progress-reporter--pulse-characters))))
> (setcar reporter index)
> (run-hook-with-args 'progress-reporter-update-functions
> reporter
> diff --git a/lisp/system-taskbar.el b/lisp/system-taskbar.el
> index cc41183fb32..973b426e026 100644
> --- a/lisp/system-taskbar.el
> +++ b/lisp/system-taskbar.el
> @@ -282,7 +282,9 @@ system-taskbar--progress-reporter-update
> ((pred floatp)
> (system-taskbar--progress state))
> ((pred integerp)
> - (system-taskbar--progress (/ (1+ state) 4.0)))
> + ;; This won't show 0.0 to indicate work in process until done.
> + (system-taskbar--progress
> + (/ (1+ (mod state 5)) 5.0)))
> ('done
> (system-taskbar--progress nil)))))
AFAICT, `state` here will cycle between 0, 1, 2, 3, 0, 1, ... so the
`mod 5` won't do anything. And I think we should fix this by not doing
the `mod` in `progress-reporter-do-update`.
=== Stefan
bug-gnu-emacs@HIDDEN:bug#80988; Package emacs.
Full text available.
Received: (at 80988) by debbugs.gnu.org; 27 May 2026 20:10:45 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 27 16:10:45 2026
Received: from localhost ([127.0.0.1]:50031 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1wSKaS-0006Ui-V2
for submit <at> debbugs.gnu.org; Wed, 27 May 2026 16:10:45 -0400
Received: from mail-vk1-xa35.google.com ([2607:f8b0:4864:20::a35]:59867)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <shipmints@HIDDEN>)
id 1wSKaP-0006UR-Ta
for 80988 <at> debbugs.gnu.org; Wed, 27 May 2026 16:10:42 -0400
Received: by mail-vk1-xa35.google.com with SMTP id
71dfb90a1353d-57513733658so4136481e0c.3
for <80988 <at> debbugs.gnu.org>; Wed, 27 May 2026 13:10:41 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1779912641; cv=none;
d=google.com; s=arc-20240605;
b=Be0UUL2cEK3CdVfGuhb7R5iTwk+psihbZtju5FpTK2Ah/mrAUZamzvSXr53fSloBdZ
QtUP7p1eRjzDI0jBUeB/kg+oChX2BFF0aG2RTPkDcZLD1ATOZWomlUGL1hS8fkzxHg6x
Lv/TG0tc/E7jXb0onbU7VwvaxoAK5Xi1QQA7bAy9WM7tElXbWM/hbtmIswBD6lVK95sk
G1FvXMIjX0xCYrSE8mohKrb0ffq9SXQxDcByZ6wQPwUHUnegmLES7lewOkrP4cpz+aRH
YIabdsc0ntJcl0x4RKTqSZeUDMwyvLnaBAt4+xA4zJneaCYbv1YHcm6TjaDkDKcerEeH
PjZQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20240605;
h=cc:to:subject:message-id:date:from:in-reply-to:references
:mime-version:dkim-signature;
bh=B863Zl6zlx7cpVZ9yl5Zh9DA/ZbseDRW6sb0dC4qa1M=;
fh=Vr5ApKBz8T9AXH4b/3sniNGiX011XyFOKU4pz2DxBbc=;
b=c7hy0cy79gItjar1waTHE+ncFTKlUaAtBn6Un8KAWlf74PziQhPQcc+AKHIb4EuPA1
4zkXrJl1l+C91EDBvEGtQhM8fbqfKKuKqtUNDqHb/Ku9X5tkjkgTeMLqgAe62lEQH/mY
fOvbCqtfyywPv5Nho0gN2HtG45sMEp1U6fPYF3ymkddI6CNoswja9H5iiY8FFzRKhCOM
uSj9/BHFIBzWxtJrx+H2PzdklnaPMKoYCJBKzU6506yjuNtR9qvwQ9q9bVom0p5SJlqC
+hqoQlopQEFGm/2irxFCvl72nftPdVDwtdRjkBtSeIrGfvhfqOmfVETXZe1PgNIfFnoK
HW9w==; darn=debbugs.gnu.org
ARC-Authentication-Results: i=1; mx.google.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20251104; t=1779912641; x=1780517441; darn=debbugs.gnu.org;
h=cc:to:subject:message-id:date:from:in-reply-to:references
:mime-version:from:to:cc:subject:date:message-id:reply-to;
bh=B863Zl6zlx7cpVZ9yl5Zh9DA/ZbseDRW6sb0dC4qa1M=;
b=rVWLBQNdCa9ftT9PxGx0l/eK3ZDI23K0zwQEJWQHtTeZbN7om11FMP0p36PhnyMMSl
56zS94z9h3lUTXCXEOF7lS27nCPt35dUUeYqxlEFI8uo7+xadFDfHdHHz2PWl9m3fZtM
v2gFlkPYgva76flWW808cT27E2AfulI5DZsB4V+KS0VG83EOLR9qUuELP+Yr7ChMcZMX
he7jucnGu4hzSRpi8nlnqO6KHG3ZIn/c9C6GrtUwk+GUlsrLXxicK5aET11QI+t4iB0e
+JN/toDkpVyvmw4dSMA3ENQWo3f7RW3Ea6s8K8c7qyKqns2H5rwuljrABhEFYdFJunX2
vCEA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20251104; t=1779912641; x=1780517441;
h=cc:to:subject:message-id:date:from:in-reply-to:references
:mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date
:message-id:reply-to;
bh=B863Zl6zlx7cpVZ9yl5Zh9DA/ZbseDRW6sb0dC4qa1M=;
b=flPZxLj9HmosZLVnulap/qWS+HBJE6lSIwLU7gem3cR8YGcEQ+xEiVia5VkYNEgL3I
wQ8Rz4xWX7LMuUXi1XraYi6EY4jDSXKRy+/xgCfYd9MZ+dPmko72PKN0WY8kMUgwhhyd
yCyw6bZSnN3f8cxBqDoNmSsNJ9z34sISe/VTWv9PEuzN+6VhsgIZVASZNSWdYQIQNwNg
7H5mxwVjKzuKw3CIBvKxk7pWT1h4KqVCBr2VKAmYYfZnZBeao/BLK36NnmhiidsviE5R
g98/Skgp9l7aB9HHRvb9ibdc9YSoKSgFzD/JS3o2U+7MUY7UbFg1aBn2KA3pkxFcKWre
VF9Q==
X-Forwarded-Encrypted: i=1;
AFNElJ/93RUkYsaWqTTVHGNG0Nk0y4ZEHKni/EHQjP90vdtfEkNvDq9Rwft3D0R5TTJnpSCpSw71Ig==@debbugs.gnu.org
X-Gm-Message-State: AOJu0YyrDnYzmnRaGOpKBLtllQWrmMiu14S3ZW5qW1CE+AZSz8SSeTTX
d0B7MhS56Cf7O/rh57JGLaxCMDIji9LvrrEGaqmFV4Amr/8gXCrXJHT96NX8mD+Qf0K0NErjopA
LWXiKAlA+XxyjjGJEHpqWMW02V8rRysQ=
X-Gm-Gg: Acq92OE+aCUpSZ3eVOvvdt52/AQfq5Wynw85VLfkTI6TwV24ApwpHdkwoFLJ/b6HYwk
LpJEIJgoAFX0MhDGl3HU/8xSKxAWPUJRMZDJFC7N90d7SZ/OOj+rlb2AkLNxKmnU0U8sP26k6jV
Hp/gBVBXxTFRoUi6+0pLOFakwiD6rjwAmeDRGdjkuLzFpXB8b2rN9DH63FZknHm7TMj0aIraHaX
CsTPfSzjpCfbj0g8ulFd1dNKk9ika0043QVaCRN+F3T4/ytJ2U04eKGu7+AzMM86OYe5jie9XwU
n/zFmIoPVF27x9YMmlr84NrvRulpNZVHsrimcxwqnujO6jgrxHuVrVZBoEuZEdosTxPlBn5kIU0
k+cC2o2Qc9Plg607HMoq3Dpt3G4GP1p2DSOHFrmw+yTrVeCoElE5OGochIzg=
X-Received: by 2002:a05:6122:4f94:b0:575:a6f4:46b4 with SMTP id
71dfb90a1353d-586628c2881mr13914438e0c.9.1779912640795; Wed, 27 May 2026
13:10:40 -0700 (PDT)
MIME-Version: 1.0
References: <875x4yl7fm.fsf@HIDDEN>
<CAN+1Hbrs_rFU35hBUaKa-AA7eaYZOmnPBMaw-Di5hDrCsd9uOA@HIDDEN>
<878q9rquo1.fsf@HIDDEN>
<CAN+1HbpJP7aWDioF1GSBHh0Bem8Od1_Ea_qJqoyx0+ptNaDaJg@HIDDEN>
<CAN+1Hbq00c0WZnYuf_hatUweO3-0tGMJge1BQDpzmaQANbF3LA@HIDDEN>
<jwvbje2f5m3.fsf-monnier+emacs@HIDDEN>
In-Reply-To: <jwvbje2f5m3.fsf-monnier+emacs@HIDDEN>
From: =?UTF-8?Q?St=C3=A9phane_Marks?= <shipmints@HIDDEN>
Date: Wed, 27 May 2026 16:10:28 -0400
X-Gm-Features: AVHnY4JE6-EnZcpFMGN_3dGIMFigECLFJPRhIJsHFJuH8E9TPFexaw8kZjFFXS0
Message-ID: <CAN+1HboAqmXqWbXNq=BQUjpQGRh==xzZF356C44DSdtbGLU35g@HIDDEN>
Subject: Re: bug#80988: 31.0.50; Progress report (commit f5f2306fc1d)
To: Stefan Monnier <monnier@HIDDEN>
Content-Type: multipart/mixed; boundary="000000000000afad960652d23414"
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: 80988
Cc: Augusto Stoffel <arstoffel@HIDDEN>, 80988 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.0 (/)
--000000000000afad960652d23414
Content-Type: multipart/alternative; boundary="000000000000afad950652d23412"
--000000000000afad950652d23412
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
On Tue, May 26, 2026 at 1:29=E2=80=AFPM Stefan Monnier <monnier@HIDDEN=
al.ca>
wrote:
> [ I still don't understand why I'm involved, but well... ]
>
> Here is my review of your patch:
>
> > --- a/etc/NEWS
> > +++ b/etc/NEWS
> > @@ -45,6 +45,15 @@ applies, and please also update docstrings as needed=
.
> >
> > * Lisp Changes in Emacs 32.1
> >
> > +
> > +** Progress reporter
> > +
> > +---
> > +*** Renamed variable 'progress-reporter-pulse-characters'.
> > +The variable 'progress-reporter--pulse-characters' is obsoleted by
> > +'progress-reporter-pulse-characters'. You can replace this with a
> > +vector characters you choose. We recommend at least four characters.
> > +
> > ---
> > ** New variable 'completion-frontend-properties'.
> > This variable generalizes the 'completion-lazy-hilit' variable added i=
n
> > diff --git a/lisp/subr.el b/lisp/subr.el
> > index d97598ab61f..afb4c144050 100644
> > --- a/lisp/subr.el
> > +++ b/lisp/subr.el
> > @@ -7107,6 +7107,13 @@ set-transient-map
> > ;; digits of precision, it doesn't really matter here. On the other
> > ;; hand, it greatly simplifies the code.
> >
> > +(define-obsolete-variable-alias
> > + 'progress-reporter--pulse-characters
> > + 'progress-reporter-pulse-characters "32.1")
> > +
> > +(defvar progress-reporter-pulse-characters ["-" "\\" "|" "/"]
> > + "Characters to use for pulsing progress reporters.")
> > +
> > (defvar progress-reporter-update-functions (list
> #'progress-reporter-echo-area)
> > "Special hook run on progress-reporter updates.
> > Each function is called with two arguments:
>
> I'm reviewing it for `emacs-31` because it's urgent to fix the API, so
> I think we should keep this renaming for `master`.
>
> > @@ -7114,8 +7121,9 @@ progress-reporter-update-functions
> > STATE can be one of:
> > - A float representing the percentage complete in the range 0.0-1.0
> > for a numeric reporter.
> > -- An integer representing the index which cycles through the range 0-3
> > -for a pulsing reporter.
> > +- An integer which for a pulsing reporter cycles through the character=
s
> > +in the vector `progress-reporter-pulse-characters'; i.e., the integer
> > +modulo the length of the vector.
> > - The symbol `done' to indicate that the progress reporter is
> complete.")
> >
> > (defsubst progress-reporter-update (reporter &optional value suffix)
>
> I think this should not refer to `progress-reporter-pulse-characters`
> because it's specific to the echo-area "pulser".
> [ Side note: etc/NEWS uses '...' quoting rather than `...'. ]
>
> > @@ -7241,8 +7246,9 @@ progress-reporter-echo-area
> > (message "%s" text)))
> > ((pred integerp)
> > (let ((message-log-max nil)
> > - (pulse-char (aref progress-reporter--pulse-characters
> > - state)))
> > + (pulse-char
> > + (aref progress-reporter-pulse-characters
> > + (mod state (length
> progress-reporter-pulse-characters)))))
> > (message "%s %s" text pulse-char)))
> > ('done
> > (message "%sdone" text))))))
>
> Looks good (modulo the absence of the var's renaming, of course).
>
> > @@ -7294,7 +7300,8 @@ progress-reporter-do-update
> > (if suffix
> > (aset parameters 6 suffix)
> > (setq suffix (or (aref parameters 6) "")))
> > - (let ((index (mod (1+ (car reporter)) 4)))
> > + (let ((index (mod (1+ (car reporter))
> > + (length
> progress-reporter-pulse-characters))))
> > (setcar reporter index)
> > (run-hook-with-args 'progress-reporter-update-functions
> > reporter
>
> Why do any `mod` operation here at all?
>
> > diff --git a/lisp/system-taskbar.el b/lisp/system-taskbar.el
> > index cc41183fb32..ebf696dd0da 100644
> > --- a/lisp/system-taskbar.el
> > +++ b/lisp/system-taskbar.el
> > @@ -282,7 +282,10 @@ system-taskbar--progress-reporter-update
> > ((pred floatp)
> > (system-taskbar--progress state))
> > ((pred integerp)
> > - (system-taskbar--progress (/ (1+ state) 4.0)))
> > + ;; This won't show 0.0 to indicate work in process until done.
> > + (system-taskbar--progress
> > + (/ (1+ (mod state (length progress-reporter-pulse-characters))=
)
> > + (float (length progress-reporter-pulse-characters)))))
> > ('done
> > (system-taskbar--progress nil)))))
>
> This can keep using 4 (or any other number of steps it likes) instead of
> `(length progress-reporter-pulse-characters)`, no?
>
Yes. Updated patch attached. No NEWS for this one.
--000000000000afad950652d23412
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon=
t-family:monospace"><span style=3D"font-family:Arial,Helvetica,sans-serif">=
On Tue, May 26, 2026 at 1:29=E2=80=AFPM Stefan Monnier <<a href=3D"mailt=
o:monnier@HIDDEN">monnier@HIDDEN</a>> wrote:</span><=
/div></div><div class=3D"gmail_quote gmail_quote_container"><blockquote cla=
ss=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid =
rgb(204,204,204);padding-left:1ex">[ I still don't understand why I'=
;m involved, but well... ]<br>
<br>
Here is my review of your patch:<br>
<br>
> --- a/etc/NEWS<br>
> +++ b/etc/NEWS<br>
> @@ -45,6 +45,15 @@ applies, and please also update docstrings as neede=
d.<br>
>=C2=A0 <br>
>=C2=A0 * Lisp Changes in Emacs 32.1<br>
>=C2=A0 <br>
> +<br>
> +** Progress reporter<br>
> +<br>
> +---<br>
> +*** Renamed variable 'progress-reporter-pulse-characters'.<br=
>
> +The variable 'progress-reporter--pulse-characters' is obsolet=
ed by<br>
> +'progress-reporter-pulse-characters'.=C2=A0 You can replace t=
his with a<br>
> +vector characters you choose.=C2=A0 We recommend at least four charac=
ters.<br>
> +<br>
>=C2=A0 ---<br>
>=C2=A0 ** New variable 'completion-frontend-properties'.<br>
>=C2=A0 This variable generalizes the 'completion-lazy-hilit' va=
riable added in<br>
> diff --git a/lisp/subr.el b/lisp/subr.el<br>
> index d97598ab61f..afb4c144050 100644<br>
> --- a/lisp/subr.el<br>
> +++ b/lisp/subr.el<br>
> @@ -7107,6 +7107,13 @@ set-transient-map<br>
>=C2=A0 ;; digits of precision, it doesn't really matter here.=C2=A0=
On the other<br>
>=C2=A0 ;; hand, it greatly simplifies the code.<br>
>=C2=A0 <br>
> +(define-obsolete-variable-alias<br>
> +=C2=A0 'progress-reporter--pulse-characters<br>
> +=C2=A0 'progress-reporter-pulse-characters "32.1")<br>
> +<br>
> +(defvar progress-reporter-pulse-characters ["-" "\\&qu=
ot; "|" "/"]<br>
> +=C2=A0 "Characters to use for pulsing progress reporters.")=
<br>
> +<br>
>=C2=A0 (defvar progress-reporter-update-functions (list #'progress-=
reporter-echo-area)<br>
>=C2=A0 =C2=A0 "Special hook run on progress-reporter updates.<br>
>=C2=A0 Each function is called with two arguments:<br>
<br>
I'm reviewing it for `emacs-31` because it's urgent to fix the API,=
so<br>
I think we should keep this renaming for `master`.<br>
<br>
> @@ -7114,8 +7121,9 @@ progress-reporter-update-functions<br>
>=C2=A0 STATE can be one of:<br>
>=C2=A0 - A float representing the percentage complete in the range 0.0-=
1.0<br>
>=C2=A0 for a numeric reporter.<br>
> -- An integer representing the index which cycles through the range 0-=
3<br>
> -for a pulsing reporter.<br>
> +- An integer which for a pulsing reporter cycles through the characte=
rs<br>
> +in the vector `progress-reporter-pulse-characters'; i.e., the int=
eger<br>
> +modulo the length of the vector.<br>
>=C2=A0 - The symbol `done' to indicate that the progress reporter i=
s complete.")<br>
>=C2=A0 <br>
>=C2=A0 (defsubst progress-reporter-update (reporter &optional value=
suffix)<br>
<br>
I think this should not refer to `progress-reporter-pulse-characters`<br>
because it's specific to the echo-area "pulser".<br>
[ Side note: etc/NEWS uses '...' quoting rather than `...'.=C2=
=A0 ]<br>
<br>
> @@ -7241,8 +7246,9 @@ progress-reporter-echo-area<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(message "%s"=
text)))<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ((pred integerp)<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(let ((message-log-max nil)<br=
>
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(pulse-char (a=
ref progress-reporter--pulse-characters<br>
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0state)))<br>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(pulse-char<br=
>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (aref progres=
s-reporter-pulse-characters<br>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
=C2=A0 (mod state (length progress-reporter-pulse-characters)))))<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(message "%s %s&qu=
ot; text pulse-char)))<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ('done<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(message "%sdone" te=
xt))))))<br>
<br>
Looks good (modulo the absence of the var's renaming, of course).<br>
<br>
> @@ -7294,7 +7300,8 @@ progress-reporter-do-update<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(if suffix<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(aset par=
ameters 6 suffix)<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(setq suffix (or=
(aref parameters 6) "")))<br>
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(let ((index (mod (1+ (car r=
eporter)) 4)))<br>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(let ((index (mod (1+ (car r=
eporter))<br>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(length progress-reporter-pulse-characte=
rs))))<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (setcar reporter index)<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(run-hook-with-a=
rgs 'progress-reporter-update-functions<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0reporter<br>
<br>
Why do any `mod` operation here at all?<br>
<br>
> diff --git a/lisp/system-taskbar.el b/lisp/system-taskbar.el<br>
> index cc41183fb32..ebf696dd0da 100644<br>
> --- a/lisp/system-taskbar.el<br>
> +++ b/lisp/system-taskbar.el<br>
> @@ -282,7 +282,10 @@ system-taskbar--progress-reporter-update<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 ((pred floatp)<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(system-taskbar--progress state))<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 ((pred integerp)<br>
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0(system-taskbar--progress (/ (1+ state) 4.=
0)))<br>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0;; This won't show 0.0 to indicate wor=
k in process until done.<br>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0(system-taskbar--progress<br>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 (/ (1+ (mod state (length progress-report=
er-pulse-characters)))<br>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(float (length progress-repo=
rter-pulse-characters)))))<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 ('done<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(system-taskbar--progress nil)))))<br=
>
<br>
This can keep using 4 (or any other number of steps it likes) instead of<br=
>
`(length progress-reporter-pulse-characters)`, no?<br></blockquote><div><br=
></div><div class=3D"gmail_default" style=3D"font-family:monospace">Yes.=C2=
=A0 Updated patch attached.=C2=A0 No NEWS for this one.</div></div></div>
--000000000000afad950652d23412--
--000000000000afad960652d23414
Content-Type: application/octet-stream;
name="0001-Improve-pulsing-progress-reporter-to-remove-hard-cod.patch"
Content-Disposition: attachment;
filename="0001-Improve-pulsing-progress-reporter-to-remove-hard-cod.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mpoi0kyv0>
X-Attachment-Id: f_mpoi0kyv0
RnJvbSA0NmFiMWY5NmNkMDdjZTg3M2U4MWZlNzhkOWFjNGJhMzFiMzcxMjY1IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/U3Q9QzM9QTlwaGFuZT0yME1hcmtzPz0gPHNo
aXBtaW50c0BnbWFpbC5jb20+CkRhdGU6IFdlZCwgMjcgTWF5IDIwMjYgMTY6MDU6MjMgLTA0MDAK
U3ViamVjdDogW1BBVENIXSBJbXByb3ZlIHB1bHNpbmcgcHJvZ3Jlc3MtcmVwb3J0ZXIgdG8gcmVt
b3ZlIGhhcmQgY29kZWQgbGVuZ3RoCiAoYnVnIzgwOTg4KQoKKiBsaXNwL3N1YnIuZWwgKHByb2dy
ZXNzLXJlcG9ydGVyLXVwZGF0ZS1mdW5jdGlvbnMpOiBVcGRhdGUKZG9jc3RyaW5nLgoocHJvZ3Jl
c3MtcmVwb3J0ZXItZWNoby1hcmVhLCBwcm9ncmVzcy1yZXBvcnRlci1kby11cGRhdGUpOiBVc2UK
J3Byb2dyZXNzLXJlcG9ydGVyLS1wdWxzZS1jaGFyYWN0ZXJzJyBsZW5ndGguCioKbGlzcC9zeXN0
ZW0tdGFza2Jhci5lbCAoc3lzdGVtLXRhc2tiYXItLXByb2dyZXNzLXJlcG9ydGVyLXVwZGF0ZSk6
Ck1ha2Ugc3RlcHMgaW5kZXBlbmRlbnQgb2YgJ3Byb2dyZXNzLXJlcG9ydGVyLS1wdWxzZS1jaGFy
YWN0ZXJzJwpsZW5ndGguCi0tLQogbGlzcC9zdWJyLmVsICAgICAgICAgICB8IDEzICsrKysrKysr
LS0tLS0KIGxpc3Avc3lzdGVtLXRhc2tiYXIuZWwgfCAgNCArKystCiAyIGZpbGVzIGNoYW5nZWQs
IDExIGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9zdWJy
LmVsIGIvbGlzcC9zdWJyLmVsCmluZGV4IGQ5NzU5OGFiNjFmLi4zNTllYzQ0MDJiOSAxMDA2NDQK
LS0tIGEvbGlzcC9zdWJyLmVsCisrKyBiL2xpc3Avc3Vici5lbApAQCAtNzExNCw4ICs3MTE0LDkg
QEAgcHJvZ3Jlc3MtcmVwb3J0ZXItdXBkYXRlLWZ1bmN0aW9ucwogU1RBVEUgY2FuIGJlIG9uZSBv
ZjoKIC0gQSBmbG9hdCByZXByZXNlbnRpbmcgdGhlIHBlcmNlbnRhZ2UgY29tcGxldGUgaW4gdGhl
IHJhbmdlIDAuMC0xLjAKIGZvciBhIG51bWVyaWMgcmVwb3J0ZXIuCi0tIEFuIGludGVnZXIgcmVw
cmVzZW50aW5nIHRoZSBpbmRleCB3aGljaCBjeWNsZXMgdGhyb3VnaCB0aGUgcmFuZ2UgMC0zCi1m
b3IgYSBwdWxzaW5nIHJlcG9ydGVyLgorLSBBbiBpbnRlZ2VyIHdoaWNoIGZvciBhIHB1bHNpbmcg
cmVwb3J0ZXIgY3ljbGVzIHRocm91Z2ggdGhlIGNoYXJhY3RlcnMKK2luIHRoZSB2ZWN0b3IgYHBy
b2dyZXNzLXJlcG9ydGVyLS1wdWxzZS1jaGFyYWN0ZXJzJzsgaS5lLiwgdGhlIGludGVnZXIKK21v
ZHVsbyB0aGUgbGVuZ3RoIG9mIHRoZSB2ZWN0b3IuCiAtIFRoZSBzeW1ib2wgYGRvbmUnIHRvIGlu
ZGljYXRlIHRoYXQgdGhlIHByb2dyZXNzIHJlcG9ydGVyIGlzIGNvbXBsZXRlLiIpCiAKIChkZWZz
dWJzdCBwcm9ncmVzcy1yZXBvcnRlci11cGRhdGUgKHJlcG9ydGVyICZvcHRpb25hbCB2YWx1ZSBz
dWZmaXgpCkBAIC03MjQxLDggKzcyNDIsOSBAQCBwcm9ncmVzcy1yZXBvcnRlci1lY2hvLWFyZWEK
ICAgICAgICAgICAgKG1lc3NhZ2UgIiVzIiB0ZXh0KSkpCiAgICAgICAgICgocHJlZCBpbnRlZ2Vy
cCkKICAgICAgICAgIChsZXQgKChtZXNzYWdlLWxvZy1tYXggbmlsKQotICAgICAgICAgICAgICAg
KHB1bHNlLWNoYXIgKGFyZWYgcHJvZ3Jlc3MtcmVwb3J0ZXItLXB1bHNlLWNoYXJhY3RlcnMKLSAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0YXRlKSkpCisgICAgICAgICAgICAgICAo
cHVsc2UtY2hhcgorICAgICAgICAgICAgICAgIChhcmVmIHByb2dyZXNzLXJlcG9ydGVyLS1wdWxz
ZS1jaGFyYWN0ZXJzCisgICAgICAgICAgICAgICAgICAgICAgKG1vZCBzdGF0ZSAobGVuZ3RoIHBy
b2dyZXNzLXJlcG9ydGVyLS1wdWxzZS1jaGFyYWN0ZXJzKSkpKSkKICAgICAgICAgICAgKG1lc3Nh
Z2UgIiVzICVzIiB0ZXh0IHB1bHNlLWNoYXIpKSkKICAgICAgICAgKCdkb25lCiAgICAgICAgICAo
bWVzc2FnZSAiJXNkb25lIiB0ZXh0KSkpKSkpCkBAIC03Mjk0LDcgKzcyOTYsOCBAQCBwcm9ncmVz
cy1yZXBvcnRlci1kby11cGRhdGUKICAgICAgICAgICAgKGlmIHN1ZmZpeAogICAgICAgICAgICAg
ICAgKGFzZXQgcGFyYW1ldGVycyA2IHN1ZmZpeCkKICAgICAgICAgICAgICAoc2V0cSBzdWZmaXgg
KG9yIChhcmVmIHBhcmFtZXRlcnMgNikgIiIpKSkKLSAgICAgICAgICAgKGxldCAoKGluZGV4ICht
b2QgKDErIChjYXIgcmVwb3J0ZXIpKSA0KSkpCisgICAgICAgICAgIChsZXQgKChpbmRleCAobW9k
ICgxKyAoY2FyIHJlcG9ydGVyKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGxlbmd0
aCBwcm9ncmVzcy1yZXBvcnRlci0tcHVsc2UtY2hhcmFjdGVycykpKSkKIAkgICAgIChzZXRjYXIg
cmVwb3J0ZXIgaW5kZXgpCiAgICAgICAgICAgICAgKHJ1bi1ob29rLXdpdGgtYXJncyAncHJvZ3Jl
c3MtcmVwb3J0ZXItdXBkYXRlLWZ1bmN0aW9ucwogICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgcmVwb3J0ZXIKZGlmZiAtLWdpdCBhL2xpc3Avc3lzdGVtLXRhc2tiYXIuZWwgYi9saXNw
L3N5c3RlbS10YXNrYmFyLmVsCmluZGV4IGNjNDExODNmYjMyLi45NzNiNDI2ZTAyNiAxMDA2NDQK
LS0tIGEvbGlzcC9zeXN0ZW0tdGFza2Jhci5lbAorKysgYi9saXNwL3N5c3RlbS10YXNrYmFyLmVs
CkBAIC0yODIsNyArMjgyLDkgQEAgc3lzdGVtLXRhc2tiYXItLXByb2dyZXNzLXJlcG9ydGVyLXVw
ZGF0ZQogICAgICAgKChwcmVkIGZsb2F0cCkKICAgICAgICAoc3lzdGVtLXRhc2tiYXItLXByb2dy
ZXNzIHN0YXRlKSkKICAgICAgICgocHJlZCBpbnRlZ2VycCkKLSAgICAgICAoc3lzdGVtLXRhc2ti
YXItLXByb2dyZXNzICgvICgxKyBzdGF0ZSkgNC4wKSkpCisgICAgICAgOzsgVGhpcyB3b24ndCBz
aG93IDAuMCB0byBpbmRpY2F0ZSB3b3JrIGluIHByb2Nlc3MgdW50aWwgZG9uZS4KKyAgICAgICAo
c3lzdGVtLXRhc2tiYXItLXByb2dyZXNzCisgICAgICAgICgvICgxKyAobW9kIHN0YXRlIDUpKSA1
LjApKSkKICAgICAgICgnZG9uZQogICAgICAgIChzeXN0ZW0tdGFza2Jhci0tcHJvZ3Jlc3Mgbmls
KSkpKSkKIAotLSAKMi41NC4wCgo=
--000000000000afad960652d23414--
bug-gnu-emacs@HIDDEN:bug#80988; Package emacs.
Full text available.
Received: (at 80988) by debbugs.gnu.org; 26 May 2026 17:29:26 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 26 13:29:26 2026
Received: from localhost ([127.0.0.1]:35154 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1wRvan-0006T0-Ed
for submit <at> debbugs.gnu.org; Tue, 26 May 2026 13:29:25 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:54812)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <monnier@HIDDEN>)
id 1wRval-0006Sb-Bh
for 80988 <at> debbugs.gnu.org; Tue, 26 May 2026 13:29:24 -0400
Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E7CC944348F;
Tue, 26 May 2026 13:29:16 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1779816555;
bh=BvE66PUz8L3w10sU1k9SVrZo7wJWtzJ639WuaPoLDLs=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=e0LdZPIXy3WJbUHukpcSNf4NoCSu71bK0S3HkBc/qwNNSBD0HxtdhzT3n8Jrk2udw
5tOhO16YgdMamiYRC/Q+fTLNd1TXwejgkbT5fHVT7cpFnDxg4+X+X4HHw+19bAmrhi
E0nIToxT2oSlnPcTVxeVTWiPblFVkJFBlEDifrMwsd5v6W5uBYrgWe7Pq49cTfhIVf
Awdhhq5dnK0ORQgIGdqfOyJHMeFSnfumwxq/YsqECnaVGmMsw62oxlGLhkdxcA74qN
le8jRr8K+e1TyG+mvTEpG5Ir/MXl2kt5FStJ8tbYeE+fJAcmXp1arNzwK9qKRHunro
DJCyOyAoug8Kg==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 66C03443486;
Tue, 26 May 2026 13:29:15 -0400 (EDT)
Received: from pastel (104-195-197-162.cpe.teksavvy.com [104.195.197.162])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 341A0120495;
Tue, 26 May 2026 13:29:15 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: =?windows-1252?Q?St=E9phane?= Marks <shipmints@HIDDEN>
Subject: Re: bug#80988: 31.0.50; Progress report (commit f5f2306fc1d)
In-Reply-To: <CAN+1Hbq00c0WZnYuf_hatUweO3-0tGMJge1BQDpzmaQANbF3LA@HIDDEN>
Message-ID: <jwvbje2f5m3.fsf-monnier+emacs@HIDDEN>
References: <875x4yl7fm.fsf@HIDDEN>
<CAN+1Hbrs_rFU35hBUaKa-AA7eaYZOmnPBMaw-Di5hDrCsd9uOA@HIDDEN>
<878q9rquo1.fsf@HIDDEN>
<CAN+1HbpJP7aWDioF1GSBHh0Bem8Od1_Ea_qJqoyx0+ptNaDaJg@HIDDEN>
<CAN+1Hbq00c0WZnYuf_hatUweO3-0tGMJge1BQDpzmaQANbF3LA@HIDDEN>
Date: Tue, 26 May 2026 13:29:14 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL 0.067 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 80988
Cc: Augusto Stoffel <arstoffel@HIDDEN>, 80988 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
[ I still don't understand why I'm involved, but well... ]
Here is my review of your patch:
> --- a/etc/NEWS
> +++ b/etc/NEWS
> @@ -45,6 +45,15 @@ applies, and please also update docstrings as needed.
>
> * Lisp Changes in Emacs 32.1
>
> +
> +** Progress reporter
> +
> +---
> +*** Renamed variable 'progress-reporter-pulse-characters'.
> +The variable 'progress-reporter--pulse-characters' is obsoleted by
> +'progress-reporter-pulse-characters'. You can replace this with a
> +vector characters you choose. We recommend at least four characters.
> +
> ---
> ** New variable 'completion-frontend-properties'.
> This variable generalizes the 'completion-lazy-hilit' variable added in
> diff --git a/lisp/subr.el b/lisp/subr.el
> index d97598ab61f..afb4c144050 100644
> --- a/lisp/subr.el
> +++ b/lisp/subr.el
> @@ -7107,6 +7107,13 @@ set-transient-map
> ;; digits of precision, it doesn't really matter here. On the other
> ;; hand, it greatly simplifies the code.
>
> +(define-obsolete-variable-alias
> + 'progress-reporter--pulse-characters
> + 'progress-reporter-pulse-characters "32.1")
> +
> +(defvar progress-reporter-pulse-characters ["-" "\\" "|" "/"]
> + "Characters to use for pulsing progress reporters.")
> +
> (defvar progress-reporter-update-functions (list #'progress-reporter-echo-area)
> "Special hook run on progress-reporter updates.
> Each function is called with two arguments:
I'm reviewing it for `emacs-31` because it's urgent to fix the API, so
I think we should keep this renaming for `master`.
> @@ -7114,8 +7121,9 @@ progress-reporter-update-functions
> STATE can be one of:
> - A float representing the percentage complete in the range 0.0-1.0
> for a numeric reporter.
> -- An integer representing the index which cycles through the range 0-3
> -for a pulsing reporter.
> +- An integer which for a pulsing reporter cycles through the characters
> +in the vector `progress-reporter-pulse-characters'; i.e., the integer
> +modulo the length of the vector.
> - The symbol `done' to indicate that the progress reporter is complete.")
>
> (defsubst progress-reporter-update (reporter &optional value suffix)
I think this should not refer to `progress-reporter-pulse-characters`
because it's specific to the echo-area "pulser".
[ Side note: etc/NEWS uses '...' quoting rather than `...'. ]
> @@ -7241,8 +7246,9 @@ progress-reporter-echo-area
> (message "%s" text)))
> ((pred integerp)
> (let ((message-log-max nil)
> - (pulse-char (aref progress-reporter--pulse-characters
> - state)))
> + (pulse-char
> + (aref progress-reporter-pulse-characters
> + (mod state (length progress-reporter-pulse-characters)))))
> (message "%s %s" text pulse-char)))
> ('done
> (message "%sdone" text))))))
Looks good (modulo the absence of the var's renaming, of course).
> @@ -7294,7 +7300,8 @@ progress-reporter-do-update
> (if suffix
> (aset parameters 6 suffix)
> (setq suffix (or (aref parameters 6) "")))
> - (let ((index (mod (1+ (car reporter)) 4)))
> + (let ((index (mod (1+ (car reporter))
> + (length progress-reporter-pulse-characters))))
> (setcar reporter index)
> (run-hook-with-args 'progress-reporter-update-functions
> reporter
Why do any `mod` operation here at all?
> diff --git a/lisp/system-taskbar.el b/lisp/system-taskbar.el
> index cc41183fb32..ebf696dd0da 100644
> --- a/lisp/system-taskbar.el
> +++ b/lisp/system-taskbar.el
> @@ -282,7 +282,10 @@ system-taskbar--progress-reporter-update
> ((pred floatp)
> (system-taskbar--progress state))
> ((pred integerp)
> - (system-taskbar--progress (/ (1+ state) 4.0)))
> + ;; This won't show 0.0 to indicate work in process until done.
> + (system-taskbar--progress
> + (/ (1+ (mod state (length progress-reporter-pulse-characters)))
> + (float (length progress-reporter-pulse-characters)))))
> ('done
> (system-taskbar--progress nil)))))
This can keep using 4 (or any other number of steps it likes) instead of
`(length progress-reporter-pulse-characters)`, no?
=== Stefan
bug-gnu-emacs@HIDDEN:bug#80988; Package emacs.
Full text available.Received: (at 80988) by debbugs.gnu.org; 26 May 2026 16:12:39 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 26 12:12:39 2026 Received: from localhost ([127.0.0.1]:34615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1wRuOU-00025i-MU for submit <at> debbugs.gnu.org; Tue, 26 May 2026 12:12:39 -0400 Received: from mail-ua1-x934.google.com ([2607:f8b0:4864:20::934]:42426) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <shipmints@HIDDEN>) id 1wRuOQ-00025Y-U0 for 80988 <at> debbugs.gnu.org; Tue, 26 May 2026 12:12:37 -0400 Received: by mail-ua1-x934.google.com with SMTP id a1e0cc1a2514c-95d18b33f93so6782230241.1 for <80988 <at> debbugs.gnu.org>; Tue, 26 May 2026 09:12:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1779811954; cv=none; d=google.com; s=arc-20240605; b=ItA8oSFrUpZngwM6DD+TlKz5hRXe31ZPM9StmjoVC8oBxW1ffyXeiJEjcam2Lvd2KN MOi30mMEQrQR83iMV/CHDV8R/QQlOiHvJg77wfrpfS68Xh7v4XsmpGZz+qvCevAmirqw NfOtPsjDluI3279oCyPtOG74OKKbCFm0mkWxuuiFMCpdpeLLt1aVoGZweuPw+vV+SItQ 1xqmaRFEOe5pPTolPJ2BTw4Vo05b18fQ26qckbdnxoJ3/PEfx5aYk/YLMScCd4SuwKgB on1zhwu/s8WjZZ90k9uritm7McWAGZJ/pLMdfz0McojBIAa/jLfC/8Yvz8M5/cK5Vqom Ptew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=nfPi0DaioX5FOqISOFL+dF6D71pVwQV6OCc2ZFDc9pY=; fh=+iaRvHz5uoIGQkrMZhntEJ0cEIF9oXaCpnuIr7XPZqY=; b=T+XcFqvtsvE5YwQF5eXvAEvePAH2pjHAcmL3+KVZwb35DLVLhSE3FAkmfgyIQFB2O+ ZarLebazoJkxsv0V3HCFVaD4hcnhyogOApJv0WOt689xrcAQv7tnw6bjrssokCdw3v/P xFZ4vYKuC2TEdzEkAkAB2jTojF88m5UeYDatJsNjVMdj9caETY4VE0AaR0OI9RYDWWef xBaWbUAtDS3DeRX/39JYqho7tB4JejvwM/oMtr2EXGLhtCfDXPp1ug2U1eRzseTeqBC9 loWIYqoW/+Hcclr7z34ZrTjuOrlLO+eVibTULDjf8qwgGo0b9WXV3GnIm0vobPvOBfVV AFHQ==; darn=debbugs.gnu.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779811954; x=1780416754; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=nfPi0DaioX5FOqISOFL+dF6D71pVwQV6OCc2ZFDc9pY=; b=lm7vkHMzcgmsjnZnWbNt7SVvP4yMoEpaLSglNtf9CXoYS5tU8hPRs0t4T/xBJQqYWa 5BYv/rvkMYvNIHz+1DQNFedx6RDha1W4uDmNiSo63vtSLKVD6KIL+QoE71Lz6NzWYixq Fadg+Vdo2/igvS1X78JM1NWzlb5JcANQf0rq8r3GjISSHniHrdNdtDt1lmVxM5OE2Lwi HbbMVmuxhmrXHz+rOJqz4INEtxKAaXzWWoTvtxiSbco7XhUsKpYJgI28asagbFlvpAqf C8exoqeFC0+/7O7eH7rRMV6cRabMp0dJm4n4pK4jOs4JKowwYN1Ri68W9d/amXepZboa liog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779811954; x=1780416754; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nfPi0DaioX5FOqISOFL+dF6D71pVwQV6OCc2ZFDc9pY=; b=A7nAwnnJpXwASdLjVdopwQev3fLn/akCHvFTH0/lINh8hwTsId2PToxRLOL8JL9lyw OzAKUuVaWGoFlxMFSYXFC8UB1K5EeBZyTzoA1Xzg+b302GKuGR7+x/ppVdf3x552lnF8 xvxf0+aBCHiuNgypQHBUqPvhL/6iVyjWgQfs9OIC3wOkMSFd+VjeUnqIR09podDcz4Og SS4CrNS8zyvnjieHqzNFrLzcmFwAEIzIsRS3gHcIa35leBGG1QcxEhuZlHqVxubekz7Q OaKc9CK+Yxs1aTCFuMog5yfurmuOzpX3NfdGLdCSInUhxbkpHInZj0Fsv2oDhHtD+5Er tqcg== X-Forwarded-Encrypted: i=1; AFNElJ8cAsYDBAJRsb1NXKoqCUx+bmLhpoyvmn0ChOwYtt8iai8nDTgVCFCG5a7449OuOCT0vyGfNg==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yw2ollrKzmZ3n1BfQJAsBgOT15uY9WHmI51ZPPMJ4G4u1ivQFya MVOeNnxhybvUX8yJH1X8SNp10SCS7bSCCj4wFkfQQhnSj5rm8ROvlCqLrvpyLiUuiZfpc+p/YxP eJVB07hqoPR+s4uOJ1A7xx3LoyWe9CSE= X-Gm-Gg: Acq92OGxU/TQ8QT1sGk2xT6gmohStGL42xyDyH2iLzhQ2Hn8Y/ZK+saxGFz/NmethIB KwxqVWxJR+CddVm+/VHaFr2t/8ho0juzSxc8jH5PgBe2gppcPK+LwG+ELfAT2zZAggN8OgYDErQ aZ6pH2wUaHepyaIEeQjNsxfkTy0FrldIDGPLmyAkA+7E+ehhjEtBrGbs5U5d4+CYIt2G9z0tM/Y RSPTjqXSH4kAwUzfelOggnOGyeSXkKR7aqIEKcex1uzFeuJfnSDXsXvswbk3lDYCHZsNv0Fkru6 phWvNVXBxuZ59ZxngRoh8den6PBB0P5ePbt0q8vljj/iwEFcyGQmhDcU0k0Pq4kIBrzNLIZ82u9 iqgr0V50uvQtv858V5xnlNMwyy8k0EJhGQl+gSz+WDPnzGq15 X-Received: by 2002:a05:6102:809f:b0:632:5db8:f672 with SMTP id ada2fe7eead31-67c8547c420mr4932540137.6.1779811954128; Tue, 26 May 2026 09:12:34 -0700 (PDT) MIME-Version: 1.0 References: <875x4yl7fm.fsf@HIDDEN> <CAN+1Hbrs_rFU35hBUaKa-AA7eaYZOmnPBMaw-Di5hDrCsd9uOA@HIDDEN> <878q9rquo1.fsf@HIDDEN> <CAN+1HbpJP7aWDioF1GSBHh0Bem8Od1_Ea_qJqoyx0+ptNaDaJg@HIDDEN> <CAN+1Hbq00c0WZnYuf_hatUweO3-0tGMJge1BQDpzmaQANbF3LA@HIDDEN> <875x4a8cay.fsf@HIDDEN> <CAN+1HbogopTOR0Zs1hxgDvFd4=SLeJ3OLDULY0i3XjPFxhvq8Q@HIDDEN> <jwvv7caf9bm.fsf-monnier+emacs@HIDDEN> In-Reply-To: <jwvv7caf9bm.fsf-monnier+emacs@HIDDEN> From: =?UTF-8?Q?St=C3=A9phane_Marks?= <shipmints@HIDDEN> Date: Tue, 26 May 2026 12:12:22 -0400 X-Gm-Features: AVHnY4JQyuEEvaZSGMNeai89afNTwJCB2WDbX6IVpJLS2wfu2xkS1yqtVlBIk1g Message-ID: <CAN+1HboDCtwaf5Nm49-nkhsgF0FJGN_PaeTBLeEV=W6iE5pmwA@HIDDEN> Subject: Re: bug#80988: 31.0.50; Progress report (commit f5f2306fc1d) To: Stefan Monnier <monnier@HIDDEN> Content-Type: multipart/alternative; boundary="0000000000004aff3c0652bac3ee" X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 80988 Cc: Augusto Stoffel <arstoffel@HIDDEN>, 80988 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.0 (/) --0000000000004aff3c0652bac3ee Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, May 26, 2026 at 12:03=E2=80=AFPM Stefan Monnier <monnier@HIDDEN= eal.ca> wrote: > >> not sure what your plan is regarding this patch. It seems to me eithe= r > >> we get rid of the magic number 4 in Emacs 31 or else it becomes the > >> official API forever. Either way there's not much time to decide. > >> (Renaming progress-reporter-pulse-characters OTOH is not a priority.) > > At this point, it's up to Stefan, I think. > > I have no idea why my opinion would be relevant here. > But to me the hardcoded 4 is a plain bug. > What I meant was up to you to evaluate the submitted patch and comment on it for revision, or install it. --0000000000004aff3c0652bac3ee Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon= t-family:monospace"><span style=3D"font-family:Arial,Helvetica,sans-serif">= On Tue, May 26, 2026 at 12:03=E2=80=AFPM Stefan Monnier <<a href=3D"mail= to:monnier@HIDDEN">monnier@HIDDEN</a>> wrote:</span>= </div></div><div class=3D"gmail_quote gmail_quote_container"><blockquote cl= ass=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid= rgb(204,204,204);padding-left:1ex">>> not sure what your plan is reg= arding this patch.=C2=A0 It seems to me either<br> >> we get rid of the magic number 4 in Emacs 31 or else it becomes th= e<br> >> official API forever.=C2=A0 Either way there's not much time t= o decide.<br> >> (Renaming progress-reporter-pulse-characters OTOH is not a priorit= y.)<br> > At this point, it's up to Stefan, I think.<br> <br> I have no idea why my opinion would be relevant here.<br> But to me the hardcoded 4 is a plain bug.<br></blockquote><div><br></div><d= iv class=3D"gmail_default" style=3D"font-family:monospace">What I meant was= up to you to evaluate the submitted patch and comment on it for revision, = or install it.</div></div></div> --0000000000004aff3c0652bac3ee--
bug-gnu-emacs@HIDDEN:bug#80988; Package emacs.
Full text available.Received: (at 80988) by debbugs.gnu.org; 26 May 2026 16:03:28 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 26 12:03:28 2026 Received: from localhost ([127.0.0.1]:34558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1wRuFb-0001Yr-TS for submit <at> debbugs.gnu.org; Tue, 26 May 2026 12:03:28 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:20743) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <monnier@HIDDEN>) id 1wRuFW-0001YN-41 for 80988 <at> debbugs.gnu.org; Tue, 26 May 2026 12:03:25 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 0ED1381BB1; Tue, 26 May 2026 12:03:16 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1779811395; bh=uzsmUAyuVDdDzi1dCxMhyVtAYhS3qu31ImEOKmoUFLM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=FbGNDaPc9Q4ZZIyvOKnrOsK1/pLTLx4ODHTljg57svQkpcVsKZool5mE2514geZ7s EaxfdzxuAM/ZsuCl1TO+gni/h2P4qOuGX1q/GI+NlTDGf51qHsHHi2NCy2APME6/qs 3CuLnnzlZm94nKdgzusXdEcGPMQGkmvUiAuNJoq10ffnWEklAlW3Xye4ezQBXDdpM4 s75FmE659bOJ+UxF0RJ1PcDA7nzw2wb1VedxKR/H5c34SX1ANJ9n1fNzwQXJkAKM1K tIoM1KM2pBLLi4xo8iQXrPkT2sEiqD+a51R7eNVLSGMMWEUgBxIXGLx85JNQlVQI8R sPRIlE4PCZxxg== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 31F6B806BF; Tue, 26 May 2026 12:03:15 -0400 (EDT) Received: from pastel (104-195-197-162.cpe.teksavvy.com [104.195.197.162]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 013B51204F1; Tue, 26 May 2026 12:03:14 -0400 (EDT) From: Stefan Monnier <monnier@HIDDEN> To: =?windows-1252?Q?St=E9phane?= Marks <shipmints@HIDDEN> Subject: Re: bug#80988: 31.0.50; Progress report (commit f5f2306fc1d) In-Reply-To: <CAN+1HbogopTOR0Zs1hxgDvFd4=SLeJ3OLDULY0i3XjPFxhvq8Q@HIDDEN> Message-ID: <jwvv7caf9bm.fsf-monnier+emacs@HIDDEN> References: <875x4yl7fm.fsf@HIDDEN> <CAN+1Hbrs_rFU35hBUaKa-AA7eaYZOmnPBMaw-Di5hDrCsd9uOA@HIDDEN> <878q9rquo1.fsf@HIDDEN> <CAN+1HbpJP7aWDioF1GSBHh0Bem8Od1_Ea_qJqoyx0+ptNaDaJg@HIDDEN> <CAN+1Hbq00c0WZnYuf_hatUweO3-0tGMJge1BQDpzmaQANbF3LA@HIDDEN> <875x4a8cay.fsf@HIDDEN> <CAN+1HbogopTOR0Zs1hxgDvFd4=SLeJ3OLDULY0i3XjPFxhvq8Q@HIDDEN> Date: Tue, 26 May 2026 12:03:07 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.092 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 80988 Cc: Augusto Stoffel <arstoffel@HIDDEN>, 80988 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) >> not sure what your plan is regarding this patch. It seems to me either >> we get rid of the magic number 4 in Emacs 31 or else it becomes the >> official API forever. Either way there's not much time to decide. >> (Renaming progress-reporter-pulse-characters OTOH is not a priority.) > At this point, it's up to Stefan, I think. I have no idea why my opinion would be relevant here. But to me the hardcoded 4 is a plain bug. === Stefan
bug-gnu-emacs@HIDDEN:bug#80988; Package emacs.
Full text available.Received: (at 80988) by debbugs.gnu.org; 26 May 2026 15:00:22 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 26 11:00:21 2026 Received: from localhost ([127.0.0.1]:34034 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1wRtGR-0004Tl-Sp for submit <at> debbugs.gnu.org; Tue, 26 May 2026 11:00:21 -0400 Received: from mail-vk1-xa36.google.com ([2607:f8b0:4864:20::a36]:48160) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <shipmints@HIDDEN>) id 1wRtGK-0004Rt-33 for 80988 <at> debbugs.gnu.org; Tue, 26 May 2026 11:00:13 -0400 Received: by mail-vk1-xa36.google.com with SMTP id 71dfb90a1353d-57747a2bf20so3296399e0c.0 for <80988 <at> debbugs.gnu.org>; Tue, 26 May 2026 08:00:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1779807607; cv=none; d=google.com; s=arc-20240605; b=X+HaNkIGtx/X+ZJX0XiL7+IWoSbjOCxb4QOuNzXhewQRSWK5FRCH5xaMZkV24ltksm kSvsku43ScHRNszimODsBtsP7NnrHee3Q9boi/c1Es7nsiLNDxTzsQmckrKPiXN9PJXw iwk0MDVFG3F583gPJ22ZAQaVXTvdPVB0yIE6fFV5Abhjle9DiJk7bx6cT7qwoQ+J9HQQ 9TDooIgoyu8eC6D1S5U8CeVr7WvurFcdGcSgq8/64MWr+Durj6L/Xtgw40KdE9ayqzpj UeJGoVmDuEgGPpHx2INOAuUn3j7MK4V8t1nCfBUtod4fN1my5XTmW9i5pfeJ9YXbdlui KJIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=UXifHWal+NTsDN9zzRzD5wqUGjf0ogOf+MUJaX72v+M=; fh=3aTbul8eH1QOpidVIWEhacHOVZP/yHTqgeOaq2/eDf8=; b=Pldt5ggedKhQ9isMBMsh01VKvAizlwz3+6qQUFNR34so65wXguYUPIBe5Ic3D8lLkm VSYYCs8dfcYdFVcjEyTC3Tudd46IPouaXnfHN1DFNWges4UlSGYN2XtZOdbxK+zEQ1gp dKhPb+fc/PtLxte2/xo64tkxLm8H1fYh9sxRPjEf+J5sSEOGva/BUvGbQ0PGHbIUKaEx kOM6THQJKT5SuMTQ7cY58GBZlwjyi/riwdsc7tSkg2QaFD4jUmdIYSspGJ/zGNWoWF08 lLeNAc8q6fHXbxbPcNxAVwhlk83y21Uqcf5HuzWLjsHmSes4C4Sp5vEzS2BrURNttuH1 moSg==; darn=debbugs.gnu.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779807607; x=1780412407; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=UXifHWal+NTsDN9zzRzD5wqUGjf0ogOf+MUJaX72v+M=; b=oX0sOy+xk40pwMK7jLHXf+1XXEWavwQg4nlUH2e6zRKASUp35VeZ8ukDYZbJUGCGNE BPiA/H7Clze1ojYEPz40zYycfMFFm6lmpbQNOZOLaKUJgtmGBbmEBTTtwQkXmjPUwj7N V2LIdE2oj5QnePtlXI+2hgw1hekT5PvP0ZpfaEzluisu4zuPgah/Hg72q7XHAik31WaL UmOiVv8p59kwhZOdQWJ+tGb8dTNFDq/S8jsoP+759I4rR8lW/MxNFuhTV4TI7fCN7GGg v4k9oee+CzFJXrBom9BrEDuxN+Y9Cbo7SerZZpFvfGxgmAcQGC8eeSGjkBaFa9YDgP5f V9Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779807607; x=1780412407; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UXifHWal+NTsDN9zzRzD5wqUGjf0ogOf+MUJaX72v+M=; b=igtogx3QF54scl303akY9xc+saMUMsYWebR/cjr1RBewQRHMmqvRjV7rCrXMdPbyAz /Af3VZMKWfj8BkwR1ILCI9EGB+0OVAvOmhQZpGqz+MjOMgNmiakm2Q0Q0/Z6iUxjajZS NkdLZrSjipmNn+KkgRhlbejmnWeVhjEjHysa8SX2cWlibPvy/yXSYSnHgyMBo9MuuSvF OF2079nTb4CJLBfXWZOUU0TJttTSmFTNZUDp4tHPab6bVKlJ+8sOG6oYwy5JG1/7ZfHC ThhBFjB2O5qb6B+37NhH6Q2dSFZpBH5jrT44tXHrxgevQ3iP8akat0Z4R5m6iU9H6w9m HihA== X-Forwarded-Encrypted: i=1; AFNElJ/2kRpdZcYHw7IMuA2AQhM00I8+OnNe6McRJU34QoNkWXC8d+DqlvVCczkXez0AuzPv+GxGrg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwjfJb8Rbpnsmk+h2hZqcMKaaV5uTRh7YF92MgvGT5oamNOd5Hm qVB1GGSEjl3v5fAvkeMsagV+++9AGvm7vEzbf2sy5FNEjrUHq9hPiEdot5YCVuerF7UO1woRYoO uU5MdUiTtnbfVOSzVnbJDfkqvHJE2xfI= X-Gm-Gg: Acq92OGatBapymLM8uCNXlK1x3ZLm3dVw11brxD3chYvvS5F1YrBqcOHBK8wViNPZKh yxUW5vvID4IPP1frq/iIULhbIhqPiA56PhReLnnjgO7mWgsc4CWhabIddpjIYlpg0lJjHLLpZUX of4ilpspxOgzK4d/2KOTr8TEcf2/ddkTJwqBUbwQplsMb+cfV9PKHVxPGl2X096E+obd9Rrkdz6 3mU9ivi81Aet3N2dqc1kfXfpz+0rFKhF6eNoyq+Om1JUYkQSwEGtyqYhYd6GfInd2Q0t3oksuwM dv39mJkRywbW8PgLLCktdUZMM2NO/iNlmXJHFrCBypwxhdxa3J/5ChtvsAwEWPrXBHRRJ4iZgw+ mJp133/fQeSEm5dVl/u20CtHhqqby592VfJWP7maZkXtXVIe6 X-Received: by 2002:a05:6122:2215:b0:56c:ce8a:b07a with SMTP id 71dfb90a1353d-58660d810c9mr9363720e0c.7.1779807607125; Tue, 26 May 2026 08:00:07 -0700 (PDT) MIME-Version: 1.0 References: <875x4yl7fm.fsf@HIDDEN> <CAN+1Hbrs_rFU35hBUaKa-AA7eaYZOmnPBMaw-Di5hDrCsd9uOA@HIDDEN> <878q9rquo1.fsf@HIDDEN> <CAN+1HbpJP7aWDioF1GSBHh0Bem8Od1_Ea_qJqoyx0+ptNaDaJg@HIDDEN> <CAN+1Hbq00c0WZnYuf_hatUweO3-0tGMJge1BQDpzmaQANbF3LA@HIDDEN> <875x4a8cay.fsf@HIDDEN> In-Reply-To: <875x4a8cay.fsf@HIDDEN> From: =?UTF-8?Q?St=C3=A9phane_Marks?= <shipmints@HIDDEN> Date: Tue, 26 May 2026 10:59:55 -0400 X-Gm-Features: AVHnY4KV21dT_KAC5ot8XBW6oa2Ud3dZGwbth2c86_Rn5uc-03AHoMommmwdZnk Message-ID: <CAN+1HbogopTOR0Zs1hxgDvFd4=SLeJ3OLDULY0i3XjPFxhvq8Q@HIDDEN> Subject: Re: bug#80988: 31.0.50; Progress report (commit f5f2306fc1d) To: Augusto Stoffel <arstoffel@HIDDEN> Content-Type: multipart/alternative; boundary="00000000000030fb3b0652b9c079" X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 80988 Cc: Stefan Monnier <monnier@HIDDEN>, 80988 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.0 (/) --00000000000030fb3b0652b9c079 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, May 26, 2026 at 10:39=E2=80=AFAM Augusto Stoffel <arstoffel@HIDDEN= om> wrote: > Hi St=C3=A9phane, > > not sure what your plan is regarding this patch. It seems to me either > we get rid of the magic number 4 in Emacs 31 or else it becomes the > official API forever. Either way there's not much time to decide. > (Renaming progress-reporter-pulse-characters OTOH is not a priority.) > > Best, > Augusto > > > On Mon, 11 May 2026, St=C3=A9phane Marks wrote: > > > On Mon, May 11, 2026 at 1:16=E2=80=AFPM St=C3=A9phane Marks <shipmints@= gmail.com> > wrote: > > > > On Sun, May 10, 2026 at 9:08=E2=80=AFAM Augusto Stoffel <arstoffel@gma= il.com> > wrote: > > > > > Nothing is special about 4 and nothing is special about the characte= rs > > > other than that change was the smallest backward compatible change > > > vs. the original code. Patches often get scrutinized for size and > > > scope of change and even some people complain when whitespace change= s > > > because things get indented when code is added. > > > > Well, before this commit the magic 4 was standing for the length of > > progress-reporter--pulse-characters, which is presumably internal > > information. But now it has become official and documented in a > > docstring. So I don't see this as a consequence of any minimality > > requirement for the change. > > > > Anyway. I really think this (i.e., get rid of the magic 4, make STATE > > an ever-increasing sequence) should be changed for Emacs 31, since aft= er > > the release it will really become official. > > > > +list > > > > The function 'system-taskbar--progress-reporter-update' will also need > to be > > patched to not refer to 4 and either use the vector's length. > > > > I will audit the rest of core to see where else. > > > > We could create a "public" defvar/alias for > 'progress-reporter--pulse-characters' if > > it's something you want to replace with your own vector. I think a > defcustom is > > going too far for most people (plus, subr.el is I think too early for > defcustom's in the > > startup sequence). > > > > I did not take you patch verbatim as it missed several key details. > > > > I audited 'progress-reporter-update' calls across core and also many > ELPA packages > > and the only place that needed a change to accommodate is in > > 'system-taskbar--progress-reporter-update' which echoed the hard-code. > > > > I tested with change with the following alternative set of pulse > characters, among others > > including just one and just two characters: > > > > (setq progress-reporter-pulse-characters ["=E2=86=90" "=E2=86=96" "= =E2=86=91" "=E2=86=97" "=E2=86=92" "=E2=86=98" "=E2=86=93" > "=E2=86=99"]) > > > > Though I seem to be partial to these: > > > > (setq progress-reporter-pulse-characters ["=E2=97=B4" "=E2=97=B7" "= =E2=97=B6" "=E2=97=B5"]) > > > > Patch attached. I leave it up to y'all to decide if this is minor > enough for Emacs 31 as > > Augusto suggests or if it should be for 32. > > > > -St=C3=A9phane > > > > [4. text/x-patch; > 0001-Improve-pulsing-progress-reporter-characters-bug-809.patch]... > At this point, it's up to Stefan, I think. --00000000000030fb3b0652b9c079 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon= t-family:monospace"><span style=3D"font-family:Arial,Helvetica,sans-serif">= On Tue, May 26, 2026 at 10:39=E2=80=AFAM Augusto Stoffel <<a href=3D"mai= lto:arstoffel@HIDDEN">arstoffel@HIDDEN</a>> wrote:</span></div></d= iv><div class=3D"gmail_quote gmail_quote_container"><blockquote class=3D"gm= ail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,= 204,204);padding-left:1ex">Hi St=C3=A9phane,<br> <br> not sure what your plan is regarding this patch.=C2=A0 It seems to me eithe= r<br> we get rid of the magic number 4 in Emacs 31 or else it becomes the<br> official API forever.=C2=A0 Either way there's not much time to decide.= <br> (Renaming progress-reporter-pulse-characters OTOH is not a priority.)<br> <br> Best,<br> Augusto<br> <br> <br> On Mon, 11 May 2026, St=C3=A9phane Marks wrote:<br> <br> > On Mon, May 11, 2026 at 1:16=E2=80=AFPM St=C3=A9phane Marks <<a hre= f=3D"mailto:shipmints@HIDDEN" target=3D"_blank">shipmints@HIDDEN</a>&= gt; wrote:<br> ><br> >=C2=A0 On Sun, May 10, 2026 at 9:08=E2=80=AFAM Augusto Stoffel <<a h= ref=3D"mailto:arstoffel@HIDDEN" target=3D"_blank">arstoffel@HIDDEN</a= >> wrote:<br> ><br> >=C2=A0 > Nothing is special about 4 and nothing is special about the= characters<br> >=C2=A0 > other than that change was the smallest backward compatible= change<br> >=C2=A0 > vs. the original code.=C2=A0 Patches often get scrutinized = for size and<br> >=C2=A0 > scope of change and even some people complain when whitespa= ce changes<br> >=C2=A0 > because things get indented when code is added.<br> ><br> >=C2=A0 Well, before this commit the magic 4 was standing for the length= of<br> >=C2=A0 progress-reporter--pulse-characters, which is presumably interna= l<br> >=C2=A0 information.=C2=A0 But now it has become official and documented= in a<br> >=C2=A0 docstring.=C2=A0 So I don't see this as a consequence of any= minimality<br> >=C2=A0 requirement for the change.<br> ><br> >=C2=A0 Anyway.=C2=A0 I really think this (i.e., get rid of the magic 4,= make STATE<br> >=C2=A0 an ever-increasing sequence) should be changed for Emacs 31, sin= ce after<br> >=C2=A0 the release it will really become official.<br> ><br> >=C2=A0 +list<br> ><br> >=C2=A0 The function 'system-taskbar--progress-reporter-update' = will also need to be<br> >=C2=A0 patched to not refer to 4 and either use the vector's length= .<br> ><br> >=C2=A0 I will audit the rest of core to see where else.<br> ><br> >=C2=A0 We could create a "public" defvar/alias for 'progr= ess-reporter--pulse-characters' if<br> >=C2=A0 it's something you want to replace with your own vector.=C2= =A0 I think a defcustom is<br> >=C2=A0 going too far for most people (plus, subr.el is I think too earl= y for defcustom's in the<br> >=C2=A0 startup sequence).<br> ><br> > I did not take you patch verbatim as it missed several key details.<br= > ><br> > I audited 'progress-reporter-update' calls across core and als= o many ELPA packages<br> > and the only place that needed a change to accommodate is in<br> > 'system-taskbar--progress-reporter-update' which echoed the ha= rd-code.<br> ><br> > I tested with change with the following alternative set of pulse chara= cters, among others<br> > including just one and just two characters:<br> ><br> >=C2=A0 =C2=A0(setq progress-reporter-pulse-characters ["=E2=86=90&= quot; "=E2=86=96" "=E2=86=91" "=E2=86=97" &qu= ot;=E2=86=92" "=E2=86=98" "=E2=86=93" "=E2=86= =99"])<br> ><br> > Though I seem to be partial to these:<br> ><br> >=C2=A0 =C2=A0(setq progress-reporter-pulse-characters ["=E2=97=B4&= quot; "=E2=97=B7" "=E2=97=B6" "=E2=97=B5"])<b= r> ><br> > Patch attached.=C2=A0 I leave it up to y'all to decide if this is = minor enough for Emacs 31 as<br> > Augusto suggests or if it should be for 32.<br> ><br> > -St=C3=A9phane<br> ><br> > [4. text/x-patch; 0001-Improve-pulsing-progress-reporter-characters-bu= g-809.patch]...<br></blockquote><div><br></div><div class=3D"gmail_default"= style=3D"font-family:monospace">At this point, it's up to Stefan, I th= ink.</div></div></div> --00000000000030fb3b0652b9c079--
bug-gnu-emacs@HIDDEN:bug#80988; Package emacs.
Full text available.Received: (at 80988) by debbugs.gnu.org; 26 May 2026 14:39:59 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 26 10:39:59 2026 Received: from localhost ([127.0.0.1]:33909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1wRswn-00012z-KM for submit <at> debbugs.gnu.org; Tue, 26 May 2026 10:39:58 -0400 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]:57820) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <arstoffel@HIDDEN>) id 1wRswi-000124-FT for 80988 <at> debbugs.gnu.org; Tue, 26 May 2026 10:39:56 -0400 Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-6746d0b2b4aso18005677a12.3 for <80988 <at> debbugs.gnu.org>; Tue, 26 May 2026 07:39:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779806391; x=1780411191; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=oHwUnoGZ60jp2hbeZPUu5R/Sn8hWpaG2iTDW+Vwdr0c=; b=BEfom79paMkcbGy+hbaXl/H9K/L0Cjjdw883TssWZX7/+NrfvtwBASld86XFACgoM2 wsWNb5hOxYukx8j85clamoOSjB4QpsB4k1PoBH+rucC25fq8RceUakK/vGgdlTtyaFAV mU7AB6ksohhzybXQG9V5aV4LbT74xFXZIygQh2XWXiom+DW8W9+Y6PEEn0+gXO4FPeQQ g2s0FQLPw6PpZDquRwRz21LdDAwIBHT6x5AmjQ/q2A/iHIrEvtfcMtsPZr+X/mL9u6H1 r5JIAM+IO22XoTLRWpw3DlgtU1m9Gtw9VurshEKfvSTLOtuzOHutc38qKmat2QGsxJI3 vV5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779806391; x=1780411191; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=oHwUnoGZ60jp2hbeZPUu5R/Sn8hWpaG2iTDW+Vwdr0c=; b=DqXXmjc4TyRGO0TCsJWcaE6obsvH3OWGQ9PCuI2MXEWJ2zNTWhvcTHA1I0xUBZkD8V y0RpSNsyb13NYnywBrHtQ0AwoDbq/bh55GQi9pfNWBbUC+kt45IzxldBluVbV1CYSsDH gPAuJ4YUsMe5wJLL8ATGl4OeBarGkJ9v448PkNTHX/d4IcHYdcibq2j0A/sr2a8EWPJK LVt/52WbI6CmR/PUn8H4/6Nwb3O6tK0zJmldVWmmOdGP9UH2+XQG2qMUgKZ47z4wCPwC V9Kqrn5vKANo2D052bIPTCSllHjcqf0ST8hdSbxbNN5WzWYADtS5TWrH1q2GZeRnwulW Jouw== X-Forwarded-Encrypted: i=1; AFNElJ9hI+2UxL3eiJ/drCzuROlowvj4H0+Qfb1KOowVMRTrBjGov2r2/BzDaUxOPeL5szQsYTYTCw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YygBN/CNQd9JLPh/Zna5IqawjSu2b7jftODrTJOhTHGNGfOBfYP Ft9EgSgWnHs8dRi/hs0CSX1WJ5hbXqiezHitVSrF8d0LIZ3fzju4v18YOSgKklpx X-Gm-Gg: Acq92OE5IY3oCIkW8evSHRBgUNj1xpVLrRWjx5+jDQ109vfry/pCNCKypK9S89K29Vk WfRMbgh5VsBiU1wjivIOvEX730VF18lVNj6GXbTYZI6stcCUusK0/aiGhk364aaTVP9ryzsuto1 viUH+81Vzx6czj0g4tk0ZQGzq9e7U6FJIxnOYDBdfreHF5q7GrWqLw+UzJrILpQDmjhznvO27wn YMyflCW1tPb3MsQrFJ6l3ogPmxzK6JV5cvc8YDPAlGJBkL9pSY0503vZk8RzOFzPCjA35JunIgg +nAERqdIh1vGhaqbB+Z8HuPMeBtxR8IVJE1TPqc7UT+nhhFAnAkprYkvDWJesqPdYkbUJdvhjHl agVLZ8WaOtVVbM/ZlvoGAPkLFzLVTO1YdF8syzzfHtQTrB5zCUKpYIa2817GE/5cJCuzgGaoSGb /5X3U7mHJ25SoTl99zfg== X-Received: by 2002:a05:6402:370a:b0:683:cd2:cf6c with SMTP id 4fb4d7f45d1cf-6889c432184mr9720397a12.10.1779806391073; Tue, 26 May 2026 07:39:51 -0700 (PDT) Received: from ars3 ([2a02:8109:8a95:9a00:a174:43ce:14f5:df5e]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-688bb6273a2sm5180700a12.29.2026.05.26.07.39.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 May 2026 07:39:50 -0700 (PDT) From: Augusto Stoffel <arstoffel@HIDDEN> To: =?utf-8?Q?St=C3=A9phane?= Marks <shipmints@HIDDEN> Subject: Re: bug#80988: 31.0.50; Progress report (commit f5f2306fc1d) In-Reply-To: <CAN+1Hbq00c0WZnYuf_hatUweO3-0tGMJge1BQDpzmaQANbF3LA@HIDDEN> References: <875x4yl7fm.fsf@HIDDEN> <CAN+1Hbrs_rFU35hBUaKa-AA7eaYZOmnPBMaw-Di5hDrCsd9uOA@HIDDEN> <878q9rquo1.fsf@HIDDEN> <CAN+1HbpJP7aWDioF1GSBHh0Bem8Od1_Ea_qJqoyx0+ptNaDaJg@HIDDEN> <CAN+1Hbq00c0WZnYuf_hatUweO3-0tGMJge1BQDpzmaQANbF3LA@HIDDEN> Date: Tue, 26 May 2026 16:39:49 +0200 Message-ID: <875x4a8cay.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 80988 Cc: Stefan Monnier <monnier@HIDDEN>, 80988 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.0 (/) Hi St=C3=A9phane, not sure what your plan is regarding this patch. It seems to me either we get rid of the magic number 4 in Emacs 31 or else it becomes the official API forever. Either way there's not much time to decide. (Renaming progress-reporter-pulse-characters OTOH is not a priority.) Best, Augusto On Mon, 11 May 2026, St=C3=A9phane Marks wrote: > On Mon, May 11, 2026 at 1:16=E2=80=AFPM St=C3=A9phane Marks <shipmints@gm= ail.com> wrote: > > On Sun, May 10, 2026 at 9:08=E2=80=AFAM Augusto Stoffel <arstoffel@gmail= .com> wrote: > > > Nothing is special about 4 and nothing is special about the characters > > other than that change was the smallest backward compatible change > > vs. the original code. Patches often get scrutinized for size and > > scope of change and even some people complain when whitespace changes > > because things get indented when code is added. > > Well, before this commit the magic 4 was standing for the length of > progress-reporter--pulse-characters, which is presumably internal > information. But now it has become official and documented in a > docstring. So I don't see this as a consequence of any minimality > requirement for the change. > > Anyway. I really think this (i.e., get rid of the magic 4, make STATE > an ever-increasing sequence) should be changed for Emacs 31, since after > the release it will really become official. > > +list > > The function 'system-taskbar--progress-reporter-update' will also need t= o be > patched to not refer to 4 and either use the vector's length. > > I will audit the rest of core to see where else. > > We could create a "public" defvar/alias for 'progress-reporter--pulse-ch= aracters' if > it's something you want to replace with your own vector. I think a defc= ustom is > going too far for most people (plus, subr.el is I think too early for de= fcustom's in the > startup sequence). > > I did not take you patch verbatim as it missed several key details. > > I audited 'progress-reporter-update' calls across core and also many ELPA= packages > and the only place that needed a change to accommodate is in > 'system-taskbar--progress-reporter-update' which echoed the hard-code. > > I tested with change with the following alternative set of pulse characte= rs, among others > including just one and just two characters: > > (setq progress-reporter-pulse-characters ["=E2=86=90" "=E2=86=96" "=E2= =86=91" "=E2=86=97" "=E2=86=92" "=E2=86=98" "=E2=86=93" "=E2=86=99"]) > > Though I seem to be partial to these: > > (setq progress-reporter-pulse-characters ["=E2=97=B4" "=E2=97=B7" "=E2= =97=B6" "=E2=97=B5"]) > > Patch attached. I leave it up to y'all to decide if this is minor enough= for Emacs 31 as > Augusto suggests or if it should be for 32. > > -St=C3=A9phane > > [4. text/x-patch; 0001-Improve-pulsing-progress-reporter-characters-bug-8= 09.patch]...
bug-gnu-emacs@HIDDEN:bug#80988; Package emacs.
Full text available.Received: (at 80988) by debbugs.gnu.org; 12 May 2026 20:30:03 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 12 16:30:02 2026 Received: from localhost ([127.0.0.1]:39323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1wMtjs-0001YB-93 for submit <at> debbugs.gnu.org; Tue, 12 May 2026 16:30:02 -0400 Received: from mail-vs1-xe2d.google.com ([2607:f8b0:4864:20::e2d]:43105) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <shipmints@HIDDEN>) id 1wMtjn-0001Xa-GM for 80988 <at> debbugs.gnu.org; Tue, 12 May 2026 16:29:58 -0400 Received: by mail-vs1-xe2d.google.com with SMTP id ada2fe7eead31-63201e0d6b8so2381631137.0 for <80988 <at> debbugs.gnu.org>; Tue, 12 May 2026 13:29:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1778617794; cv=none; d=google.com; s=arc-20240605; b=i3uqT7gT2KwOIKbFeeqjR1hBGma0/2RWqVnKyMZRCHxA8u88sph6wKG0WGNYpE9Sfu dCBlMlj+QqGUJfXX8YaHPcFsJNsbkkv6EPLMJ/toI6tX6ua+jwtMCs6GYMPNZZvsIvwR 77ImkTkA6ycaFVW/EwSRVqwV/aoySNOOJWEz3EYILmrapuEtsubyH8tNdIRDK71JQU7y ZWcK05vHa3vl2kJrEooC0ooSkSGqW6XaXHCg+eNmFF2DzAvC+z/nAYQNwHYwPUou2RdK J5hex19lJH79xXrEiVdSyATNQtOXAInhWH2rQ7Bkc3Rnjexq/co8z5Eh2qr4RqsMUOU3 Z4cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=0FjmvrvtStqKy5NUxOY9KuHFzx5PClS+sw4i26EDG/o=; fh=OOvzD7sErACJtIHCX0jlMO7AtOHMdsbcH99ZoGJz7c8=; b=RtdwSbIJFHebIx/XlA+PKKExFqwCW4lZczU/Dfs6BBjLaU10TWrgmbbAAeBK1fp+ov taKxFp9jw2rM1SlOEGTCWWDt8ED8vhKSg3mHbKOYOkAJsbn10rmorpDimgDoFnGopk3S bwH+xps8LGe+CerzEV5ldIgBS3LAtsCg1V0wFMUhzJwRyoonCh8AxvjZLKPZGQzbd7O4 CxKPfFf0UyxbEF0tWpgkPANHuixv41iGHEkrlW1ToU6SrSHoJkdwnjcN/teYx8k6y/hW PfCc/mBOcSoBNq2glBs51L3xKpDWWlJgCVRYzJChl6mTzftVghdSSxEzqc4yXDZNk1ET 6v7g==; darn=debbugs.gnu.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778617794; x=1779222594; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0FjmvrvtStqKy5NUxOY9KuHFzx5PClS+sw4i26EDG/o=; b=C+dnoErzLaTn25NZ4kXl59zWjWrXsT5zhuU7fK5LkjcsLB0ldqkSh3Cz28ZCXYNqHw uTDS0aw+ejylaqNHpXyQZbCizQwRLCmYrmC/6DrqPbd/8wCfSrVS1QnMINusr+TA20mV V1CPJeoRpW2NL51Fp2RF7aQ8VjVL866JUE/SxC+Jm0Kr4JwFJ/KMK4rNCiC7Xw0mvHmD ctQPNa8iDlFz39uH9mSIcnaErQny/CmMz336z28NT+t4risVgTe2Sa3jY80lX63Y28li l/2S4bnBvO7kq+HHeVWbqyxIHgf4rizuEwR2tWlUTkpLnQlsPAm5fhtXYbje2zZEEh8M a5xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778617794; x=1779222594; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0FjmvrvtStqKy5NUxOY9KuHFzx5PClS+sw4i26EDG/o=; b=mVK2Ac4xk/K0Qr0jieY0xae6iRVgW1uG2mlCioMSfGX3p7KvuE3t7f/zS9/aGRGWIq hDB1Mtg0rxaEOtSwfx+YgBWH/EDuxejwoIQwEtyHAM4d2W0aHhvJ05yP6Bx11DeJuTnI F4LfTRApHYO03txW47fQ/fqkJTiHRIO/sghYpaqzPytBQZTUrRV1lrgYC02TUilYZ3wG gBRhbgZTr4xdLha3o+ARlvUtEfAqxGJvHbgE7F9ta6TwGx/CEuZktQFXxGxL0mICl7Fh p0QvV8xiWiPma/sIl3Ib3mgH78Sf15vBzlbIwmE03OFXbNofQM/8gThE9Lg3I8xbIhz1 /XXQ== X-Forwarded-Encrypted: i=1; AFNElJ9ZPYIjp8JiOnTbHviyMrRTkKhMWGqqqpn8050obLKiZ7DW4gtubYa9b9g+UWWWOqMxa8f49A==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yx1uWIjTN0rep04uaI3aXTBCBzlQKQ9Ra7DEuqURwLxJ05ITL4i mlSIaMu47IDU8ABD0hR+9pudLQHbxKl+PLd965StRB/j1ViJJ1LoQIf0yjV06szb99YA4hAIOjt udLhf4ILT4OH1EvU1g3fEMt4izeaqdEc= X-Gm-Gg: Acq92OG+rlOY61kDO34VnxI6G3tB3iX2XZaciY9ekZj/izvrk3n7tNIoq7aQ309V7UH T1l/2GKoPXQZ/M3MkejzitAHoQ3PqgM8QnDn1Mx/2vM3STwM9Rt7qpaPPk6rX/oYOiokZ1FVojB lLPSTiDw1VDiMumciSat8Xn7KKRx0bUm/J5aYxVdGnqjsYraTBGjZmZIoCkO4GAhbjxmO9yqIA6 CkiqxSZP5z+NtckkEbCc3rmkTKGODZtvAZMlQAzVJSVYRdv3Ym0xZF4i4HXpDozhEnBt6PuGHfy TXirMdOktPwq4oczebzfxjyW6KXIxrXRW3zGJeks34Q2NGCK7R1ZoMiA2JPhvixhCirGpUBnzQV FSuEQ2hWIPdlcZpuZ3V+cx8elaG9qHuA587bVEFabGbi0OV4= X-Received: by 2002:a05:6102:6444:b0:634:d97f:7ee7 with SMTP id ada2fe7eead31-635cfabb79fmr2356600137.7.1778617794600; Tue, 12 May 2026 13:29:54 -0700 (PDT) MIME-Version: 1.0 References: <875x4yl7fm.fsf@HIDDEN> <CAN+1Hbrs_rFU35hBUaKa-AA7eaYZOmnPBMaw-Di5hDrCsd9uOA@HIDDEN> <878q9rquo1.fsf@HIDDEN> <CAN+1HbpJP7aWDioF1GSBHh0Bem8Od1_Ea_qJqoyx0+ptNaDaJg@HIDDEN> <CAN+1Hbq00c0WZnYuf_hatUweO3-0tGMJge1BQDpzmaQANbF3LA@HIDDEN> <87fr3xaztk.fsf@HIDDEN> <CAN+1Hbp75M=crUsQPj3=UVbB4kEi9xg1k8fNR4mVuG3=1BftvQ@HIDDEN> <87qzngl8ni.fsf@HIDDEN> In-Reply-To: <87qzngl8ni.fsf@HIDDEN> From: =?UTF-8?Q?St=C3=A9phane_Marks?= <shipmints@HIDDEN> Date: Tue, 12 May 2026 16:29:43 -0400 X-Gm-Features: AVHnY4LS644lUNBcMZA-XicqXk-MvDwPLdofbnDIJ6MfIUFJWw6EjDfPQnmIaLI Message-ID: <CAN+1HbqHP_J8kkc+HN863qDUQT6vQnjJxYL5VUzMMvDiYgQDug@HIDDEN> Subject: Re: bug#80988: 31.0.50; Progress report (commit f5f2306fc1d) To: Augusto Stoffel <arstoffel@HIDDEN> Content-Type: multipart/alternative; boundary="000000000000d6a3870651a4b9e0" X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 80988 Cc: Stefan Monnier <monnier@HIDDEN>, 80988 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.0 (/) --000000000000d6a3870651a4b9e0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 T24gVHVlLCBNYXkgMTIsIDIwMjYgYXQgMzozOeKAr1BNIEF1Z3VzdG8gU3RvZmZlbCA8YXJzdG9m ZmVsQGdtYWlsLmNvbT4gd3JvdGU6DQoNCj4NCj4gT24gVHVlLCAxMiBNYXkgMjAyNiwgU3TDqXBo YW5lIE1hcmtzIHdyb3RlOg0KPg0KPiA+IEFueXRoaW5nIHlvdSBjYW4gZGlzcGxheSB1c2luZyBh IHRleHQgcHJvcGVydHkgd29ya3MgaW5jbHVkaW5nIGltYWdlcy4NCj4gPiBNb3JlIHNpbXBseSwg dGhlIGZvbGxvd2luZyBhcmUgdW5pY29kZSBjaGFycyB5b3UgY2FuICJhbmltYXRlIiAob3IgdXNl DQo+ID4gZW1vamlzKSBhbmQgeW91IGNhbiBhZGQgY29sb3JzIG9yIGJvbGQgb3Igd2hhdGV2ZXI6 DQo+ID4NCj4gPiAoc2V0cSBwcm9ncmVzcy1yZXBvcnRlci1wdWxzZS1jaGFyYWN0ZXJzIGBbIuKW kuKWkeKWkeKWkeKWkeKWkSIgIuKWkeKWkuKWkeKWkeKWkeKWkSIgIuKWkeKWkeKWkuKWkeKWkeKW kSINCj4gIuKWkeKWkeKWkeKWkuKWkeKWkSINCj4gPiAi4paR4paR4paR4paR4paS4paRIiAi4paR 4paR4paR4paR4paR4paSIiAi4paR4paR4paR4paR4paS4paRIiAi4paR4paR4paR4paS4paR4paR IiAi4paR4paR4paS4paR4paR4paRIiAi4paR4paS4paR4paR4paR4paRIl0pDQo+ID4NCj4gPiBJ cyB0aGVyZSBzb21ldGhpbmcgeW91IGhhZCBpbiBtaW5kIGJleW9uZCB0aGlzIGZvciBlY2hvLWFy ZWEgcHJvZ3Jlc3MNCj4gPiByZXBvcnRzPw0KPg0KPiBZZXMsIEkgd2FzIHdvbmRlcmluZyBpZiBh Y2NlcHRpbmcgaWNvbnMgYXMgdmVjdG9yIGVsZW1lbnRzIGluc3RlYWQgb2YNCj4ganVzdCBzdHJp bmdzIHdvdWxkIG1ha2Ugc2Vuc2UuICBCdXQgdGhpcyBjb3VsZCBhbHdheXMgYmUgZG9uZSBsYXRl ci4NCj4NCg0KQWxyaWdodCwgbWF5YmUgU3RlZmFuIGNhbiBpbnN0YWxsIHRoZSBwYXRjaCBpZiBo ZSdzIG9rYXkgd2l0aCBpdC4gIFdlIGNhbg0KaWNvbmlmeSBsYXRlciBpZiB0aGVyZSdzIHJlYWwg ZGVtYW5kLg0K --000000000000d6a3870651a4b9e0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon= t-family:monospace"><span style=3D"font-family:Arial,Helvetica,sans-serif">= On Tue, May 12, 2026 at 3:39=E2=80=AFPM Augusto Stoffel <<a href=3D"mail= to:arstoffel@HIDDEN">arstoffel@HIDDEN</a>> wrote:</span></div></di= v><div class=3D"gmail_quote gmail_quote_container"><blockquote class=3D"gma= il_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,2= 04,204);padding-left:1ex"><br> On Tue, 12 May 2026, St=C3=A9phane Marks wrote:<br> <br> > Anything you can display using a text property works including images.= <br> > More simply, the following are unicode chars you can "animate&quo= t; (or use<br> > emojis) and you can add colors or bold or whatever:<br> ><br> > (setq progress-reporter-pulse-characters `["=E2=96=92=E2=96=91=E2= =96=91=E2=96=91=E2=96=91=E2=96=91" "=E2=96=91=E2=96=92=E2=96=91= =E2=96=91=E2=96=91=E2=96=91" "=E2=96=91=E2=96=91=E2=96=92=E2=96= =91=E2=96=91=E2=96=91" "=E2=96=91=E2=96=91=E2=96=91=E2=96=92=E2= =96=91=E2=96=91"<br> > "=E2=96=91=E2=96=91=E2=96=91=E2=96=91=E2=96=92=E2=96=91" &qu= ot;=E2=96=91=E2=96=91=E2=96=91=E2=96=91=E2=96=91=E2=96=92" "=E2= =96=91=E2=96=91=E2=96=91=E2=96=91=E2=96=92=E2=96=91" "=E2=96=91= =E2=96=91=E2=96=91=E2=96=92=E2=96=91=E2=96=91" "=E2=96=91=E2=96= =91=E2=96=92=E2=96=91=E2=96=91=E2=96=91" "=E2=96=91=E2=96=92=E2= =96=91=E2=96=91=E2=96=91=E2=96=91"])<br> ><br> > Is there something you had in mind beyond this for echo-area progress<= br> > reports?<br> <br> Yes, I was wondering if accepting icons as vector elements instead of<br> just strings would make sense.=C2=A0 But this could always be done later.<b= r></blockquote><div><br></div><div class=3D"gmail_default" style=3D"font-fa= mily:monospace">Alright, maybe Stefan can install the patch if he's oka= y with it.=C2=A0 We can iconify=C2=A0later if there's real demand.</div= ></div></div> --000000000000d6a3870651a4b9e0--
bug-gnu-emacs@HIDDEN:bug#80988; Package emacs.
Full text available.Received: (at 80988) by debbugs.gnu.org; 12 May 2026 19:39:43 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 12 15:39:43 2026 Received: from localhost ([127.0.0.1]:38838 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1wMsxB-0003cf-TI for submit <at> debbugs.gnu.org; Tue, 12 May 2026 15:39:42 -0400 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]:42255) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <arstoffel@HIDDEN>) id 1wMsx8-0003bA-Bh for 80988 <at> debbugs.gnu.org; Tue, 12 May 2026 15:39:40 -0400 Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-bd2e8931915so171161066b.1 for <80988 <at> debbugs.gnu.org>; Tue, 12 May 2026 12:39:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778614771; x=1779219571; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=N59nAAjadXPcIpljNYmh824QIytjoMUoQMYOapCDby4=; b=GIuzzFDbxLJ3+boZ2bXUV+SVzJwykWti+uQXwn5ZGu8338cwCCj5Zkuqs8nio3gXeS Ftvss++M3G/SyMpqdbxYEKPVyNsSxCQo9sjgjXrqrQVm5fFKtMvNT8wGBNmNWjvISqEN kpy9bNfX1vEMBP1LWmt318s0KyDntaLsyBWj6MQfFhegKAB8MOZWwiKzmnLYa/2RcRij HVnqIbDP6ocuqyHAX9MD4+n49tJkG1PJ9Plr4FE1MK0YERv/7158F10J3OiY3q7IC5Ai JkNlg7qpXjh4YjmYPL9Dc8Wc0dFkFw+Xqsmffp2ROVche+T+Ce6eEC8zNP/zrgrBlR97 YN1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778614771; x=1779219571; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=N59nAAjadXPcIpljNYmh824QIytjoMUoQMYOapCDby4=; b=LYfNJUhxGb0v/6NIbKA74qzpxlOVonD7ZR8Oa9PpPB4BicmkX/UYCbrmwntPaaaKG9 P8yW/99DEz1HRVJ5iqG49j2dq10k58IRfhAy2Vm4DbU6pHOC5brRKHQXDXvLHmgGau/F n5S8/8XNhLShhNjUxvrfBj79EJP2WoPxRwofNwwgOWyHw6YpaLht4QjUgd+daJWCAliU h0jOU3oRFtGEsWdk2KHs7Hr2BJesgPnKYad6O4d3awRuFhnqAPZfM8NazNHmwegfSCOi ccZO/QDTPqOuVM8pHmXrFxe+KPdfUqae+sphQO1ndg4ZGNyGDiZAch73pjJeXZqOPDjt ggAQ== X-Forwarded-Encrypted: i=1; AFNElJ+DXax/T5Ue8yZh7wj2Tsm4G7s0kQyOAisyL4twSN6vyJQxJs3uFTus5aUjPxtNXrLGc4aPRg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyfZnoj3Q9hWPF5f1f3rnkJEFWbSaJUK5PGXEbu/g4R1EX+Wv6d OoiKOPYztIybkIrYU8xoJKZTQMXN7WN3Q6B+z3AlArC0mqmT4RyIcI0HYdlfUTkc X-Gm-Gg: Acq92OFYpwQUw7aMPSoZnUoUcqmPDK+hmlM4pci8LocSorvV4bLLs/PcEFDhMdzQm7j y+NCG65N4KN7zqkICf60eQBvFszP+A6NJKqrFEPYxpwP9LpLA8V4XuPdHVIOuzVNx1x2Vom7nsK ZeSF/XPcpJhRn828tuYbWYKw21pgq0efaRcm7kSR29eVR5e1qd+54IJFPssUYFgYB6BFCQNjihr FqRc4snkp+obu10oYg0mMBD1+YFpMwEZG26Wek+aHa3DyhSJBBdFmjufc7VJ4MdT0AR6V9yUSx5 JPBoYg1HWMAVLsWtYIucRPKOi9lm/avVxBbtxxrFimfifiQkMz3R7yjr3IYD+q0r6ooU51DzF6+ yxIGTfG3+n5HKPuhzV9lOrihOdyMNxOQBbzGbh/wPu/FtLrg2GAh3mqx1gdiJzqKkaH/fqD8wKx JbeKVcOmQK+qwCwMbD2g== X-Received: by 2002:a17:907:1c23:b0:bc6:bb4b:1726 with SMTP id a640c23a62f3a-bd3ae842a8amr23963666b.22.1778614771057; Tue, 12 May 2026 12:39:31 -0700 (PDT) Received: from ars3 ([2a02:8109:8a95:9a00:a174:43ce:14f5:df5e]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bcf3226d77csm414939666b.26.2026.05.12.12.39.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2026 12:39:30 -0700 (PDT) From: Augusto Stoffel <arstoffel@HIDDEN> To: =?utf-8?Q?St=C3=A9phane?= Marks <shipmints@HIDDEN> Subject: Re: bug#80988: 31.0.50; Progress report (commit f5f2306fc1d) In-Reply-To: <CAN+1Hbp75M=crUsQPj3=UVbB4kEi9xg1k8fNR4mVuG3=1BftvQ@HIDDEN> References: <875x4yl7fm.fsf@HIDDEN> <CAN+1Hbrs_rFU35hBUaKa-AA7eaYZOmnPBMaw-Di5hDrCsd9uOA@HIDDEN> <878q9rquo1.fsf@HIDDEN> <CAN+1HbpJP7aWDioF1GSBHh0Bem8Od1_Ea_qJqoyx0+ptNaDaJg@HIDDEN> <CAN+1Hbq00c0WZnYuf_hatUweO3-0tGMJge1BQDpzmaQANbF3LA@HIDDEN> <87fr3xaztk.fsf@HIDDEN> <CAN+1Hbp75M=crUsQPj3=UVbB4kEi9xg1k8fNR4mVuG3=1BftvQ@HIDDEN> Date: Tue, 12 May 2026 21:39:29 +0200 Message-ID: <87qzngl8ni.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 80988 Cc: Stefan Monnier <monnier@HIDDEN>, 80988 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.0 (/) DQpPbiBUdWUsIDEyIE1heSAyMDI2LCBTdMOpcGhhbmUgTWFya3Mgd3JvdGU6DQoNCj4gQW55dGhp bmcgeW91IGNhbiBkaXNwbGF5IHVzaW5nIGEgdGV4dCBwcm9wZXJ0eSB3b3JrcyBpbmNsdWRpbmcg aW1hZ2VzLg0KPiBNb3JlIHNpbXBseSwgdGhlIGZvbGxvd2luZyBhcmUgdW5pY29kZSBjaGFycyB5 b3UgY2FuICJhbmltYXRlIiAob3IgdXNlDQo+IGVtb2ppcykgYW5kIHlvdSBjYW4gYWRkIGNvbG9y cyBvciBib2xkIG9yIHdoYXRldmVyOg0KPg0KPiAoc2V0cSBwcm9ncmVzcy1yZXBvcnRlci1wdWxz ZS1jaGFyYWN0ZXJzIGBbIuKWkuKWkeKWkeKWkeKWkeKWkSIgIuKWkeKWkuKWkeKWkeKWkeKWkSIg IuKWkeKWkeKWkuKWkeKWkeKWkSIgIuKWkeKWkeKWkeKWkuKWkeKWkSINCj4gIuKWkeKWkeKWkeKW keKWkuKWkSIgIuKWkeKWkeKWkeKWkeKWkeKWkiIgIuKWkeKWkeKWkeKWkeKWkuKWkSIgIuKWkeKW keKWkeKWkuKWkeKWkSIgIuKWkeKWkeKWkuKWkeKWkeKWkSIgIuKWkeKWkuKWkeKWkeKWkeKWkSJd KQ0KPg0KPiBJcyB0aGVyZSBzb21ldGhpbmcgeW91IGhhZCBpbiBtaW5kIGJleW9uZCB0aGlzIGZv ciBlY2hvLWFyZWEgcHJvZ3Jlc3MNCj4gcmVwb3J0cz8NCg0KWWVzLCBJIHdhcyB3b25kZXJpbmcg aWYgYWNjZXB0aW5nIGljb25zIGFzIHZlY3RvciBlbGVtZW50cyBpbnN0ZWFkIG9mDQpqdXN0IHN0 cmluZ3Mgd291bGQgbWFrZSBzZW5zZS4gIEJ1dCB0aGlzIGNvdWxkIGFsd2F5cyBiZSBkb25lIGxh dGVyLg0K
bug-gnu-emacs@HIDDEN:bug#80988; Package emacs.
Full text available.Received: (at 80988) by debbugs.gnu.org; 12 May 2026 10:40:01 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 12 06:40:01 2026 Received: from localhost ([127.0.0.1]:34268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1wMkWt-0005RH-Ct for submit <at> debbugs.gnu.org; Tue, 12 May 2026 06:40:00 -0400 Received: from mail-vk1-xa2d.google.com ([2607:f8b0:4864:20::a2d]:60833) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <shipmints@HIDDEN>) id 1wMkWp-0005PX-1Q for 80988 <at> debbugs.gnu.org; Tue, 12 May 2026 06:39:56 -0400 Received: by mail-vk1-xa2d.google.com with SMTP id 71dfb90a1353d-5751a9020faso3128762e0c.1 for <80988 <at> debbugs.gnu.org>; Tue, 12 May 2026 03:39:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1778582389; cv=none; d=google.com; s=arc-20240605; b=LSfJ/31S0ttmoQ5JQl1nd7rIkw5zEdE0thLLP2Zlw9iJVvLD7+IaiUWRFZEawtDALP xTWM4KnPoOtduh7X2VUOTFXDFo/lDfvMUETfR38UcvPfoBEwcZl/rxOEsKSoe07DI66t daXO5zH6NEiuZHatOp0XokxVIKqnbFOwRRZd8HiwBbjvelwtx0MHWUYcJUfSLnWVfSZu yri4x4cbq0JnCLTQuGzetOHHyXocQsXLY27/d2UZ1w+TDHv/J67+HGH5XJYBv8mruMR+ fVYdNbDn2NKvyiBFiBGpikOi5SkAHga11OIMmCOs6IVSOFlVLn7GTFrrm++n26kY6cev Pyhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=iZjJIZ7I68q4Pf0rTrT6AL9u/rsYOrX2Hu6JMM+gsKU=; fh=c3rCdiT+MoqjRrgqUEgZsnClYYApV0xWXNdSoWqlPk8=; b=Mh85fsEkbzojKnQQxnbYrEzQus/4xFrlHmSkiEpRDJ21sTbs+eCGpkL3Mm9p7zHrZm Cpkv3jkKNUb2eieH6d8FiWB1pJcm0zex/8LAPsF3G+oTQX20PQcNXK+9vOtnHDocaayV PaIgPWdPdadjEvnGTrVMV3CBhlhJK8qEuGVl86K1GK6K3hQX4ZOh+Pbc4c4yV7uBKluk xqwjWT6DtOXSAVOVcV9eSLFQVCsPXTf8+FqHRpu8ddRn/t72UOOTZkeU+gfricJxNQtt SOzOeBBEZ7Jfgx7R33sJv9lrMat8PnTGEebBhPZntWg2++FdHIunin7RpyhVBmYcWhG0 7VOg==; darn=debbugs.gnu.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778582389; x=1779187189; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=iZjJIZ7I68q4Pf0rTrT6AL9u/rsYOrX2Hu6JMM+gsKU=; b=eZ0j+r+A3HY9yrcmJ4DVEfwWtBQLZKpMzGcg/VHsXinj3uQ5zyRvZ2P0N2rDpAPb5e tHfMoItXHowI7c/3dcO7mb2ziZWtGfXXwf5vnvvdjvwxASXZ0yFa1iYYvJROw+2N8o73 9ivCqcpye/fvLWB8QXjZzrkxalfHZH8aUdI+YKo3IUO3hKNwOPGT4udhqBpvn+Tk9/1+ QryvoQOKb3vCkWHVOSz7ylsLTKx2LnBF/mp+Zc8DupuozPR0gHNKXWyQegUBMPLiSy/Z XNmyksD/ri3Ev5WmMhpR0Rbb/GIU9gssXWH+kNxYMUAb2ji9e3ahXyU66J0TblRz27be y4Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778582389; x=1779187189; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iZjJIZ7I68q4Pf0rTrT6AL9u/rsYOrX2Hu6JMM+gsKU=; b=BzzoyuZ8NHCSVzwMLDKjYQfgDeJoSSDp0rjQg6Br/xmiT7a1VS55AMqNnA19NqXiOY caKtPP9+mmzLTUiErkVzaXDC0pyg1RowWtMOjyV9vnEQJ0KaW99ZAnsUA94PRACV1s7z bV7dzUIx/wjGj4uKFluiIjXjerQfGm8LIiZATvHeRU6o1/flPOiIyWWIjGIadsnCiz/N vSQs9X8OfCFo02gEXTAwlY50OIlpngmgOCepzKvBGZiYnYpA5X3uvmtYPnm0jYdao8Ce htLtglU0e+NDoPAoSfk44YTOloKAmlaY4sx384EJyl6i83mtEEzCkxDaOdJDQT2difmL 5CeA== X-Forwarded-Encrypted: i=1; AFNElJ/8XxJS4rblDjDv6UDikmvCejOq25Vp84jvbH+MHn0/f7EXtyE03I1UII1SUXy/FQL9l7p7vA==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yzo9rTT3/qCEJo9+j6Hw4tA6str7q5yj8HrM7axJMmEVTk+t3GS 6vT6/XUVtFz+LvJV5/B0vikguOCYmiXb3Wyb+IbajChIdIz3U7boXdwFEoNvK1Kn1bnXK1SQhnu mHp/tAJf3wbPz4Ib/k+Ojs7Gq3G6/nz0= X-Gm-Gg: Acq92OHoeEYzzRijIAuouXka0zetcOEZSwbDdWDd+ZkQYCM3RKm3bRTIcEdZMeHM0u8 H120m5Vy4lKr3s4IoIvLFjvVSJzBCIZACNU5ohpUuS5ORbfH3/LrNqT4xvBebKxAzKrCxyOF54S OSPbZZBML3wYZ1VDJtGRYKEPfAAYR1GZeQWCXmIGVIw0GqNYHh8Z2rw9Bre0hFjmRWAgPKmnqhB idVkj+wVI2vkP7dfl/Hqc9QvCsoAQOo40QU5IslYPsB5Z+0gzOqHi/6auXAjl/1/GIuNehldX8J GC6Itcx7XNz31pOjS75uZ7NeWdGgwdV115EcZKFV6dpjM19T7tTpV2GVmYQpRBIxh5E/V747ggc XWnytL78m/KmFIc4HgBVL3L4/3Cz6xqGmrzW2yqr5TeIiM0E= X-Received: by 2002:a05:6102:3e10:b0:611:3bcb:aee5 with SMTP id ada2fe7eead31-630f8c42570mr13303982137.0.1778582389310; Tue, 12 May 2026 03:39:49 -0700 (PDT) MIME-Version: 1.0 References: <875x4yl7fm.fsf@HIDDEN> <CAN+1Hbrs_rFU35hBUaKa-AA7eaYZOmnPBMaw-Di5hDrCsd9uOA@HIDDEN> <878q9rquo1.fsf@HIDDEN> <CAN+1HbpJP7aWDioF1GSBHh0Bem8Od1_Ea_qJqoyx0+ptNaDaJg@HIDDEN> <CAN+1Hbq00c0WZnYuf_hatUweO3-0tGMJge1BQDpzmaQANbF3LA@HIDDEN> <87fr3xaztk.fsf@HIDDEN> In-Reply-To: <87fr3xaztk.fsf@HIDDEN> From: =?UTF-8?Q?St=C3=A9phane_Marks?= <shipmints@HIDDEN> Date: Tue, 12 May 2026 06:39:38 -0400 X-Gm-Features: AVHnY4KL8_KaklBGvasPiwAJQV4haLTSIRyvXQwrPvb-5oeA1HDuA8MLRkywQ_0 Message-ID: <CAN+1Hbp75M=crUsQPj3=UVbB4kEi9xg1k8fNR4mVuG3=1BftvQ@HIDDEN> Subject: Re: bug#80988: 31.0.50; Progress report (commit f5f2306fc1d) To: Augusto Stoffel <arstoffel@HIDDEN> Content-Type: multipart/alternative; boundary="00000000000084c68406519c7b7a" X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 80988 Cc: Stefan Monnier <monnier@HIDDEN>, 80988 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.0 (/) --00000000000084c68406519c7b7a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, May 12, 2026 at 2:48=E2=80=AFAM Augusto Stoffel <arstoffel@HIDDEN= m> wrote: > On Mon, 11 May 2026, St=C3=A9phane Marks wrote: > > > I did not take you patch verbatim as it missed several key details. > > > > I audited 'progress-reporter-update' calls across core and also many > ELPA packages > > and the only place that needed a change to accommodate is in > > 'system-taskbar--progress-reporter-update' which echoed the hard-code. > > Thanks! > > > I tested with change with the following alternative set of pulse > > characters, among others including just one and just two characters: > > > > (setq progress-reporter-pulse-characters ["=E2=86=90" "=E2=86=96" "= =E2=86=91" "=E2=86=97" "=E2=86=92" "=E2=86=98" "=E2=86=93" > "=E2=86=99"]) > > > > Though I seem to be partial to these: > > > > (setq progress-reporter-pulse-characters ["=E2=97=B4" "=E2=97=B7" "= =E2=97=B6" "=E2=97=B5"]) > > > > Patch attached. I leave it up to y'all to decide if this is minor > > enough for Emacs 31 as Augusto suggests or if it should be for 32. > > Just to be clear, the only thing I'm arguing really should be changed > right now for Emacs 31 is getting rid of the magic number 4. This magic > number was introduced during development of Emacs 31 (before that, it > was private information from progress-reporter--pulse-characters). > Might as well do both. Same code needs to be touched to get rid of 4 beyond just not mentioning 4 in the docstring. Renaming progress-reporter--pulse-characters seems safe enough. > However, I think it might make sense to accept images (say via > define-icon) instead of only characters, so maybe we should first think > that through and leave the renaming for later? > Anything you can display using a text property works including images. More simply, the following are unicode chars you can "animate" (or use emojis) and you can add colors or bold or whatever: (setq progress-reporter-pulse-characters `["=E2=96=92=E2=96=91=E2=96=91=E2= =96=91=E2=96=91=E2=96=91" "=E2=96=91=E2=96=92=E2=96=91=E2=96=91=E2=96=91=E2= =96=91" "=E2=96=91=E2=96=91=E2=96=92=E2=96=91=E2=96=91=E2=96=91" "=E2=96=91=E2=96=91=E2=96=91=E2=96=92=E2=96=91=E2=96=91" "=E2=96=91=E2=96= =91=E2=96=91=E2=96=91=E2=96=92=E2=96=91" "=E2=96=91=E2=96=91=E2=96=91=E2=96= =91=E2=96=91=E2=96=92" "=E2=96=91=E2=96=91=E2=96=91=E2=96=91=E2=96=92=E2=96= =91" "=E2=96=91=E2=96=91=E2=96=91=E2=96=92=E2=96=91=E2=96=91" "=E2=96=91=E2= =96=91=E2=96=92=E2=96=91=E2=96=91=E2=96=91" "=E2=96=91=E2=96=92=E2=96=91=E2= =96=91=E2=96=91=E2=96=91"]) Is there something you had in mind beyond this for echo-area progress reports? --00000000000084c68406519c7b7a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon= t-family:monospace"><span style=3D"font-family:Arial,Helvetica,sans-serif">= On Tue, May 12, 2026 at 2:48=E2=80=AFAM Augusto Stoffel <<a href=3D"mail= to:arstoffel@HIDDEN">arstoffel@HIDDEN</a>> wrote:</span></div></di= v><div class=3D"gmail_quote gmail_quote_container"><blockquote class=3D"gma= il_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,2= 04,204);padding-left:1ex">On Mon, 11 May 2026, St=C3=A9phane Marks wrote:<b= r> <br> > I did not take you patch verbatim as it missed several key details.<br= > ><br> > I audited 'progress-reporter-update' calls across core and als= o many ELPA packages<br> > and the only place that needed a change to accommodate is in<br> > 'system-taskbar--progress-reporter-update' which echoed the ha= rd-code.<br> <br> Thanks!<br> <br> > I tested with change with the following alternative set of pulse<br> > characters, among others including just one and just two characters:<b= r> ><br> >=C2=A0 =C2=A0(setq progress-reporter-pulse-characters ["=E2=86=90&= quot; "=E2=86=96" "=E2=86=91" "=E2=86=97" &qu= ot;=E2=86=92" "=E2=86=98" "=E2=86=93" "=E2=86= =99"])<br> ><br> > Though I seem to be partial to these:<br> ><br> >=C2=A0 =C2=A0(setq progress-reporter-pulse-characters ["=E2=97=B4&= quot; "=E2=97=B7" "=E2=97=B6" "=E2=97=B5"])<b= r> ><br> > Patch attached.=C2=A0 I leave it up to y'all to decide if this is = minor<br> > enough for Emacs 31 as Augusto suggests or if it should be for 32.<br> <br> Just to be clear, the only thing I'm arguing really should be changed<b= r> right now for Emacs 31 is getting rid of the magic number 4.=C2=A0 This mag= ic<br> number was introduced during development of Emacs 31 (before that, it<br> was private information from progress-reporter--pulse-characters).<br></blo= ckquote><div><br></div><div class=3D"gmail_default" style=3D"font-family:mo= nospace">Might as well do both.=C2=A0 Same code needs to be touched to get = rid of 4 beyond just not mentioning 4 in the docstring.</div><div class=3D"= gmail_default" style=3D"font-family:monospace"><br></div><blockquote class= =3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg= b(204,204,204);padding-left:1ex"> Renaming progress-reporter--pulse-characters seems safe enough.<br> However, I think it might make sense to accept images (say via<br> define-icon) instead of only characters, so maybe we should first think<br> that through and leave the renaming for later?<br></blockquote><div><br></d= iv><div><div class=3D"gmail_default" style=3D"font-family:monospace">Anythi= ng you can display using a text property works including images.=C2=A0 More= simply, the following are unicode chars you can "animate" (or us= e emojis) and you can add colors or bold or whatever:</div><br></div><font = face=3D"monospace">(<span class=3D"gmail_default" style=3D""></span>s<span = class=3D"gmail_default" style=3D"">etq</span> progress-reporter-pulse-chara= cters <span class=3D"gmail_default" style=3D"">`</span>["=E2=96=92=E2= =96=91=E2=96=91=E2=96=91=E2=96=91=E2=96=91" "=E2=96=91=E2=96=92= =E2=96=91=E2=96=91=E2=96=91=E2=96=91" "=E2=96=91=E2=96=91=E2=96= =92=E2=96=91=E2=96=91=E2=96=91" "=E2=96=91=E2=96=91=E2=96=91=E2= =96=92=E2=96=91=E2=96=91" "=E2=96=91=E2=96=91=E2=96=91=E2=96=91= =E2=96=92=E2=96=91"=C2=A0"=E2=96=91=E2=96=91=E2=96=91=E2=96=91=E2= =96=91=E2=96=92"=C2=A0"=E2=96=91=E2=96=91=E2=96=91=E2=96=91=E2=96= =92=E2=96=91" "=E2=96=91=E2=96=91=E2=96=91=E2=96=92=E2=96=91=E2= =96=91" "=E2=96=91=E2=96=91=E2=96=92=E2=96=91=E2=96=91=E2=96=91&q= uot; "=E2=96=91=E2=96=92=E2=96=91=E2=96=91=E2=96=91=E2=96=91"])</= font></div><div class=3D"gmail_quote gmail_quote_container"><font face=3D"m= onospace"><br></font></div><div class=3D"gmail_quote gmail_quote_container"= ><font face=3D"monospace"><span class=3D"gmail_default" style=3D"font-famil= y:monospace">Is there something you had in mind beyond this for echo-area p= rogress reports?</span><br></font><div><font face=3D"monospace">=C2=A0</fon= t></div></div></div> --00000000000084c68406519c7b7a--
bug-gnu-emacs@HIDDEN:bug#80988; Package emacs.
Full text available.Received: (at 80988) by debbugs.gnu.org; 12 May 2026 06:48:15 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 12 02:48:14 2026 Received: from localhost ([127.0.0.1]:33578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1wMgub-0006kv-1Y for submit <at> debbugs.gnu.org; Tue, 12 May 2026 02:48:14 -0400 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]:46253) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <arstoffel@HIDDEN>) id 1wMguY-0006kY-TH for 80988 <at> debbugs.gnu.org; Tue, 12 May 2026 02:48:11 -0400 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-488af96f6b2so61065075e9.0 for <80988 <at> debbugs.gnu.org>; Mon, 11 May 2026 23:48:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778568489; x=1779173289; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=fvTo+3JrZbmXGN+Sa9zaZCTTNj2+zuOWzKNL2dQJqd0=; b=RmUx+SI0IpAjthbsuJukRm6BqDpWgadr0DAkVrPNlrTTFahW9wfEt4Y8lEdFAS0R5F gtej6Fk9Zx8g5XZ+Gw6ja1AFgy5L6+P2ANEC+96J2AMJuGntEXKNsySRMOzLbC7gJrPx xuzac3VaPEsYY0UMbcBavqQxmzobLK4UOpMd7Rc422hvnv1xXgQ5WQ4AcDt157Su/QK/ lUeSNGCDKwRTMNZDehaG+ZtJ/5dEeHewMIqtdzoRbdkK7H7ZToxgy0OfHr5lAB00xiIW +Tl3tRajRtSqCo8EBDvkVkbGUtaucHZevKMKVmt5dhIeYQKRfkDspqLlsmtvQjYbiD1E XsbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778568489; x=1779173289; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=fvTo+3JrZbmXGN+Sa9zaZCTTNj2+zuOWzKNL2dQJqd0=; b=eIrcHMDINSiGeFj2OL+oUe+1CzvtN6vMvVKdhEUDJXOuqrMIZq314AaSa0dj1Ds4G3 t/M5eVnuHusN8J09tbQCbXLBJWJxMj4AKBWV2rKNA2OhBlLOsUDWCeuquUB2L84DUlS1 nPY2nhN+b2T+gZJyPYwyrUkqPSdPqwFG2/OlgTmxgJQZxbJ+hBIk1ZkQNFOKBvSzQB/L Ijxb5aPpN8lkRvpl6sTMyOZ1o4FuTfD16+1mmagOwala4PAnR90almWAFehirmiVZQuT zPYAWteUkbx1jbpB3kRgvyYXuLI+QxeuiTU4lcBtVH6p8BFN3g9sW8y58fcuYVwOqBrq Mw0A== X-Forwarded-Encrypted: i=1; AFNElJ9oAxZlQ/CBcl338oRTD0yXvFE8EiCIH8dRAPo6aOPXEEhfbM4w0tezKa54ALszhPvv3cVjEA==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yw8IMCh+7jKR8lNDa+E81/m4aMq/jLAHrv/ooXuqjle94jY6EUz 2vCtWEnhN/jPVOFCrroNl9LUwuV4If8EBaLiAK8rRFCx8zxOL63XP6VITGPy8A== X-Gm-Gg: Acq92OE/WiZOc/eCXCfxaQDtzbaIsjPNkkAosboY8kDCF8eS31YnMBM8pJnWA3hOvsy lQbynKKHKqVKhV9hhQD09cIfwUBMViQTPeKwYUfS82aABEJrwDmtBsUOGSEp2SsxkiS82nwaSM0 8MVBmNfZaQFj0Ip3F/k4onfSxg76gH4KIG70Enjz2DxhgK9AqOStT43rE+O87X3VK6Sk4wuHISg cZxZavMP8rpbn3LZWb5PSSJT7w71SnBbCJ8tKLGv4P0OEgQHeLS0P2bUzO3C9UiAqlqT6NndKis sAAY8iWYXImNtX29ke5bxZlI0pbIjFbtykDOCxy+Ribx/LVGHy5Bj6+L2ExBInOibhBTJVZOBGX e0xQQwJFoHUwve+mJE4FCHvM4gWhRkWCPh9vViwcT49qLeyyVABowLht+yn3eomwOF3XKwF69dE kiM3b8h9xEglOGfS6U0A== X-Received: by 2002:a05:600c:3507:b0:489:1b0c:8b43 with SMTP id 5b1f17b1804b1-48e706ad0e5mr195170095e9.1.1778568488946; Mon, 11 May 2026 23:48:08 -0700 (PDT) Received: from ars3 ([2a02:8109:8a95:9a00:a174:43ce:14f5:df5e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e8f43de84sm10745875e9.26.2026.05.11.23.48.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2026 23:48:08 -0700 (PDT) From: Augusto Stoffel <arstoffel@HIDDEN> To: =?utf-8?Q?St=C3=A9phane?= Marks <shipmints@HIDDEN> Subject: Re: bug#80988: 31.0.50; Progress report (commit f5f2306fc1d) In-Reply-To: <CAN+1Hbq00c0WZnYuf_hatUweO3-0tGMJge1BQDpzmaQANbF3LA@HIDDEN> References: <875x4yl7fm.fsf@HIDDEN> <CAN+1Hbrs_rFU35hBUaKa-AA7eaYZOmnPBMaw-Di5hDrCsd9uOA@HIDDEN> <878q9rquo1.fsf@HIDDEN> <CAN+1HbpJP7aWDioF1GSBHh0Bem8Od1_Ea_qJqoyx0+ptNaDaJg@HIDDEN> <CAN+1Hbq00c0WZnYuf_hatUweO3-0tGMJge1BQDpzmaQANbF3LA@HIDDEN> Date: Tue, 12 May 2026 08:48:07 +0200 Message-ID: <87fr3xaztk.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 80988 Cc: Stefan Monnier <monnier@HIDDEN>, 80988 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.0 (/) On Mon, 11 May 2026, St=C3=A9phane Marks wrote: > I did not take you patch verbatim as it missed several key details. > > I audited 'progress-reporter-update' calls across core and also many ELPA= packages > and the only place that needed a change to accommodate is in > 'system-taskbar--progress-reporter-update' which echoed the hard-code. Thanks! > I tested with change with the following alternative set of pulse > characters, among others including just one and just two characters: > > (setq progress-reporter-pulse-characters ["=E2=86=90" "=E2=86=96" "=E2= =86=91" "=E2=86=97" "=E2=86=92" "=E2=86=98" "=E2=86=93" "=E2=86=99"]) > > Though I seem to be partial to these: > > (setq progress-reporter-pulse-characters ["=E2=97=B4" "=E2=97=B7" "=E2= =97=B6" "=E2=97=B5"]) > > Patch attached. I leave it up to y'all to decide if this is minor > enough for Emacs 31 as Augusto suggests or if it should be for 32. Just to be clear, the only thing I'm arguing really should be changed right now for Emacs 31 is getting rid of the magic number 4. This magic number was introduced during development of Emacs 31 (before that, it was private information from progress-reporter--pulse-characters). Renaming progress-reporter--pulse-characters seems safe enough. However, I think it might make sense to accept images (say via define-icon) instead of only characters, so maybe we should first think that through and leave the renaming for later?
bug-gnu-emacs@HIDDEN:bug#80988; Package emacs.
Full text available.Received: (at 80988) by debbugs.gnu.org; 11 May 2026 21:21:18 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 11 17:21:18 2026 Received: from localhost ([127.0.0.1]:54402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1wMY3x-0004wG-0y for submit <at> debbugs.gnu.org; Mon, 11 May 2026 17:21:18 -0400 Received: from mail-vs1-xe33.google.com ([2607:f8b0:4864:20::e33]:44080) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <shipmints@HIDDEN>) id 1wMY3s-0004vT-Ri for 80988 <at> debbugs.gnu.org; Mon, 11 May 2026 17:21:14 -0400 Received: by mail-vs1-xe33.google.com with SMTP id ada2fe7eead31-6314d2e31d6so991849137.0 for <80988 <at> debbugs.gnu.org>; Mon, 11 May 2026 14:21:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1778534472; cv=none; d=google.com; s=arc-20240605; b=HAYOyo+LIqGDUM9MR+i9XG3mpWDu8OYoTj+lQRua9h6jhHhuPKo5tmcSxoIB8lJ3BW McIb3K5cUVg+/prruZim6idJNJrcKCUVQTbIy0y3d3plTfmk1lzLk8/h4TFdQr/MoAHj LDDVZoQaAAmHwwxrwqpCqLgamq/dl4zi/XeZZ4x1AZ0n8X6z9QDwf7XJlYMVdzj6X5PZ NfQuM+u2JrEFHtYfflCiZes3YkxU1AVNOaAyvBY3W5GbQqwlZrR0JCqv31NXR0CKyGsB byBtBRrb6xMUKgdFX0YqhRRdwX5EAFjSennY24dim2t4jnvrfXCqibAIitDmjCQ2kqaN fwnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=LRSrGkIojDhcNCgwMFZk/gGzgDcWzJ9O3eulqfpsBfA=; fh=1YFoGyBlIfeAVoYb7R2yz06OIVTG1Y4FanVFCA2CIRI=; b=T0wY2H/Y0t7WU/4IY7gNOCVME5mb0Ja05DWkb8fOzlL6MSkHv5q+8UvM21s1YKsecf QAVy1+CMozHtYqpEnkL3VBpYkUpZXVtM3GL8sBQYCUqt41RCbRCoutl9HFBQISMt5xI0 WPb52Vm97JZgKJzQl6r8DS30dVdPv1H7AaYvk5pjCWIck+al9IdWJUL6v+vXZniGHtbY QXZgZjqGrsqM3tAYKTiQIwHvnacM0sZoknDy1kpYj1I7IKwPME30OI5lJG4MZVjtS92E JKde4Mhki8TMeiN9sLf5HpXsG0DmTFyrZBXFykkIAihIQPcTKTxgkrpXQipPFxnIUQJ/ Gafw==; darn=debbugs.gnu.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778534472; x=1779139272; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=LRSrGkIojDhcNCgwMFZk/gGzgDcWzJ9O3eulqfpsBfA=; b=GI+Qr24Q9zmth+Gtv1QIS6KzgIjVKol9hLZ8aEu6oNchbqCIboeKoWfdeAQ2xvsNHL AN/25FZgw5nZYhZu/kESISFs2rcNgPs3ETvZ+QWlTeZvb46vhTNMFYLgWLK+eZe0usaM 1avnqxG6+Af+vHo/GksDDLIC/CszdqqBo2Z5beQxxbm7wvg4c7TOacj0FsD2ZDFAHJBC rvzFGWpU99uIRkvTTQiCuG9wVwMJF2xVzUzlA9HRxHcbBNZzMBiNdUkkTtbPjB5FA289 EqvXercCOHuXqQjxgaLaWVGDILyp/BkJhXc9A/5CBzGcgzkdUqizoLgO9AIlpvl9DjEi fpsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778534472; x=1779139272; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LRSrGkIojDhcNCgwMFZk/gGzgDcWzJ9O3eulqfpsBfA=; b=AZcjPUk+88br/sAlImR5KM2hpLqruS59yhmVSIQp//C5HOJuXxsS2sy/MTIsL9vNZY prriIBM5wOwJsB+1fN8JFv77RniJ2JX7hZyhwV2gHnStAlp/lyhATL44q5aXLFkueQwh +NHSI12V8eo9Ttirn1RTZRpXGA+4y1SmyLQh3PMFHk8mlOuNd1g6NdANIHNUmQXnXqUA G93p4xqMRE7q4tqtbE5zp5P7nqyaKXi8Zk9uLePd1XfVjSl99HfIc4ETAbS5syexnLyd enI3jWzKW4kXUDXMDq8uVz9lENWX4+by2oi+pmOjeDT2hB5jZ98CPFQnbTYpRupbXr05 Lwmw== X-Forwarded-Encrypted: i=1; AFNElJ9mr1CIL8bDCAxto/w/0wdytue5jhf3ZmBQRfQ0PVzJ4Ff6p6olYkXrHYc+twFeOLIsALUbYw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwlIftPrCrML1M1WqbQW9r1bx2qqA1p4xuNPwW5QZncKoHmVqrh N77vjD7OludzzHlhTKjKkewJrcLwp0FMORxhpgmbc83Q1CGHZYijSM8SpKWXstVs64X55eX/SQ6 jS0b252+69YZdfLgxXF+6IKFfOctUsZc= X-Gm-Gg: Acq92OHMvO+3yPrZtvZjXRSJPED1unSZ/oRDb3j1Y+pP119iSUECh5O5/5/ytMygL6G +repWuCRVmwVZjEDJIxWQ6GhHUPp0iaHQaL30y11Qy038A2n8AJ9cTv9tA8JCmAyVmuUb3BjEzh NWN/jeh54vYeIpvgXExwlsMu/SAnBmZq0dXNz9x/sCowOVNnXNiRKwFaDgK2E2jnvHhxkNRaFUh /4KMLccqFM5kPKvACJZr6/KUqjb9Je+YpbmM9p2aG9zohGgEPphB/vANy+CU0i9MLka2xq42o7H PRk8p1kqqauSWz+g8C9vKgsMixNxc2IxdDhT53n6eQqLM75O5D8jj+N1VnsAuKr+anunzLozCTj d0paxSU0A7jhWL2rO3OGdStsbFi2PEwNT3aj2oqYLdzpN6ZQ= X-Received: by 2002:a05:6102:a53:b0:631:2d7a:b18a with SMTP id ada2fe7eead31-6313eb828f3mr1296960137.31.1778534471756; Mon, 11 May 2026 14:21:11 -0700 (PDT) MIME-Version: 1.0 References: <875x4yl7fm.fsf@HIDDEN> <CAN+1Hbrs_rFU35hBUaKa-AA7eaYZOmnPBMaw-Di5hDrCsd9uOA@HIDDEN> <878q9rquo1.fsf@HIDDEN> <CAN+1HbpJP7aWDioF1GSBHh0Bem8Od1_Ea_qJqoyx0+ptNaDaJg@HIDDEN> In-Reply-To: <CAN+1HbpJP7aWDioF1GSBHh0Bem8Od1_Ea_qJqoyx0+ptNaDaJg@HIDDEN> From: =?UTF-8?Q?St=C3=A9phane_Marks?= <shipmints@HIDDEN> Date: Mon, 11 May 2026 17:20:59 -0400 X-Gm-Features: AVHnY4JQ9env6lUKFljVHg7jGJ9cT_0yCe-W8QVEpVBc2B6Gho-GDYFHenPjRO0 Message-ID: <CAN+1Hbq00c0WZnYuf_hatUweO3-0tGMJge1BQDpzmaQANbF3LA@HIDDEN> Subject: Re: bug#80988: 31.0.50; Progress report (commit f5f2306fc1d) To: Augusto Stoffel <arstoffel@HIDDEN> Content-Type: multipart/mixed; boundary="000000000000691a6e0651915303" X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 80988 Cc: Stefan Monnier <monnier@HIDDEN>, 80988 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.0 (/) --000000000000691a6e0651915303 Content-Type: multipart/alternative; boundary="000000000000691a6d0651915301" --000000000000691a6d0651915301 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, May 11, 2026 at 1:16=E2=80=AFPM St=C3=A9phane Marks <shipmints@gmai= l.com> wrote: > On Sun, May 10, 2026 at 9:08=E2=80=AFAM Augusto Stoffel <arstoffel@gmail.= com> > wrote: > >> >> > Nothing is special about 4 and nothing is special about the characters >> > other than that change was the smallest backward compatible change >> > vs. the original code. Patches often get scrutinized for size and >> > scope of change and even some people complain when whitespace changes >> > because things get indented when code is added. >> >> Well, before this commit the magic 4 was standing for the length of >> progress-reporter--pulse-characters, which is presumably internal >> information. But now it has become official and documented in a >> docstring. So I don't see this as a consequence of any minimality >> requirement for the change. >> >> Anyway. I really think this (i.e., get rid of the magic 4, make STATE >> an ever-increasing sequence) should be changed for Emacs 31, since after >> the release it will really become official. >> > > +list > > The function 'system-taskbar--progress-reporter-update' will also need to > be patched to not refer to 4 and either use the vector's length. > > I will audit the rest of core to see where else. > > We could create a "public" defvar/alias for ' > progress-reporter--pulse-characters' if it's something you want to > replace with your own vector. I think a defcustom is going too far for > most people (plus, subr.el is I think too early for defcustom's in the > startup sequence). > I did not take you patch verbatim as it missed several key details. I audited 'progress-reporter-update' calls across core and also many ELPA packages and the only place that needed a change to accommodate is in 'system-taskbar--progress-reporter-update' which echoed the hard-code. I tested with change with the following alternative set of pulse characters, among others including just one and just two characters: (setq progress-reporter-pulse-characters ["=E2=86=90" "=E2=86=96" "=E2=86= =91" "=E2=86=97" "=E2=86=92" "=E2=86=98" "=E2=86=93" "=E2=86=99"]) Though I seem to be partial to these: (setq progress-reporter-pulse-characters ["=E2=97=B4" "=E2=97=B7" "=E2=97= =B6" "=E2=97=B5"]) Patch attached. I leave it up to y'all to decide if this is minor enough for Emacs 31 as Augusto suggests or if it should be for 32. -St=C3=A9phane --000000000000691a6d0651915301 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon= t-family:monospace"><span style=3D"font-family:Arial,Helvetica,sans-serif">= On Mon, May 11, 2026 at 1:16=E2=80=AFPM St=C3=A9phane Marks <<a href=3D"= mailto:shipmints@HIDDEN">shipmints@HIDDEN</a>> wrote:</span></div>= </div><div class=3D"gmail_quote gmail_quote_container"><blockquote class=3D= "gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(2= 04,204,204);padding-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr"><div style= =3D"font-family:monospace"><span style=3D"font-family:Arial,Helvetica,sans-= serif">On Sun, May 10, 2026 at 9:08=E2=80=AFAM Augusto Stoffel <<a href= =3D"mailto:arstoffel@HIDDEN" target=3D"_blank">arstoffel@HIDDEN</a>&g= t; wrote:</span></div></div><div class=3D"gmail_quote"><blockquote class=3D= "gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(2= 04,204,204);padding-left:1ex"><br> > Nothing is special about 4 and nothing is special about the characters= <br> > other than that change was the smallest backward compatible change<br> > vs. the original code.=C2=A0 Patches often get scrutinized for size an= d<br> > scope of change and even some people complain when whitespace changes<= br> > because things get indented when code is added.<br> <br> Well, before this commit the magic 4 was standing for the length of<br> progress-reporter--pulse-characters, which is presumably internal<br> information.=C2=A0 But now it has become official and documented in a<br> docstring.=C2=A0 So I don't see this as a consequence of any minimality= <br> requirement for the change.<br> <br> Anyway.=C2=A0 I really think this (i.e., get rid of the magic 4, make STATE= <br> an ever-increasing sequence) should be changed for Emacs 31, since after<br= > the release it will really become official.<br></blockquote><div><br></div>= <div><div style=3D"font-family:monospace"><a class=3D"gmail_plusreply" id= =3D"m_-1201930124696772388plusReplyChip-5">+list</a><a class=3D"gmail_plusr= eply"><br></a></div><br></div><div><font face=3D"monospace">The function <s= pan class=3D"gmail_default" style=3D"font-family:monospace">'</span>sys= tem-taskbar--progress-reporter-update<span class=3D"gmail_default" style=3D= "font-family:monospace">'</span> will also need to be patched to not re= fer to 4<span class=3D"gmail_default" style=3D"font-family:monospace"> and = either use the vector's length</span>.</font></div><div><font face=3D"m= onospace"><span class=3D"gmail_default" style=3D"font-family:monospace"><br= ></span></font></div><div><font face=3D"monospace"><span class=3D"gmail_def= ault" style=3D"font-family:monospace">I will</span><span class=3D"gmail_def= ault" style=3D"font-family:monospace">=C2=A0</span>audit the rest of <span = class=3D"gmail_default" style=3D"font-family:monospace">core</span><span cl= ass=3D"gmail_default" style=3D"font-family:monospace">=C2=A0</span><span cl= ass=3D"gmail_default" style=3D"font-family:monospace">to see where else.</s= pan></font></div><div><font face=3D"monospace"><span class=3D"gmail_default= "><br></span></font></div><div><font face=3D"monospace"><span class=3D"gmai= l_default">We could create a "public" defvar/alias for '</spa= n>progress-reporter--pulse-characters<span class=3D"gmail_default">' if= it's something you want to replace with your own vector.=C2=A0 I think= a defcustom is going too far for most people (plus, subr.el is I think too= early for defcustom's in the startup sequence).</span></font></div></d= iv></div></blockquote><div><br></div><div><div class=3D"gmail_default" styl= e=3D"font-family:monospace">I did not take you patch verbatim as it missed = several key details.</div><div class=3D"gmail_default" style=3D"font-family= :monospace"><br></div><div class=3D"gmail_default" style=3D"font-family:mon= ospace">I audited 'progress-reporter-update' calls across core and = also many ELPA packages and the only place that needed a change to accommod= ate is in 'system-taskbar--progress-reporter-update' which echoed t= he hard-code.</div></div><div><br></div><div><div class=3D"gmail_default" s= tyle=3D"font-family:monospace">I tested with change with the following alte= rnative set of pulse characters, among others including just one and just t= wo characters:</div></div><div><br></div><font face=3D"monospace"><span cla= ss=3D"gmail_default" style=3D"font-family:monospace">=C2=A0=C2=A0</span>(<s= pan class=3D"gmail_default" style=3D"font-family:monospace"></span>s<span c= lass=3D"gmail_default" style=3D"font-family:monospace">etq</span> progress-= reporter-pulse-characters ["=E2=86=90" "=E2=86=96" &quo= t;=E2=86=91" "=E2=86=97" "=E2=86=92" "=E2=86= =98" "=E2=86=93" "=E2=86=99"])</font></div><div cl= ass=3D"gmail_quote gmail_quote_container"><font face=3D"monospace"><br></fo= nt></div><div class=3D"gmail_quote gmail_quote_container"><font face=3D"mon= ospace"><span class=3D"gmail_default" style=3D"">Though I seem to be partia= l to these:</span><br></font></div><div class=3D"gmail_quote gmail_quote_co= ntainer"><font face=3D"monospace"><span class=3D"gmail_default" style=3D"">= <br></span></font></div><div class=3D"gmail_quote gmail_quote_container"><f= ont face=3D"monospace"><span class=3D"gmail_default" style=3D"">=C2=A0=C2= =A0</span>(setq progress-reporter-pulse-characters ["=E2=97=B4" &= quot;=E2=97=B7" "=E2=97=B6" "=E2=97=B5"])<span cla= ss=3D"gmail_default" style=3D""></span></font></div><div class=3D"gmail_quo= te gmail_quote_container"><font face=3D"monospace"><br></font></div><div cl= ass=3D"gmail_quote gmail_quote_container"><font face=3D"monospace"><span cl= ass=3D"gmail_default" style=3D"font-family:monospace">Patch attached.=C2=A0= I leave it up to y'all to decide if this is minor enough for Emacs 31 = as Augusto suggests or if it should be for 32.</span><br></font></div><div = class=3D"gmail_quote gmail_quote_container"><font face=3D"monospace"><span = class=3D"gmail_default" style=3D"font-family:monospace"><br></span></font><= /div><div class=3D"gmail_quote gmail_quote_container"><font face=3D"monospa= ce"><span class=3D"gmail_default" style=3D"font-family:monospace">-St=C3=A9= phane</span></font></div><div class=3D"gmail_quote gmail_quote_container"><= font face=3D"monospace"><br></font></div><div class=3D"gmail_quote gmail_qu= ote_container"><font face=3D"monospace"><br><br></font><div>=C2=A0</div></d= iv></div> --000000000000691a6d0651915301-- --000000000000691a6e0651915303 Content-Type: application/octet-stream; name="0001-Improve-pulsing-progress-reporter-characters-bug-809.patch" Content-Disposition: attachment; filename="0001-Improve-pulsing-progress-reporter-characters-bug-809.patch" Content-Transfer-Encoding: base64 Content-ID: <f_mp1pglv70> X-Attachment-Id: f_mp1pglv70 RnJvbSAzMTJjYjVhZTU0YmQzNWE0YmIwMzRhMjM5YzNlNmQwYjY0Mzc4YzhmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/U3Q9QzM9QTlwaGFuZT0yME1hcmtzPz0gPHNo aXBtaW50c0BnbWFpbC5jb20+CkRhdGU6IE1vbiwgMTEgTWF5IDIwMjYgMTc6MTE6MzkgLTA0MDAK U3ViamVjdDogW1BBVENIXSBJbXByb3ZlIHB1bHNpbmcgcHJvZ3Jlc3MtcmVwb3J0ZXIgY2hhcmFj dGVycyAoYnVnIzgwOTg4KQoKKiBsaXNwL3N1YnIuZWwgKHByb2dyZXNzLXJlcG9ydGVyLS1wdWxz ZS1jaGFyYWN0ZXJzKTogT2Jzb2xldGUKYnkgJ3Byb2dyZXNzLXJlcG9ydGVyLXB1bHNlLWNoYXJh Y3RlcnMnLgoocHJvZ3Jlc3MtcmVwb3J0ZXItdXBkYXRlLWZ1bmN0aW9ucyk6IFVwZGF0ZSBkb2Nz dHJpbmcuCihwcm9ncmVzcy1yZXBvcnRlci1lY2hvLWFyZWEsIHByb2dyZXNzLXJlcG9ydGVyLWRv LXVwZGF0ZSk6ClJlbW92ZSBoYXJkLWNvZGVkIGRpdmlzb3IuCioKbGlzcC9zeXN0ZW0tdGFza2Jh ci5lbCAoc3lzdGVtLXRhc2tiYXItLXByb2dyZXNzLXJlcG9ydGVyLXVwZGF0ZSk6ClJlbW92ZSBo YXJkLWNvZGVkIGRpdmlzb3IuCiogZXRjL05FV1M6IEFubm91bmNlIHRoZSBjaGFuZ2UuCi0tLQog ZXRjL05FV1MgICAgICAgICAgICAgICB8ICA5ICsrKysrKysrKwogbGlzcC9zdWJyLmVsICAgICAg ICAgICB8IDIzICsrKysrKysrKysrKysrKy0tLS0tLS0tCiBsaXNwL3N5c3RlbS10YXNrYmFyLmVs IHwgIDUgKysrKy0KIDMgZmlsZXMgY2hhbmdlZCwgMjggaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9ldGMvTkVXUyBiL2V0Yy9ORVdTCmluZGV4IDczYTRhZDcyMTgw Li4yNDc3NTY3OWJmMiAxMDA2NDQKLS0tIGEvZXRjL05FV1MKKysrIGIvZXRjL05FV1MKQEAgLTQ1 LDYgKzQ1LDE1IEBAIGFwcGxpZXMsIGFuZCBwbGVhc2UgYWxzbyB1cGRhdGUgZG9jc3RyaW5ncyBh cyBuZWVkZWQuCiAMCiAqIExpc3AgQ2hhbmdlcyBpbiBFbWFjcyAzMi4xCiAKKworKiogUHJvZ3Jl c3MgcmVwb3J0ZXIKKworLS0tCisqKiogUmVuYW1lZCB2YXJpYWJsZSAncHJvZ3Jlc3MtcmVwb3J0 ZXItcHVsc2UtY2hhcmFjdGVycycuCitUaGUgdmFyaWFibGUgJ3Byb2dyZXNzLXJlcG9ydGVyLS1w dWxzZS1jaGFyYWN0ZXJzJyBpcyBvYnNvbGV0ZWQgYnkKKydwcm9ncmVzcy1yZXBvcnRlci1wdWxz ZS1jaGFyYWN0ZXJzJy4gIFlvdSBjYW4gcmVwbGFjZSB0aGlzIHdpdGggYQordmVjdG9yIGNoYXJh Y3RlcnMgeW91IGNob29zZS4gIFdlIHJlY29tbWVuZCBhdCBsZWFzdCBmb3VyIGNoYXJhY3RlcnMu CisKIC0tLQogKiogTmV3IHZhcmlhYmxlICdjb21wbGV0aW9uLWZyb250ZW5kLXByb3BlcnRpZXMn LgogVGhpcyB2YXJpYWJsZSBnZW5lcmFsaXplcyB0aGUgJ2NvbXBsZXRpb24tbGF6eS1oaWxpdCcg dmFyaWFibGUgYWRkZWQgaW4KZGlmZiAtLWdpdCBhL2xpc3Avc3Vici5lbCBiL2xpc3Avc3Vici5l bAppbmRleCBkOTc1OThhYjYxZi4uYWZiNGMxNDQwNTAgMTAwNjQ0Ci0tLSBhL2xpc3Avc3Vici5l bAorKysgYi9saXNwL3N1YnIuZWwKQEAgLTcxMDcsNiArNzEwNywxMyBAQCBzZXQtdHJhbnNpZW50 LW1hcAogOzsgZGlnaXRzIG9mIHByZWNpc2lvbiwgaXQgZG9lc24ndCByZWFsbHkgbWF0dGVyIGhl cmUuICBPbiB0aGUgb3RoZXIKIDs7IGhhbmQsIGl0IGdyZWF0bHkgc2ltcGxpZmllcyB0aGUgY29k ZS4KIAorKGRlZmluZS1vYnNvbGV0ZS12YXJpYWJsZS1hbGlhcworICAncHJvZ3Jlc3MtcmVwb3J0 ZXItLXB1bHNlLWNoYXJhY3RlcnMKKyAgJ3Byb2dyZXNzLXJlcG9ydGVyLXB1bHNlLWNoYXJhY3Rl cnMgIjMyLjEiKQorCisoZGVmdmFyIHByb2dyZXNzLXJlcG9ydGVyLXB1bHNlLWNoYXJhY3RlcnMg WyItIiAiXFwiICJ8IiAiLyJdCisgICJDaGFyYWN0ZXJzIHRvIHVzZSBmb3IgcHVsc2luZyBwcm9n cmVzcyByZXBvcnRlcnMuIikKKwogKGRlZnZhciBwcm9ncmVzcy1yZXBvcnRlci11cGRhdGUtZnVu Y3Rpb25zIChsaXN0ICMncHJvZ3Jlc3MtcmVwb3J0ZXItZWNoby1hcmVhKQogICAiU3BlY2lhbCBo b29rIHJ1biBvbiBwcm9ncmVzcy1yZXBvcnRlciB1cGRhdGVzLgogRWFjaCBmdW5jdGlvbiBpcyBj YWxsZWQgd2l0aCB0d28gYXJndW1lbnRzOgpAQCAtNzExNCw4ICs3MTIxLDkgQEAgcHJvZ3Jlc3Mt cmVwb3J0ZXItdXBkYXRlLWZ1bmN0aW9ucwogU1RBVEUgY2FuIGJlIG9uZSBvZjoKIC0gQSBmbG9h dCByZXByZXNlbnRpbmcgdGhlIHBlcmNlbnRhZ2UgY29tcGxldGUgaW4gdGhlIHJhbmdlIDAuMC0x LjAKIGZvciBhIG51bWVyaWMgcmVwb3J0ZXIuCi0tIEFuIGludGVnZXIgcmVwcmVzZW50aW5nIHRo ZSBpbmRleCB3aGljaCBjeWNsZXMgdGhyb3VnaCB0aGUgcmFuZ2UgMC0zCi1mb3IgYSBwdWxzaW5n IHJlcG9ydGVyLgorLSBBbiBpbnRlZ2VyIHdoaWNoIGZvciBhIHB1bHNpbmcgcmVwb3J0ZXIgY3lj bGVzIHRocm91Z2ggdGhlIGNoYXJhY3RlcnMKK2luIHRoZSB2ZWN0b3IgYHByb2dyZXNzLXJlcG9y dGVyLXB1bHNlLWNoYXJhY3RlcnMnOyBpLmUuLCB0aGUgaW50ZWdlcgorbW9kdWxvIHRoZSBsZW5n dGggb2YgdGhlIHZlY3Rvci4KIC0gVGhlIHN5bWJvbCBgZG9uZScgdG8gaW5kaWNhdGUgdGhhdCB0 aGUgcHJvZ3Jlc3MgcmVwb3J0ZXIgaXMgY29tcGxldGUuIikKIAogKGRlZnN1YnN0IHByb2dyZXNz LXJlcG9ydGVyLXVwZGF0ZSAocmVwb3J0ZXIgJm9wdGlvbmFsIHZhbHVlIHN1ZmZpeCkKQEAgLTcy MjAsOSArNzIyOCw2IEBAIHByb2dyZXNzLXJlcG9ydGVyLWZvcmNlLXVwZGF0ZQogICAgICAgKGFz ZXQgcGFyYW1ldGVycyAwIChmbG9hdC10aW1lKSkpCiAgICAgKHByb2dyZXNzLXJlcG9ydGVyLWRv LXVwZGF0ZSByZXBvcnRlciB2YWx1ZSBzdWZmaXgpKSkKIAotKGRlZnZhciBwcm9ncmVzcy1yZXBv cnRlci0tcHVsc2UtY2hhcmFjdGVycyBbIi0iICJcXCIgInwiICIvIl0KLSAgIkNoYXJhY3RlcnMg dG8gdXNlIGZvciBwdWxzaW5nIHByb2dyZXNzIHJlcG9ydGVycy4iKQotCiAoZGVmdW4gcHJvZ3Jl c3MtcmVwb3J0ZXItZWNoby1hcmVhIChyZXBvcnRlciBzdGF0ZSkKICAgIlByb2dyZXNzIHJlcG9y dGVyIGVjaG8gYXJlYSB1cGRhdGUgZnVuY3Rpb24uCiBSRVBPUlRFUiBhbmQgU1RBVEUgYXJlIHRo ZSBzYW1lIGFzIGluCkBAIC03MjQxLDggKzcyNDYsOSBAQCBwcm9ncmVzcy1yZXBvcnRlci1lY2hv LWFyZWEKICAgICAgICAgICAgKG1lc3NhZ2UgIiVzIiB0ZXh0KSkpCiAgICAgICAgICgocHJlZCBp bnRlZ2VycCkKICAgICAgICAgIChsZXQgKChtZXNzYWdlLWxvZy1tYXggbmlsKQotICAgICAgICAg ICAgICAgKHB1bHNlLWNoYXIgKGFyZWYgcHJvZ3Jlc3MtcmVwb3J0ZXItLXB1bHNlLWNoYXJhY3Rl cnMKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0YXRlKSkpCisgICAgICAgICAg ICAgICAocHVsc2UtY2hhcgorICAgICAgICAgICAgICAgIChhcmVmIHByb2dyZXNzLXJlcG9ydGVy LXB1bHNlLWNoYXJhY3RlcnMKKyAgICAgICAgICAgICAgICAgICAgICAobW9kIHN0YXRlIChsZW5n dGggcHJvZ3Jlc3MtcmVwb3J0ZXItcHVsc2UtY2hhcmFjdGVycykpKSkpCiAgICAgICAgICAgICht ZXNzYWdlICIlcyAlcyIgdGV4dCBwdWxzZS1jaGFyKSkpCiAgICAgICAgICgnZG9uZQogICAgICAg ICAgKG1lc3NhZ2UgIiVzZG9uZSIgdGV4dCkpKSkpKQpAQCAtNzI5NCw3ICs3MzAwLDggQEAgcHJv Z3Jlc3MtcmVwb3J0ZXItZG8tdXBkYXRlCiAgICAgICAgICAgIChpZiBzdWZmaXgKICAgICAgICAg ICAgICAgIChhc2V0IHBhcmFtZXRlcnMgNiBzdWZmaXgpCiAgICAgICAgICAgICAgKHNldHEgc3Vm Zml4IChvciAoYXJlZiBwYXJhbWV0ZXJzIDYpICIiKSkpCi0gICAgICAgICAgIChsZXQgKChpbmRl eCAobW9kICgxKyAoY2FyIHJlcG9ydGVyKSkgNCkpKQorICAgICAgICAgICAobGV0ICgoaW5kZXgg KG1vZCAoMSsgKGNhciByZXBvcnRlcikpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChs ZW5ndGggcHJvZ3Jlc3MtcmVwb3J0ZXItcHVsc2UtY2hhcmFjdGVycykpKSkKIAkgICAgIChzZXRj YXIgcmVwb3J0ZXIgaW5kZXgpCiAgICAgICAgICAgICAgKHJ1bi1ob29rLXdpdGgtYXJncyAncHJv Z3Jlc3MtcmVwb3J0ZXItdXBkYXRlLWZ1bmN0aW9ucwogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgcmVwb3J0ZXIKZGlmZiAtLWdpdCBhL2xpc3Avc3lzdGVtLXRhc2tiYXIuZWwgYi9s aXNwL3N5c3RlbS10YXNrYmFyLmVsCmluZGV4IGNjNDExODNmYjMyLi5lYmY2OTZkZDBkYSAxMDA2 NDQKLS0tIGEvbGlzcC9zeXN0ZW0tdGFza2Jhci5lbAorKysgYi9saXNwL3N5c3RlbS10YXNrYmFy LmVsCkBAIC0yODIsNyArMjgyLDEwIEBAIHN5c3RlbS10YXNrYmFyLS1wcm9ncmVzcy1yZXBvcnRl ci11cGRhdGUKICAgICAgICgocHJlZCBmbG9hdHApCiAgICAgICAgKHN5c3RlbS10YXNrYmFyLS1w cm9ncmVzcyBzdGF0ZSkpCiAgICAgICAoKHByZWQgaW50ZWdlcnApCi0gICAgICAgKHN5c3RlbS10 YXNrYmFyLS1wcm9ncmVzcyAoLyAoMSsgc3RhdGUpIDQuMCkpKQorICAgICAgIDs7IFRoaXMgd29u J3Qgc2hvdyAwLjAgdG8gaW5kaWNhdGUgd29yayBpbiBwcm9jZXNzIHVudGlsIGRvbmUuCisgICAg ICAgKHN5c3RlbS10YXNrYmFyLS1wcm9ncmVzcworICAgICAgICAoLyAoMSsgKG1vZCBzdGF0ZSAo bGVuZ3RoIHByb2dyZXNzLXJlcG9ydGVyLXB1bHNlLWNoYXJhY3RlcnMpKSkKKyAgICAgICAgICAg KGZsb2F0IChsZW5ndGggcHJvZ3Jlc3MtcmVwb3J0ZXItcHVsc2UtY2hhcmFjdGVycykpKSkpCiAg ICAgICAoJ2RvbmUKICAgICAgICAoc3lzdGVtLXRhc2tiYXItLXByb2dyZXNzIG5pbCkpKSkpCiAK LS0gCjIuNTIuMAoK --000000000000691a6e0651915303--
bug-gnu-emacs@HIDDEN:bug#80988; Package emacs.
Full text available.Received: (at 80988) by debbugs.gnu.org; 11 May 2026 17:16:59 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 11 13:16:59 2026 Received: from localhost ([127.0.0.1]:51385 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1wMUFV-0004fr-Fl for submit <at> debbugs.gnu.org; Mon, 11 May 2026 13:16:59 -0400 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]:50447) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <shipmints@HIDDEN>) id 1wMUFP-0004eh-Cz for 80988 <at> debbugs.gnu.org; Mon, 11 May 2026 13:16:54 -0400 Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-67e24b8ef55so6298496a12.1 for <80988 <at> debbugs.gnu.org>; Mon, 11 May 2026 10:16:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1778519810; cv=none; d=google.com; s=arc-20240605; b=im/rXo2eZRtaFrnLwlKMzJ+nyW1w0tc/rabMm8+1dudUumRyBYMloHHCUcglZKgLdN 7ytasoaytypMX3/wrUNTpPM2LMhCqMfw0wSIdTYMIgqMnSHm1+2ZgAN1NiEAi49eXP7h hhvv3R8eoIkIqp/8r+JebFse4AutF8RdeRX6mO2h4RK9J2g4dkGnYDs3HT1zT3htayNF CDlBRXArUzzddcEWZQ6tWR4J7xZQcSTpbdrqeJ48acuGbtOh5h2+TqXK72fDyJfD5wLW S9/7O4+cH8tRtjVrWy/rmPKnNgfIjRQOOf5ChVeB4oEn/Vkvz7WqCHL3NLe75ak77WBB 9gVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=FMg7VJ4kM9V1DD61nPxAFJvRsKkax35wUfpDnPutSRs=; fh=mLeKA3fy9KIZDAgnCpyKpU8CQvMJkGUhABUT0NGecTE=; b=eEP4kB6yJcM4FmdvogkVLk18yMOlVF1DdyAx3N61qZkzsTjfoo45X1pCo2pVf991oT s7L8UYZaWGaZqx1ApMQPJqplBqq2dYoCiqw+VEAi4ookBSGDJ3Zw297w935AX2dgmiZv iJygtQmBHGlcIC2wxFmlgRbmCsdnJRNbMM7QZaXy9b0/bEjnA6FcrTecTaT6T0uJ1tcK nqRoWnbCjA+TqeItKDIrRRM/PUFhtxy0NiIdUSH/Jo6Xdi9T4L96fXTkpKrw02w4AKCW eYadO/SYj43wc1PkqFlhBBW0rYc5OJciEBjCuJOHYGN4iYW/cZRrz3jmZ8xdslI9v1BJ RbWA==; darn=debbugs.gnu.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778519810; x=1779124610; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=FMg7VJ4kM9V1DD61nPxAFJvRsKkax35wUfpDnPutSRs=; b=mgaISTiCe8lB0SSFSqiWYgds6sxcdlcXv/ZZZd57DbkhXQ4laq1OtRBYgcpFYtV99A nLCqBAGcdISx1Ja4gBOm78AO/tOEA2TR+6e1sT87H1rMWkevOnAAAha19gUE8Neqhkz2 2B2836auCigu0u8CntH3ErI5+4EWncmSz6btY5JwfrCQcflvdo5mLD17WvbN7bHUceBR ZAWsiAUb/9zbZ5U0H39HYAAIYJJoiU8D7zzrJnC+QS4Ti0T/HKVnsOcp+frSsUJ6z3Qd 1AwW9yCm1USGO0MUOKJutsp1HZSPa1vIgvVPZSMQqEJDjK/i+wKPwjJY2TIKh9Ef3aH/ ZsjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778519810; x=1779124610; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FMg7VJ4kM9V1DD61nPxAFJvRsKkax35wUfpDnPutSRs=; b=M5TrO9dukg91+4Ahb9Sntx/nmPk338jmLYxbpNkIu3ZB7ZcJXS5ehPWElt+yRpQHhN as45KaQtwwe1R1GkjX3Zbc7B0WEixz98h+YJtvaUroPQCvd93Eziav4nPsZlTWZ3oi/D StRzqeCPEVhUz6xA1mHc4ONN/sqtTRTgpV5naczw5R5UAEjk9cqSn3c2wHUZx+0KF1Uo J8qs7uZaj5XpImBsVTFLRbcR6DLKRULrFT1ljZfKS2rBR8+/WADbagat1CH6epnmHPAw WplDY0d1AiT5dYUd2WwWZyV5rIqqbGYqUUsdKMytXkgvH4s3MiT1sD2S/ybFdxzaEeBq Wpkg== X-Forwarded-Encrypted: i=1; AFNElJ9sGePv62TjAihZsV6j6UEd3bxiBbZWDthkcYhHWwuReSaV+nmoX13f2YZp+JqJuQGxYT5NIw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YweMwTPeHQE/CifoOj9N0bFusX4G8BV8wEHzFoP2Mv9C/tNRF5R l5RhAGmoX1KfZoHnUxAF4T4Cgd+OeRUPFB9ZinNzGiKNWSH03RCqXP34vlrJMRLLA5/9Iu7+kse KztL1B7okMewnPkpSY0aP6ckn+F/kV8M= X-Gm-Gg: Acq92OFu0tgMHIMEz2nQlF0wLyEl9BJP9syDlFsC46A0uNp/RVebtQr7MY8u3VNd+yf o5l7jtOCY7Xb9K58INl2+EZ+R9s/ZQW7RBTa86m8jIzl5M99LXhfDXs9u52r15S0WzM0RjiBT/L +/00H5fbM5lTfbf/tqIezdmy4Oxz51PP6f60/arEi2QAkzADmAeRE6FROyHrgT2hNq5Zq5m8IIa Vnq8F1MY220cJhlyCPsLRy6bdLXWBITsx9qIX88L5znxBJwOGC2kRH+Luh2Th0eAJXAbqmdQSg/ BZsWNNZSZ5bqyXR3zKvCSfuUb2mCmYBl16cQo4uLe6maltucrb5Ad5IoHHn/P3qZjsYgrLYkDtR X1YTZtcrcwwDSf2Uz6+QDoZsABqR1oOPLrioo9UXekwGQ4Ifgmf6CJ0ER+w== X-Received: by 2002:a05:6402:5017:b0:67d:6c95:9c8e with SMTP id 4fb4d7f45d1cf-67d6c95a081mr12378206a12.14.1778519809794; Mon, 11 May 2026 10:16:49 -0700 (PDT) MIME-Version: 1.0 References: <875x4yl7fm.fsf@HIDDEN> <CAN+1Hbrs_rFU35hBUaKa-AA7eaYZOmnPBMaw-Di5hDrCsd9uOA@HIDDEN> <878q9rquo1.fsf@HIDDEN> In-Reply-To: <878q9rquo1.fsf@HIDDEN> From: =?UTF-8?Q?St=C3=A9phane_Marks?= <shipmints@HIDDEN> Date: Mon, 11 May 2026 13:16:31 -0400 X-Gm-Features: AVHnY4K4wvrLHmxhlcDweM8EvbKSjAsahv9ffw-cLCOqTt6SqnX6cgK8GlVtx7U Message-ID: <CAN+1HbpJP7aWDioF1GSBHh0Bem8Od1_Ea_qJqoyx0+ptNaDaJg@HIDDEN> Subject: Re: bug#80988: 31.0.50; Progress report (commit f5f2306fc1d) To: Augusto Stoffel <arstoffel@HIDDEN> Content-Type: multipart/alternative; boundary="0000000000007d25b206518de91a" X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 80988 Cc: Stefan Monnier <monnier@HIDDEN>, 80988 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.0 (/) --0000000000007d25b206518de91a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, May 10, 2026 at 9:08=E2=80=AFAM Augusto Stoffel <arstoffel@HIDDEN= m> wrote: > > > Nothing is special about 4 and nothing is special about the characters > > other than that change was the smallest backward compatible change > > vs. the original code. Patches often get scrutinized for size and > > scope of change and even some people complain when whitespace changes > > because things get indented when code is added. > > Well, before this commit the magic 4 was standing for the length of > progress-reporter--pulse-characters, which is presumably internal > information. But now it has become official and documented in a > docstring. So I don't see this as a consequence of any minimality > requirement for the change. > > Anyway. I really think this (i.e., get rid of the magic 4, make STATE > an ever-increasing sequence) should be changed for Emacs 31, since after > the release it will really become official. > +list The function 'system-taskbar--progress-reporter-update' will also need to be patched to not refer to 4 and either use the vector's length. I will audit the rest of core to see where else. We could create a "public" defvar/alias for ' progress-reporter--pulse-characters' if it's something you want to replace with your own vector. I think a defcustom is going too far for most people (plus, subr.el is I think too early for defcustom's in the startup sequence). --0000000000007d25b206518de91a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon= t-family:monospace"><span style=3D"font-family:Arial,Helvetica,sans-serif">= On Sun, May 10, 2026 at 9:08=E2=80=AFAM Augusto Stoffel <<a href=3D"mail= to:arstoffel@HIDDEN">arstoffel@HIDDEN</a>> wrote:</span></div></di= v><div class=3D"gmail_quote gmail_quote_container"><blockquote class=3D"gma= il_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,2= 04,204);padding-left:1ex"><br> > Nothing is special about 4 and nothing is special about the characters= <br> > other than that change was the smallest backward compatible change<br> > vs. the original code.=C2=A0 Patches often get scrutinized for size an= d<br> > scope of change and even some people complain when whitespace changes<= br> > because things get indented when code is added.<br> <br> Well, before this commit the magic 4 was standing for the length of<br> progress-reporter--pulse-characters, which is presumably internal<br> information.=C2=A0 But now it has become official and documented in a<br> docstring.=C2=A0 So I don't see this as a consequence of any minimality= <br> requirement for the change.<br> <br> Anyway.=C2=A0 I really think this (i.e., get rid of the magic 4, make STATE= <br> an ever-increasing sequence) should be changed for Emacs 31, since after<br= > the release it will really become official.<br></blockquote><div><br></div>= <div><div class=3D"gmail_default" style=3D"font-family:monospace"><a class= =3D"gmail_plusreply" id=3D"plusReplyChip-5">+list</a><a class=3D"gmail_plus= reply"><br></a></div><br></div><div><font face=3D"monospace">The function <= span class=3D"gmail_default" style=3D"font-family:monospace">'</span>sy= stem-taskbar--progress-reporter-update<span class=3D"gmail_default" style= =3D"font-family:monospace">'</span> will also need to be patched to not= refer to 4<span class=3D"gmail_default" style=3D"font-family:monospace"> a= nd either use the vector's length</span>.</font></div><div><font face= =3D"monospace"><span class=3D"gmail_default" style=3D"font-family:monospace= "><br></span></font></div><div><font face=3D"monospace"><span class=3D"gmai= l_default" style=3D"font-family:monospace">I will</span><span class=3D"gmai= l_default" style=3D"font-family:monospace">=C2=A0</span>audit the rest of <= span class=3D"gmail_default" style=3D"font-family:monospace">core</span><sp= an class=3D"gmail_default" style=3D"font-family:monospace">=C2=A0</span><sp= an class=3D"gmail_default" style=3D"font-family:monospace">to see where els= e.</span></font></div><div><font face=3D"monospace"><span class=3D"gmail_de= fault" style=3D""><br></span></font></div><div><font face=3D"monospace"><sp= an class=3D"gmail_default" style=3D"">We could create a "public" = defvar/alias for '</span>progress-reporter--pulse-characters<span class= =3D"gmail_default" style=3D"">' if it's something you want to repla= ce with your own vector.=C2=A0 I think a defcustom is going too far for mos= t people (plus, subr.el is I think too early for defcustom's in the sta= rtup sequence).</span></font></div></div></div> --0000000000007d25b206518de91a--
bug-gnu-emacs@HIDDEN:bug#80988; Package emacs.
Full text available.
Received: (at 80988) by debbugs.gnu.org; 8 May 2026 19:41:39 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 08 15:41:38 2026
Received: from localhost ([127.0.0.1]:42353 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1wLR4q-0003qO-Lu
for submit <at> debbugs.gnu.org; Fri, 08 May 2026 15:41:38 -0400
Received: from mail-vk1-xa2e.google.com ([2607:f8b0:4864:20::a2e]:60638)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <shipmints@HIDDEN>)
id 1wLR4o-0003pu-2u
for 80988 <at> debbugs.gnu.org; Fri, 08 May 2026 15:41:34 -0400
Received: by mail-vk1-xa2e.google.com with SMTP id
71dfb90a1353d-56a8e0ea02aso2159118e0c.0
for <80988 <at> debbugs.gnu.org>; Fri, 08 May 2026 12:41:34 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1778269293; cv=none;
d=google.com; s=arc-20240605;
b=ZBDVKRgEanRJ6BhgyYqCCjJN5pVryhWjUZw8IqoFGJwTgOWlbgyZnaCnqTrBonQNpR
z7vg3oqKtmFQFqGUzjQWHBjY8swGlMSghHyjayxb49pUzJSRUpwOLnnxPtKKhSKQMBO3
Rq+Nn5V9BTTZywFINw6gGUzEQmbBPiBd/G62cfQkF25iWOyqwOL+C98AdwaJGgXs2vjx
8mKk+4aS5n3Yph4i8sdgR3AIT+R+/OAE6bu2auk4cEZ3jjdsvDZWkBwx2QP/Zg/Lueu2
dPThREdnCAem5anVshuO5XePMgOQdEXmh6+XbVNbrU83dJZIf+iMtlJNrpjdSK3L7gYN
mQXQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20240605;
h=cc:to:subject:message-id:date:from:in-reply-to:references
:mime-version:dkim-signature;
bh=h4iQujjZ1YoQf8OxLiNDSve5601A+/unvIFyjBoSMgw=;
fh=VaWU0dV8G7wvXyiSVOEQ+zNwOuXsk8/kjft6xnK9xNg=;
b=hwAMt5VWiUwpDQ0q9xI4StrAiai5ElP1ojQQnjy7a0VglfICTEvVsbt5ZG9+ptRv+n
1rFp1CJ8bn3wm679HRJ6Yus1fSEew7cEXgC1mZ3JoF7tl6Dl5ebLkVjcrvqE797WG8el
UVDK/0tUVZGjIMaF4PVBz+S4/E9EmYzdglR2pC+Ll0Z2nHguOibWA5WsmOuutSbO/K8G
EOYXPSP2Tkny2pak+7mPrk/MJTzxxGBko8CE6Vc4XpKZGFFmT8oF650bzc/iGx2jVkUE
Dwl5h35j0DBsH0f0M7azNVpc0VzXqTPg/zUsxg2zmRG8WOKuXvf+L5ne2NOafG2zKMve
Akqg==; darn=debbugs.gnu.org
ARC-Authentication-Results: i=1; mx.google.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20251104; t=1778269293; x=1778874093; darn=debbugs.gnu.org;
h=cc:to:subject:message-id:date:from:in-reply-to:references
:mime-version:from:to:cc:subject:date:message-id:reply-to;
bh=h4iQujjZ1YoQf8OxLiNDSve5601A+/unvIFyjBoSMgw=;
b=fjYz3tgt47hr+6v9GWU1NZ5HOK+RwcQ4/Jg+avcWpNWgC2X834sq4eQJ7v4RstWPU/
vl3dPnbZSqCQmipaZPqMWrzct0HuadxCw+loyk8QwOwAGwnhdKlkJsQGAo5sCDTKMBxK
gJaJY4hroizM+etEGr8DLGMjknMEq1iSLA/leaov48BzKD0eN165a/T0/RDsZ/kQD8AK
pZcu2BM/sg9l8uR7Il4JEy20RZhiFtdWhiM9pPAW8B6HPJItpPhyeSMhQDv0L3TOHqUN
Y1pbe21aJcBsz8t26VnIQvlPKN4/xRxiy1E7Qwl5QDu1Thx7uIWdE5Go54nQn8tpffi8
U3pQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20251104; t=1778269293; x=1778874093;
h=cc:to:subject:message-id:date:from:in-reply-to:references
:mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date
:message-id:reply-to;
bh=h4iQujjZ1YoQf8OxLiNDSve5601A+/unvIFyjBoSMgw=;
b=IFye1RqS4qi/SxgF/tm+IIfzaSaqqAe+gD5erYy0qF0NVgyXBEsQzR6/7SSEbYv6th
q5FpqJ5BH4KZSUeVOEvnfoPVaZd8nq6ji9+PXFCZUlwDU1eHG2N85Fct2VaV/7BWUcUv
5EueLs1MiCjZM3qHed9IweCe8MRMJ9hEh5cxUKLzxKC8yiHPv8Z4IvfV1WWIhvf5t3ja
dhRTLClpDtiT9Vv0Nw3Mq3IkmUpJ902jYGUOkJ3eqqNOy55ySUBrzqg1hlCly5Q2vWu9
8+reeQZ6Ehtep3mXCrwtC3dHcvpa7SktC8qgaxWrqca+VGlZJmefbpFRJz7ePyzar+Sv
w8hQ==
X-Gm-Message-State: AOJu0YzB28oMcd9iLwYwfgvtlRTCSZYNx9J5AY3KU3A43+5U7hpickxf
MR210L8QR9iUQQMBWMG8PEySyhdcNxWSe7bqCcAIuBSvbISHPcF7+2gqpoSBOMo1CZlWZOXz5Qq
EwIyAVVYc4/jCoEaJ1QIQaWLfjoHA8mA=
X-Gm-Gg: Acq92OEmNYfGm69LewjJ/5vRmLxe8XH+Nz0rU1oPp5pLPm1kOduHpQ2HLg78pEuTunB
AAVYyRof+FyoavORCXbckQw1wRiLeukgOfZ0AfYJA53q2+p8c2mW6hHyHioAgvzzQlQVSRjMF10
hy1RGWY/BkU3lAfOADwxzB0JJmSP4ewDkpNEh7fpuL0b70/FUzu44hVlgv0nZ1hRu0OHlYGk08T
xOOXr8istNAwwad/oxovbVXgsjx6qYtEwV34YDR1lkJHouNFFkKlTlOHmrN2uX/grSZADoOR6Kt
Xj3Up907R2uJI9+y6+xyfy7h7FAIZ8lEQ9zuro4RAEK4ZK76jC+iErHYG3cVNJPd/BWgh/BjNsT
RTsXTqwVC5eUbN4330Ns6aAGnREDyjdgdlNWCgV0nPSJ5MiO/0qJNKqUxJg==
X-Received: by 2002:a05:6122:4089:b0:56f:2f47:4e69 with SMTP id
71dfb90a1353d-5755960af8amr8892224e0c.10.1778269293216; Fri, 08 May 2026
12:41:33 -0700 (PDT)
MIME-Version: 1.0
References: <875x4yl7fm.fsf@HIDDEN>
In-Reply-To: <875x4yl7fm.fsf@HIDDEN>
From: =?UTF-8?Q?St=C3=A9phane_Marks?= <shipmints@HIDDEN>
Date: Fri, 8 May 2026 15:41:22 -0400
X-Gm-Features: AVHnY4LBN-f9N898ZrzuPNm2ZedCHjRcvB4B5KvxH3vioJwn_z0Tce2qaQo1lgM
Message-ID: <CAN+1Hbrs_rFU35hBUaKa-AA7eaYZOmnPBMaw-Di5hDrCsd9uOA@HIDDEN>
Subject: Re: bug#80988: 31.0.50; Progress report (commit f5f2306fc1d)
To: Augusto Stoffel <arstoffel@HIDDEN>
Content-Type: multipart/alternative; boundary="0000000000008987c10651539503"
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: 80988
Cc: Stefan Monnier <monnier@HIDDEN>, 80988 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.0 (/)
--0000000000008987c10651539503
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
On Fri, May 8, 2026 at 2:53=E2=80=AFAM Augusto Stoffel <arstoffel@HIDDEN=
> wrote:
> From the docstring progress-reporter-update-functions:
>
> [...]
> - An integer representing the index which cycles through the range 0-3
> for a pulsing reporter.
> [...]
>
> What's special about 4?
>
> Could we please change the state to be just a continuously increasing
> integer sequence, and then do this?
>
> --8<---------------cut here---------------start------------->8---
> @@ -7241,8 +7241,9 @@ progress-reporter-echo-area
> (message "%s" text)))
> ((pred integerp)
> (let ((message-log-max nil)
> + (length (length progress-reporter--pulse-characters))
> (pulse-char (aref progress-reporter--pulse-characters
> - state)))
> + (mod state length))))
> (message "%s %s" text pulse-char)))
> ('done
> (message "%sdone" text))))))
> --8<---------------cut here---------------end--------------->8---
>
> This ensures the aref never signals, even if the user customizes
> progress-reporter--pulse-characters (which by the way could be a
> customization option, I for one use some Unicode characters).
>
> More importantly, who knows what ideas people come up with for new
> progress reporters, which would only benefit from a non-repeating state.
>
Both ideas seem reasonable to me. These days I barely even look at
the echo area since I have system-taskbar hooked up which is snazzier and
more importantly, I can see it without being in Emacs.
Nothing is special about 4 and nothing is special about the characters
other than that change was the smallest backward compatible change vs. the
original code. Patches often get scrutinized for size and scope of change
and even some people complain when whitespace changes because things get
indented when code is added.
--0000000000008987c10651539503
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon=
t-family:monospace"><span style=3D"font-family:Arial,Helvetica,sans-serif">=
On Fri, May 8, 2026 at 2:53=E2=80=AFAM Augusto Stoffel <<a href=3D"mailt=
o:arstoffel@HIDDEN">arstoffel@HIDDEN</a>> wrote:</span></div></div=
><div class=3D"gmail_quote gmail_quote_container"><blockquote class=3D"gmai=
l_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,20=
4,204);padding-left:1ex">From the docstring progress-reporter-update-functi=
ons:<br>
<br>
=C2=A0 [...]<br>
=C2=A0 - An integer representing the index which cycles through the range 0=
-3<br>
=C2=A0 =C2=A0 for a pulsing reporter.<br>
=C2=A0 [...]<br>
<br>
What's special about 4?<br>
<br>
Could we please change the state to be just a continuously increasing<br>
integer sequence, and then do this?<br>
<br>
--8<---------------cut here---------------start------------->8---<br>
@@ -7241,8 +7241,9 @@ progress-reporter-echo-area<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (message "%s" text)))<b=
r>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0((pred integerp)<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (let ((message-log-max nil)<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(length (length pro=
gress-reporter--pulse-characters))<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (pulse-char (aref p=
rogress-reporter--pulse-characters<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0state)))<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(mod state length))))<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (message "%s %s" text p=
ulse-char)))<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0('done<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (message "%sdone" text))))))<b=
r>
--8<---------------cut here---------------end--------------->8---<br>
<br>
This ensures the aref never signals, even if the user customizes<br>
progress-reporter--pulse-characters (which by the way could be a<br>
customization option, I for one use some Unicode characters).<br>
<br>
More importantly, who knows what ideas people come up with for new<br>
progress reporters, which would only benefit from a non-repeating state.<br=
></blockquote><div><br></div><div class=3D"gmail_default" style=3D"font-fam=
ily:monospace">Both ideas seem=C2=A0reasonable to me.=C2=A0 These days I ba=
rely even look at the=C2=A0echo area since I have system-taskbar hooked up =
which is snazzier and more importantly, I can see it without being in Emacs=
.</div><div class=3D"gmail_default" style=3D"font-family:monospace"><br></d=
iv><div class=3D"gmail_default" style=3D"font-family:monospace">Nothing is =
special about 4 and nothing is special about the characters other than that=
change was the smallest backward compatible change vs. the original code.=
=C2=A0 Patches often get scrutinized for size and scope of change and even =
some people complain when whitespace changes because things get indented wh=
en code is added.</div></div></div>
--0000000000008987c10651539503--
bug-gnu-emacs@HIDDEN:bug#80988; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 8 May 2026 06:52:34 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 08 02:52:34 2026
Received: from localhost ([127.0.0.1]:34799 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1wLF4b-0007Fk-JK
for submit <at> debbugs.gnu.org; Fri, 08 May 2026 02:52:34 -0400
Received: from lists1p.gnu.org ([2001:470:142::17]:49096)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <arstoffel@HIDDEN>)
id 1wLF4V-0007EM-Vd
for submit <at> debbugs.gnu.org; Fri, 08 May 2026 02:52:31 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <arstoffel@HIDDEN>)
id 1wLF4Q-0005Pq-2H
for bug-gnu-emacs@HIDDEN; Fri, 08 May 2026 02:52:22 -0400
Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <arstoffel@HIDDEN>)
id 1wLF4M-0008ED-Uv
for bug-gnu-emacs@HIDDEN; Fri, 08 May 2026 02:52:20 -0400
Received: by mail-wm1-x32a.google.com with SMTP id
5b1f17b1804b1-48a563e4ef7so15117875e9.0
for <bug-gnu-emacs@HIDDEN>; Thu, 07 May 2026 23:52:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20251104; t=1778223135; x=1778827935; darn=gnu.org;
h=mime-version:message-id:date:subject:to:from:from:to:cc:subject
:date:message-id:reply-to;
bh=U4QTqNFgLSjmv6Awz0swXQC6wXMPDlwA6cO32DtrcAQ=;
b=kW9tTWjcroCaO5jnPtO6ihI3eS/eiXQI4xd3WmYngT6OsH8rtci2SDg4bbw8nL+1Nj
cOmsBKa7b82YbLZ3YJL3ew6/QmWMEaeiRgCOx/dnVElIGwcA3A76pIl1bMRgZcuFiOYE
uGiOp3yg7eWwhQAiQQ1BdIJH7bHTwK/teF781s6gE17zcTU92G2HGCwokdQ25h+73XdE
m6Rx5q58mIbNeBRZ+t3et9bCmuXMEziSQUMQvgg29xssPDU4g//LDe0/BGE0uNo1g0qM
js+dlp7dgsYSqKhT+q2Bglx9CK34xPyZ8T4xk59CZ/TIg7tqok2JgcVbUYQl1mKhmtq2
7rgg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20251104; t=1778223135; x=1778827935;
h=mime-version:message-id:date:subject:to:from:x-gm-gg
:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=U4QTqNFgLSjmv6Awz0swXQC6wXMPDlwA6cO32DtrcAQ=;
b=cLrLEk5PoQU1LhxRdbQm4Se66GGxidcbDHOpmelh/pQ0AN4e9tBMpCHONoy20nCvQD
IVDrcvjsNIFuIaT2T5w2Yquk/v5/jZMazRZZkGCkqd2naI23r6IdKQvLUOSmy6jRbTLc
bPF/ZFOtWRFdaedtUPMGyUc8WWHEixQCi24JoXv9Ou7qtYZ6I2bdOmweORPoeydk1/a/
2n+vKFQxokxrkd84KbtgtNrfq3UcJPkxIA/oo8OhQ6wc4ryVeU3Rccs9WEAlPq+C/g5b
ZIcNaGmSZPoYdmXhhusNAetKakSsRWQBmHCdUyrLXbqSoH9wJuKDtVtPvDzy/TVtP9Mw
OdGQ==
X-Gm-Message-State: AOJu0Yws+WlBmhjK3EF+H6nRK0I8kJLUL0Z+w2ygbxOTY9kmdp02ePZH
Vp0qEiihonv87G9yzbzpmisVfYYTCBTjxj8MlgXELMBNA4GKXZnImjzOnQT7iQ==
X-Gm-Gg: AeBDieuC0pOf2yqmIPXxLnw3AD1s6mDH/uvf6doeaop3E22dU0FXeTfZrqphCGkDP7I
9AsON0aS/YSjqjFbeQ72xy0Yfh315759w99c3bJ91eKm5ilen+MMdmlLYBnM2rW5C9YNlESRrZH
frPkKTh48TIQ0TAaUIsrDDAlJMar6UoDvG06m//8D2hivLl0uHXAzNS5iBGNk3oPBs59o28yE+T
X2Dv05B/4BZ1IPpoRJFYQdu0VjA+FYzM9/YJopQT1TR0h3G0gfOjIfCt5xh6w8qeX5kHsUjch8B
SFP1Af8VtZd4d0IwDUeAOW6l7CHgIXiTg6epzC+bNrGBBNiZNuE4J3eUmbP+DkEHwiHz4wTlDFx
45TN8+qoI52gw4gI8GuBX9n7V5gRT/aO2ZHjr1hJgt7J78xhVT01BHjoelaOiUgi3iBUdkrXw4P
kQo4CeKulC3A==
X-Received: by 2002:a05:600c:3b17:b0:488:ffb1:494c with SMTP id
5b1f17b1804b1-48e51e1f0b2mr163134685e9.12.1778223134594;
Thu, 07 May 2026 23:52:14 -0700 (PDT)
Received: from ars3 ([2a02:8109:8a95:9a00::6288])
by smtp.gmail.com with ESMTPSA id
5b1f17b1804b1-48e68ef0024sm17783825e9.14.2026.05.07.23.52.13
for <bug-gnu-emacs@HIDDEN>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 07 May 2026 23:52:14 -0700 (PDT)
From: Augusto Stoffel <arstoffel@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 31.0.50; Progress report (commit f5f2306fc1d)
X-Debbugs-Cc: =?utf-8?Q?St=C3=A9phane?= Marks <shipmints@HIDDEN>
Date: Fri, 08 May 2026 08:52:13 +0200
Message-ID: <875x4yl7fm.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=2a00:1450:4864:20::32a;
envelope-from=arstoffel@HIDDEN; helo=mail-wm1-x32a.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 2.0 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: From the docstring progress-reporter-update-functions: [...]
- An integer representing the index which cycles through the range 0-3 for
a pulsing reporter. [...] What's special about 4?
Content analysis details: (2.0 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (arstoffel[at]gmail.com)
1.0 FORGED_GMAIL_RCVD 'From' gmail.com does not match 'Received'
headers -0.0 SPF_HELO_PASS SPF: HELO matches SPF record
1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail)
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust [2001:470:142:0:0:0:0:17 listed in] [list.dnswl.org]
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.0 (+)
From the docstring progress-reporter-update-functions:
[...]
- An integer representing the index which cycles through the range 0-3
for a pulsing reporter.
[...]
What's special about 4?
Could we please change the state to be just a continuously increasing
integer sequence, and then do this?
--8<---------------cut here---------------start------------->8---
@@ -7241,8 +7241,9 @@ progress-reporter-echo-area
(message "%s" text)))
((pred integerp)
(let ((message-log-max nil)
+ (length (length progress-reporter--pulse-characters))
(pulse-char (aref progress-reporter--pulse-characters
- state)))
+ (mod state length))))
(message "%s %s" text pulse-char)))
('done
(message "%sdone" text))))))
--8<---------------cut here---------------end--------------->8---
This ensures the aref never signals, even if the user customizes
progress-reporter--pulse-characters (which by the way could be a
customization option, I for one use some Unicode characters).
More importantly, who knows what ideas people come up with for new
progress reporters, which would only benefit from a non-repeating state.
Augusto Stoffel <arstoffel@HIDDEN>:shipmints@HIDDEN, bug-gnu-emacs@HIDDEN.
Full text available.shipmints@HIDDEN, bug-gnu-emacs@HIDDEN:bug#80988; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.