GNU bug report logs - #81134
[PATCH] Fix progress-reporter-update to display SUFFIX again

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: Aaron Zeng <azeng@HIDDEN>; Keywords: patch; dated Wed, 27 May 2026 20:19:02 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 81134 <at> debbugs.gnu.org:


Received: (at 81134) by debbugs.gnu.org; 6 Jun 2026 11:14:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jun 06 07:14:06 2026
Received: from localhost ([127.0.0.1]:37726 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1wVoyc-0001UK-4r
	for submit <at> debbugs.gnu.org; Sat, 06 Jun 2026 07:14:06 -0400
Received: from mail-vk1-xa2d.google.com ([2607:f8b0:4864:20::a2d]:48348)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <shipmints@HIDDEN>)
 id 1wVoyX-0001TY-KK
 for 81134 <at> debbugs.gnu.org; Sat, 06 Jun 2026 07:14:04 -0400
Received: by mail-vk1-xa2d.google.com with SMTP id
 71dfb90a1353d-59f967189e7so857661e0c.0
 for <81134 <at> debbugs.gnu.org>; Sat, 06 Jun 2026 04:14:01 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1780744441; cv=none;
 d=google.com; s=arc-20240605;
 b=Pdbr/NSewrjVYSBO1YyZ1XPtjCd84ztBiir1FE3fWhmH4snEx1mT5sYjB1sDr/VsnS
 uxGE//enQnetyteERghf30LB+JDYS0LiE2FDBHfSq3HK6/m2bC1X819YbMyj5bF9OLed
 nU3daGXizN+wgVfNZ0Syi0RIZ3ZUEw9xX0yw7+iLwJRQPULw21nXRwQ1tF0zfosJDV5e
 JSgv8GxrP+BlTeNDZNSBqW2lC8wFdX7ehNfqdbX58C5FSw08o5JbeC5r2qNc+R5wbHRG
 0o8JGMXWVNnkszKUI1x2BP5te/2nOAT4h2j6PiFjcjVcYTivWm/qjm1O7I9CXa4vkOh3
 oP8g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
 s=arc-20240605; 
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:dkim-signature;
 bh=VqBt1LSILuDk5RLI5ClMjEvneS//MVsh5l2w+qAn9PY=;
 fh=5A/SeUbO7rG8FCb6w6nvRMmmFbaih/rjaP5DlbWHlvk=;
 b=QPx5eWvoL0PO0RNm5v6Mwd0PUTwSoF+HwI01TzfnMcQZz8cFaH583Ao78X2Dsje43V
 UGp6iACy4oOmvCkJMpMhpYUUABEPhpi5bNA9f31NxNXMHivPgl4FTysJMPNgI34YV4MZ
 pJSDwCGfY1lMp1QNJqKV0MtjBCMkNFKSjY2H9G5aWl5OMYulHASQYPYMfJaPrfDO07g2
 xU69lmMtvWadDPof29Ht8YIuC+IDByCO1+DyoGyDRYs5P0/Jk+K2+mFlan9foOttk8in
 zAGe4ypwRB2mx/YcPzYvlM2eA/NQT8wZKGkimllQ87ALKwYB8HQMp1vGTs8Ngt3JUcC5
 UP6A==; darn=debbugs.gnu.org
ARC-Authentication-Results: i=1; mx.google.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20251104; t=1780744441; x=1781349241; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=VqBt1LSILuDk5RLI5ClMjEvneS//MVsh5l2w+qAn9PY=;
 b=mgRA7/Nxx0f2XZhuEah5/zuZP1lT+p9ksI0W7xi0+B6OzTAEdCfhERkPTQ7gw6BP/7
 jB7LB5qOF/CtqvFXaV/L2ivXtESazQBKYGncS0zja/6/r8+ofdULuySaV+Z1sx0wj9YE
 WP2wuQtcYUbmw7mJU2GU1MjRiNy93v07wYLjc/RGJU2iX9a6UXEhSpel0rW4nOy5y8bf
 pPO/sNCpzkupbC0EkBfggYZCIVG9VOfItel4giwp/q31ZZcV5TCcCmdneyowuN5okl1O
 QBw8AaFTFkMDxKbO3FBIv7OUXGPfHFevKLmF+c5oAaDlFJKLHawM33H3lx0NR3RCnkcC
 qmFQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20251104; t=1780744441; x=1781349241;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=VqBt1LSILuDk5RLI5ClMjEvneS//MVsh5l2w+qAn9PY=;
 b=K4nBoRc0HJe8sFBvJuZl4hOAcmha109hP3NzePl0fI3JXKIxsWzRUTIg5Z0yxzrCCZ
 ewe3zmIFuK2x16WIbLprAELniJHjza9pu+u2hM3ECQo5F5Mu/5ohvuYvUy+vhCkPJPMZ
 4fnb+X68s72b+IrZjo6pjIchPL3YP+0j9qEzcnG+3qsPlZ/XkBCeaXtVkc1BwkdQoAeX
 gzkQmOWckkVqBAWPR0FP7B/N0qaS+m2uQf6BznHuWMXEGqOYKpQqgQmTlHPE4BwBgEbX
 y4IyujDjad6K0OZM82b3Z8mxVL737O18Nd+VTG0DQ3FcYx/qSUXTs8Qdq9iDnAiYVHwc
 9DaA==
X-Forwarded-Encrypted: i=1;
 AFNElJ+iFp7QohtPig1P5kOGZAaBRsPlwXbdGmbY23/O55xYZQIoZAMfZoS66F9ntygH2qZGbHrzTg==@debbugs.gnu.org
X-Gm-Message-State: AOJu0YwLK7ibGtbYIkCH5WwmNpDhr2CsrVwwqMHNenakJ+pmfEkQlVhC
 oO6N6yC11rGZv1rMu6zZm4mbjLyb7NuXXC9rZpEeD9CRpf15sSwmvBuLNp9wE7ozRJ1FF/dy5XY
 WFYzVBoALGIk7cNlPuYp3nEu1k+SkdlQ=
X-Gm-Gg: Acq92OFgQBUyzqXSzcuaMX0JDIFDDEffFfhhUAYr2bdV0K1YuGO6D6Pep1l9b8DavuX
 TJATNAX9KxFEh8Oo3UuX8fXAKSPuWeR/SiET2y79CTu3EKW0fHaZZkwaw66wnba+6rnjueDk9T3
 ewX+aWrmUKtXcw4VV/Xpp03q5IPhuxLcDKh8F6dSicuwIkTv9TT2BW8I02E8cNlzrZJvpdE1rtt
 CSeEZ9NDpFkmfeayKGH+J0gtvqQteUFh277k4zF6dMkXdKxCednbb2Cgwyf7wS3q/WsUWDYH0tp
 yu/yMkW2FHcJNJn/3O5IWtkAjckex1FI4NRG4EQwTOW1mrGwpqR6C6vo3kdqglDyhUbV+KuGC+x
 y7ivEbUhvrxk1i6rDoVKMCo/oly4tOiHF8LNWdyVj1zacWGwjSkAqwdk3IcyoG7xQMb4QlxbFqu
 d9Vy8SRxEcyx0NNL13MDxxuYlFmXlSZWE6KZUrWxg=
X-Received: by 2002:a05:6122:4585:b0:56f:6cc0:681e with SMTP id
 71dfb90a1353d-5ac53c9549amr3882021e0c.1.1780744440730; Sat, 06 Jun 2026
 04:14:00 -0700 (PDT)
MIME-Version: 1.0
References: <q7mldd44nf3.fsf@HIDDEN>
 <CAN+1HbqbJcJMJmvOaBF1ZK7vVAOQ8PcuePU-FgUZ_L2h0orDWw@HIDDEN>
 <877bonzstp.fsf@HIDDEN>
 <jwvv7c60xcu.fsf-monnier+emacs@HIDDEN>
 <jwvjysm0whk.fsf-monnier+emacs@HIDDEN>
 <CAN+1Hbq78BMnKrMxiwB9FUVp1jmaqSheXjAdbD1JFCqYZG7K-g@HIDDEN>
 <CAN+1HbqAt+N-MnvrwP0WLZ19UO7UmJ0MsVUOSabyNgD6ift80g@HIDDEN>
 <jwvh5ngsvyp.fsf-monnier+emacs@HIDDEN>
In-Reply-To: <jwvh5ngsvyp.fsf-monnier+emacs@HIDDEN>
From: =?UTF-8?Q?St=C3=A9phane_Marks?= <shipmints@HIDDEN>
Date: Sat, 6 Jun 2026 07:13:49 -0400
X-Gm-Features: AVVi8CeHv89gzQnaJWQQ2WDWNmkPuIy1Zaq1hONN6GFpKFQpFt2gogz4X4iwXOE
Message-ID: <CAN+1HbokY5ruFJ4F4rn=Ng0nEL1-ODeZ5=Kc30h6gUXZSNdkVA@HIDDEN>
Subject: Re: bug#81134: [PATCH] Fix progress-reporter-update to display SUFFIX
 again
To: Stefan Monnier <monnier@HIDDEN>
Content-Type: multipart/mixed; boundary="000000000000d3805f065393df4f"
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: 81134
Cc: 81134 <at> debbugs.gnu.org, Aaron Zeng <azeng@HIDDEN>,
 Sean Whitton <spwhitton@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.0 (/)

--000000000000d3805f065393df4f
Content-Type: multipart/alternative; boundary="000000000000d3805e065393df4d"

--000000000000d3805e065393df4d
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Jun 5, 2026 at 2:09=E2=80=AFPM Stefan Monnier <monnier@HIDDEN=
l.ca>
wrote:

> > I'm okay renaming SUFFIX to STEP or UPDATE-TEXT.  The most natural thin=
g
> to
> > me is to not store the suffix in the reporter and change
> > 'progress-reporter-update-functions' to accept a suffix argument and ma=
ke
> > it ephemeral.  We can "open" the SUFFIX slot to reuse for another reaso=
n
> > and not fuss with removing a single array element and avoid changing
> index
> > references that come after it.
>
> Works for me.
>

Here's a patch for review.

-St=C3=A9phane

--000000000000d3805e065393df4d
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon=
t-family:monospace"><span style=3D"font-family:Arial,Helvetica,sans-serif">=
On Fri, Jun 5, 2026 at 2:09=E2=80=AFPM Stefan Monnier &lt;<a href=3D"mailto=
:monnier@HIDDEN">monnier@HIDDEN</a>&gt; wrote:</span></=
div></div><div class=3D"gmail_quote gmail_quote_container"><blockquote clas=
s=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid r=
gb(204,204,204);padding-left:1ex">&gt; I&#39;m okay renaming SUFFIX to STEP=
 or UPDATE-TEXT.=C2=A0 The most natural thing to<br>
&gt; me is to not store the suffix in the reporter and change<br>
&gt; &#39;progress-reporter-update-functions&#39; to accept a suffix argume=
nt and make<br>
&gt; it ephemeral.=C2=A0 We can &quot;open&quot; the SUFFIX slot to reuse f=
or another reason<br>
&gt; and not fuss with removing a single array element and avoid changing i=
ndex<br>
&gt; references that come after it.<br>
<br>
Works for me.<br></blockquote><div><br></div><div class=3D"gmail_default" s=
tyle=3D"font-family:monospace">Here&#39;s a patch for review.</div><div cla=
ss=3D"gmail_default" style=3D"font-family:monospace"><br></div><div class=
=3D"gmail_default" style=3D"font-family:monospace">-St=C3=A9phane=C2=A0</di=
v></div></div>

--000000000000d3805e065393df4d--

--000000000000d3805f065393df4f
Content-Type: application/octet-stream; 
	name="0001-Restore-progress-reporter-suffix-as-update-text-bug-.patch"
Content-Disposition: attachment; 
	filename="0001-Restore-progress-reporter-suffix-as-update-text-bug-.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mq298ffl0>
X-Attachment-Id: f_mq298ffl0

RnJvbSAyN2JhMWY5YjI5YjQ3NTBjNzE5ODY1OWQ4NjFhYTk2M2YwZWU1OGIwIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/U3Q9QzM9QTlwaGFuZT0yME1hcmtzPz0gPHNo
aXBtaW50c0BnbWFpbC5jb20+CkRhdGU6IFNhdCwgNiBKdW4gMjAyNiAwNjo1NTo1OCAtMDQwMApT
dWJqZWN0OiBbUEFUQ0hdIFJlc3RvcmUgcHJvZ3Jlc3MtcmVwb3J0ZXIgc3VmZml4IGFzIHVwZGF0
ZS10ZXh0IChidWcjODExMzQpCgpQcm9wZXJseSB0cmVhdCBVUERBVEUtVEVYVCBhcyBlcGhlbWVy
YWwgYW5kIGRvIG5vdCBwZXJzaXN0IGl0IGluCnRoZSByZXBvcnRlciBpbnN0YW5jZS4KCiogbGlz
cC9zdWJyLmVsIChwcm9ncmVzcy1yZXBvcnRlci11cGRhdGUtZnVuY3Rpb25zKTogVXBkYXRlCmRv
Y3N0cmluZy4KKHByb2dyZXNzLXJlcG9ydGVyLXVwZGF0ZSk6IFVwZGF0ZSBmdW5jdGlvbiBzaWdu
YXR1cmUuCihtYWtlLXByb2dyZXNzLXJlcG9ydGVyKTogRG9jdW1lbnQgc3VmZml4IHNsb3QgYXZh
aWxhYmxlIGZvcgpyZXVzZS4KKHByb2dyZXNzLXJlcG9ydGVyLWZvcmNlLXVwZGF0ZSk6IFVwZGF0
ZSBmdW5jdGlvbiBzaWduYXR1cmUuCihwcm9ncmVzcy1yZXBvcnRlci1lY2hvLWFyZWEpOiBSZXN0
b3JlIHRoZSB0ZXh0IGFyZ3VtZW50IGFuZAplY2hvIGl0LgoocHJvZ3Jlc3MtcmVwb3J0ZXItZG8t
dXBkYXRlKTogVXBkYXRlIGZ1bmN0aW9uIHNpZ25hdHVyZS4KVXBkYXRlIHRoZSBob29rLgoocHJv
Z3Jlc3MtcmVwb3J0ZXItZG9uZSk6IFVwZGF0ZSB0aGUgaG9vay4KKgpsaXNwL3N5c3RlbS10YXNr
YmFyLmVsIChzeXN0ZW0tdGFza2Jhci0tcHJvZ3Jlc3MtcmVwb3J0ZXItdXBkYXRlKToKVXBkYXRl
IGZ1bmN0aW9uIHNpZ25hdHVyZS4KKiBsaXNwL25ldC90cmFtcC5lbCAodHJhbXAtcHJvZ3Jlc3Mt
cmVwb3J0ZXItdXBkYXRlKTogVXBkYXRlCmZ1bmN0aW9uIHNpZ25hdHVyZS4KKiBkb2MvbGlzcHJl
Zi9kaXNwbGF5LnRleGkgKFByb2dyZXNzKTogVXBkYXRlIGRvY3VtZW50YXRpb24uCi0tLQogZG9j
L2xpc3ByZWYvZGlzcGxheS50ZXhpIHwgMTIgKysrKy0tLS0KIGxpc3AvbmV0L3RyYW1wLmVsICAg
ICAgICB8ICA0ICstLQogbGlzcC9zdWJyLmVsICAgICAgICAgICAgIHwgNjEgKysrKysrKysrKysr
KysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLQogbGlzcC9zeXN0ZW0tdGFza2Jhci5lbCAgIHwg
IDQgKy0tCiA0IGZpbGVzIGNoYW5nZWQsIDQyIGluc2VydGlvbnMoKyksIDM5IGRlbGV0aW9ucygt
KQoKZGlmZiAtLWdpdCBhL2RvYy9saXNwcmVmL2Rpc3BsYXkudGV4aSBiL2RvYy9saXNwcmVmL2Rp
c3BsYXkudGV4aQppbmRleCAwOTAyMjg4M2Y3MS4uOWI2NjAyOTliYmEgMTAwNjQ0Ci0tLSBhL2Rv
Yy9saXNwcmVmL2Rpc3BsYXkudGV4aQorKysgYi9kb2MvbGlzcHJlZi9kaXNwbGF5LnRleGkKQEAg
LTUzMSw3ICs1MzEsNyBAQCBQcm9ncmVzcwogbWVzc2FnZSBpcyBwcmludGVkIGltbWVkaWF0ZWx5
LgogQGVuZCBkZWZ1bgogCi1AZGVmdW4gcHJvZ3Jlc3MtcmVwb3J0ZXItdXBkYXRlIHJlcG9ydGVy
ICZvcHRpb25hbCB2YWx1ZSBzdWZmaXgKK0BkZWZ1biBwcm9ncmVzcy1yZXBvcnRlci11cGRhdGUg
cmVwb3J0ZXIgJm9wdGlvbmFsIHZhbHVlIHVwZGF0ZS10ZXh0CiBUaGlzIGZ1bmN0aW9uIGRvZXMg
dGhlIG1haW4gd29yayBvZiByZXBvcnRpbmcgcHJvZ3Jlc3Mgb2YgeW91cgogb3BlcmF0aW9uLiAg
SXQgZGlzcGxheXMgdGhlIG1lc3NhZ2Ugb2YgQHZhcntyZXBvcnRlcn0sIGZvbGxvd2VkIGJ5CiBw
cm9ncmVzcyBwZXJjZW50YWdlIGRldGVybWluZWQgYnkgQHZhcnt2YWx1ZX0uICBJZiBwZXJjZW50
YWdlIGlzIHplcm8sCkBAIC01NDUsMTAgKzU0NSwxMiBAQCBQcm9ncmVzcwogQGNvZGV7bWFrZS1w
cm9ncmVzcy1yZXBvcnRlcn0uICBGb3IgaW5zdGFuY2UsIGlmIHlvdSBzY2FuIGEgYnVmZmVyLAog
dGhlbiBAdmFye3ZhbHVlfSBzaG91bGQgYmUgdGhlIHJlc3VsdCBvZiBhIGNhbGwgdG8gQGNvZGV7
cG9pbnR9LgogCi1PcHRpb25hbCBhcmd1bWVudCBAdmFye3N1ZmZpeH0gaXMgYSBzdHJpbmcgdG8g
YmUgZGlzcGxheWVkIGFmdGVyCitPcHRpb25hbCBhcmd1bWVudCBAdmFye3VwZGF0ZS10ZXh0fSBp
cyBhIHN0cmluZyB0byBiZSBkaXNwbGF5ZWQgYWZ0ZXIKIEB2YXJ7cmVwb3J0ZXJ9J3MgbWFpbiBt
ZXNzYWdlIGFuZCBwcm9ncmVzcyB0ZXh0LiAgSWYgQHZhcntyZXBvcnRlcn0gaXMKIGEgbm9uLW51
bWVyaWNhbCByZXBvcnRlciwgdGhlbiBAdmFye3ZhbHVlfSBzaG91bGQgYmUgQGNvZGV7bmlsfSwg
b3IgYQotc3RyaW5nIHRvIHVzZSBpbnN0ZWFkIG9mIEB2YXJ7c3VmZml4fS4KK3N0cmluZyB0byB1
c2UgaW5zdGVhZCBvZiBAdmFye3VwZGF0ZS10ZXh0fS4gIEl0IGlzIHVwIHRvIHRoZSBjYWxsZXIg
dG8KK3ByZXBlbmQgYSBzcGFjZSBjaGFyYWN0ZXIgb24gaXRzIEB2YXJ7dXBkYXRlLXRleHR9LCBp
ZiBuZWNlc3NhcnksIGZvcgorYWVzdGhldGljcy4KIAogVGhpcyBmdW5jdGlvbiByZXNwZWN0cyBA
dmFye21pbi1jaGFuZ2V9IGFuZCBAdmFye21pbi10aW1lfSBhcyBwYXNzZWQKIHRvIEBjb2Rle21h
a2UtcHJvZ3Jlc3MtcmVwb3J0ZXJ9IGFuZCBzbyBkb2VzIG5vdCBvdXRwdXQgbmV3IG1lc3NhZ2Vz
CkBAIC01NTcsMTEgKzU1OSwxMSBAQCBQcm9ncmVzcwogbGlrZWx5IG5lZ2F0ZSB5b3VyIGVmZm9y
dC4KIEBlbmQgZGVmdW4KIAotQGRlZnVuIHByb2dyZXNzLXJlcG9ydGVyLWZvcmNlLXVwZGF0ZSBy
ZXBvcnRlciAmb3B0aW9uYWwgdmFsdWUgbmV3LW1lc3NhZ2Ugc3VmZml4CitAZGVmdW4gcHJvZ3Jl
c3MtcmVwb3J0ZXItZm9yY2UtdXBkYXRlIHJlcG9ydGVyICZvcHRpb25hbCB2YWx1ZSBuZXctbWVz
c2FnZSB1cGRhdGUtdGV4dAogVGhpcyBmdW5jdGlvbiBpcyBzaW1pbGFyIHRvIEBjb2Rle3Byb2dy
ZXNzLXJlcG9ydGVyLXVwZGF0ZX0gZXhjZXB0CiB0aGF0IGl0IHByaW50cyBhIG1lc3NhZ2UgaW4g
dGhlIGVjaG8gYXJlYSB1bmNvbmRpdGlvbmFsbHkuCiAKLUB2YXJ7cmVwb3J0ZXJ9LCBAdmFye3Zh
bHVlfSwgYW5kIEB2YXJ7c3VmZml4fSBoYXZlIHRoZSBzYW1lIG1lYW5pbmcgYXMgZm9yCitAdmFy
e3JlcG9ydGVyfSwgQHZhcnt2YWx1ZX0sIGFuZCBAdmFye3VwZGF0ZS10ZXh0fSBoYXZlIHRoZSBz
YW1lIG1lYW5pbmcgYXMgZm9yCiBAY29kZXtwcm9ncmVzcy1yZXBvcnRlci11cGRhdGV9LiAgT3B0
aW9uYWwgQHZhcntuZXctbWVzc2FnZX0gYWxsb3dzCiB5b3UgdG8gY2hhbmdlIHRoZSBtZXNzYWdl
IG9mIHRoZSBAdmFye3JlcG9ydGVyfS4gIFNpbmNlIHRoaXMgZnVuY3Rpb24KIGFsd2F5cyB1cGRh
dGVzIHRoZSBlY2hvIGFyZWEsIHN1Y2ggYSBjaGFuZ2Ugd2lsbCBiZSBpbW1lZGlhdGVseQpkaWZm
IC0tZ2l0IGEvbGlzcC9uZXQvdHJhbXAuZWwgYi9saXNwL25ldC90cmFtcC5lbAppbmRleCAwNDQ1
ODBiYWMwNy4uYTc5NmExZWM5ZjUgMTAwNjQ0Ci0tLSBhL2xpc3AvbmV0L3RyYW1wLmVsCisrKyBi
L2xpc3AvbmV0L3RyYW1wLmVsCkBAIC0yMjEzLDEyICsyMjEzLDEyIEBAIHdpdGgtcGFyc2VkLXRy
YW1wLWZpbGUtbmFtZQogICAgICAgIChpZ25vcmUgLEAobWFwY2FyICMnY2FyIGJpbmRpbmdzKSkK
ICAgICAgICAsQGJvZHkpKSkKIAotKGRlZnVuIHRyYW1wLXByb2dyZXNzLXJlcG9ydGVyLXVwZGF0
ZSAocmVwb3J0ZXIgJm9wdGlvbmFsIHZhbHVlIHN1ZmZpeCkKKyhkZWZ1biB0cmFtcC1wcm9ncmVz
cy1yZXBvcnRlci11cGRhdGUgKHJlcG9ydGVyICZvcHRpb25hbCB2YWx1ZSB1cGRhdGUtdGV4dCkK
ICAgIlJlcG9ydCBwcm9ncmVzcyBvZiBhbiBvcGVyYXRpb24gZm9yIFRyYW1wLiIKICAgKGxldCog
KChwYXJhbWV0ZXJzIChjZHIgcmVwb3J0ZXIpKQogCSAobWVzc2FnZSAoYXJlZiBwYXJhbWV0ZXJz
IDMpKSkKICAgICAod2hlbiAoc3RyaW5nLXNlYXJjaCBtZXNzYWdlIChvciAoY3VycmVudC1tZXNz
YWdlKSAiIikpCi0gICAgICAocHJvZ3Jlc3MtcmVwb3J0ZXItdXBkYXRlIHJlcG9ydGVyIHZhbHVl
IHN1ZmZpeCkpKSkKKyAgICAgIChwcm9ncmVzcy1yZXBvcnRlci11cGRhdGUgcmVwb3J0ZXIgdmFs
dWUgdXBkYXRlLXRleHQpKSkpCiAKIDs7OyMjI3RyYW1wLWF1dG9sb2FkCiAoZGVmdmFyIHRyYW1w
LWluaGliaXQtcHJvZ3Jlc3MtcmVwb3J0ZXIgbmlsCmRpZmYgLS1naXQgYS9saXNwL3N1YnIuZWwg
Yi9saXNwL3N1YnIuZWwKaW5kZXggMTYyMzRkMzEzYTcuLmVmYWRlZTk5YTczIDEwMDY0NAotLS0g
YS9saXNwL3N1YnIuZWwKKysrIGIvbGlzcC9zdWJyLmVsCkBAIC03MDk3LDcgKzcwOTcsOCBAQCBz
ZXQtdHJhbnNpZW50LW1hcAogOzsJCQkgICAgICBNRVNTQUdFCiA7OwkJCSAgICAgIE1JTi1DSEFO
R0UKIDs7ICAgICAgICAgICAgICAgICAgICAgICAgICAgIE1JTi1USU1FCi07OyAgICAgICAgICAg
ICAgICAgICAgICAgICAgICBNRVNTQUdFLVNVRkZJWF0pCis7OyAgICAgICAgICAgICAgICAgICAg
ICAgICAgICBVTlVTRUQgKGZvcm1lcmx5IFNVRkZJWCkKKzs7ICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIENPTlRFWFRdKQogOzsKIDs7IFRoaXMgd2VpcmRuZXNzIGlzIGZvciBvcHRpbWl6YXRp
b24gcmVhc29uczogd2Ugd2FudAogOzsgYHByb2dyZXNzLXJlcG9ydGVyLXVwZGF0ZScgdG8gYmUg
YXMgZmFzdCBhcyBwb3NzaWJsZSwgc28KQEAgLTcxMDksMTUgKzcxMTAsMTcgQEAgc2V0LXRyYW5z
aWVudC1tYXAKIAogKGRlZnZhciBwcm9ncmVzcy1yZXBvcnRlci11cGRhdGUtZnVuY3Rpb25zIChs
aXN0ICMncHJvZ3Jlc3MtcmVwb3J0ZXItZWNoby1hcmVhKQogICAiU3BlY2lhbCBob29rIHJ1biBv
biBwcm9ncmVzcy1yZXBvcnRlciB1cGRhdGVzLgotRWFjaCBmdW5jdGlvbiBpcyBjYWxsZWQgd2l0
aCB0d28gYXJndW1lbnRzOgorRWFjaCBmdW5jdGlvbiBpcyBjYWxsZWQgd2l0aCB0aHJlZSBhcmd1
bWVudHM6CiBSRVBPUlRFUiBpcyB0aGUgcmVzdWx0IG9mIGEgY2FsbCB0byBgbWFrZS1wcm9ncmVz
cy1yZXBvcnRlcicuCiBTVEFURSBjYW4gYmUgb25lIG9mOgogLSBBIGZsb2F0IHJlcHJlc2VudGlu
ZyB0aGUgcGVyY2VudGFnZSBjb21wbGV0ZSBpbiB0aGUgcmFuZ2UgMC4wLTEuMAogZm9yIGEgbnVt
ZXJpYyByZXBvcnRlci4KIC0gQSBtb25vdG9uaWNhbGx5IGluY3JlYXNpbmcgaW50ZWdlciBmb3Ig
YSBwdWxzaW5nIHJlcG9ydGVyLgotLSBUaGUgc3ltYm9sIGBkb25lJyB0byBpbmRpY2F0ZSB0aGF0
IHRoZSBwcm9ncmVzcyByZXBvcnRlciBpcyBjb21wbGV0ZS4iKQorLSBUaGUgc3ltYm9sIGBkb25l
JyB0byBpbmRpY2F0ZSB0aGF0IHRoZSBwcm9ncmVzcyByZXBvcnRlciBpcyBjb21wbGV0ZS4KK1VQ
REFURS1URVhUIGlzIGEgc3RyaW5nIHdoaWNoIGlzIGRpc3BsYXllZCBpZiB0aGUgcmVwb3J0ZXIg
cHJvZHVjZXMgYQorbWVzc2FnZSBhcyBhIHJlc3VsdCBvZiB0aGlzIHVwZGF0ZS4iKQogCi0oZGVm
c3Vic3QgcHJvZ3Jlc3MtcmVwb3J0ZXItdXBkYXRlIChyZXBvcnRlciAmb3B0aW9uYWwgdmFsdWUg
c3VmZml4KQorKGRlZnN1YnN0IHByb2dyZXNzLXJlcG9ydGVyLXVwZGF0ZSAocmVwb3J0ZXIgJm9w
dGlvbmFsIHZhbHVlIHVwZGF0ZS10ZXh0KQogICAiUmVwb3J0IHByb2dyZXNzIG9mIGFuIG9wZXJh
dGlvbiwgYnkgZGVmYXVsdCwgaW4gdGhlIGVjaG8gYXJlYS4KIFJFUE9SVEVSIHNob3VsZCBiZSB0
aGUgcmVzdWx0IG9mIGEgY2FsbCB0byBgbWFrZS1wcm9ncmVzcy1yZXBvcnRlcicuCiAKQEAgLTcx
MjYsMTAgKzcxMjksMTAgQEAgcHJvZ3Jlc3MtcmVwb3J0ZXItdXBkYXRlCiBgbWFrZS1wcm9ncmVz
cy1yZXBvcnRlcictLS10aGVuIFZBTFVFIHNob3VsZCBiZSBhIG51bWJlciBiZXR3ZWVuCiBNSU4t
VkFMVUUgYW5kIE1BWC1WQUxVRS4KIAotT3B0aW9uYWwgYXJndW1lbnQgU1VGRklYIGlzIGEgc3Ry
aW5nIHRvIGJlIGRpc3BsYXllZCBhZnRlciBSRVBPUlRFUidzCi1tYWluIG1lc3NhZ2UgYW5kIHBy
b2dyZXNzIHRleHQuICBJZiBSRVBPUlRFUiBpcyBhIG5vbi1udW1lcmljYWwKLXJlcG9ydGVyLCB0
aGVuIFZBTFVFIHNob3VsZCBiZSBuaWwsIG9yIGEgc3RyaW5nIHRvIHVzZSBpbnN0ZWFkIG9mCi1T
VUZGSVguCitPcHRpb25hbCBhcmd1bWVudCBVUERBVEUtVEVYVCBpcyBhIHN0cmluZyB0byBiZSBk
aXNwbGF5ZWQgYWZ0ZXIKK1JFUE9SVEVSJ3MgbWFpbiBtZXNzYWdlIGFuZCBwcm9ncmVzcyB0ZXh0
LiAgSWYgUkVQT1JURVIgaXMgYQorbm9uLW51bWVyaWNhbCByZXBvcnRlciwgdGhlbiBWQUxVRSBz
aG91bGQgYmUgbmlsLCBvciBhIHN0cmluZyB0byB1c2UKK2luc3RlYWQgb2YgVVBEQVRFLVRFWFQu
CiAKIFNlZSBgcHJvZ3Jlc3MtcmVwb3J0ZXItdXBkYXRlLWZ1bmN0aW9ucycgZm9yIHRoZSBsaXN0
IG9mIGZ1bmN0aW9ucwogY2FsbGVkIG9uIGVhY2ggdXBkYXRlLgpAQCAtNzEzOSw3ICs3MTQyLDcg
QEAgcHJvZ3Jlc3MtcmVwb3J0ZXItdXBkYXRlCiBub3RoaW5nLiIKICAgKHdoZW4gKG9yIChub3Qg
KG51bWJlcnAgdmFsdWUpKSAgICAgIDsgRm9yIHB1bHNpbmcgcmVwb3J0ZXIKIAkgICAgKD49IHZh
bHVlIChjYXIgcmVwb3J0ZXIpKSkgOyBGb3IgbnVtZXJpY2FsIHJlcG9ydGVyCi0gICAgKHByb2dy
ZXNzLXJlcG9ydGVyLWRvLXVwZGF0ZSByZXBvcnRlciB2YWx1ZSBzdWZmaXgpKSkKKyAgICAocHJv
Z3Jlc3MtcmVwb3J0ZXItZG8tdXBkYXRlIHJlcG9ydGVyIHZhbHVlIHVwZGF0ZS10ZXh0KSkpCiAK
IChkZWZ1biBtYWtlLXByb2dyZXNzLXJlcG9ydGVyIChtZXNzYWdlICZvcHRpb25hbCBtaW4tdmFs
dWUgbWF4LXZhbHVlCiAJCQkJICAgICAgIGN1cnJlbnQtdmFsdWUgbWluLWNoYW5nZSBtaW4tdGlt
ZQpAQCAtNzE4OSw3ICs3MTkyLDcgQEAgbWFrZS1wcm9ncmVzcy1yZXBvcnRlcgogCQkgICAgICAg
bWVzc2FnZQogCQkgICAgICAgKGlmIG1pbi1jaGFuZ2UgKG1heCAobWluIG1pbi1jaGFuZ2UgNTAp
IDEpIDEpCiAgICAgICAgICAgICAgICAgICAgICAgIG1pbi10aW1lCi0gICAgICAgICAgICAgICAg
ICAgICAgIDs7IFNVRkZJWAorICAgICAgICAgICAgICAgICAgICAgICA7OyBVbnVzZWQgKGZvcm1l
cmx5IFNVRkZJWCkuCiAgICAgICAgICAgICAgICAgICAgICAgIG5pbAogICAgICAgICAgICAgICAg
ICAgICAgICA7OwogICAgICAgICAgICAgICAgICAgICAgICBjb250ZXh0KSkpKQpAQCAtNzIwNywy
NCArNzIxMCwyNiBAQCBwcm9ncmVzcy1yZXBvcnRlci1jb250ZXh0CiAgICJSZXR1cm4gUkVQT1JU
RVIncyBjb250ZXh0LiIKICAgKGFyZWYgKGNkciByZXBvcnRlcikgNykpCiAKLShkZWZ1biBwcm9n
cmVzcy1yZXBvcnRlci1mb3JjZS11cGRhdGUgKHJlcG9ydGVyICZvcHRpb25hbCB2YWx1ZSBuZXct
bWVzc2FnZSBzdWZmaXgpCisoZGVmdW4gcHJvZ3Jlc3MtcmVwb3J0ZXItZm9yY2UtdXBkYXRlIChy
ZXBvcnRlciAmb3B0aW9uYWwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIHZhbHVlIG5ldy1tZXNzYWdlIHVwZGF0ZS10ZXh0KQogICAiUmVwb3J0IHByb2dy
ZXNzIG9mIGFuIG9wZXJhdGlvbiBpbiB0aGUgZWNobyBhcmVhIHVuY29uZGl0aW9uYWxseS4KIAot
UkVQT1JURVIsIFZBTFVFLCBhbmQgU1VGRklYIGFyZSB0aGUgc2FtZSBhcyBpbiBgcHJvZ3Jlc3Mt
cmVwb3J0ZXItdXBkYXRlJy4KK1JFUE9SVEVSLCBWQUxVRSwgYW5kIFVQREFURS1URVhUIGFyZSB0
aGUgc2FtZSBhcyBpbgorYHByb2dyZXNzLXJlcG9ydGVyLXVwZGF0ZScuCiBORVctTUVTU0FHRSwg
aWYgbm9uLW5pbCwgc2V0cyBhIG5ldyBtZXNzYWdlIGZvciB0aGUgcmVwb3J0ZXIuIgogICAobGV0
ICgocGFyYW1ldGVycyAoY2RyIHJlcG9ydGVyKSkpCiAgICAgKHdoZW4gbmV3LW1lc3NhZ2UKICAg
ICAgIChhc2V0IHBhcmFtZXRlcnMgMyBuZXctbWVzc2FnZSkpCiAgICAgKHdoZW4gKGFyZWYgcGFy
YW1ldGVycyAwKQogICAgICAgKGFzZXQgcGFyYW1ldGVycyAwIChmbG9hdC10aW1lKSkpCi0gICAg
KHByb2dyZXNzLXJlcG9ydGVyLWRvLXVwZGF0ZSByZXBvcnRlciB2YWx1ZSBzdWZmaXgpKSkKKyAg
ICAocHJvZ3Jlc3MtcmVwb3J0ZXItZG8tdXBkYXRlIHJlcG9ydGVyIHZhbHVlIHVwZGF0ZS10ZXh0
KSkpCiAKIChkZWZ2YXIgcHJvZ3Jlc3MtcmVwb3J0ZXItLXB1bHNlLWNoYXJhY3RlcnMgWyItIiAi
XFwiICJ8IiAiLyJdCiAgICJDaGFyYWN0ZXJzIHRvIHVzZSBmb3IgcHVsc2luZyBwcm9ncmVzcyBy
ZXBvcnRlcnMuIikKIAotKGRlZnVuIHByb2dyZXNzLXJlcG9ydGVyLWVjaG8tYXJlYSAocmVwb3J0
ZXIgc3RhdGUpCisoZGVmdW4gcHJvZ3Jlc3MtcmVwb3J0ZXItZWNoby1hcmVhIChyZXBvcnRlciBz
dGF0ZSB1cGRhdGUtdGV4dCkKICAgIlByb2dyZXNzIHJlcG9ydGVyIGVjaG8gYXJlYSB1cGRhdGUg
ZnVuY3Rpb24uCi1SRVBPUlRFUiBhbmQgU1RBVEUgYXJlIHRoZSBzYW1lIGFzIGluCitSRVBPUlRF
UiwgU1RBVEUsIGFuZCBVUERBVEUtVEVYVCBhcmUgdGhlIHNhbWUgYXMgaW4KIGBwcm9ncmVzcy1y
ZXBvcnRlci11cGRhdGUtZnVuY3Rpb25zJy4KIAogRG8gbm90IGVtaXQgYSBtZXNzYWdlIGlmIHRo
ZSByZXBvcnRlciBjb250ZXh0IGlzIGBhc3luYycgYW5kIHRoZSBlY2hvCkBAIC03MjMzLDIxICs3
MjM4LDIyIEBAIHByb2dyZXNzLXJlcG9ydGVyLWVjaG8tYXJlYQogICAgICh1bmxlc3MgKGFuZCAo
ZXEgKHByb2dyZXNzLXJlcG9ydGVyLWNvbnRleHQgcmVwb3J0ZXIpICdhc3luYykKICAgICAgICAg
ICAgICAgICAgKGN1cnJlbnQtbWVzc2FnZSkKICAgICAgICAgICAgICAgICAgKG5vdCAoc3RyaW5n
LXByZWZpeC1wIHRleHQgKGN1cnJlbnQtbWVzc2FnZSkpKSkKKyAgICAgIChzZXRxIHVwZGF0ZS10
ZXh0IChjb25jYXQgKGlmIHVwZGF0ZS10ZXh0ICIgIiAiIikgdXBkYXRlLXRleHQpKQogICAgICAg
KHBjYXNlIHN0YXRlCiAgICAgICAgICgocHJlZCBmbG9hdHApCiAgICAgICAgICAoaWYgKHBsdXNw
IHN0YXRlKQotICAgICAgICAgICAgIChtZXNzYWdlICIlcyVkJSUiIHRleHQgKCogc3RhdGUgMTAw
LjApKQotICAgICAgICAgICAobWVzc2FnZSAiJXMiIHRleHQpKSkKKyAgICAgICAgICAgICAobWVz
c2FnZSAiJXMlZCUlJXMiIHRleHQgKCogc3RhdGUgMTAwLjApIHVwZGF0ZS10ZXh0KQorICAgICAg
ICAgICAobWVzc2FnZSAiJXMlcyIgdGV4dCB1cGRhdGUtdGV4dCkpKQogICAgICAgICAoKHByZWQg
aW50ZWdlcnApCiAgICAgICAgICAobGV0ICgobWVzc2FnZS1sb2ctbWF4IG5pbCkKICAgICAgICAg
ICAgICAgIChwdWxzZS1jaGFyCiAgICAgICAgICAgICAgICAgKGFyZWYgcHJvZ3Jlc3MtcmVwb3J0
ZXItLXB1bHNlLWNoYXJhY3RlcnMKICAgICAgICAgICAgICAgICAgICAgICAobW9kIHN0YXRlIChs
ZW5ndGggcHJvZ3Jlc3MtcmVwb3J0ZXItLXB1bHNlLWNoYXJhY3RlcnMpKSkpKQotICAgICAgICAg
ICAobWVzc2FnZSAiJXMgJXMiIHRleHQgcHVsc2UtY2hhcikpKQorICAgICAgICAgICAobWVzc2Fn
ZSAiJXMgJXMlcyIgdGV4dCBwdWxzZS1jaGFyIHVwZGF0ZS10ZXh0KSkpCiAgICAgICAgICgnZG9u
ZQogICAgICAgICAgKG1lc3NhZ2UgIiVzZG9uZSIgdGV4dCkpKSkpKQogCi0oZGVmdW4gcHJvZ3Jl
c3MtcmVwb3J0ZXItZG8tdXBkYXRlIChyZXBvcnRlciB2YWx1ZSAmb3B0aW9uYWwgc3VmZml4KQor
KGRlZnVuIHByb2dyZXNzLXJlcG9ydGVyLWRvLXVwZGF0ZSAocmVwb3J0ZXIgdmFsdWUgJm9wdGlv
bmFsIHVwZGF0ZS10ZXh0KQogICAobGV0KiAoKHBhcmFtZXRlcnMgICAgICAoY2RyIHJlcG9ydGVy
KSkKIAkgKHVwZGF0ZS10aW1lICAgICAoYXJlZiBwYXJhbWV0ZXJzIDApKQogCSAobWluLXZhbHVl
ICAgICAgIChhcmVmIHBhcmFtZXRlcnMgMSkpCkBAIC03MjgxLDMxICs3Mjg3LDI2IEBAIHByb2dy
ZXNzLXJlcG9ydGVyLWRvLXVwZGF0ZQogCSAgICAgICAoc2V0Y2FyIHJlcG9ydGVyIChjZWlsaW5n
IChjYXIgcmVwb3J0ZXIpKSkpCiAJICAgICA7OyBQcmludCBtZXNzYWdlIG9ubHkgaWYgZW5vdWdo
IHRpbWUgaGFzIHBhc3NlZAogCSAgICAgKHdoZW4gZW5vdWdoLXRpbWUtcGFzc2VkCi0gICAgICAg
ICAgICAgICAoaWYgc3VmZml4Ci0gICAgICAgICAgICAgICAgICAgKGFzZXQgcGFyYW1ldGVycyA2
IHN1ZmZpeCkKLSAgICAgICAgICAgICAgICAgKHNldHEgc3VmZml4IChvciAoYXJlZiBwYXJhbWV0
ZXJzIDYpICIiKSkpCiAgICAgICAgICAgICAgICAocnVuLWhvb2std2l0aC1hcmdzICdwcm9ncmVz
cy1yZXBvcnRlci11cGRhdGUtZnVuY3Rpb25zCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIHJlcG9ydGVyCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICgvIHBl
cmNlbnRhZ2UgMTAwLjApKSkpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAo
LyBwZXJjZW50YWdlIDEwMC4wKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1
cGRhdGUtdGV4dCkpKSkKIAkgIDs7IFB1bHNpbmcgaW5kaWNhdG9yCiAJICAoZW5vdWdoLXRpbWUt
cGFzc2VkCi0gICAgICAgICAgICh3aGVuIChhbmQgdmFsdWUgKG5vdCBzdWZmaXgpKQotICAgICAg
ICAgICAgIChzZXRxIHN1ZmZpeCB2YWx1ZSkpCi0gICAgICAgICAgIChpZiBzdWZmaXgKLSAgICAg
ICAgICAgICAgIChhc2V0IHBhcmFtZXRlcnMgNiBzdWZmaXgpCi0gICAgICAgICAgICAgKHNldHEg
c3VmZml4IChvciAoYXJlZiBwYXJhbWV0ZXJzIDYpICIiKSkpCiAgICAgICAgICAgIChsZXQgKChp
bmRleCAoMSsgKGNhciByZXBvcnRlcikpKSkKIAkgICAgIChzZXRjYXIgcmVwb3J0ZXIgaW5kZXgp
CiAgICAgICAgICAgICAgKHJ1bi1ob29rLXdpdGgtYXJncyAncHJvZ3Jlc3MtcmVwb3J0ZXItdXBk
YXRlLWZ1bmN0aW9ucwogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVwb3J0ZXIK
LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGluZGV4KSkpKSkpCisgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBpbmRleAorICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgKG9yIHVwZGF0ZS10ZXh0IHZhbHVlKSkpKSkpKQogCiAoZGVmdW4gcHJvZ3Jlc3MtcmVw
b3J0ZXItZG9uZSAocmVwb3J0ZXIpCiAgICJQcmludCByZXBvcnRlcidzIG1lc3NhZ2UgZm9sbG93
ZWQgYnkgd29yZCBcImRvbmVcIiBpbiBlY2hvIGFyZWEuCiBDYWxsIHRoZSBmdW5jdGlvbnMgb24g
YHByb2dyZXNzLXJlcG9ydGVyLXVwZGF0ZS1mdW5jdGlvbnNgLiIKICAgKHJ1bi1ob29rLXdpdGgt
YXJncyAncHJvZ3Jlc3MtcmVwb3J0ZXItdXBkYXRlLWZ1bmN0aW9ucwogICAgICAgICAgICAgICAg
ICAgICAgIHJlcG9ydGVyCi0gICAgICAgICAgICAgICAgICAgICAgJ2RvbmUpKQorICAgICAgICAg
ICAgICAgICAgICAgICdkb25lCisgICAgICAgICAgICAgICAgICAgICAgbmlsKSkKIAogKGRlZm1h
Y3JvIGRvdGltZXMtd2l0aC1wcm9ncmVzcy1yZXBvcnRlciAoc3BlYyByZXBvcnRlci1vci1tZXNz
YWdlICZyZXN0IGJvZHkpCiAgICJMb29wIGEgY2VydGFpbiBudW1iZXIgb2YgdGltZXMgYW5kIHJl
cG9ydCBwcm9ncmVzcyBpbiB0aGUgZWNobyBhcmVhLgpkaWZmIC0tZ2l0IGEvbGlzcC9zeXN0ZW0t
dGFza2Jhci5lbCBiL2xpc3Avc3lzdGVtLXRhc2tiYXIuZWwKaW5kZXggOTczYjQyNmUwMjYuLmQx
ZmUyNzY4NDRkIDEwMDY0NAotLS0gYS9saXNwL3N5c3RlbS10YXNrYmFyLmVsCisrKyBiL2xpc3Av
c3lzdGVtLXRhc2tiYXIuZWwKQEAgLTI3Myw5ICsyNzMsOSBAQCBzeXN0ZW0tdGFza2Jhci0tdmFs
aWRhdGUtcHJvZ3Jlc3MKIAwKIDs7IGBwcm9ncmVzcy1yZXBvcnRlcicgc3VwcG9ydC4KIAotKGRl
ZnVuIHN5c3RlbS10YXNrYmFyLS1wcm9ncmVzcy1yZXBvcnRlci11cGRhdGUgKF9yZXBvcnRlciBz
dGF0ZSkKKyhkZWZ1biBzeXN0ZW0tdGFza2Jhci0tcHJvZ3Jlc3MtcmVwb3J0ZXItdXBkYXRlIChf
cmVwb3J0ZXIgc3RhdGUgX3VwZGF0ZS10ZXh0KQogICAiUHJvZ3Jlc3MgcmVwb3J0ZXIgc3lzdGVt
IHRhc2tiYXIgdXBkYXRlIGZ1bmN0aW9uLgotUkVQT1JURVIgYW5kIFNUQVRFIGFyZSB0aGUgc2Ft
ZSBhcyBpbgorUkVQT1JURVIsIFNUQVRFLCBhbmQgVVBEQVRFLVRFWFQgYXJlIHRoZSBzYW1lIGFz
IGluCiBgcHJvZ3Jlc3MtcmVwb3J0ZXItdXBkYXRlLWZ1bmN0aW9ucycuIgogICAod2hlbiBzeXN0
ZW0tdGFza2Jhci1tb2RlCiAgICAgKHBjYXNlIHN0YXRlCi0tIAoyLjU0LjAKCg==
--000000000000d3805f065393df4f--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#81134; Package emacs. Full text available.

Message received at 81134 <at> debbugs.gnu.org:


Received: (at 81134) by debbugs.gnu.org; 5 Jun 2026 18:09:53 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jun 05 14:09:53 2026
Received: from localhost ([127.0.0.1]:54786 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1wVYzQ-0007FD-Uv
	for submit <at> debbugs.gnu.org; Fri, 05 Jun 2026 14:09:53 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:8860)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <monnier@HIDDEN>)
 id 1wVYzO-0007Ev-A7
 for 81134 <at> debbugs.gnu.org; Fri, 05 Jun 2026 14:09:50 -0400
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D3AE21001CA;
 Fri, 05 Jun 2026 14:09:44 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1780682984;
 bh=TG6OIUps8L6djV8PFMm02byeiz9k/KQnuC3w1C/LqUc=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=fr1k162NAkbpGM0Gm6LeCMatqakLIBI0H+yu3ApDHBM1rDn2K3lsSOkdwjYFLezwy
 935CfkKi5d4CZnUWzBR2LjRhwkgQVpvBLAayg3q/gOFu9DJijerr+uW7+AJJxB4Q+v
 0gzCqtzyvDqd3RqbVOD1Ha3ynwr2qQQ+blFGoErB1vk2we+6ZG0LS19dOKOviQW+sS
 srBnOh+qoxAUE5hKQJWmt4147/sZKnMT6WB6202VoBbdtgQI5hmW8iEb1CfVs1jSWx
 LlmvLEW16n3XkO6HKbfMazBq0Y1QfRsW4KCyCQgmnS/VpeSt6wJVZurXWppcZQo27H
 5+seY9tHsApmQ==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id F3173100129;
 Fri, 05 Jun 2026 14:09:43 -0400 (EDT)
Received: from alfajor (modemcable209.196-177-173.mc.videotron.ca
 [173.177.196.209])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id CCA0E12018A;
 Fri,  5 Jun 2026 14:09:43 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: =?windows-1252?Q?St=E9phane?= Marks <shipmints@HIDDEN>
Subject: Re: bug#81134: [PATCH] Fix progress-reporter-update to display
 SUFFIX again
In-Reply-To: <CAN+1HbqAt+N-MnvrwP0WLZ19UO7UmJ0MsVUOSabyNgD6ift80g@HIDDEN>
Message-ID: <jwvh5ngsvyp.fsf-monnier+emacs@HIDDEN>
References: <q7mldd44nf3.fsf@HIDDEN>
 <CAN+1HbqbJcJMJmvOaBF1ZK7vVAOQ8PcuePU-FgUZ_L2h0orDWw@HIDDEN>
 <877bonzstp.fsf@HIDDEN>
 <jwvv7c60xcu.fsf-monnier+emacs@HIDDEN>
 <jwvjysm0whk.fsf-monnier+emacs@HIDDEN>
 <CAN+1Hbq78BMnKrMxiwB9FUVp1jmaqSheXjAdbD1JFCqYZG7K-g@HIDDEN>
 <CAN+1HbqAt+N-MnvrwP0WLZ19UO7UmJ0MsVUOSabyNgD6ift80g@HIDDEN>
Date: Fri, 05 Jun 2026 14:09:43 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL 0.306 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 81134
Cc: 81134 <at> debbugs.gnu.org, Aaron Zeng <azeng@HIDDEN>,
 Sean Whitton <spwhitton@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> I'm okay renaming SUFFIX to STEP or UPDATE-TEXT.  The most natural thing to
> me is to not store the suffix in the reporter and change
> 'progress-reporter-update-functions' to accept a suffix argument and make
> it ephemeral.  We can "open" the SUFFIX slot to reuse for another reason
> and not fuss with removing a single array element and avoid changing index
> references that come after it.

Works for me.


=== Stefan





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#81134; Package emacs. Full text available.

Message received at 81134 <at> debbugs.gnu.org:


Received: (at 81134) by debbugs.gnu.org; 5 Jun 2026 17:44:11 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jun 05 13:44:11 2026
Received: from localhost ([127.0.0.1]:54555 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1wVYaY-0005bJ-UT
	for submit <at> debbugs.gnu.org; Fri, 05 Jun 2026 13:44:11 -0400
Received: from mail-ua1-x933.google.com ([2607:f8b0:4864:20::933]:61620)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <shipmints@HIDDEN>)
 id 1wVYaW-0005b9-2G
 for 81134 <at> debbugs.gnu.org; Fri, 05 Jun 2026 13:44:08 -0400
Received: by mail-ua1-x933.google.com with SMTP id
 a1e0cc1a2514c-9639474a0c1so1717592241.2
 for <81134 <at> debbugs.gnu.org>; Fri, 05 Jun 2026 10:44:08 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1780681447; cv=none;
 d=google.com; s=arc-20240605;
 b=F/7I0oaqtS/OwI34xs6Ui8uXUSehHTjAFcPskoKPKFyuctHaZZK5M+aDG1NpTiWgr9
 xMnDRctWrFstHTyLZDuC7UI9imsefPlwfg6W8z1igWQAsNo0NweAXRniaFUTtC++AkoH
 7wG3a++hVlUWTBxI0Vdwfcj8MEPIrpNBZoiQv93DpEeBa09CEmLgLIrYgk7buomW7gT5
 3GAslYKbaRgJMWYwRzncxXUPU43onkoD3V1eKd8DmCRtM5QvFTwpWljemnb7kivvpZ5c
 ELeVxac7rNX6BhFt2LshkKUP1ScaCT9C5+cjoKw9WnPI+1o3Jwc5YpkRPOcf4uosdf5e
 pqEg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
 s=arc-20240605; 
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:dkim-signature;
 bh=vkgLA0PlDJUUUO3ATVZJIJugTy2fE5WPMKxY0qwSjB0=;
 fh=nBtl3DedU7AS9AEsIbuxXsvHyLEM8aP/FJ184Du6xHo=;
 b=Kv5dhyLHPVUqfuJ7vv70+mr8NnG96nSb+FYqeYAbjalpq9RrQCMsmBZn8VYVerf5NI
 XyYn3TqxHvCsIXrGeiDqGI4ctgX7VCz6kJUQ7TUPf1PuJkZ2oyi1Ya3IVams15YB55PI
 /deG/gTB0YoBi2YD56uDHbxYFJ+2M40atWMQmS6MnCb3t2NemKaBUfE6HH3z/sTq5Ywo
 HJVgpMlJ6MirHR9czqL7J+qAspfD/IBmYC4Fb2O1ZXr9c2V2CzwXY86fm5koUADNeYUO
 fgK3mZ+sKe/hqOxWjXHEwxI8MJyFc/zvtiYlUifVCNbqI9gMjajTXvSVokMpkkXRbNjK
 Phkw==; darn=debbugs.gnu.org
ARC-Authentication-Results: i=1; mx.google.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20251104; t=1780681447; x=1781286247; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=vkgLA0PlDJUUUO3ATVZJIJugTy2fE5WPMKxY0qwSjB0=;
 b=kDopdwux7kQbBO7tI+kiBW5oYq0VIhUtrDXQyDnVvfghCa6fjFCI3hupJz3RW7EVwi
 UmRGrUhrGKgATtGj+wax7/oNVRblUEd2cvKM6SItSVOZWHNchv64PNIm0LRQQwdseOsZ
 ppBWlm1gMDCpJYZ1Y9Kqk8JePLbaFlDRh0ivjz2Z4X7t6IqZqA5WxZJwJPlxMzT8wPgj
 d4HTSo2JpBOB6GfzGe9imRfxYNerFKG2D0xM5UeFI5HBja/c0Y0plrENm/3q00z4cqR8
 xC2+MdCvPJ3Y1Yq18zce1PeeOBgl88pdWkDr1IFv8mWMhrPMNNSGjFgvjpNWo7yEe5mZ
 tUIg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20251104; t=1780681447; x=1781286247;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=vkgLA0PlDJUUUO3ATVZJIJugTy2fE5WPMKxY0qwSjB0=;
 b=UHOY79VcZ2SjfBPFPA6u1oUDQZAON52ZTUVaKSPxOZ3TcOgP5i3OiZBrA69lXD2A5T
 tFB0YxsXAuKV7Y6hUt+VlzA6C+pjeec68929ddsdW4T4u2VJpup6vaQaKGJhq0/hgiQM
 7sIVyCh9M1nuwPpdojXmY5dRjRWcrpBPLe0P7fwxX7hzf1Is4uVaI661heOf1RLOAlxg
 pKmJvdW1v/dQEWS+4U53fvNHM0LnXklW3sYdZilyk/smeljFisYsaQ+cBVxj/4069TGK
 K/cMUD4PAut3NozcgjjmHGP1Zo7+XTSxjSCSeIG2e9qOy4/vXSIECX5nzqF7q6y0t8n8
 l2nw==
X-Forwarded-Encrypted: i=1;
 AFNElJ+J49QeRkhX0Tpr72k2IEw7A8+6miab/yB96EKYNt+UlMgFNU4HQGh8md9pio+iUpFeysCR3g==@debbugs.gnu.org
X-Gm-Message-State: AOJu0YyHB+a/G9eImtCtr4D3AVmYtb7a0mj6rKXbaqMZgELvAy+8RlEA
 nXXchkzQ4HAsi4qIefLW9KOO9Yblet0ZttlNbQjF/gmP4V8YeNjUfR5oNjbFfN8RIlVHjNygcpx
 pTvz512RnRDqKnaJXiu0vYtaF0lUnXr8=
X-Gm-Gg: Acq92OEUmu8PSPERCGo6IsDADhcH0k6rC1oxEk5cQ1lMtHnzilvRs6tqqrV3Uix70EZ
 HSgwZQyEwqWUj+aziSox1kT1KTi46jcHH/JVHw4D/thDUaq3mtYhB2cHIeG2kVe7VoSrkOIde3I
 dck2FINQgYfOJh0q/VaReh5WdjJJhVDWD5ZIvPYXWXn8SydUdSowks6+ghGczRa++EkEi8ReU87
 UIkABmFWjC1Tl0B653xu3wgN/eJ6q+JAAxSa+hTn0jDAnxmBEh7icKnUcM6MuAin2ZFMuEBxpiM
 dtai7j8+l3gAwQA5nCJQXROBBbKWS93TRGpZvDuN4ispjruBqgcCdQsix+55uJDCkE/jBZMEqdU
 qGCSQx6P25qKKJTNl34tCkTRQPbsi1q7HZdVqmtz+v+XrgSz6DzUmjOl1VWwd6cSO81aMb5PQyB
 A2RMwa/igFuHpJvJFzkzUUVwrLfr+o/g6IVM/JFXw=
X-Received: by 2002:a05:6102:3e23:b0:6cc:a388:1c7d with SMTP id
 ada2fe7eead31-6ff084a26bdmr2977235137.16.1780681447156; Fri, 05 Jun 2026
 10:44:07 -0700 (PDT)
MIME-Version: 1.0
References: <q7mldd44nf3.fsf@HIDDEN>
 <CAN+1HbqbJcJMJmvOaBF1ZK7vVAOQ8PcuePU-FgUZ_L2h0orDWw@HIDDEN>
 <877bonzstp.fsf@HIDDEN>
 <jwvv7c60xcu.fsf-monnier+emacs@HIDDEN>
 <jwvjysm0whk.fsf-monnier+emacs@HIDDEN>
 <CAN+1Hbq78BMnKrMxiwB9FUVp1jmaqSheXjAdbD1JFCqYZG7K-g@HIDDEN>
In-Reply-To: <CAN+1Hbq78BMnKrMxiwB9FUVp1jmaqSheXjAdbD1JFCqYZG7K-g@HIDDEN>
From: =?UTF-8?Q?St=C3=A9phane_Marks?= <shipmints@HIDDEN>
Date: Fri, 5 Jun 2026 13:43:56 -0400
X-Gm-Features: AVVi8CcSeQy6BUf87yor9sXKCQmZB7J2yVc65gUvy_apCrzxvUgo0cQAhCY8W1Q
Message-ID: <CAN+1HbqAt+N-MnvrwP0WLZ19UO7UmJ0MsVUOSabyNgD6ift80g@HIDDEN>
Subject: Re: bug#81134: [PATCH] Fix progress-reporter-update to display SUFFIX
 again
To: Stefan Monnier <monnier@HIDDEN>
Content-Type: multipart/alternative; boundary="0000000000001daed8065385357b"
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: 81134
Cc: 81134 <at> debbugs.gnu.org, Aaron Zeng <azeng@HIDDEN>,
 Sean Whitton <spwhitton@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.0 (/)

--0000000000001daed8065385357b
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 2, 2026 at 12:36=E2=80=AFPM St=C3=A9phane Marks <shipmints@gmai=
l.com> wrote:

> On Fri, May 29, 2026 at 4:58=E2=80=AFPM Stefan Monnier <monnier@HIDDEN=
real.ca>
> wrote:
>
>> >>> Stefan thought we should deprecate SUFFIX in
>> >>> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D79859#113 so I guess=
 we
>> >>> should reinstate it.
>> >> Adding Stefan.  It sounds like it might be worth rethinking the API t=
o
>> >> gain the functionality back?
>> > Aaron's example sounds good, so I agree it's worth de-deprecating it,
>> > but our doc should then clarify the intent of that argument.
>>
>> Also, its semantics is unclear: what should be displayed after
>>
>>     (progress-reporter-update PR VAL1 "foo")
>>     (progress-reporter-update PR VAL2)
>>
>> ?  Currently AFAICT, the answer is "it depends": depending on the `(>=3D
>> value (car reporter))` test, the first call may or may not call
>> `progress-reporter-do-update`: if it does then "foo" gets stashed in the
>> PR object and reused in the second call but if it doesn't, then "foo" is
>> ignored and the second call will use as SUFFIX whichever suffix was set
>> by previous calls.  I think that's a bug.
>>
>> So we need to clarify if it's kept between calls or not.  If it is, then
>> we should not drop it on the floor like we currently do (which will have
>> a performance impact).
>>
>
> I'll revise this patch once bug#80988 is installed.  Easier.
>

I'm okay renaming SUFFIX to STEP or UPDATE-TEXT.  The most natural thing to
me is to not store the suffix in the reporter and change
'progress-reporter-update-functions' to accept a suffix argument and make
it ephemeral.  We can "open" the SUFFIX slot to reuse for another reason
and not fuss with removing a single array element and avoid changing index
references that come after it.

OTOH, if someone really wants to interrogate a progress reporter for what
"step" it is on, that's a use case but a weak one.  The progress reporter
owner surely knows its own state.

Thoughts?

--0000000000001daed8065385357b
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon=
t-family:monospace"><span style=3D"font-family:Arial,Helvetica,sans-serif">=
On Tue, Jun 2, 2026 at 12:36=E2=80=AFPM St=C3=A9phane Marks &lt;<a href=3D"=
mailto:shipmints@HIDDEN">shipmints@HIDDEN</a>&gt; wrote:</span></div>=
</div><div class=3D"gmail_quote gmail_quote_container"><blockquote class=3D=
"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(2=
04,204,204);padding-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr"><div style=
=3D"font-family:monospace"><span style=3D"font-family:Arial,Helvetica,sans-=
serif">On Fri, May 29, 2026 at 4:58=E2=80=AFPM Stefan Monnier &lt;<a href=
=3D"mailto:monnier@HIDDEN" target=3D"_blank">monnier@HIDDEN=
l.ca</a>&gt; wrote:</span></div></div><div class=3D"gmail_quote"><blockquot=
e class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px s=
olid rgb(204,204,204);padding-left:1ex">&gt;&gt;&gt; Stefan thought we shou=
ld deprecate SUFFIX in<br>
&gt;&gt;&gt; <a href=3D"https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D798=
59#113" rel=3D"noreferrer" target=3D"_blank">https://debbugs.gnu.org/cgi/bu=
greport.cgi?bug=3D79859#113</a> so I guess we<br>
&gt;&gt;&gt; should reinstate it.<br>
&gt;&gt; Adding Stefan.=C2=A0 It sounds like it might be worth rethinking t=
he API to<br>
&gt;&gt; gain the functionality back?<br>
&gt; Aaron&#39;s example sounds good, so I agree it&#39;s worth de-deprecat=
ing it,<br>
&gt; but our doc should then clarify the intent of that argument.<br>
<br>
Also, its semantics is unclear: what should be displayed after<br>
<br>
=C2=A0 =C2=A0 (progress-reporter-update PR VAL1 &quot;foo&quot;)<br>
=C2=A0 =C2=A0 (progress-reporter-update PR VAL2)<br>
<br>
?=C2=A0 Currently AFAICT, the answer is &quot;it depends&quot;: depending o=
n the `(&gt;=3D<br>
value (car reporter))` test, the first call may or may not call<br>
`progress-reporter-do-update`: if it does then &quot;foo&quot; gets stashed=
 in the<br>
PR object and reused in the second call but if it doesn&#39;t, then &quot;f=
oo&quot; is<br>
ignored and the second call will use as SUFFIX whichever suffix was set<br>
by previous calls.=C2=A0 I think that&#39;s a bug.<br>
<br>
So we need to clarify if it&#39;s kept between calls or not.=C2=A0 If it is=
, then<br>
we should not drop it on the floor like we currently do (which will have<br=
>
a performance impact).<br></blockquote><div><br></div><div style=3D"font-fa=
mily:monospace">I&#39;ll revise this patch once=C2=A0bug#80988 is installed=
.=C2=A0 Easier.</div></div></div></blockquote><div><br></div><div class=3D"=
gmail_default" style=3D"font-family:monospace">I&#39;m okay renaming=C2=A0S=
UFFIX to STEP or UPDATE-TEXT.=C2=A0 The most natural thing to me is to not =
store the suffix in the reporter and change &#39;progress-reporter-update-f=
unctions&#39; to accept a suffix argument and make it ephemeral.=C2=A0 We c=
an &quot;open&quot; the SUFFIX slot to reuse for another reason and not fus=
s with removing a single array element and avoid changing index references =
that come after it.</div><div class=3D"gmail_default" style=3D"font-family:=
monospace"><br></div><div class=3D"gmail_default" style=3D"font-family:mono=
space">OTOH, if someone really wants to interrogate a progress reporter for=
 what &quot;step&quot; it is on, that&#39;s a use case but a weak one.=C2=
=A0 The progress reporter owner surely knows its own state.</div><div class=
=3D"gmail_default" style=3D"font-family:monospace"><br></div><div class=3D"=
gmail_default" style=3D"font-family:monospace">Thoughts?</div></div></div>

--0000000000001daed8065385357b--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#81134; Package emacs. Full text available.

Message received at 81134 <at> debbugs.gnu.org:


Received: (at 81134) by debbugs.gnu.org; 2 Jun 2026 16:36:40 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 02 12:36:40 2026
Received: from localhost ([127.0.0.1]:58689 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1wUS6Y-0004vf-9i
	for submit <at> debbugs.gnu.org; Tue, 02 Jun 2026 12:36:39 -0400
Received: from mail-vk1-xa36.google.com ([2607:f8b0:4864:20::a36]:58437)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <shipmints@HIDDEN>)
 id 1wUS6V-0004v6-IN
 for 81134 <at> debbugs.gnu.org; Tue, 02 Jun 2026 12:36:36 -0400
Received: by mail-vk1-xa36.google.com with SMTP id
 71dfb90a1353d-59eb501bcf0so1026028e0c.0
 for <81134 <at> debbugs.gnu.org>; Tue, 02 Jun 2026 09:36:35 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1780418195; cv=none;
 d=google.com; s=arc-20240605;
 b=BP0fZ9bHdD4vJJG23BKJWa+5KvpdIUYl0Fv4ZFZp0zN5aB39/y99BAgzJK2siv6VN2
 qkzeSsYnnYpG78Wxcs0UVphgj0d+WZRmqn69jOs/D5EyChLF5gEz5kdO5VVY9JOHG6Zc
 Knz+LNvqF6mpk+AVjDrF9B/z0L5CEpQzaGSFcqMlqH5XeT2VMDpQuxdUF/hOBe623a9p
 G5Ofunp7eHOaO0fEXmKQz/zKUSk+rC5dBzOTCY+VoGachJBSSZiRjor+oWUQwlvE+wGa
 nTrc8MROYN4MeRD0uVqpTewlifOy4dcfjEk+wTt0CvI2wV8HLqGB0zUAT/loTCRfS21I
 q0og==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
 s=arc-20240605; 
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:dkim-signature;
 bh=bB5HiyNU72JMGie83uVEa7aFjlI1RnEgl+n2omZGHe0=;
 fh=s1vnhX7VP7xt32CgDHGm+EwB2aKaNWaYCNki+R/82Lg=;
 b=Xm6vHBesMG8eUEtMmlz4PQfpsQSmKKmfCZpopVQP7gaWE9I9/skpHIGwhjs1CzQTZ+
 4tuOiOZEQvczTtA6aZ6qDwS8ZthsrT/+UPM+KvllUUIhBun+NmN2yDbhnotYg0O3Jpml
 TbKaTuAZXMPeHQKqYRwD7XhywcRKHZpgdh+fntrAalQBB5uSs9J/OltI7xgguaU+ykxk
 RQvh7axAxWYDt5vzpa7GYQM56bAODDTcVrwl3dSboBFp+peUqKudOhAQiVOYGyoI1utn
 qVP7W5UTcbbJeIZZXNFNmL87FwdN37RGxra6jVQGnv0EEU3sVqJ2aPLD9irPi0oX7NjN
 0Uhw==; darn=debbugs.gnu.org
ARC-Authentication-Results: i=1; mx.google.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20251104; t=1780418195; x=1781022995; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=bB5HiyNU72JMGie83uVEa7aFjlI1RnEgl+n2omZGHe0=;
 b=YGEWtU32OLA41ea4GIekCYEUSJeM/P5VxaE22P7S4DiHiaMGXZtMOpu1YEDdoVEAY1
 3/o4BAqhJGaug+gPjtPpxPfKFDWbGaOTGamS+Zgu73b9+9ehD2QOsMiZDHeBvA6OZ0Yt
 hBfIBV/CepT5P8dVFebclWGxKeTC/KThgdSa2KNCjUxp9mR+LyH6J+D2ycuHc+KSseKp
 5BYj+JyryHYU6Wenugkt9oLTUsKI5eWnXB2h0u4AMV1EOzKdobgdKjps1eO5QL0/Zpgt
 siSVppvpUxGoI3pz9Np1o9Q5l/YW3c/P8QSDayYQevkJn9y3/CXoFlP/JGuVXN5IUi7k
 zwIg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20251104; t=1780418195; x=1781022995;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=bB5HiyNU72JMGie83uVEa7aFjlI1RnEgl+n2omZGHe0=;
 b=l371nvye/fONpodJHEYcrUkV5BJzM4iwTjgDBzNFSiv46vhDhw1oD6fzPcTNY4CTY4
 YUxXK/97Jo+PW5W3cu1X7QGjnaKMUKosgAqviZN+SffJzfAY7BaalZICGrLql3l2TMLw
 MW6xssjemF8FIsNLbS/DWEMDs427a4WCRfx4iBidqqjk7lQIl3vE1UnQtVUGNexl9h3q
 wezWddO3s1TFIqH6RoIQ//GDTm3jYQR0OPyAd09+JUuVYIyHo3JmWkgATygAvQt50Gl8
 PhmfBI3LLYwjZsJJ6dEFQOw0qXK1iapW+MQrEyq6gPXPs9QBOKCKZEO3Nfqtzjj/Go/W
 cnrQ==
X-Forwarded-Encrypted: i=1;
 AFNElJ+VYwXHer4RKuPpkXXRh0cACVuodYy0xnnSvdpGFqEqCj+2n5+yDt/8lFictB+tVy8uCADMfw==@debbugs.gnu.org
X-Gm-Message-State: AOJu0Yy/Nh7x3Q2H290n4HTGVEFNZBw1omqLpm2uozJUgGUHiY0Zj+bG
 o//srFdBASeAaHwA0+zQl1c0IM8X/uNJUcwr2/or/PWMSbXasrkq3fXxH/IpJ1aZ1E1YCd4w21P
 V4QZJJBBLcF/PavnLWwD1Ad9AnRWOJsc=
X-Gm-Gg: Acq92OF2GLMc5YZ+O2sNdwQiZEgbhb3xOzR6ibXrt+dR4KUK6BqPUvyGQ2BK6qXmYcD
 +bN8L4VvdM0Q/p7aclR2ZkwI7rpknPGhGkYwmprFS7ZDy831ZyAnMYBn4WTESrUH2Tp0klssDLL
 Xpn3UlUEU9EuWutyN+30J89E6K9hp+w54yGF7GVobgfeczwH3vcmHMXEBd3hwTBbRWQkbla3XF2
 cuEkBK6qyaxH2smEDU6Q8BnSX95HjRKeqFmDMCsn0sYceO+J+d4w8jkben4OqvuRU743nB5Th/B
 Qj1+IlX4Qnh2a+uK7zoqCpJdNzQdAzqEPtvKH+NydXZIq4NMlnkvnmxdKBXie4+aXiAQqxdZ8jt
 /II7KtE00IPgi79itlxf0hgYTaN/sY1cD3ntZ6dReBOcyvo6PImriu81Vwg==
X-Received: by 2002:a05:6122:916:b0:5a4:6680:64f0 with SMTP id
 71dfb90a1353d-5a692d8387emr603142e0c.4.1780418194834; Tue, 02 Jun 2026
 09:36:34 -0700 (PDT)
MIME-Version: 1.0
References: <q7mldd44nf3.fsf@HIDDEN>
 <CAN+1HbqbJcJMJmvOaBF1ZK7vVAOQ8PcuePU-FgUZ_L2h0orDWw@HIDDEN>
 <877bonzstp.fsf@HIDDEN>
 <jwvv7c60xcu.fsf-monnier+emacs@HIDDEN>
 <jwvjysm0whk.fsf-monnier+emacs@HIDDEN>
In-Reply-To: <jwvjysm0whk.fsf-monnier+emacs@HIDDEN>
From: =?UTF-8?Q?St=C3=A9phane_Marks?= <shipmints@HIDDEN>
Date: Tue, 2 Jun 2026 12:36:23 -0400
X-Gm-Features: AVHnY4LXv7etAcjXLvaBmpLMRY394xWsbmu10MEePxo-xg7Fv5V3S7XiQ2lM0lU
Message-ID: <CAN+1Hbq78BMnKrMxiwB9FUVp1jmaqSheXjAdbD1JFCqYZG7K-g@HIDDEN>
Subject: Re: bug#81134: [PATCH] Fix progress-reporter-update to display SUFFIX
 again
To: Stefan Monnier <monnier@HIDDEN>
Content-Type: multipart/alternative; boundary="0000000000000e0769065347eadd"
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: 81134
Cc: 81134 <at> debbugs.gnu.org, Aaron Zeng <azeng@HIDDEN>,
 Sean Whitton <spwhitton@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.0 (/)

--0000000000000e0769065347eadd
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, May 29, 2026 at 4:58=E2=80=AFPM Stefan Monnier <monnier@HIDDEN=
al.ca>
wrote:

> >>> Stefan thought we should deprecate SUFFIX in
> >>> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D79859#113 so I guess =
we
> >>> should reinstate it.
> >> Adding Stefan.  It sounds like it might be worth rethinking the API to
> >> gain the functionality back?
> > Aaron's example sounds good, so I agree it's worth de-deprecating it,
> > but our doc should then clarify the intent of that argument.
>
> Also, its semantics is unclear: what should be displayed after
>
>     (progress-reporter-update PR VAL1 "foo")
>     (progress-reporter-update PR VAL2)
>
> ?  Currently AFAICT, the answer is "it depends": depending on the `(>=3D
> value (car reporter))` test, the first call may or may not call
> `progress-reporter-do-update`: if it does then "foo" gets stashed in the
> PR object and reused in the second call but if it doesn't, then "foo" is
> ignored and the second call will use as SUFFIX whichever suffix was set
> by previous calls.  I think that's a bug.
>
> So we need to clarify if it's kept between calls or not.  If it is, then
> we should not drop it on the floor like we currently do (which will have
> a performance impact).
>

I'll revise this patch once bug#80988 is installed.  Easier.

--0000000000000e0769065347eadd
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon=
t-family:monospace"><span style=3D"font-family:Arial,Helvetica,sans-serif">=
On Fri, May 29, 2026 at 4:58=E2=80=AFPM Stefan Monnier &lt;<a href=3D"mailt=
o:monnier@HIDDEN">monnier@HIDDEN</a>&gt; wrote:</span><=
/div></div><div class=3D"gmail_quote gmail_quote_container"><blockquote cla=
ss=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid =
rgb(204,204,204);padding-left:1ex">&gt;&gt;&gt; Stefan thought we should de=
precate SUFFIX in<br>
&gt;&gt;&gt; <a href=3D"https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D798=
59#113" rel=3D"noreferrer" target=3D"_blank">https://debbugs.gnu.org/cgi/bu=
greport.cgi?bug=3D79859#113</a> so I guess we<br>
&gt;&gt;&gt; should reinstate it.<br>
&gt;&gt; Adding Stefan.=C2=A0 It sounds like it might be worth rethinking t=
he API to<br>
&gt;&gt; gain the functionality back?<br>
&gt; Aaron&#39;s example sounds good, so I agree it&#39;s worth de-deprecat=
ing it,<br>
&gt; but our doc should then clarify the intent of that argument.<br>
<br>
Also, its semantics is unclear: what should be displayed after<br>
<br>
=C2=A0 =C2=A0 (progress-reporter-update PR VAL1 &quot;foo&quot;)<br>
=C2=A0 =C2=A0 (progress-reporter-update PR VAL2)<br>
<br>
?=C2=A0 Currently AFAICT, the answer is &quot;it depends&quot;: depending o=
n the `(&gt;=3D<br>
value (car reporter))` test, the first call may or may not call<br>
`progress-reporter-do-update`: if it does then &quot;foo&quot; gets stashed=
 in the<br>
PR object and reused in the second call but if it doesn&#39;t, then &quot;f=
oo&quot; is<br>
ignored and the second call will use as SUFFIX whichever suffix was set<br>
by previous calls.=C2=A0 I think that&#39;s a bug.<br>
<br>
So we need to clarify if it&#39;s kept between calls or not.=C2=A0 If it is=
, then<br>
we should not drop it on the floor like we currently do (which will have<br=
>
a performance impact).<br></blockquote><div><br></div><div class=3D"gmail_d=
efault" style=3D"font-family:monospace">I&#39;ll revise this patch once=C2=
=A0bug#80988 is installed.=C2=A0 Easier.</div></div></div>

--0000000000000e0769065347eadd--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#81134; Package emacs. Full text available.

Message received at 81134 <at> debbugs.gnu.org:


Received: (at 81134) by debbugs.gnu.org; 29 May 2026 20:58:19 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 29 16:58:19 2026
Received: from localhost ([127.0.0.1]:59784 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1wT4Ha-0002xW-Nj
	for submit <at> debbugs.gnu.org; Fri, 29 May 2026 16:58:19 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:20831)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <monnier@HIDDEN>)
 id 1wT4HY-0002wz-DB
 for 81134 <at> debbugs.gnu.org; Fri, 29 May 2026 16:58:17 -0400
Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
 by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 9051D4424D3;
 Fri, 29 May 2026 16:58:10 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1780088288;
 bh=9i2m6usrO7mUWS9awX/onoy4mAV8Yb+Yws7/PDZZSn8=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=hnt/U/Bl4MQx70/QwaowuFsNvZKNS6TX52Qdzt3RI2C8pmT+KAXB8B2TwjsRWLHgh
 sGxrqbkcU3SPq6svzqaerJZWvo1O/+/HdouDz4U7JVbD+qmYp3oDmyMtqItW5Acu/v
 K1Fka+AfhY0f0Z0btAiLHZ/8WUpQnfgmd7zdcIf3bZF6CdZy8TGOF6e+7mydszov91
 41Qy9kwlI1Bquose2SIREkscNrtzp3oiW+mCXFopLTyHOL+XkyTEX/2rdDKybB8u79
 0yU4Udz9Os9CIXj53RrvHupieEwzs7s3++0I8kBV8+nSHirTdv6P/S0WpRUehPW1Av
 989z0CEGMtGjQ==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 8CEC04424E6;
 Fri, 29 May 2026 16:58:08 -0400 (EDT)
Received: from alfajor (unknown [192.197.121.29])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7922B1207CF;
 Fri, 29 May 2026 16:58:08 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Sean Whitton <spwhitton@HIDDEN>
Subject: Re: bug#81134: [PATCH] Fix progress-reporter-update to display
 SUFFIX again
In-Reply-To: <jwvv7c60xcu.fsf-monnier+emacs@HIDDEN>
Message-ID: <jwvjysm0whk.fsf-monnier+emacs@HIDDEN>
References: <q7mldd44nf3.fsf@HIDDEN>
 <CAN+1HbqbJcJMJmvOaBF1ZK7vVAOQ8PcuePU-FgUZ_L2h0orDWw@HIDDEN>
 <877bonzstp.fsf@HIDDEN>
 <jwvv7c60xcu.fsf-monnier+emacs@HIDDEN>
Date: Fri, 29 May 2026 16:58:07 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 81134
Cc: 81134 <at> debbugs.gnu.org,
 =?windows-1252?Q?St=E9phane?= Marks <shipmints@HIDDEN>,
 Aaron Zeng <azeng@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

>>> Stefan thought we should deprecate SUFFIX in
>>> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=79859#113 so I guess we
>>> should reinstate it.
>> Adding Stefan.  It sounds like it might be worth rethinking the API to
>> gain the functionality back?
> Aaron's example sounds good, so I agree it's worth de-deprecating it,
> but our doc should then clarify the intent of that argument.

Also, its semantics is unclear: what should be displayed after

    (progress-reporter-update PR VAL1 "foo")
    (progress-reporter-update PR VAL2)

?  Currently AFAICT, the answer is "it depends": depending on the `(>=
value (car reporter))` test, the first call may or may not call
`progress-reporter-do-update`: if it does then "foo" gets stashed in the
PR object and reused in the second call but if it doesn't, then "foo" is
ignored and the second call will use as SUFFIX whichever suffix was set
by previous calls.  I think that's a bug.

So we need to clarify if it's kept between calls or not.  If it is, then
we should not drop it on the floor like we currently do (which will have
a performance impact).


=== Stefan





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#81134; Package emacs. Full text available.

Message received at 81134 <at> debbugs.gnu.org:


Received: (at 81134) by debbugs.gnu.org; 29 May 2026 20:37:52 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 29 16:37:52 2026
Received: from localhost ([127.0.0.1]:59621 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1wT3xn-0001MU-FF
	for submit <at> debbugs.gnu.org; Fri, 29 May 2026 16:37:52 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:44825)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <monnier@HIDDEN>)
 id 1wT3xk-0001Lq-FH
 for 81134 <at> debbugs.gnu.org; Fri, 29 May 2026 16:37:49 -0400
Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
 by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id D86DD81C86;
 Fri, 29 May 2026 16:37:42 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1780087057;
 bh=b820n+02B7DN1t93QNZ/7CpeNYOW/D7tlaFrG1E5wkA=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=TYvJTjXTDW9fpdQ81s9TyFM9SymFIYJ/Nrcw7F/3aNy5e3W/9oSur6I2QZ+Nafr+I
 JHsOVgkKBxODJiAXjSbcenHCkr4EBNoawjF2yGQJo6TfqEyLCh4/rN86E28KI2L7jK
 DjCxYv8EPklVzjdyTjVy3akOnizo2QackIu/21W2aSs6cBuBLvkABOKj8b4HeBBJYq
 uXscRn2XDCE8ijQAoVQOBZZkCzPetjxafzjLxPG0n52hFHaRFwiD4yT1WYu82vcYxL
 v52ROCvyOicv6BSqP2X44ZQR9/L/dCJGj9P93kzVyyyijLtGGiEEUBLBwI+MFbzfjC
 jNCYu3DHJxtow==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id D046E8168A;
 Fri, 29 May 2026 16:37:37 -0400 (EDT)
Received: from alfajor (unknown [192.197.121.29])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BCC5D120609;
 Fri, 29 May 2026 16:37:37 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Sean Whitton <spwhitton@HIDDEN>
Subject: Re: bug#81134: [PATCH] Fix progress-reporter-update to display
 SUFFIX again
In-Reply-To: <877bonzstp.fsf@HIDDEN>
Message-ID: <jwvv7c60xcu.fsf-monnier+emacs@HIDDEN>
References: <q7mldd44nf3.fsf@HIDDEN>
 <CAN+1HbqbJcJMJmvOaBF1ZK7vVAOQ8PcuePU-FgUZ_L2h0orDWw@HIDDEN>
 <877bonzstp.fsf@HIDDEN>
Date: Fri, 29 May 2026 16:37:37 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 81134
Cc: 81134 <at> debbugs.gnu.org,
 =?windows-1252?Q?St=E9phane?= Marks <shipmints@HIDDEN>,
 Aaron Zeng <azeng@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

>> Stefan thought we should deprecate SUFFIX in
>> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=79859#113 so I guess we
>> should reinstate it.
> Adding Stefan.  It sounds like it might be worth rethinking the API to
> gain the functionality back?

Aaron's example sounds good, so I agree it's worth de-deprecating it,
but our doc should then clarify the intent of that argument.

As it stands it doesn't say what the argument means, only what the
default backend does with it, which makes it hard to know what other
backends should do with it.  So I'd also suggest renaming it from
"suffix" to something that carries a bit more meaning, like
"current-step".


=== Stefan





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#81134; Package emacs. Full text available.

Message received at 81134 <at> debbugs.gnu.org:


Received: (at 81134) by debbugs.gnu.org; 28 May 2026 11:17:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 28 07:17:48 2026
Received: from localhost ([127.0.0.1]:33508 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1wSYkF-0000j9-Rk
	for submit <at> debbugs.gnu.org; Thu, 28 May 2026 07:17:48 -0400
Received: from fout-a7-smtp.messagingengine.com ([103.168.172.150]:33601)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <spwhitton@HIDDEN>)
 id 1wSYkC-0000ip-Or
 for 81134 <at> debbugs.gnu.org; Thu, 28 May 2026 07:17:45 -0400
Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42])
 by mailfout.phl.internal (Postfix) with ESMTP id 49D82EC01D6;
 Thu, 28 May 2026 07:17:39 -0400 (EDT)
Received: from phl-frontend-03 ([10.202.2.162])
 by phl-compute-02.internal (MEProxy); Thu, 28 May 2026 07:17:39 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name;
 h=cc:cc:content-transfer-encoding:content-type:content-type
 :date:date:from:from:in-reply-to:in-reply-to:message-id
 :mime-version:references:reply-to:subject:subject:to:to; s=fm2;
 t=1779967059; x=1780053459; bh=YZtteIK0ar/hNIbNvnNcBvyWTQVBcK/W
 PyOena5M/Ls=; b=IJtDhYFD768dC6Sq2xBYEyjcHEWtQJOW8EklDFBS2RQslO9C
 FTAyIo/H2BgBJ3aTxfPQQxuEf3hUlkMOitNPnO3wS7Ln/kdmYwIeEid9OFoYA1oo
 nzcGExlyHjIenB6Tudm0ubasxKa9snqSBwaL2o6jVL+nKM6Af4wVb4dtiRD/TgY2
 viRe100MccFY882drC0IGWlV6sexGwb0rGe+Ogz4Ey5WEn5UGstGMFIw0RO283bH
 9CixG7AL6QTqvNpy3VL/kYmwS854X0ztgOzRFaJ3cdIcLk9s0aKgGKGr9ELP4hWo
 c/RPUjxF3cNc/wGTIKu4AydL4au3dTQOikcn+A==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding
 :content-type:content-type:date:date:feedback-id:feedback-id
 :from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:subject:subject:to:to:x-me-proxy
 :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1779967059; x=
 1780053459; bh=YZtteIK0ar/hNIbNvnNcBvyWTQVBcK/WPyOena5M/Ls=; b=Z
 d1CVUhvrCXnBne1oTLzkalU95x9izVMAV9YYil/mqhJ1ECeq0sanuLWVxp6ysESj
 kCVixWrgl2PlChuD+yrldzR37net8xM23aXkfwaohER4Nzqle33VZUVctwOPEPbV
 euJN0pLpkRzd4YGRepXl8zQQKP4I+8tKBdOlgJAqCiNrCM0nwpOczoP+92K7m8If
 qPK5K5wFamV4Uen2J+btwqCUUIyQ43oOE2rXdGy7rhjl46th7Qj0tQf3luSqwSFZ
 hfgeMKS9a+kPPhpEM74HkvEnWW/nyTDvehGUshTiQKMh3tMeQpBLBhUNccBSocWy
 s0eb5AZmZepXNTDJNIzzg==
X-ME-Sender: <xms:UyQYapbQdYBiOAdOysVqo6bbJw7xJ_xI7S9EokR08dMsr5PYuDc3vg>
 <xme:UyQYauOh-MK9RNNQ-ubJzISxABIQ6aQ8PgZSczFJ2vv0EwLXu3mxqDHprJat3BUAF
 uKv_-2kOLhZ9U038QyeuhnVavUaJFv1BMR7LFWpB36GuF9Hy8HJnsOx>
X-ME-Received: <xmr:UyQYamYV1Cn8gk4Jz72Ou3T0Pw6IZeWcjLv_0ZbgtMTtTPgIEluXdpKMeDle-1y1UKKQ--9pTpb8>
X-ME-Proxy-Cause: dmFkZTFXQtmJ+SldGdIRBMJxzhABDKJHERnhPWL9Yndh+sXb8m7UsV4pNfAS70mTMo7iZh
 8cJbTGKA2m/twMY7OdBCYN59y10fLod2nedfx6j2fZDI6kGMf+cae97U9oIfZXYA/pkucV
 Lp0RUI+FfRTbrdPMtCM5NfqIHPOCiR0qgurJYfsRbM+pIpepmyEmSC4RPnH5RidHIGGL9l
 jP5Qu4F0uTR7hIpOM6OFB4OiOax6D2n11mxru238uHOPBDHZTtNoZjiaFnYZyDAObzoKbu
 Kamkej8DG5eDs0eUWM/GCZNnXe6XhvBk9C3VdBYsj02du69e1lYcI2ruah2g8JC9TLSSrG
 ln5WERrcLSEWtrhSXZG6uv+0wj1FcWVd8N4/fn+BWt2lrt0srqovPe7CrDRQMOTk/j8D/k
 Hffr+Kvzf/1tRqJtBJz0m2VN/L0FBmDMjzQzY7XQFNJLYm1Se8wK+Go9eiea3PaLehhy7C
 5Z+EadXndnJvceWTKtT0sik0ueoxX5J39Xocsgxi8VT+Bgl56nv3mKOXq2XQoOOfu0ATo3
 LeLwKr2G3LyC03tJA/V7YhQJMpBpODHHv6P+FRERGM+OX750frAkJxAVC21v3DQi7D0ckF
 QEWSVg7fXaAVZwRPHSFwjmPEP6fhnGCJHMIGq2Wc04cP7r2/PBeVWPS6QOMQ
X-ME-Proxy: <xmx:UyQYak0OJdfw3qoB_gjcrmXRKiK0fcNMiX8CYTuVmd0EDd_IfBx50w>
 <xmx:UyQYakdYh2Lqd5sXsNy-JcJ_kGThV__mQ9Wn9Kykc1MbvQj-2Bs61w>
 <xmx:UyQYatFGkZv6cfdhgc2SQ9BjUdeMod9V_fvMtgxlQfsmvN5ZKZNwBg>
 <xmx:UyQYat1_Oezhi7-V4Dv76RHtrkk4iWW_chMtBdyOtZ4XKGrElwI8eQ>
 <xmx:UyQYalIUtEqVIZ8nl9Sx_xFqz3MNO16A8fHAIkx2vCw2SwyZUHAc5I7E>
Feedback-ID: i62564b17:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu,
 28 May 2026 07:17:38 -0400 (EDT)
Received: by melete.silentflame.com (Postfix, from userid 1000)
 id 1A9257E670D; Thu, 28 May 2026 12:17:38 +0100 (BST)
From: Sean Whitton <spwhitton@HIDDEN>
To: =?utf-8?Q?St=C3=A9phane?= Marks <shipmints@HIDDEN>, Aaron Zeng
 <azeng@HIDDEN>, Stefan Monnier <monnier@HIDDEN>
Subject: Re: bug#81134: [PATCH] Fix progress-reporter-update to display
 SUFFIX again
In-Reply-To: <CAN+1HbqbJcJMJmvOaBF1ZK7vVAOQ8PcuePU-FgUZ_L2h0orDWw@HIDDEN>
References: <q7mldd44nf3.fsf@HIDDEN>
 <CAN+1HbqbJcJMJmvOaBF1ZK7vVAOQ8PcuePU-FgUZ_L2h0orDWw@HIDDEN>
Date: Thu, 28 May 2026 12:17:38 +0100
Message-ID: <877bonzstp.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 81134
Cc: 81134 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

St=C3=A9phane Marks [27/May  4:29pm -04] wrote:
> Stefan thought we should deprecate SUFFIX in
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D79859#113 so I guess we
> should reinstate it.

Adding Stefan.  It sounds like it might be worth rethinking the API to
gain the functionality back?

--=20
Sean Whitton




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#81134; Package emacs. Full text available.

Message received at 81134 <at> debbugs.gnu.org:


Received: (at 81134) by debbugs.gnu.org; 27 May 2026 20:29:36 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 27 16:29:36 2026
Received: from localhost ([127.0.0.1]:50188 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1wSKsh-0007wD-W2
	for submit <at> debbugs.gnu.org; Wed, 27 May 2026 16:29:36 -0400
Received: from mail-vk1-xa2e.google.com ([2607:f8b0:4864:20::a2e]:57702)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <shipmints@HIDDEN>)
 id 1wSKsc-0007vr-QV
 for 81134 <at> debbugs.gnu.org; Wed, 27 May 2026 16:29:33 -0400
Received: by mail-vk1-xa2e.google.com with SMTP id
 71dfb90a1353d-57512a429d1so9880428e0c.3
 for <81134 <at> debbugs.gnu.org>; Wed, 27 May 2026 13:29:30 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1779913770; cv=none;
 d=google.com; s=arc-20240605;
 b=Ca31PcMK6mwY65pj43a2JLMp5jjvV1P0ve/qHqJZsfltD0E7NFx5vM0WkTCMk5XL5a
 v2phILTzoN6fx7AqBNBlOmV2GI+CXJK5D/nZ28OnV7pQjrsWnSgICS3To2qS083cpE1T
 vbo/bQL6p9rfdn7iSca6g0GLiuWrVJkQDoGu1SRZAljiSbY5Lw7J4v9fm5xwDBXvI06x
 vikqb6y0JsX3ucqPDrgd11IHCpxlP53iWZzSoLxsgywGIygOCH90jzflaKwhf4rHzWHF
 3OwzTd/6xf197+xXfbIZzjOHtIho9gpereFaRjvu6+oPyTekTDSEIy4vJIXNzkN9E5Ft
 z9xg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
 s=arc-20240605; 
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:dkim-signature;
 bh=QSAM3Y+0kZhrbZ8H8V7GmfVQPobwRPZuhtKm3bOQjBg=;
 fh=EIo3Nty8lKC9caZ36++J4JbWvHAFCL+jkUWQGB1I684=;
 b=QV0A7sH6mn6zCgCqwXt8/bFfsn9M6eWpQQw3/eOfsGMPI9VaHB1C8LrM5ksoNqnTD7
 c3C+bb+fcZYqqFYV4Nd1LMDIYn3gB0u2cbnAWCJ41uGASc8h1ye5l/CPLke8K5dRc+R6
 fB9UsYhmunWsmr241W0234GC+AyRFYiKewAh+uMJ+lb8cIqV3c5InWAPh0+B/N92reDn
 Sz4c5ivck5E/yqiMGqRY742CoEQ+ZSWwT9DHqv+McyF5usyhWm1qISn1t97MyXPZawLe
 MO5GR4Y5ge6NAsoP2WGnPnbH68P1X2tcTJQN2I+nw/11Qfe68riDVaytcnxMTsR3KRUm
 1TOQ==; darn=debbugs.gnu.org
ARC-Authentication-Results: i=1; mx.google.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20251104; t=1779913770; x=1780518570; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=QSAM3Y+0kZhrbZ8H8V7GmfVQPobwRPZuhtKm3bOQjBg=;
 b=o77Nduk1Xci39Kh4OwL7HeTXJc+h4gyJ7CFm6ASDU/N/ydBfyHKC7oPpuDqaUNS60F
 QSXMtRQ8N4AWRFg1qN9wjmJf3fQtgMh81Lq//umYkwM8qOu9091EeT1SBu8nyvl4O6gk
 1eUTMsYl/LFfxgN5psbnIsPw+QOj5jSDkZHv5bobAISJur8U5IbgDN4WzOWk96rHSaqU
 1UEqqFj0p0xT5Wszmexfg3qUEv55sAQ5ECWIDyMWbjSXspDnXstSij4f2gICUlN/OHBk
 90laTec4O0iTZHLL7Abhp2lM8XdWL2fwth+36oCKdLx3EYbEfbIW+ur/iUqNX6mJFM6N
 FKzQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20251104; t=1779913770; x=1780518570;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=QSAM3Y+0kZhrbZ8H8V7GmfVQPobwRPZuhtKm3bOQjBg=;
 b=X1nS1vuXcOyaJEAE/ui8HMQCh5IzjAi0m/u/kYpCrXC52LBOiqtB7HKvuiwZReDlw2
 wn4+9GVh6Obv4Qh4F1xv9LvN09hJEKtuUhWpctgfxyknpaNagMMOiMpLDu8pt01v2Hfn
 CkV3hth6JbTtrXfiKa1J+/C1vcpQnXDfMUZogT3nbeCpnjL+85OITUa0sOGT1BwsQrPx
 4OktpLrt67k27nW1Lrai4sIVeyQKpUmdr7eNQHPK9TffBY2+TBHKz4Y8/kxr/W3y/K+h
 6P16zcyp6hrgMzDJ6ladK0Zl7yaZy4cD4s+P9PDitmFFcVnfjhhlMNqS452cOgswWFaK
 IW5Q==
X-Gm-Message-State: AOJu0Yw1qpXuyxagbpu99+9RI4ANLZyOexxPU94fbLXZV0w5fTx4Xsbk
 kDU7kyz+8NCPILVotbU5qH3OQR2ZJkl/0b5uHXpQzY1yrE95NfcEBMF0nYO+j3y0yYQz9pfA2Y4
 CcpoTE8aa4i0VN5Zn9VcDkLqSd8zs6TM=
X-Gm-Gg: Acq92OEcyIAK7DMVzRt+fxFsP3K/VP+pW5HHUf2WICLPjlAWVKehpIMz+wBZ18lMseO
 qUcv/4wrCZxgYq0WCNr3gpL9R4DbpBpaJ/V5NncO3AVJj5I2bEHoynDMB7aPs/uG8xYCMpg5iLq
 GGB2vdnYSMWud+RCORINEo0KEVQ38un+H0iqrzMwUjAOxKHjoxI4up4N5CCqMGRFR4V7vHV0hrE
 FrGsJlYXRUTVwS0K039G1zs3jDPSKYH9Pr387TyO/se3h4UjWEk0NyiDkl5okqTX7cd7qK75DxB
 pJQrNWkEPbT5Qjh4THnnwjfnq0SSi1T6URQM0QbTwZgX/dufw6Nkus2/2c44JW6l/+jXMnTfSnx
 slSuJ7Rt7H2hjo67ZBeaSqJwEudmniBc7hAeWbApEQoilbrGD0Mm8NjBFgqk=
X-Received: by 2002:a05:6122:e26d:b0:575:e5d7:6f1c with SMTP id
 71dfb90a1353d-5865f625831mr13270852e0c.1.1779913769861; Wed, 27 May 2026
 13:29:29 -0700 (PDT)
MIME-Version: 1.0
References: <q7mldd44nf3.fsf@HIDDEN>
In-Reply-To: <q7mldd44nf3.fsf@HIDDEN>
From: =?UTF-8?Q?St=C3=A9phane_Marks?= <shipmints@HIDDEN>
Date: Wed, 27 May 2026 16:29:18 -0400
X-Gm-Features: AVHnY4K3tBTPZdMerrW7SD-G9Zk28PAuyT1cTCZAhQgCKsJoXGYmpMCH2v8TnMk
Message-ID: <CAN+1HbqbJcJMJmvOaBF1ZK7vVAOQ8PcuePU-FgUZ_L2h0orDWw@HIDDEN>
Subject: Re: bug#81134: [PATCH] Fix progress-reporter-update to display SUFFIX
 again
To: Aaron Zeng <azeng@HIDDEN>
Content-Type: multipart/alternative; boundary="000000000000fbc6100652d277e5"
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: 81134
Cc: 81134 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.0 (/)

--000000000000fbc6100652d277e5
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, May 27, 2026 at 4:19=E2=80=AFPM Aaron Zeng via Bug reports for GNU =
Emacs,
the Swiss army knife of text editors <bug-gnu-emacs@HIDDEN> wrote:

> Hello,
>
> At my site, we have some commands which use progress-reporter-update
> to display feedback while performing some expensive operations on a list
> of files.  I noticed that in Emacs 31, the SUFFIX argument no longer
> seems to be displayed in the echo area.
>
> I see that the SUFFIX argument has been marked as obsolete in the
> docstring, but while it still exists, I believe the function should
> still use it.
>
> I tested the patch with the following short example:
>
> (let ((p (make-progress-reporter "editing files...")))
>   (progress-reporter-update p nil "foo.txt")
>   (sleep-for 1)
>   (progress-reporter-update p nil "bar.txt")
>   (sleep-for 1)
>   (progress-reporter-done p))
>
> By the way, I think the SUFFIX argument is pretty useful.  If you want
> to report percentage progress while also giving some visual feedback to
> the user on what exactly is being worked on (e.g., if maybe one of the
> many files being operated on is super slow), SUFFIX seems like the ideal
> way to do so.
>
> Best,
> Aaron
>
> In GNU Emacs 31.0.60 (build 5, x86_64-pc-linux-gnu, X toolkit, cairo
>  version 1.15.12, Xaw scroll bars) of 2026-05-27 built on
>  igm-qws-u12685a
> Repository revision: c3babe4b8966c3ada6305b2af85e24398190a14f
> Repository branch: emacs-31
> Windowing system distributor 'The X.Org Foundation', version 11.0.1201100=
0
> System Description: Rocky Linux 8.10 (Green Obsidian)
>
> Configured using:
>  'configure --with-x-toolkit=3Dlucid --without-gpm --without-gconf
>  --without-selinux --without-imagemagick --with-modules --with-gif=3Dno
>  --with-cairo --with-rsvg --without-compress-install --with-tree-sitter
>  --with-native-compilation=3Daot
>
>  PKG_CONFIG_PATH=3D/usr/local/home/garnish/libtree-sitter/0.22.6-1/lib/pk=
gconfig/'
>

Stefan thought we should deprecate SUFFIX in
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D79859#113 so I guess we
should reinstate it.

--000000000000fbc6100652d277e5
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon=
t-family:monospace"><span style=3D"font-family:Arial,Helvetica,sans-serif">=
On Wed, May 27, 2026 at 4:19=E2=80=AFPM Aaron Zeng via Bug reports for GNU =
Emacs, the Swiss army knife of text editors &lt;<a href=3D"mailto:bug-gnu-e=
macs@HIDDEN">bug-gnu-emacs@HIDDEN</a>&gt; wrote:</span></div></div><div c=
lass=3D"gmail_quote gmail_quote_container"><blockquote class=3D"gmail_quote=
" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);=
padding-left:1ex">Hello,<br>
<br>
At my site, we have some commands which use progress-reporter-update<br>
to display feedback while performing some expensive operations on a list<br=
>
of files.=C2=A0 I noticed that in Emacs 31, the SUFFIX argument no longer<b=
r>
seems to be displayed in the echo area.<br>
<br>
I see that the SUFFIX argument has been marked as obsolete in the<br>
docstring, but while it still exists, I believe the function should<br>
still use it.<br>
<br>
I tested the patch with the following short example:<br>
<br>
(let ((p (make-progress-reporter &quot;editing files...&quot;)))<br>
=C2=A0 (progress-reporter-update p nil &quot;foo.txt&quot;)<br>
=C2=A0 (sleep-for 1)<br>
=C2=A0 (progress-reporter-update p nil &quot;bar.txt&quot;)<br>
=C2=A0 (sleep-for 1)<br>
=C2=A0 (progress-reporter-done p))<br>
<br>
By the way, I think the SUFFIX argument is pretty useful.=C2=A0 If you want=
<br>
to report percentage progress while also giving some visual feedback to<br>
the user on what exactly is being worked on (e.g., if maybe one of the<br>
many files being operated on is super slow), SUFFIX seems like the ideal<br=
>
way to do so.<br>
<br>
Best,<br>
Aaron<br>
<br>
In GNU Emacs 31.0.60 (build 5, x86_64-pc-linux-gnu, X toolkit, cairo<br>
=C2=A0version 1.15.12, Xaw scroll bars) of 2026-05-27 built on<br>
=C2=A0igm-qws-u12685a<br>
Repository revision: c3babe4b8966c3ada6305b2af85e24398190a14f<br>
Repository branch: emacs-31<br>
Windowing system distributor &#39;The X.Org Foundation&#39;, version 11.0.1=
2011000<br>
System Description: Rocky Linux 8.10 (Green Obsidian)<br>
<br>
Configured using:<br>
=C2=A0&#39;configure --with-x-toolkit=3Dlucid --without-gpm --without-gconf=
<br>
=C2=A0--without-selinux --without-imagemagick --with-modules --with-gif=3Dn=
o<br>
=C2=A0--with-cairo --with-rsvg --without-compress-install --with-tree-sitte=
r<br>
=C2=A0--with-native-compilation=3Daot<br>
=C2=A0PKG_CONFIG_PATH=3D/usr/local/home/garnish/libtree-sitter/0.22.6-1/lib=
/pkgconfig/&#39;<br></blockquote><div><br></div><div class=3D"gmail_default=
" style=3D""><font face=3D"monospace">Stefan thought we should deprecate SU=
FFIX in=C2=A0<a href=3D"https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D798=
59#113" style=3D"">https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D79859#11=
3</a>=C2=A0so I guess we should reinstate it.</font></div><div><br></div><d=
iv>=C2=A0</div></div></div>

--000000000000fbc6100652d277e5--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#81134; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 27 May 2026 20:18:34 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 27 16:18:34 2026
Received: from localhost ([127.0.0.1]:50094 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1wSKi1-00074r-PX
	for submit <at> debbugs.gnu.org; Wed, 27 May 2026 16:18:34 -0400
Received: from lists1p.gnu.org ([2001:470:142::17]:33234)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <azeng@HIDDEN>)
 id 1wSKhw-000742-IM
 for submit <at> debbugs.gnu.org; Wed, 27 May 2026 16:18:32 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <azeng@HIDDEN>)
 id 1wSKhp-0004Pz-4t
 for bug-gnu-emacs@HIDDEN; Wed, 27 May 2026 16:18:21 -0400
Received: from mxout5.mail.janestreet.com ([64.215.233.18])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <azeng@HIDDEN>)
 id 1wSKhl-00077i-Jo
 for bug-gnu-emacs@HIDDEN; Wed, 27 May 2026 16:18:20 -0400
From: Aaron Zeng <azeng@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: [PATCH] Fix progress-reporter-update to display SUFFIX again
Date: Wed, 27 May 2026 16:17:52 -0400
Message-ID: <q7mldd44nf3.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com;
 s=waixah; t=1779913096;
 bh=q1ucGEpP3L01r6EwqTcrrnVefhTedfjBH+Ztr3y87Do=;
 h=From:To:Cc:Subject:Date;
 b=O/Q8/wq0YVs19rfMYmZIMI2Po2ql8ZXbPp8BUZlyn6rTeu7BqyAdjrfqgtQgIgVMx
 IvU00TJEOzShw8fXbmCCyTx57OG/stBf4O5mzEAHYYYy5L63E+9lFi8VUiRWJC5SR3
 OGYL9Ygi0wbfUDgy/u5xCOIG57fg6YI/awWT9pQDqYTc7VtyxTWIMu+nRYVnQAxqfk
 P1/aF+ZkXfxqiBblzuSQ++4w6AAcLaMMRFPIqlnp9jtGCMelKj6A3VIjzZ4vY0vuHX
 anBDMFwMBnZH3HgjHm3mszPJGh+QRMFkUBoEB91uR/HiohpaT/4m80ROFto7E+pBcN
 xgYg2B3fUPUtQ==
Received-SPF: pass client-ip=64.215.233.18; envelope-from=azeng@HIDDEN;
 helo=mxout5.mail.janestreet.com
X-Spam_score_int: -70
X-Spam_score: -7.1
X-Spam_bar: -------
X-Spam_report: (-7.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5,
 RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-Debbugs-Envelope-To: submit
Cc: azeng@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)

--=-=-=
Content-Type: text/plain

Hello,

At my site, we have some commands which use progress-reporter-update
to display feedback while performing some expensive operations on a list
of files.  I noticed that in Emacs 31, the SUFFIX argument no longer
seems to be displayed in the echo area.

I see that the SUFFIX argument has been marked as obsolete in the
docstring, but while it still exists, I believe the function should
still use it.

I tested the patch with the following short example:

(let ((p (make-progress-reporter "editing files...")))
  (progress-reporter-update p nil "foo.txt")
  (sleep-for 1)
  (progress-reporter-update p nil "bar.txt")
  (sleep-for 1)
  (progress-reporter-done p))

By the way, I think the SUFFIX argument is pretty useful.  If you want
to report percentage progress while also giving some visual feedback to
the user on what exactly is being worked on (e.g., if maybe one of the
many files being operated on is super slow), SUFFIX seems like the ideal
way to do so.

Best,
Aaron

In GNU Emacs 31.0.60 (build 5, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.15.12, Xaw scroll bars) of 2026-05-27 built on
 igm-qws-u12685a
Repository revision: c3babe4b8966c3ada6305b2af85e24398190a14f
Repository branch: emacs-31
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Rocky Linux 8.10 (Green Obsidian)

Configured using:
 'configure --with-x-toolkit=lucid --without-gpm --without-gconf
 --without-selinux --without-imagemagick --with-modules --with-gif=no
 --with-cairo --with-rsvg --without-compress-install --with-tree-sitter
 --with-native-compilation=aot
 PKG_CONFIG_PATH=/usr/local/home/garnish/libtree-sitter/0.22.6-1/lib/pkgconfig/'


--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
 filename=0001-Fix-progress-reporter-update-to-display-SUFFIX-again.patch

From efab0ed61424bf31521a084ab3742f2d448cfb23 Mon Sep 17 00:00:00 2001
From: "Aaron L. Zeng" <azeng@HIDDEN>
Date: Wed, 27 May 2026 15:28:33 -0400
Subject: [PATCH] Fix progress-reporter-update to display SUFFIX again

* lisp/subr.el (progress-reporter-echo-area): Restore display
of SUFFIX to the echo area.
---
 lisp/subr.el | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/lisp/subr.el b/lisp/subr.el
index d97598ab61f..1334964dff7 100644
--- a/lisp/subr.el
+++ b/lisp/subr.el
@@ -7230,20 +7230,23 @@ progress-reporter-echo-area
 
 Do not emit a message if the reporter context is `async' and the echo
 area is busy with something else."
-  (let ((text (progress-reporter-text reporter)))
+  (let ((text (progress-reporter-text reporter))
+        (suffix (if-let* ((suffix (aref (cdr reporter) 6)))
+                    (concat " " suffix)
+                  "")))
     (unless (and (eq (progress-reporter-context reporter) 'async)
                  (current-message)
                  (not (string-prefix-p text (current-message))))
       (pcase state
         ((pred floatp)
          (if (plusp state)
-             (message "%s%d%%" text (* state 100.0))
-           (message "%s" text)))
+             (message "%s%d%%%s" text (* state 100.0) suffix)
+           (message "%s%s" text suffix)))
         ((pred integerp)
          (let ((message-log-max nil)
                (pulse-char (aref progress-reporter--pulse-characters
                                  state)))
-           (message "%s %s" text pulse-char)))
+           (message "%s %s%s" text pulse-char suffix)))
         ('done
          (message "%sdone" text))))))
 
-- 
2.43.7


--=-=-=--




Acknowledgement sent to Aaron Zeng <azeng@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#81134; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sat, 6 Jun 2026 11:30:03 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.