Received: (at 81319) by debbugs.gnu.org; 6 Jul 2026 11:20:52 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jul 06 07:20:52 2026 Received: from localhost ([127.0.0.1]:52320 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1wghNb-0007Sh-P9 for submit <at> debbugs.gnu.org; Mon, 06 Jul 2026 07:20:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60804) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1wghNZ-0007S7-G3 for 81319 <at> debbugs.gnu.org; Mon, 06 Jul 2026 07:20:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1wghNT-0005wu-32; Mon, 06 Jul 2026 07:20:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=o2fMiAO8yUGHRm62qNXeZ/OhG62n1S1OXnItxLdqu2Q=; b=SOb98FRVWgsP IKxEBCIyrtbFNE0quLtCxxXMecEnc+36YloWPtcJb/dve7yuRoTnSzJrjwVJKoBZb0xhYN3y6dkeQ XgGVqK25g2K4IUbljolKQMoxVZMaRMxVYwNGDtEWELsDvWZcVBo/FvDDpYGVx/xHocHtih0HnKP8L pQVeOwxM0NPJVZbZc+1Ii7ABYGZPz0qQiQ3ObI+n2bkF9aoQWKTzgdpMiAC5LJrPf1YYspBYgLEKq JBCE+sCdHWlCbW+Ox45nyvDs9DWwZK6SUJhtmCZAyTAGOHoQ2owB8t/LSSkY85q4JNkNfB1zfsWKa 58ehgi/QsV4Ljy0YIHYQmA==; Date: Mon, 06 Jul 2026 14:20:39 +0300 Message-Id: <86echg8iuw.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: "J.D. Smith" <jdtsmith@HIDDEN> In-Reply-To: <m2echhh2gt.fsf@HIDDEN> (jdtsmith@HIDDEN) Subject: Re: bug#81319: [PATCH] 31.0.90; new image scale check causes frequent image cache miss References: <m28q7x7bpi.fsf@HIDDEN> <86wlvheah7.fsf@HIDDEN> <m233y570dq.fsf@HIDDEN> <8165654f-7f85-4f32-84e6-bbdf6a0a80ad@HIDDEN> <87bjco4gwr.fsf@HIDDEN> <CA+TD5hhX0uDzGSOm1oPYvFU=FeXwezbg5TJUXrWvidM1MrCBEw@HIDDEN> <878q7s4c06.fsf@HIDDEN> <CA+TD5hhi658gZ7mYLo4moeo=Qb7LWUW=oZ-Vq=R0yxvXYKm3Jg@HIDDEN> <m2qzlkl24q.fsf@HIDDEN> <86tsqd98k9.fsf@HIDDEN> <akoek1-BW2hSOKd8@HIDDEN> <m2ik6thatb.fsf@HIDDEN> <86ldbp8tst.fsf@HIDDEN> <m2echhh2gt.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 81319 Cc: alan@HIDDEN, 81319 <at> debbugs.gnu.org, tmarjeski@HIDDEN, dmitry@HIDDEN, johan.myreen@HIDDEN, spwhitton@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: "J.D. Smith" <jdtsmith@HIDDEN> > Cc: alan@HIDDEN, 81319 <at> debbugs.gnu.org, tmarjeski@HIDDEN, > dmitry@HIDDEN, johan.myreen@HIDDEN, spwhitton@HIDDEN > Date: Sun, 05 Jul 2026 11:37:38 -0400 > > Eli Zaretskii <eliz@HIDDEN> writes: > > >> From: "J.D. Smith" <jdtsmith@HIDDEN> > >> Cc: Eli Zaretskii <eliz@HIDDEN>, Sean Whitton <spwhitton@HIDDEN>, > >> johan.myreen@HIDDEN, tmarjeski@HIDDEN, 81319 <at> debbugs.gnu.org, > >> dmitry@HIDDEN > >> Date: Sun, 05 Jul 2026 08:37:20 -0400 > >> > >> Alan Third <alan@HIDDEN> writes: > >> > >> > On Sun, Jul 05, 2026 at 10:53:10AM +0300, Eli Zaretskii wrote: > >> >> Is the way I've run the benchmark supposed to produce valid results? > >> >> If not, would it be possible to modify the recipe to make the results > >> >> reflect the issue we are discussing here, but without using > >> >> ImageMagick? > >> > >> No, that should not exercise the bug. > > > > Or are you saying that it only affects ImageMagick images? > > That was my claim. But I have taken an even closer look, and I now > think this may not affect other builds aside from emacs-mac, which would > would explain why no one is seeing the 20x cache miss penalty I see. > > The original logic of the bug: > > 1. compute_image_size is the only place image_compute_scale is called > with an img pointer. Calling compute_image_size is a necessary > precondition for the "scale" part of the image cache check to > succeed. > > 2. Leaving aside SVG images, compute_image_size is /only/ called late in > image_set_transform. > > 3. image_set_transform returns early for type=imagemagick images (except > on PGTK). > > 4. Outcome: image_compute_scale is never called, cache check always > fails. In an MS-Windows build without ImageMagick, I have just run with a breakpoint in image_compute_scale, conditioned on img != NULL, and I get the breakpoint hit each time the tool bar images are displayed, and also if I visit the PNG file whose URL you posted a few messages back, Polarlicht_2_kmeans_16_large.png. So the above seems to be inaccurate, or maybe I'm missing something. Please keep in mind that the Windows build defines HAVE_NATIVE_TRANSFORMS, as many other configurations. So ImageMagick is not needed to activate the image transforms.
bug-gnu-emacs@HIDDEN:bug#81319; Package emacs.
Full text available.Received: (at 81319) by debbugs.gnu.org; 5 Jul 2026 17:42:25 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jul 05 13:42:25 2026 Received: from localhost ([127.0.0.1]:37165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1wgQrF-0000L6-JV for submit <at> debbugs.gnu.org; Sun, 05 Jul 2026 13:42:24 -0400 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]:54358) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <johan.myreen@HIDDEN>) id 1wgQrA-0000Jn-NY for 81319 <at> debbugs.gnu.org; Sun, 05 Jul 2026 13:42:19 -0400 Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-2cace7da66eso19546315ad.0 for <81319 <at> debbugs.gnu.org>; Sun, 05 Jul 2026 10:42:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1783273330; cv=none; d=google.com; s=arc-20260327; b=qrPQ7wZH6hh7/vRvttIIQZzSVQjdoW+F9Io58KQLoUgtoadkDX3/BLHHz3zB5fxMW/ KNR7hvxuPiYXTc2Lstka3pfYwAVv0YZ7ac2YJ3xnLW9LWf4ZeJRWNQ+BLqYdhzyij3Ey /HRnSviav5xohftKfvoqP9UA4ySSZGOX9uSuqdDYKM2fnUw7uJQk0tFUm1TIj7ysKlIy 6Iup1G5e6XGxPy3ZYqyF+yLt/DpQsohKUs8IuYyno5VE9D0EsAum5nSNsbNNc9yQXKYQ 5G1oD12CrI5BQ70jnWWQpl2ny75JuNYKzyCQoerljg/kZBcn2k9FcKZHsDGNx3EocU3Q dILw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=KwhEOHc118VXqlBvOyxJZDvb06pRD5c4TH7sDppnvBw=; fh=PAN3juCpUIeCPg4RnFt6U0zmGmrVXXaVAVooBVvDcio=; b=LvU3Ul+OPAglsdR9B/txCuZMOSh81lTNwc5cfZ9FSeHZGEQ/phSTjCMRNkBycq3MBb vsAcDHOTIIfafpREhu1mkwD52FR5Mr1/Yhf7ZbrCaYDtXEbiuC21Or//6flhYC7lKfxd 0VyulLZ23feRF7VEBmfudLshj8+hP2U29WptjNkIEWbb4T5R98mZP2CmZ/CLtYD2342j 1j8BCueDVoYrOo6Th03tSm/SRBp1rBju9+lmV8GymBqUkHTGsLpwuLnMor6dR79d/zbu fA1u33sKjEqNrqbFM4VIq0vpof2GYJCMafA+XxefeP8LOngCnHbzAkTh998UhG4OeaDl 1xIQ==; darn=debbugs.gnu.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783273330; x=1783878130; darn=debbugs.gnu.org; h=content-type:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to :content-type; bh=KwhEOHc118VXqlBvOyxJZDvb06pRD5c4TH7sDppnvBw=; b=eMane/103WaCm5WoE5ELZuqF500KzKP0AbsACglex55r8DJM72rHtCf814apZYSCUY sYpELPzWT87oE5TyYJczgvGbNEcobjITGm1yP+hZdYxrcZLoLHL7oteR/KdWHevDtLvU N8qog2nminQFPZT4JjUdrwE3fkhgMp0Il+SO81SkZHpTUvJdkjDELl7U6+saz+7n3vRU rmORXT+QxEwSGnU1uLz+est/ypEjOxCxwUoqRiAAlCETMdHQesqMomu4o5SnkqfMw0PO 8c1VZRpQAcFzDNhh24feYqISNgteLzk2sfrZNiTISr428LQu+EPP4ffUdoSYxo7wI/Ym dt4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783273330; x=1783878130; h=content-type:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=KwhEOHc118VXqlBvOyxJZDvb06pRD5c4TH7sDppnvBw=; b=UPc+8KntzvWFTp7ji8mT4TgTjNrjG0LnQhPSGi0z7lwrtphSJ1DQyI6oHzNPLqC5M0 kx9ocxar42PjcFx8Pgh3uRpaWE671aY3VnPf8mGPfKK6KYALh7cgFcmzqGm4YIwbDRh9 K8oG8/IcdKFkbHcyN3QPBmK9kLekmA/NvfSlSTjcqK0hKdxXlLujnrejTCB/DNWt4c0U fcQfiq43lHGer/q/VgQ1OADpHW0Ziq0OH6UpRllSyxXa8uwGThu+2A30GZpymHGrgNTs 1oP3H0W7tp0ti3e65C4FeQkjQ7+1mDjYI92DBmzqv4rjXVOFYbljIcykBaMord5ZaGRh 4hiA== X-Forwarded-Encrypted: i=1; AHgh+Rq1OZqxpZ+mVf5rjukb20b9EZx7QwnSIJtCq4nwY3wYPj+llDMsDPPoHGBjYLlE+HfBjBAPLw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwqPk0tG9Rcvl3YT3ZmOd28I4+XJAJpRcC9jFddFvVIW6n7bRaR 2jnIK04oN1EfN+S/Pf/2Pz5DKp89DHJpd2WEHUJteWJmdM/AAB66OpHMxz0OzD8EgHpG4CH/9eU uQZ+P5Z1M0NNO0qTVf5GrzTAOStXeH6o= X-Gm-Gg: AfdE7cnrnR7XrVdmsknisirZ87pbmNSuIU3HEj88haCw7OcRHr8WS3ZUnh6H1K2TX06 bjg3BNF7/ldVL4kViap+Yo/fmaNjlGt9Zpk1iAzh9ENTDHxmcA/XDIAbcA7S6xFS9vBnX1Pccsp i295rhwxXBUD99Fl8P4iVUdQ/ynUq0u2Q3jCxqPEXry39z6PKve/hySG/vzLUTYDwKow1TXsDsP vL9I1ScPIOclsziqlGRTEgpA7CZaRYlA+kCVCmPH72OinENWD/2coWp6HRlSDXCmr+NOv2o36JE BNPStrb5AXqHTWgMF+Jd51QpgBM= X-Received: by 2002:a17:903:2b0d:b0:2c9:e6d7:fbb4 with SMTP id d9443c01a7336-2cbb9ebb87bmr71476605ad.31.1783273330192; Sun, 05 Jul 2026 10:42:10 -0700 (PDT) MIME-Version: 1.0 References: <m233y570dq.fsf@HIDDEN> <8165654f-7f85-4f32-84e6-bbdf6a0a80ad@HIDDEN> <87bjco4gwr.fsf@HIDDEN> <CA+TD5hhX0uDzGSOm1oPYvFU=FeXwezbg5TJUXrWvidM1MrCBEw@HIDDEN> <878q7s4c06.fsf@HIDDEN> <CA+TD5hhi658gZ7mYLo4moeo=Qb7LWUW=oZ-Vq=R0yxvXYKm3Jg@HIDDEN> <m2qzlkl24q.fsf@HIDDEN> <86tsqd98k9.fsf@HIDDEN> <akoek1-BW2hSOKd8@HIDDEN> <m2ik6thatb.fsf@HIDDEN> <akp-U6ib28xEOTs3@HIDDEN> In-Reply-To: <akp-U6ib28xEOTs3@HIDDEN> From: =?UTF-8?Q?Johan_Myr=C3=A9en?= <johan.myreen@HIDDEN> Date: Sun, 5 Jul 2026 20:41:58 +0300 X-Gm-Features: AVVi8CeiH39x50Yiav4SKJQF5TZPJfxG7QPDMMZziWvl0TpjkMtnEZT1s1egg5g Message-ID: <CA+TD5hitjCTRAE7=+SQN3r0gCA+QVVd3aofDBLUMtjv5tOTP7w@HIDDEN> Subject: Re: bug#81319: [PATCH] 31.0.90; new image scale check causes frequent image cache miss To: Alan Third <alan@HIDDEN>, "J.D. Smith" <jdtsmith@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, Sean Whitton <spwhitton@HIDDEN>, johan.myreen@HIDDEN, tmarjeski@HIDDEN, 81319 <at> debbugs.gnu.org, dmitry@HIDDEN Content-Type: multipart/alternative; boundary="0000000000006234af0655e0ad19" X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 81319 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.0 (/) --0000000000006234af0655e0ad19 Content-Type: text/plain; charset="UTF-8" On Sun, 5 Jul 2026 at 18:55, Alan Third <alan@HIDDEN> wrote: > (This is peculiar to PGTK, and doesn't include NS, because when I > implemented transforms I thought that if someone is asking imagemagick > to resize images I would respect what they ask for. Whoever > implemented PGTK evidently disagreed with that. Maybe we should > rethink this for all builds with native transforms.) > The comment above the DONT_CREATE_TRANSFORMED_IMAGEMAGICK_IMAGE define contains an explanation: /* In pgtk, we don't want to create scaled image. If we create scaled * image on scale=2.0 environment, the created image is half size and * Gdk scales it back, and the result is blurry. To avoid this, we * hold original size image as far as we can, and let Gdk to scale it * when it is shown. */ If I understand correctly, on Wayland GDK does not even "scale it back", but lets the compositor do the scaling. In a multi-monitor setup, Wayland supports individual scaling for each monitor. PGTK Emacs on Wayland is not aware of the scaling factors of the displays, and should not care about scaling at all. If the compositor is informed of the correct scaling factors for each display, the image can cross the border between two displays, and be shown with the correct size on both monitors. --0000000000006234af0655e0ad19 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div class=3D"gmail_quote gmail_quote_container"><div dir= =3D"ltr" class=3D"gmail_attr">On Sun, 5 Jul 2026 at 18:55, Alan Third <<= a href=3D"mailto:alan@HIDDEN">alan@HIDDEN</a>> wrote:<br></div><= div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0= px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">(This is = peculiar to PGTK, and doesn't include NS, because when I<br> implemented transforms I thought that if someone is asking imagemagick<br> to resize images I would respect what they ask for. Whoever<br> implemented PGTK evidently disagreed with that. Maybe we should<br> rethink this for all builds with native transforms.)<br></blockquote><div><= br></div><div>The comment above the=C2=A0DONT_CREATE_TRANSFORMED_IMAGEMAGIC= K_IMAGE define contains an explanation:</div><div><br></div><div>/* In pgtk= , we don't want to create scaled image.=C2=A0 If we create scaled<br>= =C2=A0* image on scale=3D2.0 environment, the created image is half size an= d<br>=C2=A0* Gdk scales it back, and the result is blurry.=C2=A0 To avoid t= his, we<br>=C2=A0* hold original size image as far as we can, and let Gdk t= o scale it<br>=C2=A0* when it is shown. =C2=A0*/<br><br></div><div>If I und= erstand=C2=A0correctly, on Wayland GDK does not even "scale it back&qu= ot;, but lets the compositor do=C2=A0the scaling. In a multi-monitor setup,= Wayland supports individual scaling for each monitor. PGTK Emacs on Waylan= d is not aware of the scaling factors of the displays, and should not care = about scaling at all. If the compositor is informed of the correct scaling = factors for each display, the image can cross the border between two displa= ys, and be shown with the correct size on both monitors.</div><div><br></di= v></div></div> --0000000000006234af0655e0ad19--
bug-gnu-emacs@HIDDEN:bug#81319; Package emacs.
Full text available.Received: (at 81319) by debbugs.gnu.org; 5 Jul 2026 16:03:05 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jul 05 12:03:04 2026 Received: from localhost ([127.0.0.1]:36909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1wgPJ8-0002u0-46 for submit <at> debbugs.gnu.org; Sun, 05 Jul 2026 12:03:04 -0400 Received: from dane.soverin.net ([185.233.34.41]:47513) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <alan@HIDDEN>) id 1wgPJ2-0002sP-SY for 81319 <at> debbugs.gnu.org; Sun, 05 Jul 2026 12:02:59 -0400 Received: from smtp.soverin.net (unknown [10.10.4.99]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dane.soverin.net (Postfix) with ESMTPS id 4gtXMF68PZzykh; Sun, 05 Jul 2026 16:02:49 +0000 (UTC) Received: from smtp.soverin.net (smtp.soverin.net [10.10.4.99]) by soverin.net (Postfix) with ESMTPSA id 4gtXMF310pz3X; Sun, 5 Jul 2026 16:02:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1783267369; bh=J3ByzhVq+byhXYPLFjcRwVaE0WXNJcKAKHkf+WSwoyg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kBxzbw+/bWk1KGiOYzzMzaNne0IDxJS78Qw4pI4Akfv3xA4V7qhAHHk0LNIr66B8d p6MjqIVwXPC0dW+c9aOf6UoupjqtQBUi+6BZafWkyHJob2RhNHVeqJfEfO1bsUlAhv hvEYUhajLdqDIO5kk6qwOUv0yXyIU+E8Ir0UrT4JzSqQqY0uLTLviFjP6sSIrpYbTr Q8KySi+bOqQDtsVAFkg1L5FywkrZUGuScnxl2eXD1K1hoVJF3wE5VFJ7tPp7356PkA rRDlT88w67QuCbuqg63Rk0jujqJDxNoDmZynjg60wQvvvb+NEnGx5xJNGcGhbSKc16 y3rzya26+tcdQ== X-CM-Envelope: MS4xfEKvWR0kzFADJq/E08FiUBeg4TUUdW9TtGQXWJYtedeCgcxy7b1h/4USSU7HaAObkBsxc73qHCZ11hotir1F5Pb/TBJfypt5oCOQQlfji+4l/S91YnZf UJMyFqZ0yVxrX9ro108ROZsFwG05Ft8AW5xcitZYL70Ee1VsWainW4PfsqQIQtl+vh8VWiRgGHYfh+otqz5s/7S29D2pYGaoohRj/CZej+CtEBxI2ZHOkMzn OlS5GoRMmxUGrczDPT4Hmev3Kt8uz3aUbPDoCqkfypkdmpI9tNRvYr2OycqnixI8iJXp7prxU3E6LKiXoU8uSQ2cs063PEttahSfiA/oaoWhJtJ3E9O110rH 9E+GJ3XfGG5pGANyLGMy006vUQsJeQgYyeuWoShUqm2tyfoq1D4= X-Soverin-Id: 019f3304-a028-7f66-8e8d-54a2d35f4133 Received: from localhost (namib [local]) by namib (OpenSMTPD) with ESMTPA id 566be86b; Sun, 5 Jul 2026 16:02:49 +0000 (UTC) Date: Sun, 5 Jul 2026 17:02:49 +0100 From: Alan Third <alan@HIDDEN> To: "J.D. Smith" <jdtsmith@HIDDEN> Subject: Re: bug#81319: [PATCH] 31.0.90; new image scale check causes frequent image cache miss Message-ID: <akqAKQpl7zII2oiK@HIDDEN> Mail-Followup-To: Alan Third <alan@HIDDEN>, "J.D. Smith" <jdtsmith@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 81319 <at> debbugs.gnu.org, tmarjeski@HIDDEN, dmitry@HIDDEN, johan.myreen@HIDDEN, spwhitton@HIDDEN References: <87bjco4gwr.fsf@HIDDEN> <CA+TD5hhX0uDzGSOm1oPYvFU=FeXwezbg5TJUXrWvidM1MrCBEw@HIDDEN> <878q7s4c06.fsf@HIDDEN> <CA+TD5hhi658gZ7mYLo4moeo=Qb7LWUW=oZ-Vq=R0yxvXYKm3Jg@HIDDEN> <m2qzlkl24q.fsf@HIDDEN> <86tsqd98k9.fsf@HIDDEN> <akoek1-BW2hSOKd8@HIDDEN> <m2ik6thatb.fsf@HIDDEN> <86ldbp8tst.fsf@HIDDEN> <m2echhh2gt.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <m2echhh2gt.fsf@HIDDEN> X-Spampanel-Class: ham X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 81319 Cc: 81319 <at> debbugs.gnu.org, tmarjeski@HIDDEN, dmitry@HIDDEN, Eli Zaretskii <eliz@HIDDEN>, johan.myreen@HIDDEN, spwhitton@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Sun, Jul 05, 2026 at 11:37:38AM -0400, J.D. Smith wrote: > > So I no longer think my patch is needed, except perhaps to improve the > logic to make it clearer. Alan's other proposal is better from that > defensive point of view: initialize img->scale = -1 and disable the > cache test if img->scale remains unset. I see we've reached the same conclusion. I think the logic is confusing so we should probably clean it up. As I suggested in my other email perhaps we want to stop having imagemagick perform transforms on all platforms where it's available natively. I don't know if there's a really good reason to keep that behaviour. -- Alan Third
bug-gnu-emacs@HIDDEN:bug#81319; Package emacs.
Full text available.
Received: (at 81319) by debbugs.gnu.org; 5 Jul 2026 15:55:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jul 05 11:55:17 2026
Received: from localhost ([127.0.0.1]:36884 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1wgPBZ-0001oh-K8
for submit <at> debbugs.gnu.org; Sun, 05 Jul 2026 11:55:17 -0400
Received: from dane.soverin.net ([2a10:de80:1:4091:b9e9:222d:0:1]:48953)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <alan@HIDDEN>) id 1wgPBS-0001kg-J8
for 81319 <at> debbugs.gnu.org; Sun, 05 Jul 2026 11:55:10 -0400
Received: from smtp.soverin.net (unknown [10.10.4.100])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
(No client certificate requested)
by dane.soverin.net (Postfix) with ESMTPS id 4gtXBD2hmqzpkr;
Sun, 05 Jul 2026 15:55:00 +0000 (UTC)
Received: from smtp.soverin.net (smtp.soverin.net [10.10.4.100]) by
soverin.net (Postfix) with ESMTPSA id 4gtXBC5Ls9zbg;
Sun, 5 Jul 2026 15:54:59 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin;
t=1783266900; bh=MdF0EnfUAUgRO/aD9c1w8hN2P8qwJgfM3IW+ztYbCVU=;
h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
b=JiLOv4TV/Sn9e/k6KhUjD758p4LStH2wkhOZu2840b5eHwKUWgK7NCTYWJSlPW5mP
duVXAKdEtTWwr+VNnNB+fAQ8VPyiEmKS7432bO59LdU+ohrVukPWq92Qg+Ow2X+1fg
KIZL9vUVic4XWFJXIR+7yqCRBe2itidO5TQby3r9kr6FX2mZo3+25wCtxB6LxQudii
dYLD1TJDBc3Xd3UT6QvpXMiZAObJXvuH0IPzNLmuxW61rwNIdPEPkK7sk1hY4GdqXx
FB5/3VHl1yRCqIYxnwlZB0g4UG6yKZoiZ4yd9yobMv8MEYRdxyMeb8f/MV2x5TIr9o
hPEhKsmAzTTiA==
X-CM-Envelope: MS4xfF5yMPloNE1ISSo23LlK6fIRSXgP+Ey4BTJMlAex0TYeu04Dgo9fr8mN/6vkE3QvQqerI8LO1NSrL6HBe1H2R+w+1jN4wLzH6ebCkFX9x8L/Qls8hdRV
BOoMB5Ke/U0pexG9Gcuh1t+lPF9vEgiWnCSt8ghMzrEv3jgfDOE4zzna5nZvIo4ef5xyPHcdHS/mE91K+TGFwieXVhZlvgaO0QPfhVv4mTOGWzonv3T+563P
N4yxvogpduqR2vBAXBOmTsJrfUCuCbX4XwZj0eNbKq+LbTpm64Y/n4b+l0opucWPdu7YRsQCboq6L40YTnhVGVEgpgUsrsAhSDPkG+dW7zzlArpWwlwraCPY
pefVSLnGHfMEWy63R9GsKfqSO+0wC89DixwrsNe+y7BYE5mqIoA=
X-Soverin-Id: 019f32fd-7820-7a4a-83c1-170a997da2bf
Received: from localhost (namib [local])
by namib (OpenSMTPD) with ESMTPA id ad34d3a9;
Sun, 5 Jul 2026 15:54:59 +0000 (UTC)
Date: Sun, 5 Jul 2026 16:54:59 +0100
From: Alan Third <alan@HIDDEN>
To: "J.D. Smith" <jdtsmith@HIDDEN>
Subject: Re: bug#81319: [PATCH] 31.0.90; new image scale check causes
frequent image cache miss
Message-ID: <akp-U6ib28xEOTs3@HIDDEN>
Mail-Followup-To: Alan Third <alan@HIDDEN>,
"J.D. Smith" <jdtsmith@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
Sean Whitton <spwhitton@HIDDEN>, johan.myreen@HIDDEN,
tmarjeski@HIDDEN, 81319 <at> debbugs.gnu.org, dmitry@HIDDEN
References: <m233y570dq.fsf@HIDDEN>
<8165654f-7f85-4f32-84e6-bbdf6a0a80ad@HIDDEN>
<87bjco4gwr.fsf@HIDDEN>
<CA+TD5hhX0uDzGSOm1oPYvFU=FeXwezbg5TJUXrWvidM1MrCBEw@HIDDEN>
<878q7s4c06.fsf@HIDDEN>
<CA+TD5hhi658gZ7mYLo4moeo=Qb7LWUW=oZ-Vq=R0yxvXYKm3Jg@HIDDEN>
<m2qzlkl24q.fsf@HIDDEN> <86tsqd98k9.fsf@HIDDEN>
<akoek1-BW2hSOKd8@HIDDEN>
<m2ik6thatb.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m2ik6thatb.fsf@HIDDEN>
X-Spampanel-Class: ham
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 81319
Cc: 81319 <at> debbugs.gnu.org, tmarjeski@HIDDEN, dmitry@HIDDEN,
Eli Zaretskii <eliz@HIDDEN>, johan.myreen@HIDDEN,
Sean Whitton <spwhitton@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
On Sun, Jul 05, 2026 at 08:37:20AM -0400, J.D. Smith wrote:
> Alan Third <alan@HIDDEN> writes:
>
> > I think SVGs are also affected, but as I understand it librsvg is very
> > fast (compared to imagemagick) so it may not be as noticable.
>
> I strongly suspect neither of you are exercising the bug, but just
> exploring the benchmark's happy path timing distribution. The way you
> can be sure is to print a log message with img->width/height, or set a(n
> auto-continue, printing) breakpoint on image_compute_scale, after
> loading all the toolbars/etc. To be sure you are on the bug path, you
> should /not/ see it called for the large test image. I think it will be
> called in many/most instances:
>
> - NULL image type
> - SVG type
> - No imagemagick installed
>
> In fact, looking more closely at the PGTK-related test:
>
> #ifndef DONT_CREATE_TRANSFORMED_IMAGEMAGICK_IMAGE
> compute_image_size (f, MagickGetImageWidth (image_wand),
> MagickGetImageHeight (image_wand),
> img, &desired_width, &desired_height);
> #else
> desired_width = desired_height = -1;
> #endif
>
> I may have mistaken the order: PGTK may be the problematic build, not
> the immune one (DONT_CREATE_TRANSFORMED_IMAGEMAGICK_IMAGE is defined on
> PGTK builds with imagemagick, skipping compute_image_size here).
The double negative is confusing (DONT is NOT defined). The
imagemagick image loading path doesn't call compute_image_size under
PGTK.
However, in image_set_transform
# if (defined HAVE_IMAGEMAGICK \
&& !defined DONT_CREATE_TRANSFORMED_IMAGEMAGICK_IMAGE)
/* ImageMagick images already have the correct transform. */
if (EQ (image_spec_value (img->spec, QCtype, NULL), Qimagemagick))
return;
# endif
the above return should only be called if we HAVE_IMAGEMAGICK and it's
NOT a PGTK build, i.e. DONT_CREATE_TRANSFORMED_IMAGEMAGICK_IMAGE is
undefined.
That's what we see above. This means on a PGTK build an imagemagick
image will fall through and image_set_transform does its stuff,
including calling compute_image_size some ~25 lines later.
This is, afaict, the expected behaviour.
(This is peculiar to PGTK, and doesn't include NS, because when I
implemented transforms I thought that if someone is asking imagemagick
to resize images I would respect what they ask for. Whoever
implemented PGTK evidently disagreed with that. Maybe we should
rethink this for all builds with native transforms.)
> >> P.S. It's a pity that the change which caused this didn't have any
> >> serious testing in the 1.5 years since it was installed. Or maybe the
> >> resulting slowdown was not severe enough to have people pay attention?
> >
> > I suspect very few people have noticed since it mainly affects
> > imagemagick, and it probably doesn't get as much use since native
> > transforms were added.
>
> I think that's right. I exercise it more because in emacs-mac, imageI/O
> is used as a stand-in for imagemagick, and is used in preference to
> libpng/etc.
>
> > FWIW, trying the benchmark on my first-gen i7 with an SSD, built with:
> >
> > ./configure --with-x-toolkit=lucid --with-imagemagick
> >
> > shows a speed-up in the region of two tenths of a millisecond, which
> > isn't much at all and is probably within the margin of error.
>
> Please see if image_set_transform is called on the image!
I can convince neither lucid nor PGTK to get a cache miss on an
imagemagick image. I even had to double check that the image *is* an
imagemagick type.
Sorry, I no longer think there's a bug here. If this is a problem for
emacs-mac's native types, then it needs to add a call to
compute_image_size, image_compute_scale, or whatever itself.
--
Alan Third
bug-gnu-emacs@HIDDEN:bug#81319; Package emacs.
Full text available.Received: (at 81319) by debbugs.gnu.org; 5 Jul 2026 15:37:50 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jul 05 11:37:49 2026 Received: from localhost ([127.0.0.1]:36826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1wgOui-0007X9-JE for submit <at> debbugs.gnu.org; Sun, 05 Jul 2026 11:37:49 -0400 Received: from mail-ot1-x336.google.com ([2607:f8b0:4864:20::336]:58495) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <jdtsmith@HIDDEN>) id 1wgOug-0007WA-GI for 81319 <at> debbugs.gnu.org; Sun, 05 Jul 2026 11:37:47 -0400 Received: by mail-ot1-x336.google.com with SMTP id 46e09a7af769-7eb64371a2aso1493162a34.0 for <81319 <at> debbugs.gnu.org>; Sun, 05 Jul 2026 08:37:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783265860; x=1783870660; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=ojeUF5rSOpUFa0fY/o4hc3KTTsJnMUx/NMnrX0D23Io=; b=at3HkFEqMpAk6D9HexyBw6mJ3ifSRrJd8QODcDfWayY7rhogv2UN0AQeqgOEeFzPCj GcVqjJGMHfni3BzDqhPGk6qoeCC1uT54UuTI2bZJQENqxWhjqEJc7zcwnZSY7cf0veqH XaAIfjIy1aqakNEmu3dW8pcNlpd8kjorD4hMeqAaqgXmBpZwpQSZlmeH6hJYvGN1i3Jt tyCwkGoJXLLf/fto1N2TfvjT6siqkLzNSSpHB3JYDD3KPckwXbIVNCjTL9kzG6BbAB8q /nsTpyltddENZmzlUKVxMcNNTdvIugTf07rc1TwxK+ZwvzwYTRW5s9II6+gM7td1mfbe mFmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783265860; x=1783870660; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ojeUF5rSOpUFa0fY/o4hc3KTTsJnMUx/NMnrX0D23Io=; b=YXpkrp3aZBdWH6zSUoRPLNwAzlnc6/O5sdhvi+NL8q3prIFawFIkgTU/QKmzYhSPIt 3Ul9YyRb+H6MXtllJhMz7KKGk+13qYrIhtjMty/Ve8wPlJO2m96FjhtXrdYJwKKbzrRa 5fXSnPYKdsRsh+O+Niep31ffQExKZMsMbKE5bZe3/wZ7ZoidrhF68zDEGTMGFjNJ9s+0 g/iMHMaD6o4OAgF86ZmldXtkSFquImJv+N2oLUEiOjqzHo7lnBKJf7MWUksnvK76W/MQ oiQkrGF631cwJmb3UTo4vY1ofKhHw/erEDK8i2r2tQryIzxu36J4mvEtEKGUegS5/Y3Q mROA== X-Forwarded-Encrypted: i=1; AFNElJ9OYPy6aNfsz+JTwlyd9yi2zMSOHZrS/hIANtMfMtDiDRwdj1AC3jwIJLEa/9soMmGwGq1c+w==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzT83ol84tRBY7zw9pnxSTaIBF0k6eSt4cCRRHlJFzi1fOK5ZuJ vqSAAYwgHRL1/ELsWKmtJSYbX+47QTAOEAA/jHhydYsyIcon6nPHkjmGfgowBGbf X-Gm-Gg: AfdE7clJtviRhvgEbSsoR+1ohYYGRv4K4DaFvptyNz8Wf0IDlIyvDVTdEpYaHrBKMSS Ucb2erl1wxVSw/Ch4bKz8ESdfjoOyUVaRwYaAJS9DCusvKkdpBi+REI3z+AiMGlan2ruc0yLHQ3 hzrI4/2ybKEH4KrYcD1QSZuscgWYfFfkdWpCiMvrjPqLnhlEgGY2XDqUTlO0WMOI/vFmg3iJlVw ZqWv5Xgc+QrfWkpeTq30budAkFCw6iqGxHU3V10wIqm2QVOf6pXHiy+gIlvTJq6zM4vhzkiUg4k h5d5SVKctuajbjNwmhNA3yHp8xmZjcws/6e5LXaHNJgf8iXtq/F90AyuZt76uVHiK1BwQjYcFgI 46iXmo0ZgWBnR42zAInz5BheIl9F9abWrLnGoDizk95mIFbC9Zb4NZybP99wE7E66tn/bplPX3/ /nVI2KXERE70HfZkV6j/u7Yen4fST6qOqcgXS8b1kJgI0Dc14ZKYhP+Q== X-Received: by 2002:a05:6830:381a:b0:7df:5fc:3fd8 with SMTP id 46e09a7af769-7eb7fd2c5d2mr5082002a34.1.1783265860516; Sun, 05 Jul 2026 08:37:40 -0700 (PDT) Received: from moss (cm-24-53-187-185.buckeyecom.net. [24.53.187.185]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7eb8998850fsm3048460a34.11.2026.07.05.08.37.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jul 2026 08:37:39 -0700 (PDT) From: "J.D. Smith" <jdtsmith@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#81319: [PATCH] 31.0.90; new image scale check causes frequent image cache miss In-Reply-To: <86ldbp8tst.fsf@HIDDEN> References: <m28q7x7bpi.fsf@HIDDEN> <86wlvheah7.fsf@HIDDEN> <m233y570dq.fsf@HIDDEN> <8165654f-7f85-4f32-84e6-bbdf6a0a80ad@HIDDEN> <87bjco4gwr.fsf@HIDDEN> <CA+TD5hhX0uDzGSOm1oPYvFU=FeXwezbg5TJUXrWvidM1MrCBEw@HIDDEN> <878q7s4c06.fsf@HIDDEN> <CA+TD5hhi658gZ7mYLo4moeo=Qb7LWUW=oZ-Vq=R0yxvXYKm3Jg@HIDDEN> <m2qzlkl24q.fsf@HIDDEN> <86tsqd98k9.fsf@HIDDEN> <akoek1-BW2hSOKd8@HIDDEN> <m2ik6thatb.fsf@HIDDEN> <86ldbp8tst.fsf@HIDDEN> Date: Sun, 05 Jul 2026 11:37:38 -0400 Message-ID: <m2echhh2gt.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Eli Zaretskii writes: >> From: "J.D. Smith" >> Cc: Eli Zaretskii , Sean Whitton , >> johan.myreen@HIDDEN, tmarjeski@HIDDEN, 81319 <at> debbugs.gnu.org, >> dmitry@HIDDEN >> Date: Sun, 05 Jul 2026 08:37:20 -0400 >> > [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (jdtsmith[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 1.0 FORGED_GMAIL_RCVD 'From' gmail.com does not match 'Received' headers -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:336 listed in] [list.dnswl.org] 1.0 FREEMAIL_REPLY From and body contain different freemails X-Debbugs-Envelope-To: 81319 Cc: alan@HIDDEN, 81319 <at> debbugs.gnu.org, tmarjeski@HIDDEN, dmitry@HIDDEN, johan.myreen@HIDDEN, spwhitton@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.0 (/) Eli Zaretskii <eliz@HIDDEN> writes: >> From: "J.D. Smith" <jdtsmith@HIDDEN> >> Cc: Eli Zaretskii <eliz@HIDDEN>, Sean Whitton <spwhitton@HIDDEN>, >> johan.myreen@HIDDEN, tmarjeski@HIDDEN, 81319 <at> debbugs.gnu.org, >> dmitry@HIDDEN >> Date: Sun, 05 Jul 2026 08:37:20 -0400 >> >> Alan Third <alan@HIDDEN> writes: >> >> > On Sun, Jul 05, 2026 at 10:53:10AM +0300, Eli Zaretskii wrote: >> >> Is the way I've run the benchmark supposed to produce valid results? >> >> If not, would it be possible to modify the recipe to make the results >> >> reflect the issue we are discussing here, but without using >> >> ImageMagick? >> >> No, that should not exercise the bug. > > Or are you saying that it only affects ImageMagick images? That was my claim. But I have taken an even closer look, and I now think this may not affect other builds aside from emacs-mac, which would would explain why no one is seeing the 20x cache miss penalty I see. The original logic of the bug: 1. compute_image_size is the only place image_compute_scale is called with an img pointer. Calling compute_image_size is a necessary precondition for the "scale" part of the image cache check to succeed. 2. Leaving aside SVG images, compute_image_size is /only/ called late in image_set_transform. 3. image_set_transform returns early for type=imagemagick images (except on PGTK). 4. Outcome: image_compute_scale is never called, cache check always fails. Looking again at imagemagick_load_image shows me #2 was wrong: if NOT PGTK, compute_image_size is also called here as well. The logic is pretty convoluted, but: 1. If PGTK: imagemagick_load_image doesn't set img->scale, but image_set_transform does. 2. If NOT PGTK: visa versa. So I no longer think my patch is needed, except perhaps to improve the logic to make it clearer. Alan's other proposal is better from that defensive point of view: initialize img->scale = -1 and disable the cache test if img->scale remains unset.
bug-gnu-emacs@HIDDEN:bug#81319; Package emacs.
Full text available.Received: (at 81319) by debbugs.gnu.org; 5 Jul 2026 13:12:25 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jul 05 09:12:24 2026 Received: from localhost ([127.0.0.1]:35792 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1wgMdv-0005SG-PZ for submit <at> debbugs.gnu.org; Sun, 05 Jul 2026 09:12:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48582) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1wgMdo-0005R1-9l for 81319 <at> debbugs.gnu.org; Sun, 05 Jul 2026 09:12:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1wgMdh-0000Yb-PD; Sun, 05 Jul 2026 09:12:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=h2e+SbGcQOaUe/a+MmYz8N02KRZv6sEKQynK5ivkoGA=; b=rmgBGz8DqxO7 0f/JnNfOCskyX5Gek4QlQoyY/4v+fWej9yXxnj+QjN9t78OpgWnaLQSMA6537aYy4PAfzTUw/M9cG WNq5qONT6/BNL93RByvbrdLd4IUGFC4fC3Cg1Ijp5fxBz8qOyIA6SqVIH1lrvM4Cizm9jjo2p/ghC Fv4s6WrmAb/jpWdAGFHufJrNLSlEmWrhcHNssmjYUChuxutiCHAn6Rc4mq9Tk2Wul/Is+5ELnqMb7 Tn1kTAphcanxmPsBSEOGuShP5LwdNu+FcX7tSviXuu2K198tvVL18rUs19jwAO38aBv+E+V6Y6/j5 0SeeO0+4haS9JsbmTA/xbg==; Date: Sun, 05 Jul 2026 16:12:02 +0300 Message-Id: <86ldbp8tst.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: "J.D. Smith" <jdtsmith@HIDDEN> In-Reply-To: <m2ik6thatb.fsf@HIDDEN> (jdtsmith@HIDDEN) Subject: Re: bug#81319: [PATCH] 31.0.90; new image scale check causes frequent image cache miss References: <m28q7x7bpi.fsf@HIDDEN> <86wlvheah7.fsf@HIDDEN> <m233y570dq.fsf@HIDDEN> <8165654f-7f85-4f32-84e6-bbdf6a0a80ad@HIDDEN> <87bjco4gwr.fsf@HIDDEN> <CA+TD5hhX0uDzGSOm1oPYvFU=FeXwezbg5TJUXrWvidM1MrCBEw@HIDDEN> <878q7s4c06.fsf@HIDDEN> <CA+TD5hhi658gZ7mYLo4moeo=Qb7LWUW=oZ-Vq=R0yxvXYKm3Jg@HIDDEN> <m2qzlkl24q.fsf@HIDDEN> <86tsqd98k9.fsf@HIDDEN> <akoek1-BW2hSOKd8@HIDDEN> <m2ik6thatb.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 81319 Cc: alan@HIDDEN, 81319 <at> debbugs.gnu.org, tmarjeski@HIDDEN, dmitry@HIDDEN, johan.myreen@HIDDEN, spwhitton@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: "J.D. Smith" <jdtsmith@HIDDEN> > Cc: Eli Zaretskii <eliz@HIDDEN>, Sean Whitton <spwhitton@HIDDEN>, > johan.myreen@HIDDEN, tmarjeski@HIDDEN, 81319 <at> debbugs.gnu.org, > dmitry@HIDDEN > Date: Sun, 05 Jul 2026 08:37:20 -0400 > > Alan Third <alan@HIDDEN> writes: > > > On Sun, Jul 05, 2026 at 10:53:10AM +0300, Eli Zaretskii wrote: > >> Is the way I've run the benchmark supposed to produce valid results? > >> If not, would it be possible to modify the recipe to make the results > >> reflect the issue we are discussing here, but without using > >> ImageMagick? > > No, that should not exercise the bug. Then please modify the benchmark code so that it would. Or are you saying that it only affects ImageMagick images?
bug-gnu-emacs@HIDDEN:bug#81319; Package emacs.
Full text available.Received: (at 81319) by debbugs.gnu.org; 5 Jul 2026 12:37:39 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jul 05 08:37:38 2026 Received: from localhost ([127.0.0.1]:35728 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1wgM6J-00013p-Hl for submit <at> debbugs.gnu.org; Sun, 05 Jul 2026 08:37:38 -0400 Received: from mail-ot1-x331.google.com ([2607:f8b0:4864:20::331]:55733) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <jdtsmith@HIDDEN>) id 1wgM6C-000125-Mk for 81319 <at> debbugs.gnu.org; Sun, 05 Jul 2026 08:37:32 -0400 Received: by mail-ot1-x331.google.com with SMTP id 46e09a7af769-7eb68bdf53aso670052a34.3 for <81319 <at> debbugs.gnu.org>; Sun, 05 Jul 2026 05:37:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783255043; x=1783859843; darn=debbugs.gnu.org; h=content-type:mime-version:user-agent:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=Ho2lMPOOgaL99aumf7XleI9omUErf4Qnhjz4VLRCxWE=; b=L4ATWt3jqxQPcPu33IzC+xcCWLgs9acoN4b8zFLLiqhxErjMg1oMS6S8V/LnhM4aIf ez+tDzQg+3Hbxw5uKFG2rgfsaQrW2BiauGrK7SgFTw2LdRDK4POuBbcOmwyxzFJUpczq sFPdX1yanblN263uixfe7kLkMiwH4Jbn/1ikJrhfH4cQm47cfwg92JNYokBCvgCfL/J8 Dy3mMNyYw46xr/As8VqwWBTFL2u3DFCi5PdqY+byQYFyn/7mNdLc5G/6/7yWteqdLoi4 crRPf/6lJCAJjgXEQD47MOIa6rW79Tyt658xyiWvu6phmYHvBVcK6UKuPNWiy9x4Had0 42GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783255043; x=1783859843; h=content-type:mime-version:user-agent:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=Ho2lMPOOgaL99aumf7XleI9omUErf4Qnhjz4VLRCxWE=; b=CODAf+4Qvgs35BljY+x7EbLTJnX6NFnCy6ERm2KUiEZIzohbjRJaGXSiUFeODTK2+z 3s6IuZz5KgrPnoITOxSmnUIOp1Z++gE63iXckLwj0zZyM8yjYsBeEJOeGP3Va3DiJy5V pJzt0+OzLPrZ1n0iGz3UZ4XffsRMq++xrBesQoqZjiODnr6XXP4ulnpsVZTr/wpSXxVW FZEQrCkm4FAA8t32irQ12l3EyIYw+wmYuuNFB6JK+lYdGxZWbrtsyOls0p1EyYRH1iEz 4XoYiEte2RQaVYi4jZ9xDEq7mNfNjA5CYYpcLaitcMLaQiPPzAzhHZY6cvgeKVMTg93a tP4w== X-Forwarded-Encrypted: i=1; AFNElJ+0s4YIC3C+W9qF9bU0hrv+UiQn53zdw5QIXGdZQfQduUGSo2Dii+z/FEjabBkDtrU0mWPfPA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxgN4hn3h9h/vslC3XzrVe8mzMCI++aKDrjKEKonIr9tly5HK6M V7axXy2h8ueWZujivT3Uh+ajTxcM73S2VlX2UC/tesGJ+Dikpuw3P2yH X-Gm-Gg: AfdE7clqPQQFdijSMJ+1fqbcsZfcHR2fw1gJO92myegyCOKmZtExBevcYjvjwWvB33F VRvZZmfpOunKOnJeL/BrzQcHUKskI6uG4UrbAjPkqkiNR243yuITNes+nDlQ0PHF/SyqXlvvSZe jCCEne2SVgT5jsbTtKxjNVJ38zgfDXH42990nvcd0O9k1Xf5IwfYy3KxGZ4z0Ozni1lO4Z54EKG 8cx13Y7vJvsOWnZb7ihv7tQwDAcABjOACy6mXAuH10cuoJ8dq7xxV5srhYjBGDQtQ2+sfdu51+/ 37lQlY2utphxzGaXxSARsVzn/yRAVn4UNsY6bw6Mq9ATd2RyYJvRtDtZQabTnMVQvET6Okaty7O 5kCPRD6eHbyonMsXFABSuzMxFd9GczeOEs6q3DI0SrYtaXWAjBk37bSkY/xnSCLyQlh0Q0WVhmP GN1Gx1lpL2UQYIt6e02+L2/AHllfV149hMhnolo5vpYNQ= X-Received: by 2002:a05:6871:70f:b0:448:558c:d825 with SMTP id 586e51a60fabf-44d1846e5admr3725140fac.40.1783255042630; Sun, 05 Jul 2026 05:37:22 -0700 (PDT) Received: from moss (cm-24-53-187-185.buckeyecom.net. [24.53.187.185]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-44cfb5db92dsm7310199fac.13.2026.07.05.05.37.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jul 2026 05:37:21 -0700 (PDT) From: "J.D. Smith" <jdtsmith@HIDDEN> To: Alan Third <alan@HIDDEN> Subject: Re: bug#81319: [PATCH] 31.0.90; new image scale check causes frequent image cache miss In-Reply-To: <akoek1-BW2hSOKd8@HIDDEN> References: <m28q7x7bpi.fsf@HIDDEN> <86wlvheah7.fsf@HIDDEN> <m233y570dq.fsf@HIDDEN> <8165654f-7f85-4f32-84e6-bbdf6a0a80ad@HIDDEN> <87bjco4gwr.fsf@HIDDEN> <CA+TD5hhX0uDzGSOm1oPYvFU=FeXwezbg5TJUXrWvidM1MrCBEw@HIDDEN> <878q7s4c06.fsf@HIDDEN> <CA+TD5hhi658gZ7mYLo4moeo=Qb7LWUW=oZ-Vq=R0yxvXYKm3Jg@HIDDEN> <m2qzlkl24q.fsf@HIDDEN> <86tsqd98k9.fsf@HIDDEN> <akoek1-BW2hSOKd8@HIDDEN> Date: Sun, 05 Jul 2026 08:37:20 -0400 Message-ID: <m2ik6thatb.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 81319 Cc: 81319 <at> debbugs.gnu.org, tmarjeski@HIDDEN, dmitry@HIDDEN, Eli Zaretskii <eliz@HIDDEN>, johan.myreen@HIDDEN, Sean Whitton <spwhitton@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.0 (/) Alan Third <alan@HIDDEN> writes: > On Sun, Jul 05, 2026 at 10:53:10AM +0300, Eli Zaretskii wrote: >> Is the way I've run the benchmark supposed to produce valid results? >> If not, would it be possible to modify the recipe to make the results >> reflect the issue we are discussing here, but without using >> ImageMagick? No, that should not exercise the bug. > I think SVGs are also affected, but as I understand it librsvg is very > fast (compared to imagemagick) so it may not be as noticable. I strongly suspect neither of you are exercising the bug, but just exploring the benchmark's happy path timing distribution. The way you can be sure is to print a log message with img->width/height, or set a(n auto-continue, printing) breakpoint on image_compute_scale, after loading all the toolbars/etc. To be sure you are on the bug path, you should /not/ see it called for the large test image. I think it will be called in many/most instances: - NULL image type - SVG type - No imagemagick installed In fact, looking more closely at the PGTK-related test: #ifndef DONT_CREATE_TRANSFORMED_IMAGEMAGICK_IMAGE compute_image_size (f, MagickGetImageWidth (image_wand), MagickGetImageHeight (image_wand), img, &desired_width, &desired_height); #else desired_width = desired_height = -1; #endif I may have mistaken the order: PGTK may be the problematic build, not the immune one (DONT_CREATE_TRANSFORMED_IMAGEMAGICK_IMAGE is defined on PGTK builds with imagemagick, skipping compute_image_size here). So now I suspect a very small fraction of builds experience this, which would explain why people haven't complained. >> P.S. It's a pity that the change which caused this didn't have any >> serious testing in the 1.5 years since it was installed. Or maybe the >> resulting slowdown was not severe enough to have people pay attention? > > I suspect very few people have noticed since it mainly affects > imagemagick, and it probably doesn't get as much use since native > transforms were added. I think that's right. I exercise it more because in emacs-mac, imageI/O is used as a stand-in for imagemagick, and is used in preference to libpng/etc. > FWIW, trying the benchmark on my first-gen i7 with an SSD, built with: > > ./configure --with-x-toolkit=lucid --with-imagemagick > > shows a speed-up in the region of two tenths of a millisecond, which > isn't much at all and is probably within the margin of error. Please see if image_set_transform is called on the image! > > I agree that the patch fixes a bug, but it's looking increasingly like > the impact of the bug is negligible, at least for most people. I agree, but for some systems the effect will be quite large.
bug-gnu-emacs@HIDDEN:bug#81319; Package emacs.
Full text available.
Received: (at 81319) by debbugs.gnu.org; 5 Jul 2026 09:06:38 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jul 05 05:06:38 2026
Received: from localhost ([127.0.0.1]:34058 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1wgIoA-0007LF-2w
for submit <at> debbugs.gnu.org; Sun, 05 Jul 2026 05:06:38 -0400
Received: from dane.soverin.net ([185.233.34.158]:44227)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <alan@HIDDEN>) id 1wgIo7-0007Kj-Ix
for 81319 <at> debbugs.gnu.org; Sun, 05 Jul 2026 05:06:36 -0400
Received: from smtp.soverin.net (unknown [10.10.4.100])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
(No client certificate requested)
by dane.soverin.net (Postfix) with ESMTPS id 4gtM6s0HR4z5x;
Sun, 05 Jul 2026 09:06:29 +0000 (UTC)
Received: from smtp.soverin.net (smtp.soverin.net [10.10.4.100]) by
soverin.net (Postfix) with ESMTPSA id 4gtM6r3vsbzHb;
Sun, 5 Jul 2026 09:06:28 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin;
t=1783242388; bh=V2RI3JkBqPhGnTaSIxw1BHqYBCQJyNMZ1ZTy9wBm+xc=;
h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
b=VpDel+J+q88p45MLYFG8GYwLftYK/F85GiP+1PRoMBH80YlC9oAN46515mndJEboY
+5sb9PKDI10BD3zVf71KoNDllG6PuKHLF8+VEEbnd3R3KnPyaLufWclm1uCrPGypVK
LuFtY0xfxAJJ6+syW62EEGPxUeUeBFYE7cImBbh1tmm/+2cUSG2a5n67T3MoHIEOpx
b0PY1y9OiiIWaHqiHKhF0ykNtbnT5m3PcPhcqACnttZdQARDJ/7aqXn748uGqSkrXg
JhFuoitpYwyjho9Mf7ENu7zjKF7y2AKgoixk68Kz86BcwxHZPHy2WTGMdzBDOpqHvu
Jo+ovuvo5O79A==
X-CM-Envelope: MS4xfOt4AbLx3DWEydtBDD86yC+9Zt+cdcy/C/1gYagn14o97ESmSaQ2C0LaNsf05n7VfLnV4B1IXoyjvp0baprSRHOZ5JYfdCr7vtSlp8opvwI1jLDQ1zhx
OHqo+f2qB9HRzyxsHnQ59knZMOpmqieNzG4KowjwfStlETvtid5DF1yMGur4ILcJelBkSP0NflAZuSjdv+w6vUmw4VsVCLtDCqGy4VENUjQYOi1YzOqz9NFc
CzL0rjOoT91zQA1jF5NbrW+JCbMcUfpeMBWYE5fAJTt/LoeKbqVVABxGcBX2jdKweFq0cEU8YDOvhhOdi9mKW8LDSBvYSqRnCXJX/v/34qTbW2QSY27u8N8Q
QgiWfSpyJY0wKLuTKZlIckp4fAvK9/uNp5z6jPJ/hJhLeu93SOY=
X-Soverin-Id: 019f3187-7220-7831-b00d-0809d3f32044
Received: from localhost (namib [local])
by namib (OpenSMTPD) with ESMTPA id 523b6f86;
Sun, 5 Jul 2026 09:06:27 +0000 (UTC)
Date: Sun, 5 Jul 2026 10:06:27 +0100
From: Alan Third <alan@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#81319: [PATCH] 31.0.90; new image scale check causes
frequent image cache miss
Message-ID: <akoek1-BW2hSOKd8@HIDDEN>
Mail-Followup-To: Alan Third <alan@HIDDEN>,
Eli Zaretskii <eliz@HIDDEN>, "J.D. Smith" <jdtsmith@HIDDEN>,
Sean Whitton <spwhitton@HIDDEN>, johan.myreen@HIDDEN,
tmarjeski@HIDDEN, 81319 <at> debbugs.gnu.org, dmitry@HIDDEN
References: <m28q7x7bpi.fsf@HIDDEN> <86wlvheah7.fsf@HIDDEN>
<m233y570dq.fsf@HIDDEN>
<8165654f-7f85-4f32-84e6-bbdf6a0a80ad@HIDDEN>
<87bjco4gwr.fsf@HIDDEN>
<CA+TD5hhX0uDzGSOm1oPYvFU=FeXwezbg5TJUXrWvidM1MrCBEw@HIDDEN>
<878q7s4c06.fsf@HIDDEN>
<CA+TD5hhi658gZ7mYLo4moeo=Qb7LWUW=oZ-Vq=R0yxvXYKm3Jg@HIDDEN>
<m2qzlkl24q.fsf@HIDDEN> <86tsqd98k9.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <86tsqd98k9.fsf@HIDDEN>
X-Spampanel-Class: ham
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 81319
Cc: 81319 <at> debbugs.gnu.org, tmarjeski@HIDDEN, dmitry@HIDDEN,
"J.D. Smith" <jdtsmith@HIDDEN>, johan.myreen@HIDDEN,
Sean Whitton <spwhitton@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
On Sun, Jul 05, 2026 at 10:53:10AM +0300, Eli Zaretskii wrote:
> Is the way I've run the benchmark supposed to produce valid results?
> If not, would it be possible to modify the recipe to make the results
> reflect the issue we are discussing here, but without using
> ImageMagick?
I think SVGs are also affected, but as I understand it librsvg is very
fast (compared to imagemagick) so it may not be as noticable.
> P.S. It's a pity that the change which caused this didn't have any
> serious testing in the 1.5 years since it was installed. Or maybe the
> resulting slowdown was not severe enough to have people pay attention?
I suspect very few people have noticed since it mainly affects
imagemagick, and it probably doesn't get as much use since native
transforms were added.
FWIW, trying the benchmark on my first-gen i7 with an SSD, built with:
./configure --with-x-toolkit=lucid --with-imagemagick
shows a speed-up in the region of two tenths of a millisecond, which
isn't much at all and is probably within the margin of error.
I agree that the patch fixes a bug, but it's looking increasingly like
the impact of the bug is negligible, at least for most people.
--
Alan Third
bug-gnu-emacs@HIDDEN:bug#81319; Package emacs.
Full text available.Received: (at 81319) by debbugs.gnu.org; 5 Jul 2026 07:53:38 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jul 05 03:53:36 2026 Received: from localhost ([127.0.0.1]:33582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1wgHfO-0007yC-Ox for submit <at> debbugs.gnu.org; Sun, 05 Jul 2026 03:53:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33564) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1wgHfG-0007wy-Ee for 81319 <at> debbugs.gnu.org; Sun, 05 Jul 2026 03:53:26 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1wgHf9-00018s-Qm; Sun, 05 Jul 2026 03:53:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=KepBD9oB1eaGZwW4wQ8kaDH3zBNJ5vMFIZ6/6ekN5ZE=; b=XUXxUSwMh+u8YUn7ttIG WwuETT6Jr2SPMc+SnmblSDqRuLQ9DSg3f0UpvTHikGScZRngGc4pyKiJPwa+0hMDiFGeRGFURygyF QACPoY56BIFRnmdrJjmSJH6b3+Jcu4HgYvRLQP/MfRFg3WMZKvYTwRn8YBHviEXoS3XKgWoVl66yL iqabE1HZqLlchG//S+2L+8/CqGRx6iCh8SzHiKY+UbUTg1xMEc9GkjTI6bdldOqS6VlCDM/iZQJq1 QOUUnLjmsmja/RtHAYgjDE91dJYMTKv7cjYcj4gqG7Ar8cIG/PltFtxVv9p8rYFswuzY0saqM/w9B qdrl1VxVQ/Atbw==; Date: Sun, 05 Jul 2026 10:53:10 +0300 Message-Id: <86tsqd98k9.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: "J.D. Smith" <jdtsmith@HIDDEN>, Sean Whitton <spwhitton@HIDDEN> In-Reply-To: <m2qzlkl24q.fsf@HIDDEN> (jdtsmith@HIDDEN) Subject: Re: bug#81319: [PATCH] 31.0.90; new image scale check causes frequent image cache miss References: <m2wlvjlukb.fsf@HIDDEN> <87v7b34u6x.fsf@HIDDEN> <m2h5mmp6dz.fsf@HIDDEN> <86bjctfvr2.fsf@HIDDEN> <m28q7x7bpi.fsf@HIDDEN> <86wlvheah7.fsf@HIDDEN> <m233y570dq.fsf@HIDDEN> <8165654f-7f85-4f32-84e6-bbdf6a0a80ad@HIDDEN> <87bjco4gwr.fsf@HIDDEN> <CA+TD5hhX0uDzGSOm1oPYvFU=FeXwezbg5TJUXrWvidM1MrCBEw@HIDDEN> <878q7s4c06.fsf@HIDDEN> <CA+TD5hhi658gZ7mYLo4moeo=Qb7LWUW=oZ-Vq=R0yxvXYKm3Jg@HIDDEN> <m2qzlkl24q.fsf@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 81319 Cc: dmitry@HIDDEN, tmarjeski@HIDDEN, johan.myreen@HIDDEN, alan@HIDDEN, 81319 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: "J.D. Smith" <jdtsmith@HIDDEN> > Cc: Trevor Arjeski <tmarjeski@HIDDEN>, 81319 <at> debbugs.gnu.org, > alan@HIDDEN, Dmitry Gutov <dmitry@HIDDEN>, Eli Zaretskii > <eliz@HIDDEN> > Date: Fri, 03 Jul 2026 07:54:29 -0400 > > Johan Myréen <johan.myreen@HIDDEN> writes: > > > On Fri, 3 Jul 2026 at 13:13, Trevor Arjeski <tmarjeski@HIDDEN> wrote: > > > > If it's not too much to ask, I'm curious what you get if you turn on > > fractional scaling to 1.5 and run the tests with PGTK. > > > > No problem. I forgot to mention that the previous results were with 150% scaling. This time I also did more than two runs, because I noticed that > > there is a lot of deviation between runs. I also increased the number of reps from 10 to 100 to get a more consistent result. Here are the results > > with and without the patch, at 100% and 150% scaling. As you can see, the results in my previous message were pretty bogus... > > Thanks for testing. Is this with the same setup that gave very slow 14s > scrolling across 19 images before (if I'm recalling that correctly)? > > > With the patch: > > > > ;; 100% scaling. > > "Scrolled through image in 7.0 steps: 0.79 ms/step" > > "Scrolled through image in 7.0 steps: 0.78 ms/step" > > "Scrolled through image in 7.0 steps: 0.83 ms/step" > > > > ;; 150% scaling. > > "Scrolled through image in 7.0 steps: 1.80 ms/step" > > "Scrolled through image in 7.0 steps: 1.82 ms/step" > > "Scrolled through image in 7.0 steps: 1.93 ms/step" > > > > Without the patch: > > > > ;; 100% scaling. > > "Scrolled through image in 7.0 steps: 1.02 ms/step" > > "Scrolled through image in 7.0 steps: 0.95 ms/step" > > "Scrolled through image in 7.0 steps: 0.90 ms/step" > > > > ;; 150% scaling > > "Scrolled through image in 7.0 steps: 2.11 ms/step" > > "Scrolled through image in 7.0 steps: 1.61 ms/step" > > "Scrolled through image in 7.0 steps: 2.60 ms/step" > > I don't expect an effect on PGTK (only). For some reason my original > reply to Eli is not showing up on debbugs; summary in case you haven't > seen it: I've now ran the benchmark, but with one change: I used the PNG image as-is, without using ImageMagick (which I don't have). I compared Emacs 30.2 with the current pretest of Emacs 31. The results were close to what Johan reports: a factor 1.8 slowdown in Emacs 31. Is the way I've run the benchmark supposed to produce valid results? If not, would it be possible to modify the recipe to make the results reflect the issue we are discussing here, but without using ImageMagick? Anyway, the results above don't sound like a severe enough degradation to justify non-trivial changes on the release branch so close to the release. Thus, I'd prefer to install it on the master branch, where it could get more testing. If there are no problems with the change, we could then consider backporting it in Emacs 31.2. Sean, WDYT? P.S. It's a pity that the change which caused this didn't have any serious testing in the 1.5 years since it was installed. Or maybe the resulting slowdown was not severe enough to have people pay attention?
bug-gnu-emacs@HIDDEN:bug#81319; Package emacs.
Full text available.Received: (at 81319) by debbugs.gnu.org; 3 Jul 2026 12:51:54 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 03 08:51:54 2026 Received: from localhost ([127.0.0.1]:51352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1wfdN1-0004JZ-Fc for submit <at> debbugs.gnu.org; Fri, 03 Jul 2026 08:51:53 -0400 Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]:44334) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <johan.myreen@HIDDEN>) id 1wfdMx-0004If-9W for 81319 <at> debbugs.gnu.org; Fri, 03 Jul 2026 08:51:49 -0400 Received: by mail-pg1-x530.google.com with SMTP id 41be03b00d2f7-c9d1fff21edso402090a12.1 for <81319 <at> debbugs.gnu.org>; Fri, 03 Jul 2026 05:51:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1783083101; cv=none; d=google.com; s=arc-20260327; b=TiE5dCfhCFiNqcaM9ZaLiuW3doOR/kJAxXVHi3t+jWkP9ExZoif8eIcSajUjYPlL/i WLFlSfjn+GQXcSKQ+wWBKNHv10TRSxNKUtZMaltg9TUG07cs8+SqKpNKnhhMnhiaYcH5 D+LTWeLllcj6XuKAWQ3Seob6OCuj7QK65EyfRHp9zCYjjxCchiGyEpVUUtseeL5GUwr2 7N/oq934slb6qM5P9Gc4D0ntGpG17vGsie6DbIbBOmOfFLAxrtCfiWg8G7Yb3gXONgDB 6HlGW7A6vysGaUHt94dpM5SIkr3U6eV60d6v5C5VlCMLI48XCsMA0UDdWEg+ljDsK+k+ CX/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=Sb0gKFDKNJhv3GKE0un6pdF88je4A87SERDKMpsjq50=; fh=be37A3Bhc2NJXrPUy9JzA613VeiFdl4ciEis0kUyrOo=; b=fElu7qqvjsaCisk6gq/QCXn0m3EGMxOrQAvMMxLSTleXOc8XTRYZboXwMgaEJYrp6q Izo72hlBTrq+rCXHBPDLEqfY9fircatjyMeieHvTrXTgfHKv6yytcJoiqk4UocuMhjIk QqUgk3ingwVzQV3zxw2gVn1RrscbI2E5C1N+P1bTQQn1pzYB7pnyL5qad1vIOZiTjF6e wU/LpBXWLxH5CpbUEEcnfaDRYV0hGpWe0naBvajfZZ0PqVuj5WASdfkAytEgrXaZNvWm Z01IMhYAMI92MefdMeyCCyDJA9XMFUwYcSgGxs305vBJxra5LwGFo9347is+xi5Lc79/ resg==; darn=debbugs.gnu.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783083101; x=1783687901; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Sb0gKFDKNJhv3GKE0un6pdF88je4A87SERDKMpsjq50=; b=N3/qOmdWDdj/AnzKL44x5kKD31hpUSB48zUEsqAbkQmFtFvbefWdbOecC8Zxsp/K/E SQL436gSS06db2bk3OK/qjTNzUqtKeoy6bXaqHYhChQrRsQWhzgcfpzKY1Fdl5lMaLQa ufjc/r8fcTDKvtxGkq5mR5msYqfiD3Dv6EcZD8ZKJkUs1umsMrGgPm/D+nKSdDeFpkmk oZJYEqdL2OSA9eXsyIzFcSXYzPOqCdDT1ThSadkmR/8Hwx15JZIBtlsUN6QSHRhAfi/i 0Du72ikW3Iq/eNReK4WGmCQgN7iIMjuA+1iZP0MCXH8RIGIafXFuBp/NLQyiXoVB3RY5 OJww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783083101; x=1783687901; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Sb0gKFDKNJhv3GKE0un6pdF88je4A87SERDKMpsjq50=; b=RZh+dwD+JMtLCqQ4jrFrNlhmQdHw5FYCkrUQo1zLeFf4jsrCeIE9V2yr9HDBJDY4dq mKKC5Kb/1ZzXMAxqBfR0W1pCqjoCSJQ2zv8zQjR44DecriPPW49xGaVYkc1St3mWz6pc UgueFlnb2ewVqJUW7tfHJHEobXSqzSpPXDJwuxGlR+GgzA1Q/qyWI9aoV77TaAVUWDJF L76zfSFsbsfY9glVedGdde07Dif2F56kKCZ9tZi8sH3RHyPP4PScL13bkDqpLCYf0r4t GLooCnsH9KeslX8DbPCHFz3WGiOJQ6Yi8r6jYUxVgxL6CX9fhfQzM/Fl37U3U4zgelE/ VKiQ== X-Forwarded-Encrypted: i=1; AFNElJ+PFj3zn4WsLx2T8QR/5grBx6hcWuunw+TiVjLJk7u3qFdbHRI4+fHYyAXuFkD8+N/oC4Jdug==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwOhQNZ8h80aeKqukpTBNLXtbQCjXZ7FvtCM+J8HRYaWGGw/KkE OTFPNcrA58k1rfxvGyFzHQXbC5iKpXeXgeWyUav7/nD10bOWF0YAc3/pzB0+ITfc94ohrSkZ3e+ tuWhoxwXontY7efVcK1kdxe2OWaU6eug= X-Gm-Gg: AfdE7cmt7TydgSp7qx7qI+QcKS1JmULYsGVg7fGF2059gKHR8rY3rVl5O6+BMkCyO1o QulkP2XbcB3S2FxLQWN0eCSFHy3tfjQdQ/w7n5SUlkVb52F5oXUo34cLhWA9fqtaOIV34VQqas8 rY8sui1dObsQKHOhd32zpYz97TQK5ZzRJqHoMou1ZVTg8+2MHvOAuQD+hnpH9JAQLUNw3lJ5ioA yFfc8H/eTwh1/hX3HJylaVeuONeLqjmxY/1Ikd1KQGP1ZgpJu1Aj/0a2yFnnnZ5akakKdgJicaY zjUdSpgSFmXUAW7Cn4iY7YSh6+aLPlUhQ60LgA== X-Received: by 2002:a05:6300:6715:b0:3bf:96c6:78a9 with SMTP id adf61e73a8af0-3bfed0f65a8mr12027971637.2.1783083100670; Fri, 03 Jul 2026 05:51:40 -0700 (PDT) MIME-Version: 1.0 References: <m2wlvjlukb.fsf@HIDDEN> <87v7b34u6x.fsf@HIDDEN> <m2h5mmp6dz.fsf@HIDDEN> <86bjctfvr2.fsf@HIDDEN> <m28q7x7bpi.fsf@HIDDEN> <86wlvheah7.fsf@HIDDEN> <m233y570dq.fsf@HIDDEN> <8165654f-7f85-4f32-84e6-bbdf6a0a80ad@HIDDEN> <87bjco4gwr.fsf@HIDDEN> <CA+TD5hhX0uDzGSOm1oPYvFU=FeXwezbg5TJUXrWvidM1MrCBEw@HIDDEN> <878q7s4c06.fsf@HIDDEN> <CA+TD5hhi658gZ7mYLo4moeo=Qb7LWUW=oZ-Vq=R0yxvXYKm3Jg@HIDDEN> <m2qzlkl24q.fsf@HIDDEN> In-Reply-To: <m2qzlkl24q.fsf@HIDDEN> From: =?UTF-8?Q?Johan_Myr=C3=A9en?= <johan.myreen@HIDDEN> Date: Fri, 3 Jul 2026 15:51:28 +0300 X-Gm-Features: AVVi8CeBr-AG0qkAKyIxVyz_RGMde0wrpJLJnYA9v4lAaJ-vTR9HNdf-VNko7rM Message-ID: <CA+TD5hhuGQN17-Q2BWm6ho36EZ8KcCF1f=pzCw9yW=kyC-EHVQ@HIDDEN> Subject: Re: bug#81319: [PATCH] 31.0.90; new image scale check causes frequent image cache miss To: "J.D. Smith" <jdtsmith@HIDDEN> Content-Type: multipart/alternative; boundary="000000000000d20efa0655b462d0" X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 81319 Cc: Dmitry Gutov <dmitry@HIDDEN>, Trevor Arjeski <tmarjeski@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 81319 <at> debbugs.gnu.org, alan@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.0 (/) --000000000000d20efa0655b462d0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 3 Jul 2026 at 14:54, J.D. Smith <jdtsmith@HIDDEN> wrote: > Johan Myr=C3=A9en <johan.myreen@HIDDEN> writes: > > > On Fri, 3 Jul 2026 at 13:13, Trevor Arjeski <tmarjeski@HIDDEN> wrote= : > > Thanks for testing. Is this with the same setup that gave very slow 14s > scrolling across 19 images before (if I'm recalling that correctly)? > No, that was an older, slower machine. I re-ran the scrolling test on the same machine as today's tests, and the scrolling takes 4.7 =C2=B1 0.2 secon= ds. (PGTK/Wayland, 150% scaling). --000000000000d20efa0655b462d0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div class=3D"gmail_quote gmail_quote_container"><div dir= =3D"ltr" class=3D"gmail_attr">On Fri, 3 Jul 2026 at 14:54, J.D. Smith <<= a href=3D"mailto:jdtsmith@HIDDEN">jdtsmith@HIDDEN</a>> wrote:<br><= /div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bo= rder-left:1px solid rgb(204,204,204);padding-left:1ex">Johan Myr=C3=A9en &l= t;<a href=3D"mailto:johan.myreen@HIDDEN" target=3D"_blank">johan.myreen@= gmail.com</a>> writes:<br> <br> > On Fri, 3 Jul 2026 at 13:13, Trevor Arjeski <<a href=3D"mailto:tmar= jeski@HIDDEN" target=3D"_blank">tmarjeski@HIDDEN</a>> wrote:<br><b= r> Thanks for testing.=C2=A0 Is this with the same setup that gave very slow 1= 4s<br> scrolling across 19 images before (if I'm recalling that correctly)?<br= ></blockquote><div><br></div><div>No, that was an older, slower machine. I = re-ran the scrolling test on the same machine as today's tests, and the= scrolling takes 4.7=C2=A0=C2=B1 0.2 seconds. (PGTK/Wayland, 150% scaling).= </div><div><br></div></div></div> --000000000000d20efa0655b462d0--
bug-gnu-emacs@HIDDEN:bug#81319; Package emacs.
Full text available.Received: (at 81319) by debbugs.gnu.org; 3 Jul 2026 11:54:47 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 03 07:54:46 2026 Received: from localhost ([127.0.0.1]:51221 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1wfcTi-0007F3-RT for submit <at> debbugs.gnu.org; Fri, 03 Jul 2026 07:54:46 -0400 Received: from mail-oa1-x32.google.com ([2001:4860:4864:20::32]:47209) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <jdtsmith@HIDDEN>) id 1wfcTc-0007EJ-W3 for 81319 <at> debbugs.gnu.org; Fri, 03 Jul 2026 07:54:39 -0400 Received: by mail-oa1-x32.google.com with SMTP id 586e51a60fabf-44192448b56so156667fac.2 for <81319 <at> debbugs.gnu.org>; Fri, 03 Jul 2026 04:54:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783079671; x=1783684471; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8l6hQb9pl/vNtRYi5XyWCJw5WIz73EqXcUGTR0aN4M8=; b=PAU1RP4+lGi5osfqNxbGk0FJLow9ZkFAyNvU4EvMabGEFhIi4V+jMJx35gf6JKP1uV pUEZixn4xz+2CWhSupF6AexnlvDqCfPHvlNemRf3DzdNDhGjM01QDUotuqKTasVovge+ PUS9AbSceBFpFeVEv83awj6Z+b2cf5bjb0QhAD0OvrwaO9jhkdqLfKF4bAD4nvjTJzP3 Fw6UK1HaXQPcNI6k2KEY/R4ryxNvCOYLBvgmy3GwfH7yi8pGvOmIm8qR0gAfMo0RSUn3 WeS+sTEO/zTJiwSN29GvoHsQ+Rj+K2mZdXuzKgflnbMZCoxzc6JmHKqpr7XV63rYdYky 2g2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783079671; x=1783684471; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8l6hQb9pl/vNtRYi5XyWCJw5WIz73EqXcUGTR0aN4M8=; b=Me51J4wFZy/hNrCXoH/DK+xICPH6CxW2Gz8pv36++ab6HRIILqos1J0bCLk2vU54g+ Ma/0xTHsna7DHZjOfZuI9JX0DqFy6pploRfvmRBL96oeDOOm8PR80cpO9C67wdtHpHrC ce57MPQec0kn82Xupent+wks7lgf+Kws9hHnL2aqCsVbvp8aWKUUSrhvv2cTTIEPXtAd IVaLKfH1dk25R8E1A2XVg2M75gNrnG+oCoPL0e3lPwFmns5jaykVgwi7EXEZ0b8J68bs BEH5KuzEpok/oSX83oeVJRaHnswolueCUpuikzZvZjsoi2Tgquq39HThJ/gr/TDPUuVu hn2A== X-Forwarded-Encrypted: i=1; AFNElJ/kyEIdi+PC1UxrdZOVsYtGMBSgGxnSwqNxi+dGnoQGrxrh1W5HaBKbOm7/lN6gmXNHoig4ig==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxVKJDUdeSRH8fOvJxqqsC3NlJh+BfnYa2N4W1SoY7oPJNl2nL4 5r2kYDZuGj1AHEaq7CXhWXr+Jt1olUlLc5WSk4D7mAdeuQziE0S7ynHu X-Gm-Gg: AfdE7ckQAPjnwdN0ltUQkuUOSCnsVrdlmsIMlawlyvq6MW91Xvl0hPdd+ULBTfBrUAA KPM1vNaGdkoWZI7dzJTp8TEHBUiiaxpvk0lIVMfP19JEG7H5g3yRvp/RTTN0/XKcFpajIgzQSZd ObDbznifjEVzlhFOYrp+043GKqxhNRdTqJLqkrVdpyKSedhIGlma0UuDE982DfLvPdbIAf0iTK5 R7QHad0LXm5HeWtjpxiJix0BbIZYV0LGFbJs10g+ggqlj07LfJurEeGIxUtCrzuGE/d1xlknxVO VeL3xYA/wQIBgln78T3TxKqs7Z3K1E16/aweXDCBKNwQCjA771n4mbjqF5dycYbOzyt8ySqL9fF gF/kIPfLuybAttilCPhTwqw9zY3lWbqc0o42VLttd01lPB4QNWgXmBlRiZHvanAl3aQs4Uw/M8Y 6JDJ5xYihTB7LkJLQdaEaCTGW7VAy49pG9HHwaFn56UhQ= X-Received: by 2002:a05:6870:b015:b0:43d:108c:7145 with SMTP id 586e51a60fabf-44cab9a0dbdmr5627520fac.30.1783079670828; Fri, 03 Jul 2026 04:54:30 -0700 (PDT) Received: from moss (cm-24-53-187-185.buckeyecom.net. [24.53.187.185]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-44cfb5e257bsm1755540fac.14.2026.07.03.04.54.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2026 04:54:30 -0700 (PDT) From: "J.D. Smith" <jdtsmith@HIDDEN> To: Johan =?utf-8?Q?Myr=C3=A9en?= <johan.myreen@HIDDEN> Subject: Re: bug#81319: [PATCH] 31.0.90; new image scale check causes frequent image cache miss In-Reply-To: <CA+TD5hhi658gZ7mYLo4moeo=Qb7LWUW=oZ-Vq=R0yxvXYKm3Jg@HIDDEN> References: <m2wlvjlukb.fsf@HIDDEN> <87v7b34u6x.fsf@HIDDEN> <m2h5mmp6dz.fsf@HIDDEN> <86bjctfvr2.fsf@HIDDEN> <m28q7x7bpi.fsf@HIDDEN> <86wlvheah7.fsf@HIDDEN> <m233y570dq.fsf@HIDDEN> <8165654f-7f85-4f32-84e6-bbdf6a0a80ad@HIDDEN> <87bjco4gwr.fsf@HIDDEN> <CA+TD5hhX0uDzGSOm1oPYvFU=FeXwezbg5TJUXrWvidM1MrCBEw@HIDDEN> <878q7s4c06.fsf@HIDDEN> <CA+TD5hhi658gZ7mYLo4moeo=Qb7LWUW=oZ-Vq=R0yxvXYKm3Jg@HIDDEN> Date: Fri, 03 Jul 2026 07:54:29 -0400 Message-ID: <m2qzlkl24q.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 81319 Cc: Dmitry Gutov <dmitry@HIDDEN>, Trevor Arjeski <tmarjeski@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 81319 <at> debbugs.gnu.org, alan@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.0 (/) Johan Myr=C3=A9en <johan.myreen@HIDDEN> writes: > On Fri, 3 Jul 2026 at 13:13, Trevor Arjeski <tmarjeski@HIDDEN> wrote: > > If it's not too much to ask, I'm curious what you get if you turn on > fractional scaling to 1.5 and run the tests with PGTK. > > No problem. I forgot to mention that the previous results were with 150%= scaling. This time I also did more than two runs, because I noticed that > there is a lot of deviation between runs. I also increased the number of = reps from 10 to 100 to get a more consistent result. Here are the results > with and without the patch, at 100% and 150% scaling. As you can see, the= results in my previous message were pretty bogus... Thanks for testing. Is this with the same setup that gave very slow 14s scrolling across 19 images before (if I'm recalling that correctly)? > With the patch: > > ;; 100% scaling. > "Scrolled through image in 7.0 steps: 0.79 ms/step" > "Scrolled through image in 7.0 steps: 0.78 ms/step" > "Scrolled through image in 7.0 steps: 0.83 ms/step" > > ;; 150% scaling. > "Scrolled through image in 7.0 steps: 1.80 ms/step" > "Scrolled through image in 7.0 steps: 1.82 ms/step" > "Scrolled through image in 7.0 steps: 1.93 ms/step" > > Without the patch: > > ;; 100% scaling. > "Scrolled through image in 7.0 steps: 1.02 ms/step" > "Scrolled through image in 7.0 steps: 0.95 ms/step" > "Scrolled through image in 7.0 steps: 0.90 ms/step" > > ;; 150% scaling > "Scrolled through image in 7.0 steps: 2.11 ms/step" > "Scrolled through image in 7.0 steps: 1.61 ms/step" > "Scrolled through image in 7.0 steps: 2.60 ms/step" I don't expect an effect on PGTK (only). For some reason my original reply to Eli is not showing up on debbugs; summary in case you haven't seen it: > Both of the following appear to be affected: > > 1. Images of type `imagemagick' on any build (almost[1]), and > > 2. Graphical system *without* HAVE_NATIVE_TRANFORMS defined (for all > image types). > > [1] Except possibly PGTK, where the flag > DONT_CREATE_TRANSFORMED_IMAGEMAGICK_IMAGE is defined, and consequently > the early bailout from `image_set_transform' is skipped.
bug-gnu-emacs@HIDDEN:bug#81319; Package emacs.
Full text available.Received: (at 81319) by debbugs.gnu.org; 3 Jul 2026 10:44:55 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 03 06:44:55 2026 Received: from localhost ([127.0.0.1]:51030 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1wfbOB-0008Cn-DI for submit <at> debbugs.gnu.org; Fri, 03 Jul 2026 06:44:55 -0400 Received: from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535]:51346) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <johan.myreen@HIDDEN>) id 1wfbO8-0008CQ-Nw for 81319 <at> debbugs.gnu.org; Fri, 03 Jul 2026 06:44:53 -0400 Received: by mail-pg1-x535.google.com with SMTP id 41be03b00d2f7-ca00f126b7eso218388a12.2 for <81319 <at> debbugs.gnu.org>; Fri, 03 Jul 2026 03:44:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1783075486; cv=none; d=google.com; s=arc-20260327; b=SO0STg1OyzJi3wAgLZPia9NfBTaxW8jDB7JEc1HQf/7Cspy+lu3gYj0MmUD35+fwAU EqWRoYNSyuWMeqWTkiOkXYAmP6aLQkdcNbMOxNURtTlsHnCe8a25STJcho+Qs0u/luOh QdkStDMX8VJuYSTHqtbfwFDlv7uV+u4gqfM8uJ1Y8lMDnuW+Fmte4gBsesF7g82kXb/g j1Y4XBEA5Z/4pTYvd+GHenYtYrgF8fn68IRllTf72K8s1ame0hlxaxb0TBPCtzm6aQ7K 4bMskMjxJL2xajVolKa6XLV/rzeXNcQ9eWL5uBfAfpeAeDcLqUZr+KFqgKCBaIdxi52b LA6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=3wgBYHbENrA9nUdYKcILJ/6IE0ccf64HFSZCfD1u5aw=; fh=UlRwPiSkN4LFEemJV0HqkaOmN3iOAN2eLiiK5rdZSaM=; b=W5+5w7VL9Yf375k1Bsq2hSIUpyAdbvASxcpHkGXHGVA6ZI4vAwx7GLP+v5o3N8XRIh mmfvmQQJCUOt+B+jFoRiBthaQwQn61eMRDku9UUtq7+yn/Bu0nQEtbhuFLfI3iEW/+Ip Q/lh8g9fuzHao/VHeTrCSCO3YIphh7VdoGd30aGCPG/TeZPEaEAUnyX/E5mzH8xsM1mS TLTVM8k878C/0TtErZHj6tBS6/N9AXtCdfOjZxPPbcKuorRQPZXB/8809DjbNwI/9u3M UhmyJ59Goqt3aTZKwXiojvvpJXroHwyjS21Yq+APtf+gM6A6sm8OMZkLuo6PndEQiYxZ 7uXA==; darn=debbugs.gnu.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783075486; x=1783680286; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=3wgBYHbENrA9nUdYKcILJ/6IE0ccf64HFSZCfD1u5aw=; b=Q+0mLcTwxsU6Nt+qpPIDylGku5W/y9TDtIwZ6aRmxsVIe8G3xmO6ypNTgaGSLtmBkA MsPXkuCTB2fcy7ULaZ9MifjiVLUwyEh23b/RRv0INldtsdjAwL8yOkS0znhI4mN51S08 tRsOgNypbgq6tJ67uBalc7NqG71k9LgIFvRQagK4JByNVACEmW8v6KEyVZPym2pCHGSS 5p++P1ghv5Cjhtsqu6VPjj8jLOduOT+L172jH/bmzzAriG+k6jQkWRzkSnOhPFkfthiy pAcs8iSXqSI3DYsQI0uy1XFtZl3hTMO1w8DuZXuvvnCf92BcVCfbEVZ8tcekE7GdYsqQ Aq3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783075486; x=1783680286; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3wgBYHbENrA9nUdYKcILJ/6IE0ccf64HFSZCfD1u5aw=; b=EGT6sSs1hd0QqWP3n1CaVbBcdwUMYKZxzEsTpJGRrF5Kp3KPON/tmDdpZE4BDdHHZN fbz7lrFTNJL43Fbl07etQ1rY8N7pfFHaAticy1I8OO7HOAqYfyv5h8RiTAWRaRZ6Zdfm 0+o13JSder5Fr0MAjBhzFvHyTr9RjU18N8qA+yhdj8yC8lKmKHXQgPG+G0qsTC2VrPsr IRKoZGDkn+046bxyJ59gFMQtMcA77603YPPiSzfXLs+9w5O9s12lVF+YDZ4CgtHYWCLx nvCHRD8hCyJaDSCaFJ48nXnUkl0K4RVsFppxC+bHDwgs94YKWgaydWHtKWjuKjnIwhyH NTAQ== X-Forwarded-Encrypted: i=1; AFNElJ/WgHwqT/Bzn6BGp7q2I89MOWQNOzPkkl91ufcWDXkmwp0BHrdp9wdnBCrXvyAHlePfsl2VyA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzjU2i7aZo8K68y/QMB1cqMNz2rTo5tgEGLXgdK5FNR4W85t8gT o7IpoHhooXQOmokJNwATRT8P06XvjSJdZ8gK37gvwaKnb0qbdgCajH/vLI+5m8GxtLg9Zhk0PGS kuqxyK9LYscxxBh8ViNhLou8ou1WwbeM= X-Gm-Gg: AfdE7ckAxOZJTJPBO8w9UFNEoKWDTvFCB5L5LmJSfKLrLMXntnU192zPg1PU9TXKYXa 3iw2Mk53W+J8OyWULrzcSgtrinYb3itx6yVyejInu42NA65wDElOK1/nhS2DK0eJTEsJWa1WVsw CUvcj1rfvF/rw8lntHxo1eR0PXPyQ3I6Aq64hYb0PpayoL+ZJCglOBKsvRK20hLhLA9lM1GRUH1 fwyvv2Fz++qEMLI5hycVus5IDizKHi0oMantD4eEXOlwiP9LWKgh7wdfOnXweuibiMpX2qzGgpw 2vVc9D0ytDxdGZnR5OyiMH4zJtc= X-Received: by 2002:a05:6a21:6113:b0:3bf:8de9:c647 with SMTP id adf61e73a8af0-3bfecd5e0ebmr11936101637.0.1783075486346; Fri, 03 Jul 2026 03:44:46 -0700 (PDT) MIME-Version: 1.0 References: <m2wlvjlukb.fsf@HIDDEN> <87v7b34u6x.fsf@HIDDEN> <m2h5mmp6dz.fsf@HIDDEN> <86bjctfvr2.fsf@HIDDEN> <m28q7x7bpi.fsf@HIDDEN> <86wlvheah7.fsf@HIDDEN> <m233y570dq.fsf@HIDDEN> <8165654f-7f85-4f32-84e6-bbdf6a0a80ad@HIDDEN> <87bjco4gwr.fsf@HIDDEN> <CA+TD5hhX0uDzGSOm1oPYvFU=FeXwezbg5TJUXrWvidM1MrCBEw@HIDDEN> <878q7s4c06.fsf@HIDDEN> In-Reply-To: <878q7s4c06.fsf@HIDDEN> From: =?UTF-8?Q?Johan_Myr=C3=A9en?= <johan.myreen@HIDDEN> Date: Fri, 3 Jul 2026 13:44:33 +0300 X-Gm-Features: AVVi8Cfaa5EZuRwK1SZx6p3ZZvUPBSPAmLLF_W5BMbSsTllZnk2MLQuDVNqLLro Message-ID: <CA+TD5hhi658gZ7mYLo4moeo=Qb7LWUW=oZ-Vq=R0yxvXYKm3Jg@HIDDEN> Subject: Re: bug#81319: [PATCH] 31.0.90; new image scale check causes frequent image cache miss To: Trevor Arjeski <tmarjeski@HIDDEN> Content-Type: multipart/alternative; boundary="000000000000f8b3ad0655b29ca5" X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 81319 Cc: yantar92@HIDDEN, 81319 <at> debbugs.gnu.org, alan@HIDDEN, Dmitry Gutov <dmitry@HIDDEN>, "J.D. Smith" <jdtsmith@HIDDEN>, Eli Zaretskii <eliz@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.0 (/) --000000000000f8b3ad0655b29ca5 Content-Type: text/plain; charset="UTF-8" On Fri, 3 Jul 2026 at 13:13, Trevor Arjeski <tmarjeski@HIDDEN> wrote: > > > If it's not too much to ask, I'm curious what you get if you turn on > fractional scaling to 1.5 and run the tests with PGTK. > > No problem. I forgot to mention that the previous results were with 150% scaling. This time I also did more than two runs, because I noticed that there is a lot of deviation between runs. I also increased the number of reps from 10 to 100 to get a more consistent result. Here are the results with and without the patch, at 100% and 150% scaling. As you can see, the results in my previous message were pretty bogus... With the patch: ;; 100% scaling. "Scrolled through image in 7.0 steps: 0.79 ms/step" "Scrolled through image in 7.0 steps: 0.78 ms/step" "Scrolled through image in 7.0 steps: 0.83 ms/step" ;; 150% scaling. "Scrolled through image in 7.0 steps: 1.80 ms/step" "Scrolled through image in 7.0 steps: 1.82 ms/step" "Scrolled through image in 7.0 steps: 1.93 ms/step" Without the patch: ;; 100% scaling. "Scrolled through image in 7.0 steps: 1.02 ms/step" "Scrolled through image in 7.0 steps: 0.95 ms/step" "Scrolled through image in 7.0 steps: 0.90 ms/step" ;; 150% scaling "Scrolled through image in 7.0 steps: 2.11 ms/step" "Scrolled through image in 7.0 steps: 1.61 ms/step" "Scrolled through image in 7.0 steps: 2.60 ms/step" Johan --000000000000f8b3ad0655b29ca5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><br><div class=3D"gmail_quote gmail_quote_container"><div = dir=3D"ltr" class=3D"gmail_attr">On Fri, 3 Jul 2026 at 13:13, Trevor Arjesk= i <<a href=3D"mailto:tmarjeski@HIDDEN">tmarjeski@HIDDEN</a>> wr= ote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px= 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br> <br> If it's not too much to ask, I'm curious what you get if you turn o= n<br> fractional scaling to 1.5 and run the tests with PGTK.<br> <br></blockquote><div><br></div><div>No problem. I forgot to mention that t= he=C2=A0 previous results were with 150% scaling. This time I also did more= than two runs, because I noticed that there is a lot of deviation between = runs. I also increased the number of reps from 10 to 100 to get a more cons= istent result. Here are the results with and without=C2=A0the patch, at 100= % and 150% scaling. As you can see, the results in my previous message were= =C2=A0pretty bogus...</div><div>=C2=A0</div><div>With the patch:<div><br>;;= 100% scaling.<br>"Scrolled through image in 7.0 steps: 0.79 ms/step&q= uot;<br>"Scrolled through image in 7.0 steps: 0.78 ms/step"<br>&q= uot;Scrolled through image in 7.0 steps: 0.83 ms/step"<br><br>;; 150% = scaling.<br>"Scrolled through image in 7.0 steps: 1.80 ms/step"<b= r>"Scrolled through image in 7.0 steps: 1.82 ms/step"<br>"Sc= rolled through image in 7.0 steps: 1.93 ms/step"<br><br></div><div>Wit= hout the patch:</div><div><br></div><div><div>;; 100% scaling.</div><div>&q= uot;Scrolled through image in 7.0 steps: 1.02 ms/step"<br>"Scroll= ed through image in 7.0 steps: 0.95 ms/step"<br>"Scrolled through= image in 7.0 steps: 0.90 ms/step"</div><div><br></div>;; 150% scaling= </div><div>"Scrolled through image in 7.0 steps: 2.11 ms/step"<br= >"Scrolled through image in 7.0 steps: 1.61 ms/step"<br>"Scr= olled through image in 7.0 steps: 2.60 ms/step"<br></div>=C2=A0</div><= div>Johan</div><div><br></div></div></div> --000000000000f8b3ad0655b29ca5--
bug-gnu-emacs@HIDDEN:bug#81319; Package emacs.
Full text available.Received: (at 81319) by debbugs.gnu.org; 3 Jul 2026 10:13:25 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 03 06:13:25 2026 Received: from localhost ([127.0.0.1]:50867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1wfatg-0006fh-Rz for submit <at> debbugs.gnu.org; Fri, 03 Jul 2026 06:13:25 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]:56578) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <tmarjeski@HIDDEN>) id 1wfate-0006f8-Dd for 81319 <at> debbugs.gnu.org; Fri, 03 Jul 2026 06:13:22 -0400 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-4720d22c94aso387925f8f.1 for <81319 <at> debbugs.gnu.org>; Fri, 03 Jul 2026 03:13:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783073596; x=1783678396; darn=debbugs.gnu.org; h=content-transfer-encoding:content-type:mime-version:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=pJlUAlx9giDQKAlK0DQPvsQHKbRFP7KfAKXJE3ueYuM=; b=ZLY6B3Sp3BO6cr8oWuebVpnV8jQNOv6CGLgr7jSRmuylSU1h/pxVFAl8Yie1mWoe/G SORdWA7S2BFw4H5Ksydm3QBiINlVnw2dhve55/BBFRHa6CMBZClRD7HlMlNHW+oGwYt3 SEyCoy4xBLrigO6zMMIP/gu8esN8PO4YyzZg8sxZ7GNpNbOtbxGA6Z6azEEgGmnlT0WI zSPHlQNtfhBgJEbnqeVKTu1NFHnA9LWyBzK/E+vVBTWDTEQUQqzOf2U+ObWhW9KdAz5H 4oW+ShCD141RUgfZcF/rO8VIZWe6m22J6ZYMBbsePEdLiCXZzGw1yUMP0cY+kdUI99S5 fRaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783073596; x=1783678396; h=content-transfer-encoding:content-type:mime-version:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=pJlUAlx9giDQKAlK0DQPvsQHKbRFP7KfAKXJE3ueYuM=; b=VH0y/duxl5xROjXzaiT/OgXCB4e/sXbKADhqH5ssTw7XbG7BWQ32+dWcDDwDH6hFMv d3TFX9kgnR5l37N2ecaC9iA5DNSyJq+70MxT+EOuqcPtJILNlMgbLF5CfQBrwlQfVo+9 ZJhJjVi5wzuIpyXcgOCGPl2JWM7UQ2YGJR9ust0YMyWQTRy5aGzURR7T6c82x6qkTaKg ysQj0jUi9+PGKk6tPx7hxjI2sDQfjZQH191HykE8E8HKYUx7O1+OrTFonmLWKjbLVT9M HxKHYVEujrnCsBhtowFDK/SzJ9FdUAbUTW/TmUDkMY2Hc21pR82EYQFAzn4NdqMvLCUV GQhg== X-Forwarded-Encrypted: i=1; AHgh+RreauxWDLYQ4wGXUnWfHRBEoEW546gqvHgpG66H8WaDEfH3Yra2WbQeis7TG8dEKXrQEl/n9Q==@debbugs.gnu.org X-Gm-Message-State: AOJu0Ywb5/92qmsKDZOxN1n4dd1vZfPDcFCpM7kSqknGXueaZFUlWwrh lMKL6G9Dov/1z3HrOq9aTr8wnPBTNfUWpwCGozBOnoLrOie9Zb2ZTu5WbB0MmHe5AWvzIIQY X-Gm-Gg: AfdE7cmSP+rPVEvO3qh9mlDW7gjMngtJivEdmgRhq21FqEbeva67zx+JwouWUAZkLsk MWOi47zXEyeqfQtdJQQT9pTbt5jJqFMenZBsVnv/H6g+HpB4yQRtNmoxwhzg0XuQBwj97Q1nm/+ MQNZwhFfZM39nfAMNzTGVDr7y+ExaepE8UPpGG0hKBE7C3/X1sxrAGifmRKe+YvI3DKnTjKEfsB 1hME6aTP9MvdovqrJSTNnOLbXfHnbr/wmS39BtQX8WPWNuCTG2ncQNRJiEwgDpLtbrA31aXWSLv MQw4zrsIYvds/cPG7Hlmx9ghsbfBPJE8VEUvcErLfa4MxPKeuZ+/rNX8lMKEtNe1l4OV7/yntH/ G2yNKmEubja6Lz+lozfeNiu/tpQ3mbKNfn7M4HwfM9ADooxg1XoMpPQJSL+EFm1x9zcH0Pk+8sT cXn5EYe4A5Snepl5KG8JHLvS9GH2WCdwYVWVdM0YpJHquysJU+3dfwj/Psmp2ytXqUBgxlTeLwJ Nfi/ZDS8h+5UzQX8nktM9g3JsWm4XLPLy9xJttFhCrYzrbttTNd7Hck2N5HVw== X-Received: by 2002:a05:6000:27d3:b0:475:ba80:b657 with SMTP id ffacd0b85a97d-477aeb5d587mr10080522f8f.3.1783073596153; Fri, 03 Jul 2026 03:13:16 -0700 (PDT) Received: from stinkpad (nym-exit.ch-18.spectredao.net. [185.191.239.164]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477db8a450bsm17965115f8f.10.2026.07.03.03.13.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2026 03:13:15 -0700 (PDT) From: Trevor Arjeski <tmarjeski@HIDDEN> To: Johan =?utf-8?Q?Myr=C3=A9en?= <johan.myreen@HIDDEN> Subject: Re: bug#81319: [PATCH] 31.0.90; new image scale check causes frequent image cache miss In-Reply-To: <CA+TD5hhX0uDzGSOm1oPYvFU=FeXwezbg5TJUXrWvidM1MrCBEw@HIDDEN> References: <m2wlvjlukb.fsf@HIDDEN> <87v7b34u6x.fsf@HIDDEN> <m2h5mmp6dz.fsf@HIDDEN> <86bjctfvr2.fsf@HIDDEN> <m28q7x7bpi.fsf@HIDDEN> <86wlvheah7.fsf@HIDDEN> <m233y570dq.fsf@HIDDEN> <8165654f-7f85-4f32-84e6-bbdf6a0a80ad@HIDDEN> <87bjco4gwr.fsf@HIDDEN> <CA+TD5hhX0uDzGSOm1oPYvFU=FeXwezbg5TJUXrWvidM1MrCBEw@HIDDEN> Date: Fri, 03 Jul 2026 10:13:13 +0000 Message-ID: <878q7s4c06.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 81319 Cc: yantar92@HIDDEN, 81319 <at> debbugs.gnu.org, alan@HIDDEN, Dmitry Gutov <dmitry@HIDDEN>, "J.D. Smith" <jdtsmith@HIDDEN>, Eli Zaretskii <eliz@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.0 (/) Johan Myr=C3=A9en <johan.myreen@HIDDEN> writes: > I missed this, because I read the earlier messages haphazardly and got the > impression that the patch was specifically for macOS. Sorry. > > Anyway, I ran the test code and here are the results on Linux / KDE Plasma > / PGTK build (Wayland): > > Without the patch: > Scrolled through image in 7.0 steps: 10.1 ms/step > > WIth the patch: > Scrolled through image in 7.0 steps: 7.6 ms/step > If it's not too much to ask, I'm curious what you get if you turn on fractional scaling to 1.5 and run the tests with PGTK.
bug-gnu-emacs@HIDDEN:bug#81319; Package emacs.
Full text available.Received: (at 81319) by debbugs.gnu.org; 3 Jul 2026 09:37:00 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 03 05:37:00 2026 Received: from localhost ([127.0.0.1]:50598 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1wfaKS-0004m7-Bc for submit <at> debbugs.gnu.org; Fri, 03 Jul 2026 05:37:00 -0400 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]:51392) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <johan.myreen@HIDDEN>) id 1wfaKP-0004lo-Ki for 81319 <at> debbugs.gnu.org; Fri, 03 Jul 2026 05:36:58 -0400 Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-842358aaf36so192788b3a.2 for <81319 <at> debbugs.gnu.org>; Fri, 03 Jul 2026 02:36:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1783071411; cv=none; d=google.com; s=arc-20260327; b=QK5qI7HOc6tuFofyjIAj5U31D6RXWsgzu7wfUCq+QLAO6L9Kpu/q2u0l8TwReKz97h Li75U1jLSldkhJP7fia6eWiC6KMA9hjz4QEtXf3nBAHIb57TxmWGXpyssVHSZIrcnewG unBZ1sCUx+7sVvm2zjLNqR3EMQeKc2DCkRxjuFELi5wazEz9xLfBHxMueCi/PbhYnFF3 O1b4grTQSB9AhBPaue/Hmlp9YhFSweh+WSmOAdG2DbmxAa2RDmKyb7yWEftUJtcwkNR1 0luKUn2uDaUWtgXixevD5xr4UCH1PVLut+H9TdTrxaHd/J30RJKcub6CzL06UltMdian x49w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=U3PRIJ8OXgII6RF3qZgWzPhHoggppc+Br6kOCnuNfPo=; fh=VpMoarRfzCny56scqIq+akrhRswHqo/8atVpFt5nuZ0=; b=H62bQe5GKtOTjj3DOXTH0Av2ZMzjO54l6kRtCw2+20ZtdH03m4647iNHd+YtGYrtNc 3ZjWMVJhNjNCOSQ63GfhZhhZz+uTMlvNaQi4rQ5jpAONZLtD4O1v4v1pR46QwNJ0B8HF bU91ivAs+ToWA6zPmGHyUWGJjBWAPNtDzeE8UYRIZvrfOok2NVMxBZup2R9oaXeln/4X QtL1LkJppz6bjF1utrGjQMFCr084S3w6h8CA8zknrl5s3ngeh4ahEbyIU5mp9DJYZDt4 Y9PDPLGmC4pCDsUFIvfsgJ9vZ0AGtj1Hkf9Ujr2LCmKC/UJe7eBEAjNqOysFkt0CmqaL Kq5w==; darn=debbugs.gnu.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783071411; x=1783676211; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=U3PRIJ8OXgII6RF3qZgWzPhHoggppc+Br6kOCnuNfPo=; b=JTWOWfylJM9mNr1gsAaRF2D5wvXuUz79c+aFx1x+lAaB+iHKjnqMRoBDvUOOjSJ5Ey OSc83/B40Cw9TIWMqe1CfA0i/Gh0JexBIZjwYEEXX69TgtCLhu8MkYzn86CpcWAmQhlX 7AeDy4zHV/ksSSc/mXNOVwBUPhnaqntRIvebpkHlplYt/4EuZMyEDr+WJ+XkvTnQHwq/ Eu1ZLlSPOhpU5BMMG/de5SSfH2uH49/WgrV26fmvIjPXXAmxcA7bKU6o7+wqTSzt4nbA kXmGg5SjDluakdGujRr84nujeL03m+aAdY/d9/EbrovFpC4W18HddS5m1h9PAyu8BPmJ U2PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783071411; x=1783676211; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=U3PRIJ8OXgII6RF3qZgWzPhHoggppc+Br6kOCnuNfPo=; b=MMgk29ab4r8TKRBUZNJ/+JGGIh1rSQpxuK7eVwBUmWEv79zHsULVe3cph3NCsdOL1I tjQbIPZFa7ghb/uFFwqsu6Eg7YQZBcQeUTP90qscLstIimerhtF5gOaivkyBDVWumzlu pDF0SK1xjE5QqJOcOj6Y+8rtC+b4FpnABpMDnCOY8Cn4o6VutkEg++XRYYJvKrBIzE/y TYBFbpgVclpYEiIslyPudG9iadD7HOAtQl0JN6b63quSMGqbuTIC//cVTsQzPqW8edjY rzbJNjt3aECzLAaZZEZokKeH2KH8LzLuGeAO7xuFORVcZlYDbEgLXTecJgTtGzLET5tf cRyw== X-Forwarded-Encrypted: i=1; AFNElJ8kY02p9Kw73V25JDsDnDzbwH4xUvrVsKUIiUyttH6ziuLvNK7aZlnRCaAW7demj/7H4qYvoA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxG4W5OqhZ3N8ssyYWsp7619vE7IXGB5Pl9YUZjoNrWsjYKfkNK p1fQ9vpoDbOJ+A5uOoWW39sLnHpTp9rEj7yopJvh52FiT4NPANIPDIjPiVIssIIZMfn550RqEq5 +rw9xJz8qIQvzriDOgqB1jFNZL4NQxB0= X-Gm-Gg: AfdE7cm0q/PvAvBSxnrPbQLkRP71YwuROFOhTM43tUQt4fEE1CB+LUl+tDZhdc6u35y Zjp3m87HHWwx7AFxMReZ+UnP68ym/7tChBUwHGJBF12B86miqBkfVItrnoKmszTfW2TFa9/rouV KQFsTgC8VCL+Tb7zsjzT8p1oahQXc/QluLt9Yu4EwtraRHiKuQq5PxS4OPzPW0hsQQxpKFSHG9J PP8I6qSbugdAgwtyKfVO6o95Gx73dQjfd+/jIN5yEUhBoZrMhrjU84k+jFlKZ7SMMVtRfOQwY6i 6i5StRfWElUZVK+T9v81nc3SR8my4s0zee4ZJw== X-Received: by 2002:a05:6a20:258c:b0:3b3:1b38:d9c3 with SMTP id adf61e73a8af0-3bfed11e519mr11178372637.4.1783071411285; Fri, 03 Jul 2026 02:36:51 -0700 (PDT) MIME-Version: 1.0 References: <m2wlvjlukb.fsf@HIDDEN> <87v7b34u6x.fsf@HIDDEN> <m2h5mmp6dz.fsf@HIDDEN> <86bjctfvr2.fsf@HIDDEN> <m28q7x7bpi.fsf@HIDDEN> <86wlvheah7.fsf@HIDDEN> <m233y570dq.fsf@HIDDEN> <8165654f-7f85-4f32-84e6-bbdf6a0a80ad@HIDDEN> <87bjco4gwr.fsf@HIDDEN> In-Reply-To: <87bjco4gwr.fsf@HIDDEN> From: =?UTF-8?Q?Johan_Myr=C3=A9en?= <johan.myreen@HIDDEN> Date: Fri, 3 Jul 2026 12:36:40 +0300 X-Gm-Features: AVVi8CcvWl3NcUtSdDmbVTeSy1jkuzCKvDyYuecRnD62k-dBcHgUmKKwEsTJq5I Message-ID: <CA+TD5hhX0uDzGSOm1oPYvFU=FeXwezbg5TJUXrWvidM1MrCBEw@HIDDEN> Subject: Re: bug#81319: [PATCH] 31.0.90; new image scale check causes frequent image cache miss To: Trevor Arjeski <tmarjeski@HIDDEN> Content-Type: multipart/alternative; boundary="0000000000001434850655b1aad2" X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 81319 Cc: yantar92@HIDDEN, 81319 <at> debbugs.gnu.org, alan@HIDDEN, Dmitry Gutov <dmitry@HIDDEN>, "J.D. Smith" <jdtsmith@HIDDEN>, Eli Zaretskii <eliz@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.0 (/) --0000000000001434850655b1aad2 Content-Type: text/plain; charset="UTF-8" I missed this, because I read the earlier messages haphazardly and got the impression that the patch was specifically for macOS. Sorry. Anyway, I ran the test code and here are the results on Linux / KDE Plasma / PGTK build (Wayland): Without the patch: Scrolled through image in 7.0 steps: 10.1 ms/step WIth the patch: Scrolled through image in 7.0 steps: 7.6 ms/step On Fri, 3 Jul 2026 at 11:27, Trevor Arjeski <tmarjeski@HIDDEN> wrote: > Dmitry Gutov <dmitry@HIDDEN> writes: > > > On 29/06/2026 19:54, J.D. Smith wrote: > >> The image redisplay/scrolling performance. For example, I believe > >> Dmitry (now copied) noted it took 14s to scroll the 19 images in that > >> example. > > > > Not me (I'm more in the "text-only buffers" department). > > > > Maybe it was Trevor, or in any case he might be interested in testing > > the patch. Adding him to copy. > > Definitely was Johan, from what I can tell from my search back in the > list on that GPU thread: > https://lists.gnu.org/archive/html/emacs-devel/2026-06/msg00345.html > > Trevor > --0000000000001434850655b1aad2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div>I missed this, because I read the earlier messages ha= phazardly and got the impression that the patch was specifically for macOS.= Sorry.</div><div><br></div><div>Anyway, I ran the test code and here are t= he results on Linux / KDE Plasma / PGTK build (Wayland):</div><div><br></di= v><div>Without the patch:<br>Scrolled through image in 7.0 steps: 10.1 ms/s= tep<br><br>WIth the patch:<br>Scrolled through image in 7.0 steps: 7.6 ms/s= tep</div><div><br><br></div></div><br><div class=3D"gmail_quote gmail_quote= _container"><div dir=3D"ltr" class=3D"gmail_attr">On Fri, 3 Jul 2026 at 11:= 27, Trevor Arjeski <<a href=3D"mailto:tmarjeski@HIDDEN">tmarjeski@gma= il.com</a>> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"m= argin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left= :1ex">Dmitry Gutov <<a href=3D"mailto:dmitry@HIDDEN" target=3D"_blank= ">dmitry@HIDDEN</a>> writes:<br> <br> > On 29/06/2026 19:54, J.D. Smith wrote:<br> >> The image redisplay/scrolling performance.=C2=A0 For example, I be= lieve<br> >> Dmitry (now copied) noted it took 14s to scroll the 19 images in t= hat<br> >> example.<br> ><br> > Not me (I'm more in the "text-only buffers" department).= <br> ><br> > Maybe it was Trevor, or in any case he might be interested in testing = <br> > the patch. Adding him to copy.<br> <br> Definitely was Johan, from what I can tell from my search back in the<br> list on that GPU thread:<br> <a href=3D"https://lists.gnu.org/archive/html/emacs-devel/2026-06/msg00345.= html" rel=3D"noreferrer" target=3D"_blank">https://lists.gnu.org/archive/ht= ml/emacs-devel/2026-06/msg00345.html</a><br> <br> Trevor<br> </blockquote></div> --0000000000001434850655b1aad2--
bug-gnu-emacs@HIDDEN:bug#81319; Package emacs.
Full text available.Received: (at 81319) by debbugs.gnu.org; 3 Jul 2026 08:27:30 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 03 04:27:30 2026 Received: from localhost ([127.0.0.1]:50321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1wfZFB-00017J-M9 for submit <at> debbugs.gnu.org; Fri, 03 Jul 2026 04:27:29 -0400 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]:55706) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <tmarjeski@HIDDEN>) id 1wfZF8-00016y-KX for 81319 <at> debbugs.gnu.org; Fri, 03 Jul 2026 04:27:27 -0400 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-45fd464d51fso154440f8f.3 for <81319 <at> debbugs.gnu.org>; Fri, 03 Jul 2026 01:27:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783067240; x=1783672040; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=KL4nijh5sv1TqLPaSDeZ0XzawcyokANHgS5sJMUmh/o=; b=LL9zUBS4v9e8iwEs9Cgh2Wma1QpKxqlz5BjHc/hqg7gg46NZpfrPLaFD6OxnqFGXHa ET9n0ejh0/nP35WYgjmNnWOhqs0Ig8SDqve6YerkaekzrfD9z6CAC5uWqi+b87kae+1S XzB6Oo2hBHuoU9G2v7UOc9R4FBJeIih8IiIgQfvwy5A3+wuNIodFJa7/4RpZ9cf+yLy9 K5M3eI8yOiO2i2GFK94+4/7sTImKMoDGZaKbm0x1asC+PLVDT9ZXyS7NFaib5gKtyOUv ObMDa6vFxU+oesc13SX93D32imzlKiXijctzB8bF3aasXOz0qgZzoqSvB9xGXaCatJbm G6gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783067240; x=1783672040; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KL4nijh5sv1TqLPaSDeZ0XzawcyokANHgS5sJMUmh/o=; b=On1iJqfg79KxLumIcIFyIjOlT4+iKDHvy2SSfRDpR6C/A0qD20b2FVZQ2Ij66A43FK WGJNvy9l5Q4w9NRSrDuX44c8zP6UVLEXt7A44/eJNo1Q+kqKLOyMGBM6C5O4FGQzg7hV W9VeFUL3J8+jzwfJraVZ2jo/NfORcwGf4j7mG6XGcWW5zE2vdiG44f8IpZ8cypiXesQQ 462r8yDAlKW7yikkOSERQ4XO/o0Unizamze7umgW1iy5LWOMRXeurMGozA/n0rjWykbK rqTpLFr0hVL1t3qYWELaMs8UsRUv6QTZSuP4tZpGsAm9MvLilWZggJHMjEnKpdDYeGNl kOVw== X-Forwarded-Encrypted: i=1; AHgh+Rr7zI4ZNvCodKX/bCqTW0T0DZ7kkK+oYDiTr27tjJymuTsVRqrCYa1Qjk2YV9Gkz/OTBNwWkw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwpXoSv2xx8aCEOYXXRPN+Rf9q8Y05EYJ3xt1qD0WcpFf+qR/y9 QgRK1+OZVa/n/6FX9PzfG66DiM3fqTlJZev5BwhBHMjnIqF6SVWkP+YK X-Gm-Gg: AfdE7ckybu7E3V3OdZJT8jdIkFtlBhT8MM9lWK3BialfGlfK0dvKYibUqrXiqbbcDml rmNV9Noq6Nn19rpuXOitgv+MTNFASg5irApfssN59wEb+D2DNdAxX3to9fuDAX+FPiw2qA6Gj8M vts9lE/1gQX4RJqjL/oCsBvumbrkyw+t/eOHUb4Mq1yBfVKyxmG9c3E2ZYyIiUcI21Eg4oBk/fn axB56W69WHEHiuq0sbt9tngPTOCD0S+ikV3ZBNliMBi58JTNuzlfNhsPJmTtSd5rBd4UY/qQmnP IqtWIABIQ3S1mVEOarmWK1xIFUpKd+468A3KDnXytBWy+6myD5ihNVPIJEBDVh8xtMzBu+RsM1l i7+DRG5im7hK0osZn5BnSl+vWMltjuEaqOHKkFBPjQ2C+3ZzelESMabb8vy4Sqiv0g4oEDZ2+dn DsoeLNSZw1vw4AXON/SeeRRppjCLLfHbsqbi8yz6R/Fz+4gPIQKj/OfUUbw3eHNjcyYJpgdEOiJ +VuQ671ZaJbnPbdjGUnUsjuUG1w+AiI7ZNua8AqXAVCDpzcGRXt7sXWfJhV2A== X-Received: by 2002:a05:6000:2c09:b0:46f:f12b:e454 with SMTP id ffacd0b85a97d-47757897692mr15738054f8f.17.1783067240002; Fri, 03 Jul 2026 01:27:20 -0700 (PDT) Received: from stinkpad (nym-exit.ch-18.spectredao.net. [185.191.239.164]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477db3dbbe6sm15388007f8f.6.2026.07.03.01.27.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2026 01:27:19 -0700 (PDT) From: Trevor Arjeski <tmarjeski@HIDDEN> To: Dmitry Gutov <dmitry@HIDDEN>, "J.D. Smith" <jdtsmith@HIDDEN>, Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#81319: [PATCH] 31.0.90; new image scale check causes frequent image cache miss In-Reply-To: <8165654f-7f85-4f32-84e6-bbdf6a0a80ad@HIDDEN> References: <m2wlvjlukb.fsf@HIDDEN> <87v7b34u6x.fsf@HIDDEN> <m2h5mmp6dz.fsf@HIDDEN> <86bjctfvr2.fsf@HIDDEN> <m28q7x7bpi.fsf@HIDDEN> <86wlvheah7.fsf@HIDDEN> <m233y570dq.fsf@HIDDEN> <8165654f-7f85-4f32-84e6-bbdf6a0a80ad@HIDDEN> Date: Fri, 03 Jul 2026 08:27:16 +0000 Message-ID: <87bjco4gwr.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 81319 Cc: johan.myreen@HIDDEN, alan@HIDDEN, yantar92@HIDDEN, 81319 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.0 (/) Dmitry Gutov <dmitry@HIDDEN> writes: > On 29/06/2026 19:54, J.D. Smith wrote: >> The image redisplay/scrolling performance. For example, I believe >> Dmitry (now copied) noted it took 14s to scroll the 19 images in that >> example. > > Not me (I'm more in the "text-only buffers" department). > > Maybe it was Trevor, or in any case he might be interested in testing > the patch. Adding him to copy. Definitely was Johan, from what I can tell from my search back in the list on that GPU thread: https://lists.gnu.org/archive/html/emacs-devel/2026-06/msg00345.html Trevor
bug-gnu-emacs@HIDDEN:bug#81319; Package emacs.
Full text available.Received: (at 81319) by debbugs.gnu.org; 2 Jul 2026 21:16:19 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jul 02 17:16:19 2026 Received: from localhost ([127.0.0.1]:44779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1wfOlc-0000mi-Jg for submit <at> debbugs.gnu.org; Thu, 02 Jul 2026 17:16:18 -0400 Received: from mail-yw1-x1134.google.com ([2607:f8b0:4864:20::1134]:45385) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <jdtsmith@HIDDEN>) id 1wfOlX-0000lb-Qc for 81319 <at> debbugs.gnu.org; Thu, 02 Jul 2026 17:16:13 -0400 Received: by mail-yw1-x1134.google.com with SMTP id 00721157ae682-80dd4766206so26526357b3.3 for <81319 <at> debbugs.gnu.org>; Thu, 02 Jul 2026 14:16:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783026966; x=1783631766; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=t2WV83f0h0orVVA2zcOiDFJ4GTM7yn7QuQXy2+0vNvM=; b=Tet8CDrzPbBOF9hx5raGnoqXPsZ/fsNAaixhiGDjqCK60++22v9FjGaBE54ciKLAhE 0Mb7pz2tNFizV2cMmxRLez5ZcMYlIFgzRACxbsm28h5CQ1w/mXKb3aoXvd9YPTVpzmst YnsNIpk4hq7Ci/Mhiu+vBYuJLwx+2QzFSYKzrvIUDcAE72CUBdYZAeL/jf1J4Eg/+Zpo 1s9bDoq8F+6NAoYzRPrCruSnUbO/FKwNDQhTXninkuHIMaCKs9gzYunHbTsgQQRG+RyP NrZ3720wMJ6lnPF7+mnbUCmb4/UBXPX6SLD33QDGHmaHzRmsQ8LNHtBG6VB3mbW0nrXb JIEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783026966; x=1783631766; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=t2WV83f0h0orVVA2zcOiDFJ4GTM7yn7QuQXy2+0vNvM=; b=Txya6Ay7hYQbCD3mcYK5OmS5oFe++GGRRb2oGf4HrjcN9Tn8114DcPm+PrFN/wdm41 FrMgw9+djawQBrjGHlyFe9NtIyEcWYUHcTy5q3ti8NlySDvgm1XkUYN3o5k4Gw2t5Ooh Ctlr5uqeNOybPdEzbGiNbhiDjGoWmw0pg/VH5BRmilMXaMfTQoKhaS8YuxUqwG5jRrtb csLCg+puT/5Y05ej9RIg/GFKaPSA/YXOEvLY8OzWJGyklmBjlYepEuWeUim50PD3DwHg tvNMrk/l34m52fS/tfcICnLlp9F7WPfTGpj/hOtabcZ2Peh4N36xx7zaHedffmlLJ3+2 i7ag== X-Forwarded-Encrypted: i=1; AHgh+RrRWAm7F6sKRACFivqKf6qwYVKKUcWmPS/ymgu1lH/bU3MmmY70LeSSb51uAtZtSCtFwW0DYQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YylLaN5tfhCpx4yDGkssdGCkKhDCSZYzPIPQuwVqTdc+qnsJkjB VeTx0Ijd+dDIkQkqjYNpOWT/09BX1/xE1kHtrpQYGzZb59uiUKKMj+sGmpOMcS/t X-Gm-Gg: AfdE7cl1eOlvzy1/cMBELjQ14nRSehzIDOeEb+RDRIzKGBAUgcjCrDfEGmHmcWNXmgB WjvpiCjG0ClteKmo0jEfP3ZVgsKSLqH4GIZvdJoXPsQukRhg54pYk3rZUCemru9uoZt+6z+I7jZ 6j+bnpuL5cY/83hk6DMeCMGst52wWofLUYHAr3EwFEvDXW03u2qHXzbO1ld3kJT8HPLQIFoO4Ex 6aQG52zUK18r/Z3vcm72xPbxISqIS3qecWKBjOkv/GOHItveVtAzDC1qsHbW1A5gDbj46HH+NUl hWgYbkC/CWr/2L+TbgWiq9jQ2hcPmkGgpR6QNpKlFHRuVkpT7DBla+emv9EZ6JKDPtlczGFJZ5i 9p162h6h1x7FEmIctngW+EQ4zWovP4huhHt41u2hbGsdk0L77WMmjGMJViENrFAkCeTUPLkZXF1 wmO8a974E8URjJ X-Received: by 2002:a05:690c:893:b0:79e:8299:7505 with SMTP id 00721157ae682-812e8ef3eb3mr82412687b3.6.1783026965673; Thu, 02 Jul 2026 14:16:05 -0700 (PDT) Received: from moss ([131.183.130.137]) by smtp.gmail.com with ESMTPSA id 00721157ae682-8144783ccb7sm17400697b3.6.2026.07.02.14.16.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2026 14:16:05 -0700 (PDT) From: "J.D. Smith" <jdtsmith@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#81319: [PATCH] 31.0.90; new image scale check causes frequent image cache miss In-Reply-To: <86h5mhb39z.fsf@HIDDEN> References: <m2wlvjlukb.fsf@HIDDEN> <87v7b34u6x.fsf@HIDDEN> <m2h5mmp6dz.fsf@HIDDEN> <86bjctfvr2.fsf@HIDDEN> <m28q7x7bpi.fsf@HIDDEN> <86wlvheah7.fsf@HIDDEN> <m2zf09l1qj.fsf@HIDDEN> <86h5mhb39z.fsf@HIDDEN> Date: Thu, 02 Jul 2026 17:16:03 -0400 Message-ID: <m2v7axks8c.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Eli Zaretskii writes: >> From: "J.D. Smith" >> Cc: alan@HIDDEN, yantar92@HIDDEN, 81319 <at> debbugs.gnu.org, >> johan.myreen@HIDDEN, dmitry@HIDDEN >> Date: Mon, 29 Jun 2026 12:54:41 -0400 >> >> (Re-sending since [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:1134 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (jdtsmith[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 1.0 FORGED_GMAIL_RCVD 'From' gmail.com does not match 'Received' headers 1.0 FREEMAIL_REPLY From and body contain different freemails X-Debbugs-Envelope-To: 81319 Cc: dmitry@HIDDEN, alan@HIDDEN, yantar92@HIDDEN, johan.myreen@HIDDEN, 81319 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.0 (/) Eli Zaretskii <eliz@HIDDEN> writes: >> From: "J.D. Smith" <jdtsmith@HIDDEN> >> Cc: alan@HIDDEN, yantar92@HIDDEN, 81319 <at> debbugs.gnu.org, >> johan.myreen@HIDDEN, dmitry@HIDDEN >> Date: Mon, 29 Jun 2026 12:54:41 -0400 >> >> (Re-sending since it seems this did not go through) > > It did, actually. I just didn't yet have time looking at this close > enough to have some intelligent response. Sorry. No worries. Finally just showed up in debbugs...
bug-gnu-emacs@HIDDEN:bug#81319; Package emacs.
Full text available.Received: (at 81319) by debbugs.gnu.org; 2 Jul 2026 20:18:39 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jul 02 16:18:38 2026 Received: from localhost ([127.0.0.1]:44330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1wfNrn-0001uV-9g for submit <at> debbugs.gnu.org; Thu, 02 Jul 2026 16:18:37 -0400 Received: from fhigh-b5-smtp.messagingengine.com ([202.12.124.156]:33571) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <dmitry@HIDDEN>) id 1wfNri-0001tT-7j for 81319 <at> debbugs.gnu.org; Thu, 02 Jul 2026 16:18:32 -0400 Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfhigh.stl.internal (Postfix) with ESMTP id 2DE397A0066; Thu, 2 Jul 2026 16:18:24 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-01.internal (MEProxy); Thu, 02 Jul 2026 16:18:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1783023504; x=1783109904; bh=gjoF3w1BNz5xhi5sLO1Tegel3pF3rIaWefvXSQPqAbY=; b= LkOudvgwtik8gpXglkeQlQQfC1wJyJCOeWJRRxYbdu5hjoaENMtjCtl5TRRuRbk6 eCuHSRvmfDcmECEb6aBi0MEnjuVF0BguleEAs+NgRhncnx41owPcsPNvENOcXT+X 23Lo+zD1IT9FNvtT83g1rblpuVXyoTUkKzj2QSR7883btpG8irqup+3JwvPHjts8 UJTIv6Rz0gq9BBP2hzzA1p5F8k4btbLrxifs7qB9NcjY1A6LFHbfso1XnqTTSLUI 3P0WU7h5O0AtrvHGwqJKM4TNTc4vspRpQyom7zoIl5bVz9CWJWX6cRcT+SI1MWFJ hwiT5HGg2w9FGCkfrb/IuA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1783023504; x= 1783109904; bh=gjoF3w1BNz5xhi5sLO1Tegel3pF3rIaWefvXSQPqAbY=; b=o SRYRAmJ70m48e3JeL8Cgx+xqOkqy0XgPpyX9zrCNQ6+6zlnJ+a2EtDrJ/AAqHMlb jNdimRSAb4u1Jr0fFK5itF+D7C8X1+8njCa2jPNe/rn6FNXC5a3e5R+vGExaIP4A qL6qVVGdb27FRa8aGbHag7Ub+YzoGhunK89FHj3wrJmPfTvL37nNBR5mFJzkVNX0 m9su3jcSPLIuLT9qpwB6tMAOflg4gnPQR4dDL3ojqbq2xzkF09F0RYX9tWcROA2/ U14OLjCq2WJrlPI/80vBYzIwAjZq6GQCflpPLpwFEhGeGazqNiF8TTP1O0C8/mYn I2EccnlDy1LaDMXzTSIaQ== X-ME-Sender: <xms:j8dGanYndoT9ncWPFD4efe1jCSkuQFzWfsqt5yZT93TX20qrRaExfw> <xme:j8dGaorVWEHhYubbIdsr1JBoFBdFrTNuVayVnSyl1EwdQ1k6pIuhbOKGUR4XTcgYD b8BiDGYqTgAbbRynzJpeuriqv_-Xtr6fIjqdwdtqOJpMcEj5xDXSzX3> X-ME-Received: <xmr:j8dGasPDKBXWp4GyvBCII8eZsvt5l4by6ZtpHAJTa4n3RlKlt5Rnutz-yKy1UvtXuIXVcw> X-ME-Proxy-Cause: dmFkZTEQQgNxhxQDgAfHxfB5SX7lZIHrA0cEF/FvS83twWZjhJpkCJuYCrbnKgbJUFHPJM bPHsOhdRFIZ3jyuPAFny8EvmRDWRiKiDNUbxvsgmUwR93tz7XTXuFgk9xMB8LymO6pMsCh w5QwCPB6RQQ4QmLmn/zgZddjHU9MgnR4suHsy6oaho9TPxRFY/QiFoF4nHroEF7sM9i5vw bYfUTfiEFzKdwl7R5D8ecV0CbHf7iJSyMrdcUZ7yLHywVRPpYS+kJGdfpOnOJsoLdJZ8I5 Q/R4sUszHF8bTwF0Ptn1HSycQiZaZiW8VcCZbarOsDAyPuHZnfHC20ULD2P/1Wmu9Q3Wdy xJZbHg7KLR08kYDBXAuDb2cajyZX72THhPdSUPr9hf/Q3xslVAJ1AvnYuUtV1FmPdhAWNp cRyIwWNKGTjSB6/ir0kS98YkcpDSuzDsueoBhiZD4xNtqyNAe9hfCnJsb/33/Pqli7AUVb EmSuDXISspNyQWvQDB9P3h10Y6/hLqhCqfqiQmXkt274RDblPyHuuwU7/ENR9wU5vUAZ5I EyuX3y3ZyoK9h4nf0MBqM2Uvkk9eJfCg4Xk3HnXsUFPVnhESDGua5AJTrjhHghWwmB5v9G UO6l9u6SAHm3D0SzwwfeDoKAium91oxhx3ZsvU7P4N7LcNKO3XZG9t9eTJbw X-ME-Proxy: <xmx:j8dGajr6r8KWIWcqmXcryvMeFPK-aXyXkkopDHOaGZNPGprUIPO3nw> <xmx:j8dGahd76kDB6BnWI2iAL_fEiDDp11rPWrYFFXcWgAsaLzP9EHwG2w> <xmx:j8dGapRy7gtLT78K3sBLCJe9ARldmA3uFHtyy64xPINDYz8VZxbKXg> <xmx:j8dGaqYcwrs0aMqYCm8So6wUO8NoQiLffkC18bJW2qQSwykw7cPGRw> <xmx:kMdGanJTUoJ05odt_KI6vt_SkUKRL6UgL9qsUZBLbAFmgKUfgrwd65yr> Feedback-ID: i07de48aa:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 2 Jul 2026 16:18:20 -0400 (EDT) Message-ID: <8165654f-7f85-4f32-84e6-bbdf6a0a80ad@HIDDEN> Date: Thu, 2 Jul 2026 23:18:17 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#81319: [PATCH] 31.0.90; new image scale check causes frequent image cache miss To: "J.D. Smith" <jdtsmith@HIDDEN>, Eli Zaretskii <eliz@HIDDEN> References: <m2wlvjlukb.fsf@HIDDEN> <87v7b34u6x.fsf@HIDDEN> <m2h5mmp6dz.fsf@HIDDEN> <86bjctfvr2.fsf@HIDDEN> <m28q7x7bpi.fsf@HIDDEN> <86wlvheah7.fsf@HIDDEN> <m233y570dq.fsf@HIDDEN> Content-Language: en-US From: Dmitry Gutov <dmitry@HIDDEN> In-Reply-To: <m233y570dq.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 81319 Cc: johan.myreen@HIDDEN, alan@HIDDEN, Trevor Arjeski <tmarjeski@HIDDEN>, yantar92@HIDDEN, 81319 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) On 29/06/2026 19:54, J.D. Smith wrote: > The image redisplay/scrolling performance. For example, I believe > Dmitry (now copied) noted it took 14s to scroll the 19 images in that > example. Not me (I'm more in the "text-only buffers" department). Maybe it was Trevor, or in any case he might be interested in testing the patch. Adding him to copy.
bug-gnu-emacs@HIDDEN:bug#81319; Package emacs.
Full text available.Received: (at 81319) by debbugs.gnu.org; 2 Jul 2026 19:27:55 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jul 02 15:27:54 2026 Received: from localhost ([127.0.0.1]:44104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1wfN4h-0004Np-Mi for submit <at> debbugs.gnu.org; Thu, 02 Jul 2026 15:27:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46818) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1wfN4c-0004Ml-CN for 81319 <at> debbugs.gnu.org; Thu, 02 Jul 2026 15:27:48 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1wfN4W-0002uN-9C; Thu, 02 Jul 2026 15:27:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=RMksQLz8plCxGmj0WLZfvSGmgNpY2GMjLQ8+lE+uBLQ=; b=A4ckWgvLIBnY ohf0arTU7sIYEEzppTWFqruJsk0k0+bXqz63j5sbgIYjGf3ccuRnG5isoUR7v+z9eMpGDT7rDZjYx TUR5m/5To2FDTXjxpCrvBp0tO1TYdwZ4nXklc8ozir1beazbfK5JG9KvMer4zLDbcAoSeR9d3LzzF Nu91IvnkPejKFo/TzQJwO+tjULU3gWGDvbPEV/ex0KSvb4qE9nqNrZDdO11oMeNwPmwIZjX1t64tK cUgqBlT5GUPQT2fG6dWCKtQYIVZbL1HxBX8K7tEgzcDEADd/bRwTQFJuG5BTadkMhain0tMuyIaY5 O1IAGdBtpgFLvvL0QP1bfQ==; Date: Thu, 02 Jul 2026 22:27:36 +0300 Message-Id: <86h5mhb39z.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: "J.D. Smith" <jdtsmith@HIDDEN> In-Reply-To: <m2zf09l1qj.fsf@HIDDEN> (jdtsmith@HIDDEN) Subject: Re: bug#81319: [PATCH] 31.0.90; new image scale check causes frequent image cache miss References: <m2wlvjlukb.fsf@HIDDEN> <87v7b34u6x.fsf@HIDDEN> <m2h5mmp6dz.fsf@HIDDEN> <86bjctfvr2.fsf@HIDDEN> <m28q7x7bpi.fsf@HIDDEN> <86wlvheah7.fsf@HIDDEN> <m2zf09l1qj.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 81319 Cc: johan.myreen@HIDDEN, dmitry@HIDDEN, alan@HIDDEN, yantar92@HIDDEN, 81319 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: "J.D. Smith" <jdtsmith@HIDDEN> > Cc: alan@HIDDEN, yantar92@HIDDEN, 81319 <at> debbugs.gnu.org, > johan.myreen@HIDDEN, dmitry@HIDDEN > Date: Mon, 29 Jun 2026 12:54:41 -0400 > > (Re-sending since it seems this did not go through) It did, actually. I just didn't yet have time looking at this close enough to have some intelligent response. Sorry.
bug-gnu-emacs@HIDDEN:bug#81319; Package emacs.
Full text available.Received: (at 81319) by debbugs.gnu.org; 29 Jun 2026 13:35:09 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jun 29 09:35:09 2026 Received: from localhost ([127.0.0.1]:36867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1weC8j-0005DP-8o for submit <at> debbugs.gnu.org; Mon, 29 Jun 2026 09:35:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36762) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1weC8g-0005Ch-6O for 81319 <at> debbugs.gnu.org; Mon, 29 Jun 2026 09:35:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1weC8V-00026m-KH; Mon, 29 Jun 2026 09:34:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=oz11bX/7Xox2fulcglyYZPIa3POCn+H+AynTrQKdOys=; b=HjgWhV8yck5G UYhteAytG7IJQ3zq4IW9dOr1aRyfjY6Hc+i4MZClUz/RLBUcjo6RqhwrikNErK0KM19L7OseSr3Wi +ZmOzU//l+ffv10FKO+WG7DBOxD7BlCO80ylF0wagIj10RUZBXn2H80Ao3IZmOwoW8I4UA7Bd0ucn ZvNUrvuzV1wyH0GfPE/iJh7W2rcRiXNeBwfI+HXIXb76iz7sZ7p3/1FEl3TMfdGFWaY0N+EMNjQo0 drfdKUkPGtnSAi7ODF9oCG6f7EjfLME/qTSnIPZ5lZx2zJIV3MxTnPLREgex1isJMxuUa/tsxco/P XZe2Kx01GEHK96GEVg9D8w==; Date: Mon, 29 Jun 2026 16:34:44 +0300 Message-Id: <86wlvheah7.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: "J.D. Smith" <jdtsmith@HIDDEN> In-Reply-To: <m28q7x7bpi.fsf@HIDDEN> (jdtsmith@HIDDEN) Subject: Re: bug#81319: [PATCH] 31.0.90; new image scale check causes frequent image cache miss References: <m2wlvjlukb.fsf@HIDDEN> <87v7b34u6x.fsf@HIDDEN> <m2h5mmp6dz.fsf@HIDDEN> <86bjctfvr2.fsf@HIDDEN> <m28q7x7bpi.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 81319 Cc: alan@HIDDEN, yantar92@HIDDEN, 81319 <at> debbugs.gnu.org, johan.myreen@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: "J.D. Smith" <jdtsmith@HIDDEN> > Cc: alan@HIDDEN, 81319 <at> debbugs.gnu.org, johan.myreen@HIDDEN, > yantar92@HIDDEN > Date: Mon, 29 Jun 2026 08:50:01 -0400 > > Eli Zaretskii <eliz@HIDDEN> writes: > > >> Cc: 81319 <at> debbugs.gnu.org > >> From: "J.D. Smith" <jdtsmith@HIDDEN> > >> Date: Sun, 28 Jun 2026 19:55:20 -0400 > >> > >> I believe this fix should go on the release branch, since it represents > >> a significant performance regression for certain images. Do you agree? > > > > How serious is the regression (numbers, please!), > > Depends on the system and image details of course, but here loading and > pre-treating reasonable sized images outside of the cache is in the > 10-30ms range, whereas re-displaying from the image cache is sub-ms. > With a few images, this can add up fast and make scrolling quite > painful. Not to mention battery life concerns from needlessly reloading > the same cached image thousands of times. > > > and what images are affected? > > Any image with type tagged as `imagemagick', which I believe by default > is true for scaled images. > > As well, on any system without HAVE_NATIVE_TRANFORMS[1] defined, > `image_set_transform' is never called, so the same needless cache miss > will occur. I'm not sure I follow: are only ImageMagick images affected, and then only on systems which have HAVE_NATIVE_TRANFORMS defined? Or are system which have HAVE_NATIVE_TRANFORMS defined affected with any image type? Or both? > I've copied in a couple folks from the "scrolling images in Linux is > slow" thread; could you please see if the proposed patch improves > things? Improves what? I see no recipe for reproducing or measuring the performance. If this affects many image types on basically every system we support, I think we should have some recipe for measuring the performance degradation and the effect of the proposed patch, so we could make an informed decision. > > Also, is this specific to macOS? if not, what do you mean > > by "native images"? > > No. On the mac port, the native "IMAGE/IO" facility is used as a > "work-alike" for imagemagick; when that direct type is encountered, or > when libpng etc. are not compiled in. So here by default it affects > basically /all/ images. Then please let's not use "native images", because it's confusing: those exist only on Windows and macOS, but not on GNU/Linux AFAIU.
bug-gnu-emacs@HIDDEN:bug#81319; Package emacs.
Full text available.
Received: (at 81319) by debbugs.gnu.org; 29 Jun 2026 12:50:12 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jun 29 08:50:12 2026
Received: from localhost ([127.0.0.1]:36399 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1weBRD-00022W-AM
for submit <at> debbugs.gnu.org; Mon, 29 Jun 2026 08:50:11 -0400
Received: from mail-oa1-x32.google.com ([2001:4860:4864:20::32]:51419)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <jdtsmith@HIDDEN>)
id 1weBRB-00020r-6j
for 81319 <at> debbugs.gnu.org; Mon, 29 Jun 2026 08:50:09 -0400
Received: by mail-oa1-x32.google.com with SMTP id
586e51a60fabf-447efaebabeso754742fac.2
for <81319 <at> debbugs.gnu.org>; Mon, 29 Jun 2026 05:50:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20251104; t=1782737403; x=1783342203; darn=debbugs.gnu.org;
h=mime-version:user-agent:message-id:date:references:in-reply-to
:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=jy9l9QVd1fGDT8s6Zv26Yxo3BRGnmoUxDtMIJJksH6Y=;
b=kPX9BXCVRdWZqObSM+CkfqUHVyWtkFmleBpRD0WxkfDTDrI/lMC9dGZtFSiJRCJBYe
BtafrGtNSYOIpJkqc+1inKDn+XY9UhzAvDz3TpePGMQL41l6gTPMK3LYZJLUXE53OVMy
rTeyws0GX/pBcovIv/Lt7ebRIcsWCVjjZXfagQDsltXomloSfox4yBKhMYCSyZj1KcCi
m8zsJaEB3RKcyv4l+K+FSWL80Qkd1hC3vyf4AsYVKPSBfaSVhLltfqOmM08+Ssnblwqg
aBJMkO9UyyQ3XoqoFj7e/wGbFWLIUW3IpZTKLuInKXrRpYcbkcwXdujV4WhLsDq9PLCS
U74Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20251104; t=1782737403; x=1783342203;
h=mime-version:user-agent:message-id:date:references:in-reply-to
:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject
:date:message-id:reply-to;
bh=jy9l9QVd1fGDT8s6Zv26Yxo3BRGnmoUxDtMIJJksH6Y=;
b=YqO/ixO+JTTCz5SbGYlmueuxG4pSkV5H9SY1B37Q+oRYbXsm5d6lyjeLGzSnH0pqqe
Ro1jneEDX6DGcJikHoNnlvsHrt7nNGmYcbYNlQi1hrZu0bvegfzSOrHwdOjHcwMrpu4Y
mQIqwJeW75IBn8UEvqDj/WIJndm+kb/naGR/LwgpJy/tXsVMIS0eLU3njg8COy7bi9+U
qLl9vD8BmsKuA/I2jaOpKEzMxmAkQ/kCzfIPdkZsmZaI59aCJ/ozyoNPGdamVnqSP+ac
PTgrMZ5LoOnX4WTRCoqnrqPdStbfbTGm1R02FM+A2R2AohUsha3vpibHosJevWECwfRB
sUoA==
X-Forwarded-Encrypted: i=1;
AHgh+RrjjJ+agUPPz2VzyK0vllz8TsdvOXQRcX3YtvS0jP3jKAHkAb3e7mAsr4NCkJixfBt9+kzZ6A==@debbugs.gnu.org
X-Gm-Message-State: AOJu0Yw3O7UfZ3oik8p8vNUc8kuMgn/z4rdKLzFkWk6ZFUUIvxtrIwJL
Ekl8rYSgIZG8TD6ikF+rRfQE/MBlmuDTFm57Soc/943VfA74oEJTpsz1
X-Gm-Gg: AfdE7cktd5JtVNvHmSRNW9RnKXeGgnA0LEwMER0/3lRockaNHh0s8ysC38mp14fZwzV
Lw2inNiMtEBI+dVHqjGhhiJD4z9oOAPGc+7E3+eEMMaUIGDNzMpbtwilhigxLaqkeLkK5FfQ75e
qmhmNzLd//w18VfL8spECSXiBbpmt6DHxacTe2PDbMrWMAZZ/Dm7zWgKHTwTc4oyLbX4wuZAFuz
kIUXX2cBx40dOwJWR0vD9JzvQzE6TI7ErglVD98iiMPI4YsckFecMCuUeKgcMmz5ZdxHu0uUxmd
jq4Y8e2F3I7/8+F9J2+5ku31+qAD3wlBWrwP0jvK0cD/9079bytY5mShSu9Zk0MswoSy6sSilIf
YXPwEAvgKdv2laBuEQw31Fy/qDpO6JJCfWS6nU5Ob0zN0rOzzeuGuzEhFVBh8ihmRD+phgJmCT2
fZw+62SCAATVlbMPRA5luUPh8JhA1yXomera50L/Gw9C8=
X-Received: by 2002:a05:6870:3d85:b0:447:8919:f7cb with SMTP id
586e51a60fabf-44811c8a8d3mr12503599fac.16.1782737402639;
Mon, 29 Jun 2026 05:50:02 -0700 (PDT)
Received: from moss (cm-24-53-187-185.buckeyecom.net. [24.53.187.185])
by smtp.gmail.com with ESMTPSA id
586e51a60fabf-4472f042517sm19444679fac.13.2026.06.29.05.50.01
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 29 Jun 2026 05:50:02 -0700 (PDT)
From: "J.D. Smith" <jdtsmith@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#81319: [PATCH] 31.0.90; new image scale check causes
frequent image cache miss
In-Reply-To: <86bjctfvr2.fsf@HIDDEN>
References: <m2wlvjlukb.fsf@HIDDEN> <87v7b34u6x.fsf@HIDDEN>
<m2h5mmp6dz.fsf@HIDDEN> <86bjctfvr2.fsf@HIDDEN>
Date: Mon, 29 Jun 2026 08:50:01 -0400
Message-ID: <m28q7x7bpi.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: 81319
Cc: alan@HIDDEN, yantar92@HIDDEN, 81319 <at> debbugs.gnu.org,
johan.myreen@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.0 (/)
Eli Zaretskii <eliz@HIDDEN> writes:
>> Cc: 81319 <at> debbugs.gnu.org
>> From: "J.D. Smith" <jdtsmith@HIDDEN>
>> Date: Sun, 28 Jun 2026 19:55:20 -0400
>>
>> I believe this fix should go on the release branch, since it represents
>> a significant performance regression for certain images. Do you agree?
>
> How serious is the regression (numbers, please!),
Depends on the system and image details of course, but here loading and
pre-treating reasonable sized images outside of the cache is in the
10-30ms range, whereas re-displaying from the image cache is sub-ms.
With a few images, this can add up fast and make scrolling quite
painful. Not to mention battery life concerns from needlessly reloading
the same cached image thousands of times.
> and what images are affected?
Any image with type tagged as `imagemagick', which I believe by default
is true for scaled images.
As well, on any system without HAVE_NATIVE_TRANFORMS[1] defined,
`image_set_transform' is never called, so the same needless cache miss
will occur.
I've copied in a couple folks from the "scrolling images in Linux is
slow" thread; could you please see if the proposed patch improves
things?
> Also, is this specific to macOS? if not, what do you mean
> by "native images"?
No. On the mac port, the native "IMAGE/IO" facility is used as a
"work-alike" for imagemagick; when that direct type is encountered, or
when libpng etc. are not compiled in. So here by default it affects
basically /all/ images.
[1] window system, but one /without/ (CAIRO || XRENDER || MACGUI
|| HAVE_NS || NTGUI || HAIKU || ANDROID).
bug-gnu-emacs@HIDDEN:bug#81319; Package emacs.
Full text available.Received: (at 81319) by debbugs.gnu.org; 29 Jun 2026 11:10:04 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jun 29 07:10:04 2026 Received: from localhost ([127.0.0.1]:35800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1we9sK-0007lW-8x for submit <at> debbugs.gnu.org; Mon, 29 Jun 2026 07:10:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48134) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1we9sI-0007kt-C6 for 81319 <at> debbugs.gnu.org; Mon, 29 Jun 2026 07:10:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1we9sC-0004cn-H9; Mon, 29 Jun 2026 07:09:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=KSXnIDR1bW6ueRsf8mZZPrSzobvJJa04UbL+CTW+9Qo=; b=SQAdh0r7cNLE kmaZFnk3YKrTNjr+T8R0TY1dRj4ZeB7va1YlQqC/Q1Rf0uS+JxwhEA/o51MwNkBB7IcmXxQWo0Wby uQ81ENOsbIgHxnU5XmG9qjJvZn7p4DO3u/OKK0nJGoOdFRGxYGkH99YI3w7p8Nsc+8JBhzKIwuzyM TSuwZrOI4VeDTyLYqVjHHRE1kUmWhEh0lJhfPL6M2UlCr6aJDo36OT1e72Y5ewC+zkOdrd0FsfsLi 9NJihc/HM2iAbvOCor9tsCqB9nrhKXtNHdePCmLt0uAtmLOlupNj2kZPQ3xhHe/TX+wKOIhjhGeRz mjOhC+I1dohBfewnW6FVtw==; Date: Mon, 29 Jun 2026 14:09:53 +0300 Message-Id: <86bjctfvr2.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: "J.D. Smith" <jdtsmith@HIDDEN> In-Reply-To: <m2h5mmp6dz.fsf@HIDDEN> (jdtsmith@HIDDEN) Subject: Re: bug#81319: [PATCH] 31.0.90; new image scale check causes frequent image cache miss References: <m2wlvjlukb.fsf@HIDDEN> <87v7b34u6x.fsf@HIDDEN> <m2h5mmp6dz.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 81319 Cc: alan@HIDDEN, 81319 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Cc: 81319 <at> debbugs.gnu.org > From: "J.D. Smith" <jdtsmith@HIDDEN> > Date: Sun, 28 Jun 2026 19:55:20 -0400 > > I believe this fix should go on the release branch, since it represents > a significant performance regression for certain images. Do you agree? How serious is the regression (numbers, please!), and what images are affected? Also, is this specific to macOS? if not, what do you mean by "native images"?
bug-gnu-emacs@HIDDEN:bug#81319; Package emacs.
Full text available.Received: (at 81319) by debbugs.gnu.org; 28 Jun 2026 23:55:33 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jun 28 19:55:33 2026 Received: from localhost ([127.0.0.1]:60640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1wdzLY-0007hh-5p for submit <at> debbugs.gnu.org; Sun, 28 Jun 2026 19:55:33 -0400 Received: from mail-oo1-xc2d.google.com ([2607:f8b0:4864:20::c2d]:54489) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <jdtsmith@HIDDEN>) id 1wdzLU-0007ff-3z for 81319 <at> debbugs.gnu.org; Sun, 28 Jun 2026 19:55:29 -0400 Received: by mail-oo1-xc2d.google.com with SMTP id 006d021491bc7-69de16f5e80so1370806eaf.0 for <81319 <at> debbugs.gnu.org>; Sun, 28 Jun 2026 16:55:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782690922; x=1783295722; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=W2TOI8JGxizWDG6N++WqzFrisSBnzUprw+d/FU/iaz4=; b=IyvKWLIF1cbM/naJ+OSxx6ASxbgGd7Z53sL82+n17p4UV6LfPbB24lRWJozT22lbRr bZVf5iTLcj/IBmcJD1WOLR0onwDvqnQKhq0OaZolLXbOnXRbBum3Sf0rwIrtbBCO9pJR C0KViDgK0Q0gaXTPQG91/4avwuAedIbzZEP0ovH8ylQN5iipA431NXFGFRldu2Ht9iho iRNJI7TcYK6YZ2BdSoVPfQ9LNpnKOSHxpFz/2pjNW2o7XicXOQqOt7CMekTRQUeYxZk3 WuYqceVbFz5tZG3+MlouRV4gqzdnop+6d5xTtz5jK03kUKbq/Ux88cJiz+RqUnaY/d6t eQ+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782690922; x=1783295722; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=W2TOI8JGxizWDG6N++WqzFrisSBnzUprw+d/FU/iaz4=; b=swU1Kf6xmMfJTUR0k40lpaujUY8Isek2OQ/GrAtJsPcuJJVWCo4hRGqSZZxWObx7aD nBQpImMBBZWr/Ue3nmh144p8BBEK4GRwfyt5a4DbPZPodEfESBm4Lvjtj/AIyVlnIdRp Hq3DtFnMhNZfiC+grC4yLZkbp6ONh1ndzjOH9qkkJv4QmLp4bgTSTYTxi1Jimu0Kc+fY qp5i9aZymad8s/6gGFJ+KCW1XyizypfbuV2Ozswgs+7dq+H3bX2k3C6P71WF3nbbG6Hy jiQMYQRHKg3j1mZw7dwsVyOY/LimB8xJvtAIHEuFR9PIoX9yl8DDNvi1sZ2vAMWbFtoP M28A== X-Gm-Message-State: AOJu0YyMo93otcrlalPdFGDsOKtrpPRLGPfXJVzJj4dKxOLna1JipEzB HB62fvuRgvSCHH2CgssndcQF0oXgGE8XkE1bVp1QPBzpftcod1qp9e1Kz3x1tw== X-Gm-Gg: AfdE7cnDvydAOMNZOSdG5DGSXE+yAlJHTz5yKyWYo+ywCaPqsHALG3R/Tuqo5AXulvO ya4HRgIdm5sSdEUNmFy61yWCKMU6u5ANmlmlKbGCwhmSG1AEyE4h4vEWJHFTvtdE4c1AWUTW/GJ zUq8vlKWsTy/LJWSVAPjDfOGrOwphao+a6veStMGFV1zWKqh8uDsv0bvgr8l7Lod5DUmFiVMbV0 0ebVUblxcCDvxT8QABhdwk6GscSutgd4e+2d3JpvmhYvgOGQZaabCpOrxJhRpxkJakPLmLcHH6P kBcLeRiJwL5PNDlQHlnGX6sNE5obtaezvxo7qsjUq3prxXD2YJROmWfzIX+uCIefgEWmcGDyoAp da90UX27WnkCvW6k9z+CXbvm77tWBwwmxqcaElC+3o6ua9fr5CnWrgBpNmSkyGaF1FeB9Bcn98o ZFigBuFSiRw2WBXIAUtZE40IUUdKPnggMmTOwnksSsP28= X-Received: by 2002:a05:6820:1691:b0:6a1:4592:edf9 with SMTP id 006d021491bc7-6a14592f74cmr7311838eaf.0.1782690922000; Sun, 28 Jun 2026 16:55:22 -0700 (PDT) Received: from moss (cm-24-53-187-185.buckeyecom.net. [24.53.187.185]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-4487291914asm3732078fac.7.2026.06.28.16.55.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jun 2026 16:55:21 -0700 (PDT) From: "J.D. Smith" <jdtsmith@HIDDEN> To: Alan Third <alan@HIDDEN> Subject: Re: bug#81319: [PATCH] 31.0.90; new image scale check causes frequent image cache miss In-Reply-To: <87v7b34u6x.fsf@HIDDEN> References: <m2wlvjlukb.fsf@HIDDEN> <87v7b34u6x.fsf@HIDDEN> Date: Sun, 28 Jun 2026 19:55:20 -0400 Message-ID: <m2h5mmp6dz.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 81319 Cc: 81319 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.0 (/) Alan Third <alan@HIDDEN> writes: > "J.D. Smith" <jdtsmith@HIDDEN> writes: >> Since updating my local build to the v31 release branch, I have noticed >> image display slowdowns for native image types. I've tracked it down to >> the new "scale" check in `search_image_cache' from bug#74725 > > Seems fair to me. > > The only real alternative approach I can think of would be something > like presetting img->scale in lookup_image to, say, -1, then skip all > the scale stuff in search_image_cache for any img with a negative scale > value. > > I don't think it's obviously better, though. So your call. > > (IMHO this whole auto-scale thing is a misfeature and should never have > been allowed to affect the C code, but that ship sailed many moons ago.) Thanks, Alan. I hadn't been aware of `image-scaling-factor', and I agree with you, that kind of functionality would be better handled by explicitly altering the :scale during image load in lisp, rather than at the C level. Most image-heavy modes seem to set :scale on their own anyway. In terms of the fix, I found it hard to track down where the img->scale field was set. What do you think would be most maintainable? Perhaps initializing that field to -1 as you suggest and only comparing if it was actually set would be best. I believe this fix should go on the release branch, since it represents a significant performance regression for certain images. Do you agree? JD
bug-gnu-emacs@HIDDEN:bug#81319; Package emacs.
Full text available.
Received: (at 81319) by debbugs.gnu.org; 28 Jun 2026 12:50:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jun 28 08:50:18 2026
Received: from localhost ([127.0.0.1]:58223 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1wdoxh-0000v4-Vm
for submit <at> debbugs.gnu.org; Sun, 28 Jun 2026 08:50:16 -0400
Received: from dane.soverin.net ([185.233.34.24]:56947)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <alan@HIDDEN>) id 1wdoxa-0000tY-Ln
for 81319 <at> debbugs.gnu.org; Sun, 28 Jun 2026 08:50:10 -0400
Received: from smtp.soverin.net (unknown [10.10.4.99])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
(No client certificate requested)
by dane.soverin.net (Postfix) with ESMTPS id 4gp8Pz01bZzX4;
Sun, 28 Jun 2026 12:49:59 +0000 (UTC)
Received: from smtp.soverin.net (smtp.soverin.net [10.10.4.99]) by soverin.net
(Postfix) with ESMTPSA id 4gp8Py3HJRz4s2;
Sun, 28 Jun 2026 12:49:58 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin;
t=1782650998; bh=Dv3EexW56yV8lNW1G/WvncvFQQOoak6vsdbVNQCotcw=;
h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
b=ZAFRlH5Ka3PJNWD2p9PSQgKb+FTqjf44RYylLcezdnXHZt59iYg+sMZsjDhSPJQVf
eZLGL81HaqLgjuKxt2dG7CxfM/XRW8NnxPlwsHQKaXimQwKByYQwHK0zoM3Tb0z2oS
gnCTMCMHI3WPcZuQxPqDdlGrBefqBfkEOXVulhNBOwN4ZrzHQMBqSaUE9k18mEnPvu
FSBCdmMWvaqKVq36Cr9cHBZx6+dPysPCHXrIj2MvkZLu3bxocRWxryceFJ5GxYNqjS
Izx5G7qHNleemPrpxPZVL9jlZH2oTY7ar+j2Rr8hc6WoyZ8GT6oULzYU+DL4E+ssKh
2iDZjMvI+UoHw==
X-CM-Envelope: MS4xfNYN33PyVFEi1FPbyeAi645zpETwLRaZKzIulMc/9UchOeEM6ZS0FmX6/j3/OTYnevH0DuInROA0Bl5JiILLpwAovbIT3gGE0vMxeIslWsI+VsXKR1Ov
0lvP9mSiKWOcuVE6aDKMmJqCmf/dQaXN/CJbrzUfLWYyCLU+0gw7E2rO9YquZg4ZTTc7uN8QDrXtkCriMMy7kpGNk/QJ2zom3s41qLaNuR0ZqkCrpDtTmYwW
vWqAl+PJxgrtO3u+Jkr/Ug==
X-Soverin-Id: 019f0e47-8cf0-762d-be86-da2e58aa6ad2
Received: from localhost (namib [local])
by namib (OpenSMTPD) with ESMTPA id f6b4512d;
Sun, 28 Jun 2026 12:49:57 +0000 (UTC)
Date: Sun, 28 Jun 2026 13:49:57 +0100
From: Alan Third <alan@HIDDEN>
To: "J.D. Smith" <jdtsmith@HIDDEN>
Subject: Re: bug#81319: [PATCH] 31.0.90; new image scale check causes
frequent image cache miss
Message-ID: <87v7b34u6x.fsf@HIDDEN>
Mail-Followup-To: Alan Third <alan@HIDDEN>,
"J.D. Smith" <jdtsmith@HIDDEN>, 81319 <at> debbugs.gnu.org
References: <m2wlvjlukb.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m2wlvjlukb.fsf@HIDDEN>
X-Draft-From: ("nndoc+ephemeral:bug#81319" 2)
X-Spampanel-Class: ham
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 81319
Cc: 81319 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
"J.D. Smith" <jdtsmith@HIDDEN> writes:
> Since updating my local build to the v31 release branch, I have noticed
> image display slowdowns for native image types. I've tracked it down to
> the new "scale" check in `search_image_cache' from bug#74725, which
> corrected handling of `image-scaling-factor'. A new check in
> `search_image_cache' compares the scales computed from the image spec
> and stored in the image:
>
> && scale == img->scale
>
> and the image cache misses if they do not agree.
>
> The function `image_compute_scale' is the only place `img->scale' gets
> set, and only if the `img' pointer passed to it as the final argument is
> valid. This occurs exclusively from the function `compute_image_size':
>
> static void
> compute_image_size (struct frame *f, .., struct image *img, ...)
> {
> double scale = image_compute_scale(f, img->spec, img);
>
> For non-SVG images, `compute_image_size' is called only from
> `image_set_transform'. But note, this function has a possible early
> bailout:
>
> # if (defined HAVE_IMAGEMAGICK \
> && !defined DONT_CREATE_TRANSFORMED_IMAGEMAGICK_IMAGE)
> /* ImageMagick images already have the correct transform. */
> if (EQ (image_spec_value (img->spec, QCtype, NULL), Qimagemagick))
> return;
> # endif
>
> I.e. for `imagemagick' image types, `compute_image_scale(..., img)'
> /never/ gets called, `img->scale' never gets set, and image cache lookup
> always fails. Hence images are reloaded on every redisplay (e.g. during
> scrolling).
>
> Moreover, only with HAVE_NATIVE_TRANFORMS defined is
> `image_set_transforms' called at all:
>
> #ifdef HAVE_NATIVE_TRANSFORMS
> image_set_transform (f, img);
> #endif
>
> Otherwise, I suspect all image cache lookups would miss. Conjecture:
> this may relate to the slow image scrolling performance recently
> reported on emacs-devel for Linux builds.
>
> I want to see what Alan thinks about this, but perhaps a simple fix
> would be to pre-compute `img->scale' for all images during load,
> independent of their type (attached).
Seems fair to me.
The only real alternative approach I can think of would be something
like presetting img->scale in lookup_image to, say, -1, then skip all
the scale stuff in search_image_cache for any img with a negative scale
value.
I don't think it's obviously better, though. So your call.
(IMHO this whole auto-scale thing is a misfeature and should never have
been allowed to affect the C code, but that ship sailed many moons ago.)
--
Alan Third
--
Alan Third
bug-gnu-emacs@HIDDEN:bug#81319; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 27 Jun 2026 18:14:50 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jun 27 14:14:49 2026
Received: from localhost ([127.0.0.1]:53491 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1wdXYF-0002zD-85
for submit <at> debbugs.gnu.org; Sat, 27 Jun 2026 14:14:49 -0400
Received: from lists1p.gnu.org ([2001:470:142::17]:42832)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <jdtsmith@HIDDEN>)
id 1wdXYA-0002yL-6E
for submit <at> debbugs.gnu.org; Sat, 27 Jun 2026 14:14:45 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <jdtsmith@HIDDEN>)
id 1wdXY3-0000ey-Ba
for bug-gnu-emacs@HIDDEN; Sat, 27 Jun 2026 14:14:35 -0400
Received: from mail-oa1-x29.google.com ([2001:4860:4864:20::29])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <jdtsmith@HIDDEN>)
id 1wdXY0-0007r0-TX
for bug-gnu-emacs@HIDDEN; Sat, 27 Jun 2026 14:14:35 -0400
Received: by mail-oa1-x29.google.com with SMTP id
586e51a60fabf-44841e9f651so1119336fac.0
for <bug-gnu-emacs@HIDDEN>; Sat, 27 Jun 2026 11:14:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20251104; t=1782584071; x=1783188871; darn=gnu.org;
h=mime-version:message-id:date:subject:to:from:from:to:cc:subject
:date:message-id:reply-to;
bh=llfPE89kXBCdKE+ypbzffTM3mT8eiHCUFYcppSVeOcc=;
b=sTLYkPmHb23JjOCYyMnfSIsu3mu0UvpW7NU5WpzJWJNCVWCiPDx8y5Az/2wPNzTyQH
iQM9BKK4PdL2L6c4ytq37ZG1IxXcuZ77W7L9+MyrfPzHmGKdHc07mlNL7ZibVJdlCaxN
6tqvGtsq0vblcKi/kSv9bQ4XhqTCAqqecu2Ebn9w8KKau3IRoDJGbXwRCyN3GWmGlhJW
3mblrOonpMCBjl99NRYyynKdFDjQLShK6STtowK2l/7bDg6idSFvLoow3nDX32FAJfPs
dkU8aM1uiNpuTYrPqQOR9BL+DWGXcvHv2h3Fvwg+fe/O0rj+sHKzseAuB1kgZrKDs5Jd
+0lA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20251104; t=1782584071; x=1783188871;
h=mime-version:message-id:date:subject:to:from:x-gm-gg
:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=llfPE89kXBCdKE+ypbzffTM3mT8eiHCUFYcppSVeOcc=;
b=PlNpXgGIqU1OQnxSf35YqoM6EUk8h1gUG1z1QtX3f5U9HNhniHtknpMNjKKxBuVlko
WUX8PY4sPICtp5EhBTHR97zm5JX6AlzyAmhR+txgvlfrtDQq1mL7Xa0cKuvGE0nU3rWK
m0yMW96dOVDj4wB2zFUNKiaGOa8ro1HF7j6d42fGow98pC08Vu5MD514YmLOcu7LihFi
6/ymXQGoG4WpGVZotZ/KpRbTbv9Uha7QCtrwLpopecfaW+Xdb4BINTu0O7K6fHWqL70d
blJIBURaKwLQeRNmmpBraHGy17q0OkHvzafYVjVOOqonvYtoRkmRHT7O0XDSdvLYp/tM
znxA==
X-Gm-Message-State: AOJu0Yx7nuzktKmwRvR24EWmRJc1GukVnGtK0algB3a+vIjOtlh95HEE
AY8zuej93WR7tAZR36+BwnWxfQXlUZLso8OXk4Nsa13Zbr3XGtZwha/1jhn5Bw==
X-Gm-Gg: AfdE7cmGE/gE0ex52TFq+TDuBju59GtRK1B+d28l0DgPMUouFvRpHHUHskvJ7HPthU8
CeshXzV89CgxKAe6yVkPyLjqu0TkfCxMD+F6BJevFs+6C66xpbU4JbZjjMigPdsrg41od8i4mrq
OzAdAF7yXook/0xnuW5Sob454WiTOQX2iE5cP2bHLKEuutLTtxXuFcP4Fn2WSS3YawyEYZvqSPL
w8XpDLFznwcWLT2DQsRKhfMEpgklQPDyElCIIP2Ae62yngn3M6pAcBe2SAKU9OAqwtDVSM58ZaF
gFzh5SWibg5Ze/CsTVofoS/aWAlVW2vAQkJpyNz4GiZGlpVXS7qtTo31hAA+coIgRc0IRJurohi
MC2EMg6NE88GZio4PYUn3BG5n8x2b2xHB/Yg+AgINZYz6e9oNHnxWwr/cbEfe1/EPtIWn7YwzLd
hAURXd57qqCbQrE62S02/0xSc4OTfn2geQGvhXGS1Ez9A=
X-Received: by 2002:a05:6808:318d:b0:495:aebe:eadf with SMTP id
5614622812f47-495aebefb5fmr536870b6e.37.1782584070641;
Sat, 27 Jun 2026 11:14:30 -0700 (PDT)
Received: from moss (cm-24-53-187-185.buckeyecom.net. [24.53.187.185])
by smtp.gmail.com with ESMTPSA id
5614622812f47-495ae420640sm299596b6e.1.2026.06.27.11.14.29
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sat, 27 Jun 2026 11:14:29 -0700 (PDT)
From: "J.D. Smith" <jdtsmith@HIDDEN>
To: bug-gnu-emacs@HIDDEN, Alan Third <alan@HIDDEN>
Subject: [PATCH] 31.0.90; new image scale check causes frequent image cache
miss
X-Debbugs-Cc:
Date: Sat, 27 Jun 2026 14:14:28 -0400
Message-ID: <m2wlvjlukb.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=2001:4860:4864:20::29;
envelope-from=jdtsmith@HIDDEN; helo=mail-oa1-x29.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 2.0 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Since updating my local build to the v31 release branch, I
have noticed image display slowdowns for native image types. I've tracked
it down to the new "scale" check in `search_image_cache' from bug#7 [...]
Content analysis details: (2.0 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust [2001:470:142:0:0:0:0:17 listed in] [list.dnswl.org]
1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail)
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (jdtsmith[at]gmail.com)
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
1.0 FORGED_GMAIL_RCVD 'From' gmail.com does not match 'Received'
headers
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.0 (+)
--=-=-=
Content-Type: text/plain
Since updating my local build to the v31 release branch, I have noticed
image display slowdowns for native image types. I've tracked it down to
the new "scale" check in `search_image_cache' from bug#74725, which
corrected handling of `image-scaling-factor'. A new check in
`search_image_cache' compares the scales computed from the image spec
and stored in the image:
&& scale == img->scale
and the image cache misses if they do not agree.
The function `image_compute_scale' is the only place `img->scale' gets
set, and only if the `img' pointer passed to it as the final argument is
valid. This occurs exclusively from the function `compute_image_size':
static void
compute_image_size (struct frame *f, .., struct image *img, ...)
{
double scale = image_compute_scale(f, img->spec, img);
For non-SVG images, `compute_image_size' is called only from
`image_set_transform'. But note, this function has a possible early
bailout:
# if (defined HAVE_IMAGEMAGICK \
&& !defined DONT_CREATE_TRANSFORMED_IMAGEMAGICK_IMAGE)
/* ImageMagick images already have the correct transform. */
if (EQ (image_spec_value (img->spec, QCtype, NULL), Qimagemagick))
return;
# endif
I.e. for `imagemagick' image types, `compute_image_scale(..., img)'
/never/ gets called, `img->scale' never gets set, and image cache lookup
always fails. Hence images are reloaded on every redisplay (e.g. during
scrolling).
Moreover, only with HAVE_NATIVE_TRANFORMS defined is
`image_set_transforms' called at all:
#ifdef HAVE_NATIVE_TRANSFORMS
image_set_transform (f, img);
#endif
Otherwise, I suspect all image cache lookups would miss. Conjecture:
this may relate to the slow image scrolling performance recently
reported on emacs-devel for Linux builds.
I want to see what Alan thinks about this, but perhaps a simple fix
would be to pre-compute `img->scale' for all images during load,
independent of their type (attached).
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment; filename=compute_scale.patch
Content-Description: Pre-compute image scale
diff --git a/src/image.c b/src/image.c
index bcab4a1b944..d01b1376838 100644
--- a/src/image.c
+++ b/src/image.c
@@ -3120,7 +3120,7 @@ compute_image_size (struct frame *f, double width, double height,
struct image *img,
int *d_width, int *d_height)
{
- double scale = image_compute_scale(f, img->spec, img);
+ double scale = image_compute_scale(f, img->spec, NULL);
/* If width and/or height is set in the display spec assume we want
to scale to those values. If either h or w is unspecified, the
@@ -4031,6 +4031,7 @@ lookup_image (struct frame *f, Lisp_Object spec, int face_id)
/* postprocess_image above may modify the image or the mask,
relying on the image's real width and height, so
image_set_transform must be called after it. */
+ image_compute_scale(f, img->spec, img);
#ifdef HAVE_NATIVE_TRANSFORMS
image_set_transform (f, img);
#endif
--=-=-=--
"J.D. Smith" <jdtsmith@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#81319; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.