Received: (at 81367) by debbugs.gnu.org; 8 Jul 2026 11:21:34 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jul 08 07:21:33 2026 Received: from localhost ([127.0.0.1]:38260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1whQLK-0008Q4-W6 for submit <at> debbugs.gnu.org; Wed, 08 Jul 2026 07:21:33 -0400 Received: from fout-a2-smtp.messagingengine.com ([103.168.172.145]:41775) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <spwhitton@HIDDEN>) id 1whQLG-0008OU-C2 for 81367 <at> debbugs.gnu.org; Wed, 08 Jul 2026 07:21:28 -0400 Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfout.phl.internal (Postfix) with ESMTP id B9477EC01B3; Wed, 8 Jul 2026 07:21:20 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-06.internal (MEProxy); Wed, 08 Jul 2026 07:21:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1783509680; x=1783596080; bh=P4EtI2zppu oTX0eEHhYgIo25ShjzSzMtLyvZlSOK3p4=; b=sZ4yhYDAwToRz9N2ps+bCqYbuc 0V7AgonoECplApQeo8i3GqITj8J+7xXZFAGRPdTL0IO/F+QKOO+zNspAsLAGh0EY XLV5eH2t9NTBjkkQ+qpXKYCzxL0ScEmx1LmOE1U+EPomzIrzvGRT53m/uLZwSMRW a9oBlctNdPIWR8oUYH8YwSQmsXm580cvjY4pYjS+NwaDnUaUaMq+jcbdRyRREAdG omDtg5uqkGNNY4BiZPfIVhWlFL9WuPXjotOvlU3vErnkAODnSpcQgHEhtUkBHq8r rjMtu+B2mJ5pF6jGfC0r0ZAyBGvuqS1tL1nskptlsG5o26EQClNC0wrdStyA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1783509680; x=1783596080; bh=P4EtI2zppuoTX0eEHhYgIo25ShjzSzMtLyv ZlSOK3p4=; b=IFD3fVxeNdA15+zkutK1mzlvv0p/d+NUrjAortOlqZzGsFYxwHH rJBa9t5Ir0KUkHrK15JwO4+soaNTxZhLmxZvmNJw4We+RH8R+eW05OziCt5+C1Ju 3ZrMhIdqf8b2T6r94Y68HsgD+jvGnOkpasXjJ02vrsw0b1DtnsSDLsoXQbPbsF1z oCv266gy+ZZSuqoy4lQdMKM5F9QCqXX97XuN2FuEKv6tSlSAdUcW/ONI81Aq1az9 TLEHfufiBu5rw2/0UgEz504Ue/ZtuOjOOc6ZwbszL0vexxC7VnXrBY2RKpZGrfBh yQ3p+YApX2dqNZujj+WscRvTSjH/IN46Vhw== X-ME-Sender: <xms:sDJOahRrsLqqU_q3jXTtjI-uOm7K1MdD3q93g4SFsDsBLWr4LDiIbg> <xme:sDJOaiOHk718ylbBk7g2XdUbvRmy65Gzv-CrCO7PLrbYuLL3EJt7SCeJoybJXPLvi _VAlmsPMxq944mG648yEBCyG2T7B9vBHpMLV8EFown1Mx86HenQ9g> X-ME-Received: <xmr:sDJOakME_GUeb_VIP-Z-A1TKRPjlHKDFCEGcrgt4ke8weyRpoNCrcxK7yHtzgB5FIv_Mi5FLKhWM> X-ME-Proxy-Cause: dmFkZTFPQ7EgzC18BllydBZvWipDJIbo8nPyTBGBNKvriiIiBcaLQFQR+8bJwKoTx7NWVR P6RW//DWyNmi0VLe43VEy+szsiejMFkHIDWKL6gkHln63N9noLWZ/7R0z1rBSJeXDN9J0o 0h0yjuVMZufnt4YhHOdPlPhpCsHt6C4SHQfSwgGHIsp2Tjyg2ilVSO0X+pInF+gqcDSChn jCdJ/PJani0l2qjpL9DWiYytWGVVBtmc9FiyiZZ7SLaZYtURjmo5IaOQl46pFqzaS0dlUi nJNN3to79iWfat8DM+MR5v3lQC3/wwEHjUwBmVKgXGGhjEcYFcId/ohHXiTW2OwILfgMPF f/u6zQ0Bsx5LseaFa/fEpbd61iMcbkGgYpa/+QN+cwKbrM4viF7ZTRldJPzCWbkPf6K8oN 9BinpTXY4jFPWq/hcDKDX77iNJClAzMmaFPMACQ/Ccyz70wSdGf51k6KGeiUqTMTv11G95 ALTEBarpSEwei8jR6v1sOecvJsEFVWS4RdHHcjs7fOL/sDfv5IwKR/oqV1IbeIycg+Sv/1 ox0354NnL0UeDNXDAAp5rl17Cmqw0qLIZQ5xS47/qVXN627QHS1DLhkiSdv3vRLyPbKnEP PZ/tP7iTNYF4G+xV7Rb2RVa1ONefBDUAnV8/W9PtMspdmugZCk2eizG0HC+g X-ME-Proxy: <xmx:sDJOaiuGsMhyqvqSdkxDx999S99MFjeOBqFsShU781gPoqoVLC7A1Q> <xmx:sDJOauU9uW-N2O6dLtsPjFq-KhXNJCKKn4terXTRXBDynZyxvS8dsw> <xmx:sDJOaquZKK8BdWyAHUAb1qRObFeKJhI0E-C7AbIJdkTelWVYveGwPw> <xmx:sDJOaqUZ0G-as4T6177dwxo8r_X_QzKQFcnDS9tpvtl4-M1pq1GS0w> <xmx:sDJOagXBynY3NhJjBA9MZvtZ65eJJeShynia5aOK6erQGySXzOMFwofF> Feedback-ID: i62564b17:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 8 Jul 2026 07:21:20 -0400 (EDT) Received: by melete.silentflame.com (Postfix, from userid 1000) id 7B8597E6C09; Wed, 08 Jul 2026 12:21:19 +0100 (BST) From: Sean Whitton <spwhitton@HIDDEN> To: David Ponce <da_vid@HIDDEN>, schwab@HIDDEN, 81367 <at> debbugs.gnu.org Subject: Re: bug#81367: 32.0.50; `cl-defstruct' fails with % in slot names In-Reply-To: <f8f3d896-0492-4d4b-bc11-10b087b22c3c@HIDDEN> References: <3b85cff2-1335-406d-84a0-22294f5edb4f@HIDDEN> <mvm5x2so02x.fsf@HIDDEN> <8b4314fe-4e98-4ebd-9101-b51c09f59f97@HIDDEN> <875x2qon1g.fsf@HIDDEN> <b8a1beee-bbf0-4353-b8f8-5ec4cf9c9426@HIDDEN> <87o6ghn7p8.fsf@HIDDEN> <f8f3d896-0492-4d4b-bc11-10b087b22c3c@HIDDEN> Date: Wed, 08 Jul 2026 12:21:19 +0100 Message-ID: <87cxwxn2vk.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 81367 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) David Ponce [08/Jul 12:02pm +02] wrote: >> It doesn't apply to current master, could you look into that? >> > Perhaps there was an issue when I copied it into the body of the message. > Please find the patch attached. Thanks, it applies now. > diff --git a/lisp/emacs-lisp/cl-macs.el b/lisp/emacs-lisp/cl-macs.el > index 9fa2a2b7cf0..d22a16b5e99 100644 > --- a/lisp/emacs-lisp/cl-macs.el > +++ b/lisp/emacs-lisp/cl-macs.el > @@ -694,8 +694,10 @@ cl--do-arglist > (setq ,var nil)) > (t > (error > - ,(format "Keyword argument %%S not one of %S" > - keys) > + ,(format "Keyword argument %%S not one of %s" > + ;; Escape % in slot names. > + (string-replace > + "%" "%%" (format "%S" keys))) > (car ,var))))))) > (push `(let ((,var ,restarg)) ,check) cl--bind-forms))))) > (cl--do-&aux args) This hunk is self-explanatory. > @@ -3293,8 +3295,9 @@ cl-defstruct > ;; the parent's accessor? > (push `(define-inline ,accessor (x) > ,(let ((long-docstring > - (format "Access slot \"%s\" of `%s' struct X." > - slot name))) > + (internal--format-docstring-line > + "Access slot \"%s\" of `%s' struct X." > + slot name))) > (concat > ;; NB. This will produce incorrect results > ;; in some cases, as our coding conventions > @@ -3315,7 +3318,7 @@ cl-defstruct > "\n" > (internal--format-docstring-line > "Struct X is a `%s'." name)) > - (internal--format-docstring-line long-docstring)) > + long-docstring) > (if doc (concat "\n" doc) "") > "\n" > (format "\n\n(fn %s X)" accessor))) These hunks I understand less. Can you explain? -- Sean Whitton
bug-gnu-emacs@HIDDEN:bug#81367; Package emacs.
Full text available.Received: (at 81367) by debbugs.gnu.org; 8 Jul 2026 10:02:16 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jul 08 06:02:15 2026 Received: from localhost ([127.0.0.1]:38074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1whP6a-0004bu-6N for submit <at> debbugs.gnu.org; Wed, 08 Jul 2026 06:02:15 -0400 Received: from smtp-73.smtpout.orange.fr ([80.12.242.73]:59311 helo=smtp.smtpout.orange.fr) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <da_vid@HIDDEN>) id 1whP6T-0004an-T3 for 81367 <at> debbugs.gnu.org; Wed, 08 Jul 2026 06:02:10 -0400 Received: from [IPV6:2a01:cb15:8909:5500:8f09:52af:b5c8:9dbc] ([IPv6:2a01:cb15:8909:5500:8f09:52af:b5c8:9dbc]) by smtp.orange.fr with ESMTPSA id hP6Qwp9doLhCphP6Rwy4RP; Wed, 08 Jul 2026 12:02:04 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1783504924; bh=rdlkrFs8s94df3wIRt117AKNCnSKuUteZNUjIRweXiM=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=dsDr9gnGvrgzs+RR37wgpCC+JKD/9lofGqBpsw+04UQVg6eTyU3B7Ri13aKIFFyFv 3+dcoCqlEo2Axg1DdgSXLFdosbQj//9ou2yRjtlYwVzH+zm/o8F+QTIMDNG4eXOhhF 3xtv7krErle9FKUfj80ivFFiqzKk56YMzHsIPXh1ExejNVbtdYeeBnMsbcoHfbN+PY Yl9w+xcJiDyr5Nb62VCSuw0uXZyJs0wq2IUFhV3Q5QBq6zGgG9vnbKUVNFjrc1UOHY 2zUnqqHSbuFvI5lmVLFoFS37WBdduG9Xa2aE2AIlfo5spNYL+Joki4flBNY16RJdwQ virYJ3LuAvPDA== X-ME-Helo: [IPV6:2a01:cb15:8909:5500:8f09:52af:b5c8:9dbc] X-ME-Auth: ZGFfdmlkQG9yYW5nZS5mcg== X-ME-Date: Wed, 08 Jul 2026 12:02:04 +0200 X-ME-IP: 2a01:cb15:8909:5500:8f09:52af:b5c8:9dbc Content-Type: multipart/mixed; boundary="------------hnXjBGZh6RkniUHL1cqhtdh2" Message-ID: <f8f3d896-0492-4d4b-bc11-10b087b22c3c@HIDDEN> Date: Wed, 8 Jul 2026 12:02:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#81367: 32.0.50; `cl-defstruct' fails with % in slot names To: Sean Whitton <spwhitton@HIDDEN>, schwab@HIDDEN, 81367 <at> debbugs.gnu.org References: <3b85cff2-1335-406d-84a0-22294f5edb4f@HIDDEN> <mvm5x2so02x.fsf@HIDDEN> <8b4314fe-4e98-4ebd-9101-b51c09f59f97@HIDDEN> <875x2qon1g.fsf@HIDDEN> <b8a1beee-bbf0-4353-b8f8-5ec4cf9c9426@HIDDEN> <87o6ghn7p8.fsf@HIDDEN> Content-Language: fr From: David Ponce <da_vid@HIDDEN> In-Reply-To: <87o6ghn7p8.fsf@HIDDEN> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 81367 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------hnXjBGZh6RkniUHL1cqhtdh2 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Le 2026-07-08 à 11:37, Sean Whitton a écrit : > David Ponce [07/Jul 6:37pm +02] wrote: >> Le 2026-07-07 à 17:08, Sean Whitton a écrit : >> >> [...] >>> The patch looks fine, thanks, but I am not sure about the first part -- >>> why did you reword the message instead of just dealing with the escaping >>> issue? I'm not saying it's wrong but it needs a separate justification >>> than just dealing with the % problem. >> >> Sorry, you are right, rewording the first message has nothing to do >> with the escaping issue. >> >> It’s just that a message like "Keyword argument <keyword> not one of >> nil" strikes me as a bit odd. But I’m happy to let those with the >> relevant expertise judge whether it makes sense. > > Please feel free to file a separate bug about it. OK, I'll do it eventually. > >> Here is a revised patch without that rewording: > > It doesn't apply to current master, could you look into that? > Perhaps there was an issue when I copied it into the body of the message. Please find the patch attached. Thanks --------------hnXjBGZh6RkniUHL1cqhtdh2 Content-Type: text/x-patch; charset=UTF-8; name="cl-defstruct-fix-%-issue.patch" Content-Disposition: attachment; filename="cl-defstruct-fix-%-issue.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvZW1hY3MtbGlzcC9jbC1tYWNzLmVsIGIvbGlzcC9lbWFjcy1s aXNwL2NsLW1hY3MuZWwKaW5kZXggOWZhMmEyYjdjZjAuLmQyMmExNmI1ZTk5IDEwMDY0NAot LS0gYS9saXNwL2VtYWNzLWxpc3AvY2wtbWFjcy5lbAorKysgYi9saXNwL2VtYWNzLWxpc3Av Y2wtbWFjcy5lbApAQCAtNjk0LDggKzY5NCwxMCBAQCBjbC0tZG8tYXJnbGlzdAogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIChzZXRxICx2YXIgbmlsKSkKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICh0CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg KGVycm9yCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICwoZm9ybWF0ICJLZXl3 b3JkIGFyZ3VtZW50ICUlUyBub3Qgb25lIG9mICVTIgotICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBrZXlzKQorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAsKGZvcm1hdCAiS2V5d29yZCBhcmd1bWVudCAlJVMgbm90IG9uZSBvZiAlcyIKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOzsgRXNjYXBlICUgaW4g c2xvdCBuYW1lcy4KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg KHN0cmluZy1yZXBsYWNlCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAiJSIgIiUlIiAoZm9ybWF0ICIlUyIga2V5cykpKQogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAoY2FyICx2YXIpKSkpKSkpCiAJICAgICAgKHB1c2ggYChsZXQgKCgs dmFyICxyZXN0YXJnKSkgLGNoZWNrKSBjbC0tYmluZC1mb3JtcykpKSkpCiAgICAgICAoY2wt LWRvLSZhdXggYXJncykKQEAgLTMyOTMsOCArMzI5NSw5IEBAIGNsLWRlZnN0cnVjdAogICAg ICAgICAgICAgICA7OyB0aGUgcGFyZW50J3MgYWNjZXNzb3I/CiAJICAgICAgKHB1c2ggYChk ZWZpbmUtaW5saW5lICxhY2Nlc3NvciAoeCkKICAgICAgICAgICAgICAgICAgICAgICAgLChs ZXQgKChsb25nLWRvY3N0cmluZwotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChm b3JtYXQgIkFjY2VzcyBzbG90IFwiJXNcIiBvZiBgJXMnIHN0cnVjdCBYLiIKLSAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNsb3QgbmFtZSkpKQorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIChpbnRlcm5hbC0tZm9ybWF0LWRvY3N0cmluZy1saW5l CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJBY2Nlc3Mgc2xvdCBcIiVzXCIg b2YgYCVzJyBzdHJ1Y3QgWC4iCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNs b3QgbmFtZSkpKQogICAgICAgICAgICAgICAgICAgICAgICAgICAoY29uY2F0CiAgICAgICAg ICAgICAgICAgICAgICAgICAgICA7OyBOQi4gIFRoaXMgd2lsbCBwcm9kdWNlIGluY29ycmVj dCByZXN1bHRzCiAgICAgICAgICAgICAgICAgICAgICAgICAgICA7OyBpbiBzb21lIGNhc2Vz LCBhcyBvdXIgY29kaW5nIGNvbnZlbnRpb25zCkBAIC0zMzE1LDcgKzMzMTgsNyBAQCBjbC1k ZWZzdHJ1Y3QKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIlxuIgogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAoaW50ZXJuYWwtLWZvcm1hdC1kb2NzdHJpbmct bGluZQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIlN0cnVjdCBYIGlzIGEg YCVzJy4iIG5hbWUpKQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoaW50ZXJuYWwt LWZvcm1hdC1kb2NzdHJpbmctbGluZSBsb25nLWRvY3N0cmluZykpCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGxvbmctZG9jc3RyaW5nKQogICAgICAgICAgICAgICAgICAgICAg ICAgICAgKGlmIGRvYyAoY29uY2F0ICJcbiIgZG9jKSAiIikKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICJcbiIKICAgICAgICAgICAgICAgICAgICAgICAgICAgIChmb3JtYXQgIlxu XG4oZm4gJXMgWCkiIGFjY2Vzc29yKSkpCg== --------------hnXjBGZh6RkniUHL1cqhtdh2--
bug-gnu-emacs@HIDDEN:bug#81367; Package emacs.
Full text available.Received: (at 81367) by debbugs.gnu.org; 8 Jul 2026 09:37:20 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jul 08 05:37:19 2026 Received: from localhost ([127.0.0.1]:38010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1whOiU-0000fV-2Q for submit <at> debbugs.gnu.org; Wed, 08 Jul 2026 05:37:19 -0400 Received: from fhigh-a1-smtp.messagingengine.com ([103.168.172.152]:42187) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <spwhitton@HIDDEN>) id 1whOiQ-0000e5-Kb for 81367 <at> debbugs.gnu.org; Wed, 08 Jul 2026 05:37:15 -0400 Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfhigh.phl.internal (Postfix) with ESMTP id 1045514000FD; Wed, 8 Jul 2026 05:37:09 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Wed, 08 Jul 2026 05:37:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1783503429; x=1783589829; bh=2uxI7cNYch6htOFHMgSFadiAhlUplJOzg5ADzTTEMWY=; b= Oeaekeqv7IFLB/2X3xF2SaWTEtQqUQGIBrFa4c3C1b8iwx8hBKJaBxSSTDAtFz/4 U9B/FW2Uw+Hw7aSrY3RueYRzmbZDIyygCQUPbbrblh+71RR2+y6kRlJZgu7asclu qdUtewzp2TcQpquoK+pGbPx7kTcOKDFxuPmavHxw80LsQNUYhhbH3ea3NQ+T0rin DYwKPKECJ5mpQzaSy15P9ML1vuXnVKkhjLXuk+LcWtXMlWbGtkfLK055PunGDyDe 0zdDPTJqD6XpNL9LABgBugVu7onQDwFgLP7a6ruulCDSoTWPHQCJKW7KLgY+cZ2d 5B5njv0YL7AQGht/2MG+1g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1783503429; x=1783589829; bh=2 uxI7cNYch6htOFHMgSFadiAhlUplJOzg5ADzTTEMWY=; b=YmnVTvbk2k+zpPqC6 tEORVnkbFHjO6yTdzOMn7/Iw/8AO7QnIGU7zTee7CxjbouW4+DRPKNIkEn3vKcql NeC94FFXpRKHLsRwLSelgvQs6DDAZFLHOovGcGkcABqf7+/wOIe8p6MDou1l7koR Y0GhCvqQjleHAvq85J4KdBD/3osr7MixCaUUXQINZhVnra7MWhwjHu2in1gAffb8 1qB+MD+cebukSZZ9KDqzryxZqwxPEI+rb1uP+8Og3J9yKrAqaJKM2g6CBTbtl0my cOunnawCv5q04nh22tg2s8tcSlqDFz3DVs7LcBkr0Yz5+yukDN4Tt1Z1ytiFefnJ BF2Mg== X-ME-Sender: <xms:RBpOaqkPGBHbL-v7r3WZYgQoW1t0vKMRKvGwd3ZGMlzdpovF78CcHw> <xme:RBpOapR47pTkpDP-eVya3JKn0oQdFdgdD2DDYv2g3TKX3DazuGvdlzNuudhCFJtL3 mmEQIbRmb56KoJ3ygATj6t4DmPTWwXJbzznUZBvwy2uknUA-89brQ> X-ME-Received: <xmr:RBpOamBXzF4cIwJ-v8ODf3jl4vtYL5UkKNEJlGpWN-QHLW6EF7Tclh3z3YJuoRb16WTzFCjfHmVp> X-ME-Proxy-Cause: dmFkZTEGJfuOwPd1HpYJjMmnCv0VJBipHOlKDMTkluyqwn44ELc0puiwYmY//dNX9IY2LL 0Y7Gd3sj9e/2BpZ5AnG3E+tJ+wRQvoibys1yI+ApGB2CGXLywrOt+InqRBG7yDBzAbvbzL JKsFjerzsRdosCCVxA47fENAbwJ3Xe4VQnbb6tdcapAVIIDin8Zid+r1H1GpgK9aE3Zoll /hj+6DDQBFYDaBIb2903d/mdJ6P2o5R273T86u5ErEYW4JDMGKPjqyZojGb76lFoGPqv42 6ueAOhyKjHxGsU7959FjWq/1U44bM9nRrsrgjQ9b02HGAng9G5bPNKvcd+i5ijxbyFn1Td e7Ve7igszx0e9SQUtt7lDM4xl16SuzkAkrNPGyx/arEUsQbJmjWGrQVW9vghAKV1zchBYe Mrvpom4YhJMpxiBDMAL+Cf6xduyQF+vyf+JOif6MYsK9Ad8R0wCP4SOdTZcrvFkqRqT+G9 6/WUPJbQo1fAr1Uxl2SmicL+GYnHi0TDKAXsOZwhXtmgmp9DCWJm21SI4rcgIngRe80Itw HfgrdTVy/YoBGraFfFj4KfgIMveBoqZCKtI5KJqKIj5uetflDUdQUHob64ErMyw4WL4Hmr /AYZm+eE/eQKn7M70oMfq17kvj3/+pCbvVL/5nKgnFzqhXCg1L2eiSgKdR1g X-ME-Proxy: <xmx:RBpOaoT3y6hXVziE50uyGJEe8aWRnIAeVKdVmsq01CI88YjsvHJ1-Q> <xmx:RBpOasp2Si92J6amf3VRLNVWInfeHrVamftJtyffMW4qe6phBrwFSA> <xmx:RBpOaiyRN8JDb5IkKnyDJB0aM3yvF-BtOq1WQx6fI33Dxvee1hCrRQ> <xmx:RBpOapJheQg9zMag5VUEoXXyyCtrNT0AhfplKoE978DsTLGEB4Ad_Q> <xmx:RRpOav7U0weB7gsRf05s10F3f6IfF2_2Kt588-kt3sUtnrZrdaKEvETo> Feedback-ID: i62564b17:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 8 Jul 2026 05:37:08 -0400 (EDT) Received: by melete.silentflame.com (Postfix, from userid 1000) id B81AB7E7983; Wed, 08 Jul 2026 10:37:07 +0100 (BST) From: Sean Whitton <spwhitton@HIDDEN> To: David Ponce <da_vid@HIDDEN>, schwab@HIDDEN, 81367 <at> debbugs.gnu.org Subject: Re: bug#81367: 32.0.50; `cl-defstruct' fails with % in slot names In-Reply-To: <b8a1beee-bbf0-4353-b8f8-5ec4cf9c9426@HIDDEN> References: <3b85cff2-1335-406d-84a0-22294f5edb4f@HIDDEN> <mvm5x2so02x.fsf@HIDDEN> <8b4314fe-4e98-4ebd-9101-b51c09f59f97@HIDDEN> <875x2qon1g.fsf@HIDDEN> <b8a1beee-bbf0-4353-b8f8-5ec4cf9c9426@HIDDEN> Date: Wed, 08 Jul 2026 10:37:07 +0100 Message-ID: <87o6ghn7p8.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 81367 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) David Ponce [07/Jul 6:37pm +02] wrote: > Le 2026-07-07 =C3=A0 17:08, Sean Whitton a =C3=A9crit=C2=A0: > > [...] >> The patch looks fine, thanks, but I am not sure about the first part -- >> why did you reword the message instead of just dealing with the escaping >> issue? I'm not saying it's wrong but it needs a separate justification >> than just dealing with the % problem. > > Sorry, you are right, rewording the first message has nothing to do > with the escaping issue. > > It=E2=80=99s just that a message like "Keyword argument <keyword> not one= of > nil" strikes me as a bit odd. But I=E2=80=99m happy to let those with the > relevant expertise judge whether it makes sense. Please feel free to file a separate bug about it. > Here is a revised patch without that rewording: It doesn't apply to current master, could you look into that? --=20 Sean Whitton
bug-gnu-emacs@HIDDEN:bug#81367; Package emacs.
Full text available.
Received: (at 81367) by debbugs.gnu.org; 7 Jul 2026 16:37:53 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jul 07 12:37:53 2026
Received: from localhost ([127.0.0.1]:33630 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1wh8nw-0005KR-E5
for submit <at> debbugs.gnu.org; Tue, 07 Jul 2026 12:37:53 -0400
Received: from smtp-24.smtpout.orange.fr ([80.12.242.24]:52251
helo=smtp.smtpout.orange.fr)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <da_vid@HIDDEN>) id 1wh8ns-0005JY-Db
for 81367 <at> debbugs.gnu.org; Tue, 07 Jul 2026 12:37:49 -0400
Received: from [192.168.1.21] ([90.38.183.166]) by smtp.orange.fr with ESMTPSA
id h8nowxAENzpXLh8nowhSQ1; Tue, 07 Jul 2026 18:37:46 +0200
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr;
s=t20230301; t=1783442266;
bh=wi8nbx0BiHKHSOmDgxi26GJ661MNg4BALEiJ59DQq5s=;
h=Message-ID:Date:MIME-Version:Subject:To:From;
b=qTAqjAQWhLiKqAh7C8EQzTVP1MerRt/++Xw6/dv8lUeruciVsg02iUMqD5+2I5BEh
Nei05z/ohVXa3aXcEfAWLdH4RjVZQWg5WxArDu40pHfSry9Ohq6ev4dzY4KXRzyvXX
sN5hCFBUT01yag3M3zn/Di+cMWqho2eia+IcnwLcIMHj+JBL1gruR1Z76TjgLZzuFp
o2hk4nbbeWw98UDNhDtuDYrIG3m0q3An2Jl5OwrO8Vjzmd4OlQrbADVUwfnnfKgaP6
DTu2ClM8dlyQJ9EyPI11lZSWZKt7PuEjhXiH6IASOHIutfO89IfcI7sCTXh1gBe2Wk
t6kQ8WGnXSKfA==
X-ME-Helo: [192.168.1.21]
X-ME-Auth: ZGFfdmlkQG9yYW5nZS5mcg==
X-ME-Date: Tue, 07 Jul 2026 18:37:46 +0200
X-ME-IP: 90.38.183.166
Message-ID: <b8a1beee-bbf0-4353-b8f8-5ec4cf9c9426@HIDDEN>
Date: Tue, 7 Jul 2026 18:37:44 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: bug#81367: 32.0.50; `cl-defstruct' fails with % in slot names
To: Sean Whitton <spwhitton@HIDDEN>, schwab@HIDDEN,
81367 <at> debbugs.gnu.org
References: <3b85cff2-1335-406d-84a0-22294f5edb4f@HIDDEN>
<mvm5x2so02x.fsf@HIDDEN> <8b4314fe-4e98-4ebd-9101-b51c09f59f97@HIDDEN>
<875x2qon1g.fsf@HIDDEN>
Content-Language: fr
From: David Ponce <da_vid@HIDDEN>
In-Reply-To: <875x2qon1g.fsf@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 81367
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Le 2026-07-07 à 17:08, Sean Whitton a écrit :
[...]
> The patch looks fine, thanks, but I am not sure about the first part --
> why did you reword the message instead of just dealing with the escaping
> issue? I'm not saying it's wrong but it needs a separate justification
> than just dealing with the % problem.
Sorry, you are right, rewording the first message has nothing to do
with the escaping issue.
It’s just that a message like "Keyword argument <keyword> not one of
nil" strikes me as a bit odd. But I’m happy to let those with the
relevant expertise judge whether it makes sense.
Here is a revised patch without that rewording:
2026-07-07 David Ponce <da_vid@HIDDEN>
Fix error in `cl-defstruct' when slot names contain % characters
(bug#81367).
* lisp/emacs-lisp/cl-macs.el (cl--do-arglist): Escape % in slot
names.
(cl-defstruct): Do not pass again to `format' an already formatted
doc string.
diff --git a/lisp/emacs-lisp/cl-macs.el b/lisp/emacs-lisp/cl-macs.el
index 9fa2a2b7cf0..d22a16b5e99 100644
--- a/lisp/emacs-lisp/cl-macs.el
+++ b/lisp/emacs-lisp/cl-macs.el
@@ -694,8 +694,10 @@ cl--do-arglist
(setq ,var nil))
(t
(error
- ,(format "Keyword argument %%S not one of %S"
- keys)
+ ,(format "Keyword argument %%S not one of %s"
+ ;; Escape % in slot names.
+ (string-replace
+ "%" "%%" (format "%S" keys)))
(car ,var)))))))
(push `(let ((,var ,restarg)) ,check) cl--bind-forms)))))
(cl--do-&aux args)
@@ -3293,8 +3295,9 @@ cl-defstruct
;; the parent's accessor?
(push `(define-inline ,accessor (x)
,(let ((long-docstring
- (format "Access slot \"%s\" of `%s' struct X."
- slot name)))
+ (internal--format-docstring-line
+ "Access slot \"%s\" of `%s' struct X."
+ slot name)))
(concat
;; NB. This will produce incorrect results
;; in some cases, as our coding conventions
@@ -3315,7 +3318,7 @@ cl-defstruct
"\n"
(internal--format-docstring-line
"Struct X is a `%s'." name))
- (internal--format-docstring-line long-docstring))
+ long-docstring)
(if doc (concat "\n" doc) "")
"\n"
(format "\n\n(fn %s X)" accessor)))
bug-gnu-emacs@HIDDEN:bug#81367; Package emacs.
Full text available.Received: (at 81367) by debbugs.gnu.org; 7 Jul 2026 15:08:23 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jul 07 11:08:23 2026 Received: from localhost ([127.0.0.1]:33416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1wh7PK-0005hn-Ag for submit <at> debbugs.gnu.org; Tue, 07 Jul 2026 11:08:23 -0400 Received: from fout-a3-smtp.messagingengine.com ([103.168.172.146]:41087) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <spwhitton@HIDDEN>) id 1wh7PG-0005gY-7M for 81367 <at> debbugs.gnu.org; Tue, 07 Jul 2026 11:08:19 -0400 Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfout.phl.internal (Postfix) with ESMTP id 0280EEC022E; Tue, 7 Jul 2026 11:08:13 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-04.internal (MEProxy); Tue, 07 Jul 2026 11:08:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1783436892; x=1783523292; bh=UbzG9pZY40bmJkJ4HkUsKSerbRyg89o1UP5EH3UL72o=; b= Mu6Rlr/K5sQJDQeNXA/ctHvCjlBgr5dJUmqJ3OSgBQ1jtEH8W3CesabIQneupxMn UAWQn1BDVe+9cEFXqU6sUy4HvJJLWnV9w3hjrJQdN/zWiBUk+TmRiwba6RSmSauB 7PuerL89SFxR7ZPgNF+l4qmnk6a0SHZSQYqnAFRiGdd+kCahXizU3nQLTSj5fc7+ /JEL4Z2LnORxVF87L4vJTY4oDawOP5xA8y81Ta9RZXOWgVqsJU4rwKuWS8ysnJnW Eab9WH39D7xBN2C15FykMYIb39gWU7NPVqQBbtRbQJE8fz5hhCSdH/FVPIxZLqbM hJ6w3jh+b+WB9/fm6VLVlQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1783436892; x=1783523292; bh=U bzG9pZY40bmJkJ4HkUsKSerbRyg89o1UP5EH3UL72o=; b=GrktGHPMmkw0enFMK 02koY7sRuOlXfmW/MI1Q+uwh+ApDtdqwxR3UVcmtvrqDyJwp2Lfq5RNvH18EbCZs UVKgLzKPlbgdnAbiDtrxnZal4rBCvuT2alrq0HnyG+9W9kkQbOLo34Jn3CMWK4t/ zeOQauoc7MeMr0847TQZcOqE5fae/GZGXJFevruW7ZUgVrLR2c4+lFd3szeQV4cC gR3s9cIGh9gSPlQb9aGKC7xix03VLlTokdPqrlbcuHra5CidBiRx0YYO5BqsxIOo nhCKe/+ri2vygJEgZpkGtctL3oNXxMWlq5rJrkwPDhPQqMVCtImjRRoi06ZsxKNf 5M91g== X-ME-Sender: <xms:XBZNasTLctxnqxQVfPBZhxHt6q1J-ACRxB2hk-EoCXa597VaoXbeFQ> <xme:XBZNahPSdIJGm5RicyvjhnrGbiCKmB-tlaWiGBo4H6Z97iRbsPbgUVdG3YBDWyWYw owvR0xBwsKDyCyUt7O8Qrw8Pch8-OHobpTpKxkYgUViEZ0DLynZMoT_> X-ME-Received: <xmr:XBZNanOMfNgKpQ8qoCiF3vb8kE7exuW8OdXDtPGU4gdLTMyh2wXQKlBORUXcqRKmOfkEt8K1pOPK> X-ME-Proxy-Cause: dmFkZTEwLE2Ax9/B2EndHEVm00mmP7+ad8lwgGrNJAwM0o8gZ5Np2s6VS8XXEwSjAHBCjx zY05OjS5fgsWfQvSExKXJxFsb1zfI6r9vHkmg4AjTKtU7U3F6mngORcD4ckmtx0v17ywu3 jgoMrv0WZTeFH9KXdtFg+blUEnJh09sY/uZhe0lgFtaEMX5pmJFbcLGlBJRISFisov6saR W/4N+zEP2DnhqpeQPzbS99cojbs1NsgmKTBuxtzWgIHgvv/Z261VPKXkkwC6IfVG8BopVQ 5uYVqfwgGgxhPmofcQghQDoEUZmyVDEyJzjBTK+FJJcfaqX2wLyeg3AfKIpZS82Kf9I4gi 5Z75S/ZJr1RL1W+1P9QJv92B6UM0K6jie25bTyknRH/jw5tKp479Rhf152v4t7Ep7rAOTu JbjH380cyFvHOCCcjgzcQ910px56RwGqwhdCzXMRNDDTQCDPXyk2e7hbRHoMmubDseh38k 3H19KNQbCDbdDcJvDTMvO2e9ZJezpiAq9uAtnXrUNW/N3PkY3OeZ/e7k34RzLS8SvU9JJb JMXanEhp+Pkncrls3joWzBgPgnQtK0iDz6QakCJ0xe0S0n+M1fqeC9m9MYSeIK1f5sAAs0 eC7VJ4GhgTh5iD+/LsaNZkeTTgRRzcGlFabL1NVwVv+TKQb80upewFhZh/aw X-ME-Proxy: <xmx:XBZNapuiBTBNHOuOoyymDsUDvXoz95TniSb1_y6h_aHHYXDDnycybA> <xmx:XBZNapX5wj09ELdkedvZ9luJk5gOug25s_5F6DxFF5SEMizYTqvUzg> <xmx:XBZNapujLc7-_5SUQd6uIzv0Itx4J3e_sGbtu-t7PRwHRe4hD_6rfA> <xmx:XBZNatX0InW40oBFWqEHOgo57wtgDzVt7nmqnA3dkS3DdFUpVIGijw> <xmx:XBZNanXz-qCdW45bCbiwBCaufc6lbcSPfIhTevenAZjm3z7l3dCa7fHl> Feedback-ID: i62564b17:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 7 Jul 2026 11:08:12 -0400 (EDT) Received: by melete.silentflame.com (Postfix, from userid 1000) id B6D917E75B7; Tue, 07 Jul 2026 16:08:11 +0100 (BST) From: Sean Whitton <spwhitton@HIDDEN> To: David Ponce <da_vid@HIDDEN>, schwab@HIDDEN, 81367 <at> debbugs.gnu.org Subject: Re: bug#81367: 32.0.50; `cl-defstruct' fails with % in slot names In-Reply-To: <8b4314fe-4e98-4ebd-9101-b51c09f59f97@HIDDEN> References: <3b85cff2-1335-406d-84a0-22294f5edb4f@HIDDEN> <mvm5x2so02x.fsf@HIDDEN> <8b4314fe-4e98-4ebd-9101-b51c09f59f97@HIDDEN> Date: Tue, 07 Jul 2026 16:08:11 +0100 Message-ID: <875x2qon1g.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 81367 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) David Ponce via "Bug reports for GNU Emacs, the Swiss army knife of text ed= itors" [06/Jul 4:29pm +02] wrote: > Le 2026-07-06 =C3=A0 12:59, Andreas Schwab a =C3=A9crit=C2=A0: >> On Jul 06 2026, David Ponce via "Bug reports for GNU Emacs, the Swiss ar= my knife of text editors" wrote: >> >>> diff --git a/lisp/emacs-lisp/cl-macs.el b/lisp/emacs-lisp/cl-macs.el >>> index 9fa2a2b7cf0..0225c90627b 100644 >>> --- a/lisp/emacs-lisp/cl-macs.el >>> +++ b/lisp/emacs-lisp/cl-macs.el >>> @@ -677,8 +677,10 @@ cl--do-arglist >>> ((eq keys t) nil) ;No &keys at all >>> ((null keys) ;A &key but no actual keys s= pecified. >>> (push `(when ,restarg >>> - (error ,(format "Keyword argument %%S not one of = %S" >>> - keys) >>> + (error ,(format "Keyword argument %%S not one of = %s" >>> + ;; Escape % in slot names. >>> + (string-replace >>> + "%" "%%" (format "%S" keys))) >> >> The correct fix is not to interpolate a user-supplied argument in the >> format string that is passed to error. >> > > I am not sure I well understood your remark. > But I realized that when keys is null there is no need to escape % charac= ters. > Here is a revised patch: The patch looks fine, thanks, but I am not sure about the first part -- why did you reword the message instead of just dealing with the escaping issue? I'm not saying it's wrong but it needs a separate justification than just dealing with the % problem. --=20 Sean Whitton
bug-gnu-emacs@HIDDEN:bug#81367; Package emacs.
Full text available.
Received: (at 81367) by debbugs.gnu.org; 6 Jul 2026 14:29:40 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jul 06 10:29:39 2026
Received: from localhost ([127.0.0.1]:54614 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1wgkKG-0005Zk-4M
for submit <at> debbugs.gnu.org; Mon, 06 Jul 2026 10:29:39 -0400
Received: from smtp-80.smtpout.orange.fr ([80.12.242.80]:46763
helo=smtp.smtpout.orange.fr)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <da_vid@HIDDEN>) id 1wgkK9-0005Yt-OA
for 81367 <at> debbugs.gnu.org; Mon, 06 Jul 2026 10:29:32 -0400
Received: from [192.168.1.21] ([90.38.183.166]) by smtp.orange.fr with ESMTPSA
id gkK7wBXR5Kl4DgkK7wKcoC; Mon, 06 Jul 2026 16:29:27 +0200
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr;
s=t20230301; t=1783348168;
bh=rPlzfIQYW2RNEj0PaWK97yf132oRLjMUH47kggB05Bg=;
h=Message-ID:Date:MIME-Version:Subject:To:From;
b=JWU2WxRDJOqFZ1k6j7T1B4IJVn7Fn6n2SLcN4mjxcciF/jSyjgwdCnv8whxPOLn/S
fz17bTvT8t9ecS1zq+gs4PnppSWXAIFskEX55BJPxbEyg5ehuTqEp4jcO/+iZoIVLe
xbUPUzdfm1N/Z4MAA5iY7b2QL5ATnsif1rIJ+VVeF/NnuSoHihBJlqiNLroGdXLktl
DSg+WKsbCXPuRZP+DeQmVX4017wUmNVq8gsOWPfsOxNDz0z0abz1olADxs30J7jQNb
IKd3+MnZpQl0meSi9f2HEJ9mj5e1qPaUVy7H3wg7z+TzSaqmGHvH2X+B4KJsZpiDjy
nppeqguPqwyNA==
X-ME-Helo: [192.168.1.21]
X-ME-Auth: ZGFfdmlkQG9yYW5nZS5mcg==
X-ME-Date: Mon, 06 Jul 2026 16:29:28 +0200
X-ME-IP: 90.38.183.166
Message-ID: <8b4314fe-4e98-4ebd-9101-b51c09f59f97@HIDDEN>
Date: Mon, 6 Jul 2026 16:29:26 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: bug#81367: 32.0.50; `cl-defstruct' fails with % in slot names
To: Andreas Schwab <schwab@HIDDEN>,
David Ponce via Bug reports for GNU "Emacs," the Swiss army knife of text
editors <bug-gnu-emacs@HIDDEN>
References: <3b85cff2-1335-406d-84a0-22294f5edb4f@HIDDEN>
<mvm5x2so02x.fsf@HIDDEN>
Content-Language: fr
From: David Ponce <da_vid@HIDDEN>
In-Reply-To: <mvm5x2so02x.fsf@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 81367
Cc: 81367 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Le 2026-07-06 à 12:59, Andreas Schwab a écrit :
> On Jul 06 2026, David Ponce via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote:
>
>> diff --git a/lisp/emacs-lisp/cl-macs.el b/lisp/emacs-lisp/cl-macs.el
>> index 9fa2a2b7cf0..0225c90627b 100644
>> --- a/lisp/emacs-lisp/cl-macs.el
>> +++ b/lisp/emacs-lisp/cl-macs.el
>> @@ -677,8 +677,10 @@ cl--do-arglist
>> ((eq keys t) nil) ;No &keys at all
>> ((null keys) ;A &key but no actual keys specified.
>> (push `(when ,restarg
>> - (error ,(format "Keyword argument %%S not one of %S"
>> - keys)
>> + (error ,(format "Keyword argument %%S not one of %s"
>> + ;; Escape % in slot names.
>> + (string-replace
>> + "%" "%%" (format "%S" keys)))
>
> The correct fix is not to interpolate a user-supplied argument in the
> format string that is passed to error.
>
I am not sure I well understood your remark.
But I realized that when keys is null there is no need to escape % characters.
Here is a revised patch:
diff --git a/lisp/emacs-lisp/cl-macs.el b/lisp/emacs-lisp/cl-macs.el
index 9fa2a2b7cf0..7cc4a0e4921 100644
--- a/lisp/emacs-lisp/cl-macs.el
+++ b/lisp/emacs-lisp/cl-macs.el
@@ -677,8 +677,7 @@ cl--do-arglist
((eq keys t) nil) ;No &keys at all
((null keys) ;A &key but no actual keys specified.
(push `(when ,restarg
- (error ,(format "Keyword argument %%S not one of %S"
- keys)
+ (error "No keyword argument is defined, %S is invalid"
(car ,restarg)))
cl--bind-forms))
(t
@@ -694,8 +693,10 @@ cl--do-arglist
(setq ,var nil))
(t
(error
- ,(format "Keyword argument %%S not one of %S"
- keys)
+ ,(format "Keyword argument %%S not one of %s"
+ ;; Escape % in slot names.
+ (string-replace
+ "%" "%%" (format "%S" keys)))
(car ,var)))))))
(push `(let ((,var ,restarg)) ,check) cl--bind-forms)))))
(cl--do-&aux args)
@@ -3293,8 +3294,9 @@ cl-defstruct
;; the parent's accessor?
(push `(define-inline ,accessor (x)
,(let ((long-docstring
- (format "Access slot \"%s\" of `%s' struct X."
- slot name)))
+ (internal--format-docstring-line
+ "Access slot \"%s\" of `%s' struct X."
+ slot name)))
(concat
;; NB. This will produce incorrect results
;; in some cases, as our coding conventions
@@ -3315,7 +3317,7 @@ cl-defstruct
"\n"
(internal--format-docstring-line
"Struct X is a `%s'." name))
- (internal--format-docstring-line long-docstring))
+ long-docstring)
(if doc (concat "\n" doc) "")
"\n"
(format "\n\n(fn %s X)" accessor)))
bug-gnu-emacs@HIDDEN:bug#81367; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 6 Jul 2026 14:29:51 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jul 06 10:29:51 2026
Received: from localhost ([127.0.0.1]:54617 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1wgkKS-0005az-Ed
for submit <at> debbugs.gnu.org; Mon, 06 Jul 2026 10:29:50 -0400
Received: from lists1p.gnu.org ([2001:470:142::17]:34754)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <da_vid@HIDDEN>) id 1wgkKM-0005ZZ-EC
for submit <at> debbugs.gnu.org; Mon, 06 Jul 2026 10:29:46 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <da_vid@HIDDEN>) id 1wgkKC-0002Ye-I5
for bug-gnu-emacs@HIDDEN; Mon, 06 Jul 2026 10:29:33 -0400
Received: from smtp-79.smtpout.orange.fr ([80.12.242.79]
helo=smtp.smtpout.orange.fr)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <da_vid@HIDDEN>) id 1wgkKA-00010t-Qe
for bug-gnu-emacs@HIDDEN; Mon, 06 Jul 2026 10:29:32 -0400
Received: from [192.168.1.21] ([90.38.183.166]) by smtp.orange.fr with ESMTPSA
id gkK7wBXR5Kl4DgkK7wKcoC; Mon, 06 Jul 2026 16:29:27 +0200
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr;
s=t20230301; t=1783348168;
bh=rPlzfIQYW2RNEj0PaWK97yf132oRLjMUH47kggB05Bg=;
h=Message-ID:Date:MIME-Version:Subject:To:From;
b=JWU2WxRDJOqFZ1k6j7T1B4IJVn7Fn6n2SLcN4mjxcciF/jSyjgwdCnv8whxPOLn/S
fz17bTvT8t9ecS1zq+gs4PnppSWXAIFskEX55BJPxbEyg5ehuTqEp4jcO/+iZoIVLe
xbUPUzdfm1N/Z4MAA5iY7b2QL5ATnsif1rIJ+VVeF/NnuSoHihBJlqiNLroGdXLktl
DSg+WKsbCXPuRZP+DeQmVX4017wUmNVq8gsOWPfsOxNDz0z0abz1olADxs30J7jQNb
IKd3+MnZpQl0meSi9f2HEJ9mj5e1qPaUVy7H3wg7z+TzSaqmGHvH2X+B4KJsZpiDjy
nppeqguPqwyNA==
X-ME-Helo: [192.168.1.21]
X-ME-Auth: ZGFfdmlkQG9yYW5nZS5mcg==
X-ME-Date: Mon, 06 Jul 2026 16:29:28 +0200
X-ME-IP: 90.38.183.166
Message-ID: <8b4314fe-4e98-4ebd-9101-b51c09f59f97@HIDDEN>
Date: Mon, 6 Jul 2026 16:29:26 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: bug#81367: 32.0.50; `cl-defstruct' fails with % in slot names
To: Andreas Schwab <schwab@HIDDEN>,
David Ponce via Bug reports for GNU "Emacs," the Swiss army knife of text
editors <bug-gnu-emacs@HIDDEN>
References: <3b85cff2-1335-406d-84a0-22294f5edb4f@HIDDEN>
<mvm5x2so02x.fsf@HIDDEN>
Content-Language: fr
From: David Ponce <da_vid@HIDDEN>
In-Reply-To: <mvm5x2so02x.fsf@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=80.12.242.79; envelope-from=da_vid@HIDDEN;
helo=smtp.smtpout.orange.fr
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,
SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
Cc: 81367 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
Le 2026-07-06 à 12:59, Andreas Schwab a écrit :
> On Jul 06 2026, David Ponce via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote:
>
>> diff --git a/lisp/emacs-lisp/cl-macs.el b/lisp/emacs-lisp/cl-macs.el
>> index 9fa2a2b7cf0..0225c90627b 100644
>> --- a/lisp/emacs-lisp/cl-macs.el
>> +++ b/lisp/emacs-lisp/cl-macs.el
>> @@ -677,8 +677,10 @@ cl--do-arglist
>> ((eq keys t) nil) ;No &keys at all
>> ((null keys) ;A &key but no actual keys specified.
>> (push `(when ,restarg
>> - (error ,(format "Keyword argument %%S not one of %S"
>> - keys)
>> + (error ,(format "Keyword argument %%S not one of %s"
>> + ;; Escape % in slot names.
>> + (string-replace
>> + "%" "%%" (format "%S" keys)))
>
> The correct fix is not to interpolate a user-supplied argument in the
> format string that is passed to error.
>
I am not sure I well understood your remark.
But I realized that when keys is null there is no need to escape % characters.
Here is a revised patch:
diff --git a/lisp/emacs-lisp/cl-macs.el b/lisp/emacs-lisp/cl-macs.el
index 9fa2a2b7cf0..7cc4a0e4921 100644
--- a/lisp/emacs-lisp/cl-macs.el
+++ b/lisp/emacs-lisp/cl-macs.el
@@ -677,8 +677,7 @@ cl--do-arglist
((eq keys t) nil) ;No &keys at all
((null keys) ;A &key but no actual keys specified.
(push `(when ,restarg
- (error ,(format "Keyword argument %%S not one of %S"
- keys)
+ (error "No keyword argument is defined, %S is invalid"
(car ,restarg)))
cl--bind-forms))
(t
@@ -694,8 +693,10 @@ cl--do-arglist
(setq ,var nil))
(t
(error
- ,(format "Keyword argument %%S not one of %S"
- keys)
+ ,(format "Keyword argument %%S not one of %s"
+ ;; Escape % in slot names.
+ (string-replace
+ "%" "%%" (format "%S" keys)))
(car ,var)))))))
(push `(let ((,var ,restarg)) ,check) cl--bind-forms)))))
(cl--do-&aux args)
@@ -3293,8 +3294,9 @@ cl-defstruct
;; the parent's accessor?
(push `(define-inline ,accessor (x)
,(let ((long-docstring
- (format "Access slot \"%s\" of `%s' struct X."
- slot name)))
+ (internal--format-docstring-line
+ "Access slot \"%s\" of `%s' struct X."
+ slot name)))
(concat
;; NB. This will produce incorrect results
;; in some cases, as our coding conventions
@@ -3315,7 +3317,7 @@ cl-defstruct
"\n"
(internal--format-docstring-line
"Struct X is a `%s'." name))
- (internal--format-docstring-line long-docstring))
+ long-docstring)
(if doc (concat "\n" doc) "")
"\n"
(format "\n\n(fn %s X)" accessor)))
bug-gnu-emacs@HIDDEN:bug#81367; Package emacs.
Full text available.Received: (at 81367) by debbugs.gnu.org; 6 Jul 2026 10:59:42 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jul 06 06:59:42 2026 Received: from localhost ([127.0.0.1]:52134 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1wgh38-0005oj-3k for submit <at> debbugs.gnu.org; Mon, 06 Jul 2026 06:59:42 -0400 Received: from smtp-out1.suse.de ([2a07:de40:b251:101:10:150:64:1]:50638) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <schwab@HIDDEN>) id 1wgh36-0005oJ-3B for 81367 <at> debbugs.gnu.org; Mon, 06 Jul 2026 06:59:40 -0400 Received: from hawking.suse.de (unknown [10.168.4.11]) by smtp-out1.suse.de (Postfix) with ESMTP id 27D2473BBE; Mon, 6 Jul 2026 10:59:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1783335574; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0eO0V7G0tx5EQqoQ75T2WT2msASnXcFgUSUJZFIyHik=; b=efgnhtrlYx7J4OgUkxFHMf+l5ZBguKjooJrjmrp0BCoqFGzotO+brGYDylrG3B3rOeAEtE g+Qwddsk7Nu01r6LN0luiZ3imlA3HSdSGn8S2HQbdr8eMlDEP8uGpH89nZwfoal2q414RW CvxrrKWdK9ETy9VIPlTzeRbX9eXDPZo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1783335574; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0eO0V7G0tx5EQqoQ75T2WT2msASnXcFgUSUJZFIyHik=; b=oCRDj5+GVH8dfqGVUUb57/g7lCoHYonh8lVWbdAbqKCQHxc+XNVK2nZ2tHsxbvYzFYFgQ9 uE48nkHwl8gpllBw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1783335574; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0eO0V7G0tx5EQqoQ75T2WT2msASnXcFgUSUJZFIyHik=; b=efgnhtrlYx7J4OgUkxFHMf+l5ZBguKjooJrjmrp0BCoqFGzotO+brGYDylrG3B3rOeAEtE g+Qwddsk7Nu01r6LN0luiZ3imlA3HSdSGn8S2HQbdr8eMlDEP8uGpH89nZwfoal2q414RW CvxrrKWdK9ETy9VIPlTzeRbX9eXDPZo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1783335574; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0eO0V7G0tx5EQqoQ75T2WT2msASnXcFgUSUJZFIyHik=; b=oCRDj5+GVH8dfqGVUUb57/g7lCoHYonh8lVWbdAbqKCQHxc+XNVK2nZ2tHsxbvYzFYFgQ9 uE48nkHwl8gpllBw== Received: by hawking.suse.de (Postfix, from userid 17005) id 1714D4AA2B9; Mon, 6 Jul 2026 12:59:34 +0200 (CEST) From: Andreas Schwab <schwab@HIDDEN> To: David Ponce via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> Subject: Re: bug#81367: 32.0.50; `cl-defstruct' fails with % in slot names In-Reply-To: <3b85cff2-1335-406d-84a0-22294f5edb4f@HIDDEN> (David Ponce via's message of "Mon, 6 Jul 2026 12:23:26 +0200") References: <3b85cff2-1335-406d-84a0-22294f5edb4f@HIDDEN> Date: Mon, 06 Jul 2026 12:59:34 +0200 Message-ID: <mvm5x2so02x.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Flag: NO X-Spam-Score: -4.20 X-Spamd-Result: default: False [-4.20 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.993]; MIME_GOOD(-0.10)[text/plain]; RCVD_NO_TLS_LAST(0.10)[]; RCVD_COUNT_ONE(0.00)[1]; FREEMAIL_ENVRCPT(0.00)[orange.fr]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MID_RHS_MATCH_FROM(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FREEMAIL_CC(0.00)[debbugs.gnu.org,orange.fr]; RCPT_COUNT_THREE(0.00)[3]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:mid] X-Spam-Level: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 81367 Cc: David Ponce <da_vid@HIDDEN>, 81367 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Jul 06 2026, David Ponce via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote: > diff --git a/lisp/emacs-lisp/cl-macs.el b/lisp/emacs-lisp/cl-macs.el > index 9fa2a2b7cf0..0225c90627b 100644 > --- a/lisp/emacs-lisp/cl-macs.el > +++ b/lisp/emacs-lisp/cl-macs.el > @@ -677,8 +677,10 @@ cl--do-arglist > ((eq keys t) nil) ;No &keys at all > ((null keys) ;A &key but no actual keys specified. > (push `(when ,restarg > - (error ,(format "Keyword argument %%S not one of %S" > - keys) > + (error ,(format "Keyword argument %%S not one of %s" > + ;; Escape % in slot names. > + (string-replace > + "%" "%%" (format "%S" keys))) The correct fix is not to interpolate a user-supplied argument in the format string that is passed to error. -- Andreas Schwab, SUSE Labs, schwab@HIDDEN GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."
bug-gnu-emacs@HIDDEN:bug#81367; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 6 Jul 2026 10:59:56 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jul 06 06:59:56 2026 Received: from localhost ([127.0.0.1]:52138 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1wgh3M-0005pz-Dw for submit <at> debbugs.gnu.org; Mon, 06 Jul 2026 06:59:56 -0400 Received: from lists1p.gnu.org ([2001:470:142::17]:48902) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <schwab@HIDDEN>) id 1wgh3K-0005pC-Iw for submit <at> debbugs.gnu.org; Mon, 06 Jul 2026 06:59:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <schwab@HIDDEN>) id 1wgh35-0004Pj-Qo for bug-gnu-emacs@HIDDEN; Mon, 06 Jul 2026 06:59:40 -0400 Received: from smtp-out1.suse.de ([2a07:de40:b251:101:10:150:64:1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <schwab@HIDDEN>) id 1wgh34-0000EO-5l for bug-gnu-emacs@HIDDEN; Mon, 06 Jul 2026 06:59:39 -0400 Received: from hawking.suse.de (unknown [10.168.4.11]) by smtp-out1.suse.de (Postfix) with ESMTP id 27D2473BBE; Mon, 6 Jul 2026 10:59:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1783335574; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0eO0V7G0tx5EQqoQ75T2WT2msASnXcFgUSUJZFIyHik=; b=efgnhtrlYx7J4OgUkxFHMf+l5ZBguKjooJrjmrp0BCoqFGzotO+brGYDylrG3B3rOeAEtE g+Qwddsk7Nu01r6LN0luiZ3imlA3HSdSGn8S2HQbdr8eMlDEP8uGpH89nZwfoal2q414RW CvxrrKWdK9ETy9VIPlTzeRbX9eXDPZo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1783335574; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0eO0V7G0tx5EQqoQ75T2WT2msASnXcFgUSUJZFIyHik=; b=oCRDj5+GVH8dfqGVUUb57/g7lCoHYonh8lVWbdAbqKCQHxc+XNVK2nZ2tHsxbvYzFYFgQ9 uE48nkHwl8gpllBw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1783335574; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0eO0V7G0tx5EQqoQ75T2WT2msASnXcFgUSUJZFIyHik=; b=efgnhtrlYx7J4OgUkxFHMf+l5ZBguKjooJrjmrp0BCoqFGzotO+brGYDylrG3B3rOeAEtE g+Qwddsk7Nu01r6LN0luiZ3imlA3HSdSGn8S2HQbdr8eMlDEP8uGpH89nZwfoal2q414RW CvxrrKWdK9ETy9VIPlTzeRbX9eXDPZo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1783335574; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0eO0V7G0tx5EQqoQ75T2WT2msASnXcFgUSUJZFIyHik=; b=oCRDj5+GVH8dfqGVUUb57/g7lCoHYonh8lVWbdAbqKCQHxc+XNVK2nZ2tHsxbvYzFYFgQ9 uE48nkHwl8gpllBw== Received: by hawking.suse.de (Postfix, from userid 17005) id 1714D4AA2B9; Mon, 6 Jul 2026 12:59:34 +0200 (CEST) From: Andreas Schwab <schwab@HIDDEN> To: David Ponce via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> Subject: Re: bug#81367: 32.0.50; `cl-defstruct' fails with % in slot names In-Reply-To: <3b85cff2-1335-406d-84a0-22294f5edb4f@HIDDEN> (David Ponce via's message of "Mon, 6 Jul 2026 12:23:26 +0200") References: <3b85cff2-1335-406d-84a0-22294f5edb4f@HIDDEN> Date: Mon, 06 Jul 2026 12:59:34 +0200 Message-ID: <mvm5x2so02x.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Flag: NO X-Spam-Score: -4.20 X-Spamd-Result: default: False [-4.20 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.993]; MIME_GOOD(-0.10)[text/plain]; RCVD_NO_TLS_LAST(0.10)[]; RCVD_COUNT_ONE(0.00)[1]; FREEMAIL_ENVRCPT(0.00)[orange.fr]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MID_RHS_MATCH_FROM(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FREEMAIL_CC(0.00)[debbugs.gnu.org,orange.fr]; RCPT_COUNT_THREE(0.00)[3]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:mid] X-Spam-Level: Received-SPF: pass client-ip=2a07:de40:b251:101:10:150:64:1; envelope-from=schwab@HIDDEN; helo=smtp-out1.suse.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: David Ponce <da_vid@HIDDEN>, 81367 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) On Jul 06 2026, David Ponce via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote: > diff --git a/lisp/emacs-lisp/cl-macs.el b/lisp/emacs-lisp/cl-macs.el > index 9fa2a2b7cf0..0225c90627b 100644 > --- a/lisp/emacs-lisp/cl-macs.el > +++ b/lisp/emacs-lisp/cl-macs.el > @@ -677,8 +677,10 @@ cl--do-arglist > ((eq keys t) nil) ;No &keys at all > ((null keys) ;A &key but no actual keys specified. > (push `(when ,restarg > - (error ,(format "Keyword argument %%S not one of %S" > - keys) > + (error ,(format "Keyword argument %%S not one of %s" > + ;; Escape % in slot names. > + (string-replace > + "%" "%%" (format "%S" keys))) The correct fix is not to interpolate a user-supplied argument in the format string that is passed to error. -- Andreas Schwab, SUSE Labs, schwab@HIDDEN GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."
bug-gnu-emacs@HIDDEN:bug#81367; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 6 Jul 2026 10:23:48 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jul 06 06:23:47 2026 Received: from localhost ([127.0.0.1]:51875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1wggUN-0003M4-82 for submit <at> debbugs.gnu.org; Mon, 06 Jul 2026 06:23:47 -0400 Received: from lists1p.gnu.org ([2001:470:142::17]:45312) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <da_vid@HIDDEN>) id 1wggUJ-0003La-Mq for submit <at> debbugs.gnu.org; Mon, 06 Jul 2026 06:23:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <da_vid@HIDDEN>) id 1wggUC-0003Uc-KK for bug-gnu-emacs@HIDDEN; Mon, 06 Jul 2026 06:23:37 -0400 Received: from smtp-25.smtpout.orange.fr ([80.12.242.25] helo=smtp.smtpout.orange.fr) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <da_vid@HIDDEN>) id 1wggU6-0007eZ-HP for bug-gnu-emacs@HIDDEN; Mon, 06 Jul 2026 06:23:36 -0400 Received: from [IPV6:2a01:cb15:8909:5500:8f09:52af:b5c8:9dbc] ([IPv6:2a01:cb15:8909:5500:8f09:52af:b5c8:9dbc]) by smtp.orange.fr with ESMTPSA id ggU2wUxWSZe4uggU2w28dR; Mon, 06 Jul 2026 12:23:27 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1783333407; bh=6w9PPrtblcAp8+EUDViTVeEAipttV4wagio6/ThgH/o=; h=Message-ID:Date:MIME-Version:From:Subject:To; b=AfWD6HuNZtdOgmDbsmxd/TZTe9yD3M21c+Zn7++jjykFXupg6e5LWjm8WKzVpZN5o 4EvLB8qpO6MKIMbtcKinmq3Fh59Q8pOAbDoU1xZVuBRhjeyL2MyAkr/I1cA06fmVBd Ha1q0s/aCACfpaB7lEfI04qE6oNWc3b4DV6X9imfMog/f5Wrhz77RdR74odtLOZe8k Ni0bbBPfBQWBfc+lFDe7rphi01pFEzsEO8yClFKxGJtdRHtK1EqRSOyovNZXZGrI8u 2XCovbjTIeat/6NeUA5bpanZ5FgRYYZ8pPicPNcjZEQc7urDP4NyT4KvXJbMU3WOkW D8C/GMnKLXREQ== X-ME-Helo: [IPV6:2a01:cb15:8909:5500:8f09:52af:b5c8:9dbc] X-ME-Auth: ZGFfdmlkQG9yYW5nZS5mcg== X-ME-Date: Mon, 06 Jul 2026 12:23:27 +0200 X-ME-IP: 2a01:cb15:8909:5500:8f09:52af:b5c8:9dbc Message-ID: <3b85cff2-1335-406d-84a0-22294f5edb4f@HIDDEN> Date: Mon, 6 Jul 2026 12:23:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: David Ponce <da_vid@HIDDEN> Subject: 32.0.50; `cl-defstruct' fails with % in slot names To: bug-gnu-emacs@HIDDEN Content-Language: fr Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 Received-SPF: pass client-ip=80.12.242.25; envelope-from=da_vid@HIDDEN; helo=smtp.smtpout.orange.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) SGVsbG8sDQoNCldoaWxlIGNvbnZlcnRpbmcgYSBgZGVmY2xhc3MnIGZvcm0gdG8gYGNsLWRl ZnN0cnVjdCcsIEkgZW5jb3VudGVyZWQgYW4NCmVycm9yIChzZWUgdGhlIHNhbXBsZSBiYWNr dHJhY2UgYmVsb3cpIGJlY2F1c2UgSSB1c2VkIHRoZSBjb252ZW50aW9uDQp0byBwcmVmaXgg c2xvdCBuYW1lcyB3aXRoIGEgJyUnIGNoYXJhY3RlciB0byBlYXNpbHkgaWRlbnRpZnkgc2xv dHMgZm9yDQppbnRlcm5hbCB1c2U6DQoNCkRlYnVnZ2VyIGVudGVyZWQtLUxpc3AgZXJyb3I6 IChlcnJvciAiTm90IGVub3VnaCBhcmd1bWVudHMgZm9yIGZvcm1hdCBzdHJpbmciKQ0KICAg IGZvcm1hdCgiQWNjZXNzIHNsb3QgXCIlc2xvdDFcIiBvZiBgbXktc3RydWN0JyBzdHJ1Y3Qg WC4iKQ0KICAgIGFwcGx5KGZvcm1hdCAiQWNjZXNzIHNsb3QgXCIlc2xvdDFcIiBvZiBgbXkt c3RydWN0JyBzdHJ1Y3QgWC4iIG5pbCkNCiAgICBpbnRlcm5hbC0tZm9ybWF0LWRvY3N0cmlu Zy1saW5lKCJBY2Nlc3Mgc2xvdCBcIiVzbG90MVwiIG9mIGBteS1zdHJ1Y3QnIHN0cnVjdCBY LiIpDQogICAgI2YoY29tcGlsZWQtZnVuY3Rpb24gKG5hbWUgJm9wdGlvbmFsIGRvY3N0cmlu ZyAmcmVzdCBzbG90cykgIkRlZmluZSBhIHN0cnVjdCB0eXBlLlxuVGhpcyBtYWNybyBkZWZp bmVzIGEgbmV3IGRhdGEgdHlwZSBjYWxsZWQgTkFNRSB0aGF0IHN0b3JlcyBkYXRhXG5pbiBT TE9Ucy4gIEl0IGRlZmluZXMgYSBgbWFrZS1OQU1FJyBjb25zdHJ1Y3RvciwgYSBgY29weS1O QU1FJ1xuY29waWVyLCBhIGBOQU1FLXAnIHByZWRpY2F0ZSwgYW5kIHNsb3QgYWNjZXNzb3Jz IG5hbWVkIGBOQU1FLVNMT1QnLlxuWW91IGNhbiB1c2UgdGhlIGFjY2Vzc29ycyB0byBzZXQg dGhlIGNvcnJlc3BvbmRpbmcgc2xvdHMsIHZpYSBgc2V0ZicuXG5cbk5BTUUgaXMgdXN1YWxs eSBhIHN5bWJvbCwgYnV0IG1heSBpbnN0ZWFkIHRha2UgdGhlIGZvcm0gKE5BTUVcbk9QVElP TlMuLi4pLCB3aGVyZSBlYWNoIE9QVElPTiBpcyBlaXRoZXIgYSBzaW5nbGUga2V5d29yZFxu b3IgKEtFWVdPUkQgVkFMVUUpIHdoZXJlIEtFWVdPUkQgY2FuIGJlIG9uZSBvZiBgOmNvbmMt bmFtZScsXG5gOmNvbnN0cnVjdG9yJywgYDpjb3BpZXInLCBgOnByZWRpY2F0ZScsIGA6dHlw ZScsIGA6bmFtZWQnLFxuYDppbml0aWFsLW9mZnNldCcsIGA6cHJpbnQtZnVuY3Rpb24nLCBg Om5vaW5saW5lJywgb3IgYDppbmNsdWRlJy5cblNlZSBJbmZvIG5vZGUgYChjbClTdHJ1Y3R1 cmVzJyBmb3IgdGhlIGRlc2NyaXB0aW9uIG9mIHRoZVxub3B0aW9ucy5cblxuVGhlIGZpcnN0 IGVsZW1lbnQgaW4gU0xPVFMgY2FuIGJlIGEgZG9jIHN0cmluZy5cblxuVGhlIHJlc3Qgb2Yg dGhlIGVsZW1lbnRzIGluIFNMT1RTIGlzIGEgbGlzdCBvZiBTTE9UIGVsZW1lbnRzLFxuZWFj aCBvZiB3aGljaCBzaG91bGQgZWl0aGVyIGJlIGEgc3ltYm9sLCBvciB0YWtlIHRoZSBmb3Jt IChTTkFNRVxuU0RFRkFVTFQgU09QVElPTlMuLi4pLCB3aGVyZSBTREVGQVVMVCBpcyB0aGUg ZGVmYXVsdCB2YWx1ZSBvZlxudGhhdCBzbG90IGFuZCBTT1BUSU9OUyBhcmUga2V5d29yZC12 YWx1ZSBwYWlycyBmb3IgdGhhdCBzbG90LlxuXG5TdXBwb3J0ZWQga2V5d29yZHMgZm9yIHNs b3RzIGFyZTpcbi0gYDpyZWFkLW9ubHknOiBJZiB0aGlzIGhhcyBhIG5vbi1uaWwgdmFsdWUs IHRoYXQgc2xvdCBjYW5ub3QgYmUgc2V0IHZpYSBgc2V0ZicuXG4tIGA6ZG9jdW1lbnRhdGlv bic6IHRoaXMgaXMgYSBkb2NzdHJpbmcgZGVzY3JpYmluZyB0aGUgc2xvdC5cbi0gYDp0eXBl JzogdGhlIHR5cGUgb2YgdGhlIGZpZWxkOyBjdXJyZW50bHkgb25seSB1c2VkIGZvciBkb2N1 bWVudGF0aW9uLlxuXG5UbyBzZWUgdGhlIGRvY3VtZW50YXRpb24gZm9yIGEgZGVmaW5lZCBz dHJ1Y3QgdHlwZSwgdXNlXG5cXFtkZXNjcmliZS1zeW1ib2xdIG9yIFxcW2NsLWRlc2NyaWJl LXR5cGVdLiIgIzxieXRlY29kZSAtMHgxYmEyYjdmNjljYTE0NzFmPikobXktc3RydWN0ICJU ZXN0IHN0cnVjdHVyZS4iICglc2xvdDEpKQ0KICAgIG1hY3JvZXhwYW5kKChjbC1kZWZzdHJ1 Y3QgbXktc3RydWN0ICJUZXN0IHN0cnVjdHVyZS4iICglc2xvdDEpKSkNCg0KV1doaWxlIHRo aXMgbmFtaW5nIHdvcmtzIHdlbGwgaW4gYGRlZmNsYXNzJywgaXQgc2lnbmFscyBhbiBlcnJv ciBpbg0KYGNsLWRlZnN0cnVjdCcgYmVjYXVzZSBvZiBhIHNpZGUgZWZmZWN0IG9mIHRoZSAn JScgY2hhcmFjdGVyIHdoZW4NCnBhc3NlZCB0byBgZm9ybWF0JyAoc2VlIHRoZSBhYm92ZSBi YWNrdHJhY2UpLiAgTW9yZSBwcmVjaXNlbHksIHRoZQ0KZXJyb3Igb2NjdXJzIHdoZW4gYSBz bG90IG5hbWUgY29udGFpbnMgYSBvZGQgbnVtYmVyIG9mIG9jY3VycmVuY2VzIG9mDQp0aGUg JyUnIGNoYXJhY3Rlci4gIFdoZW4gdGhlcmUgaXMgYW4gZXZlbiBudW1iZXIgb2YgJyUnIG5v IGVycm9yIGlzDQpzaWduYWxlZCBidXQgc29tZSBnZW5lcmF0ZWQgcnVudGltZSBlcnJvciBt ZXNzYWdlcyBhcmUgbm90IGNvcnJlY3QuDQpTb21lIGV4YW1wbGVzOg0KDQo7OyBGYWlsDQoo Y2wtZGVmc3RydWN0IG15LXN0cnVjdA0KICAgICJUZXN0IHN0cnVjdHVyZS4iDQogICAgKCVz bG90MSkpDQo9PiAiTm90IGVub3VnaCBhcmd1bWVudHMgZm9yIGZvcm1hdCBzdHJpbmciDQoN Cjs7IEZhaWwNCihjbC1kZWZzdHJ1Y3QgbXktc3RydWN0DQogICAgIlRlc3Qgc3RydWN0dXJl LiINCiAgICAoc2xvdCUlJTEpKQ0KPT4gIk5vdCBlbm91Z2ggYXJndW1lbnRzIGZvciBmb3Jt YXQgc3RyaW5nIg0KDQo7OyBEb24ndCBmYWlsLCBidXQgcHJvZHVjZXMgYSB3cm9uZyBlcnJv ciBtZXNzYWdlLg0KKGNsLWRlZnN0cnVjdCBteS1zdHJ1Y3QNCiAgICAiVGVzdCBzdHJ1Y3R1 cmUuIg0KICAgIChzbG90JSUxKSkNCg0KKG1ha2UtbXktc3RydWN0IDpiYWQgInNsb3QiKQ0K PT4gIktleXdvcmQgYXJndW1lbnQgOmJhZCBub3Qgb25lIG9mICg6c2xvdCUxKSINCg0KOzsg RG9uJ3QgZmFpbCwgYnV0IHByb2R1Y2VzIGEgd3JvbmcgZXJyb3IgbWVzc2FnZS4NCihjbC1k ZWZzdHJ1Y3QgbXktc3RydWN0DQogICAgIlRlc3Qgc3RydWN0dXJlLiINCiAgICAoJSVzbG90 MSkpDQoNCihtYWtlLW15LXN0cnVjdCA6YmFkICJzbG90IikNCj0+ICJLZXl3b3JkIGFyZ3Vt ZW50IDpiYWQgbm90IG9uZSBvZiAoOiVzbG90MSkiDQoNClRoZSBiZWxvdyBwYXRjaCBmaXhl ZCB0aGUgaXNzdWUgZm9yIG1lOg0KDQoyMDI2LTA3LTA2ICBEYXZpZCBQb25jZSAgPGRhX3Zp ZEBvcmFuZ2UuZnI+DQoNCglGaXggZXJyb3IgaW4gYGNsLWRlZnN0cnVjdCcgd2hlbiBzbG90 IG5hbWVzIGNvbnRhaW4gJSBjaGFyYWN0ZXJzLg0KDQoJKiBsaXNwL2VtYWNzLWxpc3AvY2wt bWFjcy5lbCAoY2wtLWRvLWFyZ2xpc3QpOiBFc2NhcGUgJSBpbiBzbG90DQoJbmFtZXMuDQoJ KGNsLWRlZnN0cnVjdCk6IERvIG5vdCBwYXNzIGFnYWluIHRvIGBmb3JtYXQnIGFuIGFscmVh ZHkgZm9ybWF0dGVkDQoJZG9jIHN0cmluZy4NCg0KDQpkaWZmIC0tZ2l0IGEvbGlzcC9lbWFj cy1saXNwL2NsLW1hY3MuZWwgYi9saXNwL2VtYWNzLWxpc3AvY2wtbWFjcy5lbA0KaW5kZXgg OWZhMmEyYjdjZjAuLjAyMjVjOTA2MjdiIDEwMDY0NA0KLS0tIGEvbGlzcC9lbWFjcy1saXNw L2NsLW1hY3MuZWwNCisrKyBiL2xpc3AvZW1hY3MtbGlzcC9jbC1tYWNzLmVsDQpAQCAtNjc3 LDggKzY3NywxMCBAQCBjbC0tZG8tYXJnbGlzdA0KICAgICAgICAgICAgICAoKGVxIGtleXMg dCkgbmlsKSAgICAgICAgICAgIDtObyAma2V5cyBhdCBhbGwNCiAgICAgICAgICAgICAgKChu dWxsIGtleXMpICAgICAgICAgICAgICAgICA7QSAma2V5IGJ1dCBubyBhY3R1YWwga2V5cyBz cGVjaWZpZWQuDQogICAgICAgICAgICAgICAocHVzaCBgKHdoZW4gLHJlc3RhcmcNCi0gICAg ICAgICAgICAgICAgICAgICAoZXJyb3IgLChmb3JtYXQgIktleXdvcmQgYXJndW1lbnQgJSVT IG5vdCBvbmUgb2YgJVMiDQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGtleXMpDQorICAgICAgICAgICAgICAgICAgICAgKGVycm9yICwoZm9ybWF0ICJLZXl3b3Jk IGFyZ3VtZW50ICUlUyBub3Qgb25lIG9mICVzIg0KKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICA7OyBFc2NhcGUgJSBpbiBzbG90IG5hbWVzLg0KKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAoc3RyaW5nLXJlcGxhY2UNCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICIlIiAiJSUiIChmb3JtYXQgIiVTIiBrZXlz KSkpDQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGNhciAscmVzdGFyZykpKQ0K ICAgICAgICAgICAgICAgICAgICAgY2wtLWJpbmQtZm9ybXMpKQ0KICAgICAgICAgICAgICAo dA0KQEAgLTY5NCw4ICs2OTYsMTAgQEAgY2wtLWRvLWFyZ2xpc3QNCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAoc2V0cSAsdmFyIG5pbCkpDQogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAodA0KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IChlcnJvcg0KLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLChmb3JtYXQgIktl eXdvcmQgYXJndW1lbnQgJSVTIG5vdCBvbmUgb2YgJVMiDQotICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBrZXlzKQ0KKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgLChmb3JtYXQgIktleXdvcmQgYXJndW1lbnQgJSVTIG5vdCBvbmUgb2YgJXMi DQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA7OyBFc2NhcGUg JSBpbiBzbG90IG5hbWVzLg0KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgKHN0cmluZy1yZXBsYWNlDQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIiUiICIlJSIgKGZvcm1hdCAiJVMiIGtleXMpKSkNCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgKGNhciAsdmFyKSkpKSkpKQ0KICAgCSAgICAgIChw dXNoIGAobGV0ICgoLHZhciAscmVzdGFyZykpICxjaGVjaykgY2wtLWJpbmQtZm9ybXMpKSkp KQ0KICAgICAgICAgKGNsLS1kby0mYXV4IGFyZ3MpDQpAQCAtMzI5Myw4ICszMjk3LDkgQEAg Y2wtZGVmc3RydWN0DQogICAgICAgICAgICAgICAgIDs7IHRoZSBwYXJlbnQncyBhY2Nlc3Nv cj8NCiAgIAkgICAgICAocHVzaCBgKGRlZmluZS1pbmxpbmUgLGFjY2Vzc29yICh4KQ0KICAg ICAgICAgICAgICAgICAgICAgICAgICAsKGxldCAoKGxvbmctZG9jc3RyaW5nDQotICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIChmb3JtYXQgIkFjY2VzcyBzbG90IFwiJXNcIiBv ZiBgJXMnIHN0cnVjdCBYLiINCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBzbG90IG5hbWUpKSkNCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGlu dGVybmFsLS1mb3JtYXQtZG9jc3RyaW5nLWxpbmUNCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICJBY2Nlc3Mgc2xvdCBcIiVzXCIgb2YgYCVzJyBzdHJ1Y3QgWC4iDQorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzbG90IG5hbWUpKSkNCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgKGNvbmNhdA0KICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgOzsgTkIuICBUaGlzIHdpbGwgcHJvZHVjZSBpbmNvcnJlY3QgcmVzdWx0cw0KICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgOzsgaW4gc29tZSBjYXNlcywgYXMgb3VyIGNvZGlu ZyBjb252ZW50aW9ucw0KQEAgLTMzMTUsNyArMzMyMCw3IEBAIGNsLWRlZnN0cnVjdA0KICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiXG4iDQogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIChpbnRlcm5hbC0tZm9ybWF0LWRvY3N0cmluZy1saW5lDQog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiU3RydWN0IFggaXMgYSBgJXMn LiIgbmFtZSkpDQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoaW50ZXJuYWwtLWZv cm1hdC1kb2NzdHJpbmctbGluZSBsb25nLWRvY3N0cmluZykpDQorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBsb25nLWRvY3N0cmluZykNCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIChpZiBkb2MgKGNvbmNhdCAiXG4iIGRvYykgIiIpDQogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAiXG4iDQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoZm9y bWF0ICJcblxuKGZuICVzIFgpIiBhY2Nlc3NvcikpKQ0KDQpUaGFua3MNCg0KSW4gR05VIEVt YWNzIDMyLjAuNTAgKGJ1aWxkIDEsIHg4Nl82NC1wYy1saW51eC1nbnUsIEdUSysgVmVyc2lv bg0KICAgMy4yNC41MiwgY2Fpcm8gdmVyc2lvbiAxLjE4LjQpIG9mIDIwMjYtMDctMDYNClJl cG9zaXRvcnkgcmV2aXNpb246IGIzMTk1NDI4MzU1NmE4ZTlmZGMwMDgxZTgzZGViM2NkY2Zl OTkyY2INClJlcG9zaXRvcnkgYnJhbmNoOiBtYXN0ZXINCldpbmRvd2luZyBzeXN0ZW0gZGlz dHJpYnV0b3IgJ1RoZSBYLk9yZyBGb3VuZGF0aW9uJywgdmVyc2lvbiAxMS4wLjEyMTAxMDIz DQpTeXN0ZW0gRGVzY3JpcHRpb246IEZlZG9yYSBMaW51eCA0NCAoS0RFIFBsYXNtYSBEZXNr dG9wIEVkaXRpb24pDQoNCkNvbmZpZ3VyZWQgdXNpbmc6DQogICAnY29uZmlndXJlIC1xIC0t d2l0aC1uYXRpdmUtY29tcGlsYXRpb249bm8NCiAgIC0td2l0aC10cmVlLXNpdHRlcj1ubyAt LXdpdGgteCAtLXdpdGgteC10b29sa2l0PWd0azMgLS13aXRoLWNhaXJvDQogICAtLXdpdGhv dXQteGZ0IC0td2l0aC1oYXJmYnV6eiAtLXdpdGgtZ251dGxzIC0td2l0aC1nc2V0dGluZ3MN CiAgIC0td2l0aC1tb2R1bGVzIC0td2l0aC10aHJlYWRzIC0td2l0aC1saWJnbXAgLS13aXRo LXhtbDIgLS13aXRoLXpsaWINCiAgIC0td2l0aC1maWxlLW5vdGlmaWNhdGlvbj1pbm90aWZ5 IC0td2l0aG91dC1saWJvdGYgLS13aXRob3V0LXhpbQ0KICAgLS13aXRob3V0LWdwbQ0K
David Ponce <da_vid@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#81367; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.