Received: (at 81974) by debbugs.gnu.org; 5 Oct 2026 11:19:01 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Oct 05 07:19:01 2026 Received: from localhost ([127.0.0.1]:35127 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1xDgij-0003rs-1D for submit <at> debbugs.gnu.org; Mon, 05 Oct 2026 07:19:01 -0400 Received: from fhigh-a4-smtp.messagingengine.com ([103.168.172.155]:56489) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <spwhitton@HIDDEN>) id 1xDgig-0003qv-EL for 81974 <at> debbugs.gnu.org; Mon, 05 Oct 2026 07:18:59 -0400 Received: from phl-compute-07.internal (phl-compute-07.internal [10.202.2.47]) by mailfhigh.phl.internal (Postfix) with ESMTP id A92541400111 for <81974 <at> debbugs.gnu.org>; Mon, 5 Oct 2026 07:18:52 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-07.internal (MEProxy); Mon, 05 Oct 2026 07:18:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1791199132; x= 1791285532; bh=cJ2ReOYD/joNu3oXyTHUFea+0FXSd4MlYQjpgkGmYyE=; b=a 5EliKh51J1kpDoC7QpJckRlhzokT3of8ZV0sx1s3rlGSzOkzuiWpDHthU0aC9N/k HClNVRg1RcT26ErpfVzW1mZ2WsBq12vznvwEhxGuK7D2JEuZNv/KgrQp3U7NBFJF lLaDO7lU66drqTx1zFTQk+NMfx6ofWxoUpeQUZdIAEo0ob3rpyGSPbiuvkthAjob K+rb8qxztS7xG6M0sCTGqmYkI24RBSkYjxeunE4b5zXmfPmD1rbyVeJQ3Xtba8aQ V+wGL5VJEtg52LlWlB62/TzlL798gBApdpzgZE52FwYC3p/GrhJhnmMrk5vAXn9M RMTGNJaxz4OjVJH2nsp6w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1791199132; x=1791285532; bh=cJ2ReOYD/joNu3oXyTHUFea+0FXSd4MlYQj pgkGmYyE=; b=ABv8N1LRLi/7BpuuOp/qiWsu8kbZzpL6nUdN2LqAiKT0bDltICb fNhSVsMMD0Txwih8Fk7abac8RABSbQD09Czbz11382YktJNvhG9PbGyZNGagxdpR Qg36zQzsmuqMVobzhhMgi1ZgE7g1QnhZYfLZ5cZefH5L9YWLip5vK+hI9FGHb1gR Xl8645CxRsEPn8GsMH8fSM9RAjZtxX0Rp1cFqhAHIZ0g+aswIZycCwgjOb4/OC6r I7xhbuj8PpUcmzGEs3nWob7MvG+8HEAzd4elgzqkGPvp8vubvQAjHMouPhjJ58Up vZhDME8v/O95xmC+DRGCHvMTeXin97sWGZA== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-06; repo=github.com/dkim2wg/interop; date=2026-09-30; sw=lmtpprox; action=sign d=spwhitton.name a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1791199132; d=spwhitton.name; mf=PHNwd2hpdHRvbkBzcHdoaXR0b24ubmFtZT4=; rt=PDgxOTc0QGRlYmJ1Z3MuZ251Lm9yZz4=; s=fm3:rsa-sha256:oxpitmuMGbjzndXxwLKfIvlQvQGuMgDdMZqyzPnDtd1PLbv DIei0QALNq3uu+pF7q5tDUyBvbzLh6fxoo8twFMhSPTYTzGgbz2geZ+8wePcjjLr Sdw5AL3YDM9RLV1xPJy9IUyugk17dttEJ978RXValNZ8taaqaMI+rYWVZG3k+ity ihwH9A9fTffIhBHD2ATa1jA+K4QuYbdgnVLB0owx34egJeekpOsbg/J04De3LheS pD0Xvh0EHpC3ObYXdusiTl2pTtddIELBfLFXyfseVul0ZjMxyaQeeCdxJC8l3ijt lbeHn/+ndVWFhcn54DNfNkvInJJUqulfKJg1jxg==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-06; repo=github.com/dkim2wg/interop; date=2026-09-30; sw=lmtpprox; action=mi-m=1; hc=11; hn=cc,content-type,date,feedback-id,from,in-reply-to,message-id, mime-version,references,subject,to; Message-Instance: m=1; h=sha256:NAJtNCtSoNWPDh6HJY3zeJDr27ip4Jere7JiBzas2kU=:H4iCxSAwS4mBT5Yf1KEDvLJdvRMRu88mDbgBIOpe2gk=; X-ME-Sender: <xms:nIfDavx5isiZP7idgJl22qd_HRLrcvQJgGeJ8Kis58w30Bx9xOv8ag> <xme:nIfDautPsHp8Rak-QJwtMkeB4ZuQ4pgR7uUCVp3283s4PKbToE0PIeJA0MujGeSrm 3jHfKcngitVMuY4OG9flEylqEGRdNyLELfjKgmjqIzdO-vKbdSPips> X-ME-Received: <xmr:nIfDamsxAVDy9GcfnKQfNXgG53MqYTH0b2pHl_GdyGHltNZainvH2c1nw9yu3KEV9DNxsZCejCggzUbVGFzPLUZYW-CvHhNxdA> X-ME-Proxy-Cause: dmFkZTEuB4deERXbId+20PUq//5SnNjwrJ76B+QTZrBWcRI9WiRplIVRtB2390/DLweM0/ uN5dHN0Cq6UOdyrHthige1GdT1S7o1qFxK+NXWMnoKV8cJpYG6+fRr7aGVKTb7qF6nRr2S KpBM8VU59Sbu8FiT3N9as22PmjKVJ0zxsXVfSW6+wgh2oy+BapKC+RX96AIataqJmyEDkx Kf2jewJ1epZIE2nV1GMY6rhUUJeD4kTENp6zqXZrOY0niAcykgt5+ahyr3CTirlSpt8npX o7qKlwnKl4h+DY9U8tg/hPTP/FRhbRGKIByBCT3P4Pux1CYEMn1QJlSvEyFu2XCcfix9b/ cBWeZ48j+qXHw139YnCcXO7DgEw6txbx9VH8zuNPdGKn/FyLuZJDXnlnhkO8k5XwO5zaHZ L5i0xvqTHx3kLy7TFTyGbZPZ/DxgY4WGel6j8ANTVu3IGeSqH8+p83g7Os5qGNbcHufRSf bFZ64MTczCNMowVN42j28cDnnuH5K9TC7QZFcXUAiNg/radW7i0Mris8/XF1fm7/OADbrq 2P8gdIagcBdPLp0WN4K2K/e1FSWrtoDGF/Se737Vzc9Xvg4dTizmQ+VbkDD+bXHJdqx3SJ x3OWXG5Aw2VBjqrTFdS77TjFTHYDIeUX1jmQ1uJp4IEl3I40BZ9ni7JksVXQ X-ME-Proxy: <xmx:nIfDajOwVmR7f-beh1vZlzATfgOXMVILaNx1DLBmMuwFa4jSMGuutw> <xmx:nIfDak1TnK5GF-4Wt_bVIOnljGLf90DoAVR-bUn-7nqGvshwRoRgGg> <xmx:nIfDavMm9GbNvAbyFMA1qybtrDzE4tCsVgvSmGmjVYvEdhR0RLOiKA> <xmx:nIfDak3xyUCLVcKN5MBej1E3lHAJ-sQ05WQVXdhy2Suay6V60LnuEA> <xmx:nIfDasOWTkSufvuuc82QH8e9GxvG4rSp7fPHzforoFC-U3NSDE2bufuv> Feedback-ID: i62564b17:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 5 Oct 2026 07:18:52 -0400 (EDT) Received: by athena.silentflame.com (Postfix, from userid 1000) id 6CCA627CC38; Mon, 05 Oct 2026 12:18:51 +0100 (BST) From: Sean Whitton <spwhitton@HIDDEN> To: Augusto Stoffel <arstoffel@HIDDEN> Subject: Re: bug#81974: 31.1; Make Comint's prompt highlighting optional In-Reply-To: <874if0bex0.fsf@HIDDEN> References: <87qzi88d0p.fsf@HIDDEN> <87bj9cxmbk.fsf@HIDDEN> <87o6dc8bdo.fsf@HIDDEN> <878q4gxhn9.fsf@HIDDEN> <87h5j485ip.fsf@HIDDEN> <87ld8cwiy9.fsf@HIDDEN> <874if0bex0.fsf@HIDDEN> Date: Mon, 05 Oct 2026 12:18:51 +0100 Message-ID: <87ld8cv1ic.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 81974 Cc: 81974 <at> debbugs.gnu.org, Robert Pluim <rpluim@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Augusto Stoffel [05/Oct 12:49pm +02] wrote: > Yes, I removed redundant/defensive goto-chars to better understand the > logic, but we can keep the defensive stuff in a final version (or say > use save-excursion). > > Really the point is whether the refactoring is desired, or, as Robert > suggested we should add a defcustom to disable prompt highlighting. (My > goal and the title of the bug is to "make comint's prompt highlighting > optional".) I think Robert's suggestion is that the defvar become a defcustom actually. > Your suggestion to customize comint-highlight-prompt face doesn't work > if you want that for some but not all comint types. Good point. -- Sean Whitton
bug-gnu-emacs@HIDDEN:bug#81974; Package emacs.
Full text available.Received: (at 81974) by debbugs.gnu.org; 5 Oct 2026 10:49:51 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Oct 05 06:49:50 2026 Received: from localhost ([127.0.0.1]:58522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1xDgGQ-00013z-2q for submit <at> debbugs.gnu.org; Mon, 05 Oct 2026 06:49:49 -0400 Received: from mail-ed2-x2b.google.com ([2a00:1450:4864:33::2b]:45680) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <arstoffel@HIDDEN>) id 1xDgGJ-00013J-A8 for 81974 <at> debbugs.gnu.org; Mon, 05 Oct 2026 06:49:43 -0400 Received: by mail-ed2-x2b.google.com with SMTP id 4fb4d7f45d1cf-6af85996a92so1143324a12.1 for <81974 <at> debbugs.gnu.org>; Mon, 05 Oct 2026 03:49:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791197373; x=1791802173; darn=debbugs.gnu.org; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=735F4ZHLZ+MJjp+lN8axs2Obn7vve+GuPykm6EkY6oE=; b=HlAbwKrhSRFA3bhfKVRX/8pdGvRR4MOnipsfQuWsPBeJLMf5M2YLKOKQXO3kR2r0/p NakwV6oOxsLRHHTyJ3Bq2VVlCD/E03uq1BLA67AznMYh7p2TxROkqhdaTKiazBUtZfbZ MB7lBcSDDE4MWgxEREgNRENCW6CQ58pv6AWU6JiuSCm1HgYwN6irOJ1cH5UbNBLj5j6o OTUmE3nFp5lM79HORDG3ULDIhU0OW7gQfTcJmAZhrqCEyxCkSlEBIUxRBvqvWoEeqaW6 kACh2F6siLMul5lGQHnpwj43KMYKKqSmKpf5OTbTpUxBVlH4Mohyz8LVDAX2Tizt2YON xtIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791197373; x=1791802173; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=735F4ZHLZ+MJjp+lN8axs2Obn7vve+GuPykm6EkY6oE=; b=aJJH/0zoBJVncC7jdY5CfmvMSA9Q5MaqWf/PPbMlhcGTJJuL6zJnwD+OoWLzsI8q5r P21LM1DuRf5BYnQCeaVR1IsKVECXDYqUVodnxDqkLvC3e2dSKeJ5zfQpQOXWQFjPtSFC y8DR3JkAK1YuDYTjFmX1YZc5/0AhErS5re/2amAg2n+n6RRCom7WX8+i76gRYF7dOeBb DzQ2a+dLj4yO1PLKhXnJLNRNcTdpp06WjMfVARq9N2vnL2NPikKnajc+fyI/79f9EI9q oVGEVEjQyJIWRRX+3Um2LFe4zcXPRresVJjruGOYk68+V3bNr35hcthFSBz3Vu6jBA5a WDqQ== X-Gm-Message-State: AFq9FYKegHeNF2YtdE3/rAD/BXzzA/IWxvXvlZ8YWf7PIIrEOo9u++1V YeBd0sXIYJTRg4Z7Wx9LrvvAOP2PXJj/p9ommTuYfkPs1HKYjtmoBCxyZhpgZw== X-Gm-Gg: AYBFou3GjKCyu6StQWxMtdpH/29pCkKLba7w/xA1dsqvAes7YI62rUKZtH4xbwN8UKF k0d+0NVpduSff6zne2UrPRooQQs3kHYiuL9Z/l+F7Ip55IcqqHQb2hk+9b33hYbN8PP18u8FeHU ENuSfpuQrncMQxs4iuQQpmZDzRpFOquvXKmRCGk77qTS8ICsb6+HwW1RPTPeOJbpN94Mhi4JMQO cbApHN/MfOPo34P+amtwRanmhN1lD/Bi8slVmFMHkpKtKPvNxoCjflfWcebr+v/woyv+vef3NZ4 o6/ScD4HPku1if/YBj3q2aaL1Egd++JHcW9E5H1UEztplFyv8BWIKyVjWOC93SvGvkWeWZ85ND+ kERytEpoHoDMWKmJe9bq/Vmf0t/tS1/dEXNaDiHnHA2M9CUeT/iAMmMRgcYAw0FCQBppGB1RSsT 4/aD/ubCoTvN4ECojTxFmDNmIGLwsfmD4XLCrTo5OnYm9WoKwEDR0Sv+/cCTFmYk26URcGjdXp8 CGO X-Received: by 2002:a17:907:6d1f:b0:c2d:c80e:8366 with SMTP id a640c23a62f3a-c2e4a675949mr943279066b.0.1791197372803; Mon, 05 Oct 2026 03:49:32 -0700 (PDT) Received: from ars3 ([2a00:20:641d:faa4:a04e:849e:1908:d7ef]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c31563008casm58201866b.47.2026.10.05.03.49.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Oct 2026 03:49:32 -0700 (PDT) From: Augusto Stoffel <arstoffel@HIDDEN> To: Sean Whitton <spwhitton@HIDDEN> Subject: Re: bug#81974: 31.1; Make Comint's prompt highlighting optional In-Reply-To: <87ld8cwiy9.fsf@HIDDEN> References: <87qzi88d0p.fsf@HIDDEN> <87bj9cxmbk.fsf@HIDDEN> <87o6dc8bdo.fsf@HIDDEN> <878q4gxhn9.fsf@HIDDEN> <87h5j485ip.fsf@HIDDEN> <87ld8cwiy9.fsf@HIDDEN> Date: Mon, 05 Oct 2026 12:49:31 +0200 Message-ID: <874if0bex0.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 81974 Cc: 81974 <at> debbugs.gnu.org, Robert Pluim <rpluim@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.0 (/) On Mon, 5 Oct 2026, Sean Whitton wrote: > Augusto Stoffel [02/Oct 5:51pm +02] wrote: >> On Fri, 2 Oct 2026, Sean Whitton wrote: >> >>> Augusto Stoffel [02/Oct 3:45pm +02] wrote: >>>> On Fri, 2 Oct 2026, Sean Whitton wrote: >>>> >>>>> Augusto Stoffel [02/Oct 3:09pm +02] wrote: >>>>>> I think (personally) that the prompt highlighting feature in Comint is >>>>>> not particularly useful and has false positives, so I'd like to suggest >>>>>> the following reorganization of the code that allows it to be disabled. >>>>>> >>>>>> WDYT? >>>>> >>>>> Couldn't one just customise the face so that the prompt is not visibly >>>>> distinguished? >>>> >>>> Yes, but with the patch you can actually bypass all the processing, and >>>> the code is more modular. >>> >>> Unless we have reason to think that processing has a real-world >>> performance impact, we'd probably prefer not to modify the existing, >>> battle-tested code. >> >> This is just a refactoring moving a block of code to a separate >> function. There is no change in the manipulations performed on the >> buffer. Unless you remove the syntax highlighting entirely, in which >> case it's new territory to be tested. > > It's not just a pure refactor, you're handling the position of point > differently. Yes, I removed redundant/defensive goto-chars to better understand the logic, but we can keep the defensive stuff in a final version (or say use save-excursion). Really the point is whether the refactoring is desired, or, as Robert suggested we should add a defcustom to disable prompt highlighting. (My goal and the title of the bug is to "make comint's prompt highlighting optional".) Your suggestion to customize comint-highlight-prompt face doesn't work if you want that for some but not all comint types.
bug-gnu-emacs@HIDDEN:bug#81974; Package emacs.
Full text available.Received: (at 81974) by debbugs.gnu.org; 5 Oct 2026 10:17:04 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Oct 05 06:17:03 2026 Received: from localhost ([127.0.0.1]:51545 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1xDfkh-0006cu-AA for submit <at> debbugs.gnu.org; Mon, 05 Oct 2026 06:17:03 -0400 Received: from fout-a7-smtp.messagingengine.com ([103.168.172.150]:50513) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <spwhitton@HIDDEN>) id 1xDfka-0006bz-Da for 81974 <at> debbugs.gnu.org; Mon, 05 Oct 2026 06:16:55 -0400 Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfout.phl.internal (Postfix) with ESMTP id 04CCFEC00BF for <81974 <at> debbugs.gnu.org>; Mon, 5 Oct 2026 06:16:47 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Mon, 05 Oct 2026 06:16:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1791195407; x= 1791281807; bh=JETB3UYeGlBxrAj2fCd9eh+GF45zhgPWp94RjM127ZE=; b=R HJRpOlNGwFJyCuIvouhh3CqThlwNkrM9kCUonVn4TBse9surHgFFubadQ4m8byfZ BWvSvrbemy/G2NtfAzyDMMBXFtLpW2wTiC9Lauf/PxQiVBiwvVyOYZY5AfXVSEcg XRhP6aVfVR/UQK5cA95fXgu4AEvJ1aD80VWIRof0cLLD77UUWFIt+8MPYYE65nzX icCyKWzmMC3VYBJyyFVuSiu7m9XBDR5ILlPi2+ouPszRy3K/wj1ZnKb5m52mXVss ikRD5wiN31vGh5ioUP5hMxV8kBKf9ydS2AtHTq2Xb8GgTZmT24YeqKayYKgc5uCI /1P8Wu6Tfs7HJNqAgKGvw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1791195407; x=1791281807; bh=JETB3UYeGlBxrAj2fCd9eh+GF45zhgPWp94 RjM127ZE=; b=HVolcZ5vsHNUAWfGsDR5Bd/PJXy5119GwwtTd46Jm0xAYexvchA cyHA08/QWpUXDDIOJhpuz/15W69MnKOxwftAE3dnYHLhDmp4A4Bdj5iMmSL8y8iP aFpXX8ddth65F07YxB8tLo5eInvcYqKeQUhOqQrtPiWfoNuTM+gI+T/YSfrJ/XyP uurhS1lfFaSOdHnooCXgoknYWFB0CAE1zJ1ZzwU+MXt3fO3QsIykNEaa/m0UJJ52 fr024wDTbnjDzWsyYeTue/34cXNala2946GeDGP3WY7KjsCC0iCsWbbHJKZlXxL2 uf7w65wY8fQ7RPvJYuJ6n1ez+3eNg9TBPIQ== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-06; repo=github.com/dkim2wg/interop; date=2026-09-30; sw=lmtpprox; action=sign d=spwhitton.name a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1791195407; d=spwhitton.name; mf=PHNwd2hpdHRvbkBzcHdoaXR0b24ubmFtZT4=; rt=PDgxOTc0QGRlYmJ1Z3MuZ251Lm9yZz4=; s=fm3:rsa-sha256:CVuY+ibwxuDO+042BwD01tDv5m4/AuxIXScsVSkdyqCwaV7 s4Z59L3XxZpBNWQ26RLIo03naLooiLVMyz7U3pUq7FZMMbvCC0NdydD9SuOBZWn8 cwzOse4wKBAegrclwU2jkwVBa5h8Kfs9rMOGyktl6fAAlprKxI80eH8IAXKRgYcd 9a9kbmAKH7MkgXx7OoGbw8dsKbYp3kQR2ZsuLXBqxGIFk7IIs5TCbPivWK1oe+vw h23CpUbgLJ0ldIOXs8EpIDWy5ww3fJCNpGpo+7aqXa2zvJGf7L+MmIonTDDDlLcL YcpTKXc/Ma1BVSmCHX+eEgjDzYlbuAswHLzWhWw==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-06; repo=github.com/dkim2wg/interop; date=2026-09-30; sw=lmtpprox; action=mi-m=1; hc=11; hn=cc,content-type,date,feedback-id,from,in-reply-to,message-id, mime-version,references,subject,to; Message-Instance: m=1; h=sha256:tcGg1/scXvApwsEJDZeZgWNO07kgR5VKsf1FTEk8ZrM=:AJ28syU1HdNalpl+OspybZnAhTV54l5xlukEdmtiGUI=; X-ME-Sender: <xms:DnnDaj2Ld3W_PSRgYVyh9eyz-0j7s_q0TgNmtPVbmPha3jB4KK9pig> <xme:DnnDaoG2zoXrORBIKabyHn57HowfXb6zlz6FEJolsPtGWp8Xe40J8vG3f2gGNEhbb rbsusQBBVIQ9vwUWhmhCDABrVHvXJ_G2ddLUDHBlzkSZMsL4pijtzQ> X-ME-Received: <xmr:DnnDahiRMAJ6udyEJ-8zrgb_141DsjTIb0nAacbXN5x1FOR_u17WcdccoWueLYhpewDdJz03_-F_g6JYkBSErmO-YjEgiqWY7Q> X-ME-Proxy-Cause: dmFkZTGLoqfyd3KvpfG5f9akM9ncx9nq/DVGeq2YgDtID+qTV1eaxmuonMzqou1C2SfL+M tj55Jc8QzMvW1+k9nrydMC8OgwvTU1tMVhft29WsASRkNgwY13lsAn5VUAok+hCZQfhbEJ CLzvG+F1x7wQBSlrjg6/J51zjswWYkzZZAwPwQprtS7iSsXmeJEBnRft8qXFcxz3vQLp9n E6wH2MY224dMkJZROnmzLzc9+jMN41ohzExzX/1i/oX4MMdctCafWRJPsF9dUfkXYWn1Sn 4s79PUrPSxq8/XJct9tyQvmYpEWFUf7jJbra/u/6ujqs6o0Ua7wthUmfDPUBOUXKapCXKV ghcvwJ/RhptT6KxgzDk45cMY+OyeP9Ke4T0t/QSPvb6EPeEl4ZTyWhhcD1w0ri6VdJ6DDA Std7Y7Lk6BXaFf6J84mLBKMxNKPBaQZ0y5ZgL2CAI/TIjCAhY3XZeH5CN7Yz0pVxHNl7Ba KKlbB9NwUQfRy+nQoJy4gVArLOeDEy7h4e4kxeS9/5wN0jDBvtuHK54QbDAjK/IUm2FN/z 3w6elxrAY3bHaFySn9VwsJqB1bXs4bgLDS2G8DJmIKx/07zMdBoEhb6ERfy7gZ+bsHGcwl tIM/RQAnKfMBuQQiNBWq2NeK4F0O7Ov2izrtSGbpa7WZYtzzNdTHr9+/i6XA X-ME-Proxy: <xmx:DnnDaj-gA0viuJOFtH96tzVvxs5kbE1Tlyd7b0rErZQwggooUpeZnQ> <xmx:DnnDaopSXnhBMSy31HJ0Y0iws2y8u421DkpMV2pOJglFPih27SoQnw> <xmx:DnnDai8MIV8bzhM6f-RlTY42LYBOCIgCQOCoMSVNOZH8_1CqV-pQQg> <xmx:DnnDasUc7Qon2Y70FG_DELscILFMLMnoc0rnSESpaQDObyMS442ylQ> <xmx:D3nDaixQtiX6OGKjPx68esUxbGR9mXAPykYkQo9yRe80Mdub-UrrY0NV> Feedback-ID: i62564b17:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 5 Oct 2026 06:16:46 -0400 (EDT) Received: by athena.silentflame.com (Postfix, from userid 1000) id 1583C27CC28; Mon, 05 Oct 2026 11:16:46 +0100 (BST) From: Sean Whitton <spwhitton@HIDDEN> To: Augusto Stoffel <arstoffel@HIDDEN> Subject: Re: bug#81974: 31.1; Make Comint's prompt highlighting optional In-Reply-To: <87h5j485ip.fsf@HIDDEN> References: <87qzi88d0p.fsf@HIDDEN> <87bj9cxmbk.fsf@HIDDEN> <87o6dc8bdo.fsf@HIDDEN> <878q4gxhn9.fsf@HIDDEN> <87h5j485ip.fsf@HIDDEN> Date: Mon, 05 Oct 2026 11:16:46 +0100 Message-ID: <87ld8cwiy9.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 81974 Cc: 81974 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Augusto Stoffel [02/Oct 5:51pm +02] wrote: > On Fri, 2 Oct 2026, Sean Whitton wrote: > >> Augusto Stoffel [02/Oct 3:45pm +02] wrote: >>> On Fri, 2 Oct 2026, Sean Whitton wrote: >>> >>>> Augusto Stoffel [02/Oct 3:09pm +02] wrote: >>>>> I think (personally) that the prompt highlighting feature in Comint is >>>>> not particularly useful and has false positives, so I'd like to suggest >>>>> the following reorganization of the code that allows it to be disabled. >>>>> >>>>> WDYT? >>>> >>>> Couldn't one just customise the face so that the prompt is not visibly >>>> distinguished? >>> >>> Yes, but with the patch you can actually bypass all the processing, and >>> the code is more modular. >> >> Unless we have reason to think that processing has a real-world >> performance impact, we'd probably prefer not to modify the existing, >> battle-tested code. > > This is just a refactoring moving a block of code to a separate > function. There is no change in the manipulations performed on the > buffer. Unless you remove the syntax highlighting entirely, in which > case it's new territory to be tested. It's not just a pure refactor, you're handling the position of point differently. -- Sean Whitton
bug-gnu-emacs@HIDDEN:bug#81974; Package emacs.
Full text available.Received: (at 81974) by debbugs.gnu.org; 2 Oct 2026 15:52:11 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Oct 02 11:52:10 2026 Received: from localhost ([127.0.0.1]:41971 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1xCfYL-0006uW-Jz for submit <at> debbugs.gnu.org; Fri, 02 Oct 2026 11:52:09 -0400 Received: from mail-wm2-x10.google.com ([2a00:1450:4864:31::10]:36345) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <arstoffel@HIDDEN>) id 1xCfY7-0006sv-FN for 81974 <at> debbugs.gnu.org; Fri, 02 Oct 2026 11:51:59 -0400 Received: by mail-wm2-x10.google.com with SMTP id 5b1f17b1804b1-49ffed768deso239965e9.1 for <81974 <at> debbugs.gnu.org>; Fri, 02 Oct 2026 08:51:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790956305; x=1791561105; darn=debbugs.gnu.org; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=jwXua8SruF3OQvRztwLm0s2IMbMzXtnVhtZhU+m77P8=; b=Od5q0wpeZrsA69LN9FuIXrfHiaabJaxP4199zM90IMu8uvEqTjkUj0oaPvhP+NyqBT hY1kKRolO40R0WO8DX6vhLGfqDr51l4dvbrIBZByJUAxB3vhLziVBrs0vcDxWfS8Nauq G/C3vwljmZDDt2CgWNO9xxE93aQ3HzFwry9nDYAaAKg09Aushnk+7UQks7tLZEsTpTcI I+G9ILLAPxOcchcydD48HNHSM5+c5w7BdGGb8qvY1CgHbjdLmZSuUIycoF2zuv7rP4IN 9Lz28Hcn5q9I2QI5T/ilIAs6QDs1HpldrmCD4blfGWQhqFco9URqzJeuAhYynMuRVFx0 PVMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790956305; x=1791561105; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=jwXua8SruF3OQvRztwLm0s2IMbMzXtnVhtZhU+m77P8=; b=LIFXpG7CgHLpEW4PwMiW8JWNkJStB1i4dPRsvQIMDBU0V4RhZX6Ec24c8pJuq7aO1m sxli0aKAzs9NWL9QzuB63befBDQuCWksxNxIPtln19f8MbjgagC37OF5kTdnGg0innb1 HcDl1bC6qrQNrqr4/pgOWfbBdfXlPGUhy9NLya2Ba9W3rSSVuEMI61YHc2In1edl7fpc D/CcT8AJlVfTC9yvdjK6HIhh/GOfkt+wocH2redZfNMBowqCRLbhzEO2fiUw6x9G3Zj6 JryV4EawvYW/ZR1QvY+2KB1WYjtJ4WNNOAq5VPOVon0sFnOs8XXCAqkLblYm0jW2gTOh yEjA== X-Gm-Message-State: AFuF++kIdmaoFYeKyMx/0YdIwhI9qdq4lwCybDkrw5btZMzNEauKDYt6 05pAQ5XcPHM4cCF4T3ZRn0lgpgit2OrGYnwRSdvou+SdiWYVzahPc1D8e/F5zqhR X-Gm-Gg: AYBFou1/3G6f6uUQFmxNSUTO5hVBixf5hoBE5JI2k7OU0l+xyg9NdoXmm9BlL2h/Jg7 cXs893mDCVskjd8nKLgsNek7ZlsSaSz4NjwJfgvERRCgURju0B+WUDkqH1VopVHyFDcmUf/Ofv/ nlObikvg22Z16M1stle+zulmnFPK4IMPsaLZdSZ4Il21Z3QYdHd+7yS41tnRED/n8ErAtc8ujAM AgLFKVeP9Pb3eaNAW43vDKhYoBrUPbXcn0uRhlUngk8P0hHdXI1GrU1KhD5YhdM+knPfS7Zu0yG inJXlvzc4ATlL+UoJXT9YuAGemZxTLm+Dho/QnhCwilo45kbqV7RqeAz2OunjFzGynYzDwOUWQZ upXktwqTXSHP14MCkAhP6wHRiuQ5buyOA1XwXEUwslbo28xlGSDnErwpdXnpw6Y09CXjAN4Bt5k Kjzy3roITqa/AFVlJwQLokCF5anDw9/uuO3gWVQcWAoJVNPntYyE/xIfH3zzSr6zJV1vjp0g== X-Received: by 2002:a05:600c:530e:b0:49e:63cc:6324 with SMTP id 5b1f17b1804b1-4a027534c46mr57712395e9.6.1790956304367; Fri, 02 Oct 2026 08:51:44 -0700 (PDT) Received: from ars3 ([2a02:8109:8aa6:9c00::763f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a027f2a4cfsm76637615e9.1.2026.10.02.08.51.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Oct 2026 08:51:43 -0700 (PDT) From: Augusto Stoffel <arstoffel@HIDDEN> To: Sean Whitton <spwhitton@HIDDEN> Subject: Re: bug#81974: 31.1; Make Comint's prompt highlighting optional In-Reply-To: <878q4gxhn9.fsf@HIDDEN> References: <87qzi88d0p.fsf@HIDDEN> <87bj9cxmbk.fsf@HIDDEN> <87o6dc8bdo.fsf@HIDDEN> <878q4gxhn9.fsf@HIDDEN> Date: Fri, 02 Oct 2026 17:51:42 +0200 Message-ID: <87h5j485ip.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 81974 Cc: 81974 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.0 (/) On Fri, 2 Oct 2026, Sean Whitton wrote: > Augusto Stoffel [02/Oct 3:45pm +02] wrote: >> On Fri, 2 Oct 2026, Sean Whitton wrote: >> >>> Augusto Stoffel [02/Oct 3:09pm +02] wrote: >>>> I think (personally) that the prompt highlighting feature in Comint is >>>> not particularly useful and has false positives, so I'd like to suggest >>>> the following reorganization of the code that allows it to be disabled. >>>> >>>> WDYT? >>> >>> Couldn't one just customise the face so that the prompt is not visibly >>> distinguished? >> >> Yes, but with the patch you can actually bypass all the processing, and >> the code is more modular. > > Unless we have reason to think that processing has a real-world > performance impact, we'd probably prefer not to modify the existing, > battle-tested code. This is just a refactoring moving a block of code to a separate function. There is no change in the manipulations performed on the buffer. Unless you remove the syntax highlighting entirely, in which case it's new territory to be tested.
bug-gnu-emacs@HIDDEN:bug#81974; Package emacs.
Full text available.Received: (at 81974) by debbugs.gnu.org; 2 Oct 2026 15:10:57 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Oct 02 11:10:55 2026 Received: from localhost ([127.0.0.1]:34952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1xCeuQ-0004Fc-FK for submit <at> debbugs.gnu.org; Fri, 02 Oct 2026 11:10:53 -0400 Received: from fhigh-a8-smtp.messagingengine.com ([103.168.172.159]:44983) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <spwhitton@HIDDEN>) id 1xCeuI-0004Ew-Er for 81974 <at> debbugs.gnu.org; Fri, 02 Oct 2026 11:10:45 -0400 Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailfhigh.phl.internal (Postfix) with ESMTP id C209914000E5 for <81974 <at> debbugs.gnu.org>; Fri, 2 Oct 2026 11:10:36 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-02.internal (MEProxy); Fri, 02 Oct 2026 11:10:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1790953836; x= 1791040236; bh=7YagK4HncB9fv6+BwCd//qX0qNAfSjcU/RdjrYS1MPY=; b=C HsZzYArwJKgEylTqGj13e8Xhd2vemYK22aPVKME2RW8iQYiB1ZkHkk3G9nSOigy2 TNM3Akaeb73FuF8Kvobv3I0kT+5xhTYBPdzWYA1LoQH1VA3ujfPlFJsd92sAMBo9 tfG9KcWBKWasDO0SfGy7QBn6Cj/EQxUFM1/F+K8YciEm9GTthvT8rdrngcfZthu2 ZhHilQRALsaMaV+Io/9ncs05nuyikWY2DXXUAaARM3rr/OgYhwvRngd4i2hrQ6kv Vjb7rXaAX1lO63LZPhrvqVcgxRdLAiPOSyS2ZCSGd/mydCI3U9FWv9Nq0eOzEpBc ZoO42FUG+fMU638zQPGTw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1790953836; x=1791040236; bh=7YagK4HncB9fv6+BwCd//qX0qNAfSjcU/Rd jrYS1MPY=; b=vzIEZMpdGPbFEt71/5YQWPfwXNyhCqx+lRQ9oDy3frpUDUufgSK sJrwo/FeGP3RGtg47dSmI/jq9pSjpxpePzAkqkuK8X0ASQLdbi2wmU+sDZjilPf2 mzKyQqkqs63QuBBr776LBl+gchkkBXxpy7ylYseVOGblHZ8csX8QJBME2qoLVLUP PSUUuGz7FVbf+TrgBQiJxxJDYppSwm6X4yq/rULer0oGdmsH2O+/YrWS4NvDyDAd 3QqhtaT7lfSC1L+Mo9ptN5CmJmoHvY8TB3QKqO6lNyTc2WSiEwoc4LiZmTkxlCma PrheputBguh63qJeLQN3H85EnmVpMVs/EUA== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-06; repo=github.com/dkim2wg/interop; date=2026-09-30; sw=lmtpprox; action=sign d=spwhitton.name a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1790953836; d=spwhitton.name; mf=PHNwd2hpdHRvbkBzcHdoaXR0b24ubmFtZT4=; rt=PDgxOTc0QGRlYmJ1Z3MuZ251Lm9yZz4=; s=fm3:rsa-sha256:sH8jZuBSFgEsnGedR+ZLwjh1iJnW+CHexvUS4aqtLd9ciOA Nf8tSCOy2iNUvKYYPfGuAbSs10iWSa6P7OlbZJWCyKR2IjRIJCofHxLciq7l4B7s kUJAQ5e/U6lHGMpTtpJ4DOCXXFKEComtjJ1dUKyHIDsumV3UkxtTS+H3BKBLd5wH CXvbbReZ/jI7Ae5Tv7a/G/1G218iD6tbRtUibuAuOK8l/jdWPhfaZlN6s1MBI8vK dFY15zFr39j0SmLR3cbo/jausyowGC6tpAdQPlhrmjRT9NbjEEBp5Z+UFcShS8DR tkZ05jQE8uzziNl+RDm1cGQw1fso+TlzYd8yY5g==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-06; repo=github.com/dkim2wg/interop; date=2026-09-30; sw=lmtpprox; action=mi-m=1; hc=11; hn=cc,content-type,date,feedback-id,from,in-reply-to,message-id, mime-version,references,subject,to; Message-Instance: m=1; h=sha256:345KgQ8eQjuo9as0bOWv7rSLIjstHGT9ewwAU+qZKnY=:pL+2aUimStukiC9zZlB1CrVewaOtSgE+T25Z1LH2+eM=; X-ME-Sender: <xms:bMm_amtGSBfNSS41qDvp1QJmW65TbEHllj0KyYmZDVP5F2Xo7y5lCA> <xme:bMm_ahe9QWZDwyAi49wFnsrY97PxO7qscSunYtcGmPZF6WituiJC7Dl4_n1glqP49 chaVI0JRbOrJ0huim21PSCu1Wn_zeR3oEF7QPVpbDBXhh1c5wxi9VhC> X-ME-Received: <xmr:bMm_avYiXRG1gyFFpHAisNGBZYvwlEuyAlaq0QzXAMHPfisM4LSevU0xop_pmisgYC8GgkERfWTpZkOrFmK71rH6SyWHiQrKFA> X-ME-Proxy-Cause: dmFkZTGUOcJCS1OM7KvA5B/iDYXceUwrugzY3BivSqLaer90S9N2F/dA2ZfrAIkUEuWMXY yubNR0jo7BO5o2o97EXawQ+zrUDeu/zGGO1xZ36lkVEA9prrI3JutYlTTMyjK27uKS2MVU TZaWEkMw1tJK6asSl/QiGMyXfjH9HfusQf9B/ZU6uKYgKII9oAK9Wq8fvjMRij3gcGnjLZ vfwgeUjDTgyMqoJQtMlVdPh1Ll+l7qfLMQsq5Arydcfq7u4DIotWJ5A+qVb/jAhmLM39IX 725pQwbhfGj1U4JTrLqfjDkGLTElu5hx3AuLvmqL6DCITWRFnb4IvPHx0po22Jin6MbXeM rpZ/1YiSm40oSaquTcroI6wHZnHarG++bAJwMhqRkx+1SlzTSsq4Unpc+EO4xCRGu/p/37 AcVL3VesHr65kzQILxpvtp+wGFmUZDKrz6kxyg+vLC/RxltZW5JVHcCk2EuPLSR8Y/R7qN l3gMwJrFkivNGydt/2XlTve/YD3YZsZXXs3YJn0o29jGpcCZE3lR+/INj0m3RKudQ8qkeV HU4/Rra5pTlPJTQZOstWuCiS5LhiBodrjoKcdZQwQFGzg2sSvBOA+uYwwvrbQWnmENJXpf sW7iaLX62oLQInGqtsVMUO8yuQ4txDRLu2991A0n/cmNYdVSPCzNH/rShRMQ X-ME-Proxy: <xmx:bMm_asUvs8iTh8S8Zsac4ygDxt8M_OeYiWSAikp450C3VWBiZ6Clqg> <xmx:bMm_apjSmDpD455yksKraXNVpY-uxQr4g1J3I6mTXb7RPNTDkhgYAg> <xmx:bMm_aiUm_tHmAbnpK5r-RY91eSEccJKcXUmH8eNcMyf_nzNHe724Ow> <xmx:bMm_aoMuLNsUSIKBtK17FZdoD5-swJwR5to6nT2PT24nNJEHKsTD1g> <xmx:bMm_agrw-q9IIHmOmMdtt4AmtJe2_r8dxk6vyUTFeu8EdrZ1KN0ztzMK> Feedback-ID: i62564b17:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 2 Oct 2026 11:10:36 -0400 (EDT) Received: by athena.silentflame.com (Postfix, from userid 1000) id B6BCF27CBDD; Fri, 02 Oct 2026 16:10:34 +0100 (BST) From: Sean Whitton <spwhitton@HIDDEN> To: Augusto Stoffel <arstoffel@HIDDEN> Subject: Re: bug#81974: 31.1; Make Comint's prompt highlighting optional In-Reply-To: <87o6dc8bdo.fsf@HIDDEN> References: <87qzi88d0p.fsf@HIDDEN> <87bj9cxmbk.fsf@HIDDEN> <87o6dc8bdo.fsf@HIDDEN> Date: Fri, 02 Oct 2026 16:10:34 +0100 Message-ID: <878q4gxhn9.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 81974 Cc: 81974 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Augusto Stoffel [02/Oct 3:45pm +02] wrote: > On Fri, 2 Oct 2026, Sean Whitton wrote: > >> Augusto Stoffel [02/Oct 3:09pm +02] wrote: >>> I think (personally) that the prompt highlighting feature in Comint is >>> not particularly useful and has false positives, so I'd like to suggest >>> the following reorganization of the code that allows it to be disabled. >>> >>> WDYT? >> >> Couldn't one just customise the face so that the prompt is not visibly >> distinguished? > > Yes, but with the patch you can actually bypass all the processing, and > the code is more modular. Unless we have reason to think that processing has a real-world performance impact, we'd probably prefer not to modify the existing, battle-tested code. -- Sean Whitton
bug-gnu-emacs@HIDDEN:bug#81974; Package emacs.
Full text available.Received: (at 81974) by debbugs.gnu.org; 2 Oct 2026 13:45:25 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Oct 02 09:45:23 2026 Received: from localhost ([127.0.0.1]:47607 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1xCdZg-0007Le-QG for submit <at> debbugs.gnu.org; Fri, 02 Oct 2026 09:45:23 -0400 Received: from mail-wm2-x10.google.com ([2a00:1450:4864:31::10]:47063) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <arstoffel@HIDDEN>) id 1xCdZb-0007Ky-5a for 81974 <at> debbugs.gnu.org; Fri, 02 Oct 2026 09:45:17 -0400 Received: by mail-wm2-x10.google.com with SMTP id 5b1f17b1804b1-49b912e4b11so47091125e9.3 for <81974 <at> debbugs.gnu.org>; Fri, 02 Oct 2026 06:45:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790948709; x=1791553509; darn=debbugs.gnu.org; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=lpqXr5WpuArrIm3Fjdusk7SMxGAbYvJOxiliemTXmFk=; b=mHJCnXtqQhTU3J/3Aqho9cA2WfOe0ZJldofSZEXpkOoU+8VvB0/ekhk3OLMz8L7OCV 9JAJFu0hraYh+QPU+ghTAyb5AnpgZHaRlmSVJCmea+gcBju6cfY8HKBRNdy61Z5mHg7h 2yi1mqVnZGe1xsG74LRJb7WO2s4zdxbKPh20pBsUYkQeFm95QLzS5V6yjb8nVficDSQZ +D4VLtc4S5hN3ae0iepv0w2rd8jvBibZbbWT+ulL95dZ6nMBt4X7tVd7apeswm9PaD1V I+z/lKYIg1q8njpTG9CKfL7HZMfoCVzrjyawAIASYqaKTCUj4DK36nHDwotdc6MwNeoC Nx4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790948709; x=1791553509; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=lpqXr5WpuArrIm3Fjdusk7SMxGAbYvJOxiliemTXmFk=; b=08I6CkrLlYvbey5JAhkaJJM+Z8y4JZNgARYBIes6Jl+3U3jE9x9y2wmtUp4Iwjq+4/ LtZiVDBZ6ZXy0OWr5Mq3jDMIJKGgcMMCFpH7NBjfhaX0aeZpfIuSThAkIvE8KY0BoBGR wiv6I7o0H+Tgy5UWARHNfWzjK/MfBQuQADEOxrWjh8Pbk8fx9d8PbEQFxEt6rbjVtoRB xECFcZGywpbliJMpywgrcNhjljHTgaBZeZD0bPP1I+0CJb1t9tmSzahz3KoKIqq4eoSQ dv8KnPV86nLdCQJxT+uospHQizV+em6XgeJlnwJ64gvXhaglPGy6f5W34HrJJXtJEYkg QBhw== X-Gm-Message-State: AFuF++m9wwYSYMFM/z4AYS5b58HWnthKAHBYMDHDQBmBZA72//usg/lx bUCPLHdfJGm2sUjWd/uBZbDlWcJzit8VmckwBy3E+oSvtCIuJi6MEp1bUjjLKysU X-Gm-Gg: AYBFou1FjUYtIJnkRAM79QBR6ICIlIF1qr7p/Lrz42JC06j82+Vwwmw85oZ83BZ+cqj EGxrTdDv7VHOXRvPswTIUJD3u6+JiI2LbHGc3x+V0lXPFzsVH2ScGderIBNO+lFZRELozI/T5da zzZRYqQUlvCkFUZSA7yQPukHN+vCIyblVYz5DEkDeZyOydgytprvOcNicQw401YeGGEZ27wlBel E6Vhn0VMjchaPAGLPQILQ+j9p+hDXWM6xWGFhWQ71Apd1Mo/M3eNeV9oPNMJxBLL6S5efFtK4CT NBvCj6qDQnXkJf3mLVjNcpU6oSMc9VDIts4a8JqHe49FYHiTKdYu3eUAguwpPKHVGo97yG1aUJC UKudvAqy88bXuydmrWt8Yst9Yg828KCMD+6wMcMWUfj2SF1mQRctbATZ/ICzhFqQb14QIhuBd/F P64Pn20MzgoVYzKhqFUo9kkKYCqMPVFzj9aSRHX0geEIZvbzD36pudf6D6pOMx4wqvtVUa9g== X-Received: by 2002:a05:600c:45d3:b0:49c:fc6e:a3e1 with SMTP id 5b1f17b1804b1-4a0276f556emr50859565e9.32.1790948708780; Fri, 02 Oct 2026 06:45:08 -0700 (PDT) Received: from ars3 ([2a02:8109:8aa6:9c00::763f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a0280c8bb0sm90126945e9.11.2026.10.02.06.45.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Oct 2026 06:45:08 -0700 (PDT) From: Augusto Stoffel <arstoffel@HIDDEN> To: Sean Whitton <spwhitton@HIDDEN> Subject: Re: bug#81974: 31.1; Make Comint's prompt highlighting optional In-Reply-To: <87bj9cxmbk.fsf@HIDDEN> References: <87qzi88d0p.fsf@HIDDEN> <87bj9cxmbk.fsf@HIDDEN> Date: Fri, 02 Oct 2026 15:45:07 +0200 Message-ID: <87o6dc8bdo.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 81974 Cc: 81974 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.0 (/) On Fri, 2 Oct 2026, Sean Whitton wrote: > Augusto Stoffel [02/Oct 3:09pm +02] wrote: >> I think (personally) that the prompt highlighting feature in Comint is >> not particularly useful and has false positives, so I'd like to suggest >> the following reorganization of the code that allows it to be disabled. >> >> WDYT? > > Couldn't one just customise the face so that the prompt is not visibly > distinguished? Yes, but with the patch you can actually bypass all the processing, and the code is more modular.
bug-gnu-emacs@HIDDEN:bug#81974; Package emacs.
Full text available.
Received: (at 81974) by debbugs.gnu.org; 2 Oct 2026 13:42:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Oct 02 09:42:17 2026
Received: from localhost ([127.0.0.1]:47171 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1xCdWg-0007CG-Kz
for submit <at> debbugs.gnu.org; Fri, 02 Oct 2026 09:42:17 -0400
Received: from mail-wm2-x10.google.com ([2a00:1450:4864:31::10]:61366)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <rpluim@HIDDEN>) id 1xCdWZ-0007BL-7G
for 81974 <at> debbugs.gnu.org; Fri, 02 Oct 2026 09:42:10 -0400
Received: by mail-wm2-x10.google.com with SMTP id
5b1f17b1804b1-49b912e4b11so47065085e9.3
for <81974 <at> debbugs.gnu.org>; Fri, 02 Oct 2026 06:42:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20251104; t=1790948520; x=1791553320; darn=debbugs.gnu.org;
h=content-transfer-encoding:content-type:mime-version:message-id:date
:references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to:content-type;
bh=HkuaC/UgqEBISEQQ4wE/MnCMsNjKhOJQwX+abDnYV1g=;
b=BVCYCSXgFhFrRtG2RG9RTM06mD16cHY2qf5C2lMfTOfQxve92CCV2Z4cO4l6AhX+Hr
xSCckY3Taifoq18MSOvwJ83gm1BQi0Sv076IhZePe63Zf7J6NAsQoMRQ9Bto0qcMPczU
xIejVQMM+HibPkpkKzUPuW3MkUVB4p1IcJuDNM6tvnoxd1L/XgwNCWdEOdMsSO756kgm
q5SXipI0120T2HOaBVWYqWWv97k4fx/vc/uKEFLrwX5aDfL794rTfo37WiOuxl+kMF/0
AA6oom7MbIyG9hT3QtxotKHTOyqSQE21ZU4YCWB9x1QDBz+68gEKb6NX4tNX4XkMyqcH
wJIA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20260707; t=1790948520; x=1791553320;
h=content-transfer-encoding:content-type:mime-version:message-id:date
:references:in-reply-to:subject:cc:to:from:x-gm-gg
:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to
:content-type;
bh=HkuaC/UgqEBISEQQ4wE/MnCMsNjKhOJQwX+abDnYV1g=;
b=v0IHotVXbTPQlNb3rWUSyAVFOlB4dGRuzAVVumeqwmsiwTF8BCR6Tt4rdAEdwm7KkY
a1bsw7lDr98gaeOlfLJwYgTx8pNTFyq+HVboC7i2aqF6v6rmEcAJi1RBXKNonxcnT1ht
1Qt74WBNG3wwNfdgui/773s4NSJ9s4MMVGVJcs7IXXWvvDCZSHtSbzKWocLl+kSJNlMT
G5iSYFPGxsP2gjisnO4Xsuka1vl2FoMsOt5RbuP4WR56BtLWzjmsjKdgfv56IVzi+BAP
VVMM6e1XQSIYs9DSg0zQ91E5UH4IKq2O+BVa8ocSMEvFcFPLqt6z029pw5eEgQ4uHpDI
0U5A==
X-Gm-Message-State: AFuF++kHoyzx7/bW2YJBWX6bSsdoWp7ZBlEvnkaUpvrDHJ8/C2jnNKX+
py9AcoXlZx83cpnukHADH2XLr5QcyH4fLXbdWTs+AWWTXosYtDv5WR6dz+LnAQ==
X-Gm-Gg: AYBFou3Zmd+bUtrcxXOiR3sQQR4bjamIVyXYLUhBEZ9aCc5HE8ZoSy+wBhzJK2wtMjI
FxwzM2ObS1lwRWLSi3yz48kd0dP2kXQup17g2U7FSx6dQYz9RoJ+Ndhj119j3TYwq0L+FSTIll6
WIbZNT90s8y0GlfTWV3JsVezH8IC7MaqGvS3xuatUHyiKN+zXsrUb2nh+olDFROzWYYOldnJMzW
FeUbZ3IxQCzLMl7KGVDqhUeyz2EXPWmU71w7NaK1hqfORKN/4HAiI7Fhtu9b8DUc615U9fjwA0N
vQA+w+1M4mnmQPb5UxZwz2USDvYDNl4hrzQTaGnE+Yorbk/OFp0NQJhwztFdoBXQYvLyvyT7CBD
p7gDIuTp9X05rtJ4p4NRars1BHajgznlWM08G2Pj2paugebkJxNl7M61WdnrDKCjG70iv3U1Ql4
EA9pkMr5vQD1ZhZoNwKVMhwoieeH7txp+6iUsvhcUreHH8wjIu2VARxBeOUrgnKxSSfAfSTB108
JOiS3gg+V9z5O/uDt5r/TQIldqJgvkCsgQJyUSnI8GN62wpquUbaP3wTlUMEDtxohi4CBnBLo7u
VEgIiT72oO/anf+ueh4ZNXGlMSQ49/WX
X-Received: by 2002:a05:600c:3b1d:b0:4a0:2423:946 with SMTP id
5b1f17b1804b1-4a0276b5d6bmr53060035e9.15.1790948520315;
Fri, 02 Oct 2026 06:42:00 -0700 (PDT)
Received: from rlsb ([2a01:e0a:834:daf0:10a2:e1ff:fe2b:113a])
by smtp.gmail.com with ESMTPSA id
ffacd0b85a97d-48b38103856sm6191889f8f.25.2026.10.02.06.41.59
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 02 Oct 2026 06:42:00 -0700 (PDT)
From: Robert Pluim <rpluim@HIDDEN>
To: Augusto Stoffel <arstoffel@HIDDEN>
Subject: Re: bug#81974: 31.1; Make Comint's prompt highlighting optional
In-Reply-To: <87qzi88d0p.fsf@HIDDEN>
References: <87qzi88d0p.fsf@HIDDEN>
Date: Fri, 02 Oct 2026 15:41:59 +0200
Message-ID: <87cxtsdxso.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: 81974
Cc: 81974 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.0 (/)
>>>>> On Fri, 02 Oct 2026 15:09:42 +0200, Augusto Stoffel <arstoffel@gmail.=
com> said:
Augusto> I think (personally) that the prompt highlighting feature in C=
omint is
Augusto> not particularly useful and has false positives, so I'd like t=
o suggest
Augusto> the following reorganization of the code that allows it to be =
disabled.
I=CA=BCd suggest going all the way and making it a defcustom.
Robert
--=20
bug-gnu-emacs@HIDDEN:bug#81974; Package emacs.
Full text available.Received: (at 81974) by debbugs.gnu.org; 2 Oct 2026 13:29:56 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Oct 02 09:29:54 2026 Received: from localhost ([127.0.0.1]:45371 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1xCdKh-0006Od-5z for submit <at> debbugs.gnu.org; Fri, 02 Oct 2026 09:29:54 -0400 Received: from flow-a3-smtp.messagingengine.com ([103.168.172.138]:37605) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <spwhitton@HIDDEN>) id 1xCdKY-0006Nx-A8 for 81974 <at> debbugs.gnu.org; Fri, 02 Oct 2026 09:29:45 -0400 Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailflow.phl.internal (Postfix) with ESMTP id C21A61380135 for <81974 <at> debbugs.gnu.org>; Fri, 2 Oct 2026 09:29:36 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-02.internal (MEProxy); Fri, 02 Oct 2026 09:29:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1790947776; x=1790954976; bh=kd0m5T/Am/ g91rNmg6o7WS0yBCuXK78RdJdQ86cpwMU=; b=R5Im9ytlzQsuacVHU304ygey+c TaRdfaqYEi5NwOTZF/iFcqAetU+Tq95XuyaiRxRefJ8ZIWTrXixokcAOekR27nT1 U03hdj63BCkyo7ny7n8TIe9U7fU6ofyQx0cwgkb5VBfqwEvyZULGJbA0ZxL/KlQz Q4PSzwWpFCZIG0Kaa0EgltCe6xPQ2t2/1W7xdaGPHmcllgH0PfKSqiUwTaaX58+t 2tF9bto/op1+srp26qdFZSYjdEo+NGCcvqC5h4MJCi1IpSiTGIxETnGheC1BGIH7 gEupZ8nv9LBBYOz0wzmVS2v4Odu6CLY1t80YrqyEDYqxYN8gMwIFtdwMQkeQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1790947776; x=1790954976; bh=kd0m5T/Am/g91rNmg6o7WS0yBCuXK78RdJd Q86cpwMU=; b=W7arEJPuJQS/P4DkR4qaCHcoF+cvVWeYRgzG7PuCcFSBMqu4kgk T792WZ0fWNq4IzC1l8eHz9VPbAqNZDgp/8HXRzj5ACgXG/y6weJWRDCctiLN1vDO T9gPk4kuKmVJudihtn0N5UH51NYoxaxmQmF4G4N26tB38rrVykzlpkTG4Ph6bgIt bVB9lPbyBBjdgfaPxmT2RpoOkYIdeu69HfY6LQALncXamAM6LZibrkMuWKtdhjBq /AAzT+39k/JO053XvaCOs46f9z8bhDdqiufKdDS68lPMTOKOBYXCpRCsiHSQDlOX X2RzrYlJvzlReR7I+arb760Tm3vI3KhYCmw== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-06; repo=github.com/dkim2wg/interop; date=2026-09-30; sw=lmtpprox; action=sign d=spwhitton.name a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1790947776; d=spwhitton.name; mf=PHNwd2hpdHRvbkBzcHdoaXR0b24ubmFtZT4=; rt=PDgxOTc0QGRlYmJ1Z3MuZ251Lm9yZz4=; s=fm3:rsa-sha256:WGR9Lwr1Z5Ta3TCjtlmXZx+UQbLsQ5WUQKYSTRrei7v2O1r Iqsynl3Lr2zQURNmkpapyVboAwzxxsrvgnJTMAajJVquH5w2xo0yK41UuAR46mHv LLNN0fzgg5MmxL8TFjxECiggXkeDKKLEzGbSia31CNZK8gOqOjVFDLr7EpMFBrl1 5dgz040s1vsKpoUoANp4EwB8dRkhSZx26sWLTIlr0CtwFVqaWUu4HYn2S+uoR6M/ xT68HFY1bvCdHGRtE/gF8XojTLlxmdeko4DW/J4U476Hi6lq/0Qkeo6gPJdsxvCM 2Ed45An2u0fKJKPwJ+SgbRvlWLmSEubHqQN14NQ==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-06; repo=github.com/dkim2wg/interop; date=2026-09-30; sw=lmtpprox; action=mi-m=1; hc=10; hn=content-type,date,feedback-id,from,in-reply-to,message-id, mime-version,references,subject,to; Message-Instance: m=1; h=sha256:dLRGxYfXms2ug+rQ9DdInHWo6wTOulFW1A/rKR0pFCg=:HHoS2g1wKQCqXdz3CZGkC0HTQMBWZsHiziRHsn3MIHU=; X-ME-Sender: <xms:wLG_alN-b-2dG29u27EEa4YpEHNaQrTrYUkyUtE2YH1FqaTlU8A63g> <xme:wLG_at_6Dou6wJF_LIzPfy0tIAGv46-YalwBE_1iUbtZMBAHe9XKbKMXq1AaAjlEk j43eIQJ5Wl0qZeBg1yfU5AUGCD3-Ef4lZgJbjhUM1J88MuoPYMFhQla> X-ME-Received: <xmr:wLG_ah4hooZSWXQKjRbAQd8o2zaj1GyIkRfvKLe8BgSIU0g2LMdN9InR2YE27WBnMWrj1YpZW4RhdPyt4Anm1ri_xB3_eTmF2g> X-ME-Proxy-Cause: dmFkZTF7Grds4Uz4uV+Zv8gXCzvYmVVUvF0YxEuk1WCWayOO1ZLkFSNhsjAPY6GooWYpzO O507uiUxc1prTHVimVWn5xdyPmJJ8zLVU1x6MNQzkGGTV0w8KNsJx9q1tSY5Fr0a9FxtEE Yxzxv+4m7YlJil4ELFdFC0iYkpqQkiHQWKF+cKFwzPecJF62+YFUIL3uI2qEvfAJcRGUBD yc+tylpz9K/TL9EFUHmhPc3dVipsdfb8tbTcQicxGdCsKNs09jofQP1v86soPxjl9FJTcu k6BKqOjpig6chF1zfLIuiUWSKln4+i62k2FmG0BT82JnmbK66JzlAd4Znezlwj3pvE1SsH idzCKz4qP9JG+WpDUjyhCpdzQs+FxVJ9gqw/ImYOs60z/iZSPEBG9v6y71jiQv8mDIJSkA nUCDXV2izUBBLYT2apt9gxMzOf0G9mNsc6ER4qZgDHWNINdaKwDZV3H0DFAwQRg6TdCIIe wUEyHCHtxxguSO8q1wkGJmfmzxRWf84Qu/W6zjuGHvh8y+6tRdUIdYnGgvwNqwBX0WcWrQ HJ/Sp9wM8qmUzEL2oO9SYsN7izcZ39vKvpPCpLCOIc/uYlHeyX/3NH7CJMSZROyudyM7Fh /GAjED4biLy1kLnJbMSM6sjmAs7OKZpGGatADpmAtjKKYN+ws+5wgyX1dHRA X-ME-Proxy: <xmx:wLG_as1WS7CxH5MatujRUsGnHm-Jdz6CQ0w_f0UwZy2n0VidGkBykg> <xmx:wLG_agCh0nQvhI7UA3WSiqe2H_sD1VsZyHCR1IkiTZB2RF2_XDscUQ> <xmx:wLG_am147APbwDljFQLOqYdY5k-xv0mC6qZ32omq10rY1hiwmVwSaQ> <xmx:wLG_aivn8YXhGQ6LAY2rgIqLVaa40dGk32coi2j066wBcaiZe3tYRA> <xmx:wLG_ah20IzpTnDdX6cVyfCOXuB7aKRiLoA6_xt3UoyNhm4gmX8eSmjCW> Feedback-ID: i62564b17:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 2 Oct 2026 09:29:36 -0400 (EDT) Received: by athena.silentflame.com (Postfix, from userid 1000) id 5043127CBF7; Fri, 02 Oct 2026 14:29:35 +0100 (BST) From: Sean Whitton <spwhitton@HIDDEN> To: Augusto Stoffel <arstoffel@HIDDEN>, 81974 <at> debbugs.gnu.org Subject: Re: bug#81974: 31.1; Make Comint's prompt highlighting optional In-Reply-To: <87qzi88d0p.fsf@HIDDEN> References: <87qzi88d0p.fsf@HIDDEN> Date: Fri, 02 Oct 2026 14:29:35 +0100 Message-ID: <87bj9cxmbk.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 81974 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Augusto Stoffel [02/Oct 3:09pm +02] wrote: > I think (personally) that the prompt highlighting feature in Comint is > not particularly useful and has false positives, so I'd like to suggest > the following reorganization of the code that allows it to be disabled. > > WDYT? Couldn't one just customise the face so that the prompt is not visibly distinguished? -- Sean Whitton
bug-gnu-emacs@HIDDEN:bug#81974; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 2 Oct 2026 13:10:19 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Oct 02 09:10:18 2026 Received: from localhost ([127.0.0.1]:42339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1xCd1e-0005BX-MH for submit <at> debbugs.gnu.org; Fri, 02 Oct 2026 09:10:17 -0400 Received: from lists1p.gnu.org ([2001:470:142::17]:38702) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <arstoffel@HIDDEN>) id 1xCd1U-0005Ab-6V for submit <at> debbugs.gnu.org; Fri, 02 Oct 2026 09:10:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <arstoffel@HIDDEN>) id 1xCd1I-00087t-Cu for bug-gnu-emacs@HIDDEN; Fri, 02 Oct 2026 09:09:48 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <arstoffel@HIDDEN>) id 1xCd1G-00086c-IS for bug-gnu-emacs@HIDDEN; Fri, 02 Oct 2026 09:09:48 -0400 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-4a006d3fe83so249595e9.0 for <bug-gnu-emacs@HIDDEN>; Fri, 02 Oct 2026 06:09:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790946585; x=1791551385; darn=gnu.org; h=content-type:mime-version:message-id:date:subject:to:from:from:to :cc:subject:date:message-id:reply-to:content-type; bh=xH4MZmF0QnWQN+GyKojo+oEhwhy7bK08wXdNWbM8Knc=; b=Jp9V+3UvTTr3AXql7dVTEzHK61c9L2bA5oVNK6IPdfm7Ndb5AKbcz04j+LVMP1daU1 MBw7do//LoPBokWPFjrqHzGfEWZeAlaI0LM1quDbkcLYg3BA67DAP44L/xQomFeCDD36 d0L7E1I/G+U0sTMi9Z97YxGl3QE8s/Q7SI0IJ1eNjcD/aVthkcELhnesPdTulx47uyPc Z0O1OWs5xiEJQYQKbOetJdmWHb9n/Kx8FCJzIFbCTeMfSS/4zTeV+brvOZJfJIIfLUoA 3RguKZnoY04r+NICADhIieG1i6jdQ4ChSFU8JV//eg5qsyXMCEmGwSpxBtVOlupEXT5S sDiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790946585; x=1791551385; h=content-type:mime-version:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=xH4MZmF0QnWQN+GyKojo+oEhwhy7bK08wXdNWbM8Knc=; b=d6qvHz8wrgRcKQ+Okhdh8w5vgS5wbvBx4IOqCtgFrgOkt03LocoyPBPZHcZBPmDMaC a16Cig6xK7BM487c3SoEe48QxkYgz3fjDB/d+WJFZ5iPq8i80X0wXAaOmO2z26OYhWAF wO40DUK0JugOjhNfrNjioKHEU9SzniClC7ybX7OtUCvN8GCMQkwlGrs8wtL6drrR3eCH 80vEsgoHfyh2aXau/IzwRQ6OZqDnVv4pHOR+vivbkCxw4MdXSO7rskuxX7UZZ/n/Wp8U 8UF/4NJBWpJsaiSpdhN3ySY4gJoc1UxzTzWMzifhWmIwBhsG6eNDsXwlQnKLI1LGjgUm piAg== X-Gm-Message-State: AFuF++m45LmTjgOGijscWMY53bRFBhNtw+Y5ZSav+igEv+XRedGCv5tn iF2VovZW8nrr1+8N6EJdzFTRzlMdj+2qd+9bD+dNhzoKvkshnl84hawhEJGx4Q== X-Gm-Gg: AYBFou3/tZAGsfx9LRlUQwl9j6cgom2r3IIY8gLve/l5b+eeDAO8xFYnQb7jqA/1SH6 yfcjEMvpseVna1GCNz0+LX7Bg6pz9LSxEBIrPuyXu0Injo743lTAxM1PqYVpw6Nh/eVjvBJ3hzw dIfvQ9gLQxjDiiv840RjwzGMeY31XPitvjZkk6XsRWBhBVJQ0ZV6TAM4He1XstSh02GrxDOBm9H M4aDxCy1/aovXCzN0l4xMOcweERP8SkSi9pBWytEMwcGnFQE/EGXDFj4kXkH0i2WBvfPAlqhF9E tJ4johOhhwiZ+MX6gYO357lzjPep1juWGol9ji8IkxzyeW8BXWErp8ja2az3F4lOa6K7HrXDHEy jmnRNOz/wi+ewcPnCaJUnO/kmuyCWnzicfNQ1UtYjMVvlZh4O4tM85tnbeAZKp+GzJdodCRBDbI 0W1zw1cfeyoYfQ60WANh+MP+yMK9UhA6SP9ssgyAAmZWeZBWiUwauQWSsXYAo= X-Received: by 2002:a05:600c:2ad3:b0:4a1:65f4:f94f with SMTP id 5b1f17b1804b1-4a165f4fbaamr5828845e9.1.1790946584715; Fri, 02 Oct 2026 06:09:44 -0700 (PDT) Received: from ars3 ([2a02:8109:8aa6:9c00::763f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48b38104e07sm5374089f8f.31.2026.10.02.06.09.43 for <bug-gnu-emacs@HIDDEN> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Oct 2026 06:09:43 -0700 (PDT) From: Augusto Stoffel <arstoffel@HIDDEN> To: bug-gnu-emacs@HIDDEN Subject: 31.1; Make Comint's prompt highlighting optional X-Debbugs-Cc: Date: Fri, 02 Oct 2026 15:09:42 +0200 Message-ID: <87qzi88d0p.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=arstoffel@HIDDEN; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: I think (personally) that the prompt highlighting feature in Comint is not particularly useful and has false positives, so I'd like to suggest the following reorganization of the code that allows it t [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2001:470:142:0:0:0:0:17 listed in] [list.dnswl.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (arstoffel[at]gmail.com) 1.0 FORGED_GMAIL_RCVD 'From' gmail.com does not match 'Received' headers X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 1.0 (+) --=-=-= Content-Type: text/plain I think (personally) that the prompt highlighting feature in Comint is not particularly useful and has false positives, so I'd like to suggest the following reorganization of the code that allows it to be disabled. WDYT? --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Refactor-Comint-s-prompt-highlighting.patch From 6223ad6afee43167c35ef7e118fef59805f33c18 Mon Sep 17 00:00:00 2001 From: Augusto Stoffel <arstoffel@HIDDEN> Date: Fri, 2 Oct 2026 15:04:56 +0200 Subject: [PATCH] Refactor Comint's prompt highlighting --- lisp/comint.el | 70 ++++++++++++++++++++++++-------------------------- 1 file changed, 34 insertions(+), 36 deletions(-) diff --git a/lisp/comint.el b/lisp/comint.el index e5418f4ee67..3776d9ecea9 100644 --- a/lisp/comint.el +++ b/lisp/comint.el @@ -467,7 +467,7 @@ comint-input-filter-functions These functions get one argument, a string containing the text to send.") ;;;###autoload -(defvar comint-output-filter-functions '(ansi-color-process-output comint-postoutput-scroll-to-bottom comint-watch-for-password-prompt) +(defvar comint-output-filter-functions '(ansi-color-process-output comint-postoutput-scroll-to-bottom comint-watch-for-password-prompt comint-highlight-prompt) "Functions to call after output is inserted into the buffer. One possible function is `comint-postoutput-scroll-to-bottom'. These functions get one argument, a string containing the text as originally @@ -2250,42 +2250,40 @@ comint-output-filter ;; Run these hooks with point where the user had it. (goto-char saved-point) (run-hook-with-args 'comint-output-filter-functions string) - (set-marker saved-point (point)) - - (goto-char (process-mark process)) ; In case a filter moved it. - (unless comint-use-prompt-regexp - (comint--mark-as-output comint-last-output-start (point))) - - ;; Highlight the prompt, where we define `prompt' to mean - ;; the most recent output that doesn't end with a newline. - (let ((prompt-start (save-excursion (forward-line 0) (point))) - (inhibit-read-only t)) - (when comint-prompt-read-only - (with-silent-modifications - (or (= (point-min) prompt-start) - (get-text-property (1- prompt-start) 'read-only) - (put-text-property (1- prompt-start) - prompt-start 'read-only 'fence)) - (add-text-properties prompt-start (point) - '(read-only t front-sticky (read-only))))) - (when comint-last-prompt - ;; There might be some keywords here waiting for - ;; fontification, so no `with-silent-modifications'. - (font-lock--remove-face-from-text-property - (car comint-last-prompt) - (cdr comint-last-prompt) - 'font-lock-face - 'comint-highlight-prompt)) - (setq comint-last-prompt - (cons (copy-marker prompt-start) (point-marker))) - (font-lock-append-text-property prompt-start (point) - 'font-lock-face - 'comint-highlight-prompt) - (add-text-properties prompt-start (point) - `(rear-nonsticky - ,comint--prompt-rear-nonsticky))) - (goto-char saved-point))))))) + (comint--mark-as-output comint-last-output-start + (process-mark process))))))))) + +(defun comint-highlight-prompt (_string) + "Member of `comint-output-filter-functions' to highlight the prompt. +We define `prompt' to mean the most recent output that doesn't end with +a newline." + (let ((prompt-start (save-excursion (forward-line 0) (point))) + (inhibit-read-only t)) + (when comint-prompt-read-only + (with-silent-modifications + (or (= (point-min) prompt-start) + (get-text-property (1- prompt-start) 'read-only) + (put-text-property (1- prompt-start) + prompt-start 'read-only 'fence)) + (add-text-properties prompt-start (point) + '(read-only t front-sticky (read-only))))) + (when comint-last-prompt + ;; There might be some keywords here waiting for + ;; fontification, so no `with-silent-modifications'. + (font-lock--remove-face-from-text-property + (car comint-last-prompt) + (cdr comint-last-prompt) + 'font-lock-face + 'comint-highlight-prompt)) + (setq comint-last-prompt + (cons (copy-marker prompt-start) (point-marker))) + (font-lock-append-text-property prompt-start (point) + 'font-lock-face + 'comint-highlight-prompt) + (add-text-properties prompt-start (point) + `(rear-nonsticky + ,comint--prompt-rear-nonsticky)))) (defun comint--mark-as-output (beg end) (with-silent-modifications -- 2.55.0 --=-=-=--
Augusto Stoffel <arstoffel@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#81974; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.