GNU bug report logs -
#9205
24.0.50; colored mark in vc mode-line
Previous Next
Reported by: pmlists <at> free.fr (Peter Münster)
Date: Sat, 30 Jul 2011 17:59:02 UTC
Severity: wishlist
Tags: patch, wontfix
Found in version 24.0.50
Done: Lars Ingebrigtsen <larsi <at> gnus.org>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 9205 in the body.
You can then email your comments to 9205 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#9205; Package
emacs.
(Sat, 30 Jul 2011 17:59:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
pmlists <at> free.fr (Peter Münster):
New bug report received and forwarded. Copy sent to
bug-gnu-emacs <at> gnu.org.
(Sat, 30 Jul 2011 17:59:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
Hello,
Here a little feature request for vc:
--8<---------------cut here---------------start------------->8---
;; Make it immediately obvious, if file is modified or not, by a red or
;; a green point in the modeline.
;; Code is from psvn.el by Stefan Reichoer (GNU GPL)
(defvar vc-state-mark-modeline t)
(defun vc-mark-modeline-dot (color)
(propertize " "
'display
`(image :type xpm
:data ,(format "/* XPM */
static char * data[] = {
\"18 13 3 1\",
\" c None\",
\"+ c #000000\",
\". c %s\",
\" \",
\" +++++ \",
\" +.....+ \",
\" +.......+ \",
\" +.........+ \",
\" +.........+ \",
\" +.........+ \",
\" +.........+ \",
\" +.........+ \",
\" +.......+ \",
\" +.....+ \",
\" +++++ \",
\" \"};"
color)
:ascent center)))
(defsubst vc-state->color (stat)
"Interpret vc-state symbol to mode line color"
(case stat
('edited "tomato" )
('up-to-date "GreenYellow" )
;; what is missing here??
;; ('unknown "gray" )
;; ('added "blue" )
;; ('deleted "red" )
;; ('unmerged "purple" )
(t "red")))
(defun vc-install-state-mark-modeline (color)
(push `(vc-state-mark-modeline ,(vc-mark-modeline-dot color))
mode-line-format))
(defun vc-uninstall-state-mark-modeline ()
(setq mode-line-format
(remove-if #'(lambda (mode) (eq (car-safe mode)
'vc-state-mark-modeline))
mode-line-format)))
(defadvice vc-default-mode-line-string
(before my-before-vc-mode-line-string activate)
(let* ((backend-name (symbol-name backend))
(state (vc-state file backend))
(color (vc-state->color state)))
(vc-uninstall-state-mark-modeline)
(vc-install-state-mark-modeline color)))
--8<---------------cut here---------------end--------------->8---
Cheers,
--
Peter
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#9205; Package
emacs.
(Tue, 10 Apr 2012 23:59:02 GMT)
Full text and
rfc822 format available.
Message #8 received at 9205 <at> debbugs.gnu.org (full text, mbox):
pmlists <at> free.fr (Peter Münster) writes:
> Here a little feature request for vc:
> ;; Make it immediately obvious, if file is modified or not, by a red or
> ;; a green point in the modeline.
> ;; Code is from psvn.el by Stefan Reichoer (GNU GPL)
I think that looks really nice. The code needs some massaging before
possible inclusion, but, Stefan (the other one), what do you think?
Does Stefan Reichoer have FSF copyright assignment papers on file,
though?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#9205; Package
emacs.
(Wed, 11 Apr 2012 06:45:02 GMT)
Full text and
rfc822 format available.
Message #11 received at 9205 <at> debbugs.gnu.org (full text, mbox):
Lars Magne Ingebrigtsen <larsi <at> gnus.org> writes:
> pmlists <at> free.fr (Peter Münster) writes:
>
>> Here a little feature request for vc:
>> ;; Make it immediately obvious, if file is modified or not, by a red or
>> ;; a green point in the modeline.
>> ;; Code is from psvn.el by Stefan Reichoer (GNU GPL)
>
> I think that looks really nice. The code needs some massaging before
> possible inclusion, but, Stefan (the other one), what do you think?
>
> Does Stefan Reichoer have FSF copyright assignment papers on file,
> though?
Yes. But I don't know think psvn.el is currently covered under his
copyright assignment. If he wants it to be covered, the procedure is
simple: he just has to send an email to fsf-records <at> gnu.org saying that
psvn.el should be covered under his existing assignment.
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#9205; Package
emacs.
(Wed, 11 Apr 2012 07:41:01 GMT)
Full text and
rfc822 format available.
Message #14 received at 9205 <at> debbugs.gnu.org (full text, mbox):
Chong Yidong <cyd <at> gnu.org> writes:
> Lars Magne Ingebrigtsen <larsi <at> gnus.org> writes:
>
>> pmlists <at> free.fr (Peter Münster) writes:
>>
>>> Here a little feature request for vc:
>>> ;; Make it immediately obvious, if file is modified or not, by a red or
>>> ;; a green point in the modeline.
>>> ;; Code is from psvn.el by Stefan Reichoer (GNU GPL)
>>
>> I think that looks really nice. The code needs some massaging before
>> possible inclusion, but, Stefan (the other one), what do you think?
>>
>> Does Stefan Reichoer have FSF copyright assignment papers on file,
>> though?
>
> Yes. But I don't know think psvn.el is currently covered under his
> copyright assignment. If he wants it to be covered, the procedure is
> simple: he just has to send an email to fsf-records <at> gnu.org saying that
> psvn.el should be covered under his existing assignment.
Exactly. psvn.el is not covered. There are way to much contributors to
this package. If somebody is willing to contact them, I am fine with
that. But I don't want to do this.
The code for the color indication was integrated by me. I took the image
definition from somewhere else. The rest of the code was written by me.
Stefan.
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#9205; Package
emacs.
(Thu, 12 Apr 2012 13:42:02 GMT)
Full text and
rfc822 format available.
Message #17 received at 9205 <at> debbugs.gnu.org (full text, mbox):
Stefan Reichör <stefan <at> xsteve.at> writes:
> The code for the color indication was integrated by me. I took the image
> definition from somewhere else. The rest of the code was written by me.
Right. I guess we'd have to make a new image, which should be easy
enough, since it's just a circle.
And the rest of the code can't really be used as in the Emacs tree, so I
guess the copyright state of psvn.el isn't really that important.
But the main question is: Do we want to report the VC state in the mode
line? And if so, do we want to do it this graphically (on graphic
systems)? I think that something like this looks nice, and seems
useful.
What do all y'all think?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#9205; Package
emacs.
(Thu, 12 Apr 2012 14:25:01 GMT)
Full text and
rfc822 format available.
Message #20 received at 9205 <at> debbugs.gnu.org (full text, mbox):
On Thu, Apr 12 2012, Lars Magne Ingebrigtsen wrote:
> But the main question is: Do we want to report the VC state in the mode
> line?
For me it's "yes" (naturally... ;)
> And if so, do we want to do it this graphically (on graphic systems)?
Also yes. For those, who don't want it, there could be a configuration
variable.
--
Peter
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#9205; Package
emacs.
(Thu, 12 Apr 2012 14:38:02 GMT)
Full text and
rfc822 format available.
Message #23 received at 9205 <at> debbugs.gnu.org (full text, mbox):
>> Yes. But I don't know think psvn.el is currently covered under his
>> copyright assignment. If he wants it to be covered, the procedure is
>> simple: he just has to send an email to fsf-records <at> gnu.org saying that
>> psvn.el should be covered under his existing assignment.
> Exactly. psvn.el is not covered. There are way to much contributors to
> this package. If somebody is willing to contact them, I am fine with
> that. But I don't want to do this.
That's just a misunderstanding: the email to fsf-records <at> gnu.org is not
about "all of psvn.el" but only about the part of psvn.el that you wrote
(and it couldn't be any other way, since you have no authority over the
copyright of other contributors).
Stefan
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#9205; Package
emacs.
(Thu, 12 Apr 2012 16:09:01 GMT)
Full text and
rfc822 format available.
Message #26 received at 9205 <at> debbugs.gnu.org (full text, mbox):
>> But the main question is: Do we want to report the VC state in the mode
>> line?
> For me it's "yes" (naturally... ;)
Maybe I misunderstood the question, but we've been reporting the VC
state in the mode-line for as long as I can remember (except for pre-VC
times, obviously). And people don't seem annoyed by it very much, so we
can assume that it's a "yes".
Stefan
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#9205; Package
emacs.
(Thu, 12 Apr 2012 16:11:02 GMT)
Full text and
rfc822 format available.
Message #29 received at 9205 <at> debbugs.gnu.org (full text, mbox):
Stefan Monnier <monnier <at> IRO.UMontreal.CA> writes:
> Maybe I misunderstood the question, but we've been reporting the VC
> state in the mode-line for as long as I can remember (except for pre-VC
> times, obviously). And people don't seem annoyed by it very much, so we
> can assume that it's a "yes".
You mean if you let the mouse hover over the thing that says
"Bzr-<foo>"? I don't see anything that changes visually, though, when a
file changes `vc-state'...
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#9205; Package
emacs.
(Thu, 12 Apr 2012 18:24:01 GMT)
Full text and
rfc822 format available.
Message #32 received at 9205 <at> debbugs.gnu.org (full text, mbox):
>> Maybe I misunderstood the question, but we've been reporting the VC
>> state in the mode-line for as long as I can remember (except for pre-VC
>> times, obviously). And people don't seem annoyed by it very much, so we
>> can assume that it's a "yes".
> You mean if you let the mouse hover over the thing that says
> "Bzr-<foo>"? I don't see anything that changes visually, though, when a
> file changes `vc-state'...
The text is supposed to change between Bzr-nn (unmodified), Bzr:nn
(locally modified), Bzr <at> nn (locally added), ... see
vc-default-mode-line-string.
Stefan
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#9205; Package
emacs.
(Thu, 12 Apr 2012 18:26:01 GMT)
Full text and
rfc822 format available.
Message #35 received at 9205 <at> debbugs.gnu.org (full text, mbox):
Stefan Monnier <monnier <at> IRO.UMontreal.CA> writes:
> The text is supposed to change between Bzr-nn (unmodified), Bzr:nn
> (locally modified), Bzr <at> nn (locally added), ... see
> vc-default-mode-line-string.
Oh. That's really subtle. :-)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#9205; Package
emacs.
(Thu, 12 Apr 2012 18:53:02 GMT)
Full text and
rfc822 format available.
Message #38 received at 9205 <at> debbugs.gnu.org (full text, mbox):
On Thu, Apr 12 2012, Lars Magne Ingebrigtsen wrote:
> Stefan Monnier <monnier <at> IRO.UMontreal.CA> writes:
>
>> The text is supposed to change between Bzr-nn (unmodified), Bzr:nn
>> (locally modified), Bzr <at> nn (locally added), ... see
>> vc-default-mode-line-string.
>
> Oh. That's really subtle. :-)
Indeed. Even too subtle.
My eyes need something more glaring (e.g. a colored mark ... ;)
--
Peter
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#9205; Package
emacs.
(Tue, 01 Mar 2016 01:43:01 GMT)
Full text and
rfc822 format available.
Message #41 received at 9205 <at> debbugs.gnu.org (full text, mbox):
I started to work on this now, but I thought I'd do it with SVGs, since
the size of the mode line can vary, and SVGs can be made on the fly.
However, I'm having trouble creating an SVG with transparent
backgrounds, and it needs to be that, because the mode line changes
background colour when the window is selected or not.
Doesn't Emacs support SVGs with transparent backgrounds?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#9205; Package
emacs.
(Tue, 01 Mar 2016 01:49:02 GMT)
Full text and
rfc822 format available.
Message #44 received at 9205 <at> debbugs.gnu.org (full text, mbox):
Lars Ingebrigtsen <larsi <at> gnus.org> writes:
> I started to work on this now, but I thought I'd do it with SVGs, since
> the size of the mode line can vary, and SVGs can be made on the fly.
>
> However, I'm having trouble creating an SVG with transparent
> backgrounds, and it needs to be that, because the mode line changes
> background colour when the window is selected or not.
>
> Doesn't Emacs support SVGs with transparent backgrounds?
Apparently not...
Anyway, here's as far as I got before I discovered the problem. We
could go with an XPM instead, but it would only approximately match the
height of the mode line, so I'm not sure it's worth it...
diff --git a/lisp/vc/vc-hooks.el b/lisp/vc/vc-hooks.el
index 0c1718e..4a7acb8 100644
--- a/lisp/vc/vc-hooks.el
+++ b/lisp/vc/vc-hooks.el
@@ -717,6 +717,32 @@ vc-mode-line
(force-mode-line-update)
backend)
+(defun vc--face-color (color)
+ (concat
+ "#"
+ (mapconcat
+ (lambda (elem)
+ (format "%02x" (round (* elem 256))))
+ (color-name-to-rgb color)
+ "")))
+
+(defun vc--color-status (string color)
+ (if (not (image-type-available-p 'svg))
+ string
+ (propertize string
+ 'display
+ (let* ((height (- (window-font-height nil 'mode-line) 6))
+ (svg (svg-create height height)))
+ (svg-rectangle svg 0 0 height height
+ :fill-color (vc--face-color
+ (face-background 'mode-line)))
+ (svg-circle svg (/ height 2) (/ height 2) (/ height 2)
+ :fill-color color)
+ (let ((image (svg-image svg)))
+ (setf (image-property image :ascent) 80)
+ (setf (image-property image :scale) 1)
+ image)))))
+
(defun vc-default-mode-line-string (backend file)
"Return a string for `vc-mode-line' to put in the mode line for FILE.
Format:
@@ -739,11 +765,11 @@ vc-default-mode-line-string
(eq state 'needs-update))
(setq state-echo "Up to date file")
(setq face 'vc-up-to-date-state)
- (concat backend-name "-" rev))
+ (concat backend-name (vc--color-status "-" "green") rev))
((stringp state)
(setq state-echo (concat "File locked by" state))
(setq face 'vc-locked-state)
- (concat backend-name ":" state ":" rev))
+ (concat backend-name (vc--color-status ":" "orange") state ":" rev))
((eq state 'added)
(setq state-echo "Locally added file")
(setq face 'vc-locally-added-state)
@@ -751,22 +777,22 @@ vc-default-mode-line-string
((eq state 'conflict)
(setq state-echo "File contains conflicts after the last merge")
(setq face 'vc-conflict-state)
- (concat backend-name "!" rev))
+ (concat backend-name (vc--color-status "!" "red") rev))
((eq state 'removed)
(setq state-echo "File removed from the VC system")
(setq face 'vc-removed-state)
- (concat backend-name "!" rev))
+ (concat backend-name (vc--color-status "!" "red") rev))
((eq state 'missing)
(setq state-echo "File tracked by the VC system, but missing from the file system")
(setq face 'vc-missing-state)
- (concat backend-name "?" rev))
+ (concat backend-name (vc--color-status "?" "purple") rev))
(t
;; Not just for the 'edited state, but also a fallback
;; for all other states. Think about different symbols
;; for 'needs-update and 'needs-merge.
(setq state-echo "Locally modified file")
(setq face 'vc-edited-state)
- (concat backend-name ":" rev)))
+ (concat backend-name (vc--color-status ":" "blue") rev)))
'face face
'help-echo (concat state-echo " under the " backend-name
" version control system"))))
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#9205; Package
emacs.
(Tue, 01 Mar 2016 02:06:02 GMT)
Full text and
rfc822 format available.
Message #47 received at 9205 <at> debbugs.gnu.org (full text, mbox):
Lars Ingebrigtsen <larsi <at> gnus.org> writes:
> I started to work on this now, but I thought I'd do it with SVGs, since
> the size of the mode line can vary, and SVGs can be made on the fly.
I've not read the thread, sorry if I'm off-track. We now have specific
faces for the VC states on the modeline. Not as nifty as images, but you
can know the VC state at a glance.
From the NEWS entry:
*** The VC state indicator in the mode line now has different faces
corresponding to each of the possible states. See the `vc-faces'
customization group.
[snip]
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#9205; Package
emacs.
(Tue, 01 Mar 2016 02:16:01 GMT)
Full text and
rfc822 format available.
Message #50 received at 9205 <at> debbugs.gnu.org (full text, mbox):
Óscar Fuentes <ofv <at> wanadoo.es> writes:
>>From the NEWS entry:
>
> *** The VC state indicator in the mode line now has different faces
> corresponding to each of the possible states. See the `vc-faces'
> customization group.
These all default to the default face? That's not very handy. The
faces should, in my opinion, be nice without having to do any
customisation.
(defface vc-state-base-face
'((default))
"Base face for VC state indicator."
:group 'vc-faces
:group 'mode-line
:version "25.1")
(defface vc-up-to-date-state
'((default :inherit vc-state-base-face))
"Face for VC modeline state when the file is up to date."
:version "25.1"
:group 'vc-faces)
(etc)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#9205; Package
emacs.
(Tue, 01 Mar 2016 02:26:02 GMT)
Full text and
rfc822 format available.
Message #53 received at 9205 <at> debbugs.gnu.org (full text, mbox):
Lars Ingebrigtsen <larsi <at> gnus.org> writes:
> These all default to the default face? That's not very handy. The
> faces should, in my opinion, be nice without having to do any
> customisation.
We discussed this on bug#19043. Feel free to assign nice defaults to
those faces :-)
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#9205; Package
emacs.
(Tue, 01 Mar 2016 03:07:01 GMT)
Full text and
rfc822 format available.
Message #56 received at 9205 <at> debbugs.gnu.org (full text, mbox):
Óscar Fuentes <ofv <at> wanadoo.es> writes:
> Lars Ingebrigtsen <larsi <at> gnus.org> writes:
>
>> These all default to the default face? That's not very handy. The
>> faces should, in my opinion, be nice without having to do any
>> customisation.
>
> We discussed this on bug#19043. Feel free to assign nice defaults to
> those faces :-)
Oh, it's all coming back to me now...
Ok, I'll assign some suitably "fruit salad with a nervous breakdown"
colours. :-)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#9205; Package
emacs.
(Thu, 10 Mar 2016 00:12:02 GMT)
Full text and
rfc822 format available.
Message #59 received at 9205 <at> debbugs.gnu.org (full text, mbox):
More discussion at
https://lists.gnu.org/archive/html/emacs-devel/2016-03/msg00084.html
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#9205; Package
emacs.
(Thu, 27 Jun 2019 16:28:02 GMT)
Full text and
rfc822 format available.
Message #62 received at 9205 <at> debbugs.gnu.org (full text, mbox):
Lars Ingebrigtsen <larsi <at> gnus.org> writes:
> Óscar Fuentes <ofv <at> wanadoo.es> writes:
>
>> Lars Ingebrigtsen <larsi <at> gnus.org> writes:
>>
>>> These all default to the default face? That's not very handy. The
>>> faces should, in my opinion, be nice without having to do any
>>> customisation.
>>
>> We discussed this on bug#19043. Feel free to assign nice defaults to
>> those faces :-)
>
> Oh, it's all coming back to me now...
>
> Ok, I'll assign some suitably "fruit salad with a nervous breakdown"
> colours. :-)
The change wasn't well received at the time (didn't John just revert it
or something?), so I'm closing this bug report.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
Added tag(s) wontfix.
Request was from
Lars Ingebrigtsen <larsi <at> gnus.org>
to
control <at> debbugs.gnu.org.
(Thu, 27 Jun 2019 16:28:02 GMT)
Full text and
rfc822 format available.
bug closed, send any further explanations to
9205 <at> debbugs.gnu.org and pmlists <at> free.fr (Peter Münster)
Request was from
Lars Ingebrigtsen <larsi <at> gnus.org>
to
control <at> debbugs.gnu.org.
(Thu, 27 Jun 2019 16:28:02 GMT)
Full text and
rfc822 format available.
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org.
(Fri, 26 Jul 2019 11:24:05 GMT)
Full text and
rfc822 format available.
This bug report was last modified 4 years and 269 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.