GNU bug report logs - #9231
Use of TAP in Automake's own testsuite: avoid NIH

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 3 Aug 2011 20:14:59 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Aug 03 16:14:58 2011
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1QohqE-0005ma-IJ
	for submit <at> debbugs.gnu.org; Wed, 03 Aug 2011 16:14:58 -0400
Received: from eggs.gnu.org ([140.186.70.92])
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <stefano.lattarini@HIDDEN>) id 1QohqC-0005mT-AD
	for submit <at> debbugs.gnu.org; Wed, 03 Aug 2011 16:14:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefano.lattarini@HIDDEN>) id 1Qohpc-0005lA-5e
	for submit <at> debbugs.gnu.org; Wed, 03 Aug 2011 16:14:20 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,
	RCVD_IN_DNSWL_LOW, T_DKIM_INVALID,
	T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1
Received: from lists.gnu.org ([140.186.70.17]:37446)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefano.lattarini@HIDDEN>) id 1Qohpc-0005kz-0S
	for submit <at> debbugs.gnu.org; Wed, 03 Aug 2011 16:14:20 -0400
Received: from eggs.gnu.org ([140.186.70.92]:54451)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefano.lattarini@HIDDEN>) id 1Qohpa-0003Eq-N0
	for bug-automake@HIDDEN; Wed, 03 Aug 2011 16:14:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefano.lattarini@HIDDEN>) id 1QohpZ-0005jW-Bl
	for bug-automake@HIDDEN; Wed, 03 Aug 2011 16:14:18 -0400
Received: from mail-ww0-f49.google.com ([74.125.82.49]:41829)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefano.lattarini@HIDDEN>) id 1QohpZ-0005jF-46
	for bug-automake@HIDDEN; Wed, 03 Aug 2011 16:14:17 -0400
Received: by wwf22 with SMTP id 22so970987wwf.30
	for <bug-automake@HIDDEN>; Wed, 03 Aug 2011 13:14:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=from:to:subject:date:user-agent:mime-version:content-type
	:content-transfer-encoding:message-id;
	bh=+Imz/V1UxpbHn2ocmLTyYHyhN8zIme4NMLQaUZepOTA=;
	b=xrPkSwoe404TkZasqbxQI+d0bUWC5HBZNJZo0sNLfpVpM2LaX79MDOMdBeSTO438AO
	X5YUzY7aQcjTf2ZoW8gP0WVNcVG4kHmxPnFYN1+0oSoRZx9UlWNstneKiihT9b7pPHb2
	frYcu8QrfmPCrfhE5YRRhtZiC3etIx0ySTaec=
Received: by 10.216.69.130 with SMTP id n2mr3247062wed.53.1312402455339;
	Wed, 03 Aug 2011 13:14:15 -0700 (PDT)
Received: from bigio.localnet
	(host21-92-dynamic.9-87-r.retail.telecomitalia.it [87.9.92.21])
	by mx.google.com with ESMTPS id w45sm768886wec.24.2011.08.03.13.14.14
	(version=TLSv1/SSLv3 cipher=OTHER);
	Wed, 03 Aug 2011 13:14:14 -0700 (PDT)
From: Stefano Lattarini <stefano.lattarini@HIDDEN>
To: bug-automake@HIDDEN
Subject: Use of TAP in Automake's own testsuite: avoid NIH
Date: Wed, 3 Aug 2011 22:14:05 +0200
User-Agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; )
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201108032214.05946.stefano.lattarini@HIDDEN>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)
X-Received-From: 140.186.70.17
X-Spam-Score: -5.9 (-----)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -5.9 (-----)

Severity: wishlist

OK, I gotta admit that the shell-oriented "TAP library" I've introduced in
the 'test-protocols' branch[*] is probably one of worst example of the NIH
syndrome *ever*.  It's mostly OK for the simple uses I've put it to for
the moment, but I can see that, if mismanaged, it could either remain
brittle and inadequate (and force us to write more convoluted, indirected
tests), or, on the other hand, become another complex package-in-a-package
maintainance nightmare.

 [*] See commit `v1.11-920-gc349db0' "testsuite: scaffolding to allow use of
     TAP in our own tests":
  <https://lists.gnu.org/archive/html/automake-patches/2011-08/msg00015.html>

We should fix this creeping NIH-ness in the future, taking inspiration from
pre-existing, real-world TAP generators implementated in the shell; among
them are, e.g.:

  1. The `t/test-lib.sh' library in the Git testsuite:
     <http://git.kernel.org/?p=git/git.git;a=blob;f=t/test-lib.sh>

  2. The `tap/libtap.sh' from the "C TAP Harness" package:
     <http://git.eyrie.org/?p=devel/c-tap-harness.git;a=blob;f=tap/libtap.sh>

Note that those implementations will still require some editing and reshaping
in order to fit in the current Automake testing framework.

Thanks,
  Stefano