Received: (at 9622) by debbugs.gnu.org; 8 Nov 2021 01:13:29 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 07 20:13:29 2021
Received: from localhost ([127.0.0.1]:55386 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1mjtE0-0007wH-RS
for submit <at> debbugs.gnu.org; Sun, 07 Nov 2021 20:13:29 -0500
Received: from mout.web.de ([212.227.15.4]:51491)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <michael_heerdegen@HIDDEN>) id 1mjtDy-0007w3-NF
for 9622 <at> debbugs.gnu.org; Sun, 07 Nov 2021 20:13:27 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de;
s=dbaedf251592; t=1636333997;
bh=dC3N9LAaunkjqOGQvmFKbdlGQUHoOqoXeFEhVlBW3cI=;
h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To;
b=Mh7ZxTerhflRX5bolBBnvL64pWuw2dcLA3ShSTP9aKBbmrw3I9QLwapP23X2+LDHo
NlHevWDPYW50de4cRf7RToJOxeh/Xmb5yoQfxqkDTJEwefd6pd5LLR95T84xaFjKp5
dab/uToGxu1/W5giTc3QZh9zhalsm5NSbaUw5Zs4=
X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9
Received: from drachen.dragon ([92.208.225.87]) by smtp.web.de (mrweb005
[213.165.67.108]) with ESMTPSA (Nemesis) id 1N3ouq-1mb7lN0qrw-00zd5N; Mon, 08
Nov 2021 02:13:17 +0100
From: Michael Heerdegen <michael_heerdegen@HIDDEN>
To: 9622 <at> debbugs.gnu.org
Subject: Re: bug#9622: 23.3; flet indentation
References: <504153FB-8633-4755-A91A-DF5DD64E6FAA@HIDDEN>
<87lf3fntdx.fsf@HIDDEN>
Date: Mon, 08 Nov 2021 02:13:16 +0100
In-Reply-To: <87lf3fntdx.fsf@HIDDEN> (akater's message of "Wed, 29 Sep 2021
18:12:10 +0000")
Message-ID: <878rxz8n6b.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:mIVIX9hhGBgL2/jFGZV+hNwZWu9eoBTaf7QdItDQFmQesw01oPs
/1wZYf5m/76TllJ3KvTg1OBcPCw89DEm523PsvBV4d+pEi/MtMmIe3NYYWy4B/yDHhLmyAV
NoaASbo1J0XbcE1FUVjQIbjWVLztAlxfw8UGmc+m7iVdFKL6I/n5pIZjs5hbsHNCZnrk7kJ
JSmVzSN4vC5a5FB0pS6Uw==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:LD/VL/m/fyc=:9Zs5aCZgD5kpkIbq9nCbvt
wK9VKRBd24aBBpP0YmIQ4WQt9JMG7FSFVI4QnqeTpusHFXm0uPSzrWLId2cdDlPcT/hXTCvdF
w2rGSUyBkqugKClQhI22URcvQqQtMP11DijR20acLtoQqcm9tInEvV3Pu8q6CH1bSAs4C3GEp
wH1esRT8LeEv1KJBSfGtViGh1eMqVzx6O7pzHgcL7DqCK6yfLTWixUTSiC+5JHEH1DmOh/r8B
AigO8xMgkYRD4Bxli1o8/d9rfm2ZW6MHHCGqvddOYh7+1RKEaA08hD+JWOzjpHxbx1W2NeLM3
ZErZCYqsu8TVIGyMilYni34lKpAqgQ1gOarjEzUEwxtccfJ2olA2I71BkwDqfCkLB+6ny/UHv
tw62RFLl5XVjcUJ1X7cY1s8tWwyPMmqEZOBFWgYysiQu+6XK1ZGPLdCN9E+81r58O77B9N8Ri
qKG1F9e1/BUl4fPPshseQ8WTpbaHfRmJzemSDdAYrgvvHQZpC3BcMWh6engVXE46jRrVX7sao
2/AK77a8JasrWuaj6mV9wV7VDnRcX6E94UgErfBIKnPsmZr5DaPgtl76CxLYKpX9m5rrGmpA+
XkBTGLsK/j0qCy1yUlS5U4DkA2ml9rEYBCrCgedntgbiyI32EqsnWbnqiyRMIbYywNhu916JX
NQIZEqQCGGqEZokoWU1kfW+LpDKYnQLNQDenaE4yAE4sQMw4hzF0xA7tzdwW4a3XR6p4Fb64y
wnzUhN56faaD4QxYpsv5H9AiY88Kd//SgF6266W3FRs2UveB/WnssbE2/kHuTWE9VgJAFe3eI
W3fco4LB+4xpI1TCnMxvDK2BkAiqOTcYpLShHUkKhj8822NEMXXemCQ7wDRKavmJ/zMcMamd8
61kXvNHNfzxudGUo6Fr6HueQzi7Dira3WQD5qjYoNFbC5kCDz2lxAoJ7PKcPHO9kBue0Ct/wk
awD+CK9EjtZEYCRjJfE14i9KhK0LLQigLfM+b2ldF5UJnGZsdejsQSNvS9WRNMX+5xZl2P+k/
vlI/eQsaOhlXQbl8Mz4br4olB7SZ4SbWWNCBNaJ2WJUh6aSwAehtAEcjaLNEgVbSBYdTPuiIQ
k204+xLijRcsqQ=
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 9622
Cc: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattiase@HIDDEN>,
Lars Ingebrigtsen <larsi@HIDDEN>, akater <nuclearspace@HIDDEN>,
"Diogo F. S. Ramos" <diogofsr@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
akater <nuclearspace@HIDDEN> writes:
> Several fixes:
> [...]
Am I allowed to report a regression that might be caused by these
changes here?
I have code like this:
#+begin_src emacs-lisp
(cl-flet* ((cont-w/expr (f) (g-w/extended-expr cont f))
(cont-prepend (&rest exps)
(cont-w/expr (lambda (p) (apply #'g--and (append exps (list p)))))))
(pcase expr
((and (let transformed (g--trivial-transformation-p expr)) (guard transformed))
(cont-prepend transformed))))
#+end_src
and the last line gets indented wrongly (one space too less). When I
remove the wrapping `cl-flet*' indentation behavior gets back to the
expected.
Michael.
bug-gnu-emacs@HIDDEN:bug#9622; Package emacs.
Full text available.
Received: (at 9622) by debbugs.gnu.org; 28 Oct 2021 21:53:49 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Oct 28 17:53:49 2021
Received: from localhost ([127.0.0.1]:53432 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1mgDLJ-0001Or-6T
for submit <at> debbugs.gnu.org; Thu, 28 Oct 2021 17:53:49 -0400
Received: from quimby.gnus.org ([95.216.78.240]:39130)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <larsi@HIDDEN>) id 1mgDLD-0001OZ-A7
for 9622 <at> debbugs.gnu.org; Thu, 28 Oct 2021 17:53:47 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID
:In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID:
Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
List-Post:List-Owner:List-Archive;
bh=7ivN94YbqDBbfjeptT0WCPn1b8hIPhbPdSSlOsqhHz0=; b=G6N2v6AJGa2ijbL0fV244SQrqG
IFt2jrFtOFCyEfkilvH4vmKWDD4H9m6HvlfFxKWEg+BfzbEPmW4baPG2yONrErXaHoU5dH+gc6lMg
ztCNQIchnJYiC3kUnIZwpn7JBf1MQDB6okCg0zukr+6BLcir1GZV72gnHG385gLOZSIk=;
Received: from [84.212.220.105] (helo=elva)
by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.92) (envelope-from <larsi@HIDDEN>)
id 1mgDL3-00023Y-IH; Thu, 28 Oct 2021 23:53:36 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: akater <nuclearspace@HIDDEN>
Subject: Re: bug#9622: [PATCH] Re: bug#9622: 23.3; flet indentation
References: <504153FB-8633-4755-A91A-DF5DD64E6FAA@HIDDEN>
<87lf3fntdx.fsf@HIDDEN> <87tui26027.fsf@HIDDEN>
<87r1d62owt.fsf@HIDDEN> <8735pm2nai.fsf@HIDDEN>
<87a6junp3j.fsf@HIDDEN> <87ilyhx9wb.fsf@HIDDEN>
<871r4ud5gz.fsf@HIDDEN> <87v926o303.fsf@HIDDEN>
<87k0hxj6m6.fsf@HIDDEN>
X-Now-Playing: Joni Mitchell's _Dog Eat Dog_: "Lucky Girl"
Date: Thu, 28 Oct 2021 23:53:33 +0200
In-Reply-To: <87k0hxj6m6.fsf@HIDDEN> (akater's message of "Thu, 28 Oct 2021
19:23:45 +0000")
Message-ID: <874k903jfm.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
@@CONTACT_ADDRESS@@ for details.
Content preview: akater <nuclearspace@HIDDEN> writes: > New patch supports
incomplete sexps and adds tests for them. > > “test-identation” ert test
in elisp-mode-tests.el does pass. Thanks; seems to work well, so this is
now pushed to the trunk.
Content analysis details: (-2.9 points, 5.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 9622
Cc: "Basil L. Contovounesios" <contovob@HIDDEN>,
Mattias =?utf-8?Q?Engdeg?= =?utf-8?Q?=C3=A5rd?= <mattiase@HIDDEN>,
9622 <at> debbugs.gnu.org, "Diogo F. S. Ramos" <diogofsr@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
akater <nuclearspace@HIDDEN> writes:
> New patch supports incomplete sexps and adds tests for them.
>
> =E2=80=9Ctest-identation=E2=80=9D ert test in elisp-mode-tests.el does pa=
ss.
Thanks; seems to work well, so this is now pushed to the trunk.
--=20
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
bug-gnu-emacs@HIDDEN:bug#9622; Package emacs.
Full text available.
Received: (at 9622) by debbugs.gnu.org; 28 Oct 2021 19:35:37 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Oct 28 15:35:37 2021
Received: from localhost ([127.0.0.1]:53282 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1mgBBZ-00025x-5o
for submit <at> debbugs.gnu.org; Thu, 28 Oct 2021 15:35:37 -0400
Received: from mail-lf1-f54.google.com ([209.85.167.54]:43716)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <nuclearspace@HIDDEN>) id 1mgBBX-00025k-1P
for 9622 <at> debbugs.gnu.org; Thu, 28 Oct 2021 15:35:35 -0400
Received: by mail-lf1-f54.google.com with SMTP id bq11so15832804lfb.10
for <9622 <at> debbugs.gnu.org>; Thu, 28 Oct 2021 12:35:34 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
h=from:to:cc:subject:in-reply-to:references:date:message-id
:mime-version; bh=vNWYMRU+MaiG1nR8IJs6ZgwJga3fYRAJ6UmXsKV0Dtw=;
b=J2uxCJouj6H0+2mrXcoPI3XBoXGv1QrYCXgOTd2I/yTKTf3cU50F3g7rXLGd7FrGwe
TRlAgrK77HJLaydL5llh8y+6z5C+wvNRNoDeQMyryaiRBGcLIb75jv5zv3BGG5OK7SlO
Bc7foa50bvS7tKfNdvewT1/2ht92TOT41gMmgcbqpuEYjQPXzRZR3fEoU3rG3DO8iSra
TFWzNVYC6MPXkU9J5jE4sxjL0mjSi0+Z1KAAfJqVs0C9s25rVK2BnlF+J3+q/jxEtn2i
KIueYGxuUNlW1HJ0j/DdTPai0UL9LvxXTA0v0igJ/OuqVZ4aeL9kYOByN1NsI/dZNYJM
FlHg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date
:message-id:mime-version;
bh=vNWYMRU+MaiG1nR8IJs6ZgwJga3fYRAJ6UmXsKV0Dtw=;
b=mtO5WzuL2XigrARyf0SjWFdBf7a3WVeA3JSfMaIuh+XjhyVPPgpBJF5poCeDIwcvRz
QGQaYGJa84BFn2lGCbdaaRYioG/8/6CuIe+7/g+vAtsz1mIKq1MhXsd2gE4yxH+EAh+I
SIG/ezOIJ8KQQLwTlPFkw/iv1juaTU38cVizIwPAoJjixUZwQGHxvyDKDBEqktbuIAfw
GGJ0i1aa37HdjzwBO85OaOUWrcJl6saS1mLJ9E3JiFs5fsS+UkJj/liGrNV2Xo6FJb5X
2rOM7C8bYyNntNpbJxKzwCVWHLiTpM0Xsp2OtH7vqzzt//8iRjdl1/91pUqG0nXmhOip
h4BA==
X-Gm-Message-State: AOAM532YimtHt+CvnbfPTXUgXwpEbpo1ecFVuveXYFKF+jmg/5PlgWDD
sIu5IHg1cy1HQJcK5I95JMg=
X-Google-Smtp-Source: ABdhPJxbXGfd9mck2tDFbNmLqkoxQjsat5/6JjDnBP3Kc8XcoFYgDY0fKvhBdGU7xgOjpxlNBG8WvQ==
X-Received: by 2002:ac2:4e6b:: with SMTP id y11mr6200117lfs.439.1635449728830;
Thu, 28 Oct 2021 12:35:28 -0700 (PDT)
Received: from localhost ([89.248.168.244])
by smtp.googlemail.com with ESMTPSA id o21sm402037lfu.77.2021.10.28.12.35.27
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 28 Oct 2021 12:35:28 -0700 (PDT)
From: akater <nuclearspace@HIDDEN>
To: Lars Ingebrigtsen <larsi@HIDDEN>
Subject: Re: bug#9622: [PATCH] Re: bug#9622: 23.3; flet indentation
In-Reply-To: <87v926o303.fsf@HIDDEN>
References: <504153FB-8633-4755-A91A-DF5DD64E6FAA@HIDDEN>
<87lf3fntdx.fsf@HIDDEN> <87tui26027.fsf@HIDDEN>
<87r1d62owt.fsf@HIDDEN> <8735pm2nai.fsf@HIDDEN>
<87a6junp3j.fsf@HIDDEN> <87ilyhx9wb.fsf@HIDDEN>
<871r4ud5gz.fsf@HIDDEN> <87v926o303.fsf@HIDDEN>
Date: Thu, 28 Oct 2021 19:23:45 +0000
Message-ID: <87k0hxj6m6.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 9622
Cc: "Basil L. Contovounesios" <contovob@HIDDEN>,
Mattias =?utf-8?Q?Engdeg?= =?utf-8?Q?=C3=A5rd?= <mattiase@HIDDEN>,
9622 <at> debbugs.gnu.org, "Diogo F. S. Ramos" <diogofsr@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: multipart/signed; boundary="==-=-=";
micalg=pgp-sha512; protocol="application/pgp-signature"
--==-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
New patch supports incomplete sexps and adds tests for them.
=E2=80=9Ctest-identation=E2=80=9D ert test in elisp-mode-tests.el does pass.
--==-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQJLBAEBCgA1FiEEgu5SJRdnQOF34djNsr6xYbHsf0QFAmF6+MQXHG51Y2xlYXJz
cGFjZUBnbWFpbC5jb20ACgkQsr6xYbHsf0Q25A//TI7+fuHJSs9jD7znH9R7I05j
Hox1JP02hcUxNnGYQYEoSMAGvqICMs1p+ZLiWdypcr6ywEqmNs2lYtyIHqBaRSlW
a5SagalEMfeOA3OwbOzoK5oFLz0CzvieM86kUlV2HEfE4LEXtr487KJiWuN0omv+
bDKgRB6Y9DgcwO3c4cv7ug+ABDPtPtdsPKlA/tUOSsIWGpqzS/T7rVZP3Iv1FObU
PhHMNMwKFoofsl5qEenEhTV8CbXKxPRyM0bYpxsMI2yXE9wj97tXrSaiihPnMjhZ
u5orP2hznlLJSwRZeQXIJOM4pOU+LzJnyrFYyTzLV1OLY7ysMoxjjymyduE/lBBE
w5/FvAc+sJOX78sfe7fe7My5s2jNp3ZRfiqBhANDtjUSe9LmxTMV2rrofR1I0Apf
7swTnJzdnEZn3/6El67kl3z2CpiQQvEZuXs9xSb8XrJiu+ECA8l75hH+fsi3swt5
nXyN9rIv3Lhjryxv9m2EGras9FiA22z7iVRXJUyoju8mv1Ja86CUlQKaq3tDMzIp
45GTa2O7KqdY6tvCH63Z4usb+a7zE1K7pqYMSgLIGfXuaOFg/7vFAT8m+5k54kSU
dizPu++BoUPc12WL3lUTkeUE3YDE5zAgSA2oDLuZGJQOICBQfhsYPJ4J4SEyMrlV
x600BeuYFvsxwnVz1L8=
=obX0
-----END PGP SIGNATURE-----
--==-=-=--
--=-=-=
Content-Type: text/x-diff; charset=utf-8
Content-Disposition: attachment;
filename=0001-Indent-cl-flet-like-forms-correctly-in-incomplete-ex.patch
Content-Transfer-Encoding: quoted-printable
Content-Description: Support incomplete sexps when indenting cl-flet-like forms
From c3edf97a4f39044885a8bc544a31762ba9a28695 Mon Sep 17 00:00:00 2001
From: akater <nuclearspace@HIDDEN>
Date: Mon, 18 Oct 2021 03:08:06 +0000
Subject: [PATCH] Indent cl-flet-like forms correctly in incomplete expressi=
ons
* lisp/emacs-lisp/lisp-mode.el
(lisp--local-defform-body-p): Support incomplete sexps
* test/lisp/progmodes/elisp-mode-resources/flet.erts:
Add tests for incomplete sexps
---
lisp/emacs-lisp/lisp-mode.el | 74 +++++------
.../progmodes/elisp-mode-resources/flet.erts | 121 ++++++++++++++++++
2 files changed, 153 insertions(+), 42 deletions(-)
diff --git a/lisp/emacs-lisp/lisp-mode.el b/lisp/emacs-lisp/lisp-mode.el
index 5dfb1fae356..15afdef0252 100644
--- a/lisp/emacs-lisp/lisp-mode.el
+++ b/lisp/emacs-lisp/lisp-mode.el
@@ -1114,56 +1114,46 @@ defun lisp--local-defform-body-p (state)
STATE is the `parse-partial-sexp' state for current position."
(when-let ((start-of-innermost-containing-list (nth 1 state)))
(let* ((parents (nth 9 state))
- (second-cons-after (cddr parents))
- second-order-parent)
+ (first-cons-after (cdr parents))
+ (second-cons-after (cdr first-cons-after))
+ first-order-parent second-order-parent)
(while second-cons-after
(when (=3D start-of-innermost-containing-list
(car second-cons-after))
- (setq second-order-parent (car parents)
+ (setq second-order-parent (pop parents)
+ first-order-parent (pop parents)
;; Leave the loop.
second-cons-after nil))
(pop second-cons-after)
(pop parents))
(when second-order-parent
- (save-excursion
- (goto-char (1+ second-order-parent))
- (and (when-let ((head (ignore-errors
- ;; FIXME: This does not distinguish
- ;; between reading nil and a read error.
- ;; We don't care but still, better fix t=
his.
- (read (current-buffer)))))
- (memq head '( cl-flet cl-labels cl-macrolet cl-flet*
- cl-symbol-macrolet)))
- ;; Now we must check that we are
- ;; in the second element of the flet-like form.
- ;; It would be easier if `parse-partial-sexp' also recorded
- ;; relative positions of subsexps in supersexps
- ;; but it doesn't so we check manually.
- ;;
- ;; First, we must be looking at list now.
- (ignore-errors (when (=3D (scan-lists (point) 1 0)
- (scan-sexps (point) 1))
- ;; Looking at list; descend into it:
- (down-list 1)
- t))
- ;; In Wishful Lisp, the following form would be
- ;; (cl-member start-of-innermost-containing-list
- ;; (points-at-beginning-of-lists-at-this-level)
- ;; :test #'=3D)
- (cl-loop
- with pos =3D (ignore-errors
- ;; The first local definition may be indented
- ;; with whitespace following open paren.
- (goto-char (scan-lists (point) 1 0))
- (goto-char (scan-lists (point) -1 0))
- (point))
- while pos
- do (if (=3D start-of-innermost-containing-list pos)
- (cl-return t)
- (setq pos (ignore-errors
- (goto-char (scan-lists (point) 2 0))
- (goto-char (scan-lists (point) -1 0))
- (point)))))))))))
+ (let (local-definitions-starting-point)
+ (and (save-excursion
+ (goto-char (1+ second-order-parent))
+ (when-let ((head (ignore-errors
+ ;; FIXME: This does not distinguish
+ ;; between reading nil and a read erro=
r.
+ ;; We don't care but still, better fix=
this.
+ (read (current-buffer)))))
+ (when (memq head '( cl-flet cl-labels cl-macrolet cl-fl=
et*
+ cl-symbol-macrolet))
+ ;; In what follows, we rely on (point) returning non-=
nil.
+ (setq local-definitions-starting-point
+ (progn
+ (parse-partial-sexp
+ (point) first-order-parent nil
+ ;; From docstring of `parse-partial-sexp':
+ ;; Fourth arg non-nil means stop
+ ;; when we come to any character
+ ;; that starts a sexp.
+ t)
+ (point))))))
+ (ignore-errors
+ ;; We rely on `backward-up-list' working
+ ;; even when sexp is incomplete =E2=80=9Cto the right=E2=
=80=9D.
+ (backward-up-list 2)
+ t)
+ (=3D local-definitions-starting-point (point))))))))
=20
(defun lisp-indent-function (indent-point state)
"This function is the normal value of the variable `lisp-indent-function=
'.
diff --git a/test/lisp/progmodes/elisp-mode-resources/flet.erts b/test/lisp=
/progmodes/elisp-mode-resources/flet.erts
index 447cf08cc25..7c4a0f304e9 100644
--- a/test/lisp/progmodes/elisp-mode-resources/flet.erts
+++ b/test/lisp/progmodes/elisp-mode-resources/flet.erts
@@ -220,3 +220,124 @@ Name: flet15
h
i)))
=3D-=3D-=3D
+
+Name: flet-indentation-incomplete-sexp-no-side-effects-1
+Code: (lambda () (emacs-lisp-mode) (setq indent-tabs-mode nil) (newline ni=
l t))
+Point-Char: |
+
+=3D-=3D
+(let ((x (and y|
+=3D-=3D
+(let ((x (and y
+ |
+=3D-=3D-=3D
+
+Name: flet-indentation-incomplete-sexp-no-side-effects-2
+
+=3D-=3D
+(let ((x|
+=3D-=3D
+(let ((x
+ |
+=3D-=3D-=3D
+
+Name: flet-indentation-incomplete-sexp-missing-whitespace-1
+Point-Char: |
+
+=3D-=3D
+(cl-flet((f (x)|
+=3D-=3D
+(cl-flet((f (x)
+ |
+=3D-=3D-=3D
+
+Name: flet-indentation-incomplete-sexp-missing-whitespace-2
+Point-Char: |
+
+=3D-=3D
+(cl-flet((f(x)|
+=3D-=3D
+(cl-flet((f(x)
+ |
+=3D-=3D-=3D
+
+Name: flet-indentation-incomplete-sexp-missing-whitespace-3
+
+=3D-=3D
+(cl-flet ((f(x)|
+=3D-=3D
+(cl-flet ((f(x)
+ |
+=3D-=3D-=3D
+
+Name: flet-indentation-incomplete-sexp-missing-whitespace-4
+
+=3D-=3D
+(cl-flet( (f (x)|
+=3D-=3D
+(cl-flet( (f (x)
+ |
+=3D-=3D-=3D
+
+Name: flet-indentation-incomplete-sexp-missing-whitespace-5
+
+=3D-=3D
+(cl-flet( (f(x)|
+=3D-=3D
+(cl-flet( (f(x)
+ |
+=3D-=3D-=3D
+
+Name: flet-indentation-incomplete-sexp-missing-and-excessive-whitespace-1
+
+=3D-=3D
+(cl-flet((f (x)|
+=3D-=3D
+(cl-flet((f (x)
+ |
+=3D-=3D-=3D
+
+Name: flet-indentation-incomplete-sexp-missing-and-excessive-whitespace-2
+
+=3D-=3D
+(cl-flet ((f(x)|
+=3D-=3D
+(cl-flet ((f(x)
+ |
+=3D-=3D-=3D
+
+Name: flet-indentation-incomplete-sexp-missing-and-excessive-whitespace-3
+
+=3D-=3D
+(cl-flet( (f (x)|
+=3D-=3D
+(cl-flet( (f (x)
+ |
+=3D-=3D-=3D
+
+Name: flet-indentation-incomplete-sexp-missing-and-excessive-whitespace-4
+
+=3D-=3D
+(cl-flet( (f (x)|
+=3D-=3D
+(cl-flet( (f (x)
+ |
+=3D-=3D-=3D
+
+Name: flet-indentation-incomplete-sexp-missing-and-excessive-whitespace-5
+
+=3D-=3D
+(cl-flet( (f (x)|
+=3D-=3D
+(cl-flet( (f (x)
+ |
+=3D-=3D-=3D
+
+Name: flet-indentation-incomplete-sexp-missing-and-excessive-whitespace-6
+
+=3D-=3D
+(cl-flet( (f(x)|
+=3D-=3D
+(cl-flet( (f(x)
+ |
+=3D-=3D-=3D
--=20
2.32.0
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#9622; Package emacs.
Full text available.Received: (at 9622) by debbugs.gnu.org; 9 Oct 2021 11:24:07 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 09 07:24:07 2021 Received: from localhost ([127.0.0.1]:52395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mZASV-00020K-88 for submit <at> debbugs.gnu.org; Sat, 09 Oct 2021 07:24:07 -0400 Received: from quimby.gnus.org ([95.216.78.240]:60766) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <larsi@HIDDEN>) id 1mZASU-0001zn-3O for 9622 <at> debbugs.gnu.org; Sat, 09 Oct 2021 07:24:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=K9z+EitIRcYMqh3LP64yNyerOfSWG17SM7XXTVhQ8r8=; b=k+kVu8hMZP6gpIiIJ0ucFhtC+h L8wig1ZHkVgCfPKmr4Tacq6EYry8m9xmUQUuvtwMj6xGecK+XHiLvwkzWCnbGQnDTMAFdEIjEn4vp JvX39zQJ9+uplZnS5dABQLy+RCyxioPVV17u2Wxp7fGiiQDK5xruJKF3jdaELpbsgx/E=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <larsi@HIDDEN>) id 1mZASL-0004qq-4c; Sat, 09 Oct 2021 13:23:59 +0200 From: Lars Ingebrigtsen <larsi@HIDDEN> To: akater <nuclearspace@HIDDEN> Subject: Re: bug#9622: [PATCH] Re: bug#9622: 23.3; flet indentation References: <504153FB-8633-4755-A91A-DF5DD64E6FAA@HIDDEN> <87lf3fntdx.fsf@HIDDEN> <87tui26027.fsf@HIDDEN> <87r1d62owt.fsf@HIDDEN> <8735pm2nai.fsf@HIDDEN> <87a6junp3j.fsf@HIDDEN> <87ilyhx9wb.fsf@HIDDEN> <871r4ud5gz.fsf@HIDDEN> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEUkHxswKiQVEhFf VFCilpD///85qtkRAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+UKCQsPE7KWxUoAAAGxSURBVDjLrVTb kdwwDJN4DZDmFUBrG7BPbiBj919TAMqPZC/5yEw0s7uWAYIgZG8pY+n5KVae1bB+2UorLcC4KXH/ JtG+rRO/too77aHpfVmqQqH+CZgofSL6AFYFgAgRCTjHBTaK2mEGe4VbLb6agiCwgSaYoBo0sbd1 tflDRav516RBJc4H3jRbVRE3X0ZPcKwWE8gqc8Bk7EEux0+cI8SEmIp3c3Alhl0pIVUYBN1qkyuS TFAig+c07QbGPRBUAqpy1z4hCfghqJasjtl7347jsMIpJMVgEgWf1vcESkqlE+Aa/rETWKjCaNgE DSXcflBqIR85Rz4VzM6nedsHkI6v5yQ8bD82ADlJsLnUBF57R8lSOEieTHaL6r7D1rawwQCCcUT4 sXcgCxsPgK7p6lgvoPFDefoI/7R9R3MdbAAYgnG6bWmXbNzJ009/Xo5+bH0ZrccweeEtU1xOt6wY BG/mqMEcbRyVBBSDk68zSvRUyBjTHaRm+LUbKHwME3idFRLPi8bmNr1WHNR0S11A3zYA69c7cD0M 78D52kp5l/q2/ieQr27Jr9//Nuwv69+Bnw57ZtnpcaJwAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIx LTEwLTA5VDExOjE1OjE5KzAwOjAwnaRekAAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0xMC0wOVQx MToxNToxOSswMDowMOz55iwAAAAASUVORK5CYII= X-Now-Playing: Throwing Muses's _Chains Changed_: "Cry Baby Cry" Date: Sat, 09 Oct 2021 13:23:56 +0200 In-Reply-To: <871r4ud5gz.fsf@HIDDEN> (akater's message of "Sat, 09 Oct 2021 07:26:04 +0000") Message-ID: <87v926o303.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: akater <nuclearspace@HIDDEN> writes: > In what follows, ^ points to the appropriate position after RET is pressed. > > The last case that broke my patch: > (let ((x (and y > > ^ I think these tests should be fine for erts-mode. Just put Point-Char: ^ into the header and make the test be (newline). Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 9622 Cc: "Basil L. Contovounesios" <contovob@HIDDEN>, Mattias =?utf-8?Q?Engdeg?= =?utf-8?Q?=C3=A5rd?= <mattiase@HIDDEN>, 9622 <at> debbugs.gnu.org, "Diogo F. S. Ramos" <diogofsr@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) akater <nuclearspace@HIDDEN> writes: > In what follows, ^ points to the appropriate position after RET is pressed. > > The last case that broke my patch: > (let ((x (and y > > ^ I think these tests should be fine for erts-mode. Just put Point-Char: ^ into the header and make the test be (newline). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no
bug-gnu-emacs@HIDDEN:bug#9622; Package emacs.
Full text available.
Received: (at 9622) by debbugs.gnu.org; 9 Oct 2021 07:37:47 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 09 03:37:47 2021
Received: from localhost ([127.0.0.1]:52249 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1mZ6vT-0006d8-Fp
for submit <at> debbugs.gnu.org; Sat, 09 Oct 2021 03:37:47 -0400
Received: from mail-il1-f177.google.com ([209.85.166.177]:44992)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <nuclearspace@HIDDEN>) id 1mZ6vR-0006cs-Uk
for 9622 <at> debbugs.gnu.org; Sat, 09 Oct 2021 03:37:46 -0400
Received: by mail-il1-f177.google.com with SMTP id j8so421825ila.11
for <9622 <at> debbugs.gnu.org>; Sat, 09 Oct 2021 00:37:45 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
h=from:to:cc:subject:in-reply-to:references:date:message-id
:mime-version; bh=Bnkzl5KuiuSP+Ndd+Rp/loqoeuGqlqCARwv6KV61InE=;
b=SmBowmm/WquUKAamORiyZ/rM1BrQfC6Xi+urogpglkTJsTWaocCx+2797K0PCD3zBq
Fpw8rQ+ZjSRp4Ayz3aW1iPA4IBRlxcNAkBh2I5m42S0WbRy9cFmz9xO4+qPAhbWY8EPa
a5LVcJdA/Mgqb4ayGzlmJHltdstX7ij7OJNyxVy2qq+/DcqxCMyJZ2ySMb6pbvx7hy05
1UslYitmdVLv6ftH6QCYnYYsh8OHCO2NpalJZ2VG23GRFP8NROSl4ZRN0hzUI0L+7wMa
6druykYyuUKF8al6Fdi5SOq3YphsbZWAg9JzaPSVAs1H+uy4F8FDtQtmWb+MXubFCHIr
bdNQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date
:message-id:mime-version;
bh=Bnkzl5KuiuSP+Ndd+Rp/loqoeuGqlqCARwv6KV61InE=;
b=Q0QDJjZogWALpCYuE+nTgxKwOUyqBta/h2xVZmXeGTw8ofII7o+Nlq8c3cLlXHFa77
YAmGWjeyAGZJCTDDGiOi7oOgU52PqjbTnjp3lwBydjutKOpncHcm+ocRvIwF37drlgN6
Bhr3BnNulOVDml8e+WlTe54zn2VB8A9ZCBJ7EAEw/xDhydQBONerqFNSoAIvAFnINsmV
AQKjo0bys8Rp6V4x/Vi3Tilj09RW21gShdOSPOcjC1sttsXQKduwO3Xs78nI5fLPZSe+
HXsj8kFKI3NCgrN5+5WBG5lwLXHQ5mBdr/W+/S5jM4+uo1Wih2LsY5EsKJnDdJ9TC3q7
o9PA==
X-Gm-Message-State: AOAM531KAJB8IAqgndX68AE8OrP24G95NqjKCPYSo6/hYvILoyqrGPYf
6+bp23VcfEisf4WDd60Lq2A=
X-Google-Smtp-Source: ABdhPJyYXlJTxIabmGcjcy98sCKH25WetPsujREHCR/d78h3STu1ZhIoWix2A9uI1pKkxf7QX9lA7A==
X-Received: by 2002:a05:6e02:17c6:: with SMTP id
z6mr10748085ilu.185.1633765060293;
Sat, 09 Oct 2021 00:37:40 -0700 (PDT)
Received: from localhost ([23.154.177.130])
by smtp.googlemail.com with ESMTPSA id g3sm770283ile.61.2021.10.09.00.37.39
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sat, 09 Oct 2021 00:37:39 -0700 (PDT)
From: akater <nuclearspace@HIDDEN>
To: Lars Ingebrigtsen <larsi@HIDDEN>
Subject: Re: bug#9622: [PATCH] Re: bug#9622: 23.3; flet indentation
In-Reply-To: <87ilyhx9wb.fsf@HIDDEN>
References: <504153FB-8633-4755-A91A-DF5DD64E6FAA@HIDDEN>
<87lf3fntdx.fsf@HIDDEN> <87tui26027.fsf@HIDDEN>
<87r1d62owt.fsf@HIDDEN> <8735pm2nai.fsf@HIDDEN>
<87a6junp3j.fsf@HIDDEN> <87ilyhx9wb.fsf@HIDDEN>
Date: Sat, 09 Oct 2021 07:26:04 +0000
Message-ID: <871r4ud5gz.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 9622
Cc: "Basil L. Contovounesios" <contovob@HIDDEN>,
Mattias =?utf-8?Q?Engdeg?= =?utf-8?Q?=C3=A5rd?= <mattiase@HIDDEN>,
9622 <at> debbugs.gnu.org, "Diogo F. S. Ramos" <diogofsr@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Lars Ingebrigtsen <larsi@HIDDEN> writes:
> akater <nuclearspace@HIDDEN> writes:
>
>> I don't think so. The first attempt was written in a hurry, and merged
>> without extensive testing; in the second I did exhaustive tests, it just
>> never crossed my mind to test on unbalanced expressions. This very much
>> looks like the last ignore-errors of them:
>
> Thanks, but I think we're just too late to get this into Emacs 28, so I
> resurrected your patch series and pushed it as one patch to the trunk.
> (I also added all the test cases from your second patch to ert.)
>
> Please have a look and see if I missed something when I did the merge.
Everything from my last patch is in its place (my branch is even with
master, and 15 tests are there) but:
We need to also include partial sexps, and a test should ensure RET brings
point to the proper position. I have not familiarized myself with this test
routine yet so I'm not sure how to do this right. The important aspect I w=
ant
to point out now is, especially since previous partial sexps affect the
indentation of all consequent sexps, we must ensure this will not affect bo=
th
the =E2=80=9CRET tests=E2=80=9D and tests where the region is indented. Th=
is presumes all our
test cases will reside in a single file but they should be because otherwis=
e it
will be terrible. This is important enough so I write this message in adva=
nce
even though the indentation is sometimes wrong and I've not yet figured it =
out.
Here go =E2=80=9CRET test cases=E2=80=9D; looks like they are exhaustive, m=
odulo variations
with longer excessive whitespace. Not everything of what follows is indent=
ed
correctly with my patch. I'm investigating; some issues might be present e=
ven
without my patch.
In what follows, ^ points to the appropriate position after RET is pressed.
The last case that broke my patch:
(let ((x (and y
^
A variation of it, just in case:
(let ((x
^
; N.B.: This is the way it is in elisp-mode right now but in lisp-mode, the=
point is one step further.
5 cases with some whitespace missing:
flet-missing-whitespace-1
(cl-flet((f (x)
^
flet-missing-whitespace-2
(cl-flet((f(x)
^
flet-missing-whitespace-3
(cl-flet ((f(x)
^
flet-missing-whitespace-4
(cl-flet( (f (x)
^
flet-missing-whitespace-5
(cl-flet( (f(x)
^
Combinations of missing and excessive whitespace
flet-missing-and-excessive-whitespace-1
(cl-flet((f (x)
^
flet-missing-and-excessive-whitespace-2
(cl-flet ((f(x)
^
flet-missing-and-excessive-whitespace-3
(cl-flet( (f (x)
^
flet-missing-and-excessive-whitespace-4
(cl-flet( (f (x)
^
flet-missing-and-excessive-whitespace-5
(cl-flet( (f (x)
^
flet-missing-and-excessive-whitespace-6
(cl-flet( (f(x)
^
There's another problem: in some of these cases, even though initial
indentation is incorrect, once the sexp is completed, it is indented correc=
tly.
But in some other cases, it's not! I'm looking into this.
--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQJLBAEBCgA1FiEEgu5SJRdnQOF34djNsr6xYbHsf0QFAmFhRAwXHG51Y2xlYXJz
cGFjZUBnbWFpbC5jb20ACgkQsr6xYbHsf0Tjrg//cXF7txcHMtsKGfhJmUG/26In
hq9Hv6Qf43d59bST1xJHGGZcX/MGDdfyZsHK9OxhaKe0PcaZELU1/8zgY0WVTNB/
5b9SKk829c2YN33urFzHe5kFeDIKo9ga28w1/hy3NlPxs8BaGTAgU2iBQUOpQxtC
GtxyuTEnGTOITz15psCnhvkFlo7JhQ4Cj2vZLIu5uu3bPG/FQGuLxiJZVW/r62/N
Xn5480MwTDvqtZ6dbIkjmkmgZq2XuuxYp6OFLYs/sqa5hMc2NslLU7czVYStLygs
LfN0w4/8XUH8XeEnAfmhHkH/LsXSnIQEFo0Fo/wKASSZTujJi/bIEKbX2Bdv0AYr
ogMyHSBjW75RT/ewQcl0oP7hojMJh70HK5u1KuCWT4wDLh8MCmdpzRw/V9uRj8zE
MVR1+ELQwiW+xft9cp8k7uuKJLfAkICL4F7RlBPI7pX0UT1oGeDOpNx44W4CSSQ0
SPkSTHtFc2CSLrGmyHaQ1zWmfWZE+Z/YaKpZKj1+RBtt2VvZvgSf+Z4Ct+6WkFYY
kg+9GPstItxM5uCXYETa+gtefvBUWdouU0vafW7WxY11fjK95I/0jZn5CRA5g6Zo
8/qyCSESuZ+6VsaAwJ3BwjGKmsOiEKPn1cm1Xo8hryH81YNofmpZk+7AmMKDDKo9
Z72P74Luzns8MbwuGv4=
=JZWI
-----END PGP SIGNATURE-----
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#9622; Package emacs.
Full text available.Received: (at 9622) by debbugs.gnu.org; 1 Oct 2021 11:27:47 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Oct 01 07:27:47 2021 Received: from localhost ([127.0.0.1]:54816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mWGhf-0002Uy-Fc for submit <at> debbugs.gnu.org; Fri, 01 Oct 2021 07:27:47 -0400 Received: from quimby.gnus.org ([95.216.78.240]:52818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <larsi@HIDDEN>) id 1mWGhb-0002Ui-Cd for 9622 <at> debbugs.gnu.org; Fri, 01 Oct 2021 07:27:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=WiB1ntR1N/3CnJaZTZDOFtdlbCqNNJBx6jNX8YIQI0o=; b=ZvQChjxwFl6+6pY6Km7YgfIX3q t2vqP7Vn3AiAPFkhLv4RnSNS2pEEp7MUsLSFQqnNpXurFP1USOg2gyTLn6iYrvHg7NIdGQIgiM2b7 O1NCberpsyGPXlaLWRfSX7dNd9XerojtZBEJBjhoLxiJ9CKXinh9o0BPF3jqdHRXetpk=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <larsi@HIDDEN>) id 1mWGhR-0008SA-Tk; Fri, 01 Oct 2021 13:27:36 +0200 From: Lars Ingebrigtsen <larsi@HIDDEN> To: akater <nuclearspace@HIDDEN> Subject: Re: bug#9622: [PATCH] Re: bug#9622: 23.3; flet indentation References: <504153FB-8633-4755-A91A-DF5DD64E6FAA@HIDDEN> <87lf3fntdx.fsf@HIDDEN> <87tui26027.fsf@HIDDEN> <87r1d62owt.fsf@HIDDEN> <8735pm2nai.fsf@HIDDEN> <87a6junp3j.fsf@HIDDEN> X-Now-Playing: The Notwist's _Vertigo Dubs Vol. 1: Odd Nosdam_: "Ship (Odd Nosdam Remix)" Date: Fri, 01 Oct 2021 13:27:32 +0200 In-Reply-To: <87a6junp3j.fsf@HIDDEN> (akater's message of "Thu, 30 Sep 2021 13:57:04 +0000") Message-ID: <87ilyhx9wb.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: akater <nuclearspace@HIDDEN> writes: > I don't think so. The first attempt was written in a hurry, and merged > without extensive testing; in the second I did exhaustive tests, it just > never crossed my mind to test on unbalanced expres [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 9622 Cc: "Basil L. Contovounesios" <contovob@HIDDEN>, Mattias =?utf-8?Q?Engdeg?= =?utf-8?Q?=C3=A5rd?= <mattiase@HIDDEN>, 9622 <at> debbugs.gnu.org, "Diogo F. S. Ramos" <diogofsr@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) akater <nuclearspace@HIDDEN> writes: > I don't think so. The first attempt was written in a hurry, and merged > without extensive testing; in the second I did exhaustive tests, it just > never crossed my mind to test on unbalanced expressions. This very much > looks like the last ignore-errors of them: Thanks, but I think we're just too late to get this into Emacs 28, so I resurrected your patch series and pushed it as one patch to the trunk. (I also added all the test cases from your second patch to ert.) Please have a look and see if I missed something when I did the merge. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no
bug-gnu-emacs@HIDDEN:bug#9622; Package emacs.
Full text available.Received: (at 9622) by debbugs.gnu.org; 30 Sep 2021 23:35:17 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Sep 30 19:35:17 2021 Received: from localhost ([127.0.0.1]:54320 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mW5a7-0001Wi-VF for submit <at> debbugs.gnu.org; Thu, 30 Sep 2021 19:35:17 -0400 Received: from mail-ed1-f45.google.com ([209.85.208.45]:45755) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <nuclearspace@HIDDEN>) id 1mW5a1-0001WI-KJ for 9622 <at> debbugs.gnu.org; Thu, 30 Sep 2021 19:35:14 -0400 Received: by mail-ed1-f45.google.com with SMTP id r18so28011360edv.12 for <9622 <at> debbugs.gnu.org>; Thu, 30 Sep 2021 16:35:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=dxejHDtD14bYQwWl0UXkg1T5VCnwxazhFT+fc0HGTSg=; b=JelOw3xxUYKqfT2Gpn8USEZ/AJsv6ldPKIL6XYUiAKGUmNyoXAZpgGIe2mvJtWKnIO 8BHb+6Ok2KqwfX4LL0trzf5ZH6Dg/h7RBmITIxbSuC5gNo29enVVuVOjxgPX5GuzM3iF XO4MSiTY/bgzYVcCILQ8DDvAYcoPFIKDlwmrfxb3ClC9Prdyx7lBKwqlhjPAEAajwn7m RPYZto/6W+kczGPS0MGgXfvny8N038Lh15sjAbb2IvkzZYv+0qOyjFFhTu/8eDAophrN eLYV7EYApdI3YF49Uy9EgY0223HuEWjLJA4IoEfUQTbrdwDrXwPJ0ZYVoFXNRUxrRkJx Qfpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=dxejHDtD14bYQwWl0UXkg1T5VCnwxazhFT+fc0HGTSg=; b=C1tWlhHsym7M8m+KFtql63tybwFB1URNQGazMG8qnUOWTQUfmn5NHtBvZ0dJ6blL3e zGOb3Hu26x1wkR+NNFcjRJe+jBh0xSO8UoGpBKdyYL1aAKVLeyVcXGnNBdRLKtrPMbug zkNaRc5lbnvUdPNP2/HTiYBzXKFxcPjdt8vLZm1QHHkxRIEcux/vvgjZ4h+bCNNg0eRp yzlwIDI6pU3JjtfksexstG6Vx1TvpNzkrrBCQpBioTQ6Eh2kRz7jqFkt7ORyYc3zcH/R i3f375BZ1X3nbk8YSYmo0UElTPEs/lnD4qrDxpQWxn077DCFRg7F8hricBiyF1LN+YLz MBHA== X-Gm-Message-State: AOAM531bmd9M8ughlsVDDXeCPHGDIjsKKc0pfKciXYr9qfRhscokE17K Nt/taVVYzBa5en2myyeLSIeGNHMrUaUoLiTYpOU= X-Google-Smtp-Source: ABdhPJwTZ8NoAHgAOe40ECsS/w3JMF7sF7K8eFEDIey2DxAD6i5r6NMY4HOY3+4zazO+JS/jP3ljQw== X-Received: by 2002:a05:6402:21ef:: with SMTP id ce15mr10223691edb.19.1633044903383; Thu, 30 Sep 2021 16:35:03 -0700 (PDT) Received: from localhost ([185.31.175.207]) by smtp.googlemail.com with ESMTPSA id p8sm2034239ejo.2.2021.09.30.16.35.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Sep 2021 16:35:03 -0700 (PDT) From: akater <nuclearspace@HIDDEN> To: 9622 <at> debbugs.gnu.org Subject: Re: bug#9622: [PATCH] Re: bug#9622: 23.3; flet indentation In-Reply-To: <87wnmxoob9.fsf@miha-pc> References: <504153FB-8633-4755-A91A-DF5DD64E6FAA@HIDDEN> <87lf3fntdx.fsf@HIDDEN> <87tui26027.fsf@HIDDEN> <87r1d62owt.fsf@HIDDEN> <A5C97667-7C05-4558-B5BC-94CB5728D566@HIDDEN> <87lf3eqesu.fsf@HIDDEN> <C32B2FBD-379A-441A-A637-CA36EC57F94A@HIDDEN> <87sfxmm50f.fsf@HIDDEN> Date: Thu, 30 Sep 2021 23:23:39 +0000 Message-ID: <87pmspmyv8.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 9622 Cc: miha@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Thank you. This is already covered by the last patch.
bug-gnu-emacs@HIDDEN:bug#9622; Package emacs.
Full text available.
Received: (at 9622) by debbugs.gnu.org; 30 Sep 2021 19:25:21 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Sep 30 15:25:21 2021
Received: from localhost ([127.0.0.1]:54044 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1mW1gH-0003bA-JZ
for submit <at> debbugs.gnu.org; Thu, 30 Sep 2021 15:25:21 -0400
Received: from kamnitnik.top ([209.250.245.214]:52116)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <miha@HIDDEN>) id 1mW1gC-0003av-Jy
for 9622 <at> debbugs.gnu.org; Thu, 30 Sep 2021 15:25:20 -0400
Received: from localhost (BSN-77-156-43.static.siol.net [193.77.156.43])
by kamnitnik.top (Postfix) with ESMTPSA id 8B1259CFA8;
Thu, 30 Sep 2021 19:25:14 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kamnitnik.top;
s=mail; t=1633029914;
bh=y0roalKd4AfAg3K0Wxz3lwMgbTsimE/XlzOtAQ3M158=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=QqzUSHxMrTAwObDOVzsQucvFIf/dt8hY4xlBPv/P18eqRNz7Gb+KcwfF8R2zRCt1l
22IvNXa4iAscMW3tClWYgOwflR3i9NBuepQlDyXWpbBEi077gprmxqEUFdk3v+wSlj
JINsHq1Ad+vMG3XMoMM92VehaRCIafm20/Z10P8x32ama+f+bzilkar7EX4MFT2X7G
dFErxWfS0qwSuqKtVll89AVhZWu7TkWvVzgm7Q3nIfmM5dwYH0rAlTkLYixL+x+E0S
+WrihSC6BaZ/0qJsTgf+aDDoYrjO81vqCFs2oYHjdc5WNc+rWqz02iTsp/rBBLjFth
gPy9laCophsQg==
From: miha@HIDDEN
To: "Basil L. Contovounesios" <contovob@HIDDEN>, Lars Ingebrigtsen
<larsi@HIDDEN>
Subject: Re: bug#9622: [PATCH] Re: bug#9622: 23.3; flet indentation
In-Reply-To: <87r1d62owt.fsf@HIDDEN>
References: <504153FB-8633-4755-A91A-DF5DD64E6FAA@HIDDEN>
<87lf3fntdx.fsf@HIDDEN> <87tui26027.fsf@HIDDEN>
<87r1d62owt.fsf@HIDDEN>
Date: Thu, 30 Sep 2021 21:28:42 +0200
Message-ID: <87wnmxoob9.fsf@miha-pc>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
micalg=pgp-sha256; protocol="application/pgp-signature"
X-Spam-Score: 2.5 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: > Thanks,
but I found another indentation regression introduced
in > 38037e04cb that does not involve flet and is not fixed by c42af5aee7:
> > 0. emacs -Q > 1. (let ((x (and y RET > I also found a reg [...]
Content analysis details: (2.5 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 SPF_PASS SPF: sender matches SPF record
2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs
[URI: kamnitnik.top (top)]
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
0.5 FROM_SUSPICIOUS_NTLD From abused NTLD
X-Debbugs-Envelope-To: 9622
Cc: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattiase@HIDDEN>, 9622 <at> debbugs.gnu.org,
akater <nuclearspace@HIDDEN>, "Diogo F. S. Ramos" <diogofsr@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 2.5 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: > Thanks, but I found another indentation regression introduced
in > 38037e04cb that does not involve flet and is not fixed by c42af5aee7:
> > 0. emacs -Q > 1. (let ((x (and y RET > I also found a reg [...]
Content analysis details: (2.5 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 SPF_PASS SPF: sender matches SPF record
2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs
[URI: kamnitnik.top (top)]
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
0.5 FROM_SUSPICIOUS_NTLD From abused NTLD
1.0 BULK_RE_SUSP_NTLD Precedence bulk and RE: from a suspicious TLD
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager
--=-=-=
Content-Type: text/plain
> Thanks, but I found another indentation regression introduced in
> 38037e04cb that does not involve flet and is not fixed by c42af5aee7:
>
> 0. emacs -Q
> 1. (let ((x (and y RET
>
I also found a regression that you might want to add as a test case: on
Emacs commit c006286780, Evaluating the following form would signal an
"Invalid read syntax" error:
(pp `[((1 (okno . ,(current-buffer))))])
Best regards.
--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQJHBAEBCAAxFiEEmxVnesoT5rQXvVXnswkaGpIVmT8FAmFWD+oTHG1paGFAa2Ft
bml0bmlrLnRvcAAKCRCzCRoakhWZP6GzEAC+s1HQg0QiyBfiWCY2HhGFk1Y0Ua+i
PgMnAQmWgzmr4e0SVzSsaHvyGFBIZPgRiqMIydXYCVgqPiu8pUFOZP7xgoCjkyjj
yp3rcBSo6BmMaKODu6CutKaHYD/Gv1IKWEli+Vu2crcRgTghDYdo6DH9KRIISULJ
eRIizWIEZystcczzy2cUR5EPtGsdWtvpZBc0MCUQJ65AuhZLvDk4ZQMMJ3CDB7IZ
HWc7ecsLKSkdc5nTpvCO6VmYB60X0Lmt4YcJVyMXE00VY3ClX/g8y4O6x8kFLVPN
xaqQlh+jla9OfI/29gpMLaNFRjLVipH5YEHp6Rxn7zb26QQIAsJKufdFxQetBoeq
j2KrI/j94sVQnyjy/r8ssRDy4J+LCkx4SnbxpwTmGTtN6uYD/e7NHIyiihtWXOXs
wKSVNqx2rj/RKrMqkJmJIfMRfCPEUbPtma9oq5opYi5mwV0nsTDI4QPKFkRJi881
9OhnE8gWM6oGrvI9wJD28lD0zMzRrPTQldsG7pcs5dm45TfGy61dgE7KWcZ5jw83
Ph8eBPcGhLMY2JaVD8Y+rcgcendcNa0nFW1puK82sPkR+hAxg8tx3dTCwehxyF2v
FHTOocAKG1ZMaVtQftyZOhzh0qs/Jg3qwfmjDqeulrtuQILIjrwZguw78EKnwenX
saA99dnRGq+RyA==
=ttMB
-----END PGP SIGNATURE-----
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#9622; Package emacs.
Full text available.Received: (at 9622) by debbugs.gnu.org; 30 Sep 2021 16:07:55 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Sep 30 12:07:55 2021 Received: from localhost ([127.0.0.1]:53758 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mVybD-0004er-8J for submit <at> debbugs.gnu.org; Thu, 30 Sep 2021 12:07:55 -0400 Received: from mail-wr1-f43.google.com ([209.85.221.43]:38627) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <nuclearspace@HIDDEN>) id 1mVyb9-0004eV-1U for 9622 <at> debbugs.gnu.org; Thu, 30 Sep 2021 12:07:54 -0400 Received: by mail-wr1-f43.google.com with SMTP id u18so10977937wrg.5 for <9622 <at> debbugs.gnu.org>; Thu, 30 Sep 2021 09:07:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=HEqfi16tEkMEEW8fx5Hh6zPvS0pYdm4Xq4E/9zMFgsM=; b=TmOKcM1ZsUeIuUyiyTVKrtZQzrEymPDEqdP/pvzynbkF/L7tFrYvMdHtOmUQ3gfvHK e2/4eu8aAKpFyjjvYYV0r/rrkJqSk3metSEcK695TgSVI6/UlqOlB2btbh+Iki/Wld6Y E3u45nFchdKvnWg052WkI1SbiGqdoILNmG4GPtxcEjpAIi2dRIX2hIE3nAPz3eIU36+A WCo87ONFvb70+C5mabm0oHqen+89UuUojS7K1nuthv9NFAxuiu6+0tFI5fyBl5oC/KDf UUcX04qsTOQAuaDOMjVZe/WgEZtJssfIIu+TyUXtGkCSOzvgbyF4W7Qz6CtVBdQJtkIP iELQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=HEqfi16tEkMEEW8fx5Hh6zPvS0pYdm4Xq4E/9zMFgsM=; b=zNI0xU/eGvQ4yG/BFQZiSKxCgBTWLD7Mx6UsY+thdabGp/LAeCgYLtn7Vachs80irh wudF/ZrHgq3UIgXC/05e3ot/l5DrFV1zgGJU6M/Qy+G4zMi3Me/+2nZBttBy2eA2OPRN fRf5wbrmS75iuTK2kJ2ZLNQPdDbBiStwzVxI5J5d99h3dlQPPq3Vo2pIKpuYcO4Gc/i1 2/6LamiOMdF3lC9bpCuQm2CxKuJgvIcALvDhcuKSDiyn3aIqfFjlQkXNknsjLGJBNPH9 8G9M4+PDFU9MTGJooXoSO013r9GI9+3lRPVF98c+sHbTGoJ023VIGWu7LOQif7Vi7l94 0sEQ== X-Gm-Message-State: AOAM530uXSnQ/2rbllN3w+smqB6oExi02q2j+hY8at++TZPcjUxgu9ye ecWSNqnWxhtYp4+jXM32cs4= X-Google-Smtp-Source: ABdhPJyUiL8KvGiI1fYxqfP0TWrDYJCVs/MiCRqlwPdyOLTycFHtuIBf2uM/9Uo1NMXlWrES+KtUig== X-Received: by 2002:a5d:4a4e:: with SMTP id v14mr7185030wrs.271.1633018065261; Thu, 30 Sep 2021 09:07:45 -0700 (PDT) Received: from localhost (tor-exit-relay-6.anonymizing-proxy.digitalcourage.de. [185.220.102.252]) by smtp.googlemail.com with ESMTPSA id l2sm5002860wmi.1.2021.09.30.09.07.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Sep 2021 09:07:44 -0700 (PDT) From: akater <nuclearspace@HIDDEN> To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattiase@HIDDEN> Subject: Re: bug#9622: [PATCH] Re: bug#9622: 23.3; flet indentation In-Reply-To: <C32B2FBD-379A-441A-A637-CA36EC57F94A@HIDDEN> References: <504153FB-8633-4755-A91A-DF5DD64E6FAA@HIDDEN> <87lf3fntdx.fsf@HIDDEN> <87tui26027.fsf@HIDDEN> <87r1d62owt.fsf@HIDDEN> <A5C97667-7C05-4558-B5BC-94CB5728D566@HIDDEN> <87lf3eqesu.fsf@HIDDEN> <C32B2FBD-379A-441A-A637-CA36EC57F94A@HIDDEN> Date: Thu, 30 Sep 2021 15:56:16 +0000 Message-ID: <87sfxmm50f.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 9622 Cc: Lars Ingebrigtsen <larsi@HIDDEN>, 9622 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable I don't see this as hostile. I didn't expect my original one-off suggestion to be merged this soon anyway. But I still think we were going the most efficient way of producing the aforementioned =E2=80=9Cand m= ore=E2=80=9D tests. Lars, when the method is established to use external file like flet-tests.sexp (with the last unbalanced example and its variations to be added) rather than strings, let me know, I'll write the tests. As much as I want local definers indented correctly, getting these strings into tests verbatim is too much. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJLBAEBCgA1FiEEgu5SJRdnQOF34djNsr6xYbHsf0QFAmFV3iAXHG51Y2xlYXJz cGFjZUBnbWFpbC5jb20ACgkQsr6xYbHsf0RRqBAAxQHfYHj2xkuSTTEAR8v/l7IR rBo5KykJouzRn9a1QwUKPd2GykpElYcGNgVlY+iTCPHp8Sp+v7d6rPDR7YEKviP4 TWLjTJxs5Q3URpY7p5jp9yUvD75678u01bwMxsT/TNe/wdyVV3rE2qg6piTeMKbv i3YT/WRINoZV4z75oRUzXTwCFub8Vn7CK+V6Qx/rN4rxfpuVCnnVZyEOzkt1gN6r yylEkUo3B/BJFh7i/F5mxiGb8bQF2mQdi2G7+6AV33/ZSwA/gfgKpF5pxszPGL8/ iPk9Gr07vfm+2XZuCDIcaNC6rC08uu53DWg/ORxQmR/ub6U0TqPfB3L8j08lg+Hl gbT8olmeRiTahm/MuYvRQiAhuPUqHJd0V9Fkq+6o6bufdbR9AZ4TfxRQDQSrkUN6 Q5z8I6K0Rx8zw1gSkL/IS+iyDztgPib+Sr9kfcFpw2+XPWsF+CNRT8LuJTUpR0ya PNLNVPl7sIA8Avprcs450ysuOklXeCi8A1aqGSW8nWjOL4znz43tkJZsDuWxMHlO A8PpamH8x13XSEPtW87zwwxxmZUO6wdApMuXagmIqqylMA2MCeE9ZA5nxBjj4N1+ 43w4PYleZ1kmPmTiC5vuOei0+g/o7xRKQkNGI03CpFB0megMjgP1tZZgcqKonf0U lmqXnjVnSU9b//eKrSQ= =J0KI -----END PGP SIGNATURE----- --=-=-=--
bug-gnu-emacs@HIDDEN:bug#9622; Package emacs.
Full text available.Received: (at 9622) by debbugs.gnu.org; 30 Sep 2021 16:04:27 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Sep 30 12:04:27 2021 Received: from localhost ([127.0.0.1]:53754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mVyXq-0004XV-Ps for submit <at> debbugs.gnu.org; Thu, 30 Sep 2021 12:04:26 -0400 Received: from mout01.posteo.de ([185.67.36.65]:46087) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <thievol@HIDDEN>) id 1mVyXm-0004X6-K4 for 9622 <at> debbugs.gnu.org; Thu, 30 Sep 2021 12:04:25 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 372F124002A for <9622 <at> debbugs.gnu.org>; Thu, 30 Sep 2021 18:04:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1633017856; bh=ADBX+3Yn42TzJpddMlLZKwIAhptHu1XEhJUJf3OVplk=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=QTvmvx+IAby1bbF1T2aDPauUbDzk/s6qO2Pav9EmlIR2LowaDVh28PpbEgSxVnCSS OnV2fUW0wGy6RtWsaUMCEgcMjh5DYpPV1pdee9dOrysF+0+F+VS9Zn2SJN2MYLo4ab LoXVPV9QvpJHZZenMOKY2eoqBrw9VpUhB0BPtxM7kvSMMY7a+DdQG5qQBpMNyEA2Mt j3iBCbghs9K0ysF7iJIvMcdWmAcjR/HhPV139PqXg5iZYvQjvGiLO2F1V5bFMnUwL/ 7I1yqIXBxHTLojg4Y5yw6PAPCgwTwendNkVAFcuiUukXO6oxsKFcXfINcfkUcHZFrH i27SB4l1GQaTg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4HKyjT4ssTz9rxP; Thu, 30 Sep 2021 18:04:13 +0200 (CEST) From: Thierry Volpiatto <thievol@HIDDEN> To: akater <nuclearspace@HIDDEN> Subject: Re: bug#9622: [PATCH] Re: bug#9622: 23.3; flet indentation References: <504153FB-8633-4755-A91A-DF5DD64E6FAA@HIDDEN> <87lf3fntdx.fsf@HIDDEN> <87tui26027.fsf@HIDDEN> <87r1d62owt.fsf@HIDDEN> <A5C97667-7C05-4558-B5BC-94CB5728D566@HIDDEN> <87lf3eqesu.fsf@HIDDEN> <87czoqytmn.fsf@HIDDEN> <87y27em61q.fsf@HIDDEN> Autocrypt: addr=thievol@HIDDEN; prefer-encrypt=mutual; keydata= mQGNBF8ylcIBDADG+hy+zR6L4/vbdDDZuSaMmSrU3A5QZJpeBCvxTr7MpzzruZbhLPW1K3R6N2MA edi8Y+C8o27FVRIjpdbaKMGu9je7JV/TbUQYo3SOwCK1vM4LUn4V6ZLzSYkuiEt4eyMoiDdyvN0p kcK6P9x9DCetcEVszXzQg+yzCVrQ2hXWDXWT4M18EC3wtO7RHPouMqGiwBFhBAYErCqFWFxQHkfb tG/4yGyJ58rglb65O3qijjMWvYwcWZun9/7qm8Z4/4mHopmo2zgU+OrptnLSZfkZGz3Y7Uf452xQ GVq0Fv75NPvQru7y+DYVhuVXXyAmGxt+vf4rIiixMBbhKEPjcxEPAa2LTzex2IsTZR+QVG9uDnqC WcgaOEQ58fzXNvNhtwwF/Rgio2XWAJVdmFWS59/k9W58CIUSNKBMZh2XeGdEmtHvDtCxW3z6FJha 36RzOM3fMNNiAGdFZJA84gcdloJR+sHCDTTPT3784fjr+V8An7sI581NGFzkRQqPvEQCZbUAEQEA AbQSdGhpZXZvbEBwb3N0ZW8ubmV0iQHUBBMBCgA+FiEEI9twfRN7r3nig/xwDsVtFB0W75MFAl8y lcICGwMFCQPCZwAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQDsVtFB0W75MB3QwAlTsVzFmr +S/tMKwwwOibjhNPi/OZiUC2AYfaqfVAiIHDT3RbzDe03sAJoomJkJnYVjGzQZwibCMO2+ITkMPV 2wvrd4CbgS1KCVbrltwcuK/nxPCBaHytOCZUIInnhJo5PE/h03K0rWhUFLDocpnWwI7mPq33oR9N u2XMNtUQeWhhZHj8dvpMazWIR/c4iPnQiIobETISNlKIVo7DZSl67btoBrZygVYobgHpAYLBpHtH pXUcfM+Jrl8ytLouZ2XYeqzezr1qUDXhPk6mXtEVLJsK4FSS4wT5hPpRozuIwj6sE8OGJIp5uUhm SYm9mjRNJBEgmGUNxMQ/wbcA3NEWxBeIZbRvxMgHG47GJ0TJM4xLpGC8BHUZvuIw05gAtgoA3BGh 5GXbLWy4fi8ozJA/kCkP43d3zh4wTOfQterVTf90bbw6NiNcmXdKH7E/yO1or06bleza39PJsshX 8EETESzVIifk2yDnc0/CQ+FrLY9IwOOszkMouFXmiwN1xMkjuQGNBF8ylcIBDADnIDHEkmk4lUwT lOhwb2yjUfmGPnpH3MCCHkjM9H/P1gTHxFWtwFVPcNMCwXWvKSBTF2dZXKERD0yzG06zT53ZMN7E IIeuY6m4R8IcMvpohciisWxbFoB4ZY117tVSeqjo946itgbpdeESKl9a8dpn7ytZMyYxPdojlQAq xeAJ8444raESh1oTKXb64hlk4l2pSRlrLgjpJBo8asAfZndaxIUKhw68tV8sqeZh9P6cGtHbUELK VJqefNV7V7jF5wf3xvRG6Ces3kSKXalLfs+vrVaoOjQeWrc0AtwFWHmt9JLfKrqF+Q2Q7jUidboW mazQM56ESJFPpPHmWq8k6DHspsFHOforLouTHJL1556IPne7IV2BGfWc0+xLxalZ8F5F+vnPF/Ok rC1CD5iCKTjXKa2iZbcYdYQAiL6P8Ac8CgN6EkhpbxRtzrEgChuNGevdi/G/GHG4Zqrh6YFwIa/N Hq2aVaFq5C1yNTMJd1FRjRzs5JPPlJKpYDnNx+MSp7UAEQEAAYkBvAQYAQoAJhYhBCPbcH0Te695 4oP8cA7FbRQdFu+TBQJfMpXCAhsMBQkDwmcAAAoJEA7FbRQdFu+TXsEL/3nCs8oDLBSTPXylenWK CYLdfZSg8jmwgRKihktU1ZLf8kL/LtEhxdKc9nYQO0gTYdPQ+HEdFbm+gFZ4AxuCtd5zM+MP5Sej pfr93QbLwYCiqsudKa+T7wosBBNFnh8ZQkbnsF6iPIeESCJM0Vhjh1lQ+z1qVkdf/yazwmXspOUh 3kx8dzJQ1F3t6Dj/zHpdNE11bT6wFwTPBFvFeH0yCwDpvVcLbH0xf/0V/RhwkQ4jjae0Cqn8domz RpGODjXkAzoRqpRL9/DvIKTQ/uJQqzu6qvi04foFCmtWTSahJiLtbgHSDNj1HHOivtgeTgtVdAEk ZAqAXJfmaM8KkEi8Rqcbz3AzkjNWjQNkel0xjB3wkewds1iGcvo2/etWOXcvFiLUpy7YnLMZ4J6d jNpwSwDzxvJVy0OvB9SgVF0hX5DdbKTRBSZpGYQgoVdPelGnqs6uq8fa1Ker587E6O6haTIX779d pd5UIX75/XbtumwE0L+IvMpekoM9zH8pCowu4g== Date: Thu, 30 Sep 2021 16:04:11 +0000 In-Reply-To: <87y27em61q.fsf@HIDDEN> (akater's message of "Thu, 30 Sep 2021 15:33:53 +0000") Message-ID: <875yuiyrr8.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 9622 Cc: contovob@HIDDEN, mattiase@HIDDEN, larsi@HIDDEN, 9622 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) akater <nuclearspace@HIDDEN> writes: > Thierry Volpiatto <thievol@HIDDEN> writes: > >> Note that using `common-lisp-indent-function` as `lisp-indent-function` = in >> emacs-27.2 make `cl-flet` and friends indent properly, with a few more >> settings for `cl-loop` indentation it is perfect, did I miss something? > > In general, the languages are different and rules should be expected to > be different. cl- indenter takes care of #(..) and so on which is > meaningless in Elisp. > > I also think common-lisp-indent-function should not attempt to indent > cl- stuff and likewise lisp-indent-function should not indent plain flet > and so on because plain ones are =E2=80=9Cofficially deprecated=E2=80=9D. > > It would make more sense to have a generic sexp indenter and > dialect-specific indenters that inherit from it. But inheritance > practices in Emacs is in terrible shape: inheritance mechanisms have > been reinvented in incompatible ways since forever. Thanks for explanations, make sense. --=20 Thierry
bug-gnu-emacs@HIDDEN:bug#9622; Package emacs.
Full text available.Received: (at 9622) by debbugs.gnu.org; 30 Sep 2021 15:45:40 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Sep 30 11:45:40 2021 Received: from localhost ([127.0.0.1]:53729 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mVyFg-0003sh-Gj for submit <at> debbugs.gnu.org; Thu, 30 Sep 2021 11:45:40 -0400 Received: from mail-io1-f47.google.com ([209.85.166.47]:40681) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <nuclearspace@HIDDEN>) id 1mVyFc-0003sN-Dv for 9622 <at> debbugs.gnu.org; Thu, 30 Sep 2021 11:45:39 -0400 Received: by mail-io1-f47.google.com with SMTP id r75so8149507iod.7 for <9622 <at> debbugs.gnu.org>; Thu, 30 Sep 2021 08:45:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=P9WtY2ue8dvg9W44Hzas29ywW6+ZGAOnyfWyX+3uo5s=; b=O7R6+3T+ojRoONW0mJzDn/am0Qmjb7G9dfsPKuQXRGytB45qv6pWOaeTeLzzLZ+mAL WSa1w0MnE8qGfa/a9gDlrXw0ZEUxhZ0X0HbE3GjXWSbN1D6aAxu9YLDl0CzPBni8rvKW 6v0RZ/ioeNu72a9eLRg6Bk2tT70ChPzzh/Z8ToXNYzTVPfAoROyR4fSBHxFxJvCBESLG 3g/7y33Mj7dvunnAsbSNVEwP4u4nuOY61UL8wntnYZXHm+YNFXrehAT/nB6t3ySxO5La FFPU2Zo6uVcHsJdEjuBVFBLNuIos9FjvMpzQZzDHIdb0ay3gTgfQHzHqftEbzihHzgxT 8qtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=P9WtY2ue8dvg9W44Hzas29ywW6+ZGAOnyfWyX+3uo5s=; b=rTOiUWAhbyBqGcGVQACPaFj70+maMZNCCYpkJqL8VysDrukWZyjXbGsA7/4RRtjyr2 Yw0RY163ZP3zNeqIuC2HwPz5vUQUq7/A7aTd1PiXEIknYsIc4NHHxApI5t8HEe1Mbfei bQw33zMpK6FVyLpzQ8qmgI9AqPXKIWVsIpwEDfJekDHBIBPsOKFJ4zUa0B2+HKo+OHdI BOU240mD2A5cs1W6RPVUtHbSLoqhrzae7aZqPqXbxxUYsotHG5nE+itoQpvynC63T6hb vlouXXhnjCgQFEHlpmIXv0Q2M9DnQcRUSm+R7oNd+Y8A9ZxpaEUEAZsJNWmVXpSY+cJr 2hvw== X-Gm-Message-State: AOAM530fo6EA05ksyOYqxa2xdZH4mz9VjzPAwTHqAmTxJCKz8hjG6VyD 6izgmYXA5UrM+QzXhPlWXZI= X-Google-Smtp-Source: ABdhPJwBsJ8Hvo2E4hM4kIMe4h9CgU1nTJMLxn5uHXd5nOdtemswhn2SzN28I+oK5KIuHXHyyTaf4g== X-Received: by 2002:a02:a48:: with SMTP id 69mr5381010jaw.144.1633016730825; Thu, 30 Sep 2021 08:45:30 -0700 (PDT) Received: from localhost ([23.154.177.66]) by smtp.googlemail.com with ESMTPSA id m2sm1376537ilg.45.2021.09.30.08.45.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Sep 2021 08:45:30 -0700 (PDT) From: akater <nuclearspace@HIDDEN> To: Thierry Volpiatto <thievol@HIDDEN>, "Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> Subject: Re: bug#9622: [PATCH] Re: bug#9622: 23.3; flet indentation In-Reply-To: <87czoqytmn.fsf@HIDDEN> References: <504153FB-8633-4755-A91A-DF5DD64E6FAA@HIDDEN> <87lf3fntdx.fsf@HIDDEN> <87tui26027.fsf@HIDDEN> <87r1d62owt.fsf@HIDDEN> <A5C97667-7C05-4558-B5BC-94CB5728D566@HIDDEN> <87lf3eqesu.fsf@HIDDEN> <87czoqytmn.fsf@HIDDEN> Date: Thu, 30 Sep 2021 15:33:53 +0000 Message-ID: <87y27em61q.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 9622 Cc: "Basil L. Contovounesios" <contovob@HIDDEN>, Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattiase@HIDDEN>, Lars Ingebrigtsen <larsi@HIDDEN>, 9622 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Thierry Volpiatto <thievol@HIDDEN> writes: > Note that using `common-lisp-indent-function` as `lisp-indent-function` in > emacs-27.2 make `cl-flet` and friends indent properly, with a few more > settings for `cl-loop` indentation it is perfect, did I miss something? In general, the languages are different and rules should be expected to be different. cl- indenter takes care of #(..) and so on which is meaningless in Elisp. I also think common-lisp-indent-function should not attempt to indent cl- stuff and likewise lisp-indent-function should not indent plain flet and so on because plain ones are =E2=80=9Cofficially deprecated=E2=80=9D. It would make more sense to have a generic sexp indenter and dialect-specific indenters that inherit from it. But inheritance practices in Emacs is in terrible shape: inheritance mechanisms have been reinvented in incompatible ways since forever. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJLBAEBCgA1FiEEgu5SJRdnQOF34djNsr6xYbHsf0QFAmFV2OEXHG51Y2xlYXJz cGFjZUBnbWFpbC5jb20ACgkQsr6xYbHsf0QOUhAAoAnCuluOj9YvJSUIfbvK1yf9 FRX6Pc+xrmj2/MXHQody35Fmh2hdz3MP0ExgpAWlx1sHxfVYm5CwUkPqYVSIKEXR +nOeRAIn8XIM2Cb611BJfmbJ+7++HicQmdOLY4fbmVFZQeM1gaCopXcGvFoQdfTq JVGAruHc7tL/cPMu8ptMjKl9a6owTrolb3UiLaiClNtqwFvcIeZrpZnMuuaU9WNC XUkJbtSPpo69dDX5sJgGxnmdlpoVfWnkCAl5UMFGxsV0Q5mjVziqX6RXWDatfIM0 BmO/KpQJdX8ByQkv0nn8XaJqWnEKW5/Au0kByBDFuvgsUWZFYamrlke7Bp83Wwfm A4AYf1c4T5xJdVnpKEH0yZ3hlnnzCQg7z6frXMM9UexWATz2bAv09YqE9qPwk+gJ 8OTthTiDfmHil2/wVkikhBeA089pw9+2nEu1Q6nwk2RKWp3gsJ6p0xxy/1FlkY0W aw55gyVA44OQIFqIXHcRGQhndtf8+y7ahD+z5iU8mhR4/hWZglCZUouBI3IqKKb9 HsGIehtbor7Cf8xsBm1ek6ZSzCTxRZ3trvc/lJ7JQOruy+0o5MXJcvnDka4Jpe5S kNlPB3LqPJ5Ou/vqHWFm0XDOC1Ebq99lslhVxeOcOPpSCl/fVg6RbDniwRRTahGm PidyyY1bJxJ/kc85bRs= =NhoX -----END PGP SIGNATURE----- --=-=-=--
bug-gnu-emacs@HIDDEN:bug#9622; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 30 Sep 2021 15:45:50 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Sep 30 11:45:50 2021 Received: from localhost ([127.0.0.1]:53731 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mVyFl-0003t1-Oy for submit <at> debbugs.gnu.org; Thu, 30 Sep 2021 11:45:50 -0400 Received: from lists.gnu.org ([209.51.188.17]:50622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <nuclearspace@HIDDEN>) id 1mVyFe-0003sW-Ar for submit <at> debbugs.gnu.org; Thu, 30 Sep 2021 11:45:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40070) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <nuclearspace@HIDDEN>) id 1mVyFa-0004SL-Mj for bug-gnu-emacs@HIDDEN; Thu, 30 Sep 2021 11:45:36 -0400 Received: from mail-io1-xd2a.google.com ([2607:f8b0:4864:20::d2a]:47019) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <nuclearspace@HIDDEN>) id 1mVyFY-0005Tm-An for bug-gnu-emacs@HIDDEN; Thu, 30 Sep 2021 11:45:34 -0400 Received: by mail-io1-xd2a.google.com with SMTP id d18so8115818iof.13 for <bug-gnu-emacs@HIDDEN>; Thu, 30 Sep 2021 08:45:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=P9WtY2ue8dvg9W44Hzas29ywW6+ZGAOnyfWyX+3uo5s=; b=O7R6+3T+ojRoONW0mJzDn/am0Qmjb7G9dfsPKuQXRGytB45qv6pWOaeTeLzzLZ+mAL WSa1w0MnE8qGfa/a9gDlrXw0ZEUxhZ0X0HbE3GjXWSbN1D6aAxu9YLDl0CzPBni8rvKW 6v0RZ/ioeNu72a9eLRg6Bk2tT70ChPzzh/Z8ToXNYzTVPfAoROyR4fSBHxFxJvCBESLG 3g/7y33Mj7dvunnAsbSNVEwP4u4nuOY61UL8wntnYZXHm+YNFXrehAT/nB6t3ySxO5La FFPU2Zo6uVcHsJdEjuBVFBLNuIos9FjvMpzQZzDHIdb0ay3gTgfQHzHqftEbzihHzgxT 8qtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=P9WtY2ue8dvg9W44Hzas29ywW6+ZGAOnyfWyX+3uo5s=; b=E1XrhlxCBMVsKXlEGD5i7DWiWK9HNE2jR2RBJj/CHA3aM4hpLrsfcUdqIWh3GEDWNd v3ufzxdzcG/RVfkbERmusIxftSUhkOH/PGljaf8Aayss0SJ13IeXFPL91hv3NxS2PBXr +STGGtc/hnNLdq5Ju50Ke4f9qafh5MKfqDuzMjfdkyDi/0J8bd14att8uiu7KWa9Exq9 qnQuM8j+LP7nNf999oG6+DD6b5A4mbfbr5VrTAx+6QWh81JM/I+8dLw8/pROCQbl74L6 tF6Zvprg/nhEBX7dggsqvyjonYdJuDHN0GQ1F30FvAd0Q2KGhNcT5z0r7+OR5FjPP0gA 5Mqw== X-Gm-Message-State: AOAM530LGay20FAcg8qMPbZlAp18eG40B8lB8vtDH12Me3anUJxbqUPU Ggy6KguIiPSc604/QgxWxOw= X-Google-Smtp-Source: ABdhPJwBsJ8Hvo2E4hM4kIMe4h9CgU1nTJMLxn5uHXd5nOdtemswhn2SzN28I+oK5KIuHXHyyTaf4g== X-Received: by 2002:a02:a48:: with SMTP id 69mr5381010jaw.144.1633016730825; Thu, 30 Sep 2021 08:45:30 -0700 (PDT) Received: from localhost ([23.154.177.66]) by smtp.googlemail.com with ESMTPSA id m2sm1376537ilg.45.2021.09.30.08.45.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Sep 2021 08:45:30 -0700 (PDT) From: akater <nuclearspace@HIDDEN> To: Thierry Volpiatto <thievol@HIDDEN>, "Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> Subject: Re: bug#9622: [PATCH] Re: bug#9622: 23.3; flet indentation In-Reply-To: <87czoqytmn.fsf@HIDDEN> References: <504153FB-8633-4755-A91A-DF5DD64E6FAA@HIDDEN> <87lf3fntdx.fsf@HIDDEN> <87tui26027.fsf@HIDDEN> <87r1d62owt.fsf@HIDDEN> <A5C97667-7C05-4558-B5BC-94CB5728D566@HIDDEN> <87lf3eqesu.fsf@HIDDEN> <87czoqytmn.fsf@HIDDEN> Date: Thu, 30 Sep 2021 15:33:53 +0000 Message-ID: <87y27em61q.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2607:f8b0:4864:20::d2a; envelope-from=nuclearspace@HIDDEN; helo=mail-io1-xd2a.google.com X-Spam_score_int: -1 X-Spam_score: -0.2 X-Spam_bar: / X-Spam_report: (-0.2 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: "Basil L. Contovounesios" <contovob@HIDDEN>, Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattiase@HIDDEN>, Lars Ingebrigtsen <larsi@HIDDEN>, 9622 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Thierry Volpiatto <thievol@HIDDEN> writes: > Note that using `common-lisp-indent-function` as `lisp-indent-function` in > emacs-27.2 make `cl-flet` and friends indent properly, with a few more > settings for `cl-loop` indentation it is perfect, did I miss something? In general, the languages are different and rules should be expected to be different. cl- indenter takes care of #(..) and so on which is meaningless in Elisp. I also think common-lisp-indent-function should not attempt to indent cl- stuff and likewise lisp-indent-function should not indent plain flet and so on because plain ones are =E2=80=9Cofficially deprecated=E2=80=9D. It would make more sense to have a generic sexp indenter and dialect-specific indenters that inherit from it. But inheritance practices in Emacs is in terrible shape: inheritance mechanisms have been reinvented in incompatible ways since forever. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJLBAEBCgA1FiEEgu5SJRdnQOF34djNsr6xYbHsf0QFAmFV2OEXHG51Y2xlYXJz cGFjZUBnbWFpbC5jb20ACgkQsr6xYbHsf0QOUhAAoAnCuluOj9YvJSUIfbvK1yf9 FRX6Pc+xrmj2/MXHQody35Fmh2hdz3MP0ExgpAWlx1sHxfVYm5CwUkPqYVSIKEXR +nOeRAIn8XIM2Cb611BJfmbJ+7++HicQmdOLY4fbmVFZQeM1gaCopXcGvFoQdfTq JVGAruHc7tL/cPMu8ptMjKl9a6owTrolb3UiLaiClNtqwFvcIeZrpZnMuuaU9WNC XUkJbtSPpo69dDX5sJgGxnmdlpoVfWnkCAl5UMFGxsV0Q5mjVziqX6RXWDatfIM0 BmO/KpQJdX8ByQkv0nn8XaJqWnEKW5/Au0kByBDFuvgsUWZFYamrlke7Bp83Wwfm A4AYf1c4T5xJdVnpKEH0yZ3hlnnzCQg7z6frXMM9UexWATz2bAv09YqE9qPwk+gJ 8OTthTiDfmHil2/wVkikhBeA089pw9+2nEu1Q6nwk2RKWp3gsJ6p0xxy/1FlkY0W aw55gyVA44OQIFqIXHcRGQhndtf8+y7ahD+z5iU8mhR4/hWZglCZUouBI3IqKKb9 HsGIehtbor7Cf8xsBm1ek6ZSzCTxRZ3trvc/lJ7JQOruy+0o5MXJcvnDka4Jpe5S kNlPB3LqPJ5Ou/vqHWFm0XDOC1Ebq99lslhVxeOcOPpSCl/fVg6RbDniwRRTahGm PidyyY1bJxJ/kc85bRs= =NhoX -----END PGP SIGNATURE----- --=-=-=--
bug-gnu-emacs@HIDDEN:bug#9622; Package emacs.
Full text available.Received: (at 9622) by debbugs.gnu.org; 30 Sep 2021 15:25:15 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Sep 30 11:25:15 2021 Received: from localhost ([127.0.0.1]:53723 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mVxvu-0003IN-P2 for submit <at> debbugs.gnu.org; Thu, 30 Sep 2021 11:25:14 -0400 Received: from mail18c50.megamailservers.eu ([91.136.10.28]:35790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattiase@HIDDEN>) id 1mVxvq-0003I5-Vn for 9622 <at> debbugs.gnu.org; Thu, 30 Sep 2021 11:25:13 -0400 X-Authenticated-User: mattiase@HIDDEN DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1633015508; bh=7zajKCKYu18ICAD2EtTEF5ZuYnCV6zWtS9m2yBPB+tg=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=HmxjRqMrRN6PdxzFmFVMSVMFvBMRWfm6RB2x1/n/1W4qnU/fVveJTD1zjYZJ9G/F+ V+LtZDCdlffi9xB1zqXqixE8sTPI3j8BAbv1xxHmxoZfimlfBBQcB/XFB4jJ6Y7Nlv UYwbCdR+wmU9/r5x2x566CtC9gkyBZY8aFYrbe/0= Feedback-ID: mattiase@HIDDEN Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail18c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 18UFP6Pk024980; Thu, 30 Sep 2021 15:25:07 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: bug#9622: [PATCH] Re: bug#9622: 23.3; flet indentation From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattiase@HIDDEN> In-Reply-To: <87lf3eqesu.fsf@HIDDEN> Date: Thu, 30 Sep 2021 17:25:05 +0200 Content-Transfer-Encoding: 7bit Message-Id: <C32B2FBD-379A-441A-A637-CA36EC57F94A@HIDDEN> References: <504153FB-8633-4755-A91A-DF5DD64E6FAA@HIDDEN> <87lf3fntdx.fsf@HIDDEN> <87tui26027.fsf@HIDDEN> <87r1d62owt.fsf@HIDDEN> <A5C97667-7C05-4558-B5BC-94CB5728D566@HIDDEN> <87lf3eqesu.fsf@HIDDEN> To: "Basil L. Contovounesios" <contovob@HIDDEN> X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F1A.6155D6D4.0051, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.4 cv=etO8cqlX c=1 sm=1 tr=0 ts=6155d6d4 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=GIAD07YX5r7V_bbbhZYA:9 a=CjuIK1q_8ugA:10 a=efurXwZocSXF-NlR-QiR:22 X-Origin-Country: SE X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 9622 Cc: Lars Ingebrigtsen <larsi@HIDDEN>, 9622 <at> debbugs.gnu.org, akater <nuclearspace@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) 30 sep. 2021 kl. 17.11 skrev Basil L. Contovounesios <contovob@HIDDEN>: > Modulo a failing test ;). Now marked as an expected failure. Thank you!
bug-gnu-emacs@HIDDEN:bug#9622; Package emacs.
Full text available.Received: (at 9622) by debbugs.gnu.org; 30 Sep 2021 15:24:04 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Sep 30 11:24:04 2021 Received: from localhost ([127.0.0.1]:53719 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mVxum-0003Fy-7P for submit <at> debbugs.gnu.org; Thu, 30 Sep 2021 11:24:04 -0400 Received: from mout02.posteo.de ([185.67.36.66]:53875) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <thievol@HIDDEN>) id 1mVxuf-0003F1-1E for 9622 <at> debbugs.gnu.org; Thu, 30 Sep 2021 11:24:00 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 78166240105 for <9622 <at> debbugs.gnu.org>; Thu, 30 Sep 2021 17:23:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1633015430; bh=ZRVDcf28bifFYWKrF135Qv2qw9/PZ4d0fSSyQTFGd0A=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=lIBoERhD+8ItzjJlCaBI4ATk9rHAt/0M0/YWbZZrMyYpowx9m55EYVDUYFoU/6AID f5c++Rz9+VDMG/NA/diqTt9F11GDOG4R+ZvMBiBkGhdIX9GUaq9CCFI51Q584j7g5D Z4ZB/rV7xehV6nvj6BOhnz4jArmP5RcdYwm/qimPsA1HvFLZbon+LwY5o14HMFAaGr AAMPzj0LTFyNU6Wg7U0qeh2vQ/TTT8GWRcNLq4l6ZmsNzioN7ktep8Dbk4odsr7gmJ HeKcjMOR7iFeEKp4x7nVReC5iih5NRjtb44LigcBtxxSfwKHZoV+sTbudMbk9238TY nEy3BmWALZcyg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4HKxpp166Jz6tmH; Thu, 30 Sep 2021 17:23:45 +0200 (CEST) From: Thierry Volpiatto <thievol@HIDDEN> To: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> Subject: Re: bug#9622: [PATCH] Re: bug#9622: 23.3; flet indentation References: <504153FB-8633-4755-A91A-DF5DD64E6FAA@HIDDEN> <87lf3fntdx.fsf@HIDDEN> <87tui26027.fsf@HIDDEN> <87r1d62owt.fsf@HIDDEN> <A5C97667-7C05-4558-B5BC-94CB5728D566@HIDDEN> <87lf3eqesu.fsf@HIDDEN> Autocrypt: addr=thievol@HIDDEN; prefer-encrypt=mutual; keydata= mQGNBF8ylcIBDADG+hy+zR6L4/vbdDDZuSaMmSrU3A5QZJpeBCvxTr7MpzzruZbhLPW1K3R6N2MA edi8Y+C8o27FVRIjpdbaKMGu9je7JV/TbUQYo3SOwCK1vM4LUn4V6ZLzSYkuiEt4eyMoiDdyvN0p kcK6P9x9DCetcEVszXzQg+yzCVrQ2hXWDXWT4M18EC3wtO7RHPouMqGiwBFhBAYErCqFWFxQHkfb tG/4yGyJ58rglb65O3qijjMWvYwcWZun9/7qm8Z4/4mHopmo2zgU+OrptnLSZfkZGz3Y7Uf452xQ GVq0Fv75NPvQru7y+DYVhuVXXyAmGxt+vf4rIiixMBbhKEPjcxEPAa2LTzex2IsTZR+QVG9uDnqC WcgaOEQ58fzXNvNhtwwF/Rgio2XWAJVdmFWS59/k9W58CIUSNKBMZh2XeGdEmtHvDtCxW3z6FJha 36RzOM3fMNNiAGdFZJA84gcdloJR+sHCDTTPT3784fjr+V8An7sI581NGFzkRQqPvEQCZbUAEQEA AbQSdGhpZXZvbEBwb3N0ZW8ubmV0iQHUBBMBCgA+FiEEI9twfRN7r3nig/xwDsVtFB0W75MFAl8y lcICGwMFCQPCZwAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQDsVtFB0W75MB3QwAlTsVzFmr +S/tMKwwwOibjhNPi/OZiUC2AYfaqfVAiIHDT3RbzDe03sAJoomJkJnYVjGzQZwibCMO2+ITkMPV 2wvrd4CbgS1KCVbrltwcuK/nxPCBaHytOCZUIInnhJo5PE/h03K0rWhUFLDocpnWwI7mPq33oR9N u2XMNtUQeWhhZHj8dvpMazWIR/c4iPnQiIobETISNlKIVo7DZSl67btoBrZygVYobgHpAYLBpHtH pXUcfM+Jrl8ytLouZ2XYeqzezr1qUDXhPk6mXtEVLJsK4FSS4wT5hPpRozuIwj6sE8OGJIp5uUhm SYm9mjRNJBEgmGUNxMQ/wbcA3NEWxBeIZbRvxMgHG47GJ0TJM4xLpGC8BHUZvuIw05gAtgoA3BGh 5GXbLWy4fi8ozJA/kCkP43d3zh4wTOfQterVTf90bbw6NiNcmXdKH7E/yO1or06bleza39PJsshX 8EETESzVIifk2yDnc0/CQ+FrLY9IwOOszkMouFXmiwN1xMkjuQGNBF8ylcIBDADnIDHEkmk4lUwT lOhwb2yjUfmGPnpH3MCCHkjM9H/P1gTHxFWtwFVPcNMCwXWvKSBTF2dZXKERD0yzG06zT53ZMN7E IIeuY6m4R8IcMvpohciisWxbFoB4ZY117tVSeqjo946itgbpdeESKl9a8dpn7ytZMyYxPdojlQAq xeAJ8444raESh1oTKXb64hlk4l2pSRlrLgjpJBo8asAfZndaxIUKhw68tV8sqeZh9P6cGtHbUELK VJqefNV7V7jF5wf3xvRG6Ces3kSKXalLfs+vrVaoOjQeWrc0AtwFWHmt9JLfKrqF+Q2Q7jUidboW mazQM56ESJFPpPHmWq8k6DHspsFHOforLouTHJL1556IPne7IV2BGfWc0+xLxalZ8F5F+vnPF/Ok rC1CD5iCKTjXKa2iZbcYdYQAiL6P8Ac8CgN6EkhpbxRtzrEgChuNGevdi/G/GHG4Zqrh6YFwIa/N Hq2aVaFq5C1yNTMJd1FRjRzs5JPPlJKpYDnNx+MSp7UAEQEAAYkBvAQYAQoAJhYhBCPbcH0Te695 4oP8cA7FbRQdFu+TBQJfMpXCAhsMBQkDwmcAAAoJEA7FbRQdFu+TXsEL/3nCs8oDLBSTPXylenWK CYLdfZSg8jmwgRKihktU1ZLf8kL/LtEhxdKc9nYQO0gTYdPQ+HEdFbm+gFZ4AxuCtd5zM+MP5Sej pfr93QbLwYCiqsudKa+T7wosBBNFnh8ZQkbnsF6iPIeESCJM0Vhjh1lQ+z1qVkdf/yazwmXspOUh 3kx8dzJQ1F3t6Dj/zHpdNE11bT6wFwTPBFvFeH0yCwDpvVcLbH0xf/0V/RhwkQ4jjae0Cqn8domz RpGODjXkAzoRqpRL9/DvIKTQ/uJQqzu6qvi04foFCmtWTSahJiLtbgHSDNj1HHOivtgeTgtVdAEk ZAqAXJfmaM8KkEi8Rqcbz3AzkjNWjQNkel0xjB3wkewds1iGcvo2/etWOXcvFiLUpy7YnLMZ4J6d jNpwSwDzxvJVy0OvB9SgVF0hX5DdbKTRBSZpGYQgoVdPelGnqs6uq8fa1Ker587E6O6haTIX779d pd5UIX75/XbtumwE0L+IvMpekoM9zH8pCowu4g== Date: Thu, 30 Sep 2021 15:23:44 +0000 In-Reply-To: <87lf3eqesu.fsf@HIDDEN> (Basil L. Contovounesios's message of "Thu, 30 Sep 2021 16:11:13 +0100") Message-ID: <87czoqytmn.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 9622 Cc: "Basil L. Contovounesios" <contovob@HIDDEN>, Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattiase@HIDDEN>, Lars Ingebrigtsen <larsi@HIDDEN>, 9622 <at> debbugs.gnu.org, akater <nuclearspace@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) "Basil L. Contovounesios" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> writes: > Mattias Engdeg=C3=A5rd [2021-09-30 16:52 +0200] wrote: > >> 30 sep. 2021 kl. 15.06 skrev Basil L. Contovounesios <contovob@HIDDEN>: >> >>> Thanks, but I found another indentation regression introduced in >>> 38037e04cb that does not involve flet and is not fixed by c42af5aee7: >>>=20 >>> 0. emacs -Q >>> 1. (let ((x (and y RET >>>=20 >>> Point is now at BOL instead of under y. >> >> Thanks for reporting this; I've noticed the same. It's sufficient annoyi= ng that >> I'm reverting both changes; at least that gets us back where we started. > > Modulo a failing test ;). Note that using `common-lisp-indent-function` as `lisp-indent-function` in emacs-27.2 make `cl-flet` and friends indent properly, with a few more settings for `cl-loop` indentation it is perfect, did I miss something? --=20 Thierry
bug-gnu-emacs@HIDDEN:bug#9622; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 30 Sep 2021 15:24:01 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Sep 30 11:24:01 2021 Received: from localhost ([127.0.0.1]:53716 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mVxui-0003FM-V6 for submit <at> debbugs.gnu.org; Thu, 30 Sep 2021 11:24:01 -0400 Received: from lists.gnu.org ([209.51.188.17]:54614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <thievol@HIDDEN>) id 1mVxug-0003F8-4j for submit <at> debbugs.gnu.org; Thu, 30 Sep 2021 11:23:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35688) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <thievol@HIDDEN>) id 1mVxuf-0001qL-RC for bug-gnu-emacs@HIDDEN; Thu, 30 Sep 2021 11:23:57 -0400 Received: from mout01.posteo.de ([185.67.36.65]:33439) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <thievol@HIDDEN>) id 1mVxuc-000599-0S for bug-gnu-emacs@HIDDEN; Thu, 30 Sep 2021 11:23:57 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 28B60240027 for <bug-gnu-emacs@HIDDEN>; Thu, 30 Sep 2021 17:23:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1633015430; bh=ZRVDcf28bifFYWKrF135Qv2qw9/PZ4d0fSSyQTFGd0A=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=lIBoERhD+8ItzjJlCaBI4ATk9rHAt/0M0/YWbZZrMyYpowx9m55EYVDUYFoU/6AID f5c++Rz9+VDMG/NA/diqTt9F11GDOG4R+ZvMBiBkGhdIX9GUaq9CCFI51Q584j7g5D Z4ZB/rV7xehV6nvj6BOhnz4jArmP5RcdYwm/qimPsA1HvFLZbon+LwY5o14HMFAaGr AAMPzj0LTFyNU6Wg7U0qeh2vQ/TTT8GWRcNLq4l6ZmsNzioN7ktep8Dbk4odsr7gmJ HeKcjMOR7iFeEKp4x7nVReC5iih5NRjtb44LigcBtxxSfwKHZoV+sTbudMbk9238TY nEy3BmWALZcyg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4HKxpp166Jz6tmH; Thu, 30 Sep 2021 17:23:45 +0200 (CEST) From: Thierry Volpiatto <thievol@HIDDEN> To: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> Subject: Re: bug#9622: [PATCH] Re: bug#9622: 23.3; flet indentation References: <504153FB-8633-4755-A91A-DF5DD64E6FAA@HIDDEN> <87lf3fntdx.fsf@HIDDEN> <87tui26027.fsf@HIDDEN> <87r1d62owt.fsf@HIDDEN> <A5C97667-7C05-4558-B5BC-94CB5728D566@HIDDEN> <87lf3eqesu.fsf@HIDDEN> Autocrypt: addr=thievol@HIDDEN; prefer-encrypt=mutual; keydata= mQGNBF8ylcIBDADG+hy+zR6L4/vbdDDZuSaMmSrU3A5QZJpeBCvxTr7MpzzruZbhLPW1K3R6N2MA edi8Y+C8o27FVRIjpdbaKMGu9je7JV/TbUQYo3SOwCK1vM4LUn4V6ZLzSYkuiEt4eyMoiDdyvN0p kcK6P9x9DCetcEVszXzQg+yzCVrQ2hXWDXWT4M18EC3wtO7RHPouMqGiwBFhBAYErCqFWFxQHkfb tG/4yGyJ58rglb65O3qijjMWvYwcWZun9/7qm8Z4/4mHopmo2zgU+OrptnLSZfkZGz3Y7Uf452xQ GVq0Fv75NPvQru7y+DYVhuVXXyAmGxt+vf4rIiixMBbhKEPjcxEPAa2LTzex2IsTZR+QVG9uDnqC WcgaOEQ58fzXNvNhtwwF/Rgio2XWAJVdmFWS59/k9W58CIUSNKBMZh2XeGdEmtHvDtCxW3z6FJha 36RzOM3fMNNiAGdFZJA84gcdloJR+sHCDTTPT3784fjr+V8An7sI581NGFzkRQqPvEQCZbUAEQEA AbQSdGhpZXZvbEBwb3N0ZW8ubmV0iQHUBBMBCgA+FiEEI9twfRN7r3nig/xwDsVtFB0W75MFAl8y lcICGwMFCQPCZwAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQDsVtFB0W75MB3QwAlTsVzFmr +S/tMKwwwOibjhNPi/OZiUC2AYfaqfVAiIHDT3RbzDe03sAJoomJkJnYVjGzQZwibCMO2+ITkMPV 2wvrd4CbgS1KCVbrltwcuK/nxPCBaHytOCZUIInnhJo5PE/h03K0rWhUFLDocpnWwI7mPq33oR9N u2XMNtUQeWhhZHj8dvpMazWIR/c4iPnQiIobETISNlKIVo7DZSl67btoBrZygVYobgHpAYLBpHtH pXUcfM+Jrl8ytLouZ2XYeqzezr1qUDXhPk6mXtEVLJsK4FSS4wT5hPpRozuIwj6sE8OGJIp5uUhm SYm9mjRNJBEgmGUNxMQ/wbcA3NEWxBeIZbRvxMgHG47GJ0TJM4xLpGC8BHUZvuIw05gAtgoA3BGh 5GXbLWy4fi8ozJA/kCkP43d3zh4wTOfQterVTf90bbw6NiNcmXdKH7E/yO1or06bleza39PJsshX 8EETESzVIifk2yDnc0/CQ+FrLY9IwOOszkMouFXmiwN1xMkjuQGNBF8ylcIBDADnIDHEkmk4lUwT lOhwb2yjUfmGPnpH3MCCHkjM9H/P1gTHxFWtwFVPcNMCwXWvKSBTF2dZXKERD0yzG06zT53ZMN7E IIeuY6m4R8IcMvpohciisWxbFoB4ZY117tVSeqjo946itgbpdeESKl9a8dpn7ytZMyYxPdojlQAq xeAJ8444raESh1oTKXb64hlk4l2pSRlrLgjpJBo8asAfZndaxIUKhw68tV8sqeZh9P6cGtHbUELK VJqefNV7V7jF5wf3xvRG6Ces3kSKXalLfs+vrVaoOjQeWrc0AtwFWHmt9JLfKrqF+Q2Q7jUidboW mazQM56ESJFPpPHmWq8k6DHspsFHOforLouTHJL1556IPne7IV2BGfWc0+xLxalZ8F5F+vnPF/Ok rC1CD5iCKTjXKa2iZbcYdYQAiL6P8Ac8CgN6EkhpbxRtzrEgChuNGevdi/G/GHG4Zqrh6YFwIa/N Hq2aVaFq5C1yNTMJd1FRjRzs5JPPlJKpYDnNx+MSp7UAEQEAAYkBvAQYAQoAJhYhBCPbcH0Te695 4oP8cA7FbRQdFu+TBQJfMpXCAhsMBQkDwmcAAAoJEA7FbRQdFu+TXsEL/3nCs8oDLBSTPXylenWK CYLdfZSg8jmwgRKihktU1ZLf8kL/LtEhxdKc9nYQO0gTYdPQ+HEdFbm+gFZ4AxuCtd5zM+MP5Sej pfr93QbLwYCiqsudKa+T7wosBBNFnh8ZQkbnsF6iPIeESCJM0Vhjh1lQ+z1qVkdf/yazwmXspOUh 3kx8dzJQ1F3t6Dj/zHpdNE11bT6wFwTPBFvFeH0yCwDpvVcLbH0xf/0V/RhwkQ4jjae0Cqn8domz RpGODjXkAzoRqpRL9/DvIKTQ/uJQqzu6qvi04foFCmtWTSahJiLtbgHSDNj1HHOivtgeTgtVdAEk ZAqAXJfmaM8KkEi8Rqcbz3AzkjNWjQNkel0xjB3wkewds1iGcvo2/etWOXcvFiLUpy7YnLMZ4J6d jNpwSwDzxvJVy0OvB9SgVF0hX5DdbKTRBSZpGYQgoVdPelGnqs6uq8fa1Ker587E6O6haTIX779d pd5UIX75/XbtumwE0L+IvMpekoM9zH8pCowu4g== Date: Thu, 30 Sep 2021 15:23:44 +0000 In-Reply-To: <87lf3eqesu.fsf@HIDDEN> (Basil L. Contovounesios's message of "Thu, 30 Sep 2021 16:11:13 +0100") Message-ID: <87czoqytmn.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.67.36.65; envelope-from=thievol@HIDDEN; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: "Basil L. Contovounesios" <contovob@HIDDEN>, Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattiase@HIDDEN>, Lars Ingebrigtsen <larsi@HIDDEN>, 9622 <at> debbugs.gnu.org, akater <nuclearspace@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.3 (--) "Basil L. Contovounesios" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> writes: > Mattias Engdeg=C3=A5rd [2021-09-30 16:52 +0200] wrote: > >> 30 sep. 2021 kl. 15.06 skrev Basil L. Contovounesios <contovob@HIDDEN>: >> >>> Thanks, but I found another indentation regression introduced in >>> 38037e04cb that does not involve flet and is not fixed by c42af5aee7: >>>=20 >>> 0. emacs -Q >>> 1. (let ((x (and y RET >>>=20 >>> Point is now at BOL instead of under y. >> >> Thanks for reporting this; I've noticed the same. It's sufficient annoyi= ng that >> I'm reverting both changes; at least that gets us back where we started. > > Modulo a failing test ;). Note that using `common-lisp-indent-function` as `lisp-indent-function` in emacs-27.2 make `cl-flet` and friends indent properly, with a few more settings for `cl-loop` indentation it is perfect, did I miss something? --=20 Thierry
bug-gnu-emacs@HIDDEN:bug#9622; Package emacs.
Full text available.
Received: (at 9622) by debbugs.gnu.org; 30 Sep 2021 15:11:26 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Sep 30 11:11:26 2021
Received: from localhost ([127.0.0.1]:53692 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1mVxiY-0002s2-Hu
for submit <at> debbugs.gnu.org; Thu, 30 Sep 2021 11:11:26 -0400
Received: from mail-wm1-f50.google.com ([209.85.128.50]:56273)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <contovob@HIDDEN>) id 1mVxiT-0002rh-E8
for 9622 <at> debbugs.gnu.org; Thu, 30 Sep 2021 11:11:24 -0400
Received: by mail-wm1-f50.google.com with SMTP id v127so4934055wme.5
for <9622 <at> debbugs.gnu.org>; Thu, 30 Sep 2021 08:11:21 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21;
h=from:to:cc:subject:references:date:in-reply-to:message-id
:user-agent:mime-version:content-transfer-encoding;
bh=ykHoWh71LnMrVYxw2rzqhkBAPudDmgnv9Ldmf6U9K1E=;
b=BaZVyY27bxWDJPbttck8xjE1a+be1t3HvMkIWTzQP0waLPCPePuPvAI0ESh8rGCXpS
k91gZh+iHUnGDEzPv9wmhd1RE/SyxQi3aokKyau/EZ3omXzItBs/kwLEYIMXSX8aTDRA
afP96AkELivAzK5RbZe1VK3Xut2kRMDJKsTZHkqeTLUgYnxx3tlmPRSaQcZbay0zCBKy
aLlCGHE6tcdo2KkZzgmZCYwT95C71k2w65HCVevru8T8nSZFnvkff2DOxIlW7/TDpcpA
iLIePJ6aV2G0LB6v93DYnL6XSlSeENiYHgpJmbYGkmzflPnR7eUUF15zAVJmqqWFut+P
q3nw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
:message-id:user-agent:mime-version:content-transfer-encoding;
bh=ykHoWh71LnMrVYxw2rzqhkBAPudDmgnv9Ldmf6U9K1E=;
b=h9nt5ABIbCeZK3lU7mMQ0ctPFsvanFeDWCtJKwi7LkbbrS92Enq+1tENeqjO3IXzPr
+K/vqHd3tdxLigFQNx+Z1bE5duKuYVosFGkxBukGeDlPuSE4n2739w9EbKjmN0L6AGYy
EwMeaRMIb8TZRcvUWqTP4L4i43PCZzSpXIs891nlFwusC49JSe4m9KxCIMpeC726k4f3
viJb2s/IsJZggQXwOMQAqqdfsWJ+e4KO//1I6Gk11WyH5z+ZR72oUgkmv7/2XV7ENobV
ZYJfO69SlLVpIctxUGMapvY72heS3/Krc0DFZatwcx7ST8wiaj2thGSIcZ4Y9/+oPprl
/ZZA==
X-Gm-Message-State: AOAM531tMkoPnpUFVYGxlWBYmYft104vWcEXSElVnbJtcy8pNa4/0LtW
7bLwofdBQ/s36i3uzd7QUbu61g==
X-Google-Smtp-Source: ABdhPJyk29WB4oA0a2wKdhctpXnnfCt7eGQE/2aHsT2oC3PTQf7OQ+FdfDJ4UF8zP5bI6qA9uEgXMg==
X-Received: by 2002:a1c:7416:: with SMTP id p22mr4111148wmc.40.1633014675462;
Thu, 30 Sep 2021 08:11:15 -0700 (PDT)
Received: from localhost ([80.233.60.64])
by smtp.gmail.com with ESMTPSA id o5sm3174107wrf.85.2021.09.30.08.11.14
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 30 Sep 2021 08:11:14 -0700 (PDT)
From: "Basil L. Contovounesios" <contovob@HIDDEN>
To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattiase@HIDDEN>
Subject: Re: bug#9622: [PATCH] Re: bug#9622: 23.3; flet indentation
References: <504153FB-8633-4755-A91A-DF5DD64E6FAA@HIDDEN>
<87lf3fntdx.fsf@HIDDEN> <87tui26027.fsf@HIDDEN>
<87r1d62owt.fsf@HIDDEN> <A5C97667-7C05-4558-B5BC-94CB5728D566@HIDDEN>
Date: Thu, 30 Sep 2021 16:11:13 +0100
In-Reply-To: <A5C97667-7C05-4558-B5BC-94CB5728D566@HIDDEN> ("Mattias
=?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Thu, 30 Sep 2021 16:52:30
+0200")
Message-ID: <87lf3eqesu.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 9622
Cc: Lars Ingebrigtsen <larsi@HIDDEN>, 9622 <at> debbugs.gnu.org,
akater <nuclearspace@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Mattias Engdeg=C3=A5rd [2021-09-30 16:52 +0200] wrote:
> 30 sep. 2021 kl. 15.06 skrev Basil L. Contovounesios <contovob@HIDDEN>:
>
>> Thanks, but I found another indentation regression introduced in
>> 38037e04cb that does not involve flet and is not fixed by c42af5aee7:
>>=20
>> 0. emacs -Q
>> 1. (let ((x (and y RET
>>=20
>> Point is now at BOL instead of under y.
>
> Thanks for reporting this; I've noticed the same. It's sufficient annoyin=
g that
> I'm reverting both changes; at least that gets us back where we started.
Modulo a failing test ;).
--=20
Basil
bug-gnu-emacs@HIDDEN:bug#9622; Package emacs.
Full text available.Received: (at 9622) by debbugs.gnu.org; 30 Sep 2021 14:52:44 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Sep 30 10:52:44 2021 Received: from localhost ([127.0.0.1]:53653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mVxQS-0002Iu-H3 for submit <at> debbugs.gnu.org; Thu, 30 Sep 2021 10:52:44 -0400 Received: from mail1438c50.megamailservers.eu ([91.136.14.38]:40830 helo=mail263c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattiase@HIDDEN>) id 1mVxQP-0002IZ-Cl for 9622 <at> debbugs.gnu.org; Thu, 30 Sep 2021 10:52:43 -0400 X-Authenticated-User: mattiase@HIDDEN DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1633013553; bh=QdgsCQYL4+iV5q+IoLldQCGT8MhQqn6SwN8LEhfo3Cs=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=nMU0uMcQe6zCObt0wjK3fJdFCXodjN1qy3x/i8DWG7cmSORgCVbMKRSFiH15Xrrai 4eNGzC+DnbpsqTiqm4/7nlJlKtXcjkijFprMyaxWNcCOzucrIeMqcm3g1dJoLIY2tJ InEj1Jb5DGLxRX6mW43oKqUrzunM60I3acJgh4ic= Feedback-ID: mattiase@HIDDEN Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail263c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 18UEqVU3028751; Thu, 30 Sep 2021 14:52:32 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: bug#9622: [PATCH] Re: bug#9622: 23.3; flet indentation From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattiase@HIDDEN> In-Reply-To: <87r1d62owt.fsf@HIDDEN> Date: Thu, 30 Sep 2021 16:52:30 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <A5C97667-7C05-4558-B5BC-94CB5728D566@HIDDEN> References: <504153FB-8633-4755-A91A-DF5DD64E6FAA@HIDDEN> <87lf3fntdx.fsf@HIDDEN> <87tui26027.fsf@HIDDEN> <87r1d62owt.fsf@HIDDEN> To: "Basil L. Contovounesios" <contovob@HIDDEN> X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F28.6155CF31.0069, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.4 cv=TZ71CTch c=1 sm=1 tr=0 ts=6155cf31 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=VQw28yTjvnvdu99WhW0A:9 a=CjuIK1q_8ugA:10 X-Origin-Country: SE X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 30 sep. 2021 kl. 15.06 skrev Basil L. Contovounesios <contovob@HIDDEN>: > Thanks, but I found another indentation regression introduced in > 38037e04cb that does not involve flet and is not fixed by c42af5aee7: > > 0. emacs -Q > 1. (let ((x (and y RET > > Point is now at [...] Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [91.136.14.38 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-Debbugs-Envelope-To: 9622 Cc: Lars Ingebrigtsen <larsi@HIDDEN>, 9622 <at> debbugs.gnu.org, akater <nuclearspace@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) 30 sep. 2021 kl. 15.06 skrev Basil L. Contovounesios <contovob@HIDDEN>: > Thanks, but I found another indentation regression introduced in > 38037e04cb that does not involve flet and is not fixed by c42af5aee7: >=20 > 0. emacs -Q > 1. (let ((x (and y RET >=20 > Point is now at BOL instead of under y. Thanks for reporting this; I've noticed the same. It's sufficient = annoying that I'm reverting both changes; at least that gets us back = where we started. Akater, please don't see this as a hostile move -- we all want the bug = resolved. Let's make sure that the next patch comes with ERT tests for = all the mentioned issues and more.
bug-gnu-emacs@HIDDEN:bug#9622; Package emacs.
Full text available.
Received: (at 9622) by debbugs.gnu.org; 30 Sep 2021 14:09:52 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Sep 30 10:09:52 2021
Received: from localhost ([127.0.0.1]:53575 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1mVwky-0000z0-5x
for submit <at> debbugs.gnu.org; Thu, 30 Sep 2021 10:09:52 -0400
Received: from mail-ed1-f46.google.com ([209.85.208.46]:40619)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <nuclearspace@HIDDEN>) id 1mVwkv-0000yi-3d
for 9622 <at> debbugs.gnu.org; Thu, 30 Sep 2021 10:09:51 -0400
Received: by mail-ed1-f46.google.com with SMTP id g8so22904137edt.7
for <9622 <at> debbugs.gnu.org>; Thu, 30 Sep 2021 07:09:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
h=from:to:cc:subject:in-reply-to:references:date:message-id
:mime-version; bh=IIgjOfi2UxxtTM0eIe4saAHrkP7BWB7Ubx16Brv2D/8=;
b=GOGv4q9D5v0nY8xlMMW39VWNuTLVJ10clKHdwgZnGQQ2HfJCAcjPern0WuydGjHJrl
BraWnT98GymnA2KZnW/vHOviDFrnTKy2MkG7WoPRYMWb9wXfCf9HnAZ+aWiP19urKSb7
70jArdxjeuazKNCLg57OdEYfSqwTfWbirVIddkE26hFPhRU8WBAIu1H463O6TMMNXTZS
12jWaBSwZKt4iW5BQgvlAXNE0gK6G4mKu/8GnRWeVCRDllOeT34vXU6jlq414FMGfsUQ
73MMg2ahYF0c0faCTpl4vlu7wVDO0d5ui6fRfqPqVu6KTjumABihSBrJHrI+rXaIn44c
wiyw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date
:message-id:mime-version;
bh=IIgjOfi2UxxtTM0eIe4saAHrkP7BWB7Ubx16Brv2D/8=;
b=HtxZN5FkCXCY0fWX1SKKNVHenHNAdUBHcWczQtVAEKmGpKSwTTrSksXrDSu9Dvs+sR
tRmfUDzNQArjI6tTNi8RBrtApZy3qu8O+WAMkwTYfacOFV1Dsd2wlwIPiCYLPyPOb2vy
oVYnQBQnaSfa+NWK1+amjzYKhnNIBBT37KYb7W61c9sLaQRHKNy8O9sCMIq3gE0hfucl
RzZuRRMqPZulpk6QelNMH3qB5gthhara6HInnidm+LZHu+BB34k6wqXCTTmqqqN1NkEF
J5+G3c7boeJXX2bpsMWtWXu96oRicMUh0rd/UCmz9xQubt4ha82Nmj+JVR4Sq8qkFQAB
1oyw==
X-Gm-Message-State: AOAM532UjAxp9ujPcv0Q6DNsNLU7VEqYxFw/mBFQFprdW5KKI+T6t53I
gHLYaznychW+LUCiRTGs59w=
X-Google-Smtp-Source: ABdhPJxXv4tLXzLqmTMG0vB48/2M2kIMfnVQg/cM4Vh3iov2sk850naa1dpVRvXTAHaTwKDjmAcIOA==
X-Received: by 2002:a05:6402:50cc:: with SMTP id
h12mr7494122edb.216.1633010913439;
Thu, 30 Sep 2021 07:08:33 -0700 (PDT)
Received: from localhost ([185.31.175.220])
by smtp.googlemail.com with ESMTPSA id q9sm1522078ejf.70.2021.09.30.07.08.32
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 30 Sep 2021 07:08:32 -0700 (PDT)
From: akater <nuclearspace@HIDDEN>
To: Lars Ingebrigtsen <larsi@HIDDEN>, "Basil L. Contovounesios"
<contovob@HIDDEN>
Subject: Re: bug#9622: [PATCH] Re: bug#9622: 23.3; flet indentation
In-Reply-To: <8735pm2nai.fsf@HIDDEN>
References: <504153FB-8633-4755-A91A-DF5DD64E6FAA@HIDDEN>
<87lf3fntdx.fsf@HIDDEN> <87tui26027.fsf@HIDDEN>
<87r1d62owt.fsf@HIDDEN> <8735pm2nai.fsf@HIDDEN>
Date: Thu, 30 Sep 2021 13:57:04 +0000
Message-ID: <87a6junp3j.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Lars Ingebrigtsen writes: > Perhaps we should consider
backing
out these changed in Emacs 28 and > continuing to work on them on the trunk?
I don't think so. The first attempt was written in a hurry, and merged without
extensive testing; in the second I did exhaustive tests, it just never crossed
my mind to test on unbalanced expressions. [...]
Content analysis details: (1.2 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in
bl.spamcop.net
[Blocked - see <https://www.spamcop.net/bl.shtml?185.31.175.220>]
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (nuclearspace[at]gmail.com)
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2)
[209.85.208.46 listed in wl.mailspike.net]
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust [209.85.208.46 listed in list.dnswl.org]
X-Debbugs-Envelope-To: 9622
Cc: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattiase@HIDDEN>, 9622 <at> debbugs.gnu.org,
"Diogo F. S. Ramos" <diogofsr@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.2 (/)
--=-=-=
Content-Type: multipart/signed; boundary="==-=-=";
micalg=pgp-sha512; protocol="application/pgp-signature"
--==-=-=
Content-Type: text/plain
Lars Ingebrigtsen <larsi@HIDDEN> writes:
> Perhaps we should consider backing out these changed in Emacs 28 and
> continuing to work on them on the trunk?
I don't think so. The first attempt was written in a hurry, and merged
without extensive testing; in the second I did exhaustive tests, it just
never crossed my mind to test on unbalanced expressions. This very much
looks like the last ignore-errors of them:
--==-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQJLBAEBCgA1FiEEgu5SJRdnQOF34djNsr6xYbHsf0QFAmFVwjAXHG51Y2xlYXJz
cGFjZUBnbWFpbC5jb20ACgkQsr6xYbHsf0TCaw//dMtMEp0bI53hEdJF53eiZtXs
mpT0KVkpLayItJB4pkl1p3g1eUZE4as4GfwrVeOAUkSjEbJT/T+F+RQjwlK0yYC9
H+PVB5HX42fLgEY/r0DZiUwJ2aQkU1QeBVej0zx0zZ2y0JsX6mBpUd78frejz+aA
rLSmHTPwbHfcG9+SSFie3ypLFAHqAxuzhJKcfrlVts9t6YKDrO000FGSWCvmDogF
8mNPLJeYhBy7NP4W31fQPyrGOh/2rsYu4SDjFqMgiQ9b/N9Boq474w4fezUARLmk
4GrnBGLdVmdRxJzWsV5XP9a3fptfhS+mV7gxm2kn5NCMnJpNni+YURtlSEIBG70P
GaPM4U3onrrYbQuU1yA7w8mzRpi28XnGaRU3M4FqNCWfvIsFgjw45TbRSsW7I4iJ
0DP8YoxvKYYbhfMfsejpdJocZcPXvhrMXUMgcopkwyoIrdWjWK2CDhuclBUe3dEE
GIu2djXW6ndG5gsKE/VzZa6tNG4YV8lr0Fx+Txl0B9wt9nLu/8kKPMK0wnVKCSv5
q22HDnu3qlpll5JBENCEMt5yGEf+0XMkYRdfHkn8us4lVXqrVyTuUP181/3krF5m
TEoQOGdFFbKHD4RflwzhqICmFxzTjZiTJRld0MG9uzQoAaSayPDD9Ko/NiorqVF5
ZZxKjCy3WAoMHdD4Uos=
=UAqe
-----END PGP SIGNATURE-----
--==-=-=--
--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline;
filename=0001-Fix-other-regressions-in-cl-flet-indentation.patch
Content-Description: Fix indentation regression
From 2e5f87b345d349dc6657f8034102a842d0685232 Mon Sep 17 00:00:00 2001
From: akater <nuclearspace@HIDDEN>
Date: Thu, 30 Sep 2021 13:37:59 +0000
Subject: [PATCH] Fix other regressions in cl-flet indentation
* lisp/emacs-lisp/lisp-mode.el (lisp--local-defform-body-p):
Fix indentation regression
introduced by 38037e04cb05cb1f2b604f0b1602d36b0bcf6985
(bug#9622), namely don't fail in unreadable (incl. unbalanced) sexps.
---
lisp/emacs-lisp/lisp-mode.el | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/lisp/emacs-lisp/lisp-mode.el b/lisp/emacs-lisp/lisp-mode.el
index cd054801bc..57196dfec4 100644
--- a/lisp/emacs-lisp/lisp-mode.el
+++ b/lisp/emacs-lisp/lisp-mode.el
@@ -1124,9 +1124,13 @@ defun lisp--local-defform-body-p (state)
(when second-order-parent
(save-excursion
(goto-char (1+ second-order-parent))
- (and (memq (read (current-buffer))
- '( cl-flet cl-labels cl-macrolet cl-flet*
- cl-symbol-macrolet))
+ (and (when-let ((head (ignore-errors
+ ;; FIXME: This does not distinguish
+ ;; between reading nil and a read error.
+ ;; We don't care but still, better fix this.
+ (read (current-buffer)))))
+ (memq head '( cl-flet cl-labels cl-macrolet cl-flet*
+ cl-symbol-macrolet)))
;; Now we must check that we are
;; in the second element of the flet-like form.
;; It would be easier if `parse-partial-sexp' also recorded
--
2.32.0
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#9622; Package emacs.
Full text available.Received: (at 9622) by debbugs.gnu.org; 30 Sep 2021 13:41:54 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Sep 30 09:41:53 2021 Received: from localhost ([127.0.0.1]:51772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mVwJt-000875-Oo for submit <at> debbugs.gnu.org; Thu, 30 Sep 2021 09:41:53 -0400 Received: from quimby.gnus.org ([95.216.78.240]:42076) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <larsi@HIDDEN>) id 1mVwJr-00086q-38 for 9622 <at> debbugs.gnu.org; Thu, 30 Sep 2021 09:41:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=XxksIr6tLXFmC89LqsWeNWqOoSd0Qzym3R6H9O4R3g0=; b=r21ceqyuvyYMw/mm9CM+p9gbuD TzWGpUzyr/IxOXfOZg68P9+smWMjrNCegFhiBU/N1RnrZUHoeyDK5dE1LPZPh64ZzW76SdFCSD9ev ZCWXe3UU9CcsCUWHBNnjJUzcTFZsyqmzOc0kbCueRgbmRB1vrjOkDMgnnR5ljbfIVeiE=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <larsi@HIDDEN>) id 1mVwJi-0006GV-2g; Thu, 30 Sep 2021 15:41:44 +0200 From: Lars Ingebrigtsen <larsi@HIDDEN> To: "Basil L. Contovounesios" <contovob@HIDDEN> Subject: Re: bug#9622: [PATCH] Re: bug#9622: 23.3; flet indentation References: <504153FB-8633-4755-A91A-DF5DD64E6FAA@HIDDEN> <87lf3fntdx.fsf@HIDDEN> <87tui26027.fsf@HIDDEN> <87r1d62owt.fsf@HIDDEN> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEWXlWNpalDFzrf/ //+6G1XXAAAAAWJLR0QDEQxM8gAAAAlwSFlzAAALEgAACxIB0t1+/AAAAAd0SU1FB+UJHgw4DVe/ W24AAAEDSURBVCjPbdG9boQwDAfwfxCWKqYghb0duvAUQTqWm5wq3ts36XBT99tvaKWKp6zzBQw1 QsoPJ8GJgRQGw6aBf0A4QOQPTCLzkTlDdQKmHQbUnwHs0xZd1eC8vg00ok0j3ZgbDIww27nCBu8r AJEVrqATrZOogCXHNcO5UWIDmV6PsA4F1jtaLgV9WBiMmmGS0Z+gZRc8SQy+og8SVkWXQDehA9+B XlCBaLSyBrH6f99gFFzxPn2INOhQM7ZgTadhh4Ikfr6VDRZ9IkpGQkxj1HJC4ApDd3E75GcwDXCv jrRqzPl6490feLPYga9PTA3b9sDku9yfdOEkyN3WL78oXdz+AJswgvt/SGGhAAAAWmVYSWZNTQAq AAAACAAFARIAAwAAAAEAAQAAARoABQAAAAEAAABKARsABQAAAAEAAABSASgAAwAAAAEAAgAAAhMA AwAAAAEAAQAAAAAAAAAAAEgAAAABAAAASAAAAAEfUvc0AAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIx LTA5LTMwVDEyOjU2OjEzKzAwOjAw6jVWUAAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0wOS0zMFQx Mjo1NjoxMyswMDowMJto7uwAAAAXdEVYdGV4aWY6WUNiQ3JQb3NpdGlvbmluZwAxrA+AYwAAAABJ RU5ErkJggg== X-Now-Playing: Body =?utf-8?Q?Me=CF=80a's?= _The Work Is Slow_: "Money Tree" Date: Thu, 30 Sep 2021 15:41:41 +0200 In-Reply-To: <87r1d62owt.fsf@HIDDEN> (Basil L. Contovounesios's message of "Thu, 30 Sep 2021 14:06:42 +0100") Message-ID: <8735pm2nai.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: "Basil L. Contovounesios" <contovob@HIDDEN> writes: > Thanks, but I found another indentation regression introduced in > 38037e04cb that does not involve flet and is not fixed by c42af5aee7: > > 0. emacs -Q > 1. (let ((x (and y RET > > Point is now at [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 9622 Cc: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattiase@HIDDEN>, 9622 <at> debbugs.gnu.org, akater <nuclearspace@HIDDEN>, "Diogo F. S. Ramos" <diogofsr@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) "Basil L. Contovounesios" <contovob@HIDDEN> writes: > Thanks, but I found another indentation regression introduced in > 38037e04cb that does not involve flet and is not fixed by c42af5aee7: > > 0. emacs -Q > 1. (let ((x (and y RET > > Point is now at BOL instead of under y. Perhaps we should consider backing out these changed in Emacs 28 and continuing to work on them on the trunk? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no
bug-gnu-emacs@HIDDEN:bug#9622; Package emacs.
Full text available.Received: (at 9622) by debbugs.gnu.org; 30 Sep 2021 13:06:55 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Sep 30 09:06:55 2021 Received: from localhost ([127.0.0.1]:51733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mVvm2-00078f-Ut for submit <at> debbugs.gnu.org; Thu, 30 Sep 2021 09:06:55 -0400 Received: from mail-wr1-f46.google.com ([209.85.221.46]:46719) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <contovob@HIDDEN>) id 1mVvly-00078O-9t for 9622 <at> debbugs.gnu.org; Thu, 30 Sep 2021 09:06:53 -0400 Received: by mail-wr1-f46.google.com with SMTP id k7so9856891wrd.13 for <9622 <at> debbugs.gnu.org>; Thu, 30 Sep 2021 06:06:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=5t7UghYWCdnyckkcT5Rr8tEru63mADUxGEkycHioUkE=; b=SR1bF2557k7wro/4LXuSJ5QoVmKRwt0FkOn/TzhO+hB4I7GWjyJ/ZTubVVuam5XlCY J25ohOY+/Zsrjt4PwxeXosWFx07d4RUs8+ZhstGgjattVyJeeTEXMj3LAtNA4qIykpuu e+UrorJOzxX96t0IFoGwy7QYuiJVXvlbk7Qn28tcvQh+7DnxQmx1nfl7Qrh2YG0K+MEY 8GlofcebLlW5HnKppZHi260GgLQtG7XR2Cj2A+kR0pvKv3HoF0C2ZF6FYM1nJ+BMmtrA ObSTk/OQCeUOzcF0sv4Zn9gObBCIgEPAaAlrtwbsk4amOMTQOQdLL2Yxo8TguJSatbFZ fLEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=5t7UghYWCdnyckkcT5Rr8tEru63mADUxGEkycHioUkE=; b=xyIfnMkluSlgGYRkFum9t/P/l4Nlvw4+fx582ealhttf1GX1MqgABqoZDVO6YKSegR H09NuM4Sq/HNzSiNk1gc1LYE4LlK/aBQlHTAbPOY3s/3gbS2BSqycbvKAaczd/cldUit CoA3Y1bXRwPWLzsvyQSWLOfu3mQQAEsK5A2HiqUPEek/GccL/RU3gZyVYbQPkXxvH+W3 OGDqHKVZzUY8IW0Cn7KwBrnRtY1Vc3voQSLr8d25X43TYuvL4Eq0lS0ykZ7NF4+DjwHD tAfW5AkDdX/s32N6dKNOWQdjOcIxeCJ2PMmteZZGh5WlJZlZnmuBdqukSfmyjdDSW/qg 5x/A== X-Gm-Message-State: AOAM5302gWXPdLih0CKM6k4DllhmBcVmOU53nNPCk4pNze/Xlz6y+UIR MZ/Lq7qoHsFaoWv6i/s+K94U6w== X-Google-Smtp-Source: ABdhPJwfj74NefjXwu/O11TWBvRz2G1fwGFX47SR+8Z6WSuOw1EN+TGjDAKcGCr1a5h88EllxTeZVA== X-Received: by 2002:a5d:614c:: with SMTP id y12mr6242331wrt.156.1633007204439; Thu, 30 Sep 2021 06:06:44 -0700 (PDT) Received: from localhost ([80.233.52.64]) by smtp.gmail.com with ESMTPSA id 15sm4762625wmk.48.2021.09.30.06.06.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Sep 2021 06:06:43 -0700 (PDT) From: "Basil L. Contovounesios" <contovob@HIDDEN> To: Lars Ingebrigtsen <larsi@HIDDEN> Subject: Re: bug#9622: [PATCH] Re: bug#9622: 23.3; flet indentation References: <504153FB-8633-4755-A91A-DF5DD64E6FAA@HIDDEN> <87lf3fntdx.fsf@HIDDEN> <87tui26027.fsf@HIDDEN> Date: Thu, 30 Sep 2021 14:06:42 +0100 In-Reply-To: <87tui26027.fsf@HIDDEN> (Lars Ingebrigtsen's message of "Thu, 30 Sep 2021 08:37:36 +0200") Message-ID: <87r1d62owt.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 9622 Cc: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattiase@HIDDEN>, 9622 <at> debbugs.gnu.org, akater <nuclearspace@HIDDEN>, "Diogo F. S. Ramos" <diogofsr@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Lars Ingebrigtsen [2021-09-30 08:37 +0200] wrote: > akater <nuclearspace@HIDDEN> writes: > >> - We now check whether we're in the relevant subexpression of flet and >> friends. >> >> - Added -p to the predicate's name. >> >> - Added cl-macrolet cl-flet* cl-symbol-macrolet to the list of local >> definers. I added cl-symbol-macrolet too because this is how SLIME >> indents symbol-macrolet. > > Thanks; applied to Emacs 28. Thanks, but I found another indentation regression introduced in 38037e04cb that does not involve flet and is not fixed by c42af5aee7: 0. emacs -Q 1. (let ((x (and y RET Point is now at BOL instead of under y. -- Basil
bug-gnu-emacs@HIDDEN:bug#9622; Package emacs.
Full text available.Received: (at 9622) by debbugs.gnu.org; 30 Sep 2021 08:05:46 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Sep 30 04:05:46 2021 Received: from localhost ([127.0.0.1]:51382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mVr4c-0005iK-Kk for submit <at> debbugs.gnu.org; Thu, 30 Sep 2021 04:05:46 -0400 Received: from mail1468c50.megamailservers.eu ([91.136.14.68]:52228 helo=mail268c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattiase@HIDDEN>) id 1mVr4Z-0005i3-97 for 9622 <at> debbugs.gnu.org; Thu, 30 Sep 2021 04:05:44 -0400 X-Authenticated-User: mattiase@HIDDEN DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1632989136; bh=PG8eUYojJxUU+BLvT6ASegklFEdDn0+66TIFK1b6+yc=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=fPki8IFgFiL5WDEiIp1/SGkWnQi+lwkY2SSYWVm5ufi9YX8Rgmh6CTB63AUCxeYTo 3HK5eiLU3zG7il4M02rHiDKb2CT4ChnyvZlXaUouMoPq4s0zima/bUaSb0dTQbNt++ Fqu0YU/GzZx6tAdGoQLeqMrq9oy/wFZ8uuVFivDg= Feedback-ID: mattiase@HIDDEN Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail268c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 18U85XWR019942; Thu, 30 Sep 2021 08:05:35 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: bug#9622: [PATCH] Re: bug#9622: 23.3; flet indentation From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattiase@HIDDEN> In-Reply-To: <87tui26027.fsf@HIDDEN> Date: Thu, 30 Sep 2021 10:05:33 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <7A41EEAF-B19C-48A2-9033-275B7E001884@HIDDEN> References: <504153FB-8633-4755-A91A-DF5DD64E6FAA@HIDDEN> <87lf3fntdx.fsf@HIDDEN> <87tui26027.fsf@HIDDEN> To: Lars Ingebrigtsen <larsi@HIDDEN> X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F1C.61556FCF.0061, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.4 cv=QcUFAuXv c=1 sm=1 tr=0 ts=61556fd0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=OocQHUDgAAAA:8 a=0pbIO5yG-jWZW8EYeOwA:9 a=CjuIK1q_8ugA:10 a=xUZTl98r3Qw_uB5NK3jt:22 X-Origin-Country: SE X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 30 sep. 2021 kl. 08.37 skrev Lars Ingebrigtsen <larsi@HIDDEN>: >> - I attached flet-tests.sexp which only contains cl-flet forms written >> the way they are meant to be indented. I think writing them in >> strings in deftest forms would be quite ugly and unreliab [...] Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-Debbugs-Envelope-To: 9622 Cc: 9622 <at> debbugs.gnu.org, akater <nuclearspace@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) 30 sep. 2021 kl. 08.37 skrev Lars Ingebrigtsen <larsi@HIDDEN>: >> - I attached flet-tests.sexp which only contains cl-flet forms = written >> the way they are meant to be indented. I think writing them in >> strings in deftest forms would be quite ugly and unreliable. What would be unreliable? > Indeed. I have a new machinery for doing tests like this waiting for > Emacs 29 development to commence to fix this awkwardness. We should insist on tests accompanying any bug fix from the start. = Awkward is better than nothing. If the author finds it too difficult to = write the test then we should help. Akater, we have plenty of indentation tests for other programming modes = already and they employ a variety of methods; there are many examples to = look at. For instance, look at ruby-mode-tests.el; it contains a = converted legacy test (ruby--indent/converted-from-manual-test) that = reindents a separate source file, much like your example. If you need further directions, we will assist.
bug-gnu-emacs@HIDDEN:bug#9622; Package emacs.
Full text available.Received: (at 9622) by debbugs.gnu.org; 30 Sep 2021 06:37:49 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Sep 30 02:37:48 2021 Received: from localhost ([127.0.0.1]:51206 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mVphU-0001AB-Kh for submit <at> debbugs.gnu.org; Thu, 30 Sep 2021 02:37:48 -0400 Received: from quimby.gnus.org ([95.216.78.240]:38282) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <larsi@HIDDEN>) id 1mVphT-00019w-92 for 9622 <at> debbugs.gnu.org; Thu, 30 Sep 2021 02:37:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=sTk9XTZFVJv8z483NHNpzmNWy7894VSlaybnjyPZ59I=; b=L0sXsKz5rlKcfsJ8txDPpUIQJ2 DOCG4DRScHF8aZIEsw8GbKJUt6MLYUEJfbjUlBkJr6ZCBjF3RWlcVvkL9vJIs348qsucpbPfgLdFg ul0McyMIe32Oqni/GqGlMDmlR/Efyjd7P5vSiZNFK7ZpWn5ma4rNmS8gJqol7qX7xxhA=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <larsi@HIDDEN>) id 1mVphI-0002ZX-Th; Thu, 30 Sep 2021 08:37:39 +0200 From: Lars Ingebrigtsen <larsi@HIDDEN> To: akater <nuclearspace@HIDDEN> Subject: Re: bug#9622: [PATCH] Re: bug#9622: 23.3; flet indentation References: <504153FB-8633-4755-A91A-DF5DD64E6FAA@HIDDEN> <87lf3fntdx.fsf@HIDDEN> X-Now-Playing: The Notwist's _Close to the Glass_: "Signals" Date: Thu, 30 Sep 2021 08:37:36 +0200 In-Reply-To: <87lf3fntdx.fsf@HIDDEN> (akater's message of "Wed, 29 Sep 2021 18:12:10 +0000") Message-ID: <87tui26027.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: akater <nuclearspace@HIDDEN> writes: > - We now check whether we're in the relevant subexpression of flet and > friends. > > - Added -p to the predicate's name. > > - Added cl-macrolet cl-flet* cl-symbol-macrolet to the list of local > d [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 9622 Cc: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattiase@HIDDEN>, 9622 <at> debbugs.gnu.org, "Diogo F. S. Ramos" <diogofsr@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) akater <nuclearspace@HIDDEN> writes: > - We now check whether we're in the relevant subexpression of flet and > friends. > > - Added -p to the predicate's name. > > - Added cl-macrolet cl-flet* cl-symbol-macrolet to the list of local > definers. I added cl-symbol-macrolet too because this is how SLIME > indents symbol-macrolet. Thanks; applied to Emacs 28. > - I attached flet-tests.sexp which only contains cl-flet forms written > the way they are meant to be indented. I think writing them in > strings in deftest forms would be quite ugly and unreliable. Indeed. I have a new machinery for doing tests like this waiting for Emacs 29 development to commence to fix this awkwardness. > - You changed =E2=80=9Ciff=E2=80=9D to =E2=80=9Cif=E2=80=9D; I meant =E2= =80=9Ciff=E2=80=9D, i.e. =E2=80=9Cif and only if=E2=80=9D; I > now changed it to =E2=80=9Cwhen=E2=80=9D simply because the semantics c= orresponds > directly to that of lisp's own lingo and is thus in my opinion > easier to read. Oops, sorry. > The more involved stylistic note is > > - a line split issue that I wanted to discuss for some time. See the > diff when it comes to second-order-parent and (pop parents). TL;DR: > it's entirely up to you but I wanted to point out that this was done > deliberately. Note that if pop (or a hypothetical cdrf) accepted > multiple arguments, most people would agree it's fine to keep these > two on a single line; if you have time, see the discussion I started > in emacs-devel: > https://lists.gnu.org/archive/html/emacs-devel/2021-09/msg02189.html We never put two statements on the same line like that, so I added a newline there (and some other stylistic fixes, like changing the `and' to a when (the `and' is logical here (since we're doing a predicate), but we prefer `when' when it's a long and involved body). --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no
bug-gnu-emacs@HIDDEN:bug#9622; Package emacs.
Full text available.
Received: (at 9622) by debbugs.gnu.org; 29 Sep 2021 18:23:53 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Sep 29 14:23:53 2021
Received: from localhost ([127.0.0.1]:50203 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1mVeFD-0000e5-UT
for submit <at> debbugs.gnu.org; Wed, 29 Sep 2021 14:23:53 -0400
Received: from mail-qk1-f181.google.com ([209.85.222.181]:40530)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <nuclearspace@HIDDEN>) id 1mVeF7-0000dm-R8
for 9622 <at> debbugs.gnu.org; Wed, 29 Sep 2021 14:23:51 -0400
Received: by mail-qk1-f181.google.com with SMTP id 72so3244249qkk.7
for <9622 <at> debbugs.gnu.org>; Wed, 29 Sep 2021 11:23:45 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
h=from:to:cc:subject:in-reply-to:references:date:message-id
:mime-version; bh=ArSH97DPjmZnAq1eLMR9yaW6d7+wbt7HWhfhVvQTbkw=;
b=TqeJt/ksD+PpPEpRKrB77DaWDRWFAR01HjZHIoAeBL2G5DBT3a88jmj1Bq3nUVe1bx
acSSVJL7hW7IHZn8VaZKkLA13UbUU+pbmDGfuJMImj+7R/0crLZI5ODlZYW1mIoy/qXT
Xi1/1Q88I4y4Y6HCLhkmMUZplgL68Ut7xNTco7Js86hxkswP4kVlVGaivwJoly/PyY2I
0oz+oFZQEhrPJra/sU8s77jCL2dzCYcwcpCd76jvEqubwtV/HoukWUPWXgVGjYIpcxEZ
PP1Vbp/ZAngTvlhZdZ6OluXfELr7yqUjm4Ly0ev2608IAO8uc2die6Bz4V+R96E1CONv
YRFg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date
:message-id:mime-version;
bh=ArSH97DPjmZnAq1eLMR9yaW6d7+wbt7HWhfhVvQTbkw=;
b=Zba3yINq5uOZSZwzPdmeral3vgRplaLb6WAUMSyjSRuK+dJkfOLTFH7VvW2eNIjgeF
2W05m6SKMNsIFSukuRqk6LcHmOZS0JE2cwYNseS3qkF2EPKmIk0bryuqh+61pH8h0qGx
HmcaHiQ9IGT4jC/7pCxAhlH89PqzistaBvfnTc9BE2oE5T0SAauJy7yeDIQmdhR/rAjy
DioiKzQyH4GHMFB0mnQAP31nQSBSNQN7+d4B/tKVzncuJ1VrJBBJ7mz+EydtkxBSOBiO
SOjyKQet2IZupQKPDQOtrrmfCrHFOR6e0Gq+ll4kP54t5YOMZ8FA3J/4T7HtiHRQLKvB
BCYw==
X-Gm-Message-State: AOAM531Gv7XcPJfXtI9N/cLOjwNobtBFf1eY2Gj5jfepjLo/Lh6Ck0JS
RCVHNc47yjr15QEX1hZBSyw=
X-Google-Smtp-Source: ABdhPJyqLtT56BSSnXaGAfk1AR5w+h52H/k9tSj7JaYOE2i6Ja8ipjt277/vehh1xsDtlN1D37IQ3A==
X-Received: by 2002:a37:6547:: with SMTP id z68mr1179509qkb.303.1632939820331;
Wed, 29 Sep 2021 11:23:40 -0700 (PDT)
Received: from localhost (wholesomeserver.media.mit.edu. [18.27.197.252])
by smtp.googlemail.com with ESMTPSA id k19sm360371qko.115.2021.09.29.11.23.39
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 29 Sep 2021 11:23:39 -0700 (PDT)
From: akater <nuclearspace@HIDDEN>
To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattiase@HIDDEN>
Subject: [PATCH] Re: bug#9622: 23.3; flet indentation
In-Reply-To: <504153FB-8633-4755-A91A-DF5DD64E6FAA@HIDDEN>
References: <504153FB-8633-4755-A91A-DF5DD64E6FAA@HIDDEN>
Date: Wed, 29 Sep 2021 18:12:10 +0000
Message-ID: <87lf3fntdx.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Several fixes: - We now check whether we're in the relevant
subexpression of flet and friends. - Added -p to the predicate's name.
Content analysis details: (1.2 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in
bl.spamcop.net
[Blocked - see <https://www.spamcop.net/bl.shtml?18.27.197.252>]
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (nuclearspace[at]gmail.com)
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust [209.85.222.181 listed in list.dnswl.org]
-0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2)
[209.85.222.181 listed in wl.mailspike.net]
X-Debbugs-Envelope-To: 9622
Cc: Lars Ingebrigtsen <larsi@HIDDEN>, 9622 <at> debbugs.gnu.org,
"Diogo F. S. Ramos" <diogofsr@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.2 (/)
--=-=-=
Content-Type: multipart/signed; boundary="==-=-=";
micalg=pgp-sha512; protocol="application/pgp-signature"
--==-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Several fixes:
=2D We now check whether we're in the relevant subexpression of flet and
friends.
=2D Added -p to the predicate's name.
=2D Added cl-macrolet cl-flet* cl-symbol-macrolet to the list of local
definers. I added cl-symbol-macrolet too because this is how SLIME
indents symbol-macrolet.
Technical notes:
=2D I attached flet-tests.sexp which only contains cl-flet forms written
the way they are meant to be indented. I think writing them in
strings in deftest forms would be quite ugly and unreliable. If
appropriate, I could add test(s) that would try to indent individual
forms in the file; no change indicates test(s) passed. Only I'm not
sure what would be the best way to define an individual ert test per
form but I guess I'll figure it out. OK?
=2D parse-partial-sexp does not keep any record of relative position of
subexpressions in superexpressions which I found surprising. Things
would be easier if it did. Other things might become easier too.
But I did not dare to patch it.
I also have stylistic notes. First, the less important ones.
=2D You changed =E2=80=9Ciff=E2=80=9D to =E2=80=9Cif=E2=80=9D; I meant =E2=
=80=9Ciff=E2=80=9D, i.e. =E2=80=9Cif and only if=E2=80=9D; I
now changed it to =E2=80=9Cwhen=E2=80=9D simply because the semantics cor=
responds
directly to that of lisp's own lingo and is thus in my opinion
easier to read.
=2D Lines
> In Wishful Lisp, the following form would be
> ...
are supposed to convey the intent of what the form in quistion does,
in a concise way. Feel free to remove this if you feel it doesn't
help.
The more involved stylistic note is
=2D a line split issue that I wanted to discuss for some time. See the
diff when it comes to second-order-parent and (pop parents). TL;DR:
it's entirely up to you but I wanted to point out that this was done
deliberately. Note that if pop (or a hypothetical cdrf) accepted
multiple arguments, most people would agree it's fine to keep these
two on a single line; if you have time, see the discussion I started
in emacs-devel:
https://lists.gnu.org/archive/html/emacs-devel/2021-09/msg02189.html
--==-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQJLBAEBCgA1FiEEgu5SJRdnQOF34djNsr6xYbHsf0QFAmFUrHoXHG51Y2xlYXJz
cGFjZUBnbWFpbC5jb20ACgkQsr6xYbHsf0S2qQ/+K9AIm82i0sov8jkZfe0OSVns
6Dp29UG4vHMNV9GF/reAPVy72ewQW4QZo7dP0EyItZHNllHPgOnAXPApnZdpYBqL
gk067/B4MN6Erctep5gjys/0xGn0bHzJjAAzg/MrdsXDKkynNhSPP83qqEN4Kl/F
VvZWKz2HVxYjtaW+OKDnP8CsA1bj0I4+d4ZNbVVABH0ghwysuY+UZVkno2/66xot
0+7aShJYmhJU/53q4gxXw6R6N76Q+Jj5cQiTISWZJA2a//LcwA/NwgaBz5fIoi4o
9CX/luTdUdjj26lOd1EOFkGaGg9B8qXznzo+E1+G5s8U22NxC6Dm2IuLy1Ev/Qik
TWBQv92yW5TSwSaGd9XcQZ0lEERZqU6quvw7h+7sNbJNssqzue8M8YZrnNI928qM
bwJNy+80eY/N8slHGuougVm/6y068wQZ2d5OfqJDxdenQC07XLv7dLaUlv1Y4X4E
3xfrdhCBWVV2H3Jytqu2L1SNE25LfKyT1xE1qrTQimPGQ0Lg7m2vsdut9wTg7N0L
KQ6ABhCQQwH8vAMQpy75LTFEYxszUSviZXnTclaBuIKd98aKbDHItvIJ4ikV7c8T
DfCLqM3+s1ncrcstHgoWCD7+zCvse1gksAFLgqUrjNRtPIh+vKZAbAyaSRoNhxr0
DDZKyXV2YPigxr5NBss=
=0wRN
-----END PGP SIGNATURE-----
--==-=-=--
--=-=-=
Content-Type: text/x-diff
Content-Disposition: attachment;
filename=0001-Fixup-cl-flet-indentation.patch
Content-Description: Fix cl-flet indentation
From 688ec23060f89a75d7356bba576bc8d31f32174f Mon Sep 17 00:00:00 2001
From: akater <nuclearspace@HIDDEN>
Date: Wed, 29 Sep 2021 15:45:32 +0000
Subject: [PATCH] ; Fixup: cl-flet indentation
Addresses several deficiencies in bugfix
38037e04cb05cb1f2b604f0b1602d36b0bcf6985
- Check whether we're in the relevant subexpression of flet and
friends.
- Add -p to the predicate's name.
- Add cl-macrolet cl-flet* cl-symbol-macrolet to the list of local
definers. cl-symbol-macrolet added because this is how SLIME indents
symbol-macrolet.
---
lisp/emacs-lisp/lisp-mode.el | 55 ++++++++++++++++++++++++++++--------
1 file changed, 43 insertions(+), 12 deletions(-)
diff --git a/lisp/emacs-lisp/lisp-mode.el b/lisp/emacs-lisp/lisp-mode.el
index 7ce857e990..d2d63606da 100644
--- a/lisp/emacs-lisp/lisp-mode.el
+++ b/lisp/emacs-lisp/lisp-mode.el
@@ -1106,26 +1106,55 @@ defun calculate-lisp-indent (&optional parse-start)
(t
normal-indent))))))
-(defun lisp--local-defform-body (state)
- "Return non-nil if at local definition body according to STATE.
+(defun lisp--local-defform-body-p (state)
+ "Return non-nil when at local definition body according to STATE.
STATE is the `parse-partial-sexp' state for current position."
(when-let ((start-of-innermost-containing-list (nth 1 state)))
- (let* ((parents (nth 9 state))
- (second-cons-after (cddr parents))
- second-order-parent)
+ (let* ((parents (nth 9 state)) second-order-parent
+ (second-cons-after (cddr parents)))
(while second-cons-after
(when (= start-of-innermost-containing-list
(car second-cons-after))
(setq second-order-parent (car parents)
;; Leave the loop.
second-cons-after nil))
- (pop second-cons-after)
- (pop parents))
+ (pop second-cons-after) (pop parents))
(and second-order-parent
(save-excursion
(goto-char (1+ second-order-parent))
- (memq (read (current-buffer))
- '(cl-flet cl-labels)))))))
+ (and (memq (read (current-buffer))
+ '( cl-flet cl-labels cl-macrolet cl-flet*
+ cl-symbol-macrolet))
+ ;; Now we must check that we are
+ ;; in the second element of the flet-like form.
+ ;; It would be easier if `parse-partial-sexp' also recorded
+ ;; relative positions of subsexps in supersexps
+ ;; but it doesn't so we check manually.
+ ;;
+ ;; First, we must be looking at list now.
+ (ignore-errors (when (= (scan-lists (point) 1 0)
+ (scan-sexps (point) 1))
+ ;; Looking at list; descend into it:
+ (down-list 1)
+ t))
+ ;; In Wishful Lisp, the following form would be
+ ;; (cl-member start-of-innermost-containing-list
+ ;; (points-at-beginning-of-lists-at-this-level)
+ ;; :test #'=)
+ (cl-loop
+ with pos = (ignore-errors
+ ;; The first local definition may be indented
+ ;; with whitespace following open paren.
+ (goto-char (scan-lists (point) 1 0))
+ (goto-char (scan-lists (point) -1 0))
+ (point))
+ while pos
+ do (if (= start-of-innermost-containing-list pos)
+ (cl-return t)
+ (setq pos (ignore-errors
+ (goto-char (scan-lists (point) 2 0))
+ (goto-char (scan-lists (point) -1 0))
+ (point)))))))))))
(defun lisp-indent-function (indent-point state)
"This function is the normal value of the variable `lisp-indent-function'.
@@ -1160,7 +1189,9 @@ defun lisp-indent-function (indent-point state)
(if (and (elt state 2)
(not (looking-at "\\sw\\|\\s_")))
;; car of form doesn't seem to be a symbol
- (if (lisp--local-defform-body state)
+ (if (lisp--local-defform-body-p state)
+ ;; We nevertheless check whether we are in flet-like form
+ ;; as we presume local function names could be non-symbols.
(lisp-indent-defform state indent-point)
(if (not (> (save-excursion (forward-line 1) (point))
calculate-lisp-indent-last-sexp))
@@ -1184,8 +1215,8 @@ defun lisp-indent-function (indent-point state)
(and (null method)
(> (length function) 3)
(string-match "\\`def" function))
- ;; Check whether we are in flet or labels.
- (lisp--local-defform-body state))
+ ;; Check whether we are in flet-like form.
+ (lisp--local-defform-body-p state))
(lisp-indent-defform state indent-point))
((integerp method)
(lisp-indent-specform method state
--
2.32.0
--=-=-=
Content-Type: text/plain
Content-Disposition: attachment; filename=flet-tests.sexp
Content-Description: Test cases
(cl-flet ()
(a (dangerous-position
b)))
(cl-flet wrong-syntax-but-should-not-obstruct-indentation
(a (dangerous-position
b)))
(cl-flet ((a (arg-of-flet-a)
b
c)))
(cl-flet ((a (arg-of-flet-a)
b
c
(if d
e
f))
(irregular-local-def (form
returning
lambda))
(g (arg-of--flet-g)
h
i))
(let ((j k))
(if dangerous-position
l
m)))
(cl-flet ((a (arg-of-flet-a)
b
c
(if d
e
f))
(irregular-local-def (form
returning
lambda))
(g (arg-of--flet-g)
h
i))
(let ((j k))
(if dangerous-position
l
m)))
(cl-flet ((a (arg-of-flet-a)
b
c
(if d
e
f))
(irregular-local-def (form
returning
lambda))
(irregular-local-def (form returning
lambda))
wrong-syntax-but-should-not-osbtruct-indentation
(g (arg-of--flet-g)
h
i))
(let ((j k))
(if dangerous-position
l
m)))
(cl-flet ((a (arg-of-flet-a)
b
c
(if d
e
f))
(irregular-local-def (form
returning
lambda))
wrong-syntax-but-should-not-osbtruct-indentation
(g (arg-of--flet-g)
h
i))
(let ((j k))
(if dangerous-position
l
m)))
(cl-flet (wrong-syntax-but-should-not-obstruct-indentation
(g (arg-of--flet-g)
h
i))
(let ((j k))
(if dangerous-position
l
m)))
;; (setf _) not yet supported but looks like it will be
(cl-flet (((setf a) (new value)
stuff)
wrong-syntax-but-should-not-obstruct-indentation
(g (arg-of--flet-g)
h
i))
(let ((j k))
(if dangerous-position
l
m)))
(cl-flet ( (a (arg-of-flet-a)
b
c
(if d
e
f))
(irregular-local-def (form
returning
lambda))
(g (arg-of--flet-g)
h
i))
(let ((j k))
(if dangerous-position
l
m)))
(cl-flet ( wrong-syntax-but-should-not-obstruct-indentation
(g (arg-of--flet-g)
h
i))
(let ((j k))
(if dangerous-position
l
m)))
(cl-flet ( wrong-syntax-but-should-not-obstruct-indentation
(g (arg-of--flet-g)
h
i))
(let ((j k))
(if dangerous-position
l
m)))
(cl-flet (wrong-syntax-but-should-not-obstruct-indentation
(g (arg-of--flet-g)
h
i)
wrong-syntax-but-should-not-obstruct-indentation
(g (arg-of--flet-g)
h
i)))
(cl-flet (wrong-syntax-but-should-not-obstruct-indentation
wrong-syntax-but-should-not-obstruct-indentation
(g (arg-of--flet-g)
h
i)
wrong-syntax-but-should-not-obstruct-indentation))
(cl-flet (wrong-syntax-but-should-not-obstruct-indentation
wrong-syntax-but-should-not-obstruct-indentation
wrong-syntax-but-should-not-obstruct-indentation
(g (arg-of--flet-g)
h
i)))
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#9622; Package emacs.
Full text available.Received: (at 9622) by debbugs.gnu.org; 28 Sep 2021 16:51:32 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Sep 28 12:51:32 2021 Received: from localhost ([127.0.0.1]:46849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mVGKK-0008Uw-2e for submit <at> debbugs.gnu.org; Tue, 28 Sep 2021 12:51:32 -0400 Received: from mail-wr1-f43.google.com ([209.85.221.43]:38807) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <nuclearspace@HIDDEN>) id 1mVGKI-0008Ud-J4 for 9622 <at> debbugs.gnu.org; Tue, 28 Sep 2021 12:51:30 -0400 Received: by mail-wr1-f43.google.com with SMTP id u18so59228451wrg.5 for <9622 <at> debbugs.gnu.org>; Tue, 28 Sep 2021 09:51:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=mWNspKMlh5ykF/eM9Ctcy/Ip5BYS0Ds4yS5VQpkqA0I=; b=lYiPMWU6IqAvoPTdfxv47QZcWvqrpOetXSKyhjM39cbatJpNU0zzLeutyiOU9xrIU/ zyPf4J/qyKXlyj1lKUDP9ljGLHDdY2ERol8IegGDMeKcOI21Q9gIVi8KNmRB914fFTwb RsR6TWqD5cmi55EtQPaus40I7PgcqUTEeBaSKpA3U5bidOFS+aHzU9PWkEWobbggrM0M tbOMVzBG83Mig/l1DuoYMOd5vOwn2LBvX3nrg6wtkD8vJfxGEKvxa6VCQ//1QtiD/m1S 5vvOwW7lvhvr+4OLTJwpkMWEss/46i80ic6FqE41dDt212GzYOjuzb8DEBg6oQCnH7m5 VhTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=mWNspKMlh5ykF/eM9Ctcy/Ip5BYS0Ds4yS5VQpkqA0I=; b=a9r54HjXCDVGRixmS+SD4D0KTPgyzJeiRKpnuFzvW16Kh7D956apCJpqmEVyXh/oAJ iCLmqkTH/idXZJTWnpNMmjzmOFusVWJvNGwq6fcmJbuINn+SwxvzH/3SEnPN4lPWQghQ WhPeKBsYx25QLJ0sBMqGtXI0I6tGzDnOXg3uQ3AeThaJRof/aNxbrgNNYxwcj7sXz3n5 7jCCTuS0hA4n/EK9OuGrUTcC+3Rah4paEsKgmK8fEU9wX7v4IUd46MLjoF4IxVYIuTk1 IEbxh8tGDcdtJdvG+087vH3LjD4hTFNLZmSm4K4qwddaa/86C7zy21dDD5aQsYpLen/z peLg== X-Gm-Message-State: AOAM533zWmQ+KKh7Hq4HWBufs7326gsQdCTgCIwBN0HqH9ddbVF8Z+gc TzCAl6tqgcYcd+49F8IH3dM= X-Google-Smtp-Source: ABdhPJzGZmAHBVlH0OzKAW4lQ1N9UG4ASmbt7HVOyDFr2zmgEy1M35w+JawWNL7jxIGnWR4B0BmtHA== X-Received: by 2002:adf:cc82:: with SMTP id p2mr1343943wrj.5.1632847884657; Tue, 28 Sep 2021 09:51:24 -0700 (PDT) Received: from localhost (tor-exit-14.zbau.f3netze.de. [185.220.100.241]) by smtp.googlemail.com with ESMTPSA id r2sm3662608wmq.28.2021.09.28.09.51.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Sep 2021 09:51:23 -0700 (PDT) From: akater <nuclearspace@HIDDEN> To: Lars Ingebrigtsen <larsi@HIDDEN> Subject: Re: bug#9622: 23.3; flet indentation In-Reply-To: <87lf3hgtng.fsf@HIDDEN> References: <504153FB-8633-4755-A91A-DF5DD64E6FAA@HIDDEN> <FE9E3B4E-0099-4654-A804-D2CBD345203B@HIDDEN> <87lf3hgtng.fsf@HIDDEN> Date: Tue, 28 Sep 2021 16:39:53 +0000 Message-ID: <87sfxoodra.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: OK I found the culprit; figuring out the least expensive way to resolve. One way or another, I'll fix it in the coming days. Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in bl.spamcop.net [Blocked - see <https://www.spamcop.net/bl.shtml?185.220.100.241>] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (nuclearspace[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.43 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.43 listed in wl.mailspike.net] X-Debbugs-Envelope-To: 9622 Cc: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattiase@HIDDEN>, 9622 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.2 (/) --=-=-= Content-Type: text/plain OK I found the culprit; figuring out the least expensive way to resolve. One way or another, I'll fix it in the coming days. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJLBAEBCgA1FiEEgu5SJRdnQOF34djNsr6xYbHsf0QFAmFTRVkXHG51Y2xlYXJz cGFjZUBnbWFpbC5jb20ACgkQsr6xYbHsf0SKTQ/+ODvESnK7UhCN3GT+AvhIg3hm yb1xnmCcMcoWde6vaRs5CiUS9i2dcTJt1RqfChZ+O8ap+PsRvKhVTDZlC093r8TG fBTWkya0cdf9x7gjmT06JA8TDq3ePOCHNkcpYZbKCLxs2nHcHXOQ0bawklprp8WB VzFQfTu2pMPb7ekue2vJ5GzPOTLEiHuqWP8BRhrtHtDcx0nvUTMVsiXfnWEB0LwJ 9QmG5pztMic+BvxcxGmRDC5rJnsm9/2Fo7Jp1Pb+Dwm7FCraUxcPofouxPL4rqbA ZSzzmQRxIEB084vRKKyG+WAadA3mXF3nTglHm0CmM70es2Znxjp+KEDVqQNjAzG6 j9l3uSAJwyDv3ZZ+d1i/LWJ/8gMizkvGw2QN/3XPdQkS0b2h6JYx5hwwmiHV8Zis g1Yu0AnC4sK7chCu/aLxHFYE1JxGezYq6JPIbhmFcch4gGKesSSb7R1wI4CIZuPm REpMdghSfggjX7hxDsxNF/X7TXaBL+kw84LX6HWyXJX3NIJciG8delCajGriJ819 fN5iKB13o3q97b6FbeyIUEHA9fPnP/lL+YFHa0OgKUMhfkHKKNOpxzN206mbmO2p Dr8+rKH5IUtH1Y6pLMw/5zasMDe9oS9IK0OvWUNx4y77JUDa6KxpsGLGgHYM2Ytl P1c6dLM9nsaXXbbCVCM= =tmu7 -----END PGP SIGNATURE----- --=-=-=--
bug-gnu-emacs@HIDDEN:bug#9622; Package emacs.
Full text available.
Received: (at 9622) by debbugs.gnu.org; 28 Sep 2021 10:36:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Sep 28 06:36:03 2021
Received: from localhost ([127.0.0.1]:43988 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1mVASw-0000MD-PF
for submit <at> debbugs.gnu.org; Tue, 28 Sep 2021 06:36:02 -0400
Received: from mail229c50.megamailservers.eu ([91.136.10.239]:57352
helo=mail36c50.megamailservers.eu)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <mattiase@HIDDEN>) id 1mVASt-0000Lm-LL
for 9622 <at> debbugs.gnu.org; Tue, 28 Sep 2021 06:36:01 -0400
X-Authenticated-User: mattiase@HIDDEN
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu;
s=maildub; t=1632825357;
bh=r/v7/uZqQsZ6cS/zpmpklewHhfDdTWT/EtewYfE4nCQ=;
h=Subject:From:In-Reply-To:Date:Cc:References:To:From;
b=Y8OrWYiTyc36AICU5hQnD1KTm8l4VWb0GDTOpzJ7oMyZiCbdA8ftYfnr/BEGgm5NN
hc0chTCpXypSgrzwY0lpxWozf71aReloAB83k1nBaIfLxZR3h/d3nJLaIKjgN7jl8u
zSGORo7wzuq/K3WXfnENLgz4VVXlfU0EhZxtPNJA=
Feedback-ID: mattiase@HIDDEN
Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se
[188.150.171.71]) (authenticated bits=0)
by mail36c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 18SAZsex009770;
Tue, 28 Sep 2021 10:35:56 +0000
Content-Type: text/plain;
charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\))
Subject: Re: bug#9622: 23.3; flet indentation
From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattiase@HIDDEN>
In-Reply-To: <87lf3hgtng.fsf@HIDDEN>
Date: Tue, 28 Sep 2021 12:35:54 +0200
Content-Transfer-Encoding: 7bit
Message-Id: <74874DD0-15F8-4C12-8EC4-D753CBD79EA1@HIDDEN>
References: <504153FB-8633-4755-A91A-DF5DD64E6FAA@HIDDEN>
<FE9E3B4E-0099-4654-A804-D2CBD345203B@HIDDEN> <87lf3hgtng.fsf@HIDDEN>
To: Lars Ingebrigtsen <larsi@HIDDEN>
X-Mailer: Apple Mail (2.3445.104.21)
X-CTCH-RefID: str=0001.0A742F2A.6152F00D.0012, ss=1, re=0.000, recu=0.000,
reip=0.000, cl=1, cld=1, fgs=0
X-CTCH-VOD: Unknown
X-CTCH-Spam: Unknown
X-CTCH-Score: 0.000
X-CTCH-Rules:
X-CTCH-Flags: 0
X-CTCH-ScoreCust: 0.000
X-CSC: 0
X-CHA: v=2.4 cv=Crjczl0D c=1 sm=1 tr=0 ts=6152f00d
a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17
a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=Wzn737URG6fpFuyVMVAA:9
a=CjuIK1q_8ugA:10
X-Origin-Country: SE
X-Spam-Score: 1.4 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: More examples: (cl-flet ((f () alpha)) (let ((x y)) (if beta
gamma ; <- wrong delta))) (cl-flet ((f () alpha)) (gamma (delta epsilon)))
; <- wrong
Content analysis details: (1.4 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail)
0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS
X-Debbugs-Envelope-To: 9622
Cc: 9622 <at> debbugs.gnu.org, akater <nuclearspace@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
More examples:
(cl-flet ((f () alpha))
(let ((x y))
(if beta
gamma ; <- wrong
delta)))
(cl-flet ((f () alpha))
(gamma
(delta
epsilon))) ; <- wrong
bug-gnu-emacs@HIDDEN:bug#9622; Package emacs.
Full text available.
Received: (at 9622) by debbugs.gnu.org; 28 Sep 2021 10:12:08 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Sep 28 06:12:08 2021
Received: from localhost ([127.0.0.1]:43968 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1mVA5o-00084a-8Q
for submit <at> debbugs.gnu.org; Tue, 28 Sep 2021 06:12:08 -0400
Received: from mail1446c50.megamailservers.eu ([91.136.14.46]:52308
helo=mail265c50.megamailservers.eu)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <mattiase@HIDDEN>) id 1mVA5l-000844-Un
for 9622 <at> debbugs.gnu.org; Tue, 28 Sep 2021 06:12:07 -0400
X-Authenticated-User: mattiase@HIDDEN
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu;
s=maildub; t=1632823918;
bh=ReHtIy1JqdaZw0Scci2ILy8LZ+nHy29zQPSW2hmraow=;
h=Subject:From:In-Reply-To:Date:Cc:References:To:From;
b=IsInG5nd0zDVb408JlByVeUZTFYxxfB1WH5N58uM0eAV2phtUTI6bh6Xbd5TcTKFX
eAC9Vs5FoM38pBz1CwvDADStXZiJRB0ROMq5co3K5q9oJeMNyjBFu/ozz0kyF4bviY
0Im+vrm74hbzABbZ6So1dgUhw6LF2Lsp/OX9aXaI=
Feedback-ID: mattiase@HIDDEN
Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se
[188.150.171.71]) (authenticated bits=0)
by mail265c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 18SABu51004413;
Tue, 28 Sep 2021 10:11:57 +0000
Content-Type: text/plain;
charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\))
Subject: Re: bug#9622: 23.3; flet indentation
From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattiase@HIDDEN>
In-Reply-To: <87lf3hgtng.fsf@HIDDEN>
Date: Tue, 28 Sep 2021 12:11:55 +0200
Content-Transfer-Encoding: 7bit
Message-Id: <7B5F3ABA-0548-447A-B02A-DAB262349625@HIDDEN>
References: <504153FB-8633-4755-A91A-DF5DD64E6FAA@HIDDEN>
<FE9E3B4E-0099-4654-A804-D2CBD345203B@HIDDEN> <87lf3hgtng.fsf@HIDDEN>
To: Lars Ingebrigtsen <larsi@HIDDEN>
X-Mailer: Apple Mail (2.3445.104.21)
X-CTCH-RefID: str=0001.0A742F27.6152EA6E.006B, ss=1, re=0.000, recu=0.000,
reip=0.000, cl=1, cld=1, fgs=0
X-CTCH-VOD: Unknown
X-CTCH-Spam: Unknown
X-CTCH-Score: 0.000
X-CTCH-Rules:
X-CTCH-Flags: 0
X-CTCH-ScoreCust: 0.000
X-CSC: 0
X-CHA: v=2.4 cv=adICITkt c=1 sm=1 tr=0 ts=6152ea6e
a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17
a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=qflyAvl2H5422TfPxyEA:9
a=CjuIK1q_8ugA:10
X-Origin-Country: SE
X-Spam-Score: 1.4 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: It affects other constructs too: (cl-flet ((f () alpha))
(cond (beta gamma))) ; <- wrong
Content analysis details: (1.4 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail)
0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS
X-Debbugs-Envelope-To: 9622
Cc: 9622 <at> debbugs.gnu.org, akater <nuclearspace@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
It affects other constructs too:
(cl-flet ((f () alpha))
(cond
(beta
gamma))) ; <- wrong
bug-gnu-emacs@HIDDEN:bug#9622; Package emacs.
Full text available.
Received: (at 9622) by debbugs.gnu.org; 28 Sep 2021 05:24:02 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Sep 28 01:24:02 2021
Received: from localhost ([127.0.0.1]:43454 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1mV5b0-0004Vm-GZ
for submit <at> debbugs.gnu.org; Tue, 28 Sep 2021 01:24:02 -0400
Received: from quimby.gnus.org ([95.216.78.240]:40970)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <larsi@HIDDEN>) id 1mV5ay-0004VH-34
for 9622 <at> debbugs.gnu.org; Tue, 28 Sep 2021 01:24:00 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID
:In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID:
Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
List-Post:List-Owner:List-Archive;
bh=3fcWL0uF7N6WoRBfzUKy2OvxbwWj3l95ehklD37Km4Q=; b=KxNEp+qT1u4Y4xRe0RlR+z7F4E
veoCNX3DocsNJxY1zfxjTmOmIWhAdrxhjRvcs0Wdy80TX7sdLgAt9CEwyz9H9syW/svwvqS1eTRA7
2qV2RkXtliako9tfqEd39iTyaoblqx2QDH0cUB1aFADteKA0rFhWukxCk1SroCfaBb+g=;
Received: from [84.212.220.105] (helo=elva)
by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.92) (envelope-from <larsi@HIDDEN>)
id 1mV5ap-0007bw-CD; Tue, 28 Sep 2021 07:23:53 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: akater <nuclearspace@HIDDEN>
Subject: Re: bug#9622: 23.3; flet indentation
References: <504153FB-8633-4755-A91A-DF5DD64E6FAA@HIDDEN>
<FE9E3B4E-0099-4654-A804-D2CBD345203B@HIDDEN>
Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj
SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEXYebPYd7KtYpCK
TnJHKDvwyeL////KdnvEAAAAAWJLR0QGYWa4fQAAAAlwSFlzAAAAZAAAAGQAD5bF3QAAAAd0SU1F
B+UJHAUVGyaZR9QAAAGlSURBVDjLbZNtjoQgDIYLM/wHXP8reIDNlBMMHABnw/2vsgVEUaeJIekj
Lf14Aa7GZmYRw80PWhobXAB1GJOKaWOGgC4ESCKmmEQiExBFNPOyAbKYimUaP9p58lcgs3MsYFqH
UKyANbMKIlvCcSN24IPdDZYSbED8uQ5AAzHND4e4hyrRMvibjEVvMRx1xCSjsM5jNk8EjqJVjY4F
9r3SW9rgTb5x2BJ668DzDHICpSR93J8AVUCFUVtFpLY2t2t1xFz16uyWfe/VuJaBPOu73kstMHdo
pQqpymjyz78lRxwrYKX9+oXO/xzJRZ0t/cEx2KO7dYjF4LE/t05btjPn9/wC6NEy+0EPe6h28vwq
MOCAhkHpRT3HRA17M1gsgsqTYKqes6IdkQD8xU/rrCVYQ36QFKwHw8Symyma/AlwyYsOtEV3AlKa
ogN91YdRE+GJW3cB3FB8rcrGndWk6KFNOBfjryaciy2zvq1P3TqKFNwXwEmy3wCzFr+GotJIm3gD
A70H0d5AESxpwJ23veogq4Ng30TVdED6OPVqaBvtLznaRlX7B5KPsgegCyajAAAAJXRFWHRkYXRl
OmNyZWF0ZQAyMDIxLTA5LTI4VDA1OjIxOjI3KzAwOjAwT9vIeAAAACV0RVh0ZGF0ZTptb2RpZnkA
MjAyMS0wOS0yOFQwNToyMToyNyswMDowMD6GcMQAAAAASUVORK5CYII=
X-Now-Playing: Hexting's _Post Post Rock Rock_: "Bit Mac, No Tomato -Waiting
for ketchup"
Date: Tue, 28 Sep 2021 07:23:47 +0200
In-Reply-To: <FE9E3B4E-0099-4654-A804-D2CBD345203B@HIDDEN> (akater's
message of "Tue, 28 Sep 2021 03:01:13 +0000")
Message-ID: <87lf3hgtng.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
@@CONTACT_ADDRESS@@ for details.
Content preview: akater <nuclearspace@HIDDEN> writes: > I'm not around Emacs
28 atm; could you check if it's still wrong when > cl-flet's definition —
square (x) — is not on a single line? Yes, it's still wrongly indented:
Content analysis details: (-2.9 points, 5.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 9622
Cc: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattiase@HIDDEN>, 9622 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
akater <nuclearspace@HIDDEN> writes:
> I'm not around Emacs 28 atm; could you check if it's still wrong when
> cl-flet's definition =E2=80=94 square (x) =E2=80=94 is not on a single li=
ne?
Yes, it's still wrongly indented:
(cl-flet ((square (x)
(* x x)))
(let* ((a 3)
(b (square a))) ; <-- malindented
b))
--=20
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
bug-gnu-emacs@HIDDEN:bug#9622; Package emacs.
Full text available.
Received: (at 9622) by debbugs.gnu.org; 28 Sep 2021 02:59:49 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 27 22:59:49 2021
Received: from localhost ([127.0.0.1]:43319 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1mV3LR-0000ia-Es
for submit <at> debbugs.gnu.org; Mon, 27 Sep 2021 22:59:49 -0400
Received: from mail-qt1-f180.google.com ([209.85.160.180]:33363)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <nuclearspace@HIDDEN>) id 1mV3LP-0000iN-Hm
for 9622 <at> debbugs.gnu.org; Mon, 27 Sep 2021 22:59:47 -0400
Received: by mail-qt1-f180.google.com with SMTP id x9so18748174qtv.0
for <9622 <at> debbugs.gnu.org>; Mon, 27 Sep 2021 19:59:47 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
h=date:from:to:cc:subject:in-reply-to:references:message-id
:mime-version:content-transfer-encoding;
bh=grWyJTFdXZaXgu6fhtWdUILlv5zgcoaEb4ADYecA7wM=;
b=cAdYJGsEGj3eabnj6BZ/BgA8xHyqRNOsQ5g+cESugluBX7+yBIetvJTlF8VI3VKrYX
Gb+Z53anj0aNxZRLY5yOFYy7YYin7pKEUTGo49wH9IZ1ViKWv99E3Ekebg5s5IGHj7aM
mYeOZU7T9xuH+kmUgExbVPi+iImJKWThtvXTyNMHbokZOhSKcyrzFmktPRh7p0pXxMDf
wm1AD+bIOXR+UG8QCmzBLDB7BY+Dwa0zKi9N3aW2a/7vRf9iszH9G8ZJGuNQ8ZZrt781
M+w0eUygUzwAEaZpzkqeQSZUrticmWwzQh/0cgs3yYdv8DZdmAjcklD+XVDN/AFkyz+S
jvbw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:references
:message-id:mime-version:content-transfer-encoding;
bh=grWyJTFdXZaXgu6fhtWdUILlv5zgcoaEb4ADYecA7wM=;
b=Ah1BfNgkMIHQSC6Kx+vm1sAsYvjW004HD9x23KkGvuqxMq/JdEgYMN/Gu+24oNyfO/
HQiKwV8fgbUZMqH5v8xrL/ibjER3h+ixaR5IUI7AKTRRn7LTJWAo72WdOdlntDu8cpyY
5np311b7314VPQ1NZKLxViCPLMPS+zaJ1VuAECVMV2WsZ3DqAfqmljAs8mmiN1Wl+Sak
TYVF5UHYdurqyN/Fa6VRDzob/F/3KTaOHjPLbC74uyEgvfSWtMyimYL29hzdaB2OBh2j
WNI8HE9OP8sK4+U6MDO9amtz3EyD+mNqJNvEbMHQH3mYfqdgivR1g8c6+DbcizmtScM2
aIoA==
X-Gm-Message-State: AOAM532y4XISljYVnr8hPjXJr4CELTtSY8gf3gP7F6VEw5ySd3ycejmm
G66iaKZzxbDugmvTSc92/r8=
X-Google-Smtp-Source: ABdhPJzrMnHx6sefbgTLE5BXkB1lyfmhK8etvSx6IbGcOxrZ1yRcmZiVTduV4bb4jY+VPCkUk7d9hg==
X-Received: by 2002:ac8:7dc1:: with SMTP id c1mr3250499qte.289.1632797981922;
Mon, 27 Sep 2021 19:59:41 -0700 (PDT)
Received: from [127.0.0.1] ([185.247.225.85])
by smtp.googlemail.com with ESMTPSA id h17sm1543032qtp.13.2021.09.27.19.59.40
(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
Mon, 27 Sep 2021 19:59:41 -0700 (PDT)
Date: Tue, 28 Sep 2021 03:01:13 +0000
From: akater <nuclearspace@HIDDEN>
To: =?ISO-8859-1?Q?Mattias_Engdeg=E5rd?= <mattiase@HIDDEN>
Subject: Re: bug#9622: 23.3; flet indentation
In-Reply-To: <504153FB-8633-4755-A91A-DF5DD64E6FAA@HIDDEN>
References: <504153FB-8633-4755-A91A-DF5DD64E6FAA@HIDDEN>
Message-ID: <FE9E3B4E-0099-4654-A804-D2CBD345203B@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/alternative;
boundary=----YUEI1R9WT6CCM72APBWB4JGN3ROR2A
Content-Transfer-Encoding: 7bit
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: I'm not around Emacs 28 atm; could you check if it's still
wrong when cl-flet's definition — square (x) — is not on a single line?
I'm not around Emacs 28 atm; could you check if it's still wrong [...]
Content analysis details: (1.2 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in
bl.spamcop.net
[Blocked - see <https://www.spamcop.net/bl.shtml?185.247.225.85>]
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (nuclearspace[at]gmail.com)
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
0.0 HTML_MESSAGE BODY: HTML included in message
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust
[209.85.160.180 listed in list.dnswl.org]
-0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3)
[209.85.160.180 listed in wl.mailspike.net]
-0.0 RCVD_IN_MSPIKE_WL Mailspike good senders
X-Debbugs-Envelope-To: 9622
Cc: Lars Ingebrigtsen <larsi@HIDDEN>, 9622 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.2 (/)
------YUEI1R9WT6CCM72APBWB4JGN3ROR2A
Content-Type: text/plain;
charset=utf-8
Content-Transfer-Encoding: quoted-printable
I'm not around Emacs 28 atm; could you check if it's still wrong when cl-fl=
et's definition =E2=80=94 square (x) =E2=80=94 is not on a single line?
------YUEI1R9WT6CCM72APBWB4JGN3ROR2A
Content-Type: text/html;
charset=utf-8
Content-Transfer-Encoding: quoted-printable
<!DOCTYPE html><html><body>I'm not around Emacs 28 atm; could you check if =
it's still wrong when cl-flet's definition =E2=80=94 square (x) =E2=80=94 i=
s not on a single line?</body></html>
------YUEI1R9WT6CCM72APBWB4JGN3ROR2A--
bug-gnu-emacs@HIDDEN:bug#9622; Package emacs.
Full text available.Debbugs Internal Request <help-debbugs@HIDDEN>
to internal_control <at> debbugs.gnu.org.
Full text available.Lars Ingebrigtsen <larsi@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 9622) by debbugs.gnu.org; 25 Sep 2021 01:29:46 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Sep 24 21:29:46 2021 Received: from localhost ([127.0.0.1]:59695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mTwVe-00063M-MO for submit <at> debbugs.gnu.org; Fri, 24 Sep 2021 21:29:46 -0400 Received: from quimby.gnus.org ([95.216.78.240]:33616) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <larsi@HIDDEN>) id 1mTwVc-00062v-W4 for 9622 <at> debbugs.gnu.org; Fri, 24 Sep 2021 21:29:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=U2x5NcpiObkhea/oYcKcl84wv255XWCJ/JSouEfrRLc=; b=hvxqA32rry2+G4HpC8WQXcB1+M S3krHcoxqhu3BbnlCmBA10sR2QM+aZJPbEEygp/050OrjHXbtTnN9VtJowFKazD5z1paSqwKjdKtg 3XoF1W2ppO4ZjWgwYlakIkJNoEwzmpi0YzQyInQ5TeWF2IZWdGZQwynKUi8XdPDdQHsM=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <larsi@HIDDEN>) id 1mTwVT-0007uy-V6; Sat, 25 Sep 2021 03:29:38 +0200 From: Lars Ingebrigtsen <larsi@HIDDEN> To: diogofsr@HIDDEN (Diogo F. S. Ramos) Subject: Re: bug#9622: 23.3; flet indentation References: <87zkhph1k2.fsf@HIDDEN> X-Now-Playing: Brigid Mae Power's _Head Above the Water_: "You Have A Quiet Power" Date: Sat, 25 Sep 2021 03:29:33 +0200 In-Reply-To: <87zkhph1k2.fsf@HIDDEN> (Diogo F. S. Ramos's message of "Tue, 27 Sep 2011 22:56:45 -0300") Message-ID: <877df5sarm.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: diogofsr@HIDDEN (Diogo F. S. Ramos) writes: > Currently, when using `flet', the functions are indented with respect of > the arglist. > > It would be nice if flet functions were indented like a `defun', for > example. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 9622 Cc: 9622 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) diogofsr@HIDDEN (Diogo F. S. Ramos) writes: > Currently, when using `flet', the functions are indented with respect of > the arglist. > > It would be nice if flet functions were indented like a `defun', for > example. This is now fixed in Emacs 28: commit 57dcc26e4af4e4f7812f2e287f18d36c662bf6b1 (HEAD -> master) Author: akater <nuclearspace@HIDDEN> AuthorDate: Sat Sep 25 03:27:29 2021 +0200 -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no
bug-gnu-emacs@HIDDEN:bug#9622; Package emacs.
Full text available.Stefan Kangas <stefan@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Stefan Kangas <stefan@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 9622) by debbugs.gnu.org; 10 Aug 2019 20:10:18 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Aug 10 16:10:18 2019 Received: from localhost ([127.0.0.1]:44496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1hwXgw-0003ns-D8 for submit <at> debbugs.gnu.org; Sat, 10 Aug 2019 16:10:18 -0400 Received: from mail-pl1-f179.google.com ([209.85.214.179]:36788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1hwXgu-0003nR-EP for 9622 <at> debbugs.gnu.org; Sat, 10 Aug 2019 16:10:16 -0400 Received: by mail-pl1-f179.google.com with SMTP id k8so46337608plt.3 for <9622 <at> debbugs.gnu.org>; Sat, 10 Aug 2019 13:10:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=lmAUYr4Kl4V4ZTgv7aj5hY9pRi32vmlCvf4W/giEBcI=; b=tYE/mdHdzcrsjqXhPHOb60jHwAWMXxCm69C0Sfz1o2UYo6Di/zYa5HyyvMF94Yi+Fu hu40L9lU4+NvwRGZcgcfuEJJM/gcJBW13zzXTnET2V74VH4Y5AGKVdatHhT13JDA3cOK DclHW3wXSsTVMU/i62SjqV8bN1k1CxoEvWykZEFLJh46w369yZcX2tHy84u0V9DS+d2t icImSWlOrHSI9/NWoSIFCD3qp+7RHhwJ4WwanD/1ihiUWaaUwN/mU68SzaGdCk/DIxPA 083NRk+F55g54zsSjp5RR4YVX1tK/AVWyhCLjfE8O8flPGVvcO746CG59SdC2lTFKiCd xYjQ== X-Gm-Message-State: APjAAAWKykdySNXcaSvemiZW88Uc1COvFd6Gae+zDw+OtY52imHf6W9n V9CH7GfWdK7QgXP6QrDN3BtllE7ywcvilH9cbB8= X-Google-Smtp-Source: APXvYqxFp63EEpLIjZeyQXVokavoHetER7fJRxvCanLXIPD5/YiLMLZotEIGPkhg8TQW8Jd8aoPyjG43myxPYdqXFhU= X-Received: by 2002:a17:902:d70a:: with SMTP id w10mr24210786ply.251.1565467810574; Sat, 10 Aug 2019 13:10:10 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas <stefan@HIDDEN> Date: Sat, 10 Aug 2019 22:10:00 +0200 Message-ID: <CADwFkmnGAm81VhXpawf0EbuH5Go4OcYbVnfGH+zVB-eOURbOwA@HIDDEN> Subject: Re: bug#9622: 23.3; flet indentation To: diogofsr@HIDDEN Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 9622 Cc: 9622 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.5 (/) diogofsr@HIDDEN (Diogo F. S. Ramos) writes: > Currently, when using `flet', the functions are indented with respect of > the arglist. > > It would be nice if flet functions were indented like a `defun', for > example. > > Current behavior: > > (defun foo () > (flet ((long-function-name () > (misses-flet))) > (long-function-name))) > > Wanted behavior: > > (defun foo () > (flet ((long-function-name () > (hi-flet))) > (long-function-name))) I can confirm that this is still an issue on Emacs 26.2 and current master. Thanks, Stefan Kangas
bug-gnu-emacs@HIDDEN:bug#9622; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 28 Sep 2011 01:58:32 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Sep 27 21:58:31 2011
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1R8jPq-0001iI-Vc
for submit <at> debbugs.gnu.org; Tue, 27 Sep 2011 21:58:31 -0400
Received: from eggs.gnu.org ([140.186.70.92])
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <diogofsr@HIDDEN>) id 1R8jP8-0001gw-UP
for submit <at> debbugs.gnu.org; Tue, 27 Sep 2011 21:57:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from <diogofsr@HIDDEN>) id 1R8jOI-0003Uo-4T
for submit <at> debbugs.gnu.org; Tue, 27 Sep 2011 21:56:54 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org
X-Spam-Level:
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,
RCVD_IN_DNSWL_LOW, T_DKIM_INVALID,
T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1
Received: from lists.gnu.org ([140.186.70.17]:44941)
by eggs.gnu.org with esmtp (Exim 4.71)
(envelope-from <diogofsr@HIDDEN>) id 1R8jOI-0003Uk-2R
for submit <at> debbugs.gnu.org; Tue, 27 Sep 2011 21:56:54 -0400
Received: from eggs.gnu.org ([140.186.70.92]:37530)
by lists.gnu.org with esmtp (Exim 4.71)
(envelope-from <diogofsr@HIDDEN>) id 1R8jOH-0005SQ-8i
for bug-gnu-emacs@HIDDEN; Tue, 27 Sep 2011 21:56:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from <diogofsr@HIDDEN>) id 1R8jOG-0003UM-Av
for bug-gnu-emacs@HIDDEN; Tue, 27 Sep 2011 21:56:53 -0400
Received: from mail-yi0-f41.google.com ([209.85.218.41]:39085)
by eggs.gnu.org with esmtp (Exim 4.71)
(envelope-from <diogofsr@HIDDEN>) id 1R8jOG-0003UB-8S
for bug-gnu-emacs@HIDDEN; Tue, 27 Sep 2011 21:56:52 -0400
Received: by yia25 with SMTP id 25so7021600yia.0
for <bug-gnu-emacs@HIDDEN>; Tue, 27 Sep 2011 18:56:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
h=from:to:subject:date:message-id:mime-version:content-type;
bh=VEbUyn13IdgevpQm+G+14/vEA0FB8wbPAtwyR7Bj2dM=;
b=idY/2id3Hrm4+eqGsSPZfhgwRcZ/CpTrbjjyMZdYZmHLKmuajk1RlN2Ls6UYUPbtEM
RY1aa0v7ak4XESPmYMJppohQsszb+rVOuJHWOdfunpbGeAcnRqc4P13cTjDwsUfhESqH
FI/JI/jHBD8mCD94RYfY6NxbXvdIeXkp6/Rl4=
Received: by 10.146.95.6 with SMTP id s6mr7865554yab.2.1317175010916;
Tue, 27 Sep 2011 18:56:50 -0700 (PDT)
Received: from cometa (189-68-99-217.dsl.telesp.net.br. [189.68.99.217])
by mx.google.com with ESMTPS id u13sm84058734anf.14.2011.09.27.18.56.48
(version=TLSv1/SSLv3 cipher=OTHER);
Tue, 27 Sep 2011 18:56:49 -0700 (PDT)
Received: by cometa (Postfix, from userid 1000)
id 7F283121FED; Tue, 27 Sep 2011 22:56:45 -0300 (BRT)
From: diogofsr@HIDDEN (Diogo F. S. Ramos)
To: bug-gnu-emacs@HIDDEN
Subject: 23.3; flet indentation
Date: Tue, 27 Sep 2011 22:56:45 -0300
Message-ID: <87zkhph1k2.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)
X-Received-From: 140.186.70.17
X-Spam-Score: -5.9 (-----)
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Tue, 27 Sep 2011 21:58:29 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -5.9 (-----)
Currently, when using `flet', the functions are indented with respect of
the arglist.
It would be nice if flet functions were indented like a `defun', for
example.
Current behavior:
(defun foo ()
(flet ((long-function-name ()
(misses-flet)))
(long-function-name)))
Wanted behavior:
(defun foo ()
(flet ((long-function-name ()
(hi-flet)))
(long-function-name)))
--
Diogo F. S. Ramos
diogofsr@HIDDEN (Diogo F. S. Ramos):bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#9622; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.