GNU bug report logs - #70465
[PATCH] Add font-locking rule for Rust function signatures

Previous Next

Package: emacs;

Reported by: Noah Peart <noah.v.peart <at> gmail.com>

Date: Fri, 19 Apr 2024 02:03:04 UTC

Severity: normal

Tags: patch

Done: Yuan Fu <casouri <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 70465 in the body.
You can then email your comments to 70465 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#70465; Package emacs. (Fri, 19 Apr 2024 02:03:05 GMT) Full text and rfc822 format available.

Acknowledgement sent to Noah Peart <noah.v.peart <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 19 Apr 2024 02:03:05 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Noah Peart <noah.v.peart <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add font-locking rule for Rust function signatures
Date: Thu, 18 Apr 2024 19:01:57 -0700
[Message part 1 (text/plain, inline)]
Tags: patch


Adds a rule to font-lock Rust function signatures and missing function
modifier "default" to rust-ts-mode--keywords.

The new rule adds font-locking to signatures as in the following
example:

    trait Foo {
        fn foo() -> String;
//            ^ font-lock-function-name-face
    }


In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.33, cairo version 1.16.0) of 2024-04-18 built on noah-X580VD
Repository revision: 0a57dfcff8d0abcf4427cfbfd886264bb3b8eaab
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Ubuntu 22.04.4 LTS

Configured using:
 'configure --prefix=/usr/local --with-modules --with-tree-sitter
--with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls
--with-json --with-mailutils --with-jpeg --with-png --with-rsvg
--with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12
CXX=gcc-12'
[Message part 2 (text/html, inline)]
[0001-Add-font-locking-rule-for-Rust-function-signatures.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#70465; Package emacs. (Fri, 19 Apr 2024 07:26:02 GMT) Full text and rfc822 format available.

Message #8 received at 70465 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Noah Peart <noah.v.peart <at> gmail.com>
Cc: 70465 <at> debbugs.gnu.org
Subject: Re: bug#70465: [PATCH] Add font-locking rule for Rust function 
 signatures
Date: Fri, 19 Apr 2024 00:24:49 -0700
Noah Peart <noah.v.peart <at> gmail.com> writes:

> Tags: patch
>
> Adds a rule to font-lock Rust function signatures and missing function
> modifier "default" to rust-ts-mode--keywords.
>
> The new rule adds font-locking to signatures as in the following
> example:
>
>     trait Foo {
>         fn foo() -> String;
> //            ^ font-lock-function-name-face
>     }

Thanks!

Eli, for this kind of small fix patches, should it go to emacs-29 or
master? I don’t think it’ll affect the stability of emacs-29, but in the
same time it isn’t an urgent bug either.

Yuan




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#70465; Package emacs. (Fri, 19 Apr 2024 10:49:01 GMT) Full text and rfc822 format available.

Message #11 received at 70465 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Yuan Fu <casouri <at> gmail.com>
Cc: noah.v.peart <at> gmail.com, 70465 <at> debbugs.gnu.org
Subject: Re: bug#70465: [PATCH] Add font-locking rule for Rust function
 signatures
Date: Fri, 19 Apr 2024 13:47:47 +0300
> Cc: 70465 <at> debbugs.gnu.org
> From: Yuan Fu <casouri <at> gmail.com>
> Date: Fri, 19 Apr 2024 00:24:49 -0700
> 
> 
> Noah Peart <noah.v.peart <at> gmail.com> writes:
> 
> > Tags: patch
> >
> > Adds a rule to font-lock Rust function signatures and missing function
> > modifier "default" to rust-ts-mode--keywords.
> >
> > The new rule adds font-locking to signatures as in the following
> > example:
> >
> >     trait Foo {
> >         fn foo() -> String;
> > //            ^ font-lock-function-name-face
> >     }
> 
> Thanks!
> 
> Eli, for this kind of small fix patches, should it go to emacs-29 or
> master? I don’t think it’ll affect the stability of emacs-29, but in the
> same time it isn’t an urgent bug either.

Since this is an enhancement, not a bugfix, it should go to master.

Please be sure to add the bug number to the commit log message when
you install this.

Thanks.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#70465; Package emacs. (Fri, 19 Apr 2024 16:49:03 GMT) Full text and rfc822 format available.

Message #14 received at 70465 <at> debbugs.gnu.org (full text, mbox):

From: Noah Peart <noah.v.peart <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Yuan Fu <casouri <at> gmail.com>, 70465 <at> debbugs.gnu.org
Subject: Re: bug#70465: [PATCH] Add font-locking rule for Rust function
 signatures
Date: Fri, 19 Apr 2024 09:47:38 -0700
[Message part 1 (text/plain, inline)]
> Please be sure to add the bug number to the commit log message when
you install this.

When submitting a patch, is there an easy way to add the bug number to
the commit?

On Fri, Apr 19, 2024 at 3:47 AM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > Cc: 70465 <at> debbugs.gnu.org
> > From: Yuan Fu <casouri <at> gmail.com>
> > Date: Fri, 19 Apr 2024 00:24:49 -0700
> >
> >
> > Noah Peart <noah.v.peart <at> gmail.com> writes:
> >
> > > Tags: patch
> > >
> > > Adds a rule to font-lock Rust function signatures and missing function
> > > modifier "default" to rust-ts-mode--keywords.
> > >
> > > The new rule adds font-locking to signatures as in the following
> > > example:
> > >
> > >     trait Foo {
> > >         fn foo() -> String;
> > > //            ^ font-lock-function-name-face
> > >     }
> >
> > Thanks!
> >
> > Eli, for this kind of small fix patches, should it go to emacs-29 or
> > master? I don’t think it’ll affect the stability of emacs-29, but in the
> > same time it isn’t an urgent bug either.
>
> Since this is an enhancement, not a bugfix, it should go to master.
>
> Please be sure to add the bug number to the commit log message when
> you install this.
>
> Thanks.
>
[Message part 2 (text/html, inline)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#70465; Package emacs. (Fri, 19 Apr 2024 17:36:01 GMT) Full text and rfc822 format available.

Message #17 received at 70465 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Noah Peart <noah.v.peart <at> gmail.com>
Cc: casouri <at> gmail.com, 70465 <at> debbugs.gnu.org
Subject: Re: bug#70465: [PATCH] Add font-locking rule for Rust function
 signatures
Date: Fri, 19 Apr 2024 20:35:19 +0300
> From: Noah Peart <noah.v.peart <at> gmail.com>
> Date: Fri, 19 Apr 2024 09:47:38 -0700
> Cc: Yuan Fu <casouri <at> gmail.com>, 70465 <at> debbugs.gnu.org
> 
> > Please be sure to add the bug number to the commit log message when
> you install this.
> 
> When submitting a patch, is there an easy way to add the bug number to
> the commit?

Only after you get the bug report back from the bug tracker.  When you
send the first message which creates a new bug report, you cannot know
it.  So we only ask people to add the bug number if they submit a
revised patch, because at that point the number is already known.
When an original patch is installed, the person who pushes it must do
a "git commit --amend" to edit the commit log message to add the bug
number.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#70465; Package emacs. (Fri, 19 Apr 2024 17:45:01 GMT) Full text and rfc822 format available.

Message #20 received at 70465 <at> debbugs.gnu.org (full text, mbox):

From: Noah Peart <noah.v.peart <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: casouri <at> gmail.com, 70465 <at> debbugs.gnu.org
Subject: Re: bug#70465: [PATCH] Add font-locking rule for Rust function
 signatures
Date: Fri, 19 Apr 2024 10:43:48 -0700
[Message part 1 (text/plain, inline)]
Got it, thanks!

On Fri, Apr 19, 2024 at 10:35 AM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: Noah Peart <noah.v.peart <at> gmail.com>
> > Date: Fri, 19 Apr 2024 09:47:38 -0700
> > Cc: Yuan Fu <casouri <at> gmail.com>, 70465 <at> debbugs.gnu.org
> >
> > > Please be sure to add the bug number to the commit log message when
> > you install this.
> >
> > When submitting a patch, is there an easy way to add the bug number to
> > the commit?
>
> Only after you get the bug report back from the bug tracker.  When you
> send the first message which creates a new bug report, you cannot know
> it.  So we only ask people to add the bug number if they submit a
> revised patch, because at that point the number is already known.
> When an original patch is installed, the person who pushes it must do
> a "git commit --amend" to edit the commit log message to add the bug
> number.
>
[Message part 2 (text/html, inline)]

Reply sent to Yuan Fu <casouri <at> gmail.com>:
You have taken responsibility. (Mon, 22 Apr 2024 00:05:02 GMT) Full text and rfc822 format available.

Notification sent to Noah Peart <noah.v.peart <at> gmail.com>:
bug acknowledged by developer. (Mon, 22 Apr 2024 00:05:02 GMT) Full text and rfc822 format available.

Message #25 received at 70465-done <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Noah Peart <noah.v.peart <at> gmail.com>
Cc: 70465-done <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#70465: [PATCH] Add font-locking rule for Rust function
 signatures
Date: Sun, 21 Apr 2024 17:03:59 -0700

> On Apr 19, 2024, at 10:43 AM, Noah Peart <noah.v.peart <at> gmail.com> wrote:
> 
> Got it, thanks!
> 
> On Fri, Apr 19, 2024 at 10:35 AM Eli Zaretskii <eliz <at> gnu.org> wrote:
> > From: Noah Peart <noah.v.peart <at> gmail.com>
> > Date: Fri, 19 Apr 2024 09:47:38 -0700
> > Cc: Yuan Fu <casouri <at> gmail.com>, 70465 <at> debbugs.gnu.org
> > 
> > > Please be sure to add the bug number to the commit log message when
> > you install this.
> > 
> > When submitting a patch, is there an easy way to add the bug number to
> > the commit?
> 
> Only after you get the bug report back from the bug tracker.  When you
> send the first message which creates a new bug report, you cannot know
> it.  So we only ask people to add the bug number if they submit a
> revised patch, because at that point the number is already known.
> When an original patch is installed, the person who pushes it must do
> a "git commit --amend" to edit the commit log message to add the bug
> number.

And merged.

Yuan



bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 20 May 2024 11:24:09 GMT) Full text and rfc822 format available.

This bug report was last modified 12 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.