GNU bug report logs -
#70665
[PATCH] Add font-locking for typed parameters in python-ts-mode
Previous Next
Reported by: Noah Peart <noah.v.peart <at> gmail.com>
Date: Tue, 30 Apr 2024 10:10:01 UTC
Severity: normal
Tags: patch
Done: Yuan Fu <casouri <at> gmail.com>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 70665 in the body.
You can then email your comments to 70665 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#70665
; Package
emacs
.
(Tue, 30 Apr 2024 10:10:01 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Noah Peart <noah.v.peart <at> gmail.com>
:
New bug report received and forwarded. Copy sent to
bug-gnu-emacs <at> gnu.org
.
(Tue, 30 Apr 2024 10:10:01 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Tags: patch
This patch adds a rule to python--treesit-settings to apply
font-lock-variable-name-face to typed parameters in python-ts-mode.
Currently, function parameters with type annotations are missing
font-lock-variable-name-face.
For example, this patch adds font-locking in the following case:
def foo(val: str) -> str
# ^ font-lock-variable-name-face
In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.33, cairo version 1.16.0) of 2024-04-29 built on noah-X580VD
Repository revision: 3000edc6179dfe0b5f24ae2e472826530809dfd1
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Ubuntu 22.04.4 LTS
Configured using:
'configure --prefix=/usr/local --with-modules --with-tree-sitter
--with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls
--with-json --with-mailutils --with-jpeg --with-png --with-rsvg
--with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12
CXX=gcc-12'
[Message part 2 (text/html, inline)]
[0001-Add-font-locking-for-typed-parameters-in-python-ts-m.patch (text/x-patch, attachment)]
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#70665
; Package
emacs
.
(Tue, 30 Apr 2024 10:29:01 GMT)
Full text and
rfc822 format available.
Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Sorry, previous patch added an extra file by accident.
Fixed patch attached.
On Tue, Apr 30, 2024 at 3:09 AM Noah Peart <noah.v.peart <at> gmail.com> wrote:
> Tags: patch
>
> This patch adds a rule to python--treesit-settings to apply
> font-lock-variable-name-face to typed parameters in python-ts-mode.
> Currently, function parameters with type annotations are missing
> font-lock-variable-name-face.
>
> For example, this patch adds font-locking in the following case:
>
> def foo(val: str) -> str
> # ^ font-lock-variable-name-face
>
>
> In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
> 3.24.33, cairo version 1.16.0) of 2024-04-29 built on noah-X580VD
> Repository revision: 3000edc6179dfe0b5f24ae2e472826530809dfd1
> Repository branch: master
> Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
> System Description: Ubuntu 22.04.4 LTS
>
> Configured using:
> 'configure --prefix=/usr/local --with-modules --with-tree-sitter
> --with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls
> --with-json --with-mailutils --with-jpeg --with-png --with-rsvg
> --with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12
> CXX=gcc-12'
>
[Message part 2 (text/html, inline)]
[0001-Add-font-locking-for-typed-parameters-in-python-ts-m.patch (text/x-patch, attachment)]
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#70665
; Package
emacs
.
(Wed, 01 May 2024 15:05:02 GMT)
Full text and
rfc822 format available.
Message #11 received at 70665 <at> debbugs.gnu.org (full text, mbox):
> On Apr 30, 2024, at 3:27 AM, Noah Peart <noah.v.peart <at> gmail.com> wrote:
>
> Sorry, previous patch added an extra file by accident.
>
> Fixed patch attached.
>
>
> On Tue, Apr 30, 2024 at 3:09 AM Noah Peart <noah.v.peart <at> gmail.com> wrote:
> Tags: patch
>
> This patch adds a rule to python--treesit-settings to apply
> font-lock-variable-name-face to typed parameters in python-ts-mode.
> Currently, function parameters with type annotations are missing
> font-lock-variable-name-face.
>
> For example, this patch adds font-locking in the following case:
>
> def foo(val: str) -> str
> # ^ font-lock-variable-name-face
Thank you!! Had some issue with my Emacs build last night. I’ll try to get it merged tonight.
Yuan
Reply sent
to
Yuan Fu <casouri <at> gmail.com>
:
You have taken responsibility.
(Thu, 02 May 2024 04:29:02 GMT)
Full text and
rfc822 format available.
Notification sent
to
Noah Peart <noah.v.peart <at> gmail.com>
:
bug acknowledged by developer.
(Thu, 02 May 2024 04:29:02 GMT)
Full text and
rfc822 format available.
Message #16 received at 70665-done <at> debbugs.gnu.org (full text, mbox):
> On May 1, 2024, at 8:04 AM, Yuan Fu <casouri <at> gmail.com> wrote:
>
>
>
>> On Apr 30, 2024, at 3:27 AM, Noah Peart <noah.v.peart <at> gmail.com> wrote:
>>
>> Sorry, previous patch added an extra file by accident.
>>
>> Fixed patch attached.
>>
>>
>> On Tue, Apr 30, 2024 at 3:09 AM Noah Peart <noah.v.peart <at> gmail.com> wrote:
>> Tags: patch
>>
>> This patch adds a rule to python--treesit-settings to apply
>> font-lock-variable-name-face to typed parameters in python-ts-mode.
>> Currently, function parameters with type annotations are missing
>> font-lock-variable-name-face.
>>
>> For example, this patch adds font-locking in the following case:
>>
>> def foo(val: str) -> str
>> # ^ font-lock-variable-name-face
>
> Thank you!! Had some issue with my Emacs build last night. I’ll try to get it merged tonight.
>
> Yuan
Merged, thanks again!
Yuan
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Thu, 30 May 2024 11:24:08 GMT)
Full text and
rfc822 format available.
This bug report was last modified 2 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.