GNU bug report logs - #70936
[PATCH gnome-team 0/3] Fix some broken tests.

Previous Next

To reply to this bug, email your comments to 70936 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH gnome-team 0/3] Fix some broken tests.
Date: Tue, 14 May 2024 14:15:22 +0200

QA seems to dislike at least some major packages with our recent changes.
It's quite possible that some of them are flaky tests.

Liliana Marie Prikler (3):
  gnu: gst-plugins-bad: Ignore elements_netsim test.
  gnu: qtbase: Ignore tst_qsqlthread.
  gnu: qemu: Disable more tests.

 gnu/packages/gstreamer.scm      | 4 ++++
 gnu/packages/qt.scm             | 3 +++
 gnu/packages/virtualization.scm | 7 ++++++-
 3 files changed, 13 insertions(+), 1 deletion(-)


base-commit: 9185efbc6cdaf8f7d83bf8fc90f44e25131b9f88
-- 
2.41.0

Message #8 received at 70936 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: 70936 <at> debbugs.gnu.org
Subject: [PATCH gnome-team 1/3] gnu: gst-plugins-bad: Ignore
 elements_netsim test.
Date: Tue, 14 May 2024 09:27:30 +0200

* gnu/packages/gstreamer.scm (gst-plugins-bad)[adjust-tests]: Add
“elements/netsim.c” to the list of ignored test files.
---
 gnu/packages/gstreamer.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
index 2705e245ea..ad08285181 100644
--- a/gnu/packages/gstreamer.scm
+++ b/gnu/packages/gstreamer.scm
@@ -796,6 +796,10 @@ (define-public gst-plugins-bad
                   ;; The 'elements_curlhttpsrc' test sometimes times out.
                   ((".*'elements/curlhttpsrc\\.c'.*") "")
 
+                  ;; Unexpected critical/warning, see
+                  ;; <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/3000>
+                  ((".*'elements/netsim\\.c'.*") "")
+
                   ;; TODO: Figure out why this test fails on riscv64-linux.
                   #$@(if (target-riscv64?)
                          `((("'elements/viewfinderbin\\.c'\\].*],")
-- 
2.41.0

Message #11 received at 70936 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: 70936 <at> debbugs.gnu.org
Subject: [PATCH gnome-team 2/3] gnu: qtbase: Ignore tst_qsqlthread.
Date: Tue, 14 May 2024 09:39:03 +0200

* gnu/packages/qt.scm (qtbase)[check]: Add “tst_qsqlthread” to the list of
ignored tests.
---
 gnu/packages/qt.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
index 13f54fcc5d..1416c3a36c 100644
--- a/gnu/packages/qt.scm
+++ b/gnu/packages/qt.scm
@@ -899,6 +899,9 @@ (define-public qtbase
                        ;; TODO: when core-updates is merged, check again.
                        "tst_selftests"
 
+                       ;; The 'tst_qsqlthread' test sometimes fails.
+                       "tst_qsqlthread"
+
                        ;; The 'tst_qsystemsemaphore' test sometimes fails.
                        "tst_qsystemsemaphore"
                        ;; The 'tst_moc' test fails with "'fi.exists()' returned FALSE".
-- 
2.41.0

Message #14 received at 70936 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: 70936 <at> debbugs.gnu.org
Subject: [PATCH gnome-team 3/3] gnu: qemu: Disable more tests.
Date: Tue, 14 May 2024 14:10:41 +0200

* gnu/packages/virtualization.scm (qemu)[disable-unusable-tests]: Also disable
qtest/ahci-test and qemu-iotests/copy-before-write.
---
 gnu/packages/virtualization.scm | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
index 34cccd6550..5389af62f0 100644
--- a/gnu/packages/virtualization.scm
+++ b/gnu/packages/virtualization.scm
@@ -305,7 +305,12 @@ (define-public qemu
               (substitute* "tests/qtest/meson.build"
                 ;; These tests fail to get the expected number of tests
                 ;; on arm platforms.
-                (("'arm-cpu-features',") ""))))
+                (("'arm-cpu-features',") "")
+                ;; XXX: Why does this (sometimes) fail?
+                (("\\['ahci-test'\\]") "[]"))
+              ;; This test appears to be missing permissions.
+              ;; Very sus 🤔
+              (delete-file "tests/qemu-iotests/tests/copy-before-write")))
           #$@(if (target-riscv64?)
                  '((add-after 'unpack 'disable-some-tests
                      (lambda _
-- 
2.41.0

Message #17 received at 70936 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 70936 <at> debbugs.gnu.org, vivien <at> planete-kraus.eu
Subject: Re: [bug#70936] [PATCH gnome-team 1/3] gnu: gst-plugins-bad: Ignore
 elements_netsim test.
Date: Tue, 14 May 2024 21:29:56 -0400

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> * gnu/packages/gstreamer.scm (gst-plugins-bad)[adjust-tests]: Add
> “elements/netsim.c” to the list of ignored test files.

Reviewed-by: Maxim Cournoyer <maxim.cournoyer <at> gmail>

-- 
Thanks,
Maxim

Message #20 received at 70936 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 70936 <at> debbugs.gnu.org, vivien <at> planete-kraus.eu
Subject: Re: [bug#70936] [PATCH gnome-team 2/3] gnu: qtbase: Ignore
 tst_qsqlthread.
Date: Tue, 14 May 2024 21:33:45 -0400

Hi Liliana,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> * gnu/packages/qt.scm (qtbase)[check]: Add “tst_qsqlthread” to the list of
> ignored tests.
> ---
>  gnu/packages/qt.scm | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
> index 13f54fcc5d..1416c3a36c 100644
> --- a/gnu/packages/qt.scm
> +++ b/gnu/packages/qt.scm
> @@ -899,6 +899,9 @@ (define-public qtbase
>                         ;; TODO: when core-updates is merged, check again.
>                         "tst_selftests"
>  
> +                       ;; The 'tst_qsqlthread' test sometimes fails.
> +                       "tst_qsqlthread"
> +

This was reported by myself [0] and is currently skipped only for
target-ppc64le?.  We should probably skip it for every architecture if
you've encountered it on x86_64 (I'm assuming).

-- 
Thanks,
Maxim

Message #23 received at 70936 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 70936 <at> debbugs.gnu.org, vivien <at> planete-kraus.eu
Subject: Re: [bug#70936] [PATCH gnome-team 2/3] gnu: qtbase: Ignore
 tst_qsqlthread.
Date: Tue, 14 May 2024 21:34:21 -0400

Hi Liliana,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> * gnu/packages/qt.scm (qtbase)[check]: Add “tst_qsqlthread” to the list of
> ignored tests.
> ---
>  gnu/packages/qt.scm | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
> index 13f54fcc5d..1416c3a36c 100644
> --- a/gnu/packages/qt.scm
> +++ b/gnu/packages/qt.scm
> @@ -899,6 +899,9 @@ (define-public qtbase
>                         ;; TODO: when core-updates is merged, check again.
>                         "tst_selftests"
>  
> +                       ;; The 'tst_qsqlthread' test sometimes fails.
> +                       "tst_qsqlthread"
> +

This was reported by myself [0] and is currently skipped only for
target-ppc64le?.  We should probably skip it for every architecture if
you've encountered it on x86_64 (I'm assuming).

[0]  https://bugreports.qt.io/browse/QTBUG-117114?jql=text%20~%20%22tst_qsqlthread%22

Could you adjust and send a v2?

-- 
Thanks,
Maxim

Message #26 received at 70936 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 70936 <at> debbugs.gnu.org, vivien <at> planete-kraus.eu
Subject: Re: [bug#70936] [PATCH gnome-team 3/3] gnu: qemu: Disable more tests.
Date: Tue, 14 May 2024 21:40:40 -0400

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> * gnu/packages/virtualization.scm (qemu)[disable-unusable-tests]: Also disable
> qtest/ahci-test and qemu-iotests/copy-before-write.
> ---
>  gnu/packages/virtualization.scm | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
> index 34cccd6550..5389af62f0 100644
> --- a/gnu/packages/virtualization.scm
> +++ b/gnu/packages/virtualization.scm
> @@ -305,7 +305,12 @@ (define-public qemu
>                (substitute* "tests/qtest/meson.build"
>                  ;; These tests fail to get the expected number of tests
>                  ;; on arm platforms.
> -                (("'arm-cpu-features',") ""))))
> +                (("'arm-cpu-features',") "")
> +                ;; XXX: Why does this (sometimes) fail?

Someone reported it already upstream:
<https://gitlab.com/qemu-project/qemu/-/issues/2121>.  Please add a
reference to it.

> +                (("\\['ahci-test'\\]") "[]"))
> +              ;; This test appears to be missing permissions.
> +              ;; Very sus 🤔

How can it be missing permissions if it is sometimes working?  Perhaps
more something racy where the file hasn't been created yet.  I'd
personally rather not see emojis or comments of dubious utility ("Very
suspect") in the source.  Perhaps add a short excerpt of the error for
the next curious person.

> +              (delete-file "tests/qemu-iotests/tests/copy-before-write")))
>            #$@(if (target-riscv64?)
>                   '((add-after 'unpack 'disable-some-tests
>                       (lambda _

Otherwise, LGTM!

-- 
Thanks,
Maxim

Message #29 received at 70936 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 70936 <at> debbugs.gnu.org, vivien <at> planete-kraus.eu
Subject: Re: [bug#70936] [PATCH gnome-team 3/3] gnu: qemu: Disable more tests.
Date: Tue, 14 May 2024 21:41:38 -0400

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> * gnu/packages/virtualization.scm (qemu)[disable-unusable-tests]: Also disable
> qtest/ahci-test and qemu-iotests/copy-before-write.
> ---
>  gnu/packages/virtualization.scm | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
> index 34cccd6550..5389af62f0 100644
> --- a/gnu/packages/virtualization.scm
> +++ b/gnu/packages/virtualization.scm
> @@ -305,7 +305,12 @@ (define-public qemu
>                (substitute* "tests/qtest/meson.build"
>                  ;; These tests fail to get the expected number of tests
>                  ;; on arm platforms.
> -                (("'arm-cpu-features',") ""))))
> +                (("'arm-cpu-features',") "")
> +                ;; XXX: Why does this (sometimes) fail?

Someone reported it already upstream:
<https://gitlab.com/qemu-project/qemu/-/issues/2121>.  Please add a
reference to it.

> +                (("\\['ahci-test'\\]") "[]"))
> +              ;; This test appears to be missing permissions.
> +              ;; Very sus 🤔

How can it be missing permissions if it is sometimes working?  Perhaps
more something racy where the file hasn't been created yet.  I'd
personally rather not see emojis or comments of dubious utility ("Very
suspect") in the source.  Perhaps add a short excerpt of the error for
the next curious person.

> +              (delete-file "tests/qemu-iotests/tests/copy-before-write")))
>            #$@(if (target-riscv64?)
>                   '((add-after 'unpack 'disable-some-tests
>                       (lambda _

Otherwise, LGTM, with the added reference to the upstream issue.  Thanks
for taking the time to address flaky tests!  They are a real drag when
left unchecked.

-- 
Thanks,
Maxim

Message #32 received at 70936 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 70936 <at> debbugs.gnu.org, vivien <at> planete-kraus.eu
Subject: Re: [bug#70936] [PATCH gnome-team 2/3] gnu: qtbase: Ignore
 tst_qsqlthread.
Date: Thu, 16 May 2024 07:13:36 +0200

Am Dienstag, dem 14.05.2024 um 21:34 -0400 schrieb Maxim Cournoyer:
> Hi Liliana,
> 
> Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:
> 
> > * gnu/packages/qt.scm (qtbase)[check]: Add “tst_qsqlthread” to the
> > list of
> > ignored tests.
> > ---
> >  gnu/packages/qt.scm | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
> > index 13f54fcc5d..1416c3a36c 100644
> > --- a/gnu/packages/qt.scm
> > +++ b/gnu/packages/qt.scm
> > @@ -899,6 +899,9 @@ (define-public qtbase
> >                         ;; TODO: when core-updates is merged, check
> > again.
> >                         "tst_selftests"
> >  
> > +                       ;; The 'tst_qsqlthread' test sometimes
> > fails.
> > +                       "tst_qsqlthread"
> > +
> 
> This was reported by myself [0] and is currently skipped only for
> target-ppc64le?.  We should probably skip it for every architecture
> if you've encountered it on x86_64 (I'm assuming).
> 
> [0] 
> https://bugreports.qt.io/browse/QTBUG-117114?jql=text%20~%20%22tst_qsqlthread%22
Should I rebase gnome-team on master again, so that I can drop the
condition?

Cheers

Message #35 received at 70936 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 70936 <at> debbugs.gnu.org, vivien <at> planete-kraus.eu
Subject: Re: [bug#70936] [PATCH gnome-team 2/3] gnu: qtbase: Ignore
 tst_qsqlthread.
Date: Thu, 16 May 2024 08:44:59 -0400

Hi Liliana,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> Am Dienstag, dem 14.05.2024 um 21:34 -0400 schrieb Maxim Cournoyer:
>> Hi Liliana,
>> 
>> Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:
>> 
>> > * gnu/packages/qt.scm (qtbase)[check]: Add “tst_qsqlthread” to the
>> > list of
>> > ignored tests.
>> > ---
>> >  gnu/packages/qt.scm | 3 +++
>> >  1 file changed, 3 insertions(+)
>> > 
>> > diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
>> > index 13f54fcc5d..1416c3a36c 100644
>> > --- a/gnu/packages/qt.scm
>> > +++ b/gnu/packages/qt.scm
>> > @@ -899,6 +899,9 @@ (define-public qtbase
>> >                         ;; TODO: when core-updates is merged, check
>> > again.
>> >                         "tst_selftests"
>> >  
>> > +                       ;; The 'tst_qsqlthread' test sometimes
>> > fails.
>> > +                       "tst_qsqlthread"
>> > +
>> 
>> This was reported by myself [0] and is currently skipped only for
>> target-ppc64le?.  We should probably skip it for every architecture
>> if you've encountered it on x86_64 (I'm assuming).
>> 
>> [0] 
>> https://bugreports.qt.io/browse/QTBUG-117114?jql=text%20~%20%22tst_qsqlthread%22
> Should I rebase gnome-team on master again, so that I can drop the
> condition?

Sounds reasonable, if you didn't have that conditional skip on
gnome-team already.

-- 
Thanks,
Maxim

Message #38 received at 70936 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 70936 <at> debbugs.gnu.org, vivien <at> planete-kraus.eu
Subject: Re: [bug#70936] [PATCH gnome-team 2/3] gnu: qtbase: Ignore
 tst_qsqlthread.
Date: Thu, 16 May 2024 15:15:05 +0200

Am Donnerstag, dem 16.05.2024 um 08:44 -0400 schrieb Maxim Cournoyer:
> Hi Liliana,
> 
> Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:
> 
> > Am Dienstag, dem 14.05.2024 um 21:34 -0400 schrieb Maxim Cournoyer:
> > > Hi Liliana,
> > > 
> > > Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:
> > > 
> > > > * gnu/packages/qt.scm (qtbase)[check]: Add “tst_qsqlthread” to
> > > > the
> > > > list of
> > > > ignored tests.
> > > > ---
> > > >  gnu/packages/qt.scm | 3 +++
> > > >  1 file changed, 3 insertions(+)
> > > > 
> > > > diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
> > > > index 13f54fcc5d..1416c3a36c 100644
> > > > --- a/gnu/packages/qt.scm
> > > > +++ b/gnu/packages/qt.scm
> > > > @@ -899,6 +899,9 @@ (define-public qtbase
> > > >                         ;; TODO: when core-updates is merged,
> > > > check
> > > > again.
> > > >                         "tst_selftests"
> > > >  
> > > > +                       ;; The 'tst_qsqlthread' test sometimes
> > > > fails.
> > > > +                       "tst_qsqlthread"
> > > > +
> > > 
> > > This was reported by myself [0] and is currently skipped only for
> > > target-ppc64le?.  We should probably skip it for every
> > > architecture
> > > if you've encountered it on x86_64 (I'm assuming).
> > > 
> > > [0] 
> > > https://bugreports.qt.io/browse/QTBUG-117114?jql=text%20~%20%22tst_qsqlthread%22
> > Should I rebase gnome-team on master again, so that I can drop the
> > condition?
> 
> Sounds reasonable, if you didn't have that conditional skip on
> gnome-team already.
I don't see it even after the rebase… is that on master yet or
elsewhere?

Anyhow, I think I forgot to link the bug report appropriately before
pushing, will do so when CI lights green.

Cheers

Message #41 received at 70936 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 70936 <at> debbugs.gnu.org, vivien <at> planete-kraus.eu
Subject: Re: [bug#70936] [PATCH gnome-team 2/3] gnu: qtbase: Ignore
 tst_qsqlthread.
Date: Thu, 16 May 2024 12:06:40 -0400

Hi Liliana,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> Am Donnerstag, dem 16.05.2024 um 08:44 -0400 schrieb Maxim Cournoyer:
>> Hi Liliana,
>> 
>> Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:
>> 
>> > Am Dienstag, dem 14.05.2024 um 21:34 -0400 schrieb Maxim Cournoyer:
>> > > Hi Liliana,
>> > > 
>> > > Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:
>> > > 
>> > > > * gnu/packages/qt.scm (qtbase)[check]: Add “tst_qsqlthread” to
>> > > > the
>> > > > list of
>> > > > ignored tests.
>> > > > ---
>> > > >  gnu/packages/qt.scm | 3 +++
>> > > >  1 file changed, 3 insertions(+)
>> > > > 
>> > > > diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
>> > > > index 13f54fcc5d..1416c3a36c 100644
>> > > > --- a/gnu/packages/qt.scm
>> > > > +++ b/gnu/packages/qt.scm
>> > > > @@ -899,6 +899,9 @@ (define-public qtbase
>> > > >                         ;; TODO: when core-updates is merged,
>> > > > check
>> > > > again.
>> > > >                         "tst_selftests"
>> > > >  
>> > > > +                       ;; The 'tst_qsqlthread' test sometimes
>> > > > fails.
>> > > > +                       "tst_qsqlthread"
>> > > > +
>> > > 
>> > > This was reported by myself [0] and is currently skipped only for
>> > > target-ppc64le?.  We should probably skip it for every
>> > > architecture
>> > > if you've encountered it on x86_64 (I'm assuming).
>> > > 
>> > > [0] 
>> > > https://bugreports.qt.io/browse/QTBUG-117114?jql=text%20~%20%22tst_qsqlthread%22
>> > Should I rebase gnome-team on master again, so that I can drop the
>> > condition?
>> 
>> Sounds reasonable, if you didn't have that conditional skip on
>> gnome-team already.
> I don't see it even after the rebase… is that on master yet or
> elsewhere?
>
> Anyhow, I think I forgot to link the bug report appropriately before
> pushing, will do so when CI lights green.

It's from commit 625fa5745e3, dated 26th of March 2024.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.