GNU bug report logs - #16841
Bug#738716: automake: Generates syntax error in configure script

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 16841 in the body.
You can then email your comments to 16841 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eric Dorland <eric <at> debian.org>
To: bug-automake <at> gnu.org
Cc: 738716-forwarded <at> bugs.debian.org, Hilko Bengen <bengen <at> debian.org>
Subject: Re: Bug#738716: automake: Generates syntax error in configure script
Date: Sat, 22 Feb 2014 02:40:41 -0500

[Message part 1 (text/plain, inline)]

* Hilko Bengen (bengen <at> debian.org) wrote:
> Source: automake-1.14
> Version: 1:1.14.1-2
> Severity: critical
> Tags: patch
> 
> While trying to build a new version of nbdkit, I fonud that a freshly
> generated configure script contains a syntax error:
> 
> ,----
> | $ curl -O http://libguestfs.org/download/nbdkit/nbdkit-1.1.4.tar.gz
> | [...]
> | $ tar xzf nbdkit-1.1.4.tar.gz 
> | $ cd nbdkit-1.1.4/
> | $ autoreconf
> | $ ./configure
> | [...]
> | checking for style of include used by make... GNU
> | checking whether make supports nested variables... yes
> | checking dependency style of gcc... gcc3
> | ./configure: line 4820: syntax error near unexpected token `case'
> | ./configure: line 4820: `fi case `pwd` in'
> `----
> 
> To me, this looks like a missing newline at the end of AM_INIT_AUTOMAKE
> in /usr/share/aclocal-1.14/init.m4. At least the attached patch fixes
> the problem for me.

It looks like the problem is the dnl on your AM_INIT_AUTOMAKE line: 

AM_INIT_AUTOMAKE(foreign) dnl NB: Do not [quote] this parameter.

That's suppressing the natural new line that would be there. But I
think the patch is legitimate so forwarding it along.

> --- /usr/share/aclocal-1.14/init.m4.orig        2014-02-12 09:45:22.883382346 +0100
> +++ /usr/share/aclocal-1.14/init.m4     2014-02-12 09:45:40.758921507 +0100
> @@ -164,7 +164,8 @@
>  END
>      AC_MSG_ERROR([Your 'rm' program is bad, sorry.])
>    fi
> -fi])
> +fi
> +])
>  
>  dnl Hook into '_AC_COMPILER_EXEEXT' early to learn its expansion.  Do not
>  dnl add the conditional right here, as _AC_COMPILER_EXEEXT may be further


-- 
Eric Dorland <eric <at> kuroneko.ca>
ICQ: #61138586, Jabber: hooty <at> jabber.com

[signature.asc (application/pgp-signature, inline)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: bug-automake <at> gnu.org, Hilko Bengen <bengen <at> debian.org>, 
 738716-forwarded <at> bugs.debian.org
Cc: Eric Dorland <eric <at> debian.org>,
 "automake-patches <at> gnu.org" <automake-patches <at> gnu.org>
Subject: Re: bug#16841: Bug#738716: automake: Generates syntax error in
 configure script
Date: Fri, 19 Dec 2014 12:24:57 +0100

[Message part 1 (text/plain, inline)]

tags 16841 + patch
close 16841
thanks

On 02/22/2014 08:40 AM, Eric Dorland wrote:
> * Hilko Bengen (bengen <at> debian.org) wrote:
>> Source: automake-1.14
>> Version: 1:1.14.1-2
>> Severity: critical
>> Tags: patch
>>
>> While trying to build a new version of nbdkit, I fonud that a freshly
>> generated configure script contains a syntax error:
>>
>> ,----
>> | $ curl -O http://libguestfs.org/download/nbdkit/nbdkit-1.1.4.tar.gz
>> | [...]
>> | $ tar xzf nbdkit-1.1.4.tar.gz
>> | $ cd nbdkit-1.1.4/
>> | $ autoreconf
>> | $ ./configure
>> | [...]
>> | checking for style of include used by make... GNU
>> | checking whether make supports nested variables... yes
>> | checking dependency style of gcc... gcc3
>> | ./configure: line 4820: syntax error near unexpected token `case'
>> | ./configure: line 4820: `fi case `pwd` in'
>> `----
>>
>> To me, this looks like a missing newline at the end of AM_INIT_AUTOMAKE
>> in /usr/share/aclocal-1.14/init.m4. At least the attached patch fixes
>> the problem for me.
>
> It looks like the problem is the dnl on your AM_INIT_AUTOMAKE line:
>
> AM_INIT_AUTOMAKE(foreign) dnl NB: Do not [quote] this parameter.
>
> That's suppressing the natural new line that would be there. But I
> think the patch is legitimate so forwarding it along.
>
>> --- /usr/share/aclocal-1.14/init.m4.orig        2014-02-12 09:45:22.883382346 +0100
>> +++ /usr/share/aclocal-1.14/init.m4     2014-02-12 09:45:40.758921507 +0100
>> @@ -164,7 +164,8 @@
>>   END
>>       AC_MSG_ERROR([Your 'rm' program is bad, sorry.])
>>     fi
>> -fi])
>> +fi
>> +])
>>
>>   dnl Hook into '_AC_COMPILER_EXEEXT' early to learn its expansion.  Do not
>>   dnl add the conditional right here, as _AC_COMPILER_EXEEXT may be further
>
>
Agreed, we shouldn't have broken backward-compatibility for no good reason
(and IIRC the removal of the trailing newline wasn't deliberated).  Fixed
with the attached patch.

Thanks,
  Stefano

[0001-AM_INIT_AUTOMAKE-make-sure-has-a-trailing-newline-af.patch (text/x-patch, attachment)]

Message #15 received at 16841 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Scott Pakin <pakin <at> lanl.gov>, 18075 <at> debbugs.gnu.org, 
 16841 <at> debbugs.gnu.org, 
 GNU bug tracker automated control server <control <at> debbugs.gnu.org>
Subject: Re: bug#18075: AM_INIT_AUTOMAKE followed by comment
Date: Fri, 19 Dec 2014 12:31:47 +0100

forcemerge 16841 18075
stop

Reference: http://debbugs.gnu.org/18075

Hi Scott. Thanks for the report, and sorry for the awful delay.

I've already solved this issue as part of http://debbugs.gnu.org/16841
The fix will appear in the next Automake version (hopefully to be
released before the end of December).

Regards,
  Stefano

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.