GNU logs - #70459, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#70459: Flymake small improvements
Resent-From: Juri Linkov <juri@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 18 Apr 2024 17:36:02 +0000
Resent-Message-ID: <handler.70459.B.171346173923100 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 70459 <at> debbugs.gnu.org
From: Juri Linkov <juri@HIDDEN>
Organization: LINKOV.NET
Date: Thu, 18 Apr 2024 20:23:09 +0300
Message-ID: <86ttjyr3jq.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=2001:4b98:dc4:8::223;
 envelope-from=juri@HIDDEN; helo=relay3-d.mail.gandi.net
X-Spam_score_int: -25
X-Spam_score: -2.6
X-Spam_bar: --
X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

--=-=-=
Content-Type: text/plain

Tags: patch

1. clicking on flymake fringe indicator will show buffer diagnostics;
2. display diagnostics buffers at the bottom;
3. to do the above there is a need to swap the order
   of generating the buffer contents and displaying the buffer,
   i.e. the same as was done recently in info.el for bug#70213.


--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline; filename=flymake.patch

diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
index 22a139d3045..f5bf68db574 100644
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -1331,7 +1331,10 @@ flymake-start
                   nil))))))))
 
 (defvar flymake-mode-map
-  (let ((map (make-sparse-keymap))) map)
+  (let ((map (make-sparse-keymap)))
+    (define-key map `[,flymake-fringe-indicator-position mouse-1]
+                #'flymake-show-buffer-diagnostics)
+    map)
   "Keymap for `flymake-mode'.")
 
 ;;;###autoload
@@ -1972,8 +1975,12 @@ flymake-show-buffer-diagnostics
                        (current-buffer)))))
     (with-current-buffer target
       (setq flymake--diagnostics-buffer-source source)
-      (display-buffer (current-buffer))
-      (revert-buffer))))
+      (revert-buffer)
+      (display-buffer (current-buffer)
+                      `((display-buffer-reuse-window
+                         display-buffer-below-selected)
+                        (window-height . (lambda (window)
+                          (fit-window-to-buffer window 10))))))))
 
 
 ;;; Per-project diagnostic listing
@@ -2073,8 +2080,11 @@ flymake-show-project-diagnostics
     (with-current-buffer buffer
       (flymake-project-diagnostics-mode)
       (setq-local flymake--project-diagnostic-list-project prj)
-      (display-buffer (current-buffer))
-      (revert-buffer))))
+      (revert-buffer)
+      (display-buffer (current-buffer)
+                      `((display-buffer-reuse-window
+                         display-buffer-at-bottom)
+                        (window-height . fit-window-to-buffer))))))
 
 (defun flymake--update-diagnostics-listings (buffer)
   "Update diagnostics listings somehow relevant to BUFFER."

--=-=-=--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Juri Linkov <juri@HIDDEN>
Subject: bug#70459: Acknowledgement (Flymake small improvements)
Message-ID: <handler.70459.B.171346173923100.ack <at> debbugs.gnu.org>
References: <86ttjyr3jq.fsf@HIDDEN>
X-Gnu-PR-Message: ack 70459
X-Gnu-PR-Package: emacs
X-Gnu-PR-Keywords: patch
Reply-To: 70459 <at> debbugs.gnu.org
Date: Thu, 18 Apr 2024 17:36:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 70459 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
70459: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D70459
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#70459: Flymake small improvements
Resent-From: Juri Linkov <juri@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 22 Apr 2024 06:58:04 +0000
Resent-Message-ID: <handler.70459.B70459.171376906423615 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 70459 <at> debbugs.gnu.org
From: Juri Linkov <juri@HIDDEN>
In-Reply-To: <86ttjyr3jq.fsf@HIDDEN> (Juri Linkov's message of "Thu, 
 18 Apr 2024 20:23:09 +0300")
Organization: LINKOV.NET
References: <86ttjyr3jq.fsf@HIDDEN>
Date: Mon, 22 Apr 2024 09:54:27 +0300
Message-ID: <86h6ftanvh.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

close 70459 30.0.50
stop

> 1. clicking on flymake fringe indicator will show buffer diagnostics;
> 2. display diagnostics buffers at the bottom;
> 3. to do the above there is a need to swap the order
>    of generating the buffer contents and displaying the buffer,
>    i.e. the same as was done recently in info.el for bug#70213.

This is pushed to master and closed.

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 22 Apr 2024 06:57:45 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 22 02:57:45 2024
Received: from localhost ([127.0.0.1]:45600 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ryncW-00068q-NC
	for submit <at> debbugs.gnu.org; Mon, 22 Apr 2024 02:57:44 -0400
Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]:58177)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>)
 id 1ryncN-00066W-DU; Mon, 22 Apr 2024 02:57:36 -0400
Received: by mail.gandi.net (Postfix) with ESMTPSA id 19744E0005;
 Mon, 22 Apr 2024 06:57:11 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: 70459 <at> debbugs.gnu.org
Subject: Re: bug#70459: Flymake small improvements
In-Reply-To: <86ttjyr3jq.fsf@HIDDEN> (Juri Linkov's message of "Thu, 
 18 Apr 2024 20:23:09 +0300")
Organization: LINKOV.NET
References: <86ttjyr3jq.fsf@HIDDEN>
Date: Mon, 22 Apr 2024 09:54:27 +0300
Message-ID: <86h6ftanvh.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

close 70459 30.0.50
stop

> 1. clicking on flymake fringe indicator will show buffer diagnostics;
> 2. display diagnostics buffers at the bottom;
> 3. to do the above there is a need to swap the order
>    of generating the buffer contents and displaying the buffer,
>    i.e. the same as was done recently in info.el for bug#70213.

This is pushed to master and closed.

Last modified: Mon, 22 Apr 2024 07:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.