GNU bug report logs - #70459
Flymake small improvements

Message received at 70459 <at> debbugs.gnu.org:

Received: (at 70459) by debbugs.gnu.org; 22 Apr 2024 06:57:44 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 22 02:57:44 2024
Received: from localhost ([127.0.0.1]:45598 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ryncW-00068j-Bc
	for submit <at> debbugs.gnu.org; Mon, 22 Apr 2024 02:57:44 -0400
Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]:58177)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>)
 id 1ryncN-00066W-DU; Mon, 22 Apr 2024 02:57:36 -0400
Received: by mail.gandi.net (Postfix) with ESMTPSA id 19744E0005;
 Mon, 22 Apr 2024 06:57:11 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: 70459 <at> debbugs.gnu.org
Subject: Re: bug#70459: Flymake small improvements
In-Reply-To: <86ttjyr3jq.fsf@HIDDEN> (Juri Linkov's message of "Thu, 
 18 Apr 2024 20:23:09 +0300")
Organization: LINKOV.NET
References: <86ttjyr3jq.fsf@HIDDEN>
Date: Mon, 22 Apr 2024 09:54:27 +0300
Message-ID: <86h6ftanvh.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 70459
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

close 70459 30.0.50
stop

> 1. clicking on flymake fringe indicator will show buffer diagnostics;
> 2. display diagnostics buffers at the bottom;
> 3. to do the above there is a need to swap the order
>    of generating the buffer contents and displaying the buffer,
>    i.e. the same as was done recently in info.el for bug#70213.

This is pushed to master and closed.

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 18 Apr 2024 17:35:39 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 18 13:35:38 2024
Received: from localhost ([127.0.0.1]:53654 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rxVfc-000609-Qu
	for submit <at> debbugs.gnu.org; Thu, 18 Apr 2024 13:35:38 -0400
Received: from lists.gnu.org ([2001:470:142::17]:58370)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1rxVfF-0005vV-RR
 for submit <at> debbugs.gnu.org; Thu, 18 Apr 2024 13:35:15 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <juri@HIDDEN>) id 1rxVew-0002kw-2w
 for bug-gnu-emacs@HIDDEN; Thu, 18 Apr 2024 13:34:54 -0400
Received: from relay3-d.mail.gandi.net ([2001:4b98:dc4:8::223])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <juri@HIDDEN>) id 1rxVeu-0004io-6P
 for bug-gnu-emacs@HIDDEN; Thu, 18 Apr 2024 13:34:53 -0400
Received: by mail.gandi.net (Postfix) with ESMTPSA id B216760005
 for <bug-gnu-emacs@HIDDEN>; Thu, 18 Apr 2024 17:34:49 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: Flymake small improvements
Organization: LINKOV.NET
Date: Thu, 18 Apr 2024 20:23:09 +0300
Message-ID: <86ttjyr3jq.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-GND-Sasl: juri@HIDDEN
Received-SPF: pass client-ip=2001:4b98:dc4:8::223;
 envelope-from=juri@HIDDEN; helo=relay3-d.mail.gandi.net
X-Spam_score_int: -25
X-Spam_score: -2.6
X-Spam_bar: --
X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

--=-=-=
Content-Type: text/plain

Tags: patch

1. clicking on flymake fringe indicator will show buffer diagnostics;
2. display diagnostics buffers at the bottom;
3. to do the above there is a need to swap the order
   of generating the buffer contents and displaying the buffer,
   i.e. the same as was done recently in info.el for bug#70213.


--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline; filename=flymake.patch

diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
index 22a139d3045..f5bf68db574 100644
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -1331,7 +1331,10 @@ flymake-start
                   nil))))))))
 
 (defvar flymake-mode-map
-  (let ((map (make-sparse-keymap))) map)
+  (let ((map (make-sparse-keymap)))
+    (define-key map `[,flymake-fringe-indicator-position mouse-1]
+                #'flymake-show-buffer-diagnostics)
+    map)
   "Keymap for `flymake-mode'.")
 
 ;;;###autoload
@@ -1972,8 +1975,12 @@ flymake-show-buffer-diagnostics
                        (current-buffer)))))
     (with-current-buffer target
       (setq flymake--diagnostics-buffer-source source)
-      (display-buffer (current-buffer))
-      (revert-buffer))))
+      (revert-buffer)
+      (display-buffer (current-buffer)
+                      `((display-buffer-reuse-window
+                         display-buffer-below-selected)
+                        (window-height . (lambda (window)
+                          (fit-window-to-buffer window 10))))))))
 
 
 ;;; Per-project diagnostic listing
@@ -2073,8 +2080,11 @@ flymake-show-project-diagnostics
     (with-current-buffer buffer
       (flymake-project-diagnostics-mode)
       (setq-local flymake--project-diagnostic-list-project prj)
-      (display-buffer (current-buffer))
-      (revert-buffer))))
+      (revert-buffer)
+      (display-buffer (current-buffer)
+                      `((display-buffer-reuse-window
+                         display-buffer-at-bottom)
+                        (window-height . fit-window-to-buffer))))))
 
 (defun flymake--update-diagnostics-listings (buffer)
   "Update diagnostics listings somehow relevant to BUFFER."

--=-=-=--