GNU bug report logs - #15763
autoload-generate-file-autoloads can put package--builtin-versions in wrong file

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 15763 in the body.
You can then email your comments to 15763 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #3 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: submit <at> debbugs.gnu.org
Subject: autoload-generate-file-autoloads can put package--builtin-versions in
 wrong file
Date: Wed, 30 Oct 2013 16:53:02 -0400

Package: emacs
Version: 24.3.50

In current trunk, the autoload section of lisp/htmlfontify.el contains:

  ;;; Generated autoloads from hfy-cmap.el
  (push (purecopy '(htmlfontify 0 20)) package--builtin-versions)

That is:

1) Incorrect (htmlfontify.el is at version 0.21, whereas hfy-cmap.el is
at version 0.20).

2) In the wrong file.

I guess autoload-generate-file-autoloads should only do the
package--builtin-versions stuff when writing to the top-level
loaddefs.el file, not when respecting a buffer-local
generated-autoload-file.

Message #6 received at 15763 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 15763 <at> debbugs.gnu.org
Subject: Re: bug#15763: autoload-generate-file-autoloads can put
 package--builtin-versions in wrong file
Date: Sun, 06 Dec 2020 16:14:17 +0100

Glenn Morris <rgm <at> gnu.org> writes:

> In current trunk, the autoload section of lisp/htmlfontify.el contains:
>
>   ;;; Generated autoloads from hfy-cmap.el
>   (push (purecopy '(htmlfontify 0 20)) package--builtin-versions)
>
> That is:
>
> 1) Incorrect (htmlfontify.el is at version 0.21, whereas hfy-cmap.el is
> at version 0.20).
>
> 2) In the wrong file.
>
> I guess autoload-generate-file-autoloads should only do the
> package--builtin-versions stuff when writing to the top-level
> loaddefs.el file, not when respecting a buffer-local
> generated-autoload-file.

I'm guessing this was fixed by this commit:

commit 459cf7cb92445e9336d649f128ec1af274e3f5a1
Author:     Phillip Lord <phillip.lord <at> russet.org.uk>
AuthorDate: Wed Dec 16 23:15:44 2015 +0000

    htmlfontify generate autoload to non-versioned file.
    
    * lisp/Makefile.in: Add htmlfontity-loaddefs to autogenel.
    * lisp/hfy-cmap.el: Update file local.
    * lisp/htmlfontify.el: Remove autoloads, add require.
    * test/lisp/htmlfontify-tests.el: Test autoload functionality.

So I'm closing this bug report.  Please reopen if there's more to be
done here.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 15763 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 15763 <at> debbugs.gnu.org
Subject: Re: bug#15763: autoload-generate-file-autoloads can put
 package--builtin-versions in wrong file
Date: Sun, 06 Dec 2020 17:42:54 -0500

Lars Ingebrigtsen wrote:

> Glenn Morris <rgm <at> gnu.org> writes:
>
>> In current trunk, the autoload section of lisp/htmlfontify.el contains:
>>
>>   ;;; Generated autoloads from hfy-cmap.el
>>   (push (purecopy '(htmlfontify 0 20)) package--builtin-versions)
>>
>> That is:
>>
>> 1) Incorrect (htmlfontify.el is at version 0.21, whereas hfy-cmap.el is
>> at version 0.20).
>>
>> 2) In the wrong file.
>>
>> I guess autoload-generate-file-autoloads should only do the
>> package--builtin-versions stuff when writing to the top-level
>> loaddefs.el file, not when respecting a buffer-local
>> generated-autoload-file.
>
> I'm guessing this was fixed by this commit:
>
> commit 459cf7cb92445e9336d649f128ec1af274e3f5a1
> Author:     Phillip Lord <phillip.lord <at> russet.org.uk>
> AuthorDate: Wed Dec 16 23:15:44 2015 +0000
>
>     htmlfontify generate autoload to non-versioned file.
>     
>     * lisp/Makefile.in: Add htmlfontity-loaddefs to autogenel.
>     * lisp/hfy-cmap.el: Update file local.
>     * lisp/htmlfontify.el: Remove autoloads, add require.
>     * test/lisp/htmlfontify-tests.el: Test autoload functionality.
>
> So I'm closing this bug report.  Please reopen if there's more to be
> done here.

FTR, I was reporting a general issue, using htmlfontify as a specific example.
So that change can't have fixed the general issue.
It's still present, but seems not worth fixing.

Message #16 received at 15763 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 15763 <at> debbugs.gnu.org
Subject: Re: bug#15763: autoload-generate-file-autoloads can put
 package--builtin-versions in wrong file
Date: Tue, 15 Dec 2020 12:42:12 -0500

Just found a real example of this problem:
test/lisp/org/org-tests.el: org-package-version fails in both emacs-27
and master. This is because there is no entry for org in
package--builtin-versions. And this is because the entry has gone to
lisp/org/org-loaddefs.el instead of lisp/loaddefs.el.

Message #19 received at 15763 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 15763 <at> debbugs.gnu.org
Subject: Re: bug#15763: autoload-generate-file-autoloads can put
 package--builtin-versions in wrong file
Date: Tue, 15 Dec 2020 12:50:32 -0500

Glenn Morris wrote:

> Just found a real example of this problem:
> test/lisp/org/org-tests.el: org-package-version fails in both emacs-27
> and master. This is because there is no entry for org in
> package--builtin-versions. And this is because the entry has gone to
> lisp/org/org-loaddefs.el instead of lisp/loaddefs.el.

Hmm, actually, that looks like a bug in org.el.
There is now no autoload for org-mode in emacs-27 -Q.
I wonder why org.el now puts all autoloads in org-loaddefs
(and why such a change is in a bugfix release).
There's zero information in the Emacs repository about the
reason behind any of the Org 9.4.1 changes ("Update to Org 9.4.1" is all
we get).

Message #22 received at 15763 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 15763 <at> debbugs.gnu.org
Subject: Re: bug#15763: autoload-generate-file-autoloads can put
 package--builtin-versions in wrong file
Date: Tue, 15 Dec 2020 13:13:38 -0500

Glenn Morris wrote:

> Hmm, actually, that looks like a bug in org.el.

Filed as https://debbugs.gnu.org/45259 .
Re-closing 15763 as "wontfix".

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.