GNU bug report logs - #30471
sed: help2man: Very old version is used

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30471 in the body.
You can then email your comments to 30471 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Bjarni Ingi Gislason <bjarniig <at> rhi.hi.is>
To: bug-sed <at> gnu.org
Subject: sed: help2man: Very old version is used
Date: Thu, 15 Feb 2018 19:06:28 +0000

  The version of "help2man" is 1.28 from year 2002.
The current version is  1.47.5 from year 2017

  An update is due for a long time.

Message #8 received at 30471 <at> debbugs.gnu.org (full text, mbox):

From: Assaf Gordon <assafgordon <at> gmail.com>
To: Bjarni Ingi Gislason <bjarniig <at> rhi.hi.is>, 30471 <at> debbugs.gnu.org
Subject: Re: bug#30471: sed: help2man: Very old version is used
Date: Mon, 8 Oct 2018 18:50:57 -0600

[Message part 1 (text/plain, inline)]

Hello,

On 15/02/18 12:06 PM, Bjarni Ingi Gislason wrote:
>    The version of "help2man" is 1.28 from year 2002.
> The current version is  1.47.5 from year 2017
> 
>    An update is due for a long time.

Thank you for the report (and sorry for the very late reply).

The attached patch upgrades to the latest help2man (version 1.47.7, 
released on September 2018).

Jim (and others):
For small questions about changes between the (very old) version 1.28 in
sed's git and version 1.47.7 from ftp.gnu.org:

1.
The copyright years changed:
===
-# Copyright (C) 1997-2018 Free Software Foundation, Inc.
+# Copyright (C) 1997, 1998, 1999, 2000, 2001, 2002, 2003, 2004, 2005, 2009,
+# 2010, 2011, 2012, 2013, 2014, 2015, 2016, 2017 Free Software 
Foundation, Inc.
===
Should this be changed?


2.
The shebang line changed like so:
===
-#!/usr/bin/env perl
+#!/usr/bin/perl -w
===
Should this be reverted? do we prefer "/usr/bin/env perl" ?
Debian's policy prefers "/usr/bin/perl" [1]
which I guess is why the script use it.
[1] https://www.debian.org/doc/debian-policy/ch-files.html#scripts

3.
The perl modules changed like so:
===
+use Text::ParseWords qw(shellwords);
+use Locale::gettext qw(gettext);
+use Encode qw(decode encode);
+use I18N::Langinfo qw(langinfo CODESET);
===

On OpenBSD, Alpine-Linux, CentOS7 the module "Locale/gettext.pm" is missing.
This does not affect building from tarball, as the pre-built "sed.1"
is packaged in the tar file.
It is only needed when building from git.

Is this a show-stopper?



regards,
 - assaf

[0001-maint-upgrade-help2man-to-version-1.47.7.patch.xz (application/x-xz, attachment)]

Message #15 received at 30471-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Sed Devel <sed-devel <at> gnu.org>, 30471-done <at> debbugs.gnu.org
Subject: Re: FYI: update to latest help2man
Date: Mon, 23 Mar 2020 22:42:16 -0700

On Mon, Mar 23, 2020 at 6:33 PM Jim Meyering <jim <at> meyering.net> wrote:
> I'm about to push this:

Assaf noticed this: (thanks!)

> perhaps mention and close this?
>    https://debbugs.gnu.org/30471

So I'll close via this message and have adjusted the commit log.
I've just pushed it.
Thanks again!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.