GNU bug report logs - #30677
[PATCH] gnu: youtube-viewer: Add '$out/lib/perl5/site_perl/' to search path.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30677 in the body.
You can then email your comments to 30677 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alex Vong <alexvong1995 <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: alexvong1995 <at> gmail.com
Subject: [PATCH] gnu: youtube-viewer: Add '$out/lib/perl5/site_perl/' to
 search path.
Date: Fri, 02 Mar 2018 21:59:07 +0800

[Message part 1 (text/plain, inline)]

Hello,

This patch should fix <https://bugs.gnu.org/30641>.

[0001-gnu-youtube-viewer-Add-out-lib-perl5-site_perl-to-se.patch (text/x-diff, inline)]

From 2ad112584b40754fadb8269b7d5880500abe0050 Mon Sep 17 00:00:00 2001
From: Alex Vong <alexvong1995 <at> gmail.com>
Date: Fri, 2 Mar 2018 21:22:59 +0800
Subject: [PATCH] gnu: youtube-viewer: Add '$out/lib/perl5/site_perl/' to
 search path.

Fixes <https://bugs.gnu.org/30671>.
Reported by Ricardo Wurmus <rekado <at> elephly.net>.

* gnu/packages/video.scm (youtube-viewer)[arguments]: In 'wrap-program'
phase, add '$out/lib/perl5/site_perl/' to search path.
---
 gnu/packages/video.scm | 22 ++++++++++++----------
 1 file changed, 12 insertions(+), 10 deletions(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 8190b0ffc..74dd290a3 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1344,16 +1344,18 @@ audio, images) from the Web.  It can use either mpv or vlc for playback.")
                   (guix build utils)
                   (srfi srfi-26))
        #:module-build-flags '("--gtk")
-       #:phases (modify-phases %standard-phases
-                  (add-after 'install 'wrap-program
-                    (lambda* (#:key outputs #:allow-other-keys)
-                      (let ((bin-dir (string-append (assoc-ref outputs "out")
-                                                    "/bin/"))
-                            (perl-path (getenv "PERL5LIB")))
-                        (for-each (cut wrap-program <>
-                                       `("PERL5LIB" ":" prefix (,perl-path)))
-                                  (find-files bin-dir))
-                        #t))))))
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'install 'wrap-program
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let* ((out (assoc-ref outputs "out"))
+                    (bin-dir (string-append out "/bin/"))
+                    (site-dir (string-append out "/lib/perl5/site_perl/"))
+                    (lib-path (getenv "PERL5LIB")))
+               (for-each (cut wrap-program <>
+                              `("PERL5LIB" ":" prefix (,lib-path ,site-dir)))
+                         (find-files bin-dir))
+               #t))))))
     (synopsis
      "Lightweight application for searching and streaming videos from YouTube")
     (description
-- 
2.16.2

[Message part 3 (text/plain, inline)]

Cheers,
Alex

[signature.asc (application/pgp-signature, inline)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alex Vong <alexvong1995 <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: alexvong1995 <at> gmail.com
Subject: Re: [PATCH] gnu: youtube-viewer: Add '$out/lib/perl5/site_perl/' to
 search path.
Date: Fri, 02 Mar 2018 22:03:31 +0800

[Message part 1 (text/plain, inline)]

Alex Vong <alexvong1995 <at> gmail.com> writes:

> Hello,
>
> This patch should fix <https://bugs.gnu.org/30641>.
>
Sorry, I mean <https://debbugs.gnu.org/30677>.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alex Vong <alexvong1995 <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: alexvong1995 <at> gmail.com
Subject: Re: [PATCH] gnu: youtube-viewer: Add '$out/lib/perl5/site_perl/' to
 search path.
Date: Fri, 02 Mar 2018 22:08:10 +0800

[Message part 1 (text/plain, inline)]

Alex Vong <alexvong1995 <at> gmail.com> writes:

> Alex Vong <alexvong1995 <at> gmail.com> writes:
>
>> Hello,
>>
>> This patch should fix <https://bugs.gnu.org/30641>.
>>
> Sorry, I mean <https://debbugs.gnu.org/30677>.

In fact, it should be <https://debbugs.gnu.org/30671>.

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 30677 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Alex Vong <alexvong1995 <at> gmail.com>
Cc: 30677 <at> debbugs.gnu.org
Subject: Re: [bug#30677] [PATCH] gnu: youtube-viewer: Add
 '$out/lib/perl5/site_perl/' to search path.
Date: Wed, 07 Mar 2018 11:24:06 +0100

Alex Vong <alexvong1995 <at> gmail.com> skribis:

> From 2ad112584b40754fadb8269b7d5880500abe0050 Mon Sep 17 00:00:00 2001
> From: Alex Vong <alexvong1995 <at> gmail.com>
> Date: Fri, 2 Mar 2018 21:22:59 +0800
> Subject: [PATCH] gnu: youtube-viewer: Add '$out/lib/perl5/site_perl/' to
>  search path.
>
> Fixes <https://bugs.gnu.org/30671>.
> Reported by Ricardo Wurmus <rekado <at> elephly.net>.
>
> * gnu/packages/video.scm (youtube-viewer)[arguments]: In 'wrap-program'
> phase, add '$out/lib/perl5/site_perl/' to search path.

Applied, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.