GNU bug report logs - #35370
notmuch-emacs: avoiding deprecated message-default-charset

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35370 in the body.
You can then email your comments to 35370 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Daniel Kahn Gillmor <dkg <at> fifthhorseman.net>
To: David Bremner <david <at> tethera.net>, Notmuch Mail <notmuch <at> notmuchmail.org>,
 bug-gnu-emacs <at> gnu.org
Subject: Re: notmuch-emacs: avoiding deprecated message-default-charset
Date: Sun, 21 Apr 2019 15:25:46 -0400

[Message part 1 (text/plain, inline)]

On Sun 2019-04-21 11:41:22 -0300, David Bremner wrote:
> Daniel Kahn Gillmor <dkg <at> fifthhorseman.net> writes:
>
>> When i'm building notmuch in a debian environment with emacs
>> 1:26.1+1-3.2, i notice the following deprecation warnings:
>>
>> In notmuch-maildir-setup-message-for-saving:
>> emacs/notmuch-maildir-fcc.el:172:31:Warning: ‘message-default-charset’ is an
>>     obsolete variable (as of 26.1); The default charset comes from the
>>     language environment
>>
>> I'm not enough of an emacs guru to know the right way to avoid this
>> warning, but i'm hoping that someonen else can take a stab at it, since
>> extraneous warnings make it easier to ignore real problems.
>
> Good question. I looked at message.el in emacs master and it
>
>      1) Obsoletes message-default-charset as in 26.1
>      2) Still uses it in exactly the construction we do.

interesting, thanks for digging that up.

> I'm not sure if it's exactly a reportable bug in emacs, but it is a bit
> annoying.

seems reportable, if not exactly high-severity.  what does upstream
expect downstream users of message-default-charset to do?  I'm
(trying to) forward this to the emacs upstream bugtracker; maybe we can
get guidance from them on what to do.

> There is a variable byte-compile-not-obsolete-vars that (probably) can
> be used to suppress that warning, but it's not clear that's a good
> idea (we currently do something similar for Xapian obsolescence warnings
> that we can't fix).

I would generally try to avoid that kind of a bypass, because i tend to
think that warnings are reasonable to look out for and try to fix before
they become real problems.

      --dkg

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 35370 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Daniel Kahn Gillmor <dkg <at> fifthhorseman.net>
Cc: david <at> tethera.net, notmuch <at> notmuchmail.org, 35370 <at> debbugs.gnu.org
Subject: Re: bug#35370: notmuch-emacs: avoiding deprecated
 message-default-charset
Date: Sun, 21 Apr 2019 18:05:19 -0400

Daniel Kahn Gillmor <dkg <at> fifthhorseman.net> writes:

>>> In notmuch-maildir-setup-message-for-saving:
>>> emacs/notmuch-maildir-fcc.el:172:31:Warning: ‘message-default-charset’ is an
>>>     obsolete variable (as of 26.1); The default charset comes from the
>>>     language environment
>>>
>>> I'm not enough of an emacs guru to know the right way to avoid this
>>> warning, but i'm hoping that someonen else can take a stab at it, since
>>> extraneous warnings make it easier to ignore real problems.
>>
>> Good question. I looked at message.el in emacs master and it
>>
>>      1) Obsoletes message-default-charset as in 26.1
>>      2) Still uses it in exactly the construction we do.
>
> interesting, thanks for digging that up.
>
>> I'm not sure if it's exactly a reportable bug in emacs, but it is a bit
>> annoying.
>
> seems reportable, if not exactly high-severity.  what does upstream
> expect downstream users of message-default-charset to do?  I'm
> (trying to) forward this to the emacs upstream bugtracker; maybe we can
> get guidance from them on what to do.

The commit which marks this variable as obsolete, has a couple hunks
that just remove uses of it.  Not clear why other uses were left in.
Oversight?

[1: 66d9ef95c0]: 2016-02-14 17:07:48 +1100
  Remove compat code for older Emacsen
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=66d9ef95c0f9407d2a6d26bcd7ed84a303294b53

--- a/lisp/gnus/gnus-int.el
+++ b/lisp/gnus/gnus-int.el
@@ -777,8 +777,7 @@ (defun gnus-request-accept-article (group &optional gnus-command-method last
       (message-options-set-recipient)
       (save-restriction
 	(message-narrow-to-head)
-	(let ((mail-parse-charset message-default-charset))
-	  (mail-encode-encoded-word-buffer)))
+	(mail-encode-encoded-word-buffer))
       (message-encode-message-body)))
   (let ((gnus-command-method (or gnus-command-method
 				 (gnus-find-method-for-group group)))
@@ -800,8 +799,7 @@ (defun gnus-request-replace-article (article group buffer &optional no-encode)
       (message-options-set-recipient)
       (save-restriction
 	(message-narrow-to-head)
-	(let ((mail-parse-charset message-default-charset))
-	  (mail-encode-encoded-word-buffer)))
+	(mail-encode-encoded-word-buffer))
       (message-encode-message-body)))
   (let* ((func (car (gnus-group-name-to-method group)))
          (result (funcall (intern (format "%s-request-replace-article" func))

Message #11 received at 35370 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Kahn Gillmor <dkg <at> fifthhorseman.net>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: david <at> tethera.net, notmuch <at> notmuchmail.org, 35370 <at> debbugs.gnu.org
Subject: Re: bug#35370: notmuch-emacs: avoiding deprecated
 message-default-charset
Date: Sun, 21 Apr 2019 21:55:38 -0400

[Message part 1 (text/plain, inline)]

On Sun 2019-04-21 18:05:19 -0400, Noam Postavsky wrote:
> The commit which marks this variable as obsolete, has a couple hunks
> that just remove uses of it.  Not clear why other uses were left in.
> Oversight?

Thanks, Noam!  If that's the right thing for emacs itself, that's good
to know.

Do you have any recommendation for how an external emacs module (which
aims to work with at emacs 25 as well at least) should handle this?

     --dkg

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 35370 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Daniel Kahn Gillmor <dkg <at> fifthhorseman.net>
Cc: david <at> tethera.net, notmuch <at> notmuchmail.org, npostavs <at> gmail.com,
 35370 <at> debbugs.gnu.org
Subject: Re: bug#35370: notmuch-emacs: avoiding deprecated
 message-default-charset
Date: Mon, 22 Apr 2019 09:33:26 +0300

> From: Daniel Kahn Gillmor <dkg <at> fifthhorseman.net>
> Date: Sun, 21 Apr 2019 21:55:38 -0400
> Cc: david <at> tethera.net, notmuch <at> notmuchmail.org, 35370 <at> debbugs.gnu.org
> 
> Do you have any recommendation for how an external emacs module (which
> aims to work with at emacs 25 as well at least) should handle this?

Just remove any uses of it.  Why are you using it now?

Message #17 received at 35370 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Kahn Gillmor <dkg <at> fifthhorseman.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: david <at> tethera.net, notmuch <at> notmuchmail.org, npostavs <at> gmail.com,
 35370 <at> debbugs.gnu.org
Subject: Re: bug#35370: notmuch-emacs: avoiding deprecated
 message-default-charset
Date: Mon, 22 Apr 2019 10:21:25 -0400

[Message part 1 (text/plain, inline)]

Hi Eli--

Thanks for the prompt followup!

On Mon 2019-04-22 09:33:26 +0300, Eli Zaretskii wrote:
> [dkg wrote:]
>> Do you have any recommendation for how an external emacs module (which
>> aims to work with at emacs 25 as well at least) should handle this?
>
> Just remove any uses of it.  Why are you using it now?

in notmuch's emacs/notmuch-maildir-fcc.el, as mentioned at the beginning
of this thread:

https://git.notmuchmail.org/git?p=notmuch;a=blob;f=emacs/notmuch-maildir-fcc.el;h=1551e8b649102ccdfecad9a2ef278949bfb3d702;hb=HEAD#l172

If we remove that entry from the (let) block, what are the implications
for users of notmuch who are still using emacs 25?

I don't have much knowledge in the way of deep emacs or message-mode
internals, so if there's answer that's obvious to you that you think i'm
missing, feel free to just point me to it.  Thanks!

   --dkg

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 35370 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Daniel Kahn Gillmor <dkg <at> fifthhorseman.net>
Cc: david <at> tethera.net, notmuch <at> notmuchmail.org, npostavs <at> gmail.com,
 35370 <at> debbugs.gnu.org
Subject: Re: bug#35370: notmuch-emacs: avoiding deprecated
 message-default-charset
Date: Mon, 22 Apr 2019 18:37:52 +0300

> From: Daniel Kahn Gillmor <dkg <at> fifthhorseman.net>
> Cc: npostavs <at> gmail.com, david <at> tethera.net, notmuch <at> notmuchmail.org, 35370 <at> debbugs.gnu.org
> Date: Mon, 22 Apr 2019 10:21:25 -0400
> 
> > Just remove any uses of it.  Why are you using it now?
> 
> in notmuch's emacs/notmuch-maildir-fcc.el, as mentioned at the beginning
> of this thread:
> 
> https://git.notmuchmail.org/git?p=notmuch;a=blob;f=emacs/notmuch-maildir-fcc.el;h=1551e8b649102ccdfecad9a2ef278949bfb3d702;hb=HEAD#l172
> 
> If we remove that entry from the (let) block, what are the implications
> for users of notmuch who are still using emacs 25?

Nothing, I think.  But if you don't want to risk problems, you can use
it dependent on the Emacs version.

Message #23 received at 35370 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Kahn Gillmor <dkg <at> fifthhorseman.net>
To: Notmuch Mail <notmuch <at> notmuchmail.org>
Cc: 35370 <at> debbugs.gnu.org
Subject: [PATCH] emacs: drop use of message-default-charset
Date: Mon, 22 Apr 2019 16:51:16 -0400

Apparently, message-default-charset is deprecated, which causes the
following warning messages during the build:

  In notmuch-maildir-setup-message-for-saving:
  emacs/notmuch-maildir-fcc.el:172:31:Warning: ‘message-default-charset’ is an
      obsolete variable (as of 26.1); The default charset comes from the
      language environment

In discussion with emacs upstream over on
https://debbugs.gnu.org/35370, it appears that we can just drop this
entirely and things should still work with emacs 25.
---
 emacs/notmuch-maildir-fcc.el | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/emacs/notmuch-maildir-fcc.el b/emacs/notmuch-maildir-fcc.el
index 1551e8b6..ae56bacd 100644
--- a/emacs/notmuch-maildir-fcc.el
+++ b/emacs/notmuch-maildir-fcc.el
@@ -169,8 +169,7 @@ This is taken from the function message-do-fcc."
   (message-encode-message-body)
   (save-restriction
     (message-narrow-to-headers)
-    (let ((mail-parse-charset message-default-charset))
-      (mail-encode-encoded-word-buffer)))
+    (mail-encode-encoded-word-buffer))
   (goto-char (point-min))
   (when (re-search-forward
 	 (concat "^" (regexp-quote mail-header-separator) "$")
-- 
2.20.1

Message #26 received at 35370 <at> debbugs.gnu.org (full text, mbox):

From: Tomi Ollila <tomi.ollila <at> iki.fi>
To: Daniel Kahn Gillmor <dkg <at> fifthhorseman.net>,
 Notmuch Mail <notmuch <at> notmuchmail.org>
Cc: 35370 <at> debbugs.gnu.org
Subject: Re: [PATCH] emacs: drop use of message-default-charset
Date: Tue, 23 Apr 2019 00:23:24 +0300

On Mon, Apr 22 2019, Daniel Kahn Gillmor wrote:

> Apparently, message-default-charset is deprecated, which causes the
> following warning messages during the build:
>
>   In notmuch-maildir-setup-message-for-saving:
>   emacs/notmuch-maildir-fcc.el:172:31:Warning: ‘message-default-charset’ is an
>       obsolete variable (as of 26.1); The default charset comes from the
>       language environment
>
> In discussion with emacs upstream over on
> https://debbugs.gnu.org/35370, it appears that we can just drop this
> entirely and things should still work with emacs 25.

I looked this a bit (well, quite a few minutes, rfc2047.el in emacs 24.3,
25.2 and 26.1), and while it is impossible to gain any real knowledge
with such a shallow peek, I'd guess the following might be true:

Since `mail-parse-charset` and `message-default-charset` are (were) both
`nil` by default, this change does have any effect for users that never
customized message-default-charset. If anyone did, now there is small
chance that the line:

"If nil, you might be asked to input the charset."

(from message-default-charset docstring) can happen.

In this context the change is IMO even more unlikely.

So this change LGTM.

Tomi

> ---
>  emacs/notmuch-maildir-fcc.el | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/emacs/notmuch-maildir-fcc.el b/emacs/notmuch-maildir-fcc.el
> index 1551e8b6..ae56bacd 100644
> --- a/emacs/notmuch-maildir-fcc.el
> +++ b/emacs/notmuch-maildir-fcc.el
> @@ -169,8 +169,7 @@ This is taken from the function message-do-fcc."
>    (message-encode-message-body)
>    (save-restriction
>      (message-narrow-to-headers)
> -    (let ((mail-parse-charset message-default-charset))
> -      (mail-encode-encoded-word-buffer)))
> +    (mail-encode-encoded-word-buffer))
>    (goto-char (point-min))
>    (when (re-search-forward
>  	 (concat "^" (regexp-quote mail-header-separator) "$")
> -- 
> 2.20.1
>
> _______________________________________________
> notmuch mailing list
> notmuch <at> notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch

Message #29 received at 35370 <at> debbugs.gnu.org (full text, mbox):

From: David Bremner <david <at> tethera.net>
To: Daniel Kahn Gillmor <dkg <at> fifthhorseman.net>,
 Notmuch Mail <notmuch <at> notmuchmail.org>
Cc: 35370 <at> debbugs.gnu.org
Subject: Re: [PATCH] emacs: drop use of message-default-charset
Date: Tue, 07 May 2019 06:38:36 -0300

Daniel Kahn Gillmor <dkg <at> fifthhorseman.net> writes:

> Apparently, message-default-charset is deprecated, which causes the
> following warning messages during the build:
>
>   In notmuch-maildir-setup-message-for-saving:
>   emacs/notmuch-maildir-fcc.el:172:31:Warning: ‘message-default-charset’ is an
>       obsolete variable (as of 26.1); The default charset comes from the
>       language environment
>
> In discussion with emacs upstream over on
> https://debbugs.gnu.org/35370, it appears that we can just drop this
> entirely and things should still work with emacs 25.

pushed

d

Message #32 received at 35370 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: david <at> tethera.net, notmuch <at> notmuchmail.org,
 Daniel Kahn Gillmor <dkg <at> fifthhorseman.net>, 35370 <at> debbugs.gnu.org
Subject: Re: bug#35370: notmuch-emacs: avoiding deprecated
 message-default-charset
Date: Tue, 07 May 2019 08:26:59 -0400

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Daniel Kahn Gillmor <dkg <at> fifthhorseman.net>
>> Date: Sun, 21 Apr 2019 21:55:38 -0400
>> Cc: david <at> tethera.net, notmuch <at> notmuchmail.org, 35370 <at> debbugs.gnu.org
>> 
>> Do you have any recommendation for how an external emacs module (which
>> aims to work with at emacs 25 as well at least) should handle this?
>
> Just remove any uses of it.  Why are you using it now?

Should we remove the remaining uses of it from Emacs too?

[0001-Stop-using-message-default-charset-Bug-35370.patch (text/plain, attachment)]

Message #35 received at 35370 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Noam Postavsky <npostavs <at> gmail.com>, Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: david <at> tethera.net, notmuch <at> notmuchmail.org, dkg <at> fifthhorseman.net,
 35370 <at> debbugs.gnu.org
Subject: Re: bug#35370: notmuch-emacs: avoiding deprecated
 message-default-charset
Date: Tue, 07 May 2019 17:36:37 +0300

> From: Noam Postavsky <npostavs <at> gmail.com>
> Cc: Daniel Kahn Gillmor <dkg <at> fifthhorseman.net>,  david <at> tethera.net,  notmuch <at> notmuchmail.org,  35370 <at> debbugs.gnu.org
> Date: Tue, 07 May 2019 08:26:59 -0400
> 
> > Just remove any uses of it.  Why are you using it now?
> 
> Should we remove the remaining uses of it from Emacs too?

I think so, but I'd be happier if someone from the Gnus folks could
eyeball this patch.

Lars, any comments/objections?

Message #38 received at 35370 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: david <at> tethera.net, notmuch <at> notmuchmail.org,
 Noam Postavsky <npostavs <at> gmail.com>, dkg <at> fifthhorseman.net,
 35370 <at> debbugs.gnu.org
Subject: Re: bug#35370: notmuch-emacs: avoiding deprecated
 message-default-charset
Date: Thu, 09 May 2019 14:33:15 -0400

Eli Zaretskii <eliz <at> gnu.org> writes:

> I think so, but I'd be happier if someone from the Gnus folks could
> eyeball this patch.
>
> Lars, any comments/objections?

I think the patch looks OK -- it'll change the behaviour if you have
set enable-multibyte-characters to nil, but...  does anybody do that?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #41 received at 35370 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: david <at> tethera.net, notmuch <at> notmuchmail.org, npostavs <at> gmail.com,
 dkg <at> fifthhorseman.net, 35370 <at> debbugs.gnu.org
Subject: Re: bug#35370: notmuch-emacs: avoiding deprecated
 message-default-charset
Date: Fri, 10 May 2019 08:32:30 +0300

> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Cc: Noam Postavsky <npostavs <at> gmail.com>,  david <at> tethera.net,  notmuch <at> notmuchmail.org,  dkg <at> fifthhorseman.net,  35370 <at> debbugs.gnu.org
> Date: Thu, 09 May 2019 14:33:15 -0400
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > I think so, but I'd be happier if someone from the Gnus folks could
> > eyeball this patch.
> >
> > Lars, any comments/objections?
> 
> I think the patch looks OK -- it'll change the behaviour if you have
> set enable-multibyte-characters to nil, but...  does anybody do that?

If they do, it's their funeral.

Noam, please go ahead, and thanks.

Message #44 received at 35370 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: david <at> tethera.net, Lars Ingebrigtsen <larsi <at> gnus.org>,
 notmuch <at> notmuchmail.org, dkg <at> fifthhorseman.net, 35370 <at> debbugs.gnu.org
Subject: Re: bug#35370: notmuch-emacs: avoiding deprecated
 message-default-charset
Date: Fri, 10 May 2019 06:45:39 -0400

close 35370
quit

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Lars Ingebrigtsen <larsi <at> gnus.org>

>> I think the patch looks OK -- it'll change the behaviour if you have
>> set enable-multibyte-characters to nil, but...  does anybody do that?
>
> If they do, it's their funeral.
>
> Noam, please go ahead, and thanks.

Done.

510aa7505f 2019-05-10T06:41:59-04:00 "Stop using message-default-charset (Bug#35370)"
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=510aa7505fc14e0ebc6a0d220160397f068c5c04

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.