GNU bug report logs - #5783
[bug #29349] ls.c missing HAVE_NL_LANGINFO check

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 5783 in the body.
You can then email your comments to 5783 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alan Hourihane <INVALID.NOREPLY <at> gnu.org>
To: Eric Blake <eblake <at> redhat.com>, Alan Hourihane <alanh <at> fairlite.co.uk>,
	jim <at> meyering.net, bug-coreutils <at> gnu.org
Subject: [bug #29349] ls.c missing HAVE_NL_LANGINFO check
Date: Fri, 26 Mar 2010 15:54:25 +0000

Follow-up Comment #5, bug #29349 (project coreutils):

O.k. But the problem is that when abmon_init returns 0 we get the horrible
error message for the case that we don't have HAVE_NL_LANGINFO. And given that
abmon_init() already contains this check, we should probably just move the
check to around the abmon_init() call as in the attached patch and remove the
if/endif in abmon_init() itself.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?29349>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/

Message #10 received at 5783 <at> debbugs.gnu.org (full text, mbox):

From: Assaf Gordon <assafgordon <at> gmail.com>
To: 5783 <at> debbugs.gnu.org
Subject: bug5783: ls.c missing HAVE_NL_LANGINFO check
Date: Mon, 29 Oct 2018 22:46:51 -0600

tags 5783 fixed
close 5783
stop

triaging very old bug: https://debbugs.gnu.org/5783
and https://savannah.gnu.org/bugs/?29349 .

In 2016, Paul committed the following:

ls: fix %%b format and precompute more
https://git.savannah.gnu.org/cgit/coreutils.git/commit/?id=1db94ee969b984bbd00b97c6abbe2f69db8e0000

Which I believe fixes the ls/month issue
(compare the commit with the suggested patch from 2010:
https://savannah.gnu.org/bugs/download.php?file_id=20037 ).

As such, I'm closing this bug (if that's wrong, re-open it).
Discussion can continue by replying to this thread.

-assaf

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.