Lars Ingebrigtsen <larsi@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Lars Ingebrigtsen <larsi@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 22324) by debbugs.gnu.org; 29 Jan 2022 01:57:46 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 28 20:57:46 2022 Received: from localhost ([127.0.0.1]:60774 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1nDczq-0002H1-4T for submit <at> debbugs.gnu.org; Fri, 28 Jan 2022 20:57:46 -0500 Received: from mail-wr1-f54.google.com ([209.85.221.54]:46066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <raaahh@HIDDEN>) id 1nDczo-0002Go-Ka for 22324 <at> debbugs.gnu.org; Fri, 28 Jan 2022 20:57:45 -0500 Received: by mail-wr1-f54.google.com with SMTP id m14so13873668wrg.12 for <22324 <at> debbugs.gnu.org>; Fri, 28 Jan 2022 17:57:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=g93p3zrBxzek7eAOqM98hpQCxu2akLmY0ChGIIQgaHc=; b=pIG2crgN2NrLraWWtXwWodGQwKPCTMrQse1lg5t3mZC94S3ogXa0Lfsnco9ih9OrJC lDLIjThJkB5b1BIC8+Vfh/gRTLOnJK9NJyBqMWBMKs0cqNmb9p2RPKj4/F+28GGB016G 5UdrdelXE6wDCCvUjXtHqcERzacFGLoCSd2Km3tCylcDRkr3NIVHjB4bojM8q5uedxVe yKbW4akhFH9ZYofaLaLgzSDDZNZODIu5G97EQfV7ZsEoAd0zbViyER41oh36oP4iTb0G lgTMRMsxGpHH48ZlNWX+J6oJrc5MLSn63MwosjZttUPgpW3VENCBjLh64yjxmR++PGY5 itNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=g93p3zrBxzek7eAOqM98hpQCxu2akLmY0ChGIIQgaHc=; b=qILdlz004xhVGGEnL9pgX3ywcUVCHvY0htnLeii78OUvneBEHwf8rDXwD8Jz2h/s5x xH0muXFSq9zdphdf+Rg72kY642Z0O8w+NvMG4aT9QvRPrFb/2CGaHDX0x5ThTEwpr4DA xTkdaxvPZSZtU0frl7EMsE4D6BSIJ1qiSMoo4MJbheoRWewAieFznqpG/shyACXSfI04 BwVSt5fwXIxGdjjZpEgwOY5fkDxQSumBkT3xz45XfHP11DAIQw0R1YCRo0MMjFqcpcTW l9bmtsWJ3vHdFHi0L+HB0rnvrBCvvCzThzR9B5nuCwcBay4oxYUnZIvKMU+rHVFqK6co A4tA== X-Gm-Message-State: AOAM530JRIByK4mhMQ6Y6JHolZgwGeQZiWGArFzn6kEbhbWK0JOkl4cn GAuckSb2c7fdBKhvetGQu2ZBEZqGBqs= X-Google-Smtp-Source: ABdhPJzMQuZ/d3F3lF6oUIJuwo28y00t9/DRhNPR2hkJ7MuMIbiYlvkJqd/dUZHMX9XqRF/8YSueKw== X-Received: by 2002:a5d:5589:: with SMTP id i9mr9150004wrv.246.1643421458376; Fri, 28 Jan 2022 17:57:38 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id z5sm3536789wmp.10.2022.01.28.17.57.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jan 2022 17:57:37 -0800 (PST) Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead) To: Stefan Monnier <monnier@HIDDEN> References: <868u41rv84.fsf@HIDDEN> <a1f74c9e-0043-9be9-5739-e87e58dd8fa8@HIDDEN> <87lf0yjwpw.fsf@HIDDEN> <ad66bc96-1f85-850b-4952-35bd6749da02@HIDDEN> <87r1aodus0.fsf@HIDDEN> <66aa873d-5f5f-9024-efb6-e6110c27ab3a@HIDDEN> <87ilvy4m94.fsf@HIDDEN> <87czklnqvs.fsf@HIDDEN> <3045ca8b-f5d6-c85e-d170-3fe158fec64e@HIDDEN> <87ilu94gac.fsf@HIDDEN> <43725c9f-1f0a-fb43-82a2-3f284791fdf5@HIDDEN> <875yq8ypmi.fsf@HIDDEN> <a9258e5f-4ee5-61dc-dc94-8ca697ff8a41@HIDDEN> <d3a97207-c944-c941-8a85-dbf59056987f@HIDDEN> <jwvczke8w23.fsf-monnier+emacs@HIDDEN> <184dffab-4fa4-e265-c8ef-0c088149b1b4@HIDDEN> <jwvee4ue8na.fsf-monnier+emacs@HIDDEN> <bc1f89d4-fec9-a178-0e2b-d70c3c8e957e@HIDDEN> <2115dbe9-fc14-e21c-5a04-1a1c0c85ceef@HIDDEN> <jwvczkb7qj2.fsf-monnier+emacs@HIDDEN> <7e725d20-af1e-80ee-091f-caf2faac5819@HIDDEN> <jwvtudn31b1.fsf-monnier+emacs@HIDDEN> From: Dmitry Gutov <dgutov@HIDDEN> Message-ID: <4a8392b6-d95b-eeb4-e54c-e0512a4c2fe0@HIDDEN> Date: Sat, 29 Jan 2022 03:57:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <jwvtudn31b1.fsf-monnier+emacs@HIDDEN> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 22324 Cc: Daniel Mendler <mail@HIDDEN>, Lars Ingebrigtsen <larsi@HIDDEN>, 22324 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.6 (-) On 29.01.2022 01:18, Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: >> Trying to honor the user's customization of 'completion-styles' makes >> a certain amount of sense. Though I don't know how much we honor it this >> way: if the user is relatively new, they might not even know to keep typing >> to see the fallback, after noting that their input does not give them the >> matches they expected. > > Actually, I suspect it works better for new users than for old ones: new > users don't yet have a clear mental model of how Emacs's completion > works so they might expect something more like what you see with a web > browser search where adding more data can completely change the > proposed completions. But a web browser model is more like a single 'flex' completion style. You get fuzzy matching and a score-based searching. After my input in the address bar makes the completions list shrink to just a few entries, it never occurs to me to keep typing to see something else that is not in that list. In Firefox that will never work -- but it works with completion styles in Emacs. > In contrast old-timers may indeed "know" that there won't be any > completions further down and will never reach the second style (to some > extent, that's how I got Richard to accept `partial-completion` in the > default). > >> It's more of a critique of the whole "list of styles" design, admittedly. > > I don't regret doing it because I don't think there was any other > way to activate `partial-completion` by default, but yes it has > its downsides. Sure. I'm just not sure where we go from here. A "single completion style" approach (with sorting and scoring) would make things easier and familiar in the long run. But if we stay with the current approach (which has its upsides), seems like Daniel's suggestion can be a good option for this particular bug.
bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.
Received: (at 22324) by debbugs.gnu.org; 28 Jan 2022 23:18:26 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 28 18:18:26 2022
Received: from localhost ([127.0.0.1]:60721 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nDaVd-0006hy-Uh
for submit <at> debbugs.gnu.org; Fri, 28 Jan 2022 18:18:26 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:42481)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1nDaVc-0006hj-BR
for 22324 <at> debbugs.gnu.org; Fri, 28 Jan 2022 18:18:25 -0500
Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 69C8380539;
Fri, 28 Jan 2022 18:18:18 -0500 (EST)
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 07764803B6;
Fri, 28 Jan 2022 18:18:17 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1643411897;
bh=6Lf2WfywO3Xq7XYkO835YvLlUAwDCcP1LY42ywj8BbM=;
h=From:To:Cc:Subject:References:Date:In-Reply-To:From;
b=arwvoVUPeZY8SiWmBJ3aKYunuOV1tjGhNAIT3UnqaqqoK/b4uCpnqhZeEoK7HpiWv
Zs1vKM8YqSqfZryMTfWtiCaH5lWI+TOf4ehosN0A/2+nY0wE6HKtEqC8d6/u4H7vFV
V3CRTiMPOGb2QVsj0nIXFcTPjAJqVw54LRS8sDOGPgkLNZQBqBO+D57P64+pr+uDsz
GzZAz5YZXpd+ovoyozhQAd/LJvm3C61ZEibFqq1aO7S07htFY9Opu4tw1jj2MBuuVH
IXTVXjTWvSdq6F98TQ6aEgb/HsOQyopYOVVs4lCkqonVH5Wsnlqzg0HX0fAzBJAjMK
/3JRrkGm5YSUA==
Received: from ceviche (76-10-138-212.dsl.teksavvy.com [76.10.138.212])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C7C1D12059A;
Fri, 28 Jan 2022 18:18:16 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
To: Dmitry Gutov <dgutov@HIDDEN>
Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't
override completion-styles (gets prepended instead)
Message-ID: <jwvtudn31b1.fsf-monnier+emacs@HIDDEN>
References: <868u41rv84.fsf@HIDDEN>
<a1f74c9e-0043-9be9-5739-e87e58dd8fa8@HIDDEN>
<87lf0yjwpw.fsf@HIDDEN>
<ad66bc96-1f85-850b-4952-35bd6749da02@HIDDEN>
<87r1aodus0.fsf@HIDDEN>
<66aa873d-5f5f-9024-efb6-e6110c27ab3a@HIDDEN>
<87ilvy4m94.fsf@HIDDEN> <87czklnqvs.fsf@HIDDEN>
<3045ca8b-f5d6-c85e-d170-3fe158fec64e@HIDDEN>
<87ilu94gac.fsf@HIDDEN>
<43725c9f-1f0a-fb43-82a2-3f284791fdf5@HIDDEN>
<875yq8ypmi.fsf@HIDDEN>
<a9258e5f-4ee5-61dc-dc94-8ca697ff8a41@HIDDEN>
<d3a97207-c944-c941-8a85-dbf59056987f@HIDDEN>
<jwvczke8w23.fsf-monnier+emacs@HIDDEN>
<184dffab-4fa4-e265-c8ef-0c088149b1b4@HIDDEN>
<jwvee4ue8na.fsf-monnier+emacs@HIDDEN>
<bc1f89d4-fec9-a178-0e2b-d70c3c8e957e@HIDDEN>
<2115dbe9-fc14-e21c-5a04-1a1c0c85ceef@HIDDEN>
<jwvczkb7qj2.fsf-monnier+emacs@HIDDEN>
<7e725d20-af1e-80ee-091f-caf2faac5819@HIDDEN>
Date: Fri, 28 Jan 2022 18:18:15 -0500
In-Reply-To: <7e725d20-af1e-80ee-091f-caf2faac5819@HIDDEN> (Dmitry Gutov's
message of "Sat, 29 Jan 2022 00:06:21 +0200")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -0.026 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain T_SCC_BODY_TEXT_LINE -0.01 -
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 22324
Cc: Daniel Mendler <mail@HIDDEN>, Lars Ingebrigtsen <larsi@HIDDEN>,
22324 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> Trying to honor the user's customization of 'completion-styles' makes
> a certain amount of sense. Though I don't know how much we honor it this
> way: if the user is relatively new, they might not even know to keep typing
> to see the fallback, after noting that their input does not give them the
> matches they expected.
Actually, I suspect it works better for new users than for old ones: new
users don't yet have a clear mental model of how Emacs's completion
works so they might expect something more like what you see with a web
browser search where adding more data can completely change the
proposed completions.
In contrast old-timers may indeed "know" that there won't be any
completions further down and will never reach the second style (to some
extent, that's how I got Richard to accept `partial-completion` in the
default).
> It's more of a critique of the whole "list of styles" design, admittedly.
I don't regret doing it because I don't think there was any other
way to activate `partial-completion` by default, but yes it has
its downsides.
Stefan
bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.Received: (at 22324) by debbugs.gnu.org; 28 Jan 2022 22:06:32 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 28 17:06:32 2022 Received: from localhost ([127.0.0.1]:60649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1nDZO3-0002UH-Ox for submit <at> debbugs.gnu.org; Fri, 28 Jan 2022 17:06:31 -0500 Received: from mail-wm1-f44.google.com ([209.85.128.44]:39930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <raaahh@HIDDEN>) id 1nDZO2-0002U3-9s for 22324 <at> debbugs.gnu.org; Fri, 28 Jan 2022 17:06:30 -0500 Received: by mail-wm1-f44.google.com with SMTP id o1-20020a1c4d01000000b0034d95625e1fso9097575wmh.4 for <22324 <at> debbugs.gnu.org>; Fri, 28 Jan 2022 14:06:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=oTnHXYWfvxZYwTDzIrqt97vGRdbNOSwq5zAfgqTwKgY=; b=TfdChaRBV4fh1ihVYRCxMuf4xq92zJoWK078VgLgj/5puKxqCYMHfigDJIVcYzq95R Yc+FHNvvQVs3UCwUbeL4ok2cH5Ub2Kdz79J9P0ttH7xsAR8bdkww0JzSRRhL145T7lwi 6NWecficDoNwbrmenbDq4TCsONMp1P3VYJntMB+84mBhfGmehWts31kSn9XrxJP3UH4j hwYL7lwRxG6MOk4lriRXsTSKHL1T/8NN3lw3A2/oN3pwbuCcYnOc6XczTqnXYfIjnGSs jiGf2eSUdyRtH6YshqmZnsNF3ZcvFwF8nS3Ax6muGg7hTXhgcITMuq7wZ5o2jloyVWtl cHjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oTnHXYWfvxZYwTDzIrqt97vGRdbNOSwq5zAfgqTwKgY=; b=22qENZ4WKMQU+xs77Eb7jhPzaoCU9Xt5cATxRzmfo1HZyuLfs8frrDVGkNR0FTDVyC Wq66gIk0X6IP1HL3gq/RudszpSH/8mMiHIRLFDWV/N1Vbajf5kOok7MzF4M+mTtWP62k s9aZLQEgV0u0oxY5GNAlVyISXDztqMDYdgQsvyDoIqEAgwcf+aHtzs3NaLfVuYeRFPoj lVa9+iG+DwdPd1U5/9e2T55szPef1dupoLhqj5EWRUWuEy+Orh+FhBZLKcyhOq8SnBg6 2R8mCDI0IJvTx22JuRWbvs7teYJA3WrWN8Wxf6Vn/66DPFFKUsu6YnNcxQ7PYTw8p6wy 0PPw== X-Gm-Message-State: AOAM531OnU1RlikIOdj0FJZYF+jE+PaAzP9Bg3wY0VKzguOBaC+akVKB DUb8MRBRTBbajrYN2lAQsAW4IzVVfSA= X-Google-Smtp-Source: ABdhPJyg2zJfmfdb29JcU4fhxPbdycnFnbgyLBpoR8NaNXwepBd5cjzWHwBnuHJMz4ujtJeP3odwiQ== X-Received: by 2002:a7b:c4cd:: with SMTP id g13mr18051768wmk.95.1643407584168; Fri, 28 Jan 2022 14:06:24 -0800 (PST) Received: from [10.107.115.144] ([185.209.196.174]) by smtp.googlemail.com with ESMTPSA id h127sm458723wmh.2.2022.01.28.14.06.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jan 2022 14:06:23 -0800 (PST) Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead) To: Stefan Monnier <monnier@HIDDEN> References: <868u41rv84.fsf@HIDDEN> <568FABFC.3000205@HIDDEN> <87tufr74of.fsf@HIDDEN> <a1f74c9e-0043-9be9-5739-e87e58dd8fa8@HIDDEN> <87lf0yjwpw.fsf@HIDDEN> <ad66bc96-1f85-850b-4952-35bd6749da02@HIDDEN> <87r1aodus0.fsf@HIDDEN> <66aa873d-5f5f-9024-efb6-e6110c27ab3a@HIDDEN> <87ilvy4m94.fsf@HIDDEN> <87czklnqvs.fsf@HIDDEN> <3045ca8b-f5d6-c85e-d170-3fe158fec64e@HIDDEN> <87ilu94gac.fsf@HIDDEN> <43725c9f-1f0a-fb43-82a2-3f284791fdf5@HIDDEN> <875yq8ypmi.fsf@HIDDEN> <a9258e5f-4ee5-61dc-dc94-8ca697ff8a41@HIDDEN> <d3a97207-c944-c941-8a85-dbf59056987f@HIDDEN> <jwvczke8w23.fsf-monnier+emacs@HIDDEN> <184dffab-4fa4-e265-c8ef-0c088149b1b4@HIDDEN> <jwvee4ue8na.fsf-monnier+emacs@HIDDEN> <bc1f89d4-fec9-a178-0e2b-d70c3c8e957e@HIDDEN> <2115dbe9-fc14-e21c-5a04-1a1c0c85ceef@HIDDEN> <jwvczkb7qj2.fsf-monnier+emacs@HIDDEN> From: Dmitry Gutov <dgutov@HIDDEN> Message-ID: <7e725d20-af1e-80ee-091f-caf2faac5819@HIDDEN> Date: Sat, 29 Jan 2022 00:06:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <jwvczkb7qj2.fsf-monnier+emacs@HIDDEN> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 22324 Cc: Daniel Mendler <mail@HIDDEN>, Lars Ingebrigtsen <larsi@HIDDEN>, 22324 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.6 (-) On 28.01.2022 18:56, Stefan Monnier wrote: >> If we were designing it from the ground up, we probably wouldn't add an >> 'ignore' style. We could have added a special value like 't' which would >> mean the opposite (*do* the fallback, for those users who would want their >> configs to be just a little bit more terse), > > FWIW, the choice of using a fallback to `completion-style` was made for > `completion-category-defaults` so that those package-choices don't > unilaterally override the user's choice in `completion-style`. > > For `completion-category-override` there is indeed not much need for > a fallback, since it's set by the same person as `completion-style`. That seems to argue for Daniel's original suggestion: to make '-overrides' a "real" override and keep the composition behavior for the '-defaults' variable. Trying to honor the user's customization of 'completion-styles' makes a certain amount of sense. Though I don't know how much we honor it this way: if the user is relatively new, they might not even know to keep typing to see the fallback, after noting that their input does not give them the matches they expected. It's more of a critique of the whole "list of styles" design, admittedly.
bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.Received: (at 22324) by debbugs.gnu.org; 28 Jan 2022 21:23:36 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 28 16:23:36 2022 Received: from localhost ([127.0.0.1]:60622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1nDYiW-0001IV-GD for submit <at> debbugs.gnu.org; Fri, 28 Jan 2022 16:23:36 -0500 Received: from mail-wr1-f49.google.com ([209.85.221.49]:38501) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <raaahh@HIDDEN>) id 1nDYiU-0001IJ-K1 for 22324 <at> debbugs.gnu.org; Fri, 28 Jan 2022 16:23:34 -0500 Received: by mail-wr1-f49.google.com with SMTP id c23so13241462wrb.5 for <22324 <at> debbugs.gnu.org>; Fri, 28 Jan 2022 13:23:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4DtBvW+gDVnqinQqLNXN1hIWqVz85KL8jMrsSeh+EJA=; b=qPpjLxdQ+fMUtGZXVY73TSdqgcq1PTWYXFETmdp61dlw85VCaJcXsU5nOEf52Jvg// 8HolkZiacUM/c8bm58zNr7II7ICp/J81FQyiL6CSb790AoiD+P8sWHym5R7wx0zX8YcD gqjkzOPMQ8+LorTEyN7hJ1FcVRoup43689Kgajp0mni4TVD4zzk3pj/g7aHH8lUwTfDn hvR3i8rhJFot1l0SRNqjkoGxdZuP5dLDcYVnUPkRT2DCrdQF+TLM7Lkn6uHVFIcdOtEV IreFoiDBu0OxMIEIWrsQqv+686m8V5ZNHgpJ2ZCCnQ/w3wUL5M/3cgGgEyMfLGyqiJYT MT5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4DtBvW+gDVnqinQqLNXN1hIWqVz85KL8jMrsSeh+EJA=; b=0V0UxHAtelcNLtLoFGOqrYRhLPxjLSkH4q+DK0j+IlS9PqML9a+9/6jIk6vHsEnY2y jx9J3whdQOlViYFCJxXNOoJesZ7v9NPHx6G+bv+25xjkse8/ILMqDJh08fmzROlfYJuB trKVPas3+KMDJPwOXuK/UaDEBwwf6oR9DjWK3V/EFDuzDms9Cxv805hfQnV5wA49x1uL SjYg6DQ3dS0NmZbmp/6bezGe55Dl//F1YOQkkZFKywFtZ9D4uBWfzkC6xnlUoBOtKNqQ buDLmFakD+TkdSstXpyag/t06mkxhusT0dnyhgXdLe+1TDYYyJr3Ci/7q0JIZb3RPWH1 qOfQ== X-Gm-Message-State: AOAM533CJg3YvOG8hGdlzRWSlWe+DUQ/5hUTIl2pgFiqVoFbh0xpqWhj Ldo5uRq8ahmH+TiEp4iruRr6Trl3b3o= X-Google-Smtp-Source: ABdhPJzGfwoLUtOFTVHU7MhpVA8i8+SdcYZ2BpNfrP4oiiMAbwJB8etNldX8w1OWXw9EaIZ43wgf2A== X-Received: by 2002:adf:dcc4:: with SMTP id x4mr8660839wrm.676.1643405008625; Fri, 28 Jan 2022 13:23:28 -0800 (PST) Received: from [10.107.115.144] ([185.209.196.174]) by smtp.googlemail.com with ESMTPSA id s17sm5349562wrm.62.2022.01.28.13.23.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jan 2022 13:23:27 -0800 (PST) Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead) To: Stefan Monnier <monnier@HIDDEN> References: <868u41rv84.fsf@HIDDEN> <83fuy8p8oq.fsf@HIDDEN> <568FA9D0.2040609@HIDDEN> <83egdsp88n.fsf@HIDDEN> <568FABFC.3000205@HIDDEN> <87tufr74of.fsf@HIDDEN> <a1f74c9e-0043-9be9-5739-e87e58dd8fa8@HIDDEN> <87lf0yjwpw.fsf@HIDDEN> <ad66bc96-1f85-850b-4952-35bd6749da02@HIDDEN> <87r1aodus0.fsf@HIDDEN> <66aa873d-5f5f-9024-efb6-e6110c27ab3a@HIDDEN> <87ilvy4m94.fsf@HIDDEN> <87czklnqvs.fsf@HIDDEN> <3045ca8b-f5d6-c85e-d170-3fe158fec64e@HIDDEN> <87ilu94gac.fsf@HIDDEN> <43725c9f-1f0a-fb43-82a2-3f284791fdf5@HIDDEN> <875yq8ypmi.fsf@HIDDEN> <a9258e5f-4ee5-61dc-dc94-8ca697ff8a41@HIDDEN> <d3a97207-c944-c941-8a85-dbf59056987f@HIDDEN> <jwvczke8w23.fsf-monnier+emacs@HIDDEN> <f9811638-cc5f-1d2f-b477-410abd69d3a1@HIDDEN> <jwv7daj7q6c.fsf-monnier+emacs@HIDDEN> From: Dmitry Gutov <dgutov@HIDDEN> Message-ID: <1b288d78-912d-b07d-3027-300b7ff10067@HIDDEN> Date: Fri, 28 Jan 2022 23:23:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <jwv7daj7q6c.fsf-monnier+emacs@HIDDEN> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 22324 Cc: Daniel Mendler <mail@HIDDEN>, Lars Ingebrigtsen <larsi@HIDDEN>, 22324 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.6 (-) On 28.01.2022 18:59, Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > Dmitry Gutov [2022-01-28 04:37:36] wrote: >> On 26.01.2022 15:36, Stefan Monnier via Bug reports for GNU Emacs, the Swiss >> army knife of text editors wrote: >>> We can probably have our cake and eat it too by adding a `fail` >>> completion style. Such a style would always take responsibility >>> (i.e. would never return nil to delegate to subsequent styles), but >>> would always return a "useless" value that gives no completions. >> *If* we did end up adding such style, would the default value of >> completion-category-defaults include 'fail' at the end of its every line? > No, since the fallback was chosen specifically for > `completion-category-defaults`, we'd want to keep it for the cases that > are already present at least. Depends on how you look at it: out of 6 entries in there currently, I added two of them, and since I was unaware of the fallback mechanism, it wasn't quite intentional. Even if certain edge cases ended up using the fallback to their benefit. Knowing that now, I would probably rewrite those completion-category-defaults to include all styles that would be tried explicitly (meaning, add 'partial-completion' after 'substring').
bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.
Received: (at 22324) by debbugs.gnu.org; 28 Jan 2022 16:59:26 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 28 11:59:26 2022
Received: from localhost ([127.0.0.1]:60389 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nDUas-0008UG-AZ
for submit <at> debbugs.gnu.org; Fri, 28 Jan 2022 11:59:26 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:63656)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1nDUaq-0008U2-JY
for 22324 <at> debbugs.gnu.org; Fri, 28 Jan 2022 11:59:25 -0500
Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 1D91A805F9;
Fri, 28 Jan 2022 11:59:19 -0500 (EST)
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id BCA79801F2;
Fri, 28 Jan 2022 11:59:17 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1643389157;
bh=CmGYcTZ9DEAleh9PY8M9yGNPHUdE6SH0sZ9bVwgF5n4=;
h=From:To:Cc:Subject:References:Date:In-Reply-To:From;
b=fZL5sjRcwDPvUYECHf8xQJ4ewj3m7iMdVvAqcQyHIyhqq4bO0tUSJMUooTnY/4P3I
OTFWFNKfVL3wKzLo6Bn6fHEfP9asTQH35WBG011A6A3V0U+WjR/IVDnu9NyvAcAH64
G2IdZ0KgRCfEyIh0TVrv8v+1G6h0vKsGuOe6SWRMsAUs2IZqO6v23I+tPtAIJD4OMP
9WbFYUWxHm0DM3IpcmTgygt/DfTiS6tNb0kFSBz/PxMRmmkEYTU3IApWPhlCK2OIt3
fQZR+2s/7kHkPLilruTuMQCpIJHzrOkmDNEtSsqucyobLdHIKsmTaMZdq8S34jydq/
CXlt1nMNtLdJw==
Received: from ceviche (76-10-138-212.dsl.teksavvy.com [76.10.138.212])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 896511206B6;
Fri, 28 Jan 2022 11:59:17 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
To: Dmitry Gutov <dgutov@HIDDEN>
Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't
override completion-styles (gets prepended instead)
Message-ID: <jwv7daj7q6c.fsf-monnier+emacs@HIDDEN>
References: <868u41rv84.fsf@HIDDEN> <83fuy8p8oq.fsf@HIDDEN>
<568FA9D0.2040609@HIDDEN> <83egdsp88n.fsf@HIDDEN>
<568FABFC.3000205@HIDDEN> <87tufr74of.fsf@HIDDEN>
<a1f74c9e-0043-9be9-5739-e87e58dd8fa8@HIDDEN>
<87lf0yjwpw.fsf@HIDDEN>
<ad66bc96-1f85-850b-4952-35bd6749da02@HIDDEN>
<87r1aodus0.fsf@HIDDEN>
<66aa873d-5f5f-9024-efb6-e6110c27ab3a@HIDDEN>
<87ilvy4m94.fsf@HIDDEN> <87czklnqvs.fsf@HIDDEN>
<3045ca8b-f5d6-c85e-d170-3fe158fec64e@HIDDEN>
<87ilu94gac.fsf@HIDDEN>
<43725c9f-1f0a-fb43-82a2-3f284791fdf5@HIDDEN>
<875yq8ypmi.fsf@HIDDEN>
<a9258e5f-4ee5-61dc-dc94-8ca697ff8a41@HIDDEN>
<d3a97207-c944-c941-8a85-dbf59056987f@HIDDEN>
<jwvczke8w23.fsf-monnier+emacs@HIDDEN>
<f9811638-cc5f-1d2f-b477-410abd69d3a1@HIDDEN>
Date: Fri, 28 Jan 2022 11:59:14 -0500
In-Reply-To: <f9811638-cc5f-1d2f-b477-410abd69d3a1@HIDDEN> (Dmitry Gutov's
message of "Fri, 28 Jan 2022 04:37:36 +0200")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -0.028 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain T_SCC_BODY_TEXT_LINE -0.01 -
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 22324
Cc: Daniel Mendler <mail@HIDDEN>, Lars Ingebrigtsen <larsi@HIDDEN>,
22324 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Dmitry Gutov [2022-01-28 04:37:36] wrote:
> On 26.01.2022 15:36, Stefan Monnier via Bug reports for GNU Emacs, the Swiss
> army knife of text editors wrote:
>> We can probably have our cake and eat it too by adding a `fail`
>> completion style. Such a style would always take responsibility
>> (i.e. would never return nil to delegate to subsequent styles), but
>> would always return a "useless" value that gives no completions.
> *If* we did end up adding such style, would the default value of
> completion-category-defaults include 'fail' at the end of its every line?
No, since the fallback was chosen specifically for
`completion-category-defaults`, we'd want to keep it for the cases that
are already present at least.
Stefan
bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.
Received: (at 22324) by debbugs.gnu.org; 28 Jan 2022 16:57:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 28 11:57:15 2022
Received: from localhost ([127.0.0.1]:60384 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nDUYk-0008Qm-VH
for submit <at> debbugs.gnu.org; Fri, 28 Jan 2022 11:57:15 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:51400)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1nDUYj-0008QW-A0
for 22324 <at> debbugs.gnu.org; Fri, 28 Jan 2022 11:57:14 -0500
Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E5CBA805B1;
Fri, 28 Jan 2022 11:57:06 -0500 (EST)
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 97A02801F2;
Fri, 28 Jan 2022 11:57:05 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1643389025;
bh=CppRYlKy4Vpu+5CgI1mPTRbnmEZuodaWFJcI4Rea/dA=;
h=From:To:Cc:Subject:References:Date:In-Reply-To:From;
b=CglxEr6VfwFXlIEL7kk7A8bB5v6S1D0LJ0lmeRh5qvzvj5cC1RHiHbnO3cwjtFJq8
U7Yt+OM1Vj3zL8r2kivDyO3Ed9E5QqYhGX6ti1IMqZt4aidY21ur3enygBt/+yBF+L
HrWxT7YDMx8LLQNqePCMEdLRJItH3UQDxB3ivm82f1zWZnk/FO2YmT3rwkedZkJxmN
0+9TMt0WUSJtjO01qB9KhieZgnzzDxMDlHGc7KtFyDZzVuliX7lVsfMe+IMs4+mWc2
VswzRhphcUjuw2c3MSGRxKWVn2Jo7GoO7Ufe3VeQYGGH0n+9E9ZNaOwJNNqalLvmbA
Hc1gNfxzT86gg==
Received: from ceviche (76-10-138-212.dsl.teksavvy.com [76.10.138.212])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 62C4A12033B;
Fri, 28 Jan 2022 11:57:05 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
To: Dmitry Gutov <dgutov@HIDDEN>
Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't
override completion-styles (gets prepended instead)
Message-ID: <jwvczkb7qj2.fsf-monnier+emacs@HIDDEN>
References: <868u41rv84.fsf@HIDDEN> <568FABFC.3000205@HIDDEN>
<87tufr74of.fsf@HIDDEN>
<a1f74c9e-0043-9be9-5739-e87e58dd8fa8@HIDDEN>
<87lf0yjwpw.fsf@HIDDEN>
<ad66bc96-1f85-850b-4952-35bd6749da02@HIDDEN>
<87r1aodus0.fsf@HIDDEN>
<66aa873d-5f5f-9024-efb6-e6110c27ab3a@HIDDEN>
<87ilvy4m94.fsf@HIDDEN> <87czklnqvs.fsf@HIDDEN>
<3045ca8b-f5d6-c85e-d170-3fe158fec64e@HIDDEN>
<87ilu94gac.fsf@HIDDEN>
<43725c9f-1f0a-fb43-82a2-3f284791fdf5@HIDDEN>
<875yq8ypmi.fsf@HIDDEN>
<a9258e5f-4ee5-61dc-dc94-8ca697ff8a41@HIDDEN>
<d3a97207-c944-c941-8a85-dbf59056987f@HIDDEN>
<jwvczke8w23.fsf-monnier+emacs@HIDDEN>
<184dffab-4fa4-e265-c8ef-0c088149b1b4@HIDDEN>
<jwvee4ue8na.fsf-monnier+emacs@HIDDEN>
<bc1f89d4-fec9-a178-0e2b-d70c3c8e957e@HIDDEN>
<2115dbe9-fc14-e21c-5a04-1a1c0c85ceef@HIDDEN>
Date: Fri, 28 Jan 2022 11:56:58 -0500
In-Reply-To: <2115dbe9-fc14-e21c-5a04-1a1c0c85ceef@HIDDEN> (Dmitry Gutov's
message of "Fri, 28 Jan 2022 04:35:13 +0200")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -0.028 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain T_SCC_BODY_TEXT_LINE -0.01 -
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 22324
Cc: Daniel Mendler <mail@HIDDEN>, Lars Ingebrigtsen <larsi@HIDDEN>,
22324 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> If we were designing it from the ground up, we probably wouldn't add an
> 'ignore' style. We could have added a special value like 't' which would
> mean the opposite (*do* the fallback, for those users who would want their
> configs to be just a little bit more terse),
FWIW, the choice of using a fallback to `completion-style` was made for
`completion-category-defaults` so that those package-choices don't
unilaterally override the user's choice in `completion-style`.
For `completion-category-override` there is indeed not much need for
a fallback, since it's set by the same person as `completion-style`.
Stefan
bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.Received: (at 22324) by debbugs.gnu.org; 28 Jan 2022 11:54:50 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 28 06:54:50 2022 Received: from localhost ([127.0.0.1]:57647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1nDPq6-0006Ic-E9 for submit <at> debbugs.gnu.org; Fri, 28 Jan 2022 06:54:50 -0500 Received: from server.qxqx.de ([178.63.65.180]:34473 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mail@HIDDEN>) id 1nDPq4-0006IJ-1q for 22324 <at> debbugs.gnu.org; Fri, 28 Jan 2022 06:54:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Va5HaylmAHC1pg0l2KG5RJrsZeOLd9boffpEsghQaDE=; b=oMAngLcMBk6EIR1fhMT6hjsEqO kDTv+8TSAuReV2grIEoGtnh7ljdSnhjfGC0pg7SdjqAgNg/YaAHsD9/JiGpeuTwLo60RyBTuuXfDh vrttF+3SbceaYstLnEkJM51pvqEzjtIGd/HgdwReprp81WqOiY2RIBBv4fDVgwymAvK8=; Message-ID: <b01def17-0504-f9c7-16d6-57639602970a@HIDDEN> Date: Fri, 28 Jan 2022 12:54:39 +0100 MIME-Version: 1.0 Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead) Content-Language: en-US To: Dmitry Gutov <dgutov@HIDDEN>, Stefan Monnier <monnier@HIDDEN> References: <868u41rv84.fsf@HIDDEN> <83fuy8p8oq.fsf@HIDDEN> <568FA9D0.2040609@HIDDEN> <83egdsp88n.fsf@HIDDEN> <568FABFC.3000205@HIDDEN> <87tufr74of.fsf@HIDDEN> <a1f74c9e-0043-9be9-5739-e87e58dd8fa8@HIDDEN> <87lf0yjwpw.fsf@HIDDEN> <ad66bc96-1f85-850b-4952-35bd6749da02@HIDDEN> <87r1aodus0.fsf@HIDDEN> <66aa873d-5f5f-9024-efb6-e6110c27ab3a@HIDDEN> <87ilvy4m94.fsf@HIDDEN> <87czklnqvs.fsf@HIDDEN> <3045ca8b-f5d6-c85e-d170-3fe158fec64e@HIDDEN> <87ilu94gac.fsf@HIDDEN> <43725c9f-1f0a-fb43-82a2-3f284791fdf5@HIDDEN> <875yq8ypmi.fsf@HIDDEN> <a9258e5f-4ee5-61dc-dc94-8ca697ff8a41@HIDDEN> <d3a97207-c944-c941-8a85-dbf59056987f@HIDDEN> <jwvczke8w23.fsf-monnier+emacs@HIDDEN> <184dffab-4fa4-e265-c8ef-0c088149b1b4@HIDDEN> <jwvee4ue8na.fsf-monnier+emacs@HIDDEN> <bc1f89d4-fec9-a178-0e2b-d70c3c8e957e@HIDDEN> <2115dbe9-fc14-e21c-5a04-1a1c0c85ceef@HIDDEN> From: Daniel Mendler <mail@HIDDEN> In-Reply-To: <2115dbe9-fc14-e21c-5a04-1a1c0c85ceef@HIDDEN> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 22324 Cc: Lars Ingebrigtsen <larsi@HIDDEN>, 22324 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) On 1/28/22 03:35, Dmitry Gutov wrote: > Let's remove it, I think. > > IMHO, backward compatibility hacks are the reason of >50% of existing > CAPF's problems: you add one special case, then another, then another. > > Each step isn't bad by itself (just like Stefan's current suggestion > sounds workable), but every one of them complicates reading the code, > and writing code to it, even if by a little. > > If we were designing it from the ground up, we probably wouldn't add an > 'ignore' style. We could have added a special value like 't' which would > mean the opposite (*do* the fallback, for those users who would want > their configs to be just a little bit more terse), just like in the > local values of hook variables. But I'm not sure how kludgy the > implementation of this will turn out either, and terseness is not the > primary end goal for this part of user customization, I think. I agree with you. Removing the fail over seems better in the long term. For the users of Orderless and other custom documentation styles etc, we can document that the fail over mechanism has been removed and provide an advice in the documentation, which can be used to upgrade the behavior. The user base of Orderless etc is dynamic as you point out, so they will adapt to changes. If we assume that these users make up the majority of users who make use of the fail over, this should not be a blocker for this minor breaking change. Furthermore I've got multiple reports where people wondered about the failover, so the current behavior is more confusing than having no failover. Using `t` as last element to trigger fail over seems like a good idea. Daniel
bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.Received: (at 22324) by debbugs.gnu.org; 28 Jan 2022 02:39:31 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 27 21:39:31 2022 Received: from localhost ([127.0.0.1]:57067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1nDHAh-0000gP-Ap for submit <at> debbugs.gnu.org; Thu, 27 Jan 2022 21:39:31 -0500 Received: from mail-wr1-f46.google.com ([209.85.221.46]:36586) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <raaahh@HIDDEN>) id 1nDHAf-0000gD-LG for 22324 <at> debbugs.gnu.org; Thu, 27 Jan 2022 21:39:29 -0500 Received: by mail-wr1-f46.google.com with SMTP id u15so8163841wrt.3 for <22324 <at> debbugs.gnu.org>; Thu, 27 Jan 2022 18:39:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3MseSz5ZHslByvYXmWwTkhLzISw6Dyt0LM1ZNr8sOaY=; b=TynWd6X7n/8mwswkvVVfFRRMp16Gg+Cu3djErBoI1kNHm9QUA4zaRflfiw+leXpdee y4RGBUYdU83YjIF0Fn/vmLpTW5zrk2N1rcwKjrSrEMSGFpyG8rOl2Tr+DONLc/Og/WOj EePnJKL+W652/v+T8jmjkGDve5SpC/T1hXHzV2Avdc0zKqUrK45e1JA86dTVya9A7Hxa 4Q3/t8bU6HuQpGeUX1oD/7XiIomWjOgTa9bxdUuxr8PaY4tZzc2OKBUzVWmXp97tthNz efLQOHuU8eSX4KOJ8YLx20etn6aE7uv/VOVqxEHuXkI3siUjeH/Hp447sKhutC9mahuU pgjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3MseSz5ZHslByvYXmWwTkhLzISw6Dyt0LM1ZNr8sOaY=; b=XThvXVk/+ct54JO5hWawnZwG8JGlvAc5fETV2Z/EV36piL34FjeLgaw3vOPEqsjoJT asoVqNIZNIharOt3WDFyKc7ZDXizhjvho4JBauqr9qv3jKErVcv0dpoiXto9sb/LH1NT pBr8a4gEIxtpS86mwu3OmNTWDzBGvqRrmKkkRRW2zPvhyb3tZbJA2am59NWBQhTKnMyY QycLkovBAnbxLHshJM3KCZt1tYf0s9rAdZuEnKSEIKgPWalg6sYW52NbzLXf/PG9V3UE L1nmSiJ8YMz3hOuUy+EaFtzr9+Azc9+umNxzHYfWEu8uocPVMVB4j5DXiN9ZWMq5tOdl a88g== X-Gm-Message-State: AOAM532ZD0BSlWrbwceET/x2eqXYms7xgLos/Ovt0CiQcMwU5Zojk2d1 ZkWdm/xjJc9MD4K28RtHYnn1gxmjzFE= X-Google-Smtp-Source: ABdhPJypT8cegW44PfKsfzPwO8QXkNZve3kx26W+xJddStL6B6MJR780ms3D38NFnNQoFqUhJ5v6Bw== X-Received: by 2002:a05:6000:108d:: with SMTP id y13mr5084255wrw.515.1643337564017; Thu, 27 Jan 2022 18:39:24 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id n14sm3721324wri.75.2022.01.27.18.39.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Jan 2022 18:39:23 -0800 (PST) Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead) To: Daniel Mendler <mail@HIDDEN>, Lars Ingebrigtsen <larsi@HIDDEN> References: <868u41rv84.fsf@HIDDEN> <83fuy8p8oq.fsf@HIDDEN> <568FA9D0.2040609@HIDDEN> <83egdsp88n.fsf@HIDDEN> <568FABFC.3000205@HIDDEN> <87tufr74of.fsf@HIDDEN> <a1f74c9e-0043-9be9-5739-e87e58dd8fa8@HIDDEN> <87lf0yjwpw.fsf@HIDDEN> <ad66bc96-1f85-850b-4952-35bd6749da02@HIDDEN> <87r1aodus0.fsf@HIDDEN> <66aa873d-5f5f-9024-efb6-e6110c27ab3a@HIDDEN> <87ilvy4m94.fsf@HIDDEN> <87czklnqvs.fsf@HIDDEN> <3045ca8b-f5d6-c85e-d170-3fe158fec64e@HIDDEN> <87ilu94gac.fsf@HIDDEN> <43725c9f-1f0a-fb43-82a2-3f284791fdf5@HIDDEN> <875yq8ypmi.fsf@HIDDEN> <a9258e5f-4ee5-61dc-dc94-8ca697ff8a41@HIDDEN> <d3a97207-c944-c941-8a85-dbf59056987f@HIDDEN> From: Dmitry Gutov <dgutov@HIDDEN> Message-ID: <11d31a0a-b3d9-9255-e35d-bfda69acdcc6@HIDDEN> Date: Fri, 28 Jan 2022 04:39:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <d3a97207-c944-c941-8a85-dbf59056987f@HIDDEN> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 22324 Cc: Stefan Monnier <monnier@HIDDEN>, 22324 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.6 (-) On 26.01.2022 04:31, Daniel Mendler wrote: > One final statement regarding making a breaking change here: You should > consider that the packages orderless etc are fairly new and still have > breaking changes from time to time, so even if these configurations are > widespread or see growing adoption, this should not hold you back from > making a breaking change. I will then promptly adapt the documentation > of these projects and add a warning note, which will soon propagate to > the users who use Emacs master, which is still young in the development > cycle. Of course my statement applies only if the aforementioned are > truly the only widespread packages affected by this. Yeah, I think the current userbase of Orderless should be pretty dynamic, not too set in their ways. So they should be up for checking out new versions and documentation changes and adapting to them.
bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.Received: (at 22324) by debbugs.gnu.org; 28 Jan 2022 02:37:44 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 27 21:37:44 2022 Received: from localhost ([127.0.0.1]:57050 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1nDH8y-0000cd-Em for submit <at> debbugs.gnu.org; Thu, 27 Jan 2022 21:37:44 -0500 Received: from mail-wr1-f54.google.com ([209.85.221.54]:47007) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <raaahh@HIDDEN>) id 1nDH8x-0000cO-CM for 22324 <at> debbugs.gnu.org; Thu, 27 Jan 2022 21:37:43 -0500 Received: by mail-wr1-f54.google.com with SMTP id l25so8071538wrb.13 for <22324 <at> debbugs.gnu.org>; Thu, 27 Jan 2022 18:37:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7tlum3VlSl0t+s4HR25updT2e3igznYowYGrBlnDxOo=; b=UyXqt6UHlOe1FeWxc3cCQJUa0OqP1MU46x/jY5AbHJDIKFbWwSlbdocA+YKggEBC3c 8CqiMAMmSVsSfo1p6JZEs7EPggZPRVrjgqUYhO0q/og5Dv3SaGioPwzIHp2qFow9qx8J YOGlNRwi4jYlUGeKYIkpZotEF1tjJjMaqhlax+x7D0QpUN2HNTs0HUl06odMGa6tbDJ/ F7i2JhNXZCVL/10k4ZWfXW3mxl3hRK21b7r76YB37qWAlJ4Z/waDa5DS4Ss/pA6ub5T6 dxOKVu2UBj1vDinmaccpxdK6/5F6V9UAM4UvZdhEJ8I2h3YblGBdUdAHyYwTvcZn3auC m6hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7tlum3VlSl0t+s4HR25updT2e3igznYowYGrBlnDxOo=; b=jAm6nAThmbrduMommRNCt8JXOMP4zQAWpLb2KV31R5lmOULMZpTBCtTZiKRPDAsGfS tKGkVa+5dyjVcniZNsL9KSo/bbqYG7H/FgNzySIMBpXub8r3T9TXEOjQeixNILz9LB0U /TcpSwR3c9K1bIdazJfK3865s9AvcHk1yC8k7zFo6aKeEB5WwNE4n42smIoy058bMOL/ P6RJW153LRGoDJxPtwsUfW+n/1nYyEVClXCuRRRPvPnkHUaf2evwU3IyBqloK3v3jiEQ M5LOywH4gyuvbu8jqSkYZds7zmsCPgZeLjeP72yWAudy7zaqI9HSKqV49A8K98BNoUOp BenQ== X-Gm-Message-State: AOAM532zRunShLrRGWXwfd6ts1+deJ+0Z4kvupjsZaQ3PjOvm44FBWW+ ZjiRjtqjUBhy1JHESGT0QYzMZA5P/eo= X-Google-Smtp-Source: ABdhPJzUiEk+R/RpgN10uj3fm+GPNtIBBZi1QSCczMzR710RF97LkP4lBgv/i4+BC9ZvF150QpSutA== X-Received: by 2002:a5d:47a9:: with SMTP id 9mr5276114wrb.108.1643337457755; Thu, 27 Jan 2022 18:37:37 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id m5sm804083wms.4.2022.01.27.18.37.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Jan 2022 18:37:37 -0800 (PST) Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead) To: Stefan Monnier <monnier@HIDDEN>, Daniel Mendler <mail@HIDDEN> References: <868u41rv84.fsf@HIDDEN> <83fuy8p8oq.fsf@HIDDEN> <568FA9D0.2040609@HIDDEN> <83egdsp88n.fsf@HIDDEN> <568FABFC.3000205@HIDDEN> <87tufr74of.fsf@HIDDEN> <a1f74c9e-0043-9be9-5739-e87e58dd8fa8@HIDDEN> <87lf0yjwpw.fsf@HIDDEN> <ad66bc96-1f85-850b-4952-35bd6749da02@HIDDEN> <87r1aodus0.fsf@HIDDEN> <66aa873d-5f5f-9024-efb6-e6110c27ab3a@HIDDEN> <87ilvy4m94.fsf@HIDDEN> <87czklnqvs.fsf@HIDDEN> <3045ca8b-f5d6-c85e-d170-3fe158fec64e@HIDDEN> <87ilu94gac.fsf@HIDDEN> <43725c9f-1f0a-fb43-82a2-3f284791fdf5@HIDDEN> <875yq8ypmi.fsf@HIDDEN> <a9258e5f-4ee5-61dc-dc94-8ca697ff8a41@HIDDEN> <d3a97207-c944-c941-8a85-dbf59056987f@HIDDEN> <jwvczke8w23.fsf-monnier+emacs@HIDDEN> From: Dmitry Gutov <dgutov@HIDDEN> Message-ID: <f9811638-cc5f-1d2f-b477-410abd69d3a1@HIDDEN> Date: Fri, 28 Jan 2022 04:37:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <jwvczke8w23.fsf-monnier+emacs@HIDDEN> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 22324 Cc: Lars Ingebrigtsen <larsi@HIDDEN>, 22324 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.6 (-) On 26.01.2022 15:36, Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > We can probably have our cake and eat it too by adding a `fail` > completion style. Such a style would always take responsibility > (i.e. would never return nil to delegate to subsequent styles), but > would always return a "useless" value that gives no completions. *If* we did end up adding such style, would the default value of completion-category-defaults include 'fail' at the end of its every line?
bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.Received: (at 22324) by debbugs.gnu.org; 28 Jan 2022 02:35:26 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 27 21:35:26 2022 Received: from localhost ([127.0.0.1]:57046 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1nDH6k-0000Z7-1G for submit <at> debbugs.gnu.org; Thu, 27 Jan 2022 21:35:26 -0500 Received: from mail-wr1-f53.google.com ([209.85.221.53]:38456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <raaahh@HIDDEN>) id 1nDH6g-0000Yr-3m for 22324 <at> debbugs.gnu.org; Thu, 27 Jan 2022 21:35:24 -0500 Received: by mail-wr1-f53.google.com with SMTP id c23so8146888wrb.5 for <22324 <at> debbugs.gnu.org>; Thu, 27 Jan 2022 18:35:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=vpiUV8ip12hWhLA6lDE7Ivoyb0z+/eQ/vjG2bOX16Bw=; b=SxLPI9XiS5wwVl0FJinsFzatk6OgifdLRpiEbjt5OelCHt9WiXb9oPlFflADx+mqWR f3RoIKo8sK1O+EiuSeiOw1kr61WVmkZ3Slur9L8pawlG+06cQVhunk+CDthgQHqIEOnZ hUBoy882yTBa6poS+ydgSgHQnsfmAnp515iCDsh1tqAQh2rwnxpR/dAvlNiRaSnHR5aB Swnn4a/zUPysfc5K6o6/3jSVj779j3vqDmfJRpyHcRvho5/joyGxwwVQ+qC0q1o+2C48 1QRXThDQPHyG/Bvbf1aToaXZetn/xoZ41X+jEUoYZFDd2SjZ+3E+D/TIXkGg1TtXKGhr r1SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vpiUV8ip12hWhLA6lDE7Ivoyb0z+/eQ/vjG2bOX16Bw=; b=JMi6A/GkvK7FqdsMdgmbgXHy8vPnsyiUXj3QfhLwQOvmhXPapu1m2zpOXKZBkb/nRT Rw5d/1FsaNN2AtSCy64SYIsEP83Gc8ikMy9CBpJJtfQQRLqFSHLNhGvIOFWp+8HocyEE yo3otpKp8BoYBMfRpllOPnOaziAMWrRFWdjw2T4vgarVEAaXgHhsx1ZH1DsB9YDZ707T O4GlMSgU835QhwVg2pgEAkEWTXD4z8FB88Ry2a/5KsFM8cnh2KZJBoBhRZSD42fGe0O/ pmYwVdE6sgvMemvMa4NkuAV0JfinQSQudgMRu7B3FreNRAg4c9Qg/Y/wD4ypadsib9r3 vdEQ== X-Gm-Message-State: AOAM532iIdtJkxBzLMAXmD9EE08+TUovaVKdZSPO60x16+A1BpqHKoEa 1rbUVF08qygHwN+/boMy6y+Eb922ZKE= X-Google-Smtp-Source: ABdhPJzopIXxgAGPVh0QgzfqiJUGRrgAri6lXa4hDtL65CEFGMLj/8Q5+VAfGWg8RdVRFGtjeef4tg== X-Received: by 2002:a05:6000:1862:: with SMTP id d2mr5358555wri.382.1643337316092; Thu, 27 Jan 2022 18:35:16 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id l29sm11362611wms.1.2022.01.27.18.35.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Jan 2022 18:35:15 -0800 (PST) Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead) To: Daniel Mendler <mail@HIDDEN>, Stefan Monnier <monnier@HIDDEN> References: <868u41rv84.fsf@HIDDEN> <83fuy8p8oq.fsf@HIDDEN> <568FA9D0.2040609@HIDDEN> <83egdsp88n.fsf@HIDDEN> <568FABFC.3000205@HIDDEN> <87tufr74of.fsf@HIDDEN> <a1f74c9e-0043-9be9-5739-e87e58dd8fa8@HIDDEN> <87lf0yjwpw.fsf@HIDDEN> <ad66bc96-1f85-850b-4952-35bd6749da02@HIDDEN> <87r1aodus0.fsf@HIDDEN> <66aa873d-5f5f-9024-efb6-e6110c27ab3a@HIDDEN> <87ilvy4m94.fsf@HIDDEN> <87czklnqvs.fsf@HIDDEN> <3045ca8b-f5d6-c85e-d170-3fe158fec64e@HIDDEN> <87ilu94gac.fsf@HIDDEN> <43725c9f-1f0a-fb43-82a2-3f284791fdf5@HIDDEN> <875yq8ypmi.fsf@HIDDEN> <a9258e5f-4ee5-61dc-dc94-8ca697ff8a41@HIDDEN> <d3a97207-c944-c941-8a85-dbf59056987f@HIDDEN> <jwvczke8w23.fsf-monnier+emacs@HIDDEN> <184dffab-4fa4-e265-c8ef-0c088149b1b4@HIDDEN> <jwvee4ue8na.fsf-monnier+emacs@HIDDEN> <bc1f89d4-fec9-a178-0e2b-d70c3c8e957e@HIDDEN> From: Dmitry Gutov <dgutov@HIDDEN> Message-ID: <2115dbe9-fc14-e21c-5a04-1a1c0c85ceef@HIDDEN> Date: Fri, 28 Jan 2022 04:35:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <bc1f89d4-fec9-a178-0e2b-d70c3c8e957e@HIDDEN> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 22324 Cc: Lars Ingebrigtsen <larsi@HIDDEN>, 22324 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.6 (-) On 26.01.2022 20:59, Daniel Mendler wrote: > On 1/26/22 18:19, Stefan Monnier wrote: >> No, because `ignore` will return nil and so we'll just keep going to the >> next style. We need try/all-completion functions for this style to >> return a non-nil value but that is like "no completion". >> >> I suspect it can't be done quite right without changing `minibuffer.el`, >> but we can probably get close enough to be tolerable with older Emacsen. >> >> E.g. for the try-completion case, I think we can return (STRING . POINT) >> and for all-completions maybe returning `0` will do the trick. > Okay, right. This makes the proposal a bit less appealing to be honest, > since we end up with a hack, where the result is something like a > non-nil invalid completion result. Hmm. So maybe we shouldn't do this > and fix the problem at the root? Remove the failover mechanism? I am not > fond of introducing a hack to work around the problematic failover design. Let's remove it, I think. IMHO, backward compatibility hacks are the reason of >50% of existing CAPF's problems: you add one special case, then another, then another. Each step isn't bad by itself (just like Stefan's current suggestion sounds workable), but every one of them complicates reading the code, and writing code to it, even if by a little. If we were designing it from the ground up, we probably wouldn't add an 'ignore' style. We could have added a special value like 't' which would mean the opposite (*do* the fallback, for those users who would want their configs to be just a little bit more terse), just like in the local values of hook variables. But I'm not sure how kludgy the implementation of this will turn out either, and terseness is not the primary end goal for this part of user customization, I think.
bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.
Received: (at 22324) by debbugs.gnu.org; 27 Jan 2022 06:52:37 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 27 01:52:36 2022
Received: from localhost ([127.0.0.1]:54116 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nCye4-0004rK-Oo
for submit <at> debbugs.gnu.org; Thu, 27 Jan 2022 01:52:36 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:53430)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1nCye2-0004r6-AE
for 22324 <at> debbugs.gnu.org; Thu, 27 Jan 2022 01:52:35 -0500
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 89009100184;
Thu, 27 Jan 2022 01:52:28 -0500 (EST)
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 5059310000D;
Thu, 27 Jan 2022 01:52:27 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1643266347;
bh=WMch/WFpbEJ7QFHaArhuYbDPBD9mYrfk60pJerg6ThU=;
h=From:To:Cc:Subject:References:Date:In-Reply-To:From;
b=kJKjmMZxi1ZhMIxUXgiphjVafrHWpTG6xDk3uxo/OcSc5nQRYcVOuL+Tq3hPmcdld
ovrQuYJhdihty/A1WY/HCriKa+qif3uuid3qDVeuOKcK5fUBM9vzL/CuMeBE/eVchb
MvrFmRcvGBFujNVuYos1a+vbJD/Y4bxPvIqAZ3XBvZD669vTBCHOkiF8Stk/glZjYs
u0jnB8NrUEX6oWNIk9Xbm6GswxrK2ywVJIRW9cofyvQhueIwavf59z/Tl075pS9ut+
7hX7oxsB51mMaSo8SrLHat8xhwwmAObumS/9IsuudboYpWqowM/s8yVVCFyHpbI2Uo
D7/EhvtoHWHyQ==
Received: from pastel (76-10-138-212.dsl.teksavvy.com [76.10.138.212])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 03E0C1208C5;
Thu, 27 Jan 2022 01:52:26 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
To: Daniel Mendler <mail@HIDDEN>
Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't
override completion-styles (gets prepended instead)
Message-ID: <jwvpmodwu1l.fsf-monnier+emacs@HIDDEN>
References: <868u41rv84.fsf@HIDDEN> <87tufr74of.fsf@HIDDEN>
<a1f74c9e-0043-9be9-5739-e87e58dd8fa8@HIDDEN>
<87lf0yjwpw.fsf@HIDDEN>
<ad66bc96-1f85-850b-4952-35bd6749da02@HIDDEN>
<87r1aodus0.fsf@HIDDEN>
<66aa873d-5f5f-9024-efb6-e6110c27ab3a@HIDDEN>
<87ilvy4m94.fsf@HIDDEN> <87czklnqvs.fsf@HIDDEN>
<3045ca8b-f5d6-c85e-d170-3fe158fec64e@HIDDEN>
<87ilu94gac.fsf@HIDDEN>
<43725c9f-1f0a-fb43-82a2-3f284791fdf5@HIDDEN>
<875yq8ypmi.fsf@HIDDEN>
<a9258e5f-4ee5-61dc-dc94-8ca697ff8a41@HIDDEN>
<d3a97207-c944-c941-8a85-dbf59056987f@HIDDEN>
<jwvczke8w23.fsf-monnier+emacs@HIDDEN>
<184dffab-4fa4-e265-c8ef-0c088149b1b4@HIDDEN>
<jwvee4ue8na.fsf-monnier+emacs@HIDDEN>
<bc1f89d4-fec9-a178-0e2b-d70c3c8e957e@HIDDEN>
<jwvr18u9kkr.fsf-monnier+emacs@HIDDEN>
<d872d6a4-950e-4207-9157-513845127151@HIDDEN>
Date: Thu, 27 Jan 2022 01:52:24 -0500
In-Reply-To: <d872d6a4-950e-4207-9157-513845127151@HIDDEN> (Daniel
Mendler's message of "Thu, 27 Jan 2022 00:32:29 +0100")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -0.009 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 22324
Cc: Lars Ingebrigtsen <larsi@HIDDEN>, 22324 <at> debbugs.gnu.org,
Dmitry Gutov <dgutov@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Daniel Mendler [2022-01-27 00:32:29] wrote:
> On 1/26/22 23:57, Stefan Monnier wrote:
>>> So maybe we shouldn't do this and fix the problem at the root?
>>> Remove the failover mechanism?
>> Not sure how that'll help with Emacs<29 ;-)
> Easy. If advices are allowed as temporary workaround, I will just advise
> `completion--styles` or `completion--category-override` appropriately
> such that the fail over is gone.
But then you can use the same approach to implement proper support for
a new `fail` pseudo-style ;-)
Stefan
bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.Received: (at 22324) by debbugs.gnu.org; 26 Jan 2022 23:32:42 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 26 18:32:41 2022 Received: from localhost ([127.0.0.1]:53771 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1nCrmL-00087C-NR for submit <at> debbugs.gnu.org; Wed, 26 Jan 2022 18:32:41 -0500 Received: from server.qxqx.de ([178.63.65.180]:47871 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mail@HIDDEN>) id 1nCrmI-00086y-Ig for 22324 <at> debbugs.gnu.org; Wed, 26 Jan 2022 18:32:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=JFJaVCZhs6vVrAfEha110AOiSrNrKXzBsWvWaBc2KEs=; b=yXe9YUFxl4nUzlbcdtuBqOHGgH UpDSBXpSdsp9hIW/FbEM0f1t4ZXhwRQBcDzGdpc5QMeEQTPg/jNlBmL+/H7qdbmTk8qioLIfkLLeh IMv5cvCRb13Wm6qAw2A0oB5iHe9s0NNb/6k9WWLnddfGmg8CC49mZRStUlqhKQ6/PwnA=; Message-ID: <d872d6a4-950e-4207-9157-513845127151@HIDDEN> Date: Thu, 27 Jan 2022 00:32:29 +0100 MIME-Version: 1.0 Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead) Content-Language: en-US To: Stefan Monnier <monnier@HIDDEN> References: <868u41rv84.fsf@HIDDEN> <83egdsp88n.fsf@HIDDEN> <568FABFC.3000205@HIDDEN> <87tufr74of.fsf@HIDDEN> <a1f74c9e-0043-9be9-5739-e87e58dd8fa8@HIDDEN> <87lf0yjwpw.fsf@HIDDEN> <ad66bc96-1f85-850b-4952-35bd6749da02@HIDDEN> <87r1aodus0.fsf@HIDDEN> <66aa873d-5f5f-9024-efb6-e6110c27ab3a@HIDDEN> <87ilvy4m94.fsf@HIDDEN> <87czklnqvs.fsf@HIDDEN> <3045ca8b-f5d6-c85e-d170-3fe158fec64e@HIDDEN> <87ilu94gac.fsf@HIDDEN> <43725c9f-1f0a-fb43-82a2-3f284791fdf5@HIDDEN> <875yq8ypmi.fsf@HIDDEN> <a9258e5f-4ee5-61dc-dc94-8ca697ff8a41@HIDDEN> <d3a97207-c944-c941-8a85-dbf59056987f@HIDDEN> <jwvczke8w23.fsf-monnier+emacs@HIDDEN> <184dffab-4fa4-e265-c8ef-0c088149b1b4@HIDDEN> <jwvee4ue8na.fsf-monnier+emacs@HIDDEN> <bc1f89d4-fec9-a178-0e2b-d70c3c8e957e@HIDDEN> <jwvr18u9kkr.fsf-monnier+emacs@HIDDEN> From: Daniel Mendler <mail@HIDDEN> In-Reply-To: <jwvr18u9kkr.fsf-monnier+emacs@HIDDEN> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 22324 Cc: Lars Ingebrigtsen <larsi@HIDDEN>, 22324 <at> debbugs.gnu.org, Dmitry Gutov <dgutov@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) On 1/26/22 23:57, Stefan Monnier wrote: >> So maybe we shouldn't do this and fix the problem at the root? >> Remove the failover mechanism? > > Not sure how that'll help with Emacs<29 ;-) Easy. If advices are allowed as temporary workaround, I will just advise `completion--styles` or `completion--category-override` appropriately such that the fail over is gone. Let's remove the fail over mechanism! :) Daniel
bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.
Received: (at 22324) by debbugs.gnu.org; 26 Jan 2022 22:57:45 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 26 17:57:45 2022
Received: from localhost ([127.0.0.1]:53751 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nCrEW-0007DI-Qo
for submit <at> debbugs.gnu.org; Wed, 26 Jan 2022 17:57:45 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:9127)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1nCrEV-0007D6-6f
for 22324 <at> debbugs.gnu.org; Wed, 26 Jan 2022 17:57:44 -0500
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 083B510018E;
Wed, 26 Jan 2022 17:57:37 -0500 (EST)
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A227A100183;
Wed, 26 Jan 2022 17:57:35 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1643237855;
bh=8txkS2A7pBGXcyrftjrgid6+Gb5eXEqrJ0pv0tZ1FFc=;
h=From:To:Cc:Subject:References:Date:In-Reply-To:From;
b=K2LOWKCRRZRknlJw358Tx+j6fs0zj5ENclsJsETt70pBuVUaspb/tzUKDpLxjWkM6
m5Lab2ILxtB95XNFo4/LLNYDqwc6WaSASCjYS6dAvlyl9Tnd8UjvstbV5Tt2/HZVf3
XyVR8pD49Bm2hnLo2EAmB59LWOtm4u2x/Qmi9U/n3C2NDxBZ6te7+5iEB/UQoGMSeo
YYV1HrI1TNgx96Xa+vqlQXeOVNMR007ztwSFXVcHAc5Hp3iMKSAbI9G3J8GkFPULAS
kdda8jOKOI59QJJ0JS4fPS4TdFQIwKV13+W13M49T45VW2cqD1aE3EqU6xkT66anxt
dImQP25j6fq4g==
Received: from alfajor (lechon.iro.umontreal.ca [132.204.27.242])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7CD1012089E;
Wed, 26 Jan 2022 17:57:35 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
To: Daniel Mendler <mail@HIDDEN>
Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't
override completion-styles (gets prepended instead)
Message-ID: <jwvr18u9kkr.fsf-monnier+emacs@HIDDEN>
References: <868u41rv84.fsf@HIDDEN> <83egdsp88n.fsf@HIDDEN>
<568FABFC.3000205@HIDDEN> <87tufr74of.fsf@HIDDEN>
<a1f74c9e-0043-9be9-5739-e87e58dd8fa8@HIDDEN>
<87lf0yjwpw.fsf@HIDDEN>
<ad66bc96-1f85-850b-4952-35bd6749da02@HIDDEN>
<87r1aodus0.fsf@HIDDEN>
<66aa873d-5f5f-9024-efb6-e6110c27ab3a@HIDDEN>
<87ilvy4m94.fsf@HIDDEN> <87czklnqvs.fsf@HIDDEN>
<3045ca8b-f5d6-c85e-d170-3fe158fec64e@HIDDEN>
<87ilu94gac.fsf@HIDDEN>
<43725c9f-1f0a-fb43-82a2-3f284791fdf5@HIDDEN>
<875yq8ypmi.fsf@HIDDEN>
<a9258e5f-4ee5-61dc-dc94-8ca697ff8a41@HIDDEN>
<d3a97207-c944-c941-8a85-dbf59056987f@HIDDEN>
<jwvczke8w23.fsf-monnier+emacs@HIDDEN>
<184dffab-4fa4-e265-c8ef-0c088149b1b4@HIDDEN>
<jwvee4ue8na.fsf-monnier+emacs@HIDDEN>
<bc1f89d4-fec9-a178-0e2b-d70c3c8e957e@HIDDEN>
Date: Wed, 26 Jan 2022 17:57:33 -0500
In-Reply-To: <bc1f89d4-fec9-a178-0e2b-d70c3c8e957e@HIDDEN> (Daniel
Mendler's message of "Wed, 26 Jan 2022 19:59:49 +0100")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL 0.151 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 22324
Cc: Lars Ingebrigtsen <larsi@HIDDEN>, 22324 <at> debbugs.gnu.org,
Dmitry Gutov <dgutov@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
>> No, because `ignore` will return nil and so we'll just keep going to the
>> next style. We need try/all-completion functions for this style to
>> return a non-nil value but that is like "no completion".
>>
>> I suspect it can't be done quite right without changing `minibuffer.el`,
>> but we can probably get close enough to be tolerable with older Emacsen.
>>
>> E.g. for the try-completion case, I think we can return (STRING . POINT)
>> and for all-completions maybe returning `0` will do the trick.
>
> Okay, right. This makes the proposal a bit less appealing to be honest,
> since we end up with a hack, where the result is something like a
> non-nil invalid completion result. Hmm.
I think it should be easy enough to make the various UIs handle it (in
the worst case, add an advice to `completion-try-completion` and
`completion-all-completions`).
Of course it's a hack, but only one needed during the transition.
Like my gym coach used to say when we had an injury: you won't remember
it in 10 years.
> So maybe we shouldn't do this and fix the problem at the root?
> Remove the failover mechanism?
Not sure how that'll help with Emacs<29 ;-)
> My cheap proposal would be the removal of `completion-category-defaults`
> and the removal of the failover mechanism of
> `completion-category-overrides`. Then the user can adjust the
> `completion-styles` entirely in their configuration.
The purpose of `completion-category-defaults` is to improve the OOTB
behavior for those who don't customize very much.
Those who do customize heavily can easily set it to nil or override it
with `completion-category-overrides`.
Stefan
bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.Received: (at 22324) by debbugs.gnu.org; 26 Jan 2022 19:00:01 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 26 14:00:01 2022 Received: from localhost ([127.0.0.1]:53541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1nCnWT-000146-5r for submit <at> debbugs.gnu.org; Wed, 26 Jan 2022 14:00:01 -0500 Received: from server.qxqx.de ([178.63.65.180]:58139 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mail@HIDDEN>) id 1nCnWQ-00013t-S3 for 22324 <at> debbugs.gnu.org; Wed, 26 Jan 2022 13:59:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1DGYFsHR645NF8FFXYJG3jtRXdUd3WeIJ+/tQRJ4OT0=; b=PUy+GLTBHX7C8PyYI3MmO8gL/q F70WruWpqGkGuAZTwG9jMd124DSG/zj4frR29Pegmn3TwcwV4ZzAQNJKNpufFNGT9AcedNz5TEXc6 drIlxiWhAO2y5qJb69U7Scoo8IuzOnVmd4sHvpxs1UNZYy/uIzFywqCDti/xAdtb/UDA=; Message-ID: <bc1f89d4-fec9-a178-0e2b-d70c3c8e957e@HIDDEN> Date: Wed, 26 Jan 2022 19:59:49 +0100 MIME-Version: 1.0 Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead) Content-Language: en-US To: Stefan Monnier <monnier@HIDDEN> References: <868u41rv84.fsf@HIDDEN> <83fuy8p8oq.fsf@HIDDEN> <568FA9D0.2040609@HIDDEN> <83egdsp88n.fsf@HIDDEN> <568FABFC.3000205@HIDDEN> <87tufr74of.fsf@HIDDEN> <a1f74c9e-0043-9be9-5739-e87e58dd8fa8@HIDDEN> <87lf0yjwpw.fsf@HIDDEN> <ad66bc96-1f85-850b-4952-35bd6749da02@HIDDEN> <87r1aodus0.fsf@HIDDEN> <66aa873d-5f5f-9024-efb6-e6110c27ab3a@HIDDEN> <87ilvy4m94.fsf@HIDDEN> <87czklnqvs.fsf@HIDDEN> <3045ca8b-f5d6-c85e-d170-3fe158fec64e@HIDDEN> <87ilu94gac.fsf@HIDDEN> <43725c9f-1f0a-fb43-82a2-3f284791fdf5@HIDDEN> <875yq8ypmi.fsf@HIDDEN> <a9258e5f-4ee5-61dc-dc94-8ca697ff8a41@HIDDEN> <d3a97207-c944-c941-8a85-dbf59056987f@HIDDEN> <jwvczke8w23.fsf-monnier+emacs@HIDDEN> <184dffab-4fa4-e265-c8ef-0c088149b1b4@HIDDEN> <jwvee4ue8na.fsf-monnier+emacs@HIDDEN> From: Daniel Mendler <mail@HIDDEN> In-Reply-To: <jwvee4ue8na.fsf-monnier+emacs@HIDDEN> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 22324 Cc: Lars Ingebrigtsen <larsi@HIDDEN>, 22324 <at> debbugs.gnu.org, Dmitry Gutov <dgutov@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) On 1/26/22 18:19, Stefan Monnier wrote: > No, because `ignore` will return nil and so we'll just keep going to the > next style. We need try/all-completion functions for this style to > return a non-nil value but that is like "no completion". > > I suspect it can't be done quite right without changing `minibuffer.el`, > but we can probably get close enough to be tolerable with older Emacsen. > > E.g. for the try-completion case, I think we can return (STRING . POINT) > and for all-completions maybe returning `0` will do the trick. Okay, right. This makes the proposal a bit less appealing to be honest, since we end up with a hack, where the result is something like a non-nil invalid completion result. Hmm. So maybe we shouldn't do this and fix the problem at the root? Remove the failover mechanism? I am not fond of introducing a hack to work around the problematic failover design. > While we're here, let's not forget the other problem with > `completion-category-defaults` which is when a package puts something > like `substring` in it because `partial-completion` is not "good > enough": this can end up taking precedence over the users's > customization of the default to something like `flex` which is probably > not what's wanted. Exactly. This is the reason why I reset `completion-category-defaults` in my configuration and I also recommend this in the README of the packages. I should probably describe the problem more explicitly. Often users copy example configurations from packages without investigating the implications. Furthermore in the case of completion styles the implications are often not that obvious. One more reason to remove complexity if possible... > I'm not completely sure how to fix that one. An cheap solution would be > to allow `completion-category-defaults` to specify a function rather > than a list of styles, and then this function will return the list of > styles to use so it can dynamically adapt to the user's chosen default. > But it's kind of a cop out because that function will need to "guess" > what is the relationship between the various styles, which is the crux > of the matter. > > This problem doesn't apply to `completion-category-override` since we > can consider it to be the user's responsability to take `completion-styles` > into account when setting `completion-category-override`. My cheap proposal would be the removal of `completion-category-defaults` and the removal of the failover mechanism of `completion-category-overrides`. Then the user can adjust the `completion-styles` entirely in their configuration. This is maybe not the most user friendly solution in the first place. But as soon as you start to tweak the completion styles it makes things simpler and easier to understand. My opinion in this case is admittedly a bit radical since I propose that users adjust their completion styles heavily to unlock a lot of potential (for example look at orderless and the flexible orderless style dispatchers). But such adjustments may not be for everyone. Daniel
bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.
Received: (at 22324) by debbugs.gnu.org; 26 Jan 2022 17:19:20 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 26 12:19:20 2022
Received: from localhost ([127.0.0.1]:53358 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nClx2-00065b-0u
for submit <at> debbugs.gnu.org; Wed, 26 Jan 2022 12:19:20 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:63371)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1nClx0-00065N-1G
for 22324 <at> debbugs.gnu.org; Wed, 26 Jan 2022 12:19:19 -0500
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id DAFA1100189;
Wed, 26 Jan 2022 12:19:11 -0500 (EST)
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A21BF10000D;
Wed, 26 Jan 2022 12:19:09 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1643217549;
bh=ANAyi0qarT8+RbHtwC4054aMcT7hN7oIXXs/tJ7ECxw=;
h=From:To:Cc:Subject:References:Date:In-Reply-To:From;
b=D0Va7lFf2Y635NHes0a8EL0fxQy4TwnmODHjsPTgu6qLXN4/98WhaFUmyJdU/mHzy
AKvAq8lPAtmQqTfDkDfyUj3/SOTkgq/3/HfTM9JTBE7j7oV57bKQay4rMFOlO6/4Kk
cwyXFbLfr9TEP+35v9VX4TePl3QYpE+x4vIypbFA1EjXyVetyUlYmu9nit5dtefJQ5
X8oCRBMkmOFBdTGziX+kl0RmsDG76RbV1RmB2bFDMAmHNCKc/u6o0+l/HsPNwCZcIp
71RZx+UeJ9pJCE+aEZL4VSMmKgINQFBL+TW1y7mQYAWhXN1hd/rzy2hGdaWF3X92Vy
eMrsgaRlzstig==
Received: from alfajor (lechon.iro.umontreal.ca [132.204.27.242])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5E3BF1207DA;
Wed, 26 Jan 2022 12:19:09 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
To: Daniel Mendler <mail@HIDDEN>
Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't
override completion-styles (gets prepended instead)
Message-ID: <jwvee4ue8na.fsf-monnier+emacs@HIDDEN>
References: <868u41rv84.fsf@HIDDEN> <83fuy8p8oq.fsf@HIDDEN>
<568FA9D0.2040609@HIDDEN> <83egdsp88n.fsf@HIDDEN>
<568FABFC.3000205@HIDDEN> <87tufr74of.fsf@HIDDEN>
<a1f74c9e-0043-9be9-5739-e87e58dd8fa8@HIDDEN>
<87lf0yjwpw.fsf@HIDDEN>
<ad66bc96-1f85-850b-4952-35bd6749da02@HIDDEN>
<87r1aodus0.fsf@HIDDEN>
<66aa873d-5f5f-9024-efb6-e6110c27ab3a@HIDDEN>
<87ilvy4m94.fsf@HIDDEN> <87czklnqvs.fsf@HIDDEN>
<3045ca8b-f5d6-c85e-d170-3fe158fec64e@HIDDEN>
<87ilu94gac.fsf@HIDDEN>
<43725c9f-1f0a-fb43-82a2-3f284791fdf5@HIDDEN>
<875yq8ypmi.fsf@HIDDEN>
<a9258e5f-4ee5-61dc-dc94-8ca697ff8a41@HIDDEN>
<d3a97207-c944-c941-8a85-dbf59056987f@HIDDEN>
<jwvczke8w23.fsf-monnier+emacs@HIDDEN>
<184dffab-4fa4-e265-c8ef-0c088149b1b4@HIDDEN>
Date: Wed, 26 Jan 2022 12:19:00 -0500
In-Reply-To: <184dffab-4fa4-e265-c8ef-0c088149b1b4@HIDDEN> (Daniel
Mendler's message of "Wed, 26 Jan 2022 14:49:48 +0100")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL 0.153 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 22324
Cc: Lars Ingebrigtsen <larsi@HIDDEN>, 22324 <at> debbugs.gnu.org,
Dmitry Gutov <dgutov@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> This sounds like a good idea to solve the issue and retain backward
> compatibility. It is like eating the cake backwards :) A `fail'
> completion style is pretty trivial. It boils down to adding `(fail
> ignore ignore "Fail with no completions")` to the
> `completion-styles-alist`, or did I miss something?
No, because `ignore` will return nil and so we'll just keep going to the
next style. We need try/all-completion functions for this style to
return a non-nil value but that is like "no completion".
I suspect it can't be done quite right without changing `minibuffer.el`,
but we can probably get close enough to be tolerable with older Emacsen.
E.g. for the try-completion case, I think we can return (STRING . POINT)
and for all-completions maybe returning `0` will do the trick.
> I am aware of this distinction, but I chose to ignore it. Calling it
> "quite different" feels like an exaggeration, given that Emacs is
> supposed to be configurable throughout by the user - of course this is
> only my interpretation.
The users are indeed free to mess with anything they like, of course.
But packages are allowed to change `completion-category-defaults`
whereas they're not allowed to change `completion-category-override`.
While we're here, let's not forget the other problem with
`completion-category-defaults` which is when a package puts something
like `substring` in it because `partial-completion` is not "good
enough": this can end up taking precedence over the users's
customization of the default to something like `flex` which is probably
not what's wanted.
I'm not completely sure how to fix that one. An cheap solution would be
to allow `completion-category-defaults` to specify a function rather
than a list of styles, and then this function will return the list of
styles to use so it can dynamically adapt to the user's chosen default.
But it's kind of a cop out because that function will need to "guess"
what is the relationship between the various styles, which is the crux
of the matter.
This problem doesn't apply to `completion-category-override` since we
can consider it to be the user's responsability to take `completion-styles`
into account when setting `completion-category-override`.
Stefan
bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.Received: (at 22324) by debbugs.gnu.org; 26 Jan 2022 13:49:58 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 26 08:49:58 2022 Received: from localhost ([127.0.0.1]:51321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1nCigQ-0005mq-Io for submit <at> debbugs.gnu.org; Wed, 26 Jan 2022 08:49:58 -0500 Received: from server.qxqx.de ([178.63.65.180]:55727 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mail@HIDDEN>) id 1nCigO-0005mZ-Ew for 22324 <at> debbugs.gnu.org; Wed, 26 Jan 2022 08:49:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LbeHSca0eQcNhklHT3GKksy/C8m/sTq52DTStxOkHvE=; b=t3booAxrRDAm1SDUFiFEQtwOXq nz3GJI207LHe8zL6mkaFitgJUAsUNqr1J24VykCAvnf/ECt0bEoZ4lJRFb48VBosVpOMDxXci8O+9 AB+Kj5dVISSzJIkXg5GPYACeabPKLnSJfu3aKFACSp6+Wr8np/QMLqgHHR7r3fGRD8bQ=; Message-ID: <184dffab-4fa4-e265-c8ef-0c088149b1b4@HIDDEN> Date: Wed, 26 Jan 2022 14:49:48 +0100 MIME-Version: 1.0 Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead) Content-Language: en-US To: Stefan Monnier <monnier@HIDDEN> References: <868u41rv84.fsf@HIDDEN> <83fuy8p8oq.fsf@HIDDEN> <568FA9D0.2040609@HIDDEN> <83egdsp88n.fsf@HIDDEN> <568FABFC.3000205@HIDDEN> <87tufr74of.fsf@HIDDEN> <a1f74c9e-0043-9be9-5739-e87e58dd8fa8@HIDDEN> <87lf0yjwpw.fsf@HIDDEN> <ad66bc96-1f85-850b-4952-35bd6749da02@HIDDEN> <87r1aodus0.fsf@HIDDEN> <66aa873d-5f5f-9024-efb6-e6110c27ab3a@HIDDEN> <87ilvy4m94.fsf@HIDDEN> <87czklnqvs.fsf@HIDDEN> <3045ca8b-f5d6-c85e-d170-3fe158fec64e@HIDDEN> <87ilu94gac.fsf@HIDDEN> <43725c9f-1f0a-fb43-82a2-3f284791fdf5@HIDDEN> <875yq8ypmi.fsf@HIDDEN> <a9258e5f-4ee5-61dc-dc94-8ca697ff8a41@HIDDEN> <d3a97207-c944-c941-8a85-dbf59056987f@HIDDEN> <jwvczke8w23.fsf-monnier+emacs@HIDDEN> From: Daniel Mendler <mail@HIDDEN> In-Reply-To: <jwvczke8w23.fsf-monnier+emacs@HIDDEN> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 22324 Cc: Lars Ingebrigtsen <larsi@HIDDEN>, 22324 <at> debbugs.gnu.org, Dmitry Gutov <dgutov@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > We can probably have our cake and eat it too by adding a `fail` > completion style. Such a style would always take responsibility > (i.e. would never return nil to delegate to subsequent styles), but > would always return a "useless" value that gives no completions. > > Then entries in `completion-category-override/defaults` could choose to > either be mere additions to the global default (as now) or be a full > override (which they'd get by having this `fail` style at the end). This sounds like a good idea to solve the issue and retain backward compatibility. It is like eating the cake backwards :) A `fail' completion style is pretty trivial. It boils down to adding `(fail ignore ignore "Fail with no completions")` to the `completion-styles-alist`, or did I miss something? >> Furthermore we've also got `completion-category-defaults`. It may make >> sense to distinguish them by making the override a real override and >> keep the current behavior for the defaults. > > No, the role of those two is already quite different: > `completion-category-defaults` is for packages to set, whereas > `completion-category-override` is to be set by end-users. I am aware of this distinction, but I chose to ignore it. Calling it "quite different" feels like an exaggeration, given that Emacs is supposed to be configurable throughout by the user - of course this is only my interpretation. I usually override `completion-category-defaults` since I want to control the completion precisely myself and I don't like if packages interfere with that. But this is probably a special preference of someone who wrote multiple completion UIs and likes to tweak the Orderless matching behavior... ;) As far as I know `completion-category-defaults` is not used widely. I don't have a single package installed which makes use of this functionality, but once again, this is probably not representative. Daniel
bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.
Received: (at 22324) by debbugs.gnu.org; 26 Jan 2022 13:36:47 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 26 08:36:47 2022
Received: from localhost ([127.0.0.1]:51248 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nCiTe-0005Nd-O7
for submit <at> debbugs.gnu.org; Wed, 26 Jan 2022 08:36:46 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:46444)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1nCiTc-0005NO-5h
for 22324 <at> debbugs.gnu.org; Wed, 26 Jan 2022 08:36:45 -0500
Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 1000244293D;
Wed, 26 Jan 2022 08:36:38 -0500 (EST)
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 7C86C44293B;
Wed, 26 Jan 2022 08:36:36 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1643204196;
bh=8L5iSPBUvZ/goaDTgWIF4Wc+VMEE9YRLCbbE5B1P7Xk=;
h=From:To:Cc:Subject:References:Date:In-Reply-To:From;
b=MgIlWhq8suomF2K5ExvlATBMqSmv83sr95Ujv80g2hrBPm8YgfzHgSUNGSg8jEyT8
rErwGIw33xfjvYlvARMVFmalNMLYk2+GL1yQ2zMkOxekfzrIWdV9+1mlAXZLLwwlkK
FdZRUJwO1WVh4vE6STOQQGMPcYRw/tOEJoU1pdPr5BJgNLlFaeH3zrfKjn8jtjeL15
EzmghsvGJp2bBcc5yZ/QqEXbOwvNxFFA828o7rGtts/G1U4pi9gBKTj6pZE8P2+nou
zAPyNr+Vejx4KxCbx5BzDi/YZejv3pDMgI4n3DbArIybimpFaCD9SQq3Q/iYpaiDqr
7Qujiw+TALHTg==
Received: from ceviche (76-10-138-212.dsl.teksavvy.com [76.10.138.212])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4A763120648;
Wed, 26 Jan 2022 08:36:36 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
To: Daniel Mendler <mail@HIDDEN>
Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't
override completion-styles (gets prepended instead)
Message-ID: <jwvczke8w23.fsf-monnier+emacs@HIDDEN>
References: <868u41rv84.fsf@HIDDEN> <83fuy8p8oq.fsf@HIDDEN>
<568FA9D0.2040609@HIDDEN> <83egdsp88n.fsf@HIDDEN>
<568FABFC.3000205@HIDDEN> <87tufr74of.fsf@HIDDEN>
<a1f74c9e-0043-9be9-5739-e87e58dd8fa8@HIDDEN>
<87lf0yjwpw.fsf@HIDDEN>
<ad66bc96-1f85-850b-4952-35bd6749da02@HIDDEN>
<87r1aodus0.fsf@HIDDEN>
<66aa873d-5f5f-9024-efb6-e6110c27ab3a@HIDDEN>
<87ilvy4m94.fsf@HIDDEN> <87czklnqvs.fsf@HIDDEN>
<3045ca8b-f5d6-c85e-d170-3fe158fec64e@HIDDEN>
<87ilu94gac.fsf@HIDDEN>
<43725c9f-1f0a-fb43-82a2-3f284791fdf5@HIDDEN>
<875yq8ypmi.fsf@HIDDEN>
<a9258e5f-4ee5-61dc-dc94-8ca697ff8a41@HIDDEN>
<d3a97207-c944-c941-8a85-dbf59056987f@HIDDEN>
Date: Wed, 26 Jan 2022 08:36:34 -0500
In-Reply-To: <d3a97207-c944-c941-8a85-dbf59056987f@HIDDEN> (Daniel
Mendler's message of "Wed, 26 Jan 2022 03:31:08 +0100")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 22324
Cc: Lars Ingebrigtsen <larsi@HIDDEN>, 22324 <at> debbugs.gnu.org,
Dmitry Gutov <dgutov@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
>> Apparently this config is recommended in the README of both Corfu and
>> Vertico (https://github.com/minad/vertico#configuration), both projects
>> by Daniel Mendler.
>> I guess we should ask Daniel whether he has been aware of the
>> completion-styles failover mechanic, and what he thinks about it.
> Yes, I've been aware of the failover mechanic and I think it is not
> good. From my experience, I would prefer if the override is a real
> override, which this issue is about. Users can still opt-in to the
> default styles on a case by case basis if this is desired.
We can probably have our cake and eat it too by adding a `fail`
completion style. Such a style would always take responsibility
(i.e. would never return nil to delegate to subsequent styles), but
would always return a "useless" value that gives no completions.
Then entries in `completion-category-override/defaults` could choose to
either be mere additions to the global default (as now) or be a full
override (which they'd get by having this `fail` style at the end).
> Furthermore we've also got `completion-category-defaults`. It may make
> sense to distinguish them by making the override a real override and
> keep the current behavior for the defaults.
No, the role of those two is already quite different:
`completion-category-defaults` is for packages to set, whereas
`completion-category-override` is to be set by end-users.
Stefan
bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.Received: (at 22324) by debbugs.gnu.org; 26 Jan 2022 02:31:19 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 25 21:31:19 2022 Received: from localhost ([127.0.0.1]:50603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1nCY5f-0002Pg-IH for submit <at> debbugs.gnu.org; Tue, 25 Jan 2022 21:31:19 -0500 Received: from server.qxqx.de ([178.63.65.180]:52095 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mail@HIDDEN>) id 1nCY5d-0002PR-Dy for 22324 <at> debbugs.gnu.org; Tue, 25 Jan 2022 21:31:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=cMWdQF/NljCskGmsg7mM8SAg9yNdUBD9gZ7CGeDXa9w=; b=XGIlZow5nZkn+MOHLOW9JU9fLO vR9BwhDUtcgELqS82YBaBzwJy8ZCgAv9SP4W3+5sH8UTSRn2YKh+0uxqqdggyAMWibNa3akLz2Hg9 4WkXRZKOXPulTKy7WFVQ+ZDD/QoauP4c9eomd9Q3wzMNkl9G/PaR3M0vGIP/eH13D9KU=; Message-ID: <d3a97207-c944-c941-8a85-dbf59056987f@HIDDEN> Date: Wed, 26 Jan 2022 03:31:08 +0100 MIME-Version: 1.0 Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead) Content-Language: en-US To: Dmitry Gutov <dgutov@HIDDEN>, Lars Ingebrigtsen <larsi@HIDDEN> References: <868u41rv84.fsf@HIDDEN> <83fuy8p8oq.fsf@HIDDEN> <568FA9D0.2040609@HIDDEN> <83egdsp88n.fsf@HIDDEN> <568FABFC.3000205@HIDDEN> <87tufr74of.fsf@HIDDEN> <a1f74c9e-0043-9be9-5739-e87e58dd8fa8@HIDDEN> <87lf0yjwpw.fsf@HIDDEN> <ad66bc96-1f85-850b-4952-35bd6749da02@HIDDEN> <87r1aodus0.fsf@HIDDEN> <66aa873d-5f5f-9024-efb6-e6110c27ab3a@HIDDEN> <87ilvy4m94.fsf@HIDDEN> <87czklnqvs.fsf@HIDDEN> <3045ca8b-f5d6-c85e-d170-3fe158fec64e@HIDDEN> <87ilu94gac.fsf@HIDDEN> <43725c9f-1f0a-fb43-82a2-3f284791fdf5@HIDDEN> <875yq8ypmi.fsf@HIDDEN> <a9258e5f-4ee5-61dc-dc94-8ca697ff8a41@HIDDEN> From: Daniel Mendler <mail@HIDDEN> In-Reply-To: <a9258e5f-4ee5-61dc-dc94-8ca697ff8a41@HIDDEN> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 22324 Cc: Stefan Monnier <monnier@HIDDEN>, 22324 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Hello Dmitry, thank you for pinging me. > Apparently this config is recommended in the README of both Corfu and > Vertico (https://github.com/minad/vertico#configuration), both projects > by Daniel Mendler. > > I guess we should ask Daniel whether he has been aware of the > completion-styles failover mechanic, and what he thinks about it. Yes, I've been aware of the failover mechanic and I think it is not good. From my experience, I would prefer if the override is a real override, which this issue is about. Users can still opt-in to the default styles on a case by case basis if this is desired. The assessment that the variable `completion-category-overrides` is modified rarely might have been true, but this is not the case anymore. In the context of the GNU ELPA packages Orderless, Vertico, Consult, Embark, Marginalia etc., we educate users to make heavy use of this variable since it permits fine tuning of the completion behavior depending on the completion category. We also use the completion category heavily in Marginalia and Embark to determine the type of the candidates for annotations and minibuffer actions. Unfortunately the configurations you mentioned, Dmitry, make use of the failover mechanism. I indeed want to use partial-completion and then failover to the orderless default. If there wouldn't be a failover I would have of course recommended another override (partial-completion + orderless). Nevertheless I would appreciate the removal (or replacing) of the failover mechanism. I noticed that it has lead to confusion for some users before. It leads to performance issues when the slow default sets in as has been pointed out already. Since currently there is no possibility to really override the completion styles except via an advice, removing the failover seems like a good idea. Furthermore we've also got `completion-category-defaults`. It may make sense to distinguish them by making the override a real override and keep the current behavior for the defaults. The alternative would be a deprecation of the override variable and the introduction of new variable which is a real override. One final statement regarding making a breaking change here: You should consider that the packages orderless etc are fairly new and still have breaking changes from time to time, so even if these configurations are widespread or see growing adoption, this should not hold you back from making a breaking change. I will then promptly adapt the documentation of these projects and add a warning note, which will soon propagate to the users who use Emacs master, which is still young in the development cycle. Of course my statement applies only if the aforementioned are truly the only widespread packages affected by this. Daniel
bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.
Received: (at 22324) by debbugs.gnu.org; 26 Jan 2022 01:43:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 25 20:43:27 2022
Received: from localhost ([127.0.0.1]:50582 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nCXLL-0001BT-Em
for submit <at> debbugs.gnu.org; Tue, 25 Jan 2022 20:43:27 -0500
Received: from mail-wm1-f48.google.com ([209.85.128.48]:44596)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <raaahh@HIDDEN>) id 1nCXLJ-0001BG-Mf
for 22324 <at> debbugs.gnu.org; Tue, 25 Jan 2022 20:43:26 -0500
Received: by mail-wm1-f48.google.com with SMTP id
l35-20020a05600c1d2300b0034d477271c1so3157324wms.3
for <22324 <at> debbugs.gnu.org>; Tue, 25 Jan 2022 17:43:25 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
h=sender:subject:to:cc:references:from:message-id:date:user-agent
:mime-version:in-reply-to:content-language:content-transfer-encoding;
bh=Jy5vFVpBkUluzSInvwpR/zIdGyLJ6XZVtspqbxs+0vU=;
b=Nfz41CTE8S++5Zy9paEkVVIxG18Jcb5kOa4N6jsmTigN07vxfdNTp26xed1I88kwCs
qFomP8dXIuqFo9ITtmwomOL8Vc7IED613vRPrVIjS3ZXiAPDF9v92vNH/AHg74UNQkLu
zj6mm9L+WNfbDJV4gVLaIZLPoFpTaUxTKEZfVOvPDgEnMb6nU1wKgxPPR6Kkm6CoTKGk
RGdo+0Y46TrHi2Q+g/a5Oa/kCCoD/hYh9KQNTBdkDH2XCQp0xvZrcc3l6JuXK/7bZjoq
2G4OiFg5NwDN8gT8+TwOGDGObIeZcrVjD+1AVYKMaiJAwhS++ZeHq+r32fiIWszIUmfK
HpcQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:sender:subject:to:cc:references:from:message-id
:date:user-agent:mime-version:in-reply-to:content-language
:content-transfer-encoding;
bh=Jy5vFVpBkUluzSInvwpR/zIdGyLJ6XZVtspqbxs+0vU=;
b=rthBJqRS9CAl8TLNULO6YRdZVKKHwTLh3C/V39SJdTGQ3YfvQUA6qjnFeE40wEaggF
BwlfcovWn6If0jm2+UVNkExytvBn8nQS4OpOGdVQwdduBdda65d5H4oxN1cPwfUzyC/q
T8o8hO+ADhzz7o2aah0Zc4tMy0zFh9TA+Mje/q8mt0ZwdyTyVrflFmLmiTwuEXnwWy11
k941vnsOnj/ihVc5OWQlaSF443u1vvbNgvlJmWkINioajzLMXwb0x/7qM6d52x1vzUHg
E8lG+ixzH2MKsDwOdNS4x0twOayXFkcsC2ozDPLf4a7Ygy6l/biNHd3hfZl2rXWHN54q
+BQA==
X-Gm-Message-State: AOAM533l6SumvMdF27ZiGbPg8pkQz8477oeAJ+DW2Yeno4W8EdwoMrg5
6YioQAhiV4KFRwPu2SyN6U98aWutHfQ=
X-Google-Smtp-Source: ABdhPJxNZn3xTpTB/+EOJha6DCUKHcYuD8UaGBfsUe+kITYO8Ucgy+1bK5trx8SQf/6F6pk6rBZxrw==
X-Received: by 2002:a05:600c:5028:: with SMTP id
n40mr5141843wmr.10.1643161399516;
Tue, 25 Jan 2022 17:43:19 -0800 (PST)
Received: from [10.107.115.144] ([194.36.25.53])
by smtp.googlemail.com with ESMTPSA id z3sm2330560wmp.42.2022.01.25.17.43.18
(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
Tue, 25 Jan 2022 17:43:18 -0800 (PST)
Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't
override completion-styles (gets prepended instead)
To: Lars Ingebrigtsen <larsi@HIDDEN>, Daniel Mendler <mail@HIDDEN>
References: <868u41rv84.fsf@HIDDEN> <83fuy8p8oq.fsf@HIDDEN>
<568FA9D0.2040609@HIDDEN> <83egdsp88n.fsf@HIDDEN>
<568FABFC.3000205@HIDDEN> <87tufr74of.fsf@HIDDEN>
<a1f74c9e-0043-9be9-5739-e87e58dd8fa8@HIDDEN> <87lf0yjwpw.fsf@HIDDEN>
<ad66bc96-1f85-850b-4952-35bd6749da02@HIDDEN> <87r1aodus0.fsf@HIDDEN>
<66aa873d-5f5f-9024-efb6-e6110c27ab3a@HIDDEN> <87ilvy4m94.fsf@HIDDEN>
<87czklnqvs.fsf@HIDDEN> <3045ca8b-f5d6-c85e-d170-3fe158fec64e@HIDDEN>
<87ilu94gac.fsf@HIDDEN> <43725c9f-1f0a-fb43-82a2-3f284791fdf5@HIDDEN>
<875yq8ypmi.fsf@HIDDEN>
From: Dmitry Gutov <dgutov@HIDDEN>
Message-ID: <a9258e5f-4ee5-61dc-dc94-8ca697ff8a41@HIDDEN>
Date: Wed, 26 Jan 2022 03:43:17 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <875yq8ypmi.fsf@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Spam-Score: -0.6 (/)
X-Debbugs-Envelope-To: 22324
Cc: 22324 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.6 (-)
On 25.01.2022 14:19, Lars Ingebrigtsen wrote:
> Dmitry Gutov <dgutov@HIDDEN> writes:
>
>> Given that the only times people are likely to notice the distinction
>> are some odd edge cases (and the extra lag is not so big or obvious),
>> there will be even fewer occasions for people to learn about and
>> customize the new var.
>>
>> Unless we obsolete the previous one, which would be a fair approach,
>> if we knew that it actually has a fair amount of users who need to
>> migrate.
>
> Hard to say. Perhaps searching on Github for usages of the variable
> might give us a clue?
Sure.
https://github.com/search?q=%22completion-category-overrides%22&type=code should
a grand total of 2,433 matches, but the vast majority of those seem to
be users of Orderless who use this scheme:
(setq completion-styles '(orderless))
(setq completion-category-defaults nil)
(setq completion-category-overrides '((file (styles
partial-completion))))
Some add 'basic' before 'partial-completion' for better "Tramp hostname
completion".
Do these users expect the failover to the orderless style when
partial-completion fails to complete? Possible. Orderless is more lax.
But also kinda doubtful since partial-completion is fairly powerful by
itself, and entering the segments of a file name in a different order is
not something does often or intentionally.
Apparently this config is recommended in the README of both Corfu and
Vertico (https://github.com/minad/vertico#configuration), both projects
by Daniel Mendler.
I guess we should ask Daniel whether he has been aware of the
completion-styles failover mechanic, and what he thinks about it.
***
And there are occasionally configs like
(setq completion-styles
'(partial-completion substring initials basic))
;; override default completion style of specific modes
(setq completion-category-overrides
'((file (styles . (flex)))
(buffer (styles . (flex)))
(project-file (styles . (flex)))
(info-menu (styles . (flex)))))
where the override is explicitly more powerful, so we know that failover
is not desirable, just wasted CPU cycles.
bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.Received: (at 22324) by debbugs.gnu.org; 25 Jan 2022 12:19:30 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 25 07:19:30 2022 Received: from localhost ([127.0.0.1]:47207 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1nCKnK-0000Rf-1f for submit <at> debbugs.gnu.org; Tue, 25 Jan 2022 07:19:30 -0500 Received: from quimby.gnus.org ([95.216.78.240]:34436) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <larsi@HIDDEN>) id 1nCKnH-0000RM-BS for 22324 <at> debbugs.gnu.org; Tue, 25 Jan 2022 07:19:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1vlv4uy+zz26iM6opJZhGwIhiPeQycibtfq7ra1Wq2g=; b=fOXT8AVQXpt8INOrBTTj9bwloO w0bHs0j3ln2gz7J6E6NRPEYWizAVAsnulEmydP4frQgZU3Q+5ubQGA8HhBul7OKtCXp+gRwmxFbWx O1ATclbOnFFKXtwpI5odGImI+nxbi7XrUsxOfsyZL0iEWfZUf1GFnaPxjaRIkKSpSkWU=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <larsi@HIDDEN>) id 1nCKn8-0003Kf-JN; Tue, 25 Jan 2022 13:19:21 +0100 From: Lars Ingebrigtsen <larsi@HIDDEN> To: Dmitry Gutov <dgutov@HIDDEN> Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead) References: <868u41rv84.fsf@HIDDEN> <83fuy8p8oq.fsf@HIDDEN> <568FA9D0.2040609@HIDDEN> <83egdsp88n.fsf@HIDDEN> <568FABFC.3000205@HIDDEN> <87tufr74of.fsf@HIDDEN> <a1f74c9e-0043-9be9-5739-e87e58dd8fa8@HIDDEN> <87lf0yjwpw.fsf@HIDDEN> <ad66bc96-1f85-850b-4952-35bd6749da02@HIDDEN> <87r1aodus0.fsf@HIDDEN> <66aa873d-5f5f-9024-efb6-e6110c27ab3a@HIDDEN> <87ilvy4m94.fsf@HIDDEN> <87czklnqvs.fsf@HIDDEN> <3045ca8b-f5d6-c85e-d170-3fe158fec64e@HIDDEN> <87ilu94gac.fsf@HIDDEN> <43725c9f-1f0a-fb43-82a2-3f284791fdf5@HIDDEN> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEU0LipDOjVLQzyP hnZlW1CEeWuqpZb////IoTa+AAAAAWJLR0QHFmGI6wAAAAd0SU1FB+YBGQwFD/hqcyoAAAGdSURB VDjLtZNNcoMwDIVlhgNYnnQPLj2BIOvEkXOBQC/gJvc/QmUZ8sOERRf1yrzPepIlA8YRM/su+Lxa xOriQ2g9YAHezcCeYgMOBezSE0DEG7cAYGaQUSF1Ym/lFLjuGbRYy74B4zIYp2khLe6Y+6MzBvxX ml7B949UiAroGcRbH1wrEZ/XiYb4AOdbz14K810faZgKkPvhOY0crJHkfKJhLEB0TCfi0AA45riA rFc90xisWEWOe1KQjbC+RqIgd/fM0z7dQU17MThatVpADjjTPgmAGUiDg4JdohvR2FQHBXQHtZQo CaE+ADKPl+GeW0qcOOcG00m99xT4SdK4owLf5a4XJ7RnmsYVUCfs4mUBzpc5FfDBNKwAzlY0RwBm rzmFQcqzaQpw+qhEBolIEuDljRQvv2SQNzJwa8E3c4gCMGjqPsjwqqDAoOo2byuZRP60JYsu3VoE iS+yxsx6Xu6hv66qea/DxnmoNnTwWwGHvzr9y5Kfytjcf7MC0iUrovy+j7MFGAG552YF9LQarsGb tJsAN0DVbgAd4S9w9G1nnHni8gAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMi0wMS0yNVQxMjowNTox NSswMDowMN6j0rsAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjItMDEtMjVUMTI6MDU6MTUrMDA6MDCv /moHAAAAAElFTkSuQmCC X-Now-Playing: David Bowie's _Brilliant Adventure (9): Re:Call 5_: "Black Tie White Noise (radio edit)" Date: Tue, 25 Jan 2022 13:19:17 +0100 In-Reply-To: <43725c9f-1f0a-fb43-82a2-3f284791fdf5@HIDDEN> (Dmitry Gutov's message of "Tue, 25 Jan 2022 04:27:00 +0200") Message-ID: <875yq8ypmi.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dmitry Gutov <dgutov@HIDDEN> writes: > Given that the only times people are likely to notice the distinction > are some odd edge cases (and the extra lag is not so big or obvious), > there will be even fewer occasions for people to learn [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 22324 Cc: 22324 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Dmitry Gutov <dgutov@HIDDEN> writes: > Given that the only times people are likely to notice the distinction > are some odd edge cases (and the extra lag is not so big or obvious), > there will be even fewer occasions for people to learn about and > customize the new var. > > Unless we obsolete the previous one, which would be a fair approach, > if we knew that it actually has a fair amount of users who need to > migrate. Hard to say. Perhaps searching on Github for usages of the variable might give us a clue? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no
bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.Received: (at 22324) by debbugs.gnu.org; 25 Jan 2022 02:27:11 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 24 21:27:11 2022 Received: from localhost ([127.0.0.1]:46434 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1nCBY6-00071a-WB for submit <at> debbugs.gnu.org; Mon, 24 Jan 2022 21:27:11 -0500 Received: from mail-wr1-f50.google.com ([209.85.221.50]:34566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <raaahh@HIDDEN>) id 1nCBY4-00071H-IJ for 22324 <at> debbugs.gnu.org; Mon, 24 Jan 2022 21:27:09 -0500 Received: by mail-wr1-f50.google.com with SMTP id f17so17080062wrx.1 for <22324 <at> debbugs.gnu.org>; Mon, 24 Jan 2022 18:27:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6rhgCiQy36EOx2vojieoswxQN1WTP2s7kv9P0eWHjC0=; b=TNfRcUqLymTjVbn0QaHQQlPJLdv8pnTZ3TkEQZijKxRyHnbTFAkohMkHBC3bWkq8V2 ntS6Z4YpMULWyFUtF/sXcn99ez8PcoPklCnmbvQadUgwFFbCo+6+8sUTfzubracUTspP bUpjjUiDtDztRa1LamUexYa9Oic+NbFDnY9qVnADd25VBoyj03AmyhoeROJrnd61M57k iP+Q1nSHqZ3Wjfbhi8y38djsBkIKOh0bFqlkFtfZ5imI0tA6e4F6pqsVnNS8KABDfgrZ kbt6sA0t49UeJ028wJJRX+U+PvwwXZ8JzEiGvLVlOO5NdGrQNX3s6k/WfGaAgrpNVI1v 5hfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6rhgCiQy36EOx2vojieoswxQN1WTP2s7kv9P0eWHjC0=; b=1+hUj+1FDVoBX7X/VStnJVr3imFQvx5FnoeCxSFlPLp2XKPJAeOevMLJNSJ2koTQDT dvBISnJ/oWAbRDYljXAyaqtx99kiRTAGcSafIU83DRJ+PGJNIrKGlwhQBtd53kAU9G1K gQ2V5irp4k3nTCSfzYZ6GxQw3FDEK7mw8EBzs3ahQpgopO0kTJoGtcKoAn23OEq6vQvD D5JU/PmL4IOmhe8R5FKoLPJQDZI7xI2kkiE4fBGWaVB1DmXs+6COVHlL2Udr5bfL1DqB SNAlW4u8rRrAe82KfORN93ApI/5sso/pszgIa0mDcxlN0gkgl/xYPUPmAGkYxLnRTwm6 bNRQ== X-Gm-Message-State: AOAM530CGS5D1UzjkIJaXD0t+qn+bC7+Jegpv8sLL/H5ZstEEZurc3pG PgolIMzy/7HXtmI7fZ8Gw6W25YUI2vTNIg== X-Google-Smtp-Source: ABdhPJyvw3G/+nhvz2z7i6ubXeDlNMZRjRFxkIKb5vXFW/Ipb1NCMeoGGxfZeAiX7s/XZ/6OawZCOA== X-Received: by 2002:adf:9cd2:: with SMTP id h18mr6622810wre.483.1643077622487; Mon, 24 Jan 2022 18:27:02 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id n11sm2323716wms.3.2022.01.24.18.27.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jan 2022 18:27:01 -0800 (PST) Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead) To: Lars Ingebrigtsen <larsi@HIDDEN> References: <868u41rv84.fsf@HIDDEN> <83fuy8p8oq.fsf@HIDDEN> <568FA9D0.2040609@HIDDEN> <83egdsp88n.fsf@HIDDEN> <568FABFC.3000205@HIDDEN> <87tufr74of.fsf@HIDDEN> <a1f74c9e-0043-9be9-5739-e87e58dd8fa8@HIDDEN> <87lf0yjwpw.fsf@HIDDEN> <ad66bc96-1f85-850b-4952-35bd6749da02@HIDDEN> <87r1aodus0.fsf@HIDDEN> <66aa873d-5f5f-9024-efb6-e6110c27ab3a@HIDDEN> <87ilvy4m94.fsf@HIDDEN> <87czklnqvs.fsf@HIDDEN> <3045ca8b-f5d6-c85e-d170-3fe158fec64e@HIDDEN> <87ilu94gac.fsf@HIDDEN> From: Dmitry Gutov <dgutov@HIDDEN> Message-ID: <43725c9f-1f0a-fb43-82a2-3f284791fdf5@HIDDEN> Date: Tue, 25 Jan 2022 04:27:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <87ilu94gac.fsf@HIDDEN> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 22324 Cc: 22324 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.6 (-) On 24.01.2022 11:46, Lars Ingebrigtsen wrote: > Dmitry Gutov <dgutov@HIDDEN> writes: > >> So the fix I had in mind looks like: >> >> diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el >> index d58c23af8f..0aee55f33c 100644 >> --- a/lisp/minibuffer.el >> +++ b/lisp/minibuffer.el >> @@ -1043,7 +1043,7 @@ completion--styles >> (let* ((cat (completion-metadata-get metadata 'category)) >> (over (completion--category-override cat 'styles))) >> (if over >> - (delete-dups (append (cdr over) (copy-sequence completion-styles))) >> + (cdr over) >> completion-styles))) > > Oh, I see. Hm... that would change the behaviour for those that depend > on this working the old way. My theory is that this has never been reported because people never really notice the distinction in practice since if the completions styles are customized, that's usually done in favor of more lax ones. So appending the default styles at the end doesn't affect the behavior in 99% of the cases. But it does add some CPU usage/latency in the "no matches" case, because that's the only case when the failover happens. There might be a few users out there, of course, who rely on the current behavior, but I'm not sure what their use cases would be, and there can't be many people like that either because the completion styles stuff is fairly obscure. People have been exploring alternative front-ends recently that plug into CAPF, but completion-category-overrides is probably not a popular variable to customize still. > Perhaps it'd make more sense to add a new variable to allow real overrides? I don't know. What would it be called? completion-category-overrides-for-real-now? Given that the only times people are likely to notice the distinction are some odd edge cases (and the extra lag is not so big or obvious), there will be even fewer occasions for people to learn about and customize the new var. Unless we obsolete the previous one, which would be a fair approach, if we knew that it actually has a fair amount of users who need to migrate.
bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.Received: (at 22324) by debbugs.gnu.org; 24 Jan 2022 09:47:03 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 24 04:47:03 2022 Received: from localhost ([127.0.0.1]:42127 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1nBvwE-0001pF-Rs for submit <at> debbugs.gnu.org; Mon, 24 Jan 2022 04:47:03 -0500 Received: from quimby.gnus.org ([95.216.78.240]:48572) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <larsi@HIDDEN>) id 1nBvwC-0001j1-Lz for 22324 <at> debbugs.gnu.org; Mon, 24 Jan 2022 04:47:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=0izFQiI2MbgWZAuoF2OfSjIvkk7Bx5TQr/BTfNF+W/I=; b=BVlNa0pDQ+dNURovLDZD388JKF nOCL8REVb/pDPStXADP/xNLVtoJN9/Hia/om4p4AjrbFD7CqVDX8ENcQi+msc1Al4jRksgpLr2dX5 tQpJTABNau/nSHeB7/VYw3cQz/Qr7+c5K7c503AWk5N+UTK4R2kQZaGLlpa25k3iz7Og=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <larsi@HIDDEN>) id 1nBvw4-0006Ug-8Z; Mon, 24 Jan 2022 10:46:54 +0100 From: Lars Ingebrigtsen <larsi@HIDDEN> To: Dmitry Gutov <dgutov@HIDDEN> Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead) References: <868u41rv84.fsf@HIDDEN> <83fuy8p8oq.fsf@HIDDEN> <568FA9D0.2040609@HIDDEN> <83egdsp88n.fsf@HIDDEN> <568FABFC.3000205@HIDDEN> <87tufr74of.fsf@HIDDEN> <a1f74c9e-0043-9be9-5739-e87e58dd8fa8@HIDDEN> <87lf0yjwpw.fsf@HIDDEN> <ad66bc96-1f85-850b-4952-35bd6749da02@HIDDEN> <87r1aodus0.fsf@HIDDEN> <66aa873d-5f5f-9024-efb6-e6110c27ab3a@HIDDEN> <87ilvy4m94.fsf@HIDDEN> <87czklnqvs.fsf@HIDDEN> <3045ca8b-f5d6-c85e-d170-3fe158fec64e@HIDDEN> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAALVBMVEUDBQwfGCEtLTFs bHCrrLDR0dXw8PJ9fYFgWmGPkJS9vcFFOEN+f4NNTVH///8PU95gAAAAAWJLR0QOb70wTwAAAAd0 SU1FB+YBGAkIHpkDiBsAAAGcSURBVDjLrZJNS8NAEIZn41GEJD1JKdR4qUgOtRWtKFj6oRFvNZV6 bgb0rHfRXEQEKanQYg8iLejR/gm9qfUQkf4Xt5umH7vrzXchsPtk5t2dGYCRNNDTZRzosIgIk1Lc AFSKjj0FIOExUlq1n6cB6N06BY/uQR54kTvEnUtrUwAwX8ZcKtUXgVLE3P2LKgL9DHOND96A/hjd wFL+nQd0RV08zp9zYE4FNZbGqscD0EyIFPAkLQBwkzP0hRneA0ii5UqBppv05ZgSUhGtW6DgVfRQ WEtqosfiIACzfEV0I+hhlj83/TpKADH8NZYJH7i7Gv5bh4Ft3qF3GkzDrQA8lAHN6DWlAHT/D0BM NnFOmTOnId9tu4xHQgNpRfbatm21wr15HU5FzCtgpXExuo42KJrGQAedfGs6zbjq1fgwgBWZfZRB Y9FphZnooJEgjAHcV4cgDADyxcAu25GJdgXAqY1dQy1Rc9tKjvZqGBcp2E83C+oEGCqaaayAVHrf iMtJLLP+KTtXek1ry5CAWf/K+tElgCwbfbkJgf/WL9tlhd4YWsDQAAAAJXRFWHRkYXRlOmNyZWF0 ZQAyMDIyLTAxLTI0VDA5OjA4OjMwKzAwOjAw7+6+lQAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0w MS0yNFQwOTowODozMCswMDowMJ6zBikAAAAASUVORK5CYII= X-Now-Playing: This Mortal Coil's _Filigree & Shadow_: "Red Rain" Date: Mon, 24 Jan 2022 10:46:51 +0100 In-Reply-To: <3045ca8b-f5d6-c85e-d170-3fe158fec64e@HIDDEN> (Dmitry Gutov's message of "Mon, 24 Jan 2022 04:03:17 +0200") Message-ID: <87ilu94gac.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dmitry Gutov <dgutov@HIDDEN> writes: > So the fix I had in mind looks like: > > diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el > index d58c23af8f..0aee55f33c 100644 > --- a/lisp/minibuffer.el > +++ b/lisp/minibuffer.el > @@ -1043,7 [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 22324 Cc: 22324 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Dmitry Gutov <dgutov@HIDDEN> writes: > So the fix I had in mind looks like: > > diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el > index d58c23af8f..0aee55f33c 100644 > --- a/lisp/minibuffer.el > +++ b/lisp/minibuffer.el > @@ -1043,7 +1043,7 @@ completion--styles > (let* ((cat (completion-metadata-get metadata 'category)) > (over (completion--category-override cat 'styles))) > (if over > - (delete-dups (append (cdr over) (copy-sequence completion-styles))) > + (cdr over) > completion-styles))) Oh, I see. Hm... that would change the behaviour for those that depend on this working the old way. Perhaps it'd make more sense to add a new variable to allow real overrides? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no
bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.
Received: (at 22324) by debbugs.gnu.org; 24 Jan 2022 02:03:28 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 23 21:03:28 2022
Received: from localhost ([127.0.0.1]:41580 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nBohb-0003eg-PD
for submit <at> debbugs.gnu.org; Sun, 23 Jan 2022 21:03:28 -0500
Received: from mail-ed1-f48.google.com ([209.85.208.48]:42982)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <raaahh@HIDDEN>) id 1nBohZ-0003eV-Ln
for 22324 <at> debbugs.gnu.org; Sun, 23 Jan 2022 21:03:26 -0500
Received: by mail-ed1-f48.google.com with SMTP id p12so53820500edq.9
for <22324 <at> debbugs.gnu.org>; Sun, 23 Jan 2022 18:03:25 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
h=sender:subject:to:cc:references:from:message-id:date:user-agent
:mime-version:in-reply-to:content-language:content-transfer-encoding;
bh=jZGEfbjWUmODTqPUwhr69nV/+nla4vN3xXVqZfNOvBE=;
b=lvKa1xURDCREbOks5PuLTkYUyx2uPFuABloJnGHHyKeMspHicGtHvL15FkjLS+U7q2
88qL610cYtvrO7pRt93RDdvhedYlbmEoDGF/L/VEpRPWVhsuga93vkoexSukz+ejyPID
qZiYXznbEhWKrl4Oz+mVu6ajrh82CAXZPVSGZ9vThPxEHgxP92ZHzbgWKjnOnWgvpUnr
ZatcOoe7IrbU+cQEw2K/T8TScBtgRKRZ19M2uMemaSliO8LSKiOgM02y04mkKeUq1Nlj
y2OYGDein/BjZscCn49urJv4rLxCS5nBuUozAA3AMTmeewc8rFnSVsCB61Ftx1u5i6VM
vMmw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:sender:subject:to:cc:references:from:message-id
:date:user-agent:mime-version:in-reply-to:content-language
:content-transfer-encoding;
bh=jZGEfbjWUmODTqPUwhr69nV/+nla4vN3xXVqZfNOvBE=;
b=uhgaDBMJGmcxwVZgJCYSuJ47T8tEJBrpadHxKq8TPPuh6d4SPFB37UeNZSwjS/p08z
/ZqwQsifXojWO4tzL+N2So20dlXjHRRBHzITB/i4nzJX3YNLZ4GHJCFhLkgPcrIBvnfi
IWMPBcmOajjxCb7qun2wDkmtmxoU6hBl+SwvdF8cymZPPTDGticLm+MQs7pY29EVQ/ht
QdIF6S34DEasOBn+FQ/klSpHteZslbIqMR/nuJ35yXuuaPCH7rRy1wTxUR7SG2vvHB7l
e+GDZxvh6j0LV+MsDaKwqM3khE8TNPerhikDQspSQZMqKNd8E0OX397hyMnur3eZEIM2
OzCw==
X-Gm-Message-State: AOAM533DwgMT8QqHn9LFSyYnlCwzH2UncBAL19EBiehc9y/cMz6Vj2jP
lyCf9HtHW3yTGaQn+2rnn2+CRtrWVIV4bQ==
X-Google-Smtp-Source: ABdhPJy/ywTzwYKmDj4G6ITTQfe7Qxb6NnHCR0Xg+I6nsbc2QYFSrHQ1P7MjdMmLvp8y0sx63+zkBw==
X-Received: by 2002:a05:6402:50cd:: with SMTP id
h13mr13981137edb.177.1642989799624;
Sun, 23 Jan 2022 18:03:19 -0800 (PST)
Received: from [10.111.160.185] ([185.213.155.232])
by smtp.googlemail.com with ESMTPSA id gu2sm4273414ejb.221.2022.01.23.18.03.18
(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
Sun, 23 Jan 2022 18:03:19 -0800 (PST)
Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't
override completion-styles (gets prepended instead)
To: Lars Ingebrigtsen <larsi@HIDDEN>
References: <868u41rv84.fsf@HIDDEN> <83fuy8p8oq.fsf@HIDDEN>
<568FA9D0.2040609@HIDDEN> <83egdsp88n.fsf@HIDDEN>
<568FABFC.3000205@HIDDEN> <87tufr74of.fsf@HIDDEN>
<a1f74c9e-0043-9be9-5739-e87e58dd8fa8@HIDDEN> <87lf0yjwpw.fsf@HIDDEN>
<ad66bc96-1f85-850b-4952-35bd6749da02@HIDDEN> <87r1aodus0.fsf@HIDDEN>
<66aa873d-5f5f-9024-efb6-e6110c27ab3a@HIDDEN> <87ilvy4m94.fsf@HIDDEN>
<87czklnqvs.fsf@HIDDEN>
From: Dmitry Gutov <dgutov@HIDDEN>
Message-ID: <3045ca8b-f5d6-c85e-d170-3fe158fec64e@HIDDEN>
Date: Mon, 24 Jan 2022 04:03:17 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <87czklnqvs.fsf@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Spam-Score: -0.6 (/)
X-Debbugs-Envelope-To: 22324
Cc: 22324 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.6 (-)
On 21.01.2022 15:46, Lars Ingebrigtsen wrote:
> Lars Ingebrigtsen<larsi@HIDDEN> writes:
>
>> Dmitry Gutov<dgutov@HIDDEN> writes:
>>
>>> Consider changing the behavior instead, though.
>>>
>>> Yes, it's been like this for a long time, but I imagine most users
>>> won't notice the change.
>>>
>>> We could experiment on master.
>> I'd rather not change something as subtle as this (especially in a
>> mechanism that's been around for a while like this as).
> Nobody had any further opinions here in a month, so I went ahead and
> changed the doc string. If somebody feels strongly that the semantics
> should be tweaked, I don't really have a strong opinion either way.
Hi Lars,
The doc change you have pushed in 62a84eea34c33bd1d4b1 misses the point,
which leads me to believe that I have not explained the problem well.
The issue is not that an entry in completion-category-overrides doesn't
override all properties wholesale, that is falls back to defaults for
properties not specified among the overrides.
The issue is that when the 'styles' property is looked up (which is 99%
of the uses of this variable), the override value is not used as-is.
Instead, the default value is appended.
So the fix I had in mind looks like:
diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
index d58c23af8f..0aee55f33c 100644
--- a/lisp/minibuffer.el
+++ b/lisp/minibuffer.el
@@ -1043,7 +1043,7 @@ completion--styles
(let* ((cat (completion-metadata-get metadata 'category))
(over (completion--category-override cat 'styles)))
(if over
- (delete-dups (append (cdr over) (copy-sequence completion-styles)))
+ (cdr over)
completion-styles)))
(defun completion--nth-completion (n string table pred point metadata)
bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.Lars Ingebrigtsen <larsi@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 22324) by debbugs.gnu.org; 21 Jan 2022 13:46:27 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 21 08:46:27 2022 Received: from localhost ([127.0.0.1]:60711 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1nAuFH-0000uK-8y for submit <at> debbugs.gnu.org; Fri, 21 Jan 2022 08:46:27 -0500 Received: from quimby.gnus.org ([95.216.78.240]:35366) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <larsi@HIDDEN>) id 1nAuFF-0000oZ-Bf for 22324 <at> debbugs.gnu.org; Fri, 21 Jan 2022 08:46:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xT2M2yOg+z+8JPwyf3GN7+k35mAQGkdsWLS337Q7WBE=; b=d2yTLJQz7wRreQ+r/HJMMG+Avj dJhzA7W7XtVGZThByckyS4Cav0iyJlHvQgsQheGsfcuH3Ar24IN8gh3nGf17eUlv4e8dUos4ygIvC 3orWCI4HsngovRks2mqwtCQ4+Fgg0pDIbkW34jNVAy9sKd0D+r2epcFRDmXrPaAmfh0Q=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <larsi@HIDDEN>) id 1nAuF5-0004oj-WF; Fri, 21 Jan 2022 14:46:18 +0100 From: Lars Ingebrigtsen <larsi@HIDDEN> To: Dmitry Gutov <dgutov@HIDDEN> Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead) References: <868u41rv84.fsf@HIDDEN> <83fuy8p8oq.fsf@HIDDEN> <568FA9D0.2040609@HIDDEN> <83egdsp88n.fsf@HIDDEN> <568FABFC.3000205@HIDDEN> <87tufr74of.fsf@HIDDEN> <a1f74c9e-0043-9be9-5739-e87e58dd8fa8@HIDDEN> <87lf0yjwpw.fsf@HIDDEN> <ad66bc96-1f85-850b-4952-35bd6749da02@HIDDEN> <87r1aodus0.fsf@HIDDEN> <66aa873d-5f5f-9024-efb6-e6110c27ab3a@HIDDEN> <87ilvy4m94.fsf@HIDDEN> X-Now-Playing: David Bowie's _Brilliant Adventure (2): The Buddha Of Suburbia_: "Ian Fish, UK Heir" Date: Fri, 21 Jan 2022 14:46:15 +0100 In-Reply-To: <87ilvy4m94.fsf@HIDDEN> (Lars Ingebrigtsen's message of "Thu, 09 Dec 2021 02:09:43 +0100") Message-ID: <87czklnqvs.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen <larsi@HIDDEN> writes: > Dmitry Gutov <dgutov@HIDDEN> writes: > >> Consider changing the behavior instead, though. >> >> Yes, it's been like this for a long time, but I imagine most users >> won't notice the change. >> > [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 22324 Cc: 22324 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Lars Ingebrigtsen <larsi@HIDDEN> writes: > Dmitry Gutov <dgutov@HIDDEN> writes: > >> Consider changing the behavior instead, though. >> >> Yes, it's been like this for a long time, but I imagine most users >> won't notice the change. >> >> We could experiment on master. > > I'd rather not change something as subtle as this (especially in a > mechanism that's been around for a while like this as). Nobody had any further opinions here in a month, so I went ahead and changed the doc string. If somebody feels strongly that the semantics should be tweaked, I don't really have a strong opinion either way. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no
bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.Received: (at 22324) by debbugs.gnu.org; 9 Dec 2021 01:09:58 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 08 20:09:58 2021 Received: from localhost ([127.0.0.1]:41941 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mv7wb-0000OJ-TT for submit <at> debbugs.gnu.org; Wed, 08 Dec 2021 20:09:58 -0500 Received: from quimby.gnus.org ([95.216.78.240]:39504) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <larsi@HIDDEN>) id 1mv7wY-0000O4-VW for 22324 <at> debbugs.gnu.org; Wed, 08 Dec 2021 20:09:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=XbnnXRERAg87hGTyVEkdD6lVyPxfVH5+PkW2P0xny5E=; b=HYtEiDZnVaY49u5w9ZGvmUgFFw yRL1lu2MmpO4L4Y8KYwmCgv8lOssM+NAyT66BrOhEouCrtX1t0NswE8oJRq4kk8O5B0Agj1Wy8gxd tSysVmwubx0svGUTdvqpjy28fZFBzStl4aCT2soV1I6kr+YRdgPsQkZyl+RtYwzSo858=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <larsi@HIDDEN>) id 1mv7wO-0005UN-Ap; Thu, 09 Dec 2021 02:09:48 +0100 From: Lars Ingebrigtsen <larsi@HIDDEN> To: Dmitry Gutov <dgutov@HIDDEN> Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead) References: <868u41rv84.fsf@HIDDEN> <83fuy8p8oq.fsf@HIDDEN> <568FA9D0.2040609@HIDDEN> <83egdsp88n.fsf@HIDDEN> <568FABFC.3000205@HIDDEN> <87tufr74of.fsf@HIDDEN> <a1f74c9e-0043-9be9-5739-e87e58dd8fa8@HIDDEN> <87lf0yjwpw.fsf@HIDDEN> <ad66bc96-1f85-850b-4952-35bd6749da02@HIDDEN> <87r1aodus0.fsf@HIDDEN> <66aa873d-5f5f-9024-efb6-e6110c27ab3a@HIDDEN> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEUtLT9Wcarq7/ai rsT///+j1o5LAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+UMCQECAAFRiq8AAAGXSURBVDjLbZOLteQg CEBBG5CxgUQbEOm/t+UTNXlnmTkmcgMoH0CiAoDgQtRc+mxQRQo8UgirA4AJhISbIJWp+gsgmcUx UV9ZgfvOVOgAlQDh4POYreOyj/X5LrV7H8b1K1RuYxmYokoXdoIeAu2I9hTRi/q5sfm59U/uKB4P QBK7k724HmxVVwgLWL506wAm+2fhQl0y1EIW/3cfazVQb7+BXXepFwiLJ/P6pmewIHTDAr4Czc6W LemFDFCIsLTu0e96gGbfKuEg9YgOrn5qSp4t9pvCVrcmkRQnRcH8ACuJeKK3wR+AfwBFo3xA31sv 1YnR7cY0F6gvYHWrC+QN7r3/L0D6BQB5uXLFAicIoDWPhn9a6Ld9oRYRuS2A26TJ5CkbgHd9hHl8 vuRl9gWwAdUOwgyZryr3OcKw8nFScAlbM/1OJsEtRNKoHDlaNQHRX5+pjB737Gs6tLI8MoKMGJLP PK5pqzKOiuG+UuIArImtY4HB+QFZXDbII5WdFpH6lKKMfL0sKMa6foJnmTGLB8AGQtFR/wDlyU2n njvcHgAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMS0xMi0wOVQwMTowMjowMCswMDowMA5/OOMAAAAl dEVYdGRhdGU6bW9kaWZ5ADIwMjEtMTItMDlUMDE6MDI6MDArMDA6MDB/IoBfAAAAAElFTkSuQmCC X-Now-Playing: Peter Gabriel's _Plays Live (1)_: "The Family and the Fishing Net" Date: Thu, 09 Dec 2021 02:09:43 +0100 In-Reply-To: <66aa873d-5f5f-9024-efb6-e6110c27ab3a@HIDDEN> (Dmitry Gutov's message of "Wed, 8 Dec 2021 01:46:52 +0300") Message-ID: <87ilvy4m94.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dmitry Gutov <dgutov@HIDDEN> writes: > Consider changing the behavior instead, though. > > Yes, it's been like this for a long time, but I imagine most users > won't notice the change. > > We could experiment on master. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 22324 Cc: 22324 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Dmitry Gutov <dgutov@HIDDEN> writes: > Consider changing the behavior instead, though. > > Yes, it's been like this for a long time, but I imagine most users > won't notice the change. > > We could experiment on master. I'd rather not change something as subtle as this (especially in a mechanism that's been around for a while like this as). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no
bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.Received: (at 22324) by debbugs.gnu.org; 7 Dec 2021 22:47:55 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Dec 07 17:47:55 2021 Received: from localhost ([127.0.0.1]:38950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mujFb-00021X-6j for submit <at> debbugs.gnu.org; Tue, 07 Dec 2021 17:47:55 -0500 Received: from mail-lf1-f45.google.com ([209.85.167.45]:44031) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <raaahh@HIDDEN>) id 1mujFW-00020d-Vt for 22324 <at> debbugs.gnu.org; Tue, 07 Dec 2021 17:47:53 -0500 Received: by mail-lf1-f45.google.com with SMTP id b40so1674890lfv.10 for <22324 <at> debbugs.gnu.org>; Tue, 07 Dec 2021 14:47:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=C0W6KGNtorYZ5YKGBnDG+iBKwtjIf3exCrtHTVhELBA=; b=ea6u4H+MeONh2lSPIUOtz2ASTg13qhi9whfxckn1DtAVe36hIhOFyIUrI53JUdpTSs u2qH3/CtKnLkMUXb/Ow1fQkrzAuYTo06IOqR0Hfm9vpYb/sXToowA8WW9IofRlDFKHQA aLfTKGOG7cXZdJsIr91DrebGPMPK3wPBzoqUlV6oL9l56SxepzgDCY/Up3PZqPkDEp2C 9ymct9MWVeigUO5xvNdbX3WsZksY0pHS+Fl0kXqE6qbNGV3fR5A5l6jgNx86SFFzeeFL LxAWSm4QU1ytqKv8m7tlcLjV+yRMhpd+EPYBRzDEIrxBgaAU4CFcaQGuTKmNDs9dxm2J 8b+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=C0W6KGNtorYZ5YKGBnDG+iBKwtjIf3exCrtHTVhELBA=; b=C0AqcnFEUkSm4Qhta9+d3iFeJYryoDkaFsRNHtUA+aKnQfgFxa3gSggVG4IrGAmf5X UifBEHpp6e/tEeTQQwo7cB/yJ8YQrMs+3ct+PzRjwVgVssIG0nv1WYUSj4NzSILpr/RS zHXMM+IFOvNlhRHWbHcMNNZ6WlzBAwM6uO+pupUUZxhC/0naW6l0gCL7B/Dn6qm3yE4B p/5cehLcXoLjyvMaelgX2fMbfvAqPO3v7Xh8jgG2BbmGfOuZDv8ly39RKV2xMmWJScF5 y9ZOZ0KU9sZp39VuKLj6o88277VAsir0TyzJ2ahDDqFcWoDLfzdg74BgmU9eFSMOfA0j NNeA== X-Gm-Message-State: AOAM532mW/qOf+m86tQl9/G5vyXjodqgPkYfudJfOzqmC+yY6o2AumWl 65Du3SMLcDUWFThLD2hHbD13u13/LpA= X-Google-Smtp-Source: ABdhPJxxuRBBrPoihTcxoT/dWwZhFu8iwiRQ+HTUXM3SyYgx5klfw/s39n38NTcs7NmPVLQ8wXozdg== X-Received: by 2002:a19:6b0b:: with SMTP id d11mr16460123lfa.96.1638917264964; Tue, 07 Dec 2021 14:47:44 -0800 (PST) Received: from [192.168.0.103] ([5.18.233.185]) by smtp.googlemail.com with ESMTPSA id b10sm92525lfj.230.2021.12.07.14.47.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Dec 2021 14:47:44 -0800 (PST) Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead) To: Lars Ingebrigtsen <larsi@HIDDEN> References: <868u41rv84.fsf@HIDDEN> <83fuy8p8oq.fsf@HIDDEN> <568FA9D0.2040609@HIDDEN> <83egdsp88n.fsf@HIDDEN> <568FABFC.3000205@HIDDEN> <87tufr74of.fsf@HIDDEN> <a1f74c9e-0043-9be9-5739-e87e58dd8fa8@HIDDEN> <87lf0yjwpw.fsf@HIDDEN> <ad66bc96-1f85-850b-4952-35bd6749da02@HIDDEN> <87r1aodus0.fsf@HIDDEN> From: Dmitry Gutov <dgutov@HIDDEN> Message-ID: <66aa873d-5f5f-9024-efb6-e6110c27ab3a@HIDDEN> Date: Wed, 8 Dec 2021 01:46:52 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <87r1aodus0.fsf@HIDDEN> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 22324 Cc: 22324 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.6 (/) On 07.12.2021 23:28, Lars Ingebrigtsen wrote: > Dmitry Gutov<dgutov@HIDDEN> writes: > >> Perhaps a better word is "prepends". >> >>> So it's two types of overrides. >> If we use the language from the nadvice package, it performs the >> "before-until" combination, rather than the "override" one. > Right. But I don't think that'll make things clearer. > > Perhaps instead of trying to find the perfect word here, we could just > write a paragraph that explains what's happening? Consider changing the behavior instead, though. Yes, it's been like this for a long time, but I imagine most users won't notice the change. We could experiment on master.
bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.Received: (at 22324) by debbugs.gnu.org; 7 Dec 2021 20:28:43 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Dec 07 15:28:43 2021 Received: from localhost ([127.0.0.1]:38765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1muh4t-0002CF-4S for submit <at> debbugs.gnu.org; Tue, 07 Dec 2021 15:28:43 -0500 Received: from quimby.gnus.org ([95.216.78.240]:53566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <larsi@HIDDEN>) id 1muh4r-0002C0-E6 for 22324 <at> debbugs.gnu.org; Tue, 07 Dec 2021 15:28:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rPDhRr9fdeYWofbgkYF8wUZ5+GrdHDXLVnZqaC0MNE8=; b=M0Pf9i99MKcfT+93SliOkhsV85 +KFYHBptq6/9+vL4wiGDnDdWq0vwVTFhkDzqercI8hlnoNtgRqIg3Z8lry/g/hMowGa4VtY57KM72 efEVLogY22H9a9Duu7EgQLlatW5+SxvLrufooxXOzoKMyOlYqBos5m7BtpiPf9MCjIf4=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <larsi@HIDDEN>) id 1muh4i-0002AK-LJ; Tue, 07 Dec 2021 21:28:35 +0100 From: Lars Ingebrigtsen <larsi@HIDDEN> To: Dmitry Gutov <dgutov@HIDDEN> Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead) References: <868u41rv84.fsf@HIDDEN> <83fuy8p8oq.fsf@HIDDEN> <568FA9D0.2040609@HIDDEN> <83egdsp88n.fsf@HIDDEN> <568FABFC.3000205@HIDDEN> <87tufr74of.fsf@HIDDEN> <a1f74c9e-0043-9be9-5739-e87e58dd8fa8@HIDDEN> <87lf0yjwpw.fsf@HIDDEN> <ad66bc96-1f85-850b-4952-35bd6749da02@HIDDEN> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAMAAABg3Am1AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAM1BMVEX+/v7Q7fxtyPqj 3fvr9fkxsvzgtMPTUZ/h1czZlmTlrpfup3KviGSfbExeUD6yVz////+BBqVmAAAAAWJLR0QQlbIN LAAAAAd0SU1FB+UMBxQSAyio3+wAAAFpSURBVEjHxZXRcoQgDEWNRDQS5P//tkkAdbvtBB+2vauA mAOXZJydps8LZpW2QS7RDA4AEAJggNDlbRFm61BWBgu2BgPKIpPhiDCD3NiApe60iJUgc6gDxZWf dTWUl0G9vAO2tr6sk3gBt4NdQMBzYqk+bzsA/AKgeXoHwg9AdYQoURZ4PwNM+AJABRB1XmZsUpqX MzRkXrR6dZFaND22OpCEWy5blnqFECTP0DrEWkyzVofaS0msLI1ozWnSUVzlF1dRjEPAasEWP7ZH jHGza3CDP9ZGe1e0dnOBlFJHZEQuwBeRElH2gHgcmRWROx8iL3GbRmXdhWzEriVd1YhsgGtJgWyu BGB5GAJy5p1YgOwDMTMzaaqIZMS+JTsvkVRARykNA2kUsCglngBU9RigR0AaBegE0hMgn57GAC7C lGeW2hHcDyjeMvpBgEvpmA8w6adWqmgMoNLjB4A9X4TZctP6XaN/Af+pL6x6Fsf3UPEvAAAAJXRF WHRkYXRlOmNyZWF0ZQAyMDIxLTEyLTA3VDIwOjE4OjAzKzAwOjAw9UGG9AAAACV0RVh0ZGF0ZTpt b2RpZnkAMjAyMS0xMi0wN1QyMDoxODowMyswMDowMIQcPkgAAAAASUVORK5CYII= X-Now-Playing: The Human League's _Dare_: "The Sound of the Crowd" Date: Tue, 07 Dec 2021 21:28:31 +0100 In-Reply-To: <ad66bc96-1f85-850b-4952-35bd6749da02@HIDDEN> (Dmitry Gutov's message of "Tue, 7 Dec 2021 04:35:18 +0300") Message-ID: <87r1aodus0.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dmitry Gutov <dgutov@HIDDEN> writes: > Perhaps a better word is "prepends". > >> So it's two types of overrides. > If we use the language from the nadvice package, it performs the > "before-until" combination, rather than the "override" [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 22324 Cc: 22324 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Dmitry Gutov <dgutov@HIDDEN> writes: > Perhaps a better word is "prepends". > >> So it's two types of overrides. > If we use the language from the nadvice package, it performs the > "before-until" combination, rather than the "override" one. Right. But I don't think that'll make things clearer. Perhaps instead of trying to find the perfect word here, we could just write a paragraph that explains what's happening? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no
bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.Received: (at 22324) by debbugs.gnu.org; 7 Dec 2021 01:36:01 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Dec 06 20:36:01 2021 Received: from localhost ([127.0.0.1]:35728 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1muPOj-0003L2-0T for submit <at> debbugs.gnu.org; Mon, 06 Dec 2021 20:36:01 -0500 Received: from mail-lj1-f177.google.com ([209.85.208.177]:38533) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <raaahh@HIDDEN>) id 1muPOh-0003Kn-L2 for 22324 <at> debbugs.gnu.org; Mon, 06 Dec 2021 20:36:00 -0500 Received: by mail-lj1-f177.google.com with SMTP id p8so24437797ljo.5 for <22324 <at> debbugs.gnu.org>; Mon, 06 Dec 2021 17:35:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=yY+zKYxrbx/ijVz8crEbi3KCb5Y2FwSiE2bTouYA/zU=; b=UxKHc7wh2XC9rET+qXx00cfolh+3spOvaR4tg7BmXBLEVZT5CZBTaK6VK6/JI3QXpC CslSxj1xOToAyALgYgNg56mMM9DTjwXHC04bKgb634omqUsPvv988B9+rj9+rbiYRIlN TB3nS4w6HWQ22B3m5wul/k0lJ/BjiQLMYDLBWeEF11mRg27/w/2gH2j8KjU8cDXinVxK Ta6EreDk2Vre074zHH4EaxHBDdVA+mea5wZQdCbCQGSM038cB8BcxJudXtn9dSVhVxfU pVq8+Rcz+aVQGxST9TSe2MSC3dj7lMbH2ZfFt9p7dlwNms1hCXevZxXGHLQIFHAGCk0s H//A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yY+zKYxrbx/ijVz8crEbi3KCb5Y2FwSiE2bTouYA/zU=; b=nGLSWziHI12ERB73KMfWjcZNwidxvJp2spPw+jQZ5+BQj517XI0bcoyN7fTPd5qhXI x6Pzn3sPWjrhEAftny69gs/xgP9SFAAogdAsXy8i5s+vhiBCzdBojYYGbC0/HOM4jonK rpTxz2cuweVDG2sDUNjxG2kNwIPEU8HNMwKgNN14t2C1e1d7towlLHK/oYbABY1RB+aK SMwnq3tphUynLpgYJ+cZIAZbYlPx4q9w8T9NC8hj/fWNutxZN+k8+3UhQLK3z0uSlftS kzeU3crLH1jgEd2hO9RQiv3ERG/vlqmdex7A4Vgk34UHZv09dv32b0lZq6UGoW3MvwMn vfRQ== X-Gm-Message-State: AOAM531C5eHldWqNOBJvQeuLwoE/ZjcQJ1ab8ssKtrmBMUgB1h0BvykM 8W5JXCMPuqGBLl+Fca7qUhrL3oD85m8= X-Google-Smtp-Source: ABdhPJyUCYNVdnYIg/u1+0gLPCj3+JiN2gSP+ZglptqOA/4L2o43vHHXWdGHaa6t8ognSRq3PH7EeA== X-Received: by 2002:a2e:a365:: with SMTP id i5mr38904049ljn.335.1638840953401; Mon, 06 Dec 2021 17:35:53 -0800 (PST) Received: from [192.168.0.103] ([5.18.233.185]) by smtp.googlemail.com with ESMTPSA id h1sm1510939lfp.249.2021.12.06.17.35.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Dec 2021 17:35:52 -0800 (PST) Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead) To: Lars Ingebrigtsen <larsi@HIDDEN> References: <868u41rv84.fsf@HIDDEN> <83fuy8p8oq.fsf@HIDDEN> <568FA9D0.2040609@HIDDEN> <83egdsp88n.fsf@HIDDEN> <568FABFC.3000205@HIDDEN> <87tufr74of.fsf@HIDDEN> <a1f74c9e-0043-9be9-5739-e87e58dd8fa8@HIDDEN> <87lf0yjwpw.fsf@HIDDEN> From: Dmitry Gutov <dgutov@HIDDEN> Message-ID: <ad66bc96-1f85-850b-4952-35bd6749da02@HIDDEN> Date: Tue, 7 Dec 2021 04:35:18 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <87lf0yjwpw.fsf@HIDDEN> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 22324 Cc: 22324 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.6 (/) On 06.12.2021 05:25, Lars Ingebrigtsen wrote: >> As a user, I might try to override it with an entry in >> completion-category-overrides, to use a stricter style like >> 'partial-completion' or even 'basic'. > > Well, it overrides the specific tag/category -- but > completion-category-overrides doesn't (by being non-nil) override the > entirety of completion-category-defaults. Perhaps a better word is "prepends". > So it's two types of overrides. If we use the language from the nadvice package, it performs the "before-until" combination, rather than the "override" one.
bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.
Received: (at 22324) by debbugs.gnu.org; 6 Dec 2021 02:25:44 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Dec 05 21:25:44 2021
Received: from localhost ([127.0.0.1]:60159 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1mu3hI-0000wd-6k
for submit <at> debbugs.gnu.org; Sun, 05 Dec 2021 21:25:44 -0500
Received: from quimby.gnus.org ([95.216.78.240]:58994)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <larsi@HIDDEN>) id 1mu3hG-0000wQ-Fr
for 22324 <at> debbugs.gnu.org; Sun, 05 Dec 2021 21:25:43 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=ay1xLX4WvnjZqtgDhE7CYMJIAhHtHUxP4c/VbsveTU0=; b=kmTC1d7FcMxCj+1dlaLI2oDao0
F1wIs+tn4ajcrH/OKMrF3MNqsxD0MCJ0o5Sdq6Dt1Y6TLRR/iMEewaUN+S87NmNcrng0aCrax+tNi
3poeN5jTHv4TWkPR2F90SlEvzWawc03xAvVs9lCSobbqfUP/gx441XCU+ufmHrNpu+cM=;
Received: from [84.212.220.105] (helo=xo)
by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.92) (envelope-from <larsi@HIDDEN>)
id 1mu3h7-0005Ht-87; Mon, 06 Dec 2021 03:25:36 +0100
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: Dmitry Gutov <dgutov@HIDDEN>
Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't
override completion-styles (gets prepended instead)
References: <868u41rv84.fsf@HIDDEN> <83fuy8p8oq.fsf@HIDDEN>
<568FA9D0.2040609@HIDDEN> <83egdsp88n.fsf@HIDDEN>
<568FABFC.3000205@HIDDEN> <87tufr74of.fsf@HIDDEN>
<a1f74c9e-0043-9be9-5739-e87e58dd8fa8@HIDDEN>
Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj
SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEUhGRMkGxNaOi2+
nJurWkn///+df6DXAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+UMBgESD4NPlTkAAAG+SURBVDjLZZOL
udsgDIUh6QASvQMYXQ3QGga4wdp/ph7JroNj5Yvj8KOjF6R0s8xueCG8ZeLMOdZEWKqDLG5VZnOA
D8Hjppb4NNdxWQ7FVCqHb3v23tsflsIMXUol5Cutj9X+rpRLFd9J/6VI5KV1LBkRfY0S0a5v46Vs
yzuBw+Nx5HkDzxa2TiA6kB/te/tefy9zNQhC/GuzTdbnDPbiEGNo/Vqu5UcvseXaluS9pdhB6VOJ
jy03EFu95hu4yp/gM+7sATFkfA+OzETNhD4BpYcB2GsCmCYOSlUTgDF7RHEQArsCz4gBRoELzYBQ
M2G7g3fP9jKyg/ohlSMD24NMUtWPAvHYgyyXOghnOrQUwI8z7QC/OYK8SJY4ymflFYF0QwSmdE4h
+sSlatv6EoAi4aNXZVhrfSGfsGcZAAeeijj4EZ983IQA4l/z5j5wqnEBUDGehzkYhXcF+PjaEFEA
NDLuhlsJ4H99fmLv+5mq6JASUg7GDKyLqm0R5PTxEW3dsHHDqo3DwwQxvBcBoNaHZ6A6NFkY/rcu
pi08hoqDhlHAq3X1E1S5jB14BB9R6wPJNfdGBgdAd12KGc9D+R9mcWmmh4psdgAAACV0RVh0ZGF0
ZTpjcmVhdGUAMjAyMS0xMi0wNlQwMToxODoxNSswMDowMMirP+kAAAAldEVYdGRhdGU6bW9kaWZ5
ADIwMjEtMTItMDZUMDE6MTg6MTUrMDA6MDC59odVAAAAAElFTkSuQmCC
X-Now-Playing: Neil Young & Crazy Horse's _Live Rust_: "Hey Hey, My My (Into
The Black)"
Date: Mon, 06 Dec 2021 03:25:31 +0100
In-Reply-To: <a1f74c9e-0043-9be9-5739-e87e58dd8fa8@HIDDEN> (Dmitry Gutov's
message of "Mon, 6 Dec 2021 04:16:52 +0300")
Message-ID: <87lf0yjwpw.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
@@CONTACT_ADDRESS@@ for details.
Content preview: Dmitry Gutov <dgutov@HIDDEN> writes: >> (defun
completion--category-override
(category tag) >> (or (assq tag (cdr (assq category
completion-category-overrides)))
>> (assq tag (cdr (assq category completion-category-defaults))))) >> But..
[...] Content analysis details: (-2.9 points, 5.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 22324
Cc: 22324 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Dmitry Gutov <dgutov@HIDDEN> writes:
>> (defun completion--category-override (category tag)
>> (or (assq tag (cdr (assq category completion-category-overrides)))
>> (assq tag (cdr (assq category completion-category-defaults)))))
>> But... I think saying that that "overrides" is fine?
>
> I think an "override" has a particular meaning, and that's replacing
> something that was there before. Not prepending to it.
>
> Why is it important? Suppose the "category defaults" entry has a
> "permissive" style set up for a certain completion category.
>
> As a user, I might try to override it with an entry in
> completion-category-overrides, to use a stricter style like
> 'partial-completion' or even 'basic'.
Well, it overrides the specific tag/category -- but
completion-category-overrides doesn't (by being non-nil) override the
entirety of completion-category-defaults.
So it's two types of overrides.
> But what happens when my input fails to find any completions with the
> style I specified? It will fall back the default one, which is both
> surprising, given the current documentation, and can be problematic
> with respect to performance ('flex' is slower than
> 'partial-completion') and behavior (bringing lots of probably
> irrelevant completions which match my input because 'flex' is quite
> lax).
Yes, it doesn't seem to allow dropping any of them out completely.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.
Received: (at 22324) by debbugs.gnu.org; 6 Dec 2021 01:17:35 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Dec 05 20:17:35 2021
Received: from localhost ([127.0.0.1]:60055 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1mu2dK-00006T-Ql
for submit <at> debbugs.gnu.org; Sun, 05 Dec 2021 20:17:35 -0500
Received: from mail-lf1-f46.google.com ([209.85.167.46]:45965)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <raaahh@HIDDEN>) id 1mu2dI-000065-Va
for 22324 <at> debbugs.gnu.org; Sun, 05 Dec 2021 20:17:33 -0500
Received: by mail-lf1-f46.google.com with SMTP id m27so21283892lfj.12
for <22324 <at> debbugs.gnu.org>; Sun, 05 Dec 2021 17:17:32 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
h=sender:subject:to:cc:references:from:message-id:date:user-agent
:mime-version:in-reply-to:content-language:content-transfer-encoding;
bh=I7VF4ihWGOkCOS6DSike2Qbo1RP4PGRaFuuhex3i0iw=;
b=Hh0bYcNKBGrQI7UUJ2QqNpYP+OeWI+WRGvrBVi5cVve+aKZrN0gMmCWj9l3yIrBEGv
l+YlgrZm7T/nBhZP1QDtLDayZblX13Qdg+Y//vjhSrC3C5He0qQ75LY/QLBLkclC7Al3
uTwe4AS4oc3fNz0kYLSIxOhl5xC2iK9+DmOpZfgK2HWOwVJd5U8Hxdq24at1pndS7Wt+
hW86mc249psNH5gf4KZW2U7PSk0CyW313L2G8ksTu53ldgTxjZHi+I8O/uu+ePQ/Pu3H
E0/RzDvEuWz5V9U5Bmvvp2+Gk6GtZ/Pv4kB9zyYx+aRlJOEn/EWMzx2KuQDUYuPJ2+Cw
X4Xg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:sender:subject:to:cc:references:from:message-id
:date:user-agent:mime-version:in-reply-to:content-language
:content-transfer-encoding;
bh=I7VF4ihWGOkCOS6DSike2Qbo1RP4PGRaFuuhex3i0iw=;
b=Xg9BTRRiw6SJKzuUWecX5UPTwrXgIlnJW5bwcTcXYBGko42UH/xyJHy7v2elHQaico
nFXsdByXGrSb41hh0a+bnDVF+ULdcAd969TVdLiCvVueHSHd2u9cZ1RUUlYZDtzyKZKH
4p8G9gbrMBRNZXm3dOl9nE2IKwzpZ702NIrKLtpax+mroGoL8vvDAfDLvyPZBM6bj0zO
aPBMZjegFqhE2a3mwK9ZekkInrRd8WjLvrLg8DdiOUWVzjN+PysldUfNjjO3MMU1Qcv9
PnxOBaP4ALuu82f/u6Cqaom2ubarF0IIIllDkyeM52mk9mDArcM5wSkBBrSAW3TMNMLE
T2/Q==
X-Gm-Message-State: AOAM531PuqNQm2od4sIeEUQGITsYQPMWFBwtVOcE8ygzM2QrEMYkfdop
/4GEZT4hmndF8/M4tE1CN+0mYuHsqiw=
X-Google-Smtp-Source: ABdhPJz0ms65FX/usvEhObyxVJCR/9dOMztmCsDSroA4chsa85YmA2Uiq4mAtE22at6H0hAfsVbAWA==
X-Received: by 2002:a05:6512:3a91:: with SMTP id
q17mr31012117lfu.425.1638753447005;
Sun, 05 Dec 2021 17:17:27 -0800 (PST)
Received: from [192.168.0.103] ([5.18.233.185])
by smtp.googlemail.com with ESMTPSA id i11sm1207468lfu.141.2021.12.05.17.17.26
(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
Sun, 05 Dec 2021 17:17:26 -0800 (PST)
Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't
override completion-styles (gets prepended instead)
To: Lars Ingebrigtsen <larsi@HIDDEN>
References: <868u41rv84.fsf@HIDDEN> <83fuy8p8oq.fsf@HIDDEN>
<568FA9D0.2040609@HIDDEN> <83egdsp88n.fsf@HIDDEN>
<568FABFC.3000205@HIDDEN> <87tufr74of.fsf@HIDDEN>
From: Dmitry Gutov <dgutov@HIDDEN>
Message-ID: <a1f74c9e-0043-9be9-5739-e87e58dd8fa8@HIDDEN>
Date: Mon, 6 Dec 2021 04:16:52 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <87tufr74of.fsf@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.4 (/)
X-Debbugs-Envelope-To: 22324
Cc: 22324 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.6 (/)
On 02.12.2021 12:10, Lars Ingebrigtsen wrote:
> ---
> This overrides the defaults specified in `completion-category-defaults'."
> ---
>
> And it does indeed prepend:
>
> (defun completion--category-override (category tag)
> (or (assq tag (cdr (assq category completion-category-overrides)))
> (assq tag (cdr (assq category completion-category-defaults)))))
>
> But... I think saying that that "overrides" is fine?
I think an "override" has a particular meaning, and that's replacing
something that was there before. Not prepending to it.
Why is it important? Suppose the "category defaults" entry has a
"permissive" style set up for a certain completion category.
As a user, I might try to override it with an entry in
completion-category-overrides, to use a stricter style like
'partial-completion' or even 'basic'.
But what happens when my input fails to find any completions with the
style I specified? It will fall back the default one, which is both
surprising, given the current documentation, and can be problematic with
respect to performance ('flex' is slower than 'partial-completion') and
behavior (bringing lots of probably irrelevant completions which match
my input because 'flex' is quite lax).
Whether one enjoys the lax behavior of 'flex', is more or less a user
preference, and it seems one can't configure it entirely through
completion-category-overrides. And since that variable is a defcustom
and completion-category-defaults is not, it seems like we're limiting
customization this way.
Though, of course, a user that's motivated enough can change the value
of completion-category-defaults too.
bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.Received: (at 22324) by debbugs.gnu.org; 2 Dec 2021 09:46:13 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Dec 02 04:46:13 2021 Received: from localhost ([127.0.0.1]:46631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1msifM-0004e0-OE for submit <at> debbugs.gnu.org; Thu, 02 Dec 2021 04:46:13 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1msifJ-0004Wx-5k for 22324 <at> debbugs.gnu.org; Thu, 02 Dec 2021 04:46:11 -0500 Received: from [2001:470:142:3::e] (port=36582 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1msifD-0006DK-KC; Thu, 02 Dec 2021 04:46:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ksqny7TRe0XHVdKSG89T/uTSI5Bs7VXpToJuwtPvgKs=; b=rSEzoyNPINHO DMuk4xyKEe+Dq/svEDoAqARbRMPvb7BtxNsMLCkRl+6FA6aU9Vojg1dpTpeJa3a1SExMtFN4zad4c NV/1x+NiBDiJ7VgvYr2gWp44PWH3LOy0/Jfi2EIqP9aZ1t6Stc8fWotjNPyw6cuOF4Km0yiEwmNsf RSKPxtmtPiA1K1gjJtFh7oXHZiVBZuuU9B0/eTxRdGDU5+MEMBbQf/OB/tGzP8QujfMlHdfItlTX4 IRePCNXQeZQmrRAGvU0j9YwEAz8OImyimYdyK+37TjbbkE//mz9RAigZPXf+hguaq37oV0iLtG8V6 qrrZ3lRvuuXRaBzemW4Hww==; Received: from [87.69.77.57] (port=3140 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1msif9-0006tI-1u; Thu, 02 Dec 2021 04:46:00 -0500 Date: Thu, 02 Dec 2021 11:45:45 +0200 Message-Id: <83o85zpcfq.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Lars Ingebrigtsen <larsi@HIDDEN> In-Reply-To: <87tufr74of.fsf@HIDDEN> (message from Lars Ingebrigtsen on Thu, 02 Dec 2021 10:10:40 +0100) Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead) References: <868u41rv84.fsf@HIDDEN> <83fuy8p8oq.fsf@HIDDEN> <568FA9D0.2040609@HIDDEN> <83egdsp88n.fsf@HIDDEN> <568FABFC.3000205@HIDDEN> <87tufr74of.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 22324 Cc: 22324 <at> debbugs.gnu.org, dgutov@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen <larsi@HIDDEN> > Cc: Eli Zaretskii <eliz@HIDDEN>, 22324 <at> debbugs.gnu.org > Date: Thu, 02 Dec 2021 10:10:40 +0100 > > Dmitry Gutov <dgutov@HIDDEN> writes: > > > On 01/08/2016 03:26 PM, Eli Zaretskii wrote: > > > >> Thanks, that wasn't clear from the problem description. Normally, > >> when someone says "the documentation doesn't describe the behavior > >> accurately", they mean the documentation should be updated. > > > > Right, sorry. Poor wording on my part. > > > > But if you were talking about a documentation fix, changing the list > > in `(emacs) Completion Styles' to include `partial-completion' is not > > a good fix semantically, because the result would still contain the > > word "only". > > This bug report is a bit on the vague side. > > It looks like `partial-completion' is documented in that node? > > The subject mentions "doesn't override", but is that about > `completion-category-overrides' instead? > > --- > This overrides the defaults specified in `completion-category-defaults'." > --- > > And it does indeed prepend: > > (defun completion--category-override (category tag) > (or (assq tag (cdr (assq category completion-category-overrides))) > (assq tag (cdr (assq category completion-category-defaults))))) > > But... I think saying that that "overrides" is fine? > > So it's unclear what's suggested in this bug report. I think the problem is that we don't clearly document how the list of styles to be actually used for some CATEGORY is obtained from the various contributions, like completion-category-defaults and completion-category-overrides, and what is the priority of each contribution in the resulting list of styles.
bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.Lars Ingebrigtsen <larsi@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.
Received: (at 22324) by debbugs.gnu.org; 2 Dec 2021 09:11:02 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Dec 02 04:11:01 2021
Received: from localhost ([127.0.0.1]:46537 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1msi7A-0006dl-EV
for submit <at> debbugs.gnu.org; Thu, 02 Dec 2021 04:11:01 -0500
Received: from quimby.gnus.org ([95.216.78.240]:36192)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <larsi@HIDDEN>) id 1msi78-0006dW-VL
for 22324 <at> debbugs.gnu.org; Thu, 02 Dec 2021 04:10:51 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=6OhyrwSyuhinEFGhGmm7r5wmT+kwIefc9N6cJus+Cec=; b=VIkUO9+8bsc7h1z/+VjFWKH0e9
qKslInl1oSP37pWctCxAMfjw/a5rQrDluO9n6rPluRTBTcD5C3yu9DJWypCONukqH4Pw+slzaEkRH
bgOKjkDpSZis6lidmTXKDyWCc0qkv8CL1l5Bw74P9UhDXdX+gkCIIgRXIo/AWczvk/Ao=;
Received: from [84.212.220.105] (helo=xo)
by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.92) (envelope-from <larsi@HIDDEN>)
id 1msi6z-0007gt-BJ; Thu, 02 Dec 2021 10:10:44 +0100
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: Dmitry Gutov <dgutov@HIDDEN>
Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't
override completion-styles (gets prepended instead)
References: <868u41rv84.fsf@HIDDEN> <83fuy8p8oq.fsf@HIDDEN>
<568FA9D0.2040609@HIDDEN> <83egdsp88n.fsf@HIDDEN>
<568FABFC.3000205@HIDDEN>
X-Now-Playing: Mega Bog's _Dolphine_: "Fwee Again"
Date: Thu, 02 Dec 2021 10:10:40 +0100
In-Reply-To: <568FABFC.3000205@HIDDEN> (Dmitry Gutov's message of "Fri, 8
Jan 2016 15:30:52 +0300")
Message-ID: <87tufr74of.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
@@CONTACT_ADDRESS@@ for details.
Content preview: Dmitry Gutov <dgutov@HIDDEN> writes: > On 01/08/2016 03:26
PM, Eli Zaretskii wrote: > >> Thanks, that wasn't clear from the problem
description. Normally, >> when someone says "the documentation doesn't describe
the behavior >> accuratel [...]
Content analysis details: (-2.9 points, 5.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 22324
Cc: Eli Zaretskii <eliz@HIDDEN>, 22324 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Dmitry Gutov <dgutov@HIDDEN> writes:
> On 01/08/2016 03:26 PM, Eli Zaretskii wrote:
>
>> Thanks, that wasn't clear from the problem description. Normally,
>> when someone says "the documentation doesn't describe the behavior
>> accurately", they mean the documentation should be updated.
>
> Right, sorry. Poor wording on my part.
>
> But if you were talking about a documentation fix, changing the list
> in `(emacs) Completion Styles' to include `partial-completion' is not
> a good fix semantically, because the result would still contain the
> word "only".
This bug report is a bit on the vague side.
It looks like `partial-completion' is documented in that node?
The subject mentions "doesn't override", but is that about
`completion-category-overrides' instead?
---
This overrides the defaults specified in `completion-category-defaults'."
---
And it does indeed prepend:
(defun completion--category-override (category tag)
(or (assq tag (cdr (assq category completion-category-overrides)))
(assq tag (cdr (assq category completion-category-defaults)))))
But... I think saying that that "overrides" is fine?
So it's unclear what's suggested in this bug report.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.Received: (at 22324) by debbugs.gnu.org; 8 Jan 2016 15:31:24 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 08 10:31:24 2016 Received: from localhost ([127.0.0.1]:43339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1aHZ0e-0002I6-9S for submit <at> debbugs.gnu.org; Fri, 08 Jan 2016 10:31:24 -0500 Received: from eggs.gnu.org ([208.118.235.92]:56738) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <eliz@HIDDEN>) id 1aHZ0c-0002Ht-RZ for 22324 <at> debbugs.gnu.org; Fri, 08 Jan 2016 10:31:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1aHZ0S-0000HP-W0 for 22324 <at> debbugs.gnu.org; Fri, 08 Jan 2016 10:31:17 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55344) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1aHZ0S-0000HL-TR; Fri, 08 Jan 2016 10:31:12 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1534 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from <eliz@HIDDEN>) id 1aHZ0S-0005cy-6e; Fri, 08 Jan 2016 10:31:12 -0500 Date: Fri, 08 Jan 2016 17:31:10 +0200 Message-Id: <83bn8wozpd.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Dmitry Gutov <dgutov@HIDDEN> In-reply-to: <568FABFC.3000205@HIDDEN> (message from Dmitry Gutov on Fri, 8 Jan 2016 15:30:52 +0300) Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead) References: <868u41rv84.fsf@HIDDEN> <83fuy8p8oq.fsf@HIDDEN> <568FA9D0.2040609@HIDDEN> <83egdsp88n.fsf@HIDDEN> <568FABFC.3000205@HIDDEN> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 22324 Cc: 22324 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Reply-To: Eli Zaretskii <eliz@HIDDEN> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -5.0 (-----) > Cc: 22324 <at> debbugs.gnu.org > From: Dmitry Gutov <dgutov@HIDDEN> > Date: Fri, 8 Jan 2016 15:30:52 +0300 > > On 01/08/2016 03:26 PM, Eli Zaretskii wrote: > > > Thanks, that wasn't clear from the problem description. Normally, > > when someone says "the documentation doesn't describe the behavior > > accurately", they mean the documentation should be updated. > > Right, sorry. Poor wording on my part. No harm done. > But if you were talking about a documentation fix, changing the list in > `(emacs) Completion Styles' to include `partial-completion' is not a > good fix semantically, because the result would still contain the word > "only". Who said I intended to leave that word there? ;-)
bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.Received: (at 22324) by debbugs.gnu.org; 8 Jan 2016 12:31:01 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 08 07:31:01 2016 Received: from localhost ([127.0.0.1]:42344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1aHWC5-0003sf-Fj for submit <at> debbugs.gnu.org; Fri, 08 Jan 2016 07:31:01 -0500 Received: from mail-lb0-f182.google.com ([209.85.217.182]:33109) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <raaahh@HIDDEN>) id 1aHWC4-0003km-83 for 22324 <at> debbugs.gnu.org; Fri, 08 Jan 2016 07:31:00 -0500 Received: by mail-lb0-f182.google.com with SMTP id sv6so216219036lbb.0 for <22324 <at> debbugs.gnu.org>; Fri, 08 Jan 2016 04:31:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=tFxhsw7FsPzpsOXeZezYfBIFTeSdC+gYmKdP+WxyK9Q=; b=W6RDzp9IF59OYpyHoQb+sCZRY3sd11pId6NnjEPZRgWRq2EKkwALDpZub826wq6aLG ujhGQD41kfh1BvvhxG6gFk5dsELqyG/Iq8r98evrNbhVMYnSZU1ACj7r48Bwpj9Ua1NS F6B6Vkym/BzuoRZiPBTXPdSIZw0TN7d8ObirIyu1nyixxtva31hFGwSiYb4g7fFFmHus nqPdnYxTAEAGvcVCfRQLLGscf9Mrm0pabY/SR9Q2bubfXgwey4UIebfaQfd2AYFLxFOS lQHN2pP5fOTLppzP1ttXRlOSp9liBjjdIQeE7ZP/KGG0zWbWxObWQwyiIlvl8Pl3ky7p h16w== X-Received: by 10.112.184.133 with SMTP id eu5mr28787635lbc.99.1452256254505; Fri, 08 Jan 2016 04:30:54 -0800 (PST) Received: from [192.168.1.190] ([178.252.127.222]) by smtp.googlemail.com with ESMTPSA id b135sm1617260lfe.28.2016.01.08.04.30.52 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 08 Jan 2016 04:30:53 -0800 (PST) Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead) To: Eli Zaretskii <eliz@HIDDEN> References: <868u41rv84.fsf@HIDDEN> <83fuy8p8oq.fsf@HIDDEN> <568FA9D0.2040609@HIDDEN> <83egdsp88n.fsf@HIDDEN> From: Dmitry Gutov <dgutov@HIDDEN> Message-ID: <568FABFC.3000205@HIDDEN> Date: Fri, 8 Jan 2016 15:30:52 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:43.0) Gecko/20100101 Thunderbird/43.0 MIME-Version: 1.0 In-Reply-To: <83egdsp88n.fsf@HIDDEN> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 22324 Cc: 22324 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.5 (/) On 01/08/2016 03:26 PM, Eli Zaretskii wrote: > Thanks, that wasn't clear from the problem description. Normally, > when someone says "the documentation doesn't describe the behavior > accurately", they mean the documentation should be updated. Right, sorry. Poor wording on my part. But if you were talking about a documentation fix, changing the list in `(emacs) Completion Styles' to include `partial-completion' is not a good fix semantically, because the result would still contain the word "only".
bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.Received: (at 22324) by debbugs.gnu.org; 8 Jan 2016 12:27:01 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 08 07:27:01 2016 Received: from localhost ([127.0.0.1]:42340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1aHW8C-0002mj-WB for submit <at> debbugs.gnu.org; Fri, 08 Jan 2016 07:27:01 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57278) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <eliz@HIDDEN>) id 1aHW8C-0002mW-9K for 22324 <at> debbugs.gnu.org; Fri, 08 Jan 2016 07:27:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1aHW83-0007sL-6L for 22324 <at> debbugs.gnu.org; Fri, 08 Jan 2016 07:26:55 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47909) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1aHW83-0007sH-30; Fri, 08 Jan 2016 07:26:51 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1472 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from <eliz@HIDDEN>) id 1aHW82-0004uk-Bd; Fri, 08 Jan 2016 07:26:50 -0500 Date: Fri, 08 Jan 2016 14:26:48 +0200 Message-Id: <83egdsp88n.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Dmitry Gutov <dgutov@HIDDEN> In-reply-to: <568FA9D0.2040609@HIDDEN> (message from Dmitry Gutov on Fri, 8 Jan 2016 15:21:36 +0300) Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead) References: <868u41rv84.fsf@HIDDEN> <83fuy8p8oq.fsf@HIDDEN> <568FA9D0.2040609@HIDDEN> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 22324 Cc: 22324 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Reply-To: Eli Zaretskii <eliz@HIDDEN> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -5.0 (-----) > Cc: 22324 <at> debbugs.gnu.org > From: Dmitry Gutov <dgutov@HIDDEN> > Date: Fri, 8 Jan 2016 15:21:36 +0300 > > FTR, I'm not sure it's the documentation that needs fixing. Thanks, that wasn't clear from the problem description. Normally, when someone says "the documentation doesn't describe the behavior accurately", they mean the documentation should be updated.
bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.Received: (at 22324) by debbugs.gnu.org; 8 Jan 2016 12:21:46 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 08 07:21:46 2016 Received: from localhost ([127.0.0.1]:42336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1aHW38-0002ex-DT for submit <at> debbugs.gnu.org; Fri, 08 Jan 2016 07:21:46 -0500 Received: from mail-lf0-f48.google.com ([209.85.215.48]:33338) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <raaahh@HIDDEN>) id 1aHW36-0002ei-Ig for 22324 <at> debbugs.gnu.org; Fri, 08 Jan 2016 07:21:44 -0500 Received: by mail-lf0-f48.google.com with SMTP id m198so26626654lfm.0 for <22324 <at> debbugs.gnu.org>; Fri, 08 Jan 2016 04:21:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=7n+mvoHhgPpgeiPOVsJao4tRNvHDywBPXpvAdRwUCAQ=; b=a1V2eRB0b1EPeNdZand+j2b95AvGcz82vm7s+Dd3cnUE2kwueStA7oTis7dyAuICZZ Bk2+IwRRNDHwgWc5xeFpUzWzvEnFz3ALwE7biMH8DfeyI8jQGj48qzoZq0U7P45S5FSb dcqbtjrhRAR7UL8Gl+WwiocVC3VbOlXvD3+4nslQXsMSBK0822cRMEhLLRkhUfpwXh0N sG2kJ8koYaNMurD9DdsVD7vtH8ixOJ+JB1I6sL9BJGkbpVNQy42uhJomkrMvNR//N+Iw Cf0DyxcSn/mfjnqWmBgpShtSJ2V/Lt42wGRxXQ9DfRgRbf11ZsVhYowmwJjt0LVaJq2H tDxQ== X-Received: by 10.25.86.211 with SMTP id k202mr20541692lfb.69.1452255698756; Fri, 08 Jan 2016 04:21:38 -0800 (PST) Received: from [192.168.1.190] ([178.252.127.222]) by smtp.googlemail.com with ESMTPSA id kz5sm17244068lbc.7.2016.01.08.04.21.37 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 08 Jan 2016 04:21:37 -0800 (PST) Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead) To: Eli Zaretskii <eliz@HIDDEN> References: <868u41rv84.fsf@HIDDEN> <83fuy8p8oq.fsf@HIDDEN> From: Dmitry Gutov <dgutov@HIDDEN> Message-ID: <568FA9D0.2040609@HIDDEN> Date: Fri, 8 Jan 2016 15:21:36 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:43.0) Gecko/20100101 Thunderbird/43.0 MIME-Version: 1.0 In-Reply-To: <83fuy8p8oq.fsf@HIDDEN> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 22324 Cc: 22324 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.5 (/) On 01/08/2016 03:17 PM, Eli Zaretskii wrote: > Would adding `partial-completion' to the list there fix this problem? It would make no difference WRT to resulting behavior. > Or is there anything else that needs to be done? The problem is that the actual behavior and the documented one are different, and should be reconciled. FTR, I'm not sure it's the documentation that needs fixing.
bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.Received: (at 22324) by debbugs.gnu.org; 8 Jan 2016 12:17:24 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 08 07:17:24 2016 Received: from localhost ([127.0.0.1]:42332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1aHVyt-0002Y5-Qi for submit <at> debbugs.gnu.org; Fri, 08 Jan 2016 07:17:24 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54536) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <eliz@HIDDEN>) id 1aHVys-0002Xr-6e for 22324 <at> debbugs.gnu.org; Fri, 08 Jan 2016 07:17:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1aHVyi-0004yY-B2 for 22324 <at> debbugs.gnu.org; Fri, 08 Jan 2016 07:17:17 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47338) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1aHVyi-0004yU-8P; Fri, 08 Jan 2016 07:17:12 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1419 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from <eliz@HIDDEN>) id 1aHVyh-0001hk-GM; Fri, 08 Jan 2016 07:17:11 -0500 Date: Fri, 08 Jan 2016 14:17:09 +0200 Message-Id: <83fuy8p8oq.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Dmitry Gutov <dgutov@HIDDEN> In-reply-to: <868u41rv84.fsf@HIDDEN> (message from Dmitry Gutov on Thu, 07 Jan 2016 23:27:23 +0300) Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead) References: <868u41rv84.fsf@HIDDEN> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 22324 Cc: 22324 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Reply-To: Eli Zaretskii <eliz@HIDDEN> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -5.0 (-----) > From: Dmitry Gutov <dgutov@HIDDEN> > Date: Thu, 07 Jan 2016 23:27:23 +0300 > > As mentioned in > http://lists.gnu.org/archive/html/emacs-devel/2016-01/msg00445.html, > the docstring of completion-category-defaults, as well as its manual > documentation do not describe its behavior accurately. > > (See what `completion--styles' does.) Would adding `partial-completion' to the list there fix this problem? Or is there anything else that needs to be done? Thanks.
bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 7 Jan 2016 20:27:38 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 07 15:27:38 2016 Received: from localhost ([127.0.0.1]:42030 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1aHH9m-0001zo-DZ for submit <at> debbugs.gnu.org; Thu, 07 Jan 2016 15:27:38 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58221) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <raaahh@HIDDEN>) id 1aHH9l-0001zW-24 for submit <at> debbugs.gnu.org; Thu, 07 Jan 2016 15:27:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <raaahh@HIDDEN>) id 1aHH9f-0001JV-5Z for submit <at> debbugs.gnu.org; Thu, 07 Jan 2016 15:27:31 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40278) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <raaahh@HIDDEN>) id 1aHH9f-0001JR-2l for submit <at> debbugs.gnu.org; Thu, 07 Jan 2016 15:27:31 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49181) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <raaahh@HIDDEN>) id 1aHH9e-0007Oc-B1 for bug-gnu-emacs@HIDDEN; Thu, 07 Jan 2016 15:27:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <raaahh@HIDDEN>) id 1aHH9a-0001I6-Bx for bug-gnu-emacs@HIDDEN; Thu, 07 Jan 2016 15:27:30 -0500 Received: from mail-lb0-x22e.google.com ([2a00:1450:4010:c04::22e]:36829) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <raaahh@HIDDEN>) id 1aHH9Z-0001Hg-U3 for bug-gnu-emacs@HIDDEN; Thu, 07 Jan 2016 15:27:26 -0500 Received: by mail-lb0-x22e.google.com with SMTP id oh2so214218774lbb.3 for <bug-gnu-emacs@HIDDEN>; Thu, 07 Jan 2016 12:27:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id:mime-version:content-type; bh=TMtPQPpXK76ti1jZckWB5dd2YumdO7K92miI0ClPlYQ=; b=OvtSq9+jelRrNwJ4ILJIxPr+2beKnwdVU1BtFCP9ihv25DURD5hlfd2jd1jf5dwFqw XwKI32G0N9uSq9vVvqOWt4W6ut9GKB+8Pbdp02LnXxcg37SJS7zQi1/Ai7+YVIb1hmjR pIf19frhmf6zJ0ceyJGvYH16jRPEwyeQ+7GBAHESZgVwQFimyYZ0zZiCnQxfSvI/DDLJ jrhOV2/EPyQMifxCrFMWnV8QMBxxYeCTQLnMmoisZFZaZxqys5Yg7RwA3aRyJ2KyNoEI iKxz9aQ3IDU+7gt/x+l8iKEenmGeE550RUpb77ghjX6IpfETBgqkM3CQsmZ03X4ASB4B ok6Q== X-Received: by 10.112.125.9 with SMTP id mm9mr26872757lbb.113.1452198444985; Thu, 07 Jan 2016 12:27:24 -0800 (PST) Received: from axl ([178.252.127.222]) by smtp.gmail.com with ESMTPSA id r200sm8841154lfd.35.2016.01.07.12.27.23 for <bug-gnu-emacs@HIDDEN> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Jan 2016 12:27:23 -0800 (PST) From: Dmitry Gutov <dgutov@HIDDEN> To: bug-gnu-emacs@HIDDEN Subject: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead) Date: Thu, 07 Jan 2016 23:27:23 +0300 Message-ID: <868u41rv84.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.8 (---) As mentioned in http://lists.gnu.org/archive/html/emacs-devel/2016-01/msg00445.html, the docstring of completion-category-defaults, as well as its manual documentation do not describe its behavior accurately. (See what `completion--styles' does.) In GNU Emacs 25.0.50.5 (x86_64-unknown-linux-gnu, GTK+ Version 3.16.7) of 2016-01-06 built on axl Repository revision: 50575b1bdd7fcb4d1bf525fb5ca635fe7ab7d8c6
Dmitry Gutov <dgutov@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#22324; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.