GNU logs - #22895, boring messages

Message sent to bug-libtool@HIDDEN:

Subject: bug#22895: broken handling of spaces after -{L,R,l}
Resent-From: Michael <mhofma@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-libtool@HIDDEN
Resent-Date: Thu, 03 Mar 2016 10:26:02 +0000
Resent-Message-ID: <handler.22895.B.145700074531343 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 22895 <at> debbugs.gnu.org
From: Michael <mhofma@HIDDEN>
Message-ID: <56D7F887.8090703@HIDDEN>
Date: Thu, 3 Mar 2016 09:40:39 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Icedove/38.6.0
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="------------090702020906090402040503"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

This is a multi-part message in MIME format.
--------------090702020906090402040503
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Hi,

in m4/libtool.m4, the handling of spaces after -{L,R,l} for parsing
linker commands looks as follows:

  case $prev$p in
    -L* | -R* | -l*)
      # Some compilers place space between "-{L,R}" and the path.
      # Remove the space.
      if test x-L = "$p" ||
         test x-R = "$p"; then
         prev=$p
         continue
      fi

This seems to be broken for two reasons:
1. The case handling captures -l, but the following tests consider only
-L and -R.
2. The tests for equality use an x on the left side, but not on the
right side.

A working code should look as follows (patch is attached):

  case $prev$p in
    -L* | -R* | -l*)
      # Some compilers place space between "-{L,R,l}" and the path.
      # Remove the space.
      if test x-L = "x$p" ||
         test x-R = "x$p" ||
         test x-l = "x$p"; then
         prev=$p
         continue
      fi

I stumbled across this bug when using gfortran (5.3.1) which emits the
following (valid) line:

  Driving: gfortran -v conftest.o -l gfortran -l m -shared-libgcc

The current (broken) libtool leads to "-l -l" in the "postdeps_FC"
variable. After the fix, the correct "-lgfortran -lm" appears.


Best regards,
Michael

--------------090702020906090402040503
Content-Type: text/x-patch;
 name="libtool_fix_space_handling.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="libtool_fix_space_handling.patch"

diff --git a/m4/libtool.m4 b/m4/libtool.m4
index ee292af..8349119 100644
--- a/m4/libtool.m4
+++ b/m4/libtool.m4
@@ -7557,10 +7557,11 @@ if AC_TRY_EVAL(ac_compile); then
     case $prev$p in
 
     -L* | -R* | -l*)
-       # Some compilers place space between "-{L,R}" and the path.
+       # Some compilers place space between "-{L,R,l}" and the path.
        # Remove the space.
-       if test x-L = "$p" ||
-          test x-R = "$p"; then
+       if test x-L = "x$p" ||
+          test x-R = "x$p" ||
+          test x-l = "x$p"; then
 	 prev=$p
 	 continue
        fi

--------------090702020906090402040503--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Michael <mhofma@HIDDEN>
Subject: bug#22895: Acknowledgement (broken handling of spaces after -{L,R,l})
Message-ID: <handler.22895.B.145700074531343.ack <at> debbugs.gnu.org>
References: <56D7F887.8090703@HIDDEN>
X-Gnu-PR-Message: ack 22895
X-Gnu-PR-Package: libtool
Reply-To: 22895 <at> debbugs.gnu.org
Date: Thu, 03 Mar 2016 10:26:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-libtool@HIDDEN

If you wish to submit further information on this problem, please
send it to 22895 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
22895: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D22895
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-libtool@HIDDEN:

Subject: bug#22895: broken handling of spaces after -{L,R,l}
Resent-From: Gilles Gouaillardet <gilles.gouaillardet@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-libtool@HIDDEN
Resent-Date: Fri, 04 Mar 2016 06:15:02 +0000
Resent-Message-ID: <handler.22895.B22895.14570720871553 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Michael <mhofma@HIDDEN>
Cc: 22895 <at> debbugs.gnu.org
MIME-Version: 1.0
In-Reply-To: <56D7F887.8090703@HIDDEN>
References: <56D7F887.8090703@HIDDEN>
Date: Fri, 4 Mar 2016 15:14:40 +0900
Message-ID: <CAAkFZ5uym-Ww_FhMWvQPoF+JoeUrOG7LZ03t6bhdXDjD-UEHDA@HIDDEN>
From: Gilles Gouaillardet <gilles.gouaillardet@HIDDEN>
Content-Type: text/plain; charset=UTF-8
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

That sounds like a duplicate of
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=21137

Cheers,

Gilles

On Thu, Mar 3, 2016 at 5:40 PM, Michael <mhofma@HIDDEN> wrote:
> Hi,
>
> in m4/libtool.m4, the handling of spaces after -{L,R,l} for parsing
> linker commands looks as follows:
>
>   case $prev$p in
>     -L* | -R* | -l*)
>       # Some compilers place space between "-{L,R}" and the path.
>       # Remove the space.
>       if test x-L = "$p" ||
>          test x-R = "$p"; then
>          prev=$p
>          continue
>       fi
>
> This seems to be broken for two reasons:
> 1. The case handling captures -l, but the following tests consider only
> -L and -R.
> 2. The tests for equality use an x on the left side, but not on the
> right side.
>
> A working code should look as follows (patch is attached):
>
>   case $prev$p in
>     -L* | -R* | -l*)
>       # Some compilers place space between "-{L,R,l}" and the path.
>       # Remove the space.
>       if test x-L = "x$p" ||
>          test x-R = "x$p" ||
>          test x-l = "x$p"; then
>          prev=$p
>          continue
>       fi
>
> I stumbled across this bug when using gfortran (5.3.1) which emits the
> following (valid) line:
>
>   Driving: gfortran -v conftest.o -l gfortran -l m -shared-libgcc
>
> The current (broken) libtool leads to "-l -l" in the "postdeps_FC"
> variable. After the fix, the correct "-lgfortran -lm" appears.
>
>
> Best regards,
> Michael
>
> _______________________________________________
> Bug-libtool mailing list
> Bug-libtool@HIDDEN
> https://lists.gnu.org/mailman/listinfo/bug-libtool
>

Message sent to bug-libtool@HIDDEN:

Subject: bug#22895: broken handling of spaces after -{L,R,l}
Resent-From: Michael <mhofma@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-libtool@HIDDEN
Resent-Date: Fri, 04 Mar 2016 16:33:02 +0000
Resent-Message-ID: <handler.22895.B22895.145710914213622 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Gilles Gouaillardet <gilles.gouaillardet@HIDDEN>
Cc: 22895 <at> debbugs.gnu.org
References: <56D7F887.8090703@HIDDEN>
 <CAAkFZ5uym-Ww_FhMWvQPoF+JoeUrOG7LZ03t6bhdXDjD-UEHDA@HIDDEN>
From: Michael <mhofma@HIDDEN>
Message-ID: <56D94304.9090202@HIDDEN>
Date: Fri, 4 Mar 2016 09:10:44 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Icedove/38.6.0
MIME-Version: 1.0
In-Reply-To: <CAAkFZ5uym-Ww_FhMWvQPoF+JoeUrOG7LZ03t6bhdXDjD-UEHDA@HIDDEN>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Am 04.03.2016 um 07:14 schrieb Gilles Gouaillardet:
> That sounds like a duplicate of
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=21137

Yes, but only half. Your patch fixes only the missing "x"s in the tests,
but not the missing test for "-l".


Best regards,
Michael

Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.