GNU logs - #30609, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#30609: 26.0.91; underline should be drawn behind text
Resent-From: Aaron Jensen <aaronjensen@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 25 Feb 2018 23:06:02 +0000
Resent-Message-ID: <handler.30609.B.151959994723998 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 30609 <at> debbugs.gnu.org
From: Aaron Jensen <aaronjensen@HIDDEN>
Date: Sun, 25 Feb 2018 15:05:29 -0800
Message-ID: <m2woz0zn46.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

I don't know if it's true on all platforms, but at least on the mac the
text decorations (like underlines) are drawn after the glyph causing
them to overlap the descenders. Typically underlines are drawn behind
the characters as they are less important than the characters
themselves.
I'd be happy to submit a patch to change the order if no one sees a problem with this.

Maybe some day we a text-decoration-skip equivalent, but that's a bit
beyond my capabilities at the moment :)

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Aaron Jensen <aaronjensen@HIDDEN>
Subject: bug#30609: Acknowledgement (26.0.91; underline should be drawn
 behind text)
Message-ID: <handler.30609.B.151959994723998.ack <at> debbugs.gnu.org>
References: <m2woz0zn46.fsf@HIDDEN>
X-Gnu-PR-Message: ack 30609
X-Gnu-PR-Package: emacs
Reply-To: 30609 <at> debbugs.gnu.org
Date: Sun, 25 Feb 2018 23:06:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 30609 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
30609: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D30609
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#30609: 26.0.91; underline should be drawn behind text
References: <m2woz0zn46.fsf@HIDDEN>
In-Reply-To: <m2woz0zn46.fsf@HIDDEN>
Resent-From: Aaron Jensen <aaronjensen@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 26 Feb 2018 03:48:02 +0000
Resent-Message-ID: <handler.30609.B30609.151961682416112 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 30609 <at> debbugs.gnu.org
MIME-Version: 1.0
From: Aaron Jensen <aaronjensen@HIDDEN>
Date: Sun, 25 Feb 2018 19:46:55 -0800
Message-ID: <CAHyO48yHD_tUOb6HRK+VWa9s3KODR2fZXCA5wFUUG5Lpa0q5-g@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

It seems like there's a bit more to this than I thought. It looks like
ns_draw_glyph_string_foreground sometimes draws the background too,
covering the underline. It didn't do this with emacs -Q, but it did
with my config. It seems like I'd need to actually draw the background
separately, then the underline, then the glyph above. Any thoughts
about this or other suggestions?

Thanks,

Aaron

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#30609: 26.0.91; underline should be drawn behind text
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 26 Feb 2018 15:46:02 +0000
Resent-Message-ID: <handler.30609.B30609.151965990614614 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Aaron Jensen <aaronjensen@HIDDEN>
Cc: 30609 <at> debbugs.gnu.org
Reply-To: Eli Zaretskii <eliz@HIDDEN>
Date: Mon, 26 Feb 2018 17:44:56 +0200
Message-Id: <83woyz21s7.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-reply-to: <m2woz0zn46.fsf@HIDDEN> (message from Aaron Jensen on Sun, 25
 Feb 2018 15:05:29 -0800)
References: <m2woz0zn46.fsf@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> From: Aaron Jensen <aaronjensen@HIDDEN>
> Date: Sun, 25 Feb 2018 15:05:29 -0800
> 
> I don't know if it's true on all platforms, but at least on the mac the
> text decorations (like underlines) are drawn after the glyph causing
> them to overlap the descenders. Typically underlines are drawn behind
> the characters as they are less important than the characters
> themselves.
> I'd be happy to submit a patch to change the order if no one sees a problem with this.

I'm far from being an expert in this area, but AFAICT, such a change
could cause the underline to become partially or even fully invisible,
at least in some situations.  For example, if the underline is to be
drawn below one or more images, or some special characters, or what we
use to display characters with no font.  That's because we sometimes
clear the entire character cell with the background color before
drawing the foreground, and that would erase the part of the underline
below that cell.  Right?

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#30609: 26.0.91; underline should be drawn behind text
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 26 Feb 2018 15:47:01 +0000
Resent-Message-ID: <handler.30609.B30609.151965997114733 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 30609
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Aaron Jensen <aaronjensen@HIDDEN>
Cc: 30609 <at> debbugs.gnu.org
Reply-To: Eli Zaretskii <eliz@HIDDEN>
Received: via spool by 30609-submit <at> debbugs.gnu.org id=B30609.151965997114733
          (code B ref 30609); Mon, 26 Feb 2018 15:47:01 +0000
Received: (at 30609) by debbugs.gnu.org; 26 Feb 2018 15:46:11 +0000
Received: from localhost ([127.0.0.1]:33658 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1eqKyh-0003pY-5c
	for submit <at> debbugs.gnu.org; Mon, 26 Feb 2018 10:46:11 -0500
Received: from eggs.gnu.org ([208.118.235.92]:54266)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1eqKyg-0003pN-IE
 for 30609 <at> debbugs.gnu.org; Mon, 26 Feb 2018 10:46:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <eliz@HIDDEN>) id 1eqKyZ-0005xz-Gm
 for 30609 <at> debbugs.gnu.org; Mon, 26 Feb 2018 10:46:05 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,T_RP_MATCHES_RCVD
 autolearn=disabled version=3.3.2
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45832)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>)
 id 1eqKyZ-0005xe-CS; Mon, 26 Feb 2018 10:46:03 -0500
Received: from [176.228.60.248] (port=4456 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@HIDDEN>)
 id 1eqKyY-0007TY-TF; Mon, 26 Feb 2018 10:46:03 -0500
Date: Mon, 26 Feb 2018 17:46:05 +0200
Message-Id: <83vaej21qa.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-reply-to: <CAHyO48yHD_tUOb6HRK+VWa9s3KODR2fZXCA5wFUUG5Lpa0q5-g@HIDDEN>
 (message from Aaron Jensen on Sun, 25 Feb 2018 19:46:55 -0800)
References: <m2woz0zn46.fsf@HIDDEN>
 <CAHyO48yHD_tUOb6HRK+VWa9s3KODR2fZXCA5wFUUG5Lpa0q5-g@HIDDEN>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-Spam-Score: -5.0 (-----)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -5.0 (-----)

> From: Aaron Jensen <aaronjensen@HIDDEN>
> Date: Sun, 25 Feb 2018 19:46:55 -0800
> 
> It seems like there's a bit more to this than I thought. It looks like
> ns_draw_glyph_string_foreground sometimes draws the background too,
> covering the underline. It didn't do this with emacs -Q, but it did
> with my config. It seems like I'd need to actually draw the background
> separately, then the underline, then the glyph above. Any thoughts
> about this or other suggestions?

Yes, this is what I feared, and that's why I think simply switching
the order will not give good results.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#30609: 26.0.91; underline should be drawn behind text
Resent-From: Aaron Jensen <aaronjensen@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 26 Feb 2018 21:11:02 +0000
Resent-Message-ID: <handler.30609.B30609.151967941518928 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 30609
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 30609 <at> debbugs.gnu.org
Received: via spool by 30609-submit <at> debbugs.gnu.org id=B30609.151967941518928
          (code B ref 30609); Mon, 26 Feb 2018 21:11:02 +0000
Received: (at 30609) by debbugs.gnu.org; 26 Feb 2018 21:10:15 +0000
Received: from localhost ([127.0.0.1]:34006 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1eqQ2I-0004vE-Qb
	for submit <at> debbugs.gnu.org; Mon, 26 Feb 2018 16:10:15 -0500
Received: from mail-qt0-f176.google.com ([209.85.216.176]:42747)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <aaronjensen@HIDDEN>) id 1eqQ2G-0004v2-Ok
 for 30609 <at> debbugs.gnu.org; Mon, 26 Feb 2018 16:10:12 -0500
Received: by mail-qt0-f176.google.com with SMTP id t6so11072852qtn.9
 for <30609 <at> debbugs.gnu.org>; Mon, 26 Feb 2018 13:10:12 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc; bh=uV4R+LWVk8Fl7WW+SZDHQqkii//IlPuDllI1PyO5htM=;
 b=G8ErxjI+w3+vtzhLX+GYZeXRgzYwBvprtKCiUWT4NPh0HN+Hs1M29DDTD8DEMzeEHm
 7F1AH3Qi2Svge4wthsi0vbb3cvVSn6FzBRpVvQ6N8wlqd2lKTthQD74DC2ekybrUFY4F
 lV6BT4d2i43nUSMfStrMcJsXwqKVZsMgVPxXgeyKjuVcB/pIZ6PhaMKphjUS7RAdQ5oj
 G1aJxYQRlPZlHo54bw4/000D/zXAJW1GbNorIaWsO2rP8eZb4rrsYH30pXNG6NZc4iyh
 sgtaoSVawNHhKEW/05N1D7LH4PDnpXGl2maS9dtPwMylFwyZFmYIFmKUpIMD3zYTs8EE
 GBvQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=uV4R+LWVk8Fl7WW+SZDHQqkii//IlPuDllI1PyO5htM=;
 b=jSAZbXWDajB+vuZQFCJ6hinDt7+aCHiS8LGvOq98tXqjQq81TK8DxCTaJCjOzSWoiZ
 ibICKsPKhryUauZ3laVi5KkbK6YXniLiyAA/wXgZiKCvUT8TbX04m98RBYk3CCvXfrTg
 Rr6sZ/3RcJlky5b5g2F4nmHvS5GJDJGUU1fmHFJBmQVKkSZvABGydbFz9YXI4eLapaoR
 KZF5wjBPfZfBxQKoKNxLSPk4ILxXQ4+R9JapFoYHlze2Q+GXg5bulYoGOYB0mj+hDOI0
 4kQi3n9Zznqr+gDWn5HHL6V31MYMFFtKOZ2JDn9OUR5tOPxmO+/0eXf4A9+bciqueIq8
 Uaag==
X-Gm-Message-State: APf1xPCEsflC7D9n+KHc/U8RAwfzGXfjAXnDIPIYezvzzZfL1Eh7S/B/
 YzH0kPbPgeJZalkDwXqMLgS+hnJ4Rr2dIwIunV8=
X-Google-Smtp-Source: AG47ELuS+ztUI3B8hgXSoE9q7DbCPKLo2+ICP1EmkoM2slhXJAl3dmn08pM+WIFeAlZ4U3HL/18JaH/ZhsdVAfAHRs8=
X-Received: by 10.237.35.76 with SMTP id i12mr19182766qtc.134.1519679407486;
 Mon, 26 Feb 2018 13:10:07 -0800 (PST)
MIME-Version: 1.0
Received: by 10.237.54.65 with HTTP; Mon, 26 Feb 2018 13:10:06 -0800 (PST)
In-Reply-To: <83vaej21qa.fsf@HIDDEN>
References: <m2woz0zn46.fsf@HIDDEN>
 <CAHyO48yHD_tUOb6HRK+VWa9s3KODR2fZXCA5wFUUG5Lpa0q5-g@HIDDEN>
 <83vaej21qa.fsf@HIDDEN>
From: Aaron Jensen <aaronjensen@HIDDEN>
Date: Mon, 26 Feb 2018 13:10:06 -0800
Message-ID: <CAHyO48xq5EFZ+PszxH8uwr2apV0vZ9_dvda0_G=BoCJk37o2FA@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

On Mon, Feb 26, 2018 at 7:46 AM, Eli Zaretskii <eliz@HIDDEN> wrote:
> Yes, this is what I feared, and that's why I think simply switching
> the order will not give good results.

I may be able to move the text decoration code to the font drawing,
but text decoration is done for more than fonts, so that could result
in some duplication or nsterm referencing nsfont which would then
reference nsterm. If that's ok, I can look into that.

The other option would be to move the background drawing code out of
the font rendering. I don't know all of the places that it is done, so
that may be cumbersome.

One other, completely different idea that may not work or may be
really slow would be to do a color replacement--only replacing pixels
that match the background color with the underline color. I have no
idea if reading from the canvas in this way is slow. This would end up
giving a similar effect to text-decoration-skip.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#30609: 26.0.91; underline should be drawn behind text
Resent-From: Alan Third <athird@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 26 Feb 2018 21:39:01 +0000
Resent-Message-ID: <handler.30609.B30609.151968111021385 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 30609
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Aaron Jensen <aaronjensen@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, 30609 <at> debbugs.gnu.org
Received: via spool by 30609-submit <at> debbugs.gnu.org id=B30609.151968111021385
          (code B ref 30609); Mon, 26 Feb 2018 21:39:01 +0000
Received: (at 30609) by debbugs.gnu.org; 26 Feb 2018 21:38:30 +0000
Received: from localhost ([127.0.0.1]:34017 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1eqQTc-0005Yo-FD
	for submit <at> debbugs.gnu.org; Mon, 26 Feb 2018 16:38:30 -0500
Received: from mail-io0-f181.google.com ([209.85.223.181]:44697)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <athird@HIDDEN>) id 1eqQTb-0005Yc-A2
 for 30609 <at> debbugs.gnu.org; Mon, 26 Feb 2018 16:38:27 -0500
Received: by mail-io0-f181.google.com with SMTP id h23so8278562iob.11
 for <30609 <at> debbugs.gnu.org>; Mon, 26 Feb 2018 13:38:27 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=googlemail.com; s=20161025;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc; bh=8r3rtDyfdoS10VYxOitiQLGRBVC6B3ZIv4G/13MB0/8=;
 b=DH6FL/cSLY7Yqh5zoL5vp4W+axd3LajdrG3g7lr798P8dyeRafFrydkDJHoHiFfVqq
 FkTXKwGTZq+RfshewQ9o8tmCdDB4w5OQKk+WJAiqb/VAYhhr0AFNhcGJhnl0DUKjYvi4
 k3Zbq+5mGHAHgQOcWm9521j1p55jZiU96L0R/5kbiUxbjyOktkPYm9hiMh9+kEQHz5Yl
 EtlzPDxHgUZxF7/etu/hwVEtWc3StOXvByui8Wsg7S5ECiE0AK8WQ2yhs2uVRugV6HP2
 pRC+JkVbIpfAF2nXt4zby7ArOW9Utm2nKLc8Er+nrxH48HFtAk6u6S8EK4SOUCCycjZs
 kAlA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=8r3rtDyfdoS10VYxOitiQLGRBVC6B3ZIv4G/13MB0/8=;
 b=Sr09C+poiYUAfd7B0FKdN1uyY5GhHQ3ehqORx7B5g95PJsYXfIL74zWZVHSGWucjMA
 scrGFLkiKJ4JNCo402XTFI2QR8ZomYbq44tHO5+0J1ooRl+Kd6aVu6gD5CHXihq7TJ7u
 FVlJlplEN0VG6e3rG3Jtlu3DI9UW1xJGRRUNNr5cMAxqDQtt41fBLftb3qPDxS4qRG74
 yWFVHfygInAf7vZuZdYgXXQ4g9DfjUl4tTsGzS5wCAnR+pv69S/SYHh25CGqMHaC3ibt
 04TgVmX0SlDZpDYqFLHZ74x4YP/HrtKeVIRLQnbPpT5qiKe5wkwo192JdSGpzjje5U1S
 rRMg==
X-Gm-Message-State: APf1xPDbVw+N5cUyuGlOr7L6d78cW38Uwla7AQoTUEeSQoVl1zZmcolG
 a/ZUw8KQCVJ4IF3tEdvfQa95z6kbZgdTzieRwZw=
X-Google-Smtp-Source: AG47ELshIbRMHgI87Xw757aKUbYVUEkX9qD2XPSg7LNhlWlODhWe54UH0ytIfvbyVSEuaYAnJECC5LtmfcCGBUTHczU=
X-Received: by 10.107.78.1 with SMTP id c1mr13883749iob.120.1519681101345;
 Mon, 26 Feb 2018 13:38:21 -0800 (PST)
MIME-Version: 1.0
Received: by 10.79.141.82 with HTTP; Mon, 26 Feb 2018 13:38:20 -0800 (PST)
Received: by 10.79.141.82 with HTTP; Mon, 26 Feb 2018 13:38:20 -0800 (PST)
In-Reply-To: <CAHyO48xq5EFZ+PszxH8uwr2apV0vZ9_dvda0_G=BoCJk37o2FA@HIDDEN>
References: <m2woz0zn46.fsf@HIDDEN>
 <CAHyO48yHD_tUOb6HRK+VWa9s3KODR2fZXCA5wFUUG5Lpa0q5-g@HIDDEN>
 <83vaej21qa.fsf@HIDDEN>
 <CAHyO48xq5EFZ+PszxH8uwr2apV0vZ9_dvda0_G=BoCJk37o2FA@HIDDEN>
From: Alan Third <athird@HIDDEN>
Date: Mon, 26 Feb 2018 21:38:20 +0000
Message-ID: <CABGBtwmJVkGpZqyNVARr8s1H5ZWibGHx8BQGD0QNpWF1CZPfDA@HIDDEN>
Content-Type: multipart/alternative; boundary="f403043cc55837b7cb05662454c0"
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.0 (/)

--f403043cc55837b7cb05662454c0
Content-Type: text/plain; charset="UTF-8"

On 26 Feb 2018 9:11 p.m., "Aaron Jensen" <aaronjensen@HIDDEN> wrote:


I may be able to move the text decoration code to the font drawing,
but text decoration is done for more than fonts, so that could result
in some duplication or nsterm referencing nsfont which would then
reference nsterm. If that's ok, I can look into that.


The NS port has two font backends: nsfont and macfont. If you make changes
you'll have to support both.

--f403043cc55837b7cb05662454c0
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div><br><div class=3D"gmail_extra"><br><div class=3D"gma=
il_quote">On 26 Feb 2018 9:11 p.m., &quot;Aaron Jensen&quot; &lt;<a href=3D=
"mailto:aaronjensen@HIDDEN">aaronjensen@HIDDEN</a>&gt; wrote:<br type=
=3D"attribution"><blockquote class=3D"quote" style=3D"margin:0 0 0 .8ex;bor=
der-left:1px #ccc solid;padding-left:1ex"><div class=3D"quoted-text"><br>
</div>I may be able to move the text decoration code to the font drawing,<b=
r>
but text decoration is done for more than fonts, so that could result<br>
in some duplication or nsterm referencing nsfont which would then<br>
reference nsterm. If that&#39;s ok, I can look into that.<br></blockquote><=
/div></div></div><div dir=3D"auto"><br></div><div dir=3D"auto">The NS port =
has two font backends: nsfont and macfont. If you make changes you&#39;ll h=
ave to support both.</div><div dir=3D"auto"><div class=3D"gmail_extra"><div=
 class=3D"gmail_quote"><blockquote class=3D"quote" style=3D"margin:0 0 0 .8=
ex;border-left:1px #ccc solid;padding-left:1ex"></blockquote></div></div></=
div></div>

--f403043cc55837b7cb05662454c0--

Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.