Received: (at 30609) by debbugs.gnu.org; 26 Feb 2018 21:38:30 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 26 16:38:30 2018 Received: from localhost ([127.0.0.1]:34017 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1eqQTc-0005Yo-FD for submit <at> debbugs.gnu.org; Mon, 26 Feb 2018 16:38:30 -0500 Received: from mail-io0-f181.google.com ([209.85.223.181]:44697) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <athird@HIDDEN>) id 1eqQTb-0005Yc-A2 for 30609 <at> debbugs.gnu.org; Mon, 26 Feb 2018 16:38:27 -0500 Received: by mail-io0-f181.google.com with SMTP id h23so8278562iob.11 for <30609 <at> debbugs.gnu.org>; Mon, 26 Feb 2018 13:38:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=8r3rtDyfdoS10VYxOitiQLGRBVC6B3ZIv4G/13MB0/8=; b=DH6FL/cSLY7Yqh5zoL5vp4W+axd3LajdrG3g7lr798P8dyeRafFrydkDJHoHiFfVqq FkTXKwGTZq+RfshewQ9o8tmCdDB4w5OQKk+WJAiqb/VAYhhr0AFNhcGJhnl0DUKjYvi4 k3Zbq+5mGHAHgQOcWm9521j1p55jZiU96L0R/5kbiUxbjyOktkPYm9hiMh9+kEQHz5Yl EtlzPDxHgUZxF7/etu/hwVEtWc3StOXvByui8Wsg7S5ECiE0AK8WQ2yhs2uVRugV6HP2 pRC+JkVbIpfAF2nXt4zby7ArOW9Utm2nKLc8Er+nrxH48HFtAk6u6S8EK4SOUCCycjZs kAlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=8r3rtDyfdoS10VYxOitiQLGRBVC6B3ZIv4G/13MB0/8=; b=Sr09C+poiYUAfd7B0FKdN1uyY5GhHQ3ehqORx7B5g95PJsYXfIL74zWZVHSGWucjMA scrGFLkiKJ4JNCo402XTFI2QR8ZomYbq44tHO5+0J1ooRl+Kd6aVu6gD5CHXihq7TJ7u FVlJlplEN0VG6e3rG3Jtlu3DI9UW1xJGRRUNNr5cMAxqDQtt41fBLftb3qPDxS4qRG74 yWFVHfygInAf7vZuZdYgXXQ4g9DfjUl4tTsGzS5wCAnR+pv69S/SYHh25CGqMHaC3ibt 04TgVmX0SlDZpDYqFLHZ74x4YP/HrtKeVIRLQnbPpT5qiKe5wkwo192JdSGpzjje5U1S rRMg== X-Gm-Message-State: APf1xPDbVw+N5cUyuGlOr7L6d78cW38Uwla7AQoTUEeSQoVl1zZmcolG a/ZUw8KQCVJ4IF3tEdvfQa95z6kbZgdTzieRwZw= X-Google-Smtp-Source: AG47ELshIbRMHgI87Xw757aKUbYVUEkX9qD2XPSg7LNhlWlODhWe54UH0ytIfvbyVSEuaYAnJECC5LtmfcCGBUTHczU= X-Received: by 10.107.78.1 with SMTP id c1mr13883749iob.120.1519681101345; Mon, 26 Feb 2018 13:38:21 -0800 (PST) MIME-Version: 1.0 Received: by 10.79.141.82 with HTTP; Mon, 26 Feb 2018 13:38:20 -0800 (PST) Received: by 10.79.141.82 with HTTP; Mon, 26 Feb 2018 13:38:20 -0800 (PST) In-Reply-To: <CAHyO48xq5EFZ+PszxH8uwr2apV0vZ9_dvda0_G=BoCJk37o2FA@HIDDEN> References: <m2woz0zn46.fsf@HIDDEN> <CAHyO48yHD_tUOb6HRK+VWa9s3KODR2fZXCA5wFUUG5Lpa0q5-g@HIDDEN> <83vaej21qa.fsf@HIDDEN> <CAHyO48xq5EFZ+PszxH8uwr2apV0vZ9_dvda0_G=BoCJk37o2FA@HIDDEN> From: Alan Third <athird@HIDDEN> Date: Mon, 26 Feb 2018 21:38:20 +0000 Message-ID: <CABGBtwmJVkGpZqyNVARr8s1H5ZWibGHx8BQGD0QNpWF1CZPfDA@HIDDEN> Subject: Re: bug#30609: 26.0.91; underline should be drawn behind text To: Aaron Jensen <aaronjensen@HIDDEN> Content-Type: multipart/alternative; boundary="f403043cc55837b7cb05662454c0" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30609 Cc: Eli Zaretskii <eliz@HIDDEN>, 30609 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.0 (/) --f403043cc55837b7cb05662454c0 Content-Type: text/plain; charset="UTF-8" On 26 Feb 2018 9:11 p.m., "Aaron Jensen" <aaronjensen@HIDDEN> wrote: I may be able to move the text decoration code to the font drawing, but text decoration is done for more than fonts, so that could result in some duplication or nsterm referencing nsfont which would then reference nsterm. If that's ok, I can look into that. The NS port has two font backends: nsfont and macfont. If you make changes you'll have to support both. --f403043cc55837b7cb05662454c0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"auto"><div><br><div class=3D"gmail_extra"><br><div class=3D"gma= il_quote">On 26 Feb 2018 9:11 p.m., "Aaron Jensen" <<a href=3D= "mailto:aaronjensen@HIDDEN">aaronjensen@HIDDEN</a>> wrote:<br type= =3D"attribution"><blockquote class=3D"quote" style=3D"margin:0 0 0 .8ex;bor= der-left:1px #ccc solid;padding-left:1ex"><div class=3D"quoted-text"><br> </div>I may be able to move the text decoration code to the font drawing,<b= r> but text decoration is done for more than fonts, so that could result<br> in some duplication or nsterm referencing nsfont which would then<br> reference nsterm. If that's ok, I can look into that.<br></blockquote><= /div></div></div><div dir=3D"auto"><br></div><div dir=3D"auto">The NS port = has two font backends: nsfont and macfont. If you make changes you'll h= ave to support both.</div><div dir=3D"auto"><div class=3D"gmail_extra"><div= class=3D"gmail_quote"><blockquote class=3D"quote" style=3D"margin:0 0 0 .8= ex;border-left:1px #ccc solid;padding-left:1ex"></blockquote></div></div></= div></div> --f403043cc55837b7cb05662454c0--
bug-gnu-emacs@HIDDEN:bug#30609; Package emacs.
Full text available.Received: (at 30609) by debbugs.gnu.org; 26 Feb 2018 21:10:15 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 26 16:10:15 2018 Received: from localhost ([127.0.0.1]:34006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1eqQ2I-0004vE-Qb for submit <at> debbugs.gnu.org; Mon, 26 Feb 2018 16:10:15 -0500 Received: from mail-qt0-f176.google.com ([209.85.216.176]:42747) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <aaronjensen@HIDDEN>) id 1eqQ2G-0004v2-Ok for 30609 <at> debbugs.gnu.org; Mon, 26 Feb 2018 16:10:12 -0500 Received: by mail-qt0-f176.google.com with SMTP id t6so11072852qtn.9 for <30609 <at> debbugs.gnu.org>; Mon, 26 Feb 2018 13:10:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=uV4R+LWVk8Fl7WW+SZDHQqkii//IlPuDllI1PyO5htM=; b=G8ErxjI+w3+vtzhLX+GYZeXRgzYwBvprtKCiUWT4NPh0HN+Hs1M29DDTD8DEMzeEHm 7F1AH3Qi2Svge4wthsi0vbb3cvVSn6FzBRpVvQ6N8wlqd2lKTthQD74DC2ekybrUFY4F lV6BT4d2i43nUSMfStrMcJsXwqKVZsMgVPxXgeyKjuVcB/pIZ6PhaMKphjUS7RAdQ5oj G1aJxYQRlPZlHo54bw4/000D/zXAJW1GbNorIaWsO2rP8eZb4rrsYH30pXNG6NZc4iyh sgtaoSVawNHhKEW/05N1D7LH4PDnpXGl2maS9dtPwMylFwyZFmYIFmKUpIMD3zYTs8EE GBvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=uV4R+LWVk8Fl7WW+SZDHQqkii//IlPuDllI1PyO5htM=; b=jSAZbXWDajB+vuZQFCJ6hinDt7+aCHiS8LGvOq98tXqjQq81TK8DxCTaJCjOzSWoiZ ibICKsPKhryUauZ3laVi5KkbK6YXniLiyAA/wXgZiKCvUT8TbX04m98RBYk3CCvXfrTg Rr6sZ/3RcJlky5b5g2F4nmHvS5GJDJGUU1fmHFJBmQVKkSZvABGydbFz9YXI4eLapaoR KZF5wjBPfZfBxQKoKNxLSPk4ILxXQ4+R9JapFoYHlze2Q+GXg5bulYoGOYB0mj+hDOI0 4kQi3n9Zznqr+gDWn5HHL6V31MYMFFtKOZ2JDn9OUR5tOPxmO+/0eXf4A9+bciqueIq8 Uaag== X-Gm-Message-State: APf1xPCEsflC7D9n+KHc/U8RAwfzGXfjAXnDIPIYezvzzZfL1Eh7S/B/ YzH0kPbPgeJZalkDwXqMLgS+hnJ4Rr2dIwIunV8= X-Google-Smtp-Source: AG47ELuS+ztUI3B8hgXSoE9q7DbCPKLo2+ICP1EmkoM2slhXJAl3dmn08pM+WIFeAlZ4U3HL/18JaH/ZhsdVAfAHRs8= X-Received: by 10.237.35.76 with SMTP id i12mr19182766qtc.134.1519679407486; Mon, 26 Feb 2018 13:10:07 -0800 (PST) MIME-Version: 1.0 Received: by 10.237.54.65 with HTTP; Mon, 26 Feb 2018 13:10:06 -0800 (PST) In-Reply-To: <83vaej21qa.fsf@HIDDEN> References: <m2woz0zn46.fsf@HIDDEN> <CAHyO48yHD_tUOb6HRK+VWa9s3KODR2fZXCA5wFUUG5Lpa0q5-g@HIDDEN> <83vaej21qa.fsf@HIDDEN> From: Aaron Jensen <aaronjensen@HIDDEN> Date: Mon, 26 Feb 2018 13:10:06 -0800 Message-ID: <CAHyO48xq5EFZ+PszxH8uwr2apV0vZ9_dvda0_G=BoCJk37o2FA@HIDDEN> Subject: Re: bug#30609: 26.0.91; underline should be drawn behind text To: Eli Zaretskii <eliz@HIDDEN> Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30609 Cc: 30609 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) On Mon, Feb 26, 2018 at 7:46 AM, Eli Zaretskii <eliz@HIDDEN> wrote: > Yes, this is what I feared, and that's why I think simply switching > the order will not give good results. I may be able to move the text decoration code to the font drawing, but text decoration is done for more than fonts, so that could result in some duplication or nsterm referencing nsfont which would then reference nsterm. If that's ok, I can look into that. The other option would be to move the background drawing code out of the font rendering. I don't know all of the places that it is done, so that may be cumbersome. One other, completely different idea that may not work or may be really slow would be to do a color replacement--only replacing pixels that match the background color with the underline color. I have no idea if reading from the canvas in this way is slow. This would end up giving a similar effect to text-decoration-skip.
bug-gnu-emacs@HIDDEN:bug#30609; Package emacs.
Full text available.Received: (at 30609) by debbugs.gnu.org; 26 Feb 2018 15:46:11 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 26 10:46:11 2018 Received: from localhost ([127.0.0.1]:33658 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1eqKyh-0003pY-5c for submit <at> debbugs.gnu.org; Mon, 26 Feb 2018 10:46:11 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1eqKyg-0003pN-IE for 30609 <at> debbugs.gnu.org; Mon, 26 Feb 2018 10:46:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1eqKyZ-0005xz-Gm for 30609 <at> debbugs.gnu.org; Mon, 26 Feb 2018 10:46:05 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45832) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1eqKyZ-0005xe-CS; Mon, 26 Feb 2018 10:46:03 -0500 Received: from [176.228.60.248] (port=4456 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <eliz@HIDDEN>) id 1eqKyY-0007TY-TF; Mon, 26 Feb 2018 10:46:03 -0500 Date: Mon, 26 Feb 2018 17:46:05 +0200 Message-Id: <83vaej21qa.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Aaron Jensen <aaronjensen@HIDDEN> In-reply-to: <CAHyO48yHD_tUOb6HRK+VWa9s3KODR2fZXCA5wFUUG5Lpa0q5-g@HIDDEN> (message from Aaron Jensen on Sun, 25 Feb 2018 19:46:55 -0800) Subject: Re: bug#30609: 26.0.91; underline should be drawn behind text References: <m2woz0zn46.fsf@HIDDEN> <CAHyO48yHD_tUOb6HRK+VWa9s3KODR2fZXCA5wFUUG5Lpa0q5-g@HIDDEN> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30609 Cc: 30609 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Reply-To: Eli Zaretskii <eliz@HIDDEN> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -5.0 (-----) > From: Aaron Jensen <aaronjensen@HIDDEN> > Date: Sun, 25 Feb 2018 19:46:55 -0800 > > It seems like there's a bit more to this than I thought. It looks like > ns_draw_glyph_string_foreground sometimes draws the background too, > covering the underline. It didn't do this with emacs -Q, but it did > with my config. It seems like I'd need to actually draw the background > separately, then the underline, then the glyph above. Any thoughts > about this or other suggestions? Yes, this is what I feared, and that's why I think simply switching the order will not give good results.
bug-gnu-emacs@HIDDEN:bug#30609; Package emacs.
Full text available.Received: (at 30609) by debbugs.gnu.org; 26 Feb 2018 15:45:06 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 26 10:45:06 2018 Received: from localhost ([127.0.0.1]:33654 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1eqKxd-0003nd-Qu for submit <at> debbugs.gnu.org; Mon, 26 Feb 2018 10:45:06 -0500 Received: from eggs.gnu.org ([208.118.235.92]:53872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1eqKxZ-0003mq-Mf for 30609 <at> debbugs.gnu.org; Mon, 26 Feb 2018 10:45:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1eqKxS-0005FE-1k for 30609 <at> debbugs.gnu.org; Mon, 26 Feb 2018 10:44:56 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45809) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1eqKxR-0005F8-UL; Mon, 26 Feb 2018 10:44:53 -0500 Received: from [176.228.60.248] (port=4455 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <eliz@HIDDEN>) id 1eqKxR-0007Kz-9Q; Mon, 26 Feb 2018 10:44:53 -0500 Date: Mon, 26 Feb 2018 17:44:56 +0200 Message-Id: <83woyz21s7.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Aaron Jensen <aaronjensen@HIDDEN> In-reply-to: <m2woz0zn46.fsf@HIDDEN> (message from Aaron Jensen on Sun, 25 Feb 2018 15:05:29 -0800) Subject: Re: bug#30609: 26.0.91; underline should be drawn behind text References: <m2woz0zn46.fsf@HIDDEN> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30609 Cc: 30609 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Reply-To: Eli Zaretskii <eliz@HIDDEN> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -5.0 (-----) > From: Aaron Jensen <aaronjensen@HIDDEN> > Date: Sun, 25 Feb 2018 15:05:29 -0800 > > I don't know if it's true on all platforms, but at least on the mac the > text decorations (like underlines) are drawn after the glyph causing > them to overlap the descenders. Typically underlines are drawn behind > the characters as they are less important than the characters > themselves. > I'd be happy to submit a patch to change the order if no one sees a problem with this. I'm far from being an expert in this area, but AFAICT, such a change could cause the underline to become partially or even fully invisible, at least in some situations. For example, if the underline is to be drawn below one or more images, or some special characters, or what we use to display characters with no font. That's because we sometimes clear the entire character cell with the background color before drawing the foreground, and that would erase the part of the underline below that cell. Right?
bug-gnu-emacs@HIDDEN:bug#30609; Package emacs.
Full text available.Received: (at 30609) by debbugs.gnu.org; 26 Feb 2018 03:47:04 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 25 22:47:04 2018 Received: from localhost ([127.0.0.1]:60878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1eq9kl-0004Bl-Se for submit <at> debbugs.gnu.org; Sun, 25 Feb 2018 22:47:04 -0500 Received: from mail-qt0-f172.google.com ([209.85.216.172]:42798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <aaronjensen@HIDDEN>) id 1eq9kk-0004BG-33 for 30609 <at> debbugs.gnu.org; Sun, 25 Feb 2018 22:47:02 -0500 Received: by mail-qt0-f172.google.com with SMTP id t6so7799317qtn.9 for <30609 <at> debbugs.gnu.org>; Sun, 25 Feb 2018 19:47:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=ee2y0034LZt2axouTuk4PzYq+klMyNTO9DCkFjU59Lg=; b=P1NrXV7UZutjt8Pr1LQ8ahCPTi14FTkLmuVTKE00zMCAmQYZPhVfRB2WpTgt1JOoFY LaeGlDBF9jVGQWCf5jKQqgEDG9A5iJIzY923UFU0EBOAAJbhzIIQR5CS9n71NmhHW3V4 ctJTcUMQf1X8ht1pmGAGCU5FirDK/h6ctz7EzaOlTNZmjZSCquyYrp4ujGD9ZYWi8F1u aABx0jUz6M+ik+IikgvvbHhe9xglMS5R7R+CgANvtXwGsfBVs6MX0GZF/yOgQ/u/5pL0 Z6tSD8rEvrx+wIAoKJPPD4EB4FCNPlbj0zOuOVNFiTDJOa8njo5al1aHG8Wtz7jrPKB5 ++GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=ee2y0034LZt2axouTuk4PzYq+klMyNTO9DCkFjU59Lg=; b=i4i9tJWu0ECOeXBK1RkCyWCof60I/zUrV/KBeM9Hay/5O68PaeKLwWQsPUDiw5yG4v bN23JDGLaYXWHUumw59GZdQUGN+s1MBvUm4lc1DRz60DjEUU3PSp0RyiaJQDfQhOfI6g rfTSwuW3QF+2MDTyReRO2Nv97FZFRxoOnyb+luYEg1YpPp34C0Lx5vMV4CAkob4C5+cE R7zunqNzfzndXpiMIqHfAgnhWjmTsrEt7iuktW1HXlvx0wvtw4dfLqZFPPLhvcqu+2u6 0eIntxVUP9lHmGSS32C4tmFrtIVsFouEgusO0J7YlQEVrweFMD42JryGe4mnPHrJhKe+ OdgQ== X-Gm-Message-State: APf1xPC63l0nkpxlgIHVtVnYn76I3uj6/9Zj15Tt3K7+ggyrpZbM2+O9 +SulQtF+yjUFEWSMIxYEMXb+Ee1xnKwWFosGmqdX1Q== X-Google-Smtp-Source: AG47ELv/nz5DTMwnF4DLHh0R6glnbxYHNwFFTFSc6Q5W4Nn1qPOqAt9/bfor4NypsbgNd/Axa3GygpkLKAs2F3g25WE= X-Received: by 10.200.7.77 with SMTP id k13mr15392342qth.165.1519616815678; Sun, 25 Feb 2018 19:46:55 -0800 (PST) MIME-Version: 1.0 Received: by 10.237.54.65 with HTTP; Sun, 25 Feb 2018 19:46:55 -0800 (PST) From: Aaron Jensen <aaronjensen@HIDDEN> Date: Sun, 25 Feb 2018 19:46:55 -0800 Message-ID: <CAHyO48yHD_tUOb6HRK+VWa9s3KODR2fZXCA5wFUUG5Lpa0q5-g@HIDDEN> Subject: Re: 26.0.91; underline should be drawn behind text To: 30609 <at> debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30609 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) It seems like there's a bit more to this than I thought. It looks like ns_draw_glyph_string_foreground sometimes draws the background too, covering the underline. It didn't do this with emacs -Q, but it did with my config. It seems like I'd need to actually draw the background separately, then the underline, then the glyph above. Any thoughts about this or other suggestions? Thanks, Aaron
bug-gnu-emacs@HIDDEN:bug#30609; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 25 Feb 2018 23:05:47 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 25 18:05:47 2018 Received: from localhost ([127.0.0.1]:60717 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1eq5MZ-0006Ez-HZ for submit <at> debbugs.gnu.org; Sun, 25 Feb 2018 18:05:47 -0500 Received: from eggs.gnu.org ([208.118.235.92]:59382) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <aaronjensen@HIDDEN>) id 1eq5MX-0006Em-CQ for submit <at> debbugs.gnu.org; Sun, 25 Feb 2018 18:05:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <aaronjensen@HIDDEN>) id 1eq5MR-0004r5-GP for submit <at> debbugs.gnu.org; Sun, 25 Feb 2018 18:05:40 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:38648) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from <aaronjensen@HIDDEN>) id 1eq5MR-0004qn-D6 for submit <at> debbugs.gnu.org; Sun, 25 Feb 2018 18:05:39 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50346) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <aaronjensen@HIDDEN>) id 1eq5MQ-0006eh-ER for bug-gnu-emacs@HIDDEN; Sun, 25 Feb 2018 18:05:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <aaronjensen@HIDDEN>) id 1eq5ML-0004l4-HE for bug-gnu-emacs@HIDDEN; Sun, 25 Feb 2018 18:05:38 -0500 Received: from mail-pl0-x22c.google.com ([2607:f8b0:400e:c01::22c]:38065) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from <aaronjensen@HIDDEN>) id 1eq5ML-0004kT-BA for bug-gnu-emacs@HIDDEN; Sun, 25 Feb 2018 18:05:33 -0500 Received: by mail-pl0-x22c.google.com with SMTP id d4so8197723pll.5 for <bug-gnu-emacs@HIDDEN>; Sun, 25 Feb 2018 15:05:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=QWvc5CNJSROmIxiciJAHlBsHsqupPQyHbds51ADWv6M=; b=ZzaTlUGBn8ydXQtVQ9XNZWtLNjs8pDtMU6Nlmt8S8FKntBIBDWBMDjfSIi915ZCXYi Dw1015DMra7jP+gKPfZKs+KLi6ghTkPlIe4LAIEk01Anm8Cmbg2FIZYjayodC2scImR4 oAypac9BJv4UaVuKBXkcyN31JnBGiKKTP1NDz8TIEfmfHeLqf1BAzAqhw8GJFh+FLShx mFYONUYKNDall7Cr/MrAanQH5lUnUnbVeBG53pmwRS34rrO1UJLDB941hp8kWa5hplF8 f2LamCS7ug1F1MSqq+S3JXHrIWMOoL5mka7vytHYwQThuYzVxO6xpF+JCPtJlqLtVxCF Te6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=QWvc5CNJSROmIxiciJAHlBsHsqupPQyHbds51ADWv6M=; b=he086aa1wJ7pX6r9KPVswXGXyCIbNV2BC1Obgp8ImsrU79aXl7OFvtp0c4NKToRH1M eKGQcWxX0vArV6s2IQT3ctlyRHBYrUTtIAaK1h+mUZKVr23eOYhsZVvFReg24DuGuwSt C3u2jbILr7015ETaM/gnSpmlGH8sajEtOSWZ0tnj0Oe+jr+Z9+EjzIxFjWj4Sc9uGAC0 L0AdDuVptbHUx+uH/vFaVA2fGjoOqkuVx8jvE092diyXYTZtWVXki8EzSGWmuUD6rZAR XFVHxjf/oU2WcqwLB7L7wX7yfyt6H37Yhfu8yV360ceyFwyr/9yhTcSC+4Po2Uy0pf5w ouvg== X-Gm-Message-State: APf1xPBJ64851ekoZ+muXJWZvLSLTB8BP3cqseuWl0NvPkQR940qNDj0 Ca2gBrgf86xwfPspbOBaUy/S8SQd X-Google-Smtp-Source: AH8x224bVdYhhtZ5/Zq1219ZLmxfeU2E1y4KhZ1c5TXA3ZOiRPozfV4GgMiyDLXz4mPZSlHlz68sgA== X-Received: by 2002:a17:902:9885:: with SMTP id s5-v6mr8823505plp.400.1519599931853; Sun, 25 Feb 2018 15:05:31 -0800 (PST) Received: from aaron-mbt.local (c-76-28-156-232.hsd1.wa.comcast.net. [76.28.156.232]) by smtp.gmail.com with ESMTPSA id t85sm15875556pfg.159.2018.02.25.15.05.30 for <bug-gnu-emacs@HIDDEN> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 25 Feb 2018 15:05:30 -0800 (PST) From: Aaron Jensen <aaronjensen@HIDDEN> To: bug-gnu-emacs@HIDDEN Subject: 26.0.91; underline should be drawn behind text Date: Sun, 25 Feb 2018 15:05:29 -0800 Message-ID: <m2woz0zn46.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -4.0 (----) I don't know if it's true on all platforms, but at least on the mac the text decorations (like underlines) are drawn after the glyph causing them to overlap the descenders. Typically underlines are drawn behind the characters as they are less important than the characters themselves. I'd be happy to submit a patch to change the order if no one sees a problem with this. Maybe some day we a text-decoration-skip equivalent, but that's a bit beyond my capabilities at the moment :)
Aaron Jensen <aaronjensen@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#30609; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.