GNU bug report logs - #33467
"diff" can not scan directories with same dev/inode

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: diffutils; Reported by: Delian Krustev <krustev-diffutils@HIDDEN>; dated Thu, 22 Nov 2018 16:04:02 UTC; Maintainer for diffutils is bug-diffutils@HIDDEN.

Message received at 33467 <at> debbugs.gnu.org:


Received: (at 33467) by debbugs.gnu.org; 30 Nov 2018 23:41:04 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 30 18:41:04 2018
Received: from localhost ([127.0.0.1]:56688 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1gSsP8-0003lP-TJ
	for submit <at> debbugs.gnu.org; Fri, 30 Nov 2018 18:41:03 -0500
Received: from zimbra.cs.ucla.edu ([131.179.128.68]:33674)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eggert@HIDDEN>) id 1gSsP6-0003kl-Nq
 for 33467 <at> debbugs.gnu.org; Fri, 30 Nov 2018 18:41:01 -0500
Received: from localhost (localhost [127.0.0.1])
 by zimbra.cs.ucla.edu (Postfix) with ESMTP id 7BE8A160544;
 Fri, 30 Nov 2018 15:40:54 -0800 (PST)
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
 by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032)
 with ESMTP id pzpaLjTyZvz5; Fri, 30 Nov 2018 15:40:53 -0800 (PST)
Received: from localhost (localhost [127.0.0.1])
 by zimbra.cs.ucla.edu (Postfix) with ESMTP id 9E72E160524;
 Fri, 30 Nov 2018 15:40:53 -0800 (PST)
X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
 by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026)
 with ESMTP id nYPgXpshZBXG; Fri, 30 Nov 2018 15:40:53 -0800 (PST)
Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200])
 by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 7EE461604F2;
 Fri, 30 Nov 2018 15:40:53 -0800 (PST)
Subject: Re: [bug-diffutils] bug#33467: bug#33467: bug#33467: bug#33467:
 "diff" can not scan directories with same dev/inode
To: Delian Krustev <krustev-diffutils@HIDDEN>, 33467 <at> debbugs.gnu.org
References: <58c517f3-6ae0-d0e2-3e35-a8a605ee4838@HIDDEN>
 <dbdd4bbc-f1a3-3d6a-2633-076e5552bbeb@HIDDEN> <2261323.X7QU81BNaR@home>
From: Paul Eggert <eggert@HIDDEN>
Openpgp: preference=signencrypt
Autocrypt: addr=eggert@HIDDEN; prefer-encrypt=mutual; keydata=
 xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9
 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS
 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl
 KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss
 mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK
 QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2
 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC
 OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+
 KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB
 n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy
 dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG
 FQgCCQoLBBYCAwECHgECF4AACgkQ7ZfpDmKqfjRRGw/+Ij03dhYfYl/gXVRiuzV1gGrbHk+t
 nfrI/C7fAeoFzQ5tVgVinShaPkZo0HTPf18x6IDEdAiO8Mqo1yp0CtHmzGMCJ50o4Grgfjlr
 6g/+vtEOKbhleszN2XpJvpwM2QgGvn/laTLUu8PH9aRWTs7qJJZKKKAb4sxYc92FehPu6FOD
 0dDiyhlDAq4lOV2mdBpzQbiojoZzQLMQwjpgCTK2572eK9EOEQySUThXrSIz6ASenp4NYTFH
 s9tuJQvXk9gZDdPSl3bp+47dGxlxEWLpBIM7zIONw4ks4azgT8nvDZxA5IZHtvqBlJLBObYY
 0Le61Wp0y3TlBDh2qdK8eYL426W4scEMSuig5gb8OAtQiBW6k2sGUxxeiv8ovWu8YAZgKJfu
 oWI+uRnMEddruY8JsoM54KaKvZikkKs2bg1ndtLVzHpJ6qFZC7QVjeHUh6/BmgvdjWPZYFTt
 N+KA9CWX3GQKKgN3uu988yznD7LnB98T4EUH1HA/GnfBqMV1gpzTvPc4qVQinCmIkEFp83zl
 +G5fCjJJ3W7ivzCnYo4KhKLpFUm97okTKR2LW3xZzEW4cLSWO387MTK3CzDOx5qe6s4a91Zu
 ZM/j/TQdTLDaqNn83kA4Hq48UHXYxcIh+Nd8k/3w6lFuoK0wrOFiywjLx+0ur5jmmbecBGHc
 1xdhAFHOwU0ETIByZAEQAKaF678T9wyH4wjTrV1Pz3cDEoSnV/0ZUrOT37p1dcGyj/IXq1x6
 70HRVahAmk0sZpYc25PF9D5GPYHFWlNjuPU96rDndXB3hedmBRhLdC4bAXjI4DV+bmdVe+q/
 IMnlZRaVlm9EiMCVAR6w13sReu7qXkW9r3RwY2AzXskp/tAe4BRKr1Zmbvi2nbnQ6epEC42r
 Rbx0B1EhjbIQZ5JHGk24iPT7LdBgnNmos5wYjzwNlkMQD5T0Ydzhk7J+UxwA5m46mOhRDC2r
 FV/A0gm5TLy8DXjv/Esc4gYnYai6SQqnUEVh5LuV8YCJBnijs+Tiw71x1icmn6xGI45EugJO
 gec+rLypYgpVp4x0HI5T88qBRYCkxH3Kg8Qo+EWNA9A4LRQ9DX8njona0gf0s03tocK8kBN6
 6UoqqPtHBnc4eMgBymCflK12eKfd2YYxnyg9cZazWA5VslvTxpm76hbg5oiAEH/Vg/8MxHyA
 nPhfrgwyPrmJEcVBafdspJnYQxBYNco2LFPIhlOvWh8r4at+s+M3Lb26oUTczlgdW1Sf3SDA
 77BMRnF0FQyE+7AzV79MBN4ykiqaezQxtaF1Fy/tvkhffSo8u+dwG0EgJh+te38gTcISVr0G
 IPplLz6YhjrbHrPRF1CN5UuL9DBGjxuN35RLNVEfta6RUFlR6NctTjvrABEBAAHCwWUEGAEC
 AA8FAkyAcmQCGwwFCRLMAwAACgkQ7ZfpDmKqfjSrHA/+KzAKvTxRhA9MWNLxIyJ7S5uJ16gs
 T3oCjZrBKGEhKMOGX4O0GA6VOEryO7QRCCYah3oxSG38IAnNeiwJXgU9Bzkk85UGbPEd7HGF
 /VSeHCQwWou6jqUDTSDvn9YhNTdG0KXPM74aC+xr2Zow1O2mhXihgWKD0Dw+0LYPnUOsQ0KO
 FxHXXYHmRrS1OZPU59BLvc+TRhIhafSHKLwbXK+6ckkxBx6h8z5ccpG0Qs4bFhdFYnFrEieD
 LoGmnE2YLhdV6swJ9VNCS6pLiEohT3fm7aXm15tZOIyzMZhHRSAPblXxQ0ZSWjq8oRrcYNFx
 c4W1URpAkBCOYJoXvQfD5L3lqAl8TCqDUzYxhH/tJhbDdHrqHH767jaDaTB1+Talp/2AMKwc
 XNOdiklGxbmHVG6YGl6g8Lrbsu9NZEI4yLlHzuikthJWgz+3vZhVGyNlt+HNIoF6CjDL2omu
 5cEq4RDHM44QqPk6l7O0pUvN1mT4B+S1b08RKpqm/ff015E37HNV/piIvJlxGAYz8PSfuGCB
 1thMYqlmgdhd9/BabGFbGGYHA6U4/T5zqU+f6xHy1SsAQZ1MSKlLwekBIT+4/cLRGqCHjnV0
 q5H/T6a7t5mPkbzSrOLSo4puj+IToNjYyYIDBWzhlA19avOa+rvUjmHtD3sFN7cXWtkGoi8b
 uNcby4U=
Organization: UCLA Computer Science Department
Message-ID: <1da8d307-2657-33d3-3d8e-0a197129ad73@HIDDEN>
Date: Fri, 30 Nov 2018 15:40:53 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.1
MIME-Version: 1.0
In-Reply-To: <2261323.X7QU81BNaR@home>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 33467
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

On 11/30/18 5:09 AM, Delian Krustev wrote:
> This can be easily cross-reported to LKML. If "diff" developers blame the
> kernel/fs both parties should discuss it as its unacceptable a core utility to
> be unusable. ( I'm pretty sure though, that the kernel developers will be
> convinced that it does not need change. )

In that case I suppose we are at an impasse, and it's the poor users who 
will have to suffer. :-)

Seriously, POSIX is clear that dev+ino uniquely identifies a file, and 
many applications rely on this property. If a filesystem chooses to 
depart from standard behavior it hardly seems realistic to expect 
developers to change all their programs to work around the 
incompatibility, particularly if workarounds lead to slow behavior or 
incorrect behavior or both.

It shouldn't be that hard for the filesystem in question to invent inode 
numbers specific to the particular instance of the file. This sort of 
game has been played for years for Microsoft filesystems that lack 
inodes, and although the game can't be played perfectly in practice it 
seems to work well enough to keep users happy. Better, of course, would 
be proper support for inode numbers.





Information forwarded to bug-diffutils@HIDDEN:
bug#33467; Package diffutils. Full text available.

Message received at 33467 <at> debbugs.gnu.org:


Received: (at 33467) by debbugs.gnu.org; 30 Nov 2018 14:17:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 30 09:17:05 2018
Received: from localhost ([127.0.0.1]:55659 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1gSjbN-0006Rd-M0
	for submit <at> debbugs.gnu.org; Fri, 30 Nov 2018 09:17:05 -0500
Received: from mx1.redhat.com ([209.132.183.28]:54026)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eblake@HIDDEN>) id 1gSjbM-0006R2-3D
 for 33467 <at> debbugs.gnu.org; Fri, 30 Nov 2018 09:17:04 -0500
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com
 [10.5.11.23])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 2E6783001FC8;
 Fri, 30 Nov 2018 14:16:58 +0000 (UTC)
Received: from [10.3.117.105] (ovpn-117-105.phx2.redhat.com [10.3.117.105])
 by smtp.corp.redhat.com (Postfix) with ESMTP id C641419489;
 Fri, 30 Nov 2018 14:16:57 +0000 (UTC)
Subject: Re: [bug-diffutils] bug#33467: bug#33467: bug#33467: "diff" can not
 scan directories with same dev/inode
To: Delian Krustev <krustev-diffutils@HIDDEN>, bug-diffutils@HIDDEN
References: <58c517f3-6ae0-d0e2-3e35-a8a605ee4838@HIDDEN>
 <dbdd4bbc-f1a3-3d6a-2633-076e5552bbeb@HIDDEN> <2261323.X7QU81BNaR@home>
From: Eric Blake <eblake@HIDDEN>
Organization: Red Hat, Inc.
Message-ID: <f212a963-7b33-8250-8389-ee8ce7485b5e@HIDDEN>
Date: Fri, 30 Nov 2018 08:16:57 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.0
MIME-Version: 1.0
In-Reply-To: <2261323.X7QU81BNaR@home>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.45]); Fri, 30 Nov 2018 14:16:58 +0000 (UTC)
X-Spam-Score: -5.0 (-----)
X-Debbugs-Envelope-To: 33467
Cc: 33467 <at> debbugs.gnu.org, Mark Raymond <markr@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -6.0 (------)

On 11/30/18 7:09 AM, Delian Krustev wrote:

> This can be easily cross-reported to LKML. If "diff" developers blame the
> kernel/fs both parties should discuss it as its unacceptable a core utility to
> be unusable. ( I'm pretty sure though, that the kernel developers will be
> convinced that it does not need change. )
> 
> All we need is command line option which can turn off the comparison by dev/
> inode. Does not sound like too much work.

Except that it does not scale. Working around a kernel/filesystem bug in 
every single affected user space app is nowhere near as efficient as 
just fixing the kernel/filesystem bug.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org




Information forwarded to bug-diffutils@HIDDEN:
bug#33467; Package diffutils. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 30 Nov 2018 14:17:14 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 30 09:17:14 2018
Received: from localhost ([127.0.0.1]:55662 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1gSjbU-0006Rx-WC
	for submit <at> debbugs.gnu.org; Fri, 30 Nov 2018 09:17:14 -0500
Received: from eggs.gnu.org ([208.118.235.92]:43834)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eblake@HIDDEN>) id 1gSjbT-0006Rk-1d
 for submit <at> debbugs.gnu.org; Fri, 30 Nov 2018 09:17:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <eblake@HIDDEN>) id 1gSjbL-0002LB-IE
 for submit <at> debbugs.gnu.org; Fri, 30 Nov 2018 09:17:04 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled
 version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:52477)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <eblake@HIDDEN>) id 1gSjbL-0002L0-E7
 for submit <at> debbugs.gnu.org; Fri, 30 Nov 2018 09:17:03 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53434)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <eblake@HIDDEN>) id 1gSjbK-0007O5-KU
 for bug-diffutils@HIDDEN; Fri, 30 Nov 2018 09:17:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <eblake@HIDDEN>) id 1gSjbH-0002J2-Cd
 for bug-diffutils@HIDDEN; Fri, 30 Nov 2018 09:17:02 -0500
Received: from mx1.redhat.com ([209.132.183.28]:39310)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <eblake@HIDDEN>) id 1gSjbH-0002If-4l
 for bug-diffutils@HIDDEN; Fri, 30 Nov 2018 09:16:59 -0500
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com
 [10.5.11.23])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 2E6783001FC8;
 Fri, 30 Nov 2018 14:16:58 +0000 (UTC)
Received: from [10.3.117.105] (ovpn-117-105.phx2.redhat.com [10.3.117.105])
 by smtp.corp.redhat.com (Postfix) with ESMTP id C641419489;
 Fri, 30 Nov 2018 14:16:57 +0000 (UTC)
Subject: Re: [bug-diffutils] bug#33467: bug#33467: bug#33467: "diff" can not
 scan directories with same dev/inode
To: Delian Krustev <krustev-diffutils@HIDDEN>, bug-diffutils@HIDDEN
References: <58c517f3-6ae0-d0e2-3e35-a8a605ee4838@HIDDEN>
 <dbdd4bbc-f1a3-3d6a-2633-076e5552bbeb@HIDDEN> <2261323.X7QU81BNaR@home>
From: Eric Blake <eblake@HIDDEN>
Organization: Red Hat, Inc.
Message-ID: <f212a963-7b33-8250-8389-ee8ce7485b5e@HIDDEN>
Date: Fri, 30 Nov 2018 08:16:57 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.0
MIME-Version: 1.0
In-Reply-To: <2261323.X7QU81BNaR@home>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.45]); Fri, 30 Nov 2018 14:16:58 +0000 (UTC)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
 [fuzzy]
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -4.1 (----)
X-Debbugs-Envelope-To: submit
Cc: 33467 <at> debbugs.gnu.org, Mark Raymond <markr@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -5.1 (-----)

On 11/30/18 7:09 AM, Delian Krustev wrote:

> This can be easily cross-reported to LKML. If "diff" developers blame the
> kernel/fs both parties should discuss it as its unacceptable a core utility to
> be unusable. ( I'm pretty sure though, that the kernel developers will be
> convinced that it does not need change. )
> 
> All we need is command line option which can turn off the comparison by dev/
> inode. Does not sound like too much work.

Except that it does not scale. Working around a kernel/filesystem bug in 
every single affected user space app is nowhere near as efficient as 
just fixing the kernel/filesystem bug.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org




Information forwarded to bug-diffutils@HIDDEN:
bug#33467; Package diffutils. Full text available.

Message received at 33467 <at> debbugs.gnu.org:


Received: (at 33467) by debbugs.gnu.org; 30 Nov 2018 14:08:05 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 30 09:08:05 2018
Received: from localhost ([127.0.0.1]:55646 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1gSjSf-0006Da-4p
	for submit <at> debbugs.gnu.org; Fri, 30 Nov 2018 09:08:05 -0500
Received: from prime.netspace.pro ([51.15.249.167]:49624)
 by debbugs.gnu.org with smtp (Exim 4.84_2)
 (envelope-from <krustev-diffutils@HIDDEN>) id 1gSjSa-0006D0-Q9
 for 33467 <at> debbugs.gnu.org; Fri, 30 Nov 2018 09:08:02 -0500
Received: (qmail 18789 invoked from network); 30 Nov 2018 13:09:54 -0000
X-Bad-FCrDNS: no ( immune - auth, relay, whitelist, etc )
Received: from 84-238-173-183.ip.btc-net.bg (HELO home.localnet)
 (84.238.173.183)
 by prime.netspace.pro (qpsmtpd/0.94) with (ECDHE-RSA-AES256-GCM-SHA384
 encrypted) ESMTPSA; Fri, 30 Nov 2018 13:09:54 +0000
Authentication-Results: prime.netspace.pro;
 auth=pass (plain) smtp.auth=krustev@HIDDEN
From: Delian Krustev <krustev-diffutils@HIDDEN>
To: bug-diffutils@HIDDEN
Subject: Re: [bug-diffutils] bug#33467: bug#33467: bug#33467: "diff" can not
 scan directories with same dev/inode
Date: Fri, 30 Nov 2018 15:09:51 +0200
Message-ID: <2261323.X7QU81BNaR@home>
User-Agent: KMail/5.2.3 (Linux/4.9.0-8-amd64; KDE/5.28.0; x86_64; ; )
In-Reply-To: <dbdd4bbc-f1a3-3d6a-2633-076e5552bbeb@HIDDEN>
References: <58c517f3-6ae0-d0e2-3e35-a8a605ee4838@HIDDEN>
 <dbdd4bbc-f1a3-3d6a-2633-076e5552bbeb@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 33467
Cc: 33467 <at> debbugs.gnu.org, Eric Blake <eblake@HIDDEN>,
 Mark Raymond <markr@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On Thursday, November 29, 2018 4:39:48 PM EET Eric Blake <eblake@HIDDEN> 
wrote:
> POSIX says that a file is uniquely determined by its inode and device
> number. If you have a file system that reports the same device for
> different contents, your file system is broken,

NILFS allows time traveling - you can mount an old snapshot and can see two 
points in time of the same filesystem. Thus it is the same dev (there is no 
practice dev numbers to be time dependent).

This is also valid for files.
Files with the same dev/inode can have different contents.

> and it's no wonder that
> LOTS of Unix tools will fail to see the differences, because your file
> system is lying.  We can't fix it in diffutils; that would have to be a
> fix in the kernel implementation of your file system driver.

This can be easily cross-reported to LKML. If "diff" developers blame the 
kernel/fs both parties should discuss it as its unacceptable a core utility to 
be unusable. ( I'm pretty sure though, that the kernel developers will be 
convinced that it does not need change. )

All we need is command line option which can turn off the comparison by dev/
inode. Does not sound like too much work.

Or maybe you are worried about changing the API ?





Information forwarded to bug-diffutils@HIDDEN:
bug#33467; Package diffutils. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 30 Nov 2018 14:08:14 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 30 09:08:14 2018
Received: from localhost ([127.0.0.1]:55649 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1gSjSo-0006Dx-FP
	for submit <at> debbugs.gnu.org; Fri, 30 Nov 2018 09:08:14 -0500
Received: from eggs.gnu.org ([208.118.235.92]:40585)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <krustev-diffutils@HIDDEN>) id 1gSjSm-0006Dk-OU
 for submit <at> debbugs.gnu.org; Fri, 30 Nov 2018 09:08:13 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <krustev-diffutils@HIDDEN>) id 1gSjSf-00065v-UR
 for submit <at> debbugs.gnu.org; Fri, 30 Nov 2018 09:08:07 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05 autolearn=disabled
 version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:60177)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <krustev-diffutils@HIDDEN>)
 id 1gSjSf-00065i-OW
 for submit <at> debbugs.gnu.org; Fri, 30 Nov 2018 09:08:05 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50177)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <krustev-diffutils@HIDDEN>) id 1gSjSe-0006dY-6l
 for bug-diffutils@HIDDEN; Fri, 30 Nov 2018 09:08:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <krustev-diffutils@HIDDEN>) id 1gSjSb-00063L-27
 for bug-diffutils@HIDDEN; Fri, 30 Nov 2018 09:08:04 -0500
Received: from prime.netspace.pro ([51.15.249.167]:38628)
 by eggs.gnu.org with smtp (Exim 4.71)
 (envelope-from <krustev-diffutils@HIDDEN>) id 1gSjSa-00060f-IJ
 for bug-diffutils@HIDDEN; Fri, 30 Nov 2018 09:08:00 -0500
Received: (qmail 18789 invoked from network); 30 Nov 2018 13:09:54 -0000
X-Bad-FCrDNS: no ( immune - auth, relay, whitelist, etc )
Received: from 84-238-173-183.ip.btc-net.bg (HELO home.localnet)
 (84.238.173.183)
 by prime.netspace.pro (qpsmtpd/0.94) with (ECDHE-RSA-AES256-GCM-SHA384
 encrypted) ESMTPSA; Fri, 30 Nov 2018 13:09:54 +0000
Authentication-Results: prime.netspace.pro;
 auth=pass (plain) smtp.auth=krustev@HIDDEN
From: Delian Krustev <krustev-diffutils@HIDDEN>
To: bug-diffutils@HIDDEN
Subject: Re: [bug-diffutils] bug#33467: bug#33467: bug#33467: "diff" can not
 scan directories with same dev/inode
Date: Fri, 30 Nov 2018 15:09:51 +0200
Message-ID: <2261323.X7QU81BNaR@home>
User-Agent: KMail/5.2.3 (Linux/4.9.0-8-amd64; KDE/5.28.0; x86_64; ; )
In-Reply-To: <dbdd4bbc-f1a3-3d6a-2633-076e5552bbeb@HIDDEN>
References: <58c517f3-6ae0-d0e2-3e35-a8a605ee4838@HIDDEN>
 <dbdd4bbc-f1a3-3d6a-2633-076e5552bbeb@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
 [fuzzy]
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -4.0 (----)
X-Debbugs-Envelope-To: submit
Cc: 33467 <at> debbugs.gnu.org, Eric Blake <eblake@HIDDEN>,
 Mark Raymond <markr@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -5.0 (-----)

On Thursday, November 29, 2018 4:39:48 PM EET Eric Blake <eblake@HIDDEN> 
wrote:
> POSIX says that a file is uniquely determined by its inode and device
> number. If you have a file system that reports the same device for
> different contents, your file system is broken,

NILFS allows time traveling - you can mount an old snapshot and can see two 
points in time of the same filesystem. Thus it is the same dev (there is no 
practice dev numbers to be time dependent).

This is also valid for files.
Files with the same dev/inode can have different contents.

> and it's no wonder that
> LOTS of Unix tools will fail to see the differences, because your file
> system is lying.  We can't fix it in diffutils; that would have to be a
> fix in the kernel implementation of your file system driver.

This can be easily cross-reported to LKML. If "diff" developers blame the 
kernel/fs both parties should discuss it as its unacceptable a core utility to 
be unusable. ( I'm pretty sure though, that the kernel developers will be 
convinced that it does not need change. )

All we need is command line option which can turn off the comparison by dev/
inode. Does not sound like too much work.

Or maybe you are worried about changing the API ?





Information forwarded to bug-diffutils@HIDDEN:
bug#33467; Package diffutils. Full text available.

Message received at 33467 <at> debbugs.gnu.org:


Received: (at 33467) by debbugs.gnu.org; 30 Nov 2018 10:06:47 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 30 05:06:47 2018
Received: from localhost ([127.0.0.1]:55541 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1gSfh9-0002VE-Ll
	for submit <at> debbugs.gnu.org; Fri, 30 Nov 2018 05:06:47 -0500
Received: from outmx-028.london.gridhost.co.uk ([95.142.156.253]:44241)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <markr@HIDDEN>) id 1gSfh6-0002V5-P5
 for 33467 <at> debbugs.gnu.org; Fri, 30 Nov 2018 05:06:45 -0500
Received: from mdr-rpi-server (unknown [91.125.162.76])
 (Authenticated sender: markr@HIDDEN)
 by outmx-028.london.gridhost.co.uk (Postfix) with ESMTPA id D9EA7262EE171;
 Fri, 30 Nov 2018 10:06:43 +0000 (GMT)
Received: from [192.168.1.68] (mdr-kubuntu.lan [192.168.1.68])
 by mdr-rpi-server (Postfix) with ESMTPSA id 4FA81207F1;
 Fri, 30 Nov 2018 10:06:43 +0000 (GMT)
Subject: Re: [bug-diffutils] bug#33467: "diff" can not scan directories with
 same dev/inode
To: Eric Deplagne <Eric@HIDDEN>
References: <20181129225240.GZ29395@HIDDEN>
 <24ee6820-3761-44e0-9397-87479a7d47eb@HIDDEN>
 <20181130085552.GA29395@HIDDEN>
From: Mark Raymond <markr@HIDDEN>
Message-ID: <58ff8812-e527-b2d1-fb0f-345c03179f1f@HIDDEN>
Date: Fri, 30 Nov 2018 10:06:42 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <20181130085552.GA29395@HIDDEN>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 33467
Cc: 33467 <at> debbugs.gnu.org, eblake@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

> POSIX says that a file is uniquely determined by its inode and device
> number.

This makes sense for files - but I'm not convinced it makes sense for directories. The only cases I can think of where two directories could have the same inode and device number are bind mounts (and theoretically directory hard links) - and in both those cases it's legitimate for there to be different mounts on subdirectories.





Information forwarded to bug-diffutils@HIDDEN:
bug#33467; Package diffutils. Full text available.

Message received at 33467 <at> debbugs.gnu.org:


Received: (at 33467) by debbugs.gnu.org; 30 Nov 2018 08:55:58 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 30 03:55:58 2018
Received: from localhost ([127.0.0.1]:55514 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1gSeac-0000lM-EY
	for submit <at> debbugs.gnu.org; Fri, 30 Nov 2018 03:55:58 -0500
Received: from goldorak5.eric.deplagne.name ([213.246.56.18]:43146
 helo=exim4.goldorak5.eric.deplagne.name)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <Eric@HIDDEN>) id 1gSeaZ-0000lC-Jr
 for 33467 <at> debbugs.gnu.org; Fri, 30 Nov 2018 03:55:56 -0500
Received: from [192.168.0.4] (helo=mail.eric.deplagne.name)
 by exim4.goldorak5.eric.deplagne.name with esmtp (Exim 4.72)
 (envelope-from <Eric@HIDDEN>)
 id 1gSeaW-0002Rl-Uy; Fri, 30 Nov 2018 09:55:52 +0100
Received: from deplagne by mail.eric.deplagne.name with local (Exim 4.69)
 (envelope-from <Eric@HIDDEN>)
 id 1gSeaW-0002Ri-U4; Fri, 30 Nov 2018 09:55:52 +0100
Date: Fri, 30 Nov 2018 09:55:52 +0100
From: Eric Deplagne <Eric@HIDDEN>
To: Mark Raymond <markr@HIDDEN>
Subject: Re: [bug-diffutils] bug#33467: "diff" can not scan directories
 with same dev/inode
Message-ID: <20181130085552.GA29395@HIDDEN>
References: <20181129225240.GZ29395@HIDDEN>
 <24ee6820-3761-44e0-9397-87479a7d47eb@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="K4LMwn8CgX2KMboP"
Content-Disposition: inline
In-Reply-To: <24ee6820-3761-44e0-9397-87479a7d47eb@HIDDEN>
User-Agent: Mutt/1.5.18 (2008-05-17)
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 33467
Cc: 33467 <at> debbugs.gnu.org, eblake@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--K4LMwn8CgX2KMboP
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, 30 Nov 2018 06:28:25 +0000, Mark Raymond wrote:
> <div dir=3D'auto'>This is the normal behaviour of bind mounts, introduced=
 in Linux 2.4.0. If this is to be considered a bug in Linux, it's a very ol=
d one!</div>

  Could be argued, and has probably been debated aplenty, if mounts should =
or should not be propagated by bind mounts,
  and the fact is they are not.

  It feels odd from diff-ing point of vue, but there must be other (especia=
lly security) implications.

--=20
  Eric Deplagne

--K4LMwn8CgX2KMboP
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iD8DBQFcAPsYej7DisjVpq4RAjibAJ9avjPGPtGzJCynFWjS4qRopaqXOQCeJjaq
QRZ5itNGQQEPsqowCKkCudg=
=YIPh
-----END PGP SIGNATURE-----

--K4LMwn8CgX2KMboP--




Information forwarded to bug-diffutils@HIDDEN:
bug#33467; Package diffutils. Full text available.

Message received at 33467 <at> debbugs.gnu.org:


Received: (at 33467) by debbugs.gnu.org; 30 Nov 2018 06:28:36 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 30 01:28:36 2018
Received: from localhost ([127.0.0.1]:55404 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1gScI0-00057j-85
	for submit <at> debbugs.gnu.org; Fri, 30 Nov 2018 01:28:36 -0500
Received: from outmx-028.london.gridhost.co.uk ([95.142.156.253]:39525)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <markr@HIDDEN>) id 1gScHx-00057V-2t
 for 33467 <at> debbugs.gnu.org; Fri, 30 Nov 2018 01:28:34 -0500
Received: from mdr-rpi-server (unknown [91.125.162.76])
 (Authenticated sender: markr@HIDDEN)
 by outmx-028.london.gridhost.co.uk (Postfix) with ESMTPA id 0DDF726374958;
 Fri, 30 Nov 2018 06:28:32 +0000 (GMT)
Received: from [192.168.1.163] (76.162.125.91.dyn.plus.net [91.125.162.76])
 by mdr-rpi-server (Postfix) with ESMTPSA id 81103207F1;
 Fri, 30 Nov 2018 06:28:31 +0000 (GMT)
Date: Fri, 30 Nov 2018 06:28:25 +0000
Subject: Re: [bug-diffutils] bug#33467: "diff" can	not scan directories with
 same dev/inode
Message-ID: <24ee6820-3761-44e0-9397-87479a7d47eb@HIDDEN>
X-Android-Message-ID: <24ee6820-3761-44e0-9397-87479a7d47eb@HIDDEN>
In-Reply-To: <20181129225240.GZ29395@HIDDEN>
From: Mark Raymond <markr@HIDDEN>
To: Eric Deplagne <Eric@HIDDEN>
Importance: Normal
X-Priority: 3
X-MSMail-Priority: Normal
MIME-Version: 1.0
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: base64
X-Spam-Score: 2.9 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  This is the normal behaviour of bind mounts, introduced in
 Linux 2.4.0. If this is to be considered a bug in Linux, it's a very old
 one! Content analysis details:   (2.9 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -0.7 RCVD_IN_DNSWL_LOW      RBL: Sender listed at http://www.dnswl.org/,
 low trust [95.142.156.253 listed in list.dnswl.org]
 -0.0 SPF_PASS               SPF: sender matches SPF record
 1.1 MIME_HTML_ONLY         BODY: Message only has text/html MIME parts
 0.0 HTML_MESSAGE           BODY: HTML included in message
 0.6 HTML_MIME_NO_HTML_TAG  HTML-only message, but there is no HTML
 tag
 1.8 MISSING_MIMEOLE        Message has X-MSMail-Priority, but no X-MimeOLE
X-Debbugs-Envelope-To: 33467
Cc: 33467 <at> debbugs.gnu.org, eblake@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.9 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 
 Content preview:  This is the normal behaviour of bind mounts, introduced in
    Linux 2.4.0. If this is to be considered a bug in Linux, it's a very old
   one! 
 
 Content analysis details:   (1.9 points, 10.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -0.7 RCVD_IN_DNSWL_LOW      RBL: Sender listed at http://www.dnswl.org/,
                             low trust
                             [95.142.156.253 listed in list.dnswl.org]
 -0.0 SPF_PASS               SPF: sender matches SPF record
  1.1 MIME_HTML_ONLY         BODY: Message only has text/html MIME parts
  0.0 HTML_MESSAGE           BODY: HTML included in message
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
  0.6 HTML_MIME_NO_HTML_TAG  HTML-only message, but there is no HTML
                             tag
  1.8 MISSING_MIMEOLE        Message has X-MSMail-Priority, but no X-MimeOLE

PGRpdiBkaXI9J2F1dG8nPlRoaXMgaXMgdGhlIG5vcm1hbCBiZWhhdmlvdXIgb2YgYmluZCBtb3Vu
dHMsIGludHJvZHVjZWQgaW4gTGludXggMi40LjAuIElmIHRoaXMgaXMgdG8gYmUgY29uc2lkZXJl
ZCBhIGJ1ZyBpbiBMaW51eCwgaXQncyBhIHZlcnkgb2xkIG9uZSE8L2Rpdj4=





Information forwarded to bug-diffutils@HIDDEN:
bug#33467; Package diffutils. Full text available.

Message received at 33467 <at> debbugs.gnu.org:


Received: (at 33467) by debbugs.gnu.org; 29 Nov 2018 22:52:46 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 29 17:52:46 2018
Received: from localhost ([127.0.0.1]:55254 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1gSVAs-0008AK-6w
	for submit <at> debbugs.gnu.org; Thu, 29 Nov 2018 17:52:46 -0500
Received: from goldorak5.eric.deplagne.name ([213.246.56.18]:42608
 helo=exim4.goldorak5.eric.deplagne.name)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <Eric@HIDDEN>) id 1gSVAp-0008AA-By
 for 33467 <at> debbugs.gnu.org; Thu, 29 Nov 2018 17:52:44 -0500
Received: from [192.168.0.4] (helo=mail.eric.deplagne.name)
 by exim4.goldorak5.eric.deplagne.name with esmtp (Exim 4.72)
 (envelope-from <Eric@HIDDEN>)
 id 1gSVAm-0007FY-OF; Thu, 29 Nov 2018 23:52:40 +0100
Received: from deplagne by mail.eric.deplagne.name with local (Exim 4.69)
 (envelope-from <Eric@HIDDEN>)
 id 1gSVAm-0007FT-NH; Thu, 29 Nov 2018 23:52:40 +0100
Date: Thu, 29 Nov 2018 23:52:40 +0100
From: Eric Deplagne <Eric@HIDDEN>
To: Eric Blake <eblake@HIDDEN>
Subject: Re: [bug-diffutils] bug#33467: bug#33467: bug#33467: "diff" can
 not scan directories with same dev/inode
Message-ID: <20181129225240.GZ29395@HIDDEN>
References: <58c517f3-6ae0-d0e2-3e35-a8a605ee4838@HIDDEN>
 <dbdd4bbc-f1a3-3d6a-2633-076e5552bbeb@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="yaap9KN+GmBP785v"
Content-Disposition: inline
In-Reply-To: <dbdd4bbc-f1a3-3d6a-2633-076e5552bbeb@HIDDEN>
User-Agent: Mutt/1.5.18 (2008-05-17)
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 33467
Cc: 33467 <at> debbugs.gnu.org, Mark Raymond <markr@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--yaap9KN+GmBP785v
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, 29 Nov 2018 16:39:48 -0600, Eric Blake wrote:
> On 11/29/18 4:32 PM, Mark Raymond wrote:
>> This sounds similar to a problem I have just encountered.
>>
>> If I have filesystems mounted at:
>>
>>  =A0=A0=A0 /mnt/foo
>>  =A0=A0=A0 /mnt/foo/subfs
>>
>> then do
>>
>>  =A0=A0=A0 mount --bind /mnt/foo /mnt/bar
>>
>> then the contents of `/mnt/foo` and `/mnt/bar` are different, because =
=20
>> `/mnt/foo/subfs` has contents but `/mnt/bar/subfs` does not have =20
>> contents. However
>>
>>  =A0=A0=A0 diff -r /mnt/foo /mnt/bar
>>
>> returns no results. However in my case, rsync is also unable to show=20
>> the differences.
>
> POSIX says that a file is uniquely determined by its inode and device =20
> number. If you have a file system that reports the same device for =20
> different contents, your file system is broken, and it's no wonder that =
=20
> LOTS of Unix tools will fail to see the differences, because your file =
=20
> system is lying.  We can't fix it in diffutils; that would have to be a =
=20
> fix in the kernel implementation of your file system driver.
>
> --=20
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3266
> Virtualization:  qemu.org | libvirt.org

  Maybe the closest thing to a bug there is that /mnt/bar/subfs does not ha=
ve contents.

--=20
  Eric Deplagne

--yaap9KN+GmBP785v
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iD8DBQFcAG24ej7DisjVpq4RAgMGAJ9Dutxe89u/y8Kt5YuRw/A7QDq3nACgjWjG
TX55gFL8ypZciHdxtoZRhwA=
=nMbU
-----END PGP SIGNATURE-----

--yaap9KN+GmBP785v--




Information forwarded to bug-diffutils@HIDDEN:
bug#33467; Package diffutils. Full text available.

Message received at 33467 <at> debbugs.gnu.org:


Received: (at 33467) by debbugs.gnu.org; 29 Nov 2018 22:40:00 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 29 17:40:00 2018
Received: from localhost ([127.0.0.1]:55241 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1gSUyW-0007qm-Ef
	for submit <at> debbugs.gnu.org; Thu, 29 Nov 2018 17:40:00 -0500
Received: from mx1.redhat.com ([209.132.183.28]:60738)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eblake@HIDDEN>) id 1gSUyR-0007qX-VD
 for 33467 <at> debbugs.gnu.org; Thu, 29 Nov 2018 17:39:56 -0500
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com
 [10.5.11.12])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id E32E189ADC;
 Thu, 29 Nov 2018 22:39:49 +0000 (UTC)
Received: from [10.3.117.105] (ovpn-117-105.phx2.redhat.com [10.3.117.105])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 84EAD60CD1;
 Thu, 29 Nov 2018 22:39:49 +0000 (UTC)
Subject: Re: [bug-diffutils] bug#33467: bug#33467: "diff" can not scan
 directories with same dev/inode
To: Mark Raymond <markr@HIDDEN>, 33467 <at> debbugs.gnu.org
References: <58c517f3-6ae0-d0e2-3e35-a8a605ee4838@HIDDEN>
From: Eric Blake <eblake@HIDDEN>
Organization: Red Hat, Inc.
Message-ID: <dbdd4bbc-f1a3-3d6a-2633-076e5552bbeb@HIDDEN>
Date: Thu, 29 Nov 2018 16:39:48 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.0
MIME-Version: 1.0
In-Reply-To: <58c517f3-6ae0-d0e2-3e35-a8a605ee4838@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.26]); Thu, 29 Nov 2018 22:39:50 +0000 (UTC)
X-Spam-Score: -5.0 (-----)
X-Debbugs-Envelope-To: 33467
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -6.0 (------)

On 11/29/18 4:32 PM, Mark Raymond wrote:
> This sounds similar to a problem I have just encountered.
> 
> If I have filesystems mounted at:
> 
>      /mnt/foo
>      /mnt/foo/subfs
> 
> then do
> 
>      mount --bind /mnt/foo /mnt/bar
> 
> then the contents of `/mnt/foo` and `/mnt/bar` are different, because 
> `/mnt/foo/subfs` has contents but `/mnt/bar/subfs` does not have 
> contents. However
> 
>      diff -r /mnt/foo /mnt/bar
> 
> returns no results. However in my case, rsync is also unable to show the 
> differences.

POSIX says that a file is uniquely determined by its inode and device 
number. If you have a file system that reports the same device for 
different contents, your file system is broken, and it's no wonder that 
LOTS of Unix tools will fail to see the differences, because your file 
system is lying.  We can't fix it in diffutils; that would have to be a 
fix in the kernel implementation of your file system driver.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org




Information forwarded to bug-diffutils@HIDDEN:
bug#33467; Package diffutils. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 29 Nov 2018 22:32:55 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 29 17:32:54 2018
Received: from localhost ([127.0.0.1]:55225 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1gSUre-0007g1-Nt
	for submit <at> debbugs.gnu.org; Thu, 29 Nov 2018 17:32:54 -0500
Received: from eggs.gnu.org ([208.118.235.92]:37738)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <markr@HIDDEN>) id 1gSUr2-0007et-R1
 for submit <at> debbugs.gnu.org; Thu, 29 Nov 2018 17:32:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <markr@HIDDEN>) id 1gSUqx-0002cM-5d
 for submit <at> debbugs.gnu.org; Thu, 29 Nov 2018 17:32:11 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled
 version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:33472)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <markr@HIDDEN>)
 id 1gSUqx-0002cI-16
 for submit <at> debbugs.gnu.org; Thu, 29 Nov 2018 17:32:11 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47344)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <markr@HIDDEN>) id 1gSUqw-0000qT-7O
 for bug-diffutils@HIDDEN; Thu, 29 Nov 2018 17:32:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <markr@HIDDEN>) id 1gSUqt-0002aE-4H
 for bug-diffutils@HIDDEN; Thu, 29 Nov 2018 17:32:10 -0500
Received: from outmx-028.london.gridhost.co.uk ([95.142.156.253]:51206)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <markr@HIDDEN>)
 id 1gSUqs-0002ZZ-U9
 for bug-diffutils@HIDDEN; Thu, 29 Nov 2018 17:32:07 -0500
Received: from mdr-rpi-server (unknown [91.125.162.76])
 (Authenticated sender: markr@HIDDEN)
 by outmx-028.london.gridhost.co.uk (Postfix) with ESMTPA id 8623F24A1245F;
 Thu, 29 Nov 2018 22:32:05 +0000 (GMT)
Received: from [192.168.1.68] (mdr-kubuntu.lan [192.168.1.68])
 by mdr-rpi-server (Postfix) with ESMTPSA id 27067208B1;
 Thu, 29 Nov 2018 22:32:05 +0000 (GMT)
To: bug-diffutils@HIDDEN
References: 
Subject: [bug-diffutils] bug#33467: "diff" can not scan directories with same
 dev/inode
From: Mark Raymond <markr@HIDDEN>
Message-ID: <58c517f3-6ae0-d0e2-3e35-a8a605ee4838@HIDDEN>
Date: Thu, 29 Nov 2018 22:32:04 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy]
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -4.0 (----)
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Thu, 29 Nov 2018 17:32:52 -0500
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -5.0 (-----)

This sounds similar to a problem I have just encountered.

If I have filesystems mounted at:

 =C2=A0=C2=A0=C2=A0 /mnt/foo
 =C2=A0=C2=A0=C2=A0 /mnt/foo/subfs

then do

 =C2=A0=C2=A0=C2=A0 mount --bind /mnt/foo /mnt/bar

then the contents of `/mnt/foo` and `/mnt/bar` are different, because=20
`/mnt/foo/subfs` has contents but `/mnt/bar/subfs` does not have=20
contents. However

 =C2=A0=C2=A0=C2=A0 diff -r /mnt/foo /mnt/bar

returns no results. However in my case, rsync is also unable to show the=20
differences.




Information forwarded to bug-diffutils@HIDDEN:
bug#33467; Package diffutils. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 22 Nov 2018 16:03:26 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 22 11:03:26 2018
Received: from localhost ([127.0.0.1]:42559 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1gPrRs-0001IC-FF
	for submit <at> debbugs.gnu.org; Thu, 22 Nov 2018 11:03:25 -0500
Received: from eggs.gnu.org ([208.118.235.92]:45338)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <krustev-diffutils@HIDDEN>) id 1gPpIG-0005w3-9c
 for submit <at> debbugs.gnu.org; Thu, 22 Nov 2018 08:45:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <krustev-diffutils@HIDDEN>) id 1gPpI8-0005Ct-0Z
 for submit <at> debbugs.gnu.org; Thu, 22 Nov 2018 08:45:13 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled
 version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:44851)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <krustev-diffutils@HIDDEN>)
 id 1gPpI7-0005B5-4N
 for submit <at> debbugs.gnu.org; Thu, 22 Nov 2018 08:45:11 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54924)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <krustev-diffutils@HIDDEN>) id 1gPpI6-00034n-8H
 for bug-diffutils@HIDDEN; Thu, 22 Nov 2018 08:45:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <krustev-diffutils@HIDDEN>) id 1gPpI3-00052L-2h
 for bug-diffutils@HIDDEN; Thu, 22 Nov 2018 08:45:10 -0500
Received: from prime.netspace.pro ([163.172.26.229]:40967)
 by eggs.gnu.org with smtp (Exim 4.71)
 (envelope-from <krustev-diffutils@HIDDEN>) id 1gPpI1-0004aj-23
 for bug-diffutils@HIDDEN; Thu, 22 Nov 2018 08:45:05 -0500
Received: (qmail 20955 invoked from network); 22 Nov 2018 13:44:58 -0000
X-Bad-FCrDNS: no ( immune - auth, relay, whitelist, etc )
Received: from 84-238-173-183.ip.btc-net.bg (HELO home.localnet)
 (84.238.173.183)
 by prime.netspace.pro (qpsmtpd/0.94) with (ECDHE-RSA-AES256-GCM-SHA384
 encrypted) ESMTPSA; Thu, 22 Nov 2018 13:44:58 +0000
Authentication-Results: prime.netspace.pro;
 auth=pass (plain) smtp.auth=krustev@HIDDEN
From: Delian Krustev <krustev-diffutils@HIDDEN>
To: bug-diffutils@HIDDEN
Subject: "diff" can not scan directories with same dev/inode
Date: Thu, 22 Nov 2018 15:44:56 +0200
Message-ID: <3087387.ZnD5iEkHCf@home>
User-Agent: KMail/5.2.3 (Linux/4.9.0-8-amd64; KDE/5.28.0; x86_64; ; )
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
 [fuzzy]
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -4.0 (----)
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Thu, 22 Nov 2018 11:03:22 -0500
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -5.0 (-----)


	Hi,

NILFS is a log structured file system which supports snapshotting.
I've tried to see the differences between two snapshots using diff:

  root@srv1:/mnt/protected# diff -qr tmp/ bkp_srv1/

and was amazed to find out that I can't.

Here are the mounts:

  # the HEAD of the filesystem, mounted read/write:
  /dev/mapper/bkp_srv1 on /mnt/protected/bkp_srv1 type nilfs2 (rw,nosuid,nodev,noexec,relatime)
  # an older snapshot, mounted read only:
  /dev/mapper/bkp_srv1 on /mnt/protected/tmp type nilfs2 (ro,relatime,cp=2171601)


At first I've decided that I've mounted the wrong checkpoint(snapshot) or
have done something else wrong. Then I've double checked and have verified
that there ARE actually different file contents on both mounts.

So my guess is that diff checks the stat information on the dirs and if
its the same dev&inode it does not bother to compare:

root@srv1:/mnt/protected# stat tmp bkp_srv1
  File: tmp
  Size: 4096            Blocks: 1          IO Block: 4096   directory
Device: fd05h/64773d    Inode: 2           Links: 4
Access: (0755/drwxr-xr-x)  Uid: (    0/    root)   Gid: (    0/    root)
Access: 2014-02-11 22:16:50.545497340 +0000
Modify: 2014-02-11 22:16:50.545497340 +0000
Change: 2014-02-11 22:16:50.545497340 +0000
 Birth: -

  File: bkp_srv1
  Size: 4096            Blocks: 1          IO Block: 4096   directory
Device: fd05h/64773d    Inode: 2           Links: 4
Access: (0755/drwxr-xr-x)  Uid: (    0/    root)   Gid: (    0/    root)
Access: 2014-02-11 22:16:50.545497340 +0000
Modify: 2014-02-11 22:16:50.545497340 +0000
Change: 2014-02-11 22:16:50.545497340 +0000
 Birth: -

I've checked the man page and was not able to find a usable diff option,
e.g. force the comparison anyway.

I've also run:

  rsync -a --dry-run --verbose tmp/. bkp_srv1/.

and it shows the differences as expected.

So "diff" is unable to do its job and show the differences between
files/dirs when they exist.

Thus I consider this to be a bug.


P.S. I am aware that "diff" is crucially important software for
lots of software developers and infrastructure and making changes
to it or its interface (e.g. command line options) is a responsible
task.


Best regards
--
Delian






Acknowledgement sent to Delian Krustev <krustev-diffutils@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-diffutils@HIDDEN. Full text available.
Report forwarded to bug-diffutils@HIDDEN:
bug#33467; Package diffutils. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.