GNU logs - #34239, boring messages

Message sent to bug-coreutils@HIDDEN:

Subject: bug#34239: build failure on Android, due to S_MAGIC_* symbols
Resent-From: Bruno Haible <bruno@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-coreutils@HIDDEN
Resent-Date: Tue, 29 Jan 2019 03:20:01 +0000
Resent-Message-ID: <handler.34239.B.154873199926546 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 34239 <at> debbugs.gnu.org
From: Bruno Haible <bruno@HIDDEN>
Date: Tue, 29 Jan 2019 04:19:42 +0100
Message-ID: <1643060.pFagY2F4Kt@omega>
User-Agent: KMail/5.1.3 (Linux/4.4.0-141-generic; KDE/5.18.0; x86_64; ; )
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi,

Compiling coreutils on Android produces this error:

  CC       src/tail.o
In file included from ../src/tail.c:63:
../src/fs-is-local.h: In function 'is_local_fs_type':
../src/fs-is-local.h:9: error: 'S_MAGIC_AAFS' undeclared (first use in this function)
../src/fs-is-local.h:9: error: (Each undeclared identifier is reported only once
../src/fs-is-local.h:9: error: for each function it appears in.)
../src/fs-is-local.h:10: error: 'S_MAGIC_ACFS' undeclared (first use in this function)
../src/fs-is-local.h:11: error: 'S_MAGIC_ADFS' undeclared (first use in this function)
../src/fs-is-local.h:12: error: 'S_MAGIC_AFFS' undeclared (first use in this function)
../src/fs-is-local.h:13: error: 'S_MAGIC_AFS' undeclared (first use in this function)
../src/fs-is-local.h:14: error: 'S_MAGIC_ANON_INODE_FS' undeclared (first use in this function)
../src/fs-is-local.h:15: error: 'S_MAGIC_AUFS' undeclared (first use in this function)
../src/fs-is-local.h:16: error: 'S_MAGIC_AUTOFS' undeclared (first use in this function)
../src/fs-is-local.h:17: error: 'S_MAGIC_BALLOON_KVM' undeclared (first use in this function)
../src/fs-is-local.h:18: error: 'S_MAGIC_BEFS' undeclared (first use in this function)
../src/fs-is-local.h:19: error: 'S_MAGIC_BDEVFS' undeclared (first use in this function)
../src/fs-is-local.h:20: error: 'S_MAGIC_BFS' undeclared (first use in this function)
../src/fs-is-local.h:21: error: 'S_MAGIC_BPF_FS' undeclared (first use in this function)
../src/fs-is-local.h:22: error: 'S_MAGIC_BINFMTFS' undeclared (first use in this function)
../src/fs-is-local.h:23: error: 'S_MAGIC_BTRFS' undeclared (first use in this function)
../src/fs-is-local.h:24: error: 'S_MAGIC_BTRFS_TEST' undeclared (first use in this function)
../src/fs-is-local.h:25: error: 'S_MAGIC_CEPH' undeclared (first use in this function)
../src/fs-is-local.h:26: error: 'S_MAGIC_CGROUP' undeclared (first use in this function)
../src/fs-is-local.h:27: error: 'S_MAGIC_CGROUP2' undeclared (first use in this function)
../src/fs-is-local.h:28: error: 'S_MAGIC_CIFS' undeclared (first use in this function)
../src/fs-is-local.h:29: error: 'S_MAGIC_CODA' undeclared (first use in this function)
../src/fs-is-local.h:30: error: 'S_MAGIC_COH' undeclared (first use in this function)
../src/fs-is-local.h:31: error: 'S_MAGIC_CONFIGFS' undeclared (first use in this function)
../src/fs-is-local.h:32: error: 'S_MAGIC_CRAMFS' undeclared (first use in this function)
../src/fs-is-local.h:33: error: 'S_MAGIC_CRAMFS_WEND' undeclared (first use in this function)
../src/fs-is-local.h:34: error: 'S_MAGIC_DAXFS' undeclared (first use in this function)
../src/fs-is-local.h:35: error: 'S_MAGIC_DEBUGFS' undeclared (first use in this function)
../src/fs-is-local.h:36: error: 'S_MAGIC_DEVFS' undeclared (first use in this function)
../src/fs-is-local.h:37: error: 'S_MAGIC_DEVPTS' undeclared (first use in this function)
../src/fs-is-local.h:38: error: 'S_MAGIC_ECRYPTFS' undeclared (first use in this function)
../src/fs-is-local.h:39: error: 'S_MAGIC_EFIVARFS' undeclared (first use in this function)
../src/fs-is-local.h:40: error: 'S_MAGIC_EFS' undeclared (first use in this function)
../src/fs-is-local.h:41: error: 'S_MAGIC_EXFS' undeclared (first use in this function)
../src/fs-is-local.h:42: error: 'S_MAGIC_EXOFS' undeclared (first use in this function)
../src/fs-is-local.h:43: error: 'S_MAGIC_EXT' undeclared (first use in this function)
../src/fs-is-local.h:44: error: 'S_MAGIC_EXT2' undeclared (first use in this function)
../src/fs-is-local.h:45: error: 'S_MAGIC_EXT2_OLD' undeclared (first use in this function)
../src/fs-is-local.h:46: error: 'S_MAGIC_F2FS' undeclared (first use in this function)
../src/fs-is-local.h:47: error: 'S_MAGIC_FAT' undeclared (first use in this function)
../src/fs-is-local.h:48: error: 'S_MAGIC_FHGFS' undeclared (first use in this function)
../src/fs-is-local.h:49: error: 'S_MAGIC_FUSEBLK' undeclared (first use in this function)
../src/fs-is-local.h:50: error: 'S_MAGIC_FUSECTL' undeclared (first use in this function)
../src/fs-is-local.h:51: error: 'S_MAGIC_FUTEXFS' undeclared (first use in this function)
../src/fs-is-local.h:52: error: 'S_MAGIC_GFS' undeclared (first use in this function)
../src/fs-is-local.h:53: error: 'S_MAGIC_GPFS' undeclared (first use in this function)
../src/fs-is-local.h:54: error: 'S_MAGIC_HFS' undeclared (first use in this function)
../src/fs-is-local.h:55: error: 'S_MAGIC_HFS_PLUS' undeclared (first use in this function)
../src/fs-is-local.h:56: error: 'S_MAGIC_HFS_X' undeclared (first use in this function)
../src/fs-is-local.h:57: error: 'S_MAGIC_HOSTFS' undeclared (first use in this function)
../src/fs-is-local.h:58: error: 'S_MAGIC_HPFS' undeclared (first use in this function)
../src/fs-is-local.h:59: error: 'S_MAGIC_HUGETLBFS' undeclared (first use in this function)
../src/fs-is-local.h:60: error: 'S_MAGIC_MTD_INODE_FS' undeclared (first use in this function)
../src/fs-is-local.h:61: error: 'S_MAGIC_IBRIX' undeclared (first use in this function)
../src/fs-is-local.h:62: error: 'S_MAGIC_INOTIFYFS' undeclared (first use in this function)
../src/fs-is-local.h:63: error: 'S_MAGIC_ISOFS' undeclared (first use in this function)
../src/fs-is-local.h:64: error: 'S_MAGIC_ISOFS_R_WIN' undeclared (first use in this function)
../src/fs-is-local.h:65: error: 'S_MAGIC_ISOFS_WIN' undeclared (first use in this function)
../src/fs-is-local.h:66: error: 'S_MAGIC_JFFS' undeclared (first use in this function)
../src/fs-is-local.h:67: error: 'S_MAGIC_JFFS2' undeclared (first use in this function)
../src/fs-is-local.h:68: error: 'S_MAGIC_JFS' undeclared (first use in this function)
../src/fs-is-local.h:69: error: 'S_MAGIC_KAFS' undeclared (first use in this function)
../src/fs-is-local.h:70: error: 'S_MAGIC_LOGFS' undeclared (first use in this function)
../src/fs-is-local.h:71: error: 'S_MAGIC_LUSTRE' undeclared (first use in this function)
../src/fs-is-local.h:72: error: 'S_MAGIC_M1FS' undeclared (first use in this function)
../src/fs-is-local.h:73: error: 'S_MAGIC_MINIX' undeclared (first use in this function)
../src/fs-is-local.h:74: error: 'S_MAGIC_MINIX_30' undeclared (first use in this function)
../src/fs-is-local.h:75: error: 'S_MAGIC_MINIX_V2' undeclared (first use in this function)
../src/fs-is-local.h:76: error: 'S_MAGIC_MINIX_V2_30' undeclared (first use in this function)
../src/fs-is-local.h:77: error: 'S_MAGIC_MINIX_V3' undeclared (first use in this function)
../src/fs-is-local.h:78: error: 'S_MAGIC_MQUEUE' undeclared (first use in this function)
../src/fs-is-local.h:79: error: 'S_MAGIC_MSDOS' undeclared (first use in this function)
../src/fs-is-local.h:80: error: 'S_MAGIC_NCP' undeclared (first use in this function)
../src/fs-is-local.h:81: error: 'S_MAGIC_NFS' undeclared (first use in this function)
../src/fs-is-local.h:82: error: 'S_MAGIC_NFSD' undeclared (first use in this function)
../src/fs-is-local.h:83: error: 'S_MAGIC_NILFS' undeclared (first use in this function)
../src/fs-is-local.h:84: error: 'S_MAGIC_NSFS' undeclared (first use in this function)
../src/fs-is-local.h:85: error: 'S_MAGIC_NTFS' undeclared (first use in this function)
../src/fs-is-local.h:86: error: 'S_MAGIC_OPENPROM' undeclared (first use in this function)
../src/fs-is-local.h:87: error: 'S_MAGIC_OCFS2' undeclared (first use in this function)
../src/fs-is-local.h:88: error: 'S_MAGIC_OVERLAYFS' undeclared (first use in this function)
../src/fs-is-local.h:89: error: 'S_MAGIC_PANFS' undeclared (first use in this function)
../src/fs-is-local.h:90: error: 'S_MAGIC_PIPEFS' undeclared (first use in this function)
../src/fs-is-local.h:91: error: 'S_MAGIC_PRL_FS' undeclared (first use in this function)
../src/fs-is-local.h:92: error: 'S_MAGIC_PROC' undeclared (first use in this function)
../src/fs-is-local.h:93: error: 'S_MAGIC_PSTOREFS' undeclared (first use in this function)
../src/fs-is-local.h:94: error: 'S_MAGIC_QNX4' undeclared (first use in this function)
../src/fs-is-local.h:95: error: 'S_MAGIC_QNX6' undeclared (first use in this function)
../src/fs-is-local.h:96: error: 'S_MAGIC_RAMFS' undeclared (first use in this function)
../src/fs-is-local.h:97: error: 'S_MAGIC_RDTGROUP' undeclared (first use in this function)
../src/fs-is-local.h:98: error: 'S_MAGIC_REISERFS' undeclared (first use in this function)
../src/fs-is-local.h:99: error: 'S_MAGIC_ROMFS' undeclared (first use in this function)
../src/fs-is-local.h:100: error: 'S_MAGIC_RPC_PIPEFS' undeclared (first use in this function)
../src/fs-is-local.h:101: error: 'S_MAGIC_SECURITYFS' undeclared (first use in this function)
../src/fs-is-local.h:102: error: 'S_MAGIC_SELINUX' undeclared (first use in this function)
../src/fs-is-local.h:103: error: 'S_MAGIC_SMACK' undeclared (first use in this function)
../src/fs-is-local.h:104: error: 'S_MAGIC_SMB' undeclared (first use in this function)
../src/fs-is-local.h:105: error: 'S_MAGIC_SMB2' undeclared (first use in this function)
../src/fs-is-local.h:106: error: 'S_MAGIC_SNFS' undeclared (first use in this function)
../src/fs-is-local.h:107: error: 'S_MAGIC_SOCKFS' undeclared (first use in this function)
../src/fs-is-local.h:108: error: 'S_MAGIC_SQUASHFS' undeclared (first use in this function)
../src/fs-is-local.h:109: error: 'S_MAGIC_SYSFS' undeclared (first use in this function)
../src/fs-is-local.h:110: error: 'S_MAGIC_SYSV2' undeclared (first use in this function)
../src/fs-is-local.h:111: error: 'S_MAGIC_SYSV4' undeclared (first use in this function)
../src/fs-is-local.h:112: error: 'S_MAGIC_TMPFS' undeclared (first use in this function)
../src/fs-is-local.h:113: error: 'S_MAGIC_TRACEFS' undeclared (first use in this function)
../src/fs-is-local.h:114: error: 'S_MAGIC_UBIFS' undeclared (first use in this function)
../src/fs-is-local.h:115: error: 'S_MAGIC_UDF' undeclared (first use in this function)
../src/fs-is-local.h:116: error: 'S_MAGIC_UFS' undeclared (first use in this function)
../src/fs-is-local.h:117: error: 'S_MAGIC_UFS_BYTESWAPPED' undeclared (first use in this function)
../src/fs-is-local.h:118: error: 'S_MAGIC_USBDEVFS' undeclared (first use in this function)
../src/fs-is-local.h:119: error: 'S_MAGIC_V9FS' undeclared (first use in this function)
../src/fs-is-local.h:120: error: 'S_MAGIC_VMHGFS' undeclared (first use in this function)
../src/fs-is-local.h:121: error: 'S_MAGIC_VXFS' undeclared (first use in this function)
../src/fs-is-local.h:122: error: 'S_MAGIC_VZFS' undeclared (first use in this function)
../src/fs-is-local.h:123: error: 'S_MAGIC_WSLFS' undeclared (first use in this function)
../src/fs-is-local.h:124: error: 'S_MAGIC_XENFS' undeclared (first use in this function)
../src/fs-is-local.h:125: error: 'S_MAGIC_XENIX' undeclared (first use in this function)
../src/fs-is-local.h:126: error: 'S_MAGIC_XFS' undeclared (first use in this function)
../src/fs-is-local.h:127: error: 'S_MAGIC_XIAFS' undeclared (first use in this function)
../src/fs-is-local.h:128: error: 'S_MAGIC_ZFS' undeclared (first use in this function)
../src/fs-is-local.h:129: error: 'S_MAGIC_ZSMALLOC' undeclared (first use in this function)
make[2]: *** [src/tail.o] Error 1

The Android libc, Bionic, does not define any of these S_MAGIC_* symbols or
macros, even in the newest version [1].

Can some #ifdef be used to avoid this build failure?
'defined __ANDROID__' tests for Android.
'defined __linux__' tests for Linux excluding Android.

Bruno

[1] https://android.googlesource.com/platform/bionic/

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Bruno Haible <bruno@HIDDEN>
Subject: bug#34239: Acknowledgement (build failure on Android, due to
 S_MAGIC_* symbols)
Message-ID: <handler.34239.B.154873199926546.ack <at> debbugs.gnu.org>
References: <1643060.pFagY2F4Kt@omega>
X-Gnu-PR-Message: ack 34239
X-Gnu-PR-Package: coreutils
Reply-To: 34239 <at> debbugs.gnu.org
Date: Tue, 29 Jan 2019 03:20:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-coreutils@HIDDEN

If you wish to submit further information on this problem, please
send it to 34239 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
34239: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D34239
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-coreutils@HIDDEN:

Subject: bug#34239: build failure on Android, due to S_MAGIC_* symbols
Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady <P@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-coreutils@HIDDEN
Resent-Date: Wed, 30 Jan 2019 05:01:02 +0000
Resent-Message-ID: <handler.34239.B34239.154882444021658 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Bruno Haible <bruno@HIDDEN>, 34239 <at> debbugs.gnu.org
References: <1643060.pFagY2F4Kt@omega>
From: =?UTF-8?Q?P=C3=A1draig?= Brady <P@HIDDEN>
Message-ID: <190df5d5-dd38-085d-8aa0-a0c03665c447@HIDDEN>
Date: Tue, 29 Jan 2019 21:00:35 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <1643060.pFagY2F4Kt@omega>
Content-Type: multipart/mixed; boundary="------------3A7299D9B9B1A1106BB1ACDA"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

This is a multi-part message in MIME format.
--------------3A7299D9B9B1A1106BB1ACDA
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit

On 28/01/19 19:19, Bruno Haible wrote:
> Hi,
> 
> Compiling coreutils on Android produces this error:
> 
>   CC       src/tail.o
> In file included from ../src/tail.c:63:
> ../src/fs-is-local.h: In function 'is_local_fs_type':
> ../src/fs-is-local.h:9: error: 'S_MAGIC_AAFS' undeclared (first use in this function)
> ...
> make[2]: *** [src/tail.o] Error 1
> 
> The Android libc, Bionic, does not define any of these S_MAGIC_* symbols or
> macros, even in the newest version [1].
> 
> Can some #ifdef be used to avoid this build failure?
> 'defined __ANDROID__' tests for Android.
> 'defined __linux__' tests for Linux excluding Android.
> 
> Bruno
> 
> [1] https://android.googlesource.com/platform/bionic/

Interesting. So inotify is supported on that android system.
Our ifdefs were wrong anyway as we check for remoteness even if one disables inotify.
I.E. our build would have failed on standard linux if one explicitly disabled inotify.
I've fixed that up and added support for the android specific "sdcardfs" which I found in:
https://android.googlesource.com/kernel/common/+/android-mainline-tracking/include/uapi/linux/magic.h

Proposed patch attached.

thanks!
P�draig

--------------3A7299D9B9B1A1106BB1ACDA
Content-Type: text/x-patch;
 name="tail-android.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="tail-android.patch"

From 500e567165d210a8d8a96e4084a5fdc6007b2ca8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?P=C3=A1draig=20Brady?= <P@HIDDEN>
Date: Tue, 29 Jan 2019 20:32:53 -0800
Subject: [PATCH] stat,tail: fix android build and support inotify

* src/extract-magic: Treat android like linux,
which fixes the build by ensuring the constants are defined.
* src/stat.c: Support all constants on android, including
the android specific "sdcardfs".
* src/tail.c: Fix inclusion of statfs headers to be independent
of inotify availability, as fremote() is used on linux even
if inotify has been disabled.  Also enable fremote() on android.
* NEWS: Mention the improvment.
Fixes https://bugs.gnu.org/34239
---
 NEWS              | 5 +++++
 src/extract-magic | 2 +-
 src/stat.c        | 4 +++-
 src/tail.c        | 7 +++++--
 4 files changed, 14 insertions(+), 4 deletions(-)

diff --git a/NEWS b/NEWS
index 4b6b8bf..e6ccb19 100644
--- a/NEWS
+++ b/NEWS
@@ -69,6 +69,11 @@ GNU coreutils NEWS                                    -*- outline -*-
   and encodes and decodes printable text using various common encodings:
   base64,base64url,base32,base32hex,base16,base2,z85.
 
+** Improvements
+
+  stat and tail now know about the "sdcardfs" file system on Android.
+  stat -f -c%T now reports the file system type, and tail -f uses inotify.
+
 
 * Noteworthy changes in release 8.30 (2018-07-01) [stable]
 
diff --git a/src/extract-magic b/src/extract-magic
index 48c38df..892c1db 100644
--- a/src/extract-magic
+++ b/src/extract-magic
@@ -125,7 +125,7 @@ EOF
   print $emit_magic ? $magic_comment : $map_comment;
 
   $emit_magic
-    and print "\n#if defined __linux__\n";
+    and print "\n#if defined __linux__ || defined __ANDROID__\n";
   $emit_magic
     or print "static inline int\n"
       . "is_local_fs_type (unsigned long int magic)\n"
diff --git a/src/stat.c b/src/stat.c
index f17246d..c8f1809 100644
--- a/src/stat.c
+++ b/src/stat.c
@@ -235,7 +235,7 @@ human_fstype (STRUCT_STATVFS const *statfsbuf)
 #else
   switch (statfsbuf->f_type)
     {
-# if defined __linux__
+# if defined __linux__ || defined __ANDROID__
 
       /* Compare with what's in libc:
          f=/a/libc/sysdeps/unix/sysv/linux/linux_fsinfo.h
@@ -450,6 +450,8 @@ human_fstype (STRUCT_STATVFS const *statfsbuf)
       return "romfs";
     case S_MAGIC_RPC_PIPEFS: /* 0x67596969 local */
       return "rpc_pipefs";
+    case S_MAGIC_SDCARDFS: /* 0x5DCA2DF5 local */
+      return "sdcardfs";
     case S_MAGIC_SECURITYFS: /* 0x73636673 local */
       return "securityfs";
     case S_MAGIC_SELINUX: /* 0xF97CFF8C local */
diff --git a/src/tail.c b/src/tail.c
index dee827b..8fab049 100644
--- a/src/tail.c
+++ b/src/tail.c
@@ -57,8 +57,10 @@
 # include <sys/inotify.h>
 /* 'select' is used by tail_forever_inotify.  */
 # include <sys/select.h>
+#endif
 
-/* inotify needs to know if a file is local.  */
+/* Linux can optimize the handling of local files.  */
+#if defined __linux__ || defined __ANDROID__
 # include "fs.h"
 # include "fs-is-local.h"
 # if HAVE_SYS_STATFS_H
@@ -938,7 +940,8 @@ fremote (int fd, const char *name)
 {
   bool remote = true;           /* be conservative (poll by default).  */
 
-#if HAVE_FSTATFS && HAVE_STRUCT_STATFS_F_TYPE && defined __linux__
+#if HAVE_FSTATFS && HAVE_STRUCT_STATFS_F_TYPE \
+ && (defined __linux__ || defined __ANDROID__)
   struct statfs buf;
   int err = fstatfs (fd, &buf);
   if (err != 0)
-- 
2.9.3


--------------3A7299D9B9B1A1106BB1ACDA--

Message sent to bug-coreutils@HIDDEN:

Subject: bug#34239: build failure on Android, due to S_MAGIC_* symbols
Resent-From: Jim Meyering <jim@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-coreutils@HIDDEN
Resent-Date: Sat, 16 Feb 2019 17:51:02 +0000
Resent-Message-ID: <handler.34239.B34239.155033942022109 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: =?UTF-8?Q?P=C3=A1draig?= Brady <P@HIDDEN>
Cc: 34239 <at> debbugs.gnu.org, Bruno Haible <bruno@HIDDEN>
MIME-Version: 1.0
References: <1643060.pFagY2F4Kt@omega>
 <190df5d5-dd38-085d-8aa0-a0c03665c447@HIDDEN>
In-Reply-To: <190df5d5-dd38-085d-8aa0-a0c03665c447@HIDDEN>
From: Jim Meyering <jim@HIDDEN>
Date: Sat, 16 Feb 2019 09:49:59 -0800
Message-ID: <CA+8g5KGy0fqZSb=kVJyzrTcxircUgFWRfGFHeYbxFNbPuWPWfg@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On Tue, Jan 29, 2019 at 9:01 PM P=C3=A1draig Brady <P@HIDDEN> wrote=
:
> On 28/01/19 19:19, Bruno Haible wrote:
> > Hi,
> >
> > Compiling coreutils on Android produces this error:
> >
> >   CC       src/tail.o
> > In file included from ../src/tail.c:63:
> > ../src/fs-is-local.h: In function 'is_local_fs_type':
> > ../src/fs-is-local.h:9: error: 'S_MAGIC_AAFS' undeclared (first use in =
this function)
> > ...
> > make[2]: *** [src/tail.o] Error 1
> >
> > The Android libc, Bionic, does not define any of these S_MAGIC_* symbol=
s or
> > macros, even in the newest version [1].
> >
> > Can some #ifdef be used to avoid this build failure?
> > 'defined __ANDROID__' tests for Android.
> > 'defined __linux__' tests for Linux excluding Android.
> >
> > Bruno
> >
> > [1] https://android.googlesource.com/platform/bionic/
>
> Interesting. So inotify is supported on that android system.
> Our ifdefs were wrong anyway as we check for remoteness even if one disab=
les inotify.
> I.E. our build would have failed on standard linux if one explicitly disa=
bled inotify.
> I've fixed that up and added support for the android specific "sdcardfs" =
which I found in:
> https://android.googlesource.com/kernel/common/+/android-mainline-trackin=
g/include/uapi/linux/magic.h
>
> Proposed patch attached.

Looks all good. Thanks!

Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.