Received: (at 34239) by debbugs.gnu.org; 16 Feb 2019 17:50:20 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 16 12:50:20 2019 Received: from localhost ([127.0.0.1]:50505 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1gv46W-0005kW-8t for submit <at> debbugs.gnu.org; Sat, 16 Feb 2019 12:50:20 -0500 Received: from mail-wr1-f44.google.com ([209.85.221.44]:43195) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <meyering@HIDDEN>) id 1gv46U-0005kG-FB for 34239 <at> debbugs.gnu.org; Sat, 16 Feb 2019 12:50:18 -0500 Received: by mail-wr1-f44.google.com with SMTP id r2so13591656wrv.10 for <34239 <at> debbugs.gnu.org>; Sat, 16 Feb 2019 09:50:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=krvnAVsa/vSwm/M+c+H2f7cU21HrhoTaaxlQe8pT3vA=; b=hsrhI89Ao5A2A1jTuUTlPabLW5tzPvfTg8J6Oh6xsVUkz0RCI+AmwOuAcrWPCmkZSj 7nICCOiHkvtzv7RXE5Rt3/xiWaKl6RhHag4adVsjiyXcSuNf5dUWVZ4G6U8LpKENyJzO g2j2zS3MdpPzfd16bEDULY0dmfFcrxhtnGOXUZnjvjnOyBQcxXHZzkZwDUVbU0GDHium d7AKk8Hpsd44D5y0TwxtwX99gH6tMk6j03pOI2iB/wpKcq7WWA5K9sFjj7ptEcI2e7BX pkHmyLQ+8TX30w127MBECeSCFvfd6FDrmWSG8M7w8LpR+9FuyctVpwht7tUMdenE8VWk obyg== X-Gm-Message-State: AHQUAubQjgHO/WOvd+yGmi1H7sY/X7zuwh+2KomDMMYTZIMWWTomt3al Ga0knRa18qMIBTqh6jHQHHyfSs13lpkpyGVTPxE= X-Google-Smtp-Source: AHgI3IZSSFoc0nqtQU/nGH3at535XGrMIVDi/6t0nFAXegwWVYkhFwMCppDj85zmAsIhAoxQjajgGxfGd/PiHwPMezo= X-Received: by 2002:adf:fa51:: with SMTP id y17mr11486067wrr.233.1550339412118; Sat, 16 Feb 2019 09:50:12 -0800 (PST) MIME-Version: 1.0 References: <1643060.pFagY2F4Kt@omega> <190df5d5-dd38-085d-8aa0-a0c03665c447@HIDDEN> In-Reply-To: <190df5d5-dd38-085d-8aa0-a0c03665c447@HIDDEN> From: Jim Meyering <jim@HIDDEN> Date: Sat, 16 Feb 2019 09:49:59 -0800 Message-ID: <CA+8g5KGy0fqZSb=kVJyzrTcxircUgFWRfGFHeYbxFNbPuWPWfg@HIDDEN> Subject: Re: bug#34239: build failure on Android, due to S_MAGIC_* symbols To: =?UTF-8?Q?P=C3=A1draig_Brady?= <P@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 34239 Cc: 34239 <at> debbugs.gnu.org, Bruno Haible <bruno@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.8 (/) On Tue, Jan 29, 2019 at 9:01 PM P=C3=A1draig Brady <P@HIDDEN> wrote= : > On 28/01/19 19:19, Bruno Haible wrote: > > Hi, > > > > Compiling coreutils on Android produces this error: > > > > CC src/tail.o > > In file included from ../src/tail.c:63: > > ../src/fs-is-local.h: In function 'is_local_fs_type': > > ../src/fs-is-local.h:9: error: 'S_MAGIC_AAFS' undeclared (first use in = this function) > > ... > > make[2]: *** [src/tail.o] Error 1 > > > > The Android libc, Bionic, does not define any of these S_MAGIC_* symbol= s or > > macros, even in the newest version [1]. > > > > Can some #ifdef be used to avoid this build failure? > > 'defined __ANDROID__' tests for Android. > > 'defined __linux__' tests for Linux excluding Android. > > > > Bruno > > > > [1] https://android.googlesource.com/platform/bionic/ > > Interesting. So inotify is supported on that android system. > Our ifdefs were wrong anyway as we check for remoteness even if one disab= les inotify. > I.E. our build would have failed on standard linux if one explicitly disa= bled inotify. > I've fixed that up and added support for the android specific "sdcardfs" = which I found in: > https://android.googlesource.com/kernel/common/+/android-mainline-trackin= g/include/uapi/linux/magic.h > > Proposed patch attached. Looks all good. Thanks!
bug-coreutils@HIDDEN:bug#34239; Package coreutils.
Full text available.
Received: (at 34239) by debbugs.gnu.org; 30 Jan 2019 05:00:40 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 30 00:00:40 2019
Received: from localhost ([127.0.0.1]:50995 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1gohzM-0005dG-C7
for submit <at> debbugs.gnu.org; Wed, 30 Jan 2019 00:00:40 -0500
Received: from mail.magicbluesmoke.com ([82.195.144.49]:52756)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <P@HIDDEN>) id 1gohzL-0005d8-1c
for 34239 <at> debbugs.gnu.org; Wed, 30 Jan 2019 00:00:39 -0500
Received: from localhost.localdomain (unknown [76.21.115.186])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
by mail.magicbluesmoke.com (Postfix) with ESMTPSA id CC3679FB7;
Wed, 30 Jan 2019 05:00:37 +0000 (GMT)
Subject: Re: bug#34239: build failure on Android, due to S_MAGIC_* symbols
To: Bruno Haible <bruno@HIDDEN>, 34239 <at> debbugs.gnu.org
References: <1643060.pFagY2F4Kt@omega>
From: =?UTF-8?Q?P=c3=a1draig_Brady?= <P@HIDDEN>
Message-ID: <190df5d5-dd38-085d-8aa0-a0c03665c447@HIDDEN>
Date: Tue, 29 Jan 2019 21:00:35 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <1643060.pFagY2F4Kt@omega>
Content-Type: multipart/mixed; boundary="------------3A7299D9B9B1A1106BB1ACDA"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 34239
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
This is a multi-part message in MIME format.
--------------3A7299D9B9B1A1106BB1ACDA
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
On 28/01/19 19:19, Bruno Haible wrote:
> Hi,
>
> Compiling coreutils on Android produces this error:
>
> CC src/tail.o
> In file included from ../src/tail.c:63:
> ../src/fs-is-local.h: In function 'is_local_fs_type':
> ../src/fs-is-local.h:9: error: 'S_MAGIC_AAFS' undeclared (first use in this function)
> ...
> make[2]: *** [src/tail.o] Error 1
>
> The Android libc, Bionic, does not define any of these S_MAGIC_* symbols or
> macros, even in the newest version [1].
>
> Can some #ifdef be used to avoid this build failure?
> 'defined __ANDROID__' tests for Android.
> 'defined __linux__' tests for Linux excluding Android.
>
> Bruno
>
> [1] https://android.googlesource.com/platform/bionic/
Interesting. So inotify is supported on that android system.
Our ifdefs were wrong anyway as we check for remoteness even if one disables inotify.
I.E. our build would have failed on standard linux if one explicitly disabled inotify.
I've fixed that up and added support for the android specific "sdcardfs" which I found in:
https://android.googlesource.com/kernel/common/+/android-mainline-tracking/include/uapi/linux/magic.h
Proposed patch attached.
thanks!
Pádraig
--------------3A7299D9B9B1A1106BB1ACDA
Content-Type: text/x-patch;
name="tail-android.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename="tail-android.patch"
From 500e567165d210a8d8a96e4084a5fdc6007b2ca8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?P=C3=A1draig=20Brady?= <P@HIDDEN>
Date: Tue, 29 Jan 2019 20:32:53 -0800
Subject: [PATCH] stat,tail: fix android build and support inotify
* src/extract-magic: Treat android like linux,
which fixes the build by ensuring the constants are defined.
* src/stat.c: Support all constants on android, including
the android specific "sdcardfs".
* src/tail.c: Fix inclusion of statfs headers to be independent
of inotify availability, as fremote() is used on linux even
if inotify has been disabled. Also enable fremote() on android.
* NEWS: Mention the improvment.
Fixes https://bugs.gnu.org/34239
---
NEWS | 5 +++++
src/extract-magic | 2 +-
src/stat.c | 4 +++-
src/tail.c | 7 +++++--
4 files changed, 14 insertions(+), 4 deletions(-)
diff --git a/NEWS b/NEWS
index 4b6b8bf..e6ccb19 100644
--- a/NEWS
+++ b/NEWS
@@ -69,6 +69,11 @@ GNU coreutils NEWS -*- outline -*-
and encodes and decodes printable text using various common encodings:
base64,base64url,base32,base32hex,base16,base2,z85.
+** Improvements
+
+ stat and tail now know about the "sdcardfs" file system on Android.
+ stat -f -c%T now reports the file system type, and tail -f uses inotify.
+
* Noteworthy changes in release 8.30 (2018-07-01) [stable]
diff --git a/src/extract-magic b/src/extract-magic
index 48c38df..892c1db 100644
--- a/src/extract-magic
+++ b/src/extract-magic
@@ -125,7 +125,7 @@ EOF
print $emit_magic ? $magic_comment : $map_comment;
$emit_magic
- and print "\n#if defined __linux__\n";
+ and print "\n#if defined __linux__ || defined __ANDROID__\n";
$emit_magic
or print "static inline int\n"
. "is_local_fs_type (unsigned long int magic)\n"
diff --git a/src/stat.c b/src/stat.c
index f17246d..c8f1809 100644
--- a/src/stat.c
+++ b/src/stat.c
@@ -235,7 +235,7 @@ human_fstype (STRUCT_STATVFS const *statfsbuf)
#else
switch (statfsbuf->f_type)
{
-# if defined __linux__
+# if defined __linux__ || defined __ANDROID__
/* Compare with what's in libc:
f=/a/libc/sysdeps/unix/sysv/linux/linux_fsinfo.h
@@ -450,6 +450,8 @@ human_fstype (STRUCT_STATVFS const *statfsbuf)
return "romfs";
case S_MAGIC_RPC_PIPEFS: /* 0x67596969 local */
return "rpc_pipefs";
+ case S_MAGIC_SDCARDFS: /* 0x5DCA2DF5 local */
+ return "sdcardfs";
case S_MAGIC_SECURITYFS: /* 0x73636673 local */
return "securityfs";
case S_MAGIC_SELINUX: /* 0xF97CFF8C local */
diff --git a/src/tail.c b/src/tail.c
index dee827b..8fab049 100644
--- a/src/tail.c
+++ b/src/tail.c
@@ -57,8 +57,10 @@
# include <sys/inotify.h>
/* 'select' is used by tail_forever_inotify. */
# include <sys/select.h>
+#endif
-/* inotify needs to know if a file is local. */
+/* Linux can optimize the handling of local files. */
+#if defined __linux__ || defined __ANDROID__
# include "fs.h"
# include "fs-is-local.h"
# if HAVE_SYS_STATFS_H
@@ -938,7 +940,8 @@ fremote (int fd, const char *name)
{
bool remote = true; /* be conservative (poll by default). */
-#if HAVE_FSTATFS && HAVE_STRUCT_STATFS_F_TYPE && defined __linux__
+#if HAVE_FSTATFS && HAVE_STRUCT_STATFS_F_TYPE \
+ && (defined __linux__ || defined __ANDROID__)
struct statfs buf;
int err = fstatfs (fd, &buf);
if (err != 0)
--
2.9.3
--------------3A7299D9B9B1A1106BB1ACDA--
bug-coreutils@HIDDEN:bug#34239; Package coreutils.
Full text available.Received: (at submit) by debbugs.gnu.org; 29 Jan 2019 03:19:59 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 28 22:19:59 2019 Received: from localhost ([127.0.0.1]:49664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1goJwM-0006u5-HH for submit <at> debbugs.gnu.org; Mon, 28 Jan 2019 22:19:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57840) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <bruno@HIDDEN>) id 1goJwJ-0006tr-QA for submit <at> debbugs.gnu.org; Mon, 28 Jan 2019 22:19:56 -0500 Received: from lists.gnu.org ([209.51.188.17]:56984) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from <bruno@HIDDEN>) id 1goJwE-0000cG-DV for submit <at> debbugs.gnu.org; Mon, 28 Jan 2019 22:19:50 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39806) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <bruno@HIDDEN>) id 1goJwC-0002mv-P8 for bug-coreutils@HIDDEN; Mon, 28 Jan 2019 22:19:50 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <bruno@HIDDEN>) id 1goJwB-0000bZ-6Z for bug-coreutils@HIDDEN; Mon, 28 Jan 2019 22:19:48 -0500 Received: from mo6-p00-ob.smtp.rzone.de ([2a01:238:20a:202:5300::5]:30488) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from <bruno@HIDDEN>) id 1goJwA-0000aY-Bf for bug-coreutils@HIDDEN; Mon, 28 Jan 2019 22:19:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1548731983; s=strato-dkim-0002; d=clisp.org; h=Message-ID:Date:Subject:To:From:X-RZG-CLASS-ID:X-RZG-AUTH:From: Subject:Sender; bh=E/7/zFoFf4Z3BzoxBk7sD5//7mU0QeYnsoOP7wioRaI=; b=lLBgoM0VFc9lk/zQB3ilMImzMg2lOeIVJ5F0FoVq5eViLLevYw8Hz7N/aAVQbo92aO VvPRsFVi6GFMUmQJoPAcCw7IRndUuigmv0OPRlv46sbJ3xWogjFLBHbYPizpEZ80/bc5 FG8hk0e6tURaNgsecUG2fnU/OpK31H8DEnfNjLS3WCWbZCcrXks9uzdgmqsDfbCOId+t HAl0h9mFPNYt3a9Zu9YGgt88LPbBpN+BvylnXuWDeouNbBAkuG8GRyA9FaH5nVfVd5Qc rTFDRRcevRqd4WMisKPDADRO6Tabn4yOSNf2mc8npEeElOZdQJn1on25HRKYW1T/X/UX Ic4w== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH+AHjwLuWOGKf2y/s=" X-RZG-CLASS-ID: mo00 Received: from bruno.haible.de by smtp.strato.de (RZmta 44.9 DYNA|AUTH) with ESMTPSA id v0a34ev0T3JhyxU (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Tue, 29 Jan 2019 04:19:43 +0100 (CET) From: Bruno Haible <bruno@HIDDEN> To: bug-coreutils@HIDDEN Subject: build failure on Android, due to S_MAGIC_* symbols Date: Tue, 29 Jan 2019 04:19:42 +0100 Message-ID: <1643060.pFagY2F4Kt@omega> User-Agent: KMail/5.1.3 (Linux/4.4.0-141-generic; KDE/5.18.0; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a01:238:20a:202:5300::5 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi, Compiling coreutils on Android produces this error: CC src/tail.o In file included from ../src/tail.c:63: ../src/fs-is-local.h: In function 'is_local_fs_type': ../src/fs-is-local.h:9: error: 'S_MAGIC_AAFS' undeclared (first use in this function) ../src/fs-is-local.h:9: error: (Each undeclared identifier is reported only once ../src/fs-is-local.h:9: error: for each function it appears in.) ../src/fs-is-local.h:10: error: 'S_MAGIC_ACFS' undeclared (first use in this function) ../src/fs-is-local.h:11: error: 'S_MAGIC_ADFS' undeclared (first use in this function) ../src/fs-is-local.h:12: error: 'S_MAGIC_AFFS' undeclared (first use in this function) ../src/fs-is-local.h:13: error: 'S_MAGIC_AFS' undeclared (first use in this function) ../src/fs-is-local.h:14: error: 'S_MAGIC_ANON_INODE_FS' undeclared (first use in this function) ../src/fs-is-local.h:15: error: 'S_MAGIC_AUFS' undeclared (first use in this function) ../src/fs-is-local.h:16: error: 'S_MAGIC_AUTOFS' undeclared (first use in this function) ../src/fs-is-local.h:17: error: 'S_MAGIC_BALLOON_KVM' undeclared (first use in this function) ../src/fs-is-local.h:18: error: 'S_MAGIC_BEFS' undeclared (first use in this function) ../src/fs-is-local.h:19: error: 'S_MAGIC_BDEVFS' undeclared (first use in this function) ../src/fs-is-local.h:20: error: 'S_MAGIC_BFS' undeclared (first use in this function) ../src/fs-is-local.h:21: error: 'S_MAGIC_BPF_FS' undeclared (first use in this function) ../src/fs-is-local.h:22: error: 'S_MAGIC_BINFMTFS' undeclared (first use in this function) ../src/fs-is-local.h:23: error: 'S_MAGIC_BTRFS' undeclared (first use in this function) ../src/fs-is-local.h:24: error: 'S_MAGIC_BTRFS_TEST' undeclared (first use in this function) ../src/fs-is-local.h:25: error: 'S_MAGIC_CEPH' undeclared (first use in this function) ../src/fs-is-local.h:26: error: 'S_MAGIC_CGROUP' undeclared (first use in this function) ../src/fs-is-local.h:27: error: 'S_MAGIC_CGROUP2' undeclared (first use in this function) ../src/fs-is-local.h:28: error: 'S_MAGIC_CIFS' undeclared (first use in this function) ../src/fs-is-local.h:29: error: 'S_MAGIC_CODA' undeclared (first use in this function) ../src/fs-is-local.h:30: error: 'S_MAGIC_COH' undeclared (first use in this function) ../src/fs-is-local.h:31: error: 'S_MAGIC_CONFIGFS' undeclared (first use in this function) ../src/fs-is-local.h:32: error: 'S_MAGIC_CRAMFS' undeclared (first use in this function) ../src/fs-is-local.h:33: error: 'S_MAGIC_CRAMFS_WEND' undeclared (first use in this function) ../src/fs-is-local.h:34: error: 'S_MAGIC_DAXFS' undeclared (first use in this function) ../src/fs-is-local.h:35: error: 'S_MAGIC_DEBUGFS' undeclared (first use in this function) ../src/fs-is-local.h:36: error: 'S_MAGIC_DEVFS' undeclared (first use in this function) ../src/fs-is-local.h:37: error: 'S_MAGIC_DEVPTS' undeclared (first use in this function) ../src/fs-is-local.h:38: error: 'S_MAGIC_ECRYPTFS' undeclared (first use in this function) ../src/fs-is-local.h:39: error: 'S_MAGIC_EFIVARFS' undeclared (first use in this function) ../src/fs-is-local.h:40: error: 'S_MAGIC_EFS' undeclared (first use in this function) ../src/fs-is-local.h:41: error: 'S_MAGIC_EXFS' undeclared (first use in this function) ../src/fs-is-local.h:42: error: 'S_MAGIC_EXOFS' undeclared (first use in this function) ../src/fs-is-local.h:43: error: 'S_MAGIC_EXT' undeclared (first use in this function) ../src/fs-is-local.h:44: error: 'S_MAGIC_EXT2' undeclared (first use in this function) ../src/fs-is-local.h:45: error: 'S_MAGIC_EXT2_OLD' undeclared (first use in this function) ../src/fs-is-local.h:46: error: 'S_MAGIC_F2FS' undeclared (first use in this function) ../src/fs-is-local.h:47: error: 'S_MAGIC_FAT' undeclared (first use in this function) ../src/fs-is-local.h:48: error: 'S_MAGIC_FHGFS' undeclared (first use in this function) ../src/fs-is-local.h:49: error: 'S_MAGIC_FUSEBLK' undeclared (first use in this function) ../src/fs-is-local.h:50: error: 'S_MAGIC_FUSECTL' undeclared (first use in this function) ../src/fs-is-local.h:51: error: 'S_MAGIC_FUTEXFS' undeclared (first use in this function) ../src/fs-is-local.h:52: error: 'S_MAGIC_GFS' undeclared (first use in this function) ../src/fs-is-local.h:53: error: 'S_MAGIC_GPFS' undeclared (first use in this function) ../src/fs-is-local.h:54: error: 'S_MAGIC_HFS' undeclared (first use in this function) ../src/fs-is-local.h:55: error: 'S_MAGIC_HFS_PLUS' undeclared (first use in this function) ../src/fs-is-local.h:56: error: 'S_MAGIC_HFS_X' undeclared (first use in this function) ../src/fs-is-local.h:57: error: 'S_MAGIC_HOSTFS' undeclared (first use in this function) ../src/fs-is-local.h:58: error: 'S_MAGIC_HPFS' undeclared (first use in this function) ../src/fs-is-local.h:59: error: 'S_MAGIC_HUGETLBFS' undeclared (first use in this function) ../src/fs-is-local.h:60: error: 'S_MAGIC_MTD_INODE_FS' undeclared (first use in this function) ../src/fs-is-local.h:61: error: 'S_MAGIC_IBRIX' undeclared (first use in this function) ../src/fs-is-local.h:62: error: 'S_MAGIC_INOTIFYFS' undeclared (first use in this function) ../src/fs-is-local.h:63: error: 'S_MAGIC_ISOFS' undeclared (first use in this function) ../src/fs-is-local.h:64: error: 'S_MAGIC_ISOFS_R_WIN' undeclared (first use in this function) ../src/fs-is-local.h:65: error: 'S_MAGIC_ISOFS_WIN' undeclared (first use in this function) ../src/fs-is-local.h:66: error: 'S_MAGIC_JFFS' undeclared (first use in this function) ../src/fs-is-local.h:67: error: 'S_MAGIC_JFFS2' undeclared (first use in this function) ../src/fs-is-local.h:68: error: 'S_MAGIC_JFS' undeclared (first use in this function) ../src/fs-is-local.h:69: error: 'S_MAGIC_KAFS' undeclared (first use in this function) ../src/fs-is-local.h:70: error: 'S_MAGIC_LOGFS' undeclared (first use in this function) ../src/fs-is-local.h:71: error: 'S_MAGIC_LUSTRE' undeclared (first use in this function) ../src/fs-is-local.h:72: error: 'S_MAGIC_M1FS' undeclared (first use in this function) ../src/fs-is-local.h:73: error: 'S_MAGIC_MINIX' undeclared (first use in this function) ../src/fs-is-local.h:74: error: 'S_MAGIC_MINIX_30' undeclared (first use in this function) ../src/fs-is-local.h:75: error: 'S_MAGIC_MINIX_V2' undeclared (first use in this function) ../src/fs-is-local.h:76: error: 'S_MAGIC_MINIX_V2_30' undeclared (first use in this function) ../src/fs-is-local.h:77: error: 'S_MAGIC_MINIX_V3' undeclared (first use in this function) ../src/fs-is-local.h:78: error: 'S_MAGIC_MQUEUE' undeclared (first use in this function) ../src/fs-is-local.h:79: error: 'S_MAGIC_MSDOS' undeclared (first use in this function) ../src/fs-is-local.h:80: error: 'S_MAGIC_NCP' undeclared (first use in this function) ../src/fs-is-local.h:81: error: 'S_MAGIC_NFS' undeclared (first use in this function) ../src/fs-is-local.h:82: error: 'S_MAGIC_NFSD' undeclared (first use in this function) ../src/fs-is-local.h:83: error: 'S_MAGIC_NILFS' undeclared (first use in this function) ../src/fs-is-local.h:84: error: 'S_MAGIC_NSFS' undeclared (first use in this function) ../src/fs-is-local.h:85: error: 'S_MAGIC_NTFS' undeclared (first use in this function) ../src/fs-is-local.h:86: error: 'S_MAGIC_OPENPROM' undeclared (first use in this function) ../src/fs-is-local.h:87: error: 'S_MAGIC_OCFS2' undeclared (first use in this function) ../src/fs-is-local.h:88: error: 'S_MAGIC_OVERLAYFS' undeclared (first use in this function) ../src/fs-is-local.h:89: error: 'S_MAGIC_PANFS' undeclared (first use in this function) ../src/fs-is-local.h:90: error: 'S_MAGIC_PIPEFS' undeclared (first use in this function) ../src/fs-is-local.h:91: error: 'S_MAGIC_PRL_FS' undeclared (first use in this function) ../src/fs-is-local.h:92: error: 'S_MAGIC_PROC' undeclared (first use in this function) ../src/fs-is-local.h:93: error: 'S_MAGIC_PSTOREFS' undeclared (first use in this function) ../src/fs-is-local.h:94: error: 'S_MAGIC_QNX4' undeclared (first use in this function) ../src/fs-is-local.h:95: error: 'S_MAGIC_QNX6' undeclared (first use in this function) ../src/fs-is-local.h:96: error: 'S_MAGIC_RAMFS' undeclared (first use in this function) ../src/fs-is-local.h:97: error: 'S_MAGIC_RDTGROUP' undeclared (first use in this function) ../src/fs-is-local.h:98: error: 'S_MAGIC_REISERFS' undeclared (first use in this function) ../src/fs-is-local.h:99: error: 'S_MAGIC_ROMFS' undeclared (first use in this function) ../src/fs-is-local.h:100: error: 'S_MAGIC_RPC_PIPEFS' undeclared (first use in this function) ../src/fs-is-local.h:101: error: 'S_MAGIC_SECURITYFS' undeclared (first use in this function) ../src/fs-is-local.h:102: error: 'S_MAGIC_SELINUX' undeclared (first use in this function) ../src/fs-is-local.h:103: error: 'S_MAGIC_SMACK' undeclared (first use in this function) ../src/fs-is-local.h:104: error: 'S_MAGIC_SMB' undeclared (first use in this function) ../src/fs-is-local.h:105: error: 'S_MAGIC_SMB2' undeclared (first use in this function) ../src/fs-is-local.h:106: error: 'S_MAGIC_SNFS' undeclared (first use in this function) ../src/fs-is-local.h:107: error: 'S_MAGIC_SOCKFS' undeclared (first use in this function) ../src/fs-is-local.h:108: error: 'S_MAGIC_SQUASHFS' undeclared (first use in this function) ../src/fs-is-local.h:109: error: 'S_MAGIC_SYSFS' undeclared (first use in this function) ../src/fs-is-local.h:110: error: 'S_MAGIC_SYSV2' undeclared (first use in this function) ../src/fs-is-local.h:111: error: 'S_MAGIC_SYSV4' undeclared (first use in this function) ../src/fs-is-local.h:112: error: 'S_MAGIC_TMPFS' undeclared (first use in this function) ../src/fs-is-local.h:113: error: 'S_MAGIC_TRACEFS' undeclared (first use in this function) ../src/fs-is-local.h:114: error: 'S_MAGIC_UBIFS' undeclared (first use in this function) ../src/fs-is-local.h:115: error: 'S_MAGIC_UDF' undeclared (first use in this function) ../src/fs-is-local.h:116: error: 'S_MAGIC_UFS' undeclared (first use in this function) ../src/fs-is-local.h:117: error: 'S_MAGIC_UFS_BYTESWAPPED' undeclared (first use in this function) ../src/fs-is-local.h:118: error: 'S_MAGIC_USBDEVFS' undeclared (first use in this function) ../src/fs-is-local.h:119: error: 'S_MAGIC_V9FS' undeclared (first use in this function) ../src/fs-is-local.h:120: error: 'S_MAGIC_VMHGFS' undeclared (first use in this function) ../src/fs-is-local.h:121: error: 'S_MAGIC_VXFS' undeclared (first use in this function) ../src/fs-is-local.h:122: error: 'S_MAGIC_VZFS' undeclared (first use in this function) ../src/fs-is-local.h:123: error: 'S_MAGIC_WSLFS' undeclared (first use in this function) ../src/fs-is-local.h:124: error: 'S_MAGIC_XENFS' undeclared (first use in this function) ../src/fs-is-local.h:125: error: 'S_MAGIC_XENIX' undeclared (first use in this function) ../src/fs-is-local.h:126: error: 'S_MAGIC_XFS' undeclared (first use in this function) ../src/fs-is-local.h:127: error: 'S_MAGIC_XIAFS' undeclared (first use in this function) ../src/fs-is-local.h:128: error: 'S_MAGIC_ZFS' undeclared (first use in this function) ../src/fs-is-local.h:129: error: 'S_MAGIC_ZSMALLOC' undeclared (first use in this function) make[2]: *** [src/tail.o] Error 1 The Android libc, Bionic, does not define any of these S_MAGIC_* symbols or macros, even in the newest version [1]. Can some #ifdef be used to avoid this build failure? 'defined __ANDROID__' tests for Android. 'defined __linux__' tests for Linux excluding Android. Bruno [1] https://android.googlesource.com/platform/bionic/
Bruno Haible <bruno@HIDDEN>:bug-coreutils@HIDDEN.
Full text available.bug-coreutils@HIDDEN:bug#34239; Package coreutils.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.