GNU logs - #37150, boring messages

Message sent to bug-guix@HIDDEN:

Subject: bug#37150: Erroneous uses of regex in the invokation of FIND-FILES
Resent-From: Alex Vong <alexvong1995@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Fri, 23 Aug 2019 02:51:02 +0000
Resent-Message-ID: <handler.37150.B.156652863230600 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 37150 <at> debbugs.gnu.org
References: <864l29iki4.fsf@HIDDEN> <87mug1ylg3.fsf@HIDDEN>
User-agent: mu4e 1.2.0; emacs 26.2
From: Alex Vong <alexvong1995@HIDDEN>
Date: Fri, 23 Aug 2019 10:50:02 +0800
Message-ID: <861rxcioit.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hello guix,

Currently, there are a lot of erroneous uses of regex in the invokation
of FIND-FILES. Please see the conversations below (taken from
https://lists.gnu.org/archive/html/guix-devel/2019-08/msg00149.html).

Mark H Weaver writes:

> Hi Alex,
>
> Alex Vong <alexvong1995@HIDDEN> writes:
>
>> I find out that there are a lof of erroneous uses of regex in the
>> invokation of FIND-FILES. The correct usage should be:
>>
>>   (find-files "." "\\.c$")
>>
>> Instead people write:
>>
>>   (find-files "." ".*\\.c")
>>
>> which match unwanted files.
>>
>> For examples, in the procedure CUSTOM-GCC, the correct regex should be:
>>
>>   "(c\\+\\+|cpp|g\\+\\+|gcov|gcc|gcc-.*)$"
>>
>> instead of:
>>
>>   ".*(c\\+\\+|cpp|g\\+\\+|gcov|gcc|gcc-.*)"
>>
>> Please correct me if I am wrong.
>
> You're right.  It would be good to fix these problems incrementally, as
> long as the changes don't cause too many rebuilds.
>
> Changes to core packages will need to wait for now, since 'core-updates'
> is frozen, and 'core-updates-next' should also be considered frozen,
> since it will become 'core-updates' as soon as Berlin has built it out a
> bit more.  (The only change in 'core-updates-next' relative to
> 'core-updates' is that the new bootstrap tarballs have been fixed to be
> deterministic.)
>
> For some of these fixes, it might be best to apply them to 'staging'.
>
>> Right now, the erroneous use of regex in CUSTOM-GCC casues the 'bin/'
>> directory of the output of gccgo, gcc-objc and gcc-objc++ to be empty.
>
> I'm uncertain how many rebuilds it would trigger to change 'custom-gcc',
> and I don't have confidence that "guix refresh -l" is capable of giving
> us a reliable answer.  In the meantime, would you like to file a bug
> report for this, so it's not forgotten?
>
> Thanks for looking into it.
>
>      Best,
>       Mark


=2D-=20
Stand with Hong Kong!
#Eye4HK
Alex

https://twitter.com/freedomhkg
https://twitter.com/stand_with_hk

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYIAB0WIQQwb8uPLAHCXSnTBVZh71Au9gJS8gUCXV9UWgAKCRBh71Au9gJS
8kCUAQCllDPx3sygAoAI2qJv74Dz6fKvF9FNh+j+WfJ+p/T9UAEA9CU9RJSp/0DA
SxHDGeHMcetMoj9nkgQq8AZPTrjaAgc=
=fvZ/
-----END PGP SIGNATURE-----
--=-=-=--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Alex Vong <alexvong1995@HIDDEN>
Subject: bug#37150: Acknowledgement (Erroneous uses of regex in the
 invokation of FIND-FILES)
Message-ID: <handler.37150.B.156652863230600.ack <at> debbugs.gnu.org>
References: <861rxcioit.fsf@HIDDEN>
X-Gnu-PR-Message: ack 37150
X-Gnu-PR-Package: guix
Reply-To: 37150 <at> debbugs.gnu.org
Date: Fri, 23 Aug 2019 02:51:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-guix@HIDDEN

If you wish to submit further information on this problem, please
send it to 37150 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
37150: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D37150
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-guix@HIDDEN:

Subject: bug#37150: Erroneous uses of regex in the invokation of FIND-FILES
Resent-From: Alex Vong <alexvong1995@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Fri, 23 Aug 2019 03:56:01 +0000
Resent-Message-ID: <handler.37150.B37150.156653251320359 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 37150 <at> debbugs.gnu.org
Cc: Mark H Weaver <mhw@HIDDEN>
References: <864l29iki4.fsf@HIDDEN> <87mug1ylg3.fsf@HIDDEN>
 <861rxcioit.fsf@HIDDEN>
User-agent: mu4e 1.2.0; emacs 26.2
From: Alex Vong <alexvong1995@HIDDEN>
In-reply-to: <861rxcioit.fsf@HIDDEN>
Date: Fri, 23 Aug 2019 11:55:00 +0800
Message-ID: <86zhk0h6y3.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="==-=-=";
 micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--==-=-=
Content-Type: multipart/mixed; boundary="=-=-="

--=-=-=
Content-Type: text/plain

Hello Mark,

>> You're right.  It would be good to fix these problems incrementally, as
>> long as the changes don't cause too many rebuilds.
>>
I agree we should fix it incrementally, like how the 'invoke' transition
was handled. The patch below does exactly that (it fixes the problem for
delta which causes 6 rebuilds only according to "guix refresh -l").


--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline;
 filename=0001-gnu-delta-Fix-regex-in-the-invokation-of-find-files.patch
Content-Transfer-Encoding: quoted-printable

From=20cb5f2febd564a2bcb550de537156db59588098c4 Mon Sep 17 00:00:00 2001
From: Alex Vong <alexvong1995@HIDDEN>
Date: Fri, 23 Aug 2019 11:06:49 +0800
Subject: [PATCH] gnu: delta: Fix regex in the invokation of 'find-files'.

See <https://bugs.gnu.org/37150> for more information.

* gnu/packages/debug.scm (delta)[arguments]: Fix regex.
=2D--
 gnu/packages/debug.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/debug.scm b/gnu/packages/debug.scm
index 82631deef6..e1cba5d3fe 100644
=2D-- a/gnu/packages/debug.scm
+++ b/gnu/packages/debug.scm
@@ -75,7 +75,7 @@
                (begin
                  (for-each (lambda (h)
                              (install-file h doc))
=2D                           `("License.txt" ,@(find-files "www" ".*\\.htm=
l")))
+                           `("License.txt" ,@(find-files "www" "\\.html$")=
))
                  (for-each (lambda (b)
                              (install-file b bin))
                            `("delta" "multidelta" "topformflat"))))
=2D-=20
2.23.0


--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


>> Changes to core packages will need to wait for now, since 'core-updates'
>> is frozen, and 'core-updates-next' should also be considered frozen,
>> since it will become 'core-updates' as soon as Berlin has built it out a
>> bit more.  (The only change in 'core-updates-next' relative to
>> 'core-updates' is that the new bootstrap tarballs have been fixed to be
>> deterministic.)
>>
>> For some of these fixes, it might be best to apply them to 'staging'.
>>
>>> Right now, the erroneous use of regex in CUSTOM-GCC casues the 'bin/'
>>> directory of the output of gccgo, gcc-objc and gcc-objc++ to be empty.
>>
>> I'm uncertain how many rebuilds it would trigger to change 'custom-gcc',
>> and I don't have confidence that "guix refresh -l" is capable of giving
>> us a reliable answer.  In the meantime, would you like to file a bug
>> report for this, so it's not forgotten?
>>
It would probably cause a world rebuild... I will wait for the next
cycle for patch submittion.

>> Thanks for looking into it.
>>
>>      Best,
>>       Mark

You're welcomed!


=2D-=20
Stand with Hong Kong!
#Eye4HK #BoycottMulan
Alex

https://twitter.com/freedomhkg
https://twitter.com/stand_with_hk

--=-=-=--

--==-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYIAB0WIQQwb8uPLAHCXSnTBVZh71Au9gJS8gUCXV9jlAAKCRBh71Au9gJS
8m0xAP9eWbx+nuJ7TlmIUiinZA//diChWzWivt0ay23kR806tQD+LuqLxadqBzgo
NE5rZb0DbRkdhmQoF5MVdJ8+4bdq0Qw=
=8hgq
-----END PGP SIGNATURE-----
--==-=-=--

Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.