X-Loop: help-debbugs@HIDDEN
Subject: bug#47291: [PATCH] Auto-detect ns-appearance of frames and call a hook when it changes
Resent-From: Daphne Preston-Kendal <dpk@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 21 Mar 2021 12:56:02 +0000
Resent-Message-ID: <handler.47291.B.1616331356397 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: report 47291
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: 47291 <at> debbugs.gnu.org
X-Debbugs-Original-To: bug-gnu-emacs@HIDDEN
Received: via spool by submit <at> debbugs.gnu.org id=B.1616331356397
(code B ref -1); Sun, 21 Mar 2021 12:56:02 +0000
Received: (at submit) by debbugs.gnu.org; 21 Mar 2021 12:55:56 +0000
Received: from localhost ([127.0.0.1]:53733 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1lNxca-00006J-7i
for submit <at> debbugs.gnu.org; Sun, 21 Mar 2021 08:55:56 -0400
Received: from lists.gnu.org ([209.51.188.17]:58190)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <dpk@HIDDEN>) id 1lNvd6-0003KG-FU
for submit <at> debbugs.gnu.org; Sun, 21 Mar 2021 06:48:21 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:54362)
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <dpk@HIDDEN>) id 1lNvd6-0004uR-4Y
for bug-gnu-emacs@HIDDEN; Sun, 21 Mar 2021 06:48:20 -0400
Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:43593)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <dpk@HIDDEN>) id 1lNvd4-00006c-4z
for bug-gnu-emacs@HIDDEN; Sun, 21 Mar 2021 06:48:19 -0400
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
by mailout.west.internal (Postfix) with ESMTP id 81D4C1572
for <bug-gnu-emacs@HIDDEN>; Sun, 21 Mar 2021 06:48:13 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute4.internal (MEProxy); Sun, 21 Mar 2021 06:48:13 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=content-type:date:from:message-id
:mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender
:x-me-sender:x-sasl-enc; s=fm2; bh=3+2HWhM4uIUGLiIc3H1homl1wYkoU
SShd2FO/dRekNs=; b=ZqJ//qGjFOEgJrb9pCU/9AtaDAzJGUEgiv3kft0jTkZHc
mWStsejjZCa1q4EbcjqlVNXVrw2cQIRWxK/6rW+JM3Diw9CwGEnKpMATE1JH6AIl
DUVQq4RtkJuvWpG/Ma+1fZSTANnoRj0pg5PwZqEBa/OtjLtP0Ox6Bw9UcvCn3g1H
A4Ihn2qqKPINlEdIl1Zd1efBYS9ilckhp8j2OlwkHnEqrCfjR5xcgHPLz7i4NX1g
/BHA9ElBni+I4LmJm6QGqfWKwMNN4Cj4ZLmC6J9d+50SfL5DcpOpXhGF4r13cdj8
eNcennJU7dMSfnXSlXsy+spUMC7zJNoaihY2KkDag==
X-ME-Sender: <xms:bCRXYBzO8i5WWZD5v6e0uB_vZmBvpvy0T1imS_mOo-1JhC1mhJTUjQ>
<xme:bCRXYBQGVbRm1CApDVmJ1hfgS_pt4V8duJn7hlZa0EZikd-noKRemR1eIBlfExuUJ
REMMPpnYOrtVXp5fQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudegvddgudelucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucenucfjughrpefhtggguffkfffvofesmhdtmherhh
dtjeenucfhrhhomhepffgrphhhnhgvucfrrhgvshhtohhnqdfmvghnuggrlhcuoeguphhk
sehnohhntggvfihorhgurdhorhhgqeenucggtffrrghtthgvrhhnpeegveffteejgfdutd
ffgfekkeejffehvdevkeejteelffetgefgteeghffhtddvheenucffohhmrghinhepghhn
uhdrohhrghenucfkphepleehrdeltddrvdefgedrudefleenucevlhhushhtvghrufhiii
gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpeguphhksehnohhntggvfihorhgurdho
rhhg
X-ME-Proxy: <xmx:bCRXYLXmeRVxWFOKY3XjzjVwTppc1GxxoS-M-n_s9heWphY2w_liBg>
<xmx:bCRXYDhF7ZMEeM4clzQK1ymAhYO3qxZ04unOtygNaKCRXu4A4sJo7w>
<xmx:bCRXYDCNGsTpqC4JlyDrqHd2nq9tPG1e5d7WuSS3CqtKrJbp2jllQQ>
<xmx:bSRXYHwLPthmZoW8VRhoahqMPbYNSdspG9Hl1ID4XA0wOsGcXcpFBg>
Received: from [192.168.0.3] (unknown [95.90.234.139])
by mail.messagingengine.com (Postfix) with ESMTPA id 97C20240423
for <bug-gnu-emacs@HIDDEN>; Sun, 21 Mar 2021 06:48:12 -0400 (EDT)
From: Daphne Preston-Kendal <dpk@HIDDEN>
Content-Type: multipart/mixed;
boundary="Apple-Mail=_00A35F14-D080-469E-85A2-0ADF277FA6D5"
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\))
Message-Id: <1B39376A-B108-41FD-87EE-52D68E8F7256@HIDDEN>
Date: Sun, 21 Mar 2021 11:48:10 +0100
X-Mailer: Apple Mail (2.3654.60.0.2.21)
Received-SPF: none client-ip=64.147.123.20; envelope-from=dpk@HIDDEN;
helo=wout4-smtp.messagingengine.com
X-Spam_score_int: -25
X-Spam_score: -2.6
X-Spam_bar: --
X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001,
SPF_NONE=0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -2.3 (--)
X-Mailman-Approved-At: Sun, 21 Mar 2021 08:55:55 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
--Apple-Mail=_00A35F14-D080-469E-85A2-0ADF277FA6D5
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
charset=utf-8
This is a slightly cleaned-up version of the patch I initially posted =
for
commentary on emacs-devel.
<https://lists.gnu.org/archive/html/emacs-devel/2021-03/msg00482.html>
The patch makes two closely related changes: when a new frame is
created, the ns-appearance parameter (which was already in Emacs) is
bound to 'light or 'dark depending on the system theme. (Previously,
it could be set explicitly and Emacs would respect that change on a
per-frame basis, but if it wasn't explicitly set it was unbound.)
Secondly, it registers an event handler for changes to the system-wide
theme, and when the system theme changes, it changes the ns-appearance
parameter of all frames to match the new system theme, and runs a new
hook, ns-dark-mode-changed-hook so that users can e.g. set a new Emacs
theme to match the new system theme or whatever.
The patch is against Emacs HEAD as of time of writing. (3cbf92323c)
As mentioned on emacs-devel, this is my first Emacs patch and my first
time programming Objective-C in a long while, so I=E2=80=99d definitely
appreciate feedback!
Daphne Preston-Kendal
--Apple-Mail=_00A35F14-D080-469E-85A2-0ADF277FA6D5
Content-Disposition: attachment;
filename=0001-Auto-detect-ns-appearance-of-frames-and-call-a-hook-.patch
Content-Type: application/octet-stream;
x-unix-mode=0644;
name="0001-Auto-detect-ns-appearance-of-frames-and-call-a-hook-.patch"
Content-Transfer-Encoding: quoted-printable
=46rom=20f0fec3e277432d20a38c50685a84448e7cd5a536=20Mon=20Sep=2017=20=
00:00:00=202001=0AFrom:=20Daphne=20Preston-Kendal=20<git@HIDDEN>=0ADate:=20=
Tue,=209=20Mar=202021=2013:05:13=20+0100=0ASubject:=20[PATCH]=20=
Auto-detect=20ns-appearance=20of=20frames=20and=20call=20a=20hook=20when=20=
it=0A=20changes.=0A=0A*=20src/nsfns.m=20(Fx_create_frame):=20=
Automatically=20set=20the=20ns-appearance=0Aparamter=20of=20a=20frame=20=
from=20the=20current=20system=20appearance=20on=20Mac=20OS.=0A*=20=
src/nsterm.m:=20Register=20for=20system=20dark/light=20mode=20change=20=
events=20on=0AMac=20OS,=20and=20update=20the=20ns-appearance=20parameter=20=
of=20frames=20when=20the=0Asystem=20theme=20changes,=20calling=20a=20new=20=
ns-dark-mode-changed-hook=20when=0Adone.=0A---=0A=20src/nsfns.m=20=20|=20=
10=20+++++++++-=0A=20src/nsterm.m=20|=2052=20=
++++++++++++++++++++++++++++++++++++++++++++++++++++=0A=202=20files=20=
changed,=2061=20insertions(+),=201=20deletion(-)=0A=0Adiff=20--git=20=
a/src/nsfns.m=20b/src/nsfns.m=0Aindex=205c4cc915e7..fc73725226=20100644=0A=
---=20a/src/nsfns.m=0A+++=20b/src/nsfns.m=0A@@=20-1284,7=20+1284,15=20@@=20=
Turn=20the=20input=20menu=20(an=20NSMenu)=20into=20a=20lisp=20list=20for=20=
tracking=20on=20lisp=20side.=0A=20=20=20else=20if=20(EQ=20(tem,=20=
Qlight))=0A=20=20=20=20=20FRAME_NS_APPEARANCE=20(f)=20=3D=20=
ns_appearance_aqua;=0A=20=20=20else=0A-=20=20=20=20FRAME_NS_APPEARANCE=20=
(f)=20=3D=20ns_appearance_system_default;=0A+=20=20=20=20{=0A+=20=20=20=20=
=20=20tem=20=3D=20[[[NSApp=20effectiveAppearance]=0A+=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20bestMatchFromAppearancesWithNames:@[=0A+=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
NSAppearanceNameAqua,=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20NSAppearanceNameDarkAqua=0A+=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20]=0A+=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20]=20=
isEqualToString:NSAppearanceNameDarkAqua]=20?=20Qdark=20:=20Qlight;=0A+=20=
=20=20=20=20=20FRAME_NS_APPEARANCE=20(f)=20=3D=20(tem=20=3D=3D=20Qdark=20=
?=20ns_appearance_vibrant_dark=20:=20ns_appearance_aqua);=0A+=20=20=20=20=
}=0A=20=20=20store_frame_param=20(f,=20Qns_appearance,=0A=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(!NILP=20(tem)=20&&=20=
!EQ=20(tem,=20Qunbound))=20?=20tem=20:=20Qnil);=0A=20=0Adiff=20--git=20=
a/src/nsterm.m=20b/src/nsterm.m=0Aindex=20bf175bbd18..2a0213dcb4=20=
100644=0A---=20a/src/nsterm.m=0A+++=20b/src/nsterm.m=0A@@=20-2207,6=20=
+2207,14=20@@=20so=20some=20key=20presses=20(TAB)=20are=20swallowed=20by=20=
the=20system.=20=20*/=0A=20#endif=20/*=20MAC_OS_X_VERSION_MAX_ALLOWED=20=
>=3D=20101000=20*/=0A=20}=0A=20=0A+void=0A+ns_update_system_appearance=20=
(struct=20frame=20*f,=20Lisp_Object=20new_value)=0A+{=0A+#if=20=
MAC_OS_X_VERSION_MAX_ALLOWED=20>=3D=20101000=0A+=20=20store_frame_param=20=
(f,=20Qns_appearance,=20new_value);=0A+#endif=20/*=20=
MAC_OS_X_VERSION_MAX_ALLOWED=20>=3D=20101000=20*/=0A+}=0A+=0A=20void=0A=20=
ns_set_transparent_titlebar=20(struct=20frame=20*f,=20Lisp_Object=20=
new_value,=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20Lisp_Object=20old_value)=0A@@=20-5926,6=20=
+5934,15=20@@=20-=20(void)applicationDidFinishLaunching:=20=
(NSNotification=20*)notification=0A=20=09=20object:nil];=0A=20#endif=0A=20=
=0A+#ifdef=20NS_IMPL_COCOA=0A+=20=20[[NSDistributedNotificationCenter=20=
defaultCenter]=0A+=20=20=20=20addObserver:self=0A+=20=20=20=20=20=20=20=
selector:@selector(darkModeDidChange:)=0A+=20=20=20=20=20=20=20=20=20=20=20=
name:@"AppleInterfaceThemeChangedNotification"=0A+=20=20=20=20=20=20=20=20=
=20object:nil=0A+=20=20=20];=0A+#endif=0A+=0A=20#ifdef=20NS_IMPL_COCOA=0A=
=20=20=20/*=20Some=20functions/methods=20in=20CoreFoundation/Foundation=20=
increase=20the=0A=20=20=20=20=20=20maximum=20number=20of=20open=20files=20=
for=20the=20process=20in=20their=20first=20call.=0A@@=20-5964,6=20=
+5981,36=20@@=20-=20(void)antialiasThresholdDidChange:(NSNotification=20=
*)notification=0A=20#endif=0A=20}=0A=20=0A+-=20=
(void)darkModeDidChange:(NSNotification=20*)notification=0A+{=0A+#ifdef=20=
NS_IMPL_COCOA=0A+=20=20NSTRACE=20("[EmacsApp=20darkModeDidChange:]");=0A=
+=0A+=20=20/*=20It=20appears=20that=20the=20=
AppleInterfaceThemeChangedNotification=20is=0A+=20=20=20=20=20sent=20to=20=
the=20app=20before=20the=20effectiveAppearance=20is=20set,=20so=0A+=20=20=
=20=20=20if=20the=20effectiveAppearance=20matches=20the=20dark=20theme,=20=
we=20assume=0A+=20=20=20=20=20the=20new=20theme=20is=20the=20light=20=
theme,=20and=20vice-versa.=20*/=0A+=20=20Lisp_Object=20new_value=20=3D=20=
[[[self=20effectiveAppearance]=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
bestMatchFromAppearancesWithNames:@[=0A+=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20NSAppearanceNameAqua,=0A+=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20NSAppearanceNameDarkAqua=0A+=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20]=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20]=20isEqualToString:NSAppearanceNameDarkAqua]=20=
?=20Qlight=20:=20Qdark;=0A+=0A+=20=20Lisp_Object=20tail,=20frame;=0A+=20=20=
FOR_EACH_FRAME=20(tail,=20frame)=0A+=20=20=20=20{=0A+=20=20=20=20=20=20=
struct=20frame=20*f=20=3D=20XFRAME=20(frame);=0A+=20=20=20=20=20=20=
EmacsView=20*view=20=3D=20(EmacsView=20*)FRAME_NS_VIEW=20(f);=0A+=20=20=20=
=20=20=20EmacsWindow=20*window=20=3D=20(EmacsWindow=20*)[view=20window];=0A=
+=20=20=20=20=20=20ns_update_system_appearance=20(f,=20new_value);=0A+=20=
=20=20=20=20=20ns_set_appearance=20(f,=20new_value,=0A+=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(new_value=20=3D=3D=
=20Qdark=20?=20Qlight=20:=20Qdark));=0A+=20=20=20=20}=0A+=0A+=20=20=
run_hook=20(Qns_dark_mode_changed_hook);=0A+#endif=0A+}=0A=20=0A=20/*=20=
Termination=20sequences:=0A=20=20=20=20=20C-x=20C-c:=0A@@=20-10199,6=20=
+10246,11=20@@=20Nil=20means=20use=20fullscreen=20the=20old=20(<=2010.7)=20=
way.=20=20The=20old=20way=20works=20better=20with=0A=20This=20variable=20=
is=20ignored=20on=20Mac=20OS=20X=20<=2010.7=20and=20GNUstep.=20=20*/);=0A=
=20=20=20ns_use_srgb_colorspace=20=3D=20YES;=0A=20=0A+=20=20DEFSYM=20=
(Qns_dark_mode_changed_hook,=20"ns-dark-mode-changed-hook");=0A+=0A+=20=20=
DEFVAR_LISP=20("ns-dark-mode-changed-hook",=20=
Vns_dark_mode_changed_hook,=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20doc:=20/*=20Hook=20run=20when=20the=20Mac=20OS=20system-wide=20UI=20=
theme=20changes=20from=20dark=20to=20light=20or=20vice=20versa.=20*/);=0A=
+=0A=20=20=20DEFVAR_BOOL=20("ns-use-mwheel-acceleration",=0A=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20ns_use_mwheel_acceleration,=0A=20=20=20=20=
=20=20doc:=20/*=20Non-nil=20means=20use=20macOS's=20standard=20mouse=20=
wheel=20acceleration.=0A--=20=0A2.24.3=20(Apple=20Git-128)=0A=0A=
--Apple-Mail=_00A35F14-D080-469E-85A2-0ADF277FA6D5
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
charset=us-ascii
--Apple-Mail=_00A35F14-D080-469E-85A2-0ADF277FA6D5--
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Daphne Preston-Kendal <dpk@HIDDEN> Subject: bug#47291: Acknowledgement ([PATCH] Auto-detect ns-appearance of frames and call a hook when it changes) Message-ID: <handler.47291.B.1616331356397.ack <at> debbugs.gnu.org> References: <1B39376A-B108-41FD-87EE-52D68E8F7256@HIDDEN> X-Gnu-PR-Message: ack 47291 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 47291 <at> debbugs.gnu.org Date: Sun, 21 Mar 2021 12:56:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): bug-gnu-emacs@HIDDEN If you wish to submit further information on this problem, please send it to 47291 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 47291: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D47291 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN
Subject: bug#47291: [PATCH] Auto-detect ns-appearance of frames and call a hook when it changes
Resent-From: Matt Armstrong <matt@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 23 Mar 2021 18:07:02 +0000
Resent-Message-ID: <handler.47291.B47291.161652277521967 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 47291
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Daphne Preston-Kendal <dpk@HIDDEN>, 47291 <at> debbugs.gnu.org
Received: via spool by 47291-submit <at> debbugs.gnu.org id=B47291.161652277521967
(code B ref 47291); Tue, 23 Mar 2021 18:07:02 +0000
Received: (at 47291) by debbugs.gnu.org; 23 Mar 2021 18:06:15 +0000
Received: from localhost ([127.0.0.1]:32948 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1lOlPy-0005iE-TP
for submit <at> debbugs.gnu.org; Tue, 23 Mar 2021 14:06:15 -0400
Received: from relay6-d.mail.gandi.net ([217.70.183.198]:40811)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <matt@HIDDEN>) id 1lOlPt-0005hr-Ir
for 47291 <at> debbugs.gnu.org; Tue, 23 Mar 2021 14:06:13 -0400
X-Originating-IP: 24.113.169.116
Received: from mdeb (24-113-169-116.wavecable.com [24.113.169.116])
(Authenticated sender: matt@HIDDEN)
by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 51050C0002;
Tue, 23 Mar 2021 18:06:02 +0000 (UTC)
Received: from matt by mdeb with local (Exim 4.94)
(envelope-from <matt@HIDDEN>)
id 1lOlPj-000Hi8-Ee; Tue, 23 Mar 2021 11:05:59 -0700
From: Matt Armstrong <matt@HIDDEN>
In-Reply-To: <1B39376A-B108-41FD-87EE-52D68E8F7256@HIDDEN>
References: <1B39376A-B108-41FD-87EE-52D68E8F7256@HIDDEN>
Date: Tue, 23 Mar 2021 11:05:59 -0700
Message-ID: <87blb9hhiw.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
Daphne Preston-Kendal <dpk@HIDDEN> writes:
> This is a slightly cleaned-up version of the patch I initially posted for
> commentary on emacs-devel.
> <https://lists.gnu.org/archive/html/emacs-devel/2021-03/msg00482.html>
>
> The patch makes two closely related changes: when a new frame is
> created, the ns-appearance parameter (which was already in Emacs) is
> bound to 'light or 'dark depending on the system theme. (Previously,
> it could be set explicitly and Emacs would respect that change on a
> per-frame basis, but if it wasn't explicitly set it was unbound.)
I think GTK already has similar functionality. When I change the GTK
theme Emacs' frame decorations change accordingly. So, to me this part
of the patch seems fine from the policy perspective that Lars raised on
emacs-devel.
> Secondly, it registers an event handler for changes to the system-wide
> theme, and when the system theme changes, it changes the ns-appearance
> parameter of all frames to match the new system theme, and runs a new
> hook, ns-dark-mode-changed-hook so that users can e.g. set a new Emacs
> theme to match the new system theme or whatever.
I suggested an alternative approach on emacs-devel -- use the
dynamic-setting.el mechanism which is used for GTK but expressed in a
general way.
Since Emacs already has that mechanism for GTK, I think this approach
would satisfy the policy issue Lars raised as well.
X-Loop: help-debbugs@HIDDEN
Subject: bug#47291: [PATCH] Auto-detect ns-appearance of frames and call a hook when it changes
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 18 May 2021 14:44:02 +0000
Resent-Message-ID: <handler.47291.B47291.162134902630721 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 47291
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Matt Armstrong <matt@HIDDEN>
Cc: Alan Third <alan@HIDDEN>, 47291 <at> debbugs.gnu.org, Daphne Preston-Kendal <dpk@HIDDEN>
Received: via spool by 47291-submit <at> debbugs.gnu.org id=B47291.162134902630721
(code B ref 47291); Tue, 18 May 2021 14:44:02 +0000
Received: (at 47291) by debbugs.gnu.org; 18 May 2021 14:43:46 +0000
Received: from localhost ([127.0.0.1]:56873 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1lj0wj-0007zR-U6
for submit <at> debbugs.gnu.org; Tue, 18 May 2021 10:43:46 -0400
Received: from quimby.gnus.org ([95.216.78.240]:43036)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <larsi@HIDDEN>) id 1lj0wh-0007zB-MJ
for 47291 <at> debbugs.gnu.org; Tue, 18 May 2021 10:43:44 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=jdTDsn1JvrHguvyUNbmP2GslBv+3ssFu8EjkhIV/8CY=; b=t4ma/kxXUf82+Sz03yGbRsnXkp
QLOBKEtqvgVPd+cBOijmFQ7lopD3i4FFDrtxHjdClaonv46YOZfG8rrUL3f7iVl0eGtE9S4KOliMw
vzktHItsrRk3OBJX1IPxK11AYcjD+eM1UjxbVFXqC257ky2jHadiV9irr8zNo9hHxYKs=;
Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo)
by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.92) (envelope-from <larsi@HIDDEN>)
id 1lj0wY-0006Le-8K; Tue, 18 May 2021 16:43:36 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <1B39376A-B108-41FD-87EE-52D68E8F7256@HIDDEN>
<87blb9hhiw.fsf@HIDDEN>
X-Now-Playing: Oval's _Eksploio_: "Brockaat"
Date: Tue, 18 May 2021 16:43:33 +0200
In-Reply-To: <87blb9hhiw.fsf@HIDDEN> (Matt Armstrong's message of "Tue, 23
Mar 2021 11:05:59 -0700")
Message-ID: <87tun0drvu.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
@@CONTACT_ADDRESS@@ for details.
Content preview: Matt Armstrong <matt@HIDDEN> writes: > I suggested an
alternative
approach on emacs-devel -- use the > dynamic-setting.el mechanism which is
used for GTK but expressed in a > general way. > > Since Emacs already has
that mechanism for GT [...]
Content analysis details: (-2.9 points, 5.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Matt Armstrong <matt@HIDDEN> writes:
> I suggested an alternative approach on emacs-devel -- use the
> dynamic-setting.el mechanism which is used for GTK but expressed in a
> general way.
>
> Since Emacs already has that mechanism for GTK, I think this approach
> would satisfy the policy issue Lars raised as well.
Yes, I think that might make sense... but I've added Alan to the CCs,
since this affects Macos things. Perhaps he has some comments on these
alternative approaches.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
X-Loop: help-debbugs@HIDDEN
Subject: bug#47291: [PATCH] Auto-detect ns-appearance of frames and call a hook when it changes
Resent-From: Alan Third <alan@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 18 May 2021 17:45:01 +0000
Resent-Message-ID: <handler.47291.B47291.16213598961514 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 47291
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Lars Ingebrigtsen <larsi@HIDDEN>
Cc: Matt Armstrong <matt@HIDDEN>, 47291 <at> debbugs.gnu.org, Daphne Preston-Kendal <dpk@HIDDEN>
Received: via spool by 47291-submit <at> debbugs.gnu.org id=B47291.16213598961514
(code B ref 47291); Tue, 18 May 2021 17:45:01 +0000
Received: (at 47291) by debbugs.gnu.org; 18 May 2021 17:44:56 +0000
Received: from localhost ([127.0.0.1]:57207 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1lj3m4-0000OM-6m
for submit <at> debbugs.gnu.org; Tue, 18 May 2021 13:44:56 -0400
Received: from outbound.soverin.net ([116.202.65.218]:35027)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <alan@HIDDEN>) id 1lj3m0-0000O4-NE
for 47291 <at> debbugs.gnu.org; Tue, 18 May 2021 13:44:54 -0400
Received: from smtp.soverin.net (unknown [10.10.3.28])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
(No client certificate requested)
by outbound.soverin.net (Postfix) with ESMTPS id 5DED360800;
Tue, 18 May 2021 17:44:46 +0000 (UTC)
Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.142]) by
soverin.net
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin;
t=1621359885; bh=E/esyjoTR7QacDFFdXDDtBaLeCBxwHBJE8kEf9+yNVQ=;
h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
b=nfMMe57IXN14yuk9fX+qWrIuW2NYVmZ/smW5VtwZAkhDaGzvTNNW0Jh2azUTSNhfP
DQ3tnesNztTDiCLJ4NGK4MhbHw8c7YnQwd/Q4npUZ695//y5X+6zrq0oBrsA9ff5LU
W35B1fc+uh9D8aH7D1OJxO3Sk0XjHK/2VRioBvyCxUzTf5E0W1/uDvH6UGrKVNeOXy
EVLchIXSulE4neV2krOSPmEZoxvWOj5/fhYGF3hngdC/iMQSUiz0HDsrCXEUdBcMtv
G4mK1cN+//U1kjlWtffSzythq6ZOSZxSTm5eSdfEOL0bsPjnAQvblsI6XkRN9S/vzc
aJM7UUZLrIKEw==
Received: from alan by faroe.holly.idiocy.org with local (Exim 4.94)
(envelope-from <alan@HIDDEN>)
id 1lj3lq-000157-8m; Tue, 18 May 2021 18:44:42 +0100
Date: Tue, 18 May 2021 18:44:42 +0100
From: Alan Third <alan@HIDDEN>
Message-ID: <YKP9Cm4RPhR0Qy3I@HIDDEN>
Mail-Followup-To: Alan Third <alan@HIDDEN>,
Lars Ingebrigtsen <larsi@HIDDEN>, Matt Armstrong <matt@HIDDEN>,
47291 <at> debbugs.gnu.org, Daphne Preston-Kendal <dpk@HIDDEN>
References: <1B39376A-B108-41FD-87EE-52D68E8F7256@HIDDEN>
<87blb9hhiw.fsf@HIDDEN> <87tun0drvu.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87tun0drvu.fsf@HIDDEN>
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
On Tue, May 18, 2021 at 04:43:33PM +0200, Lars Ingebrigtsen wrote:
> Matt Armstrong <matt@HIDDEN> writes:
>
> > I suggested an alternative approach on emacs-devel -- use the
> > dynamic-setting.el mechanism which is used for GTK but expressed in a
> > general way.
> >
> > Since Emacs already has that mechanism for GTK, I think this approach
> > would satisfy the policy issue Lars raised as well.
>
> Yes, I think that might make sense... but I've added Alan to the CCs,
> since this affects Macos things. Perhaps he has some comments on these
> alternative approaches.
I don't really have much of an opinion. I feel tying in with
pre-existing functionality is probably the way to go but I don't know
anything about it.
I think the first part of Daphne's change can go straight in if it's
in a separate patch.
--
Alan Third
X-Loop: help-debbugs@HIDDEN
Subject: bug#47291: [PATCH] Auto-detect ns-appearance of frames and call a hook when it changes
Resent-From: Daphne Preston-Kendal <dpk@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 18 May 2021 18:04:02 +0000
Resent-Message-ID: <handler.47291.B47291.16213610013399 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 47291
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Matt Armstrong <matt@HIDDEN>
Cc: 47291 <at> debbugs.gnu.org
Received: via spool by 47291-submit <at> debbugs.gnu.org id=B47291.16213610013399
(code B ref 47291); Tue, 18 May 2021 18:04:02 +0000
Received: (at 47291) by debbugs.gnu.org; 18 May 2021 18:03:21 +0000
Received: from localhost ([127.0.0.1]:57238 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1lj43t-0000sk-FJ
for submit <at> debbugs.gnu.org; Tue, 18 May 2021 14:03:21 -0400
Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:33549)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <dpk@HIDDEN>) id 1lj43o-0000sS-3V
for 47291 <at> debbugs.gnu.org; Tue, 18 May 2021 14:03:19 -0400
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.west.internal (Postfix) with ESMTP id D1ABF1683;
Tue, 18 May 2021 14:03:09 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute1.internal (MEProxy); Tue, 18 May 2021 14:03:10 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm2; bh=a30JOXV/CIdsSyvkLt1oDFhS2Gg+oYk0jJk0tk0Pq
AI=; b=wwJeau5fUy89vv9+yengYkcEKqIiSRPLcDAoSO1/Q/FjZoipkgWzoMWzf
ApHIqELqQ6iQShE2gZ9RaUyMQU3dsJf+MmkJ+P1N5d23c/YLaL82in1BG5kC2RlK
TAqAj3R+7YLhscWqDPX9/0RavuxrcnpZc/CURGhUHhGroovmfj9ebUzSpRefPhnQ
NSVTVAnr8VFbE+pXO1IrhHQJ6JCoofaVHEfK+Bt5Le95hZpX5d9EOhWSgJPiMUcK
CcuQ2rQPZEXn9my3LnbFaRN+qV5yOh5nB4waymsiKBOZbPzL2DkJuHqDHyKL46GV
L20NlZrLjO6zsBXIlXTg0bTgk3PzQ==
X-ME-Sender: <xms:XQGkYPP6ZTrPwotGQktw2NjPn1vTFqs4xQ26-3wGJCxsrVYjQIhQSQ>
<xme:XQGkYJ9H3NZja7qpNMVRDinvp6Y8Ljkaed7nObcIUYhA54RPGbbpKHEHJEhRD14za
u8hfA8xHu7Nr5yc0g>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdeijedguddvtdcutefuodetggdotefrod
ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
enucfjughrpegtggfuhfgjfffgkfhfvffosehtqhhmtdhhtdejnecuhfhrohhmpeffrghp
hhhnvgcurfhrvghsthhonhdqmfgvnhgurghluceoughpkhesnhhonhgtvgifohhrugdroh
hrgheqnecuggftrfgrthhtvghrnhepjeejleejvefgiefhteeijeeiueegfeefveekheeg
leekjeekhfdvueehgeeigedtnecukfhppeelhedrledtrddvfeegrddufeelnecuvehluh
hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepughpkhesnhhonhgt
vgifohhrugdrohhrgh
X-ME-Proxy: <xmx:XQGkYOSwF0TrjdccpOJ5ZoS7JCs6ccoXoxkfw-r_gjeD3YheLmLodw>
<xmx:XQGkYDuVFlZuwNJT2h7sXY-KEuHkO1RbAkziC2LJmTROIB-Jxjbm4w>
<xmx:XQGkYHdQWOqjfjGewz1P4UbWJUAv2gCs_WyBNLwYV1e5tT9PL67XoA>
<xmx:XQGkYBqxcZz1LVSehXt74wVnum5Zr0kHQT_wIsY7zbCHddO9BVSsmA>
Received: from smtpclient.apple (ip5f5aea8b.dynamic.kabel-deutschland.de
[95.90.234.139]) by mail.messagingengine.com (Postfix) with ESMTPA;
Tue, 18 May 2021 14:03:07 -0400 (EDT)
Content-Type: text/plain;
charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.80.0.2.43\))
From: Daphne Preston-Kendal <dpk@HIDDEN>
In-Reply-To: <87blb9hhiw.fsf@HIDDEN>
Date: Tue, 18 May 2021 20:03:04 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <CAE411AB-D39A-47E4-B714-368DEEB4A271@HIDDEN>
References: <1B39376A-B108-41FD-87EE-52D68E8F7256@HIDDEN>
<87blb9hhiw.fsf@HIDDEN>
X-Mailer: Apple Mail (2.3654.80.0.2.43)
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
On 23 Mar 2021, at 19:05, Matt Armstrong <matt@HIDDEN> wrote:
> I suggested an alternative approach on emacs-devel -- use the
> dynamic-setting.el mechanism which is used for GTK but expressed in a
> general way.
I took a look at dynamic-setting.el but couldn=E2=80=99t quite see how =
what
this patch does would fit in with it/how it would enable the same
functionality as this patch provides. It doesn=E2=80=99t seem to be
documented? (Though in fairness, either is my patch at the moment!)
The goal of this patch is to allow Emacs to automatically select
different themes depending on the system-wide setting, and
automatically change which theme is in use when the system-wide
setting changes. There may be multiple themes involved in the change =E2=80=
=94
for instance, I would want the light smart-mode-line theme plus light
buffer theme enabled when the system is in light mode, but both should
be deactivated and changed to the dark smart-mode-line and buffer
themes when the system changes to dark mode.
Is it possible to do that within the framework of what dynamic-setting
provides? Sorry if this is obvious, I=E2=80=99m just not familiar with =
this
bit of Emacs.
Daphne
X-Loop: help-debbugs@HIDDEN
Subject: bug#47291: [PATCH] Auto-detect ns-appearance of frames and call a hook when it changes
Resent-From: Daphne Preston-Kendal <dpk@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 08 Oct 2021 08:25:01 +0000
Resent-Message-ID: <handler.47291.B47291.163368146531850 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 47291
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: 47291 <at> debbugs.gnu.org
Received: via spool by 47291-submit <at> debbugs.gnu.org id=B47291.163368146531850
(code B ref 47291); Fri, 08 Oct 2021 08:25:01 +0000
Received: (at 47291) by debbugs.gnu.org; 8 Oct 2021 08:24:25 +0000
Received: from localhost ([127.0.0.1]:49045 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1mYlB3-0008He-Lt
for submit <at> debbugs.gnu.org; Fri, 08 Oct 2021 04:24:25 -0400
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:47911)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <dpk@HIDDEN>) id 1mYlB2-0008HR-KP
for 47291 <at> debbugs.gnu.org; Fri, 08 Oct 2021 04:24:25 -0400
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
by mailout.nyi.internal (Postfix) with ESMTP id 223A05C00E0
for <47291 <at> debbugs.gnu.org>; Fri, 8 Oct 2021 04:24:19 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute4.internal (MEProxy); Fri, 08 Oct 2021 04:24:19 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm1; bh=yEVkF1p6ONd4XXu31tUjkNxKtcFya5CNAvBr2DDNa
h0=; b=XVhESKL0Mi/HtDmp1zToNBWihWqVgCxCWcZbtb+Nxded/y9IXrJNK7cEg
OK+HwFF5MNu8rzFj/PJrCtT2ZFUPeE6DNmhFRSD2InGH3htpZujsQb+AER9wgUpw
LEiB0+EKsbf8MqNFiaHGERiaQXJgCyM5V2kzV4R/RDb9JPLPq2Vd7WquPB9krZpx
KP1Q9drc0w83H0auA5I28ISEBRHjZBvFtGiUcIRvFIXG+c5Zur3tUpuNITX6vUwj
mRHYrouUe66/OS3LAIeKVepLmFQ6GC0SYfAh/78i9NE18YwiiD4zgsR3B+nznz7E
Q2jcDWawrk4tmT58nEpeQnAuA5Zeg==
X-ME-Sender: <xms:MgBgYXEWHuVcdjr56PJNaioffcfxnC_YdAp09GubhQWAID2Atb9WWQ>
<xme:MgBgYUUwG4wk2j0sQsCJSxxs3HLYLyGLX7DoMnp_fizLPmWPvYtckwQ1GT_gKfjNq
4HARlUr1Qa0Mcd46w>
X-ME-Received: <xmr:MgBgYZLj7WF2nBB5eLN26qHnDVWWqiOgP21tkYLdyRFWOTwPUSElDenFYJxSBuUNXBrx2zX-VGF_f-QnaSBwjURAIkZX1yFzebChqq8nu7oR5v8>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddttddgtddvucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucenucfjughrpefhtgfgggfuffhfvfgjkffosehtqh
hmtdhhtdejnecuhfhrohhmpeffrghphhhnvgcurfhrvghsthhonhdqmfgvnhgurghluceo
ughpkhesnhhonhgtvgifohhrugdrohhrgheqnecuggftrfgrthhtvghrnhephfetueektd
fgveefhedvheekhfdtffeiieeugfefueevtdeljeduueevgeetheegnecuvehluhhsthgv
rhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepughpkhesnhhonhgtvgifoh
hrugdrohhrgh
X-ME-Proxy: <xmx:MgBgYVF9OhhGT4yqou7me6w7tliPBfxoxMFM9u_LjsoxEtaYRzux4A>
<xmx:MgBgYdXlbd57_Z2dpuiUAWHJUIiPhOAlLh_Tz2j3ioFGLWmFz3JWeg>
<xmx:MgBgYQPWiohI_M62oVrvxCbqlqz5wE7TRjEjc3bkcdg3-zgiVB7-qg>
<xmx:MwBgYVh-djLdK-S5ZP5xG_ueLqjHjUCXFczFuuEdtrx92WUlt94CgQ>
Received: by mail.messagingengine.com (Postfix) with ESMTPA for
<47291 <at> debbugs.gnu.org>; Fri, 8 Oct 2021 04:24:18 -0400 (EDT)
From: Daphne Preston-Kendal <dpk@HIDDEN>
Content-Type: text/plain;
charset=utf-8
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\))
Date: Fri, 8 Oct 2021 10:24:16 +0200
References: <1B39376A-B108-41FD-87EE-52D68E8F7256@HIDDEN>
<87blb9hhiw.fsf@HIDDEN>
<CAE411AB-D39A-47E4-B714-368DEEB4A271@HIDDEN>
In-Reply-To: <CAE411AB-D39A-47E4-B714-368DEEB4A271@HIDDEN>
Message-Id: <32D4CA88-145B-4519-A372-3E8B56A36441@HIDDEN>
X-Mailer: Apple Mail (2.3654.120.0.1.13)
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
On 18 May 2021, at 20:03, Daphne Preston-Kendal <dpk@HIDDEN> =
wrote:
> Is it possible to do that within the framework of what dynamic-setting
> provides? Sorry if this is obvious, I=E2=80=99m just not familiar with =
this
> bit of Emacs.
Since there have been no answers since May, I=E2=80=99d like to suggest/
request that my patch be merged in more or less as it is. If there is
an OS-portable mechanism for detecting light/dark switches somewhere
in a Lisp library, like dynamic-setting.el, then the patch I provide
here can still work as the underlying C implementation, and we can
bridge them together at the Lisp level later. An analogy for this
approach would be how the Lisp-level interprogram-{cut,paste}-function
settings bridge to underlying ns-get-selection and ns-own-selection
functions on Mac OS, but to other things on free OSes.
I=E2=80=99d really like to see this in Emacs 28 if possible!
Daphne
X-Loop: help-debbugs@HIDDEN
Subject: bug#47291: bug#51404: Support system dark mode on Windows 10
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 11 Nov 2021 05:37:01 +0000
Resent-Message-ID: <handler.47291.B47291.163660898316800 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 47291
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Eli Zaretskii <eliz@HIDDEN>
Cc: Vince Salvino <salvino@HIDDEN>, 51404 <at> debbugs.gnu.org, 47291 <at> debbugs.gnu.org
Received: via spool by 47291-submit <at> debbugs.gnu.org id=B47291.163660898316800
(code B ref 47291); Thu, 11 Nov 2021 05:37:01 +0000
Received: (at 47291) by debbugs.gnu.org; 11 Nov 2021 05:36:23 +0000
Received: from localhost ([127.0.0.1]:39875 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ml2l5-0004Mr-HN
for submit <at> debbugs.gnu.org; Thu, 11 Nov 2021 00:36:23 -0500
Received: from quimby.gnus.org ([95.216.78.240]:50206)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <larsi@HIDDEN>)
id 1ml2l2-0004MY-NG; Thu, 11 Nov 2021 00:36:21 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=mzjntn0LwIWCNzk4cYH++LOQharC2AAiBkT2W6+tp1Q=; b=u5fp25xI3tKkJYi73d3rPITLoQ
iRWtHX3oFTWw89jHamnfZcbR3SfW24UGWaOt4sjIujP7J1mAzPdikNZeaLNLZinaHZ1lbVkAumSUM
RONkkXvTuOCOmjAa9lbVn5EDTtVCWXJ/Lf+TSw1qHZeDPj26PQww5oH9OJN7Wn+dky1Q=;
Received: from [84.212.220.105] (helo=xo)
by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.92) (envelope-from <larsi@HIDDEN>)
id 1ml2kt-0002j9-NN; Thu, 11 Nov 2021 06:36:14 +0100
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <CH2PR12MB4231758A937F6FB9F33291CFA5849@HIDDEN>
<834k93zxyo.fsf@HIDDEN>
<CH2PR12MB4231BD9B939F3D485536A5BAA5849@HIDDEN>
<838ryfyawv.fsf@HIDDEN>
<CH2PR12MB4231BF93A366641B94D7A636A5849@HIDDEN>
<CH2PR12MB423138F5C432C2BBF330BC6BA5859@HIDDEN>
<83r1c5tyar.fsf@HIDDEN> <83a6iqpzrv.fsf@HIDDEN>
<ddm9cg097co1e4d11e8bh6c6.1635613989653@HIDDEN>
<83k0huo1iy.fsf@HIDDEN>
X-Now-Playing: King Crimson's _The Complete 1969 Recordings (26): BBC
Sessions_: "Trees"
Date: Thu, 11 Nov 2021 06:36:09 +0100
In-Reply-To: <83k0huo1iy.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 30 Oct
2021 20:39:17 +0300")
Message-ID: <87wnlf8d9y.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
@@CONTACT_ADDRESS@@ for details.
Content preview: Eli Zaretskii <eliz@HIDDEN> writes: > I'm not sure I
understand
why 'light' necessarily means the old > behavior: we didn't set any theme
before this change, we just used the > Windows default. So maybe there should
be 4 values: > > nil [...]
Content analysis details: (-2.9 points, 5.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Eli Zaretskii <eliz@HIDDEN> writes:
> I'm not sure I understand why 'light' necessarily means the old
> behavior: we didn't set any theme before this change, we just used the
> Windows default. So maybe there should be 4 values:
>
> nil: never follow the system theme (use Windows default)
> t: always follow the system theme
> light: force light theme (currently the same as nil)
> dark: force dark theme.
For a similar bug report, see bug#47291. And we really should support
this on GNU/Linux, too, so having three different methods to support
this seems sub-optimal.
dynamic-setting.el seems like the most likely place to centralise all
this, I think? I've had a look at what happens when you change the
theme in Gnome, and dynamic-setting-handle-config-changed-event gets
called with an
(config-changed-event theme-name ":1")
event. (But not what the event name is -- anybody know how to get at
that?)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
X-Loop: help-debbugs@HIDDEN
Subject: bug#47291: bug#51404: Support system dark mode on Windows 10
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 11 Nov 2021 07:52:02 +0000
Resent-Message-ID: <handler.47291.B47291.16366170891261 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 47291
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Lars Ingebrigtsen <larsi@HIDDEN>
Cc: salvino@HIDDEN, 51404 <at> debbugs.gnu.org, 47291 <at> debbugs.gnu.org
Received: via spool by 47291-submit <at> debbugs.gnu.org id=B47291.16366170891261
(code B ref 47291); Thu, 11 Nov 2021 07:52:02 +0000
Received: (at 47291) by debbugs.gnu.org; 11 Nov 2021 07:51:29 +0000
Received: from localhost ([127.0.0.1]:40052 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ml4ro-0000KF-Nt
for submit <at> debbugs.gnu.org; Thu, 11 Nov 2021 02:51:28 -0500
Received: from eggs.gnu.org ([209.51.188.92]:37516)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>)
id 1ml4rl-0000Jw-At; Thu, 11 Nov 2021 02:51:25 -0500
Received: from [2001:470:142:3::e] (port=44676 helo=fencepost.gnu.org)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1ml4rf-0000lW-Pb; Thu, 11 Nov 2021 02:51:19 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=gJyEuzZTmsxqRlWo3gN/CCJe1XXhDEBWJtg+Sn4tRYo=; b=meeiYWvGJ9z9
tLy06PmYvrnnqBSv6NoLkmUY8vo+7rLe+UjSxz4IOsNWBHvgYPoA5qKKgKOMZrhVE5U84uhiouQ0A
ApxGNBqUvpZOSVB2U/6mWjSoJTWqGNvExKjh+etQoJO409w6ND7cIB/DwYRU8ocJyEM8Yi9dwXXUu
Usss4ut7I6P03rdo6TEaYAsBXKhcWKcT0zyH7+K7MpK1CRy0hiqK6EkInOpiHnV2NumQRQ7n5no8b
Kabmho6p0u8Gvfni5cXy+Yt2+/+FbHe92n8Wg4YgKmMsG+LtWL72YqgkxKsGA2y4L70A2vDK1I5X+
fyV8+CCqBWfxlKTTIyA4EQ==;
Received: from [87.69.77.57] (port=3193 helo=home-c4e4a596f7)
by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1ml4rf-0008OV-BL; Thu, 11 Nov 2021 02:51:19 -0500
Date: Thu, 11 Nov 2021 09:51:16 +0200
Message-Id: <83wnlf166j.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <87wnlf8d9y.fsf@HIDDEN> (message from Lars Ingebrigtsen on Thu,
11 Nov 2021 06:36:09 +0100)
References: <CH2PR12MB4231758A937F6FB9F33291CFA5849@HIDDEN>
<834k93zxyo.fsf@HIDDEN>
<CH2PR12MB4231BD9B939F3D485536A5BAA5849@HIDDEN>
<838ryfyawv.fsf@HIDDEN>
<CH2PR12MB4231BF93A366641B94D7A636A5849@HIDDEN>
<CH2PR12MB423138F5C432C2BBF330BC6BA5859@HIDDEN>
<83r1c5tyar.fsf@HIDDEN> <83a6iqpzrv.fsf@HIDDEN>
<ddm9cg097co1e4d11e8bh6c6.1635613989653@HIDDEN>
<83k0huo1iy.fsf@HIDDEN> <87wnlf8d9y.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: Lars Ingebrigtsen <larsi@HIDDEN>
> Cc: Vince Salvino <salvino@HIDDEN>, 51404 <at> debbugs.gnu.org,
> 47291 <at> debbugs.gnu.org
> Date: Thu, 11 Nov 2021 06:36:09 +0100
>
> Eli Zaretskii <eliz@HIDDEN> writes:
>
> > I'm not sure I understand why 'light' necessarily means the old
> > behavior: we didn't set any theme before this change, we just used the
> > Windows default. So maybe there should be 4 values:
> >
> > nil: never follow the system theme (use Windows default)
> > t: always follow the system theme
> > light: force light theme (currently the same as nil)
> > dark: force dark theme.
>
> For a similar bug report, see bug#47291. And we really should support
> this on GNU/Linux, too, so having three different methods to support
> this seems sub-optimal.
I'm not sure unification is possible here, because the functionality
is quite different, AFAICT. At least for the functionality in this
bug report, we cannot apply the system theme to an existing frame, we
can only apply it at frame creation time. So having a handler for
such changes will be able to affect only the frames created after the
change. Or at least that is my understanding; the code definitely
applies the dark/light theme as part of creating a frame.
Also, having a dynamic thing that tracks changes in these settings
would on Windows mean listening and processing a special window-system
message, which seems to be WM_THEMECHANGED or maybe WM_SETTINGCHANGE.
But that's not what the code installed in this bug report does.
So the functionality seems similar, but the details differ.
X-Loop: help-debbugs@HIDDEN
Subject: bug#47291: bug#51404: Support system dark mode on Windows 10
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 11 Nov 2021 12:16:01 +0000
Resent-Message-ID: <handler.47291.B47291.163663293229807 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 47291
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Eli Zaretskii <eliz@HIDDEN>
Cc: salvino@HIDDEN, 51404 <at> debbugs.gnu.org, 47291 <at> debbugs.gnu.org
Received: via spool by 47291-submit <at> debbugs.gnu.org id=B47291.163663293229807
(code B ref 47291); Thu, 11 Nov 2021 12:16:01 +0000
Received: (at 47291) by debbugs.gnu.org; 11 Nov 2021 12:15:32 +0000
Received: from localhost ([127.0.0.1]:40342 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ml8zL-0007kd-70
for submit <at> debbugs.gnu.org; Thu, 11 Nov 2021 07:15:31 -0500
Received: from quimby.gnus.org ([95.216.78.240]:53624)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <larsi@HIDDEN>)
id 1ml8z3-0007jw-ID; Thu, 11 Nov 2021 07:15:29 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=GP54OdRhE5PVChyqcqHU57Gn/RE/mHzenueTptACiqk=; b=oIX1s7mLR03+ZXsZL5JhzfPlRj
W8UKQwH/Bxek6BHId76cGvTs9MG8HQuTanbTqaFunrSCTyYLm1iiKBGCwgwF8FyTxNWW+WbK3KN8P
FpadLexHISXNBkdEWhyUT3sWmcCufuNwWxMZ9/S+b4S1ihMUAsTyR2ePceHiFxSlFtZM=;
Received: from [84.212.220.105] (helo=xo)
by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.92) (envelope-from <larsi@HIDDEN>)
id 1ml8yu-0005Xq-7E; Thu, 11 Nov 2021 13:15:07 +0100
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <CH2PR12MB4231758A937F6FB9F33291CFA5849@HIDDEN>
<834k93zxyo.fsf@HIDDEN>
<CH2PR12MB4231BD9B939F3D485536A5BAA5849@HIDDEN>
<838ryfyawv.fsf@HIDDEN>
<CH2PR12MB4231BF93A366641B94D7A636A5849@HIDDEN>
<CH2PR12MB423138F5C432C2BBF330BC6BA5859@HIDDEN>
<83r1c5tyar.fsf@HIDDEN> <83a6iqpzrv.fsf@HIDDEN>
<ddm9cg097co1e4d11e8bh6c6.1635613989653@HIDDEN>
<83k0huo1iy.fsf@HIDDEN> <87wnlf8d9y.fsf@HIDDEN>
<83wnlf166j.fsf@HIDDEN>
Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj
SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEWDe3BYU0yll4K9
oXnauo3gvo7gwZT///+NHmO0AAAAAWJLR0QHFmGI6wAAAAd0SU1FB+ULCwwJAYVT5DoAAAG3SURB
VDjLdZNNbqQwEIXd0WQPMxdApJV1NEazjgabA6SrvI4S7PsfYV65yuBoOg+1G/zh+sddxsFBF9fr
Mo5uVGB6mEWTvDiOPqjWZfWLX+yhA00ciO+CWErJ94Cw9A2476MHEe6aFZKVBCDAyBCWgr/EEXc3
M4VbpRCecjbAQZ4D4YrIAuF+GrBXQyo7fqVwc67msZoOH0DRDpYsPzG16o6uhRE5fMgJDYoJoKSS
iaRYCmJAEsFegDY1JTY0XckR9uVSEGEYLMIt58Qpa1TNBJmrCD+1iCfQm5Bh9DwRa+aBu7LX5xps
/toP2U+v0+Oru/4HYlj9n7/TY64Z9uDlYXIf8/S87j5sEsZqCYbg5zeAp3fnniP62wDvbnqar9f9
uiy18c0U0W/v/fzjw/38tZuPoYKIRqF1exfVoPWz9qacKZ6AD2G37ImogRhqYdE6VJq2OtTD2SCZ
AjFHp3O1XyzxA+h+THXumPpwq9c21tJPBTUcOioLk3Q7ANcia7Ig5wk5j0+A61TVuRq00dBWTu0C
zFAd86ZbAzYEGKkOBJsdU52LdqLbly+Vws3K/kUba8/vaBjHf0usLVcfdy2oAAAAJXRFWHRkYXRl
OmNyZWF0ZQAyMDIxLTExLTExVDEyOjA5OjAwKzAwOjAwgbmcCQAAACV0RVh0ZGF0ZTptb2RpZnkA
MjAyMS0xMS0xMVQxMjowOTowMCswMDowMPDkJLUAAAAASUVORK5CYII=
X-Now-Playing: Hype Williams's _Junt-Deez Ruins You See_: "Infinity"
Date: Thu, 11 Nov 2021 13:15:03 +0100
In-Reply-To: <83wnlf166j.fsf@HIDDEN> (Eli Zaretskii's message of "Thu, 11 Nov
2021 09:51:16 +0200")
Message-ID: <87wnle6g8o.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
@@CONTACT_ADDRESS@@ for details.
Content preview: Eli Zaretskii <eliz@HIDDEN> writes: > I'm not sure
unification
is possible here, because the functionality > is quite different, AFAICT.
At least for the functionality in this > bug report, we cannot apply the
system theme to an existin [...]
Content analysis details: (-2.9 points, 5.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Eli Zaretskii <eliz@HIDDEN> writes:
> I'm not sure unification is possible here, because the functionality
> is quite different, AFAICT. At least for the functionality in this
> bug report, we cannot apply the system theme to an existing frame, we
> can only apply it at frame creation time. So having a handler for
> such changes will be able to affect only the frames created after the
> change. Or at least that is my understanding; the code definitely
> applies the dark/light theme as part of creating a frame.
Gtk Emacs doesn't respond to dark mode either -- so we have the
opportunity to decide how to handle these things across the board.
Perhaps in Gtk Emacs, dynamic-setting-handle-config-changed-event should
also just set something that will make the next frame creation use
different colours?
> Also, having a dynamic thing that tracks changes in these settings
> would on Windows mean listening and processing a special window-system
> message, which seems to be WM_THEMECHANGED or maybe WM_SETTINGCHANGE.
> But that's not what the code installed in this bug report does.
>
> So the functionality seems similar, but the details differ.
But perhaps Windows should be listening to those events, too?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
X-Loop: help-debbugs@HIDDEN
Subject: bug#47291: bug#51404: Support system dark mode on Windows 10
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 11 Nov 2021 15:09:01 +0000
Resent-Message-ID: <handler.47291.B47291.163664329426247 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 47291
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Lars Ingebrigtsen <larsi@HIDDEN>
Cc: salvino@HIDDEN, 51404 <at> debbugs.gnu.org, 47291 <at> debbugs.gnu.org
Received: via spool by 47291-submit <at> debbugs.gnu.org id=B47291.163664329426247
(code B ref 47291); Thu, 11 Nov 2021 15:09:01 +0000
Received: (at 47291) by debbugs.gnu.org; 11 Nov 2021 15:08:14 +0000
Received: from localhost ([127.0.0.1]:41935 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1mlBgU-0006pF-HI
for submit <at> debbugs.gnu.org; Thu, 11 Nov 2021 10:08:14 -0500
Received: from eggs.gnu.org ([209.51.188.92]:57488)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>)
id 1mlBgS-0006oy-W3; Thu, 11 Nov 2021 10:08:13 -0500
Received: from [2001:470:142:3::e] (port=56760 helo=fencepost.gnu.org)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1mlBgM-0007VH-Cp; Thu, 11 Nov 2021 10:08:07 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=Bi9DzzxszVB6DzQl2QhPBI+fVguYZSfHEM/WjOAL138=; b=VCj1P6sEiy5T
YSYbXFZZM33R9nuqF21XCZPsdGozP9+sp2qHoCZWIIdaHENb+gjoXWZ6ZKIAfVTy9Isxauleg2R5F
qmBsz+JmJnvV2CsG1fnMvwIiiGvl+pIjnoF8cLeWZbbKL3EtaztypoBBNnJ6TfD94tkbxljCoWZIJ
wE1poeRluPE1Zv40pC6GkD6hOEcZXn1FeONMCcDXa3j0DKNpkddWzROSxdrS/aq4d4H6HUAl0rdwE
1QbWyApMX1IVZ+Ej1EyDibuGStkZsikGEXL8vL12uCdFMNt+LNIeo8TRM0UnCMPN2k42rhV+4TSmd
FYAIqgGqJKqBd2yHQQQCJg==;
Received: from [87.69.77.57] (port=2143 helo=home-c4e4a596f7)
by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1mlBgL-00071O-RT; Thu, 11 Nov 2021 10:08:06 -0500
Date: Thu, 11 Nov 2021 17:08:04 +0200
Message-Id: <83ee7m20iz.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <87wnle6g8o.fsf@HIDDEN> (message from Lars Ingebrigtsen on Thu,
11 Nov 2021 13:15:03 +0100)
References: <CH2PR12MB4231758A937F6FB9F33291CFA5849@HIDDEN>
<834k93zxyo.fsf@HIDDEN>
<CH2PR12MB4231BD9B939F3D485536A5BAA5849@HIDDEN>
<838ryfyawv.fsf@HIDDEN>
<CH2PR12MB4231BF93A366641B94D7A636A5849@HIDDEN>
<CH2PR12MB423138F5C432C2BBF330BC6BA5859@HIDDEN>
<83r1c5tyar.fsf@HIDDEN> <83a6iqpzrv.fsf@HIDDEN>
<ddm9cg097co1e4d11e8bh6c6.1635613989653@HIDDEN>
<83k0huo1iy.fsf@HIDDEN> <87wnlf8d9y.fsf@HIDDEN>
<83wnlf166j.fsf@HIDDEN> <87wnle6g8o.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: Lars Ingebrigtsen <larsi@HIDDEN>
> Cc: salvino@HIDDEN, 51404 <at> debbugs.gnu.org, 47291 <at> debbugs.gnu.org
> Date: Thu, 11 Nov 2021 13:15:03 +0100
>
> Eli Zaretskii <eliz@HIDDEN> writes:
>
> > I'm not sure unification is possible here, because the functionality
> > is quite different, AFAICT. At least for the functionality in this
> > bug report, we cannot apply the system theme to an existing frame, we
> > can only apply it at frame creation time. So having a handler for
> > such changes will be able to affect only the frames created after the
> > change. Or at least that is my understanding; the code definitely
> > applies the dark/light theme as part of creating a frame.
>
> Gtk Emacs doesn't respond to dark mode either -- so we have the
> opportunity to decide how to handle these things across the board.
> Perhaps in Gtk Emacs, dynamic-setting-handle-config-changed-event should
> also just set something that will make the next frame creation use
> different colours?
If that's what people want, sure. I'd expect them to want Emacs to go
to dark background on all frames.
> > Also, having a dynamic thing that tracks changes in these settings
> > would on Windows mean listening and processing a special window-system
> > message, which seems to be WM_THEMECHANGED or maybe WM_SETTINGCHANGE.
> > But that's not what the code installed in this bug report does.
> >
> > So the functionality seems similar, but the details differ.
>
> But perhaps Windows should be listening to those events, too?
Maybe. But some expert (which is not me) will have to explain what to
do when we receive these messages, or submit patches for that.
X-Loop: help-debbugs@HIDDEN
Subject: bug#47291: bug#51404: Support system dark mode on Windows 10
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 12 Nov 2021 03:01:02 +0000
Resent-Message-ID: <handler.47291.B47291.163668604327172 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 47291
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Eli Zaretskii <eliz@HIDDEN>
Cc: salvino@HIDDEN, 51404 <at> debbugs.gnu.org, 47291 <at> debbugs.gnu.org
Received: via spool by 47291-submit <at> debbugs.gnu.org id=B47291.163668604327172
(code B ref 47291); Fri, 12 Nov 2021 03:01:02 +0000
Received: (at 47291) by debbugs.gnu.org; 12 Nov 2021 03:00:43 +0000
Received: from localhost ([127.0.0.1]:42744 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1mlMny-00074A-Bz
for submit <at> debbugs.gnu.org; Thu, 11 Nov 2021 22:00:42 -0500
Received: from quimby.gnus.org ([95.216.78.240]:60178)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <larsi@HIDDEN>)
id 1mlMnj-00073W-Oc; Thu, 11 Nov 2021 22:00:41 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=PTYBUmw8Z7FniTTzeJfyBphpDLoyRK73Gz5KKT0o0qk=; b=iw8PJPNc7aBLoGBdbBqw/QVtS1
AumCPALCjNtbQrCP7sXI+LWQfoLZ5xNH/tB6/Ot35TZ01NTV4eJYYYFodHh01QKhq4KGn13V/NsN7
9KCCWvMIpCQAoAbVqENWnG+C6I3Cb9Mr+2EV1a4/ctV12x9qm4iM4rSoJBNesVjUicHY=;
Received: from [84.212.220.105] (helo=xo)
by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.92) (envelope-from <larsi@HIDDEN>)
id 1mlMna-0003N7-Qx; Fri, 12 Nov 2021 04:00:21 +0100
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <CH2PR12MB4231758A937F6FB9F33291CFA5849@HIDDEN>
<834k93zxyo.fsf@HIDDEN>
<CH2PR12MB4231BD9B939F3D485536A5BAA5849@HIDDEN>
<838ryfyawv.fsf@HIDDEN>
<CH2PR12MB4231BF93A366641B94D7A636A5849@HIDDEN>
<CH2PR12MB423138F5C432C2BBF330BC6BA5859@HIDDEN>
<83r1c5tyar.fsf@HIDDEN> <83a6iqpzrv.fsf@HIDDEN>
<ddm9cg097co1e4d11e8bh6c6.1635613989653@HIDDEN>
<83k0huo1iy.fsf@HIDDEN> <87wnlf8d9y.fsf@HIDDEN>
<83wnlf166j.fsf@HIDDEN> <87wnle6g8o.fsf@HIDDEN>
<83ee7m20iz.fsf@HIDDEN>
Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj
SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEXf399/foAkJCb/
//8aMSjyAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+ULDAIxCQtexUAAAAGFSURBVCjPhZLNboJAFIUP
BIiykkRMOyvTaNLwFEOjXWMiprLqwiZ1noJ20TUuNCkr2ohh7lP2zmDTZWc13z2XOfcH4O+M4KzS
aOzH4zW8DL6XRojyKDOag+UCqQf4BQGrSEo4G6KcAxyMFR3z0uYVpNexqhu+k2YZ8zxeQyJzNhpI
sVpyPhKqK1z2Fy35E6JTh8vnyxMLLrWHOQ5EHZcTqBIusg86szJUC6eWMyQHhoHaK8IUQ+PptaKd
yGnfxFjevamSJFsCAkrrgCounz1vEv0aUGfuEIOwGrmkHiqGrX/LkaOyPrIQQGgrADb0KCEaZUHV
7yUmTULcCPank0bIQEb55gT3CgkdMziNsMAzyEeD54C4IhAbJJpteyCZkOm+tKCFhcpC5SvJ0PRp
CA2cLQDBmR/QV8XtemgL84xROtv6Hpgx7Mzy/C33H1Ar7bR2DL6qS2Eg4MX4okBid5chGwZLhBZ2
rKawSp7zapyvGWI7SLGAJ8cmKeZ53//+PixlI/xzfgA4zIj9xqxzCwAAACV0RVh0ZGF0ZTpjcmVh
dGUAMjAyMS0xMS0xMlQwMjo0OTowOSswMDowMBA//9wAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjEt
MTEtMTJUMDI6NDk6MDkrMDA6MDBhYkdgAAAAAElFTkSuQmCC
X-Now-Playing: Sonic Youth's _Goo_: "Dirty Boots"
Date: Fri, 12 Nov 2021 04:00:18 +0100
In-Reply-To: <83ee7m20iz.fsf@HIDDEN> (Eli Zaretskii's message of "Thu, 11 Nov
2021 17:08:04 +0200")
Message-ID: <87czn63wot.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
@@CONTACT_ADDRESS@@ for details.
Content preview: Eli Zaretskii <eliz@HIDDEN> writes: > If that's what people
want, sure. I'd expect them to want Emacs to go > to dark background on all
frames. Possibly -- there should probably be a user option, I guess.
Content analysis details: (-2.9 points, 5.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Eli Zaretskii <eliz@HIDDEN> writes:
> If that's what people want, sure. I'd expect them to want Emacs to go
> to dark background on all frames.
Possibly -- there should probably be a user option, I guess.
> Maybe. But some expert (which is not me) will have to explain what to
> do when we receive these messages, or submit patches for that.
On the Linux side, we convert the messages to input events and then
react to that event from special-event-map, which seems like a
reasonable structure.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
X-Loop: help-debbugs@HIDDEN
Subject: bug#47291: bug#51404: Support system dark mode on Windows 10
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 12 Nov 2021 06:20:01 +0000
Resent-Message-ID: <handler.47291.B47291.163669799316906 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 47291
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Lars Ingebrigtsen <larsi@HIDDEN>
Cc: salvino@HIDDEN, 51404 <at> debbugs.gnu.org, 47291 <at> debbugs.gnu.org
Received: via spool by 47291-submit <at> debbugs.gnu.org id=B47291.163669799316906
(code B ref 47291); Fri, 12 Nov 2021 06:20:01 +0000
Received: (at 47291) by debbugs.gnu.org; 12 Nov 2021 06:19:53 +0000
Received: from localhost ([127.0.0.1]:43109 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1mlPui-0004Oa-AI
for submit <at> debbugs.gnu.org; Fri, 12 Nov 2021 01:19:53 -0500
Received: from eggs.gnu.org ([209.51.188.92]:34572)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>)
id 1mlPue-0004O2-3L; Fri, 12 Nov 2021 01:19:51 -0500
Received: from [2001:470:142:3::e] (port=33576 helo=fencepost.gnu.org)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1mlPuY-0001om-OP; Fri, 12 Nov 2021 01:19:42 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=0PBZbzmonAKMntBtIFB81brghKlU32JAMBte4BR9rkE=; b=guusM14171Nu
uI0IOJMXg1Y7OhRCuYvP4ic6T+hHewiOrxvd2Q6OEaQCVc0/azPQF15el9JSF//1z/SOi+2LJ/J9P
B3YVDKNztHtfHCV1dHVFeop7m76cC+lf+f+hzrwiXwCNPNzLcpHhTGX9g/sJQ+mybWYCXDJW90mZM
e9MaR5r8J0sBESCbwJs6lPXh5dOLhUN6L7oPNxugpR+RxoeIi1CUtR/j3cJkiZf1wpPzXDTsgxuYQ
KIM0pmKRZsS6WhShv2SkkNY0OZGDmacFEwgfLWw4ngOJhdRvRWP82cJQu5Nsl8i3MspwFmq8KcnJb
75EG1/dnl5jJNhknGk8rbw==;
Received: from [87.69.77.57] (port=2465 helo=home-c4e4a596f7)
by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1mlPuY-0001Gn-BZ; Fri, 12 Nov 2021 01:19:42 -0500
Date: Fri, 12 Nov 2021 08:19:22 +0200
Message-Id: <83k0hdzyj9.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <87czn63wot.fsf@HIDDEN> (message from Lars Ingebrigtsen on Fri,
12 Nov 2021 04:00:18 +0100)
References: <CH2PR12MB4231758A937F6FB9F33291CFA5849@HIDDEN>
<834k93zxyo.fsf@HIDDEN>
<CH2PR12MB4231BD9B939F3D485536A5BAA5849@HIDDEN>
<838ryfyawv.fsf@HIDDEN>
<CH2PR12MB4231BF93A366641B94D7A636A5849@HIDDEN>
<CH2PR12MB423138F5C432C2BBF330BC6BA5859@HIDDEN>
<83r1c5tyar.fsf@HIDDEN> <83a6iqpzrv.fsf@HIDDEN>
<ddm9cg097co1e4d11e8bh6c6.1635613989653@HIDDEN>
<83k0huo1iy.fsf@HIDDEN> <87wnlf8d9y.fsf@HIDDEN>
<83wnlf166j.fsf@HIDDEN> <87wnle6g8o.fsf@HIDDEN>
<83ee7m20iz.fsf@HIDDEN> <87czn63wot.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: Lars Ingebrigtsen <larsi@HIDDEN>
> Cc: salvino@HIDDEN, 51404 <at> debbugs.gnu.org, 47291 <at> debbugs.gnu.org
> Date: Fri, 12 Nov 2021 04:00:18 +0100
>
> > Maybe. But some expert (which is not me) will have to explain what to
> > do when we receive these messages, or submit patches for that.
>
> On the Linux side, we convert the messages to input events and then
> react to that event from special-event-map, which seems like a
> reasonable structure.
I mean how to tell what the message wants us to do, i.e. which parts
of the UI to change and in what way.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.