GNU logs - #49674, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#49674: 28.0.50; Should unload-feature remove advices?
Resent-From: Michael Heerdegen <michael_heerdegen@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 21 Jul 2021 02:39:01 +0000
Resent-Message-ID: <handler.49674.B.162683512417935 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 49674 <at> debbugs.gnu.org
From: Michael Heerdegen <michael_heerdegen@HIDDEN>
Date: Wed, 21 Jul 2021 04:38:33 +0200
Message-ID: <871r7s75na.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=212.227.15.3;
 envelope-from=michael_heerdegen@HIDDEN; helo=mout.web.de
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -0.1 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

Hello,

While talking about the text about FEATURE-unload-hook in
(info "(elisp) Coding Conventions") (Bug#21440) the question was raised
whether `unload-feature' should try to automatically remove advices
(nadvice style) that belong to functions defined by the unloaded
feature.  Currently these are ignored.  I guess it would be a good
thing.  AFAICT old-style advices were (and are) handled.

And the docstring of `unload-feature' covers a lot of cases to care
about manually, but it doesn't mention advices.  Should it?

TIA,

Michael.

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Michael Heerdegen <michael_heerdegen@HIDDEN>
Subject: bug#49674: Acknowledgement (28.0.50; Should unload-feature remove
 advices?)
Message-ID: <handler.49674.B.162683512417935.ack <at> debbugs.gnu.org>
References: <871r7s75na.fsf@HIDDEN>
X-Gnu-PR-Message: ack 49674
X-Gnu-PR-Package: emacs
Reply-To: 49674 <at> debbugs.gnu.org
Date: Wed, 21 Jul 2021 02:39:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 49674 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
49674: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D49674
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#49674: 28.0.50; Should unload-feature remove advices?
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 21 Jul 2021 14:59:02 +0000
Resent-Message-ID: <handler.49674.B49674.162687948721438 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Michael Heerdegen <michael_heerdegen@HIDDEN>
Cc: Stefan Monnier <monnier@HIDDEN>, 49674 <at> debbugs.gnu.org
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <871r7s75na.fsf@HIDDEN>
Date: Wed, 21 Jul 2021 16:57:56 +0200
In-Reply-To: <871r7s75na.fsf@HIDDEN> (Michael Heerdegen's message of "Wed, 21
 Jul 2021 04:38:33 +0200")
Message-ID: <87o8avpvd7.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Michael Heerdegen <michael_heerdegen@HIDDEN> writes:

> While talking about the text about FEATURE-unload-hook in
> (info "(elisp) Coding Conventions") (Bug#21440) the question was raised
> whether `unload-feature' should try to automatically remove advices
> (nadvice style) that belong to functions defined by the unloaded
> feature.  Currently these are ignored.  I guess it would be a good
> thing.  AFAICT old-style advices were (and are) handled.

I think that sounds like a good idea, but perhaps Stefan has a comment
here (added to the CCs).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Last modified: Wed, 21 Jul 2021 15:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.