GNU bug report logs - #49674
28.0.50; Should unload-feature remove advices?

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: Michael Heerdegen <michael_heerdegen@HIDDEN>; dated Wed, 21 Jul 2021 02:39:01 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 49674 <at> debbugs.gnu.org:


Received: (at 49674) by debbugs.gnu.org; 21 Jul 2021 14:58:07 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jul 21 10:58:07 2021
Received: from localhost ([127.0.0.1]:38264 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1m6Dfj-0005Zi-HK
	for submit <at> debbugs.gnu.org; Wed, 21 Jul 2021 10:58:07 -0400
Received: from quimby.gnus.org ([95.216.78.240]:43690)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1m6Dfh-0005ZB-8Z
 for 49674 <at> debbugs.gnu.org; Wed, 21 Jul 2021 10:58:05 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
 s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
 References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
 Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
 Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
 List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=XIPwGfodkisEVyzaVJFEzFdcc8M9MINFUQFzOXB2Yw0=; b=KwzRVU1USvSQqwVZYokH8ovZNO
 r59WIuy823ZkewGmQST6UwQDe50hvm+4oV+bvzxV55G1JE4OUGzlDv1Epo0+Uz7b4O7WvU2TC3D/k
 pXAZjjj4YrpGLsI6/GKXQzfepxhSQ+OIu54Icocpqnnjh+meP8OXQyrwEFLQrepdebnQ=;
Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva)
 by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.92) (envelope-from <larsi@HIDDEN>)
 id 1m6DfZ-0007c2-0I; Wed, 21 Jul 2021 16:57:59 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: Michael Heerdegen <michael_heerdegen@HIDDEN>
Subject: Re: bug#49674: 28.0.50; Should unload-feature remove advices?
References: <871r7s75na.fsf@HIDDEN>
X-Now-Playing: Bob Hund's _KlassiskBOBHUNkonsert_: "Harduingetmankandansatill?"
Date: Wed, 21 Jul 2021 16:57:56 +0200
In-Reply-To: <871r7s75na.fsf@HIDDEN> (Michael Heerdegen's message of "Wed, 21
 Jul 2021 04:38:33 +0200")
Message-ID: <87o8avpvd7.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview: Michael Heerdegen <michael_heerdegen@HIDDEN> writes: > While
 talking about the text about FEATURE-unload-hook in > (info "(elisp) Coding
 Conventions") (Bug#21440) the question was raised > whether `unload-feature'
 should try to automatically remove advi [...] 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 49674
Cc: Stefan Monnier <monnier@HIDDEN>, 49674 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Michael Heerdegen <michael_heerdegen@HIDDEN> writes:

> While talking about the text about FEATURE-unload-hook in
> (info "(elisp) Coding Conventions") (Bug#21440) the question was raised
> whether `unload-feature' should try to automatically remove advices
> (nadvice style) that belong to functions defined by the unloaded
> feature.  Currently these are ignored.  I guess it would be a good
> thing.  AFAICT old-style advices were (and are) handled.

I think that sounds like a good idea, but perhaps Stefan has a comment
here (added to the CCs).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#49674; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 21 Jul 2021 02:38:44 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jul 20 22:38:44 2021
Received: from localhost ([127.0.0.1]:35852 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1m628C-0004fD-7K
	for submit <at> debbugs.gnu.org; Tue, 20 Jul 2021 22:38:44 -0400
Received: from lists.gnu.org ([209.51.188.17]:36566)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <michael_heerdegen@HIDDEN>) id 1m628A-0004f5-5v
 for submit <at> debbugs.gnu.org; Tue, 20 Jul 2021 22:38:42 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:46428)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <michael_heerdegen@HIDDEN>)
 id 1m6289-0005rD-UA
 for bug-gnu-emacs@HIDDEN; Tue, 20 Jul 2021 22:38:41 -0400
Received: from mout.web.de ([212.227.15.3]:34733)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <michael_heerdegen@HIDDEN>)
 id 1m6285-0004H6-AB
 for bug-gnu-emacs@HIDDEN; Tue, 20 Jul 2021 22:38:41 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de;
 s=dbaedf251592; t=1626835114;
 bh=CRhYSaRxTUHBMhbIVMWAQ5N6OaNb/3p38u5rRKyFd9w=;
 h=X-UI-Sender-Class:From:To:Subject:Date;
 b=R8B53R2mcAHhv+FNxwJFwnocfSZuTH8VRcr0tBu/h45Ve3IBXeb0Psgho8p68hMw8
 PVa2kCllGG9sFHqCGNXhNaTf56T3/S9OUAjFglL0mGo06e2K3yJuTAFBXkaa1ziOYd
 SD1K9sKTLtXYAC49nQadx5GJW+HhNCp679jL0njo=
X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9
Received: from drachen.dragon ([88.66.201.45]) by smtp.web.de (mrweb001
 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MWAtV-1ldGzr03Uf-00XIEp; Wed, 21
 Jul 2021 04:38:34 +0200
From: Michael Heerdegen <michael_heerdegen@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 28.0.50; Should unload-feature remove advices?
Date: Wed, 21 Jul 2021 04:38:33 +0200
Message-ID: <871r7s75na.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:+dIeeUy+gx65NB4Mnyf4qaK+Zh2gCcGFJem/wACXraDxuUEc6Yg
 nn1/j3uF7xkW0kFegfUnA3PoXZa3uBvgVCh075ucHLuepWJ4p0ScdwidMrEpFq6l8l0vdLU
 0GB+J1Rkqd6SgUMelcXG/EWA9zaVS9BilWQO3+9j/ht/urIq9gBssqZtmd6Fl13nQq/BV6X
 JIxpadhAeLvQsbJHcIF3Q==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:v/HWKqz0Fpo=:517yfwHOg/cfji2CK0Hi3P
 eDcWeYYuDEVALlsczX2X+4CEI3kJHxSyB4VL9bJRthA61D7tT12CQ1zdZcIbg7HMVWqoz/jtu
 aT6ejQUMdrCb+tJtqOAlk9VdjvAw8SlQuhHFvgGKhxpqqeKMObPnL4n+ezoXXiokCcqu4KaFh
 6V2KFqEBCNj5jc9IZXmEhMyW9qiSkapOA6ycVGAkOrkuCDK1uTIkkULIVmyO2AcFl102d6jlo
 rbwdV3OWsAe3b9KbEBBt6u8TPMJ6t18iA/AGvEtnJuGHm3qjJOza+GQxGw0sJ45DcdOsWjBcB
 7L7+KIWZzhb8q62mGf227mHUuzST21zGp+71ZarUwNy6Y7VmnSuLnnfe2OQ+9HeVz0jhaPlam
 YsWC7jMG02OG2NkIk7n3ZhfF9AOB6i7vrezBJkbqNvC9ZVmf5BhWdSxoOo3A0U0O0fQGU10Ka
 i0NPrG/KVuhTP48W5arVZedHn4OUOJc/DM4L/jfWmJ3DVrlKuVjR990gA0RYkJZ8G8j7Wy0hB
 PAe6KGtZeTwf2Rib6su3WHr2trhF7HeUxHLxTH0BtA8CrKnHvPSGNEa0VPm7iAyUkH7MLsrSy
 Vkf5erw2MNWMOzXJ5YH4xH+G0nLb/FS+TBiTjRlmkd2/3hdEqOJlj4hQN69lIXNCcuKkZ8Nhy
 r0O+F7nPXx1gopI1Gm/oa9v1+6U5hsHaxAzCf2TcHtTD7T0t1KebM8KdtZJ6A1M0S3S0JIpvw
 dKuCKuvtDVS9i0Z38tBklxgL/o9rZeVwpx3SedXVGoENt6X7YIf0LI12wgFM8plXmRxRQP7wF
 WJ1UTRdKfqG5GHQKkcvIjz5qo4ws48eKjpcPsFQLC6nWTiMci2I6O9cyaOcDp1aqV+wBO2G7I
 0huxBMCAalxxAPfIqrAoNeqBvykEeQFezGp0oXLXE5uTzE/WkbmvPaNhJawSJ7utJVSlsN7o/
 Q318NIRRFFE/nOD3s97kxFrLac81ba7A+eiMP3y6eCdE2Nx7fNNyE+la5NcoK5dIV2CF/2tIP
 L5O8WXrS4n2EHciX/FhHB07fbyF5aooShqjc7CAhmC+xZF8kKDLLYX1XNthrvvJERrjAvY8JL
 UgGvVCNWOj7XZUG3kc1rMq2sPRpLt8XkN9/qbDCS695azKwfC61dzsd2g==
Received-SPF: pass client-ip=212.227.15.3;
 envelope-from=michael_heerdegen@HIDDEN; helo=mout.web.de
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -0.1 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)


Hello,

While talking about the text about FEATURE-unload-hook in
(info "(elisp) Coding Conventions") (Bug#21440) the question was raised
whether `unload-feature' should try to automatically remove advices
(nadvice style) that belong to functions defined by the unloaded
feature.  Currently these are ignored.  I guess it would be a good
thing.  AFAICT old-style advices were (and are) handled.

And the docstring of `unload-feature' covers a lot of cases to care
about manually, but it doesn't mention advices.  Should it?


TIA,

Michael.




Acknowledgement sent to Michael Heerdegen <michael_heerdegen@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#49674; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Wed, 21 Jul 2021 15:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.