GNU logs - #54599, boring messages

Message sent to guix-patches@HIDDEN:

Subject: [bug#54599] [PATCH] gnu: libdaemon: fix build for riscv64
Resent-From: fesoj000 <fesoj000@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 27 Mar 2022 19:25:02 +0000
Resent-Message-ID: <handler.54599.B.16484090674305 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 54599 <at> debbugs.gnu.org
Message-ID: <b19763fb-6671-4410-77c8-aa6989a55805@HIDDEN>
Date: Sun, 27 Mar 2022 21:24:20 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
From: fesoj000 <fesoj000@HIDDEN>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Received-SPF: pass client-ip=2a00:1450:4864:20::62e;
 envelope-from=fesoj000@HIDDEN; helo=mail-ej1-x62e.google.com
X-Spam_score_int: -3
X-Spam_score: -0.4
X-Spam_bar: /
X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659,
 RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.1 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.1 (--)

* gnu/packages/libdaemon.scm: (native-inputs): Add check for riscv64 to
include config
* gnu/packages/libdaemon.scm: (arguments): Add check for riscv64 to add
update-config.sub build step
---
  gnu/packages/libdaemon.scm | 6 ++++--
  1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/libdaemon.scm b/gnu/packages/libdaemon.scm
index 9dc851e823..e91b651e5a 100644
--- a/gnu/packages/libdaemon.scm
+++ b/gnu/packages/libdaemon.scm
@@ -49,7 +49,8 @@ (define-public libdaemon
               (file-name (string-append name "-" version ".tar.gz"))))
      (build-system gnu-build-system)
      (native-inputs
-     (if (and=> (%current-target-system) target-aarch64?)
+     (if (or (target-aarch64?)
+             (target-riscv64?))
           `(("config" ,config)) ; for config.sub
           '()))
      (arguments
@@ -66,7 +67,8 @@ (define-public libdaemon
                                         ;; Hurd's console client.
                                         "--localstatedir=/var"))
               '())
-       ,@(if (and=> (%current-target-system) target-aarch64?)
+       ,@(if (or (target-aarch64?)
+                 (target-riscv64?))
               `(#:phases
                 (modify-phases %standard-phases
                   (add-before 'configure 'update-config.sub
-- 
2.34.0

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: fesoj000 <fesoj000@HIDDEN>
Subject: bug#54599: Acknowledgement ([PATCH] gnu: libdaemon: fix build for
 riscv64)
Message-ID: <handler.54599.B.16484090674305.ack <at> debbugs.gnu.org>
References: <b19763fb-6671-4410-77c8-aa6989a55805@HIDDEN>
X-Gnu-PR-Message: ack 54599
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 54599 <at> debbugs.gnu.org
Date: Sun, 27 Mar 2022 19:25:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 54599 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
54599: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D54599
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#54599] [PATCH] gnu: libdaemon: fix build for riscv64
Resent-From: fesoj000 <fesoj000@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Mon, 28 Mar 2022 19:36:02 +0000
Resent-Message-ID: <handler.54599.B54599.164849611711054 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 54599 <at> debbugs.gnu.org
Message-ID: <0d4128d2-da62-2d04-768d-0fe2c5801bf4@HIDDEN>
Date: Mon, 28 Mar 2022 21:35:08 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-US
References: <b19763fb-6671-4410-77c8-aa6989a55805@HIDDEN>
 <handler.54599.B.16484090674305.ack <at> debbugs.gnu.org>
From: fesoj000 <fesoj000@HIDDEN>
In-Reply-To: <handler.54599.B.16484090674305.ack <at> debbugs.gnu.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Actually, this fixex cross compiling using --target=riscv64-linux-gnu,
on real hardware it works without the patch.

Message sent to guix-patches@HIDDEN:

Subject: [bug#54599] [PATCH] gnu: libdaemon: fix build for riscv64
Resent-From: Thiago Jung Bauermann <bauermann@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 29 Mar 2022 01:41:02 +0000
Resent-Message-ID: <handler.54599.B54599.164851802213574 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: fesoj000 <fesoj000@HIDDEN>
Cc: 54599 <at> debbugs.gnu.org
References: <b19763fb-6671-4410-77c8-aa6989a55805@HIDDEN>
From: Thiago Jung Bauermann <bauermann@HIDDEN>
Date: Mon, 28 Mar 2022 22:25:20 -0300
In-reply-to: <b19763fb-6671-4410-77c8-aa6989a55805@HIDDEN>
Message-ID: <87sfr14juy.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hello,

Thanks for this patch! Just a few comments:

fesoj000 <fesoj000@HIDDEN> writes:

> * gnu/packages/libdaemon.scm: (native-inputs): Add check for riscv64 to
> include config
> * gnu/packages/libdaemon.scm: (arguments): Add check for riscv64 to add
> update-config.sub build step

In the changelog, the name of the package goes in the parentheses, and
the package attribute being changed in square brackets. For example:

* gnu/packages/libdaemon.scm (libdaemon)[native-inputs]: Add check for
riscv64 to include config.

Also the sentences should have a period at the end.

> ---
>  gnu/packages/libdaemon.scm | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/libdaemon.scm b/gnu/packages/libdaemon.scm
> index 9dc851e823..e91b651e5a 100644
> --- a/gnu/packages/libdaemon.scm
> +++ b/gnu/packages/libdaemon.scm
> @@ -49,7 +49,8 @@ (define-public libdaemon
>               (file-name (string-append name "-" version ".tar.gz"))))
>      (build-system gnu-build-system)
>      (native-inputs
> -     (if (and=3D> (%current-target-system) target-aarch64?)
> +     (if (or (target-aarch64?)
> +             (target-riscv64?))
>           `(("config" ,config)) ; for config.sub
>           '()))
>      (arguments
> @@ -66,7 +67,8 @@ (define-public libdaemon
>                                         ;; Hurd's console client.
>                                         "--localstatedir=3D/var"))
>               '())
> -       ,@(if (and=3D> (%current-target-system) target-aarch64?)
> +       ,@(if (or (target-aarch64?)
> +                 (target-riscv64?))
>               `(#:phases
>                 (modify-phases %standard-phases
>                   (add-before 'configure 'update-config.sub

Before the patch, =E2=80=98native-inputs=E2=80=99 and =E2=80=98arguments=E2=
=80=99 were only changed when
cross-compiling on aarch64. After your patch, they are changed even for
native builds.

Functionally, it's not a problem but this changes the package's
derivation. Since the package has many dependents, it causes a lot of
other packages to be rebuilt:

popigai: guix refresh --list-dependent libdaemon=20
Building the following 1496 packages would ensure 3175 dependent packages a=
re rebuilt: =E2=80=A6

Because of this, the patch can't be applied on the master branch. It
would have to go to core-updates.

So for the master branch, you need to keep the property of only making
changes to =E2=80=98native-inputs=E2=80=99 and =E2=80=98arguments=E2=80=99 =
when cross-compiling.

But I also suggest sending an additional patch for the core-updates
branch which unconditionally updates config.sub, regardless of the
architecture and regardless of whether it's a native compilation or a
cross one. This way, the next time Guix is ported to a new architecture
we won't need to update this package again.

--=20
Thanks
Thiago

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 4 Apr 2022 20:45:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 04 16:45:48 2022
Received: from localhost ([127.0.0.1]:53183 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nbTa8-0000dU-1J
	for submit <at> debbugs.gnu.org; Mon, 04 Apr 2022 16:45:48 -0400
Received: from eggs.gnu.org ([209.51.188.92]:57312)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1nbTa6-0000dB-O4
 for control <at> debbugs.gnu.org; Mon, 04 Apr 2022 16:45:47 -0400
Received: from [2001:470:142:3::e] (port=42410 helo=fencepost.gnu.org)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1nbTa1-0005Qg-44
 for control <at> debbugs.gnu.org; Mon, 04 Apr 2022 16:45:41 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:Subject:From:To:Date:in-reply-to:
 references; bh=Q3Rur425uTRmmkUbL7CwNVTlzhzRkCL0tn9CfI8uG4c=; b=oqAV5boR/OVJY8
 I201btyNFcVJNKogTTNbDuXRLaf3CYo0w0ikS8lJ8CbYAhRPcuSsxMarenHozk6owWx6E7/6khwL/
 N6Ncl2YxMf615reSWLWe+xR80QLEETQEZNGYwYCA8gfjkAHljTHqKYVpp9FuepSDxKZb5DEnr03OJ
 5vt3SmI0wY6VPq+kHhSPA/zWAKbnN2AwTQlkY+oX33dHRRp1wI2/MnCx3SINqstY+QarVpnuBpOaD
 XEorh+Mw7iGkPsP5e3qo1DycDzrLetlkNA3THGIPos2XzXAamJ3j7r8kY9btydTfLfRXJCAKHpskq
 5+eV2eCbYd43Ji8+sBeg==;
Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:56501
 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1nbTa0-0006og-5N
 for control <at> debbugs.gnu.org; Mon, 04 Apr 2022 16:45:40 -0400
Date: Mon, 04 Apr 2022 22:45:38 +0200
Message-Id: <87a6d0shl9.fsf@HIDDEN>
To: control <at> debbugs.gnu.org
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
Subject: control message for bug #54599
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

tags 54599 + moreinfo
quit

Last modified: Mon, 4 Apr 2022 21:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.