GNU bug report logs - #54599
[PATCH] gnu: libdaemon: fix build for riscv64

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: fesoj000 <fesoj000@HIDDEN>; Keywords: patch moreinfo; dated Sun, 27 Mar 2022 19:25:02 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.
Added tag(s) moreinfo. Request was from Ludovic Courtès <ludo@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 54599 <at> debbugs.gnu.org:


Received: (at 54599) by debbugs.gnu.org; 29 Mar 2022 01:40:22 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Mar 28 21:40:22 2022
Received: from localhost ([127.0.0.1]:59479 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nZ0qL-0003Ws-Qo
	for submit <at> debbugs.gnu.org; Mon, 28 Mar 2022 21:40:22 -0400
Received: from mx.kolabnow.com ([212.103.80.154]:43342)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <bauermann@HIDDEN>) id 1nZ0qJ-0003WZ-DT
 for 54599 <at> debbugs.gnu.org; Mon, 28 Mar 2022 21:40:20 -0400
Received: from localhost (unknown [127.0.0.1])
 by mx.kolabnow.com (Postfix) with ESMTP id E3A98D76;
 Tue, 29 Mar 2022 03:40:12 +0200 (CEST)
Authentication-Results: ext-mx-out001.mykolab.com (amavisd-new);
 dkim=pass (4096-bit key) reason="pass (just generated, assumed good)"
 header.d=kolabnow.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h=
 content-transfer-encoding:content-type:content-type:mime-version
 :message-id:in-reply-to:date:date:subject:subject:from:from
 :references:received:received:received; s=dkim20160331; t=
 1648518012; x=1650332413; bh=lwATQMwUGiLw6cbLCh6g4mq7xtPRKbRkYBO
 UEXZuCrw=; b=5gmUM0HWO0e0oX55CsV5mYOz8ux6rDGlq1dS8b7FEa2VNC4jRK0
 rWggC58dFZuz1jfSIFPHG53r8S1S6TvCyRRVEvLQ1ewlzodFxeGLrDeG7HETtoR6
 pS3n6ywkguPBCTBHbtQ3TgHm8ls7jyqzPzzMRDqIggUp7VM1VRpaH1g17gFC18gE
 r/X0YkNK0vauqeawDxr93gcIKQKVuQ9vUAqvKfLEfUOGZ9EtMuqt1aWno2wW2MLT
 JhV5X80OLXcJdLKUwlEAazSMrhzwPgptuirxhLaURHzlQZoVmHqfZAv4XvHHs/MI
 QEsPZujc2AORVWIGXv0B08EQMbGW51sJ3EP82Gau5oxegb4UJU4INPRjAup/7Qqy
 Ob4OJfCtJztAktjtkV+CKgVvTIbM6zuC+CSqlDQyDx2efnm9GBs+C2Z8nGB72+kK
 pPNnCfy9MxA8kp7SGEwwHBmBs95IEMv84iAo8b/JOUMCqJoRM+vQRHW4/VzVH26u
 XIPQW3HvwkwPsmfLNMQx4DFWAwhZF5EDjUEA/x9tEZxQhPvUBcYtcDtwTKYJ/XSi
 N0IZJVVDE6MjZuXDnQ4lXYAtGJKMkinbN+ut29agtYWLmLhoqA9fNxkMkDPUsTCa
 N6dkyrJaP4e6kT/MDU+dOfeB/TgYF9HtGRlZERRG2nJAxRUj0LXd1IAI=
X-Virus-Scanned: amavisd-new at mykolab.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 tagged_above=-10 required=5
 tests=[BAYES_00=-1.9] autolearn=ham autolearn_force=no
Received: from mx.kolabnow.com ([127.0.0.1])
 by localhost (ext-mx-out001.mykolab.com [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id oblufi1HtPkM; Tue, 29 Mar 2022 03:40:12 +0200 (CEST)
Received: from int-mx001.mykolab.com (unknown [10.9.13.1])
 by mx.kolabnow.com (Postfix) with ESMTPS id B5732B9A;
 Tue, 29 Mar 2022 03:40:11 +0200 (CEST)
Received: from ext-subm001.mykolab.com (unknown [10.9.6.1])
 by int-mx001.mykolab.com (Postfix) with ESMTPS id 840CD2346;
 Tue, 29 Mar 2022 03:40:11 +0200 (CEST)
References: <b19763fb-6671-4410-77c8-aa6989a55805@HIDDEN>
From: Thiago Jung Bauermann <bauermann@HIDDEN>
To: fesoj000 <fesoj000@HIDDEN>
Subject: Re: [bug#54599] [PATCH] gnu: libdaemon: fix build for riscv64
Date: Mon, 28 Mar 2022 22:25:20 -0300
In-reply-to: <b19763fb-6671-4410-77c8-aa6989a55805@HIDDEN>
Message-ID: <87sfr14juy.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 54599
Cc: 54599 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


Hello,

Thanks for this patch! Just a few comments:

fesoj000 <fesoj000@HIDDEN> writes:

> * gnu/packages/libdaemon.scm: (native-inputs): Add check for riscv64 to
> include config
> * gnu/packages/libdaemon.scm: (arguments): Add check for riscv64 to add
> update-config.sub build step

In the changelog, the name of the package goes in the parentheses, and
the package attribute being changed in square brackets. For example:

* gnu/packages/libdaemon.scm (libdaemon)[native-inputs]: Add check for
riscv64 to include config.

Also the sentences should have a period at the end.

> ---
>  gnu/packages/libdaemon.scm | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/libdaemon.scm b/gnu/packages/libdaemon.scm
> index 9dc851e823..e91b651e5a 100644
> --- a/gnu/packages/libdaemon.scm
> +++ b/gnu/packages/libdaemon.scm
> @@ -49,7 +49,8 @@ (define-public libdaemon
>               (file-name (string-append name "-" version ".tar.gz"))))
>      (build-system gnu-build-system)
>      (native-inputs
> -     (if (and=3D> (%current-target-system) target-aarch64?)
> +     (if (or (target-aarch64?)
> +             (target-riscv64?))
>           `(("config" ,config)) ; for config.sub
>           '()))
>      (arguments
> @@ -66,7 +67,8 @@ (define-public libdaemon
>                                         ;; Hurd's console client.
>                                         "--localstatedir=3D/var"))
>               '())
> -       ,@(if (and=3D> (%current-target-system) target-aarch64?)
> +       ,@(if (or (target-aarch64?)
> +                 (target-riscv64?))
>               `(#:phases
>                 (modify-phases %standard-phases
>                   (add-before 'configure 'update-config.sub

Before the patch, =E2=80=98native-inputs=E2=80=99 and =E2=80=98arguments=E2=
=80=99 were only changed when
cross-compiling on aarch64. After your patch, they are changed even for
native builds.

Functionally, it's not a problem but this changes the package's
derivation. Since the package has many dependents, it causes a lot of
other packages to be rebuilt:

popigai: guix refresh --list-dependent libdaemon=20
Building the following 1496 packages would ensure 3175 dependent packages a=
re rebuilt: =E2=80=A6

Because of this, the patch can't be applied on the master branch. It
would have to go to core-updates.

So for the master branch, you need to keep the property of only making
changes to =E2=80=98native-inputs=E2=80=99 and =E2=80=98arguments=E2=80=99 =
when cross-compiling.

But I also suggest sending an additional patch for the core-updates
branch which unconditionally updates config.sub, regardless of the
architecture and regardless of whether it's a native compilation or a
cross one. This way, the next time Guix is ported to a new architecture
we won't need to update this package again.

--=20
Thanks
Thiago




Information forwarded to guix-patches@HIDDEN:
bug#54599; Package guix-patches. Full text available.

Message received at 54599 <at> debbugs.gnu.org:


Received: (at 54599) by debbugs.gnu.org; 28 Mar 2022 19:35:17 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Mar 28 15:35:17 2022
Received: from localhost ([127.0.0.1]:59234 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nYv93-0002sD-94
	for submit <at> debbugs.gnu.org; Mon, 28 Mar 2022 15:35:17 -0400
Received: from mail-ej1-f52.google.com ([209.85.218.52]:34448)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <fesoj000@HIDDEN>) id 1nYv91-0002rr-IC
 for 54599 <at> debbugs.gnu.org; Mon, 28 Mar 2022 15:35:15 -0400
Received: by mail-ej1-f52.google.com with SMTP id o10so30837097ejd.1
 for <54599 <at> debbugs.gnu.org>; Mon, 28 Mar 2022 12:35:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=message-id:date:mime-version:user-agent:subject:content-language:to
 :references:from:in-reply-to:content-transfer-encoding;
 bh=F7QnS6HEodm7J+INEP0ptx+wjIghB5L33pI6eU4kKRo=;
 b=Hc56B9+/0TAVMqBbSQBX9qsY9GIDP8r50f0SrLCvVyXdepspAFk4ZRT3W8qOD7J/dw
 ijB6YLiXW6FAzdNMd0Jw2yIFV+i18Qy8lC25a6bvWe/hamXf9Q6cF94L2IzCdj/efGOJ
 jX9nWi+BirCjR4RDwt5Niu91pvhJy3U0JtJzCvKou0I3R8lN2rCUrUggkL5pLHQcKBKF
 A6pzKuasQANYVKMtZEehWlfmpnigbXT7h1Szb9bG9KrS4uNiFvP1uSSoQf6IUGYpk18p
 OgxFXXZJO928KX8WvlzloH4ntPJIkVjeuxX1WjD5LcAQpOByZafmxJjj6fGoCvsx+TSA
 rR5g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
 :content-language:to:references:from:in-reply-to
 :content-transfer-encoding;
 bh=F7QnS6HEodm7J+INEP0ptx+wjIghB5L33pI6eU4kKRo=;
 b=x4ud0sias7sIv4ISCc2EnrKktGIyYH+gYEBreMYvuydfbvcL9AmkICDNpevaoFIKMB
 6beJkAPRM45HIwRrtMQtQ6PJylYBvnPiJ9a4+oj3z97TcT3CqFmVoRp55UOiW327e/9U
 T+4yETmmzZecN0bPkLbViduHN/ZiJXhEAPqtfKQuIlJWXJwy/UWbA2ahMGLCX+EkSQve
 qc7//flXfio0SWnEuX3kM6QSvFNJmU+p9UkabLcU2ncj6LfdybX75AUjFBYSSpj+1Fjz
 oxd3cOfJEzsgTWmrBEbcgW+RNSfYZUCXI2DbaBSdP3UKCfk/Mh4y94mm68wpfh3aaWZW
 6qxA==
X-Gm-Message-State: AOAM533gJHNxYM7g0/aJpIlsQyCV8eV8kiMPOR1ucfC1qHQTx0bX7Br5
 EIfePHLaXzMjuoAuQnLiwuikacG2Rz8=
X-Google-Smtp-Source: ABdhPJxEXFDUU2NqLLUm5Ptf1L+Ig9grQe/kUzK8K8UmECHHFhzoi5SeV8WGE2wamnNracobFdHEHg==
X-Received: by 2002:a17:907:6297:b0:6da:6388:dc58 with SMTP id
 nd23-20020a170907629700b006da6388dc58mr30683594ejc.472.1648496109508; 
 Mon, 28 Mar 2022 12:35:09 -0700 (PDT)
Received: from ?IPV6:2003:ee:af13:4e00:138c:330:2a14:b8fb?
 (p200300eeaf134e00138c03302a14b8fb.dip0.t-ipconnect.de.
 [2003:ee:af13:4e00:138c:330:2a14:b8fb])
 by smtp.gmail.com with ESMTPSA id
 bw26-20020a170906c1da00b006c8aeca8febsm6217251ejb.47.2022.03.28.12.35.08
 for <54599 <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 28 Mar 2022 12:35:09 -0700 (PDT)
Message-ID: <0d4128d2-da62-2d04-768d-0fe2c5801bf4@HIDDEN>
Date: Mon, 28 Mar 2022 21:35:08 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: [PATCH] gnu: libdaemon: fix build for riscv64
Content-Language: en-US
To: 54599 <at> debbugs.gnu.org
References: <b19763fb-6671-4410-77c8-aa6989a55805@HIDDEN>
 <handler.54599.B.16484090674305.ack <at> debbugs.gnu.org>
From: fesoj000 <fesoj000@HIDDEN>
In-Reply-To: <handler.54599.B.16484090674305.ack <at> debbugs.gnu.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.2 (/)
X-Debbugs-Envelope-To: 54599
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.8 (/)

Actually, this fixex cross compiling using --target=riscv64-linux-gnu,
on real hardware it works without the patch.




Information forwarded to guix-patches@HIDDEN:
bug#54599; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 27 Mar 2022 19:24:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Mar 27 15:24:27 2022
Received: from localhost ([127.0.0.1]:56571 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nYYV1-00017M-A7
	for submit <at> debbugs.gnu.org; Sun, 27 Mar 2022 15:24:27 -0400
Received: from lists.gnu.org ([209.51.188.17]:37038)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <fesoj000@HIDDEN>) id 1nYYUy-00017D-Fy
 for submit <at> debbugs.gnu.org; Sun, 27 Mar 2022 15:24:26 -0400
Received: from eggs.gnu.org ([209.51.188.92]:58124)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <fesoj000@HIDDEN>)
 id 1nYYUy-0003ul-8U
 for guix-patches@HIDDEN; Sun, 27 Mar 2022 15:24:24 -0400
Received: from [2a00:1450:4864:20::62e] (port=35564
 helo=mail-ej1-x62e.google.com)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <fesoj000@HIDDEN>)
 id 1nYYUw-0002fa-R3
 for guix-patches@HIDDEN; Sun, 27 Mar 2022 15:24:23 -0400
Received: by mail-ej1-x62e.google.com with SMTP id yy13so24633772ejb.2
 for <guix-patches@HIDDEN>; Sun, 27 Mar 2022 12:24:22 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=message-id:date:mime-version:user-agent:from:subject
 :content-language:to:content-transfer-encoding;
 bh=ZM8v+x2vjlbGTA6EL37ta7QtVu07r7sBH4LUdudcLz8=;
 b=BtZOHpZqP+3u8Q9W0MA5yR5TP07hgFeFv3tn3AfjSptcy/6OO2RJu6urXrMfs1lSHb
 VR5hwOjWxAmDDqEdbclIU4MWtYfL5699Fe/ci6vfdGZwktx2oNbMkTT0VzzCZNkVE4U0
 3Q5ygJcwkmOSufIIFRDt4rbMSUX4EpnJHbM+tW2JS96qLfq0CHMkp9FTaAa8H9T1k9Nx
 fxHxvxx2X7FSPBdivRtyIhwNogXMw7AIpmQziPb5uzZzDTEsBMZHy58e4AyWdUPy+0aM
 FEITXgtbaUuhH5wZv2jzAhcgBR6TJSrOnqPSjw+KgWC3lwKZcE4nyAOAuUUpl8l8X+kM
 QrCA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:message-id:date:mime-version:user-agent:from
 :subject:content-language:to:content-transfer-encoding;
 bh=ZM8v+x2vjlbGTA6EL37ta7QtVu07r7sBH4LUdudcLz8=;
 b=B4/xbDQKnLcMEhinKXzQZtbFW+Sy3FOAWrhoK2qzQ4liXUCXbhw0IFWab1MhXU7Chb
 5RCXpVnyk/N5zEg7WyQXBKtAkc33uASVQi3ezp00BdS+o/ut6A9j8CpDpj9UdiSgaQOl
 3DjFs7sBWEjFI+XblLevALdSh0EOEWGoeCa6KVtVSU8f7G8T7eH4htkWJi4y7xeDtmum
 Oq9b38dgxtIkChTAjgetGu9ZIQHJi60TNdeaha39kQbrmqS83nSDLzlDdeA5Ev9i+6Oq
 39MQcfGCrM5jwU6OuNEnmBX7vQNV+3txIYW7QCvkKzf9SFA8q6KTnVtToR8srx8gVgVb
 ZCcQ==
X-Gm-Message-State: AOAM531kq8DeiXDvk6rtzcFMS8oKSYKYQsz/i+BG30k1ev9cWEQ5sPAG
 uPH2ANbOsK+Lv2d1l704/vmem1lTWjg=
X-Google-Smtp-Source: ABdhPJwz85uwsoERcI2aUMDOdNC3BD3g4Ah7ZQRkqeHUKo1eZB3aLIZJwezVEHAk+lCrWWZ/p3Zkog==
X-Received: by 2002:a17:907:9617:b0:6df:d17b:f869 with SMTP id
 gb23-20020a170907961700b006dfd17bf869mr23589906ejc.569.1648409060689; 
 Sun, 27 Mar 2022 12:24:20 -0700 (PDT)
Received: from ?IPV6:2003:ee:af13:4e00:138c:330:2a14:b8fb?
 (p200300eeaf134e00138c03302a14b8fb.dip0.t-ipconnect.de.
 [2003:ee:af13:4e00:138c:330:2a14:b8fb])
 by smtp.gmail.com with ESMTPSA id
 y26-20020a1709063a9a00b006e0c272e263sm2498407ejd.71.2022.03.27.12.24.19
 for <guix-patches@HIDDEN>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 27 Mar 2022 12:24:20 -0700 (PDT)
Message-ID: <b19763fb-6671-4410-77c8-aa6989a55805@HIDDEN>
Date: Sun, 27 Mar 2022 21:24:20 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
From: fesoj000 <fesoj000@HIDDEN>
Subject: [PATCH] gnu: libdaemon: fix build for riscv64
Content-Language: en-US
To: guix-patches@HIDDEN
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::62e
 (failed)
Received-SPF: pass client-ip=2a00:1450:4864:20::62e;
 envelope-from=fesoj000@HIDDEN; helo=mail-ej1-x62e.google.com
X-Spam_score_int: -3
X-Spam_score: -0.4
X-Spam_bar: /
X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659,
 RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.1 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.1 (--)

* gnu/packages/libdaemon.scm: (native-inputs): Add check for riscv64 to
include config
* gnu/packages/libdaemon.scm: (arguments): Add check for riscv64 to add
update-config.sub build step
---
  gnu/packages/libdaemon.scm | 6 ++++--
  1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/libdaemon.scm b/gnu/packages/libdaemon.scm
index 9dc851e823..e91b651e5a 100644
--- a/gnu/packages/libdaemon.scm
+++ b/gnu/packages/libdaemon.scm
@@ -49,7 +49,8 @@ (define-public libdaemon
               (file-name (string-append name "-" version ".tar.gz"))))
      (build-system gnu-build-system)
      (native-inputs
-     (if (and=> (%current-target-system) target-aarch64?)
+     (if (or (target-aarch64?)
+             (target-riscv64?))
           `(("config" ,config)) ; for config.sub
           '()))
      (arguments
@@ -66,7 +67,8 @@ (define-public libdaemon
                                         ;; Hurd's console client.
                                         "--localstatedir=/var"))
               '())
-       ,@(if (and=> (%current-target-system) target-aarch64?)
+       ,@(if (or (target-aarch64?)
+                 (target-riscv64?))
               `(#:phases
                 (modify-phases %standard-phases
                   (add-before 'configure 'update-config.sub
-- 
2.34.0





Acknowledgement sent to fesoj000 <fesoj000@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#54599; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Mon, 4 Apr 2022 21:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.