GNU logs - #55896, boring messages

Message sent to guix-patches@HIDDEN:

Subject: [bug#55896] [PATCH] gnu: Add python-pybare.
Resent-From: jgart <jgart@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 11 Jun 2022 04:29:02 +0000
Resent-Message-ID: <handler.55896.B.165492172922494 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 55896 <at> debbugs.gnu.org
Cc: jgart <jgart@HIDDEN>
From: jgart <jgart@HIDDEN>
Date: Fri, 10 Jun 2022 23:27:37 -0500
Message-Id: <20220611042737.15082-1-jgart@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=78.46.223.134; envelope-from=jgart@HIDDEN;
 helo=mx1.dismail.de
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

* gnu/packages/python-xyz.scm (python-pybare): New variable.
---
 gnu/packages/python-xyz.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 4104472848..ceedacd714 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -29418,6 +29418,38 @@ (define-public python-gatt
 Currently, Linux is the only platform supported by this library.")
     (license license:expat)))

+(define-public python-pybare
+  (package
+    (name "python-pybare")
+    (version "0.1.1")
+    (source
+      (origin
+        (method git-fetch)
+        (uri
+         (git-reference
+          (url "https://git.sr.ht/~chiefnoah/pybare")
+          (commit (string-append "v" version))))
+        (file-name (git-file-name name version))
+        (sha256
+         (base32 "1ibmwwf1rdxlwyxlzhv3v1i0ybsqg0kppim90sm8rsbns86yy4by"))))
+    (build-system python-build-system)
+    (native-inputs
+      (list python-pytest))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (replace 'check
+           (lambda _
+             (chdir "bare")
+             (invoke "pytest" "."))))))
+    (home-page "https://sr.ht/~chiefnoah/PyBARE/")
+    (synopsis "Declarative implementation of BARE for Python")
+    (description
+"@code{python-pybare} is a general purpose library for strongly
+typed primitives in Python that supports serializing to and from BARE
+messages.")
+    (license license:expat)))
+
 (define-public python-musical-scales
   (package
     (name "python-musical-scales")
-- 
2.36.1

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: jgart <jgart@HIDDEN>
Subject: bug#55896: Acknowledgement ([PATCH] gnu: Add python-pybare.)
Message-ID: <handler.55896.B.165492172922494.ack <at> debbugs.gnu.org>
References: <20220611042737.15082-1-jgart@HIDDEN>
X-Gnu-PR-Message: ack 55896
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 55896 <at> debbugs.gnu.org
Date: Sat, 11 Jun 2022 04:29:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 55896 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
55896: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D55896
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#55896] [PATCH] gnu: Add python-pybare.
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 11 Jun 2022 08:22:01 +0000
Resent-Message-ID: <handler.55896.B55896.165493570315141 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: jgart <jgart@HIDDEN>, 55896 <at> debbugs.gnu.org
Message-ID: <31595048a784bc8cefeb42951c790cf8a654cd05.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Sat, 11 Jun 2022 10:21:36 +0200
In-Reply-To: <20220611042737.15082-1-jgart@HIDDEN>
References: <20220611042737.15082-1-jgart@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
 protocol="application/pgp-signature"; boundary="=-zK4aJ/Hw2MEV+JbN3Ato"
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--=-zK4aJ/Hw2MEV+JbN3Ato
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

jgart via Guix-patches via schreef op vr 10-06-2022 om 23:27 [-0500]:
> +=C2=A0=C2=A0=C2=A0 (arguments
> +=C2=A0=C2=A0=C2=A0=C2=A0 `(#:phases
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (modify-phases %standard-phases
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (replace 'check
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (lambda _
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
 (chdir "bare")
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
 (invoke "pytest" "."))))))

"./pre-inst-env guix lint python-pybare" will have a warning about
this.  Also, apparently 'list' is considered more readable than
quasiquote/unquote, see [1], so maybe eliminate the quasiquote in
favour of 'list'?

> BARE

Looks like a not well-known acronym, maybe use @acronym?

[1] https://logs.guix.gnu.org/guix/2022-06-09.log#194339

Otherwise the package definition LGTM, but I haven't built or tested it
or read the source code.

Greetings,
Maxime.

--=-zK4aJ/Hw2MEV+JbN3Ato
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYqRQkBccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7qCgAP9Q1yU1khgacVHShcqnMkyEpRZe
DCB78jXtC+fDz4BtiAEAvBkNC+ZvQWuq2j9pokBQFanJ7fhXWJo7+7QKbhIPYwQ=
=TnDM
-----END PGP SIGNATURE-----

--=-zK4aJ/Hw2MEV+JbN3Ato--

Message sent to guix-patches@HIDDEN:

Subject: [bug#55896] [PATCH v2] gnu: Add python-pybare.
References: <20220611042737.15082-1-jgart@HIDDEN>
In-Reply-To: <20220611042737.15082-1-jgart@HIDDEN>
Resent-From: jgart <jgart@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 11 Jun 2022 20:37:01 +0000
Resent-Message-ID: <handler.55896.B55896.165497979426832 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 55896 <at> debbugs.gnu.org
Cc: Maxime Devos <maximedevos@HIDDEN>, jgart <jgart@HIDDEN>
From: jgart <jgart@HIDDEN>
Date: Sat, 11 Jun 2022 15:27:01 -0500
Message-Id: <20220611202700.5655-1-jgart@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

* gnu/packages/python-xyz.scm (python-pybare): New variable.

Hi Maxime,

Thanks for the review. It is much appreciated.

Here is version 2 with your requested changes.

all best,

jgart
---
 gnu/packages/python-xyz.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 4104472848..5109434cbf 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -29418,6 +29418,39 @@ (define-public python-gatt
 Currently, Linux is the only platform supported by this library.")
     (license license:expat)))

+(define-public python-pybare
+  (package
+    (name "python-pybare")
+    (version "0.1.1")
+    (source
+      (origin
+        (method git-fetch)
+        (uri
+         (git-reference
+          (url "https://git.sr.ht/~chiefnoah/pybare")
+          (commit (string-append "v" version))))
+        (file-name (git-file-name name version))
+        (sha256
+         (base32 "1ibmwwf1rdxlwyxlzhv3v1i0ybsqg0kppim90sm8rsbns86yy4by"))))
+    (build-system python-build-system)
+    (arguments
+      (list #:phases
+            #~(modify-phases %standard-phases
+                (replace 'check
+                  (lambda* (#:key tests? #:allow-other-keys)
+                    (when tests?
+                      (chdir "bare")
+                      (invoke "pytest" "-vv" ".")))))))
+    (native-inputs
+      (list python-pytest))
+    (home-page "https://sr.ht/~chiefnoah/PyBARE/")
+    (synopsis "Declarative implementation of BARE for Python")
+    (description
+"@code{python-pybare} is a general purpose library for strongly typed
+primitives in Python that supports serializing to and from @acronym{BARE,
+Binary Application Record Encoding} messages.")
+    (license license:expat)))
+
 (define-public python-musical-scales
   (package
     (name "python-musical-scales")
-- 
2.36.1

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#55896] [PATCH v2] gnu: Add python-pybare.
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 12 Jun 2022 15:43:01 +0000
Resent-Message-ID: <handler.55896.B55896.165504852814601 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 55896
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: jgart <jgart@HIDDEN>, 55896 <at> debbugs.gnu.org
Received: via spool by 55896-submit <at> debbugs.gnu.org id=B55896.165504852814601
          (code B ref 55896); Sun, 12 Jun 2022 15:43:01 +0000
Received: (at 55896) by debbugs.gnu.org; 12 Jun 2022 15:42:08 +0000
Received: from localhost ([127.0.0.1]:56365 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1o0Pj5-0003nR-ND
	for submit <at> debbugs.gnu.org; Sun, 12 Jun 2022 11:42:07 -0400
Received: from michel.telenet-ops.be ([195.130.137.88]:44230)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maximedevos@HIDDEN>) id 1o0Pj2-0003nG-Tc
 for 55896 <at> debbugs.gnu.org; Sun, 12 Jun 2022 11:42:07 -0400
Received: from [172.20.10.5] ([188.188.255.8])
 by michel.telenet-ops.be with bizsmtp
 id iFi22700F0BeyFQ06Fi3AE; Sun, 12 Jun 2022 17:42:03 +0200
Message-ID: <fa829031dd0a11841914052a5277b3852e99db82.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Sun, 12 Jun 2022 17:41:57 +0200
In-Reply-To: <20220611202700.5655-1-jgart@HIDDEN>
References: <20220611202700.5655-1-jgart@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
 protocol="application/pgp-signature"; boundary="=-KTuBE4fayLPodAI6yOqY"
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
 t=1655048523; bh=GRfh4FYo48fTqPjoLYSKPJ5ioCeZVw8H6mq/HV0uFO0=;
 h=Subject:From:To:Date:In-Reply-To:References;
 b=IhBlIwgxvLMgnrM6f4isdHCx8BJ1mGt/mDgXrA4sAeEncJ2KHuD5dHGdJcZ+dgeVN
 JquGhA27nSGc/AnvwKWvqqEu1cJxaWP+hbv9NzS/ZccCXflCelIzi/qncqpb5kubdk
 Oy4r7fQwJIpwJSlDthuDvcoeJ1jv/RbMmuLW/9kF3PfI+lC08AydaTo3mFIrH2TK8m
 1rqbbuisCRJQcxrB7s/QDIiEp9IZIg0rL0DSxaa/xl3Ej2/AEEtrjAwIeidscGkCgB
 MaFdhksu2z+vDb8L7QR6PRxkpBtcZl6gZCgrSR67RidFLhjyzurjDA7SneB1DXNLiq
 aZlApexTgiKUw==
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--=-KTuBE4fayLPodAI6yOqY
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: base64

amdhcnQgc2NocmVlZiBvcCB6YSAxMS0wNi0yMDIyIG9tIDE1OjI3IFstMDUwMF06Cj4gKyhkZWZp
bmUtcHVibGljIHB5dGhvbi1weWJhcmUKPiArwqAgKHBhY2thZ2UKPiArwqDCoMKgIChuYW1lICJw
eXRob24tcHliYXJlIikKPiArwqDCoMKgICh2ZXJzaW9uICIwLjEuMSIpCj4gK8KgwqDCoCAoc291
cmNlCj4gK8KgwqDCoMKgwqAgKG9yaWdpbgo+ICvCoMKgwqDCoMKgwqDCoCAobWV0aG9kIGdpdC1m
ZXRjaCkKPiArwqDCoMKgwqDCoMKgwqAgKHVyaQo+ICvCoMKgwqDCoMKgwqDCoMKgIChnaXQtcmVm
ZXJlbmNlCj4gK8KgwqDCoMKgwqDCoMKgwqDCoCAodXJsICJodHRwczovL2dpdC5zci5odC9+Y2hp
ZWZub2FoL3B5YmFyZSIpCj4gK8KgwqDCoMKgwqDCoMKgwqDCoCAoY29tbWl0IChzdHJpbmctYXBw
ZW5kICJ2IiB2ZXJzaW9uKSkpKQo+ICvCoMKgwqDCoMKgwqDCoCAoZmlsZS1uYW1lIChnaXQtZmls
ZS1uYW1lIG5hbWUgdmVyc2lvbikpCj4gK8KgwqDCoMKgwqDCoMKgIChzaGEyNTYKPiArwqDCoMKg
wqDCoMKgwqDCoCAoYmFzZTMyICIxaWJtd3dmMXJkeGx3eXhsemh2M3YxaTB5YnNxZzBrcHBpbTkw
c204cnNibnM4Nnl5NGJ5IikpKSkKPiArwqDCoMKgIChidWlsZC1zeXN0ZW0gcHl0aG9uLWJ1aWxk
LXN5c3RlbSkKPiArwqDCoMKgIChhcmd1bWVudHMKPiArwqDCoMKgwqDCoCAobGlzdCAjOnBoYXNl
cwo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICN+KG1vZGlmeS1waGFzZXMgJXN0YW5kYXJkLXBo
YXNlcwo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKHJlcGxhY2UgJ2NoZWNrCj4g
K8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKGxhbWJkYSogKCM6a2V5IHRlc3Rz
PyAjOmFsbG93LW90aGVyLWtleXMpCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgICh3aGVuIHRlc3RzPwo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqAgKGNoZGlyICJiYXJlIikKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgIChpbnZva2UgInB5dGVzdCIgIi12diIgIi4iKSkpKSkpKQo+ICvCoMKgwqAg
KG5hdGl2ZS1pbnB1dHMKPiArwqDCoMKgwqDCoCAobGlzdCBweXRob24tcHl0ZXN0KSkKPiArwqDC
oMKgIChob21lLXBhZ2UgImh0dHBzOi8vc3IuaHQvfmNoaWVmbm9haC9QeUJBUkUvIikKPiArwqDC
oMKgIChzeW5vcHNpcyAiRGVjbGFyYXRpdmUgaW1wbGVtZW50YXRpb24gb2YgQkFSRSBmb3IgUHl0
aG9uIikKPiArwqDCoMKgIChkZXNjcmlwdGlvbgo+ICsiQGNvZGV7cHl0aG9uLXB5YmFyZX0gaXMg
YSBnZW5lcmFsIHB1cnBvc2UgbGlicmFyeSBmb3Igc3Ryb25nbHkgdHlwZWQKPiArcHJpbWl0aXZl
cyBpbiBQeXRob24gdGhhdCBzdXBwb3J0cyBzZXJpYWxpemluZyB0byBhbmQgZnJvbSBAYWNyb255
bXtCQVJFLAo+ICtCaW5hcnkgQXBwbGljYXRpb24gUmVjb3JkIEVuY29kaW5nfSBtZXNzYWdlcy4i
KQo+ICvCoMKgwqAgKGxpY2Vuc2UgbGljZW5zZTpleHBhdAoKClBhY2thZ2UgZGVmaW5pdGlvbiBM
R1RNLCBidXQgSSBoYXZlIG9ubHkgbG9va2VkIGF0IHRoZSBkZWZpbml0aW9uLCBub3QKdGhlIHNv
dXJjZXMgZXRjLgo=


--=-KTuBE4fayLPodAI6yOqY
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYqYJRRccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7hezAQC/XkoJAQOnNwntQeQW7BPAW0uh
m+pBIO5wvQlbGj2oFQEAgBOkupg9vagjuCGaLg8ObX/IT74Xp1xeUAtyGFCYwAY=
=Dqgi
-----END PGP SIGNATURE-----

--=-KTuBE4fayLPodAI6yOqY--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#55896] [PATCH v2] gnu: Add python-pybare.
Resent-From: jgart <jgart@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 12 Jun 2022 20:55:02 +0000
Resent-Message-ID: <handler.55896.B55896.165506727120678 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 55896
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Maxime Devos <maximedevos@HIDDEN>
Cc: 55896 <at> debbugs.gnu.org
Received: via spool by 55896-submit <at> debbugs.gnu.org id=B55896.165506727120678
          (code B ref 55896); Sun, 12 Jun 2022 20:55:02 +0000
Received: (at 55896) by debbugs.gnu.org; 12 Jun 2022 20:54:31 +0000
Received: from localhost ([127.0.0.1]:56569 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1o0UbP-0005NR-DP
	for submit <at> debbugs.gnu.org; Sun, 12 Jun 2022 16:54:31 -0400
Received: from mx1.dismail.de ([78.46.223.134]:17822)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jgart@HIDDEN>) id 1o0UbK-0005N9-Eq
 for 55896 <at> debbugs.gnu.org; Sun, 12 Jun 2022 16:54:30 -0400
Received: from mx1.dismail.de (localhost [127.0.0.1])
 by mx1.dismail.de (OpenSMTPD) with ESMTP id ff10eaf6;
 Sun, 12 Jun 2022 22:54:19 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h=date
 :message-id:from:to:cc:subject:in-reply-to:references
 :mime-version:content-type:content-transfer-encoding; s=
 20190914; bh=fkbydiEBP45xbnJG1RiCAGlgyP3LP51VGYiZx3YaLQA=; b=Bk9
 QBrw99M15esQfm7X7/QuImG/1XduO5Fj2RbMiUhTN4WvuvofhLHBXNSWcr9l25aN
 zqWZCDED61TFeefNbjg8zuNAyfKxoWvtgpfcShHcmY/NIxgveKpl2GVcMCbrKYos
 cdgffgGo2CJtmoKNHvzUluhK/mFORInC+aT0ZZ/o4Ve/AJd0d0gR5tB2v+11Li3B
 41Yz6L+RMueHVy2nrrfOA+orFQ0cgXdJfl7probqMOfUte10het9GIDVtxB6Emgs
 ggP+ECE8DEqKCs2s7VVE6YG11/oAmy/WeutfZPhPvOafv6uG2809u5eHzFW4cKSa
 k0uhdodDwhVSF+U6z6Q==
Received: from smtp1.dismail.de (<unknown> [10.240.26.11])
 by mx1.dismail.de (OpenSMTPD) with ESMTP id eaa1c5bb;
 Sun, 12 Jun 2022 22:54:18 +0200 (CEST)
Received: from smtp1.dismail.de (localhost [127.0.0.1])
 by smtp1.dismail.de (OpenSMTPD) with ESMTP id 576a657d;
 Sun, 12 Jun 2022 22:54:18 +0200 (CEST)
Received: by dismail.de (OpenSMTPD) with ESMTPSA id 26ad4fc4
 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); 
 Sun, 12 Jun 2022 22:54:17 +0200 (CEST)
Date: Sun, 12 Jun 2022 15:54:18 -0500
Message-ID: <20220612155418.GC1648@gac>
From: jgart <jgart@HIDDEN>
In-Reply-To: <fa829031dd0a11841914052a5277b3852e99db82.camel@HIDDEN>
References: <20220611202700.5655-1-jgart@HIDDEN>
 <fa829031dd0a11841914052a5277b3852e99db82.camel@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

On Sun, 12 Jun 2022 17:41:57 +0200 Maxime Devos <maximedevos@HIDDEN> wrote:
> jgart schreef op za 11-06-2022 om 15:27 [-0500]:
> > +(define-public python-pybare
> > +  (package
> > +    (name "python-pybare")
> > +    (version "0.1.1")
> > +    (source
> > +      (origin
> > +        (method git-fetch)
> > +        (uri
> > +         (git-reference
> > +          (url "https://git.sr.ht/~chiefnoah/pybare")
> > +          (commit (string-append "v" version))))
> > +        (file-name (git-file-name name version))
> > +        (sha256
> > +         (base32 "1ibmwwf1rdxlwyxlzhv3v1i0ybsqg0kppim90sm8rsbns86yy4by"))))
> > +    (build-system python-build-system)
> > +    (arguments
> > +      (list #:phases
> > +            #~(modify-phases %standard-phases
> > +                (replace 'check
> > +                  (lambda* (#:key tests? #:allow-other-keys)
> > +                    (when tests?
> > +                      (chdir "bare")
> > +                      (invoke "pytest" "-vv" ".")))))))
> > +    (native-inputs
> > +      (list python-pytest))
> > +    (home-page "https://sr.ht/~chiefnoah/PyBARE/")
> > +    (synopsis "Declarative implementation of BARE for Python")
> > +    (description
> > +"@code{python-pybare} is a general purpose library for strongly typed
> > +primitives in Python that supports serializing to and from @acronym{BARE,
> > +Binary Application Record Encoding} messages.")
> > +    (license license:expat
> 
> 
> Package definition LGTM, but I have only looked at the definition, not
> the sources etc.

Hi Maxime, no worries. Take your time. The review is much appreciated.

I just looked at the sources again myself and noticed that the tests
use pre-generated BARE binaries to test against.

See here:

https://git.sr.ht/~chiefnoah/pybare/tree/master/item/bare/test_encoder.py#L225

and here:

https://git.sr.ht/~chiefnoah/pybare/tree/master/item/bare/_examples

Should I ask the author if they can provide a way to generate those
binaries for testing instead of vendoring the pre-compiled binaries
without their sources?

all best,

jgart

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#55896] [PATCH] gnu: Add python-pybare.
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 07 Jul 2022 20:34:02 +0000
Resent-Message-ID: <handler.55896.B55896.16572260117951 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 55896
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: jgart <jgart@HIDDEN>
Cc: 55896 <at> debbugs.gnu.org, Maxime Devos <maximedevos@HIDDEN>
Received: via spool by 55896-submit <at> debbugs.gnu.org id=B55896.16572260117951
          (code B ref 55896); Thu, 07 Jul 2022 20:34:02 +0000
Received: (at 55896) by debbugs.gnu.org; 7 Jul 2022 20:33:31 +0000
Received: from localhost ([127.0.0.1]:58101 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1o9YBn-000248-FD
	for submit <at> debbugs.gnu.org; Thu, 07 Jul 2022 16:33:31 -0400
Received: from mail-qt1-f179.google.com ([209.85.160.179]:42577)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1o9YBj-00023o-F5
 for 55896 <at> debbugs.gnu.org; Thu, 07 Jul 2022 16:33:29 -0400
Received: by mail-qt1-f179.google.com with SMTP id g14so24510371qto.9
 for <55896 <at> debbugs.gnu.org>; Thu, 07 Jul 2022 13:33:27 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=from:to:cc:subject:references:date:in-reply-to:message-id
 :user-agent:mime-version;
 bh=2E9tMyi1amJ6JGKMgPOnQ4B1sakk4RhQkuA1mKB7ImY=;
 b=nA2oLpE8B0VcHbHee7sEa/xZtgBNGDiEpAZtkdhw2kukKgPf3H6+lAYAV7ZKFYKY7o
 asBiSnM6Nqi1oIFTBijwG4gcSl4vN1G6/yHOLoPQRRwoZcqzfVOAyXwQFhJ4gGrX3oxU
 gcyNXj2SqffoeobiFStLNd5hZA7TZJwvUZgOn+IQvRakQG1xt67Saa6xegP5/SPEH4Xe
 6JRG+WLgtSz8CRJ6vSVTC4MyUiqnuxiTdb3oGrIyyi1ubQKu8prSgi8ZzJ2M5N+/ft/V
 Ssz1/pwxKUnFmCghtW9ZGJJsIKh0FsbbrlEM+fMcM/64Sf6LTzSjbil3uZNJq8agbJDa
 TGZg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
 :message-id:user-agent:mime-version;
 bh=2E9tMyi1amJ6JGKMgPOnQ4B1sakk4RhQkuA1mKB7ImY=;
 b=RMEFT7NQQ/z0owxqavYB5aqQiC+fyTwM/vhrQ+0HdPRv9VEn77XnvkdHNyDI83+Zj5
 YgB9A9kMp33a4odrx+QaA4nShKfWhN540UohQYeTShzH0gMYxq8QHULiawOqeuzgvmsW
 BCprVdWHMcftU479m2Ypjz3wys020EYB9V4ZVytmCjl+G5IGvl3P7groSF0v08yOrUXU
 AVoyTM2B9JsFXNi8oUyAPxLRt9Mgf2lPXmssInywr2xAtIt+QMDxRlSv9z0qlpk1VVkr
 +NH5M+33LY37bs9ZUlLTOhBIuYzMeSUJE534mnN5ofCSp+7FRh8p6zy8eetbDOehfESf
 lxnQ==
X-Gm-Message-State: AJIora8SfqrhVIxdHX4mI76xeK9h/mwqvrAIeMADGN08mniMmv6CxAvB
 Nzvg9p2Q492j5+JWBs2LY9cMTPycSGRkn0kq
X-Google-Smtp-Source: AGRyM1vpTFrRNtos3vCJDugEmXCdaWCZoozXy4OtODkAqqRkx6rpPppZl34kF628Y76M390QrwuXXQ==
X-Received: by 2002:a05:6214:29e9:b0:473:63b:5c61 with SMTP id
 jv9-20020a05621429e900b00473063b5c61mr12717082qvb.99.1657226001791; 
 Thu, 07 Jul 2022 13:33:21 -0700 (PDT)
Received: from hurd (dsl-153-127.b2b2c.ca. [66.158.153.127])
 by smtp.gmail.com with ESMTPSA id
 dm15-20020a05620a1d4f00b006b555509398sm1668465qkb.136.2022.07.07.13.33.21
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 07 Jul 2022 13:33:21 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
References: <20220611202700.5655-1-jgart@HIDDEN>
 <fa829031dd0a11841914052a5277b3852e99db82.camel@HIDDEN>
 <20220612155418.GC1648@gac>
Date: Thu, 07 Jul 2022 16:33:20 -0400
In-Reply-To: <20220612155418.GC1648@gac> (jgart@HIDDEN's message of "Sun, 
 12 Jun 2022 15:54:18 -0500")
Message-ID: <87h73swtm7.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hello,

jgart <jgart@HIDDEN> writes:

[...]

> Hi Maxime, no worries. Take your time. The review is much appreciated.
>
> I just looked at the sources again myself and noticed that the tests
> use pre-generated BARE binaries to test against.
>
> See here:
>
> https://git.sr.ht/~chiefnoah/pybare/tree/master/item/bare/test_encoder.py#L225
>
> and here:
>
> https://git.sr.ht/~chiefnoah/pybare/tree/master/item/bare/_examples
>
> Should I ask the author if they can provide a way to generate those
> binaries for testing instead of vendoring the pre-compiled binaries
> without their sources?

Yes, please ask.  Otherwise, we'll have to delete the binaries from
unknown source in a source snippet and not run the test suite...

Thank you!

Maxim

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 7 Jul 2022 20:33:34 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jul 07 16:33:34 2022
Received: from localhost ([127.0.0.1]:58104 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1o9YBp-00024O-Rt
	for submit <at> debbugs.gnu.org; Thu, 07 Jul 2022 16:33:33 -0400
Received: from mail-qt1-f181.google.com ([209.85.160.181]:40626)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1o9YBo-00023z-Ty
 for control <at> debbugs.gnu.org; Thu, 07 Jul 2022 16:33:33 -0400
Received: by mail-qt1-f181.google.com with SMTP id ck6so24492125qtb.7
 for <control <at> debbugs.gnu.org>; Thu, 07 Jul 2022 13:33:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=date:message-id:to:from:subject;
 bh=PCYKvoxeU/Qs7Xo9cHnvu4PpqqFzjbUVCBHhKuECC/4=;
 b=BTBTx8coCZIQPOYf03KYwc6SAvc/6BHbj78aeybXnysGcrqGgteYfulwm3ChqjT1Ns
 mUosiUD0+c3EGgN0jd23lq4erZ3JLSAv6zpcPJU1I0A48Xb76koRMh722uJi5+y+V4gi
 WG4XWml0UlpQ63Yan5qdDL7nowWiqSbn3Xz5AF3OC7baVb8AVu8YWBnXaYUSddSilb9R
 6M8nqZKGNhznPOx8y6d38gmRIv61aC7g4gzyGaeCAvKneyuUgN4dnQR3j44zlU22gr4F
 31q6O4QZLY4aOT1y+nst7gM+yRdHRQi0t+SJVgEFEDZ/ySssd5wM4jncWYH9Wj+0oBaH
 Fg1A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:date:message-id:to:from:subject;
 bh=PCYKvoxeU/Qs7Xo9cHnvu4PpqqFzjbUVCBHhKuECC/4=;
 b=Fswj9ezGFzYOFqEKeGXjrDowaqId4DhCA/74REoPHHiOR6Uc+2u55JPgkhcFVQF3Kr
 NMyyyGsGec4o81Yp9mX8VNeP4dona9STGay78588RztqVJQwlGkP+ZQXIrrPGaXH/yaF
 tqCyk4mJTP1dQQObQZepUF9NogHoCjOingnB5E+x+L/+pArntD892Vl3YEpYDniw4e5u
 xXM+FobCNeTOfGS8AUm9m5nh+fKh+YDYtW/5RUTAaSHNchXnOw6fTMwtehyiBEHcRFy0
 onmBVU34t3IPxK3rZl8HY1nqIybMaZgd6n6mP7Wo+c96R7xr3IkmOXtTbyiv5r7942t1
 9S0w==
X-Gm-Message-State: AJIora+47DLkAOLeOdAqUSEe9YdartH8MpTRZIV7c6lju8ktT80XhoKd
 nscO3GV8XVTyGZuD7p1wTct8D/FN/L1V7fsk
X-Google-Smtp-Source: AGRyM1vXK60D1duaysAbkIMZbK+h+ZXgkrUcXpmNi1jPL1o9J5o4UxAgiBvzWJbdxxG9amUlG8cWGQ==
X-Received: by 2002:a05:622a:9:b0:31d:4281:417 with SMTP id
 x9-20020a05622a000900b0031d42810417mr4021qtw.362.1657226007238; 
 Thu, 07 Jul 2022 13:33:27 -0700 (PDT)
Received: from hurd (dsl-153-127.b2b2c.ca. [66.158.153.127])
 by smtp.gmail.com with ESMTPSA id
 t19-20020a05622a01d300b00304f3e320f2sm29736544qtw.4.2022.07.07.13.33.26
 for <control <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 07 Jul 2022 13:33:26 -0700 (PDT)
Date: Thu, 07 Jul 2022 16:33:26 -0400
Message-Id: <87fsjcwtm1.fsf@HIDDEN>
To: control <at> debbugs.gnu.org
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Subject: control message for bug #55896
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

tags 55896 + moreinfo
quit

Last modified: Thu, 7 Jul 2022 20:45:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.