GNU bug report logs - #56996
gpt_partition_set_system possible regression

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 5 Aug 2022 07:14:38 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Aug 05 03:14:38 2022
Received: from localhost ([127.0.0.1]:55976 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oJrXa-0001qV-7y
	for submit <at> debbugs.gnu.org; Fri, 05 Aug 2022 03:14:38 -0400
Received: from lists.gnu.org ([209.51.188.17]:44838)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <othacehe@HIDDEN>) id 1oJrXW-0001qK-68
 for submit <at> debbugs.gnu.org; Fri, 05 Aug 2022 03:14:36 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:54984)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <othacehe@HIDDEN>) id 1oJrXS-0004Fb-FG
 for bug-parted@HIDDEN; Fri, 05 Aug 2022 03:14:32 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:32796)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <othacehe@HIDDEN>) id 1oJrXS-00035v-2M
 for bug-parted@HIDDEN; Fri, 05 Aug 2022 03:14:30 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to:
 references; bh=Tv8ZQn0wcury1k0GEz58t20fxDHUmyUAR9qFqaW/NrQ=; b=HrtjN9gcDeq74t
 IERBZQgn4vvh0yz5h1pvGmNu5G6hg7VlaMnt3ri11Tle9zfscr8BqkYCZpTug4oLPn/Wh4oqMA+FG
 a8chBT+Gu35IUSfUgTvVbDh9bc2J82YcpsEbP7py2vfUUl813k4Evkf/IUAe54k35jqvZKRkgCg/M
 ipRuh8zMuuufZKB4vYq5WP2eDDoI983j3KtjkjBvwA9GieNUYo2tS5xu6RGkYSu0D56D0w5unPw4s
 ZHL4i/Fr4WrnJkwzpik7GF3BWbGw2Ld1XVRBqZ/Gy5q5iN6FgDUvZTosw57AFyJ5wNfYDe1dlkRXr
 ydZb9rzbxntDXR74y3JA==;
Received: from 2a02-8429-81d2-3d01-94c9-8097-ea5c-2775.rev.sfr.net
 ([2a02:8429:81d2:3d01:94c9:8097:ea5c:2775]:50560 helo=meije)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <othacehe@HIDDEN>) id 1oJrXR-0000oe-3h
 for bug-parted@HIDDEN; Fri, 05 Aug 2022 03:14:29 -0400
From: Mathieu Othacehe <othacehe@HIDDEN>
To: bug-parted@HIDDEN
Subject: gpt_partition_set_system possible regression
Date: Fri, 05 Aug 2022 09:14:26 +0200
Message-ID: <87wnbnyxf1.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)


Hello,

In GNU Guix we are using GNU Parted via Guile-Parted bindings. Upgrading
from Parted 3.4 to Parted 3.5 we discovered a possible regression.

We are creation a new partition on a gpt disk this way:

ped_partition_new (ext4)
ped_partition_set_flag (PED_PARTITION_BIOS_GRUB)
ped_partition_set_system (ext4)

Since 15c49ec04f7eaff014d2e1eddd0aecf4150db63d, ped_partition_set_system
forces the gpt_part_data->type to PARTITION_LINUX_DATA_GUID, whereas it
used to conserve the gpt_part_data->type to PARTITION_BIOS_GRUB_GUID.

This forces us to reverse the ped_partition_set_system and
ped_partition_set_flag call order. Is that expected?

Thanks,

Mathieu